date:20220228

[Libreoffice-bugs] [Bug 147664] Sukapura: Some icons with text (like B, I, U, etc) are too big that make them unbalance with the rest of the icons

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147664

Rizal Muttaqin  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |riz...@libreoffice.org
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147664] Sukapura: Some icons with text (like B, I, U, etc) are too big that make them unbalance with the rest of the icons

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147664

--- Comment #4 from Commit Notification 
 ---
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fcfa854db5b81454047e1dde36de781e395dd498

Sukapura: tdf#147664 Revise Increase Font & Decrease Font, Default Style,

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: icon-themes/sukapura icon-themes/sukapura_svg

2022-02-28 Thread Rizal Muttaqin (via logerrit)

 icon-themes/sukapura/cmd/32/grow.png  |binary
 icon-themes/sukapura/cmd/32/shrink.png|binary
 icon-themes/sukapura/cmd/32/smallcaps.png |binary
 icon-themes/sukapura/cmd/lc_defaultcharstyle.png  |binary
 icon-themes/sukapura/cmd/lc_grow.png  |binary
 icon-themes/sukapura/cmd/lc_shrink.png|binary
 icon-themes/sukapura/cmd/lc_smallcaps.png |binary
 icon-themes/sukapura/cmd/lc_textbodyparastyle.png |binary
 icon-themes/sukapura/cmd/sc_grow.png  |binary
 icon-themes/sukapura/cmd/sc_shrink.png|binary
 icon-themes/sukapura/cmd/sc_smallcaps.png |binary
 icon-themes/sukapura_svg/cmd/32/grow.svg  |2 +-
 icon-themes/sukapura_svg/cmd/32/ko/grow.svg   |1 -
 icon-themes/sukapura_svg/cmd/32/ko/shrink.svg |1 -
 icon-themes/sukapura_svg/cmd/32/shrink.svg|2 +-
 icon-themes/sukapura_svg/cmd/32/smallcaps.svg |2 +-
 icon-themes/sukapura_svg/cmd/ko/lc_grow.svg   |1 -
 icon-themes/sukapura_svg/cmd/ko/lc_shrink.svg |1 -
 icon-themes/sukapura_svg/cmd/ko/sc_grow.svg   |1 -
 icon-themes/sukapura_svg/cmd/ko/sc_shrink.svg |1 -
 icon-themes/sukapura_svg/cmd/lc_defaultcharstyle.svg  |2 +-
 icon-themes/sukapura_svg/cmd/lc_grow.svg  |2 +-
 icon-themes/sukapura_svg/cmd/lc_shrink.svg|2 +-
 icon-themes/sukapura_svg/cmd/lc_smallcaps.svg |2 +-
 icon-themes/sukapura_svg/cmd/lc_textbodyparastyle.svg |2 +-
 icon-themes/sukapura_svg/cmd/sc_grow.svg  |2 +-
 icon-themes/sukapura_svg/cmd/sc_shrink.svg|2 +-
 icon-themes/sukapura_svg/cmd/sc_smallcaps.svg |2 +-
 28 files changed, 11 insertions(+), 17 deletions(-)

New commits:
commit fcfa854db5b81454047e1dde36de781e395dd498
Author: Rizal Muttaqin 
AuthorDate: Tue Mar 1 06:25:32 2022 +0700
Commit: Rizal Muttaqin 
CommitDate: Tue Mar 1 08:39:06 2022 +0100

Sukapura: tdf#147664 Revise Increase Font & Decrease Font, Default Style,

Small Caps icons

Change-Id: I1348cc7fbde63d335ba3676a4c424d76f8cf2349
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130733
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin 

diff --git a/icon-themes/sukapura/cmd/32/grow.png 
b/icon-themes/sukapura/cmd/32/grow.png
index a8f5d739eac1..f6d50b1d6b5c 100644
Binary files a/icon-themes/sukapura/cmd/32/grow.png and 
b/icon-themes/sukapura/cmd/32/grow.png differ
diff --git a/icon-themes/sukapura/cmd/32/shrink.png 
b/icon-themes/sukapura/cmd/32/shrink.png
index f14197a4b0c5..f6932cb02d26 100644
Binary files a/icon-themes/sukapura/cmd/32/shrink.png and 
b/icon-themes/sukapura/cmd/32/shrink.png differ
diff --git a/icon-themes/sukapura/cmd/32/smallcaps.png 
b/icon-themes/sukapura/cmd/32/smallcaps.png
index 6f868fbfa7a8..3b4df09aa7b4 100644
Binary files a/icon-themes/sukapura/cmd/32/smallcaps.png and 
b/icon-themes/sukapura/cmd/32/smallcaps.png differ
diff --git a/icon-themes/sukapura/cmd/lc_defaultcharstyle.png 
b/icon-themes/sukapura/cmd/lc_defaultcharstyle.png
index af57cae79a92..8dcca8c2178e 100644
Binary files a/icon-themes/sukapura/cmd/lc_defaultcharstyle.png and 
b/icon-themes/sukapura/cmd/lc_defaultcharstyle.png differ
diff --git a/icon-themes/sukapura/cmd/lc_grow.png 
b/icon-themes/sukapura/cmd/lc_grow.png
index 96716988b8c7..f26850dcd2cd 100644
Binary files a/icon-themes/sukapura/cmd/lc_grow.png and 
b/icon-themes/sukapura/cmd/lc_grow.png differ
diff --git a/icon-themes/sukapura/cmd/lc_shrink.png 
b/icon-themes/sukapura/cmd/lc_shrink.png
index 6d5b8ea7ce3d..1457cda3f521 100644
Binary files a/icon-themes/sukapura/cmd/lc_shrink.png and 
b/icon-themes/sukapura/cmd/lc_shrink.png differ
diff --git a/icon-themes/sukapura/cmd/lc_smallcaps.png 
b/icon-themes/sukapura/cmd/lc_smallcaps.png
index 77828a7749fa..125eddd50a01 100644
Binary files a/icon-themes/sukapura/cmd/lc_smallcaps.png and 
b/icon-themes/sukapura/cmd/lc_smallcaps.png differ
diff --git a/icon-themes/sukapura/cmd/lc_textbodyparastyle.png 
b/icon-themes/sukapura/cmd/lc_textbodyparastyle.png
index fba6822e3682..90daf2c49191 100644
Binary files a/icon-themes/sukapura/cmd/lc_textbodyparastyle.png and 
b/icon-themes/sukapura/cmd/lc_textbodyparastyle.png differ
diff --git a/icon-themes/sukapura/cmd/sc_grow.png 
b/icon-themes/sukapura/cmd/sc_grow.png
index c7c106dc52a6..9917192dbc44 100644
Binary files a/icon-themes/sukapura/cmd/sc_grow.png and 
b/icon-themes/sukapura/cmd/sc_grow.png differ
diff --git a/icon-themes/sukapura/cmd/sc_shrink.png 
b/icon-themes/sukapura/cmd/sc_shrink.png
index f1445ca9238b..4273b8880432 100644
Binary files a/icon-themes/sukapura/cmd/sc_shrink.png and 
b/icon-themes/sukapura/cmd/sc_shrink.png differ
diff --git a/icon-themes/sukapura/cmd/sc_smallcaps.png 
b/icon-themes/sukapura/cmd/sc_smallcaps.png
index 5ee5fa917921..1ef127831763 100644
Binary files

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - icon-themes/sukapura icon-themes/sukapura_svg

2022-02-28 Thread Rizal Muttaqin (via logerrit)

 icon-themes/sukapura/cmd/32/grow.png  |binary
 icon-themes/sukapura/cmd/32/shrink.png|binary
 icon-themes/sukapura/cmd/32/smallcaps.png |binary
 icon-themes/sukapura/cmd/lc_defaultcharstyle.png  |binary
 icon-themes/sukapura/cmd/lc_grow.png  |binary
 icon-themes/sukapura/cmd/lc_shrink.png|binary
 icon-themes/sukapura/cmd/lc_smallcaps.png |binary
 icon-themes/sukapura/cmd/lc_textbodyparastyle.png |binary
 icon-themes/sukapura/cmd/sc_grow.png  |binary
 icon-themes/sukapura/cmd/sc_shrink.png|binary
 icon-themes/sukapura/cmd/sc_smallcaps.png |binary
 icon-themes/sukapura_svg/cmd/32/grow.svg  |2 +-
 icon-themes/sukapura_svg/cmd/32/ko/grow.svg   |1 -
 icon-themes/sukapura_svg/cmd/32/ko/shrink.svg |1 -
 icon-themes/sukapura_svg/cmd/32/shrink.svg|2 +-
 icon-themes/sukapura_svg/cmd/32/smallcaps.svg |2 +-
 icon-themes/sukapura_svg/cmd/ko/lc_grow.svg   |1 -
 icon-themes/sukapura_svg/cmd/ko/lc_shrink.svg |1 -
 icon-themes/sukapura_svg/cmd/ko/sc_grow.svg   |1 -
 icon-themes/sukapura_svg/cmd/ko/sc_shrink.svg |1 -
 icon-themes/sukapura_svg/cmd/lc_defaultcharstyle.svg  |2 +-
 icon-themes/sukapura_svg/cmd/lc_grow.svg  |2 +-
 icon-themes/sukapura_svg/cmd/lc_shrink.svg|2 +-
 icon-themes/sukapura_svg/cmd/lc_smallcaps.svg |2 +-
 icon-themes/sukapura_svg/cmd/lc_textbodyparastyle.svg |2 +-
 icon-themes/sukapura_svg/cmd/sc_grow.svg  |2 +-
 icon-themes/sukapura_svg/cmd/sc_shrink.svg|2 +-
 icon-themes/sukapura_svg/cmd/sc_smallcaps.svg |2 +-
 28 files changed, 11 insertions(+), 17 deletions(-)

New commits:
commit 0c7edf73fcd3df053060e723282d6d788fc3848f
Author: Rizal Muttaqin 
AuthorDate: Tue Mar 1 06:25:32 2022 +0700
Commit: Rizal Muttaqin 
CommitDate: Tue Mar 1 08:38:38 2022 +0100

Sukapura: tdf#147664 Revise Increase Font & Decrease Font, Default Style,

Small Caps icons

Change-Id: I1348cc7fbde63d335ba3676a4c424d76f8cf2349
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130680
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin 

diff --git a/icon-themes/sukapura/cmd/32/grow.png 
b/icon-themes/sukapura/cmd/32/grow.png
index a8f5d739eac1..f6d50b1d6b5c 100644
Binary files a/icon-themes/sukapura/cmd/32/grow.png and 
b/icon-themes/sukapura/cmd/32/grow.png differ
diff --git a/icon-themes/sukapura/cmd/32/shrink.png 
b/icon-themes/sukapura/cmd/32/shrink.png
index f14197a4b0c5..f6932cb02d26 100644
Binary files a/icon-themes/sukapura/cmd/32/shrink.png and 
b/icon-themes/sukapura/cmd/32/shrink.png differ
diff --git a/icon-themes/sukapura/cmd/32/smallcaps.png 
b/icon-themes/sukapura/cmd/32/smallcaps.png
index 6f868fbfa7a8..3b4df09aa7b4 100644
Binary files a/icon-themes/sukapura/cmd/32/smallcaps.png and 
b/icon-themes/sukapura/cmd/32/smallcaps.png differ
diff --git a/icon-themes/sukapura/cmd/lc_defaultcharstyle.png 
b/icon-themes/sukapura/cmd/lc_defaultcharstyle.png
index af57cae79a92..8dcca8c2178e 100644
Binary files a/icon-themes/sukapura/cmd/lc_defaultcharstyle.png and 
b/icon-themes/sukapura/cmd/lc_defaultcharstyle.png differ
diff --git a/icon-themes/sukapura/cmd/lc_grow.png 
b/icon-themes/sukapura/cmd/lc_grow.png
index 96716988b8c7..f26850dcd2cd 100644
Binary files a/icon-themes/sukapura/cmd/lc_grow.png and 
b/icon-themes/sukapura/cmd/lc_grow.png differ
diff --git a/icon-themes/sukapura/cmd/lc_shrink.png 
b/icon-themes/sukapura/cmd/lc_shrink.png
index 6d5b8ea7ce3d..1457cda3f521 100644
Binary files a/icon-themes/sukapura/cmd/lc_shrink.png and 
b/icon-themes/sukapura/cmd/lc_shrink.png differ
diff --git a/icon-themes/sukapura/cmd/lc_smallcaps.png 
b/icon-themes/sukapura/cmd/lc_smallcaps.png
index 77828a7749fa..125eddd50a01 100644
Binary files a/icon-themes/sukapura/cmd/lc_smallcaps.png and 
b/icon-themes/sukapura/cmd/lc_smallcaps.png differ
diff --git a/icon-themes/sukapura/cmd/lc_textbodyparastyle.png 
b/icon-themes/sukapura/cmd/lc_textbodyparastyle.png
index fba6822e3682..90daf2c49191 100644
Binary files a/icon-themes/sukapura/cmd/lc_textbodyparastyle.png and 
b/icon-themes/sukapura/cmd/lc_textbodyparastyle.png differ
diff --git a/icon-themes/sukapura/cmd/sc_grow.png 
b/icon-themes/sukapura/cmd/sc_grow.png
index c7c106dc52a6..9917192dbc44 100644
Binary files a/icon-themes/sukapura/cmd/sc_grow.png and 
b/icon-themes/sukapura/cmd/sc_grow.png differ
diff --git a/icon-themes/sukapura/cmd/sc_shrink.png 
b/icon-themes/sukapura/cmd/sc_shrink.png
index f1445ca9238b..4273b8880432 100644
Binary files a/icon-themes/sukapura/cmd/sc_shrink.png and 
b/icon-themes/sukapura/cmd/sc_shrink.png differ
diff --git a/icon-themes/sukapura/cmd/sc_smallcaps.png 
b/icon-themes/sukapura/cmd/sc_smallcaps.png
index 5ee5fa917921..1ef127831763 100644
Binary files

[Libreoffice-bugs] [Bug 147664] Sukapura: Some icons with text (like B, I, U, etc) are too big that make them unbalance with the rest of the icons

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147664

--- Comment #3 from Commit Notification 
 ---
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/0c7edf73fcd3df053060e723282d6d788fc3848f

Sukapura: tdf#147664 Revise Increase Font & Decrease Font, Default Style,

It will be available in 7.3.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 146905] Allow cross-references to bookmarks to show the line number

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146905

Heiko Tietze  changed:

   What|Removed |Added

 CC||michael.me...@collabora.com

--- Comment #5 from Heiko Tietze  ---
IIRC religious texts such as bible or koran use line numbers for referencing
verses. Not sure if this is the line number but the paragraph. And
cross-referencing numbered paragraphs is possible. That's why I doubt going
further is a use case for more than a handful users.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 146905] Allow cross-references to bookmarks to show the line number

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146905

Heiko Tietze  changed:

   What|Removed |Added

 CC||michael.me...@collabora.com

--- Comment #5 from Heiko Tietze  ---
IIRC religious texts such as bible or koran use line numbers for referencing
verses. Not sure if this is the line number but the paragraph. And
cross-referencing numbered paragraphs is possible. That's why I doubt going
further is a use case for more than a handful users.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 85295] FILEOPEN: Import/preserve embedded fonts from pdf

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=85295

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #14 from Heiko Tietze  ---
AFAIU, we do not use the few glyphs stored in the PDF because it's not a
complete font and editing wont be possible. Makes sense to me. If the PDF
contains the whole font we should use it, on the other hand.

I suggest to show an infobar if a font was not shipped with the PDF. Something
like "Fonts in this document have been replaced. For full editing capabilities
please ask the original author to embed the whole font." 
(Me concerns the list of bugs in c0 regarding the issue.)

And we should provide options to export the font because it's our mission to
make documents readable cross-platform and cross-applications. According [1]
the open font spec knows: No embedding, Print and preview, Editable,
Installable. And MSO allows to save fonts respectively.

[1]
https://www.microsoft.com/en-us/microsoft-365/blog/2015/07/06/document-font-embedding-demystified/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 85295] FILEOPEN: Import/preserve embedded fonts from pdf

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=85295

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #14 from Heiko Tietze  ---
AFAIU, we do not use the few glyphs stored in the PDF because it's not a
complete font and editing wont be possible. Makes sense to me. If the PDF
contains the whole font we should use it, on the other hand.

I suggest to show an infobar if a font was not shipped with the PDF. Something
like "Fonts in this document have been replaced. For full editing capabilities
please ask the original author to embed the whole font." 
(Me concerns the list of bugs in c0 regarding the issue.)

And we should provide options to export the font because it's our mission to
make documents readable cross-platform and cross-applications. According [1]
the open font spec knows: No embedding, Print and preview, Editable,
Installable. And MSO allows to save fonts respectively.

[1]
https://www.microsoft.com/en-us/microsoft-365/blog/2015/07/06/document-font-embedding-demystified/

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-commits] core.git: sfx2/inc sfx2/IwyuFilter_sfx2.yaml sfx2/qa sfx2/source slideshow/IwyuFilter_slideshow.yaml slideshow/source slideshow/test sot/IwyuFilter_sot.yaml sot/source starmath/i

2022-02-28 Thread Gabor Kelemen (via logerrit)

 sfx2/IwyuFilter_sfx2.yaml |   10 +++--
 sfx2/inc/charmapcontrol.hxx   |1 
 sfx2/inc/commandpopup/CommandPopup.hxx|6 ---
 sfx2/inc/dinfdlg.hrc  |2 +
 sfx2/inc/doctempl.hrc |2 +
 sfx2/inc/emojicontrol.hxx |1 
 sfx2/inc/notebookbar/NotebookbarTabControl.hxx|3 +
 sfx2/inc/recentdocsview.hxx   |2 -
 sfx2/inc/sidebar/ControllerFactory.hxx|1 
 sfx2/inc/sidebar/SidebarToolBox.hxx   |2 -
 sfx2/inc/sidebar/TitleBar.hxx |3 -
 sfx2/inc/sidebar/Tools.hxx|4 --
 sfx2/inc/unoctitm.hxx |1 
 sfx2/qa/cppunit/test_misc.cxx |2 -
 sfx2/source/appl/app.cxx  |2 -
 sfx2/source/appl/appcfg.cxx   |2 -
 sfx2/source/appl/appchild.cxx |3 -
 sfx2/source/appl/appdata.cxx  |4 --
 sfx2/source/appl/appdde.cxx   |2 -
 sfx2/source/appl/appinit.cxx  |2 -
 sfx2/source/appl/appquit.cxx  |5 --
 sfx2/source/appl/appreg.cxx   |1 
 sfx2/source/appl/appserv.cxx  |2 -
 sfx2/source/appl/childwin.cxx |1 
 sfx2/source/appl/newhelp.cxx  |1 
 sfx2/source/appl/shutdownicon.cxx |1 
 sfx2/source/commandpopup/CommandPopup.cxx |   10 +
 sfx2/source/control/bindings.cxx  |1 
 sfx2/source/control/emojicontrol.cxx  |1 
 sfx2/source/control/emojiview.cxx |1 
 sfx2/source/control/emojiviewitem.cxx |1 
 sfx2/source/control/sfxstatuslistener.cxx |1 
 sfx2/source/control/statcach.cxx  |1 
 sfx2/source/control/thumbnailviewacc.hxx  |1 
 sfx2/source/control/thumbnailviewitem.cxx |4 +-
 sfx2/source/control/unoctitm.cxx  |   10 -
 sfx2/source/devtools/DocumentModelTreeHandler.cxx |1 
 sfx2/source/devtools/ObjectInspectorTreeHandler.cxx   |2 -
 sfx2/source/devtools/SelectionChangeHandler.hxx   |2 -
 sfx2/source/dialog/StyleList.cxx  |   12 +-
 sfx2/source/dialog/alienwarn.cxx  |1 
 sfx2/source/dialog/backingwindow.cxx  |1 
 sfx2/source/dialog/filedlghelper.cxx  |1 
 sfx2/source/dialog/navigat.cxx|3 -
 sfx2/source/dialog/templdlg.cxx   |   18 
--
 sfx2/source/doc/docfile.cxx   |2 -
 sfx2/source/doc/docinsert.cxx |1 
 sfx2/source/doc/doctemplates.cxx  |1 
 sfx2/source/doc/guisaveas.cxx |2 -
 sfx2/source/doc/objmisc.cxx   |2 -
 sfx2/source/doc/printhelper.cxx   |3 -
 sfx2/source/doc/templatedlg.cxx   |4 --
 sfx2/source/inc/StyleList.hxx |9 +
 sfx2/source/inc/helpids.h |2 +
 sfx2/source/inc/templdgi.hxx  |6 ---
 sfx2/source/inet/inettbc.cxx  |1 
 sfx2/source/notify/globalevents.cxx   |1 
 sfx2/source/sidebar/Deck.cxx  |5 --
 sfx2/source/sidebar/DeckLayouter.cxx  |1 
 sfx2/source/sidebar/DeckTitleBar.cxx  |4 +-
 sfx2/source/sidebar/Panel.cxx |2 -
 sfx2/source/sidebar/PanelLayout.cxx   |4 +-
 sfx2/source/sidebar/PanelTitleBar.cxx |3 -
 sfx2/source/sidebar/SidebarController.cxx |3 -
 sfx2/source/sidebar/SidebarDockingWindow.cxx  |4 --

[Libreoffice-commits] core.git: svx/README.md

2022-02-28 Thread Miklos Vajna (via logerrit)

 svx/README.md |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 5787a610df7f0e63054c51968c573b539452f67b
Author: Miklos Vajna 
AuthorDate: Mon Feb 28 20:32:04 2022 +0100
Commit: Miklos Vajna 
CommitDate: Tue Mar 1 08:19:01 2022 +0100

svx: fix URL and class name in README

It's a bit concerning that this URL was working in 2014, i.e. after
Apache OpenOffice was established and still got broken, but luckily the
archive has it.

Change-Id: If79ae0bc861ed855650156d87c7fc052773fb33a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130726
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/svx/README.md b/svx/README.md
index adf52ccacd1f..dc4345ad6f57 100644
--- a/svx/README.md
+++ b/svx/README.md
@@ -72,7 +72,7 @@ From `SdrView` on, it is not flat, but a real hierarchy again.
 See `drawinglayer/README.md` for general information about drawinglayer.
 
 Below is the class diagram that comes from
-,
+
 slide number 6.
 
 .--- Model --.  .--- View 
-.
@@ -101,5 +101,5 @@ If the number of visualizable objects (e.g. `SdrObjects`) 
is `X`, and the number
 
 - there are `X` `ViewContact` instances (1:1 relation with a visualizable 
object)
 - there are `Y` `ObjectContact` instances (1:1 relation with an `SdrView`)
-- there are `X*Y` `ViewObjecContact` instances (1:N relation to both
+- there are `X*Y` `ViewObjectContact` instances (1:N relation to both
   visualizable objects and `SdrView`s)

[Libreoffice-commits] core.git: cui/source

2022-02-28 Thread Noel Grandin (via logerrit)

 cui/source/customize/acccfg.cxx   |5 -
 cui/source/dialogs/zoom.cxx   |5 -
 cui/source/inc/align.hxx  |4 
 cui/source/inc/numpages.hxx   |   13 +-
 cui/source/options/optchart.cxx   |5 -
 cui/source/options/optgdlg.cxx|   23 ++--
 cui/source/options/treeopt.cxx|   19 +---
 cui/source/tabpages/align.cxx |   32 ++
 cui/source/tabpages/backgrnd.cxx  |5 -
 cui/source/tabpages/border.cxx|   22 ++--
 cui/source/tabpages/chardlg.cxx   |   15 +--
 cui/source/tabpages/grfpage.cxx   |   34 +++
 cui/source/tabpages/macroass.cxx  |   13 +-
 cui/source/tabpages/numfmt.cxx|   11 --
 cui/source/tabpages/numpages.cxx  |  180 --
 cui/source/tabpages/page.cxx  |   30 +++---
 cui/source/tabpages/paragrph.cxx  |   15 +--
 cui/source/tabpages/tabstpge.cxx  |   11 --
 cui/source/tabpages/themepage.cxx |9 -
 cui/source/tabpages/tpbitmap.cxx  |   11 +-
 cui/source/tabpages/tpcolor.cxx   |5 -
 cui/source/tabpages/tpgradnt.cxx  |   10 +-
 cui/source/tabpages/tphatch.cxx   |   10 +-
 cui/source/tabpages/tpline.cxx|   13 +-
 cui/source/tabpages/tppattern.cxx |   17 +--
 cui/source/tabpages/tptrans.cxx   |   16 +--
 cui/source/tabpages/transfrm.cxx  |   13 --
 27 files changed, 249 insertions(+), 297 deletions(-)

New commits:
commit e85b482df3fa01e5a2b549df63db96cc49f1ca78
Author: Noel Grandin 
AuthorDate: Mon Feb 28 12:01:43 2022 +0200
Commit: Noel Grandin 
CommitDate: Tue Mar 1 07:49:28 2022 +0100

use SfxItemSet::GetItemIfSet in cui

Change-Id: I0a6dbf50d29adf9da9512a9136709bf563e478f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130689
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/cui/source/customize/acccfg.cxx b/cui/source/customize/acccfg.cxx
index 09891003b784..81d1bb10668e 100644
--- a/cui/source/customize/acccfg.cxx
+++ b/cui/source/customize/acccfg.cxx
@@ -1510,10 +1510,9 @@ void SfxAcceleratorConfigPage::Reset(const SfxItemSet* 
rSet)
 RadioHdl(*m_xOfficeButton);
 
 #if HAVE_FEATURE_SCRIPTING
-const SfxPoolItem* pMacroItem = nullptr;
-if (SfxItemState::SET == rSet->GetItemState(SID_MACROINFO, true, 
))
+if (const SfxMacroInfoItem* pMacroItem = rSet->GetItemIfSet(SID_MACROINFO))
 {
-m_pMacroInfoItem = _cast(*pMacroItem);
+m_pMacroInfoItem = pMacroItem;
 m_xGroupLBox->SelectMacro(m_pMacroInfoItem);
 }
 #else
diff --git a/cui/source/dialogs/zoom.cxx b/cui/source/dialogs/zoom.cxx
index c1e56d28647d..0c9b189dd0f1 100644
--- a/cui/source/dialogs/zoom.cxx
+++ b/cui/source/dialogs/zoom.cxx
@@ -228,11 +228,8 @@ SvxZoomDialog::SvxZoomDialog(weld::Window* pParent, const 
SfxItemSet& rCoreSet)
 SetFactor(nZoom);
 }
 
-const SfxPoolItem* pPoolViewLayoutItem = nullptr;
-if (SfxItemState::SET == m_rSet.GetItemState(SID_ATTR_VIEWLAYOUT, false, 
))
+if (const SvxViewLayoutItem* pViewLayoutItem = 
m_rSet.GetItemIfSet(SID_ATTR_VIEWLAYOUT, false))
 {
-const SvxViewLayoutItem* pViewLayoutItem
-= static_cast(pPoolViewLayoutItem);
 const sal_uInt16 nColumns = pViewLayoutItem->GetValue();
 const bool bBookMode = pViewLayoutItem->IsBookMode();
 
diff --git a/cui/source/inc/align.hxx b/cui/source/inc/align.hxx
index 2be30aec6c71..7f4b906a3923 100644
--- a/cui/source/inc/align.hxx
+++ b/cui/source/inc/align.hxx
@@ -40,6 +40,8 @@
 #include 
 #include 
 
+class SfxEnumItemInterface;
+
 namespace svx {
 
 
@@ -62,7 +64,7 @@ private:
 voidInitVsRefEgde();
 voidUpdateEnableControls();
 
-boolHasAlignmentChanged( const SfxItemSet& rNew, 
sal_uInt16 nWhich ) const;
+boolHasAlignmentChanged( const SfxItemSet& rNew, 
TypedWhichId nWhich ) const;
 
 DECL_LINK(UpdateEnableHdl, weld::ComboBox&, void);
 DECL_LINK(StackedClickHdl, weld::Toggleable&, void);
diff --git a/cui/source/inc/numpages.hxx b/cui/source/inc/numpages.hxx
index c4f6961f82b0..8f554722fa67 100644
--- a/cui/source/inc/numpages.hxx
+++ b/cui/source/inc/numpages.hxx
@@ -63,8 +63,7 @@ class SvxSingleNumPickTabPage final : public SfxTabPage
 sal_uInt16  nActNumLvl;
 boolbModified   : 1;
 boolbPreset : 1;
-
-sal_uInt16  nNumItemId;
+TypedWhichId nNumItemId;
 
 std::unique_ptr m_xExamplesVS;
 std::unique_ptr m_xExamplesVSWin;
@@ -92,7 +91,7 @@ class SvxBulletPickTabPage final : public SfxTabPage
 sal_uInt16  nActNumLvl;
 boolbModified   : 1;
 boolbPreset : 1;
-sal_uInt16  nNumItemId;
+TypedWhichId nNumItemId;
 
 OUStringsBulletCharFormatName;
 
@@ -129,7 +128,7 @@ class SvxNumPickTabPage final : public SfxTabPage
 std::unique_ptr pActNum;
 std::unique_ptr pSaveNum;
 sal_uInt16  nActNumLvl;
-sal_uInt16  nNumItemId;
+

[Libreoffice-commits] core.git: sfx2/source

2022-02-28 Thread Noel Grandin (via logerrit)

 sfx2/source/appl/appcfg.cxx |  136 +-
 sfx2/source/appl/appserv.cxx|   32 ++---
 sfx2/source/appl/appuno.cxx |  239 +++-
 sfx2/source/dialog/dinfdlg.cxx  |   44 +++
 sfx2/source/dialog/mgetempl.cxx |7 -
 sfx2/source/doc/docfile.cxx |   10 -
 sfx2/source/doc/guisaveas.cxx   |3 
 sfx2/source/view/viewfrm.cxx|6 -
 sfx2/source/view/viewprn.cxx|3 
 9 files changed, 221 insertions(+), 259 deletions(-)

New commits:
commit 51b995b9861c3415c44f59fa5367347fd7eee255
Author: Noel Grandin 
AuthorDate: Mon Feb 28 14:59:35 2022 +0200
Commit: Noel Grandin 
CommitDate: Tue Mar 1 07:46:47 2022 +0100

use SfxItemSet::GetItemIfSet in sfx2

Change-Id: I241b038953f61228b6667014a4096bfe8dcc9c2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130709
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sfx2/source/appl/appcfg.cxx b/sfx2/source/appl/appcfg.cxx
index 8bcc6c0232fc..74e157bc9e16 100644
--- a/sfx2/source/appl/appcfg.cxx
+++ b/sfx2/source/appl/appcfg.cxx
@@ -401,17 +401,15 @@ void SfxApplication::GetOptions( SfxItemSet& rSet )
 // TODO/CLEANUP: Why two SetOptions Methods?
 void SfxApplication::SetOptions_Impl( const SfxItemSet& rSet )
 {
-const SfxPoolItem *pItem = nullptr;
 SfxItemPool  = GetPool();
 
 SvtMiscOptions aMiscOptions;
 std::shared_ptr< comphelper::ConfigurationChanges > batch(
 comphelper::ConfigurationChanges::create());
 
-if ( SfxItemState::SET == rSet.GetItemState(SID_ATTR_BUTTON_BIGSIZE, true, 
) )
+if ( const SfxBoolItem *pItem = rSet.GetItemIfSet(SID_ATTR_BUTTON_BIGSIZE) 
)
 {
-DBG_ASSERT(dynamic_cast< const SfxBoolItem *>( pItem ) !=  nullptr, 
"BoolItem expected");
-bool bBigSize = static_cast(pItem)->GetValue();
+bool bBigSize = pItem->GetValue();
 aMiscOptions.SetSymbolsSize(
 sal::static_int_cast< sal_Int16 >(
 bBigSize ? SFX_SYMBOLS_SIZE_LARGE : SFX_SYMBOLS_SIZE_SMALL ) );
@@ -425,147 +423,132 @@ void SfxApplication::SetOptions_Impl( const SfxItemSet& 
rSet )
 }
 
 // Backup
-if ( SfxItemState::SET == rSet.GetItemState(SID_ATTR_BACKUP, true, ) 
)
+if ( const SfxBoolItem *pItem = rSet.GetItemIfSet(SID_ATTR_BACKUP) )
 {
-DBG_ASSERT(dynamic_cast< const SfxBoolItem *>( pItem ) !=  nullptr, 
"BoolItem expected");
 officecfg::Office::Common::Save::Document::CreateBackup::set(
-static_cast(pItem)->GetValue(),
+pItem->GetValue(),
 batch );
 }
 
 // PrettyPrinting
-if ( SfxItemState::SET == rSet.GetItemState( SID_ATTR_PRETTYPRINTING, 
true,  ) )
+if ( const SfxBoolItem *pItem = rSet.GetItemIfSet( SID_ATTR_PRETTYPRINTING 
) )
 {
-DBG_ASSERT( dynamic_cast< const SfxBoolItem *>( pItem ) !=  nullptr, 
"BoolItem expected" );
 officecfg::Office::Common::Save::Document::PrettyPrinting::set(
-static_cast< const SfxBoolItem*> ( pItem )->GetValue(),
+pItem->GetValue(),
 batch );
 }
 
 // WarnAlienFormat
-if ( SfxItemState::SET == rSet.GetItemState( SID_ATTR_WARNALIENFORMAT, 
true,  ) )
+if ( const SfxBoolItem *pItem = rSet.GetItemIfSet( 
SID_ATTR_WARNALIENFORMAT ) )
 {
-DBG_ASSERT( dynamic_cast< const SfxBoolItem *>( pItem ) !=  nullptr, 
"BoolItem expected" );
 officecfg::Office::Common::Save::Document::WarnAlienFormat::set(
-static_cast< const SfxBoolItem*> ( pItem )->GetValue(),
+pItem->GetValue(),
 batch);
 }
 
 // AutoSave
-if ( SfxItemState::SET == rSet.GetItemState( SID_ATTR_AUTOSAVE, true, 
))
+if ( const SfxBoolItem *pItem = rSet.GetItemIfSet( SID_ATTR_AUTOSAVE ))
 {
-DBG_ASSERT(dynamic_cast< const SfxBoolItem *>( pItem ) !=  nullptr, 
"BoolItem expected");
 officecfg::Office::Common::Save::Document::AutoSave::set(
-static_cast(pItem)->GetValue(),
+pItem->GetValue(),
 batch);
 }
 
 // AutoSave-Prompt
-if ( SfxItemState::SET == rSet.GetItemState( SID_ATTR_AUTOSAVEPROMPT, 
true, ))
+if ( const SfxBoolItem *pItem = rSet.GetItemIfSet( SID_ATTR_AUTOSAVEPROMPT 
))
 {
-DBG_ASSERT(dynamic_cast< const SfxBoolItem *>( pItem ) !=  nullptr, 
"BoolItem expected");
 officecfg::Office::Common::Save::Document::AutoSavePrompt::set(
-static_cast(pItem)->GetValue(),
+pItem->GetValue(),
 batch);
 }
 
 // AutoSave-Time
-if ( SfxItemState::SET == rSet.GetItemState(SID_ATTR_AUTOSAVEMINUTE, true, 
))
+if ( const SfxUInt16Item *pItem = 
rSet.GetItemIfSet(SID_ATTR_AUTOSAVEMINUTE ))
 {
-DBG_ASSERT(dynamic_cast< const SfxUInt16Item *>( pItem ) !=  nullptr, 
"UInt16Item expected");
 officecfg::Office::Common::Save::Document::AutoSaveTimeIntervall::set(
-

[Libreoffice-commits] core.git: desktop/source editeng/source filter/source forms/source reportdesign/source

2022-02-28 Thread Noel Grandin (via logerrit)

 desktop/source/app/app.cxx |7 
 editeng/source/editeng/eertfpar.cxx|8 
 editeng/source/outliner/outlvw.cxx |8 
 filter/source/msfilter/msdffimp.cxx|4 
 filter/source/msfilter/svdfppt.cxx |   15 -
 forms/source/richtext/rtattributehandler.cxx   |5 
 reportdesign/source/ui/misc/UITools.cxx|  302 +
 reportdesign/source/ui/report/ReportController.cxx |   37 +-
 8 files changed, 172 insertions(+), 214 deletions(-)

New commits:
commit e13a8c7df2d11814a0a4669aad88e68e27835934
Author: Noel Grandin 
AuthorDate: Mon Feb 28 14:59:00 2022 +0200
Commit: Noel Grandin 
CommitDate: Tue Mar 1 07:46:32 2022 +0100

use SfxItemSet::GetItemIfSet in desktop..reportdesign

Change-Id: Iaa0ddf4e97866d537a478e668e3c651a9eabc465
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130708
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/desktop/source/app/app.cxx b/desktop/source/app/app.cxx
index f7e9a8ec8930..9c272314dadf 100644
--- a/desktop/source/app/app.cxx
+++ b/desktop/source/app/app.cxx
@@ -286,12 +286,11 @@ bool shouldLaunchQuickstart()
 bool bQuickstart = Desktop::GetCommandLineArgs().IsQuickstart();
 if (!bQuickstart)
 {
-const SfxPoolItem* pItem=nullptr;
 SfxItemSetFixed 
aQLSet(SfxGetpApp()->GetPool());
 SfxApplication::GetOptions(aQLSet);
-SfxItemState eState = aQLSet.GetItemState(SID_ATTR_QUICKLAUNCHER, 
false, );
-if (SfxItemState::SET == eState)
-bQuickstart = static_cast(pItem)->GetValue();
+const SfxBoolItem* pLauncherItem = 
aQLSet.GetItemIfSet(SID_ATTR_QUICKLAUNCHER, false);
+if (pLauncherItem)
+bQuickstart = pLauncherItem->GetValue();
 }
 return bQuickstart;
 }
diff --git a/editeng/source/editeng/eertfpar.cxx 
b/editeng/source/editeng/eertfpar.cxx
index 3006caf21594..8bf696a02603 100644
--- a/editeng/source/editeng/eertfpar.cxx
+++ b/editeng/source/editeng/eertfpar.cxx
@@ -307,7 +307,6 @@ void EditRTFParser::SetAttrInDoc( SvxRTFItemStackType  
)
 EditPaM aEndPaM( pEndNode, rSet.GetEndCnt() );
 
 // If possible adjust the Escapement-Item:
-const SfxPoolItem* pItem;
 
 // #i66167# adapt font heights to destination MapUnit if necessary
 const MapUnit eDestUnit = 
mpEditEngine->GetEditDoc().GetItemPool().GetMetric(0);
@@ -316,6 +315,7 @@ void EditRTFParser::SetAttrInDoc( SvxRTFItemStackType  
)
 sal_uInt16 const aFntHeightIems[3] = { EE_CHAR_FONTHEIGHT, 
EE_CHAR_FONTHEIGHT_CJK, EE_CHAR_FONTHEIGHT_CTL };
 for (unsigned short aFntHeightIem : aFntHeightIems)
 {
+const SfxPoolItem* pItem;
 if (SfxItemState::SET == rSet.GetAttrSet().GetItemState( 
aFntHeightIem, false,  ))
 {
 sal_uInt32 nHeight  = static_cast(pItem)->GetHeight();
@@ -331,10 +331,10 @@ void EditRTFParser::SetAttrInDoc( SvxRTFItemStackType 
 )
 }
 }
 
-if( SfxItemState::SET == rSet.GetAttrSet().GetItemState( 
EE_CHAR_ESCAPEMENT, false,  ))
+if( const SvxEscapementItem* pItem = rSet.GetAttrSet().GetItemIfSet( 
EE_CHAR_ESCAPEMENT, false ) )
 {
 // the correct one
-tools::Long nEsc = static_cast(pItem)->GetEsc();
+tools::Long nEsc = pItem->GetEsc();
 tools::Long nEscFontHeight = 0;
 if( ( DFLT_ESC_AUTO_SUPER != nEsc ) && ( DFLT_ESC_AUTO_SUB != nEsc ) )
 {
@@ -347,7 +347,7 @@ void EditRTFParser::SetAttrInDoc( SvxRTFItemStackType  
)
 {
 nEsc = nEsc * 100 / nEscFontHeight;
 
-SvxEscapementItem aEscItem( static_cast(nEsc), 
static_cast(pItem)->GetProportionalHeight(), 
EE_CHAR_ESCAPEMENT );
+SvxEscapementItem aEscItem( static_cast(nEsc), 
pItem->GetProportionalHeight(), EE_CHAR_ESCAPEMENT );
 rSet.GetAttrSet().Put( aEscItem );
 }
 }
diff --git a/editeng/source/outliner/outlvw.cxx 
b/editeng/source/outliner/outlvw.cxx
index bf11c742dfea..e4b8fd5e80f3 100644
--- a/editeng/source/outliner/outlvw.cxx
+++ b/editeng/source/outliner/outlvw.cxx
@@ -1045,17 +1045,15 @@ void OutlinerView::ApplyBulletsNumbering(
 
 // Get old bullet space.
 {
-const SfxPoolItem* pPoolItem=nullptr;
-SfxItemState eState = 
rAttrs.GetItemState(EE_PARA_NUMBULLET, false, );
-if (eState != SfxItemState::SET)
+const SvxNumBulletItem* pNumBulletItem = 
rAttrs.GetItemIfSet(EE_PARA_NUMBULLET, false);
+if (pNumBulletItem)
 {
 // Use default value when has not contain bullet 
item.
 ESelection aSelection(nPara, 0);
 SfxItemSet 
aTmpSet(pOwner->pEditEngine->GetAttribs(aSelection));
-pPoolItem =

[Libreoffice-commits] core.git: sc/source

2022-02-28 Thread Justin Luth (via logerrit)

 sc/source/filter/excel/xestream.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 5a64b618d84edb65465950d54e3b4afc952a301c
Author: Justin Luth 
AuthorDate: Tue Mar 1 06:54:49 2022 +0200
Commit: Justin Luth 
CommitDate: Tue Mar 1 07:19:51 2022 +0100

followup tdf#122098 xlsx export: avoid corrupt format if not bool value

Although I can't find any documents that cause a "b"
when the value is not 1 or 0, if such should ever happen,
then Excel complains about an invalid format and fails to load.

(The formatting looks a bit weird, but that is what clang-format
produces. How nice.)

Change-Id: I090a27829596260cdd6379b6a6daa75ce250b7e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130734
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/sc/source/filter/excel/xestream.cxx 
b/sc/source/filter/excel/xestream.cxx
index 2178b0b3abc7..08048e922111 100644
--- a/sc/source/filter/excel/xestream.cxx
+++ b/sc/source/filter/excel/xestream.cxx
@@ -673,7 +673,10 @@ void XclXmlUtils::GetFormulaTypeAndValue( ScFormulaCell& 
rCell, const char*& rsT
 rsValue = ToOUString(lcl_GetErrorString(aResValue.mnError));
 break;
 case sc::FormulaResultValue::Value:
-rsType = rCell.GetFormatType() == SvNumFormatType::LOGICAL ? "b" : 
"n";
+rsType = rCell.GetFormatType() == SvNumFormatType::LOGICAL
+ && (aResValue.mfValue == 0.0 || aResValue.mfValue 
== 1.0)
+ ? "b"
+ : "n";
 rsValue = OUString::number(aResValue.mfValue);
 break;
 case sc::FormulaResultValue::String:

[Libreoffice-bugs] [Bug 145580] Comment balloon doesn't allow Latin characters

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=145580

--- Comment #15 from flrnc...@gmail.com ---
When using the keyboard layout "US International with dead keys" in Linux
(Debian testing, X11), I can enter composite characters except double and
single quotes. With this keyboard layout, quotes need to be escaped by entering
first the quote character, then space so that they aren't used as accent
characters. This works as it should in the main document of Writer, but not in
comments.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147425] Feature request: Use super script (and sub script) glyphs from the font if it includes those characters.

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147425

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147415] Macro modules crashes in librecalc 7.4

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147415

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147413] After selecting multiple lines and editing them I cant write anymore.

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147413

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147411] SfxSlotMode TOOLBOXCONFIG & ACCELCONFIG not working independently from each other

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147411

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147606] Multiple index marks before the terms when updating the index that uses a concordance file

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147606

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147606] Multiple index marks before the terms when updating the index that uses a concordance file

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147606

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143652] All of a sudden, the document will begin to scroll out of control, adding multiple blank pages to the document until I close it.

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=143652

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143652] All of a sudden, the document will begin to scroll out of control, adding multiple blank pages to the document until I close it.

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=143652

--- Comment #3 from QA Administrators  ---
Dear MAWhitford2,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144240] write open document very slow(up to 2 min)

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=144240

--- Comment #2 from QA Administrators  ---
Dear saskuu,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133085] Calc is very very slow compared to MS Office - EDITING, FILEOPEN, FILESAVE

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=133085

--- Comment #24 from QA Administrators  ---
Dear Khaldoun,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142807] Libreoffice don't insert nor playback videos from ver 7 and later

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=142807

--- Comment #12 from QA Administrators  ---
Dear Alej,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 119492] Image got messed up when exporting directly to PDF

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=119492

--- Comment #32 from QA Administrators  ---
Dear libre,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 41725] CONFIGURATION: HKCU defined mail client should be used instead of HKLM defined by "Document as E-mail" toolbar button

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=41725

--- Comment #23 from QA Administrators  ---
Dear Lenge,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107486] EDITING: Border and background changes made to the header can't be undone using undo

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107486

--- Comment #5 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147690] When open a document that uses slanted boxes, they appear incorrectly and i cannot read it

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147690

Aron Budea  changed:

   What|Removed |Added

 CC||aron.bu...@gmail.com
 Attachment #178571|application/octet-stream|application/vnd.openxmlform
  mime type||ats-officedocument.presenta
   ||tionml.presentation

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147706] Animation pane selects additional animations to the one intended.

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147706

ci...@protonmail.com changed:

   What|Removed |Added

   Keywords||skillUI
 CC||ci...@protonmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147706] New: Animation pane selects additional animations to the one intended.

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147706

Bug ID: 147706
   Summary: Animation pane selects additional animations to the
one intended.
   Product: Impress Remote
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ci...@protonmail.com

Created attachment 178590
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178590=edit
Animation pane with all animations of the same object selected.

Version: 7.3.0.3 (x64) / LibreOffice Community
Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Calc: CL

If, when I'm editing an Impress presentation, I open the animation pane and
select an animation for editing, Impress will also select every other animation
related to the same object. This makes the process incredibly frustrating, as I
must manually deselect them with ctrl+click every time to prevent edits from
applying to all animations.

Steps to reproduce:

1. Open a blank Impress presentation;
2. Insert two objects, eg shapes or images.
3. Add an animation to each, e.g. an entrance animation.
4. As you select an object to add a second animation, the first animation in
the Animation pane is selected. Once it's added, it and a random other
animation is selected. Any edits applied will be to both. 
5. Select the second animation in the Animation Pane. The first animation will
automatically selected, and any edits or deletions will apply to both.

This makes multiple animations applied to the same object, such as entering and
exiting the slide in sequence, incredibly difficult and time consuming to
create.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147623] AutoCalculate sometimes fails to AutoCalculate

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147623

Kevin Suo  changed:

   What|Removed |Added

 CC||suokunl...@126.com
 Status|NEEDINFO|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #4 from Kevin Suo  ---
(In reply to cbarring from comment #3)
This is an known issue and is now fixed on master and backported in 7.3. It
will be available in 7.3.1 release soon. Please do upgrade once 7.3.1 is
released, or usr a 7.3 daily build for testing.

*** This bug has been marked as a duplicate of bug 147298 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147705] New: CRASH when pressing compose key

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147705

Bug ID: 147705
   Summary: CRASH when pressing compose key
   Product: LibreOffice
   Version: 7.2.5.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: hamish...@protonmail.com

Description:
In Calc, Draw, Impress, Math and Writer (don't use other components), pressing
the system compose key crashes LibreOffice

Steps to Reproduce:
1.Define any compose key in KDE system settings (tested using CapsLock, AltGr)
2.Open any new or existing file in Calc, Draw, Impress, Math or Writer
3.(Draw only) Create a text box to enable text entry
4.(Impress only) Click into "Click to add Title/Text" field
5.Press compose key

Actual Results:
LibreOffice crashes to desktop, then automatically restarts with Document
Recovery. Calc/Draw/etc runs normally again once recovery is complete

Expected Results:
Allow to complete composing of special characters (or if compose is
unsupported, nothing)


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 7.2.5.2.0+ / LibreOffice Community
Build ID: 20(Build:2)
CPU threads: 8; OS: Linux 5.16; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-GB (en_GB.UTF-8); UI: en-US
7.2.5-4
Calc: threaded

Compose key works normally in other programs (tested in Konsole, Kate, Firefox,
Zoom)
Insert > Special character works normally

If LibreOffice was started from a console, it always prints exactly the
following to the console as it crashes:

 /usr/include/c++/11.2.0/bits/stl_vector.h:1045: std::vector<_Tp,
_Alloc>::reference std::vector<_Tp, _Alloc>::operator[](std::vector<_Tp,
_Alloc>::size_type) [with _Tp = ExtTextInputAttr; _Alloc =
std::allocator; std::vector<_Tp, _Alloc>::reference =
ExtTextInputAttr&; std::vector<_Tp, _Alloc>::size_type = long unsigned int]:
Assertion '__n < this->size()' failed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146842] All pages are empty/white when printing (skia, macOS only)

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146842

m.a.riosv  changed:

   What|Removed |Added

 CC||dreapp...@yahoo.com

--- Comment #52 from m.a.riosv  ---
*** Bug 147703 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147703] Printing blank pages, no text

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147703

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg
 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from m.a.riosv  ---


*** This bug has been marked as a duplicate of bug 146842 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147704] FILEOPEN PPTX: image appears vertically compressed (by a factor of two)

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147704

m.a.riosv  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #2 from m.a.riosv  ---
Reproducible with
Version: 7.3.1.2 (x64) / LibreOffice Community
Build ID: 9fff0292474d6d0bf5df787b512c71d9ac4bc98e
CPU threads: 4; OS: Windows 10.0 Build 21390; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 4202ea2c932a14d216e74617bbb74a85030c9a59
CPU threads: 4; OS: Windows 10.0 Build 21390; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/TODO.performance

2022-02-28 Thread Luboš Luňák (via logerrit)

 sc/TODO.performance |   12 
 1 file changed, 12 deletions(-)

New commits:
commit 2c6f5ebfe69c3031af7b4903637226bd8a3dde62
Author: Luboš Luňák 
AuthorDate: Mon Feb 28 22:59:51 2022 +0100
Commit: Luboš Luňák 
CommitDate: Mon Feb 28 23:01:43 2022 +0100

remove obsolete TODO.performance

None of the issues listed is valid anymore.

Change-Id: I3e28753b111b9a8fd0f280684555dff214c158f3

diff --git a/sc/TODO.performance b/sc/TODO.performance
deleted file mode 100644
index 835aef373ae5..
--- a/sc/TODO.performance
+++ /dev/null
@@ -1,12 +0,0 @@
-This is a collection of methods that should be optimized to make better use
-of mdds or other calc internal data structures.
-Each method should contain a short description on how to hit the performance 
problem.
-
-
-* ScColumn::GetRangeScriptType
-** Import tdf80853.csv and select the whole content with the keyboard
-
-* XclExpRowBuffer::GetOrCreateRow
-** Look at the profile of chart2export
-** The repeated calls to ScDocument::GetRowHeight seem strange
-*** There should be a more efficient way to handle that loop

[Libreoffice-commits] core.git: include/o3tl

2022-02-28 Thread Stephan Bergmann (via logerrit)

 include/o3tl/unreachable.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8597748c42727b62e60f8a4af45520193d682de0
Author: Stephan Bergmann 
AuthorDate: Mon Feb 28 21:14:11 2022 +0100
Commit: Stephan Bergmann 
CommitDate: Mon Feb 28 22:54:38 2022 +0100

Brown paper bag fix

...of 87369ad7b82da6904e889614c88617e610d4506b "Use std::unreachable if
available".  (Unfortunately, Clang didn't warn about the thus meaningless 
uses
of O3TL_UNREACHABLE, presumably due to


"Suppress all -Wunused-value warnings from macro body expansions.")

(While at it, and as the expansion of O3TL_UNREACHABLE is now a nice full
expression, wrap it in parentheses, as is common best practice for such 
macro
definitions.)

Change-Id: I555e6716ebb66172add686521446d90db6054845
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130729
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/include/o3tl/unreachable.hxx b/include/o3tl/unreachable.hxx
index d5a2e156b760..604f7a2f7728 100644
--- a/include/o3tl/unreachable.hxx
+++ b/include/o3tl/unreachable.hxx
@@ -21,7 +21,7 @@
 
 #if defined __cpp_lib_unreachable
 
-#define O3TL_UNREACHABLE ::std::unreachable
+#define O3TL_UNREACHABLE (::std::unreachable())
 
 #else

[Libreoffice-bugs] [Bug 147704] FILEOPEN PPTX: image appears vertically compressed (by a factor of two)

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147704

--- Comment #1 from Gerald Pfeifer  ---
Created attachment 178589
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178589=edit
Visual comparison LibreOffice (left) vs Office 365 (right)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: uitest/impress_tests uitest/uitest

2022-02-28 Thread Xisco Fauli (via logerrit)

 uitest/impress_tests/drawinglayer.py |   81 +--
 uitest/uitest/uihelper/common.py |3 -
 2 files changed, 31 insertions(+), 53 deletions(-)

New commits:
commit 30c302cf489571ef13579c1ecd27c276945138d0
Author: Xisco Fauli 
AuthorDate: Mon Feb 28 20:00:53 2022 +0100
Commit: Xisco Fauli 
CommitDate: Mon Feb 28 22:42:10 2022 +0100

uitest: fix sporadic UITest_impress_demo failures

Revert 9158d2d2f19cf7bccba12d2ad4cb340e882b51cc
< blind fix for UITest_impress_demo failed >
and 99d2ee15ad6fae7073a53f7df8868300328a36e7
< blind fix for UITest_impress_demo failures >
Instead of asserting the shapes' properties directly,
Use the Position and Size dialog

Change-Id: Ie9aec0dbd1f1fc2ccab0993b428c8ac17938b3b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130724
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/uitest/impress_tests/drawinglayer.py 
b/uitest/impress_tests/drawinglayer.py
index acd1dbffe6fc..063211d413c6 100644
--- a/uitest/impress_tests/drawinglayer.py
+++ b/uitest/impress_tests/drawinglayer.py
@@ -25,29 +25,22 @@ class ImpressDrawinglayerTest(UITestCase):
 
 xImpressDoc = self.xUITest.getTopFocusWindow()
 
-self.assertEqual(1400, 
document.DrawPages[0].getByIndex(0).Position.X)
-self.assertEqual(628, 
document.DrawPages[0].getByIndex(0).Position.Y)
-self.assertEqual(1400, 
document.DrawPages[0].getByIndex(1).Position.X)
-self.assertEqual(3685, 
document.DrawPages[0].getByIndex(1).Position.Y)
-
-
-xEditWin = xImpressDoc.getChild("impress_win")
-xDrawinglayerObject = xEditWin.getChild("Unnamed Drawinglayer 
object 1")
-xDrawinglayerObject.executeAction("MOVE", mkPropertyValues({"X": 
"1000", "Y":"1000"}))
-
-xToolkit = 
self.xContext.ServiceManager.createInstance('com.sun.star.awt.Toolkit')
-xToolkit.processEventsToIdle()
-
-self.assertEqual(1400, 
document.DrawPages[0].getByIndex(0).Position.X)
-self.assertEqual(628, 
document.DrawPages[0].getByIndex(0).Position.Y)
-self.assertEqual(2400, 
document.DrawPages[0].getByIndex(1).Position.X)
-self.assertEqual(4685, 
document.DrawPages[0].getByIndex(1).Position.Y)
-
 self.assertIsNone(document.CurrentSelection)
 
+xEditWin = xImpressDoc.getChild("impress_win")
 xEditWin.executeAction("SELECT", 
mkPropertyValues({"OBJECT":"Unnamed Drawinglayer object 1"}))
 self.assertEqual("com.sun.star.drawing.SvxShapeCollection", 
document.CurrentSelection.getImplementationName())
 
+with self.ui_test.execute_dialog_through_command(".uno:Size") as 
xDialog:
+self.assertEqual('25.2', 
get_state_as_dict(xDialog.getChild('MTR_FLD_WIDTH'))['Value'])
+self.assertEqual('9.13', 
get_state_as_dict(xDialog.getChild('MTR_FLD_HEIGHT'))['Value'])
+self.assertEqual('1.4', 
get_state_as_dict(xDialog.getChild('MTR_FLD_POS_X'))['Value'])
+self.assertEqual('3.69', 
get_state_as_dict(xDialog.getChild('MTR_FLD_POS_Y'))['Value'])
+self.assertEqual('0', 
get_state_as_dict(xDialog.getChild('NF_ANGLE'))['Value'])
+
+xDrawinglayerObject = xEditWin.getChild("Unnamed Drawinglayer 
object 1")
+xDrawinglayerObject.executeAction("MOVE", mkPropertyValues({"X": 
"1000", "Y":"1000"}))
+
 with self.ui_test.execute_dialog_through_command(".uno:Size") as 
xDialog:
 self.assertEqual('25.2', 
get_state_as_dict(xDialog.getChild('MTR_FLD_WIDTH'))['Value'])
 self.assertEqual('9.13', 
get_state_as_dict(xDialog.getChild('MTR_FLD_HEIGHT'))['Value'])
@@ -59,7 +52,6 @@ class ImpressDrawinglayerTest(UITestCase):
 xEditWin.executeAction("DESELECT", tuple())
 self.assertIsNone(document.CurrentSelection)
 
-
 def test_resize_object(self):
 with self.ui_test.create_doc_in_start_center("impress") as document:
 
@@ -71,26 +63,22 @@ class ImpressDrawinglayerTest(UITestCase):
 
 xImpressDoc = self.xUITest.getTopFocusWindow()
 
-self.assertEqual(25199, 
document.DrawPages[0].getByIndex(0).Size.Width)
-self.assertEqual(2629, 
document.DrawPages[0].getByIndex(0).Size.Height)
-self.assertEqual(25199, 
document.DrawPages[0].getByIndex(1).Size.Width)
-self.assertAlmostEqual(9134, 
document.DrawPages[0].getByIndex(1).Size.Height,delta=1)
+self.assertIsNone(document.CurrentSelection)
 
 xEditWin = xImpressDoc.getChild("impress_win")
+xEditWin.executeAction("SELECT", 
mkPropertyValues({"OBJECT":"Unnamed Drawinglayer object 1"}))
+self.assertEqual("com.sun.star.drawing.SvxShapeCollection", 
document.CurrentSelection.getImplementationName())
+
+with

[Libreoffice-bugs] [Bug 147704] New: FILEOPEN PPTX: image appears vertically compressed (by a factor of two)

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147704

Bug ID: 147704
   Summary: FILEOPEN PPTX: image appears vertically compressed (by
a factor of two)
   Product: LibreOffice
   Version: 7.2.5.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: bibisectRequest, regression
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ger...@pfeifer.com

Created attachment 178588
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178588=edit
Sample slide (PPTX)

When opened in LibreOffice, the image on the slide appears vertically
compressed by about a factor of two compared to PowerPoint.

This is a regression, not seen with

  Version: 6.4.8.0.0+
  Build ID: 99b065ec31d032fc08ab14f66430dac4fef904a5
  CPU threads: 8; OS: Linux 5.16; UI render: default; VCL: gtk3; 
  TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:libreoffice-6-4, Time:  
2020-10-08_08:57:08

  Version: 7.1.8.0.0+ / LibreOffice Community
  Build ID: 4784990eda6098f0408276b4d424e81382a50460
  CPU threads: 8; OS: Linux 5.16; UI render: default; VCL: gtk3
  TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:libreoffice-7-1, Time:
2021-10-15_11:37:03

Seen with

  Version: 7.2.6.0.0+ / LibreOffice Community
  Build ID: 3db1a060a033a2f84bdf798bed3c7e2515a498ce
  CPU threads: 8; OS: Linux 5.16; UI render: default; VCL: gtk3
  TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:libreoffice-7-2, Time:
2022-01-30_18:48:19

  Version: 7.4.0.0.alpha0+ / LibreOffice Community
  Build ID: 522bde9470bbb321813fa5f1ca8e3c2ebb1bb5cc
  CPU threads: 8; OS: Linux 5.16; UI render: default; VCL: gtk3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 106547] [META] OOXML SmartArt bug tracker

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=106547

Regina Henschel  changed:

   What|Removed |Added

 Depends on||147690


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=147690
[Bug 147690] When open a document that uses slanted boxes, they appear
incorrectly and i cannot read it
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147690] When open a document that uses slanted boxes, they appear incorrectly and i cannot read it

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147690

Regina Henschel  changed:

   What|Removed |Added

 Blocks||106547
 Ever confirmed|0   |1
 OS|Linux (All) |All
 CC||rb.hensc...@t-online.de
 Status|UNCONFIRMED |NEW

--- Comment #2 from Regina Henschel  ---
I guess you mean the shape on the right side of slide 5.

That object is a so called "SmartArt". Import of SmartArt is only partly
implemented. There are currently some efforts to improve it, but that will not
be available soon.

You could do these:
* Ask the author to provide the presentation in PDF format in addition. That is
a simple "Save As" in PowerPoint.

* Customize your LibreOffice and add the command "Autofit Text" to your
Standard toolbar for example. Then select the object and click on command
"Autofit Text". This command reduces the rendered font size, so that the text
is inside the shape and you can read it.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106547
[Bug 106547] [META] OOXML SmartArt bug tracker
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/qa sw/qa

2022-02-28 Thread Xisco Fauli (via logerrit)

 sc/qa/uitest/calc_tests3/insertQrCodeGen.py   |   15 ---
 sc/qa/uitest/signatureLine/insertSignatureLine.py |   22 --
 sw/qa/uitest/writer_tests3/insertQrCodeGen.py |   15 ---
 sw/qa/uitest/writer_tests3/insertSignatureLine.py |7 ---
 4 files changed, 16 insertions(+), 43 deletions(-)

New commits:
commit 907a3c0248834f13441ec8c1239b3ca5c016aa5a
Author: Xisco Fauli 
AuthorDate: Mon Feb 28 20:36:38 2022 +0100
Commit: Xisco Fauli 
CommitDate: Mon Feb 28 22:28:05 2022 +0100

uitest: simplify tests even more

- No need to open the dialog to click the cancel button
- Avoid repeated calls to document.DrawPage.getByIndex(0).
Similar to 26298f29e9d36313be527b785a9bb96089582037
this might fix the different failures these tests sometimes
have

Change-Id: I4e175b6c5d48c4651e5877ec2a72c4858b590321
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130727
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/uitest/calc_tests3/insertQrCodeGen.py 
b/sc/qa/uitest/calc_tests3/insertQrCodeGen.py
index 27fd3e1227f7..2594b66c2dea 100644
--- a/sc/qa/uitest/calc_tests3/insertQrCodeGen.py
+++ b/sc/qa/uitest/calc_tests3/insertQrCodeGen.py
@@ -9,7 +9,6 @@
 
 from uitest.framework import UITestCase
 from uitest.uihelper.common import type_text
-from com.sun.star.lang import IndexOutOfBoundsException
 
 class insertQrCode(UITestCase):
 
@@ -18,13 +17,6 @@ class insertQrCode(UITestCase):
 xCalcDoc = self.xUITest.getTopFocusWindow()
 gridwin = xCalcDoc.getChild("grid_window")
 
-# cancel the dialog without doing anything
-with 
self.ui_test.execute_dialog_through_command(".uno:InsertQrCode", 
close_button="cancel") as xDialog:
-
-xURL = xDialog.getChild("edit_text")
-type_text(xURL, "www.libreoffice.org")
-
-# Reopen the dialog box
 with 
self.ui_test.execute_dialog_through_command(".uno:InsertQrCode") as xDialog:
 
 # Get elements in the Dialog Box
@@ -38,8 +30,9 @@ class insertQrCode(UITestCase):
 xBorder.executeAction("DOWN", tuple())
 
 # check the QR code in the document
-
self.assertEqual(document.Sheets.getByIndex(0).DrawPage.getByIndex(0).BarCodeProperties.Payload,
 "www.libreoffice.org")
-
self.assertEqual(document.Sheets.getByIndex(0).DrawPage.getByIndex(0).BarCodeProperties.ErrorCorrection,
 1)
-
self.assertEqual(document.Sheets.getByIndex(0).DrawPage.getByIndex(0).BarCodeProperties.Border,
 1)
+element = document.Sheets.getByIndex(0).DrawPage.getByIndex(0)
+self.assertEqual(element.BarCodeProperties.Payload, 
"www.libreoffice.org")
+self.assertEqual(element.BarCodeProperties.ErrorCorrection, 1)
+self.assertEqual(element.BarCodeProperties.Border, 1)
 
 # vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/sc/qa/uitest/signatureLine/insertSignatureLine.py 
b/sc/qa/uitest/signatureLine/insertSignatureLine.py
index 804b5e638b68..08323811a364 100644
--- a/sc/qa/uitest/signatureLine/insertSignatureLine.py
+++ b/sc/qa/uitest/signatureLine/insertSignatureLine.py
@@ -11,7 +11,6 @@ from uitest.framework import UITestCase
 from libreoffice.uno.propertyvalue import mkPropertyValues
 from uitest.uihelper.common import get_state_as_dict, type_text
 from libreoffice.uno.propertyvalue import mkPropertyValues
-from com.sun.star.lang import IndexOutOfBoundsException
 
 #Bug 117903 - Allow signature lines in Calc
 
@@ -22,12 +21,6 @@ class insertSignatureLineCalc(UITestCase):
 xCalcDoc = self.xUITest.getTopFocusWindow()
 gridwin = xCalcDoc.getChild("grid_window")
 
-# cancel the dialog without doing anything
-with 
self.ui_test.execute_dialog_through_command(".uno:InsertSignatureLine", 
close_button="cancel") as xDialog:
-
-xName = xDialog.getChild("edit_name")
-xName.executeAction("TYPE", mkPropertyValues({"TEXT":"Name"})) 
#set the signature line
-
 # set the signature line
 with 
self.ui_test.execute_dialog_through_command(".uno:InsertSignatureLine") as 
xDialog:
 
@@ -44,12 +37,13 @@ class insertSignatureLineCalc(UITestCase):
 xInstructions.executeAction("TYPE", 
mkPropertyValues({"TEXT":"Instructions"}))
 
 #check the signature Line in the document
-
self.assertEqual(document.Sheets.getByIndex(0).DrawPage.getByIndex(0).SignatureLineSuggestedSignerName,
 "Name")
-
self.assertEqual(document.Sheets.getByIndex(0).DrawPage.getByIndex(0).SignatureLineSuggestedSignerTitle,
 "Title")
-
self.assertEqual(document.Sheets.getByIndex(0).DrawPage.getByIndex(0).SignatureLineSuggestedSignerEmail,
 "Email")
-
self.assertEqual(document.Sheets.getByIndex(0).DrawPage.getByIndex(0).SignatureLineSuggestedSignerTitle,

[Libreoffice-commits] core.git: sc/qa

2022-02-28 Thread Luboš Luňák (via logerrit)

 sc/qa/unit/data/functions/date_time/fods/months.fods  |   16 +++---
 sc/qa/unit/data/functions/date_time/fods/networkdays.fods |   10 
 sc/qa/unit/data/functions/date_time/fods/weeks.fods   |   10 
 sc/qa/unit/data/functions/date_time/fods/workday.fods |   10 
 sc/qa/unit/data/functions/date_time/fods/years.fods   |   10 
 sc/qa/unit/data/ods/functions.ods |binary
 6 files changed, 28 insertions(+), 28 deletions(-)

New commits:
commit 424de44cd0eba254368d3b867bc440c99b548168
Author: Luboš Luňák 
AuthorDate: Mon Feb 28 20:40:05 2022 +0100
Commit: Luboš Luňák 
CommitDate: Mon Feb 28 22:27:33 2022 +0100

make named ranges in tests work with 16k columns

References like 'day1' are valid cell addresses with 16k columns,
since they go up to XFD1. Since addresses currently take precedence
over names, rename ranges to not conflict.

Change-Id: Iab63947565ed176c98bc541de6189d7ee9e8d255
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130728
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/sc/qa/unit/data/functions/date_time/fods/months.fods 
b/sc/qa/unit/data/functions/date_time/fods/months.fods
index 7857ad15b91a..538c8a60a3b4 100644
--- a/sc/qa/unit/data/functions/date_time/fods/months.fods
+++ b/sc/qa/unit/data/functions/date_time/fods/months.fods
@@ -670,7 +670,7 @@
  
 
 
- 
+ 
   1
  
  
@@ -679,15 +679,15 @@
  
   TRUE
  
- 
-  =MONTHS(day1, day2, 1)
+ 
+  =MONTHS(day1ref, day2ref, 1)
  
  
  
  
 
 
- 
+ 
   Err:502
  
  
@@ -696,8 +696,8 @@
  
   TRUE
  
- 
-  =MONTHS(day1, day2, 8999)
+ 
+  =MONTHS(day1ref, day2ref, 8999)
  
  
   Tdf#100440 
@@ -921,8 +921,8 @@
 


-
-
+
+

   
  
diff --git a/sc/qa/unit/data/functions/date_time/fods/networkdays.fods 
b/sc/qa/unit/data/functions/date_time/fods/networkdays.fods
index ade367258633..c23d0c52e7e5 100644
--- a/sc/qa/unit/data/functions/date_time/fods/networkdays.fods
+++ b/sc/qa/unit/data/functions/date_time/fods/networkdays.fods
@@ -880,7 +880,7 @@
  
 
 
- 
+ 
   17
  
  
@@ -889,8 +889,8 @@
  
   PRAVDA
  
- 
-  =NETWORKDAYS(day1;day2;days)
+ 
+  =NETWORKDAYS(day1ref;day2ref;days)
  
  
  
@@ -1005,8 +1005,8 @@
 


-
-
+
+
 

   
diff --git a/sc/qa/unit/data/functions/date_time/fods/weeks.fods 
b/sc/qa/unit/data/functions/date_time/fods/weeks.fods
index c59113ce768f..37eb7ff18c68 100644
--- a/sc/qa/unit/data/functions/date_time/fods/weeks.fods
+++ b/sc/qa/unit/data/functions/date_time/fods/weeks.fods
@@ -827,7 +827,7 @@
  
 
 
- 
+ 
   4
  
  
@@ -836,8 +836,8 @@
  
   TRUE
  
- 
-  =WEEKS(day1,day2,one)
+ 
+  =WEEKS(day1ref,day2ref,one)
  
  
  
@@ -1682,8 +1682,8 @@
 


-
-
+
+
 
 

diff --git a/sc/qa/unit/data/functions/date_time/fods/workday.fods 
b/sc/qa/unit/data/functions/date_time/fods/workday.fods
index 549c0e6a3d0e..f20be0b337f1 100644
--- a/sc/qa/unit/data/functions/date_time/fods/workday.fods
+++ b/sc/qa/unit/data/functions/date_time/fods/workday.fods
@@ -756,7 +756,7 @@
  
 
 
- 
+ 
   07.11.2014
  
  
@@ -765,8 +765,8 @@
  
   PRAVDA
  
- 
-  =WORKDAY(day1;day2;days)
+ 
+  =WORKDAY(day1ref;day2ref;days)
  
  
  
@@ -915,8 +915,8 @@
 


-
-
+
+
 

   
diff --git a/sc/qa/unit/data/functions/date_time/fods/years.fods 
b/sc/qa/unit/data/functions/date_time/fods/years.fods
index 968cda1f43cd..e02a77c4c211 100644
--- a/sc/qa/unit/data/functions/date_time/fods/years.fods
+++ b/sc/qa/unit/data/functions/date_time/fods/years.fods
@@ -847,7 +847,7 @@
  
 
 
- 
+ 
   3
  
  
@@ -856,8 +856,8 @@
  
   TRUE
  
- 
-  =YEARS(day1,day2,one)
+ 
+  =YEARS(day1ref,day2ref,one)
  
  
  
@@ -1122,8 +1122,8 @@
 


-
-
+
+
 
 

diff --git a/sc/qa/unit/data/ods/functions.ods 
b/sc/qa/unit/data/ods/functions.ods
index 2585b0afc530..04c6e6ed1274 100644
Binary files a/sc/qa/unit/data/ods/functions.ods and 
b/sc/qa/unit/data/ods/functions.ods differ

[Libreoffice-bugs] [Bug 139734] Drop redundant asserts after MacrosTest::loadFromDesktop

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=139734

--- Comment #30 from Commit Notification 
 ---
pragat-pandya committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/73ef2f6f615b88ef25366f9073c5fb3db5e76687

tdf#139734 removing redundant asserts after MacrosTest::loadFromDesktop

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: dbaccess/qa sccomp/qa

2022-02-28 Thread pragat-pandya (via logerrit)

 dbaccess/qa/extras/rowsetclones.cxx |3 +--
 dbaccess/qa/unit/dbtest_base.cxx|4 +---
 sccomp/qa/unit/SwarmSolverTest.cxx  |   10 --
 3 files changed, 2 insertions(+), 15 deletions(-)

New commits:
commit 73ef2f6f615b88ef25366f9073c5fb3db5e76687
Author: pragat-pandya 
AuthorDate: Sun Feb 6 16:50:05 2022 +0530
Commit: Mike Kaganski 
CommitDate: Mon Feb 28 22:21:28 2022 +0100

tdf#139734 removing redundant asserts after MacrosTest::loadFromDesktop

Change-Id: I89ffa387464ce7cc43c1884b031d6fade5b85078
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129581
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/dbaccess/qa/extras/rowsetclones.cxx 
b/dbaccess/qa/extras/rowsetclones.cxx
index 21a30636961b..d83d160ca132 100644
--- a/dbaccess/qa/extras/rowsetclones.cxx
+++ b/dbaccess/qa/extras/rowsetclones.cxx
@@ -51,8 +51,7 @@ void RowSetClones::test()
 const OUString 
sFilePath(m_directories.getURLFromWorkdir(u"CppunitTest/RowSetClones.odb"));
 
 uno::Reference< lang::XComponent > xComponent (loadFromDesktop(sFilePath));
-uno::Reference< XOfficeDatabaseDocument > xDocument(xComponent, UNO_QUERY);
-CPPUNIT_ASSERT(xDocument.is());
+uno::Reference< XOfficeDatabaseDocument > xDocument(xComponent, 
UNO_QUERY_THROW);
 
 uno::Reference< XDataSource > xDataSource = xDocument->getDataSource();
 CPPUNIT_ASSERT(xDataSource.is());
diff --git a/dbaccess/qa/unit/dbtest_base.cxx b/dbaccess/qa/unit/dbtest_base.cxx
index c7992288cdbd..b5a3bd31cf90 100644
--- a/dbaccess/qa/unit/dbtest_base.cxx
+++ b/dbaccess/qa/unit/dbtest_base.cxx
@@ -67,9 +67,7 @@ uno::Reference< XOfficeDatabaseDocument >
 
 uno::Reference DBTestBase::getDocumentForUrl(OUString 
const & url) {
 uno::Reference< lang::XComponent > xComponent (loadFromDesktop(url));
-uno::Reference< XOfficeDatabaseDocument > xDocument(xComponent, UNO_QUERY);
-CPPUNIT_ASSERT(xDocument.is());
-
+uno::Reference< XOfficeDatabaseDocument > xDocument(xComponent, 
UNO_QUERY_THROW);
 return xDocument;
 }
 
diff --git a/sccomp/qa/unit/SwarmSolverTest.cxx 
b/sccomp/qa/unit/SwarmSolverTest.cxx
index 030822b9cdb4..966f9c673fc5 100644
--- a/sccomp/qa/unit/SwarmSolverTest.cxx
+++ b/sccomp/qa/unit/SwarmSolverTest.cxx
@@ -60,8 +60,6 @@ void SwarmSolverTest::testUnconstrained()
 createFileURL(u"Simple.ods", aFileURL);
 mxComponent = loadFromDesktop(aFileURL);
 
-CPPUNIT_ASSERT_MESSAGE("Component not loaded", mxComponent.is());
-
 uno::Reference xDocument(mxComponent, 
uno::UNO_QUERY_THROW);
 uno::Reference xIndex(xDocument->getSheets(), 
uno::UNO_QUERY_THROW);
 uno::Reference xSheet(xIndex->getByIndex(0), 
uno::UNO_QUERY_THROW);
@@ -109,8 +107,6 @@ void SwarmSolverTest::testVariableBounded()
 createFileURL(u"Simple.ods", aFileURL);
 mxComponent = loadFromDesktop(aFileURL);
 
-CPPUNIT_ASSERT_MESSAGE("Component not loaded", mxComponent.is());
-
 uno::Reference xDocument(mxComponent, 
uno::UNO_QUERY_THROW);
 uno::Reference xIndex(xDocument->getSheets(), 
uno::UNO_QUERY_THROW);
 uno::Reference xSheet(xIndex->getByIndex(0), 
uno::UNO_QUERY_THROW);
@@ -160,8 +156,6 @@ void SwarmSolverTest::testVariableConstrained()
 createFileURL(u"Simple.ods", aFileURL);
 mxComponent = loadFromDesktop(aFileURL);
 
-CPPUNIT_ASSERT_MESSAGE("Component not loaded", mxComponent.is());
-
 uno::Reference xDocument(mxComponent, 
uno::UNO_QUERY_THROW);
 uno::Reference xIndex(xDocument->getSheets(), 
uno::UNO_QUERY_THROW);
 uno::Reference xSheet(xIndex->getByIndex(0), 
uno::UNO_QUERY_THROW);
@@ -214,8 +208,6 @@ void SwarmSolverTest::testTwoVariables()
 createFileURL(u"TwoVariables.ods", aFileURL);
 mxComponent = loadFromDesktop(aFileURL);
 
-CPPUNIT_ASSERT_MESSAGE("Component not loaded", mxComponent.is());
-
 uno::Reference xDocument(mxComponent, 
uno::UNO_QUERY_THROW);
 uno::Reference xIndex(xDocument->getSheets(), 
uno::UNO_QUERY_THROW);
 uno::Reference xSheet(xIndex->getByIndex(0), 
uno::UNO_QUERY_THROW);
@@ -272,8 +264,6 @@ void SwarmSolverTest::testMultipleVariables()
 createFileURL(u"MultiVariable.ods", aFileURL);
 mxComponent = loadFromDesktop(aFileURL);
 
-CPPUNIT_ASSERT_MESSAGE("Component not loaded", mxComponent.is());
-
 uno::Reference xDocument(mxComponent, 
uno::UNO_QUERY_THROW);
 uno::Reference xIndex(xDocument->getSheets(), 
uno::UNO_QUERY_THROW);
 uno::Reference xSheet(xIndex->getByIndex(0), 
uno::UNO_QUERY_THROW);

[Libreoffice-commits] core.git: sw/source

2022-02-28 Thread Jim Raykowski (via logerrit)

 sw/source/uibase/utlui/content.cxx |   13 +++--
 1 file changed, 7 insertions(+), 6 deletions(-)

New commits:
commit 393e8d622e1ebea0eb2ac59274e7216819b7022b
Author: Jim Raykowski 
AuthorDate: Fri Feb 25 15:16:32 2022 -0900
Commit: Jim Raykowski 
CommitDate: Mon Feb 28 22:04:01 2022 +0100

SwNavigator: fix cursor positioning on comment context menu 'Edit...'

Makes the cursor end up in the selected comment annotation window
instead of at the comment anchor position in the document when a
comment annotation window has the cursor focus and the Comment context
menu item 'Edit...' is selected.

Change-Id: Iac87177670a1b74525dd03ecce05135c4b89d692
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130572
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sw/source/uibase/utlui/content.cxx 
b/sw/source/uibase/utlui/content.cxx
index 963ab9efe9db..7fa9c9fa5fb2 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -4679,16 +4679,17 @@ void SwContentTree::EditEntry(const weld::TreeIter& 
rEntry, EditEntryMode nMode)
 [[fallthrough]]; // execute FN_POSTIT assuring standard mode first
 }
 case ContentTypeId::POSTIT:
-m_pActiveShell->GetView().GetPostItMgr()->AssureStdModeAtShell();
+{
+auto& rView = m_pActiveShell->GetView();
+auto pPostItMgr = rView.GetPostItMgr();
+pPostItMgr->AssureStdModeAtShell();
+pPostItMgr->SetActiveSidebarWin(nullptr);
+rView.GetEditWin().GrabFocus();
 if(nMode == EditEntryMode::DELETE)
-{
-
m_pActiveShell->GetView().GetPostItMgr()->SetActiveSidebarWin(nullptr);
 m_pActiveShell->DelRight();
-}
 else
-{
 nSlot = FN_POSTIT;
-}
+}
 break;
 case ContentTypeId::INDEX:
 {

[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-21.06.18-1'

2022-02-28 Thread Andras Timar (via logerrit)

Tag 'cp-21.06.18-1' created by Andras Timar  at 
2022-02-28 20:52 +

cp-21.06.18-1

Changes since cp-21.06.17-1-19:
---
 0 files changed
---

[Libreoffice-commits] translations.git: Changes to 'refs/tags/cp-21.06.18-1'

2022-02-28 Thread Andras Timar (via logerrit)

Tag 'cp-21.06.18-1' created by Andras Timar  at 
2022-02-28 20:52 +

cp-21.06.18-1

Changes since cp-21.06.13-1-1:
---
 0 files changed
---

[Libreoffice-commits] help.git: Changes to 'refs/tags/cp-21.06.18-1'

2022-02-28 Thread Adolfo Jayme Barrientos (via logerrit)

Tag 'cp-21.06.18-1' created by Andras Timar  at 
2022-02-28 20:52 +

cp-21.06.18-1

Changes since co-2021-branch-point-10:
---
 0 files changed
---

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/cp-21.06.18-1'

2022-02-28 Thread Andras Timar (via logerrit)

Tag 'cp-21.06.18-1' created by Andras Timar  at 
2022-02-28 20:52 +

cp-21.06.18-1

Changes since libreoffice-7-1-branch-point-5:
---
 0 files changed
---

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - configure.ac

2022-02-28 Thread Andras Timar (via logerrit)

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a60ce86a3c17edf21f2f449b425c44f630c12c03
Author: Andras Timar 
AuthorDate: Mon Feb 28 21:51:32 2022 +0100
Commit: Andras Timar 
CommitDate: Mon Feb 28 21:51:32 2022 +0100

Bump version to 21.06.18.1

Change-Id: Iaebb5dc6b32cc722ffdc646089cecd905ddad1df

diff --git a/configure.ac b/configure.ac
index 7362ec1a34b4..2991ef0b09bf 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([Collabora Office],[21.06.17.1],[],[],[https://collaboraoffice.com/])
+AC_INIT([Collabora Office],[21.06.18.1],[],[],[https://collaboraoffice.com/])
 
 dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just 
fine if it is installed
 dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails 
hard

[Libreoffice-bugs] [Bug 147703] New: Printing blank pages, no text

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147703

Bug ID: 147703
   Summary: Printing blank pages, no text
   Product: LibreOffice
   Version: 7.3.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dreapp...@yahoo.com

Description:
With either Writer or Calc, printing a document recognizes the number of pages
to print, but all the pages are blank.

Steps to Reproduce:
1. Clicked on CMD-P to print my document. Dialog presented. Recognized printer
and number of pages in document, but preview showed all pages were blank.
2. Clicked on "Print" button anyway. Printed blank pages.

Actual Results:
See Steps above.

Expected Results:
Should print document rather than blank pages.


Reproducible: Always


User Profile Reset: No



Additional Info:
LibreOffice: Build 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3
Printer is Brother MFC-J995DW 2. Connected to local network.
Computer is MacBook Pro, running MAC OS X 11.6.4 (Big Sur)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147623] AutoCalculate sometimes fails to AutoCalculate

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147623

--- Comment #3 from cbarr...@shaw.ca ---
Hi.  I installed version 7.3.1.2.  So far, this works.  I have some fairly
complicated calculations involving regression.  Under 7.3.0.3, the non-updating
problem generated really unreliable numbers.  The regression worked properly
under 7.3.1.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/qa sw/qa

2022-02-28 Thread Xisco Fauli (via logerrit)

 sc/qa/uitest/calc_tests3/insertQrCodeGen.py   |   25 
 sc/qa/uitest/signatureLine/insertSignatureLine.py |   34 --
 sw/qa/uitest/writer_tests3/insertQrCodeGen.py |   24 ---
 sw/qa/uitest/writer_tests3/insertSignatureLine.py |   34 --
 4 files changed, 117 deletions(-)

New commits:
commit 9a810cd97b3d92c7b6ea277fe2e483c223405e88
Author: Xisco Fauli 
AuthorDate: Mon Feb 28 18:28:30 2022 +0100
Commit: Xisco Fauli 
CommitDate: Mon Feb 28 20:51:00 2022 +0100

uitest: remove duplicated tests

They are pretty much the same as the other one in the
same file

Besides, the 'with self.assertRaises(IndexOutOfBoundsException)'
nonsense

Change-Id: I0ad9aaf80721eb49080d94a34deb43b0bc39724c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130718
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/uitest/calc_tests3/insertQrCodeGen.py 
b/sc/qa/uitest/calc_tests3/insertQrCodeGen.py
index 67a3015b051d..27fd3e1227f7 100644
--- a/sc/qa/uitest/calc_tests3/insertQrCodeGen.py
+++ b/sc/qa/uitest/calc_tests3/insertQrCodeGen.py
@@ -24,9 +24,6 @@ class insertQrCode(UITestCase):
 xURL = xDialog.getChild("edit_text")
 type_text(xURL, "www.libreoffice.org")
 
-with self.assertRaises(IndexOutOfBoundsException):
-document.Sheets.getByIndex(0).DrawPage.getByIndex(0)
-
 # Reopen the dialog box
 with 
self.ui_test.execute_dialog_through_command(".uno:InsertQrCode") as xDialog:
 
@@ -45,26 +42,4 @@ class insertQrCode(UITestCase):
 
self.assertEqual(document.Sheets.getByIndex(0).DrawPage.getByIndex(0).BarCodeProperties.ErrorCorrection,
 1)
 
self.assertEqual(document.Sheets.getByIndex(0).DrawPage.getByIndex(0).BarCodeProperties.Border,
 1)
 
-
-   def test_insert_qr_code_gen2(self):
-with self.ui_test.create_doc_in_start_center("calc") as document:
-xCalcDoc = self.xUITest.getTopFocusWindow()
-gridwin = xCalcDoc.getChild("grid_window")
-
-with 
self.ui_test.execute_dialog_through_command(".uno:InsertQrCode") as xDialog:
-
-xURL = xDialog.getChild("edit_text")
-xECC_Low = xDialog.getChild("button_low")
-xBorder = xDialog.getChild("edit_margin")
-
-type_text(xURL, "www.libreoffice.org") #set the QR code
-xECC_Low.executeAction("CLICK", tuple())
-xBorder.executeAction("UP", tuple())
-xBorder.executeAction("DOWN", tuple())
-
-#check the QR Code in the document
-
self.assertEqual(document.Sheets.getByIndex(0).DrawPage.getByIndex(0).BarCodeProperties.Payload,
 "www.libreoffice.org")
-
self.assertEqual(document.Sheets.getByIndex(0).DrawPage.getByIndex(0).BarCodeProperties.ErrorCorrection,
 1)
-
self.assertEqual(document.Sheets.getByIndex(0).DrawPage.getByIndex(0).BarCodeProperties.Border,
 1)
-
 # vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/sc/qa/uitest/signatureLine/insertSignatureLine.py 
b/sc/qa/uitest/signatureLine/insertSignatureLine.py
index 3472ed409d0d..804b5e638b68 100644
--- a/sc/qa/uitest/signatureLine/insertSignatureLine.py
+++ b/sc/qa/uitest/signatureLine/insertSignatureLine.py
@@ -28,9 +28,6 @@ class insertSignatureLineCalc(UITestCase):
 xName = xDialog.getChild("edit_name")
 xName.executeAction("TYPE", mkPropertyValues({"TEXT":"Name"})) 
#set the signature line
 
-with self.assertRaises(IndexOutOfBoundsException):
-document.Sheets.getByIndex(0).DrawPage.getByIndex(0)
-
 # set the signature line
 with 
self.ui_test.execute_dialog_through_command(".uno:InsertSignatureLine") as 
xDialog:
 
@@ -55,35 +52,4 @@ class insertSignatureLineCalc(UITestCase):
 
self.assertEqual(document.Sheets.getByIndex(0).DrawPage.getByIndex(0).SignatureLineShowSignDate,
 True)
 
self.assertEqual(document.Sheets.getByIndex(0).DrawPage.getByIndex(0).SignatureLineSigningInstructions,
 "Instructions")
 
-
-   def test_insert_signature_line2_calc(self):
-with self.ui_test.create_doc_in_start_center("calc") as document:
-xCalcDoc = self.xUITest.getTopFocusWindow()
-gridwin = xCalcDoc.getChild("grid_window")
-
-with 
self.ui_test.execute_dialog_through_command(".uno:InsertSignatureLine") as 
xDialog:
-
-xName = xDialog.getChild("edit_name")
-xTitle = xDialog.getChild("edit_title")
-xEmail = xDialog.getChild("edit_email")
-xComment = xDialog.getChild("checkbox_can_add_comments")
-xDate = xDialog.getChild("checkbox_show_sign_date")
-xInstructions = xDialog.getChild("edit_instructions")
-
-xName.executeAction("TYPE",

[Libreoffice-bugs] [Bug 147623] AutoCalculate sometimes fails to AutoCalculate

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147623

--- Comment #2 from Herb B  ---
See bug: 147298 
This may be same issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: winaccessibility/source

2022-02-28 Thread Andrea Gelmini (via logerrit)

 winaccessibility/source/service/AccObjectWinManager.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a6a3edaa8b34ead7458a59d00e96c5b38b4de887
Author: Andrea Gelmini 
AuthorDate: Mon Feb 28 19:15:30 2022 +0100
Commit: Julien Nabet 
CommitDate: Mon Feb 28 20:21:32 2022 +0100

Fix typo

Change-Id: I9502432260287ae0e6d17231c60f34b4ae2e3729
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130722
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/winaccessibility/source/service/AccObjectWinManager.cxx 
b/winaccessibility/source/service/AccObjectWinManager.cxx
index 5c1f021d422a..c405e6799d2b 100644
--- a/winaccessibility/source/service/AccObjectWinManager.cxx
+++ b/winaccessibility/source/service/AccObjectWinManager.cxx
@@ -146,7 +146,7 @@ AccObject* AccObjectWinManager::GetTopWindowAccObj(HWND 
hWnd)
 /**
* Simulate MSAA event via XAccessible interface and event type.
* @param pXAcc XAccessible interface.
-   * @param eEvent eventy type
+   * @param eEvent event type
* @return The terminate result that identifies if the call is successful.
*/
 bool AccObjectWinManager::NotifyAccEvent(XAccessible* pXAcc, UnoMSAAEvent 
eEvent)

[Libreoffice-bugs] [Bug 147702] Fileopen DOC: Text jumbled together on a page

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147702

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #2 from m.a.riosv  ---
Really a mess along the document.
Version: 7.2.6.1 (x64) / LibreOffice Community
Build ID: ce99d6a58f9368279ff1495b5b367eb64343b26c
CPU threads: 4; OS: Windows 10.0 Build 21390; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL

Maybe a dup of:
https://bugs.documentfoundation.org/show_bug.cgi?id=134458
https://bugs.documentfoundation.org/show_bug.cgi?id=141223
https://bugs.documentfoundation.org/show_bug.cgi?id=132598
https://bugs.documentfoundation.org/show_bug.cgi?id=95623

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147691] Calc chart embedded basic custom altered at record

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147691

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #3 from m.a.riosv  ---
Repro
Version: 7.2.6.1 (x64) / LibreOffice Community
Build ID: ce99d6a58f9368279ff1495b5b367eb64343b26c
CPU threads: 4; OS: Windows 10.0 Build 21390; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL

Please, how you have set up the blue area?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147702] Fileopen DOC: Text jumbled together on a page

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147702

--- Comment #1 from Telesto  ---
Created attachment 178587
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178587=edit
Example file

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147702] New: Fileopen DOC: Text jumbled together on a page

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147702

Bug ID: 147702
   Summary: Fileopen DOC: Text jumbled together on a page
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Text jumbled together on a page

Steps to Reproduce:
1. Open the attached file (source: attachment 148544 -> page 67 )
2. Scroll down, notice overlapping texts

Actual Results:
Text overlapping

Expected Results:
Every text block on different page


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 2a403801576543a7254edd41d6919c8c57c34f9e
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147694] In LibreOffice Calc, the date "3/4" is not converted correctly.

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147694

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg
 Resolution|--- |NOTABUG
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from m.a.riosv  ---
You need to avoid the conversion on Menu/Tools/Autocorrect options/Replace
deleting the replacement for 3/4.

In any way, you can use 03/4 or 3/04 and the date it's entered.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147696] FILESAVE DOCX Index entries of alphabetic index are wrongly exported to docx

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147696

m.a.riosv  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|UNCONFIRMED |NEW

--- Comment #1 from m.a.riosv  ---
Reproducible.
Right-click on the index with word, offers to update field, which works but not
like in LibreOffice, and there it's not 'table of contents to update'
Version: 7.2.6.1 (x64) / LibreOffice Community
Build ID: ce99d6a58f9368279ff1495b5b367eb64343b26c
CPU threads: 4; OS: Windows 10.0 Build 21390; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 126382] Impress/Draw: character Highlight color "No fill" cannot override style highlight on file-open

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=126382

--- Comment #12 from Justin L  ---
After file-load, try changing the style's background color. It doesn't affect
the highlight color. So somehow the direct formatting has acquired a copy of
the style's highlight? Or is this autostyle related?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] translations.git: Changes to 'refs/tags/libreoffice-7.3.1.3'

2022-02-28 Thread Christian Lohmaier (via logerrit)

Tag 'libreoffice-7.3.1.3' created by Christian Lohmaier 
 at 2022-02-28 18:19 +

Tag libreoffice-7.3.1.3
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmIdEj8ACgkQ9DSh76/u
rqPqixAAkroifmuSfjNoPjdwd+2kw5jBIJ9A/mk9Ih7z0vjSxi+qKelnNdJNFnHN
NmwmYiPuKka6kphJ+6lNB8Of/OQ6TkkomM/u4sW2F+jWepAxJn2dZqmoceluvIbx
Jp40BYGbhXuUw3SsFrhZAEXR+J0R+PkGw4JasFEG88j7zBvPPRwmtL8Lntk5Gna8
YxN3V1hFhmrujdwdlxNUbMfoY3geAorNLOaSS+Uj29y1LKzXOO5hVVy/ZkM62zop
PMIBoH8RogHVgRLPYNcAyLBQhuKWo8+aN9EPXfvgp1Ty/16DobrwPXBZilf0kmv0
Bt2589SIoBXOFxxoMFH5WKtAzxLsU8dHmEp6woaMY/9IZabRpLSNKWsJtO6A3K+G
G5EtkFK/4Ss5uLzvKGHEwnA5WpanO0lMWeoRwDQFa4XAELqwsRPcX4SpsD4e24up
8OadmYy/8XNSFP3q/wpEcG2dCbZHtTCX+j2fyH0OX5XbsCeGVidTR8+6wNZW9xvV
rhMYIhxpNDBE40+s9GTqkFzcf6brwxuw9Dy5R3qUB7tQztIUQgK2NM/nVUHe72Y0
wN2agwHebTeRxDRud+suQ9d4krXtILlz2+2LC4BUi+ah7Z7r1ARA7hDUS3kzz8rm
tgVPGynsKD8QRWtXFaQAHRhVdLemHAxcckV7xKh3rTroJQWOmTQ=
=ATOG
-END PGP SIGNATURE-

Changes since co-22.05-branch-point-5:
---
 0 files changed
---

[Libreoffice-bugs] [Bug 112416] [META] XLSX pivot table bugs

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112416
Bug 112416 depends on bug 122471, which changed state.

Bug 122471 Summary: FILEOPEN XLSX, Pivot missing columns and rows in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=122471

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] help.git: Changes to 'refs/tags/libreoffice-7.3.1.3'

2022-02-28 Thread Christian Lohmaier (via logerrit)

Tag 'libreoffice-7.3.1.3' created by Christian Lohmaier 
 at 2022-02-28 18:19 +

Tag libreoffice-7.3.1.3
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmIdEj8ACgkQ9DSh76/u
rqOaxRAAsDDcsO6JtjsU7vf3lVvedLKyjzwmj6s7RfFH4jILf4iKwaFL+f8ugfZE
LlWf2BmCFNPvBnODdZ2h8UsPsYIYSvYgeZqt2xxrz4KJg3x3NXk7hFqroBSoG3dZ
P9f01si9U9LEPQUDJ1j9HcoRkjZqVCYNTRXl1oMTQxAZlN1SWctE/LEXfRGhMwIy
Rqnt1xmiJlKdSn9YJynbj6KJLmJ2gLJ4HpD1cNY9zTaX78PTn6Dn4JVWFTuyvTdy
mZC3nMB0E6+Vs2WqsxUFk6fQRCsEEl0PhWtlJXYKT1JM4sWqh2zYCujI+imydWAt
i/iAhmzPIaJLU6tU+v5Jh+z12A3Dswgv4hQ4PYYYqxidzwFWScluRUapcBpNaZl9
7lYld5EUL90GlcQEW+GJdGnQ98f8dgT5iLfWoMVlK7Z8Yfwm8cZMSU0giW64TcBQ
Xhe/JyQzc4Fol8xzM51/12LgXb2uTvuNv21tyOKNTmCWsWRK8DxyEiX1avOe9H4N
IhlcZdg9/DSfKTT7Bk6FtNx5Ct2c18tE1IKd9YRBZ8fsyio6iCm7p8UIxvkqkGda
BNScxn3hwZFia/4FBaKG2tAEw0KF3Q+ExbalYElSn7qBToRs7SFQ1n8HO1fnsVfA
mpp805V4w03IvMvN61pbKQjjWJMykzM9mAtNd6oORhjsMewGT20=
=cwRT
-END PGP SIGNATURE-

Changes since co-22.05-branch-point-1:
---
 0 files changed
---

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/libreoffice-7.3.1.3'

2022-02-28 Thread Christian Lohmaier (via logerrit)

Tag 'libreoffice-7.3.1.3' created by Christian Lohmaier 
 at 2022-02-28 18:19 +

Tag libreoffice-7.3.1.3
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmIdEjsACgkQ9DSh76/u
rqP7phAApzeNKjBwGGJRlOkw35P1h6zzd2F7OGAUf832i7oO9MVAt7VlLTSfEJEt
xkrpW59fdjVu7hklhq2f21Eu7mVlg1/ytq7rAIvjeUvPVuytGh/9hkMIvl+vQDkx
eQ3hTxzQsnCF9X/+gWPwNaHNRqybUlyjUPeyQCNY6aAHio+TekK3hLXwXBOa0HGQ
fvt57Ob+5BoECi4Mu1boLgZKErcnwjeYp/B584ib2YstErPHwwG3XK8Qo1q+w2If
iM9J6xRr1zWg1eKM0Lhufv2RfrizH2g0eDsy6f+v2jPBhCr21+c0BeOF40FggRBJ
dT5rkA61/YYoqALpDzLIZ5FREESfri7ykCF52/iZQlkPaMrORJY85wpUv0HLPTdd
/jRk9lmLykhxfMJGsP2RjAISURRyafAF4nnQ7lCTitz/FABjwy06QwrgvIRCO1XB
bkrQIvSvF1KXzS9xuMTUJ2nLjkDfSf91m6ZALXF7h4KapL3fKnVnM7QEUv+mcLfv
T+w+z5+EtIAOU75yCBhFj/+x3dOFz2a2fz27qdzOlHFpk7iqYvQrW5l4wo7bvIX/
ig7u3jCJ3lt8UiNyQSJTU9UpD7ldSybFIX+dwxS998f/Vvm9QTKf8O8HcRMzsckL
GqWlpcMNl5I3bGFRGqIZbUT7dk5/wylXcUgVJHtvN+9k4vtN3bI=
=746O
-END PGP SIGNATURE-

Changes since co-22.05-branch-point-1:
---
 0 files changed
---

[Libreoffice-commits] core.git: Changes to 'refs/tags/libreoffice-7.3.1.3'

2022-02-28 Thread Christian Lohmaier (via logerrit)

Tag 'libreoffice-7.3.1.3' created by Christian Lohmaier 
 at 2022-02-28 18:19 +

Tag libreoffice-7.3.1.3
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmIdEj8ACgkQ9DSh76/u
rqNYEg/7B2+wY/VIB4BRpj7mRlWT3hWRrf+EU+/C6Vl5WUxOP9seFvaB3xIT+XAU
eukysb+gHK+p1QQ2JK00guTu/yrMuZSRaBz+VZSsfI92rErZPdi9sA/bimzT3XdJ
q44i6dt68TGZsCsaDUAvQCwu6i3JZOsXih12mqB5XJ0cQIuhDVgez1JQckednu9S
B0eMRgI2kRclWYc70ruVSFiNJmhlPw5Ogu/NKZhYSb314U9Nk5l4j1KC2+c5pbgz
QdindP8fYsqcwTzc0dkjTGy2YCd4CzzMgp5xq2CZxhBJD60o2iW2q8DVEynVJ00t
TjUOFLy2h7DWAxRL2mHRqXFHEEYB2Vq3ZmuexH4FGM7O4bDOrWK2mP1/+umezc13
q+j+HOGo44Z+K3ebROMXdKRfiS/auRMdKlzeqdfwEwJuIK8vjcvtQP/NgOr+AHo9
KjNYS/rC7G0KRk6T5PiLqYnB+XAp+Sf/t5eD4OG/PVGh80U96IM4VftwafGFDD72
WkmNw1KxGIPc7m4gUpVRLEZLTpYEnSvd5sQ9Nj2hjM8o1agjDkNzWl7mmSHdPrF4
W396kGA4LFredMWHVmhFipU3Rwv97sFRUn7R2ptpAVa1mmvjfJY/HtimtRsmfYIp
bNCG/+4Z5yj01YcIt2vcPawsZYtgUXm1RanyJ0T0CACFM4P7bKA=
=0mYY
-END PGP SIGNATURE-

Changes since co-22.05-branch-point-77:
---
 0 files changed
---

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3-1' - configure.ac

2022-02-28 Thread Christian Lohmaier (via logerrit)

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 102ed19179b3200956e319e8249f3f0238610cf8
Author: Christian Lohmaier 
AuthorDate: Mon Feb 28 19:20:10 2022 +0100
Commit: Christian Lohmaier 
CommitDate: Mon Feb 28 19:20:10 2022 +0100

bump product version to 7.3.1.3.0+

Change-Id: I5eb53886fd2301e832d73fe5f35646edf90f23f2

diff --git a/configure.ac b/configure.ac
index 0a20c2c26c31..c7085b5fc33d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[7.3.1.2.0+],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[7.3.1.3.0+],[],[],[http://documentfoundation.org/])
 
 dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just 
fine if it is installed
 dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails 
hard

[Libreoffice-commits] core.git: sc/qa sc/source

2022-02-28 Thread Justin Luth (via logerrit)

 sc/qa/unit/data/xlsb/pivottable_error_item_filter.xlsb |binary
 sc/qa/unit/data/xlsx/tdf122471.xlsx|binary
 sc/qa/unit/pivottable_filters_test.cxx |   56 +
 sc/source/filter/inc/pivotcachebuffer.hxx  |2 
 sc/source/filter/oox/pivotcachebuffer.cxx  |   10 +--
 sc/source/filter/oox/pivotcachefragment.cxx|2 
 6 files changed, 63 insertions(+), 7 deletions(-)

New commits:
commit 6961f6732954742415413fa53bdeebd1b03d9ec5
Author: Justin Luth 
AuthorDate: Mon Feb 28 15:36:08 2022 +0200
Commit: Justin Luth 
CommitDate: Mon Feb 28 19:17:53 2022 +0100

tdf#122471 xlsx import: pivottable error OUString, not uInt8

This fixes a LO 6.0 regression from
commit 9fa34e9f2cebe2cfc551668f2a67ddcb799d3fb8
which only half-way changed to OUString from uInt8.

An exception was raised because in XLSX, an INT was written
while the corresponding read function was expecting an OUString.

However, doing this runs into problems with binary files (xlsb),
which were still setting the value to an int.
Unit test shows the need to use OUString for xlsb too,
which now matches what I see in Excel 2003.

make CppunitTest_sc_pivottable_filters_test \
  CPPUNIT_TEST_NAME=testPivotTableErrorItem2FilterXLSX

Change-Id: I399c9e34984bb1ff71695a87aa56f53063d37b3d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130714
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/sc/qa/unit/data/xlsb/pivottable_error_item_filter.xlsb 
b/sc/qa/unit/data/xlsb/pivottable_error_item_filter.xlsb
new file mode 100644
index ..c32b8f3743e6
Binary files /dev/null and 
b/sc/qa/unit/data/xlsb/pivottable_error_item_filter.xlsb differ
diff --git a/sc/qa/unit/data/xlsx/tdf122471.xlsx 
b/sc/qa/unit/data/xlsx/tdf122471.xlsx
new file mode 100644
index ..febac5c73506
Binary files /dev/null and b/sc/qa/unit/data/xlsx/tdf122471.xlsx differ
diff --git a/sc/qa/unit/pivottable_filters_test.cxx 
b/sc/qa/unit/pivottable_filters_test.cxx
index 36aa697b5071..14f790e89b68 100644
--- a/sc/qa/unit/pivottable_filters_test.cxx
+++ b/sc/qa/unit/pivottable_filters_test.cxx
@@ -79,6 +79,8 @@ public:
 void testPivotTableBoolFieldFilterXLSX();
 void testPivotTableRowColPageFieldFilterXLSX();
 void testPivotTableErrorItemFilterXLSX();
+void testPivotTableErrorItemFilterXLSB();
+void testPivotTableErrorItem2FilterXLSX();
 void testPivotTableOutlineModeXLSX();
 void testPivotTableDuplicatedMemberFilterXLSX();
 void testPivotTableTabularModeXLSX();
@@ -130,6 +132,8 @@ public:
 CPPUNIT_TEST(testPivotTableBoolFieldFilterXLSX);
 CPPUNIT_TEST(testPivotTableRowColPageFieldFilterXLSX);
 CPPUNIT_TEST(testPivotTableErrorItemFilterXLSX);
+CPPUNIT_TEST(testPivotTableErrorItemFilterXLSB);
+CPPUNIT_TEST(testPivotTableErrorItem2FilterXLSX);
 CPPUNIT_TEST(testPivotTableOutlineModeXLSX);
 CPPUNIT_TEST(testPivotTableDuplicatedMemberFilterXLSX);
 CPPUNIT_TEST(testPivotTableTabularModeXLSX);
@@ -2365,6 +2369,58 @@ void 
ScPivotTableFiltersTest::testPivotTableErrorItemFilterXLSX()
 xDocSh->DoClose();
 }
 
+void ScPivotTableFiltersTest::testPivotTableErrorItemFilterXLSB()
+{
+ScDocShellRef xDocSh = loadDoc(u"pivottable_error_item_filter.", 
FORMAT_XLSB);
+CPPUNIT_ASSERT_MESSAGE("Failed to load file", xDocSh.is());
+ScDocument& rDoc = xDocSh->GetDocument();
+ScDPCollection* pDPs = rDoc.GetDPCollection();
+CPPUNIT_ASSERT_EQUAL(static_cast(1), pDPs->GetCount());
+const ScDPObject* pDPObj = &(*pDPs)[0];
+CPPUNIT_ASSERT(pDPObj);
+ScDPSaveData* pSaveData = pDPObj->GetSaveData();
+CPPUNIT_ASSERT(pSaveData);
+
+ScDPSaveDimension* pSaveDim = pSaveData->GetExistingDimensionByName(u"b");
+CPPUNIT_ASSERT(pSaveDim);
+const ScDPSaveDimension::MemberList& rMembers = pSaveDim->GetMembers();
+CPPUNIT_ASSERT_EQUAL(size_t(4), rMembers.size());
+ScDPSaveMember* pMember = pSaveDim->GetExistingMemberByName("#DIV/0!");
+CPPUNIT_ASSERT(pMember);
+CPPUNIT_ASSERT(pMember->HasIsVisible());
+CPPUNIT_ASSERT(!pMember->GetIsVisible());
+
+xDocSh->DoClose();
+}
+
+void ScPivotTableFiltersTest::testPivotTableErrorItem2FilterXLSX()
+{
+ScDocShellRef xDocSh = loadDoc(u"tdf122471.", FORMAT_XLSX);
+CPPUNIT_ASSERT_MESSAGE("Failed to load file", xDocSh.is());
+ScDocument& rDoc = xDocSh->GetDocument();
+ScDPCollection* pDPs = rDoc.GetDPCollection();
+CPPUNIT_ASSERT_EQUAL(static_cast(1), pDPs->GetCount());
+
+// Reload and check whether filtering is preserved
+xDocSh = saveAndReload(*xDocSh, FORMAT_XLSX);
+CPPUNIT_ASSERT_MESSAGE("Failed to load file", xDocSh.is());
+ScDocument& rLoadedDoc = xDocSh->GetDocument();
+pDPs = rLoadedDoc.GetDPCollection();
+CPPUNIT_ASSERT_EQUAL(static_cast(1), pDPs->GetCount());
+const ScDPObject* pDPObj = &(*pDPs)[0];
+

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3-1' - shell/source

2022-02-28 Thread Caolán McNamara (via logerrit)

 shell/source/win32/SysShExec.cxx |8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

New commits:
commit fdb80b1c6280410223b10b4f38f7e137730380d4
Author: Caolán McNamara 
AuthorDate: Tue Feb 22 09:41:26 2022 +
Commit: Christian Lohmaier 
CommitDate: Mon Feb 28 19:16:13 2022 +0100

add to suffix denylist

mostly https: 
//support.google.com/mail/answer/6590?hl=en#zippy=%2Cmessages-that-have-attachments

but see also:

https://www.howtogeek.com/137270/50-file-extensions-that-are-potentially-dangerous-on-windows

Change-Id: Ibe3abbdcdb6f82a73d245318ef97d86789d00523
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130394
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130383
Reviewed-by: Xisco Fauli 
Reviewed-by: Christian Lohmaier 
Tested-by: Christian Lohmaier 

diff --git a/shell/source/win32/SysShExec.cxx b/shell/source/win32/SysShExec.cxx
index ba8dc4e8a3ae..d01c01f839ea 100644
--- a/shell/source/win32/SysShExec.cxx
+++ b/shell/source/win32/SysShExec.cxx
@@ -343,8 +343,12 @@ void SAL_CALL CSysShExec::execute( const OUString& 
aCommand, const OUString& aPa
 if (!(checkExtension(ext, env)
   && checkExtension(
   ext,
-  
".COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC;.MSI;.PY;.CLASS;"
-  ".JAR;.APPLICATION;.LNK;.SCR")))
+  
".ADE;.ADP;.APK;.APPLICATION;.APPX;.APPXBUNDLE;.BAT;.CAB;.CHM;.CLASS;"
+  
".CMD;.COM;.CPL;.DLL;.DMG;.EX;.EX_;.EXE;.GADGET;.HTA;.INF;.INS;.IPA;"
+  
".ISO;.ISP;.JAR;.JS;.JSE;.LIB;.LNK;.MDE;.MSC;.MSH;.MSH1;.MSH2;.MSHXML;"
+  
".MSH1XML;.MSH2XML;.MSI;.MSIX;.MSIXBUNDLE;.MSP;.MST;.NSH;.PIF;.PS1;"
+  
".PS1XML;.PS2;.PS2XML;.PSC1;.PSC2;.PY;.REG;.SCF;.SCR;.SCT;.SHB;.SYS;"
+  ".VB;.VBE;.VBS;.VXD;.WS;.WSC;.WSF;.WSH;")))
 {
 throw css::lang::IllegalArgumentException(
 "XSystemShellExecute.execute, cannot process <" + 
aCommand + ">", {},

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3-1' - shell/source

2022-02-28 Thread Caolán McNamara (via logerrit)

 shell/source/unix/exec/shellexec.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 3bddf099072befe18cf07f400ff14fef077b
Author: Caolán McNamara 
AuthorDate: Tue Feb 22 20:38:55 2022 +
Commit: Christian Lohmaier 
CommitDate: Mon Feb 28 19:15:38 2022 +0100

add to suffix denylist

add the macOS specific suffixes from
https: 
//support.google.com/mail/answer/6590?hl=en#zippy=%2Cmessages-that-have-attachments

Change-Id: I3a834694e3aefb757974cd00ade009874c68c8b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130397
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
(cherry picked from commit 3e67678af2f6f8f7d25c5ad67b3828e96bc293b8)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130449
Reviewed-by: Michael Stahl 
(cherry picked from commit 2004067d2d3f9728770eac8f99a8835d230ffb0a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130452
Reviewed-by: Xisco Fauli 
Reviewed-by: Christian Lohmaier 
Tested-by: Christian Lohmaier 

diff --git a/shell/source/unix/exec/shellexec.cxx 
b/shell/source/unix/exec/shellexec.cxx
index 2535fbb18e7f..d9da11334a64 100644
--- a/shell/source/unix/exec/shellexec.cxx
+++ b/shell/source/unix/exec/shellexec.cxx
@@ -136,8 +136,10 @@ void SAL_CALL ShellExec::execute( const OUString& 
aCommand, const OUString& aPar
 throw css::lang::IllegalArgumentException(
 "XSystemShellExecute.execute, cannot process <" + aCommand 
+ ">", {}, 0);
 } else if (pathname.endsWithIgnoreAsciiCase(".class")
+   || pathname.endsWithIgnoreAsciiCase(".dmg")
|| pathname.endsWithIgnoreAsciiCase(".fileloc")
|| pathname.endsWithIgnoreAsciiCase(".inetloc")
+   || pathname.endsWithIgnoreAsciiCase(".ipa")
|| pathname.endsWithIgnoreAsciiCase(".jar")
|| pathname.endsWithIgnoreAsciiCase(".terminal"))
 {

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3-1' - translations

2022-02-28 Thread Christian Lohmaier (via logerrit)

 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 92ecfad8210c3c769a31a62a25a667dd0c8ecf8a
Author: Christian Lohmaier 
AuthorDate: Mon Feb 28 19:06:51 2022 +0100
Commit: Gerrit Code Review 
CommitDate: Mon Feb 28 19:06:51 2022 +0100

Update git submodules

* Update translations from branch 'libreoffice-7-3-1'
  to 58047d0be2e5d50a4c38b245c6692628e77728e9
  - update translations for 7.3.1 rc3

and force-fix errors using pocheck

Change-Id: I41de399ba9bbdc8157aa5c04a76f1845d974fc8a
(cherry picked from commit 1dab7b297f1b7c2c2ab834239fc40961f60b70e3)

diff --git a/translations b/translations
index a19b043323a0..58047d0be2e5 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit a19b043323a0187ac0903415305f1ba177ff827d
+Subproject commit 58047d0be2e5d50a4c38b245c6692628e77728e9

[Libreoffice-commits] translations.git: Branch 'libreoffice-7-3-1' - source/an source/ar source/ast source/bg source/ca source/cs source/de source/es source/fa source/fi source/gl source/gug source/ja

2022-02-28 Thread Christian Lohmaier (via logerrit)

 source/an/sc/messages.po|  
  4 
 source/an/sw/messages.po|  
  5 
 source/ar/basctl/messages.po|  
 50 -
 source/ar/chart2/messages.po|  
 16 
 source/ar/cui/messages.po   |  
167 +--
 source/ar/dbaccess/messages.po  |  
 24 
 source/ar/desktop/messages.po   |  
  4 
 source/ar/dictionaries/en/dialog.po |  
  8 
 source/ar/dictionaries/pt_BR/dialog.po  |  
 12 
 source/ar/dictionaries/ru_RU/dialog.po  |  
  6 
 source/ar/editeng/messages.po   |  
 48 -
 source/ar/extensions/messages.po|  
 30 
 source/ar/extras/source/autocorr/emoji.po   |  
 10 
 source/ar/filter/messages.po|  
 14 
 source/ar/forms/messages.po |  
  4 
 source/ar/formula/messages.po   |  
  4 
 source/ar/framework/messages.po |  
  6 
 source/ar/instsetoo_native/inc_openoffice/windows/msi_languages.po  |  
 36 
 source/ar/librelogo/source/pythonpath.po|  
  4 
 source/ar/officecfg/registry/data/org/openoffice/Office.po  |  
 14 
 source/ar/officecfg/registry/data/org/openoffice/Office/UI.po   |  
191 ++--
 source/ar/reportdesign/messages.po  |  
  5 
 source/ar/sc/messages.po|  
267 ++---
 source/ar/sd/messages.po|  
 60 -
 source/ar/sfx2/classification.po|  
 14 
 source/ar/sfx2/messages.po  |  
 42 
 source/ar/shell/source/win32/shlxthandler/res.po|  
  6 
 source/ar/starmath/messages.po  |  
 16 
 source/ar/svtools/messages.po   |  
 55 -
 source/ar/svx/messages.po   |  
198 +---
 source/ar/sw/messages.po|  
281 ++
 source/ar/swext/mediawiki/help.po   |  
 16 
 source/ar/swext/mediawiki/src/registry/data/org/openoffice/Office/Custom.po |  
 10 
 source/ar/vcl/messages.po   |  
 96 +-
 source/ar/wizards/messages.po   |  
  6 
 source/ar/wizards/source/resources.po   |  
  6 
 source/ar/writerperfect/messages.po |  
  6 
 source/ar/xmlsecurity/messages.po   |  
  4 
 source/ast/cui/messages.po  |  
  4 
 source/ast/helpcontent2/source/text/sbasic/shared.po|  
  4 
 source/ast/helpcontent2/source/text/scalc/01.po |  
 14 
 source/ast/officecfg/registry/data/org/openoffice/Office/UI.po  |  
  9 
 source/ast/sc/messages.po   |  
  6 
 source/ast/sd/messages.po   |  
  4 
 source/ast/setup_native/source/mac.po   |  
 10 
 source/ast/starmath/messages.po |  
 26 
 source/ast/svx/messages.po  |  
  4 
 source/bg/officecfg/registry/data/org/openoffice/Office/UI.po   |  
  6 
 source/bg/starmath/messages.po  |  
  8 
 source/ca/cui/messages.po   |  
  4 
 source/ca/helpcontent2/source/text/sbasic/guide.po  |  
  6 
 source/ca/helpcontent2/source/text/sbasic/shared/03.po  |  
  6 
 source/ca/helpcontent2/source/text/scalc/01.po  |  
  6 
 source/ca/helpcontent2/source/text/shared/00.po |  
  6 
 source/ca/helpcontent2/source/text/swriter/guide.po |  
  6 
 source/ca/sc/messages.po|  
  4 
 source/cs/chart2/messages.po|  
 12 
 source/cs/connectivity/messages.po

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - desktop/inc desktop/source

2022-02-28 Thread Luboš Luňák (via logerrit)

 desktop/inc/lib/init.hxx|1 +
 desktop/source/lib/init.cxx |   19 +--
 2 files changed, 14 insertions(+), 6 deletions(-)

New commits:
commit a81e47aca7e7d21276f73be2859c85d3ea98b9b9
Author: Luboš Luňák 
AuthorDate: Fri Feb 25 12:22:16 2022 +0100
Commit: Luboš Luňák 
CommitDate: Mon Feb 28 19:06:20 2022 +0100

make sure that LOK "updated types" start a timer as well

273a25c796fca9afa0dfadac57dc3f336831221c changed the handling of LOK
messages to only set up an "updated" flag for types and then
when flushing the value is fetched. This means that queue() is not
called for such updates, and so the timeout to flush the messages
wasn't started.

Change-Id: I3a7324c86a55697f509f80b6c54cb949fb1daa72
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130460
Tested-by: Luboš Luňák 
Reviewed-by: Luboš Luňák 

diff --git a/desktop/inc/lib/init.hxx b/desktop/inc/lib/init.hxx
index 288fa8ebfcc0..6132a7a302cc 100644
--- a/desktop/inc/lib/init.hxx
+++ b/desktop/inc/lib/init.hxx
@@ -177,6 +177,7 @@ namespace desktop {
 typedef std::vector queue_type1;
 typedef std::vector queue_type2;
 
+void startTimer();
 bool removeAll(int type);
 bool removeAll(int type, const std::function& rTestFunc);
 bool processInvalidateTilesEvent(int type, CallbackData& 
aCallbackData);
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 91a4d80ca128..9720a7a78967 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -1397,6 +1397,8 @@ void CallbackFlushHandler::setUpdatedType( int nType, 
bool value )
 if( m_updatedTypes.size() <= o3tl::make_unsigned( nType ))
 m_updatedTypes.resize( nType + 1 ); // new are default-constructed, 
i.e. false
 m_updatedTypes[ nType ] = value;
+if(value)
+startTimer();
 }
 
 void CallbackFlushHandler::resetUpdatedType( int nType )
@@ -1411,6 +1413,8 @@ void CallbackFlushHandler::setUpdatedTypePerViewId( int 
nType, int nViewId, int
 if( types.size() <= o3tl::make_unsigned( nType ))
 types.resize( nType + 1 ); // new are default-constructed, i.e. 'set' 
is false
 types[ nType ] = PerViewIdData{ value, nSourceViewId };
+if(value)
+startTimer();
 }
 
 void CallbackFlushHandler::resetUpdatedTypePerViewId( int nType, int nViewId )
@@ -1735,12 +1739,7 @@ void CallbackFlushHandler::queue(const int type, 
CallbackData& aCallbackData)
 #endif
 
 lock.unlock();
-if (!IsActive())
-{
-Start();
-}
-if (!m_TimeoutIdle.IsActive())
-m_TimeoutIdle.Start();
+startTimer();
 }
 
 bool CallbackFlushHandler::processInvalidateTilesEvent(int type, CallbackData& 
aCallbackData)
@@ -2223,6 +,14 @@ void CallbackFlushHandler::Invoke()
 m_TimeoutIdle.Stop();
 }
 
+void CallbackFlushHandler::startTimer()
+{
+if (!IsActive())
+Start();
+if (!m_TimeoutIdle.IsActive())
+m_TimeoutIdle.Start();
+}
+
 bool CallbackFlushHandler::removeAll(int type)
 {
 bool bErased = false;

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - translations

2022-02-28 Thread Christian Lohmaier (via logerrit)

 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 16d6e78bf51f36752953d65adf844e372b3ac6b2
Author: Christian Lohmaier 
AuthorDate: Mon Feb 28 19:03:11 2022 +0100
Commit: Gerrit Code Review 
CommitDate: Mon Feb 28 19:03:11 2022 +0100

Update git submodules

* Update translations from branch 'libreoffice-7-3'
  to 1dab7b297f1b7c2c2ab834239fc40961f60b70e3
  - update translations for 7.3.1 rc3

and force-fix errors using pocheck

Change-Id: I41de399ba9bbdc8157aa5c04a76f1845d974fc8a

diff --git a/translations b/translations
index e32fb9dee61f..1dab7b297f1b 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit e32fb9dee61f405ded4fe47ea33c0272e91ae5a8
+Subproject commit 1dab7b297f1b7c2c2ab834239fc40961f60b70e3

[Libreoffice-commits] translations.git: Branch 'libreoffice-7-3' - source/an source/ar source/ast source/bg source/ca source/cs source/de source/es source/fa source/fi source/gl source/gug source/ja s

2022-02-28 Thread Christian Lohmaier (via logerrit)

 source/an/sc/messages.po|  
  4 
 source/an/sw/messages.po|  
  5 
 source/ar/basctl/messages.po|  
 50 -
 source/ar/chart2/messages.po|  
 16 
 source/ar/cui/messages.po   |  
167 +--
 source/ar/dbaccess/messages.po  |  
 24 
 source/ar/desktop/messages.po   |  
  4 
 source/ar/dictionaries/en/dialog.po |  
  8 
 source/ar/dictionaries/pt_BR/dialog.po  |  
 12 
 source/ar/dictionaries/ru_RU/dialog.po  |  
  6 
 source/ar/editeng/messages.po   |  
 48 -
 source/ar/extensions/messages.po|  
 30 
 source/ar/extras/source/autocorr/emoji.po   |  
 10 
 source/ar/filter/messages.po|  
 14 
 source/ar/forms/messages.po |  
  4 
 source/ar/formula/messages.po   |  
  4 
 source/ar/framework/messages.po |  
  6 
 source/ar/instsetoo_native/inc_openoffice/windows/msi_languages.po  |  
 36 
 source/ar/librelogo/source/pythonpath.po|  
  4 
 source/ar/officecfg/registry/data/org/openoffice/Office.po  |  
 14 
 source/ar/officecfg/registry/data/org/openoffice/Office/UI.po   |  
191 ++--
 source/ar/reportdesign/messages.po  |  
  5 
 source/ar/sc/messages.po|  
267 ++---
 source/ar/sd/messages.po|  
 60 -
 source/ar/sfx2/classification.po|  
 14 
 source/ar/sfx2/messages.po  |  
 42 
 source/ar/shell/source/win32/shlxthandler/res.po|  
  6 
 source/ar/starmath/messages.po  |  
 16 
 source/ar/svtools/messages.po   |  
 55 -
 source/ar/svx/messages.po   |  
198 +---
 source/ar/sw/messages.po|  
281 ++
 source/ar/swext/mediawiki/help.po   |  
 16 
 source/ar/swext/mediawiki/src/registry/data/org/openoffice/Office/Custom.po |  
 10 
 source/ar/vcl/messages.po   |  
 96 +-
 source/ar/wizards/messages.po   |  
  6 
 source/ar/wizards/source/resources.po   |  
  6 
 source/ar/writerperfect/messages.po |  
  6 
 source/ar/xmlsecurity/messages.po   |  
  4 
 source/ast/cui/messages.po  |  
  4 
 source/ast/helpcontent2/source/text/sbasic/shared.po|  
  4 
 source/ast/helpcontent2/source/text/scalc/01.po |  
 14 
 source/ast/officecfg/registry/data/org/openoffice/Office/UI.po  |  
  9 
 source/ast/sc/messages.po   |  
  6 
 source/ast/sd/messages.po   |  
  4 
 source/ast/setup_native/source/mac.po   |  
 10 
 source/ast/starmath/messages.po |  
 26 
 source/ast/svx/messages.po  |  
  4 
 source/bg/officecfg/registry/data/org/openoffice/Office/UI.po   |  
  6 
 source/bg/starmath/messages.po  |  
  8 
 source/ca/cui/messages.po   |  
  4 
 source/ca/helpcontent2/source/text/sbasic/guide.po  |  
  6 
 source/ca/helpcontent2/source/text/sbasic/shared/03.po  |  
  6 
 source/ca/helpcontent2/source/text/scalc/01.po  |  
  6 
 source/ca/helpcontent2/source/text/shared/00.po |  
  6 
 source/ca/helpcontent2/source/text/swriter/guide.po |  
  6 
 source/ca/sc/messages.po|  
  4 
 source/cs/chart2/messages.po|  
 12 
 source/cs/connectivity/messages.po

[Libreoffice-commits] core.git: filter/qa include/unotest unotest/Library_unotest.mk unotest/source vcl/qa

2022-02-28 Thread Mike Kaganski (via logerrit)

 filter/qa/pdf.cxx   |2 +-
 include/unotest/macros_test.hxx |8 
 unotest/Library_unotest.mk  |1 +
 unotest/source/cpp/macros_test.cxx  |   14 ++
 vcl/qa/cppunit/filter/ipdf/ipdf.cxx |   10 +-
 5 files changed, 29 insertions(+), 6 deletions(-)

New commits:
commit ff49a550df626a4b02869b86f1ca9b9a5a421e44
Author: Mike Kaganski 
AuthorDate: Mon Feb 28 13:59:05 2022 +0300
Commit: Mike Kaganski 
CommitDate: Mon Feb 28 18:44:33 2022 +0100

Fix the tests failing when invalid certificate is in cert store

Change-Id: I72055c814a11a76c4934610bcad9c24aae21164e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130690
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/filter/qa/pdf.cxx b/filter/qa/pdf.cxx
index 8eb64b08cc7a..ddf6c3bce066 100644
--- a/filter/qa/pdf.cxx
+++ b/filter/qa/pdf.cxx
@@ -65,7 +65,7 @@ CPPUNIT_TEST_FIXTURE(Test, testSignCertificateSubjectName)
 = xSEInitializer->createSecurityContext(OUString());
 uno::Reference xSecurityEnvironment
 = xSecurityContext->getSecurityEnvironment();
-if (!xSecurityEnvironment->getPersonalCertificates().hasElements())
+if (!GetValidCertificate(xSecurityEnvironment->getPersonalCertificates()))
 {
 return;
 }
diff --git a/include/unotest/macros_test.hxx b/include/unotest/macros_test.hxx
index ed879b835a55..c6c810ad108b 100644
--- a/include/unotest/macros_test.hxx
+++ b/include/unotest/macros_test.hxx
@@ -39,6 +39,11 @@ namespace utl
 class TempFile;
 }
 
+namespace com::sun::star::security
+{
+class XCertificate;
+}
+
 namespace unotest
 {
 class OOO_DLLPUBLIC_UNOTEST MacrosTest
@@ -88,6 +93,9 @@ public:
 void setUpNssGpg(const test::Directories& rDirectories, const OUString& 
rTestName);
 void tearDownNssGpg();
 
+static css::uno::Reference 
GetValidCertificate(
+const 
css::uno::Sequence>& certs);
+
 protected:
 css::uno::Reference mxDesktop;
 
diff --git a/unotest/Library_unotest.mk b/unotest/Library_unotest.mk
index 3acfe2f69ed9..1a7f8ba5ab5f 100644
--- a/unotest/Library_unotest.mk
+++ b/unotest/Library_unotest.mk
@@ -22,6 +22,7 @@ $(eval $(call gb_Library_use_libraries,unotest,\
cppuhelper \
sal \
sb \
+   tl \
utl \
 ))
 
diff --git a/unotest/source/cpp/macros_test.cxx 
b/unotest/source/cpp/macros_test.cxx
index 718c0b1b8954..81738dc6dafe 100644
--- a/unotest/source/cpp/macros_test.cxx
+++ b/unotest/source/cpp/macros_test.cxx
@@ -15,6 +15,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -24,6 +25,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
@@ -169,6 +171,18 @@ void MacrosTest::tearDownNssGpg()
 (void)this;
 #endif
 }
+
+css::uno::Reference 
MacrosTest::GetValidCertificate(
+const 
css::uno::Sequence>& certs)
+{
+auto it
+= std::find_if(certs.begin(), certs.end(), [now = 
DateTime(DateTime::SYSTEM)](auto& xCert) {
+  return now.IsBetween(xCert->getNotValidBefore(), 
xCert->getNotValidAfter());
+  });
+if (it != certs.end())
+return *it;
+return {};
+}
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/qa/cppunit/filter/ipdf/ipdf.cxx 
b/vcl/qa/cppunit/filter/ipdf/ipdf.cxx
index 8ed49813e88b..a2732b58d862 100644
--- a/vcl/qa/cppunit/filter/ipdf/ipdf.cxx
+++ b/vcl/qa/cppunit/filter/ipdf/ipdf.cxx
@@ -115,17 +115,17 @@ CPPUNIT_TEST_FIXTURE(VclFilterIpdfTest, 
testPDFAddVisibleSignatureLastPage)
 uno::Reference 
xSelectionSupplier(pBaseModel->getCurrentController(),
 
uno::UNO_QUERY);
 xSelectionSupplier->select(uno::makeAny(xShape));
-uno::Sequence> aCertificates
-= 
getSecurityContext()->getSecurityEnvironment()->getPersonalCertificates();
-if (!aCertificates.hasElements())
+auto xCert = GetValidCertificate(
+
getSecurityContext()->getSecurityEnvironment()->getPersonalCertificates());
+if (!xCert)
 {
 return;
 }
 SdrView* pView = SfxViewShell::Current()->GetDrawView();
-svx::SignatureLineHelper::setShapeCertificate(pView, aCertificates[0]);
+svx::SignatureLineHelper::setShapeCertificate(pView, xCert);
 
 // When: do the actual signing.
-pObjectShell->SignDocumentContentUsingCertificate(aCertificates[0]);
+pObjectShell->SignDocumentContentUsingCertificate(xCert);
 
 // Then: count the # of shapes on the signature widget/annotation.
 std::shared_ptr pPDFium = vcl::pdf::PDFiumLibrary::get();

[Libreoffice-bugs] [Bug 38669] Typing an accented letter when focus on a figure, display another character

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=38669

Andreas Heinisch  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |andreas.heini...@yahoo.de
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3-1' - sc/inc sc/source

2022-02-28 Thread Kohei Yoshida (via logerrit)

 sc/inc/mtvelements.hxx  |2 ++
 sc/source/core/data/column.cxx  |1 +
 sc/source/core/data/mtvelements.cxx |5 +
 3 files changed, 8 insertions(+)

New commits:
commit 1c3c72bf20914b13960508ec337de96f82b8225b
Author: Kohei Yoshida 
AuthorDate: Thu Feb 24 21:06:50 2022 -0500
Commit: Christian Lohmaier 
CommitDate: Mon Feb 28 18:33:41 2022 +0100

tdf#147298: When swapping the cell stores, swap back the event handlers.

Swapping the cell stores also swap the event handlers stored therein.
But we do want the event handlers to stay with the original column
instances as they store pointers to their host column instances.

Change-Id: Id35b89db641e94dbaa341b33d0b64dce19a99465
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130510
Reviewed-by: Kohei Yoshida 
Tested-by: Kohei Yoshida 
(cherry picked from commit 8f25d42938977b34f3281238a92fb34ebea5838c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130464
Tested-by: Jenkins
(cherry picked from commit 7d64ec7d342da64e050ed9ac326b1af33d5c6955)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130571
Reviewed-by: Eike Rathke 
Reviewed-by: Kevin Suo 
Reviewed-by: Christian Lohmaier 
Tested-by: Christian Lohmaier 

diff --git a/sc/inc/mtvelements.hxx b/sc/inc/mtvelements.hxx
index 05a0970bd64d..75cdea9483bd 100644
--- a/sc/inc/mtvelements.hxx
+++ b/sc/inc/mtvelements.hxx
@@ -98,6 +98,8 @@ public:
 
 /** Stop processing events. */
 void stop();
+
+void swap(CellStoreEvent& other);
 };
 
 struct CellStoreTrait
diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx
index 20cfc194b8b4..9d5643073f70 100644
--- a/sc/source/core/data/column.cxx
+++ b/sc/source/core/data/column.cxx
@@ -1970,6 +1970,7 @@ void ScColumn::SwapCol(ScColumn& rCol)
 maCellNotes.swap(rCol.maCellNotes);
 
 // Swap all CellStoreEvent mdds event_func related.
+maCells.event_handler().swap(rCol.maCells.event_handler());
 std::swap( mnBlkCountFormula, rCol.mnBlkCountFormula);
 
 // notes update caption
diff --git a/sc/source/core/data/mtvelements.cxx 
b/sc/source/core/data/mtvelements.cxx
index ee6c9cf1499c..a06e86dcae16 100644
--- a/sc/source/core/data/mtvelements.cxx
+++ b/sc/source/core/data/mtvelements.cxx
@@ -56,6 +56,11 @@ void CellStoreEvent::stop()
 mpCol = nullptr;
 }
 
+void CellStoreEvent::swap(CellStoreEvent& other)
+{
+std::swap(mpCol, other.mpCol);
+}
+
 ColumnBlockPositionSet::ColumnBlockPositionSet(ScDocument& rDoc) : mrDoc(rDoc) 
{}
 
 ColumnBlockPosition* ColumnBlockPositionSet::getBlockPosition(SCTAB nTab, 
SCCOL nCol)

[Libreoffice-bugs] [Bug 147701] New: Bug report bug

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147701

Bug ID: 147701
   Summary: Bug report bug
   Product: LibreOffice
   Version: 7.3.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: erndo...@cox.net

Description:
This is not intended to be a bug, but might be. 
I wanted to suggest that empty boxes be added to the list of bulleted list
characters, so that a to do list could be made that can be checked off as
needed.
However, when I clicked on "File an Enhancement Request" I was sent to
Bugzilla.
Please relay my request to the correct recipient.


Actual Results:
This is not intended to be a bug, but might be. 
I wanted to suggest that empty boxes be added to the list of bulleted list
characters, so that a to do list could be made that can be checked off as
needed.
However, when I clicked on "File an Enhancement Request" I was sent to
Bugzilla.
Please relay my request to the correct recipient.


Expected Results:
This is not intended to be a bug, but might be. 
I wanted to suggest that empty boxes be added to the list of bulleted list
characters, so that a to do list could be made that can be checked off as
needed.
However, when I clicked on "File an Enhancement Request" I was sent to
Bugzilla.
Please relay my request to the correct recipient.



Reproducible: Always


User Profile Reset: No



Additional Info:
This is not intended to be a bug, but might be. 
I wanted to suggest that empty boxes be added to the list of bulleted list
characters, so that a to do list could be made that can be checked off as
needed.
However, when I clicked on "File an Enhancement Request" I was sent to
Bugzilla.
Please relay my request to the correct recipient.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: jurt/source

2022-02-28 Thread Stephan Bergmann (via logerrit)

 jurt/source/pipe/staticsalhack.cxx |   10 --
 1 file changed, 8 insertions(+), 2 deletions(-)

New commits:
commit 0694a66e8e5ad3c83f28a093add009ecc37d500b
Author: Stephan Bergmann 
AuthorDate: Mon Feb 28 14:10:55 2022 +0100
Commit: Stephan Bergmann 
CommitDate: Mon Feb 28 18:11:23 2022 +0100

Fix jurt/source/pipe/staticsalhack.cxx

> jurt/source/pipe/staticsalhack.cxx:62:
> sal/rtl/ustrbuf.cxx:29:9: error: 'RTL_LOG_STRING_BITS' macro redefined 
[-Werror,-Wmacro-redefined]
> #define RTL_LOG_STRING_BITS 16
> ^
> sal/rtl/strbuf.cxx:27:9: note: previous definition is here
> #define RTL_LOG_STRING_BITS 8
> ^
> In file included from jurt/source/pipe/staticsalhack.cxx:62:
> sal/rtl/ustrbuf.cxx:29:9: error: duplicate defines 
[loplugin:duplicatedefines]
> #define RTL_LOG_STRING_BITS 16
> ^
> sal/rtl/strbuf.cxx:27:9: note: previous define [loplugin:duplicatedefines]
> #define RTL_LOG_STRING_BITS 8
> ^

after 22de5757a2c7c6cd4544a4699e5d4c69969f5961 "Deduplicate string buffer 
code"

Change-Id: I5e6883effea0ce53c96cb5da8e02142450216ad4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130711
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/jurt/source/pipe/staticsalhack.cxx 
b/jurt/source/pipe/staticsalhack.cxx
index 78a44bba6bb1..ac83bd84fb59 100644
--- a/jurt/source/pipe/staticsalhack.cxx
+++ b/jurt/source/pipe/staticsalhack.cxx
@@ -17,10 +17,18 @@
 
 #include 
 
+#include 
+#if USE_SDT_PROBES
+#undef RTL_LOG_STRING_BITS
+#endif
 #include 
 #if USE_SDT_PROBES
 #undef RTL_LOG_STRING_BITS
 #endif
+#include 
+#if USE_SDT_PROBES
+#undef RTL_LOG_STRING_BITS
+#endif
 #include 
 #if USE_SDT_PROBES
 #undef RTL_LOG_STRING_BITS
@@ -56,10 +64,8 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include

[Libreoffice-bugs] [Bug 147576] SLIDESHOW: Shapes get stretched in slideshow

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147576

--- Comment #11 from Armin Le Grand  ---
Created a version without the change in discussion. The context menu convert/to
metafile creates the same error, so the BoundRect is already wrong in that
version. But he Presentation works - have to check why, AFAIK
GraphicExporter::GetGraphic (where the change is) is not used by Presentation
preparations...?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - drawinglayer/source

2022-02-28 Thread Caolán McNamara (via logerrit)

 drawinglayer/source/tools/emfphelperdata.cxx |   36 +++
 1 file changed, 20 insertions(+), 16 deletions(-)

New commits:
commit 94f4152c0b5e77e3b4b2942cdb3450035fe4e9de
Author: Caolán McNamara 
AuthorDate: Mon Feb 28 09:45:55 2022 +
Commit: Michael Stahl 
CommitDate: Mon Feb 28 17:58:36 2022 +0100

check if cast is to the right type

LIBREOFFICE-311XVJ95

Change-Id: I159f516daafad3e4088677fe2c8c6f5423b3e264
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130669
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/drawinglayer/source/tools/emfphelperdata.cxx 
b/drawinglayer/source/tools/emfphelperdata.cxx
index d2d082424493..447686167837 100644
--- a/drawinglayer/source/tools/emfphelperdata.cxx
+++ b/drawinglayer/source/tools/emfphelperdata.cxx
@@ -459,7 +459,7 @@ namespace emfplushelper
 }
 else // we use a brush
 {
-const EMFPBrush* brush = 
static_cast(maEMFPObjects[brushIndexOrColor & 0xff].get());
+const EMFPBrush* brush = 
dynamic_cast(maEMFPObjects[brushIndexOrColor & 0xff].get());
 if (brush)
 {
 color = brush->GetColor();
@@ -735,7 +735,7 @@ namespace emfplushelper
 }
 else // use Brush
 {
-EMFPBrush* brush = static_cast( 
maEMFPObjects[brushIndexOrColor & 0xff].get() );
+EMFPBrush* brush = 
dynamic_cast(maEMFPObjects[brushIndexOrColor & 0xff].get());
 SAL_INFO("drawinglayer.emf", "EMF+\t\t Fill polygon, brush slot: " 
<< brushIndexOrColor << " (brush type: " << (brush ? brush->GetType() : -1) << 
")");
 
 // give up in case something wrong happened
@@ -1257,7 +1257,11 @@ namespace emfplushelper
 rMS.ReadUInt32(brushIndexOrColor);
 SAL_INFO("drawinglayer.emf", "EMF+\t FillRegion slot: 
" << index);
 
-
EMFPPlusFillPolygon(static_cast(maEMFPObjects[flags & 
0xff].get())->regionPolyPolygon, flags & 0x8000, brushIndexOrColor);
+EMFPRegion* region = 
dynamic_cast(maEMFPObjects[flags & 0xff].get());
+if (region)
+EMFPPlusFillPolygon(region->regionPolyPolygon, 
flags & 0x8000, brushIndexOrColor);
+else
+SAL_WARN("drawinglayer.emf", 
"EMF+\tEmfPlusRecordTypeFillRegion missing region");
 }
 break;
 case EmfPlusRecordTypeDrawEllipse:
@@ -1435,10 +1439,10 @@ namespace emfplushelper
 SAL_INFO("drawinglayer.emf", "EMF+\t TODO: use image 
attributes");
 
 // Source unit of measurement type must be 1 pixel
-if (sourceUnit == UnitTypePixel && maEMFPObjects[flags 
& 0xff])
+if (EMFPImage* image = sourceUnit == UnitTypePixel ?
+dynamic_cast(maEMFPObjects[flags & 
0xff].get()) :
+nullptr)
 {
-EMFPImage& image
-= *static_cast(maEMFPObjects[flags 
& 0xff].get());
 float sx, sy, sw, sh;
 ReadRectangle(rMS, sx, sy, sw, sh);
 
@@ -1488,9 +1492,9 @@ namespace emfplushelper
 SAL_INFO("drawinglayer.emf",
 "EMF+\t Rectangle: " << dx << "," << dy << 
" " << dw << "x" << dh);
 Size aSize;
-if (image.type == ImageDataTypeBitmap)
+if (image->type == ImageDataTypeBitmap)
 {
-aSize = 
image.graphic.GetBitmapEx().GetSizePixel();
+aSize = 
image->graphic.GetBitmapEx().GetSizePixel();
 SAL_INFO("drawinglayer.emf", "EMF+\t Bitmap 
size: " << aSize.Width()

 << "x"

 << aSize.Height());
@@ -1535,9 +1539,9 @@ namespace emfplushelper
 /* Row 1, Column 1 */ aDstSize.getY(),
 /* Row 1, Column 2 */ aDstPoint.getY());
 
-if (image.type == ImageDataTypeBitmap)
+if (image->type == ImageDataTypeBitmap)
 {
-BitmapEx aBmp(image.graphic.GetBitmapEx());
+BitmapEx aBmp(image->graphic.GetBitmapEx());
 aBmp.Crop(aSource);
 aSize = aBmp.GetSizePixel();
 if (aSize.Width() > 0 && aSize.Height() > 0)
@@ -1549,9 +1553,9 @@

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - drawinglayer/source

2022-02-28 Thread Caolán McNamara (via logerrit)

 drawinglayer/source/tools/emfphelperdata.cxx |   36 +++
 1 file changed, 20 insertions(+), 16 deletions(-)

New commits:
commit b44bd9ef8e2efdb66558917200e1f179b9db1c58
Author: Caolán McNamara 
AuthorDate: Mon Feb 28 09:45:55 2022 +
Commit: Michael Stahl 
CommitDate: Mon Feb 28 17:58:17 2022 +0100

check if cast is to the right type

LIBREOFFICE-311XVJ95

Change-Id: I159f516daafad3e4088677fe2c8c6f5423b3e264
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130670
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/drawinglayer/source/tools/emfphelperdata.cxx 
b/drawinglayer/source/tools/emfphelperdata.cxx
index 164237b043e3..cb1ee024c528 100644
--- a/drawinglayer/source/tools/emfphelperdata.cxx
+++ b/drawinglayer/source/tools/emfphelperdata.cxx
@@ -460,7 +460,7 @@ namespace emfplushelper
 }
 else // we use a brush
 {
-const EMFPBrush* brush = 
static_cast(maEMFPObjects[brushIndexOrColor & 0xff].get());
+const EMFPBrush* brush = 
dynamic_cast(maEMFPObjects[brushIndexOrColor & 0xff].get());
 if (brush)
 {
 color = brush->GetColor();
@@ -736,7 +736,7 @@ namespace emfplushelper
 }
 else // use Brush
 {
-EMFPBrush* brush = static_cast( 
maEMFPObjects[brushIndexOrColor & 0xff].get() );
+EMFPBrush* brush = 
dynamic_cast(maEMFPObjects[brushIndexOrColor & 0xff].get());
 SAL_INFO("drawinglayer.emf", "EMF+\t\t Fill polygon, brush slot: " 
<< brushIndexOrColor << " (brush type: " << (brush ? brush->GetType() : -1) << 
")");
 
 // give up in case something wrong happened
@@ -1263,7 +1263,11 @@ namespace emfplushelper
 rMS.ReadUInt32(brushIndexOrColor);
 SAL_INFO("drawinglayer.emf", "EMF+\t FillRegion slot: 
" << index);
 
-
EMFPPlusFillPolygon(static_cast(maEMFPObjects[flags & 
0xff].get())->regionPolyPolygon, flags & 0x8000, brushIndexOrColor);
+EMFPRegion* region = 
dynamic_cast(maEMFPObjects[flags & 0xff].get());
+if (region)
+EMFPPlusFillPolygon(region->regionPolyPolygon, 
flags & 0x8000, brushIndexOrColor);
+else
+SAL_WARN("drawinglayer.emf", 
"EMF+\tEmfPlusRecordTypeFillRegion missing region");
 }
 break;
 case EmfPlusRecordTypeDrawEllipse:
@@ -1442,10 +1446,10 @@ namespace emfplushelper
 SAL_INFO("drawinglayer.emf", "EMF+\t TODO: use image 
attributes");
 
 // Source unit of measurement type must be 1 pixel
-if (sourceUnit == UnitTypePixel && maEMFPObjects[flags 
& 0xff])
+if (EMFPImage* image = sourceUnit == UnitTypePixel ?
+dynamic_cast(maEMFPObjects[flags & 
0xff].get()) :
+nullptr)
 {
-EMFPImage& image
-= *static_cast(maEMFPObjects[flags 
& 0xff].get());
 float sx, sy, sw, sh;
 ReadRectangle(rMS, sx, sy, sw, sh);
 
@@ -1495,9 +1499,9 @@ namespace emfplushelper
 SAL_INFO("drawinglayer.emf",
 "EMF+\t Rectangle: " << dx << "," << dy << 
" " << dw << "x" << dh);
 Size aSize;
-if (image.type == ImageDataTypeBitmap)
+if (image->type == ImageDataTypeBitmap)
 {
-aSize = 
image.graphic.GetBitmapEx().GetSizePixel();
+aSize = 
image->graphic.GetBitmapEx().GetSizePixel();
 SAL_INFO("drawinglayer.emf", "EMF+\t Bitmap 
size: " << aSize.Width()

 << "x"

 << aSize.Height());
@@ -1542,9 +1546,9 @@ namespace emfplushelper
 /* Row 1, Column 1 */ aDstSize.getY(),
 /* Row 1, Column 2 */ aDstPoint.getY());
 
-if (image.type == ImageDataTypeBitmap)
+if (image->type == ImageDataTypeBitmap)
 {
-BitmapEx aBmp(image.graphic.GetBitmapEx());
+BitmapEx aBmp(image->graphic.GetBitmapEx());
 aBmp.Crop(aSource);
 aSize = aBmp.GetSizePixel();
 if (aSize.Width() > 0 && aSize.Height() > 0)
@@ -1556,9 +1560,9 @@

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sw/source

2022-02-28 Thread Mert Tumer (via logerrit)

 sw/source/core/crsr/viscrs.cxx |7 +++
 1 file changed, 7 insertions(+)

New commits:
commit bc86da350e3b5137a1a3c86b19f5c6c028b67b21
Author: Mert Tumer 
AuthorDate: Fri Feb 25 13:05:28 2022 +0300
Commit: Mert Tumer 
CommitDate: Mon Feb 28 17:54:24 2022 +0100

dont send text selection start/end when there is no selection

when there is no selection, startrect and endrect get the
cursor coordinates, we should not send it. Otherwise this
causes selection handles to appear on online

Signed-off-by: Mert Tumer 
Change-Id: I4402e04d4a16a1f840499c57421fd01caf43f116
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130525
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Szymon Kłos 

diff --git a/sw/source/core/crsr/viscrs.cxx b/sw/source/core/crsr/viscrs.cxx
index f81f9750b312..6b8c3c5b71a2 100644
--- a/sw/source/core/crsr/viscrs.cxx
+++ b/sw/source/core/crsr/viscrs.cxx
@@ -524,6 +524,13 @@ OString SwSelPaintRects::getLOKPayload( int nType, int 
nViewId, bool* ignore ) c
 SwRect aEndRect;
 FillStartEnd(aStartRect, aEndRect);
 
+// no selection rect
+if (!size())
+{
+*ignore = true;
+return OString();
+}
+
 if( nType == LOK_CALLBACK_TEXT_SELECTION_START )
 {
 if (aStartRect.HasArea())

[Libreoffice-commits] core.git: chart2/qa

2022-02-28 Thread Xisco Fauli (via logerrit)

 chart2/qa/extras/chart2import2.cxx  |   25 +
 chart2/qa/extras/data/ods/tdf146463.ods |binary
 2 files changed, 25 insertions(+)

New commits:
commit 97ca239014e50d26bb2553ebeb96e0bc57e27d2d
Author: Xisco Fauli 
AuthorDate: Mon Feb 28 12:14:05 2022 +0100
Commit: Xisco Fauli 
CommitDate: Mon Feb 28 17:45:36 2022 +0100

tdf#146463: chart2_import2: Add unittest

Change-Id: I1c8879eaab8cfc3d623a27d7d5d3d8a9cffb003b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130693
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/chart2/qa/extras/chart2import2.cxx 
b/chart2/qa/extras/chart2import2.cxx
index 17b762824f43..e35473717655 100644
--- a/chart2/qa/extras/chart2import2.cxx
+++ b/chart2/qa/extras/chart2import2.cxx
@@ -55,6 +55,7 @@ public:
 void testTdf137505();
 void testTdf137734();
 void testTdf137874();
+void testTdf146463();
 void testTdfCustomShapePos();
 void testTdf121281();
 void testTdf139658();
@@ -95,6 +96,7 @@ public:
 CPPUNIT_TEST(testTdf137505);
 CPPUNIT_TEST(testTdf137734);
 CPPUNIT_TEST(testTdf137874);
+CPPUNIT_TEST(testTdf146463);
 CPPUNIT_TEST(testTdfCustomShapePos);
 CPPUNIT_TEST(testTdf121281);
 CPPUNIT_TEST(testTdf139658);
@@ -792,6 +794,29 @@ void Chart2ImportTest2::testTdf137874()
 CPPUNIT_ASSERT(xLegendEntry.is());
 }
 
+void Chart2ImportTest2::testTdf146463()
+{
+load(u"/chart2/qa/extras/data/ods/", "tdf146463.ods");
+Reference xChartDoc(getChartDocFromSheet(0, 
mxComponent),
+   UNO_QUERY_THROW);
+Reference xDrawPageSupplier(xChartDoc, 
UNO_QUERY_THROW);
+Reference xDrawPage(xDrawPageSupplier->getDrawPage(), 
UNO_SET_THROW);
+Reference xShapes(xDrawPage->getByIndex(0), 
UNO_QUERY_THROW);
+uno::Reference xLegend = getShapeByName(xShapes, 
"CID/D=0:Legend=");
+CPPUNIT_ASSERT(xLegend.is());
+
+awt::Size aSize = xLegend->getSize();
+
+// Without the fix in place, this test would have failed with
+// - Expected: 598
+// - Actual  : 7072
+CPPUNIT_ASSERT_DOUBLES_EQUAL(598, aSize.Height, 30);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(4256, aSize.Width, 30);
+awt::Point aPosition = xLegend->getPosition();
+CPPUNIT_ASSERT_DOUBLES_EQUAL(11534, aPosition.X, 30);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(4201, aPosition.Y, 30);
+}
+
 void Chart2ImportTest2::testTdfCustomShapePos()
 {
 load(u"/chart2/qa/extras/data/docx/", "testcustomshapepos.docx");
diff --git a/chart2/qa/extras/data/ods/tdf146463.ods 
b/chart2/qa/extras/data/ods/tdf146463.ods
new file mode 100644
index ..6214f4a50075
Binary files /dev/null and b/chart2/qa/extras/data/ods/tdf146463.ods differ

[Libreoffice-commits] core.git: winaccessibility/source

2022-02-28 Thread Michael Weghorn (via logerrit)

 winaccessibility/source/service/AccObjectWinManager.cxx |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 7dd7bd7d9ff03fe2038943f5460a95163bec5e04
Author: Michael Weghorn 
AuthorDate: Mon Feb 28 11:54:09 2022 +
Commit: Michael Weghorn 
CommitDate: Mon Feb 28 17:43:37 2022 +0100

wina11y: Drop another 'using' directive

This is similar to
Change-Id: If4b295548468067c65afcd1a216d29cad9e0c213
("wina11y: Unify how AccessibleRole is referred to here"),
just for `AccessibleStateType`.

Change-Id: I5e99fad42dab87e0e303e5a08c610f6af77641ed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130700
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/winaccessibility/source/service/AccObjectWinManager.cxx 
b/winaccessibility/source/service/AccObjectWinManager.cxx
index 13b6bd640bf2..5c1f021d422a 100644
--- a/winaccessibility/source/service/AccObjectWinManager.cxx
+++ b/winaccessibility/source/service/AccObjectWinManager.cxx
@@ -46,7 +46,6 @@
 
 
 using namespace com::sun::star::accessibility;
-using namespace com::sun::star::accessibility::AccessibleStateType;
 using namespace com::sun::star::uno;
 
 /**
@@ -1062,7 +1061,7 @@ bool 
AccObjectWinManager::IsStateManageDescendant(XAccessible* pAccessible)
 int count = pStates.getLength();
 for( int iIndex = 0;iIndex < count;iIndex++ )
 {
-if(pStates[iIndex] == 
/*AccessibleStateType::*/MANAGES_DESCENDANTS)
+if (pStates[iIndex] == 
AccessibleStateType::MANAGES_DESCENDANTS)
 return true;
 }
 }

[Libreoffice-commits] core.git: 2 commits - winaccessibility/inc winaccessibility/source

2022-02-28 Thread Michael Weghorn (via logerrit)

 winaccessibility/inc/AccObjectManagerAgent.hxx|2 
 winaccessibility/inc/AccObjectWinManager.hxx  |2 
 winaccessibility/source/service/AccComponentEventListener.cxx |4 
 winaccessibility/source/service/AccObjectManagerAgent.cxx |4 
 winaccessibility/source/service/AccObjectWinManager.cxx   |  207 --
 5 files changed, 109 insertions(+), 110 deletions(-)

New commits:
commit 3cde1fe16965d2b976c6c1210e81f17ae352b79f
Author: Michael Weghorn 
AuthorDate: Mon Feb 28 11:43:13 2022 +
Commit: Michael Weghorn 
CommitDate: Mon Feb 28 17:43:19 2022 +0100

wina11y: Unify how AccessibleRole is referred to here

Using

using namespace com::sun::star::accessibility::AccessibleRole;

and then

case /*AccessibleRole::*/DIALOG

looks a bit odd. Drop the `using` directive and
consistently use `AccessibleRole::` across
this source file when referring to `AccessibleRole`s.

Change-Id: If4b295548468067c65afcd1a216d29cad9e0c213
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130699
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/winaccessibility/source/service/AccObjectWinManager.cxx 
b/winaccessibility/source/service/AccObjectWinManager.cxx
index d24154769b05..13b6bd640bf2 100644
--- a/winaccessibility/source/service/AccObjectWinManager.cxx
+++ b/winaccessibility/source/service/AccObjectWinManager.cxx
@@ -46,7 +46,6 @@
 
 
 using namespace com::sun::star::accessibility;
-using namespace com::sun::star::accessibility::AccessibleRole;
 using namespace com::sun::star::accessibility::AccessibleStateType;
 using namespace com::sun::star::uno;
 
@@ -530,10 +529,10 @@ void AccObjectWinManager::DeleteAccObj( XAccessible* 
pXAcc )
 assert(i != 0);
 (void) i;
 DeleteFromHwndXAcc(pXAcc);
-if( accObj.GetRole() == DOCUMENT ||
-accObj.GetRole() == DOCUMENT_PRESENTATION ||
-accObj.GetRole() == DOCUMENT_SPREADSHEET ||
-accObj.GetRole() == DOCUMENT_TEXT )
+if (accObj.GetRole() == AccessibleRole::DOCUMENT ||
+accObj.GetRole() == AccessibleRole::DOCUMENT_PRESENTATION ||
+accObj.GetRole() == AccessibleRole::DOCUMENT_SPREADSHEET ||
+accObj.GetRole() == AccessibleRole::DOCUMENT_TEXT)
 {
 XHWNDDocList.erase(accObj.GetParentHWND());
 }
@@ -695,10 +694,10 @@ bool AccObjectWinManager::InsertAccObj( XAccessible* 
pXAcc,XAccessible* pParentX
 pObj.SetParentHWND( pWnd );
 
 //for file name support
-if( pObj.GetRole() == DOCUMENT ||
-pObj.GetRole() == DOCUMENT_PRESENTATION ||
-pObj.GetRole() == DOCUMENT_SPREADSHEET ||
-pObj.GetRole() == DOCUMENT_TEXT )
+if (pObj.GetRole() == AccessibleRole::DOCUMENT ||
+pObj.GetRole() == AccessibleRole::DOCUMENT_PRESENTATION ||
+pObj.GetRole() == AccessibleRole::DOCUMENT_SPREADSHEET ||
+pObj.GetRole() == AccessibleRole::DOCUMENT_TEXT)
 {
 XHWNDToDocumentHash::iterator aIter = XHWNDDocList.find(pWnd);
 if ( aIter != XHWNDDocList.end() )
@@ -765,94 +764,94 @@ AccObjectWinManager::CreateAccEventListener(XAccessible* 
pXAcc)
 {
 switch( xContext->getAccessibleRole() )
 {
-case /*AccessibleRole::*/DIALOG:
+case AccessibleRole::DIALOG:
 pRet = new AccDialogEventListener(pXAcc,pAgent);
 break;
-case /*AccessibleRole::*/FRAME:
+case AccessibleRole::FRAME:
 pRet = new AccFrameEventListener(pXAcc,pAgent);
 break;
-case /*AccessibleRole::*/WINDOW:
+case AccessibleRole::WINDOW:
 pRet = new AccWindowEventListener(pXAcc,pAgent);
 break;
-case /*AccessibleRole::*/ROOT_PANE:
+case AccessibleRole::ROOT_PANE:
 pRet = new AccFrameEventListener(pXAcc,pAgent);
 break;
 //Container
-case /*AccessibleRole::*/CANVAS:
-case /*AccessibleRole::*/COMBO_BOX:
-case /*AccessibleRole::*/DOCUMENT:
-case /*AccessibleRole::*/DOCUMENT_PRESENTATION:
-case /*AccessibleRole::*/DOCUMENT_SPREADSHEET:
-case /*AccessibleRole::*/DOCUMENT_TEXT:
-case /*AccessibleRole::*/END_NOTE:
-case /*AccessibleRole::*/FILLER:
-case /*AccessibleRole::*/FOOTNOTE:
-case /*AccessibleRole::*/FOOTER:
-case /*AccessibleRole::*/HEADER:
-case /*AccessibleRole::*/LAYERED_PANE:
-case /*AccessibleRole::*/MENU_BAR:
-case /*AccessibleRole::*/POPUP_MENU:
-case /*AccessibleRole::*/OPTION_PANE:
-case /*AccessibleRole::*/PAGE_TAB:
-case /*AccessibleRole::*/PAGE_TAB_LIST:
-case /*AccessibleRole::*/PANEL:
-case /*AccessibleRole::*/SCROLL_PANE:
-case /*AccessibleRole::*/SPLIT_PANE:
-case /*AccessibleRole::*/STATUS_BAR:
-case /*AccessibleRole::*/TABLE_CELL:
-case /*AccessibleRole::*/TOOL_BAR:
-

[Libreoffice-commits] core.git: winaccessibility/inc winaccessibility/source

2022-02-28 Thread Michael Weghorn (via logerrit)

 winaccessibility/inc/AccContainerEventListener.hxx|4 
 winaccessibility/inc/AccDescendantManagerEventListener.hxx|4 
 winaccessibility/inc/AccObjectManagerAgent.hxx|3 
 winaccessibility/inc/AccObjectWinManager.hxx  |3 
 winaccessibility/inc/unomsaaevent.hxx |  128 
+++---
 winaccessibility/source/service/AccComponentEventListener.cxx |   28 +-
 winaccessibility/source/service/AccContainerEventListener.cxx |   66 
++---
 winaccessibility/source/service/AccDescendantManagerEventListener.cxx |   26 +-
 winaccessibility/source/service/AccDialogEventListener.cxx|4 
 winaccessibility/source/service/AccEventListener.cxx  |   12 
 winaccessibility/source/service/AccFrameEventListener.cxx |4 
 winaccessibility/source/service/AccListEventListener.cxx  |4 
 winaccessibility/source/service/AccMenuEventListener.cxx  |6 
 winaccessibility/source/service/AccObjectManagerAgent.cxx |6 
 winaccessibility/source/service/AccObjectWinManager.cxx   |   84 
+++---
 winaccessibility/source/service/AccParagraphEventListener.cxx |4 
 winaccessibility/source/service/AccTableEventListener.cxx |   23 -
 winaccessibility/source/service/AccTopWindowListener.cxx  |6 
 winaccessibility/source/service/AccTreeEventListener.cxx  |2 
 winaccessibility/source/service/AccWindowEventListener.cxx|4 
 20 files changed, 190 insertions(+), 231 deletions(-)

New commits:
commit 6723203528739430974d5c1dd14a26f8d4efcf0a
Author: Michael Weghorn 
AuthorDate: Mon Feb 28 10:57:30 2022 +
Commit: Michael Weghorn 
CommitDate: Mon Feb 28 17:42:47 2022 +0100

wina11y: Convert unomsaaevent.hxx constants to enum class UnoMSAAEvent

Also drop the previous comments for the constants that add
little value and are partially outdated.
See the actual implementation to see how values are mapped
to send out actual MSAA events, e.g. the previous comment

// CARET_CHANGED --> EVENT_OBJECT_LOCATIONCHANGED

was no longer correct by now, since that is by now mapped to
`IA2_EVENT_TEXT_CARET_MOVED` in `AccObjectWinManager::NotifyAccEvent`.

Change-Id: I38111ccb60c06f73ce53b18a6ca32e13dbd629b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130697
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/winaccessibility/inc/AccContainerEventListener.hxx 
b/winaccessibility/inc/AccContainerEventListener.hxx
index f0b87c3d4042..c880374fbb3d 100644
--- a/winaccessibility/inc/AccContainerEventListener.hxx
+++ b/winaccessibility/inc/AccContainerEventListener.hxx
@@ -19,6 +19,8 @@
 
 #pragma once
 
+enum class UnoMSAAEvent;
+
 #include 
 #include "AccEventListener.hxx"
 #include 
@@ -73,7 +75,7 @@ public:
 // update all children's state
 void UpdateAllChildrenState( css::accessibility::XAccessible* 
pXAccessible);
 
-bool NotifyChildEvent(short nWinEvent, const css::uno::Any );
+bool NotifyChildEvent(UnoMSAAEvent eWinEvent, const css::uno::Any& Value);
 
 virtual void HandleSelectionChangedAddEvent(
 const css::uno::Any , const css::uno::Any );
diff --git a/winaccessibility/inc/AccDescendantManagerEventListener.hxx 
b/winaccessibility/inc/AccDescendantManagerEventListener.hxx
index 73cda0f4eb46..669143a036f6 100644
--- a/winaccessibility/inc/AccDescendantManagerEventListener.hxx
+++ b/winaccessibility/inc/AccDescendantManagerEventListener.hxx
@@ -19,6 +19,8 @@
 
 #pragma once
 
+enum class UnoMSAAEvent;
+
 #include 
 #include 
 #include "AccComponentEventListener.hxx"
@@ -54,7 +56,7 @@ public:
 virtual void HandleChildChangedNoFocusEvent(
 css::uno::Any oldValue, css::uno::Any newValue);
 
-bool NotifyChildEvent(short nWinEvent,const css::uno::Any );
+bool NotifyChildEvent(UnoMSAAEvent eWinEvent, const css::uno::Any& Value);
 
 virtual void HandleSelectionChangedAddEvent(
 const css::uno::Any , const css::uno::Any );
diff --git a/winaccessibility/inc/AccObjectManagerAgent.hxx 
b/winaccessibility/inc/AccObjectManagerAgent.hxx
index a0f3daec579b..f0f0ca06a66a 100644
--- a/winaccessibility/inc/AccObjectManagerAgent.hxx
+++ b/winaccessibility/inc/AccObjectManagerAgent.hxx
@@ -30,6 +30,7 @@
 struct IMAccessible;
 struct IAccessible;
 class AccObjectWinManager;
+enum class UnoMSAAEvent;
 
 /
 AccObjectManagerAgent is used for managing AccObjects, which encapsulates
@@ -56,7 +57,7 @@ public:
 virtual void DeleteAccObj( css::accessibility::XAccessible* pXAcc );
 virtual IMAccessible*  GetIMAccByXAcc(css::accessibility::XAccessible* 
pXAcc);
 
-bool NotifyAccEvent(short pEvent = 0, css::accessibility::XAccessible* 
pXAcc = nullptr);
+

[Libreoffice-commits] core.git: winaccessibility/source

2022-02-28 Thread Michael Weghorn (via logerrit)

 winaccessibility/source/service/AccObjectWinManager.cxx |4 
 1 file changed, 4 deletions(-)

New commits:
commit 470ed0ff78a8b07d5aa02e0bba97bfa479860cf3
Author: Michael Weghorn 
AuthorDate: Mon Feb 28 08:23:05 2022 +
Commit: Michael Weghorn 
CommitDate: Mon Feb 28 17:42:18 2022 +0100

wina11y: Drop useless #ifdef block

`ACC_DEBUG` isn't defined anywhere and the
`pFile` variable/member used inside of the `ifedf`ed block
doesn't exist either.

Change-Id: I0d04ca71dbc9a731a6673fad9b69c1229c472d16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130696
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/winaccessibility/source/service/AccObjectWinManager.cxx 
b/winaccessibility/source/service/AccObjectWinManager.cxx
index 341d108e1bff..0f37eeb2628f 100644
--- a/winaccessibility/source/service/AccObjectWinManager.cxx
+++ b/winaccessibility/source/service/AccObjectWinManager.cxx
@@ -79,10 +79,6 @@ AccObjectWinManager::~AccObjectWinManager()
 HwndXAcc.clear();
 XResIdAccList.clear();
 XHWNDDocList.clear();
-#ifdef ACC_DEBUG
-
-fclose( pFile );
-#endif
 }

[Libreoffice-bugs] [Bug 138706] [META] Regressions from "tdf106792 Get rid of SvxShapePolyPolygonBezier"

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=138706

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||96640


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=96640
[Bug 96640] Fileopen DOCX : Drawing of electric circuit has capacitor symbol
wrong because vertical line is horizontal
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 96640] Fileopen DOCX : Drawing of electric circuit has capacitor symbol wrong because vertical line is horizontal

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96640

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Blocks||138706
 CC||kelem...@ubuntu.com


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=138706
[Bug 138706] [META] Regressions from "tdf106792 Get rid of
SvxShapePolyPolygonBezier"
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147700] New: Position of Manage Changes window is not retained

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147700

Bug ID: 147700
   Summary: Position of Manage Changes window is not retained
   Product: LibreOffice
   Version: 7.3.0.3 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: robert.funn...@mcgill.ca

Description:
After upgrading from 7.1.5 (I think) to 7.3.0.3, I find that when I call up the
Manage Changes window it always appears in the middle of the document window.
It used to appear where I positioned it the last time I used it, which is
preferable.

Steps to Reproduce:
1. Open a document.
2. Open the Manage Changes window. It appears in the middle of the document
window.
3. Move the Manage Changes window to a more convenient position.
4. Close the Manage Changes window.
5. Open the Manage Changes window again.

Actual Results:
 The Manage Changes window again appears in the middle of the document window.

Expected Results:
The Manage Changes window should appear where it was positioned when last used.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.3.0.3 (x64) / LibreOffice Community
Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3
CPU threads: 12; OS: Windows 10.0 Build 22000; UI render: Skia/Vulkan; VCL: win
Locale: en-CA (en_CA); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 96640] Fileopen DOCX : Drawing of electric circuit has capacitor symbol wrong because vertical line is horizontal

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96640

--- Comment #18 from Gabor Kelemen (allotropia)  ---
Created attachment 178586
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178586=edit
The minimized example in Word 2013 and current master

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 4202ea2c932a14d216e74617bbb74a85030c9a59
CPU threads: 14; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (hu_HU); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143002] [META] Tracked Changes of tables

2022-02-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=143002
Bug 143002 depends on bug 146962, which changed state.

Bug 146962 Summary: FILEEDIT ODT  Hide changes deletion
https://bugs.documentfoundation.org/show_bug.cgi?id=146962

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

1 2 3 >

1 - 100 of 275 matches

Mail list logo