[Libreoffice-bugs] [Bug 87040] Floating toolbar feature request aka "mini toolbar"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87040

Heiko Tietze  changed:

   What|Removed |Added

Summary|Floating toolbar feature|Floating toolbar feature
   |request |request aka "mini toolbar"

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Test name: VclTextTest::testSimpleText double equality assertion failed

[Luboš Luňák]

On Thursday 26 of May 2022, Lera Goncharuk wrote:
> Hi,
>
> I was running automated tests and got an error.
>
> OS: Kubuntu 20.04
> Last commit: e544febe2108d0bbe99936ce7373a22f32fe08a7
> fe08a7>
> finished in: 365ms text.cxx:222:Assertion Test name:
> VclTextTest::testSimpleText double equality assertion failed - Expected: 42
> - Actual : 37 - Delta : 4 Failures !!! Run: 16 Failure total: 1 Failures: 1

 That test has exportDevice() calls that can show you what the rendered result 
is if you enable them. The results may differ slightly based on the font 
used, since here increasing the tolerance by one would make it pass, them may 
be the thing to do if the rendered result looks ok.

-- 
 Luboš Luňák
 l.lu...@collabora.com

[Libreoffice-bugs] [Bug 147891] Regression: roundtrip of presentations/drawings including cropped PDF images is broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147891

--- Comment #5 from raal  ---
Yes, I used manual cropping. Can you attach printscreen before and after save?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149327] Can't type accented letters at the end of a paragraph in Writer (EDITING)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149327

--- Comment #1 from Marcelo  ---
Just a small rectification: in the example I gave, after typing "parágrafo" at
the end of Paragraph1, I'll end up with:

Paragraph1par´
grafoParagraph2


The accent is displayed, but not the letter that should have been accented.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149327] Can't type accented letters at the end of a paragraph in Writer (EDITING)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149327

Marcelo  changed:

   What|Removed |Added

Version|3.3.3 release   |7.3.3.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149327] New: Can't type accented letters at the end of a paragraph in Writer (EDITING)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149327

Bug ID: 149327
   Summary: Can't type accented letters at the end of a paragraph
in Writer (EDITING)
   Product: LibreOffice
   Version: 3.3.3 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mmtsa...@gmail.com

Description:
Typing a dead key at the very end of a paragraph will send the cursor to the
beginning of the next paragraph. The first character typed after the dead key
will be "eaten" and not displayed at all. The following typed characters will
be placed in the beginning of the paragraph after the one where the dead key
was typed.

For example, if I have the two following paragraphs:

Paragraph1
Paragraph2

And, at the end of Paragraph1 I type the word "parágrafo", I will end up with:

Paragraph1par
grafoParagraph2


I'm unable to type any accented characters at the end of a paragraph, unless I
add a blank space (or any other character) before the paragraph end marker and
type my text before it. Then dead keys will work as they should.
Dead keys are working fine in other applications and also work ok in
LibreOffice Writer, as long as there are no paragraphs after the one being
typed, or if I'm typing anywhere in a paragraph other than at its very end.
This behavior can only be reproduced in Writer, but not in other LibreOffice
applications.

Running Kubuntu 21.10 and LibreOffice 7.3.3.2, pt-BR language.

Steps to Reproduce:
1. In a document with more than one paragraph, place the cursor at the very end
of any paragraph, except the last one
2. Type a dead key (any accent), followed by several characters


Actual Results:
As soon as you type the dead key, the cursor will be moved to the beginning of
the following paragraph. The next letter you type will not be shown. After
that, all characters you type will be placed in the beginning of the paragraph
following the one where the dead key was typed.

Expected Results:
All the typed characters should have been placed where the cursor was when you
started typing (where you placed it in step 1) 


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.3.3.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 12; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: pt-BR
Ubuntu package version: 1:7.3.3~rc2-0ubuntu0.21.10.1~lo1
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149326] New: Libra Office Writer Hangs When I Click On File Then Scroll Past "Open Remote"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149326

Bug ID: 149326
   Summary: Libra Office Writer Hangs When I Click On File Then
Scroll Past "Open Remote"
   Product: LibreOffice
   Version: 3.3.0 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bestb4expi...@gmail.com

Description:
In Libra Office Writer a lot of times when I click on the file button (Top
Left) and then start to scroll my mouse down the list. As it passes over the
button titled "open remote" it freezes there as if it's trying to open
something remotely. But I didn't click this. I am only scrolling past it. But
it freezes for five or ten really annoying seconds before it catches on that
I'm not trying to land on that button and goes down to the save or whatever I'm
actually trying to do.

Actual Results:
Click file scroll down with mouse

Expected Results:
Freezes on "open Remote"


Reproducible: Sometimes


User Profile Reset: No



Additional Info:
let the mouse pass over the "open remote" without trying to do anything unless
you actually click on open remote.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148011] copy-paste extreme slowness

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148011

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147891] Regression: roundtrip of presentations/drawings including cropped PDF images is broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147891

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147749] calc issuing X11 activate hint when "Find" bottom tab is opened

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147749

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147698] Typing (") after a fraction or an (') to show possession causes a large spacing (7.3.0.3 - x64)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147698

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149063] Writer "hanging" regularly whilst amending documents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149063

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149059] [VIEWING] Selection display is displaced when selecting upward with mouse without exiting write/edit mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149059

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149055] Embedded chart no longer works properly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149055

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149046] Error in the description of the mathematical formula

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149046

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148633] LO Help F1 shows contents of a script file, not a doc for help

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148633

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145247] Cannot save documents macOS Catalina

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145247

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148633] LO Help F1 shows contents of a script file, not a doc for help

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148633

--- Comment #8 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145247] Cannot save documents macOS Catalina

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145247

--- Comment #3 from QA Administrators  ---
Dear Keith Johnson,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145891] Massive colour change of text not working anymore in 7.1.7.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145891

--- Comment #3 from QA Administrators  ---
Dear drexlar,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149325] Crash when Excel VBA code is run

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149325

Óvári  changed:

   What|Removed |Added

 CC||hmeeks4...@gmail.com,
   ||qui...@gmail.com,
   ||t...@libreoffice.org

--- Comment #3 from Óvári  ---
cc: Hannah Meeks, Thorsten Behrens, Tomaž Vajngerl

Hannah Meeks’ Google Summer of Code 2022 project.

VBA Macros - Tests and missing APIs
Hannah Meeks proposal is to research and make new tests for Writer (as Calc
seems to already have lots of tests) as well as identify and implement some
missing methods in both Calc and Writer that improve compatibility.
https://summerofcode.withgoogle.com/programs/2022/projects/wMvv2tnI

Hannah Meeks – VBA Macros – Tests and missing APIs : We support VBA (Visual
Basic for Applications) Macros in LibreOffice, but the implemented API isn’t
complete and the API functions aren’t largely tested. The consequence of this
is that the VBA macros in OOXML documents don’t run as intended in LibreOffice,
which causes compatibility problems. The goal of this project is to add tests
for the functions already implemented and then look for what functions are
missing for a method or module and add them.
https://blog.documentfoundation.org/blog/2022/05/26/projects-selected-for-libreoffice-in-the-google-summer-of-code-2022/?unapproved=106262=cc4b688d85ff2c090af061520d9b3b80#comment-106262

Does the attached Excel spreadsheet help identify and implement some missing
methods in Calc?

Thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149325] Crash when Excel VBA code is run

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149325

--- Comment #2 from Óvári  ---
Created attachment 180421
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180421=edit
Excel spreadsheet automatic output after “Generate Statement” button is pressed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149325] Crash when Excel VBA code is run

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149325

--- Comment #1 from Óvári  ---
Created attachment 180420
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180420=edit
Excel spreadsheet created with Excel 2000. Tested and works with Excel
2000/2003/2007/2010

1. Open Statement.xls with  LibreOffice Calc 7.3.3.2
2. Click the “Generate Statement” button in the “Range” sheet
3. LibreOffice crashes

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149325] New: Crash when Excel VBA code is run

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149325

Bug ID: 149325
   Summary: Crash when Excel VBA code is run
   Product: LibreOffice
   Version: 7.3.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ovari...@zoho.com

Description:
With Excel 2010, clicking the “Generate Statement” button in the “Range” sheet:
1. Clears all the contents in the “Statement” tab
2. Creates “Statements” tab using the information from the “Transactions”,
“Interest Rates Cr”, “Interest Rates Dr” tabs.
3. Creates a PDF of using a region (not all) of the “Statements” tab.

Unfortunately, LibreOffice Calc 7.3.3.2 crashes when the “Generate Statement”
button is clicked.

Does LibreOffice Calc have some missing VBA Macro APIs?

Unsure how to add a file now and will add files in the next comments.

Thank you

Steps to Reproduce:
1. Open Statement.xls with  LibreOffice Calc 7.3.3.2
2. Click the “Generate Statement” button in the “Range” sheet
3. LibreOffice crashes

Actual Results:
1. Open Statement.xls with  LibreOffice Calc 7.3.3.2
2. Click the “Generate Statement” button in the “Range” sheet
3. LibreOffice crashes

Expected Results:
Expected results are what happens when using Excel 2010:
1. Open Statement.xls with Excel 2010
2. Click the “Generate Statement” button in the “Range” sheet
3. VBA code clears all the contents in the “Statement” tab
4. VBA code creates “Statements” tab using the information from the
“Transactions”, “Interest Rates Cr”, “Interest Rates Dr” tabs.
5. VBA code creates a PDF of using a region (not all) of the “Statements” tab.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.3.3.2 / LibreOffice Community
Build ID: d1d0ea68f081ee2800a922cac8f79445e4603348
CPU threads: 2; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Flatpak
Calc: threaded

Linux Mint 20.3 Cinnamon

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148633] LO Help F1 shows contents of a script file, not a doc for help

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148633

--- Comment #7 from robgrune  ---
(In reply to Timur from comment #6)
> That's a different problem.
> Where exactly did you press F1 and what page did you get? 
> Is it the same if you press Help button (rarely doesn't have to be)?

Pressing F1 or Help links to the default browser (could be either Firefox or
Chromium) and a page shows with message to the effect no help files found.

The problem is the lack of system integration. Seems LO, FF, Chrome are now
'snap' installs. 

The problem is solved by installing a new browser from the deb repository. I
found 'slimjet', and this works perfectly to show the help files.

This help problem is only one of many LO bugs I have discovered. The worst is
severe input lag, causing LO to be entirely useless.

LO is no longer the capable, friendly suite is was once upon a time.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149168] Freeze at undo (caused by Image anchor) + hidden track changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149168

Rangarajan  changed:

   What|Removed |Added

 CC||rangarajan.20...@gmail.com

--- Comment #3 from Rangarajan  ---
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 465c3ad95059f0efa13c8027f7383c4d20a5b2ff
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-IN (en_IN); UI: en-US
Calc: threaded


Actual Results:
No freeze


Expected Results:
No freeze

No reproduce

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: trigger MapMode ScaleX change in writer

[Mark Hung]

Caolán McNamara  於 2022年5月26日 週四 下午6:33寫道：

> On Wed, 2022-05-25 at 21:42 +0800, Mark Hung wrote:
> > here is another precondition: OutputDevice must be a printer (bPrt
> > ==true)
>
> I think this requires that "Use printer metrics for document
> formatting" is enabled to get to this path (tools, options, writer,
> compatibility) which I think is "PrinterIndependantLayout" of
> "disabled" in the config setting in the file format.
>
> If I create a new document, enable that "use printer metrics", add some
> text and then use the "file, print" dialog and I get a hit of bPrt of
> true. If you can reproduce the same I think that backtrace is valuable
> to you to attempt a test, e.g. PrintOrPDFExport(pOut, ...) where I see
> pOut->GetOutDevType() is OUTPUT_PRINTER (unotxdoc.cxx:2962) so I'd
> guess something like
>
> a doc with "use printer metrics" enabled
> ScopedVclPtrInstance printer,
> SwViewShell::PrintOrPDFExport(printer, ...
> might get you where you want to go
>
>
Now I can make both bPrt and bStretch true, if I enable  "Use printer
metrics for document
formatting" and insert some code in  PrintOrPDFExport to set ScaleX and
ScaleY.
I guess I can continue with that for my unit test. Interestingly, I didn't
find any place it is set for the printer.
I wonder if it is something that is no longer useful. In that case, we may
remove the code completely.

Thank you.

-- 
Mark Hung

[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120550

--- Comment #13 from sdc.bla...@youmail.dk ---
Created attachment 180419
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180419=edit
Draw document with attempt to use Minimal Row Height

In Writer 

"Minimize row height: Adjusts the height of the selected rows to fit the
content, causing the table to shrink. "

Counter-demonstration to "causing the table to shrink" (or demonstration of my
misunderstanding).

2 x 2 table 

48 pt size text  | 12 pt size text
12 pt size text  | 12 pt size text

1. Cursor in first row
2. Right-click Size > Row Height
3. unclick "Fit to Size", set Height to 1cm
4. Select the two rows, right-click Size > Minimal Row Height

Actual:  table grows
Expected: (according to help): table shrinks.

I also tried in Draw -- but could not see that I can set Row Height (steps 2
and 3), so maybe this will not be an issue in Draw.  

But ... I did try to use the "Minimal" commands, and got an unexpected result
-- have attached the .odg, with a description of what I did, what I expected,
and what I got.  (not claiming any misbehavior in Draw -- just seeking to gain
a proper understanding).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120550

--- Comment #12 from sdc.bla...@youmail.dk ---
> >.uno:SetMinimalRowHeight and uno:SetMinimalColumnWidth 
> Yes, these ought to be the same wording. Probably "minimal" to match "optimal"
https://gerrit.libreoffice.org/c/core/+/135005

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120550

--- Comment #11 from sdc.bla...@youmail.dk ---
(In reply to Justin L from comment #10)
Thanks for clear answers, which help to define the scope of what is needed.
Now to more forward with the actual descriptions.

Comparing c22 (from Comment 0 here) (for Draw) and c23 and c23 (from Comment 1)
here, plus bug 121367, comment 1 (for Writer):  I see only one clear
difference:  Minimize Column Width.  

(in fact, your descriptions are identical for Draw and Writer, but then you add
a note explaining "selected cells" (for Writer) vs. "entire column" for Draw --
will try to convey this difference.)

Does that sound right? -- that the differences between Writer and Draw are in
relation to "Minimal Column Width" (and possibly "Optimal Column Width",
addressed in the next topic here.)

If there are other differences, then please identify them, because I cannot see
more in what has been provided.

Bug 121367, comment 1 (for Writer) indicates:

  Minimize column and optimize column DO grow the table size if the space is
available.

Questions (to be sure I have it right):

1.  Minimal column: DOES grow table for Writer; DOES NOT grow for Draw

2.  Optimal column DOES grow table for Writer (if space is available); DOES NOT
grow for Draw?  (your descriptions for "Optimal" did not comment on growing,
hence the uncertainty)

3.  What does "if space is available" mean in this context?  (left/right page
margins? plus top/bottom margins, unless table can flow over a page?  Will the
top border of the table ever move up in the page, or is the space always added
at the end of the table?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: trigger MapMode ScaleX change in writer

[Mark Hung]

Caolán McNamara  於 2022年5月26日 週四 下午6:33寫道：

> On Wed, 2022-05-25 at 21:42 +0800, Mark Hung wrote:
> > here is another precondition: OutputDevice must be a printer (bPrt
> > ==true)
>
> I think this requires that "Use printer metrics for document
> formatting" is enabled to get to this path (tools, options, writer,
> compatibility) which I think is "PrinterIndependantLayout" of
> "disabled" in the config setting in the file format.
>

After I enabled "use printer metrics", bPrt = true is achieved, but I still
need XScale changed.
Maybe some printers have an option to scale the printed data?
I didn't find any options that looks related with CUPS pdf printer or print
to file.


-- 
Mark Hung

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - filter/source

[Marco Cecchetti (via logerrit)]

 filter/source/svg/presentation_engine.js |  231 ++-
 1 file changed, 226 insertions(+), 5 deletions(-)

New commits:
commit dba435ead382deeadcd7225c1941ad12c8d127d5
Author: Marco Cecchetti 
AuthorDate: Mon May 23 12:22:19 2022 +0200
Commit: Aron Budea 
CommitDate: Fri May 27 01:13:20 2022 +0200

svg filter: transform animations: support for scale and translate

Now the emphasis grow and shrink animation is supported.
Now the animation engine is able to handle array of values instead of
single value param when computing the next animation state.

Change-Id: Ic200103c6c26a63de8eecc37dcd36ba1a2f0d391
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134870
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 
(cherry picked from commit a6ed16394c4a95cf204f38c30cb025bc99f00027)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134995
Reviewed-by: Aron Budea 

diff --git a/filter/source/svg/presentation_engine.js 
b/filter/source/svg/presentation_engine.js
index de73ab9710bd..8906825126fe 100644
--- a/filter/source/svg/presentation_engine.js
+++ b/filter/source/svg/presentation_engine.js
@@ -7033,6 +7033,8 @@ function matrixToString( aSVGMatrix )
 // eslint-disable-next-line no-unused-vars
 function numberParser( sValue )
 {
+if( typeof sValue !== 'string' )
+return undefined;
 if( sValue === '.' )
 return undefined;
 var reFloatNumber = /^[+-]?[0-9]*[.]?[0-9]*$/;
@@ -7045,6 +7047,9 @@ function numberParser( sValue )
 
 function booleanParser( sValue )
 {
+if( typeof sValue !== 'string' )
+return undefined;
+
 sValue = sValue.toLowerCase();
 if( sValue === 'true' )
 return true;
@@ -7056,6 +7061,9 @@ function booleanParser( sValue )
 
 function colorParser( sValue )
 {
+if( typeof sValue !== 'string' )
+return undefined;
+
 // The following 3 color functions are used in evaluating sValue string
 // so don't remove them.
 
@@ -7989,6 +7997,7 @@ var ENUM_PROPERTY   = 2;
 var COLOR_PROPERTY  = 3;
 var STRING_PROPERTY = 4;
 var BOOL_PROPERTY   = 5;
+var TUPLE_NUMBER_PROPERTY   = 6;
 
 var aValueTypeOutMap = [ 'unknown', 'number', 'enum', 'color', 'string', 
'boolean' ];
 
@@ -8006,6 +8015,14 @@ var aAttributeMap =
 'get':  'getOpacity',
 'set':  'setOpacity'   
 },
 
+'scale':   {   'type':  TUPLE_NUMBER_PROPERTY,
+'get':  'getSize',
+'set':  'setSize'  
 },
+
+'translate':   {   'type':  TUPLE_NUMBER_PROPERTY,
+'get':  'getPos',
+'set':  'setPos'   
 },
+
 'rotate':   {   'type': NUMBER_PROPERTY,
 'get':  'getRotationAngle',
 'set':  'setRotationAngle' 
 },
@@ -11615,10 +11632,21 @@ AnimationTransformNode.prototype.createActivity = 
function()
 var aActivityParamSet = this.fillActivityParams();
 var aAnimation;
 
-aAnimation = createPropertyAnimation( this.getAttributeName(),
-  this.getAnimatedElement(),
-  this.aNodeContext.aSlideWidth,
-  this.aNodeContext.aSlideHeight );
+if( this.getAttributeName() === 'scale' || this.getAttributeName() === 
'translate' )
+{
+aAnimation = createPairPropertyAnimation( this.getAttributeName(),
+  this.getAnimatedElement(),
+  
this.aNodeContext.aSlideWidth,
+  
this.aNodeContext.aSlideHeight );
+
+}
+else
+{
+aAnimation = createPropertyAnimation( this.getAttributeName(),
+  this.getAnimatedElement(),
+  this.aNodeContext.aSlideWidth,
+  this.aNodeContext.aSlideHeight );
+}
 
 var aInterpolator = null;  // createActivity will compute it;
 return createActivity( aActivityParamSet, this, aAnimation, aInterpolator 
);
@@ -12049,6 +12077,41 @@ function createPropertyAnimation( sAttrName, 
aAnimatedElement, nWidth, nHeight )
 
 
 
+function createPairPropertyAnimation( sTransformType, aAnimatedElement, 
nWidth, nHeight )
+{
+var aFunctorSet = aAttributeMap[ sTransformType ];
+var sGetValueMethod = aFunctorSet.get;
+var sSetValueMethod = aFunctorSet.set;
+
+var aDefaultValue = [];
+var aSizeReference = [];
+if( sTransformType === 'scale' )
+{
+

[Libreoffice-commits] core.git: Branch 'feature/cib_contract891c' - 16 commits - download.lst external/curl external/libxslt external/pdfium hwpfilter/source jvmfwk/plugins jvmfwk/source shell/source

[Miklos Vajna (via logerrit)]

 download.lst  |   24 +-
 external/curl/ExternalPackage_curl.mk |2 
 external/curl/ExternalProject_curl.mk |2 
 external/curl/curl-7.26.0_win-proxy.patch |   12 -
 external/curl/curl-nss.patch.1|6 
 external/curl/zlib.patch.0|   16 -
 external/libxslt/UnpackedTarball_xslt.mk  |1 
 external/libxslt/e2584eed1c84c18f16e42188c30d2c3d8e3e8853.patch.1 |   69 

 external/libxslt/rpath.patch.0|2 
 external/pdfium/Library_pdfium.mk |   44 +++--
 external/pdfium/README|2 
 external/pdfium/build.patch.1 |   86 
+-
 external/pdfium/ubsan.patch   |6 
 hwpfilter/source/htags.cxx|   26 +--
 hwpfilter/source/hwpreader.cxx|   64 
+--
 jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx   |   16 +
 jvmfwk/source/framework.cxx   |8 
 jvmfwk/source/fwkbase.cxx |6 
 shell/source/win32/SysShExec.cxx  |8 
 solenv/flatpak-manifest.in|7 
 sw/qa/core/data/ooxml/fail/LIBREOFFICE-DBDAZAEC.docx  |binary
 sw/qa/extras/layout/data/LIBREOFFICE-UXTSOREL.rtf |binary
 sw/qa/extras/layout/layout.cxx|8 
 sw/source/core/layout/objectformattertxtfrm.cxx   |   52 --
 sw/source/core/unocore/unodraw.cxx|2 
 25 files changed, 255 insertions(+), 214 deletions(-)

New commits:
commit dccc99d530dc7bc4815797baa02c4f0dcd187f69
Author: Miklos Vajna 
AuthorDate: Wed Sep 22 20:09:04 2021 +0200
Commit: Gabor Kelemen 
CommitDate: Fri May 27 00:33:43 2022 +0200

external: update pdfium to 4643

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122485
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 
(cherry picked from commit 8cecaa622700cecb5b5776bd3e5360ac6cc3dd63)

Change-Id: I4e86b163a9abef88f26c6c0ae91ae0a4008658f1

diff --git a/download.lst b/download.lst
index 69f74fb7f72a..da08c1c0b47f 100644
--- a/download.lst
+++ b/download.lst
@@ -185,8 +185,8 @@ export OWNCLOUD_ANDROID_LIB_SHA256SUM := 
b18b3e3ef7fae6a79b62f2bb43cc47a5346b633
 export OWNCLOUD_ANDROID_LIB_TARBALL := 
owncloud-android-library-0.9.4-no-binary-deps.tar.gz
 export PAGEMAKER_SHA256SUM := 
3b5de037692f8e156777a75e162f6b110fa24c01749e4a66d7eb83f364e52a33
 export PAGEMAKER_TARBALL := libpagemaker-0.0.3.tar.bz2
-export PDFIUM_SHA256SUM := 
b0c5725e1cdcef7f52f068fd33adf9e8d833a271c28ba5b6a5a576ef8f2bbbf4
-export PDFIUM_TARBALL := pdfium-4568.tar.bz2
+export PDFIUM_SHA256SUM := 
eb98a77eaaab9e9e8de541cfd18b9438dd3c538bd5ef163820353179727f5dc9
+export PDFIUM_TARBALL := pdfium-4643.tar.bz2
 export PIXMAN_SHA256SUM := 
21b6b249b51c6800dc9553b65106e1e37d0e25df942c90531d4c3997aa20a88e
 export PIXMAN_TARBALL := e80ebae4da01e77f68744319f01d52a3-pixman-0.34.0.tar.gz
 export PNG_SHA256SUM := 
505e70834d35383537b6491e7ae8641f1a4bed1876dbfe361201fc80868d88ca
diff --git a/external/pdfium/Library_pdfium.mk 
b/external/pdfium/Library_pdfium.mk
index 20964c68e9ad..a238672a97f7 100644
--- a/external/pdfium/Library_pdfium.mk
+++ b/external/pdfium/Library_pdfium.mk
@@ -63,7 +63,6 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,pdfium,\
 UnpackedTarball/pdfium/fpdfsdk/cpdfsdk_actionhandler \
 UnpackedTarball/pdfium/fpdfsdk/cpdfsdk_annotiterator \
 UnpackedTarball/pdfium/fpdfsdk/cpdfsdk_customaccess \
-UnpackedTarball/pdfium/fpdfsdk/cpdfsdk_fieldaction \
 UnpackedTarball/pdfium/fpdfsdk/cpdfsdk_filewriteadapter \
 UnpackedTarball/pdfium/fpdfsdk/cpdfsdk_helpers \
 UnpackedTarball/pdfium/fpdfsdk/fpdf_annot \
@@ -109,7 +108,8 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,pdfium,\
 UnpackedTarball/pdfium/fpdfsdk/formfiller/cffl_textfield \
 UnpackedTarball/pdfium/fpdfsdk/formfiller/cffl_button \
 UnpackedTarball/pdfium/fpdfsdk/formfiller/cffl_textobject \
-UnpackedTarball/pdfium/fpdfsdk/formfiller/cffl_privatedata \
+UnpackedTarball/pdfium/fpdfsdk/formfiller/cffl_fieldaction \
+UnpackedTarball/pdfium/fpdfsdk/formfiller/cffl_perwindowdata \
 ))
 
 # fpdfapi
@@ -293,6 +293,7 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,pdfium,\
 UnpackedTarball/pdfium/core/fpdfapi/render/cpdf_pagerendercontext \
 UnpackedTarball/pdfium/core/fpdfapi/page/cpdf_transferfuncdib \
 UnpackedTarball/pdfium/core/fpdfapi/page/cpdf_transferfunc \
+

[Libreoffice-bugs] [Bug 149077] Change how Rounded Rectangle Callout is drawn in LibreOffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149077

--- Comment #4 from Regina Henschel  ---
(In reply to Rafael Lima from comment #3)
> (In reply to Regina Henschel from comment #2)
> > If you do not intend to save to the binary ppt format, then you can use the
> > ooxml-callout. That is in the Gallery theme "Shapes".
> 
> Regina, do you have a code pointer to where the rectangle callout is defined
> in LO?

The shape belongs to those, which have a corresponding shape in binary MS
Office. By import in filter/source/msfilter/msdffimp.cxx it gets a type from
enum MSO_SPT, in this case mso_sptWedgeRRectCallout = 62.
Coming from ODF we have the map from the value of
draw:type="rounded-rectangular-callout" in ODF to MSO_SPT in
/svx/source/customshapes/EnhancedCustomShapeTypeNames.cxx.

The MSO_SPT enum value is then mapped to a mso_CustomShape* in method
GetCustomShapeContent() at the end of
svx/source/customshapes/EnhancedCustomShapeGeometry.cxx, here
msoWedgeRRectCallout. The details for this shape are then around #5800 above in
this file.

> 
> I was looking for .uno:CalloutShapes and SID_DRAWTBX_CS_CALLOUT to try to
> figure out where LO pulls the coordinates for the callout, but I could not
> find it.

Depending on what you want to do, you likely need some more info. No problem
with that, but I need to know what you want to do, to help you further.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 89131] UI Control spin button for number of heading rows in dialog Insert Table is not working

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89131

--- Comment #11 from sdc.bla...@youmail.dk ---
Here is a proposal for a sentence to add to the description of "Heading rows"
in the help page:

The spinbox accepts values up to one less than the number of rows being
inserted.

https://gerrit.libreoffice.org/c/help/+/135004

(will leave tooltips to others...)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 89131] UI Control spin button for number of heading rows in dialog Insert Table is not working

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89131

--- Comment #11 from sdc.bla...@youmail.dk ---
Here is a proposal for a sentence to add to the description of "Heading rows"
in the help page:

The spinbox accepts values up to one less than the number of rows being
inserted.

https://gerrit.libreoffice.org/c/help/+/135004

(will leave tooltips to others...)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 89131] UI Control spin button for number of heading rows in dialog Insert Table is not working

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89131

--- Comment #10 from sdc.bla...@youmail.dk ---
(In reply to Regina Henschel from comment #9)
> Perhaps your table has not enough rows? 
That was exactly the problem.

Making the table with 6 rows was enough to use the spinbox to add three heading
rows (and these three heading rows are carried over to the next page of the
table, and the Text Flow tab in Table Properties gives the possibility to
change how many rows will be in the heading).

=> not a bug

But maybe a sign that this ticket should be converted to a Documentation bug.

There are extended tooltips for this dialog.  

But maybe a tooltip on the spinbox would help, such as:  

   Cannot be greater than number of rows - 1

(And actually that information could/should probably be added to the extended
tooltip as well.)

code pointer: sw/uiconfig/swriter/ui/inserttable.ui

Will leave question to UXEval...maybe as EasyHack...

Nothing is mentioned about this in the help page for this dialog:

https://help.libreoffice.org/7.4/en-US/text/swriter/01/0415.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 89131] UI Control spin button for number of heading rows in dialog Insert Table is not working

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89131

--- Comment #10 from sdc.bla...@youmail.dk ---
(In reply to Regina Henschel from comment #9)
> Perhaps your table has not enough rows? 
That was exactly the problem.

Making the table with 6 rows was enough to use the spinbox to add three heading
rows (and these three heading rows are carried over to the next page of the
table, and the Text Flow tab in Table Properties gives the possibility to
change how many rows will be in the heading).

=> not a bug

But maybe a sign that this ticket should be converted to a Documentation bug.

There are extended tooltips for this dialog.  

But maybe a tooltip on the spinbox would help, such as:  

   Cannot be greater than number of rows - 1

(And actually that information could/should probably be added to the extended
tooltip as well.)

code pointer: sw/uiconfig/swriter/ui/inserttable.ui

Will leave question to UXEval...maybe as EasyHack...

Nothing is mentioned about this in the help page for this dialog:

https://help.libreoffice.org/7.4/en-US/text/swriter/01/0415.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 147891] Regression: roundtrip of presentations/drawings including cropped PDF images is broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147891

--- Comment #4 from Callegar  ---
@raal

The dialog is there... not very easy to find, though.
If you do not have it in the menu, you can easily add it via the Tools ->
Customize functionality, searching for "Crop Image Dialog"

In any case the availability of the dialog is not essential to check for the
bug. It only makes it easier to have a fully reproducible procedure.  The bug
is there also in case of manual cropping using the cropping handles instead of
a dialog to enter numeric values for the crop margins.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149312] Support multi-paragraph items of lists

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149312

--- Comment #5 from Eyal Rozenberg  ---
(In reply to Regina Henschel from comment #4)
Thanks, and shame on me for not knowing any of this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 91456] "Fade smoothly" slide transition is broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91456

dldld  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |daniel-...@web.de
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 102062] [META] Notebookbar: bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102062

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||138440


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=138440
[Bug 138440] Calc missing the Right to Left and Left to Right buttons in Tabbed
mode
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138440] Calc missing the Right to Left and Left to Right buttons in Tabbed mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138440

Eyal Rozenberg  changed:

   What|Removed |Added

 Blocks||102062


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102062
[Bug 102062] [META] Notebookbar: bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149312] Support multi-paragraph items of lists

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149312

--- Comment #4 from Regina Henschel  ---
(In reply to Eyal Rozenberg from comment #3)
> (In reply to Regina Henschel from comment #2)
> > In case you are creating the list in Writer use the icon 'Insert unnumbered
> > entry' at the end of the paragraph and do not press Enter.
> 
> I'm not sue I understand what you've written here. How do I "use an icon"?
> Where is that icon located exactly?

In Writer, if you are inside a list, you should get the "Bullet and Numbering"
toolbar above the status bar. If it is not there, you can open it via menu View
> Toolbars. There you find the icon "Insert Unnumbered Entry".

The command does not work in Impress.

> 
> Anyway, ok, I realize now this is possible - but it's a relatively
> "well-hidden" feature.

Coming from other office suites you might not know it. But it exists in OOo/LO
from the beginning. And in contrast to Word, if you press Enter at the end of
such paragraph the numbering continues automatically in the next paragraph.

 Can I make this happen using the toolbar? The menu
> bar? Without first creating bulleted/numbered item?

For Impress it could be an enhancement to have this uno-command too. Currently
you really need to first generate the next paragraph with enter and then remove
its bullet/numbering with backspace-key. You might be able to combine these two
steps in a macro, I have not tested it. The fact, that the uno-command does not
work directly, I have tested.

In Writer you can customize any menu or toolbar to contain the command or you
can assign a short cut for it. When you use in the customize dialog the
category "Numbering" you will easily find it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: android/source

[Michael Weghorn (via logerrit)]

 android/source/build.gradle |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit be3f29bd103bf058eeef063823fd4049448ce27f
Author: Michael Weghorn 
AuthorDate: Thu May 26 09:48:27 2022 +0200
Commit: Michael Weghorn 
CommitDate: Thu May 26 22:06:04 2022 +0200

android: Update compileSdkVersion/targetSdkVersion to 32

API version 32 refers to the Android 12L feature drop
(Android 12.1).

According to [1], "12L is a special feature drop that makes Android 12
even better on tablets and foldable devices."

When getting over the list of behavior changes for apps targeting
Android 12, I didn't realize anyting relevant specific to API level 32
not yet in API level 31 as well, so there seems to be no need
for any special adjustments for this update on top of

commit 2ab389b251744fa7f3f6b060c09746e59d87f3b1
Date:   Tue Apr 19 10:33:27 2022 +0200

android: Update compileSdkVersion/targetSdkVersion to 31

[1] https://developer.android.com/about/versions/12/12L

Change-Id: Ic99c4ee5b81b6584648fa4717e23cc7f3c78bdab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134988
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/android/source/build.gradle b/android/source/build.gradle
index adb9b067d1b4..0e0cd6381053 100644
--- a/android/source/build.gradle
+++ b/android/source/build.gradle
@@ -31,7 +31,7 @@ dependencies {
 }
 
 android {
-compileSdkVersion 31
+compileSdkVersion 32
 // uses non-conventional source layout, so need to reconfigure accordingly
 // ToDo move to conventional layout, so stuff can be stripped down.
 sourceSets {
@@ -48,7 +48,7 @@ android {
 }
 defaultConfig {
 minSdkVersion 16
-targetSdkVersion 31
+targetSdkVersion 32
 vectorDrawables.useSupportLibrary = true
 }
 buildTypes {

[Libreoffice-commits] core.git: android/source

[Michael Weghorn (via logerrit)]

 android/source/build.gradle |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 97b1a21f9b7b7ed8a24da4a83a043e82de46683c
Author: Michael Weghorn 
AuthorDate: Thu May 26 09:18:05 2022 +0200
Commit: Michael Weghorn 
CommitDate: Thu May 26 22:05:20 2022 +0200

android: Update androidx.constraintlayout to 2.1.4

Change-Id: If2edff8006c3aa904d40dabf679d5ed0b0fd0127
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134987
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/android/source/build.gradle b/android/source/build.gradle
index 22cbb858d4fa..adb9b067d1b4 100644
--- a/android/source/build.gradle
+++ b/android/source/build.gradle
@@ -27,7 +27,7 @@ dependencies {
 "unoloader.jar"
 ])
 implementation 'com.google.android.material:material:1.6.0'
-implementation 'androidx.constraintlayout:constraintlayout:2.1.3'
+implementation 'androidx.constraintlayout:constraintlayout:2.1.4'
 }
 
 android {

[Libreoffice-commits] core.git: android/source

[Michael Weghorn (via logerrit)]

 android/source/build.gradle |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b6258ff75dd3c19e8309a33c85e17e8a76b388cf
Author: Michael Weghorn 
AuthorDate: Thu May 26 09:16:42 2022 +0200
Commit: Michael Weghorn 
CommitDate: Thu May 26 22:04:58 2022 +0200

android: Update com.google.android.material to 1.6.0

Change-Id: Iac3831d400d29b45be82d2585ca1454ed22676be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134986
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/android/source/build.gradle b/android/source/build.gradle
index 137501b39654..22cbb858d4fa 100644
--- a/android/source/build.gradle
+++ b/android/source/build.gradle
@@ -26,7 +26,7 @@ dependencies {
 "libreoffice.jar",
 "unoloader.jar"
 ])
-implementation 'com.google.android.material:material:1.5.0'
+implementation 'com.google.android.material:material:1.6.0'
 implementation 'androidx.constraintlayout:constraintlayout:2.1.3'
 }
 

[Libreoffice-bugs] [Bug 102062] [META] Notebookbar: bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102062

Thomas Lendo  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||5501

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135501] Change the default UI (see comment 67)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135501

Thomas Lendo  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||2062

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 135501] Change the default UI (see comment 67)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135501

Thomas Lendo  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||2062

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 149315] Support sequence of slides with the "same" title

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149315

Regina Henschel  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||rb.hensc...@t-online.de
 Status|UNCONFIRMED |NEW

--- Comment #1 from Regina Henschel  ---
Such automatic would need fields comparable with those in Writer. Impress has
only a very small set of fields.

It is a valid enhancement request.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149110] LibreOffice Base slows down if there is an unsaved change to the databse

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149110

--- Comment #3 from Robert Großkopf  ---
(In reply to Dr. Martinus from comment #2)
> it's the version from the distribution (Manjaro, KDE).

I have never worked with this system. Is it possible to install a *.deb or
*.rpm package on this system? You should try to install the original packages
from LO so we could see if it is a bug from LO. In other Linux distributions
you could install packaged from LO parallel to the version from the
distribution. Have installed here many different *.rpm-versions (OpenSUSE).

If it is impossible to install a package direct from LO: File a bug to Manjaro.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149077] Change how Rounded Rectangle Callout is drawn in LibreOffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149077

--- Comment #3 from Rafael Lima  ---
(In reply to Regina Henschel from comment #2)
> If you do not intend to save to the binary ppt format, then you can use the
> ooxml-callout. That is in the Gallery theme "Shapes".

Regina, do you have a code pointer to where the rectangle callout is defined in
LO?

I was looking for .uno:CalloutShapes and SID_DRAWTBX_CS_CALLOUT to try to
figure out where LO pulls the coordinates for the callout, but I could not find
it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135501] Change the default UI (see comment 67)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135501

--- Comment #132 from Eyal Rozenberg  ---
(In reply to Rafael Lima from comment #131)
> TBH my main goal in joining this discussion is to raise awareness about the
> problems we have in the Tabbed UI, which is possibly the second most popular
> UI variant, after the Standard Toolbar.
> 
> I don't really mind if it doesn't end up becoming the default UI. But I
> would love to see it receiving more love from devs.

Then - I apologize for my tone. The bug title, after all, is "change the
default UI", and that's how I (mis)-interpreted your post. Perhaps it would be
a good idea to split off a meta bug tracking fixes and improvements to the
Tabbed UI (and perhaps other UI variants (like tabbed compact and sidebar) -
away from the fire-and-brimstone of the argument about the default UI.

> Those who are not involved with LO development and news simply have not heard 
> of it and the way to change it is not very prominent so that new users will 
> easily learn that it exists.

Bug 137931 seems like the solution to that problem...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 135501] Change the default UI (see comment 67)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135501

--- Comment #132 from Eyal Rozenberg  ---
(In reply to Rafael Lima from comment #131)
> TBH my main goal in joining this discussion is to raise awareness about the
> problems we have in the Tabbed UI, which is possibly the second most popular
> UI variant, after the Standard Toolbar.
> 
> I don't really mind if it doesn't end up becoming the default UI. But I
> would love to see it receiving more love from devs.

Then - I apologize for my tone. The bug title, after all, is "change the
default UI", and that's how I (mis)-interpreted your post. Perhaps it would be
a good idea to split off a meta bug tracking fixes and improvements to the
Tabbed UI (and perhaps other UI variants (like tabbed compact and sidebar) -
away from the fire-and-brimstone of the argument about the default UI.

> Those who are not involved with LO development and news simply have not heard 
> of it and the way to change it is not very prominent so that new users will 
> easily learn that it exists.

Bug 137931 seems like the solution to that problem...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 149312] Support multi-paragraph items of lists

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149312

--- Comment #3 from Eyal Rozenberg  ---
(In reply to Regina Henschel from comment #2)
> In case you are creating the list in Writer use the icon 'Insert unnumbered
> entry' at the end of the paragraph and do not press Enter.

I'm not sue I understand what you've written here. How do I "use an icon"?
Where is that icon located exactly?

Anyway, ok, I realize now this is possible - but it's a relatively
"well-hidden" feature. Can I make this happen using the toolbar? The menu bar?
Without first creating bulleted/numbered item?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149312] Support multi-paragraph items of lists

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149312

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de
 Resolution|--- |WORKSFORME
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Regina Henschel  ---
That is already possible. Set the cursor at the start of the text of the
paragraph (after the number or bullet) and press the backspace-key. That
removes the number or bullet and the paragraph will belong to the same
list-item as the previous paragraph. That works in Writer and in Impress as
well.

In case you are creating the list in Writer use the icon 'Insert unnumbered
entry' at the end of the paragraph and do not press Enter.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 149248] Feature request: Option to not hyphenate last word in a paragraph

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149248

--- Comment #20 from László Németh  ---
@rferr...@sccoast.net, Heiko, Regina: thanks for the report!

(In reply to Regina Henschel from comment #7)
> I do not support the idea to have a special rule to prevent hyphenation
> between second last line and last line. But let's discuss it with UX-team.

Likely the requirement related to the easier work-flow: accessing to the
paragraph-level settings i.e. trying different hyphenation options is much more
comfortable for adjusting errors of the automatic hyphenation: you can try a
lot of combinations with a few click or short cuts, than selecting words and
text parts, which less productive, especially if the problematic word occurs
more in the document.

Interestingly, CSS 4 has got line-level rule, but Adobe InDesign has a
word-level, limiting the prevention only for the last word.

I think, it's really important to give similarly rich options for hyphenation,
than DTP software and future web browsers. My next plan to implement
hyphenation zone, which is a Word/OOXML feature. I have long term plan to give
some settings for better hyphenation for compound words, e.g. for
German/Hungarian. Maybe Better Spacing / Fewer Hyphens slider of InDesign is a
good user interface for that.

But ODF don't hyphenate character property is a nice feature, especially if we
could add a shortcut for that. In fact, if this is not for adjustment of the
paragraph text flow, but a bad or unwanted automatic hyphenation, Writer has
already supported to disable the hyphenation of a specific word, by adding an
equal mark to the plain word ("word=") in the custom hyphenation dictionary:

https://help.libreoffice.org/latest/lo/text/swriter/guide/hyphen_prevent.html?=SHARED=UNIX

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 149248] Feature request: Option to not hyphenate last word in a paragraph

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149248

--- Comment #20 from László Németh  ---
@rferr...@sccoast.net, Heiko, Regina: thanks for the report!

(In reply to Regina Henschel from comment #7)
> I do not support the idea to have a special rule to prevent hyphenation
> between second last line and last line. But let's discuss it with UX-team.

Likely the requirement related to the easier work-flow: accessing to the
paragraph-level settings i.e. trying different hyphenation options is much more
comfortable for adjusting errors of the automatic hyphenation: you can try a
lot of combinations with a few click or short cuts, than selecting words and
text parts, which less productive, especially if the problematic word occurs
more in the document.

Interestingly, CSS 4 has got line-level rule, but Adobe InDesign has a
word-level, limiting the prevention only for the last word.

I think, it's really important to give similarly rich options for hyphenation,
than DTP software and future web browsers. My next plan to implement
hyphenation zone, which is a Word/OOXML feature. I have long term plan to give
some settings for better hyphenation for compound words, e.g. for
German/Hungarian. Maybe Better Spacing / Fewer Hyphens slider of InDesign is a
good user interface for that.

But ODF don't hyphenate character property is a nice feature, especially if we
could add a shortcut for that. In fact, if this is not for adjustment of the
paragraph text flow, but a bad or unwanted automatic hyphenation, Writer has
already supported to disable the hyphenation of a specific word, by adding an
equal mark to the plain word ("word=") in the custom hyphenation dictionary:

https://help.libreoffice.org/latest/lo/text/swriter/guide/hyphen_prevent.html?=SHARED=UNIX

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144168] Inconsistent ratio between Dialog.Model.Height and the height on the screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144168

Michael  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Michael  ---
Thank you. I have tested those two spreadsheets, and they work very well! Your
functions will be very useful.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149248] Feature request: Option to not hyphenate last word in a paragraph

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149248

--- Comment #19 from László Németh  ---
(In reply to Telesto from comment #16)
> (In reply to László Németh from comment #14)
> > Proposed fix: https://gerrit.libreoffice.org/c/core/+/134985
> > 
> > See the attached screenshot about the new option
> 
> A) How is this handled at DOCX/DOC export code? Or is this an incompatible
> feature  (off-topic: is there a incompatibility list for DOCX/DOC. I thought
> Justin L keeping track of that somewhere on a wikipage)

If Word will implement the similar CSS settings, it will be possible to support
those immediately. Also it's possible to add this to the HTML/CSS export
(first, start with the missing hyphenation).

> B) Does the setting also appear in the Style Inspector (yes, I can also
> check it myself after the patch is merged). I assume the code being genetic
> enough, but checking never hurts)

Yes, it's generic. Moreover, it needed to fix the style inspector tests, which
contain direct property count, so it works well

See also tdf#149324 for the similar typographic option, the paragraph-level
limit for the min. word length for hyphenation.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 149248] Feature request: Option to not hyphenate last word in a paragraph

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149248

--- Comment #19 from László Németh  ---
(In reply to Telesto from comment #16)
> (In reply to László Németh from comment #14)
> > Proposed fix: https://gerrit.libreoffice.org/c/core/+/134985
> > 
> > See the attached screenshot about the new option
> 
> A) How is this handled at DOCX/DOC export code? Or is this an incompatible
> feature  (off-topic: is there a incompatibility list for DOCX/DOC. I thought
> Justin L keeping track of that somewhere on a wikipage)

If Word will implement the similar CSS settings, it will be possible to support
those immediately. Also it's possible to add this to the HTML/CSS export
(first, start with the missing hyphenation).

> B) Does the setting also appear in the Style Inspector (yes, I can also
> check it myself after the patch is merged). I assume the code being genetic
> enough, but checking never hurts)

Yes, it's generic. Moreover, it needed to fix the style inspector tests, which
contain direct property count, so it works well

See also tdf#149324 for the similar typographic option, the paragraph-level
limit for the min. word length for hyphenation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 89131] UI Control spin button for number of heading rows in dialog Insert Table is not working

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89131

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #9 from Regina Henschel  ---
I cannot confirm the problem. I can increase the number of heading rows with
the spin button and the generated table has the number of heading rows as set.

Tested with Version: 7.3.2.2 (x64) / LibreOffice Community
Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: CL

Perhaps your table has not enough rows? Set the number of rows to 20 in the
upper part of the dialog, for example, and try again.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 89131] UI Control spin button for number of heading rows in dialog Insert Table is not working

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89131

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #9 from Regina Henschel  ---
I cannot confirm the problem. I can increase the number of heading rows with
the spin button and the generated table has the number of heading rows as set.

Tested with Version: 7.3.2.2 (x64) / LibreOffice Community
Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: CL

Perhaps your table has not enough rows? Set the number of rows to 20 in the
upper part of the dialog, for example, and try again.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 149324] Add paragraph property for Hyphenation option "Minimum Word Length"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149324

László Németh  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
 CC||nem...@numbertext.org
   Assignee|nem...@numbertext.org   |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #3 from László Németh  ---
Commit description:

tdf#149324 sw offapi xmloff: add option to not hyphenate short words

Add paragraph property to disable automatic hyphenation of short
words based on a minimum character count.

Note: there is a (broken) global option for Minimum Word Length
at hyphenation, see "Minimal number of characters for hyphenation"
in Tools->Options->Language Settings->Writing Aids), but
for better/comfortable paragraph-level adjustment of typesetting,
add a paragraph property for it. The same option is available e.g.
in Adobe InDesign and in CSS Text Module Level 4 (hyphenate-limit-chars).

* Add checkbox to Text Flow in paragraph dialog
* Store property in paragraph model
(com::sun::star::style::ParagraphProperties::ParaHyphenationMinWordLength)
* Add ODF import/export
* Add ODF unit test
* Add layout test

Follow-up to commit 8c018910ae4d8701b1ce2a95727b9baed4016da3
"tdf#149248 sw offapi xmloff: add option to not hyphenate last word".

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146955] SAXParseException: '[word/footnotes.xml line 2] after RT save of DOCX - on open by LO and not by MSO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146955

--- Comment #10 from Commit Notification 
 ---
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/73696a01224a3758bde686f32ec7e6f4c90877fe

tdf#146955 DOCX import: fix SAX exception with footnotes

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146955] SAXParseException: '[word/footnotes.xml line 2] after RT save of DOCX - on open by LO and not by MSO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146955

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104448] [META] DOCX SAXParseException

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104448
Bug 104448 depends on bug 146955, which changed state.

Bug 146955 Summary: SAXParseException: '[word/footnotes.xml line 2] after RT 
save of DOCX - on open by LO and not by MSO
https://bugs.documentfoundation.org/show_bug.cgi?id=146955

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146955] SAXParseException: '[word/footnotes.xml line 2] after RT save of DOCX - on open by LO and not by MSO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146955

László Németh  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
   Assignee|nem...@numbertext.org   |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #9 from László Németh  ---
Commit description:

tdf#146955 DOCX import: fix SAX exception with footnotes

(Likely broken) DOCX documents exported by Writer raised a SAX
exception, when PopFootOrEndnote() tried to access to a
not-existent footnote, because PushFootOrEndnote() failed to
create that.

Note: the original ODT contains hundreds of frames, and
these and the text content of the document have been put
into the TOC section during Writer's DOCX export, resulting a
broken document.

Regression from commit 9b39ce0e66acfe812e1d50e530dc2ccdef3e1357
"tdf#76260 DOCX import: fix slow footnote import".

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa writerfilter/source

[László Németh (via logerrit)]

 sw/qa/extras/ooxmlexport/data/tdf146955.odt   |binary
 sw/qa/extras/ooxmlexport/ooxmlexport17.cxx|   12 
 writerfilter/source/dmapper/DomainMapper_Impl.cxx |   12 +---
 3 files changed, 17 insertions(+), 7 deletions(-)

New commits:
commit 73696a01224a3758bde686f32ec7e6f4c90877fe
Author: László Németh 
AuthorDate: Wed May 25 11:57:13 2022 +0200
Commit: László Németh 
CommitDate: Thu May 26 20:26:13 2022 +0200

tdf#146955 DOCX import: fix SAX exception with footnotes

(Likely broken) DOCX documents exported by Writer raised a SAX
exception, when PopFootOrEndnote() tried to access to a
not-existent footnote, because PushFootOrEndnote() failed to
create that.

Note: the original ODT contains hundreds of frames, and
these and the text content of the document have been put
into the TOC section during Writer's DOCX export, resulting a
broken document.

Regression from commit 9b39ce0e66acfe812e1d50e530dc2ccdef3e1357
"tdf#76260 DOCX import: fix slow footnote import".

Change-Id: I9e32feb0cae778a87f034a8b5c41989fec90899d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134934
Tested-by: Jenkins
Reviewed-by: László Németh 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf146955.odt 
b/sw/qa/extras/ooxmlexport/data/tdf146955.odt
new file mode 100644
index ..c7a849f9b756
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf146955.odt differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
index d3804717e29c..fd6c560395b5 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
@@ -9,6 +9,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -813,6 +814,17 @@ DECLARE_OOXMLEXPORT_TEST(testTdf144563, "tdf144563.docx")
 }
 }
 
+// broken test document?
+#if !defined(_WIN32)
+DECLARE_OOXMLEXPORT_TEST(testTdf146955, "tdf146955.odt")
+{
+// import of a (broken?) DOCX export with dozens of frames raised a SAX 
exception,
+// when the code tried to access to a non-existent footnote
+uno::Reference xNotes(mxComponent, 
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xNotes->getFootnotes()->getCount());
+}
+#endif
+
 DECLARE_OOXMLEXPORT_TEST(testTdf144668, "tdf144668.odt")
 {
 uno::Reference xPara1(getParagraph(1, u"level1"), 
uno::UNO_QUERY);
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 1371b7cc0e32..4e769e15b0cf 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -3504,13 +3504,11 @@ void DomainMapper_Impl::PopFootOrEndnote()
 uno::Reference< text::XFootnote > xFootnoteFirst, xFootnoteLast;
 auto xFootnotes = xFootnotesSupplier->getFootnotes();
 auto xEndnotes = xEndnotesSupplier->getEndnotes();
-if (IsInFootnote())
-xFootnotes->getByIndex(xFootnotes->getCount()-1) >>= xFootnoteLast;
-else
-xEndnotes->getByIndex(xEndnotes->getCount()-1) >>= xFootnoteLast;
-if ( ( ( IsInFootnote() && xFootnotes->getCount() > 1 ) ||
- ( !IsInFootnote() && xEndnotes->getCount() > 1 ) ) &&
-xFootnoteLast->getLabel().isEmpty() )
+if ( ( ( IsInFootnote() && xFootnotes->getCount() > 1 &&
+   ( xFootnotes->getByIndex(xFootnotes->getCount()-1) >>= 
xFootnoteLast ) ) ||
+   ( !IsInFootnote() && xEndnotes->getCount() > 1 &&
+   ( xEndnotes->getByIndex(xEndnotes->getCount()-1) >>= 
xFootnoteLast ) )
+ ) && xFootnoteLast->getLabel().isEmpty() )
 {
 // copy content of the first remaining temporary footnote
 if ( IsInFootnote() )

[Libreoffice-commits] core.git: cui/source cui/uiconfig editeng/source include/editeng include/xmloff offapi/com schema/libreoffice svx/sdi sw/inc sw/qa sw/source xmloff/source

[László Németh (via logerrit)]

 cui/source/inc/paragrph.hxx |1 
 cui/source/tabpages/paragrph.cxx|   10 ++
 cui/uiconfig/ui/textflowpage.ui |   41 
 editeng/source/items/paraitem.cxx   |   19 -
 include/editeng/editrids.hrc|1 
 include/editeng/hyphenzoneitem.hxx  |4 +
 include/editeng/memberids.h |1 
 include/xmloff/xmltoken.hxx |1 
 offapi/com/sun/star/style/ParagraphProperties.idl   |5 +
 schema/libreoffice/OpenDocument-v1.3+libreoffice-schema.rng |   12 +++
 svx/sdi/svxitems.sdi|9 +-
 sw/inc/inspectorproperties.hrc  |1 
 sw/inc/unoprnms.hxx |1 
 sw/qa/extras/layout/data/tdf149324.odt  |binary
 sw/qa/extras/layout/layout.cxx  |   15 
 sw/qa/extras/odfexport/data/tdf149324.odt   |binary
 sw/qa/extras/odfexport/odfexport.cxx|7 ++
 sw/qa/uitest/styleInspector/styleInspector.py   |   20 ++---
 sw/qa/uitest/styleInspector/tdf137513.py|2 
 sw/source/core/text/inftxt.cxx  |   14 ++--
 sw/source/core/unocore/unomapproperties.hxx |2 
 sw/source/uibase/app/docshini.cxx   |1 
 sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx   |1 
 xmloff/source/core/xmltoken.cxx |1 
 xmloff/source/text/txtprmap.cxx |1 
 xmloff/source/token/tokens.txt  |1 
 26 files changed, 147 insertions(+), 24 deletions(-)

New commits:
commit 29359fc15c435cec17987fd6221ab6833d38746e
Author: László Németh 
AuthorDate: Thu May 26 19:01:07 2022 +0200
Commit: László Németh 
CommitDate: Thu May 26 20:25:35 2022 +0200

tdf#149324 sw offapi xmloff: add option to not hyphenate short words

Add paragraph property to disable automatic hyphenation of short
words based on a minimum character count.

Note: there is a (broken) global option for Minimum Word Length
at hyphenation, see "Minimal number of characters for hyphenation"
in Tools->Options->Language Settings->Writing Aids), but
for better/comfortable paragraph-level adjustment of typesetting,
add a paragraph property for it. The same option is available e.g.
in Adobe InDesign and in CSS Text Module Level 4 (hyphenate-limit-chars).

* Add checkbox to Text Flow in paragraph dialog
* Store property in paragraph model 
(com::sun::star::style::ParagraphProperties::ParaHyphenationMinWordLength)
* Add ODF import/export
* Add ODF unit test
* Add layout test

Follow-up to commit 8c018910ae4d8701b1ce2a95727b9baed4016da3
"tdf#149248 sw offapi xmloff: add option to not hyphenate last word".

Change-Id: I68715f47d17b5c022430bd0e74c88a97bc7f81f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135028
Tested-by: Jenkins
Reviewed-by: László Németh 

diff --git a/cui/source/inc/paragrph.hxx b/cui/source/inc/paragrph.hxx
index 0967c32a060e..f0c56775fc2c 100644
--- a/cui/source/inc/paragrph.hxx
+++ b/cui/source/inc/paragrph.hxx
@@ -232,6 +232,7 @@ private:
 std::unique_ptr m_xExtHyphenAfterBox;
 std::unique_ptr m_xMaxHyphenLabel;
 std::unique_ptr m_xMaxHyphenEdit;
+std::unique_ptr m_xMinWordLength;
 
 // pagebreak
 std::unique_ptr m_xPageBreakBox;
diff --git a/cui/source/tabpages/paragrph.cxx b/cui/source/tabpages/paragrph.cxx
index 29bc2fc76b43..2d651fedae6a 100644
--- a/cui/source/tabpages/paragrph.cxx
+++ b/cui/source/tabpages/paragrph.cxx
@@ -1355,7 +1355,8 @@ bool SvxExtParagraphTabPage::FillItemSet( SfxItemSet* 
rOutSet )
  m_xHyphenNoLastWordBox->get_state_changed_from_saved() ||
  m_xExtHyphenBeforeBox->get_value_changed_from_saved() ||
  m_xExtHyphenAfterBox->get_value_changed_from_saved() ||
- m_xMaxHyphenEdit->get_value_changed_from_saved() )
+ m_xMaxHyphenEdit->get_value_changed_from_saved() ||
+ m_xMinWordLength->get_value_changed_from_saved() )
 {
 SvxHyphenZoneItem aHyphen(
 static_cast(GetItemSet().Get( _nWhich )) 
);
@@ -1367,6 +1368,7 @@ bool SvxExtParagraphTabPage::FillItemSet( SfxItemSet* 
rOutSet )
 {
 aHyphen.GetMinLead() = 
static_cast(m_xExtHyphenBeforeBox->get_value());
 aHyphen.GetMinTrail() = 
static_cast(m_xExtHyphenAfterBox->get_value());
+aHyphen.GetMinWordLength() = 
static_cast(m_xMinWordLength->get_value());
 }
 aHyphen.GetMaxHyphens() = 
static_cast(m_xMaxHyphenEdit->get_value());
 
@@ -1577,6 +1579,7 @@ void SvxExtParagraphTabPage::Reset( const 

[Libreoffice-bugs] [Bug 147698] Typing (") after a fraction or an (') to show possession causes a large spacing (7.3.0.3 - x64)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147698

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #1 from raal  ---
no repro with Version: 7.4.0.0.alpha1+ / LibreOffice Community
Build ID: b6e0ae1b1bad5e222e21bbb4b2a158c1fc6f9779
CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147749] calc issuing X11 activate hint when "Find" bottom tab is opened

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147749

--- Comment #1 from raal  ---
I'm afraid, no one want read chat conversation. Please can you make clear
description of the bug?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120550] Draw - Changes to table size "Optimal" features need documentation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120550

--- Comment #10 from Justin L  ---
(In reply to sdc.blanco from comment #5)
> Do any of the relevant pages need updating?
All of the relevant pages will need updating since all functions have been
tweaked.

(In reply to sdc.blanco from comment #6)
> Have now found "Optimize Size"
> iiuc -- this page needs the following controls added for Draw:
> 
> "Minimal Row Height"
> "Minimal Column Width"
> "Optimal Row Height"
> "Optimal Column Width"
Yes, and the descriptions for "Distribute * Equally" might need to be corrected
as well.

> I assume that the "Optimize Size" toolbar in Draw and Writer have (a) the
> same controls, and (b) the same behavior.
The same controls, yes. The behaviour is approximately the same, but not
completely as indicated in comment 1 (since the code is completely different).

(In reply to sdc.blanco from comment #7)
> Just to be sure... no such menu for Calc?
Correct.

(In reply to sdc.blanco from comment #8)
> Writer:  "Minimize Row Height"  "Minimize Column Width"
> Draw/Impress:  "Minimal Row Height" "Minimal Column Width"
> 
> (but it looks like they use the same .uno:SetMinimalRowHeight and
> uno:SetMinimalColumnWidth )
Yes, these ought to be the same wording. Probably "minimal" to match "optimal"

(In reply to sdc.blanco from comment #9)
> but it is possible that the text that appears in
> https://help.libreoffice.org/master/en-US/text/swriter/main0110.html (with
> possible additions) would be correct/adequate in relation to Draw/Impress (?)
These descriptions are not very accurate or complete.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144168] Inconsistent ratio between Dialog.Model.Height and the height on the screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144168

--- Comment #4 from Vladimir Sokolinskiy  ---
Created attachment 180418
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180418=edit
TestCellCoordinates.ods

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147771] Impress. If remove all characters in any cell in the table of attach file, save and reopen then return character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147771

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
Version|7.3.0.3 release |4.2.0.4 release
 CC||r...@post.cz
 Ever confirmed|0   |1

--- Comment #2 from raal  ---
-open file-
- delete text Balance inicial (en miles)
- save
- reload

confirm with Version: 7.4.0.0.alpha1+ / LibreOffice Community
Build ID: b6e0ae1b1bad5e222e21bbb4b2a158c1fc6f9779
CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo

and Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144168] Inconsistent ratio between Dialog.Model.Height and the height on the screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144168

Vladimir Sokolinskiy  changed:

   What|Removed |Added

 Attachment #180417|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147891] Regression: roundtrip of presentations/drawings including cropped PDF images is broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147891

--- Comment #3 from raal  ---
(In reply to raal from comment #2)
> Hello, 
> I doesn't see crop dialog in Draw:
> 3. Use "crop dialog" to crop at 119 mm top and 28 mm bottom
> According the help page
> https://help.libreoffice.org/latest/he/text/shared/02/2410.html this
> dialog is not available in Draw.
> 
> Tested with Version: 7.2.0.0.alpha1+ / LibreOffice Community
> Build ID: ff2ba77f22b2e96f96f5537aec1705956b47583d
> CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3
> Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
> Calc: threaded
> and tried reproduce your steps. I cannot confirm the bug.

Also tested Version: 7.4.0.0.alpha1+ / LibreOffice Community
Build ID: b6e0ae1b1bad5e222e21bbb4b2a158c1fc6f9779
CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147891] Regression: roundtrip of presentations/drawings including cropped PDF images is broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147891

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #2 from raal  ---
Hello, 
I doesn't see crop dialog in Draw:
3. Use "crop dialog" to crop at 119 mm top and 28 mm bottom
According the help page
https://help.libreoffice.org/latest/he/text/shared/02/2410.html this dialog
is not available in Draw.

Tested with Version: 7.2.0.0.alpha1+ / LibreOffice Community
Build ID: ff2ba77f22b2e96f96f5537aec1705956b47583d
CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded
and tried reproduce your steps. I cannot confirm the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144168] Inconsistent ratio between Dialog.Model.Height and the height on the screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144168

--- Comment #3 from Vladimir Sokolinskiy  ---
Created attachment 180417
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180417=edit
TestCellCoordinates.ods

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144168] Inconsistent ratio between Dialog.Model.Height and the height on the screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144168

--- Comment #2 from Vladimir Sokolinskiy  ---
Mike, the problem was discussed in the topic "Dynamically position a dialog"
([1]).
The solution was found using the AccessibleContext interfaces.
The example in the attachment TestCellCoordinates.ods . Double-clicking a cell
should position the dialog at the top left corner of the cell. The relative
position must be the same for all cells shown on the screen and not change when
the zoom changes.

[1] https://ask.libreoffice.org/t/dynamically-position-a-dialog/67289/32

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 90796] [META] HiDPI / Retina bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90796

Rafael Lima  changed:

   What|Removed |Added

 Depends on||149291


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=149291
[Bug 149291] Mouse cursor freeze if I resize sidebar in Writer / Calc
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149291] Mouse cursor freeze if I resize sidebar in Writer / Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149291

Rafael Lima  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
  Component|LibreOffice |graphics stack
 Blocks||90796
 Ever confirmed|1   |0

--- Comment #3 from Rafael Lima  ---
Apparently we have a problem calculating the maximum width of the sidebar when
a scaling factor is applied.

I do not have a PC with a 4K display to confirm this bug. So I'm setting this
to UNCONFIRMED for now to see if anyone else with a 4K display to test it.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=90796
[Bug 90796] [META] HiDPI / Retina bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140793] FORMATTING - When an image is anchored as character and centered or right aligned and you resize it to be smaller the text doesn't follow.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140793

--- Comment #3 from wpeat...@gmail.com ---
I can confirm this bug. It has been present for years

A workaround for this problem is to change the paragraph to left aligned, then
back to center (or right) aligned. Writer seems to immediately recalculate the
layout correctly when the paragraph is switch to left aligned.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149173] Crash BigPtrEntry::GetArray(this=0x0000600001726940) const at bparr.hxx:106:23 (STR: comment 3)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149173

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #8 from raal  ---
No crash with Version: 7.4.0.0.alpha1+ / LibreOffice Community
Build ID: b6e0ae1b1bad5e222e21bbb4b2a158c1fc6f9779
CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: x11
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149248] Feature request: Option to not hyphenate last word in a paragraph

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149248

László Németh  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||9324

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 149248] Feature request: Option to not hyphenate last word in a paragraph

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149248

László Németh  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||9324

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 149324] Add paragraph property for Hyphenation option "Minimum Word Length"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149324

László Németh  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |nem...@numbertext.org
   |desktop.org |
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||9248
 Ever confirmed|0   |1
 Status|UNCONFIRMED |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144167] exported PNG image has wrong size when page has border

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144167

--- Comment #17 from Valerio Messina  ---
I made some tests with a just installed

Version: 7.4.0.0.alpha1+ / LibreOffice Community
Build ID: fd45045cc3029b41c02a2634e6fe2e5456f716ad
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk3
Locale: it-IT (it_IT.UTF-8); UI: en-US
Calc: threaded

on Debian 11/x86_64


On first run, LO is configured with this export settings default:
1) Dimensions unit: cm
2) Resolution: 37 pixel/cm
3) Compression: 6

I changed to:
1) Dimensions unit: mm
2) Resolution: 96 pixel/inch
3) Compression: 9


Then perform some extractions with:
. Modify resolution: 300 pixels/inch
. Modify dimensions, Width: 320 mm
. the Height is set by LO to 220.03 mm and width to 320.03 mm

Results:
- The output aspect ratio is the one of page, and not the one of the rectangle
- the output images is sized: 3786x2603 px, that at 300 dpi, has a size of
320.55x220.39 mm
- LO7.4 export to PNG the rectangle without the 10 mm page border (like LO7.2)
  and in contrast to export as PDF (but may be reasonable)

So the 300x200 mm source rectangle is stretched to 320.55x220.39 mm in exported
PNG
This is out of scale of about 320/300=1.06 periodic,
and worse the image is still with the wrong aspect ratio like was with LO7.2
This is still wrong but better than LO7.2


As the 10mm border is always omitted in exported PNG, I repeated the tests
with:
. Modify resolution: 300 pixels/inch
. Modify dimensions, Width: 300 mm
. the Height is set by LO to 206.26 mm while width remain to 300.00 mm

Results:
- The output aspect ratio is the one of page, and not the one of the rectangle
- the output images is sized: 3549x2440 px, that at 300 dpi, has a size of
300.48x206.59 mm

So the 300x200 mm source rectangle is stretched to 300.48x206.59 mm in exported
PNG
this is out of scale of about 300.48/300=1.0016  on X asis, 0.5 mm error maybe
acceptable, but
this is out of scale of about 206.59/200=1.03295 on Y asis, 6.59 mm error this
is wrong.
So the image is still with the wrong aspect ratio:
original rectangle has 300/200=1.5 aspect ratio
exported rectangle has 300.48/206.59=1.454475 aspect ratio


Note 1: LO should export the drawing area (the 300x200 mm rectangle) keeping
his aspect ratio,
and not use the one of the page (that include the 10 mm border).

Note 2: There are various approximation in LO compute for output pixels, that
round the numbers in the wrong way too.
Maybe caused by the use of a float instead of a double in some variables.

Note 3: I cannot test on Win, as the only PC with Win I had access, is the
company PC, but I cannot install an Alpha level application on it

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149324] New: Add paragraph property for Hyphenation option "Minimum Word Length"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149324

Bug ID: 149324
   Summary: Add paragraph property for Hyphenation option "Minimum
Word Length"
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: nem...@numbertext.org

Description:
While there is a (broken) global option for Minimum Word Length at hyphenation
(see "Minimal number of characters for hyphenation" in Tools->Options->Language
Settings->Writing Aids), for better/comfortable paragraph level adjustment, add
a paragraph property for is.

Steps to Reproduce:
Open the attached test document.

Actual Results:
No option to set min. word length on paragraph-level.

Expected Results:
There is a hyphenation option for that in paragraph settings, similar to
Remaining/Trailing characters.


Reproducible: Always


User Profile Reset: No



Additional Info:
This is an interoperability feature, because DTP software, e.g. Adobe InDesign
and CSS Text Module Level 4 "hyphenate-limit-chars" support this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149264] assert in checkGlyphsEqual() when loading sw/qa/extras/uiwriter/data/tdf104649.docx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149264

Michael Stahl (allotropia)  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #9 from Michael Stahl (allotropia)  ---
yep no more asserts

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: i18npool/inc i18npool/source

[Noel Grandin (via logerrit)]

 i18npool/inc/breakiteratorImpl.hxx |3 ++-
 i18npool/inc/calendarImpl.hxx  |5 +++--
 i18npool/inc/cclass_unicode.hxx|2 +-
 i18npool/inc/characterclassificationImpl.hxx   |7 ---
 i18npool/inc/collatorImpl.hxx  |5 +++--
 i18npool/inc/inputsequencechecker.hxx  |5 +++--
 i18npool/inc/textconversionImpl.hxx|3 ++-
 i18npool/source/characterclassification/cclass_unicode.cxx |5 +++--
 i18npool/source/localedata/LocaleNode.cxx  |5 +++--
 i18npool/source/localedata/LocaleNode.hxx  |2 +-
 10 files changed, 25 insertions(+), 17 deletions(-)

New commits:
commit 3cde7345199b535763bb7d83a87096e9157b7317
Author: Noel Grandin 
AuthorDate: Thu May 26 10:46:16 2022 +0200
Commit: Noel Grandin 
CommitDate: Thu May 26 18:30:04 2022 +0200

clang-tidy modernize-pass-by-value in i18npool

Change-Id: I96d99fbdce2b0432676acec8b327cece7c39bcb7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134983
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/i18npool/inc/breakiteratorImpl.hxx 
b/i18npool/inc/breakiteratorImpl.hxx
index c27645a60ef2..a2700b7a9bf9 100644
--- a/i18npool/inc/breakiteratorImpl.hxx
+++ b/i18npool/inc/breakiteratorImpl.hxx
@@ -22,6 +22,7 @@
 #include 
 #include 
 
+#include 
 #include 
 
 namespace com::sun::star::uno { class XComponentContext; }
@@ -103,7 +104,7 @@ protected:
 private:
 
 struct lookupTableItem {
-lookupTableItem(const css::lang::Locale& _aLocale, css::uno::Reference 
< XBreakIterator > const & _xBI) : aLocale(_aLocale), xBI(_xBI) {};
+lookupTableItem(css::lang::Locale _aLocale, css::uno::Reference < 
XBreakIterator > _xBI) : aLocale(std::move(_aLocale)), xBI(std::move(_xBI)) {};
 css::lang::Locale aLocale;
 css::uno::Reference < XBreakIterator > xBI;
 };
diff --git a/i18npool/inc/calendarImpl.hxx b/i18npool/inc/calendarImpl.hxx
index 4d90ed0ef2be..0580a878535e 100644
--- a/i18npool/inc/calendarImpl.hxx
+++ b/i18npool/inc/calendarImpl.hxx
@@ -21,6 +21,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 namespace com::sun::star::uno { class XComponentContext; }
@@ -92,8 +93,8 @@ public:
 
 private:
 struct lookupTableItem {
-lookupTableItem(const OUString& rCacheID, css::uno::Reference < 
css::i18n::XCalendar4 > const & _xCalendar)
-: m_aCacheID(rCacheID), xCalendar(_xCalendar) {}
+lookupTableItem(OUString aCacheID, css::uno::Reference < 
css::i18n::XCalendar4 > _xCalendar)
+: m_aCacheID(std::move(aCacheID)), 
xCalendar(std::move(_xCalendar)) {}
 OUString  m_aCacheID;
 css::uno::Reference < css::i18n::XCalendar4 > xCalendar;
 };
diff --git a/i18npool/inc/cclass_unicode.hxx b/i18npool/inc/cclass_unicode.hxx
index a10fe84eb8d9..03c03d5bbc97 100644
--- a/i18npool/inc/cclass_unicode.hxx
+++ b/i18npool/inc/cclass_unicode.hxx
@@ -64,7 +64,7 @@ namespace i18npool {
 class cclass_Unicode final : public cppu::WeakImplHelper < 
css::i18n::XCharacterClassification, css::lang::XServiceInfo >
 {
 public:
-cclass_Unicode(const css::uno::Reference < css::uno::XComponentContext >& 
rxContext );
+cclass_Unicode(css::uno::Reference < css::uno::XComponentContext > 
xContext );
 virtual ~cclass_Unicode() override;
 
 virtual OUString SAL_CALL toUpper( const OUString& Text, sal_Int32 nPos, 
sal_Int32 nCount,
diff --git a/i18npool/inc/characterclassificationImpl.hxx 
b/i18npool/inc/characterclassificationImpl.hxx
index 6ae8dee6c572..bcfc7836a92f 100644
--- a/i18npool/inc/characterclassificationImpl.hxx
+++ b/i18npool/inc/characterclassificationImpl.hxx
@@ -20,6 +20,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -68,9 +69,9 @@ public:
 
 private:
 struct lookupTableItem {
-lookupTableItem(const css::lang::Locale& rLocale, const OUString& 
rName,
-css::uno::Reference < XCharacterClassification > const 
& rxCI) :
-aLocale(rLocale), aName(rName), xCI(rxCI) {};
+lookupTableItem(css::lang::Locale _aLocale, OUString _aName,
+css::uno::Reference < XCharacterClassification > _xCI) 
:
+aLocale(std::move(_aLocale)), aName(std::move(_aName)), 
xCI(std::move(_xCI)) {};
 css::lang::Locale aLocale;
 OUString aName;
 css::uno::Reference < XCharacterClassification > xCI;
diff --git a/i18npool/inc/collatorImpl.hxx b/i18npool/inc/collatorImpl.hxx
index 061333d84df9..4d2eee6b7fa9 100644
--- a/i18npool/inc/collatorImpl.hxx
+++ b/i18npool/inc/collatorImpl.hxx
@@ -24,6 +24,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 
@@ -79,8 +80,8 @@ private:
 OUString algorithm;
 OUString service;
 css::uno::Reference < XCollator 

[Libreoffice-commits] core.git: sc/source

[Caolán McNamara (via logerrit)]

 sc/source/ui/drawfunc/drawsh2.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b566a5f5cef881c858d14d434df2b82b6d07d687
Author: Caolán McNamara 
AuthorDate: Thu May 26 12:15:51 2022 +0100
Commit: Caolán McNamara 
CommitDate: Thu May 26 18:27:31 2022 +0200

cid#1504573 Dereference before null check

since...

commit 8b4b852a35149b1cfffc681cbb4f57d4c0b671b3
Date:   Mon May 23 15:48:41 2022 +0200

Advanced Diagram support: Isolated IDiagramHelper, selection 
visualization

we've already derefed pObj so can drop that check

Change-Id: I9bdab5c069405c0015f74e4621e7b37fbbed2dd8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135017
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/ui/drawfunc/drawsh2.cxx 
b/sc/source/ui/drawfunc/drawsh2.cxx
index 020178be50ce..806216137a6d 100644
--- a/sc/source/ui/drawfunc/drawsh2.cxx
+++ b/sc/source/ui/drawfunc/drawsh2.cxx
@@ -270,7 +270,7 @@ void ScDrawShell::GetDrawFuncState( SfxItemSet& rSet )  
// disable functions
 rSet.DisableItem( SID_FITCELLSIZE );
 
 // Support advanced DiagramHelper
-if(!pObj || !pObj->isDiagram())
+if (!pObj->isDiagram())
 {
 rSet.DisableItem( SID_REGENERATE_DIAGRAM );
 rSet.DisableItem( SID_EDIT_DIAGRAM );

[Libreoffice-commits] core.git: sw/qa

[Andrea Gelmini (via logerrit)]

 sw/qa/extras/ooxmlexport/ooxmlexport17.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8148896dc8a81f4d4aeddae8527c18ab2db1aa3a
Author: Andrea Gelmini 
AuthorDate: Fri May 20 11:17:08 2022 +0200
Commit: Julien Nabet 
CommitDate: Thu May 26 17:47:06 2022 +0200

Fix typo

Change-Id: Id418d65ce165d93e84463ae321ca2db869e857cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134670
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
index 281884057770..d3804717e29c 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
@@ -871,7 +871,7 @@ DECLARE_OOXMLEXPORT_TEST(testTdf148132, "tdf148132.docx")
 comphelper::SequenceAsHashMap levelProps(xLevels->getByIndex(1));
 OUString aCharStyleName = levelProps["CharStyleName"].get();
 // Ensure that numbering in this paragraph is 24pt bold italic
-// Previously it got overriden by paragraph properties and became 6pt, 
no bold, no italic
+// Previously it got overridden by paragraph properties and became 
6pt, no bold, no italic
 uno::Reference 
xStyle(getStyles("CharacterStyles")->getByName(aCharStyleName), uno::UNO_QUERY);
 CPPUNIT_ASSERT_EQUAL(24.f, getProperty(xStyle, "CharHeight"));
 CPPUNIT_ASSERT_EQUAL(awt::FontWeight::BOLD, getProperty(xStyle, 
"CharWeight"));

[Libreoffice-commits] core.git: sc/inc

[Andrea Gelmini (via logerrit)]

 sc/inc/SparklineCell.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b9070eedb3b0296a04fcb53aad62f98bb528476b
Author: Andrea Gelmini 
AuthorDate: Fri May 20 11:13:23 2022 +0200
Commit: Julien Nabet 
CommitDate: Thu May 26 17:45:07 2022 +0200

WIP: dunno about "Hodler"

Change-Id: I9fbee006237ccb70e31109023cf46b21aec325d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134668
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/sc/inc/SparklineCell.hxx b/sc/inc/SparklineCell.hxx
index f048148ce4a0..be0ff9b5a9fd 100644
--- a/sc/inc/SparklineCell.hxx
+++ b/sc/inc/SparklineCell.hxx
@@ -16,7 +16,7 @@
 
 namespace sc
 {
-/** Hodler of a sparkline, that is connected to a cell specific */
+/** Holder of a sparkline, that is connected to a cell specific */
 class SC_DLLPUBLIC SparklineCell
 {
 private:

[Libreoffice-commits] core.git: sw/source

[Andrea Gelmini (via logerrit)]

 sw/source/core/txtnode/justify.hxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 1cd8aee91b2fb9da6925d9165f10a980fa7b26b2
Author: Andrea Gelmini 
AuthorDate: Thu May 26 12:07:01 2022 +0200
Commit: Julien Nabet 
CommitDate: Thu May 26 17:43:54 2022 +0200

Fix typos

Change-Id: I12273f1193a4089743b8e5a9716432e065930cc5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134990
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/sw/source/core/txtnode/justify.hxx 
b/sw/source/core/txtnode/justify.hxx
index 5a4c08b3da28..157fe95d2d4b 100644
--- a/sw/source/core/txtnode/justify.hxx
+++ b/sw/source/core/txtnode/justify.hxx
@@ -29,15 +29,15 @@ SW_DLLPUBLIC void SpaceDistribution(std::vector& 
rKernArray, const OU
 /// Snap ideographs to text grids:
 /// a) Ideographic open brackets are aligned to the rightmost edge of spanned 
grids so that
 //  they can be closer to the next ideograph.
-/// b) Ideographic close brackets, ideogrpahic comma, and idographic fullstop 
are aligned
+/// b) Ideographic close brackets, ideographic comma, and ideographic fullstop 
are aligned
 /// to the leftmost edge of spanned grids so that they can be closer to the 
previous
 /// ideograph.
-/// c) Other ideographs are aligned to the center of the spnaned grids.
+/// c) Other ideographs are aligned to the center of the spanned grids.
 /// @param[in,out] rKernArray text positions from OutDev::GetTextArray().
 /// @param rText string used to determine where space and kern are inserted.
 /// @param nStt starting index of rText.
 /// @param nLen number of elements to process in rKernArray and rText.
-/// @param nGirdWidth width of a text gird
+/// @param nGridWidth width of a text grid
 /// @param nWidth width of the whole portion.
 /// @return the delta offset of first glyph so text origin can be updated 
accordingly.
 SW_DLLPUBLIC tools::Long SnapToGrid(std::vector& rKernArray, const 
OUString& rText,

[Libreoffice-bugs] [Bug 149110] LibreOffice Base slows down if there is an unsaved change to the databse

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149110

--- Comment #2 from Dr. Martinus  ---
Sorry for the delay...
it's the version from the distribution (Manjaro, KDE). I do all upgrades
regularly, but this behaviour I have witnessed for years, even after a complete
new installation with new user etc. I should have reported it earlier.
Database is HSQLDB, I guess. I haven't done any changes to the settings. Where
would I find info about what engine is being used?
I can't send you a sample, because the database contains private information. 
I would need to set up a new database. That may take time, since I have other
things to finish first.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa

[Miklos Vajna (via logerrit)]

 sw/qa/extras/tiledrendering/tiledrendering.cxx |   70 +
 1 file changed, 70 insertions(+)

New commits:
commit ce12103990f7a8623c6de8b668784dbd0ab4d1b7
Author: Miklos Vajna 
AuthorDate: Thu May 26 14:49:22 2022 +0200
Commit: Miklos Vajna 
CommitDate: Thu May 26 17:21:51 2022 +0200

sw content controls, picture: add LOK API testcase

Fails with commit 9a76be53dfb801b754bf55f9d4b8c5f82991a62f (sw content
controls, picture: add LOK API, 2022-05-23) reverted.

Change-Id: I6164e597099632a2212afee86ac9a4c7555e5c61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135022
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx 
b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index 1090662aa127..2a8c05fe19e6 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx
@@ -66,6 +66,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 
 constexpr OUStringLiteral DATA_DIRECTORY = 
u"/sw/qa/extras/tiledrendering/data/";
 
@@ -169,6 +171,7 @@ public:
 void testRedlinePortions();
 void testContentControl();
 void testDropDownContentControl();
+void testPictureContentControl();
 
 CPPUNIT_TEST_SUITE(SwTiledRenderingTest);
 CPPUNIT_TEST(testRegisterCallback);
@@ -258,6 +261,7 @@ public:
 CPPUNIT_TEST(testRedlinePortions);
 CPPUNIT_TEST(testContentControl);
 CPPUNIT_TEST(testDropDownContentControl);
+CPPUNIT_TEST(testPictureContentControl);
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -3714,6 +3718,72 @@ void SwTiledRenderingTest::testDropDownContentControl()
 CPPUNIT_ASSERT_EQUAL(OUString("green"), 
pTextNode->GetExpandText(pWrtShell->GetLayout()));
 }
 
+void SwTiledRenderingTest::testPictureContentControl()
+{
+// Given a document with a picture content control:
+SwXTextDocument* pXTextDocument = createDoc();
+SwWrtShell* pWrtShell = pXTextDocument->GetDocShell()->GetWrtShell();
+setupLibreOfficeKitViewCallback(pWrtShell->GetSfxViewShell());
+uno::Reference xMSF(mxComponent, 
uno::UNO_QUERY);
+uno::Reference xTextDocument(mxComponent, 
uno::UNO_QUERY);
+uno::Reference xText = xTextDocument->getText();
+uno::Reference xCursor = xText->createTextCursor();
+uno::Reference xTextGraphic(
+xMSF->createInstance("com.sun.star.text.TextGraphicObject"), 
uno::UNO_QUERY);
+xTextGraphic->setPropertyValue("AnchorType",
+   
uno::Any(text::TextContentAnchorType_AS_CHARACTER));
+uno::Reference xTextContent(xTextGraphic, 
uno::UNO_QUERY);
+xText->insertTextContent(xCursor, xTextContent, false);
+xCursor->gotoStart(/*bExpand=*/false);
+xCursor->gotoEnd(/*bExpand=*/true);
+uno::Reference xContentControl(
+xMSF->createInstance("com.sun.star.text.ContentControl"), 
uno::UNO_QUERY);
+uno::Reference xContentControlProps(xContentControl, 
uno::UNO_QUERY);
+xContentControlProps->setPropertyValue("ShowingPlaceHolder", 
uno::Any(true));
+xContentControlProps->setPropertyValue("Picture", uno::Any(true));
+xText->insertTextContent(xCursor, xContentControl, /*bAbsorb=*/true);
+pWrtShell->SttEndDoc(/*bStt=*/true);
+m_aContentControl.clear();
+
+// When clicking on that content control:
+pWrtShell->GotoObj(/*bNext=*/true, GotoObjFlags::Any);
+pWrtShell->EnterSelFrameMode();
+const SwFrameFormat* pFlyFormat = pWrtShell->GetFlyFrameFormat();
+const SwFormatAnchor& rFormatAnchor = pFlyFormat->GetAnchor();
+const SwPosition* pAnchorPos = rFormatAnchor.GetContentAnchor();
+SwTextNode* pTextNode = pAnchorPos->nNode.GetNode().GetTextNode();
+SwTextAttr* pAttr = pTextNode->GetTextAttrForCharAt(0, 
RES_TXTATR_CONTENTCONTROL);
+auto pTextContentControl = 
static_txtattr_cast(pAttr);
+auto& rFormatContentControl
+= static_cast(pTextContentControl->GetAttr());
+pWrtShell->GotoContentControl(rFormatContentControl);
+
+// Then make sure that the callback is emitted:
+// Without the accompanying fix in place, this test would have failed, no 
callback was emitted.
+CPPUNIT_ASSERT(!m_aContentControl.isEmpty());
+std::stringstream aStream(m_aContentControl.getStr());
+boost::property_tree::ptree aTree;
+boost::property_tree::read_json(aStream, aTree);
+OString sAction = 
aTree.get_child("action").get_value().c_str();
+CPPUNIT_ASSERT_EQUAL(OString("change-picture"), sAction);
+
+// And when replacing the image:
+std::map aArguments;
+aArguments.emplace("type", "picture");
+OUString aURL = 
m_directories.getURLFromSrc(u"sw/qa/extras/uiwriter/data/ole2.png");
+aArguments.emplace("changed", aURL);
+pXTextDocument->executeContentControlEvent(aArguments);
+
+// Then make sure that the document is updated accordingly:
+uno::Reference xShape = getShape(1);
+auto xGraphic = getProperty>(xShape, 

[Libreoffice-bugs] [Bug 149323] New: Contents cannot display or blinking when clicking on PPSX file by using Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149323

Bug ID: 149323
   Summary: Contents cannot display or blinking when clicking on
PPSX file by using Impress
   Product: LibreOffice
   Version: 3.3.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jamessun2...@gmail.com

Description:
When using Impress to open a PPSX file, some slides need to click some
rectangles to display the content, it doesn't work on Impress, it cannot
display the contents, also the contents may blink one time but still not
showing up. It works fine when using Microsoft PowerPoint from Windows OS.

Steps to Reproduce:
1.Open a PPSX file
2.Click each slide 
3.Contents cannot display when clicking

Actual Results:
The contents are blinking quickly but cannot display

Expected Results:
Contents displaying normally.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 7.3.3.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Ubuntu package version: 1:7.3.3~rc2-0ubuntu0.20.04.1~lo1
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147708] Writer crashes trying to open file with 3000 pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147708

Caolán McNamara  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.