[Libreoffice-bugs] [Bug 149724] impossible tu use Java on 7.2.7.2 for MAC M1
https://bugs.documentfoundation.org/show_bug.cgi?id=149724 Robert changed: What|Removed |Added OS|All |macOS (All) CC||d...@palmieri.fr Hardware|Other |ARM -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149724] New: impossible tu use Java on 7.2.7.2 for MAC M1
https://bugs.documentfoundation.org/show_bug.cgi?id=149724 Bug ID: 149724 Summary: impossible tu use Java on 7.2.7.2 for MAC M1 Product: LibreOffice Version: 7.2.7.2 release Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Installation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: d...@palmieri.fr Description: LibreOffice does not detect JAVA. All fields are read only on the setup section if you do the 7.2.7.2 for MAC puce intel installation it's ok idem for the 7.3.xx versions, it's ok I have 2 JRE version installed on my Mac Elipse adpotium 18.0.1 and Temurin 1.8.0_332 if I install 7.2.7.2 for MAC puce intel I see these two version on libreOffice setup if I install 7.3.x.x for MAC puce intel I see only the adpotium 18.0.1 version on libreOffice setup if I install 7.3.x.x for MAC puce M1 I see nothing on libreOffice setup Steps to Reproduce: 1. install a java runtime 2. install 7.2.7.2 on MAC M1 3. go to préférences and check the java setup Actual Results: LibreOffice does not detect JAVA. All fields are read only on the setup section Expected Results: impossible to get JRE on LibreOffice Reproducible: Always User Profile Reset: Yes Additional Info: if you do the 7.2.7.2 for MAC puce intel installation it's ok idem for the 7.3.xx versions, it's ok I have 2 JRE version installed on my Mac Elipse adpotium 18.0.1 and Temurin 1.8.0_332 if I install 7.2.7.2 for MAC puce intel I see these two version on libreOffice setup if I install 7.3.x.x for MAC puce intel I see only the adpotium 18.0.1 version on libreOffice setup if I install 7.3.x.x for MAC puce M1 I see nothing on libreOffice setup -- You are receiving this mail because: You are the assignee for the bug.
Nazanin Yadi license statement
All of my past & future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license.
[Libreoffice-bugs] [Bug 149279] better vertical alignment in the Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=149279 Jim Raykowski changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |rayk...@gmail.com |desktop.org | Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #2 from Jim Raykowski --- Hi Adalbert and Dieter, Here is a link to an enhancement patch that shows at least two headings above tracked heading when the tracked heading is automatically scrolled into view: https://gerrit.libreoffice.org/c/core/+/136436 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: filter/source
filter/source/svg/presentation_engine.js | 68 +++ 1 file changed, 61 insertions(+), 7 deletions(-) New commits: commit 32f2f43929e2869bf2e66f5f70795beb03cb39a1 Author: Marco Cecchetti AuthorDate: Fri May 20 11:35:57 2022 +0200 Commit: Aron Budea CommitDate: Sat Jun 25 06:34:27 2022 +0200 svg filter: support for emphasis spin animation Partial support for transform animations. At present only rotate is supported. Change-Id: If9ba69ec0b74bc3b527a963cb0c0bf3a7bfa5220 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134626 Tested-by: Jenkins Reviewed-by: Aron Budea diff --git a/filter/source/svg/presentation_engine.js b/filter/source/svg/presentation_engine.js index 370bacc5cd72..c98e93de7b7a 100644 --- a/filter/source/svg/presentation_engine.js +++ b/filter/source/svg/presentation_engine.js @@ -11574,6 +11574,59 @@ PropertyAnimationNode.prototype.createActivity = function() +function isValidTransformation( sType ) +{ +return ( sType === 'translate' || sType === 'scale' || sType === 'rotate' + || sType === 'skewX' || sType === 'skewY' ); +} + +function AnimationTransformNode( aAnimElem, aParentNode, aNodeContext ) +{ +AnimationTransformNode.superclass.constructor.call( this, aAnimElem, aParentNode, aNodeContext ); + +this.sClassName = 'AnimationTransformNode'; +} +extend( AnimationTransformNode, AnimationBaseNode3 ); + + +AnimationTransformNode.prototype.parseElement = function() +{ +var bRet = AnimationTransformNode.superclass.parseElement.call(this); + +var aAnimElem = this.aElement; + +// transformation type +var sTransformType = aAnimElem.getAttribute( 'svg:type' ); +if( !isValidTransformation( sTransformType ) ) +{ +this.eCurrentState = INVALID_NODE; +log( 'AnimationTransformNode.parseElement: transformation type not found: ' + sTransformType ); +} +else +{ +this.sAttributeName = sTransformType; +} + +return bRet; +} + +AnimationTransformNode.prototype.createActivity = function() +{ +var aActivityParamSet = this.fillActivityParams(); +var aAnimation; + +aAnimation = createPropertyAnimation( this.getAttributeName(), + this.getAnimatedElement(), + this.aNodeContext.aSlideWidth, + this.aNodeContext.aSlideHeight ); + +var aInterpolator = null; // createActivity will compute it; +return createActivity( aActivityParamSet, this, aAnimation, aInterpolator ); +}; + + + + function AnimationSetNode( aAnimElem, aParentNode, aNodeContext ) { AnimationSetNode.superclass.constructor.call( this, aAnimElem, aParentNode, aNodeContext ); @@ -11872,10 +11925,8 @@ function createAnimationNode( aElement, aParentNode, aNodeContext ) aCreatedNode = new AnimationColorNode( aElement, aParentNode, aNodeContext ); break; case ANIMATION_NODE_ANIMATETRANSFORM: -//aCreatedNode = new AnimationTransformNode( aElement, aParentNode, aNodeContext ); -//break; -log( 'createAnimationNode: ANIMATETRANSFORM not implemented' ); -return null; +aCreatedNode = new AnimationTransformNode( aElement, aParentNode, aNodeContext ); +break; case ANIMATION_NODE_TRANSITIONFILTER: aCreatedNode = new AnimationTransitionFilterNode( aElement, aParentNode, aNodeContext ); break; @@ -17934,9 +17985,12 @@ function evalValuesAttribute( aValueList, aValueSet, aBBox, nSlideWidth, nSlideH for( var i = 0; i < aValueSet.length; ++i ) { var sValue = aValueSet[i]; -sValue = sValue.replace(reMath, 'Math.$&'); -sValue = sValue.replace(/pi(?!\w)/g, 'Math.PI'); -sValue = sValue.replace(/e(?!\w)/g, 'Math.E'); +if(sValue) +{ +sValue = sValue.replace(reMath, 'Math.$&'); +sValue = sValue.replace(/pi(?!\w)/g, 'Math.PI'); +sValue = sValue.replace(/e(?!\w)/g, 'Math.E'); +} var aValue = eval( sValue ); aValueList.push( aValue ); }
[Libreoffice-bugs] [Bug 143344] [META] Linux Dark Mode bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=143344 Bug 143344 depends on bug 148138, which changed state. Bug 148138 Summary: LibreOffice Dark Color Scheme: Text boundaries are Dark Gray 3 but should have a lighter color https://bugs.documentfoundation.org/show_bug.cgi?id=148138 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 75349] [UI] No animations/transitions shown in remote control app
https://bugs.documentfoundation.org/show_bug.cgi?id=75349 --- Comment #15 from Nauman --- is the bug are still available bcoz I want to use on my site https://www.argadetectives.com/detectives-privados-infidelidades-madrid.html -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - officecfg/registry
officecfg/registry/data/org/openoffice/Office/UI.xcu |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5d2afaa057bd038d0f2a3554e5f485421beb13ac Author: Roman Kuznetsov AuthorDate: Tue Jun 21 13:48:22 2022 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Sat Jun 25 05:41:19 2022 +0200 tdf#148138 change Text Boundaries color to Gray for Dark mode Change-Id: I276896d0ea94e741be8c0ae49f79f95769e0c2a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136234 Tested-by: Jenkins Reviewed-by: Heiko Tietze Reviewed-by: Adolfo Jayme Barrientos (cherry picked from commit 4412044340ea8447058bb99f529310c2be56a5a9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136414 Tested-by: Adolfo Jayme Barrientos diff --git a/officecfg/registry/data/org/openoffice/Office/UI.xcu b/officecfg/registry/data/org/openoffice/Office/UI.xcu index e3195b7ac50f..0726415a41b8 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI.xcu @@ -441,7 +441,7 @@ true -1842204 +8421504
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - officecfg/registry
officecfg/registry/data/org/openoffice/Office/UI.xcu |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c65eaa70a8a192cc25059a78e408279b84780ce6 Author: Roman Kuznetsov AuthorDate: Tue Jun 21 13:48:22 2022 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Sat Jun 25 05:41:25 2022 +0200 tdf#148138 change Text Boundaries color to Gray for Dark mode Change-Id: I276896d0ea94e741be8c0ae49f79f95769e0c2a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136234 Tested-by: Jenkins Reviewed-by: Heiko Tietze Reviewed-by: Adolfo Jayme Barrientos (cherry picked from commit 4412044340ea8447058bb99f529310c2be56a5a9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136415 diff --git a/officecfg/registry/data/org/openoffice/Office/UI.xcu b/officecfg/registry/data/org/openoffice/Office/UI.xcu index 4e0e4c030b2c..ab3090babe24 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI.xcu @@ -433,7 +433,7 @@ true -1842204 +8421504
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sw/source
sw/source/ui/chrdlg/pardlg.cxx |2 +- sw/source/ui/fmtui/tmpdlg.cxx |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit c22fc180845c4d170b412e8ea11a65dc7124a18a Author: Julien Nabet AuthorDate: Sun Jun 19 23:19:12 2022 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Sat Jun 25 05:40:22 2022 +0200 tdf#149615: "No list" twice in Outline & Style tab (non English UI only) Change-Id: I8a983b62175ed00ca8817556bd3e55fc87ddc9d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136110 Reviewed-by: Julien Nabet (cherry picked from commit f340442cde0c3e91768adcef164b41b5556b3835) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136317 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/sw/source/ui/chrdlg/pardlg.cxx b/sw/source/ui/chrdlg/pardlg.cxx index 232b9f8154df..e465cb7e84f3 100644 --- a/sw/source/ui/chrdlg/pardlg.cxx +++ b/sw/source/ui/chrdlg/pardlg.cxx @@ -215,7 +215,7 @@ void SwParaDlg::PageCreated(const OString& rId, SfxTabPage& rPage) aNames.insert(pBase->GetName()); pBase = pPool->Next(); } -aNames.erase("No List"); +aNames.erase(SwResId(STR_POOLNUMRULE_NOLIST)); for (const auto& rName : aNames) rBox.append_text(rName); } diff --git a/sw/source/ui/fmtui/tmpdlg.cxx b/sw/source/ui/fmtui/tmpdlg.cxx index 184401b134f8..aa3c9e5eacf6 100644 --- a/sw/source/ui/fmtui/tmpdlg.cxx +++ b/sw/source/ui/fmtui/tmpdlg.cxx @@ -457,7 +457,7 @@ void SwTemplateDlgController::PageCreated(const OString& rId, SfxTabPage aNames.insert(pBase->GetName()); pBase = pPool->Next(); } -aNames.erase("No List"); +aNames.erase(SwResId(STR_POOLNUMRULE_NOLIST)); for(std::set::const_iterator it = aNames.begin(); it != aNames.end(); ++it) rBox.append_text(*it); }
[Libreoffice-bugs] [Bug 149189] Update chart with method update() does not work in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=149189 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149189] Update chart with method update() does not work in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=149189 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144983] Wrong umlaut behaviour in linux
https://bugs.documentfoundation.org/show_bug.cgi?id=144983 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149516] FILEOPEN: PDF in hebrew - RTL does not apply - fresh LibreOffice install
https://bugs.documentfoundation.org/show_bug.cgi?id=149516 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149506] Slow start-up and opening of files since 7.3 release
https://bugs.documentfoundation.org/show_bug.cgi?id=149506 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149718] Writer Crashes on inserting a Chart based on a Table with merged cells
https://bugs.documentfoundation.org/show_bug.cgi?id=149718 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149718] Writer Crashes on inserting a Chart based on a Table with merged cells
https://bugs.documentfoundation.org/show_bug.cgi?id=149718 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149102] Content from "link to external data" is not shown
https://bugs.documentfoundation.org/show_bug.cgi?id=149102 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149102] Content from "link to external data" is not shown
https://bugs.documentfoundation.org/show_bug.cgi?id=149102 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135961] Screen corruption when changing screen DPI
https://bugs.documentfoundation.org/show_bug.cgi?id=135961 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135961] Screen corruption when changing screen DPI
https://bugs.documentfoundation.org/show_bug.cgi?id=135961 --- Comment #7 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139248] No control handles on text box
https://bugs.documentfoundation.org/show_bug.cgi?id=139248 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139248] No control handles on text box
https://bugs.documentfoundation.org/show_bug.cgi?id=139248 --- Comment #7 from QA Administrators --- Dear Menoo, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138955] Deleting whitespace when pasting Calc cell to Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=138955 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138955] Deleting whitespace when pasting Calc cell to Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=138955 --- Comment #4 from QA Administrators --- Dear alan-sloma, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145859] Can not download from Thai Website
https://bugs.documentfoundation.org/show_bug.cgi?id=145859 --- Comment #8 from QA Administrators --- Dear pj, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112742] FILEOPEN: DOCX - Jump to saved cursor position
https://bugs.documentfoundation.org/show_bug.cgi?id=112742 --- Comment #4 from Justin L --- Shift-F5 suggested implementation here: https://gerrit.libreoffice.org/c/core/+/136409/1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112740] FILESAVE: DOCX - Save cursor position
https://bugs.documentfoundation.org/show_bug.cgi?id=112740 --- Comment #5 from Justin L --- an idea presented here: https://gerrit.libreoffice.org/c/core/+/136408/1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149619] unresponsive document, lowriter freezes, brk(0xfffc000) = 0xfffc000
https://bugs.documentfoundation.org/show_bug.cgi?id=149619 --- Comment #3 from vis_qa --- @Scott Clewell thank u. today i recheck and it has no issues. found reason. please close, file is opening properly. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149723] Piano template doesn't have designated footer areas in master slide anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=149723 Aron Budea changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 132138] Styles for Accent, Status like in calc
https://bugs.documentfoundation.org/show_bug.cgi?id=132138 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||9723 -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 132138] Styles for Accent, Status like in calc
https://bugs.documentfoundation.org/show_bug.cgi?id=132138 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||9723 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149723] New: Piano template doesn't have designated footer areas in master slide anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=149723 Bug ID: 149723 Summary: Piano template doesn't have designated footer areas in master slide anymore Product: LibreOffice Version: 7.0.0.3 release Hardware: All OS: All Status: UNCONFIRMED Keywords: bibisected, bisected, regression Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: aron.bu...@gmail.com CC: kain...@gmail.com Blocks: 103314 Create a presentation based on Piano template, and switch to Master View. Note that on the first master slide, while the footer fields are there (date/time, footer, number), they are not specialized Date Area, Footer Area, Slide Number Area anymore. Compare it with the second master slide to see what that is like. A side-effect of this is that those fields are always visible (when non-empty, like the slide number by default), and can't be controlled by Insert -> Header and Footer. Observed using LO 7.4.0.0.beta1+ (cdf48e57da6b8a6a5eb4131340fa2c14be135714) / Ubuntu. This is a regression from the following commit, bibisected using repo bibisect-linux-64-7.0 (had to clean user directory at each step). https://cgit.freedesktop.org/libreoffice/core/commit/?id=155648d602e84e7626b55c71e9b76140303e7432 author andreas kainz2020-04-30 16:22:11 +0200 committer andreas_kainz2020-04-30 18:06:18 +0200 tdf#132138 Update piano impress template Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103314 [Bug 103314] [META] Templates bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103314] [META] Templates bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103314 Aron Budea changed: What|Removed |Added Depends on||149723 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149723 [Bug 149723] Piano template doesn't have designated footer areas in master slide anymore -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149722] `Macro Selector` should only show macros to Run which are “not Private” and have “no arguments passed”
https://bugs.documentfoundation.org/show_bug.cgi?id=149722 --- Comment #3 from Óvári --- Created attachment 180955 --> https://bugs.documentfoundation.org/attachment.cgi?id=180955=edit LO Calc Macro Selector Window screenshot LO Calc displays 3 macro which can be run. The `Private` macro can be run, which is wrong The `Passed Argument` macro can be run, which produces an error. Perhaps this issue should be changed from request for enhancement (RFE) to bug? What do you think? Thank you -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149722] `Macro Selector` should only show macros to Run which are “not Private” and have “no arguments passed”
https://bugs.documentfoundation.org/show_bug.cgi?id=149722 --- Comment #2 from Óvári --- Created attachment 180954 --> https://bugs.documentfoundation.org/attachment.cgi?id=180954=edit MS Excel Macro Window screenshot MS Excel only displays 1 macro which can be run, i.e. the public macro with no passed arguments. Clicking `Run` produces no error. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149722] `Macro Selector` should only show macros to Run which are “not Private” and have “no arguments passed”
https://bugs.documentfoundation.org/show_bug.cgi?id=149722 --- Comment #1 from Óvári --- Created attachment 180953 --> https://bugs.documentfoundation.org/attachment.cgi?id=180953=edit Macros.xls MS Excel spreadsheet with 3 functions: 1. Private 2. With passed argument(s) 3. Public and no passed arguments -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149722] New: `Macro Selector` should only show macros to Run which are “not Private” and have “no arguments passed”
https://bugs.documentfoundation.org/show_bug.cgi?id=149722 Bug ID: 149722 Summary: `Macro Selector` should only show macros to Run which are “not Private” and have “no arguments passed” Product: LibreOffice Version: 7.3.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ovari...@zoho.com Description: End users may `Run` macros which were programmed by others. To improve the user experience, only valid macros should be listed in the `Macro Selector` window. Actual Results: Macros which produce errors when run or are private can be access by the `Macro Selector`. Expected Results: Macros which produce errors (i.e. ones with passed arguments) when run or are private should not be shown in the `Macro Selector`. Reproducible: Always User Profile Reset: No Additional Info: `Macro Selector` should only show macros to Run which are “not Private” and have “no arguments passed” End users may `Run` macros which were programmed by others. To improve the user experience, only valid macros should be listed in the `Macro Selector` window. LibreOffice Calc should only showing macros that can be Run in the LO Calc `Macro Selector`. Screenshot will be attached later. Macros which are `Private` or are passed arguments should not be show. Inspiration from MS Excel. Screenshot will be attached later. Code examples: ``` Private Sub PrivateFunction() MsgBox "This subroutine should not show in the list of macros to run as it is private" End Sub Sub FunctionWithArguments(intVariable As Integer) MsgBox "This function should not show in the list of macros to run as it is passed argument(s)" End Sub Sub FunctionNotPrivateNoArguments() MsgBox "This function should show as it is public and does not get passed any arguments" End Sub ``` What do you think? Thank you -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149720] Crash in: SwLayoutFrame::IsAnLower(SwFrame const *)
https://bugs.documentfoundation.org/show_bug.cgi?id=149720 Ainhoa changed: What|Removed |Added Keywords||dataLoss -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149721] New: problem with 7.3.3.2 and 7.4 Libre Office Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=149721 Bug ID: 149721 Summary: problem with 7.3.3.2 and 7.4 Libre Office Writer Product: LibreOffice Version: 3.3.4 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: stuco...@yahoo.com Description: shift + F5 no longer works in both versions. Also document always opens on page 1. Steps to Reproduce: 1.Open a long document that was edited near the last page. 2.Document always opens on page 1 3.shift F5 does not take you any place except page 1 Actual Results: First I updated to version 7.4, this had the same problem. I uninstalled Libre Office and installed version 7.2.7 and everything functions. Uninstalled that and installed 7.4 again, same problem shift F5 does not work. Uninstalled 7.4, reinstalled 7.2.7 and everything works as it should. This is on both my desktop and my notebook computer. Expected Results: I expected the document to open at the point of last edit. It did not. I expected shift F5 to take me to the point of last edit and absolutely nothing happens, it just sits on page 1. Reproducible: Always User Profile Reset: No Additional Info: First I updated to version 7.4, this had the same problem. I uninstalled Libre Office and installed version 7.2.7 and everything functions. Uninstalled that and installed 7.4 again, same problem shift F5 does not work. Uninstalled 7.4, reinstalled 7.2.7 and everything works as it should. This is on both my desktop and my notebook computer. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149720] New: Crash in: SwLayoutFrame::IsAnLower(SwFrame const *)
https://bugs.documentfoundation.org/show_bug.cgi?id=149720 Bug ID: 149720 Summary: Crash in: SwLayoutFrame::IsAnLower(SwFrame const *) Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ainhoabuenorah...@gmail.com This bug was filed from the crash reporting server and is br-6e46744f-8250-4cd3-ad65-71315783afa7. = PORFAVOR ES UN TRABAJO DE LA UNIVERSIDAD LO NECESITO RECUPERAR!! GRACIAS. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149719] New: UI: Background Color of "Font Color" and "Background Color" Buttons Turns Black on File Reload
https://bugs.documentfoundation.org/show_bug.cgi?id=149719 Bug ID: 149719 Summary: UI: Background Color of "Font Color" and "Background Color" Buttons Turns Black on File Reload Product: LibreOffice Version: 7.3.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: trivial Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rewj...@gmail.com Description: With the Icon Style setting set to "Karasa Jaga," the background color of the "Font Color" and "Background Color" buttons turns black on file reload. Steps to Reproduce: 1. Choose Tools -> Options menu item. Options dialog opens. 2. Select LibreOffice -> View in option tree on left side. 3. Select "Karasa Jaga" entry in the "Icon Style" drop-down list. 4. Click "OK" button. Options dialog disappears. 5. Load a spreadsheet with cells that have external links to other spreadsheet files. Calc will state, "Automatic update of external links has been disabled," and ask if updating should be allowed (by displaying the "Allow updating" button on the right edge of the warning banner between the formula toolbar and the spreadsheet area). Actual Results: The background color of both the "Font Color" and "Background Color" buttons turns black when the caution banner is displayed to notify the user that automatic updating of external links is disabled and waits for the user to click either the "Allow updating" button, or the "X" button and the right side of said banner. Expected Results: The background color of both the "Font Color" and "Background Color" buttons should not change. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Version: 7.3.3.2 (x64) / LibreOffice Community Build ID: d1d0ea68f081ee2800a922cac8f79445e4603348 CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - svtools/source
svtools/source/control/ctrlbox.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit aef5eb654ce5cd6b0026d50782137e79664dc30a Author: Xisco Fauli AuthorDate: Tue Jun 21 16:58:24 2022 +0200 Commit: Xisco Fauli CommitDate: Fri Jun 24 23:21:36 2022 +0200 svtools: avoid divide by zero in calcCustomItemSize See https://crashreport.libreoffice.org/stats/signature/%60anonymous%20namespace'::calcCustomItemSize Change-Id: I5f1b19b7679c73cf29952629469e5151395b2b12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136254 Reviewed-by: Caolán McNamara Tested-by: Jenkins Reviewed-by: Xisco Fauli (cherry picked from commit ec03eef9b431048ea21a733c39c79b792b0f653c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136393 diff --git a/svtools/source/control/ctrlbox.cxx b/svtools/source/control/ctrlbox.cxx index 411a2dd4961d..37952f5336e2 100644 --- a/svtools/source/control/ctrlbox.cxx +++ b/svtools/source/control/ctrlbox.cxx @@ -343,7 +343,8 @@ namespace gUserItemSz.setHeight(gUserItemSz.Height() / 10); size_t nMaxDeviceHeight = SAL_MAX_INT16 / 16; // see limitXCreatePixmap and be generous wrt up to x16 hidpi -gPreviewsPerDevice = nMaxDeviceHeight / gUserItemSz.Height(); +assert(gUserItemSz.Height() != 0); +gPreviewsPerDevice = gUserItemSz.Height() == 0 ? 16 : nMaxDeviceHeight / gUserItemSz.Height(); } }
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - external/liborcus
external/liborcus/UnpackedTarball_liborcus.mk |1 external/liborcus/overrun.patch.0 | 63 ++ 2 files changed, 64 insertions(+) New commits: commit 5e7049f2ee3b4df3c249639b635e2e86d5d080eb Author: Stephan Bergmann AuthorDate: Fri Jun 24 18:21:32 2022 +0200 Commit: Stephan Bergmann CommitDate: Fri Jun 24 22:57:52 2022 +0200 external/liborcus: Fix heap-buffer-overflow ...as seen during CppunitTest_vcl_pdfexport: > ==573913==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x62b0001dba0e at pc 0x560576627186 bp 0x7ffeab9fa730 sp 0x7ffeab9f9ef0 > READ of size 26624 at 0x62b0001dba0e thread T0 > #0 in StrtolFixAndCheck(void*, char const*, char**, char*, int) at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:3629:3 > #1 in strtol at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_interceptors.cpp:485:3 > #2 in orcus::sax_token_handler_wrapper_base::attribute(std::basic_string_view>, std::basic_string_view>) at workdir/UnpackedTarball/liborcus/src/parser/sax_token_parser.cpp:344:22 > #3 in orcus::sax_ns_parser::handler_wrapper>::handler_wrapper::attribute(orcus::sax::parser_attribute const&) at workdir/UnpackedTarball/liborcus/src/liborcus/../../include/orcus/sax_ns_parser.hpp:212:27 > #4 in orcus::sax_parser::handler_wrapper>::handler_wrapper, orcus::sax_parser_default_config>::attribute() at workdir/UnpackedTarball/liborcus/src/liborcus/../../include/orcus/sax_parser.hpp:570:15 > #5 in orcus::sax_parser::handler_wrapper>::handler_wrapper, orcus::sax_parser_default_config>::declaration(char const*) at workdir/UnpackedTarball/liborcus/src/liborcus/../../include/orcus/sax_parser.hpp:389:9 > #6 in orcus::sax_parser::handler_wrapper>::handler_wrapper, orcus::sax_parser_default_config>::element() at workdir/UnpackedTarball/liborcus/src/liborcus/../../include/orcus/sax_parser.hpp:242:13 > #7 in orcus::sax_parser::handler_wrapper>::handler_wrapper, orcus::sax_parser_default_config>::body() at workdir/UnpackedTarball/liborcus/src/liborcus/../../include/orcus/sax_parser.hpp:214:13 > #8 in orcus::sax_parser::handler_wrapper>::handler_wrapper, orcus::sax_parser_default_config>::parse() at workdir/UnpackedTarball/liborcus/src/liborcus/../../include/orcus/sax_parser.hpp:182:5 > #9 in orcus::sax_ns_parser::handler_wrapper>::parse() at workdir/UnpackedTarball/liborcus/src/liborcus/../../include/orcus/sax_ns_parser.hpp:277:14 > #10 in orcus::sax_token_parser::parse() at workdir/UnpackedTarball/liborcus/src/liborcus/../../include/orcus/sax_token_parser.hpp:215:14 > #11 in orcus::xml_stream_parser::parse() at workdir/UnpackedTarball/liborcus/src/liborcus/xml_stream_parser.cpp:68:9 > #12 in orcus::orcus_xls_xml::detect(unsigned char const*, unsigned long) at workdir/UnpackedTarball/liborcus/src/liborcus/orcus_xls_xml.cpp:94:16 > #13 in orcus::detect(unsigned char const*, unsigned long) at workdir/UnpackedTarball/liborcus/src/liborcus/format_detection.cpp:68:9 > #14 in (anonymous namespace)::OrcusFormatDetect::detect(com::sun::star::uno::Sequence&) at sc/source/filter/orcus/filterdetect.cxx:83:31 > 0x62b0001dba0e is located 0 bytes to the right of 26638-byte region [0x62b0001d5200,0x62b0001dba0e) > allocated by thread T0 here: > #0 in operator new[](unsigned long) at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:98:3 > #1 in SvMemoryStream::AllocateMemory(unsigned long) at tools/source/stream/stream.cxx:1698:12 > #2 in SvMemoryStream::SvMemoryStream(unsigned long, unsigned long) at tools/source/stream/stream.cxx:1544:9 > #3 in (anonymous namespace)::OrcusFormatDetect::detect(com::sun::star::uno::Sequence&) at sc/source/filter/orcus/filterdetect.cxx:71:20 This started to occur now after a95c585433246813096e8890b7ed6ef4fe30c621 "Pump XInputStream into an SvMemoryStream rather than an OStringBuffer" no longer guarantees that the memory range passed into orcus::detect(const unsigned char* buffer, size_t length) is followed by a null byte at buffer[length]. (There appears to be no documentation for that function, but it looks unreasonable to me that it should require callers to provide a buffer thus terminated, and I rather assume that what is observed here is an orcus bug.) The problematic calls of std::strtol were used in code apparently meant to parse strings matching the XML VersionNum grammar production, and then store the two dot-separated numbers each as uint8_t. The new code using a local readUint8 accepts a different set of strings now than the original code using std::strtol, but the new set is arguably closer to what the actual XML VersionNum grammar production accepts (which is '1.' [0-9]+ for XML 1.0 and '1.1' for XML
[Libreoffice-bugs] [Bug 149626] HANG during basic macro using com.sun.star.datatransfer.dnd
https://bugs.documentfoundation.org/show_bug.cgi?id=149626 Caolán McNamara changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | --- Comment #12 from Caolán McNamara --- seems to work, backport to 7-3 in gerrit -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149626] HANG during basic macro using com.sun.star.datatransfer.dnd
https://bugs.documentfoundation.org/show_bug.cgi?id=149626 --- Comment #11 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/9647f34412814ff9b14cd28a5c84a66d5f791ea5 tdf#149626 use recursive_mutex to fix hang in macro callback during dnd It will be available in 7.4.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149626] HANG during basic macro using com.sun.star.datatransfer.dnd
https://bugs.documentfoundation.org/show_bug.cgi?id=149626 Commit Notification changed: What|Removed |Added Whiteboard|target:7.5.0|target:7.5.0 ||target:7.4.0.0.beta2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - vcl/inc
vcl/inc/dndeventdispatcher.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9647f34412814ff9b14cd28a5c84a66d5f791ea5 Author: Caolán McNamara AuthorDate: Fri Jun 24 15:44:40 2022 +0100 Commit: Caolán McNamara CommitDate: Fri Jun 24 22:41:23 2022 +0200 tdf#149626 use recursive_mutex to fix hang in macro callback during dnd See frame #5 and frame #45 where both the same DNDEventDispatcher object and both functions lock m_aMutex which is a std::mutex since commit 8de81db4e3fca488d50db2d74734109b31541a6f Date: Mon Aug 2 09:21:17 2021 +0200 osl::Mutex->std::mutex in DNDEventDispatcher #0 0x7ff094530c40 in __lll_lock_wait () at /lib64/libc.so.6 #1 0x7ff0945371d2 in pthread_mutex_lock@@GLIBC_2.2.5 () at /lib64/libc.so.6 #2 0x7ff08b901663 in __gthread_mutex_lock(pthread_mutex_t*) (__mutex=0x1a32c60) at /usr/bin/../lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/x86_64-redhat-linux/bits/gthr-default.h:749 #3 0x7ff08b9024d5 in std::mutex::lock() (this=0x1a32c60) at /usr/bin/../lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/std_mutex.h:100 #4 0x7ff08b9018f3 in std::scoped_lock::scoped_lock(std::mutex&) (this=0x7ffdd0d79240, __m=...) at /usr/bin/../lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/mutex:731 #5 0x7ff08b9006a8 in DNDEventDispatcher::dragOver(com::sun::star::datatransfer::dnd::DropTargetDragEvent const&) (this=0x1a32c10, dtde=...) at vcl/source/window/dndeventdispatcher.cxx:156 #6 0x7ff075f47658 in GtkInstDropTarget::fire_dragOver(com::sun::star::datatransfer::dnd::DropTargetDragEvent const&) (this=0x199eb40, dtde=...) at vcl/unx/gtk3/gtkinst.cxx:1710 #7 0x7ff0760a7010 in GtkInstDropTarget::signalDragMotion(_GtkWidget*, _GdkDragContext*, int, int, unsigned int) (this=0x199eb40, pWidget=0x1c67e40, context=0x1957450, x=89, y=175, time=0) at vcl/unx/gtk3/gtkframe.cxx:5026 #8 0x7ff07609bb77 in GtkSalFrame::signalDragMotion(_GtkWidget*, _GdkDragContext*, int, int, unsigned int, void*) (pWidget=0x1c67e40, context=0x1957450, x=89, y=175, time=0, frame=0x19b7d70) at vcl/unx/gtk3/gtkframe.cxx:4922 #9 0x7ff075649527 in _gtk_marshal_BOOLEAN__OBJECT_INT_INT_UINTv () at /lib64/libgtk-3.so.0 #10 0x7ff0865dcd5b in g_signal_emit_valist () at /lib64/libgobject-2.0.so.0 #11 0x7ff0865ddeb8 in g_signal_emit_by_name () at /lib64/libgobject-2.0.so.0 #12 0x7ff07595b491 in gtk_drag_dest_motion.lto_priv () at /lib64/libgtk-3.so.0 #13 0x7ff0757b8f7d in gtk_main_do_event () at /lib64/libgtk-3.so.0 #14 0x7ff0754e5463 in _gdk_event_emit () at /lib64/libgdk-3.so.0 #15 0x7ff075518056 in gdk_event_source_dispatch () at /lib64/libgdk-3.so.0 #16 0x7ff0864c3faf in g_main_context_dispatch () at /lib64/libglib-2.0.so.0 #17 0x7ff0865192c8 in g_main_context_iterate.constprop () at /lib64/libglib-2.0.so.0 #18 0x7ff0864c1940 in g_main_context_iteration () at /lib64/libglib-2.0.so.0 #19 0x7ff075f3e60f in GtkSalData::Yield(bool, bool) (this=0x952930, bWait=false, bHandleAllCurrentEvents=false) at vcl/unx/gtk3/gtkdata.cxx:405 #20 0x7ff075f43e43 in GtkInstance::DoYield(bool, bool) (this=0x9527e0, bWait=false, bHandleAllCurrentEvents=false) at vcl/unx/gtk3/gtkinst.cxx:428 #21 0x7ff08c2dc5df in ImplYield(bool, bool) (i_bWait=false, i_bAllEvents=false) at vcl/source/app/svapp.cxx:474 #22 0x7ff08c2dc24d in Application::Reschedule(bool) (i_bAllEvents=false) at vcl/source/app/svapp.cxx:493 #23 0x7ff091eeeb55 in SbiRuntime::Step() (this=0xa21eb20) at basic/source/runtime/runtime.cxx:801 #24 0x7ff091e0e659 in (anonymous namespace)::RunInitGuard::run() (this=0x76a6290) at basic/source/classes/sbxmod.cxx:1015 #25 0x7ff091e0d135 in SbModule::Run(SbMethod*) (this=0xa0ada00, pMeth=0xa16d7e0) at basic/source/classes/sbxmod.cxx:1176 #26 0x7ff091e0c503 in SbModule::Notify(SfxBroadcaster&, SfxHint const&) (this=0xa0ada00, rBC=..., rHint=...) at basic/source/classes/sbxmod.cxx:775 #27 0x7ff090b3ee6e in SfxBroadcaster::Broadcast(SfxHint const&) (this=0xa231de0, rHint=...) at svl/source/notify/SfxBroadcaster.cxx:39 #28 0x7ff091e1372e in SbMethod::Broadcast(SfxHintId) (this=0xa231ca0, nHintId=SfxHintId::BasicDataWanted) at basic/source/classes/sbxmod.cxx:2113 #29 0x7ff091f6ddfa in SbxObject::Call(rtl::OUString const&, SbxArray*) (this=0xa258670, rName="DTL_dragOver", pParam=0xa1e47d0) at basic/source/sbx/sbxobj.cxx:274 #30 0x7ff091d9dd76 in StarBASIC::Call(rtl::OUString const&, SbxArray*) (this=0xa258670, rName="DTL_dragOver", pParam=0xa1e47d0) at basic/source/classes/sb.cxx:1324 #31 0x7ff091dd7127 in (anonymous
[Libreoffice-bugs] [Bug 149715] MAILMERGE Data Source not Updated For Email Mail Merge (Filtering and Modifying Data Source Has No Effect)
https://bugs.documentfoundation.org/show_bug.cgi?id=149715 --- Comment #1 from mworks --- Some typos, in: > All these functions do not use the whole data set instead of only using the > filtered data. I actually meant: "all these functions USE the whole data set instead of only using the filtered data". Generally speaking I apologize for the many typos in the original message. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148956] DOCX Cleared direct formatting in styled paragraph lingers
https://bugs.documentfoundation.org/show_bug.cgi?id=148956 --- Comment #5 from Aron Budea --- Created attachment 180952 --> https://bugs.documentfoundation.org/attachment.cgi?id=180952=edit Sample ODT #2 (see comment 5) (In reply to Justin L from comment #4) > No big surprise here. Heading formats are (almost by definition) numbering > formats, and exporting numbering spams direct formatting all over the place. > There are various places in DOCX export where style formatting needs to be > spammed as direct formatting in order to emulate things. If that was causing the problem here, my expectation would be that unexpected direct formatting gets removed as well, not that it persists regardless, which is kind of the opposite. But anyway, here's a sample, see the second paragraph (line), formatted with a new style derived from Text Body, and having additional direct formatting. Steps: - Save ODT as DOCX, and reload DOCX, - Select the second line, and press Ctrl + M to clear direct formatting, - Unselect, and press Enter at the end of the line, - Type a few characters. => The characters have direct formatting. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149626] HANG during basic macro using com.sun.star.datatransfer.dnd
https://bugs.documentfoundation.org/show_bug.cgi?id=149626 --- Comment #10 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/328b7a34255ed1ffb0029fa1f247d16ba92f18cd tdf#149626 use recursive_mutex to fix hang in macro callback during dnd It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/inc
vcl/inc/dndeventdispatcher.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 328b7a34255ed1ffb0029fa1f247d16ba92f18cd Author: Caolán McNamara AuthorDate: Fri Jun 24 15:44:40 2022 +0100 Commit: Noel Grandin CommitDate: Fri Jun 24 21:45:30 2022 +0200 tdf#149626 use recursive_mutex to fix hang in macro callback during dnd See frame #5 and frame #45 where both the same DNDEventDispatcher object and both functions lock m_aMutex which is a std::mutex since commit 8de81db4e3fca488d50db2d74734109b31541a6f Date: Mon Aug 2 09:21:17 2021 +0200 osl::Mutex->std::mutex in DNDEventDispatcher #0 0x7ff094530c40 in __lll_lock_wait () at /lib64/libc.so.6 #1 0x7ff0945371d2 in pthread_mutex_lock@@GLIBC_2.2.5 () at /lib64/libc.so.6 #2 0x7ff08b901663 in __gthread_mutex_lock(pthread_mutex_t*) (__mutex=0x1a32c60) at /usr/bin/../lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/x86_64-redhat-linux/bits/gthr-default.h:749 #3 0x7ff08b9024d5 in std::mutex::lock() (this=0x1a32c60) at /usr/bin/../lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/std_mutex.h:100 #4 0x7ff08b9018f3 in std::scoped_lock::scoped_lock(std::mutex&) (this=0x7ffdd0d79240, __m=...) at /usr/bin/../lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/mutex:731 #5 0x7ff08b9006a8 in DNDEventDispatcher::dragOver(com::sun::star::datatransfer::dnd::DropTargetDragEvent const&) (this=0x1a32c10, dtde=...) at vcl/source/window/dndeventdispatcher.cxx:156 #6 0x7ff075f47658 in GtkInstDropTarget::fire_dragOver(com::sun::star::datatransfer::dnd::DropTargetDragEvent const&) (this=0x199eb40, dtde=...) at vcl/unx/gtk3/gtkinst.cxx:1710 #7 0x7ff0760a7010 in GtkInstDropTarget::signalDragMotion(_GtkWidget*, _GdkDragContext*, int, int, unsigned int) (this=0x199eb40, pWidget=0x1c67e40, context=0x1957450, x=89, y=175, time=0) at vcl/unx/gtk3/gtkframe.cxx:5026 #8 0x7ff07609bb77 in GtkSalFrame::signalDragMotion(_GtkWidget*, _GdkDragContext*, int, int, unsigned int, void*) (pWidget=0x1c67e40, context=0x1957450, x=89, y=175, time=0, frame=0x19b7d70) at vcl/unx/gtk3/gtkframe.cxx:4922 #9 0x7ff075649527 in _gtk_marshal_BOOLEAN__OBJECT_INT_INT_UINTv () at /lib64/libgtk-3.so.0 #10 0x7ff0865dcd5b in g_signal_emit_valist () at /lib64/libgobject-2.0.so.0 #11 0x7ff0865ddeb8 in g_signal_emit_by_name () at /lib64/libgobject-2.0.so.0 #12 0x7ff07595b491 in gtk_drag_dest_motion.lto_priv () at /lib64/libgtk-3.so.0 #13 0x7ff0757b8f7d in gtk_main_do_event () at /lib64/libgtk-3.so.0 #14 0x7ff0754e5463 in _gdk_event_emit () at /lib64/libgdk-3.so.0 #15 0x7ff075518056 in gdk_event_source_dispatch () at /lib64/libgdk-3.so.0 #16 0x7ff0864c3faf in g_main_context_dispatch () at /lib64/libglib-2.0.so.0 #17 0x7ff0865192c8 in g_main_context_iterate.constprop () at /lib64/libglib-2.0.so.0 #18 0x7ff0864c1940 in g_main_context_iteration () at /lib64/libglib-2.0.so.0 #19 0x7ff075f3e60f in GtkSalData::Yield(bool, bool) (this=0x952930, bWait=false, bHandleAllCurrentEvents=false) at vcl/unx/gtk3/gtkdata.cxx:405 #20 0x7ff075f43e43 in GtkInstance::DoYield(bool, bool) (this=0x9527e0, bWait=false, bHandleAllCurrentEvents=false) at vcl/unx/gtk3/gtkinst.cxx:428 #21 0x7ff08c2dc5df in ImplYield(bool, bool) (i_bWait=false, i_bAllEvents=false) at vcl/source/app/svapp.cxx:474 #22 0x7ff08c2dc24d in Application::Reschedule(bool) (i_bAllEvents=false) at vcl/source/app/svapp.cxx:493 #23 0x7ff091eeeb55 in SbiRuntime::Step() (this=0xa21eb20) at basic/source/runtime/runtime.cxx:801 #24 0x7ff091e0e659 in (anonymous namespace)::RunInitGuard::run() (this=0x76a6290) at basic/source/classes/sbxmod.cxx:1015 #25 0x7ff091e0d135 in SbModule::Run(SbMethod*) (this=0xa0ada00, pMeth=0xa16d7e0) at basic/source/classes/sbxmod.cxx:1176 #26 0x7ff091e0c503 in SbModule::Notify(SfxBroadcaster&, SfxHint const&) (this=0xa0ada00, rBC=..., rHint=...) at basic/source/classes/sbxmod.cxx:775 #27 0x7ff090b3ee6e in SfxBroadcaster::Broadcast(SfxHint const&) (this=0xa231de0, rHint=...) at svl/source/notify/SfxBroadcaster.cxx:39 #28 0x7ff091e1372e in SbMethod::Broadcast(SfxHintId) (this=0xa231ca0, nHintId=SfxHintId::BasicDataWanted) at basic/source/classes/sbxmod.cxx:2113 #29 0x7ff091f6ddfa in SbxObject::Call(rtl::OUString const&, SbxArray*) (this=0xa258670, rName="DTL_dragOver", pParam=0xa1e47d0) at basic/source/sbx/sbxobj.cxx:274 #30 0x7ff091d9dd76 in StarBASIC::Call(rtl::OUString const&, SbxArray*) (this=0xa258670, rName="DTL_dragOver", pParam=0xa1e47d0) at basic/source/classes/sb.cxx:1324 #31 0x7ff091dd7127 in (anonymous
[Libreoffice-bugs] [Bug 149626] HANG during basic macro using com.sun.star.datatransfer.dnd
https://bugs.documentfoundation.org/show_bug.cgi?id=149626 Commit Notification changed: What|Removed |Added Whiteboard||target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: external/liborcus
external/liborcus/UnpackedTarball_liborcus.mk |1 external/liborcus/overrun.patch.0 | 63 ++ 2 files changed, 64 insertions(+) New commits: commit 3f17a643d0f943d02c7cb2b5d8e702fe0e63e38d Author: Stephan Bergmann AuthorDate: Fri Jun 24 18:21:32 2022 +0200 Commit: Stephan Bergmann CommitDate: Fri Jun 24 21:36:34 2022 +0200 external/liborcus: Fix heap-buffer-overflow ...as seen during CppunitTest_vcl_pdfexport: > ==573913==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x62b0001dba0e at pc 0x560576627186 bp 0x7ffeab9fa730 sp 0x7ffeab9f9ef0 > READ of size 26624 at 0x62b0001dba0e thread T0 > #0 in StrtolFixAndCheck(void*, char const*, char**, char*, int) at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:3629:3 > #1 in strtol at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_interceptors.cpp:485:3 > #2 in orcus::sax_token_handler_wrapper_base::attribute(std::basic_string_view>, std::basic_string_view>) at workdir/UnpackedTarball/liborcus/src/parser/sax_token_parser.cpp:344:22 > #3 in orcus::sax_ns_parser::handler_wrapper>::handler_wrapper::attribute(orcus::sax::parser_attribute const&) at workdir/UnpackedTarball/liborcus/src/liborcus/../../include/orcus/sax_ns_parser.hpp:212:27 > #4 in orcus::sax_parser::handler_wrapper>::handler_wrapper, orcus::sax_parser_default_config>::attribute() at workdir/UnpackedTarball/liborcus/src/liborcus/../../include/orcus/sax_parser.hpp:570:15 > #5 in orcus::sax_parser::handler_wrapper>::handler_wrapper, orcus::sax_parser_default_config>::declaration(char const*) at workdir/UnpackedTarball/liborcus/src/liborcus/../../include/orcus/sax_parser.hpp:389:9 > #6 in orcus::sax_parser::handler_wrapper>::handler_wrapper, orcus::sax_parser_default_config>::element() at workdir/UnpackedTarball/liborcus/src/liborcus/../../include/orcus/sax_parser.hpp:242:13 > #7 in orcus::sax_parser::handler_wrapper>::handler_wrapper, orcus::sax_parser_default_config>::body() at workdir/UnpackedTarball/liborcus/src/liborcus/../../include/orcus/sax_parser.hpp:214:13 > #8 in orcus::sax_parser::handler_wrapper>::handler_wrapper, orcus::sax_parser_default_config>::parse() at workdir/UnpackedTarball/liborcus/src/liborcus/../../include/orcus/sax_parser.hpp:182:5 > #9 in orcus::sax_ns_parser::handler_wrapper>::parse() at workdir/UnpackedTarball/liborcus/src/liborcus/../../include/orcus/sax_ns_parser.hpp:277:14 > #10 in orcus::sax_token_parser::parse() at workdir/UnpackedTarball/liborcus/src/liborcus/../../include/orcus/sax_token_parser.hpp:215:14 > #11 in orcus::xml_stream_parser::parse() at workdir/UnpackedTarball/liborcus/src/liborcus/xml_stream_parser.cpp:68:9 > #12 in orcus::orcus_xls_xml::detect(unsigned char const*, unsigned long) at workdir/UnpackedTarball/liborcus/src/liborcus/orcus_xls_xml.cpp:94:16 > #13 in orcus::detect(unsigned char const*, unsigned long) at workdir/UnpackedTarball/liborcus/src/liborcus/format_detection.cpp:68:9 > #14 in (anonymous namespace)::OrcusFormatDetect::detect(com::sun::star::uno::Sequence&) at sc/source/filter/orcus/filterdetect.cxx:83:31 > 0x62b0001dba0e is located 0 bytes to the right of 26638-byte region [0x62b0001d5200,0x62b0001dba0e) > allocated by thread T0 here: > #0 in operator new[](unsigned long) at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:98:3 > #1 in SvMemoryStream::AllocateMemory(unsigned long) at tools/source/stream/stream.cxx:1698:12 > #2 in SvMemoryStream::SvMemoryStream(unsigned long, unsigned long) at tools/source/stream/stream.cxx:1544:9 > #3 in (anonymous namespace)::OrcusFormatDetect::detect(com::sun::star::uno::Sequence&) at sc/source/filter/orcus/filterdetect.cxx:71:20 This started to occur now after a95c585433246813096e8890b7ed6ef4fe30c621 "Pump XInputStream into an SvMemoryStream rather than an OStringBuffer" no longer guarantees that the memory range passed into orcus::detect(const unsigned char* buffer, size_t length) is followed by a null byte at buffer[length]. (There appears to be no documentation for that function, but it looks unreasonable to me that it should require callers to provide a buffer thus terminated, and I rather assume that what is observed here is an orcus bug.) The problematic calls of std::strtol were used in code apparently meant to parse strings matching the XML VersionNum grammar production, and then store the two dot-separated numbers each as uint8_t. The new code using a local readUint8 accepts a different set of strings now than the original code using std::strtol, but the new set is arguably closer to what the actual XML VersionNum grammar production accepts (which is '1.' [0-9]+ for XML 1.0 and '1.1' for XML
[Libreoffice-bugs] [Bug 113546] [META] Paragraph indent bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113546 Bug 113546 depends on bug 124769, which changed state. Bug 124769 Summary: FILEOPEN DOCX: LO doesn't shrink spaces when justify-aligning paragraphs https://bugs.documentfoundation.org/show_bug.cgi?id=124769 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107830] [META] DOCX (OOXML) paragraph-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107830 Bug 107830 depends on bug 124769, which changed state. Bug 124769 Summary: FILEOPEN DOCX: LO doesn't shrink spaces when justify-aligning paragraphs https://bugs.documentfoundation.org/show_bug.cgi?id=124769 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119908] FILEOPEN: DOCX: Layout differences with justified paragraph. MS 2013 introduced a new "smart justify" that can shrink as well as expand.
https://bugs.documentfoundation.org/show_bug.cgi?id=119908 Justin L changed: What|Removed |Added CC||patrick.j...@tu-dresden.de --- Comment #10 from Justin L --- *** Bug 124769 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 124769] FILEOPEN DOCX: LO doesn't shrink spaces when justify-aligning paragraphs
https://bugs.documentfoundation.org/show_bug.cgi?id=124769 Justin L changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #18 from Justin L --- *** This bug has been marked as a duplicate of bug 119908 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138139] FILEOPEN DOCX Empty paragraph with only page break has its border from style drawn
https://bugs.documentfoundation.org/show_bug.cgi?id=138139 Justin L changed: What|Removed |Added CC||jl...@mail.com Severity|normal |minor Priority|medium |low --- Comment #3 from Justin L --- It is an emulation thing. Word treats the page break as a carriage return, while LO doesn't, so it needs to insert a CR (with all that entails). We need to clear numbering in a similar way IIRC. Searching for "bRemove" should get you in the right area of the code. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115523] FILEOPEN Track Changes: Writer does not show the change in number of deleted numbered paragraphs
https://bugs.documentfoundation.org/show_bug.cgi?id=115523 Commit Notification changed: What|Removed |Added Whiteboard|target:7.5.0|target:7.5.0 ||target:7.4.0.0.beta2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115523] FILEOPEN Track Changes: Writer does not show the change in number of deleted numbered paragraphs
https://bugs.documentfoundation.org/show_bug.cgi?id=115523 --- Comment #7 from Commit Notification --- László Németh committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/9d429619fa04fb30dc8ab48dcc23d523f50b7aae tdf#115523 sw_redlinenum: show correct, also original numbering It will be available in 7.4.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sw/qa sw/source
sw/qa/extras/layout/data/tdf149710.fodt | 31 +++ sw/qa/extras/layout/layout2.cxx | 42 ++ sw/source/core/doc/DocumentRedlineManager.cxx | 12 +++ 3 files changed, 85 insertions(+) New commits: commit d3b0fb222f96964d7bd2b82fe20e1547f731b7a6 Author: László Németh AuthorDate: Fri Jun 24 11:21:46 2022 +0200 Commit: László Németh CommitDate: Fri Jun 24 21:14:49 2022 +0200 tdf#149710 sw_redlinenum: update numbering at deletion in Show Changes mode. Follow-up to commit 2413f213625253a9c2b1787b3b9fe859d724a9bd "tdf#115523 sw_redlinenum: show correct, also original numbering". Change-Id: Iebf54775f3850e668ac5b12ecbd9f010b4e93ee4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136363 Tested-by: Jenkins Reviewed-by: László Németh (cherry picked from commit 4430bf8f97b1438252dc494cae89863d24469d2b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136392 diff --git a/sw/qa/extras/layout/data/tdf149710.fodt b/sw/qa/extras/layout/data/tdf149710.fodt new file mode 100644 index ..c936b9f9bcef --- /dev/null +++ b/sw/qa/extras/layout/data/tdf149710.fodt @@ -0,0 +1,31 @@ + + +http://www.w3.org/1999/xlink; xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" xmlns:math="http://www.w3.org/1998/Math/MathML; xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" xmlns:config="urn:oas is:names:tc:opendocument:xmlns:config:1.0" xmlns:ooo="http://openoffice.org/2004/office; xmlns:ooow="http://openoffice.org/2004/writer; xmlns:oooc="http://openoffice.org/2004/calc; xmlns:dom="http://www.w3.org/2001/xml-events; xmlns:xforms="http://www.w3.org/2002/xforms; xmlns:xsd="http://www.w3.org/2001/XMLSchema; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xmlns:rpt="http://openoffice.org/2005/report; xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" xmlns:xhtml="http://www.w3.org/1999/xhtml; xmlns:grddl="http://www.w3.org/2003/g/data-view#; xmlns:officeooo="http://openoffice.org/2009/office; xmlns:tableooo="http://openoffice.org/2009/table; xmlns:drawooo="http://openoffice.org/2010/draw; xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0" xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0" xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" xmlns:formx="urn:openoffice:names: experimental:ooxml-odf-interop:xmlns:form:1.0" xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" office:mimetype="application/vnd.oasis.opendocument.text"> + + + + + + + + + + + + + + + + + Item + + + Item + + + Item + + + + + diff --git a/sw/qa/extras/layout/layout2.cxx b/sw/qa/extras/layout/layout2.cxx index 57e06f05553e..66941abc4269 100644 --- a/sw/qa/extras/layout/layout2.cxx +++ b/sw/qa/extras/layout/layout2.cxx @@ -332,6 +332,48 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter2, testRedlineNumbering) assertXPathContent(pXmlDoc, "/metafile/push/push/push/textarray[5]/text", "2.[3.] "); } +CPPUNIT_TEST_FIXTURE(SwLayoutWriter2, testTdf149710_RedlineNumberingEditing) +{ +SwDoc* pDoc = createSwDoc(DATA_DIRECTORY, "tdf149710.fodt"); +SwXTextDocument* pTextDoc = dynamic_cast(mxComponent.get()); +CPPUNIT_ASSERT(pTextDoc); + +// Show Changes +SwWrtShell* pWrtShell = pTextDoc->GetDocShell()->GetWrtShell(); +SwRootFrame* pLayout(pWrtShell->GetLayout()); +CPPUNIT_ASSERT(!pLayout->IsHideRedlines()); + +// delete the paragraph mark of the first list item with change tracking +dispatchCommand(mxComponent, ".uno:GoToEndOfLine", {}); +dispatchCommand(mxComponent, ".uno:TrackChanges", {}); +dispatchCommand(mxComponent, ".uno:Delete", {}); + +// Dump the rendering of the first page as an XML file. +SwDocShell* pShell = pDoc->GetDocShell(); +std::shared_ptr xMetaFile = pShell->GetPreviewMetaFile(); +MetafileXmlDump dumper; + +xmlDocUniquePtr pXmlDoc = dumpAndParse(dumper, *xMetaFile); +CPPUNIT_ASSERT(pXmlDoc); + +// Show the correct and the original line numbering instead of counting +// the deleted list items in Show Changes mode, as part of the list +// This was "1." +assertXPathContent(pXmlDoc, "/metafile/push/push/push/textarray[1]/text", "[1.] "); +// This was "2." (deleted text node, now its text content is part of the first list item) +assertXPathContent(pXmlDoc, "/metafile/push/push/push/textarray[3]/text", "1.[2.] "); +
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sw/inc sw/qa sw/source
sw/inc/list.hxx | 23 +++- sw/inc/ndtxt.hxx| 15 - sw/qa/extras/layout/data/tdf115523.fodt | 42 +++ sw/qa/extras/layout/layout2.cxx | 27 -- sw/source/core/doc/list.cxx | 13 +++- sw/source/core/text/txtfld.cxx | 43 +--- sw/source/core/txtnode/ndtxt.cxx| 86 7 files changed, 208 insertions(+), 41 deletions(-) New commits: commit 9d429619fa04fb30dc8ab48dcc23d523f50b7aae Author: László Németh AuthorDate: Thu Jun 23 12:11:22 2022 +0200 Commit: László Németh CommitDate: Fri Jun 24 21:14:31 2022 +0200 tdf#115523 sw_redlinenum: show correct, also original numbering in Show Changes mode, according to the name "Show Changes" and according to the interoperability requirements. Instead of the fake numbering which counted the deleted list items in Show Changes mode, e.g.: "3. This was the third originally, but now it's the second list item." now show the correct number followed by the original number within braces: "2.[3.] This was the third originally, but now it's the second list item." Note: the tabulators after the longer numbering are replaced with spaces to avoid messy indentation in Show Changes mode. New enum values for the alternative lists: SwListRedlineType::SHOW - the original (fake) numbering in Show Changes mode SwListRedlineType::HIDDEN - the original numbering of Hide Changes mode, and new numbering in Show Changes mode SwListRedlineType::ORIGTEXT - the new numbering of Show Changes mode to show the original numbering of the deleted or inserted list items Follow-up to commit c180c9447256588fe5e7991e06642883574760ae "sw_redlinehide_3: add second SwNodeNum to SwTextNode". Change-Id: Ieaca550561c5d5a7ac5d9defb9c7fa283d6aa674 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136313 Tested-by: Jenkins Reviewed-by: László Németh (cherry picked from commit 093588f4b4914e95a6f1604777b6d74c684b654e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136333 Tested-by: László Németh diff --git a/sw/inc/list.hxx b/sw/inc/list.hxx index 14acb303ae07..d62d3a46ea86 100644 --- a/sw/inc/list.hxx +++ b/sw/inc/list.hxx @@ -29,6 +29,13 @@ class SwDoc; class SwNumRule; class SwNodes; +enum class SwListRedlineType +{ +SHOW, +HIDDEN, +ORIGTEXT, +}; + class SwList { public: @@ -44,7 +51,7 @@ class SwList void SetDefaultListStyleName(OUString const&); void InsertListItem(SwNodeNum& rNodeNum, -bool isHiddenRedlines, +SwListRedlineType eRedlines, const int nLevel, const SwDoc& rDoc); static void RemoveListItem(SwNodeNum& rNodeNum, const SwDoc& rDoc); @@ -84,10 +91,20 @@ class SwList /// the previous node on the same level. /// The nodes of pRootRLHidden are a subset of the nodes of pRoot. std::unique_ptr pRootRLHidden; +/// Tree that is missing those nodes that are merged or hidden +/// by insert redlines; this is only used if there is a layout +/// that has IsHideRedlines() disabled, and the numbering of the +/// original text is also shown. +/// A third tree is needed because not only are the numbers in +/// the nodes different, the structure of the tree may be different +/// The nodes of pRootOrigText are a subset of the nodes of pRoot. +std::unique_ptr pRootOrigText; /// top-level SwNodes section std::unique_ptr pSection; -tListTreeForRange(std::unique_ptr p1, std::unique_ptr p2, std::unique_ptr p3) -: pRoot(std::move(p1)), pRootRLHidden(std::move(p2)), pSection(std::move(p3)) {} +tListTreeForRange(std::unique_ptr p1, std::unique_ptr p2, +std::unique_ptr p3, std::unique_ptr p4) +: pRoot(std::move(p1)), pRootRLHidden(std::move(p2)), +pRootOrigText(std::move(p3)), pSection(std::move(p4)) {} }; std::vector maListTrees; diff --git a/sw/inc/ndtxt.hxx b/sw/inc/ndtxt.hxx index a2ca71ea197c..8007beff59cd 100644 --- a/sw/inc/ndtxt.hxx +++ b/sw/inc/ndtxt.hxx @@ -25,6 +25,7 @@ #include "IDocumentContentOperations.hxx" #include "SwNumberTreeTypes.hxx" #include "hintids.hxx" +#include "list.hxx" #include "modeltoviewhelper.hxx" #include "ndhints.hxx" #include "node.hxx" @@ -94,6 +95,7 @@ class SW_DLLPUBLIC SwTextNode final mutable std::unique_ptr mpNodeNum; ///< Numbering for this paragraph. mutable std::unique_ptr
[Libreoffice-bugs] [Bug 149718] Writer Crashes on inserting a Chart based on a Table with merged cells
https://bugs.documentfoundation.org/show_bug.cgi?id=149718 --- Comment #2 from inozemcew --- Created attachment 180951 --> https://bugs.documentfoundation.org/attachment.cgi?id=180951=edit File to reproduce crash Select column with numbers then 'Insert' - 'Chart' causes a crash. The problem appears when the count of merged cells plus selected column number is greater than total count of columns, I think. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102950] Format All Comments is not persistent for new comments
https://bugs.documentfoundation.org/show_bug.cgi?id=102950 Justin L changed: What|Removed |Added Blocks||101214 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=101214 [Bug 101214] Format All Comments doesn't function correctly in 2007 DOCX if the same format confirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101214] Format All Comments doesn't function correctly in 2007 DOCX if the same format confirmed
https://bugs.documentfoundation.org/show_bug.cgi?id=101214 Justin L changed: What|Removed |Added Depends on||102950 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102950 [Bug 102950] Format All Comments is not persistent for new comments -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108760] [META] DOCX (OOXML) style bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108760 Bug 108760 depends on bug 144947, which changed state. Bug 144947 Summary: IMPORT DOCX: Each page has its own page style after save as docx and reload https://bugs.documentfoundation.org/show_bug.cgi?id=144947 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108771] [META] DOCX (OOXML) page-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108771 Bug 108771 depends on bug 144947, which changed state. Bug 144947 Summary: IMPORT DOCX: Each page has its own page style after save as docx and reload https://bugs.documentfoundation.org/show_bug.cgi?id=144947 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108576] [META] Writer page style bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108576 Bug 108576 depends on bug 144947, which changed state. Bug 144947 Summary: IMPORT DOCX: Each page has its own page style after save as docx and reload https://bugs.documentfoundation.org/show_bug.cgi?id=144947 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145998] Page styles in docx-file revert to previous settings after reopening the document
https://bugs.documentfoundation.org/show_bug.cgi?id=145998 Justin L changed: What|Removed |Added CC||tele...@surfxs.nl --- Comment #7 from Justin L --- *** Bug 144947 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144947] IMPORT DOCX: Each page has its own page style after save as docx and reload
https://bugs.documentfoundation.org/show_bug.cgi?id=144947 Justin L changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #6 from Justin L --- *** This bug has been marked as a duplicate of bug 145998 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145998] Page styles in docx-file revert to previous settings after reopening the document
https://bugs.documentfoundation.org/show_bug.cgi?id=145998 Justin L changed: What|Removed |Added CC||jl...@mail.com Version|6.4.7.2 release |Inherited From OOo --- Comment #6 from Justin L --- DOCX has no concept of page styles. Everything here is based on emulation, so it is impossible to keep the page style names. In your specific document, you are using "section page breaks" - specifying a style to use. Change that to a normal page break, and you will be fine. [It is virtually impossible to compare equality with a existing page styles.] Perhaps we can be smarter on export? If the "section page break" is to the same style as the current page, could we just change that into a normal page break? Likely not, since everything "smartly" done about page styles backfires. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141265] Random characters appear as black boxes at certain zoom levels in windows 10.
https://bugs.documentfoundation.org/show_bug.cgi?id=141265 --- Comment #11 from mlbl...@gmail.com --- I tried to replicate this bug but I did not have any success. I kept my files open for a couple days and tried various zoom levels, but I never was able to observe this reported bug. With your original observations, did this happen with multiple font types and font sizes, or only with the font and size that was set in your attached documents? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149695] Untranslated strings in the Edit Paragraph Styles window of LO Writer 7.3.4 in Spanish
https://bugs.documentfoundation.org/show_bug.cgi?id=149695 --- Comment #5 from Albert Acer --- For "Set outline level, list style and line numbering for paragraph style", I fully agree with the translation suggested by Julien. That is the best understandable translation for us native Spanish speakers. For "Values on this tab specified in “Contains” in Organizer are removed", I fully agree with the translation suggested by Julien. That is the best understandable translation for us native Spanish speakers. For "Reset to Parent" I still have doubts, however, I will soon be providing my final answer. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - include/sal
include/sal/log.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4ed228b81d9d051addda86a4394ed2ad878cf34d Author: Noel Grandin AuthorDate: Tue Jun 21 12:10:21 2022 +0200 Commit: Michael Meeks CommitDate: Fri Jun 24 20:53:32 2022 +0200 use SAL_UNLIKELY to make logging a little more efficient if we have logging compiled into a release build, the most frequent logging (e.g. INFO) is typically off, so most of the time, we are not going to execute the logging. Change-Id: I2b464b4153307df8730998728e508cce09d5013b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136212 Tested-by: Jenkins Reviewed-by: Noel Grandin (cherry picked from commit 1fd6298be955331f64f6f0b2e04675d9914f44e4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136379 Tested-by: Jenkins CollaboraOffice Reviewed-by: Michael Meeks diff --git a/include/sal/log.hxx b/include/sal/log.hxx index 5faeec3113dc..a60d8dc24829 100644 --- a/include/sal/log.hxx +++ b/include/sal/log.hxx @@ -148,7 +148,7 @@ inline char const * unwrapStream(SAL_UNUSED_PARAMETER StreamIgnore const &) { #define SAL_DETAIL_LOG_STREAM(condition, level, area, where, stream) \ do { \ -if (condition) \ +if (SAL_UNLIKELY(condition)) \ { \ switch (sal_detail_log_report(level, area)) \ { \
[Libreoffice-bugs] [Bug 148956] DOCX Cleared direct formatting in styled paragraph lingers
https://bugs.documentfoundation.org/show_bug.cgi?id=148956 --- Comment #4 from Justin L --- No big surprise here. Heading formats are (almost by definition) numbering formats, and exporting numbering spams direct formatting all over the place. There are various places in DOCX export where style formatting needs to be spammed as direct formatting in order to emulate things. To make this a real bug, can you reproduce with a "normal" style that is not part of chapter numbering, or contain any numbering aspect? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105948] [META] Undo/Redo bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105948 Bug 105948 depends on bug 148522, which changed state. Bug 148522 Summary: Undo line color changes aligns text centered (and doesn't undo the line color) https://bugs.documentfoundation.org/show_bug.cgi?id=148522 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 100366] [META] Impress/Draw table bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=100366 Bug 100366 depends on bug 148522, which changed state. Bug 148522 Summary: Undo line color changes aligns text centered (and doesn't undo the line color) https://bugs.documentfoundation.org/show_bug.cgi?id=148522 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108769] [META] DOCX (OOXML) character-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108769 Bug 108769 depends on bug 142493, which changed state. Bug 142493 Summary: FILEOPEN DOCX: Settings of character position and size changes in character style "Footnote Anchor" https://bugs.documentfoundation.org/show_bug.cgi?id=142493 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108760] [META] DOCX (OOXML) style bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108760 Bug 108760 depends on bug 142493, which changed state. Bug 142493 Summary: FILEOPEN DOCX: Settings of character position and size changes in character style "Footnote Anchor" https://bugs.documentfoundation.org/show_bug.cgi?id=142493 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142493] FILEOPEN DOCX: Settings of character position and size changes in character style "Footnote Anchor"
https://bugs.documentfoundation.org/show_bug.cgi?id=142493 Justin L changed: What|Removed |Added Status|NEW |RESOLVED CC||jl...@mail.com Version|7.0.6.2 release |6.4 all versions See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=99 ||602 OS|Windows (All) |All Resolution|--- |WONTFIX --- Comment #13 from Justin L --- from bug 99602 comment 30: DOCX: Please note that the character-style subscripts are set to automatic/default values intentionally, regardless of what the user entered for relative size/position. NOT doing that in direct formatting caused lots of these problems in the first place, and adding a style into the mix only complicates it that much more. It is better to let the computer be smart about subscripts, rather than to pretend that we can make print-perfect matching between two completely different ways of describing subscripts/superscripts. Also see http://gerrit.libreoffice.org/c/core/+/80217/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108014] [META] Writer character style bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108014 Bug 108014 depends on bug 142493, which changed state. Bug 142493 Summary: FILEOPEN DOCX: Settings of character position and size changes in character style "Footnote Anchor" https://bugs.documentfoundation.org/show_bug.cgi?id=142493 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/oox oox/source
include/oox/helper/helper.hxx |2 +- oox/source/drawingml/chart/seriesconverter.cxx |2 +- oox/source/drawingml/shape.cxx |2 +- oox/source/vml/vmlformatting.cxx |2 +- oox/source/vml/vmlshape.cxx|6 -- oox/source/vml/vmltextbox.cxx |4 ++-- 6 files changed, 10 insertions(+), 8 deletions(-) New commits: commit 79f3abc0e200ffa772bc7722b5f384eb538d7576 Author: Noel Grandin AuthorDate: Fri Jun 24 11:55:13 2022 +0200 Commit: Noel Grandin CommitDate: Fri Jun 24 20:37:10 2022 +0200 make oox::OptValue::value() assert if empty as part of replacing OptValue with std::optional, we need to mimc the behaviour of std::optional::value(), which will throw bad_optional_access Change-Id: Icf5141cefd4623a6a1bb7b3a3449d3af382e01c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136365 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/include/oox/helper/helper.hxx b/include/oox/helper/helper.hxx index 9d5b7c3e2549..ef066f31d338 100644 --- a/include/oox/helper/helper.hxx +++ b/include/oox/helper/helper.hxx @@ -180,7 +180,7 @@ public: bool has_value() const { return mbHasValue; } bool operator!() const { return !mbHasValue; } -const Type& value() const { return maValue; } +const Type& value() const { assert(mbHasValue); return maValue; } const Type& value_or( const Type& rDefValue ) const { return mbHasValue ? maValue : rDefValue; } Type&operator*() { assert(mbHasValue); return maValue; } diff --git a/oox/source/drawingml/chart/seriesconverter.cxx b/oox/source/drawingml/chart/seriesconverter.cxx index 383e5bd3fa4b..03e97d3e3339 100644 --- a/oox/source/drawingml/chart/seriesconverter.cxx +++ b/oox/source/drawingml/chart/seriesconverter.cxx @@ -197,7 +197,7 @@ void importBorderProperties( PropertySet& rPropSet, Shape& rShape, const Graphic { LineProperties& rLP = rShape.getLineProperties(); // no fill has the same effect as no border so skip it -if (rLP.maLineFill.moFillType.value() == XML_noFill) +if (rLP.maLineFill.moFillType.has_value() && rLP.maLineFill.moFillType.value() == XML_noFill) return; if (rLP.moLineWidth.has_value()) diff --git a/oox/source/drawingml/shape.cxx b/oox/source/drawingml/shape.cxx index 236e0bea3c82..20564b584f76 100644 --- a/oox/source/drawingml/shape.cxx +++ b/oox/source/drawingml/shape.cxx @@ -1685,7 +1685,7 @@ Reference< XShape > const & Shape::createAndInsert( mpCustomShapePropertiesPtr->setMirroredY( true ); if( getTextBody() ) { -sal_Int32 nTextCameraZRotation = static_cast< sal_Int32 >( getTextBody()->get3DProperties().maCameraRotation.mnRevolution.value() ); +sal_Int32 nTextCameraZRotation = getTextBody()->get3DProperties().maCameraRotation.mnRevolution.value_or(0); mpCustomShapePropertiesPtr->setTextCameraZRotateAngle( nTextCameraZRotation / 6 ); sal_Int32 nTextRotateAngle = static_cast< sal_Int32 >( getTextBody()->getTextProperties().moRotation.value_or( 0 ) ); diff --git a/oox/source/vml/vmlformatting.cxx b/oox/source/vml/vmlformatting.cxx index 6d80193e7b37..00a346748531 100644 --- a/oox/source/vml/vmlformatting.cxx +++ b/oox/source/vml/vmlformatting.cxx @@ -981,7 +981,7 @@ void TextpathModel::pushToPropMap(ShapePropertyMap& rPropMap, const uno::Referen if (moTrim.has_value() && moTrim.value()) return; -OUString sText = moString.value(); +OUString sText = moString.value_or(""); ScopedVclPtrInstance pDevice; vcl::Font aFont = pDevice->GetFont(); aFont.SetFamilyName(sFont); diff --git a/oox/source/vml/vmlshape.cxx b/oox/source/vml/vmlshape.cxx index 2cb8261f1af4..22ea45a3bdd3 100644 --- a/oox/source/vml/vmlshape.cxx +++ b/oox/source/vml/vmlshape.cxx @@ -578,7 +578,7 @@ SimpleShape::SimpleShape( Drawing& rDrawing, const OUString& rService ) : static void lcl_setSurround(PropertySet& rPropSet, const ShapeTypeModel& rTypeModel, const GraphicHelper& rGraphicHelper) { -OUString aWrapType = rTypeModel.moWrapType.value(); +OUString aWrapType = rTypeModel.moWrapType.value_or(""); // Extreme negative top margin? Then the shape will end up at the top of the page, it's pointless to perform any kind of wrapping. sal_Int32 nMarginTop = ConversionHelper::decodeMeasureToHmm(rGraphicHelper, rTypeModel.maMarginTop, 0, false, true); @@ -590,7 +590,9 @@ static void lcl_setSurround(PropertySet& rPropSet, const ShapeTypeModel& rTypeMo aWrapType == "through" ) { nSurround = css::text::WrapTextMode_PARALLEL; -if ( rTypeModel.moWrapSide.value() == "left" ) +if ( !rTypeModel.moWrapSide.has_value() ) +; // leave as PARALLEL +else if ( rTypeModel.moWrapSide.value() == "left" ) nSurround
[Libreoffice-bugs] [Bug 149718] Writer Crashes on inserting a Chart based on a Table with merged cells
https://bugs.documentfoundation.org/show_bug.cgi?id=149718 Rafael Lima changed: What|Removed |Added Ever confirmed|0 |1 CC||rafael.palma.l...@gmail.com Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Rafael Lima --- Not repro in Version: 7.3.3.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Ubuntu package version: 1:7.3.3~rc2-0ubuntu0.21.10.1~lo1 Calc: threaded Nor in Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: cb83063cc0eb4e93bd44bc0cb9b7c4841230cdef CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: threaded Please, share a sample file so we can test if this is indeed a bug. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 132092] DOCX import: a generated document has black text highlighting, where in Word, the background is white
https://bugs.documentfoundation.org/show_bug.cgi?id=132092 Justin L changed: What|Removed |Added Severity|normal |minor Priority|medium |low --- Comment #6 from Justin L --- styles.xml w:docDefaults contains Assuming something here is illegal since all is well after MS Word round-trips it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 130363] FILESAVE DOCX character padded border highlight fill incomplete at end-of-line
https://bugs.documentfoundation.org/show_bug.cgi?id=130363 --- Comment #6 from David Nolan --- Issue can also occur whilst editing a file saved as an odt. Once problem starts, however, the only solution is to reload the file. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149716] Crash on cutting cells loses data permanently
https://bugs.documentfoundation.org/show_bug.cgi?id=149716 --- Comment #1 from Rafael Lima --- Hi, thanks for your report. Simply cutting a range with Ctrl+X does not remove it from the file unless it is saved. I ran a test on my PC: 1) Created a sheet with bogus data 2) Saved the file 3) Selected a range with data and Ctrl+X (the selected data disappears from the view) 4) I forced a crash by killing LO process 5) Restarted LO and File Recovery dialog showed up 6) Proceeded with recovery 7) The file with all the data was recovered, including the range I had cut What may have happened is that the file was restored to the last point it was saved before the crash. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149718] New: Writer Crashes on inserting a Chart based on a Table with merged cells
https://bugs.documentfoundation.org/show_bug.cgi?id=149718 Bug ID: 149718 Summary: Writer Crashes on inserting a Chart based on a Table with merged cells Product: LibreOffice Version: 7.3.4.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: inozem...@i.ua Description: Writer crashes when a chart is being inserted which is based on a table with merged cells. After recovery there are an empty chart with no data source. Steps to Reproduce: 1.Insert a table and merge two first cells 2.Put any data in other(non-merged) cells 3.Select the cells with data and click in the main menu 'Insert' - 'Chart' Actual Results: Writer immediately crash. Expected Results: Chart configuration dialog must appear. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Version: 7.3.4.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 3; OS: Linux 5.14; UI render: default; VCL: kf5 (cairo+xcb) Locale: uk-UA (ru_UA.UTF-8); UI: ru-RU Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 130363] FILESAVE DOCX character padded border highlight fill incomplete at end-of-line
https://bugs.documentfoundation.org/show_bug.cgi?id=130363 Justin L changed: What|Removed |Added CC||jl...@mail.com Hardware|x86-64 (AMD64) |All OS|Windows (All) |All --- Comment #5 from Justin L --- repro 7.5+ Must be a layout issue I assume. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149623] Writer does not allow to view source for HTML
https://bugs.documentfoundation.org/show_bug.cgi?id=149623 --- Comment #2 from raal --- and Version: 7.4.0.0.beta1+ / LibreOffice Community Build ID: 6ab56a4fc946f6294513f23a3ea47aa0aa154b7d CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: x11 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded Jumbo -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149623] Writer does not allow to view source for HTML
https://bugs.documentfoundation.org/show_bug.cgi?id=149623 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #1 from raal --- Works for me in Version: 7.2.7.2 / LibreOffice Community Build ID: 20(Build:2) CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: cs-CZ Ubuntu package version: 1:7.2.7-0ubuntu0.21.10.1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146901] Files .docx forget subscript format when file is saved. Files .odt do not forget.
https://bugs.documentfoundation.org/show_bug.cgi?id=146901 --- Comment #3 from Justin L --- LO and MS Word use totally different concepts to format subscripts. So this it is total emulation hacking to convert from one to another. It is impossible to keep things exact, so best to just use all default/automatic values. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149630] Can't search for single quote character (hex 27)
https://bugs.documentfoundation.org/show_bug.cgi?id=149630 --- Comment #8 from Michael Warner --- (In reply to V Stuart Foote from comment #5) > For OP, any reason you don't use the Find & Replace dialog's 'Other options' > -> 'Regular expressions' search for "\u0027", or octal "\0047". > > Both provided by ICU libs and that seem functional and suited to specific > ask? That may be an option for this specific person's particular task, but expecting this to be the go-to solution for the average user is not reasonable, in my opinion. I feel confident in saying that it is a small subset of LO users who know what regular expressions are or would ever think to search for a character using a hex code. This seems to me like more of a workaround than an expected use case for what should be the simple task of finding a specific character (and only that character). > > An additional transliteration mode that László and Mike K. mention in the > gerrit link aside, the search dialog still works. Even if you don't consider this to be a bug, the enhancement proposals Mike K. provides in Comment 4 seem like good usability improvements to me. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 126314] FILEOPEN: DOCX: Incorrect height of line (b/c entire document is superscript)
https://bugs.documentfoundation.org/show_bug.cgi?id=126314 Justin L changed: What|Removed |Added Summary|FILEOPEN: DOCX: Incorrect |FILEOPEN: DOCX: Incorrect |height of line |height of line (b/c entire ||document is superscript) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149695] Untranslated strings in the Edit Paragraph Styles window of LO Writer 7.3.4 in Spanish
https://bugs.documentfoundation.org/show_bug.cgi?id=149695 Julien Nabet changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #4 from Julien Nabet --- On pc Debian x86-64 with master sources updated today + Spanish UI, I could reproduce this. I know very little Spanish but have access to Weblate to submit translations. Taking a look at https://wiki.documentfoundation.org/Language_Teams, there's Adolfo and another guy I don't know, Daniel Armando Rodriguez. Strings are here: #. xT7hc #: sw/uiconfig/swriter/ui/templatedialog2.ui:936 msgctxt "templatedialog2|outline" msgid "Set outline level, list style and line numbering for paragraph style." msgstr "" https://translations.documentfoundation.org/translate/libo_ui-master/swmessages/es/?checksum=4172912bf0c9163e=note%3AxT7hc_by=-priority%2Cposition Someone suggested: "Establezca el nivel de esquema, el estilo de lista y la numeración de líneas para el estilo de párrafo." #. FRWsF #: sw/inc/strings.hrc:28 msgctxt "STR_STANDARD_TOOLTIP" msgid "Values on this tab specified in “Contains” in Organizer are removed." msgstr "" https://translations.documentfoundation.org/translate/libo_ui-master/swmessages/es/?checksum=d250bb8b01e52b24=note%3AFRWsF_by=-priority%2Cposition Someone suggested: "Se eliminan los valores de esta pestaña especificados en "Contiene" en el Organizador." #. qGjWe #. Dialog buttons #: sw/inc/strings.hrc:27 msgctxt "STR_STANDARD_LABEL" msgid "Reset to ~Parent" msgstr "" https://translations.documentfoundation.org/translate/libo_ui-master/swmessages/es/?checksum=90b3ed44f3a99807=note%3AqGjWe_by=-priority%2Cposition Someone suggested: "Restaurar al ~Padre" If suggestions are ok, I can submit them on Weblate. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 72640] RTL: numbering alignment issue with doc and docx files
https://bugs.documentfoundation.org/show_bug.cgi?id=72640 Justin L changed: What|Removed |Added OS|Windows (All) |All Hardware|x86 (IA32) |All CC||jl...@mail.com -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sdext/source
sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) New commits: commit 71fb0151f985924af60c383331b214a5a27790a5 Author: Nathan Pratta Teodosio AuthorDate: Tue Jun 21 08:47:14 2022 -0300 Commit: Adolfo Jayme Barrientos CommitDate: Fri Jun 24 19:42:15 2022 +0200 Follow-up for Poppler 22.06 update Change-Id: I8ee9f1a53cc4389e6a4d44e9765b478b5edfffd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136342 Tested-by: Jenkins Reviewed-by: Michael Stahl (cherry picked from commit ad1ffc62e40c2409b610dfff25a8483b1f2556ad) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136382 Reviewed-by: Adolfo Jayme Barrientos diff --git a/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx b/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx index d9efa39d8a54..f12478cb2f4d 100644 --- a/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx +++ b/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx @@ -476,10 +476,10 @@ int PDFOutDev::parseFont( long long nNewId, GfxFont* gfxFont, const GfxState* st // we must write byte count to stdout before #if POPPLER_CHECK_VERSION(22, 6, 0) std::optional> pBuf = gfxFont->readEmbFontFile( m_pDoc->getXRef() ); -nSize = pBuf->size(); -if ( nSize > 0 ) +if ( pBuf ) { aNewFont.isEmbedded = true; +nSize = pBuf->size(); } #else char* pBuf = gfxFont->readEmbFontFile( m_pDoc->getXRef(), ); @@ -503,7 +503,8 @@ void PDFOutDev::writeFontFile( GfxFont* gfxFont ) const int nSize = 0; #if POPPLER_CHECK_VERSION(22, 6, 0) std::optional> pBuf = gfxFont->readEmbFontFile( m_pDoc->getXRef() ); -nSize = pBuf->size(); +if ( pBuf ) +nSize = pBuf->size(); if ( nSize == 0 ) return; #else
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sc/source
sc/source/ui/condformat/condformatmgr.cxx | 10 ++ 1 file changed, 10 insertions(+) New commits: commit f777a25f32b3c98a45cf1a24e130a5cce153f5d0 Author: Heiko Tietze AuthorDate: Wed Jun 15 12:07:31 2022 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Fri Jun 24 19:41:37 2022 +0200 Related tdf#101285 - Remember position of conditional format dialog Change-Id: I4094fb46bb6130f4befcc25136424a45b90b9d92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135897 Tested-by: Jenkins Reviewed-by: Heiko Tietze (cherry picked from commit 3d3341aa156e089a6ebcf399d9ec6ad1f183d063) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135889 Reviewed-by: Adolfo Jayme Barrientos diff --git a/sc/source/ui/condformat/condformatmgr.cxx b/sc/source/ui/condformat/condformatmgr.cxx index 06954a7f65d1..d4a2980a6dfa 100644 --- a/sc/source/ui/condformat/condformatmgr.cxx +++ b/sc/source/ui/condformat/condformatmgr.cxx @@ -13,6 +13,7 @@ #include #include #include +#include ScCondFormatManagerWindow::ScCondFormatManagerWindow(weld::TreeView& rTreeView, ScDocument& rDoc, ScConditionalFormatList* pFormatList) @@ -99,11 +100,20 @@ ScCondFormatManagerDlg::ScCondFormatManagerDlg(weld::Window* pParent, ScDocument m_xBtnAdd->connect_clicked(LINK(this, ScCondFormatManagerDlg, AddBtnHdl)); m_xTreeView->connect_row_activated(LINK(this, ScCondFormatManagerDlg, EditBtnHdl)); +SvtViewOptions aDlgOpt(EViewType::Dialog, "CondFormatDialog"); +if (aDlgOpt.Exists()) +m_xDialog->set_window_state(aDlgOpt.GetWindowState().toUtf8()); + UpdateButtonSensitivity(); } ScCondFormatManagerDlg::~ScCondFormatManagerDlg() { + // tdf#101285 - Remember position of dialog +SvtViewOptions aDlgOpt(EViewType::Dialog, "CondFormatDialog"); +OString sWindowState += m_xDialog->get_window_state(vcl::WindowDataMask::Pos); +aDlgOpt.SetWindowState(OUString::fromUtf8(sWindowState)); } std::unique_ptr ScCondFormatManagerDlg::GetConditionalFormatList()
[Libreoffice-bugs] [Bug 101285] Manage Conditional Formatting dialog doesn't remember position, column sizes, and range selection
https://bugs.documentfoundation.org/show_bug.cgi?id=101285 Commit Notification changed: What|Removed |Added Whiteboard|target:7.5.0|target:7.5.0 ||target:7.4.0.0.beta2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101285] Manage Conditional Formatting dialog doesn't remember position, column sizes, and range selection
https://bugs.documentfoundation.org/show_bug.cgi?id=101285 --- Comment #9 from Commit Notification --- Heiko Tietze committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/f777a25f32b3c98a45cf1a24e130a5cce153f5d0 Related tdf#101285 - Remember position of conditional format dialog It will be available in 7.4.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.