[Libreoffice-bugs] [Bug 149878] New: COPY & PASTE STYLES from document to document

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149878

Bug ID: 149878
   Summary: COPY & PASTE STYLES from document to document
   Product: LibreOffice
   Version: 7.5.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: j...@cspv.hu

hi,

- - - there are two suggestions in this post, the first one is just the
original version of the (simple) idea, the actual suggestion starts at [THE
actual suggestion] - - -

::PRE::

What I'm going to suggest lacks one intermediate stage, namely, to see the
styles of a document in such way as in Firefox's "inspect" view, where each
style's definition is displayed, including the definition's location, the
document and the exact line where it is...

Anyway, looking at the pace at which the STYLES EVOLUTION is happening, we're
practically there already... or will be the next moment...


ONE great possibility could be to be able to export a style to a template...

this could happen in the popup window, in a new tab...

it would mean, self-evidently, that the selected style, say, a "heading 1"
could be exported to XY template...
which would also make an overwrite dialog necessary...

the whole point is control over the styles...

a style has several directives... several settings in several tabs...
it's easy to make a mistake when attempting to "copy paste" a style to another
template... one thing you forget, one little checkbox, and the document will
look different, but only slightly, which means you might not notice it...

:: / PRE ::

:
[THE actual suggestion]
:


AN EASIER OPTION:

copy paste!!

in the style's "modify" popup window, in the organizer there could be a
button:  "copy this style definition"...

and.. accordingly, a "paste style definition from style clipboard", too...

this could be a pretty civilized method...
easy to use, and hopefully not crazy complex to implement...




- - - - - - -  thank you for developing Writer - - - - - - -

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149874] LibreOffice Writer 7.3.4.2 corrupts previously saved documents

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149874

Faisal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from Faisal  ---
Please attach the file with the problem and describe in more detail where the
images were anchored before.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149856] XLSX: the "highest row with data" marker will go to 1048576 when deleting any row within rows with data

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149856

--- Comment #3 from Mike Kaganski  ---
Created attachment 181131
  --> https://bugs.documentfoundation.org/attachment.cgi?id=181131=edit
Just a simple XLSX created with MS Excel 2016

(In reply to Eike Rathke from comment #2)
 is present in the
attached sample. So this could be turned into "defaultRowHeight attribute of
sheetFormatPr is not read / not taken into account when adding rows after row
removal".

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149842] Crash in: lcl_InnerCalcLayout

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149842

--- Comment #2 from Adalbert Hanßen  ---
(In reply to Xisco Faulí from comment #1)
> Thank you for reporting the bug. Please attach a sample document, as this
> makes it easier for us to verify the bug. 
> I have set the bug's status to 'NEEDINFO'. Please change it back to
> 'UNCONFIRMED' once the requested document is provided.
> (Please note that the attachment will be public, remove any sensitive
> information before attaching it. 
> See
> https://wiki.documentfoundation.org/QA/
> FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F for help
> on how to do so.)

In order to not interrupt my workflow, I had modified the document immediately.
Also it was a rather big one, so I can't provide it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149877] Track changes color coding inconsistent; moved has sometimes the same color as deleted

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149877

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||9873

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149873] Cursor doesn't move the left after pressing backspace with track changes enabled in certain consternation

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149873

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||9877

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149877] Track changes color coding inconsistent; moved has sometimes the same color as deleted

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149877

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||9388

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149877] New: Track changes color coding inconsistent; moved has sometimes the same color as deleted

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149877

Bug ID: 149877
   Summary: Track changes color coding inconsistent; moved has
sometimes the same color as deleted
   Product: LibreOffice
   Version: 7.5.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Track changes color coding inconsistent; moved has sometimes the same color as
deleted

Steps to Reproduce:
1. Open attachment 180483
2. Tools -> Options -> Make sure user date being empty (close dialog with OK)
3. Enable track changes: Edit -> Track changes -> Record (show changes should
be enabled)
3. Select the "six" in the first line
4. Backspace -> Text strike through, yellow (expected)
5. Select "ways" next to six in the first line
6. CTRL+X
7. CTRL_V -> Strike through, yellow -> UN-expected (reference: step 8-10)
8. Select "idolatry" in the first line
9. CTRL+X -> Text strike through, yellow (expected)
10. CTRL+V -> Text strike through, green (expected)
11. Press CTRL+Z once -> Text strike through, green (UN-expected, expected
yellow)


Actual Results:
Moved gets the color coding of deleted

Expected Results:
Proper color coding


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 7a89eae97a970939174d59aa58147eaa194acaee
CPU threads: 8; OS: Mac OS X 12.3.1; UI render: Skia/Metal; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149771] CRASH: pasting content

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149771

QA Administrators  changed:

   What|Removed |Added

   Keywords||bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149659] PPTX roundtrip looses writing mode and text area position for textbox with vert="eaVert"

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149659

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149658] Support OOXML Strict in "Save as" GUI and "convert-to" CLI

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149658

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149656] Discrepancy between "Text attributes" labels and actual view for writing-mode TB_RL (east asian)

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149656

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146071] Problem in Pivot table

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146071

--- Comment #3 from QA Administrators  ---
Dear Scott,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146071] Problem in Pivot table

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146071

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143207] Every time I open a .doc file it says it needs to be recovered

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143207

--- Comment #6 from QA Administrators  ---
Dear Chas B,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143207] Every time I open a .doc file it says it needs to be recovered

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143207

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143191] Cannot open hyperlink to another sheet

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143191

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143191] Cannot open hyperlink to another sheet

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143191

--- Comment #9 from QA Administrators  ---
Dear Chuyen Nguyen,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142804] General I/O error when attempting to export soft edge rectangles to SVG

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142804

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142626] Infinity save

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142626

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142804] General I/O error when attempting to export soft edge rectangles to SVG

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142804

--- Comment #8 from QA Administrators  ---
Dear Bogdan Stăncescu,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142626] Infinity save

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142626

--- Comment #6 from QA Administrators  ---
Dear Marat Nagayev,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146603] After minutes of usage, the UI of my computer goes black.

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146603

--- Comment #3 from QA Administrators  ---
Dear hyudongsoul,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - basctl/uiconfig connectivity/inc cui/uiconfig include/sfx2 include/svtools include/svx nlpsolver/help sc/inc

2022-07-05 Thread Adolfo Jayme Barrientos (via logerrit)
 basctl/uiconfig/basicide/ui/basicmacrodialog.ui  |2 
 connectivity/inc/strings.hrc |  102 +--
 cui/uiconfig/ui/optgeneralpage.ui|2 
 cui/uiconfig/ui/opthtmlpage.ui   |2 
 cui/uiconfig/ui/tipofthedaydialog.ui |4 
 include/sfx2/strings.hrc |2 
 include/svtools/strings.hrc  |   22 +-
 include/svx/strings.hrc  |   12 -
 nlpsolver/help/en/com.sun.star.comp.Calc.NLPSolver/Usage.xhp |2 
 sc/inc/globstr.hrc   |   10 -
 10 files changed, 80 insertions(+), 80 deletions(-)

New commits:
commit 67262d02da99f6304553fbff4b516853f8142ad3
Author: Adolfo Jayme Barrientos 
AuthorDate: Tue Jul 5 04:57:02 2022 -0500
Commit: Adolfo Jayme Barrientos 
CommitDate: Wed Jul 6 05:02:49 2022 +0200

Related tdf#137145 tdf#137569 Capitalization + punctuation fixes

Change-Id: Icd8a631da83c86333c7e5bcee0069165899d3041
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136822
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 
(cherry picked from commit d582bc1dfaa9f5b2628c20991ec3939a7c390223)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136773

diff --git a/basctl/uiconfig/basicide/ui/basicmacrodialog.ui 
b/basctl/uiconfig/basicide/ui/basicmacrodialog.ui
index cfcc9af9c038..bdece2cca419 100644
--- a/basctl/uiconfig/basicide/ui/basicmacrodialog.ui
+++ b/basctl/uiconfig/basicide/ui/basicmacrodialog.ui
@@ -23,7 +23,7 @@
   
 False
 6
-Basic Macros
+BASIC Macros
 True
 dialog
 
diff --git a/connectivity/inc/strings.hrc b/connectivity/inc/strings.hrc
index bbcab01914bd..6cf594809439 100644
--- a/connectivity/inc/strings.hrc
+++ b/connectivity/inc/strings.hrc
@@ -23,28 +23,28 @@
 
 // = common strings
 #define STR_NO_CONNECTION_GIVEN NC_("STR_NO_CONNECTION_GIVEN", 
"No connection to the database exists.")
-#define STR_WRONG_PARAM_INDEX   NC_("STR_WRONG_PARAM_INDEX", 
"You tried to set a parameter at position '$pos$' but there is/are only 
'$count$' parameter(s) allowed. One reason may be that the property 
\"ParameterNameSubstitution\" is not set to TRUE in the data source.")
+#define STR_WRONG_PARAM_INDEX   NC_("STR_WRONG_PARAM_INDEX", 
"You tried to set a parameter at position “$pos$” but there is/are only 
“$count$” parameter(s) allowed. One reason may be that the property 
“ParameterNameSubstitution” is not set to TRUE in the data source.")
 #define STR_NO_INPUTSTREAM  NC_("STR_NO_INPUTSTREAM", "The 
input stream was not set.")
-#define STR_NO_ELEMENT_NAME NC_("STR_NO_ELEMENT_NAME", 
"There is no element named '$name$'.")
+#define STR_NO_ELEMENT_NAME NC_("STR_NO_ELEMENT_NAME", 
"There is no element named “$name$”.")
 #define STR_INVALID_BOOKMARKNC_("STR_INVALID_BOOKMARK", 
"Invalid bookmark value")
 #define STR_PRIVILEGE_NOT_GRANTED   
NC_("STR_PRIVILEGE_NOT_GRANTED", "Privilege not granted: Only table privileges 
can be granted.")
 #define STR_PRIVILEGE_NOT_REVOKED   
NC_("STR_PRIVILEGE_NOT_REVOKED", "Privilege not revoked: Only table privileges 
can be revoked.")
 #define STR_ERRORMSG_SEQUENCE   NC_("STR_ERRORMSG_SEQUENCE", 
"Function sequence error.")
 #define STR_INVALID_INDEX   NC_("STR_INVALID_INDEX", 
"Invalid descriptor index.")
-#define STR_UNSUPPORTED_FUNCTION
NC_("STR_UNSUPPORTED_FUNCTION", "The driver does not support the function 
'$functionname$'.")
-#define STR_UNSUPPORTED_FEATURE NC_("STR_UNSUPPORTED_FEATURE", 
"The driver does not support the functionality for '$featurename$'. It is not 
implemented.")
+#define STR_UNSUPPORTED_FUNCTION
NC_("STR_UNSUPPORTED_FUNCTION", "The driver does not support the function 
“$functionname$”.")
+#define STR_UNSUPPORTED_FEATURE NC_("STR_UNSUPPORTED_FEATURE", 
"The driver does not support the functionality for “$featurename$”. It is not 
implemented.")
 #define STR_FORMULA_WRONG   NC_("STR_FORMULA_WRONG", "The 
formula for TypeInfoSettings is wrong!")
-#define STR_STRING_LENGTH_EXCEEDED  
NC_("STR_STRING_LENGTH_EXCEEDED", "The string '$string$' exceeds the maximum 
length of $maxlen$ characters when converted to the target character set 
'$charset$'.")
-#define STR_CANNOT_CONVERT_STRING   
NC_("STR_CANNOT_CONVERT_STRING", "The string '$string$' cannot be converted 
using the encoding '$charset$'.")
+#define STR_STRING_LENGTH_EXCEEDED  
NC_("STR_STRING_LENGTH_EXCEEDED", "The string “$string$” exceeds the maximum 
length of $maxlen$ characters when converted to the target character set 
“$charset$”.")
+#define 

[Libreoffice-bugs] [Bug 137145] Use Unicode symbols instead of ASCII in translatable strings

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137145

--- Comment #3 from Commit Notification 
 ---
Adolfo Jayme Barrientos committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/67262d02da99f6304553fbff4b516853f8142ad3

Related tdf#137145 tdf#137569 Capitalization + punctuation fixes

It will be available in 7.4.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 137145] Use Unicode symbols instead of ASCII in translatable strings

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137145

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.5.0|target:7.5.0
   ||target:7.4.0.0.beta2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149870] EDITING: Input line Contents vanishes with mouse click into line

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149870

--- Comment #4 from m.a.riosv  ---
Does it happen, if the message below the input line, it's closed?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149871] Menu for define / view cell ranges on a worksheet

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149871

m.a.riosv  changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #1 from m.a.riosv  ---
Please don't set up your own report as new, except you are going to assign it
to yourself, to work in it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149851] Mouse pointer over down arrow in AutoFilter should not be a fat cross

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149851

m.a.riosv  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #4 from m.a.riosv  ---
I see, but looks like the whole cell it's one object, the same happens with
hyperlink in a cell, you need to do the crtl+click so the mouse pointer
changes, after that if you don't click in other cell then the mouse pointer
change.
Maybe not an easy patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149854] Track Changes: replace of the first letter of a word is not consistent; new character at the left or right of deleted one depending on how

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149854

--- Comment #5 from Telesto  ---
(In reply to Rainer Bielefeld Retired from comment #3)
> Currently I am seeing that more than a feature than as a bug, but that
> mighbeseen different from a different POV.

I find it hard to tell, the variation is somewhat annoying; Esthetically and
for orientation. No clue what MSO does..

Original reporter at bug 149388

(In reply to Rainer Bielefeld Retired from comment #4)
> And I still don't see a regression.
> Detailed comparison V6.vs. V7 migt help?!

I will re-check it tomorrow.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149856] XLSX: the "highest row with data" marker will go to 1048576 when deleting any row within rows with data

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149856

--- Comment #2 from Eike Rathke  ---
I think the default row height should simply be set when reading such file if
it is available from there (or maybe differs by generator application, but
going down that route is also doomed to fail).

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: libreoffice-7.4.0.0.beta1 build failure on MacOS Monterey 12.4

2022-07-05 Thread Ilmari Lauhakangas

On 5.7.2022 22.42, Tim Daley wrote:
On Tue, Jul 5, 2022 at 11:50 AM Rene Engelhard > wrote:


Hi,

Am 05.07.22 um 16:06 schrieb Christian Lohmaier:
 > Fatal:
 >

/Users/tim.daley/AixNPanes/libreoffice-7.4.0.0.beta1/schema/libreoffice/OpenDocument-v1.3+libreoffice-manifest-schema.rng:

 >
 > file does not exist
 >
 > Guess you're using a tarball to build - the schema files are not
added
 > to the tarballs.
 > https://gerrit.libreoffice.org/28494

 >
 > I don't remember the reason why they were added to the ignore list,
 > maybe Thorsten remembers...

Because they are non-free and I *do* want to use the tarball with the
signature instead of having to repackage it to remove them...


Regards,


Rene


> So I should use the github repo? If so, that fails, too:
>
> gh repo clone LibreOffice/core
> Cloning into 'core'...
> remote: Enumerating objects: 5821827, done.
> remote: Counting objects: 100% (761/761), done.
> remote: Compressing objects: 100% (482/482), done.
> error: object 657924e4d73d6d501c9a3ceaf62e29b8f243cead:
> missingSpaceBeforeEmail: invalid author/committer line - missing space
> before email
> fatal: fsck error in packed object
> fatal: fetch-pack: invalid index-pack output
> signal: broken pipe
>

You can use the recommended workflow:
https://wiki.documentfoundation.org/Development/BuildingOnMac
https://wiki.documentfoundation.org/Development/lode

Ilmari


[Libreoffice-bugs] [Bug 149876] Melhoria - Acessibilidade (leitura fácil ao selecionar texto com mouse)

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149876

Eike Rathke  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149875] Melhoria - Acessibilidade (leitura fácil ao selecionar texto com mouse)

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149875

--- Comment #1 from Eike Rathke  ---
*** Bug 149876 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149876] Melhoria - Acessibilidade (leitura fácil ao selecionar texto com mouse)

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149876

Eike Rathke  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Eike Rathke  ---


*** This bug has been marked as a duplicate of bug 149875 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138371] Convert Serbian spelling dictionary files to UTF-8 Unicode with standard line terminators

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138371

--- Comment #3 from Roman Kuznetsov <79045_79...@mail.ru> ---
(In reply to Pander from comment #2)
> Hi Roman, do you have an update on this? Thanks.

No, I just confirmed the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 91688] VIEWING: Print Preview does not display comments

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=91688

--- Comment #30 from pamela nelson  ---
(In reply to Timur from comment #4)
> I'd say this is similar to Bug 77650 in terms of a need to unify comments
> behavior in printing.
> 
> So, expected result here would be:
> - add Comments pulldown menu in Print Preview instant toolbar, similar to
> the current Comments pulldown menu in File-Print dialog





look one of the best one reply

https://www.google.nl/url?sa=t=https://www.kortingsok.nl;>Kortingscode

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149876] New: Melhoria - Acessibilidade (leitura fácil ao selecionar texto com mouse)

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149876

Bug ID: 149876
   Summary: Melhoria - Acessibilidade (leitura fácil ao selecionar
texto com mouse)
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: protonsconsult...@protonmail.com

Oi LibreOffice, boa tarde
Tudo Bem

Recentemente descobri que Tenho deficiência  Oculta: ◦ Dislexia,  pré  cortex 
frontal  ruim  (atenção  concentrada,  alternada,  dividida)  e caustrofobia. ◦
Sou  considerado  normal,  estou  organizado.


Existe uma galera com dislexia e não sabe, acha que é burro.

Na verdade não conseguem ler.

Dica de Funcionalidade:
- Ao selecionar com o mouse o texto no libre writer, automaticamente vai ler em
voz Alta para você.

Ou, ao selecionar o texto, clicar com botão direito vai aparecer a opcão de
leitura em voz Alta.


Grande desafio de acessibilidade:
- os botões geralmente não estão na regra de até 3 (três) cliques.

Seria ótimo, nas proximas builds os botões aparecerem na tela de primeira.
Desta, forma vai ensinando a cada usuário a funcionalidade de acessibilidade. 

Atenciosamente,

--


Hi LibreOffice, good afternoon
It's all right

I recently discovered that I have Occult Disabilities: ◦ Dyslexia, poor frontal
precortex (focused, alternating, divided attention) and caustrophobia. ◦ I am
considered normal, I am organized.


There is a crowd with dyslexia and they don't know it, they think they're
stupid.

They can't actually read.

Functionality Tip:
- When you select the text with the mouse in the libre writer, it will
automatically read it aloud to you.

Or, when selecting the text, clicking with the right button will bring up the
option to read aloud.


Great accessibility challenge:
- buttons are generally not in the up to 3 (three) clicks rule.

It would be great, in the next builds the buttons appear on the screen at
first. In this way, it teaches each user the accessibility functionality.

Yours sincerely,



-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149875] New: Melhoria - Acessibilidade (leitura fácil ao selecionar texto com mouse)

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149875

Bug ID: 149875
   Summary: Melhoria - Acessibilidade (leitura fácil ao selecionar
texto com mouse)
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: protonsconsult...@protonmail.com

Oi LibreOffice, boa tarde
Tudo Bem

Recentemente descobri que Tenho deficiência  Oculta: ◦ Dislexia,  pré  cortex 
frontal  ruim  (atenção  concentrada,  alternada,  dividida)  e caustrofobia. ◦
Sou  considerado  normal,  estou  organizado.


Existe uma galera com dislexia e não sabe, acha que é burro.

Na verdade não conseguem ler.

Dica de Funcionalidade:
- Ao selecionar com o mouse o texto no libre writer, automaticamente vai ler em
voz Alta para você.

Ou, ao selecionar o texto, clicar com botão direito vai aparecer a opcão de
leitura em voz Alta.


Grande desafio de acessibilidade:
- os botões geralmente não estão na regra de até 3 (três) cliques.

Seria ótimo, nas proximas builds os botões aparecerem na tela de primeira.
Desta, forma vai ensinando a cada usuário a funcionalidade de acessibilidade. 

Atenciosamente,

--


Hi LibreOffice, good afternoon
It's all right

I recently discovered that I have Occult Disabilities: ◦ Dyslexia, poor frontal
precortex (focused, alternating, divided attention) and caustrophobia. ◦ I am
considered normal, I am organized.


There is a crowd with dyslexia and they don't know it, they think they're
stupid.

They can't actually read.

Functionality Tip:
- When you select the text with the mouse in the libre writer, it will
automatically read it aloud to you.

Or, when selecting the text, clicking with the right button will bring up the
option to read aloud.


Great accessibility challenge:
- buttons are generally not in the up to 3 (three) clicks rule.

It would be great, in the next builds the buttons appear on the screen at
first. In this way, it teaches each user the accessibility functionality.

Yours sincerely,



-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: libreoffice-7.4.0.0.beta1 build failure on MacOS Monterey 12.4

2022-07-05 Thread Tim Daley
So I should use the github repo? If so, that fails, too:

gh repo clone LibreOffice/core
Cloning into 'core'...
remote: Enumerating objects: 5821827, done.
remote: Counting objects: 100% (761/761), done.
remote: Compressing objects: 100% (482/482), done.
error: object 657924e4d73d6d501c9a3ceaf62e29b8f243cead:
missingSpaceBeforeEmail: invalid author/committer line - missing space
before email
fatal: fsck error in packed object
fatal: fetch-pack: invalid index-pack output
signal: broken pipe

On Tue, Jul 5, 2022 at 11:50 AM Rene Engelhard  wrote:

> Hi,
>
> Am 05.07.22 um 16:06 schrieb Christian Lohmaier:
> > Fatal:
> >
> /Users/tim.daley/AixNPanes/libreoffice-7.4.0.0.beta1/schema/libreoffice/OpenDocument-v1.3+libreoffice-manifest-schema.rng:
>
> >
> > file does not exist
> >
> > Guess you're using a tarball to build - the schema files are not added
> > to the tarballs.
> > https://gerrit.libreoffice.org/28494
> >
> > I don't remember the reason why they were added to the ignore list,
> > maybe Thorsten remembers...
>
> Because they are non-free and I *do* want to use the tarball with the
> signature instead of having to repackage it to remove them...
>
>
> Regards,
>
>
> Rene
>
>


[Libreoffice-bugs] [Bug 149874] New: LibreOffice Writer 7.3.4.2 corrupts previously saved documents

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149874

Bug ID: 149874
   Summary: LibreOffice Writer 7.3.4.2 corrupts previously saved
documents
   Product: LibreOffice
   Version: 7.3.4.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: j...@lauterbachandassociates.net

Description:
LibreOffice Writer 7.3.4.2 running under Ubuntu 22.04 LTS corrupts previously
saved documents.  For example, saved document with two images perfectly spaced
and anchored to position of PAGE exactly where I wanted them.

Started PC today, Ubuntu made numerous updates.  Opened same document I was
working on yesterday, and your software corrupted it.  For example. DISPLAY
IMAGES was TURNED OFF.  Why?  Next, your software removed all the page anchors
and wrap I had set yesterday!

Every PC I am buying for my consulting business is coming with Win 10 Pro and
Office 365 preinstalled.

Do you not realize that you are killing LibreOffice?

John

Steps to Reproduce:
1. Save document with images anchored to specific locations on each page.
2. Log off LibreOffice and Ubuntu 22.04 and reboot
3. Observe the mess that LibreOffice Writer has made to your document; all the
time you spent carefully positioning images has been wasted.

Actual Results:
Already described above

Expected Results:
see above


Reproducible: Always


User Profile Reset: No



Additional Info:
Why should I waste my time fixing problems that you should have discovered in
7.3.4.2?  Previous versions did not have the problems I described above.

also, why should I have to waste my time resetting my user profile?

Open GL not enabled

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103596] Support OpenType variable font (OTVF) based text layout

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103596

--- Comment #28 from Volga  ---
I think this should not just to support variable fonts. While a variable font
is used, LibreOffice need to provide more options to let users adjust variable
axis as whatever they want, at least in the Character dialog.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149854] Track Changes: replace of the first letter of a word is not consistent; new character at the left or right of deleted one depending on how

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149854

--- Comment #4 from Rainer Bielefeld Retired  
---
And I still don't see a regression.
Detailed comparison V6.vs. V7 migt help?!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sfx2/source

2022-07-05 Thread Xisco Fauli (via logerrit)
 sfx2/source/appl/appserv.cxx |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit 9e25ab14713a31746a9a8a62649b046606ae04b2
Author: Xisco Fauli 
AuthorDate: Tue Jul 5 15:51:21 2022 +0200
Commit: Xisco Fauli 
CommitDate: Tue Jul 5 21:17:18 2022 +0200

sfx2: fix null derefs of SfxViewFrame::Current()

See 
https://crashreport.libreoffice.org/stats/signature/%60anonymous%20namespace'::lcl_tryLoadBibliography

Change-Id: I80d764c4bbcf0c5affa3386fbb11f5a79e98b699
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136766
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sfx2/source/appl/appserv.cxx b/sfx2/source/appl/appserv.cxx
index 66ac22ee133a..ee603ab5e097 100644
--- a/sfx2/source/appl/appserv.cxx
+++ b/sfx2/source/appl/appserv.cxx
@@ -186,8 +186,10 @@ namespace
 SfxStringItem aURL(SID_FILE_NAME, ".component:Bibliography/View1");
 SfxStringItem aRef(SID_REFERER, "private:user");
 SfxStringItem aTarget(SID_TARGETNAME, "_blank");
-SfxViewFrame::Current()->GetDispatcher()->ExecuteList(SID_OPENDOC,
-SfxCallMode::ASYNCHRON, { , ,  });
+const SfxViewFrame* pViewFrame = SfxViewFrame::Current();
+if ( pViewFrame )
+pViewFrame->GetDispatcher()->ExecuteList(SID_OPENDOC,
+SfxCallMode::ASYNCHRON, { , ,  });
 }
 catch (const Exception &)
 {


[Libreoffice-bugs] [Bug 149854] Track Changes: replace of the first letter of a word is not consistent; new character at the left or right of deleted one depending on how

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149854

--- Comment #3 from Rainer Bielefeld Retired  
---
Indeed, there is a relation to "Bug 149873 - Cursor doesn't move the left after
pressing backspace with track changes enabled in certain consternation"

Currently I am seeing that more than a feature than as a bug, but that
mighbeseen different from a different POV.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sw/source

2022-07-05 Thread Xisco Fauli (via logerrit)
 sw/source/core/layout/wsfrm.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 11a5a54567da8e85673aa48740ce7af08cba6016
Author: Xisco Fauli 
AuthorDate: Tue Jul 5 16:47:10 2022 +0200
Commit: Xisco Fauli 
CommitDate: Tue Jul 5 21:13:41 2022 +0200

sw: fix null derefs of GetCurrShell()

See 
https://crashreport.libreoffice.org/stats/signature/SwContentFrame::Cut()

Change-Id: I00267b480d9c123f68996572d2e6fdebc4fb383f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136768
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sw/source/core/layout/wsfrm.cxx b/sw/source/core/layout/wsfrm.cxx
index e171ab8108be..1eadc9db6a6f 100644
--- a/sw/source/core/layout/wsfrm.cxx
+++ b/sw/source/core/layout/wsfrm.cxx
@@ -1222,13 +1222,14 @@ void SwContentFrame::Cut()
 // find if there are pages without content following pPage
 // and if so request a call to CheckPageDescs()
 SwPageFrame const* pNext(pPage);
-if (pRoot->GetCurrShell()->Imp()->IsAction())
+SwViewShell *pSh = pRoot->GetCurrShell();
+if (pSh && pSh->Imp()->IsAction())
 {
 while ((pNext = static_cast(pNext->GetNext(
 {
 if (!sw::IsPageFrameEmpty(*pNext) && 
!pNext->IsFootnotePage())
 {
-
pRoot->GetCurrShell()->Imp()->GetLayAction().SetCheckPageNum(pPage->GetPhyPageNum());
+
pSh->Imp()->GetLayAction().SetCheckPageNum(pPage->GetPhyPageNum());
 break;
 }
 }


[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sc/source

2022-07-05 Thread Eike Rathke (via logerrit)
 sc/source/core/data/column3.cxx |   27 +++
 sc/source/ui/view/tabvwsha.cxx  |   12 ++--
 2 files changed, 29 insertions(+), 10 deletions(-)

New commits:
commit ff1c2cd5ea8049fe0dc4283a8990c67eb19b8219
Author: Eike Rathke 
AuthorDate: Tue Jul 5 18:37:54 2022 +0200
Commit: Eike Rathke 
CommitDate: Tue Jul 5 21:12:52 2022 +0200

Resolves: tdf#149665 Strip first ' also for multiple '' if following is 
numeric

... and prepend accordingly when editing content.

Change-Id: I9b35c4e370323966400e8e7ef3bce95026052f10
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136837
Reviewed-by: Eike Rathke 
Tested-by: Jenkins
(cherry picked from commit ce95b6a2eeca1ac1f2e9385af69e8ca8f644)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136854

diff --git a/sc/source/core/data/column3.cxx b/sc/source/core/data/column3.cxx
index e8000bdc9797..6436bff414b0 100644
--- a/sc/source/core/data/column3.cxx
+++ b/sc/source/core/data/column3.cxx
@@ -2078,14 +2078,25 @@ bool ScColumn::ParseString(
 bool bNumeric = false;
 if (aParam.mbHandleApostrophe)
 {
-// Cell format is not 'Text', and the first char
-// is an apostrophe. Check if the input is considered a number.
-OUString aTest = rString.copy(1);
-double fTest;
-bNumeric = aParam.mpNumFormatter->IsNumberFormat(aTest, nIndex, 
fTest);
-if (bNumeric)
-// This is a number. Strip out the first char.
-rCell.set(rPool.intern(aTest));
+// Cell format is not 'Text', and the first char is an apostrophe.
+// Check if the input is considered a number with all leading
+// apostrophes removed. All because ''1 should produce '1 not ''1,
+// thus '''1 be ''1 and so on.
+// NOTE: this corresponds with sc/source/ui/view/tabvwsha.cxx
+// ScTabViewShell::UpdateInputHandler() prepending an apostrophe if
+// necessary.
+sal_Int32 i = 1;
+while (i < rString.getLength() && rString[i] == '\'')
+++i;
+if (i < rString.getLength())
+{
+OUString aTest = rString.copy(i);
+double fTest;
+bNumeric = aParam.mpNumFormatter->IsNumberFormat(aTest, 
nIndex, fTest);
+if (bNumeric)
+// This is a number. Strip out the first apostrophe.
+rCell.set(rPool.intern(rString.copy(1)));
+}
 }
 if (!bNumeric)
 // This is normal text. Take it as-is.
diff --git a/sc/source/ui/view/tabvwsha.cxx b/sc/source/ui/view/tabvwsha.cxx
index 99877fdaf589..d44bd6b0034b 100644
--- a/sc/source/ui/view/tabvwsha.cxx
+++ b/sc/source/ui/view/tabvwsha.cxx
@@ -722,11 +722,19 @@ void ScTabViewShell::UpdateInputHandler( bool bForce /* = 
sal_False */, bool bSt
 aString = ScCellFormat::GetInputString( rCell, nNumFmt, 
*pFormatter, rDoc );
 if (rCell.meType == CELLTYPE_STRING)
 {
+sal_Int32 i = 0;
+while (i < aString.getLength() && aString[i] == '\'')
+++i;
+OUString aTest((i && i < aString.getLength()) ? 
aString.copy(i) : aString);
 // Put a ' in front if necessary, so that the string is not
 // unintentionally interpreted as a number, and to show the
 // user that it is a string (#35060#).
-//! also for numberformat "Text"? -> then remove when 
editing
-if ( pFormatter->IsNumberFormat(aString, nNumFmt, 
o3tl::temporary(double())) )
+// NOTE: this corresponds with
+// sc/source/core/data/column3.cxx ScColumn::ParseString()
+// removing one apostrophe also for multiple consecutive
+// apostrophes.
+// For number format 'Text' this never results in numeric.
+if (pFormatter->IsNumberFormat(aTest, nNumFmt, 
o3tl::temporary(double(
 aString = "'" + aString;
 }
 }


[Libreoffice-bugs] [Bug 146781] Function wizard - allow search description of functions.

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146781

Andreas Heinisch  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |andreas.heini...@yahoo.de
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142857] Clone Formatting inappropriately applies paragraph style

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142857

--- Comment #13 from Eyal Rozenberg  ---
(In reply to Heiko Tietze from comment #11)
> The tooltip gives a clue about ctrl/cmd and double-click.

The tooltip says "double-click for multi-selection". Perhaps you're thinking
about Writer? But in Writer, the default behavior doesn't propagate Paragraph
Style when you only select some characters within a paragraph.

> an exemplary scenario is to copy the background color where you not want to 
> modify the PS.

IMHO cloning the background color is not a reasonable exemplary scenario for
using the clone formatting tool, because the tool is based on a selection, and
whatever it is you selected - you have not explicitly selected the background.
So background color propagation is not obviously expected and possibly
unexpected. ... unless you mean the character background, in which case that
doesn't contradict my point.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149873] Cursor doesn't move the left after pressing backspace with track changes enabled in certain consternation

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149873

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||9388

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149854] Track Changes: replace of the first letter of a word is not consistent; new character at the left or right of deleted one depending on how

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149854

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||9873

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149873] Cursor doesn't move the left after pressing backspace with track changes enabled in certain consternation

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149873

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||9854

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149873] New: Cursor doesn't move the left after pressing backspace with track changes enabled in certain consternation

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149873

Bug ID: 149873
   Summary: Cursor doesn't move the left after pressing backspace
with track changes enabled in certain consternation
   Product: LibreOffice
   Version: 7.5.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Cursor doesn't move the left after pressing backspace in certain consternation

Steps to Reproduce:
1. Open attachment 180483 
2. Enable track changes
3. Place the cursor after the 's' of six in the first line
4. Press backspace -> Cursor moves from right side of s to the left (expected)
5. CTRL+Z (s will be highlighted)
6. Press backspace again -> Cursor doesn't move


Actual Results:
Cursor doesn't move

Expected Results:
Cursor should move to the left


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 7a89eae97a970939174d59aa58147eaa194acaee
CPU threads: 8; OS: Mac OS X 12.3.1; UI render: Skia/Metal; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149872] New: Sidebar properties switch from what we're manipulating to the page's properties after merging two shapes

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149872

Bug ID: 149872
   Summary: Sidebar properties switch from what we're manipulating
to the page's properties after merging two shapes
   Product: LibreOffice
   Version: 7.5.0.0 alpha0+ Master
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xordevore...@gmail.com

Description:
I noticed the properties sidebar changes what it's pointing at after I merge
two shapes.

Steps to Reproduce:
1. Launch LibreOffice
2. Create a new Draw file
3. Display the properties sidebar (View > Sidebar)
4. Create any two shapes so that they overlap at least a little bit
5. Select both shapes at the same time 
6. Change their color in the properties sidebar (None > Color > [something])
7. Observe that the properties sidebar for color matches those of the shapes
8. Merge the shapes (Shape > Merge)
9. Observe that the properties sidebar now points to the page, not the shape

Actual Results:
Properties sidebar inappropriately retargets the page rather than staying on
the shape we're manipulating.

Expected Results:
The properties sidebar should remain on what we're manipulating


Reproducible: Always


User Profile Reset: No



Additional Info:
Tested using:

Version: 7.3.4.2 (x64) / LibreOffice Community
Build ID: 728fec16bd5f605073805c3c9e7c4212a0120dc5
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

and:

Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 23f76e2fed8d77c888a5595d96520ec958cccda8
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149854] Track Changes: replace of the first letter of a word is not consistent; new character at the left or right of deleted one depending on how

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149854

--- Comment #2 from Telesto  ---
Well I obviously forgot so detail at step 4. This about difference between
overwrite, compared to deleting by backspace & typing something else

1. Open attachment 180483 [details]
2. Select the 's' of six in the first line
3. Type S
4. Place the cursor after w of "ways"  on the first line, next to six
5. Press backspace
6. Type W.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/qt5

2022-07-05 Thread Michael Weghorn (via logerrit)
 vcl/qt5/QtAccessibleWidget.cxx |   11 +--
 1 file changed, 9 insertions(+), 2 deletions(-)

New commits:
commit e4066a41406b1ddd454901b4fa718cf9be2746c4
Author: Michael Weghorn 
AuthorDate: Tue Jul 5 18:30:02 2022 +0200
Commit: Michael Weghorn 
CommitDate: Tue Jul 5 20:30:00 2022 +0200

qt a11y: Implement QtAccessibleWidget::table

Implement that `QAccessibleTableCellInterface::table`
override by returning the parent, if it is a table.

This turned out to be the missing piece when working
on an implementation for the Qt library to expose the
AT-SPI table cell interface for a11y objects that implement
`QAccessibleTableCellInterface`, and testing the
"GetTable" method by calling
`acc.queryTableCell().get_table()` on a selected
LO Calc cell in Accerciser's IPython console.

Change-Id: I6144c613f31cafc338ccac739cd7db1bf314d4a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136836
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/vcl/qt5/QtAccessibleWidget.cxx b/vcl/qt5/QtAccessibleWidget.cxx
index 88616a555efd..44d9f896217b 100644
--- a/vcl/qt5/QtAccessibleWidget.cxx
+++ b/vcl/qt5/QtAccessibleWidget.cxx
@@ -1480,8 +1480,15 @@ int QtAccessibleWidget::rowIndex() const
 
 QAccessibleInterface* QtAccessibleWidget::table() const
 {
-SAL_WARN("vcl.qt", "Unsupported QAccessibleTableCellInterface::table");
-return nullptr;
+Reference xTable = getAccessibleTableForParent();
+if (!xTable.is())
+return nullptr;
+
+Reference xTableAcc(xTable, UNO_QUERY);
+if (!xTableAcc.is())
+return nullptr;
+
+return QAccessible::queryAccessibleInterface(new QtXAccessible(xTableAcc));
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */


[Libreoffice-commits] core.git: sc/source

2022-07-05 Thread Eike Rathke (via logerrit)
 sc/source/core/data/column3.cxx |   27 +++
 sc/source/ui/view/tabvwsha.cxx  |   12 ++--
 2 files changed, 29 insertions(+), 10 deletions(-)

New commits:
commit 484448bc04edfbe22db784d2c68a679a3f98fbb9
Author: Eike Rathke 
AuthorDate: Tue Jul 5 18:37:54 2022 +0200
Commit: Eike Rathke 
CommitDate: Tue Jul 5 20:14:29 2022 +0200

Resolves: tdf#149665 Strip first ' also for multiple '' if following is 
numeric

... and prepend accordingly when editing content.

Change-Id: I9b35c4e370323966400e8e7ef3bce95026052f10
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136837
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/sc/source/core/data/column3.cxx b/sc/source/core/data/column3.cxx
index 019a8b58283a..91d5c4eaef2e 100644
--- a/sc/source/core/data/column3.cxx
+++ b/sc/source/core/data/column3.cxx
@@ -2078,14 +2078,25 @@ bool ScColumn::ParseString(
 bool bNumeric = false;
 if (aParam.mbHandleApostrophe)
 {
-// Cell format is not 'Text', and the first char
-// is an apostrophe. Check if the input is considered a number.
-OUString aTest = rString.copy(1);
-double fTest;
-bNumeric = aParam.mpNumFormatter->IsNumberFormat(aTest, nIndex, 
fTest);
-if (bNumeric)
-// This is a number. Strip out the first char.
-rCell.set(rPool.intern(aTest));
+// Cell format is not 'Text', and the first char is an apostrophe.
+// Check if the input is considered a number with all leading
+// apostrophes removed. All because ''1 should produce '1 not ''1,
+// thus '''1 be ''1 and so on.
+// NOTE: this corresponds with sc/source/ui/view/tabvwsha.cxx
+// ScTabViewShell::UpdateInputHandler() prepending an apostrophe if
+// necessary.
+sal_Int32 i = 1;
+while (i < rString.getLength() && rString[i] == '\'')
+++i;
+if (i < rString.getLength())
+{
+OUString aTest = rString.copy(i);
+double fTest;
+bNumeric = aParam.mpNumFormatter->IsNumberFormat(aTest, 
nIndex, fTest);
+if (bNumeric)
+// This is a number. Strip out the first apostrophe.
+rCell.set(rPool.intern(rString.copy(1)));
+}
 }
 if (!bNumeric)
 // This is normal text. Take it as-is.
diff --git a/sc/source/ui/view/tabvwsha.cxx b/sc/source/ui/view/tabvwsha.cxx
index f559732fff74..67cd905341f0 100644
--- a/sc/source/ui/view/tabvwsha.cxx
+++ b/sc/source/ui/view/tabvwsha.cxx
@@ -722,11 +722,19 @@ void ScTabViewShell::UpdateInputHandler( bool bForce /* = 
sal_False */, bool bSt
 aString = ScCellFormat::GetInputString( rCell, nNumFmt, 
*pFormatter, rDoc );
 if (rCell.getType() == CELLTYPE_STRING)
 {
+sal_Int32 i = 0;
+while (i < aString.getLength() && aString[i] == '\'')
+++i;
+OUString aTest((i && i < aString.getLength()) ? 
aString.copy(i) : aString);
 // Put a ' in front if necessary, so that the string is not
 // unintentionally interpreted as a number, and to show the
 // user that it is a string (#35060#).
-//! also for numberformat "Text"? -> then remove when 
editing
-if ( pFormatter->IsNumberFormat(aString, nNumFmt, 
o3tl::temporary(double())) )
+// NOTE: this corresponds with
+// sc/source/core/data/column3.cxx ScColumn::ParseString()
+// removing one apostrophe also for multiple consecutive
+// apostrophes.
+// For number format 'Text' this never results in numeric.
+if (pFormatter->IsNumberFormat(aTest, nNumFmt, 
o3tl::temporary(double(
 aString = "'" + aString;
 }
 }


[Libreoffice-bugs] [Bug 149777] The contents of the cell appears in the second line of the formula bar

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149777

Rainer Bielefeld Retired  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||9870

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149870] EDITING: Input line Contents vanishes with mouse click into line

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149870

Rainer Bielefeld Retired  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||9777

--- Comment #3 from Rainer Bielefeld Retired  
---
Well, I can't reproduce Bug 149777 with sample there.
But when Problem reappears I will have a look whether contents has not
vanished, but become shifted to "second line" of input line.
We will see.

Thank you for the hint!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: include/vcl sc/source vcl/inc vcl/source vcl/unx

2022-07-05 Thread Henry Castro (via logerrit)
 include/vcl/customweld.hxx|1 +
 include/vcl/weld.hxx  |2 ++
 sc/source/ui/pagedlg/tphfedit.cxx |2 ++
 vcl/inc/salvtables.hxx|2 ++
 vcl/source/app/salvtables.cxx |9 +
 vcl/unx/gtk3/gtkinst.cxx  |2 ++
 6 files changed, 18 insertions(+)

New commits:
commit ed3270a522c487e172f78eab5ee449fd68591bed
Author: Henry Castro 
AuthorDate: Wed Feb 23 14:42:03 2022 -0400
Commit: Henry Castro 
CommitDate: Tue Jul 5 19:54:33 2022 +0200

lok: vcl: introduce set_cursor_data method

The ScEditWindow requires to assign a cursor,
so the child widget can send cursor invalidation
to client side.

Change-Id: I429d484a311f217f2419e38d50f8d9a422640221
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130446
Reviewed-by: Szymon Kłos 
Tested-by: Jenkins CollaboraOffice 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136829
Tested-by: Jenkins
Reviewed-by: Henry Castro 

diff --git a/include/vcl/customweld.hxx b/include/vcl/customweld.hxx
index e37555b36777..196608ee53a9 100644
--- a/include/vcl/customweld.hxx
+++ b/include/vcl/customweld.hxx
@@ -63,6 +63,7 @@ public:
 }
 virtual void Show() { m_pDrawingArea->show(); }
 virtual void Hide() { m_pDrawingArea->hide(); }
+void SetCursor(void* pData) { m_pDrawingArea->set_cursor_data(pData); }
 void GrabFocus() { m_pDrawingArea->grab_focus(); }
 bool HasFocus() const { return m_pDrawingArea->has_focus(); }
 bool HasChildFocus() const { return m_pDrawingArea->has_child_focus(); }
diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index 83e68002ce6c..bfd9ba30b189 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -219,6 +219,8 @@ public:
 virtual void set_tooltip_text(const OUString& rTip) = 0;
 virtual OUString get_tooltip_text() const = 0;
 
+virtual void set_cursor_data(void* pData) = 0;
+
 virtual void connect_focus_in(const Link& rLink)
 {
 assert(!m_aFocusInHdl.IsSet() || !rLink.IsSet());
diff --git a/sc/source/ui/pagedlg/tphfedit.cxx 
b/sc/source/ui/pagedlg/tphfedit.cxx
index c71c67b0842b..bf256e8a0016 100644
--- a/sc/source/ui/pagedlg/tphfedit.cxx
+++ b/sc/source/ui/pagedlg/tphfedit.cxx
@@ -107,6 +107,8 @@ void ScEditWindow::SetDrawingArea(weld::DrawingArea* 
pDrawingArea)
 
 tmpAcc->InitAcc(nullptr, m_xEditView.get(),
   sName, pDrawingArea->get_tooltip_text());
+
+SetCursor(m_xEditView->GetCursor());
 }
 
 ScEditWindow::~ScEditWindow()
diff --git a/vcl/inc/salvtables.hxx b/vcl/inc/salvtables.hxx
index 4fab7dfe2bb9..f0ed09273753 100644
--- a/vcl/inc/salvtables.hxx
+++ b/vcl/inc/salvtables.hxx
@@ -305,6 +305,8 @@ public:
 
 virtual OUString get_tooltip_text() const override;
 
+virtual void set_cursor_data(void* pData) override;
+
 virtual void connect_focus_in(const Link& rLink) override;
 
 virtual void connect_mnemonic_activate(const Link& rLink) 
override;
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index 6cd499a1dcc7..c034b88bc285 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -451,6 +451,15 @@ void SalInstanceWidget::set_tooltip_text(const OUString& 
rTip)
 
 OUString SalInstanceWidget::get_tooltip_text() const { return 
m_xWidget->GetQuickHelpText(); }
 
+void SalInstanceWidget::set_cursor_data(void* pData)
+{
+vcl::Cursor* pCursor = static_cast(pData);
+if (!pCursor)
+return;
+
+m_xWidget->SetCursor(pCursor);
+}
+
 void SalInstanceWidget::connect_focus_in(const Link& rLink)
 {
 ensure_event_listener();
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 9abde0981326..1b4809fb57a2 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -3895,6 +3895,8 @@ public:
 return OUString(pStr, pStr ? strlen(pStr) : 0, RTL_TEXTENCODING_UTF8);
 }
 
+virtual void set_cursor_data(void * /*pData*/) override {};
+
 virtual std::unique_ptr weld_parent() const override;
 
 virtual OString get_buildable_name() const override


[Libreoffice-commits] core.git: svx/source

2022-07-05 Thread Henry Castro (via logerrit)
 svx/source/dialog/weldeditview.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 5e9f1f1bf905987c172299eb82f4a1f0f5682ee8
Author: Henry Castro 
AuthorDate: Wed Jan 19 12:00:21 2022 -0400
Commit: Henry Castro 
CommitDate: Tue Jul 5 19:54:03 2022 +0200

lok: fix regression "WeldEditView::DoPaint" for dialog tunneling

Change-Id: I1cb345b3911d03dc90acef2a17705d654a06deb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128622
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Jan Holesovsky 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136830
Tested-by: Jenkins
Reviewed-by: Henry Castro 

diff --git a/svx/source/dialog/weldeditview.cxx 
b/svx/source/dialog/weldeditview.cxx
index 4d900093b044..7d36ed3c79b9 100644
--- a/svx/source/dialog/weldeditview.cxx
+++ b/svx/source/dialog/weldeditview.cxx
@@ -31,6 +31,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -180,7 +181,9 @@ void WeldEditView::DoPaint(vcl::RenderContext& 
rRenderContext, const tools::Rect
 
 if (EditView* pEditView = GetEditView())
 {
-pEditView->Paint(rRect, );
+pEditView->Paint(comphelper::LibreOfficeKit::isActive() ? 
rRenderContext.PixelToLogic(rRect)
+: rRect,
+ );
 
 if (HasFocus())
 {


[Libreoffice-bugs] [Bug 149708] DOCX Track Changes: Writer does not export change tracking of the paragraph mark of an inserted list item (see Comment 2)

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149708

László Németh  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED
   Assignee|libreoffice-b...@lists.free |nem...@numbertext.org
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 40917] UI: scrolling only by full row height

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=40917

V Stuart Foote  changed:

   What|Removed |Added

 CC||darcey.ll...@gmail.com

--- Comment #21 from V Stuart Foote  ---
*** Bug 149869 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149869] scroll over tall rows not jump

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149869

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from V Stuart Foote  ---


*** This bug has been marked as a duplicate of bug 40917 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149871] Menu for define / view cell ranges on a worksheet

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149871

Ramon Tavarez  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149871] New: Menu for define / view cell ranges on a worksheet

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149871

Bug ID: 149871
   Summary: Menu for define / view cell ranges on a worksheet
   Product: LibreOffice
   Version: 7.3.4.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ramontava...@gmail.com

Description:
Create a new menu to define, view, edit and delete ranges of cells:
Enhancement asked to make easier hide or show range of cells (rows and/or
columns) on worksheets.
With this tool, several ranges of visible cells can be predefined on the same
worksheet to use according to the user's requirement, without having to repeat,
manually, the process of showing or hiding the rows and/or columns that you
need visible.

Actual Results:
doesn't exist

Expected Results:
on FORMAT menu:
Format-> View Range -> Define (to define the range of cells to view on screen)
-> Call (to activate the rage of cells to use for work)
-> Edit (to hide or show ranges of cells on a defined
range)
-> Clear (to delete a defined range of cells)


Reproducible: Always


User Profile Reset: No



Additional Info:
Something similar to the  Print range's tool, But only to predefine a visible
cell ranges to work.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149862] SPAM

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149862

V Stuart Foote  changed:

   What|Removed |Added

Summary|assignment writing service  |SPAM
   |australia   |
 Resolution|--- |INVALID
  Component|Writer Web  |deletionRequest
 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 118344] No suggest flag for African English is used incorrectly

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118344

--- Comment #8 from Marco A.G.Pinto  ---
(In reply to Pander from comment #7)
> Hi Marco, do you have an update on this? Thanks.

Yes, I forgot to fix it myself.

I did some fixes, but forgot these.

I will fix the ! flags this month.

I only release dictionary updates once a month, around day 1 of every month.

Still some weeks before the date right now, a lot of time to fix it.

If I don't post here that it is done, one week before next month, remember me
again.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149851] Mouse pointer over down arrow in AutoFilter should not be a fat cross

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149851

--- Comment #3 from Rafael Lima  ---
(In reply to m.a.riosv from comment #2)
> I can't see it on windows.

To see the "fat cross" mouse pointer you have to use the "Themed pointer". For
that, go to Tools - Options - LibreOffice Calc - View and then check the
"Themed" option under "Pointer".

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138370] Convert Nepal spelling dictionary file to UTF-8 Unicode with standard line terminators

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138370

--- Comment #2 from Pander  ---
Please, see also https://bugs.documentfoundation.org/show_bug.cgi?id=138371 as
it is an identical issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138371] Convert Serbian spelling dictionary files to UTF-8 Unicode with standard line terminators

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138371

--- Comment #2 from Pander  ---
Hi Roman, do you have an update on this? Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 118344] No suggest flag for African English is used incorrectly

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118344

--- Comment #7 from Pander  ---
Hi Marco, do you have an update on this? Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 149859] Exported pdf displays in firefox and acrobat as titled "landscape."

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149859

--- Comment #3 from Timur  ---
I'd close this as WF.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 149859] Exported pdf displays in firefox and acrobat as titled "landscape."

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149859

--- Comment #3 from Timur  ---
I'd close this as WF.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 149859] Exported pdf displays in firefox and acrobat as titled "landscape."

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149859

Timur  changed:

   What|Removed |Added

   Priority|medium  |lowest
   Severity|normal  |trivial

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 149859] Exported pdf displays in firefox and acrobat as titled "landscape."

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149859

Timur  changed:

   What|Removed |Added

   Priority|medium  |lowest
   Severity|normal  |trivial

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149708] DOCX Track Changes: Writer does not export change tracking of the paragraph mark of an inserted list item (see Comment 2)

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149708

László Németh  changed:

   What|Removed |Added

Summary|DOCX Track Changes: Writer  |DOCX Track Changes: Writer
   |does not export change  |does not export change
   |tracking of the paragraph   |tracking of the paragraph
   |mark of an inserted list|mark of an inserted list
   |item|item (see Comment 2)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149851] Mouse pointer over down arrow in AutoFilter should not be a fat cross

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149851

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #2 from m.a.riosv  ---
I can't see it on windows.
Version: 7.3.4.2 (x64) / LibreOffice Community
Build ID: 728fec16bd5f605073805c3c9e7c4212a0120dc5
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149861] visit

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149861

Timur  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED
Product|cppunit |LibreOffice
  Component|General |deletionRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143003] [META] Tracked Changes of ordered and unordered lists

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143003

László Németh  changed:

   What|Removed |Added

 Depends on||149708


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=149708
[Bug 149708] DOCX Track Changes: Writer does not export change tracking of the
paragraph mark of an inserted list item
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143003] [META] Tracked Changes of ordered and unordered lists

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143003
Bug 143003 depends on bug 149708, which changed state.

Bug 149708 Summary: DOCX Track Changes: Writer does not export change tracking 
of the paragraph mark of an inserted list item
https://bugs.documentfoundation.org/show_bug.cgi?id=149708

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149708] DOCX Track Changes: Writer does not export change tracking of the paragraph mark of an inserted list item

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149708

László Németh  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Resolution|DUPLICATE   |---
 Status|RESOLVED|REOPENED
Version|7.5.0.0 alpha0+ Master  |Inherited From OOo
 CC||nem...@numbertext.org
 Blocks||143003
Summary|EDITING Track Changes:  |DOCX Track Changes: Writer
   |Writer does not show the|does not export change
   |change in number of |tracking of the paragraph
   |inserted numbered   |mark of an inserted list
   |paragraphs  |item

--- Comment #2 from László Németh  ---
I.e. a new list item is exported only as an old empty list item with new
tracked text content. It's rejection leaves an empty list item in the list.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=143003
[Bug 143003] [META] Tracked Changes of ordered and unordered lists
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149857] Cell Styles pane is not visible/accessible/grayed-out when a sheet is protected

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149857

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #2 from m.a.riosv  ---
Works for me
Version: 7.3.4.2 (x64) / LibreOffice Community
Build ID: 728fec16bd5f605073805c3c9e7c4212a0120dc5
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149870] EDITING: Input line Contents vanishes with mouse click into line

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149870

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #2 from m.a.riosv  ---
Maybe a dup of https://bugs.documentfoundation.org/show_bug.cgi?id=149777

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142857] Clone Formatting inappropriately applies paragraph style

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142857

--- Comment #12 from Julien Nabet  ---
Here's the code for Writer:
   4957 if( pFormatClipboard )//apply format paintbrush
   4958 {
   4959 //get some parameters
   4960 SwWrtShell& rWrtShell = m_rView.GetWrtShell();
   4961 SfxStyleSheetBasePool* pPool=nullptr;
   4962 bool bNoCharacterFormats = false;
   4963 bool bNoParagraphFormats = true;
   4964 {
   4965 SwDocShell* pDocSh = m_rView.GetDocShell();
   4966 if(pDocSh)
   4967 pPool = pDocSh->GetStyleSheetPool();
   4968 if( (rMEvt.GetModifier()_MOD1) &&
(rMEvt.GetModifier()_SHIFT) )
   4969 {
   4970 bNoCharacterFormats = true;
   4971 bNoParagraphFormats = false;
   4972 }
   4973 else if( rMEvt.GetModifier() & KEY_MOD1 )
   4974 bNoParagraphFormats = false;
   4975 }
   4976 //execute paste
   4977 pFormatClipboard->Paste( rWrtShell, pPool,
bNoCharacterFormats, bNoParagraphFormats );

(see
https://opengrok.libreoffice.org/xref/core/sw/source/uibase/docvw/edtwin.cxx?r=1f820cd3#4957)

So in Writer, it seems by default behavior is not to copy paragraph format.
It copies the paragraph format only when using Ctrl.

According to the code, if we use Ctrl+Shift, it should copy only paragraph
format and not character format but I gave a try and either I missed something
or it doesn't work.

Now I must dig into SwFormatClipboard::Paste (see
https://opengrok.libreoffice.org/xref/core/sw/source/uibase/uiview/formatclipboard.cxx?r=e6de84d4#437)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149388] deleting 'the' tracks the change as 'moved (deletion)'

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149388

László Németh  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||nem...@numbertext.org
   Assignee|libreoffice-b...@lists.free |nem...@numbertext.org
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - chart2/qa chart2/source

2022-07-05 Thread Kurt Nordback (via logerrit)
 chart2/qa/extras/chart2dump/reference/piecharttest/donut_chart.txt |   10 -
 chart2/source/view/charttypes/PieChart.cxx |   60 
+++---
 chart2/source/view/charttypes/PieChart.hxx |4 
 3 files changed, 55 insertions(+), 19 deletions(-)

New commits:
commit 597bc417192fd9eac58c3cca9527ce5646d9972f
Author: Kurt Nordback 
AuthorDate: Fri Jun 3 15:19:28 2022 -0600
Commit: Adolfo Jayme Barrientos 
CommitDate: Tue Jul 5 18:25:24 2022 +0200

tdf#104428 Improve rendering of exploded donut charts

This bug shows an exploded donut chart with more than one series. The
concern is that the standard pie/donut' explosion' rendering, with the shape
of the pieces unchanged but the pieces translated outward, gives
unsatisfactory results in the case of a donut with more than one series,
where the translated 'exploded' pieces can overlap with the inner ring.
This proposed fix renders this case differently, by increasing the radius
of the exploded ring but keeping the pieces concentric with the inner ring.

This commit also modifies the unit test values for donut_chart.ods.

Change-Id: I713b1f3ce4697d46d29914410056f0aa83c6aa8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135394
Tested-by: Jenkins
Reviewed-by: Noel Grandin 
(cherry picked from commit 9b558357a3e7a4c908084134d56770809116b4f1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136765
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/chart2/qa/extras/chart2dump/reference/piecharttest/donut_chart.txt 
b/chart2/qa/extras/chart2dump/reference/piecharttest/donut_chart.txt
index b2dfd33295a2..c1af41103de5 100644
--- a/chart2/qa/extras/chart2dump/reference/piecharttest/donut_chart.txt
+++ b/chart2/qa/extras/chart2dump/reference/piecharttest/donut_chart.txt
@@ -35,15 +35,15 @@
 16728590
 /// /D=0:CS=0:CT=0:Series=0:Point=2
 // aSlicePosition.X
-8909
+9033
 // aSlicePosition.Y
-4532
+4635
 // aSliceSize.Height
-4689
+4659
 // aSliceSize.Width
-2544
+2458
 // aSliceTransformation
-2544;0;8909;0;4689;4532;0;0;1
+2458;0;9033;0;4659;4635;0;0;1
 // static_cast(aSliceFillStyle)
 1
 // static_cast(aSliceFillColor)
diff --git a/chart2/source/view/charttypes/PieChart.cxx 
b/chart2/source/view/charttypes/PieChart.cxx
index 806bc468414c..a81428c24c15 100644
--- a/chart2/source/view/charttypes/PieChart.cxx
+++ b/chart2/source/view/charttypes/PieChart.cxx
@@ -246,17 +246,47 @@ bool PieChart::shouldSnapRectToUsedArea()
 rtl::Reference PieChart::createDataPoint(
 const rtl::Reference& xTarget,
 const uno::Reference& xObjectProperties,
-const ShapeParam& rParam )
+const ShapeParam& rParam,
+const sal_Int32 nPointCount,
+const bool bConcentricExplosion)
 {
 //transform position:
 drawing::Direction3D aOffset;
-if (rParam.mfExplodePercentage != 0.0)
-{
-double fAngle  = rParam.mfUnitCircleStartAngleDegree + 
rParam.mfUnitCircleWidthAngleDegree/2.0;
-double fRadius = 
(rParam.mfUnitCircleOuterRadius-rParam.mfUnitCircleInnerRadius)*rParam.mfExplodePercentage;
-drawing::Position3D aOrigin = 
m_pPosHelper->transformUnitCircleToScene(0, 0, rParam.mfLogicZ);
-drawing::Position3D aNewOrigin = 
m_pPosHelper->transformUnitCircleToScene(fAngle, fRadius, rParam.mfLogicZ);
-aOffset = aNewOrigin - aOrigin;
+double fExplodedInnerRadius = rParam.mfUnitCircleInnerRadius;
+double fExplodedOuterRadius = rParam.mfUnitCircleOuterRadius;
+double fStartAngle = rParam.mfUnitCircleStartAngleDegree;
+double fWidthAngle = rParam.mfUnitCircleWidthAngleDegree;
+
+if (rParam.mfExplodePercentage != 0.0) {
+double fRadius = 
(fExplodedOuterRadius-fExplodedInnerRadius)*rParam.mfExplodePercentage;
+
+if (bConcentricExplosion) {
+
+// For concentric explosion, increase the radius but retain the 
original
+// arc length of all ring segments together. This results in a gap
+// that's evenly divided among all segments, assuming they all have
+// the same explosion percentage
+assert(fExplodedInnerRadius >= 0 && fExplodedOuterRadius > 0);
+double fAngleRatio = (fExplodedInnerRadius + fExplodedOuterRadius) 
/
+(fExplodedInnerRadius + fExplodedOuterRadius + 2 * fRadius);
+
+assert(nPointCount > 0);
+double fAngleGap = 360 * (1.0 - fAngleRatio) / nPointCount;
+fStartAngle += fAngleGap / 2;
+fWidthAngle -= fAngleGap;
+
+fExplodedInnerRadius += fRadius;
+fExplodedOuterRadius += fRadius;
+
+} else {
+// For the non-concentric explosion case, keep the original radius
+// but shift the circle origin
+double fAngle  = fStartAngle + fWidthAngle/2.0;
+
+drawing::Position3D aOrigin = 
m_pPosHelper->transformUnitCircleToScene(0, 0, rParam.mfLogicZ);
+

[Libreoffice-commits] core.git: sw/source

2022-07-05 Thread Andrea Gelmini (via logerrit)
 sw/source/core/text/itrcrsr.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f2af1527c65fbf696c4996a9b4fa68f7f325cf31
Author: Andrea Gelmini 
AuthorDate: Tue Jul 5 13:42:38 2022 +0200
Commit: Julien Nabet 
CommitDate: Tue Jul 5 18:20:30 2022 +0200

Fix typo

Change-Id: I500b02954de8ed0897a9e6b7ba0e77252a171085
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136824
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/sw/source/core/text/itrcrsr.cxx b/sw/source/core/text/itrcrsr.cxx
index b2a0b3bdb458..e20a90a715d4 100644
--- a/sw/source/core/text/itrcrsr.cxx
+++ b/sw/source/core/text/itrcrsr.cxx
@@ -411,7 +411,7 @@ void SwTextCursor::AddExtraBlankWidth()
 {
 pNextPos = pPos->GetNextPortion();
 // Do it only if it is the last portion that able to handle the cursor,
-// else the next portion would misscalculate the cursor position
+// else the next portion would miscalculate the cursor position
 if (pPos->ExtraBlankWidth() && (!pNextPos || 
pNextPos->IsMarginPortion()))
 {
 pPos->Width(pPos->Width() + pPos->ExtraBlankWidth());


[Libreoffice-bugs] [Bug 137145] Use Unicode symbols instead of ASCII in translatable strings

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137145

--- Comment #2 from Commit Notification 
 ---
Adolfo Jayme Barrientos committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/02c5c0288aeb3bd5e6f4bf63b53f39e6a73cba86

Related tdf#137145 tdf#137569 Capitalization + punctuation fixes

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 137145] Use Unicode symbols instead of ASCII in translatable strings

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137145

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: basctl/uiconfig connectivity/inc cui/uiconfig include/sfx2 include/svtools include/svx nlpsolver/help sc/inc

2022-07-05 Thread Adolfo Jayme Barrientos (via logerrit)
 basctl/uiconfig/basicide/ui/basicmacrodialog.ui  |2 
 connectivity/inc/strings.hrc |  102 +--
 cui/uiconfig/ui/optgeneralpage.ui|2 
 cui/uiconfig/ui/opthtmlpage.ui   |2 
 cui/uiconfig/ui/tipofthedaydialog.ui |4 
 include/sfx2/strings.hrc |2 
 include/svtools/strings.hrc  |   22 +-
 include/svx/strings.hrc  |   12 -
 nlpsolver/help/en/com.sun.star.comp.Calc.NLPSolver/Usage.xhp |2 
 sc/inc/globstr.hrc   |   10 -
 10 files changed, 80 insertions(+), 80 deletions(-)

New commits:
commit 02c5c0288aeb3bd5e6f4bf63b53f39e6a73cba86
Author: Adolfo Jayme Barrientos 
AuthorDate: Tue Jul 5 04:57:02 2022 -0500
Commit: Adolfo Jayme Barrientos 
CommitDate: Tue Jul 5 18:18:46 2022 +0200

Related tdf#137145 tdf#137569 Capitalization + punctuation fixes

Change-Id: Icd8a631da83c86333c7e5bcee0069165899d3041
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136822
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/basctl/uiconfig/basicide/ui/basicmacrodialog.ui 
b/basctl/uiconfig/basicide/ui/basicmacrodialog.ui
index cfcc9af9c038..bdece2cca419 100644
--- a/basctl/uiconfig/basicide/ui/basicmacrodialog.ui
+++ b/basctl/uiconfig/basicide/ui/basicmacrodialog.ui
@@ -23,7 +23,7 @@
   
 False
 6
-Basic Macros
+BASIC Macros
 True
 dialog
 
diff --git a/connectivity/inc/strings.hrc b/connectivity/inc/strings.hrc
index bbcab01914bd..6cf594809439 100644
--- a/connectivity/inc/strings.hrc
+++ b/connectivity/inc/strings.hrc
@@ -23,28 +23,28 @@
 
 // = common strings
 #define STR_NO_CONNECTION_GIVEN NC_("STR_NO_CONNECTION_GIVEN", 
"No connection to the database exists.")
-#define STR_WRONG_PARAM_INDEX   NC_("STR_WRONG_PARAM_INDEX", 
"You tried to set a parameter at position '$pos$' but there is/are only 
'$count$' parameter(s) allowed. One reason may be that the property 
\"ParameterNameSubstitution\" is not set to TRUE in the data source.")
+#define STR_WRONG_PARAM_INDEX   NC_("STR_WRONG_PARAM_INDEX", 
"You tried to set a parameter at position “$pos$” but there is/are only 
“$count$” parameter(s) allowed. One reason may be that the property 
“ParameterNameSubstitution” is not set to TRUE in the data source.")
 #define STR_NO_INPUTSTREAM  NC_("STR_NO_INPUTSTREAM", "The 
input stream was not set.")
-#define STR_NO_ELEMENT_NAME NC_("STR_NO_ELEMENT_NAME", 
"There is no element named '$name$'.")
+#define STR_NO_ELEMENT_NAME NC_("STR_NO_ELEMENT_NAME", 
"There is no element named “$name$”.")
 #define STR_INVALID_BOOKMARKNC_("STR_INVALID_BOOKMARK", 
"Invalid bookmark value")
 #define STR_PRIVILEGE_NOT_GRANTED   
NC_("STR_PRIVILEGE_NOT_GRANTED", "Privilege not granted: Only table privileges 
can be granted.")
 #define STR_PRIVILEGE_NOT_REVOKED   
NC_("STR_PRIVILEGE_NOT_REVOKED", "Privilege not revoked: Only table privileges 
can be revoked.")
 #define STR_ERRORMSG_SEQUENCE   NC_("STR_ERRORMSG_SEQUENCE", 
"Function sequence error.")
 #define STR_INVALID_INDEX   NC_("STR_INVALID_INDEX", 
"Invalid descriptor index.")
-#define STR_UNSUPPORTED_FUNCTION
NC_("STR_UNSUPPORTED_FUNCTION", "The driver does not support the function 
'$functionname$'.")
-#define STR_UNSUPPORTED_FEATURE NC_("STR_UNSUPPORTED_FEATURE", 
"The driver does not support the functionality for '$featurename$'. It is not 
implemented.")
+#define STR_UNSUPPORTED_FUNCTION
NC_("STR_UNSUPPORTED_FUNCTION", "The driver does not support the function 
“$functionname$”.")
+#define STR_UNSUPPORTED_FEATURE NC_("STR_UNSUPPORTED_FEATURE", 
"The driver does not support the functionality for “$featurename$”. It is not 
implemented.")
 #define STR_FORMULA_WRONG   NC_("STR_FORMULA_WRONG", "The 
formula for TypeInfoSettings is wrong!")
-#define STR_STRING_LENGTH_EXCEEDED  
NC_("STR_STRING_LENGTH_EXCEEDED", "The string '$string$' exceeds the maximum 
length of $maxlen$ characters when converted to the target character set 
'$charset$'.")
-#define STR_CANNOT_CONVERT_STRING   
NC_("STR_CANNOT_CONVERT_STRING", "The string '$string$' cannot be converted 
using the encoding '$charset$'.")
+#define STR_STRING_LENGTH_EXCEEDED  
NC_("STR_STRING_LENGTH_EXCEEDED", "The string “$string$” exceeds the maximum 
length of $maxlen$ characters when converted to the target character set 
“$charset$”.")
+#define STR_CANNOT_CONVERT_STRING   
NC_("STR_CANNOT_CONVERT_STRING", "The string “$string$” cannot be converted 
using the encoding 

[Libreoffice-bugs] [Bug 149867] Comments in header: unpredictable behaviour

2022-07-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149867

--- Comment #3 from ajlittoz  ---
Added Jorendc on CC list as he was apparently the author of a "fix" for bug
65107

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/source

2022-07-05 Thread Xisco Fauli (via logerrit)
 sw/source/core/layout/wsfrm.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit f5ca3291e4f2c25fbff49301d6f3a7ed0017a708
Author: Xisco Fauli 
AuthorDate: Tue Jul 5 16:47:10 2022 +0200
Commit: Xisco Fauli 
CommitDate: Tue Jul 5 18:04:54 2022 +0200

sw: fix null derefs of GetCurrShell()

See 
https://crashreport.libreoffice.org/stats/signature/SwContentFrame::Cut()

Change-Id: I00267b480d9c123f68996572d2e6fdebc4fb383f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136834
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sw/source/core/layout/wsfrm.cxx b/sw/source/core/layout/wsfrm.cxx
index e171ab8108be..1eadc9db6a6f 100644
--- a/sw/source/core/layout/wsfrm.cxx
+++ b/sw/source/core/layout/wsfrm.cxx
@@ -1222,13 +1222,14 @@ void SwContentFrame::Cut()
 // find if there are pages without content following pPage
 // and if so request a call to CheckPageDescs()
 SwPageFrame const* pNext(pPage);
-if (pRoot->GetCurrShell()->Imp()->IsAction())
+SwViewShell *pSh = pRoot->GetCurrShell();
+if (pSh && pSh->Imp()->IsAction())
 {
 while ((pNext = static_cast(pNext->GetNext(
 {
 if (!sw::IsPageFrameEmpty(*pNext) && 
!pNext->IsFootnotePage())
 {
-
pRoot->GetCurrShell()->Imp()->GetLayAction().SetCheckPageNum(pPage->GetPhyPageNum());
+
pSh->Imp()->GetLayAction().SetCheckPageNum(pPage->GetPhyPageNum());
 break;
 }
 }


[Libreoffice-commits] core.git: sc/source sd/source

2022-07-05 Thread Michael Meeks (via logerrit)
 sc/source/ui/drawfunc/fuins1.cxx |7 +++
 sd/source/ui/view/sdview.cxx |4 
 2 files changed, 7 insertions(+), 4 deletions(-)

New commits:
commit 92f531209675e1855798f513fb7698fceddd022b
Author: Michael Meeks 
AuthorDate: Tue Jul 5 13:54:42 2022 +0100
Commit: Michael Meeks 
CommitDate: Tue Jul 5 18:04:31 2022 +0200

fix build with disable-avmedia.

Change-Id: Ia57db9b2bcec4ff73e1332bb5b2197080343baa4
Signed-off-by: Michael Meeks 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136831
Tested-by: Jenkins

diff --git a/sc/source/ui/drawfunc/fuins1.cxx b/sc/source/ui/drawfunc/fuins1.cxx
index c6f2f69daaa5..1e2791b12e16 100644
--- a/sc/source/ui/drawfunc/fuins1.cxx
+++ b/sc/source/ui/drawfunc/fuins1.cxx
@@ -207,6 +207,8 @@ static void lcl_InsertGraphic( const Graphic& rGraphic,
 pObj->SetGraphicLink( rFileName );
 }
 
+#if HAVE_FEATURE_AVMEDIA
+
 static void lcl_InsertMedia( const OUString& rMediaURL, bool bApi,
   ScTabViewShell* pViewSh, const vcl::Window* pWindow, 
SdrView* pView,
   const Size& rPrefSize, bool const bLink )
@@ -241,12 +243,8 @@ static void lcl_InsertMedia( const OUString& rMediaURL, 
bool bApi,
 {
 uno::Reference const xModel(
 rData.GetDocument().GetDocumentShell()->GetModel());
-#if HAVE_FEATURE_AVMEDIA
 bool const bRet = ::avmedia::EmbedMedia(xModel, rMediaURL, realURL);
 if (!bRet) { return; }
-#else
-return;
-#endif
 }
 
 SdrMediaObj* pObj = new SdrMediaObj(
@@ -256,6 +254,7 @@ static void lcl_InsertMedia( const OUString& rMediaURL, 
bool bApi,
 pObj->setURL( realURL, ""/*TODO?*/ );
 pView->InsertObjectAtView( pObj, *pPV, bApi ? SdrInsertFlags::DONTMARK : 
SdrInsertFlags::NONE );
 }
+#endif
 
 FuInsertGraphic::FuInsertGraphic( ScTabViewShell&   rViewSh,
   vcl::Window*  pWin,
diff --git a/sd/source/ui/view/sdview.cxx b/sd/source/ui/view/sdview.cxx
index 9ab22b73bf5b..429a8c408753 100644
--- a/sd/source/ui/view/sdview.cxx
+++ b/sd/source/ui/view/sdview.cxx
@@ -17,6 +17,8 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
+#include 
+
 #include 
 #include 
 #include 
@@ -143,11 +145,13 @@ View::~View()
 // release content of selection clipboard, if we own the content
 ClearSelectionClipboard();
 
+#if HAVE_FEATURE_AVMEDIA
 if (mxDropMediaSizeListener)
 {
 suppress_fun_call_w_exception(mxDropMediaSizeListener->dispose());
 mxDropMediaSizeListener.clear();
 }
+#endif
 
 maDropErrorIdle.Stop();
 maDropInsertFileIdle.Stop();


Re: libreoffice-7.4.0.0.beta1 build failure on MacOS Monterey 12.4

2022-07-05 Thread Thorsten Behrens
Hi *,

Christian Lohmaier wrote:
> I don't remember the reason why they were added to the ignore list,
> maybe Thorsten remembers...
> 
Yes, they're a problem to have e.g. for Debian.

Cheers,

-- Thorsten

signature.asc
Description: PGP signature


[Libreoffice-commits] core.git: sc/source

2022-07-05 Thread Noel Grandin (via logerrit)
 sc/source/filter/inc/richstring.hxx|   15 ++---
 sc/source/filter/oox/commentsbuffer.cxx|4 +--
 sc/source/filter/oox/commentsfragment.cxx  |2 -
 sc/source/filter/oox/revisionfragment.cxx  |2 -
 sc/source/filter/oox/richstring.cxx|   27 +++--
 sc/source/filter/oox/richstringcontext.cxx |2 -
 sc/source/filter/oox/sharedstringsbuffer.cxx   |5 ++--
 sc/source/filter/oox/sharedstringsfragment.cxx |2 -
 sc/source/filter/oox/sheetdatacontext.cxx  |   16 +++---
 9 files changed, 36 insertions(+), 39 deletions(-)

New commits:
commit 9f72592591f1dfbfda79e1aecb161de97f2a1b73
Author: Noel Grandin 
AuthorDate: Tue Jul 5 14:51:32 2022 +0200
Commit: Noel Grandin 
CommitDate: Tue Jul 5 17:51:17 2022 +0200

compact the RichString class

Which reduces peak memory load from 495M to 455M when loading
a large spreadsheet

Change-Id: Iad78524bedf3db193820be2d507652abde59d67c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136827
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/source/filter/inc/richstring.hxx 
b/sc/source/filter/inc/richstring.hxx
index fe0d0f2f527a..1e3cf921b326 100644
--- a/sc/source/filter/inc/richstring.hxx
+++ b/sc/source/filter/inc/richstring.hxx
@@ -144,10 +144,10 @@ private:
 };
 
 /** Contains text data and positioning information for a phonetic text 
portion. */
-class RichStringPhonetic : public WorkbookHelper
+class RichStringPhonetic
 {
 public:
-explicitRichStringPhonetic( const WorkbookHelper& rHelper );
+RichStringPhonetic();
 
 /** Sets text data for this phonetic portion. */
 voidsetText( const OUString& rText );
@@ -203,10 +203,9 @@ private:
 };
 
 /** Contains string data and a list of formatting runs for a rich formatted 
string. */
-class RichString : public WorkbookHelper
+class RichString
 {
 public:
-explicitRichString( const WorkbookHelper& rHelper );
 
 /** Appends and returns an index of a portion object for a plain string (t 
element). */
 sal_Int32 importText();
@@ -215,13 +214,13 @@ public:
 /** Appends and returns a phonetic text object for a new phonetic run (rPh 
element). */
 RichStringPhoneticRef importPhoneticRun( const AttributeList& rAttribs );
 /** Imports phonetic settings from the rPhoneticPr element. */
-voidimportPhoneticPr( const AttributeList& rAttribs );
+voidimportPhoneticPr( const AttributeList& rAttribs, const 
WorkbookHelper& rHelper );
 
 /** Imports a Unicode rich-string from the passed record stream. */
-voidimportString( SequenceInputStream& rStrm, bool bRich );
+voidimportString( SequenceInputStream& rStrm, bool bRich, 
const WorkbookHelper& rHelper );
 
 /** Final processing after import of all strings. */
-voidfinalizeImport();
+voidfinalizeImport(const WorkbookHelper& rHelper);
 
 /** Tries to extract a plain string from this object. Returns the string,
 if there is only one unformatted portion. */
@@ -252,7 +251,7 @@ private:
 typedef RefVector< RichStringPhonetic > PhoneticVector;
 
 std::vector  maTextPortions; /// String portions with 
font data.
-PhoneticSettingsmaPhonSettings; /// Phonetic settings for this string.
+std::unique_ptr mxPhonSettings; /// Phonetic settings 
for this string.
 PhoneticVector  maPhonPortions; /// Phonetic text portions.
 };
 
diff --git a/sc/source/filter/oox/commentsbuffer.cxx 
b/sc/source/filter/oox/commentsbuffer.cxx
index b4e6c7f48cb1..7dbd5c942e30 100644
--- a/sc/source/filter/oox/commentsbuffer.cxx
+++ b/sc/source/filter/oox/commentsbuffer.cxx
@@ -141,7 +141,7 @@ void Comment::importComment( SequenceInputStream& rStrm )
 
 RichStringRef const & Comment::createText()
 {
-maModel.mxText = std::make_shared( *this );
+maModel.mxText = std::make_shared();
 return maModel.mxText;
 }
 
@@ -196,7 +196,7 @@ void Comment::finalizeImport()
 pDocShell->GetDocFunc().ShowNote( maModel.maRange.aStart, bVisible 
);
 
 // insert text and convert text formatting
-maModel.mxText->finalizeImport();
+maModel.mxText->finalizeImport(*this);
 Reference< XText > xAnnoText( xAnnoShape, UNO_QUERY_THROW );
 Reference< css::document::XActionLockable > xAnnoLock( xAnnoShape, 
UNO_QUERY_THROW );
 xAnnoLock->addActionLock();
diff --git a/sc/source/filter/oox/commentsfragment.cxx 
b/sc/source/filter/oox/commentsfragment.cxx
index 0d6a8b27a870..a5d1da8dacc8 100644
--- a/sc/source/filter/oox/commentsfragment.cxx
+++ b/sc/source/filter/oox/commentsfragment.cxx
@@ -100,7 +100,7 @@ ContextHandlerRef CommentsFragment::onCreateRecordContext( 
sal_Int32 nRecId, Seq
 break;
 case BIFF12_ID_COMMENT:
 if( (nRecId == BIFF12_ID_COMMENTTEXT) && 

[Libreoffice-commits] core.git: sc/source

2022-07-05 Thread Noel Grandin (via logerrit)
 sc/source/filter/inc/richstring.hxx|   29 +++
 sc/source/filter/inc/richstringcontext.hxx |2 -
 sc/source/filter/inc/worksheethelper.hxx   |2 -
 sc/source/filter/oox/richstring.cxx|   55 ++---
 sc/source/filter/oox/richstringcontext.cxx |   12 +++---
 sc/source/filter/oox/worksheethelper.cxx   |2 -
 6 files changed, 50 insertions(+), 52 deletions(-)

New commits:
commit f6378ed693960c852537c101faa85264c73643bf
Author: Noel Grandin 
AuthorDate: Tue Jul 5 14:07:20 2022 +0200
Commit: Noel Grandin 
CommitDate: Tue Jul 5 17:50:09 2022 +0200

compact the RichStringPortion class

Which reduces peak memory load from 548M to 495M when loading
a large spreadsheet

Change-Id: I74adfddd1722bba7a9dfae6dd0135e5f2b78b1a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136826
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/source/filter/inc/richstring.hxx 
b/sc/source/filter/inc/richstring.hxx
index 71b393c1db41..fe0d0f2f527a 100644
--- a/sc/source/filter/inc/richstring.hxx
+++ b/sc/source/filter/inc/richstring.hxx
@@ -35,20 +35,20 @@ namespace oox { class SequenceInputStream; }
 namespace oox::xls {
 
 /** Contains text data and font attributes for a part of a rich formatted 
string. */
-class RichStringPortion : public WorkbookHelper
+class RichStringPortion
 {
 public:
-explicitRichStringPortion( const WorkbookHelper& rHelper );
+RichStringPortion();
 
 /** Sets text data for this portion. */
 voidsetText( const OUString& rText );
 /** Creates and returns a new font formatting object. */
-FontRef const & createFont();
+FontRef const & createFont(const WorkbookHelper& rHelper);
 /** Links this portion to a font object from the global font list. */
 voidsetFontId( sal_Int32 nFontId );
 
 /** Final processing after import of all strings. */
-voidfinalizeImport();
+voidfinalizeImport(const WorkbookHelper& rHelper);
 
 /** Returns the text data of this portion. */
 const OUString& getText() const { return maText; }
@@ -71,8 +71,6 @@ private:
 boolmbConverted;/// Without repeatedly convert
 };
 
-typedef std::shared_ptr< RichStringPortion > RichStringPortionRef;
-
 /** Represents a position in a rich-string containing current font identifier.
 
 This object stores the position of a formatted character in a rich-string
@@ -210,10 +208,10 @@ class RichString : public WorkbookHelper
 public:
 explicitRichString( const WorkbookHelper& rHelper );
 
-/** Appends and returns a portion object for a plain string (t element). */
-RichStringPortionRef importText();
-/** Appends and returns a portion object for a new formatting run (r 
element). */
-RichStringPortionRef importRun();
+/** Appends and returns an index of a portion object for a plain string (t 
element). */
+sal_Int32 importText();
+/** Appends and returns an index of a portion object for a new formatting 
run (r element). */
+sal_Int32 importRun();
 /** Appends and returns a phonetic text object for a new phonetic run (rPh 
element). */
 RichStringPhoneticRef importPhoneticRun( const AttributeList& rAttribs );
 /** Imports phonetic settings from the rPhoneticPr element. */
@@ -234,12 +232,14 @@ public:
 /** Converts the string and writes it into the passed XText, replace old 
contents of the text object,.
 @param rxText  The XText interface of the target object.
  */
-voidconvert( const css::uno::Reference< css::text::XText 
>& rxText ) const;
-std::unique_ptr convert( ScEditEngineDefaulter& rEE, const 
oox::xls::Font* pFont ) const;
+voidconvert( const css::uno::Reference< css::text::XText 
>& rxText );
+std::unique_ptr convert( ScEditEngineDefaulter& rEE, const 
oox::xls::Font* pFont );
+
+RichStringPortion& getPortion(sal_Int32 nPortionIdx) { return 
maTextPortions[nPortionIdx]; }
 
 private:
 /** Creates, appends, and returns a new empty string portion. */
-RichStringPortionRef createPortion();
+sal_Int32 createPortion();
 /** Creates, appends, and returns a new empty phonetic text portion. */
 RichStringPhoneticRef createPhonetic();
 
@@ -249,10 +249,9 @@ private:
 voidcreatePhoneticPortions( const OUString& rText, 
PhoneticPortionModelList& rPortions, sal_Int32 nBaseLen );
 
 private:
-typedef RefVector< RichStringPortion >  PortionVector;
 typedef RefVector< RichStringPhonetic > PhoneticVector;
 
-PortionVector   maTextPortions; /// String portions with font data.
+std::vector  maTextPortions; /// String portions with 
font data.
 PhoneticSettingsmaPhonSettings; /// Phonetic settings for this string.
 PhoneticVector  maPhonPortions; /// Phonetic text portions.
 };
diff 

[Libreoffice-commits] core.git: sc/source

2022-07-05 Thread Noel Grandin (via logerrit)
 sc/source/filter/inc/pivotcachebuffer.hxx |2 +-
 sc/source/filter/inc/sheetdatabuffer.hxx  |   20 
 sc/source/filter/inc/worksheethelper.hxx  |3 ---
 sc/source/filter/oox/pivotcachebuffer.cxx |7 +++
 sc/source/filter/oox/sheetdatabuffer.cxx  |   23 ---
 sc/source/filter/oox/sheetdatacontext.cxx |7 +--
 sc/source/filter/oox/worksheethelper.cxx  |8 
 7 files changed, 5 insertions(+), 65 deletions(-)

New commits:
commit 3c90f2bd1ad87e86f0562920b49ea55c2cb317c9
Author: Noel Grandin 
AuthorDate: Tue Jul 5 12:08:07 2022 +0200
Commit: Noel Grandin 
CommitDate: Tue Jul 5 17:49:26 2022 +0200

remove span data storage from oox import

We are not using it,
and removing it reduces peak memory load from 648M to 548M when loading
a large spreadsheet

Change-Id: I683bfba6c8f151d8845bbd7d5f92cde2a9c17807
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136825
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/source/filter/inc/pivotcachebuffer.hxx 
b/sc/source/filter/inc/pivotcachebuffer.hxx
index 5997d8db3d2c..e255c79eae15 100644
--- a/sc/source/filter/inc/pivotcachebuffer.hxx
+++ b/sc/source/filter/inc/pivotcachebuffer.hxx
@@ -409,7 +409,7 @@ private:
 /** Creates a dummy sheet that will be filled with the pivot cache data. */
 voidprepareSourceDataSheet();
 /** Checks, if the row index has changed since last call, and initializes 
the sheet data buffer. */
-voidupdateSourceDataRow( const WorksheetHelper& 
rSheetHelper, sal_Int32 nRow ) const;
+voidupdateSourceDataRow( sal_Int32 nRow ) const;
 
 private:
 typedef RefVector< PivotCacheField >PivotCacheFieldVector;
diff --git a/sc/source/filter/inc/sheetdatabuffer.hxx 
b/sc/source/filter/inc/sheetdatabuffer.hxx
index a6bec5a55807..538631330082 100644
--- a/sc/source/filter/inc/sheetdatabuffer.hxx
+++ b/sc/source/filter/inc/sheetdatabuffer.hxx
@@ -72,22 +72,6 @@ struct DataTableModel
 explicitDataTableModel();
 };
 
-/** Manages all cell blocks currently in use. */
-class CellBlockBuffer : public WorksheetHelper
-{
-public:
-explicitCellBlockBuffer( const WorksheetHelper& rHelper );
-
-/** Sets column span information for a row. */
-voidsetColSpans( sal_Int32 nRow, const ValueRangeSet& 
rColSpans );
-
-private:
-typedef ::std::map< sal_Int32, ValueRangeVector >   ColSpanVectorMap;
-
-ColSpanVectorMapmaColSpans; /// Buffered column spans, 
mapped by row index.
-sal_Int32   mnCurrRow;  /// Current row index used for 
buffered cell import.
-};
-
 /** Manages the cell contents and cell formatting of a sheet.
  */
 class SheetDataBuffer : public WorksheetHelper
@@ -95,9 +79,6 @@ class SheetDataBuffer : public WorksheetHelper
 public:
 explicitSheetDataBuffer( const WorksheetHelper& rHelper );
 
-/** Sets column span information for a row. */
-voidsetColSpans( sal_Int32 nRow, const ValueRangeSet& 
rColSpans );
-
 /** Inserts a blank cell (with formatting) into the sheet. */
 voidsetBlankCell( const CellModel& rModel );
 /** Inserts a value cell into the sheet. */
@@ -223,7 +204,6 @@ private:
 typedef ::std::vector< MergedRange > MergedRangeVector;
 
 ColStyles   maStylesPerColumn;  /// Stores cell styles by 
column ( in row ranges )
-CellBlockBuffer maCellBlocks;   /// Manages all open cell 
blocks.
 ArrayFormulaVector  maArrayFormulas;/// All array formulas in the 
sheet.
 std::vector< TableOperation >
 maTableOperations;  /// All table operations in 
the sheet.
diff --git a/sc/source/filter/inc/worksheethelper.hxx 
b/sc/source/filter/inc/worksheethelper.hxx
index 7beacf7c2105..3aeb576f93de 100644
--- a/sc/source/filter/inc/worksheethelper.hxx
+++ b/sc/source/filter/inc/worksheethelper.hxx
@@ -85,7 +85,6 @@ struct ColumnModel
 struct RowModel
 {
 sal_Int32   mnRow;  /// 1-based (!) index of the 
described row.
-ValueRangeSet   maColSpans; /// 0-based (!) column ranges of 
used cells.
 double  mfHeight;   /// Row height in points.
 sal_Int32   mnXfId; /// Row default formatting (see 
mbIsFormatted).
 sal_Int32   mnLevel;/// Row outline level.
@@ -99,8 +98,6 @@ struct RowModel
 
 explicitRowModel();
 
-/** Inserts the passed column span into the row model. */
-voidinsertColSpan( const ValueRange& rColSpan );
 /** Returns true, if this entry can be merged with the passed row range 
(row settings are equal). */
 boolisMergeable( const RowModel& rModel ) const;
 };
diff --git a/sc/source/filter/oox/pivotcachebuffer.cxx 

Re: libreoffice-7.4.0.0.beta1 build failure on MacOS Monterey 12.4

2022-07-05 Thread Rene Engelhard

Hi,

Am 05.07.22 um 16:06 schrieb Christian Lohmaier:
Fatal: 
/Users/tim.daley/AixNPanes/libreoffice-7.4.0.0.beta1/schema/libreoffice/OpenDocument-v1.3+libreoffice-manifest-schema.rng: 


file does not exist

Guess you're using a tarball to build - the schema files are not added
to the tarballs.
https://gerrit.libreoffice.org/28494

I don't remember the reason why they were added to the ignore list,
maybe Thorsten remembers...


Because they are non-free and I *do* want to use the tarball with the 
signature instead of having to repackage it to remove them...



Regards,


Rene



[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - include/vcl sc/source vcl/inc vcl/source vcl/unx

2022-07-05 Thread Henry Castro (via logerrit)
 include/vcl/customweld.hxx|1 +
 include/vcl/weld.hxx  |2 ++
 sc/source/ui/pagedlg/tphfedit.cxx |2 ++
 vcl/inc/salvtables.hxx|2 ++
 vcl/source/app/salvtables.cxx |9 +
 vcl/unx/gtk3/gtk3gtkinst.cxx  |2 ++
 6 files changed, 18 insertions(+)

New commits:
commit 49b8b4c2caefa9428d86ee0c6bb78a151e10d292
Author: Henry Castro 
AuthorDate: Wed Feb 23 14:42:03 2022 -0400
Commit: Henry Castro 
CommitDate: Tue Jul 5 17:46:16 2022 +0200

lok: vcl: introduce set_cursor_data method

The ScEditWindow requires to assign a cursor,
so the child widget can send cursor invalidation
to client side.

Change-Id: I429d484a311f217f2419e38d50f8d9a422640221
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130446
Reviewed-by: Szymon Kłos 
Tested-by: Jenkins CollaboraOffice 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136832
Reviewed-by: Henry Castro 

diff --git a/include/vcl/customweld.hxx b/include/vcl/customweld.hxx
index 64f980732dfb..e5166bae0fd9 100644
--- a/include/vcl/customweld.hxx
+++ b/include/vcl/customweld.hxx
@@ -63,6 +63,7 @@ public:
 }
 virtual void Show() { m_pDrawingArea->show(); }
 virtual void Hide() { m_pDrawingArea->hide(); }
+void SetCursor(void * pData) { m_pDrawingArea->set_cursor_data(pData); }
 void GrabFocus() { m_pDrawingArea->grab_focus(); }
 bool HasFocus() const { return m_pDrawingArea->has_focus(); }
 bool IsVisible() const { return m_pDrawingArea->get_visible(); }
diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index 70d91ee6ca96..c2922048e0a8 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -206,6 +206,8 @@ public:
 virtual void set_tooltip_text(const OUString& rTip) = 0;
 virtual OUString get_tooltip_text() const = 0;
 
+virtual void set_cursor_data(void * pData) = 0;
+
 virtual void connect_focus_in(const Link& rLink)
 {
 assert(!m_aFocusInHdl.IsSet() || !rLink.IsSet());
diff --git a/sc/source/ui/pagedlg/tphfedit.cxx 
b/sc/source/ui/pagedlg/tphfedit.cxx
index acf8333d246d..964b022eb943 100644
--- a/sc/source/ui/pagedlg/tphfedit.cxx
+++ b/sc/source/ui/pagedlg/tphfedit.cxx
@@ -111,6 +111,8 @@ void ScEditWindow::SetDrawingArea(weld::DrawingArea* 
pDrawingArea)
 
 pAcc->InitAcc(nullptr, m_xEditView.get(), nullptr, nullptr,
   sName, pDrawingArea->get_tooltip_text());
+
+SetCursor(m_xEditView->GetCursor());
 }
 
 ScEditWindow::~ScEditWindow()
diff --git a/vcl/inc/salvtables.hxx b/vcl/inc/salvtables.hxx
index aeb1e7bc4e0f..cb57115a73b9 100644
--- a/vcl/inc/salvtables.hxx
+++ b/vcl/inc/salvtables.hxx
@@ -300,6 +300,8 @@ public:
 
 virtual OUString get_tooltip_text() const override;
 
+virtual void set_cursor_data(void * pData) override;
+
 virtual void connect_focus_in(const Link& rLink) override;
 
 virtual void connect_mnemonic_activate(const Link& rLink) 
override;
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index 97330df96b58..f3797237e1fa 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -391,6 +391,15 @@ void SalInstanceWidget::set_tooltip_text(const OUString& 
rTip)
 
 OUString SalInstanceWidget::get_tooltip_text() const { return 
m_xWidget->GetQuickHelpText(); }
 
+void SalInstanceWidget::set_cursor_data(void * pData)
+{
+vcl::Cursor * pCursor = static_cast(pData);
+if (!pCursor)
+return;
+
+m_xWidget->SetCursor(pCursor);
+}
+
 void SalInstanceWidget::connect_focus_in(const Link& rLink)
 {
 ensure_event_listener();
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 9fd92aa39b9c..292cd3bb764b 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -2874,6 +2874,8 @@ public:
 return OUString(pStr, pStr ? strlen(pStr) : 0, RTL_TEXTENCODING_UTF8);
 }
 
+virtual void set_cursor_data(void * /*pData*/) override {};
+
 virtual std::unique_ptr weld_parent() const override;
 
 virtual OString get_buildable_name() const override


  1   2   3   >