[Libreoffice-bugs] [Bug 117001] cell not readed correctly - Tab as Separator
https://bugs.documentfoundation.org/show_bug.cgi?id=117001 Rainer Bielefeld Retired changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||0454 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150454] [EDITING] Tab character does not show when inserted as CHAR(9)
https://bugs.documentfoundation.org/show_bug.cgi?id=150454 Rainer Bielefeld Retired changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||7001 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139730] Char(09) to create a tabulator does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=139730 Rainer Bielefeld Retired changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||0454 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 82411] Numeric fields are limited to Integer-Values in Tablecontrols and Databrowser of a Form
https://bugs.documentfoundation.org/show_bug.cgi?id=82411 --- Comment #19 from Robert Großkopf --- Bug is still the same in LO 7.4.0.2 on OpenSUSE 15.3 64bit rpm Linux. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/node.hxx |7 +++
sw/source/core/doc/DocumentContentOperationsManager.cxx |2 +-
sw/source/core/doc/dbgoutsw.cxx |2 +-
sw/source/core/docnode/ndsect.cxx |2 +-
sw/source/core/docnode/nodes.cxx|2 +-
sw/source/core/text/itratr.cxx | 12 ++--
sw/source/core/text/txtfrm.cxx |6 +++---
sw/source/core/txtnode/ndtxt.cxx| 10 +-
sw/source/core/undo/undel.cxx |2 +-
sw/source/core/unocore/unotbl.cxx |2 +-
sw/source/filter/ww8/ww8par2.cxx|2 +-
sw/source/uibase/wrtsh/wrtsh1.cxx |2 +-
12 files changed, 29 insertions(+), 22 deletions(-)
New commits:
commit 133b9db4d68ba48eeb3682f4decba5689f6c0c1b
Author: Noel Grandin
AuthorDate: Mon Aug 15 18:46:53 2022 +0200
Commit: Noel Grandin
CommitDate: Wed Aug 17 07:44:03 2022 +0200
add comparison operators for SwNode
which will make it easier when I do more conversion of code doing
stuff like
rPos.nNode ==
to
rPos.GetNode() ==
Add an assert to make sure we are talking about nodes from the
same parent node array.
Change-Id: I12011768d67e7fbe5a87663c661a5cc444f1deb4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138320
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/inc/node.hxx b/sw/inc/node.hxx
index 91b18e30ed66..62f6da8ef308 100644
--- a/sw/inc/node.hxx
+++ b/sw/inc/node.hxx
@@ -308,6 +308,13 @@ public:
*/
virtual void dumpAsXml(xmlTextWriterPtr pWriter) const;
+bool operator==(const SwNode& rOther) const { assert(() ==
()); return this == }
+bool operator!=(const SwNode& rOther) const { assert(() ==
()); return this != }
+bool operator<(const SwNode& rOther) const { assert(() ==
()); return GetIndex() < rOther.GetIndex(); }
+bool operator<=(const SwNode& rOther) const { assert(() ==
()); return GetIndex() <= rOther.GetIndex(); }
+bool operator>(const SwNode& rOther) const { assert(() ==
()); return GetIndex() > rOther.GetIndex(); }
+bool operator>=(const SwNode& rOther) const { assert(() ==
()); return GetIndex() >= rOther.GetIndex(); }
+
private:
SwNode( const SwNode & rNodes ) = delete;
SwNode & operator= ( const SwNode & rNodes ) = delete;
diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index fb33ec5103f4..9e6d8ab0ad46 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -3922,7 +3922,7 @@ void DocumentContentOperationsManager::CopyFlyInFlyImpl(
const SwNode& aEndOfContentNd =
aIdx.GetNode().GetNodes().GetEndOfContent();
while ( nAnchorTextNdNumInRange > 0 &&
-&(aIdx.GetNode()) != )
+aIdx.GetNode() != aEndOfContentNd )
{
if ( aIdx.GetNode().IsTextNode() )
{
diff --git a/sw/source/core/doc/dbgoutsw.cxx b/sw/source/core/doc/dbgoutsw.cxx
index 9139da0996e1..5a3d7c86518b 100644
--- a/sw/source/core/doc/dbgoutsw.cxx
+++ b/sw/source/core/doc/dbgoutsw.cxx
@@ -423,7 +423,7 @@ static OUString lcl_AnchoredFrames(const SwNode & rNode)
const SwFormatAnchor & rAnchor = (*i)->GetAnchor();
const SwPosition * pPos = rAnchor.GetContentAnchor();
-if (pPos && >GetNode() == )
+if (pPos && pPos->GetNode() == rNode)
{
if (! bFirst)
aResult.append(", ");
diff --git a/sw/source/core/docnode/ndsect.cxx
b/sw/source/core/docnode/ndsect.cxx
index 555e550a14a8..47eef09cef10 100644
--- a/sw/source/core/docnode/ndsect.cxx
+++ b/sw/source/core/docnode/ndsect.cxx
@@ -848,7 +848,7 @@ SwSectionNode* SwNodes::InsertTextSection(SwNode& rNd,
if( pEnd )
{
// Special case for the Reader/Writer
-if( >GetNode() != () )
+if( pEnd->GetNode() != GetEndOfContent() )
aInsPos = pEnd->GetIndex()+1;
// #i58710: We created a RTF document with a section break inside a
table cell
// We are not able to handle a section start inside a table and the
section end outside.
diff --git a/sw/source/core/docnode/nodes.cxx b/sw/source/core/docnode/nodes.cxx
index 739ef2932241..98e1ac29de2a 100644
--- a/sw/source/core/docnode/nodes.cxx
+++ b/sw/source/core/docnode/nodes.cxx
@@ -1676,7 +1676,7 @@ void SwNodes::MoveRange( SwPaM & rPam, SwPosition & rPos,
SwNodes& rNodes )
// if the StartNode was moved to whom the cursor pointed, so
// the content must be registered in the current content!
-if ( >GetNode() == () )
+if ( pStt->GetNode() ==
[Libreoffice-commits] core.git: cui/uiconfig
cui/uiconfig/ui/paragalignpage.ui |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 16f01f82a765fc51a19be2e370a69eb7819c9ce4 Author: Heiko Tietze AuthorDate: Tue Aug 16 18:02:32 2022 +0200 Commit: Heiko Tietze CommitDate: Wed Aug 17 07:41:07 2022 +0200 Resolves tdf#65473 - Unintuitive paragraph alignment options Switched Center and Right Change-Id: I7b24bb23d113dfa76b878b1533f3e7df1a2ba3dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138376 Tested-by: Jenkins Reviewed-by: Heiko Tietze diff --git a/cui/uiconfig/ui/paragalignpage.ui b/cui/uiconfig/ui/paragalignpage.ui index cbba348eb815..07bda24e5a04 100644 --- a/cui/uiconfig/ui/paragalignpage.ui +++ b/cui/uiconfig/ui/paragalignpage.ui @@ -98,7 +98,7 @@ 0 -1 +2 @@ -113,7 +113,7 @@ 0 -2 +1
[Libreoffice-commits] core.git: cui/uiconfig
cui/uiconfig/ui/paragalignpage.ui | 208 +++--- 1 file changed, 104 insertions(+), 104 deletions(-) New commits: commit 905e2793082f4366d8129430d06098a5ff36c4b9 Author: Heiko Tietze AuthorDate: Tue Aug 16 18:00:27 2022 +0200 Commit: Heiko Tietze CommitDate: Wed Aug 17 07:40:19 2022 +0200 Raise Glade version No actual changes Change-Id: I79d3831c3aa1399df95fa5c33f7c624468525a69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138375 Tested-by: Jenkins Reviewed-by: Heiko Tietze diff --git a/cui/uiconfig/ui/paragalignpage.ui b/cui/uiconfig/ui/paragalignpage.ui index 70fab84cc46b..cbba348eb815 100644 --- a/cui/uiconfig/ui/paragalignpage.ui +++ b/cui/uiconfig/ui/paragalignpage.ui @@ -1,35 +1,35 @@ - + - + True -False +False start True -6 -12 -24 +6 +12 +24 True -False +False end start -True -never -never -in 24 +True +never +never +in True -False +False True -False +False center start @@ -43,134 +43,134 @@ -1 -0 +1 +0 - + True -False +False start start True True -12 +12 True -False -0 -none +False +0 +none - + True -False -3 +False 12 6 +3 _Left True -True -False -True +True +False +True True -True +True -0 -0 +0 +0 _Right True -True -False -True -True +True +False +True +True radioBTN_LEFTALIGN -0 -1 +0 +1 _Center True -True -False -True -True +True +False +True +True radioBTN_LEFTALIGN -0 -2 +0 +2 _Justified True -True -False -True -True +True +False +True +True radioBTN_LEFTALIGN -0 -3 +0 +3 _Expand single word True -True -False +True +False 22 -True -True +True +True -0 -5 +0 +5 _Snap to text grid (if active) True -True -False +True +False 22 -True -True +True +True -0 -6 +0 +
[Libreoffice-bugs] [Bug 150451] Some text boxes in dialogs do not have borders in dark mode (Dark mode + kf5)
https://bugs.documentfoundation.org/show_bug.cgi?id=150451 --- Comment #3 from Michael Weghorn --- (In reply to Michael Weghorn from comment #1) > Can't reproduce on Debian testing (with plasma-desktop 4:5.25.4-1, breeze > 4:5.25.4-1). Version I used: Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: f7e0493987f4d2d821d2724e9fef018676af5ddf CPU threads: 12; OS: Linux 5.18; UI render: default; VCL: kf5 (cairo+xcb) Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150451] Some text boxes in dialogs do not have borders in dark mode (Dark mode + kf5)
https://bugs.documentfoundation.org/show_bug.cgi?id=150451 Michael Weghorn changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||8010 Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #2 from Michael Weghorn --- This sounds similar to tdf#138010, but obviously the LO versions you're using already include the commits for that one. Does it still happen with a fresh user profile? Other than than, I currently have no idea to explain the difference other than that it might be related to the Plasma/KF5/Breeze versions used. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150454] [EDITING] Tab character does not show when inserted as CHAR(9)
https://bugs.documentfoundation.org/show_bug.cgi?id=150454
--- Comment #2 from Rainer Bielefeld Retired
---
Additional Info:
---
a) Because I was not sure concerning correct syntax I die a different approach
for Reproducing problem with a formula '=CONCATENATE(A11;A12;A13)
A11 and a 13 are Numbers
a1) If A12 is "char(10)" (= Line Feed), I see a linefeed between numbers from
A11 and A13.
a2) If A12 is "char(9)" (= Tab), I see NO distance between numbers from A11 and
A13.
To narrow Down roots of the problem
11) copy → paste as plain text contents of B11 from sample document to an
empty writer document.
Expected: Numbers 8 and 9 shown in 2 lines
Actual: as expected
12) copy → paste as plain text contents of B2 from sample document to an
empty writer document.
Expected: Numbers 8 and 9 showshown with some distance between ("7 8")
Actual: as expected
21) copy → paste as plain text contents of B11 from sample document to B20
Expected: "7"in B20, "8" in B21
Actual: as expected
22) copy → paste as plain text contents of B2 from sample document to B30
Expected: "7"in B30, "8" in C30
Actual: as expected
b) All this shows that TAB in Cell B2 does exist, but it's not shown.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-commits] core.git: include/sfx2 sfx2/source starmath/inc starmath/source
include/sfx2/sfxbasecontroller.hxx |4
include/sfx2/viewsh.hxx|1 +
sfx2/source/view/sfxbasecontroller.cxx | 12
sfx2/source/view/viewsh.cxx|5 +
starmath/inc/view.hxx |1 +
starmath/source/view.cxx | 21 +
6 files changed, 44 insertions(+)
New commits:
commit bb6c70f7a9af806347a1e1401a9cce2ad41bc81b
Author: Mike Kaganski
AuthorDate: Mon Aug 15 14:31:15 2022 +0300
Commit: Mike Kaganski
CommitDate: Wed Aug 17 07:19:01 2022 +0200
lok: register view callback also for nested sm view
This allows to send context change events that originate in the
embedded views.
Change-Id: I574ca347a2ffa67f9645a2ee790e42088ad8721f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138303
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/include/sfx2/sfxbasecontroller.hxx
b/include/sfx2/sfxbasecontroller.hxx
index ac4950e5a45a..978cd5669d45 100644
--- a/include/sfx2/sfxbasecontroller.hxx
+++ b/include/sfx2/sfxbasecontroller.hxx
@@ -196,6 +196,10 @@ public:
SAL_DLLPRIVATE bool HasMouseClickListeners_Impl() const;
SAL_DLLPRIVATE void SetCreationArguments_Impl( const css::uno::Sequence<
css::beans::PropertyValue >& i_rCreationArgs );
SAL_DLLPRIVATE css::uno::Reference< css::frame::XTitle >
impl_getTitleHelper ();
+
+protected:
+void CopyLokViewCallbackFromFrameCreator();
+
private:
enum ConnectSfxFrame
{
diff --git a/include/sfx2/viewsh.hxx b/include/sfx2/viewsh.hxx
index 3faf7aeb2071..ea431a687b49 100644
--- a/include/sfx2/viewsh.hxx
+++ b/include/sfx2/viewsh.hxx
@@ -342,6 +342,7 @@ public:
/// Set up a more efficient internal callback instead of
LibreOfficeKitCallback.
void setLibreOfficeKitViewCallback(SfxLokCallbackInterface* pCallback);
+SfxLokCallbackInterface* getLibreOfficeKitViewCallback() const;
/// dump view state for diagnostics
void dumpLibreOfficeKitViewState(rtl::OStringBuffer );
/// Invokes the registered callback, if there are any.
diff --git a/sfx2/source/view/sfxbasecontroller.cxx
b/sfx2/source/view/sfxbasecontroller.cxx
index e7c098fcda27..6db3b5570ec1 100644
--- a/sfx2/source/view/sfxbasecontroller.cxx
+++ b/sfx2/source/view/sfxbasecontroller.cxx
@@ -1021,6 +1021,18 @@ void SfxBaseController::ReleaseShell_Impl()
attachFrame( aXFrame );
}
+void SfxBaseController::CopyLokViewCallbackFromFrameCreator()
+{
+if (!m_pData->m_pViewShell)
+return;
+SfxLokCallbackInterface* pCallback = nullptr;
+if (m_pData->m_xFrame)
+if (auto xCreator = m_pData->m_xFrame->getCreator())
+if (auto parentVS = SfxViewShell::Get(xCreator->getController()))
+pCallback = parentVS->getLibreOfficeKitViewCallback();
+m_pData->m_pViewShell->setLibreOfficeKitViewCallback(pCallback);
+}
+
SfxViewShell* SfxBaseController::GetViewShell_Impl() const
{
return m_pData->m_pViewShell;
diff --git a/sfx2/source/view/viewsh.cxx b/sfx2/source/view/viewsh.cxx
index d1f326c68b7f..bd04697fab89 100644
--- a/sfx2/source/view/viewsh.cxx
+++ b/sfx2/source/view/viewsh.cxx
@@ -1435,6 +1435,11 @@ void
SfxViewShell::setLibreOfficeKitViewCallback(SfxLokCallbackInterface* pCallb
}
}
+SfxLokCallbackInterface* SfxViewShell::getLibreOfficeKitViewCallback() const
+{
+return pImpl->m_pLibreOfficeKitViewCallback;
+}
+
void SfxViewShell::dumpLibreOfficeKitViewState(rtl::OStringBuffer )
{
if (pImpl->m_pLibreOfficeKitViewCallback)
diff --git a/starmath/inc/view.hxx b/starmath/inc/view.hxx
index 45df0f425574..0a18e0084435 100644
--- a/starmath/inc/view.hxx
+++ b/starmath/inc/view.hxx
@@ -289,6 +289,7 @@ class SmViewShell final : public SfxViewShell
virtual void OuterResizePixel(const Point , const Size )
override;
virtual void QueryObjAreaPixel( tools::Rectangle& rRect ) const override;
virtual void SetZoomFactor( const Fraction , const Fraction )
override;
+virtual OString getLOKPayload(int nType, int nViewId, bool* ignore) const
override;
public:
diff --git a/starmath/source/view.cxx b/starmath/source/view.cxx
index 39676971a93f..add20227a808 100644
--- a/starmath/source/view.cxx
+++ b/starmath/source/view.cxx
@@ -32,6 +32,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -2121,6 +2122,9 @@ public:
{
SfxBaseController::attachFrame(xFrame);
+if (comphelper::LibreOfficeKit::isActive())
+CopyLokViewCallbackFromFrameCreator();
+
// No need to call mpSelectionChangeHandler->Connect() unless
SmController implements XSelectionSupplier
mpSelectionChangeHandler->selectionChanged({}); // Installs the
correct context
}
@@ -2271,4 +2275,21 @@ void SmViewShell::ZoomByItemSet(const SfxItemSet *pSet)
}
}
+OString SmViewShell::getLOKPayload(int nType, int nViewId, bool* ignore) const
+{
+switch (nType)
+{
+
[Libreoffice-bugs] [Bug 150454] [EDITING] Tab character does not show when inserted as CHAR(9)
https://bugs.documentfoundation.org/show_bug.cgi?id=150454 Rainer Bielefeld Retired changed: What|Removed |Added CC||LibreOffice@bielefeldundbus ||s.de --- Comment #1 from Rainer Bielefeld Retired --- Created attachment 181821 --> https://bugs.documentfoundation.org/attachment.cgi?id=181821=edit Sample Document Seems REPRODUCIBLE with Server Installation of Version: 7.5.0.0.alpha0+ Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e CPU-Threads: 4; BS: Windows 6.1 Service Pack 1 Build 7601; UI-Render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL | Auto Colibre Theme | Special devUserProfile (based on my normal one) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 150428] Document Recovery UX can be improved
https://bugs.documentfoundation.org/show_bug.cgi?id=150428 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 150428] Document Recovery UX can be improved
https://bugs.documentfoundation.org/show_bug.cgi?id=150428 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150428] Document Recovery UX can be improved
https://bugs.documentfoundation.org/show_bug.cgi?id=150428 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150389] loose centering with new entry in a table in writer
https://bugs.documentfoundation.org/show_bug.cgi?id=150389 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 150428] Document Recovery UX can be improved
https://bugs.documentfoundation.org/show_bug.cgi?id=150428 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 146531] Resetting Footnote Area to Larger Than Page Area Does Not Work
https://bugs.documentfoundation.org/show_bug.cgi?id=146531 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146531] Resetting Footnote Area to Larger Than Page Area Does Not Work
https://bugs.documentfoundation.org/show_bug.cgi?id=146531 --- Comment #3 from QA Administrators --- Dear larrybradley, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145962] [META] Bugs related to kerning/font spacing (cramped/to width/wiggling)
https://bugs.documentfoundation.org/show_bug.cgi?id=145962 Bug 145962 depends on bug 136548, which changed state. Bug 136548 Summary: Poor kerning preview (maybe font-related) https://bugs.documentfoundation.org/show_bug.cgi?id=136548 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=71732 Bug 71732 depends on bug 136548, which changed state. Bug 136548 Summary: Poor kerning preview (maybe font-related) https://bugs.documentfoundation.org/show_bug.cgi?id=136548 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136548] Poor kerning preview (maybe font-related)
https://bugs.documentfoundation.org/show_bug.cgi?id=136548 --- Comment #7 from QA Administrators --- Dear Ulrich Windl, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136548] Poor kerning preview (maybe font-related)
https://bugs.documentfoundation.org/show_bug.cgi?id=136548 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147371] save icon misleading
https://bugs.documentfoundation.org/show_bug.cgi?id=147371 --- Comment #2 from QA Administrators --- Dear Jens-D Doll, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145707] in v 7.1.7.2 Libre Office Mac - Crash reliably when I click Export and then click ok in dialogue box
https://bugs.documentfoundation.org/show_bug.cgi?id=145707 --- Comment #3 from QA Administrators --- Dear elrikzappa, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137918] Characters overlap feature
https://bugs.documentfoundation.org/show_bug.cgi?id=137918 --- Comment #5 from QA Administrators --- Dear silvio.gerli, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150439] Disjointed arabic ligatures at the end of line
https://bugs.documentfoundation.org/show_bug.cgi?id=150439 خالد حسني changed: What|Removed |Added OS|Windows (All) |All Hardware|x86-64 (AMD64) |All -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150439] Disjointed arabic ligatures at the end of line
https://bugs.documentfoundation.org/show_bug.cgi?id=150439 خالد حسني changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Version|7.5.0.0 alpha0+ Master |Inherited From OOo CC||kha...@aliftype.com Resolution|--- |NOTABUG --- Comment #3 from خالد حسني --- I don’t think this is a bug. If there is no suitable line breaking place (i.e. there is no space) LO will break between any two characters (the equivalent of CSS “word-break: break-all;”). The line breaking code does not know there is a ligature here and will happily break inside it, and I think this is acceptable given that this is an emergency hatch. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103729] [META] HarfBuzz-based common text layout regressions
https://bugs.documentfoundation.org/show_bug.cgi?id=103729 خالد حسني changed: What|Removed |Added Depends on|119186 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=119186 [Bug 119186] FILEOPEN: Some rows in table are higher than expected in .DOC with Microsoft fonts -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119186] FILEOPEN: Some rows in table are higher than expected in .DOC with Microsoft fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=119186 خالد حسني changed: What|Removed |Added Summary|FILEOPEN: Some rows in |FILEOPEN: Some rows in |table are higher than |table are higher than |expected in .DOC with |expected in .DOC with |Microsoft fonts since |Microsoft fonts |Harfbuzz upgrade| Blocks|103729 | --- Comment #8 from خالد حسني --- Not a HarfBuzz regression per comment 3. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103729 [Bug 103729] [META] HarfBuzz-based common text layout regressions -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119342] EDITING: Pasted HTML table into Calc can't optimize width
https://bugs.documentfoundation.org/show_bug.cgi?id=119342 --- Comment #7 from خالد حسني --- I can’t possibly imagine what in the HarfBuzz-based layout engine could affect something like this. I tested even Apache Open Office and it gives me the same behavior as LO; the last column from comment 4 optimizes but the other two don’t. Please attach a Calc file where one can reproduce this, and specify the LO version and OS where this issue was not present. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103729] [META] HarfBuzz-based common text layout regressions
https://bugs.documentfoundation.org/show_bug.cgi?id=103729 خالد حسني changed: What|Removed |Added Depends on|127655 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=127655 [Bug 127655] [UI] Wrong font in formula bar (input line) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 127655] [UI] Wrong font in formula bar (input line)
https://bugs.documentfoundation.org/show_bug.cgi?id=127655 خالد حسني changed: What|Removed |Added Blocks|103729 | CC||kha...@aliftype.com --- Comment #18 from خالد حسني --- The layout engine has no influence on font selection, and there is nothing HarfBuzz related here. Per comment 9, this is somehow related to the CTL font settings I can’t reproduce this either (even after installing the fonts, and even on a fresh LO profile), so I suggest narrowing the Hardware fields to the OS where this has been reproduced (font selection and fallback are very OS-specific). Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103729 [Bug 103729] [META] HarfBuzz-based common text layout regressions -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103729] [META] HarfBuzz-based common text layout regressions
https://bugs.documentfoundation.org/show_bug.cgi?id=103729 خالد حسني changed: What|Removed |Added Depends on|135126 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135126 [Bug 135126] Paragraph or Character attributes applied to the U+0020 "Space" NPC change text layout (Harfbuzz) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135126] Paragraph or Character attributes applied to the U+0020 "Space" NPC change text layout (Harfbuzz)
https://bugs.documentfoundation.org/show_bug.cgi?id=135126 خالد حسني changed: What|Removed |Added Blocks|103729 | --- Comment #12 from خالد حسني --- There is no HarfBuzz-related regression here, this is not even something happening in VCL. It is not a regression either, nothing changed in this area. It might have not been visible before because LO was relegating more to the system text layout engines on Windows and macOS. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103729 [Bug 103729] [META] HarfBuzz-based common text layout regressions -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 85426] VIEWING: Fixing line space crops Arabic tashkeel below in Amiri font
https://bugs.documentfoundation.org/show_bug.cgi?id=85426 --- Comment #18 from خالد حسني --- I think this is a clipping issue. Ideally applications should be using the clipping font metrics to determine the height and depth of the clipping region (AKA OS/2 usWinAscent/usWinDescent https://docs.microsoft.com/en-us/typography/opentype/spec/os2#uswinascent), but it seems that LO is (sometimes?) using line spacing instead. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150452] Crash in: libc.so.6
https://bugs.documentfoundation.org/show_bug.cgi?id=150452 Eike Rathke changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150452] Crash in: libc.so.6
https://bugs.documentfoundation.org/show_bug.cgi?id=150452 Eike Rathke changed: What|Removed |Added CC||er...@redhat.com --- Comment #2 from Eike Rathke --- Created attachment 181820 --> https://bugs.documentfoundation.org/attachment.cgi?id=181820=edit backtrace That's apparently in the bundled libcuckoo. Fwiw, I can reproduce in a 7.5 debug build, additional console message shown: terminate called after throwing an instance of 'libcuckoo::load_factor_too_low' what(): Automatic expansion triggered when load factor was below minimum threshold Attaching backtrace. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150455] New: Word completion remainder of word doubled on Enter
https://bugs.documentfoundation.org/show_bug.cgi?id=150455 Bug ID: 150455 Summary: Word completion remainder of word doubled on Enter Product: LibreOffice Version: 7.4.0.0 beta1+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: saywel...@gmail.com Created attachment 181819 --> https://bugs.documentfoundation.org/attachment.cgi?id=181819=edit Writer doc with Dummy Text showing Word Completion result by pressing Enter. Image of settings incl. In Writer 7.4.0.1 and 7.4.0.3 (new parallel installation) When Word Completion is enabled and *Show as tip* is disabled then pressing *Enter* key when suggested word is shown adds the remainder of the word twice. For example, type `dis`, the suggestion is `dis`appeared but on pressing *Enter* then the word disappearedappeared is entered. Pressing the *Space* key instead completes the word normally as expected -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150454] New: [EDITING] Tab character does not show when inserted as CHAR(9)
https://bugs.documentfoundation.org/show_bug.cgi?id=150454 Bug ID: 150454 Summary: [EDITING] Tab character does not show when inserted as CHAR(9) Product: LibreOffice Version: 7.3.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: leem...@protonmail.com Description: Tab character does not show when inserted as CHAR(9) Steps to Reproduce: 1. Create a new Calc spreadsheet. 2. Type =""(9)&"" into any cell 3. Press enter to leave text-edit mode Actual Results: The cell displays as Expected Results: The cell should show ( and separated by a tab character) Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Version: 7.3.5.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: en-GB (en_US.UTF-8); UI: en-US 7.3.5-1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103829] FILESAVE: Tab characters lost in cell
https://bugs.documentfoundation.org/show_bug.cgi?id=103829 --- Comment #18 from Faisal --- Regression still reproducible. Version: 7.3.5.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: en-GB (en_US.UTF-8); UI: en-US 7.3.5-1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150453] New: [EDITING] Select all in formula bar only selects partially for URLs
https://bugs.documentfoundation.org/show_bug.cgi?id=150453 Bug ID: 150453 Summary: [EDITING] Select all in formula bar only selects partially for URLs Product: LibreOffice Version: 7.3.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: leem...@protonmail.com Description: When there is an URL in a cell, selecting all text in the formula bar will only select n+1 characters starting from the beginning of the cell content, where n = the number of characters that is not part of the URL. Steps to Reproduce: 1. Open a new Calc spreadsheet 2. Type "https://documentfoundation.org; (without quotes) into any cell 3. Press enter and the URL will turn blue and become hyperlinked 4. Select the cell with the URL 5. Click on the formula bar to put focus on it 6. Try to select all by pressing ctrl+A or ctrl+shift+space or right click + select all Actual Results: Only the first character is highlighted. Expected Results: The entire URL should be highlighted. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Further testing: If you add characters after the URL, it will select n+1 characters, where n = the number of characters that is not part of the URL. Version: 7.3.5.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: en-GB (en_US.UTF-8); UI: en-US 7.3.5-1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: dbaccess/source
dbaccess/source/ui/dlg/DbAdminImpl.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f7e0493987f4d2d821d2724e9fef018676af5ddf Author: Caolán McNamara AuthorDate: Tue Aug 16 09:29:20 2022 +0100 Commit: Caolán McNamara CommitDate: Wed Aug 17 00:43:37 2022 +0200 cid#1509203 Dereference after null check Change-Id: I6d584c36762d8ae91a766c47ef1ee0d5a68ff4a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138370 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/dbaccess/source/ui/dlg/DbAdminImpl.cxx b/dbaccess/source/ui/dlg/DbAdminImpl.cxx index ca20930ef8df..8609c939cfe1 100644 --- a/dbaccess/source/ui/dlg/DbAdminImpl.cxx +++ b/dbaccess/source/ui/dlg/DbAdminImpl.cxx @@ -530,7 +530,7 @@ OUString ODbDataSourceAdministrationHelper::getConnectionURL() const } if ( !sNewUrl.isEmpty() ) sNewUrl = pCollection->getPrefix(eType) + sNewUrl; -else +else if (pUrlItem) sNewUrl = pUrlItem->GetValue(); return sNewUrl;
[Libreoffice-commits] core.git: sd/source
sd/source/ui/app/scalectrl.cxx |5 +
1 file changed, 5 insertions(+)
New commits:
commit 050ec6a5f282abc0c587d6971052510378a1dbe6
Author: Caolán McNamara
AuthorDate: Tue Aug 16 09:32:56 2022 +0100
Commit: Caolán McNamara
CommitDate: Wed Aug 17 00:38:30 2022 +0200
cid#1509249 Unchecked dynamic_cast
Change-Id: I8015a53004d8ba8a6ee8d6dca29ec87c655eb3ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138372
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sd/source/ui/app/scalectrl.cxx b/sd/source/ui/app/scalectrl.cxx
index 0444163b5847..90ccbc78150e 100644
--- a/sd/source/ui/app/scalectrl.cxx
+++ b/sd/source/ui/app/scalectrl.cxx
@@ -50,6 +50,11 @@ void
SdScaleControl::StateChangedAtStatusBarControl(sal_uInt16 /*nSID*/, SfxItem
if (eState != SfxItemState::DEFAULT || pState->IsVoidItem())
return;
auto pStringItem = dynamic_cast(pState);
+if (!pStringItem)
+{
+SAL_WARN("sd", "Item wasn't a SfxStringItem");
+return;
+}
GetStatusBar().SetItemText(GetId(), pStringItem->GetValue());
}
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/sidebar/PageMarginControl.cxx |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
New commits:
commit 833e4d059aae5f3a66c70f9f3d8dc1ab4c931322
Author: Caolán McNamara
AuthorDate: Tue Aug 16 09:34:18 2022 +0100
Commit: Caolán McNamara
CommitDate: Wed Aug 17 00:38:09 2022 +0200
cid#1509262 Explicit null dereferenced
Change-Id: I65eab19b3b40fae6f6b88e4dd3cf21934dd3fd95
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138373
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/source/uibase/sidebar/PageMarginControl.cxx
b/sw/source/uibase/sidebar/PageMarginControl.cxx
index 632e94140e4f..f6e0caa727bc 100644
--- a/sw/source/uibase/sidebar/PageMarginControl.cxx
+++ b/sw/source/uibase/sidebar/PageMarginControl.cxx
@@ -204,8 +204,11 @@ PageMarginControl::PageMarginControl(PageMarginPopup*
pControl, weld::Widget* pP
SetMetricValue( *m_xBottomMarginEdit, m_nPageBottomMargin, m_eUnit );
SetFieldUnit( *m_xBottomMarginEdit, lcl_GetFieldUnit() );
-m_aPageSize = pSize->GetSize();
-SetMetricFieldMaxValues( m_aPageSize );
+if (pSize)
+{
+m_aPageSize = pSize->GetSize();
+SetMetricFieldMaxValues( m_aPageSize );
+}
if ( m_bMirrored )
{
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/utlui/content.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 8faf62c76ab3a89fb149f9ec127cb352f081fcf9
Author: Caolán McNamara
AuthorDate: Tue Aug 16 09:17:20 2022 +0100
Commit: Caolán McNamara
CommitDate: Wed Aug 17 00:36:46 2022 +0200
cid#1500520 Explicit null dereferenced
and
cid#1500605 Explicit null dereferenced
Change-Id: Ic9d36899fb5c39fcd2e85fa8320addb0b05ac7d0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138359
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/source/uibase/utlui/content.cxx
b/sw/source/uibase/utlui/content.cxx
index f05611d2cc59..dfba5294a35e 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -3531,7 +3531,7 @@ static void lcl_SelectByContentTypeAndName(SwContentTree*
pThis, weld::TreeView&
std::unique_ptr
xFirstSelected(rContentTree.make_iterator());
if (!rContentTree.get_selected(xFirstSelected.get()))
xFirstSelected.reset();
-if (rContentTree.count_selected_rows() != 1 ||
+if (rContentTree.count_selected_rows() != 1 || !xFirstSelected ||
rContentTree.iter_compare(*xIter, *xFirstSelected) != 0)
{
// unselect all entries and make passed entry visible and
selected
@@ -3888,7 +3888,7 @@ void SwContentTree::UpdateTracking()
if (!m_xTreeView->get_selected(xFirstSelected.get()))
xFirstSelected.reset();
// only select if not already selected or tree has
multiple entries selected
-if (m_xTreeView->count_selected_rows() != 1 ||
+if (m_xTreeView->count_selected_rows() != 1 ||
!xFirstSelected ||
m_xTreeView->iter_compare(rEntry, *xFirstSelected)
!= 0)
{
if (m_nOutlineTracking == 2) // focused outline
tracking
[Libreoffice-commits] core.git: sw/source
sw/source/ui/misc/glossary.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit e1cd4b81d3133c460eef10efc7744f9a644b2c5b
Author: Caolán McNamara
AuthorDate: Tue Aug 16 09:16:43 2022 +0100
Commit: Caolán McNamara
CommitDate: Wed Aug 17 00:36:15 2022 +0200
cid#1500517 Explicit null dereferenced
Change-Id: I83ccacf69c22d8c05374bf5f06eb5e7ee734b12f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138358
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/source/ui/misc/glossary.cxx b/sw/source/ui/misc/glossary.cxx
index 4e657a260d02..2f3347d1e1ef 100644
--- a/sw/source/ui/misc/glossary.cxx
+++ b/sw/source/ui/misc/glossary.cxx
@@ -763,7 +763,7 @@ void SwGlossaryDlg::Init()
if (!xSelEntry)
{
xSelEntry = std::move(xSearch);
-if (!m_xCategoryBox->get_iter_first(*xSelEntry))
+if (!xSelEntry || !m_xCategoryBox->get_iter_first(*xSelEntry))
xSelEntry.reset();
}
}
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/drivers/hsqldb/HStorageAccess.cxx |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) New commits: commit cc396384b13a71a5ac2732d22b076c98316d64a0 Author: Caolán McNamara AuthorDate: Tue Aug 16 09:24:15 2022 +0100 Commit: Caolán McNamara CommitDate: Wed Aug 17 00:35:53 2022 +0200 cid#1500701 silence Dereference after null check Change-Id: Ic982e7d46688628396d659d0c1a9d17fdb8c43a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138360 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/connectivity/source/drivers/hsqldb/HStorageAccess.cxx b/connectivity/source/drivers/hsqldb/HStorageAccess.cxx index 36ef9f287347..fbbd25fbdea3 100644 --- a/connectivity/source/drivers/hsqldb/HStorageAccess.cxx +++ b/connectivity/source/drivers/hsqldb/HStorageAccess.cxx @@ -341,9 +341,14 @@ extern "C" SAL_JNI_EXPORT void JNICALL Java_com_sun_star_sdbcx_comp_hsqldb_Nativ #endif std::shared_ptr pHelper = StorageContainer::getRegisteredStream(env,name,key); -Reference< XSeekable> xSeek = pHelper ? pHelper->getSeek() : Reference< XSeekable>(); -OSL_ENSURE(xSeek.is(),"No Seekable stream!"); +OSL_ENSURE(pHelper, "No StreamHelper!"); +if (!pHelper) +return; + +Reference< XSeekable> xSeek = pHelper->getSeek(); + +OSL_ENSURE(xSeek.is(), "No Seekable stream!"); if (!xSeek) return;
[Libreoffice-bugs] [Bug 150389] loose centering with new entry in a table in writer
https://bugs.documentfoundation.org/show_bug.cgi?id=150389 --- Comment #3 from seth_...@yahoo.com --- No, I had not set AutoFormat styles; I was not aware of that function; I did not deliberately set AutoFormat. I reviewed help on that, and AutoFormat was checked; unchecking AutoFormat did correct the problem. That does solve my problem, but should AutoFormat be on by default? Also, after I change the format in the first (approximately) 20 rows, why should they be changed back to the default when I decide to add more rows? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/qt5
vcl/qt5/QtAccessibleWidget.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 04af1b4e1ce5e3e74bad517a238957bf9aaccdcd
Author: Michael Weghorn
AuthorDate: Tue Aug 16 14:25:18 2022 +0200
Commit: Michael Weghorn
CommitDate: Tue Aug 16 22:29:57 2022 +0200
qt a11y: Drop duplicate nullptr check
There is already a check whether `object` is a nullptr
just a few lines above, so this check is superfluous
since
commit f29e3dbe015571d49d4262f4623a165a0cbc94a3
Author: Michael Weghorn
Date: Tue Aug 16 09:39:01 2022 +0200
qt a11y: Replace dynamic_cast with static_cast
Reported by cppcheck:
> .../vcl/qt5/QtAccessibleWidget.cxx:751: Condition 'pXAccessible' is
always true
Change-Id: Iab69c967d97fc01dad617a25503cc5b5e50a3b4f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138366
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/vcl/qt5/QtAccessibleWidget.cxx b/vcl/qt5/QtAccessibleWidget.cxx
index 09d01c6e496f..876b735b0e48 100644
--- a/vcl/qt5/QtAccessibleWidget.cxx
+++ b/vcl/qt5/QtAccessibleWidget.cxx
@@ -748,7 +748,7 @@ QAccessibleInterface*
QtAccessibleWidget::customFactory(const QString& classname
if (classname == QLatin1String("QtXAccessible") && object)
{
QtXAccessible* pXAccessible = static_cast(object);
-if (pXAccessible && pXAccessible->m_xAccessible.is())
+if (pXAccessible->m_xAccessible.is())
{
QtAccessibleWidget* pRet = new
QtAccessibleWidget(pXAccessible->m_xAccessible, object);
// clear the reference in the QtXAccessible, no longer needed now
that the QtAccessibleWidget holds one
[Libreoffice-commits] core.git: vcl/inc vcl/qt5
vcl/inc/qt5/QtXAccessible.hxx |5 +
vcl/qt5/QtAccessibleWidget.cxx |7 ++-
2 files changed, 11 insertions(+), 1 deletion(-)
New commits:
commit f2371a7d9b306ce217689bd69c920c9f780f1ee3
Author: Michael Weghorn
AuthorDate: Tue Aug 16 14:13:20 2022 +0200
Commit: Michael Weghorn
CommitDate: Tue Aug 16 22:29:15 2022 +0200
qt a11y: Clear QtXAccessible's ref to XAccessible once passed on
The `QtXAccessible` only needs to hold a reference to
the `XAccessible` in order to pass it to the
`QtAccessibleWidget` ctor in `QtAccessibleWidget::customFactory`
(which gets called via `QAccessible::queryAccessibleInterface`).
After that has happened, the `QtAccessibleWidget` holds
its own reference in its `m_xAccessible` member and is the
only class in the context of the qt a11y bridge that needs
access to the `XAccessible`, so drop the reference
in the `QtXAccessible` to avoid any references being
held even after `QtAccessibleEventListener::disposing`
has been called, s.a.
Change-Id I077dffe6ca3e887707d1f578e947ccf3c2c2a492
"qt a11y: Clear XAccessible reference when disposing" for
some more context.
Change-Id: Ief80b2939e4c509fc4bc68e67500dbad66498506
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138365
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/vcl/inc/qt5/QtXAccessible.hxx b/vcl/inc/qt5/QtXAccessible.hxx
index 4f4285e8065b..ddb7849b641c 100644
--- a/vcl/inc/qt5/QtXAccessible.hxx
+++ b/vcl/inc/qt5/QtXAccessible.hxx
@@ -28,6 +28,11 @@ class QtXAccessible : public QObject
public:
QtXAccessible(css::uno::Reference
xAccessible);
+
+/** Reference to the XAccessible.
+ * This is cleared once it has been passed to the QtAccessibleWidget,
+ * which then keeps an own reference and takes care of all required
+ * access to the XAccessible for the Qt a11y bridge. */
css::uno::Reference m_xAccessible;
};
diff --git a/vcl/qt5/QtAccessibleWidget.cxx b/vcl/qt5/QtAccessibleWidget.cxx
index 83733e04c285..09d01c6e496f 100644
--- a/vcl/qt5/QtAccessibleWidget.cxx
+++ b/vcl/qt5/QtAccessibleWidget.cxx
@@ -749,7 +749,12 @@ QAccessibleInterface*
QtAccessibleWidget::customFactory(const QString& classname
{
QtXAccessible* pXAccessible = static_cast(object);
if (pXAccessible && pXAccessible->m_xAccessible.is())
-return new QtAccessibleWidget(pXAccessible->m_xAccessible, object);
+{
+QtAccessibleWidget* pRet = new
QtAccessibleWidget(pXAccessible->m_xAccessible, object);
+// clear the reference in the QtXAccessible, no longer needed now
that the QtAccessibleWidget holds one
+pXAccessible->m_xAccessible.clear();
+return pRet;
+}
}
return nullptr;
[Libreoffice-commits] core.git: vcl/inc vcl/qt5
vcl/inc/qt5/QtAccessibleWidget.hxx|4
vcl/qt5/QtAccessibleEventListener.cxx |6 +-
vcl/qt5/QtAccessibleWidget.cxx|2 ++
3 files changed, 11 insertions(+), 1 deletion(-)
New commits:
commit a65719ec67523cdfc294aeeda527b51ba4d2e17c
Author: Michael Weghorn
AuthorDate: Tue Aug 16 12:35:56 2022 +0200
Commit: Michael Weghorn
CommitDate: Tue Aug 16 22:28:16 2022 +0200
qt a11y: Clear XAccessible reference when disposing
The `XEventListener::disposing` doc
(in `./udkapi/com/sun/star/lang/XEventListener.idl`) says:
> /** gets called when the broadcaster is about to be disposed.
>
> All listeners and all other objects, which reference the
> broadcaster should release the reference to the source.
> No method should be invoked anymore on this object (
> including XComponent::removeEventListener() ).
>
>
> This method is called for every listener registration
> of derived listener interfaced, not only for registrations
> at XComponent.
> */
Therefore, clear the `XAccessible` reference held in
the associated `QtAccessibleWidget`
in `QtAccessibleEventListener::disposing`.
This also implies that `QtAccessibleWidget::isValid()`
(overriding the `QAccessibleInterface` method)
will return `false` from that point on.
Change-Id: I077dffe6ca3e887707d1f578e947ccf3c2c2a492
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138364
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/vcl/inc/qt5/QtAccessibleWidget.hxx
b/vcl/inc/qt5/QtAccessibleWidget.hxx
index fdd97b0b407d..0ca17b394123 100644
--- a/vcl/inc/qt5/QtAccessibleWidget.hxx
+++ b/vcl/inc/qt5/QtAccessibleWidget.hxx
@@ -50,6 +50,10 @@ class QtAccessibleWidget final : public QObject,
public:
QtAccessibleWidget(const
css::uno::Reference xAccessible,
QObject* pObject);
+
+void invalidate();
+
+// QAccessibleInterface
QWindow* window() const override;
int childCount() const override;
int indexOfChild(const QAccessibleInterface* child) const override;
diff --git a/vcl/qt5/QtAccessibleEventListener.cxx
b/vcl/qt5/QtAccessibleEventListener.cxx
index ee562a4eca38..53256181ea4e 100644
--- a/vcl/qt5/QtAccessibleEventListener.cxx
+++ b/vcl/qt5/QtAccessibleEventListener.cxx
@@ -353,6 +353,10 @@ void QtAccessibleEventListener::notifyEvent(const
css::accessibility::Accessible
}
}
-void QtAccessibleEventListener::disposing(const EventObject& /* Source */) {}
+void QtAccessibleEventListener::disposing(const EventObject& /* Source */)
+{
+assert(m_pAccessibleWidget);
+m_pAccessibleWidget->invalidate();
+}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/qt5/QtAccessibleWidget.cxx b/vcl/qt5/QtAccessibleWidget.cxx
index d6370877f449..83733e04c285 100644
--- a/vcl/qt5/QtAccessibleWidget.cxx
+++ b/vcl/qt5/QtAccessibleWidget.cxx
@@ -73,6 +73,8 @@ QtAccessibleWidget::QtAccessibleWidget(const
Reference xAccessible,
}
}
+void QtAccessibleWidget::invalidate() { m_xAccessible.clear(); }
+
Reference QtAccessibleWidget::getAccessibleContextImpl()
const
{
Reference xAc;
[Libreoffice-commits] core.git: vcl/inc vcl/qt5
vcl/inc/qt5/QtAccessibleEventListener.hxx |5 +
vcl/qt5/QtAccessibleEventListener.cxx |6 ++
vcl/qt5/QtAccessibleWidget.cxx|3 +--
3 files changed, 4 insertions(+), 10 deletions(-)
New commits:
commit 48baddac8f175e628a854f78304a19238e25d529
Author: Michael Weghorn
AuthorDate: Tue Aug 16 11:54:20 2022 +0200
Commit: Michael Weghorn
CommitDate: Tue Aug 16 22:27:49 2022 +0200
qt a11y: Drop QtAccessibleEventListener's XAccessible reference
`QtAccessibleEventListener` was holding a reference
to the `XAccessible` but not making use of it.
The `QtAccessibleWidget` class that actually
operates on the `XAccessible` is holding its own reference
in its `m_xAccessible` member, so there's no need for
the corresponding `QtAccessibleEventListener` to
hold another one.
Change-Id: I5b838e55d8285b4e52287dc8c9c70e06e45ab317
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138363
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/vcl/inc/qt5/QtAccessibleEventListener.hxx
b/vcl/inc/qt5/QtAccessibleEventListener.hxx
index 1103dc9da598..f6c7c4866ec0 100644
--- a/vcl/inc/qt5/QtAccessibleEventListener.hxx
+++ b/vcl/inc/qt5/QtAccessibleEventListener.hxx
@@ -21,9 +21,7 @@ class QtAccessibleEventListener final
: public cppu::WeakImplHelper
{
public:
-QtAccessibleEventListener(
-const css::uno::Reference xAccessible,
-QtAccessibleWidget* pAccessibleWidget);
+explicit QtAccessibleEventListener(QtAccessibleWidget* pAccessibleWidget);
virtual void SAL_CALL
notifyEvent(const css::accessibility::AccessibleEventObject& aEvent)
override;
@@ -31,7 +29,6 @@ public:
virtual void SAL_CALL disposing(const css::lang::EventObject& Source)
override;
private:
-css::uno::Reference m_xAccessible;
QtAccessibleWidget* m_pAccessibleWidget;
static void HandleStateChangedEvent(QAccessibleInterface*
pQAccessibleInterface,
diff --git a/vcl/qt5/QtAccessibleEventListener.cxx
b/vcl/qt5/QtAccessibleEventListener.cxx
index d109e4b5c844..ee562a4eca38 100644
--- a/vcl/qt5/QtAccessibleEventListener.cxx
+++ b/vcl/qt5/QtAccessibleEventListener.cxx
@@ -35,10 +35,8 @@ using namespace css::accessibility;
using namespace css::lang;
using namespace css::uno;
-QtAccessibleEventListener::QtAccessibleEventListener(const
Reference xAccessible,
- QtAccessibleWidget*
pAccessibleWidget)
-: m_xAccessible(xAccessible)
-, m_pAccessibleWidget(pAccessibleWidget)
+QtAccessibleEventListener::QtAccessibleEventListener(QtAccessibleWidget*
pAccessibleWidget)
+: m_pAccessibleWidget(pAccessibleWidget)
{
}
diff --git a/vcl/qt5/QtAccessibleWidget.cxx b/vcl/qt5/QtAccessibleWidget.cxx
index 7fa4cd297778..d6370877f449 100644
--- a/vcl/qt5/QtAccessibleWidget.cxx
+++ b/vcl/qt5/QtAccessibleWidget.cxx
@@ -68,8 +68,7 @@ QtAccessibleWidget::QtAccessibleWidget(const
Reference xAccessible,
Reference xBroadcaster(xContext, UNO_QUERY);
if (xBroadcaster.is())
{
-Reference xListener(
-new QtAccessibleEventListener(xAccessible, this));
+Reference xListener(new
QtAccessibleEventListener(this));
xBroadcaster->addAccessibleEventListener(xListener);
}
}
[Libreoffice-bugs] [Bug 150430] FILEOPEN / EDITING: Rows and row headers are not aligned to each other to the point of incorrect cell selection
https://bugs.documentfoundation.org/show_bug.cgi?id=150430 --- Comment #9 from Mike Kaganski --- (In reply to Rafael Lima from comment #8) Note that the problem appears with experimental options and jumbo sheets enabled. And it definitely repro using Version: 7.3.0.3 (x64) / LibreOffice Community Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3 CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL Jumbo -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150452] Crash in: libc.so.6
https://bugs.documentfoundation.org/show_bug.cgi?id=150452 --- Comment #1 from wcrup...@gmail.com --- Also crashes on Windows x64. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150452] New: Crash in: libc.so.6
https://bugs.documentfoundation.org/show_bug.cgi?id=150452 Bug ID: 150452 Summary: Crash in: libc.so.6 Product: LibreOffice Version: 7.3.5.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: wcrup...@gmail.com Created attachment 181818 --> https://bugs.documentfoundation.org/attachment.cgi?id=181818=edit The CSV file I was attempting to open. This bug was filed from the crash reporting server and is br-3581264b-abff-42ea-a273-0c7cb795ac2a. = Was trying to open the attached CSV file, largish at 100,001 rows. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144862] Wiggling letter with window size of 1920 pixel width (72dpi) and zoom 140% (RSID?)
https://bugs.documentfoundation.org/show_bug.cgi?id=144862
--- Comment #52 from Caolán McNamara ---
(In reply to Gibtnix from comment #51)
> For me the font rendering issues were pretty much the same across all LO
> programs. The best way to reproduce it is just to insert some dummy text
> (lorem ipsum), select a font and size (personally I prefer Arial 12 pt
> because it is most easily recognizable here, still the issue is the same
> with all fonts) and adjust the zoom level a bit. Zooming in and out will
> easily show neighbored 'wide' characters smearing into each other (e.g. 'm'
> and 'p') while smaller ones ('l' or 'i') show asymmetric/ugly spacings.
> Also, exporting the file to PDF and open it with a PDF viewer or
> alternatively in parallel do the same with MS Office easily shows the
> "untidy" font rendering of LO.
Hmm, debugging a little in impress I think there might be a separate problem
with VclProcessor2D::RenderTextSimpleOrDecoratedPortionPrimitive2D and the text
positioning scaling done there before it even gets to the usual text rendering
stuff so things are probably already gone wrong before it even gets as far as
the underlying stuff touched under this bug. I think we need a new separate
impress bug, my thinking is that we should pass the dx positions to vcl
untouched and instead set up vcl to scale them rather than scale them in
advance in drawinglayer, which would at least give vcl a chance to do something
nice.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149055] Embedded chart no longer works properly
https://bugs.documentfoundation.org/show_bug.cgi?id=149055 --- Comment #9 from Timur --- To be sure that problem is fixed in 7.4, tester should first reproduce with 7.3. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150430] FILEOPEN / EDITING: Rows and row headers are not aligned to each other to the point of incorrect cell selection
https://bugs.documentfoundation.org/show_bug.cgi?id=150430 --- Comment #8 from Rafael Lima --- The file opened correctly for me in Version: 7.3.5.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Ubuntu package version: 1:7.3.5-0ubuntu0.22.04.1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Rafael Lima changed: What|Removed |Added Depends on||150451 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150451 [Bug 150451] Some text boxes in dialogs do not have borders in dark mode (Dark mode + kf5) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150451] Some text boxes in dialogs do not have borders in dark mode (Dark mode + kf5)
https://bugs.documentfoundation.org/show_bug.cgi?id=150451 Rafael Lima changed: What|Removed |Added Blocks||102495 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102495 [Bug 102495] [META] KDE VCL backend bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150451] New: Some text boxes in dialogs do not have borders in dark mode (Dark mode + kf5)
https://bugs.documentfoundation.org/show_bug.cgi?id=150451 Bug ID: 150451 Summary: Some text boxes in dialogs do not have borders in dark mode (Dark mode + kf5) Product: LibreOffice Version: 7.3.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rafael.palma.l...@gmail.com Created attachment 181817 --> https://bugs.documentfoundation.org/attachment.cgi?id=181817=edit Properties dialog (notice text boxes without borders) Open attachment 181815 from bug 150448 and notice that the text box where the value "P" was entered does not have borders around it. Actually, without the value it is not even possible to know that a text box exists there. Also notice that the "Range" field at the bottom of the same dialog does not have borders as well, which is a visual glitch. This problem happens in various dialogs using dark mode, but only in text boxes. Another example is the "Properties" dialog under the "Description" tab (see image attached to this ticket). This problem seems to be Kf5-only, because using "SAL_USE_VCLPLUGIN=gtk3" even in KDE the text boxes have borders. BTW I am using stock KDE Plasma 5.24.6 without any themes applied. Just stock Breeze dark. System info Version: 7.3.5.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Ubuntu package version: 1:7.3.5-0ubuntu0.22.04.1 Calc: threaded Also repro in Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 641d92a73e5b3d0e062e16ed4b42236e1a4796a5 CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150170] Crash in: mdds::flat_segment_tree::insert_to_pos(boost::intrusive_ptr > > &,long,long,bool)
https://bugs.documentfoundation.org/show_bug.cgi?id=150170 --- Comment #13 from Xisco Faulí --- @Roman, @Raal, Could you please try with the 7.3 branch ? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - basic/source
basic/source/classes/sbunoobj.cxx |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) New commits: commit 8e9bc34c0555ed09e2f996a949dc9cf9e028beac Author: Caolán McNamara AuthorDate: Tue Aug 16 10:00:00 2022 +0100 Commit: Caolán McNamara CommitDate: Tue Aug 16 20:26:18 2022 +0200 cid#1509215 Using a moved object and cid#1509294 Using a moved object Change-Id: Ic4ef9bbc94d7b946d7d1904edf4b5b23278baafd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138284 Reviewed-by: Michael Stahl Tested-by: Jenkins diff --git a/basic/source/classes/sbunoobj.cxx b/basic/source/classes/sbunoobj.cxx index 51b1b956b170..604ac8d866f5 100644 --- a/basic/source/classes/sbunoobj.cxx +++ b/basic/source/classes/sbunoobj.cxx @@ -4679,7 +4679,8 @@ SbxVariable* SbUnoStructRefObject::Find( const OUString& rName, SbxClassType t ) Property aProp; aProp.Name = rName; aProp.Type = css::uno::Type( it->second->getTypeClass(), it->second->getTypeName() ); -SbUnoProperty* pProp = new SbUnoProperty( rName, eSbxType, eRealSbxType, std::move(aProp), 0, false, ( aProp.Type.getTypeClass() == css::uno::TypeClass_STRUCT) ); +const bool bIsStruct = aProp.Type.getTypeClass() == css::uno::TypeClass_STRUCT; +SbUnoProperty* pProp = new SbUnoProperty( rName, eSbxType, eRealSbxType, std::move(aProp), 0, false, bIsStruct ); SbxVariableRef xVarRef = pProp; QuickInsert( xVarRef.get() ); pRes = xVarRef.get(); @@ -4739,7 +4740,8 @@ void SbUnoStructRefObject::implCreateAll() Property aProp; aProp.Name = rName; aProp.Type = css::uno::Type( field.second->getTypeClass(), field.second->getTypeName() ); -SbUnoProperty* pProp = new SbUnoProperty( rName, eSbxType, eRealSbxType, std::move(aProp), 0, false, ( aProp.Type.getTypeClass() == css::uno::TypeClass_STRUCT) ); +const bool bIsStruct = aProp.Type.getTypeClass() == css::uno::TypeClass_STRUCT; +SbUnoProperty* pProp = new SbUnoProperty( rName, eSbxType, eRealSbxType, std::move(aProp), 0, false, bIsStruct ); SbxVariableRef xVarRef = pProp; QuickInsert( xVarRef.get() ); }
[Libreoffice-bugs] [Bug 150170] Crash in: mdds::flat_segment_tree::insert_to_pos(boost::intrusive_ptr > > &,long,long,bool)
https://bugs.documentfoundation.org/show_bug.cgi?id=150170 --- Comment #12 from Xisco Faulí --- no crash in Version: 7.4.0.3 (x64) / LibreOffice Community Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a CPU threads: 1; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150170] Crash in: mdds::flat_segment_tree::insert_to_pos(boost::intrusive_ptr > > &,long,long,bool)
https://bugs.documentfoundation.org/show_bug.cgi?id=150170 --- Comment #11 from Xisco Faulí --- I can't reproduce it in Version: 7.3.5.0.0+ / LibreOffice Community Build ID: ff6e536111a966f465c4756cbfa74935752df612 CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: es-ES (es_ES.UTF-8); UI: en-US Calc: threaded @Stan, @Jared, could you please share the information from Help - About LibreOffice ? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150236] Does not open full screen, ooSetupFactoryWindowAttributes not being filled ( steps in comment 21 )
https://bugs.documentfoundation.org/show_bug.cgi?id=150236 --- Comment #26 from V Stuart Foote --- Created attachment 181816 --> https://bugs.documentfoundation.org/attachment.cgi?id=181816=edit cgit of 8b6000f in 7.4.0 (In reply to Xisco Faulí from comment #25) ... > > [1] https://gerrit.libreoffice.org/c/core/+/135809 > > no, it's not Umm, you sure? If so it fooled me. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150170] Crash in: mdds::flat_segment_tree::insert_to_pos(boost::intrusive_ptr > > &,long,long,bool)
https://bugs.documentfoundation.org/show_bug.cgi?id=150170 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org Status|RESOLVED|NEW Ever confirmed|0 |1 Resolution|WORKSFORME |--- --- Comment #10 from Xisco Faulí --- this crash is still reproducible in 7.3 series, putting it to NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150170] Crash in: mdds::flat_segment_tree::insert_to_pos(boost::intrusive_ptr > > &,long,long,bool)
https://bugs.documentfoundation.org/show_bug.cgi?id=150170 Xisco Faulí changed: What|Removed |Added CC||norbert.n...@gmx.de --- Comment #9 from Xisco Faulí --- *** Bug 150449 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150449] Calc crashes sporadically
https://bugs.documentfoundation.org/show_bug.cgi?id=150449 Xisco Faulí changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #1 from Xisco Faulí --- oh, I just found there is actually a report for it *** This bug has been marked as a duplicate of bug 150170 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150449] Calc crashes sporadically
https://bugs.documentfoundation.org/show_bug.cgi?id=150449 Xisco Faulí changed: What|Removed |Added Ever confirmed|1 |0 CC||xiscofa...@libreoffice.org Status|NEW |UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150449] Calc crashes sporadically
https://bugs.documentfoundation.org/show_bug.cgi?id=150449 OfficeUser changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150450] New: DOCX Document Intermittently Appears Saved as a DOC File with DOCX Extension
https://bugs.documentfoundation.org/show_bug.cgi?id=150450 Bug ID: 150450 Summary: DOCX Document Intermittently Appears Saved as a DOC File with DOCX Extension Product: LibreOffice Version: 7.3.5.2 release Hardware: All OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: pm...@fn-software.com Description: LibreOffice: 7.3.5 Apple iMac: MacOS Monterey 12.5 I downloaded LibreOffice 7.3.5 to try out. Played around a while, seemed fine. I loaded a 50k DOCX file (created with MAC MS Word 2016) and made changes. Saved File. Reloaded, all good. Made more changes, Saved. Exited. Later, when I tried to open, it said (instantly): “my_file.docx” is damaged and can’t be opened. You should move it to the Trash. So, I went to a backup (lost my changes) and tried to recreate the issue, but could not. So, more editing and multiple saves, exited, corrupted again. So, deciding to create a Bug Report, I tried to recreate the issue for the report, no dice. Everything works fine. I noticed that the 50k file, was saved as a 40k file. Just on a whim, I renamed the file to my_file.doc. Now both Word and LibreOffice load the previously corrupted file, with no issues. Steps to Reproduce: 1. LibreOffice 7.3.5 2. Open My_File.docx 3. Make changes to the file 4. Save changes 5. Repeat 3-4 a few times. 6. Exit LibreOffice 7. Double Click the DOCX file 8. Corrupt message occurs Actual Results: “my_file.docx” is damaged and can’t be opened. You should move it to the Trash. Expected Results: Open/Edit File. Reproducible: Sometimes User Profile Reset: No Additional Info: It appears that the DOCX decompression occurs before Word or LibreOffice is opened (since it occurs so quickly after double-click file. It fails, so it never loads the editor (word or LibreOffice). Once the issue occurs, both Word and LibreOffice see the exact same issue. Renaming the file to *.doc allows the file to load correctly. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150449] New: Calc crashes sporadically
https://bugs.documentfoundation.org/show_bug.cgi?id=150449 Bug ID: 150449 Summary: Calc crashes sporadically Product: LibreOffice Version: 7.3.5.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: norbert.n...@gmx.de Calc crashes sporadically. The bug seems to be Windows-only. Unfortunately, the problem cannot yet be narrowed down to specific steps. https://crashreport.libreoffice.org/stats/crash_details/7cbafa54-0301-45d8-b002-428645a9e852 Version: 7.3.5.2 (x86) / LibreOffice Community Build ID: 184fe81b8c8c30d8b5082578aee2fed2ea847c01 CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: default; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150236] Does not open full screen, ooSetupFactoryWindowAttributes not being filled ( steps in comment 21 )
https://bugs.documentfoundation.org/show_bug.cgi?id=150236 --- Comment #25 from Xisco Faulí --- (In reply to V Stuart Foote from comment #24) > (In reply to Xisco Faulí from comment #23) > > In master, this issue got fixed by > > > > https://cgit.freedesktop.org/libreoffice/core/commit/ > > ?id=8b6000f6075725b2e17b8fa745251ea96d7185f1 > > No, that [1] is already in the 7.4.0.1 pre-release (built 2022-07-06), > right? > > =-ref-= > [1] https://gerrit.libreoffice.org/c/core/+/135809 no, it's not -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 87351] [META] Conditional formatting bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=87351 Rafael Lima changed: What|Removed |Added Depends on||150448 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150448 [Bug 150448] Preview using Conditional Formatting has weird behavior when multiple cells are selected -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150448] Preview using Conditional Formatting has weird behavior when multiple cells are selected
https://bugs.documentfoundation.org/show_bug.cgi?id=150448 Rafael Lima changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval Blocks||87351 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=87351 [Bug 87351] [META] Conditional formatting bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 150448] Preview using Conditional Formatting has weird behavior when multiple cells are selected
https://bugs.documentfoundation.org/show_bug.cgi?id=150448 Rafael Lima changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval Blocks||87351 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=87351 [Bug 87351] [META] Conditional formatting bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 150448] New: Preview using Conditional Formatting has weird behavior when multiple cells are selected
https://bugs.documentfoundation.org/show_bug.cgi?id=150448 Bug ID: 150448 Summary: Preview using Conditional Formatting has weird behavior when multiple cells are selected Product: LibreOffice Version: 7.3.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rafael.palma.l...@gmail.com Created attachment 181815 --> https://bugs.documentfoundation.org/attachment.cgi?id=181815=edit Screenshots showing the problem I have a sheet with a column (see Column D in the screenshot) where values are either "F" or "P" and I would like to format cells based on their values so that cells with "P" are formatted with the "Good" style. So I select the cells and go to "Format - Conditional - Condition" and apply a conditional formatting so that cells "equal to" "P" receive the "Good" style. The formatting itself works as expected, but the preview box shows weird content (again, see attached image). Notice that the preview has the values "P P P P F P P P F P ..." as though a single string was being formatted. What's more, "P"s and "F"s are marked as green in the preview, which is weird because I'm only formatting cells with "P". Cells with "F" should remain white. In summary, we could improve this preview. I'm still unsure what strategy we should take, but here are some options: 1) We could have a default preview value, with generic text or number (or a default value depending on the "Number Format" chosen for the style) to which the style can be applied in the preview 2) We could use the contents of the first matching cell to serve as sample in the preview. The only problem is if there's no matching cell to use as sample. 3) We could use strategy (2) above and if no matching value is found, then we use (1) System info Version: 7.3.5.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Ubuntu package version: 1:7.3.5-0ubuntu0.22.04.1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150236] Does not open full screen, ooSetupFactoryWindowAttributes not being filled ( steps in comment 21 )
https://bugs.documentfoundation.org/show_bug.cgi?id=150236 --- Comment #24 from V Stuart Foote --- (In reply to Xisco Faulí from comment #23) > In master, this issue got fixed by > > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=8b6000f6075725b2e17b8fa745251ea96d7185f1 No, that [1] is already in the 7.4.0.1 pre-release (built 2022-07-06), right? =-ref-= [1] https://gerrit.libreoffice.org/c/core/+/135809 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150447] Solve the Extra Spacing in the Optinos
https://bugs.documentfoundation.org/show_bug.cgi?id=150447 Kartik Tiwari changed: What|Removed |Added CC||cemaw52...@upshopt.com Assignee|libreoffice-b...@lists.free |cemaw52...@upshopt.com |desktop.org | --- Comment #1 from Kartik Tiwari --- Created attachment 181814 --> https://bugs.documentfoundation.org/attachment.cgi?id=181814=edit Extra Spacing -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150447] Solve the Extra Spacing in the Optinos
https://bugs.documentfoundation.org/show_bug.cgi?id=150447 Kartik Tiwari changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149055] Embedded chart no longer works properly
https://bugs.documentfoundation.org/show_bug.cgi?id=149055 --- Comment #8 from BogdanB --- 7.4 is in prerelease now. https://www.libreoffice.org/download/download/?type=win-x86_64=7.4.0=en -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150447] New: Solve the Extra Spacing in the Optinos
https://bugs.documentfoundation.org/show_bug.cgi?id=150447 Bug ID: 150447 Summary: Solve the Extra Spacing in the Optinos Product: LibreOffice Version: 6.0.0.3 release Hardware: x86 (IA32) URL: https://www.libreoffice.org/discover/libreoffice/ OS: Windows (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: cemaw52...@upshopt.com -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150436] settings AllowEditReadonlyDocs and AllowOverrideLocking seem to be set to true by default
https://bugs.documentfoundation.org/show_bug.cgi?id=150436 Julien Nabet changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr |desktop.org | Ever confirmed|0 |1 CC||samuel.mehrbrodt@allotropia ||.de, serval2...@yahoo.fr Status|UNCONFIRMED |ASSIGNED --- Comment #1 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I could reproduce this. I submitted https://gerrit.libreoffice.org/c/core/+/138378 on gerrit. Samuel: put you in cc so you can tell if there was some reason to use true by default. In this case, I'll abandon the patch of course. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150236] Does not open full screen, ooSetupFactoryWindowAttributes not being filled ( steps in comment 21 )
https://bugs.documentfoundation.org/show_bug.cgi?id=150236 --- Comment #23 from Xisco Faulí --- In master, this issue got fixed by https://cgit.freedesktop.org/libreoffice/core/commit/?id=8b6000f6075725b2e17b8fa745251ea96d7185f1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150443] Track changes: Crash rejecting a grouped change
https://bugs.documentfoundation.org/show_bug.cgi?id=150443 Julien Nabet changed: What|Removed |Added Priority|medium |high Severity|normal |major --- Comment #4 from Julien Nabet --- Crash+regression+all envs => let's increase importance. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150236] Does not open full screen, ooSetupFactoryWindowAttributes not being filled ( steps in comment 21 )
https://bugs.documentfoundation.org/show_bug.cgi?id=150236 --- Comment #22 from V Stuart Foote --- (In reply to Xisco Faulí from comment #21) > I'm sorry but the steps were not clear at all, it took me more than an hour > to find the way to reproduce it... > > Steps to reproduce: > 1. Clean the profile > 2. Launch soffice > 3. Open writer from the start center > 4. Maximize the window > 5. Close LibreOffice > 6. Launch Writer > > -> it should be maximized Yep, like that. Or you could just look in the user profile for any launch ;-) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150236] Does not open full screen, ooSetupFactoryWindowAttributes not being filled ( steps in comment 21 )
https://bugs.documentfoundation.org/show_bug.cgi?id=150236 Xisco Faulí changed: What|Removed |Added Summary|Does not open full screen, |Does not open full screen, |ooSetupFactoryWindowAttribu |ooSetupFactoryWindowAttribu |tes not being filled|tes not being filled ( ||steps in comment 21 ) --- Comment #21 from Xisco Faulí --- I'm sorry but the steps were not clear at all, it took me more than an hour to find the way to reproduce it... Steps to reproduce: 1. Clean the profile 2. Launch soffice 3. Open writer from the start center 4. Maximize the window 5. Close LibreOffice 6. Launch Writer -> it should be maximized -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150443] Track changes: Crash rejecting a grouped change
https://bugs.documentfoundation.org/show_bug.cgi?id=150443 Julien Nabet changed: What|Removed |Added Keywords||haveBacktrace -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150443] Track changes: Crash rejecting a grouped change
https://bugs.documentfoundation.org/show_bug.cgi?id=150443 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #2 from Julien Nabet --- Created attachment 181813 --> https://bugs.documentfoundation.org/attachment.cgi?id=181813=edit bt with debug symbols On pc Debian x86-64 with master sources updated today, I could reproduce this. (remark: I don't have a "+" but a triangle to indicated the list can be expanded). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150442] Crash Report : Publipostage "Envoyer les courriels"
https://bugs.documentfoundation.org/show_bug.cgi?id=150442 Julien Nabet changed: What|Removed |Added Version|7.3.5.2 release |7.3.3.2 release CC||serval2...@yahoo.fr Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #6 from Julien Nabet --- As Xisco indicated in his comment, it would be useful to have the files to make the mailmerge (of course after having removed any private/confidential part) so we can try to reproduce this. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150446] New: Incorrect behaviour of gutter in mirrored pages with top binding
https://bugs.documentfoundation.org/show_bug.cgi?id=150446 Bug ID: 150446 Summary: Incorrect behaviour of gutter in mirrored pages with top binding Product: LibreOffice Version: 7.3.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: page74010...@yahoo.fr Created attachment 181812 --> https://bugs.documentfoundation.org/attachment.cgi?id=181812=edit 3 pages intended for duplex printing and top binding Gutter is some space reserved for binding. It is removed from usable area of page to make sure no element would be hidden by the binding device. Common documents are bound on left. However there are special cases where binding is at top. Gutter is then positioned at top. Pages may also be duplex printed. Then page style layout is selected as "Mirrored". It is expected that with the indication of top gutter, Writer will understand the intent and reverse top and bottom margins and also distribute alternatively gutter at top and bottom of pages. Presently, right pages get their gutter at top while left pages have no gutter at all (see attachment). Note also that top and bottom margins are still considered rigidly as top and bottom instead of close to binding and far from binding. Everything works fine in the traditional configuration of left gutter with mirrored layout (the gutter alternates between sides, always positioned at inner edge, near the binding). A possible workaround is to separate left and right pages to set differently top and bottom margins, integrating the gutter into margin measurement. But this is rather troublesome since the gutter setting was provided to avoid using separate page styles. Version: 7.3.4.2 Build ID: 30(Build:2) CPU threads: 4; OS: Linux 5.18; UI render: default; VCL: kf5 (cairo+xcb) Locale: fr-FR (fr_FR.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/ndtxt.hxx |2 +-
sw/source/core/doc/docfmt.cxx |4 ++--
sw/source/core/table/swtable.cxx |7 +++
sw/source/core/txtnode/ndtxt.cxx |3 +--
sw/source/core/txtnode/thints.cxx |2 +-
sw/source/core/undo/unattr.cxx|6 ++
6 files changed, 10 insertions(+), 14 deletions(-)
New commits:
commit b9a45cca8a0014d975f6e3d16c94cfe08c52a8bb
Author: Noel Grandin
AuthorDate: Mon Aug 15 17:42:25 2022 +0200
Commit: Noel Grandin
CommitDate: Tue Aug 16 18:22:39 2022 +0200
pass sal_Int32 to DontExpandormat
instead of SwContentIndex.
Part of the process of hiding the implementation of SwPosition.
Change-Id: I69d2a92093109b52b21c558f8ea8e3ae486fe1ed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138319
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/inc/ndtxt.hxx b/sw/inc/ndtxt.hxx
index f9da070ae25e..8715f0e7e98e 100644
--- a/sw/inc/ndtxt.hxx
+++ b/sw/inc/ndtxt.hxx
@@ -366,7 +366,7 @@ public:
SwContentNode *AppendNode( const SwPosition & );
/// When appropriate set DontExpand-flag at INet or character styles
respectively.
-bool DontExpandFormat( const SwContentIndex& rIdx, bool bFlag = true,
+bool DontExpandFormat( sal_Int32 nContentIdx, bool bFlag = true,
bool bFormatToTextAttributes = true );
enum GetTextAttrMode {
diff --git a/sw/source/core/doc/docfmt.cxx b/sw/source/core/doc/docfmt.cxx
index c6399b31344f..43e1e24e9b25 100644
--- a/sw/source/core/doc/docfmt.cxx
+++ b/sw/source/core/doc/docfmt.cxx
@@ -288,7 +288,7 @@ void SwDoc::ResetAttrs( const SwPaM ,
{
nPtPos = nMkPos = rSt.GetIndex();
if( bTextAttr )
-pTextNd->DontExpandFormat( rSt );
+pTextNd->DontExpandFormat( nPtPos );
}
}
@@ -1702,7 +1702,7 @@ bool SwDoc::DontExpandFormat( const SwPosition& rPos,
bool bFlag )
SwTextNode* pTextNd = rPos.GetNode().GetTextNode();
if( pTextNd )
{
-bRet = pTextNd->DontExpandFormat( rPos.nContent, bFlag );
+bRet = pTextNd->DontExpandFormat( rPos.GetContentIndex(), bFlag );
if( bRet && GetIDocumentUndoRedo().DoesUndo() )
{
GetIDocumentUndoRedo().AppendUndo(
std::make_unique(rPos) );
diff --git a/sw/source/core/table/swtable.cxx b/sw/source/core/table/swtable.cxx
index 9386c3f31470..1863316d1531 100644
--- a/sw/source/core/table/swtable.cxx
+++ b/sw/source/core/table/swtable.cxx
@@ -2218,7 +2218,7 @@ void ChgTextToNum( SwTableBox& rBox, const OUString&
rText, const Color* pCol,
// Reset DontExpand-Flags before exchange, to retrigger expansion
{
SwContentIndex aResetIdx( aIdx, n );
-pTNd->DontExpandFormat( aResetIdx, false, false );
+pTNd->DontExpandFormat( aResetIdx.GetIndex(), false, false );
}
if( !pDoc->getIDocumentRedlineAccess().IsIgnoreRedline() &&
!pDoc->getIDocumentRedlineAccess().GetRedlineTable().empty() )
@@ -2284,10 +2284,9 @@ static void ChgNumToText( SwTableBox& rBox, sal_uLong
nFormat )
if( sText != sTmp )
{
// exchange text
-SwContentIndex aIdx( pTNd, sText.getLength() );
// Reset DontExpand-Flags before exchange, to retrigger expansion
-pTNd->DontExpandFormat( aIdx, false, false );
-aIdx = 0;
+pTNd->DontExpandFormat( sText.getLength(), false, false );
+SwContentIndex aIdx( pTNd, 0 );
pTNd->EraseText( aIdx, SAL_MAX_INT32, SwInsertFlags::EMPTYEXPAND );
pTNd->InsertText( sTmp, aIdx, SwInsertFlags::EMPTYEXPAND );
}
diff --git a/sw/source/core/txtnode/ndtxt.cxx b/sw/source/core/txtnode/ndtxt.cxx
index 4a00177b97a8..b567ec4d17cc 100644
--- a/sw/source/core/txtnode/ndtxt.cxx
+++ b/sw/source/core/txtnode/ndtxt.cxx
@@ -1640,10 +1640,9 @@ void SwTextNode::ChgTextCollUpdateNum( const
SwTextFormatColl *pOldColl,
// If positioned exactly at the end of a CharStyle or Hyperlink,
// set its DontExpand flag.
-bool SwTextNode::DontExpandFormat( const SwContentIndex& rIdx, bool bFlag,
+bool SwTextNode::DontExpandFormat( sal_Int32 nIdx, bool bFlag,
bool bFormatToTextAttributes )
{
-const sal_Int32 nIdx = rIdx.GetIndex();
if (bFormatToTextAttributes && nIdx == m_Text.getLength())
{
FormatToTextAttr( this );
diff --git a/sw/source/core/txtnode/thints.cxx
b/sw/source/core/txtnode/thints.cxx
index 3c189cbb55e9..aac947bbe844 100644
--- a/sw/source/core/txtnode/thints.cxx
+++ b/sw/source/core/txtnode/thints.cxx
@@ -1985,7 +1985,7 @@ bool SwTextNode::SetAttr(
{
SwContentIndex aIndex( this, nStt );
RstTextAttr( aIndex, nEnd - nStt, RES_TXTATR_CHARFMT );
-DontExpandFormat( aIndex );
+DontExpandFormat( aIndex.GetIndex() );
[Libreoffice-bugs] [Bug 150439] Disjointed arabic ligatures at the end of line
https://bugs.documentfoundation.org/show_bug.cgi?id=150439 --- Comment #2 from Kamil Landa --- I'm sorry, it isn't duplicate of the bug 85426, I clicked badly. But I don't know how to delete previous comment. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112810] [META] Arabic language-specific RTL issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112810 Bug 112810 depends on bug 113102, which changed state. Bug 113102 Summary: Arabic double tashkeel gets cropped on the first line due to extending into header area https://bugs.documentfoundation.org/show_bug.cgi?id=113102 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 48741] [META] Writer's page header and footer issues
https://bugs.documentfoundation.org/show_bug.cgi?id=48741 Bug 48741 depends on bug 113102, which changed state. Bug 113102 Summary: Arabic double tashkeel gets cropped on the first line due to extending into header area https://bugs.documentfoundation.org/show_bug.cgi?id=113102 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 85426] VIEWING: Fixing line space crops Arabic tashkeel below in Amiri font
https://bugs.documentfoundation.org/show_bug.cgi?id=85426 --- Comment #17 from Kamil Landa --- *** Bug 113102 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113102] Arabic double tashkeel gets cropped on the first line due to extending into header area
https://bugs.documentfoundation.org/show_bug.cgi?id=113102 Kamil Landa changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #5 from Kamil Landa --- *** This bug has been marked as a duplicate of bug 85426 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150439] Disjointed arabic ligatures at the end of line
https://bugs.documentfoundation.org/show_bug.cgi?id=150439 Kamil Landa changed: What|Removed |Added Resolution|DUPLICATE |--- Status|RESOLVED|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
