[Libreoffice-bugs] [Bug 108137] [META] Writer feature enhancements

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108137
Bug 108137 depends on bug 126535, which changed state.

Bug 126535 Summary: 'Find' doesn't show number of matches
https://bugs.documentfoundation.org/show_bug.cgi?id=126535

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 102847] [META] Quick Find, Search and Replace

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102847
Bug 102847 depends on bug 126535, which changed state.

Bug 126535 Summary: 'Find' doesn't show number of matches
https://bugs.documentfoundation.org/show_bug.cgi?id=126535

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147457] Basic 'Me' keyword not implemented

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147457

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150762] FILEOPEN RTF Paragraph left indents missing inside frame

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150762

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150752] LO Write 7.3.3.1 outline numbering in master document gives offset in chapter numbering in level 1

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150752

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150863] after paste special unformatted text, Calc scrolls only visible rows

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150863

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150863] after paste special unformatted text, Calc scrolls only visible rows

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150863

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145707] in v 7.1.7.2 Libre Office Mac - Crash reliably when I click Export and then click ok in dialogue box

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145707

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145707] in v 7.1.7.2 Libre Office Mac - Crash reliably when I click Export and then click ok in dialogue box

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145707

--- Comment #4 from QA Administrators  ---
Dear elrikzappa,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147788] Word document containing equations is imported incorrectly/incompletely

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147788

--- Comment #2 from QA Administrators  ---
Dear swulf,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 90682] Pasting table as RTF hides second column

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90682

--- Comment #9 from QA Administrators  ---
Dear Yousuf Philips (jay) (retired),

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 78048] FORMATTING: "constant value" error bars can't be arbitrary small or big

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=78048

--- Comment #8 from QA Administrators  ---
Dear bruno.binet,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 43419] Accessing Writer with unoconv changes the configuration

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=43419

--- Comment #30 from QA Administrators  ---
Dear sworddragon2,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135631] Document layout on screen 'unstable' under circumstances (MacOS)

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135631

--- Comment #4 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 121513] FILESAVE DOCX TextBox in Shape is modified after export

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121513

--- Comment #9 from QA Administrators  ---
Dear NISZ LibreOffice Team,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150986] Updated icu to 71.1 and Libreoffice 7.4.1 crashes when trying to print (PcLinuxOS, KDE?)

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150986

texs...@gmail.com changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEEDINFO|RESOLVED
 OS|Linux (All) |All

--- Comment #7 from texs...@gmail.com ---
I had some time today so I took an old install, updated LibreOffice rpms and
only updated ICU to 71.1 and LibreOffice still prints. So there is something
else that was part of the ICU update/rebuild that is breaking our printing in
LibreOffice. Now to track down what package what was rebuilt against icu 71.1
that is causing the printing problem in the 7.4.x series of LibreOffice. Sure
glad 7.3.6 is not affected.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

2022-09-16 Thread Rafael Lima (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3752e8eaa81a50b018669d03dc59b3753a5248ef
Author: Rafael Lima 
AuthorDate: Sat Sep 17 05:11:27 2022 +0200
Commit: Gerrit Code Review 
CommitDate: Sat Sep 17 05:11:27 2022 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to b0c4a0d68e1e2bf0ab4f89b06a15402ffe8daa30
  - tdf#150989 Document "Math baseline" option in Writer

Change-Id: I1746ce0c2a0c414b0217b5df93f20f599d1537b9
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139985
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index dfa442b3d862..b0c4a0d68e1e 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit dfa442b3d862539a7b10af5281a080acaef7e73d
+Subproject commit b0c4a0d68e1e2bf0ab4f89b06a15402ffe8daa30


[Libreoffice-commits] help.git: source/text

2022-09-16 Thread Rafael Lima (via logerrit)
 source/text/shared/optionen/01040600.xhp |4 
 1 file changed, 4 insertions(+)

New commits:
commit b0c4a0d68e1e2bf0ab4f89b06a15402ffe8daa30
Author: Rafael Lima 
AuthorDate: Fri Sep 16 21:11:53 2022 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Sep 17 05:11:25 2022 +0200

tdf#150989 Document "Math baseline" option in Writer

Change-Id: I1746ce0c2a0c414b0217b5df93f20f599d1537b9
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139985
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/source/text/shared/optionen/01040600.xhp 
b/source/text/shared/optionen/01040600.xhp
index 58ca4d557..d5d131ab2 100644
--- a/source/text/shared/optionen/01040600.xhp
+++ b/source/text/shared/optionen/01040600.xhp
@@ -51,6 +51,7 @@
 hidden fields display (Writer)
 paragraphs; hidden paragraphs (Writer)
 cursor; allowing in protected areas (Writer)
+Math baseline alignment (Writer)
 
 
 
@@ -60,6 +61,9 @@
 
   
 
+Layout Assistance
+Math baseline alignment
+Specifies whether Math 
formula objects are aligned using the text baseline as reference. Uncheck this 
option to be able to change the vertical position of Math objects in a 
paragraph.
 Display formatting
 Defines which 
formatting marks are visible on screen. Activate the Formatting Marks icon on the Standard 
bar. All characters that you have selected on the Formatting Aids 
tab page will be displayed.
 


[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - vcl/unx

2022-09-16 Thread Michael Weghorn (via logerrit)
 vcl/unx/gtk3/salnativewidgets-gtk.cxx |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit 2103178720fd485651b94b7819ea33ec602c3b79
Author: Michael Weghorn 
AuthorDate: Fri Sep 16 10:30:01 2022 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Sep 17 05:10:19 2022 +0200

tdf#137341 gtk: Set missing style text colors from theme

commit 8d11b953c0a69f4f5eb5ca42dec3812a62d0cd0f
Date:   Sun Feb 23 21:11:05 2020 +0100

tdf#125532: White text on default/action buttons and selected tabs 
on macOS

had introduced various new text colors to the style
settings, but some were not set from the theme for gtk.

Add the missing ones.

Change-Id: I1bd7ce358626b3f4ff1d6f2794d5c0f19f78a668
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140058
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 
(cherry picked from commit 8306152d5205dd35c118d06368f6c77254f87518)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139984
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/vcl/unx/gtk3/salnativewidgets-gtk.cxx 
b/vcl/unx/gtk3/salnativewidgets-gtk.cxx
index 3eaffc903e16..64f6357abd79 100644
--- a/vcl/unx/gtk3/salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk3/salnativewidgets-gtk.cxx
@@ -2337,10 +2337,16 @@ bool GtkSalGraphics::updateSettings(AllSettings& 
rSettings)
 style_context_set_state(pStyle, GTK_STATE_FLAG_PRELIGHT);
 style_context_get_color(pStyle, _color);
 aTextColor = getColor(text_color);
+aStyleSet.SetDefaultButtonTextColor(aTextColor);
 aStyleSet.SetDefaultButtonRolloverTextColor(aTextColor);
+aStyleSet.SetDefaultButtonPressedRolloverTextColor(aTextColor);
 aStyleSet.SetButtonRolloverTextColor(aTextColor);
 aStyleSet.SetDefaultActionButtonRolloverTextColor(aTextColor);
+aStyleSet.SetDefaultActionButtonPressedRolloverTextColor(aTextColor);
 aStyleSet.SetActionButtonRolloverTextColor(aTextColor);
+aStyleSet.SetActionButtonPressedRolloverTextColor(aTextColor);
+aStyleSet.SetFlatButtonTextColor(aTextColor);
+aStyleSet.SetFlatButtonPressedRolloverTextColor(aTextColor);
 aStyleSet.SetFlatButtonRolloverTextColor(aTextColor);
 aStyleSet.SetFieldRolloverTextColor(aTextColor);
 


[Libreoffice-bugs] [Bug 112237] Add the multiline tooltip on the Available Commands also to the Assigned Commands in the Customize dialog

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112237

--- Comment #20 from Jim Raykowski  ---
Hi All,

It's been a while since I posted code pointers for this and there has been no
takers. If there are no objections I'll take it. It's something that at times
I've found would be useful while hacking on LO. Sure, I can move the assigned
command back into the list of available commands and see the info in the
tooltip or description box, or search the commands xcu files, but, well, I
think it would be nice not to have to do that :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150863] after paste special unformatted text, Calc scrolls only visible rows

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150863

--- Comment #2 from Pierre Fortin  ---
Just downloaded the latest 7.5 a few minutes ago...  Here are the exact steps
to reproduce:

- opened new calc document
- entered      into cells A1 B1 C1 (default: Liberation Sans, 10pt)
- clicked on cell A1
- highlighted text in Input line
- middle-clicked on cell A2, pastes  -- A1 is still selected
- clicked on cell A2 (font = Noto Sans, 7.2pt) -- bug
- selected row 2
- changed font/size to Liberration Sans, 12pt -- A2 visible text does not
change

Bonus:  :)

- clicked on B1, Ctrl+C -- B1 is still Liberation Sans, 10pt
- clicked on B2, empty cell is Liberation Sans, 12pt
- Ctrl+V -- B2 = "" and is Liberation Sans, 10pt as expected
- select row 2
- changed font to Liberation Sans, 12pt
- B2 "" size visibly increases
- A2 "" does not change -- bug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149718] Writer Crashes on inserting a Chart based on a Table with merged cells

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149718

Hossein  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |hoss...@libreoffice.org
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151012] New: Msgbox Button parameter isn't optional

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151012

Bug ID: 151012
   Summary: Msgbox Button parameter isn't optional
   Product: LibreOffice
   Version: 7.4.1.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: pierre.tissend...@mailo.com

Version: 7.4.1.2 / LibreOffice Community
Build ID: 3c58a8f3a960df8bc8fd77b461821e42c061c5f0
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded

Hello,
Sorry but I don't find this bug in bugzilla

In LO 7.4 the Button parameter (2nd) of Msgbox function/instruction is no
longer optional

msgbox "hello" -> good
msgbox "hello",,"title" -> fail  ???
msgbox "hello",0,"title" -> good

thank you for your look.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151011] Simple subtraction fails with inaccurate result

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151011

h31...@gmail.com changed:

   What|Removed |Added

Summary|Simple subtraction fails|Simple subtraction fails
   |with wrong result   |with inaccurate result

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151011] New: Simple subtraction fails with wrong result

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151011

Bug ID: 151011
   Summary: Simple subtraction fails with wrong result
   Product: LibreOffice
   Version: 7.4.1.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: h31...@gmail.com

Description:
First installation of LibreOffice. Opened an ods sheet to find calculations
wrong at sub-pico UNIT level. Tested number of calculations in case it was the
file that was faulty.


Steps to Reproduce:
1.New CALC Sheet
2.In cell A1 enter 999.1
3.In cell B1 enter 999
4.In cell C1 enter =A1-B1
5.Set column C1 to optimum width OR Select cell C1 and view Average or Sum on
bottom status bar

Actual Results:
Contents of cell C1 = 0.123

Expected Results:
Contents of cell C1 = 0.1


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
[Information automatically included from LibreOffice]
Locale: en-GB
Module: SpreadsheetDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no

Version: 7.4.1.2 (x64) / LibreOffice Community
Build ID: 3c58a8f3a960df8bc8fd77b461821e42c061c5f0
CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: CL

New (first-time) installation. en-GB ver, Gaelic language additions, other
languages deselected.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151002] Confusing radio button placement in Text flow tab of Table Properties dialog

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151002

Rafael Lima  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 151002] Confusing radio button placement in Text flow tab of Table Properties dialog

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151002

Rafael Lima  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 151002] Confusing radio button placement in Text flow tab of Table Properties dialog

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151002

Rafael Lima  changed:

   What|Removed |Added

 CC||rafael.palma.l...@gmail.com

--- Comment #1 from Rafael Lima  ---
Created attachment 182512
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182512=edit
Screenshot of the Table Properties dialog

I tend to agree with the need to redesign the position of these radio buttons.

Let's hear from the UX team.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151009] Sorting, oCellRange.Sort(oSortDesc()), 3 columns by column#2 but column#3 sorted

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151009

Rafael Lima  changed:

   What|Removed |Added

  Component|Base|BASIC

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151009] Sorting, oCellRange.Sort(oSortDesc()), 3 columns by column#2 but column#3 sorted

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151009

Rafael Lima  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||rafael.palma.l...@gmail.com

--- Comment #1 from Rafael Lima  ---
Can you share a sample file with the data you used for testing as well as with
your implementation of the macro?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103342] [META] Font substitution bugs and enhancements

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103342
Bug 103342 depends on bug 151010, which changed state.

Bug 151010 Summary: Font substitution message should tell which font is being 
used
https://bugs.documentfoundation.org/show_bug.cgi?id=151010

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 61134] Font substitute name should appear in the font name combobox and in its tooltip

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=61134

Rafael Lima  changed:

   What|Removed |Added

 CC||rafael.palma.l...@gmail.com

--- Comment #15 from Rafael Lima  ---
*** Bug 151010 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151010] Font substitution message should tell which font is being used

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151010

Rafael Lima  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Rafael Lima  ---
(In reply to Aron Budea from comment #1)
> This looks like a dupe of bug 61134 to me. What do you think, Rafael?

You're right Aron. It is indeed a duplicate of bug 61134. I had done some
search but did not find this one.

I'm marking it as duplicate of bug 61134.

*** This bug has been marked as a duplicate of bug 61134 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 151010] Font substitution message should tell which font is being used

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151010

Rafael Lima  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Rafael Lima  ---
(In reply to Aron Budea from comment #1)
> This looks like a dupe of bug 61134 to me. What do you think, Rafael?

You're right Aron. It is indeed a duplicate of bug 61134. I had done some
search but did not find this one.

I'm marking it as duplicate of bug 61134.

*** This bug has been marked as a duplicate of bug 61134 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 151010] Font substitution message should tell which font is being used

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151010

Aron Budea  changed:

   What|Removed |Added

 CC||aron.bu...@gmail.com

--- Comment #1 from Aron Budea  ---
This looks like a dupe of bug 61134 to me. What do you think, Rafael?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 151010] Font substitution message should tell which font is being used

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151010

Aron Budea  changed:

   What|Removed |Added

 CC||aron.bu...@gmail.com

--- Comment #1 from Aron Budea  ---
This looks like a dupe of bug 61134 to me. What do you think, Rafael?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - vcl/headless vcl/inc vcl/source

2022-09-16 Thread Caolán McNamara (via logerrit)
 vcl/headless/svpgdi.cxx |9 +
 vcl/inc/headless/svpgdi.hxx |2 ++
 vcl/inc/image.h |6 --
 vcl/inc/salgdi.hxx  |8 
 vcl/source/gdi/salgdilayout.cxx |7 +++
 vcl/source/image/Image.cxx  |2 +-
 vcl/source/image/ImplImage.cxx  |   18 ++
 7 files changed, 41 insertions(+), 11 deletions(-)

New commits:
commit c062358d7b58ce3a9b27681040d854ec7ea1868b
Author: Caolán McNamara 
AuthorDate: Wed Sep 14 16:05:38 2022 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Fri Sep 16 22:56:49 2022 +0200

Resolves: tdf#144583 reuse lok hidpi icon scheme for gtk

and includes...

Related: tdf#144583 move current lok hidpi icon thing into SalGraphics

Change-Id: If34a2b15aebc5316783d72564ede23e02db04302
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139947
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index c97048dada12..322dab644f2a 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -51,6 +51,15 @@ void SvpSalGraphics::GetResolution( sal_Int32& rDPIX, 
sal_Int32& rDPIY )
 rDPIX = rDPIY = 96;
 }
 
+bool SvpSalGraphics::ShouldDownscaleIconsAtSurface(double* pScaleOut) const
+{
+if (comphelper::LibreOfficeKit::isActive())
+return SalGraphics::ShouldDownscaleIconsAtSurface(pScaleOut);
+if (pScaleOut)
+*pScaleOut = m_aCairoCommon.m_fScale;
+return true;
+}
+
 #if ENABLE_CAIRO_CANVAS
 bool SvpSalGraphics::SupportsCairo() const
 {
diff --git a/vcl/inc/headless/svpgdi.hxx b/vcl/inc/headless/svpgdi.hxx
index a63e7f289abf..1abc2b05f1f6 100644
--- a/vcl/inc/headless/svpgdi.hxx
+++ b/vcl/inc/headless/svpgdi.hxx
@@ -95,6 +95,8 @@ public:
 GetTextLayout(int nFallbackLevel) override;
 virtual voidDrawTextLayout( const GenericSalLayout& ) override;
 
+virtual boolShouldDownscaleIconsAtSurface(double* pScaleOut) 
const override;
+
 virtual SystemGraphicsData GetGraphicsData() const override;
 
 #if ENABLE_CAIRO_CANVAS
diff --git a/vcl/inc/image.h b/vcl/inc/image.h
index 633c38c4a34e..a6b51f30a5b0 100644
--- a/vcl/inc/image.h
+++ b/vcl/inc/image.h
@@ -22,6 +22,8 @@
 
 #include 
 
+class SalGraphics;
+
 class ImplImage
 {
 private:
@@ -36,7 +38,7 @@ private:
 BitmapEx maBitmapEx;
 BitmapEx maDisabledBitmapEx;
 
-bool loadStockAtScale(double fScale, BitmapEx );
+bool loadStockAtScale(SalGraphics* pGraphics, BitmapEx );
 
 public:
 ImplImage(const BitmapEx& rBitmapEx);
@@ -57,7 +59,7 @@ public:
 /// Legacy - the original bitmap
 BitmapEx const & getBitmapEx(bool bDisabled = false);
 /// Taking account of HiDPI scaling
-BitmapEx const & getBitmapExForHiDPI(bool bDisabled = false);
+BitmapEx const & getBitmapExForHiDPI(bool bDisabled, SalGraphics* 
pGraphics);
 
 bool isEqual(const ImplImage ) const;
 bool isSizeEmpty() const
diff --git a/vcl/inc/salgdi.hxx b/vcl/inc/salgdi.hxx
index 75938afecece..8679d4a0a062 100644
--- a/vcl/inc/salgdi.hxx
+++ b/vcl/inc/salgdi.hxx
@@ -452,6 +452,14 @@ public:
 
 virtual SystemGraphicsData  GetGraphicsData() const = 0;
 
+// Backends like the svp/gtk ones use cairo and hidpi scale at the surface
+// but bitmaps aren't hidpi, so if this returns true for the case that the
+// surface is hidpi then pScaleOut contains the scaling factor. So we can
+// create larger hires bitmaps which we know will be logically scaled down
+// by this factor but physically just copied
+virtual bool ShouldDownscaleIconsAtSurface(double* pScaleOut) const;
+
+
 #if ENABLE_CAIRO_CANVAS
 
 /// Check whether cairo will work
diff --git a/vcl/source/gdi/salgdilayout.cxx b/vcl/source/gdi/salgdilayout.cxx
index 623afed8c1c6..c557912d826c 100644
--- a/vcl/source/gdi/salgdilayout.cxx
+++ b/vcl/source/gdi/salgdilayout.cxx
@@ -1087,4 +1087,11 @@ void SalGraphics::FillFontSubsetInfo(const 
vcl::TTGlobalFontInfo& rTTInfo, const
 rInfo.m_nDescent = -rTTInfo.descender;
 }
 
+bool SalGraphics::ShouldDownscaleIconsAtSurface(double* pScaleOut) const
+{
+if (pScaleOut)
+*pScaleOut = comphelper::LibreOfficeKit::getDPIScale();
+return comphelper::LibreOfficeKit::isActive();
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/source/image/Image.cxx b/vcl/source/image/Image.cxx
index e32f7e54df22..2b0a9521c8c1 100644
--- a/vcl/source/image/Image.cxx
+++ b/vcl/source/image/Image.cxx
@@ -120,7 +120,7 @@ void Image::Draw(OutputDevice* pOutDev, const Point& rPos, 
DrawImageFlags nStyle
 
 Size aOutSize = pSize ? *pSize : 
pOutDev->PixelToLogic(mpImplData->getSizePixel());
 
-BitmapEx aRenderBmp = mpImplData->getBitmapExForHiDPI(bool(nStyle & 
DrawImageFlags::Disable));
+BitmapEx aRenderBmp = mpImplData->getBitmapExForHiDPI(bool(nStyle & 
DrawImageFlags::Disable), 

[Libreoffice-bugs] [Bug 144583] Blurry icon on HiDPI

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144583

--- Comment #16 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/c062358d7b58ce3a9b27681040d854ec7ea1868b

Resolves: tdf#144583 reuse lok hidpi icon scheme for gtk

It will be available in 7.4.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144583] Blurry icon on HiDPI

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144583

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.5.0|target:7.5.0 target:7.4.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151010] Font substitution message should tell which font is being used

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151010

Rafael Lima  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 151010] Font substitution message should tell which font is being used

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151010

Rafael Lima  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 103342] [META] Font substitution bugs and enhancements

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103342

Rafael Lima  changed:

   What|Removed |Added

 Depends on||151010


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=151010
[Bug 151010] Font substitution message should tell which font is being used
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151010] Font substitution message should tell which font is being used

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151010

Rafael Lima  changed:

   What|Removed |Added

 Blocks||103342


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103342
[Bug 103342] [META] Font substitution bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151010] New: Font substitution message should tell which font is being used

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151010

Bug ID: 151010
   Summary: Font substitution message should tell which font is
being used
   Product: LibreOffice
   Version: 7.3.5.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rafael.palma.l...@gmail.com

Created attachment 182511
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182511=edit
Current tooltip for font substitution

When a font is being substituted in the document, the tooltip that informs this
situation in the UI should tell which font is being used in its place.

For instance, in the attached image the tooltip says:

"The current font is not available and will be substituted."

However, by which font is it being substituted? What font is actually being
used?

Hence, I would like to propose that this tooltip is changed to:

"The current font is not available and was substituted by ."

Where  is the name of the actual font being used. Also, I think that it
makes more sense to write the sentence in the past tense (note the "was" in the
new tooltip in contrast with "will" in the current one).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151009] New: Sorting, oCellRange.Sort(oSortDesc()), 3 columns by column#2 but column#3 sorted

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151009

Bug ID: 151009
   Summary: Sorting, oCellRange.Sort(oSortDesc()), 3 columns by
column#2 but column#3 sorted
   Product: LibreOffice
   Version: 7.3.2.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: nalong...@sbcglobal.net

Description:
Column#1 & 2 are numeric, column#3 alphanumeric. When sorting by column#2 using
a sort range of the 3 coulumns, column#3 is sorted. If the sort range is 2
columns, column2 is sorted.

Steps to Reproduce:
1.Create table with 3 columns, #1 numeric, #2 numeric and #3 alphanumeric in
columns D, E & C
2.Create macro using https://wiki.documentfoundation.org/Macros/Calc/ba023
3.Set oSortFields(0).Field = 4 rem column E
run macro

Actual Results:
5   4   A
1   5   B
2   1   C
3   2   D
4   3   E



Expected Results:
2   1   C
3   2   D
4   3   E
5   4   A
1   5   B



Reproducible: Always


User Profile Reset: No



Additional Info:
If you put the same data in columns A, B & C, the expected results are
obtained!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150996] [XLSX] Cell colors and number formats are not imported by LibreOffice

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150996

Rafael Lima  changed:

   What|Removed |Added

Summary|FORMATTING shows in excel   |[XLSX] Cell colors and
   |but not in libreoffice  |number formats are not
   ||imported by LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150996] FORMATTING shows in excel but not in libreoffice

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150996

--- Comment #3 from Rafael Lima  ---
Created attachment 182510
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182510=edit
Screenshot showing the problem

Here's a screenshot showing the differences between LO and MSO.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - oox/source vcl/qa vcl/source

2022-09-16 Thread Sarper Akdemir (via logerrit)
 oox/source/drawingml/fillproperties.cxx |   24 
 vcl/qa/cppunit/GraphicTest.cxx  |   33 
 vcl/qa/cppunit/data/testColorChange-red-linear-gradient.png |binary
 vcl/source/graphic/UnoGraphic.cxx   |4 -
 4 files changed, 58 insertions(+), 3 deletions(-)

New commits:
commit 448fd8c392edd5e632eaaacecff823189c7c8376
Author: Sarper Akdemir 
AuthorDate: Thu Sep 1 14:59:51 2022 +0300
Commit: Andras Timar 
CommitDate: Fri Sep 16 22:39:02 2022 +0200

tdf#149670 fix color change api and adjust tolerance for ooxml

It appears at the start of Graphic::colorChange aBmpColorFrom &
aBmpColorTo gets initialized with wrong colors. Instead of {R,G,B},
they get initialized with {B,G,R}.

Instead of bitshifting use the ::Color constructor so that it is
initialized correctly.

For ooxml import adapt tolerance values of the image format in an
attempt to get similar results on how the results appear in
PowerPoint.

Change-Id: I1fa901691512de82936dba0e47158b7e0ca2223e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139203
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 
(cherry picked from commit 2b902b6203a87bdca7856e17a9c0fcc403de4264)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139421
Reviewed-by: Xisco Fauli 
(cherry picked from commit de325e4b603d6b57fa6b46021a1b4c83e2d44e82)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139673
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 

diff --git a/oox/source/drawingml/fillproperties.cxx 
b/oox/source/drawingml/fillproperties.cxx
index 0ef86bc75f5c..3fb6b4ca372e 100644
--- a/oox/source/drawingml/fillproperties.cxx
+++ b/oox/source/drawingml/fillproperties.cxx
@@ -197,9 +197,31 @@ Reference< XGraphic > 
lclCheckAndApplyChangeColorTransform(const BlipFillPropert
 sal_Int16 nToTransparence = 
aBlipProps.maColorChangeTo.getTransparency();
 sal_Int8 nToAlpha = static_cast< sal_Int8 >( (100 - 
nToTransparence) * 2.55 );
 
+sal_uInt8 nTolerance = 9;
+Graphic aGraphic{ xGraphic };
+if( aGraphic.IsGfxLink() )
+{
+// tdf#149670: Try to guess tolerance depending on image format
+switch (aGraphic.GetGfxLink().GetType())
+{
+case GfxLinkType::NativeJpg:
+nTolerance = 15;
+break;
+case GfxLinkType::NativePng:
+case GfxLinkType::NativeTif:
+nTolerance = 1;
+break;
+case GfxLinkType::NativeBmp:
+nTolerance = 0;
+break;
+default:
+break;
+}
+}
+
 uno::Reference 
xTransformer(aBlipProps.mxFillGraphic, uno::UNO_QUERY);
 if (xTransformer.is())
-return xTransformer->colorChange(xGraphic, 
sal_Int32(nFromColor), 9, sal_Int32(nToColor), nToAlpha);
+return xTransformer->colorChange(xGraphic, 
sal_Int32(nFromColor), nTolerance, sal_Int32(nToColor), nToAlpha);
 }
 }
 return xGraphic;
diff --git a/vcl/qa/cppunit/GraphicTest.cxx b/vcl/qa/cppunit/GraphicTest.cxx
index 2e398c544c79..40fb316bd93e 100644
--- a/vcl/qa/cppunit/GraphicTest.cxx
+++ b/vcl/qa/cppunit/GraphicTest.cxx
@@ -9,6 +9,8 @@
 
 #include 
 #include 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -84,6 +86,7 @@ private:
 void testLoadWEBP();
 
 void testAvailableThreaded();
+void testColorChangeToTransparent();
 
 CPPUNIT_TEST_SUITE(GraphicTest);
 CPPUNIT_TEST(testUnloadedGraphic);
@@ -122,6 +125,7 @@ private:
 CPPUNIT_TEST(testLoadWEBP);
 
 CPPUNIT_TEST(testAvailableThreaded);
+CPPUNIT_TEST(testColorChangeToTransparent);
 
 CPPUNIT_TEST_SUITE_END();
 };
@@ -1344,6 +1348,35 @@ void GraphicTest::testAvailableThreaded()
 }
 }
 
+void GraphicTest::testColorChangeToTransparent()
+{
+Graphic aGraphic = 
importUnloadedGraphic(u"testColorChange-red-linear-gradient.png");
+
+auto xGraphic = aGraphic.GetXGraphic();
+uno::Reference xGraphicTransformer{ 
xGraphic, uno::UNO_QUERY };
+::Color nColorFrom{ ColorTransparency, 0x00, 0xFF, 0x00, 0x00 };
+::Color nColorTo{ ColorTransparency, 0xFF, 0xFF, 0x00, 0x00 };
+sal_uInt8 nTolerance{ 15 };
+
+auto xGraphicAfter = xGraphicTransformer->colorChange(
+xGraphic, static_cast(nColorFrom), nTolerance, 
static_cast(nColorTo),
+static_cast(nColorTo.GetAlpha()));
+
+Graphic aGraphicAfter{ xGraphicAfter };
+const BitmapEx& rBitmapAfter = aGraphicAfter.GetBitmapExRef();
+const BitmapEx& rBitmapBefore = aGraphic.GetBitmapExRef();
+// Without the accompanying fix in place, this test would have failed with:
+

[Libreoffice-bugs] [Bug 150996] FORMATTING shows in excel but not in libreoffice

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150996

Rafael Lima  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
   Keywords||filter:xlsx

--- Comment #2 from Rafael Lima  ---
Repro with

Version: 7.4.1.2 / LibreOffice Community
Build ID: 40(Build:2)
CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Ubuntu package version: 1:7.4.1~rc2-0ubuntu0.22.04.1~lo1
Calc: threaded

Colors in columns "F" to "I" as well as in the first row in columns "J" to "O"
were not imported.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151008] New: FILEOPEN PPTX text in shape has wrong anchor if text direction is tb-rl (eaVert)

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151008

Bug ID: 151008
   Summary: FILEOPEN PPTX text in shape has wrong anchor if text
direction is tb-rl (eaVert)
   Product: LibreOffice
   Version: 7.5.0.0 alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Created attachment 182509
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182509=edit
all six kind of anchoring

Open attached document. It has on the first slide the six cases of anchoring
available in PowerPoint. The second slide contains an image of how it looks in
PowerPoint. There is no wrap in the examples to force the text to overflow and
so make the anchor position better visible.

The text direction tb-rl is not rendered by text rotation but is a native
writing mode of the edit engine. Therefore anchor position needs special
treatment on import and export.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150971] Emoji in Drop Caps have wrong margins

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150971

Rafael Lima  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150971] Emoji in Drop Caps have wrong margins

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150971

--- Comment #4 from Rafael Lima  ---
Created attachment 182508
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182508=edit
Screenshot showing the problem

Here's a screenshot of what I see.

I'm setting this to NEW.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150971] Emoji in Drop Caps have wrong margins

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150971

--- Comment #3 from Rafael Lima  ---
Created attachment 182507
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182507=edit
Sample file with emoji in drop caps

In this file I used an Emoji in Drop caps and indeed it is not correctly
aligned.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150975] invoking navigation pane summons a second undockable pane, leading to confusion

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150975

--- Comment #5 from Rafael Lima  ---
Created attachment 182506
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182506=edit
Video showing how to dock the Navigator

Here's a video of how I dock the Navigator. Notice where I double-click. It has
to be in an empty part of the window.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 122457] Worse text rendering in newer versions of LibreOffice (OpenGL)

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122457
Bug 122457 depends on bug 107521, which changed state.

Bug 107521 Summary: Improve DirectWrite implementation font rendering on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=107521

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 109234] [META] DirectWrite rendering bugs and enhancements

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109234
Bug 109234 depends on bug 107521, which changed state.

Bug 107521 Summary: Improve DirectWrite implementation font rendering on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=107521

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=71732
Bug 71732 depends on bug 107521, which changed state.

Bug 107521 Summary: Improve DirectWrite implementation font rendering on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=107521

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107521] Improve DirectWrite implementation font rendering on Windows

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107521

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #26 from V Stuart Foote  ---
(In reply to Roman Kuznetsov from comment #25)
> 
> V Stuart Foote, could you retest it now yourself in latest dev build?

Luboš purged most of the OpenGL related code as Skia lib based rendering was
implemented. And Caolán, Chris and Khaled have done a fair bit of refactoring
for winlayout and sallayout with end result that checking side-by-side on
current Windows build master the Skia rendering (raster or Vulkan accelerated)
antialiasing is now bit for bit identical with the GDI+ "default" vcl
rendering.  And where we seem to be using more of the DirectWrite 2D functions
for the GDI+ paths as well.

So, I'm OK closing this WFM as the potential for FreeType everywhere seems kind
of unlikely to ever occur.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150974] Writer crashes when starting with WollMux installed

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150974

Caolán McNamara  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #5 from Caolán McNamara  ---
Added another place that asserted and there's a backport to 7-4 in gerrit.
Probably best to fix the extension if possible to not do the odd add empty
listener thing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150974] Writer crashes when starting with WollMux installed

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150974

--- Comment #4 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a3bbdfab809609bec3475613a918eda699fbdc29

tdf#150974 Writer crashes when starting with WollMux installed

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150974] Writer crashes when starting with WollMux installed

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150974

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: toolkit/source

2022-09-16 Thread Noel Grandin (via logerrit)
 toolkit/source/controls/unocontrols.cxx |   26 ++
 1 file changed, 26 insertions(+)

New commits:
commit a3bbdfab809609bec3475613a918eda699fbdc29
Author: Noel Grandin 
AuthorDate: Fri Sep 16 16:05:30 2022 +0200
Commit: Caolán McNamara 
CommitDate: Fri Sep 16 22:14:07 2022 +0200

tdf#150974 Writer crashes when starting with WollMux installed

regression from
commit b2aa646ef09dc8434d3ca8a5bba53a8d8ff3f910
Author: Caolán McNamara 
Date:   Wed Dec 15 11:43:32 2021 +
use more OInterfaceContainerHelper3 in toolkit

Change-Id: I26532ea79b7c5f750b4bf693881cbf41aeb82266
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140077
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/toolkit/source/controls/unocontrols.cxx 
b/toolkit/source/controls/unocontrols.cxx
index 3bc095cf3f03..84fe8ce50774 100644
--- a/toolkit/source/controls/unocontrols.cxx
+++ b/toolkit/source/controls/unocontrols.cxx
@@ -270,11 +270,23 @@ void UnoEditControl::textChanged(const awt::TextEvent& e)
 
 void UnoEditControl::addTextListener(const uno::Reference< awt::XTextListener 
> & l)
 {
+// tdf#150974 some extensions pass null
+if (!l)
+{
+SAL_WARN("toolkit", "null XTextListener");
+return;
+}
 maTextListeners.addInterface( l );
 }
 
 void UnoEditControl::removeTextListener(const uno::Reference< 
awt::XTextListener > & l)
 {
+// tdf#150974 some extensions pass null
+if (!l)
+{
+SAL_WARN("toolkit", "null XTextListener");
+return;
+}
 maTextListeners.removeInterface( l );
 }
 
@@ -767,6 +779,13 @@ void UnoButtonControl::createPeer( const uno::Reference< 
awt::XToolkit > & rxToo
 
 void UnoButtonControl::addActionListener(const uno::Reference< 
awt::XActionListener > & l)
 {
+// tdf#150974 some extensions pass null
+if (!l)
+{
+SAL_WARN("toolkit", "null XActionListener");
+return;
+}
+
 maActionListeners.addInterface( l );
 if( getPeer().is() && maActionListeners.getLength() == 1 )
 {
@@ -777,6 +796,13 @@ void UnoButtonControl::addActionListener(const 
uno::Reference< awt::XActionListe
 
 void UnoButtonControl::removeActionListener(const uno::Reference< 
awt::XActionListener > & l)
 {
+// tdf#150974 some extensions pass null
+if (!l)
+{
+SAL_WARN("toolkit", "null XActionListener");
+return;
+}
+
 if( getPeer().is() && maActionListeners.getLength() == 1 )
 {
 uno::Reference < awt::XButton >  xButton( getPeer(), uno::UNO_QUERY );


[Libreoffice-commits] core.git: 2 commits - sw/source

2022-09-16 Thread Jim Raykowski (via logerrit)
 sw/source/uibase/utlui/content.cxx |8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

New commits:
commit d87e1859cbd41a623f48a9522507ab0adc8e7324
Author: Jim Raykowski 
AuthorDate: Thu Sep 15 14:20:23 2022 -0800
Commit: Jim Raykowski 
CommitDate: Fri Sep 16 22:11:26 2022 +0200

SwNavigator: Make Drawing objects context menu entry 'Edit..' edit

This patch uses SwEditWin::KeyInput handling of KEY_RETURN for the
Drawing objects context menu entry 'Edit...' which moves focus of the
selected drawing object into the text box of the drawing object.
Previous to this patch the 'Edit...' menu entry would select the
drawing object the same as the 'Go to' menu entry.

Change-Id: I4d6d278e25badd086dc718c4c7ea02ce6330a45d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140037
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sw/source/uibase/utlui/content.cxx 
b/sw/source/uibase/utlui/content.cxx
index 2dfc91fbfdf1..68b77a6d9249 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -5110,6 +5110,12 @@ void SwContentTree::EditEntry(const weld::TreeIter& 
rEntry, EditEntryMode nMode)
 nSlot = SID_DELETE;
 else if(nMode == EditEntryMode::RENAME)
 nSlot = FN_NAME_SHAPE;
+else if (nMode == EditEntryMode::EDIT)
+{
+vcl::KeyCode aKeyCode(KEY_RETURN, false, false, false, false);
+KeyEvent aKeyEvent(0, aKeyCode);
+m_pActiveShell->GetWin()->KeyInput(aKeyEvent);
+}
 break;
 case ContentTypeId::FOOTNOTE:
 case ContentTypeId::ENDNOTE:
commit a5eb6660ed85afb706527704e1170a35e0677cf8
Author: Caolán McNamara 
AuthorDate: Fri Sep 16 16:33:05 2022 +0100
Commit: Caolán McNamara 
CommitDate: Fri Sep 16 22:11:13 2022 +0200

cid#1514676 perturb mysterious Logically dead code warning

throw a const at it

Change-Id: I273c85329765e1655cfde9efdf5422e5bb90ee57
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140082
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/uibase/utlui/content.cxx 
b/sw/source/uibase/utlui/content.cxx
index 55e51b52d51b..2dfc91fbfdf1 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -1878,7 +1878,7 @@ IMPL_LINK(SwContentTree, CommandHdl, const CommandEvent&, 
rCEvt, bool)
 if (bRemoveDeleteFieldEntry)
 xPop->remove("deletefield");
 
-bool bRemoveDeleteEntry =
+const bool bRemoveDeleteEntry =
 bRemoveDeleteChapterEntry ||
 bRemoveDeleteTableEntry ||
 bRemoveDeleteFrameEntry ||


[Libreoffice-bugs] [Bug 150975] invoking navigation pane summons a second undockable pane, leading to confusion

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150975

--- Comment #4 from Rafael Lima  ---
(In reply to Aleix from comment #2)
> However, I am still confused about having 2 navigators. Why calling F5 does
> not make the one in the side pane to expand? 

I too do not understand what's the use of having 2 navigators. Maybe it's a
legacy feature and many users still like to have a floating navigator without
having to undock the entire sidebar for that.

(In reply to Aleix from comment #2)
> Regarding the navigator pane called by F5: in my case, it won't dock in any
> way (either ctrl + doubleclick on empty space, nor ctrl+shift+F10, nor
> dradding it with the titlebar close to the main window side). So perhaps it
> is a docking issue specific in my case. 

This is weird. I've just tried using gtk3 backend and Ctrl+double-click did
work to dock the navigator to the left.

Make sure you're double-clicking in the right place. It has to be in an empty
position of the navigator.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/source

2022-09-16 Thread Jim Raykowski (via logerrit)
 sw/source/uibase/shells/drwbassh.cxx |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit dced115279b953735040663f71a2e848762672d7
Author: Jim Raykowski 
AuthorDate: Thu Sep 15 12:12:31 2022 -0800
Commit: Jim Raykowski 
CommitDate: Fri Sep 16 22:08:20 2022 +0200

tdf#150589 Set cursor to better position after deleting a drawing

object

Cutting a drawing object involves SwWrtShell::DelRight which uses the
drawing object's frame top-left point to set the cursor after
deleting. Delete and Backspace do not use SwWrtShell::DelRight to
delete a drawing object. This patch makes Delete and Backspace
position the cursor like Cut after drawing object delete.

Change-Id: I6dc07eccc8397393a230368a20b0589e6d57a89a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140036
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sw/source/uibase/shells/drwbassh.cxx 
b/sw/source/uibase/shells/drwbassh.cxx
index 766ca0ae81bb..71c66a046e7d 100644
--- a/sw/source/uibase/shells/drwbassh.cxx
+++ b/sw/source/uibase/shells/drwbassh.cxx
@@ -374,6 +374,8 @@ void SwDrawBaseShell::Execute(SfxRequest const )
 {
 bDone = true;
 
+const Point aPt = pSh->GetObjRect().TopLeft(); // tdf#150589
+
 if( GetView().IsDrawRotate() )
 {
 pSh->SetDragMode( SdrDragMode::Move );
@@ -399,8 +401,10 @@ void SwDrawBaseShell::Execute(SfxRequest const )
 if (pSh->IsSelFrameMode())
 {
 pSh->LeaveSelFrameMode();
-// #105852# FME
+// #105852# FME <- perhaps fixed by tdf#150589
+static_cast(pSh)->SetCursor(aPt);
 }
+
 }
 break;
 


[Libreoffice-commits] core.git: sc/source

2022-09-16 Thread Caolán McNamara (via logerrit)
 sc/source/core/data/table6.cxx |5 +
 1 file changed, 5 insertions(+)

New commits:
commit c690d7c3d49d887fab85f8040fa91965b4ab2781
Author: Caolán McNamara 
AuthorDate: Fri Sep 16 16:06:31 2022 +0100
Commit: Caolán McNamara 
CommitDate: Fri Sep 16 22:07:50 2022 +0200

cid#1513720 silence Improper use of negative value

negative col doesn't seem to arise in this branch, seems it can only
negative for the other direction and/or for styles which isn't handled
in this method.

Change-Id: I3a50ebef57a84e808a03fc677030acfd7605230d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140078
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/core/data/table6.cxx b/sc/source/core/data/table6.cxx
index 1915ad7c1588..1f0fc1efbf3d 100644
--- a/sc/source/core/data/table6.cxx
+++ b/sc/source/core/data/table6.cxx
@@ -482,6 +482,11 @@ bool ScTable::Search(const SvxSearchItem& rSearchItem, 
SCCOL& rCol, SCROW& rRow,
 if (bSkipFiltered)
 SkipFilteredRows(nRow, nLastNonFilteredRow, true);
 
+// GetSearchAndReplaceStart sets a nCol of -1 for
+// ColDirection() only if rSearchItem.GetPattern() is true,
+// so a negative column shouldn't be possible here.
+assert(nCol >= 0 && "negative nCol for ColDirection");
+
 bFound = SearchCell(rSearchItem, nCol, blockPos[ nCol ],
 nRow, rMark, rUndoStr, pUndoDoc);
 if (!bFound)


[Libreoffice-commits] core.git: connectivity/source

2022-09-16 Thread Caolán McNamara (via logerrit)
 connectivity/source/parse/sqlnode.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit bb1f2894e40881abcfcb0372b2b3c8fae5b8cd6d
Author: Caolán McNamara 
AuthorDate: Fri Sep 16 16:12:50 2022 +0100
Commit: Caolán McNamara 
CommitDate: Fri Sep 16 22:07:28 2022 +0200

OSL_ENSURE->assert where we would crash if not true

Change-Id: I1544573ea9f57b5ca732c9b05acae9b4f91f53ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140080
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/connectivity/source/parse/sqlnode.cxx 
b/connectivity/source/parse/sqlnode.cxx
index bd6853ecd1ee..f9bee9da69b6 100644
--- a/connectivity/source/parse/sqlnode.cxx
+++ b/connectivity/source/parse/sqlnode.cxx
@@ -2355,7 +2355,7 @@ void OSQLParseNode::showParseTree( OUStringBuffer& 
_inout_rBuffer, sal_uInt32 nL
 
 void OSQLParseNode::insert(sal_uInt32 nPos, OSQLParseNode* pNewSubTree)
 {
-OSL_ENSURE(pNewSubTree != nullptr, "OSQLParseNode: invalid NewSubTree");
+assert(pNewSubTree != nullptr && "OSQLParseNode: invalid NewSubTree");
 OSL_ENSURE(pNewSubTree->getParent() == nullptr, "OSQLParseNode: Node is 
not an orphan");
 
 // Create connection to getParent
@@ -2367,7 +2367,7 @@ void OSQLParseNode::insert(sal_uInt32 nPos, 
OSQLParseNode* pNewSubTree)
 
 OSQLParseNode* OSQLParseNode::removeAt(sal_uInt32 nPos)
 {
-OSL_ENSURE(nPos < m_aChildren.size(),"Illegal position for removeAt");
+assert(nPos < m_aChildren.size() && "Illegal position for removeAt");
 auto aPos(m_aChildren.begin() + nPos);
 auto pNode = std::move(*aPos);
 
@@ -2382,7 +2382,7 @@ OSQLParseNode* OSQLParseNode::removeAt(sal_uInt32 nPos)
 
 OSQLParseNode* OSQLParseNode::replace(OSQLParseNode* pOldSubNode, 
OSQLParseNode* pNewSubNode )
 {
-OSL_ENSURE(pOldSubNode != nullptr && pNewSubNode != nullptr, 
"OSQLParseNode: invalid nodes");
+assert(pOldSubNode != nullptr && pNewSubNode != nullptr && "OSQLParseNode: 
invalid nodes");
 OSL_ENSURE(pNewSubNode->getParent() == nullptr, "OSQLParseNode: node 
already has getParent");
 OSL_ENSURE(std::any_of(m_aChildren.begin(), m_aChildren.end(),
[&] (std::unique_ptr const & r) { return 
r.get() == pOldSubNode; }),


[Libreoffice-bugs] [Bug 145734] [META] Qt6 VCL plugin bugs and enhancements

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145734

--- Comment #8 from Timur  ---
In the last case (if I remember well)  soffice starts but with light gtk3 and
not dark qt5. So I didn't figure out how to use QT_QPA_PLATFORM.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150820] Can't open file named in non latin languages

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150820

--- Comment #26 from Eyal Rozenberg  ---
I wonder, though... could we possibly detect cases where it is _likely_ that
this is what's happening (e.g. getting an empty filename, getting a filename
with stand-in characters, or spaces, etc.) and give a more verbose warning
suggesting this may be the cause of the problem?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151007] When opening a CSV file, default to CSV-spec-compliant options

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151007

Eyal Rozenberg  changed:

   What|Removed |Added

Summary|When opening a CSV file,|When opening a CSV file,
   |default to CSV spec |default to
   ||CSV-spec-compliant options

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149718] Writer Crashes on inserting a Chart based on a Table with merged cells

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149718

--- Comment #6 from Hossein  ---
Note: You have to select more than 1 cell with data (For example, all the cells
that contain numbers 1 to 5), and then choose "Insert" > "Chart" to reproduce
the crash.

Not reproducible with: OOo 3.2

OpenOffice.org 3.2.1 (Build:9502)
https://ftp5.gwdg.de/pub/openoffice/archive/stable/3.2.1/


Reproduced with LO 3.5

LibreOffice 3.5.0rc3 
Build ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735
https://downloadarchive.documentfoundation.org/libreoffice/old/3.5.0.3/
It crashes after a small delay, giving this message:
terminate called after throwing an instance of
'com::sun::star::lang::IllegalArgumentException'


Reproduced with LO 7.2:

Version: 7.2.4.1 / LibreOffice Community
Build ID: 27d75539669ac387bb498e35313b970b7fe9c4f9
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded


Also with the latest LO 7.5 dev master:

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 164a1f4c3315fc44161128d3d9ca886f767f7d30
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151007] When opening a CSV file, default to CSV spec

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151007

Eyal Rozenberg  changed:

   What|Removed |Added

 Whiteboard||needsUXAdvice

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151007] New: When opening a CSV file, default to CSV spec

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151007

Bug ID: 151007
   Summary: When opening a CSV file, default to CSV spec
   Product: LibreOffice
   Version: 6.0 all versions
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyalr...@gmx.com

Currently, when opening a CSV file, the parsing dialog has its options set to
(IIANM) the last settings for parsing any textual data.

Instead, when opening a CSV file (that is, with a ".csv" extension or with a
"text/csv" MIME type) - the settings should correspond to the CSV spec, in RFC
4180. So, for example, only a comma separates records, and the string delimiter
is double-quotes (").

The _second_ a later times the same CSV file is opened, this may be relaxed to
the previous settings for that file, but perhaps that's a separate bug, so
let's start with just the default.

Settings which are orthogonal to the CSV spec should behave... actually, I'm
not entirely sure what to recommend here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left and Complex Text Layout language issues (RTL/CTL)

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=43808
Bug 43808 depends on bug 150820, which changed state.

Bug 150820 Summary: Can't open file named in non latin languages
https://bugs.documentfoundation.org/show_bug.cgi?id=150820

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150820] Can't open file named in non latin languages

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150820

medmedin2014  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |NOTABUG

--- Comment #25 from medmedin2014  ---
(In reply to Hossein from comment #23)

> On the other hand, somehow similar problem was happening when setting the
> locale to  C, but with a different error message: "The operation on ... was
> started with an invalid parameter."

After opening "/etc/locale.gen" I found that my previous selected entry
"en_US.UTF-8 UTF-8" was disabled (commented), I don't how it ended like that,
may be due to last upgrades it was reset to that configuration without
prompting. After enabling that entry and rerun "sudo locale-gen" on terminal
all worked again like it was before. Thanks for your precious help.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151004] When closed in maximized state LibO 7.4 applications are then reopened with windows that are as small as possible (kf5 only)

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151004

Rafael Lima  changed:

   What|Removed |Added

Summary|When closed in maximized|When closed in maximized
   |state, LibO 7.4 |state LibO 7.4 applications
   |applications are then   |are then reopened with
   |reopened with windows that  |windows that are as small
   |are as small as possible|as possible (kf5 only)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 79654] Save XLSX consumes 100% memory and hangs with "bad allocation" (scfiltlo.dll)

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=79654

Julien Nabet  changed:

   What|Removed |Added

 CC||noelgran...@gmail.com

--- Comment #20 from Julien Nabet  ---
Taking a look at the Flamegraph, I noticed
mxCellTable = new XclExpCellTable( GetRoot() );
(see
https://opengrok.libreoffice.org/xref/core/sc/source/filter/excel/excdoc.cxx?r=1d25d32b#564).

The ctr of XclExpCellTable does quite a lot of things.

First I thought using a mere singleton but since the finalization seems to
modify the state of the object, I think we rather need to make copies of the
singleton (which corresponds to the original state).

Any thoughts here?

(BTW, there's the equivalent in ExcTable::FillAsTableBinary).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102495

Rafael Lima  changed:

   What|Removed |Added

 Depends on||151004


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=151004
[Bug 151004] When closed in maximized state, LibO 7.4 applications are then
reopened with windows that are as small as possible
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151004] When closed in maximized state, LibO 7.4 applications are then reopened with windows that are as small as possible

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151004

Rafael Lima  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW
 Blocks||102495

--- Comment #2 from Rafael Lima  ---
Now that I read again your ticket, as well as the KDE ticket, I see that it is
the same issue.

I'm setting this to NEW and marking it as kf5-only.

However, I feel this may be Kwin to blame?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102495
[Bug 102495] [META] KDE VCL backend bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151004] When closed in maximized state, LibO 7.4 applications are then reopened with windows that are as small as possible

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151004

Rafael Lima  changed:

   What|Removed |Added

Version|7.2.4.1 release |7.4.1.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151004] When closed in maximized state, LibO 7.4 applications are then reopened with windows that are as small as possible

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151004

Rafael Lima  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from Rafael Lima  ---
I started having this problem right after the update to LibreOffice 7.4.1 in
KDE Plasma (Kubuntu 22.04). It seems that some setting in the user profile is
causing the window to have a minimal size and be located at the top-left side
of the screen.

If you manually resize the window and close the application (f.i. Writer), and
then open it again, the previous size will be remembered.

But if you maximize the window and then close it, the next time you open Writer
it will be again in a minuscule size at the top-left corner of the screen.

Can you confirm that this is what you're experiencing?

My system info:

Version: 7.4.1.2 / LibreOffice Community
Build ID: 40(Build:2)
CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Ubuntu package version: 1:7.4.1~rc2-0ubuntu0.22.04.1~lo1
Calc: threaded

Interestingly, this issue is not happening with the master build (7.5 alpha)
that I have installed in the same machine.

This may be a kf5-only bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-4' - ucb/source

2022-09-16 Thread Michael Stahl (via logerrit)
 ucb/source/ucp/webdav-curl/CurlSession.cxx   |   38 +--
 ucb/source/ucp/webdav-curl/ImportCookies.cxx |   19 +
 2 files changed, 38 insertions(+), 19 deletions(-)

New commits:
commit 23ff13457247e4457817b3e2dc24d99fc8703f9d
Author: Michael Stahl 
AuthorDate: Fri Sep 16 21:25:50 2022 +0200
Commit: Michael Stahl 
CommitDate: Fri Sep 16 21:25:50 2022 +0200

ucb: webdav-curl: tweak cookie import

Improve error handling/logging, and do it only if the error code
0x000E0098 is received.

Change-Id: I47dada2ef08b21a43cdfa3db9eb2fcdb4043a04f

diff --git a/ucb/source/ucp/webdav-curl/CurlSession.cxx 
b/ucb/source/ucp/webdav-curl/CurlSession.cxx
index 066ad2d2feb9..cc0a2368784f 100644
--- a/ucb/source/ucp/webdav-curl/CurlSession.cxx
+++ b/ucb/source/ucp/webdav-curl/CurlSession.cxx
@@ -707,19 +707,6 @@ 
CurlSession::CurlSession(uno::Reference const& xContext,
 rc = curl_easy_setopt(m_pCurl.get(), CURLOPT_FORBID_REUSE, 1L);
 assert(rc == CURLE_OK);
 }
-#ifdef _WIN32
-if (m_URI.GetScheme() == "https")
-{
-OString const cookies(TryImportCookies(m_xContext, m_URI.GetHost()));
-if (!cookies.isEmpty())
-{
-rc = curl_easy_setopt(m_pCurl.get(), CURLOPT_COOKIEFILE, "");
-assert(rc == CURLE_OK);
-rc = curl_easy_setopt(m_pCurl.get(), CURLOPT_COOKIE, 
cookies.getStr());
-assert(rc == CURLE_OK);
-}
-}
-#endif
 }
 
 CurlSession::~CurlSession() {}
@@ -1247,6 +1234,7 @@ auto CurlProcessor::ProcessRequest(
 bool isRetry(false);
 int nAuthRequests(0);
 int nAuthRequestsProxy(0);
+OString cookies;
 
 // libcurl does not have an authentication callback so handle auth
 // related status codes and requesting credentials via this loop
@@ -1386,6 +1374,30 @@ auto CurlProcessor::ProcessRequest(
 }
 break;
 }
+case SC_FORBIDDEN:
+{
+::std::map const headerMap(
+ProcessHeaders(headers.HeaderFields.back().first));
+// X-MSDAVEXT_Error see [MS-WEBDAVE] 2.2.3.1.9
+auto const it(headerMap.find("x-msdavext_error"));
+if (cookies.isEmpty() // retry only once - could be 
expired...
+&& rSession.m_URI.GetScheme() == "https" // only 
encrypted
+&& it != headerMap.end()
+&& it->second.startsWith("917656;"))
+{
+cookies = TryImportCookies(rSession.m_xContext, 
rSession.m_URI.GetHost());
+if (!cookies.isEmpty())
+{
+CURLcode rc = 
curl_easy_setopt(rSession.m_pCurl.get(), CURLOPT_COOKIEFILE, "");
+assert(rc == CURLE_OK);
+rc = curl_easy_setopt(rSession.m_pCurl.get(), 
CURLOPT_COOKIE, cookies.getStr());
+assert(rc == CURLE_OK);
+(void)rc;
+isRetry = true;
+}
+}
+break;
+}
 case SC_UNAUTHORIZED:
 case SC_PROXY_AUTHENTICATION_REQUIRED:
 {
diff --git a/ucb/source/ucp/webdav-curl/ImportCookies.cxx 
b/ucb/source/ucp/webdav-curl/ImportCookies.cxx
index 897299da3c0a..4df885e4efc7 100644
--- a/ucb/source/ucp/webdav-curl/ImportCookies.cxx
+++ b/ucb/source/ucp/webdav-curl/ImportCookies.cxx
@@ -24,6 +24,8 @@
 #include 
 
 #ifdef _WIN32
+#include 
+
 #include 
 
 #include 
@@ -98,7 +100,7 @@ OString 
TryImportCookies(uno::Reference const& xContext[
 char* err(nullptr);
 Value value;
 OString const statement("SELECT value, LENGTH(encrypted_value), 
encrypted_value FROM cookies "
-"WHERE name = \"FedAuth\"  and host_key = \""
+"WHERE name = \"FedAuth\" AND host_key = \""
 + ::rtl::OUStringToOString(rHost, 
RTL_TEXTENCODING_ASCII_US) + "\";");
 rc = sqlite3_exec(db, statement.getStr(), callback, , );
 if (rc != SQLITE_OK)
@@ -113,7 +115,7 @@ OString 
TryImportCookies(uno::Reference const& xContext[
 }
 if (value.encryptedValue.getLength() < 3 + 12 + 16)
 {
-SAL_INFO("ucb.ucp.webdav.curl", "encrypted_value too short");
+SAL_INFO("ucb.ucp.webdav.curl", "encrypted_value too short: " << 
value.encryptedValue.getLength());
 return OString();
 }
 
@@ -125,7 +127,7 @@ OString 
TryImportCookies(uno::Reference const& xContext[
 OUString const stateUrl = localAppDirUrl + "/Microsoft/Edge/User 
Data/Local State";
 OUString statePathU;
 

[Libreoffice-bugs] [Bug 151006] New: new LibreOffice update

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151006

Bug ID: 151006
   Summary: new LibreOffice update
   Product: LibreOffice
   Version: 7.4.1.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: yeffetei...@gmail.com

Description:
every time i try to do the new update, I can't open any file with Libreoffice.
to use it again i need to delete (though isn't always easy) and download the
old version.

Actual Results:
can't open libreoffice 7.4

Expected Results:
be able to open files using the libreoffice


Reproducible: Always


User Profile Reset: No



Additional Info:
all info was submitted

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 79654] Save XLSX consumes 100% memory and hangs with "bad allocation" (scfiltlo.dll)

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=79654

--- Comment #19 from Julien Nabet  ---
Created attachment 182504
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182504=edit
Flamegraph

Here's an update of the Flamegraph on pc Debian x86-64 with master sources
updated today + gen rendering.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150989] "Math baseline alignment" is not documented in Help

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150989

Rafael Lima  changed:

   What|Removed |Added

 CC||rafael.palma.l...@gmail.com
 Ever confirmed|0   |1
 Status|UNCONFIRMED |ASSIGNED
   Assignee|libreoffice-b...@lists.free |rafael.palma.l...@gmail.com
   |desktop.org |

--- Comment #2 from Rafael Lima  ---
Indeed the explanation is missing in the Help. Fortunately we have a good
description of this feature in the Writer guide.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 67583] FILEOPEN: File with 40 images long opening, not responding and RAM increasing - both DOC, DOCX (win only)

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=67583

--- Comment #38 from Julien Nabet  ---
Created attachment 182503
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182503=edit
Flamegraph

On pc Debian x86-64 with master sources updated today + gen rendering, I
retrieved a Flamegraph during opening of
https://bugs.documentfoundation.org/attachment.cgi?id=83363, if it can help.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140696] vba initialisation of variables

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140696

Rafael Lima  changed:

   What|Removed |Added

 CC||rafael.palma.l...@gmail.com

--- Comment #6 from Rafael Lima  ---
(In reply to Harald Langheinrich from comment #3)
> Created attachment 170562 [details]
> this file is under development  it took time to depersonalize it

Hi... Have you been able to solve this issue?

I am trying to reproduce this bug, but I can't find which macro triggers the
problem. Can you please provide a set of steps that cause the error so that I
can reproduce it with the provided sample file?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 101631] VBA function parameter is passed by reference by default

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101631

Rafael Lima  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||1005

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151005] With "Option VBASupport 1" arguments should be treated as ByValue by default (not as ByRef)

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151005

Rafael Lima  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||1631

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150687] Simple inserting of text: too many warnings in console with debug LO

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150687

--- Comment #7 from BogdanB  ---
Created attachment 182502
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182502=edit
video about this bug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147457] Basic 'Me' keyword not implemented

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147457

Rafael Lima  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||rafael.palma.l...@gmail.com

--- Comment #2 from Rafael Lima  ---
Since this is a feature of class modules, the keyword "Me" should also be
implemented with Option Compatible / VBASupport 1.

I am setting this to NEW.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108908] [META] Visual Basic for Applications (VBA) macro issues

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108908

Rafael Lima  changed:

   What|Removed |Added

 Depends on||151005


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=151005
[Bug 151005] With "Option VBASupport 1" arguments should be treated as ByValue
by default (not as ByRef)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151005] With "Option VBASupport 1" arguments should be treated as ByValue by default (not as ByRef)

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151005

Rafael Lima  changed:

   What|Removed |Added

 Blocks||108908


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108908
[Bug 108908] [META] Visual Basic for Applications (VBA) macro issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151005] With "Option VBASupport 1" arguments should be treated as ByValue by default (not as ByRef)

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151005

Rafael Lima  changed:

   What|Removed |Added

Summary|With VBASupport 1 arguments |With "Option VBASupport 1"
   |should be treated as|arguments should be treated
   |ByValue by default (not as  |as ByValue by default (not
   |ByRef)  |as ByRef)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150727] A reference passed as parameter gets a new target

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150727

Rafael Lima  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||1005

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151005] With VBASupport 1 arguments should be treated as ByValue by default (not as ByRef)

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151005

Rafael Lima  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||0727

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144839] Cannot access certain options in Tabbed interface

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144839

--- Comment #13 from Kuba Orlik  ---
Another missing option is "Insert Trend Line"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151005] New: With VBASupport 1 arguments should be treated as ByValue by default (not as ByRef)

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151005

Bug ID: 151005
   Summary: With VBASupport 1 arguments should be treated as
ByValue by default (not as ByRef)
   Product: LibreOffice
   Version: 7.3.5.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rafael.palma.l...@gmail.com

This ticket is a spinoff from bug 150727.

LibreOffice's Basic implementation assumes that arguments are defined as ByRef
(see [1]). So in LO the code below prints "Y" as a result, which is correct.

Sub Test()
Dim a As String
a = "X"
DummySub (a)
MsgBox (a)
End Sub

Sub DummySub(val As String)
val = "Y"
End Sub

[1] https://help.libreoffice.org/7.4/en-US/text/sbasic/shared/03090409.html

However, in MS VBA, arguments are passed as ByValue by default, hence the code
above using Option VBASupport 1 should print "X" in LibreOffice, but we still
get "Y" as a result.

If you run the code above in MSO you'll get an "X" as result.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-4' - sw/qa

2022-09-16 Thread Xisco Fauli (via logerrit)
 sw/qa/extras/uiwriter/uiwriter.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit f335dad0fe61ec4807ad6ee17166a569e9a97b1d
Author: Xisco Fauli 
AuthorDate: Mon Feb 14 15:44:37 2022 +0100
Commit: Michael Stahl 
CommitDate: Fri Sep 16 20:27:44 2022 +0200

sw_uiwriter3: just check the number of pages is the same...

... before and after, sometimes it might be 6 instead
of 7 and in this test we just care about it not crashing

Change-Id: Ia358517f4b0c566199af368da51ba385845218a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129916
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 5c49a9c98620153e206a3aabc2a89ef19c0a1046)

diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx 
b/sw/qa/extras/uiwriter/uiwriter.cxx
index 1e0b5b46114e..4fd56405933d 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -4233,7 +4233,7 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest, testTdf139843)
 {
 load(DATA_DIRECTORY, "tdf139843.odt");
 
-CPPUNIT_ASSERT_EQUAL(7, getPages());
+int nPages = getPages();
 
 lcl_dispatchCommand(mxComponent, ".uno:SelectAll", {});
 Scheduler::ProcessEventsToIdle();
@@ -4247,7 +4247,7 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest, testTdf139843)
 lcl_dispatchCommand(mxComponent, ".uno:Paste", {});
 Scheduler::ProcessEventsToIdle();
 
-CPPUNIT_ASSERT_EQUAL(7, getPages());
+CPPUNIT_ASSERT_EQUAL(nPages, getPages());
 }
 
 CPPUNIT_TEST_FIXTURE(SwUiWriterTest, testTdf134252)


[Libreoffice-bugs] [Bug 118503] Can't run user python macros.

2022-09-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118503

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru

--- Comment #10 from Roman Kuznetsov <79045_79...@mail.ru> ---
Alain, so it's a bug or not a bug at all? 

If I understood correctly we have only one place for Python scripts placing and
it's just by default. If user want start his/her Python scripts in LibreOffice
from any other place then he/she should just add a new place to Python sys.path
him/herself, right?

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   3   4   >