[Libreoffice-bugs] [Bug 144438] Cell editing random spurious odd content re-arrangements and deletions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144438

--- Comment #12 from John  ---
I forgot to say that in the video the re-arrangement of the text occurred in
less than 0.01 seconds after data entry into that cell.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151840] API: Text Table Cursor has no notion of row and columns, and no sane way to loop through the selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151840

--- Comment #13 from Lionel Elie Mamane  ---
(In reply to Mike Kaganski from comment #12)
> (In reply to Lionel Elie Mamane from comment #8)
> 
> For all that, simple introduction of TextTable property is enough, together
> with existing getRangeName.

No. getRangeName()/gotoCellByName means the macro writer must parse the range
name, a string, manually. This is not a sane, usable API. Something like
css:table:XCellRange is much better. Clearly, the designer of the idl files
intended that to be provided for text tables, since css:text:CellRange provides
that interface.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151562] Text jumps down by a pixel after entering

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151562

Adolfo Jayme Barrientos  changed:

   What|Removed |Added

   Severity|normal  |minor
   Priority|medium  |low

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 151562] Text jumps down by a pixel after entering

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151562

Adolfo Jayme Barrientos  changed:

   What|Removed |Added

   Severity|normal  |minor
   Priority|medium  |low

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 149932] When using ibus input methods, the underlining style set by the input method is ignored in the gtk3 backend.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149932

Caolán McNamara  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151665] There are no "Deletions in margin" and "Insertions in margin" items in some Edit-Track changes submenu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151665

--- Comment #1 from Heiko Tietze  ---
"Edit > TC > [x] Show" is an easy-to-use and well-known function. And we have
to consider the off situation. If we do something like 
Edit > TC > Show > (o) Off
Edit > TC > Show > ( ) Show all inline
Edit > TC > Show > ( ) Insertion in margin
Edit > TC > Show > ( ) Deletions in margin

it adds a lot of confusion for casual users. My take: keep it simple here and
let the inline vs. margin thing be something for the advanced users with access
per menu button in the toolbar.

Btw, having another route per tools > options is also not helping.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 151665] There are no "Deletions in margin" and "Insertions in margin" items in some Edit-Track changes submenu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151665

--- Comment #1 from Heiko Tietze  ---
"Edit > TC > [x] Show" is an easy-to-use and well-known function. And we have
to consider the off situation. If we do something like 
Edit > TC > Show > (o) Off
Edit > TC > Show > ( ) Show all inline
Edit > TC > Show > ( ) Insertion in margin
Edit > TC > Show > ( ) Deletions in margin

it adds a lot of confusion for casual users. My take: keep it simple here and
let the inline vs. margin thing be something for the advanced users with access
per menu button in the toolbar.

Btw, having another route per tools > options is also not helping.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 151174] sidebar transparency slider isn't hidden when it does not apply

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151174

Samuel Mehrbrodt (allotropia)  changed:

   What|Removed |Added

 CC||samuel.mehrbrodt@allotropia
   ||.de
   Assignee|libreoffice-b...@lists.free |samuel.mehrbrodt@allotropia
   |desktop.org |.de
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151874] New: FORMATTING: It shouldn’t be possible to edit „No Character Style“

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151874

Bug ID: 151874
   Summary: FORMATTING: It shouldn’t be possible to edit „No
Character Style“
   Product: LibreOffice
   Version: 7.3.6.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: martin.sour...@gmail.com

Currently it’s possible to edit the No Character Style even though it shouldn’t
be.

Steps:
1. Modify any character style (other than the No Character Style)
2. On Organizer tab set Inherit from to No Character Style
3. Click on Edit Style
4. Change parameters of No Character Style at will
5. Click OK
6. Click Cancel

Expected outcome:
The No Character Style should not be editable in any way.

Actual outcome:
All character styles inherit the changes of No Character Style, even if they
have Inherit from set to None.

Version: 7.3.6.2 (x64) / LibreOffice Community
Build ID: c28ca90fd6e1a19e189fc16c05f8f8924961e12e
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: cs-CZ (cs_CZ); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151603] ScriptForge library gives an error on rpy2py conversion

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151603

--- Comment #16 from Paul Smith  ---
Thanks for your cooperation.

APSO console and my own Python console run the same Python binary:

/usr/bin/python3

I suspect that the error does not come from uno or ScriptForge, as when I run
the following code on APSO console, I get the following error:

-
>>> import uno
>>> import numpy as np
>>> from rpy2.robjects.packages import importr, data
>>> rpart = importr('rpart')
Traceback (most recent call last):
  File "/usr/lib64/python3.10/code.py", line 90, in runcode
exec(code, self.locals)
  File "", line 1, in 
  File "/home/x/.local/lib/python3.10/site-packages/rpy2/robjects/packages.py",
line 496, in importr
pack = InstalledSTPackage(env, name,
  File "/home/x/.local/lib/python3.10/site-packages/rpy2/robjects/packages.py",
line 203, in __init__
self.__fill_rpy2r__(on_conflict=on_conflict)
  File "/home/x/.local/lib/python3.10/site-packages/rpy2/robjects/packages.py",
line 329, in __fill_rpy2r__
(super(SignatureTranslatedPackage, self)
  File "/home/x/.local/lib/python3.10/site-packages/rpy2/robjects/packages.py",
line 264, in __fill_rpy2r__
rpyobj = cv.rpy2py(riobj)
  File "/usr/lib64/python3.10/functools.py", line 889, in wrapper
return dispatch(args[0].__class__)(*args, **kw)
  File
"/home/x/.local/lib/python3.10/site-packages/rpy2/robjects/conversion.py", line
252, in _rpy2py
raise NotImplementedError(
NotImplementedError: Conversion 'rpy2py' not defined for objects of type
''
>>> 
-

Running this exact same code on my own Python console, no error is returned.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103341

Dieter  changed:

   What|Removed |Added

 Depends on||151623


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=151623
[Bug 151623] Auto-complete being sensitive to uppercase/lower-case but word
auto-complete list contains only a single entry
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151623] Auto-complete being sensitive to uppercase/lower-case but word auto-complete list contains only a single entry

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151623

Dieter  changed:

   What|Removed |Added

   Severity|normal  |minor
 Ever confirmed|0   |1
   Priority|medium  |low
 Blocks||103341
 Status|UNCONFIRMED |NEW
 CC||dgp-m...@gmx.de
 Whiteboard| QA:needsComment|

--- Comment #1 from Dieter  ---
I confirm the problem with

Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9cd0f4c2d25462feba0ffcbd906c199273821243
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: default; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded

But when I first tried to reproduce, LO added "amitriptyline" to word
collection list and gave me "Amitriptyline" (at beginning of a paragraph) and
"amitriptyline" (after a space) as suggestion. For me that's the correct
behaviour. But I couldn't reproduce this behaviour and couldn't explain it.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103341
[Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 151365] Consider letting +/- change zoom level in Read-Only mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151365

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Heiko Tietze  ---
Using different shortcuts depending on some state makes it hard to familiarize.
Might be not much of a problem in this particular case. But it also depends on
the type of keyboard anyway (wouldn't press +/- on a TKL). Another argument
against the modification is the required hard-coding. Last but not least I
don't see need / a clear use case / some real life request for this. => WF

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 151365] Consider letting +/- change zoom level in Read-Only mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151365

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Heiko Tietze  ---
Using different shortcuts depending on some state makes it hard to familiarize.
Might be not much of a problem in this particular case. But it also depends on
the type of keyboard anyway (wouldn't press +/- on a TKL). Another argument
against the modification is the required hard-coding. Last but not least I
don't see need / a clear use case / some real life request for this. => WF

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151819] Scripts in java

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151819

FL  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #3 from FL  ---
Works.
I'm sorry.
I haven't tested my macros on the latest version of libreoffice.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 115712] [META] Usability metrics (usage stats) bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115712

--- Comment #6 from Adolfo Jayme Barrientos  ---
I must say that the blog post and intent has taken me completely by surprise. I
am a TDF trustee, so it’s a little disappointing to be blindsided on this.

It is unclear how and if any TDF personnel will act upon any hypothetical data
obtained from telemetry, and what are the benefits — will the TDF fund
development on UX improvements? Given its track record, you will excuse me for
being skeptical.

I don’t care if the TDF as an organization wants to obtain income from
corporate partnerships, but please don’t taint the software.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sd/qa svx/source

[Tomaž Vajngerl (via logerrit)]

 sd/qa/unit/export-tests-ooxml3.cxx |2 +-
 svx/source/svdraw/svdotext.cxx |   15 +++
 2 files changed, 8 insertions(+), 9 deletions(-)

New commits:
commit 7f73a779e33dd91fad0111629c6b3420c2c9aea0
Author: Tomaž Vajngerl 
AuthorDate: Wed Nov 2 20:15:31 2022 +0100
Commit: Tomaž Vajngerl 
CommitDate: Thu Nov 3 09:53:54 2022 +0100

optimize text fitting algorithm to correctly calculate the fit

As we converted the chart stretching variable from int to double
this can cause the text fitting algorithm to calculate the fit
wrong. This commit changes the text fitting algorithm a bit so
that it produces similar result as before the change.

Change test testAutofittedTextboxIndent from 691200 to 712800 as
the fitting algorithm changed a bit. Visually the document still
looks correct.

Change-Id: Ib75733360039d80a5aed836f757c3f8e8ec56d61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142186
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/sd/qa/unit/export-tests-ooxml3.cxx 
b/sd/qa/unit/export-tests-ooxml3.cxx
index 62fe34150896..2f2576ed1ce6 100644
--- a/sd/qa/unit/export-tests-ooxml3.cxx
+++ b/sd/qa/unit/export-tests-ooxml3.cxx
@@ -2068,7 +2068,7 @@ void SdOOXMLExportTest3::testAutofittedTextboxIndent()
 
 xmlDocUniquePtr pXmlDocContent1 = parseExport(tempFile, 
"ppt/slides/slide1.xml");
 assertXPath(pXmlDocContent1, 
"/p:sld/p:cSld/p:spTree/p:sp/p:txBody/a:p[1]/a:pPr", "marL",
-"691200");
+"712800");
 }
 
 CPPUNIT_TEST_SUITE_REGISTRATION(SdOOXMLExportTest3);
diff --git a/svx/source/svdraw/svdotext.cxx b/svx/source/svdraw/svdotext.cxx
index 5e2a8721cd89..6e47273fe175 100644
--- a/svx/source/svdraw/svdotext.cxx
+++ b/svx/source/svdraw/svdotext.cxx
@@ -1252,9 +1252,8 @@ void SdrTextObj::ImpAutoFitText(SdrOutliner& rOutliner, 
const Size& rTextSize,
 // loop early-exits if we detect an already attained value
 double nMinStretchX = 0.0;
 double nMinStretchY = 0.0;
-sal_uInt16 aOldStretchXVals[]={0,0,0,0,0,0,0,0,0,0};
-const size_t aStretchArySize=SAL_N_ELEMENTS(aOldStretchXVals);
-for(unsigned int i=0; i aOldStretchXVals = {0,0,0,0,0,0,0,0,0,0};
+for (size_t i = 0; i < aOldStretchXVals.size(); ++i)
 {
 const Size aCurrTextSize = rOutliner.CalcTextSizeNTP();
 double fFactor = 1.0;
@@ -1279,7 +1278,7 @@ void SdrTextObj::ImpAutoFitText(SdrOutliner& rOutliner, 
const Size& rTextSize,
 double nCurrStretchX, nCurrStretchY;
 rOutliner.GetGlobalCharStretching(nCurrStretchX, nCurrStretchY);
 
-if (fFactor >= 1.0 )
+if (fFactor >= 0.98)
 {
 // resulting text area fits into available shape rect -
 // err on the larger stretching, to optimally fill area
@@ -1287,14 +1286,14 @@ void SdrTextObj::ImpAutoFitText(SdrOutliner& rOutliner, 
const Size& rTextSize,
 nMinStretchY = std::max(nMinStretchY, nCurrStretchY);
 }
 
-aOldStretchXVals[i] = nCurrStretchX;
-if( std::find(aOldStretchXVals, aOldStretchXVals+i, nCurrStretchX) != 
aOldStretchXVals+i )
+aOldStretchXVals[i] = basegfx::fround(nCurrStretchX * 10.0);
+if (std::find(aOldStretchXVals.begin(), aOldStretchXVals.begin() + i, 
basegfx::fround(nCurrStretchX * 10.0)) != aOldStretchXVals.begin() + i)
 break; // same value already attained once; algo is looping, exit
 
 if (fFactor < 1.0 || nCurrStretchX != 100)
 {
-nCurrStretchX = nCurrStretchX * fFactor;
-nCurrStretchY = nCurrStretchY * fFactor;
+nCurrStretchX = double(basegfx::fround(nCurrStretchX * fFactor * 
100.0)) / 100.00;
+nCurrStretchY = double(basegfx::fround(nCurrStretchY * fFactor * 
100.0)) / 100.00;
 
 rOutliner.SetGlobalCharStretching(std::min(100.0, nCurrStretchX), 
std::min(100.0, nCurrStretchY));
 SAL_INFO("svx", "zoom is " << nCurrStretchX);

[Libreoffice-bugs] [Bug 151603] ScriptForge library gives an error on rpy2py conversion

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151603

--- Comment #15 from Jean-Pierre Ledure  ---
In:
def acertos_iris(args=None):
... iris = data(datasets).fetch('iris')['iris']
... model = rpart.rpart('Species ~ .', iris)
... preds = rpart.predict_rpart(model, iris, type='class') 
... nacertos = base.sum(base.diag(base.table(preds, iris.rx2(5
... erro = nacertos[0]/150
... doc = XSCRIPTCONTEXT.getDocument()
... sheet = doc.CurrentController.ActiveSheet
... cell = sheet.getCellByPosition(0, 0)
... cell.setValue(erro)
... doc.setArray("~.A1", erro)

only the last statement seems to invoke ScriptForge.
However, "doc" is a UNO object, not a ScriptForge Calc instance.

Can this explain the observed behaviours ?

Maybe, replace last statement with (not tested);
def acertos_iris(args=None):
... iris = data(datasets).fetch('iris')['iris']
... model = rpart.rpart('Species ~ .', iris)
... preds = rpart.predict_rpart(model, iris, type='class') 
... nacertos = base.sum(base.diag(base.table(preds, iris.rx2(5
... erro = nacertos[0]/150
... doc = XSCRIPTCONTEXT.getDocument()
... sheet = doc.CurrentController.ActiveSheet
... cell = sheet.getCellByPosition(0, 0)
... cell.setValue(erro)
... ui = CreateScriptService("UI")
... doc2 = ui.GetDocument(doc)
... doc2.setArray("~.A1", erro)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150409] Style inspector: CJK & CTL properties should never be hidden

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150409

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g

--- Comment #16 from BogdanB  ---
Liu Hao, this bug is marked as New. If you solved this bug please assign this
bug to you than mark it as Resolved - Fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151873] Writer doc crashes when scrolling document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151873

Telesto  changed:

   What|Removed |Added

 CC||tele...@surfxs.nl,
   ||xiscofa...@libreoffice.org

--- Comment #2 from Telesto  ---
@Xisco
In reply to Wilbur Harvey from comment #1)
> sorry, I can't attach my files, they are very company proprietary.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 124603] Automatic spell check of edited word is made after another word edit starts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124603

--- Comment #12 from Gabriel Masei  ---
Thanks Laszlo for your fix! I've tested it by building the master branch and
running locally and it works.

However, I think that the solution is incomplete. The state of the word is
changed only if the user presses the up or down keys. This is good but not
enough. The issue still manifests if the user performs any other actions (like
left/right keys or mouse to change the cursor position or perform a different
action, Ctrl + S to save the document, mouse to navigate through menu for
choosing an option, ...). I think that the update of the word state should be
done after any other action beside editing the word. Maybe we should update the
state at "leave the current word" event, if this event is available. Or to
update the word after any action from the user. I don't know if the last
suggestion is feasible as it could slow the editing but, on the other hand,
this will include all cases.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 151215] Let me choose different fonts for different languages in the same group

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151215

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Keywords|needsUXEval |
 Ever confirmed|0   |1
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #18 from Heiko Tietze  ---
Plenty of input from UX, happy to help when implementation has further
questions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 151215] Let me choose different fonts for different languages in the same group

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151215

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Keywords|needsUXEval |
 Ever confirmed|0   |1
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #18 from Heiko Tietze  ---
Plenty of input from UX, happy to help when implementation has further
questions.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 96000] [META] Spelling and grammar checking bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96000

Heiko Tietze  changed:

   What|Removed |Added

 Depends on||151625


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=151625
[Bug 151625] User-defined dictionary: Easier access to management functions
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151625] User-defined dictionary: Easier access to management functions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151625

Heiko Tietze  changed:

   What|Removed |Added

   Severity|normal  |enhancement
 Blocks||96000
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   Keywords|needsUXEval |
Summary|ENHANCEMENT: Make   |User-defined dictionary:
   |adding/removing item to |Easier access to management
   |user-defined more   |functions
   |accessible  |

--- Comment #4 from Heiko Tietze  ---
It's a wide topic with a) into which dictionary new words go, b) how to
add/edit/delete the words in a dictionary, and c) how to access all this (via
context menu, dialog etc.).


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=96000
[Bug 96000] [META] Spelling and grammar checking bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150477] "Slide 1 of 1" instead of "Page" in the bottom bar of Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150477

BogdanB  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |buzea.bog...@libreoffice.or
   |desktop.org |g
 CC||buzea.bog...@libreoffice.or
   ||g

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/source

[Miklos Vajna (via logerrit)]

 sw/source/ui/fldui/fldref.cxx|   30 +++---
 sw/source/ui/fldui/fldref.hxx|   10 +-
 sw/source/ui/fldui/fldvar.cxx|   32 
 sw/source/ui/fldui/fldvar.hxx|8 
 sw/source/ui/frmdlg/frmpage.cxx  |   36 ++--
 sw/source/ui/misc/pgfnote.cxx|   20 ++--
 sw/source/uibase/inc/bmpwin.hxx  |   14 +++---
 sw/source/uibase/inc/pgfnote.hxx |2 +-
 8 files changed, 76 insertions(+), 76 deletions(-)

New commits:
commit 3b37482bf1fecd9e28bef454bc6a49a5c66c716d
Author: Miklos Vajna 
AuthorDate: Thu Nov 3 07:58:28 2022 +0100
Commit: Miklos Vajna 
CommitDate: Thu Nov 3 09:08:00 2022 +0100

sw: prefix members of BmpWindow, SwFieldRefPage, SwFieldVarPage and ...

... SwFootNotePage

See tdf#94879 for motivation.

Change-Id: Ie665eca504a7092db68591942a527c671a151c3b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142191
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/sw/source/ui/fldui/fldref.cxx b/sw/source/ui/fldui/fldref.cxx
index bae2557f173d..b7a30d589196 100644
--- a/sw/source/ui/fldui/fldref.cxx
+++ b/sw/source/ui/fldui/fldref.cxx
@@ -76,12 +76,12 @@ SwFieldRefPage::SwFieldRefPage(weld::Container* pPage, 
weld::DialogController* p
 m_xFormatLB->append_text(SwResId(FLD_REF_PAGE_TYPES[i]));
 }
 
-sBookmarkText = m_xTypeLB->get_text(0);
-sFootnoteText = m_xTypeLB->get_text(1);
-sEndnoteText = m_xTypeLB->get_text(2);
+m_sBookmarkText = m_xTypeLB->get_text(0);
+m_sFootnoteText = m_xTypeLB->get_text(1);
+m_sEndnoteText = m_xTypeLB->get_text(2);
 // #i83479#
-sHeadingText = m_xTypeLB->get_text(3);
-sNumItemText = m_xTypeLB->get_text(4);
+m_sHeadingText = m_xTypeLB->get_text(3);
+m_sNumItemText = m_xTypeLB->get_text(4);
 
 auto nHeight = m_xTypeLB->get_height_rows(8);
 auto nWidth = m_xTypeLB->get_approximate_digit_width() * 
FIELD_COLUMN_WIDTH;
@@ -191,8 +191,8 @@ void SwFieldRefPage::Reset(const SfxItemSet* )
 
 // #i83479#
 // entries for headings and numbered items
-m_xTypeLB->append(OUString::number(REFFLDFLAG_HEADING), sHeadingText);
-m_xTypeLB->append(OUString::number(REFFLDFLAG_NUMITEM), sNumItemText);
+m_xTypeLB->append(OUString::number(REFFLDFLAG_HEADING), m_sHeadingText);
+m_xTypeLB->append(OUString::number(REFFLDFLAG_NUMITEM), m_sNumItemText);
 
 // fill up with the sequence types
 SwWrtShell *pSh = GetWrtShell();
@@ -226,18 +226,18 @@ void SwFieldRefPage::Reset(const SfxItemSet* )
 }
 
 // text marks - now always (because of globaldocuments)
-m_xTypeLB->append(OUString::number(REFFLDFLAG_BOOKMARK), sBookmarkText);
+m_xTypeLB->append(OUString::number(REFFLDFLAG_BOOKMARK), m_sBookmarkText);
 
 // footnotes:
 if( pSh->HasFootnotes() )
 {
-m_xTypeLB->append(OUString::number(REFFLDFLAG_FOOTNOTE), 
sFootnoteText);
+m_xTypeLB->append(OUString::number(REFFLDFLAG_FOOTNOTE), 
m_sFootnoteText);
 }
 
 // endnotes:
 if ( pSh->HasFootnotes(true) )
 {
-m_xTypeLB->append(OUString::number(REFFLDFLAG_ENDNOTE), sEndnoteText);
+m_xTypeLB->append(OUString::number(REFFLDFLAG_ENDNOTE), 
m_sEndnoteText);
 }
 
 m_xTypeLB->thaw();
@@ -315,30 +315,30 @@ IMPL_LINK_NOARG(SwFieldRefPage, TypeHdl, weld::TreeView&, 
void)
 if ( pRefField &&
  pRefField->IsRefToHeadingCrossRefBookmark() )
 {
-sName = sHeadingText;
+sName = m_sHeadingText;
 nFlag = REFFLDFLAG_HEADING;
 }
 else if ( pRefField &&
   pRefField->IsRefToNumItemCrossRefBookmark() )
 {
-sName = sNumItemText;
+sName = m_sNumItemText;
 nFlag = REFFLDFLAG_NUMITEM;
 }
 else
 {
-sName = sBookmarkText;
+sName = m_sBookmarkText;
 nFlag = REFFLDFLAG_BOOKMARK;
 }
 }
 break;
 
 case REF_FOOTNOTE:
-sName = sFootnoteText;
+sName = m_sFootnoteText;
 nFlag = REFFLDFLAG_FOOTNOTE;
 break;
 
 case REF_ENDNOTE:
-sName = sEndnoteText;
+sName = m_sEndnoteText;
 nFlag = REFFLDFLAG_ENDNOTE;
 break;
 
diff --git a/sw/source/ui/fldui/fldref.hxx b/sw/source/ui/fldui/fldref.hxx
index 8dc9a311bcfe..68dc6f6480be 100644
--- a/sw/source/ui/fldui/fldref.hxx
+++ b/sw/source/ui/fldui/fldref.hxx
@@ -28,12 +28,12 @@ class SwTextNode;
 
 class SwFieldRefPage : public 

[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103030
Bug 103030 depends on bug 151299, which changed state.

Bug 151299 Summary: let's clean up the promote / demote ambiguity (part of it 
solved already)
https://bugs.documentfoundation.org/show_bug.cgi?id=151299

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151299] let's clean up the promote / demote ambiguity (part of it solved already)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151299

Heiko Tietze  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WONTFIX

--- Comment #6 from Heiko Tietze  ---
Following Rizal's WF

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 151299] let's clean up the promote / demote ambiguity (part of it solved already)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151299

Heiko Tietze  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WONTFIX

--- Comment #6 from Heiko Tietze  ---
Following Rizal's WF

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98259
Bug 98259 depends on bug 142888, which changed state.

Bug 142888 Summary: UI - View menu - the same hotkeys for two items ("Toolbars" 
and "Show Tracked Changes")
https://bugs.documentfoundation.org/show_bug.cgi?id=142888

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 32249] When importing PDF with text in it , it will be better to have a easy and fluent option to edit the imported Text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=32249

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||1598

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151598] Implement "Consolidate Text" functionality for text boxes in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151598

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=32
   ||249

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 109527] [META] Spell check dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109527
Bug 109527 depends on bug 137555, which changed state.

Bug 137555 Summary: EDIT CUSTOM DICTIONARY DIALOG: Not possible to choose 
language with keyboard
https://bugs.documentfoundation.org/show_bug.cgi?id=137555

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 137555] EDIT CUSTOM DICTIONARY DIALOG: Not possible to choose language with keyboard

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137555

Dieter  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #3 from Dieter  ---
Tested with

Version: 7.4.2.2 (x64) / LibreOffice Community
Build ID: 1726efbecd001a1fe871cba3e00e71283688f34d
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

Steps to reproduce
1. Put cursor in a misspelled word
2. right click => Spelling => Options => Edit
3. Click in Language selection => German is selected (at least with my
settings)
4. Try to type "France"

Result:
with typing in normal speed first country with that character is selected. Fast
typing selects language (not sure about selecting specific country).

But for the moment I would say RESOLVED WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151700] "Print to file" doesn't work on OSX 12.6

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151700

--- Comment #16 from Mike Little  ---
(In reply to monochromec from comment #13)
> Repeated the procedure as outlined by Mike but could not reproduce the delay
> he experienced when saving the document.
> 
> Dialog / issue still remains the same: No "Save to PDF" option available.

Hello, I have not observed that behaviour. see my results below...

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: terminate called after throwing an instance of 'com::sun::star::deployment::DeploymentException'

[Mike Kaganski]

Hi,

On 02.11.2022 10:12, Kevin Suo wrote:
I have been suffering the DeploymentException discussed below for a long 
time. Good news is that, this seems now have been fixed by:



commit 8c6467a785037309d2a2cec56c8e38cf52da0aee
Author: Mike Kaganski 
Date:   Sat Oct 29 23:38:12 2022 +0300

     MSI: fix handling empty directories



Great; likely that means that the problem was because of missing empty 
directory that is expected to be present.




I am wondering whether you can backport this commit to libreoffice-7-4 
as well, since the problem below also exists on 7.4 branch.


No. The change is a bit risky, because that Perl-based installer 
machinery is very opaque, and - as you see yourself, it's very difficult 
to track the problems that may arise from errors in the Perl scripts. 
One regression has already appeared and hopefully was fixed by 
89022d5b6dc51e592e22bb8ff94c430ec14de17c; I already see another flaw in 
my code. It must boil in master.


--
Best regards,
Mike Kaganski

[Libreoffice-bugs] [Bug 151700] "Print to file" doesn't work on OSX 12.6

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151700

--- Comment #15 from Mike Little  ---
00STATE INFORMATION, TEST SETUP PRIOR TO TEST


1. CPU Load
--

System:  30.64%
User:  11.42%
Idle: 57.95%

2. Memory Load
--
Physical Memory: 8.00 GB
Memory Used: 6.47 GB
Cached Files: 1.57 GB
Swap used: 1.19 GB
App Memory: 2.40 GB
Wired Memory: 2.58 GB
Compressed Memory: 2.35 GB

3. System Software Overview 
--
  System Version:   macOS 13.0 (22A380)
  Kernel Version:   Darwin 22.1.0
  Boot Volume:  Macintosh HD
  Boot Mode:Normal
  Computer Name:mlittle-macmini-20200921’s Mac mini
  Username: mlittle-macmini-20200921 (mlittle-macmini-20200921)
  Secure Virtual Memory:Enabled
  System Integrity Protection:  Enabled
  Time since boot:  6 days, 21 hours, 49 minutes


4. LibreOffice application details
--
Version: 7.4.1.2 / LibreOffice Community
Build ID: 3c58a8f3a960df8bc8fd77b461821e42c061c5f0
CPU threads: 4; OS: Mac OS X 13.0; UI render: default; VCL: osx
Locale: en-AU (en_AU.UTF-8); UI: en-US

1.  Start application from the ./soffice.sh. LibreOffice opened
successfully presenting the document navigator window.
2.  Capture the Sample Process from Activity Monitor before starting
LibreOffice, Impress. 
3.  Execute “Impress Presentation” 
4.  Create an Impress file by importing an existing MS PowerPoint document.
 File imported correctly. 

C.TESTING IMPRESS
===
1.  Commenced test of problem identified above concerning Print to
File…”Save as PDF”
2.  Choose File>Print. Print dialog  appears. 
3.  Choose “Save As PDF”  Path select presented as expected. 
4.  PDF file created successfully. Application Stable.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - solenv/flatpak-manifest.in

[Stephan Bergmann (via logerrit)]

 solenv/flatpak-manifest.in |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 7da429432e4c4566625fb99a8fe0852c8e8d1bec
Author: Stephan Bergmann 
AuthorDate: Wed Nov 2 14:52:50 2022 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Thu Nov 3 07:56:41 2022 +0100

Sync flatpak-manifest.in with Flathub

...including


"Update to Freedesktop SDK 22.08" and


"Adapt build of gvfs to org.freedesktop.Platform//22.08"

Change-Id: I7f3b228a5a15539e07555d6625d1eabff83a5f5b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142166
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
(cherry picked from commit 76560e670a36b1acc9429d1ea183422382c8bbe3)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142148
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/solenv/flatpak-manifest.in b/solenv/flatpak-manifest.in
index 3099285443f2..9ed880565c52 100644
--- a/solenv/flatpak-manifest.in
+++ b/solenv/flatpak-manifest.in
@@ -1,7 +1,7 @@
 {
 "id": "org.libreoffice.LibreOffice",
 "runtime": "org.freedesktop.Platform",
-"runtime-version": "21.08",
+"runtime-version": "22.08",
 "sdk": "org.freedesktop.Sdk",
 "sdk-extensions": [
 "org.freedesktop.Sdk.Extension.openjdk11"
@@ -19,7 +19,7 @@
 "name": "gvfs",
 "buildsystem": "meson",
 "config-opts": [ "-Dsystemduserunitdir=no", "-Dtmpfilesdir=no", 
"-Dinstalled_tests=true",
-"-Ddbus_service_dir=/usr/share/dbus-1/services", "-Dadmin=false", 
"-Dafc=false", "-Dafp=false",
+"-Dadmin=false", "-Dafc=false", "-Dafp=false",
 "-Darchive=false", "-Dcdda=false", "-Ddnssd=false", "-Dgoa=false", 
"-Dgoogle=false",
 "-Dgphoto2=false", "-Dhttp=false", "-Dmtp=false", "-Dnfs=false", 
"-Dsftp=false", "-Dsmb=false",
 "-Dudisks2=false", "-Dbluray=false", "-Dfuse=false", 
"-Dgcr=false", "-Dgcrypt=false",

[Libreoffice-commits] core.git: include/sfx2 sw/inc sw/qa sw/source

[Paris Oplopoios (via logerrit)]

 include/sfx2/AccessibilityIssue.hxx|1 
 sw/inc/AccessibilityCheckStrings.hrc   |1 
 sw/qa/core/accessibilitycheck/AccessibilityCheckTest.cxx   |   11 ++
 sw/qa/core/accessibilitycheck/data/TableFormattingTest.odt |binary
 sw/source/core/access/AccessibilityCheck.cxx   |   49 +
 5 files changed, 62 insertions(+)

New commits:
commit 5c8934809ac60488d6160e27ff5962350c612a09
Author: Paris Oplopoios 
AuthorDate: Thu Nov 3 01:02:40 2022 +0200
Commit: Tomaž Vajngerl 
CommitDate: Thu Nov 3 07:53:53 2022 +0100

a11y: Add check for table used for text formatting

Add accessibility check and relevant test for a document that uses a
table for text formatting

Change-Id: I20290a3ec89cd5333f3c66867b50aa7b80ed494f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142188
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/sfx2/AccessibilityIssue.hxx 
b/include/sfx2/AccessibilityIssue.hxx
index b9e3266c73a2..0c22d9e19238 100644
--- a/include/sfx2/AccessibilityIssue.hxx
+++ b/include/sfx2/AccessibilityIssue.hxx
@@ -29,6 +29,7 @@ enum class AccessibilityIssueID
 NO_ALT_SHAPE,
 TABLE_MERGE_SPLIT,
 TEXT_FORMATTING,
+TABLE_FORMATTING,
 HYPERLINK_IS_TEXT,
 HYPERLINK_SHORT,
 FAKE_FOOTNOTE,
diff --git a/sw/inc/AccessibilityCheckStrings.hrc 
b/sw/inc/AccessibilityCheckStrings.hrc
index e63d304d1063..7245a2b8d3e0 100644
--- a/sw/inc/AccessibilityCheckStrings.hrc
+++ b/sw/inc/AccessibilityCheckStrings.hrc
@@ -34,6 +34,7 @@
 #define STR_HEADING_IN_TABLENC_("STR_HEADING_IN_TABLE", "Tables 
must not contain headings.")
 #define STR_HEADING_ORDER   NC_("STR_HEADING_ORDER", "Keep 
headings' levels ordered. Heading level %LEVEL_CURRENT% must not go after 
%LEVEL_PREV%.")
 #define STR_FONTWORKS   NC_("STR_FONTWORKS", "Avoid Fontwork 
objects in your documents. Make sure you use it for samples or other 
meaningless text.")
+#define STR_TABLE_FORMATTINGNC_("STR_TABLE_FORMATTING", "Avoid 
using empty table cells for formatting.")
 
 #define STR_DOCUMENT_DEFAULT_LANGUAGE   NC_("STR_DOCUMENT_DEFAULT_LANGUAGE", 
"Document default language is not set")
 #define STR_STYLE_NO_LANGUAGE   NC_("STR_STYLE_NO_LANGUAGE", "Style 
'%STYLE_NAME%' has no language set")
diff --git a/sw/qa/core/accessibilitycheck/AccessibilityCheckTest.cxx 
b/sw/qa/core/accessibilitycheck/AccessibilityCheckTest.cxx
index 02912e4c9d35..b7561ad01764 100644
--- a/sw/qa/core/accessibilitycheck/AccessibilityCheckTest.cxx
+++ b/sw/qa/core/accessibilitycheck/AccessibilityCheckTest.cxx
@@ -154,6 +154,17 @@ CPPUNIT_TEST_FIXTURE(AccessibilityCheckTest, 
testCheckFakeCaption)
 CPPUNIT_ASSERT_EQUAL(sfx::AccessibilityIssueID::FAKE_CAPTION, 
aIssues[0]->m_eIssueID);
 }
 
+CPPUNIT_TEST_FIXTURE(AccessibilityCheckTest, testCheckTableFormatting)
+{
+SwDoc* pDoc = createSwDoc(DATA_DIRECTORY, "TableFormattingTest.odt");
+CPPUNIT_ASSERT(pDoc);
+sw::AccessibilityCheck aCheck(pDoc);
+aCheck.check();
+auto& aIssues = aCheck.getIssueCollection().getIssues();
+CPPUNIT_ASSERT_EQUAL(size_t(1), aIssues.size());
+CPPUNIT_ASSERT_EQUAL(sfx::AccessibilityIssueID::TABLE_FORMATTING, 
aIssues[0]->m_eIssueID);
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/qa/core/accessibilitycheck/data/TableFormattingTest.odt 
b/sw/qa/core/accessibilitycheck/data/TableFormattingTest.odt
new file mode 100644
index ..adc63daaf7cb
Binary files /dev/null and 
b/sw/qa/core/accessibilitycheck/data/TableFormattingTest.odt differ
diff --git a/sw/source/core/access/AccessibilityCheck.cxx 
b/sw/source/core/access/AccessibilityCheck.cxx
index 0170003c4a48..ce0409d6ba5b 100644
--- a/sw/source/core/access/AccessibilityCheck.cxx
+++ b/sw/source/core/access/AccessibilityCheck.cxx
@@ -236,6 +236,50 @@ public:
 }
 };
 
+class TableFormattingCheck : public NodeCheck
+{
+private:
+void checkTableNode(SwTableNode* pTableNode)
+{
+if (!pTableNode)
+return;
+
+const SwTable& rTable = pTableNode->GetTable();
+if (!rTable.IsTableComplex())
+{
+size_t nEmptyBoxes = 0;
+size_t nBoxCount = 0;
+for (const SwTableLine* pTableLine : rTable.GetTabLines())
+{
+nBoxCount += pTableLine->GetTabBoxes().size();
+for (const SwTableBox* pBox : pTableLine->GetTabBoxes())
+if (pBox->IsEmpty())
+++nEmptyBoxes;
+}
+// If more than half of the boxes are empty we can assume that it 
is used for formatting
+if (nEmptyBoxes > nBoxCount / 2)
+lclAddIssue(m_rIssueCollection, SwResId(STR_TABLE_FORMATTING),
+sfx::AccessibilityIssueID::TABLE_FORMATTING);
+}
+}
+
+public:
+

[Libreoffice-commits] core.git: officecfg/registry

[Bogdan B (via logerrit)]

 officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 54ca50536e1c98f0bfe3b32d2a8c72668289e183
Author: Bogdan B 
AuthorDate: Wed Nov 2 21:39:38 2022 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Thu Nov 3 07:51:30 2022 +0100

tdf#142888 Changing Tracked Changes accelerator

Change-Id: Iba55f1aec8a4b3e5fe56a5dd0b3e4dc3e8a0c7b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142151
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
index 43890c198d0f..ee7712d51367 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
@@ -372,7 +372,7 @@
   
   
 
-  Show ~Tracked Changes
+  Show Tracked ~Changes
 
 
   .uno:ShowTrackedChanges

[Libreoffice-bugs] [Bug 125257] [META] Tip of the day

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125257
Bug 125257 depends on bug 148777, which changed state.

Bug 148777 Summary: The tip of the day 106/223
https://bugs.documentfoundation.org/show_bug.cgi?id=148777

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: cui/inc

[Bogdan B (via logerrit)]

 cui/inc/tipoftheday.hrc |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5beddf4c66c63cac050b4f32d2756c733c842d6f
Author: Bogdan B 
AuthorDate: Wed Nov 2 21:50:56 2022 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Thu Nov 3 07:49:04 2022 +0100

tdf#148777 Improvement to Tip of the day 106

Change-Id: Iea1304d314f6070999f5e3a778e4ea10d92c0688
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142153
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/cui/inc/tipoftheday.hrc b/cui/inc/tipoftheday.hrc
index 5baafec6578d..27f13fcfdc4e 100644
--- a/cui/inc/tipoftheday.hrc
+++ b/cui/inc/tipoftheday.hrc
@@ -154,7 +154,7 @@ const std::tuple 
TIPOFTHEDAY_STRINGARRAY[] =
  { NC_("RID_CUI_TIPOFTHEDAY", "%PRODUCTNAME has a portable version which 
gives you mobility. Even without administrator rights on your computer you can 
install %PRODUCTNAME Portable to your hard drive too."), 
"https://www.libreoffice.org/download/portable-versions/;, ""},
  { NC_("RID_CUI_TIPOFTHEDAY", "Writer lets you number your footnotes per 
page, chapter, document: Tools ▸ Footnotes and Endnotes ▸ Footnotes tab ▸ 
Counting."), "", "tipoftheday_w.png"},
  { NC_("RID_CUI_TIPOFTHEDAY", "Your Writer document does not reopen with 
the text cursor at the same editing position it was when you saved it? Add 
First or Last name in Tools ▸ Options ▸ %PRODUCTNAME ▸ User Data ▸ First/last 
name."), "", ""},
- { NC_("RID_CUI_TIPOFTHEDAY", "Citation management? Use a 3rd party 
extension."), 
"https://wiki.documentfoundation.org/Referencing_Systems_in_LibreOffice;, ""},
+ { NC_("RID_CUI_TIPOFTHEDAY", "Need to do citation? You can use 3rd-party 
citation managers such as Zotero."), 
"https://wiki.documentfoundation.org/Referencing_Systems_in_LibreOffice;, ""},
  { NC_("RID_CUI_TIPOFTHEDAY", "Want to insert a value in the same place on 
several sheets? Select the sheets: hold down %MOD1 key and click their tabs 
before entering."), "", "tipoftheday_c.png"},
  { NC_("RID_CUI_TIPOFTHEDAY", "Want to hide some text in a document? 
Select the text. Insert ▸ Section, and select “Hide”."), 
"modules/swriter/ui/editsectiondialog/hide", "tipoftheday_w.png"},  // online 
help is different 
https://help.libreoffice.org/%PRODUCTVERSION/%LANGUAGENAME/text/swriter/guide/hidden_text.html#hd_id3148675
  { NC_("RID_CUI_TIPOFTHEDAY", "You can customize the middle mouse button 
by going to Tools ▸ Options ▸ %PRODUCTNAME ▸ View ▸ Mouse ▸ Middle button."), 
"", ""},

[Libreoffice-commits] core.git: include/svx

[Bogdan B (via logerrit)]

 include/svx/strings.hrc |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit e272afb703ce3009f9c3edc43653771abd04c8fb
Author: Bogdan B 
AuthorDate: Wed Nov 2 21:20:39 2022 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Thu Nov 3 07:46:55 2022 +0100

tdf#150605 Change "Measure unit" to "Unit of measurement"

... "Measure unit" is not proper English and should be changed to "Unit of 
measurement".

Change-Id: Ic2bf24859fbf3b9b8f468d909afc99da643a026b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142149
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/include/svx/strings.hrc b/include/svx/strings.hrc
index d0b66a81f135..3eeb16e7dcb7 100644
--- a/include/svx/strings.hrc
+++ b/include/svx/strings.hrc
@@ -430,9 +430,9 @@
 #define SIP_SA_MEASURETEXTROTA90
NC_("SIP_SA_MEASURETEXTROTA90", "Dimension value across dimension line")
 #define SIP_SA_MEASURETEXTUPSIDEDOWN
NC_("SIP_SA_MEASURETEXTUPSIDEDOWN", "Rotate dimension value by 180 degree")
 #define SIP_SA_MEASUREOVERHANG  
NC_("SIP_SA_MEASUREOVERHANG", "Dimension line overhang")
-#define SIP_SA_MEASUREUNIT  
NC_("SIP_SA_MEASUREUNIT", "Measure unit")
+#define SIP_SA_MEASUREUNIT  
NC_("SIP_SA_MEASUREUNIT", "Unit of measurement")
 #define SIP_SA_MEASURESCALE 
NC_("SIP_SA_MEASURESCALE", "Additional scale factor")
-#define SIP_SA_MEASURESHOWUNIT  
NC_("SIP_SA_MEASURESHOWUNIT", "Measure unit display")
+#define SIP_SA_MEASURESHOWUNIT  
NC_("SIP_SA_MEASURESHOWUNIT", "Unit of measurement display")
 #define SIP_SA_MEASUREFORMATSTRING  
NC_("SIP_SA_MEASUREFORMATSTRING", "Dimension value format")
 #define SIP_SA_MEASURETEXTAUTOANGLE 
NC_("SIP_SA_MEASURETEXTAUTOANGLE", "AutoPositioning of the dimension value")
 #define SIP_SA_MEASURETEXTAUTOANGLEVIEW 
NC_("SIP_SA_MEASURETEXTAUTOANGLEVIEW", "Angle for the automatic positioning of 
the dimension value")

[Libreoffice-commits] core.git: include/sfx2 sw/inc sw/qa sw/source

[Paris Oplopoios (via logerrit)]

 include/sfx2/AccessibilityIssue.hxx  |1 
 sw/inc/AccessibilityCheckStrings.hrc |1 
 sw/qa/core/accessibilitycheck/AccessibilityCheckTest.cxx |   11 ++
 sw/qa/core/accessibilitycheck/data/FakeCaptionTest.odt   |binary
 sw/source/core/access/AccessibilityCheck.cxx |   66 +++
 5 files changed, 79 insertions(+)

New commits:
commit 766151ff6ec759563583abfa43f5bb3755ee2603
Author: Paris Oplopoios 
AuthorDate: Fri Oct 28 13:14:36 2022 +0300
Commit: Tomaž Vajngerl 
CommitDate: Thu Nov 3 07:43:09 2022 +0100

a11y: Add check for fake captions

Add accessibility check and relevant test for a document that has
fake captions

Change-Id: If22999378fd7467151c1d400662858fe1cb0319d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141964
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/sfx2/AccessibilityIssue.hxx 
b/include/sfx2/AccessibilityIssue.hxx
index 9d1023053515..b9e3266c73a2 100644
--- a/include/sfx2/AccessibilityIssue.hxx
+++ b/include/sfx2/AccessibilityIssue.hxx
@@ -32,6 +32,7 @@ enum class AccessibilityIssueID
 HYPERLINK_IS_TEXT,
 HYPERLINK_SHORT,
 FAKE_FOOTNOTE,
+FAKE_CAPTION,
 MANUAL_NUMBERING
 };
 
diff --git a/sw/inc/AccessibilityCheckStrings.hrc 
b/sw/inc/AccessibilityCheckStrings.hrc
index 86be8b494c90..e63d304d1063 100644
--- a/sw/inc/AccessibilityCheckStrings.hrc
+++ b/sw/inc/AccessibilityCheckStrings.hrc
@@ -22,6 +22,7 @@
 #define STR_TEXT_BLINKING   NC_("STR_TEXT_BLINKING", "Blinking 
text.")
 #define STR_AVOID_FOOTNOTES NC_("STR_AVOID_FOOTNOTES", "Avoid 
footnotes.")
 #define STR_AVOID_FAKE_FOOTNOTESNC_("STR_AVOID_FAKE_FOOTNOTES", "Avoid 
fake footnotes.")
+#define STR_AVOID_FAKE_CAPTIONS NC_("STR_AVOID_FAKE_CAPTIONS", "Avoid 
fake captions.")
 #define STR_AVOID_ENDNOTES  NC_("STR_AVOID_ENDNOTES", "Avoid 
endnotes.")
 #define STR_AVOID_BACKGROUND_IMAGES NC_("STR_AVOID_BACKGROUND_IMAGES", 
"Avoid background images.")
 #define STR_AVOID_NEWLINES_SPACENC_("STR_AVOID_NEWLINES_SPACE", "Avoid 
newlines to create space.")
diff --git a/sw/qa/core/accessibilitycheck/AccessibilityCheckTest.cxx 
b/sw/qa/core/accessibilitycheck/AccessibilityCheckTest.cxx
index 39f094a38c2a..02912e4c9d35 100644
--- a/sw/qa/core/accessibilitycheck/AccessibilityCheckTest.cxx
+++ b/sw/qa/core/accessibilitycheck/AccessibilityCheckTest.cxx
@@ -143,6 +143,17 @@ CPPUNIT_TEST_FIXTURE(AccessibilityCheckTest, 
testCheckFakeFootnote)
 CPPUNIT_ASSERT_EQUAL(sfx::AccessibilityIssueID::FAKE_FOOTNOTE, 
aIssues[1]->m_eIssueID);
 }
 
+CPPUNIT_TEST_FIXTURE(AccessibilityCheckTest, testCheckFakeCaption)
+{
+SwDoc* pDoc = createSwDoc(DATA_DIRECTORY, "FakeCaptionTest.odt");
+CPPUNIT_ASSERT(pDoc);
+sw::AccessibilityCheck aCheck(pDoc);
+aCheck.check();
+auto& aIssues = aCheck.getIssueCollection().getIssues();
+CPPUNIT_ASSERT_EQUAL(size_t(1), aIssues.size());
+CPPUNIT_ASSERT_EQUAL(sfx::AccessibilityIssueID::FAKE_CAPTION, 
aIssues[0]->m_eIssueID);
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/qa/core/accessibilitycheck/data/FakeCaptionTest.odt 
b/sw/qa/core/accessibilitycheck/data/FakeCaptionTest.odt
new file mode 100644
index ..9630bfcf73d7
Binary files /dev/null and 
b/sw/qa/core/accessibilitycheck/data/FakeCaptionTest.odt differ
diff --git a/sw/source/core/access/AccessibilityCheck.cxx 
b/sw/source/core/access/AccessibilityCheck.cxx
index 3860eb8904e0..0170003c4a48 100644
--- a/sw/source/core/access/AccessibilityCheck.cxx
+++ b/sw/source/core/access/AccessibilityCheck.cxx
@@ -11,12 +11,14 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -26,11 +28,13 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -841,6 +845,67 @@ public:
 }
 };
 
+class FakeCaptionCheck : public NodeCheck
+{
+public:
+FakeCaptionCheck(sfx::AccessibilityIssueCollection& rIssueCollection)
+: NodeCheck(rIssueCollection)
+{
+}
+void check(SwNode* pCurrent) override
+{
+if (!pCurrent->IsTextNode())
+return;
+
+SwTextNode* pTextNode = pCurrent->GetTextNode();
+const OUString& sText = pTextNode->GetText();
+
+if (sText.getLength() == 0)
+return;
+
+// Check if it's a real caption
+const SwNode* aStartFly = pCurrent->FindFlyStartNode();
+if (aStartFly
+&& aStartFly->GetFlyFormat()->GetAnchor().GetAnchorId() != 
RndStdIds::FLY_AS_CHAR)
+return;
+
+auto aIter = SwIterator(*pTextNode);
+auto nCount = 0;
+for (auto aTextFrame = aIter.First(); aTextFrame; aTextFrame = 
aIter.Next())
+{
+

[Libreoffice-commits] core.git: helpcontent2

[Bogdan B (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3765f547cd701dfc69fa61b4948f9522140d457a
Author: Bogdan B 
AuthorDate: Thu Nov 3 08:42:49 2022 +0200
Commit: Gerrit Code Review 
CommitDate: Thu Nov 3 07:42:49 2022 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to f129a53a423805628f95cf72469f48f5279147a6
  - tdf#134882 Improve help about changing label from 'fit' to 'shrink'

Change-Id: Ie7759eea6991defbbb785b7426cddde7f1cebdc2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142146
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 
Tested-by: Jenkins

diff --git a/helpcontent2 b/helpcontent2
index 4de3a5df9563..f129a53a4238 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 4de3a5df9563bb86b7295664b579efd79169d92e
+Subproject commit f129a53a423805628f95cf72469f48f5279147a6

[Libreoffice-commits] help.git: source/text

[Bogdan B (via logerrit)]

 source/text/scalc/01/05070500.xhp |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit f129a53a423805628f95cf72469f48f5279147a6
Author: Bogdan B 
AuthorDate: Wed Nov 2 18:35:52 2022 +0200
Commit: Ilmari Lauhakangas 
CommitDate: Thu Nov 3 07:42:47 2022 +0100

tdf#134882 Improve help about changing label from 'fit' to 'shrink'

Change-Id: Ie7759eea6991defbbb785b7426cddde7f1cebdc2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142146
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 
Tested-by: Jenkins

diff --git a/source/text/scalc/01/05070500.xhp 
b/source/text/scalc/01/05070500.xhp
index 9ef68735eb..d14dfec7eb 100644
--- a/source/text/scalc/01/05070500.xhp
+++ b/source/text/scalc/01/05070500.xhp
@@ -75,7 +75,7 @@
 Specifies a 
scaling factor to scale all printed pages.
 Scaling factor
 Enter a scaling factor. 
Factors less than 100 reduce the pages, higher factors enlarge the 
pages.
-Fit 
print range(s) to width/height
+Shrink 
print range(s) to width/height
 Specifies the 
maximum number of pages horizontally (width) and vertically (height) on which 
every sheet with the current Page Style is to be printed. 
 
 
@@ -92,7 +92,7 @@
 Enter the maximum 
number of pages to be printed horizontally across.
 Height in pages
 Enter the maximum 
number of pages to be printed vertically stacked.
-Fit 
print range(s) on number of pages
+Shrink 
print range(s) to number of pages
 Specifies the 
maximum number of pages on which every sheet with the current Page Style is to 
be printed. The scale will be reduced as necessary to fit the defined number of 
pages.UFI: fixes #112585#
 Number of pages
 Enter the maximum 
number of pages to be printed.

[Libreoffice-commits] core.git: include/sfx2 sw/inc sw/qa sw/source

[Paris Oplopoios (via logerrit)]

 include/sfx2/AccessibilityIssue.hxx  |1 
 sw/inc/AccessibilityCheckStrings.hrc |1 
 sw/qa/core/accessibilitycheck/AccessibilityCheckTest.cxx |   12 ++
 sw/qa/core/accessibilitycheck/data/FakeFootnoteTest.odt  |binary
 sw/source/core/access/AccessibilityCheck.cxx |   72 +++
 5 files changed, 86 insertions(+)

New commits:
commit a1ae31bd248ab62a0614f3a25f1abfcc214ff431
Author: Paris Oplopoios 
AuthorDate: Tue Oct 25 23:53:32 2022 +0300
Commit: Tomaž Vajngerl 
CommitDate: Thu Nov 3 07:41:22 2022 +0100

a11y: Add check for fake footnotes

Add accessibility check and relevant test for a document that has
fake footnotes

Change-Id: I22682a161a858f45c956660a51849bd18fcee0e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141832
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/sfx2/AccessibilityIssue.hxx 
b/include/sfx2/AccessibilityIssue.hxx
index 7ca02ef3b7e9..9d1023053515 100644
--- a/include/sfx2/AccessibilityIssue.hxx
+++ b/include/sfx2/AccessibilityIssue.hxx
@@ -31,6 +31,7 @@ enum class AccessibilityIssueID
 TEXT_FORMATTING,
 HYPERLINK_IS_TEXT,
 HYPERLINK_SHORT,
+FAKE_FOOTNOTE,
 MANUAL_NUMBERING
 };
 
diff --git a/sw/inc/AccessibilityCheckStrings.hrc 
b/sw/inc/AccessibilityCheckStrings.hrc
index 77b93378869f..86be8b494c90 100644
--- a/sw/inc/AccessibilityCheckStrings.hrc
+++ b/sw/inc/AccessibilityCheckStrings.hrc
@@ -21,6 +21,7 @@
 #define STR_TEXT_CONTRAST   NC_("STR_TEXT_CONTRAST", "Text 
contrast is too low.")
 #define STR_TEXT_BLINKING   NC_("STR_TEXT_BLINKING", "Blinking 
text.")
 #define STR_AVOID_FOOTNOTES NC_("STR_AVOID_FOOTNOTES", "Avoid 
footnotes.")
+#define STR_AVOID_FAKE_FOOTNOTESNC_("STR_AVOID_FAKE_FOOTNOTES", "Avoid 
fake footnotes.")
 #define STR_AVOID_ENDNOTES  NC_("STR_AVOID_ENDNOTES", "Avoid 
endnotes.")
 #define STR_AVOID_BACKGROUND_IMAGES NC_("STR_AVOID_BACKGROUND_IMAGES", 
"Avoid background images.")
 #define STR_AVOID_NEWLINES_SPACENC_("STR_AVOID_NEWLINES_SPACE", "Avoid 
newlines to create space.")
diff --git a/sw/qa/core/accessibilitycheck/AccessibilityCheckTest.cxx 
b/sw/qa/core/accessibilitycheck/AccessibilityCheckTest.cxx
index 91d6be266a8c..39f094a38c2a 100644
--- a/sw/qa/core/accessibilitycheck/AccessibilityCheckTest.cxx
+++ b/sw/qa/core/accessibilitycheck/AccessibilityCheckTest.cxx
@@ -131,6 +131,18 @@ CPPUNIT_TEST_FIXTURE(AccessibilityCheckTest, 
testNumberingCheck)
 CPPUNIT_ASSERT_EQUAL(sfx::AccessibilityIssueID::MANUAL_NUMBERING, 
aIssues[4]->m_eIssueID);
 }
 
+CPPUNIT_TEST_FIXTURE(AccessibilityCheckTest, testCheckFakeFootnote)
+{
+SwDoc* pDoc = createSwDoc(DATA_DIRECTORY, "FakeFootnoteTest.odt");
+CPPUNIT_ASSERT(pDoc);
+sw::AccessibilityCheck aCheck(pDoc);
+aCheck.check();
+auto& aIssues = aCheck.getIssueCollection().getIssues();
+CPPUNIT_ASSERT_EQUAL(size_t(2), aIssues.size());
+CPPUNIT_ASSERT_EQUAL(sfx::AccessibilityIssueID::FAKE_FOOTNOTE, 
aIssues[0]->m_eIssueID);
+CPPUNIT_ASSERT_EQUAL(sfx::AccessibilityIssueID::FAKE_FOOTNOTE, 
aIssues[1]->m_eIssueID);
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/qa/core/accessibilitycheck/data/FakeFootnoteTest.odt 
b/sw/qa/core/accessibilitycheck/data/FakeFootnoteTest.odt
new file mode 100644
index ..fdacf6cb35de
Binary files /dev/null and 
b/sw/qa/core/accessibilitycheck/data/FakeFootnoteTest.odt differ
diff --git a/sw/source/core/access/AccessibilityCheck.cxx 
b/sw/source/core/access/AccessibilityCheck.cxx
index 0763ff0e90c5..3860eb8904e0 100644
--- a/sw/source/core/access/AccessibilityCheck.cxx
+++ b/sw/source/core/access/AccessibilityCheck.cxx
@@ -23,6 +23,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -770,6 +771,76 @@ public:
 }
 };
 
+class FakeFootnoteCheck : public NodeCheck
+{
+private:
+void checkAutoFormat(SwTextNode* pTextNode, const SwTextAttr* pTextAttr)
+{
+const SwFormatAutoFormat& rAutoFormat = pTextAttr->GetAutoFormat();
+SfxItemIter aItemIter(*rAutoFormat.GetStyleHandle());
+const SfxPoolItem* pItem = aItemIter.GetCurItem();
+while (pItem)
+{
+if (pItem->Which() == RES_CHRATR_ESCAPEMENT)
+{
+auto pEscapementItem = static_cast(pItem);
+if (pEscapementItem->GetEscapement() == 
SvxEscapement::Superscript
+&& pTextAttr->GetStart() == 0 && pTextAttr->GetAnyEnd() == 
1)
+{
+auto pIssue = lclAddIssue(m_rIssueCollection, 
SwResId(STR_AVOID_FAKE_FOOTNOTES),
+  
sfx::AccessibilityIssueID::FAKE_FOOTNOTE);
+pIssue->setIssueObject(IssueObject::TEXT);
+pIssue->setNode(pTextNode);
+SwDoc& rDocument 

[Libreoffice-bugs] [Bug 143148] Use pragma once instead of include guards (Episode 2: Endgame)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143148

--- Comment #59 from Commit Notification 
 ---
zonnebloempje committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e519b121e3e43e4fd9e8e11c2ead4076ccda422f

tdf#143148 Use pragma once instead of include guards

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/source

[zonnebloempje (via logerrit)]

 vcl/source/control/imivctl.hxx |5 +
 vcl/source/control/wizimpldata.hxx |5 +
 2 files changed, 2 insertions(+), 8 deletions(-)

New commits:
commit e519b121e3e43e4fd9e8e11c2ead4076ccda422f
Author: zonnebloempje 
AuthorDate: Wed Nov 2 23:58:46 2022 -0300
Commit: Ilmari Lauhakangas 
CommitDate: Thu Nov 3 07:35:38 2022 +0100

tdf#143148 Use pragma once instead of include guards

Change-Id: Idf0a645bee9b2fc80bdf152c0703c3d25e3b330f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142189
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/vcl/source/control/imivctl.hxx b/vcl/source/control/imivctl.hxx
index be442e495678..5a052c083efa 100644
--- a/vcl/source/control/imivctl.hxx
+++ b/vcl/source/control/imivctl.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_SVTOOLS_SOURCE_CONTNR_IMIVCTL_HXX
-#define INCLUDED_SVTOOLS_SOURCE_CONTNR_IMIVCTL_HXX
+#pragma once
 
 #include 
 
@@ -508,6 +507,4 @@ public:
 voidOutputSizeChanged();
 };
 
-#endif
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/source/control/wizimpldata.hxx 
b/vcl/source/control/wizimpldata.hxx
index f943c0473aec..7565cb0897e4 100644
--- a/vcl/source/control/wizimpldata.hxx
+++ b/vcl/source/control/wizimpldata.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_VCL_SOURCE_CONTROL_WIZIMPLDATA_HXX
-#define INCLUDED_VCL_SOURCE_CONTROL_WIZIMPLDATA_HXX
+#pragma once
 
 #include 
 
@@ -59,6 +58,4 @@ namespace vcl
 };
 }   // namespace svt
 
-#endif
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

[Libreoffice-commits] core.git: editeng/source include/editeng sd/qa sd/source svx/source

[Tomaž Vajngerl (via logerrit)]

 editeng/source/editeng/editeng.cxx  |4 -
 editeng/source/editeng/editobj.cxx  |6 -
 editeng/source/editeng/editobj2.hxx |   10 +-
 editeng/source/editeng/impedit.hxx  |   30 +++
 editeng/source/editeng/impedit2.cxx |4 -
 editeng/source/editeng/impedit3.cxx |   41 --
 editeng/source/editeng/impedit4.cxx |6 -
 editeng/source/outliner/outlin2.cxx |7 -
 editeng/source/outliner/outliner.cxx|   12 +--
 include/editeng/editeng.hxx |4 -
 include/editeng/outliner.hxx|4 -
 sd/qa/unit/import-tests2.cxx|4 -
 sd/source/ui/view/drtxtob.cxx   |6 -
 svx/source/svdraw/svdotext.cxx  |  110 ++--
 svx/source/svdraw/svdotextdecomposition.cxx |2 
 15 files changed, 139 insertions(+), 111 deletions(-)

New commits:
commit 4c349be1d74c669e5804c3c43f3f0a3960c88bc5
Author: Tomaž Vajngerl 
AuthorDate: Mon Oct 31 13:28:27 2022 +0100
Commit: Tomaž Vajngerl 
CommitDate: Thu Nov 3 07:24:22 2022 +0100

fix rendering of text when "fit to frame" is enabled

This changes the nStretchX and nStretchY from sal_uInt16 to double
so the text in text boxes is rendered correctly (text should be
resized to the same size as the textbox).

Change-Id: Ic92d03043af0abe86f1b67ae15522d0176ebb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142064
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/editeng/source/editeng/editeng.cxx 
b/editeng/source/editeng/editeng.cxx
index 88bc04a9efed..c8a66d0470a4 100644
--- a/editeng/source/editeng/editeng.cxx
+++ b/editeng/source/editeng/editeng.cxx
@@ -2266,12 +2266,12 @@ bool EditEngine::HasText( const SvxSearchItem& 
rSearchItem )
 return pImpEditEngine->HasText( rSearchItem );
 }
 
-void EditEngine::SetGlobalCharStretching( sal_uInt16 nX, sal_uInt16 nY )
+void EditEngine::SetGlobalCharStretching(double nX, double nY)
 {
 pImpEditEngine->SetCharStretching( nX, nY );
 }
 
-void EditEngine::GetGlobalCharStretching( sal_uInt16& rX, sal_uInt16& rY ) 
const
+void EditEngine::GetGlobalCharStretching(double& rX, double& rY) const
 {
 pImpEditEngine->GetCharStretching( rX, rY );
 }
diff --git a/editeng/source/editeng/editobj.cxx 
b/editeng/source/editeng/editobj.cxx
index 6d57c7497c2b..437754d70def 100644
--- a/editeng/source/editeng/editobj.cxx
+++ b/editeng/source/editeng/editobj.cxx
@@ -71,10 +71,10 @@ void XEditAttribute::SetItem(const SfxPoolItem& rNew)
 }
 
 XParaPortionList::XParaPortionList(
-OutputDevice* pRefDev, sal_uInt32 nPW, sal_uInt16 _nStretchX, sal_uInt16 
_nStretchY)
+OutputDevice* pRefDev, sal_uInt32 nPW, double nStretchX, double nStretchY)
 : pRefDevPtr(pRefDev)
-, nStretchX(_nStretchX)
-, nStretchY(_nStretchY)
+, mnStretchX(nStretchX)
+, mnStretchY(nStretchY)
 , nPaperWidth(nPW)
 {
 }
diff --git a/editeng/source/editeng/editobj2.hxx 
b/editeng/source/editeng/editobj2.hxx
index 250341fd4283..86a2e379be20 100644
--- a/editeng/source/editeng/editobj2.hxx
+++ b/editeng/source/editeng/editobj2.hxx
@@ -94,12 +94,12 @@ class XParaPortionList
 ListType maList;
 
 VclPtr pRefDevPtr;
-sal_uInt16  nStretchX;
-sal_uInt16  nStretchY;
+double  mnStretchX;
+double  mnStretchY;
 sal_uInt32  nPaperWidth;
 
 public:
-XParaPortionList(OutputDevice* pRefDev, sal_uInt32 nPW, sal_uInt16 
_nStretchX, sal_uInt16 _nStretchY);
+XParaPortionList(OutputDevice* pRefDev, sal_uInt32 nPW, double nStretchX, 
double nStretchY);
 
 void push_back(XParaPortion* p);
 const XParaPortion& operator[](size_t i) const;
@@ -108,8 +108,8 @@ public:
 sal_uInt32  GetPaperWidth() const   { return nPaperWidth; }
 boolRefDevIsVirtual() const {return 
pRefDevPtr->IsVirtual();}
 const MapMode&  GetRefMapMode() const   { return 
pRefDevPtr->GetMapMode(); }
-sal_uInt16  GetStretchX() const { return nStretchX; }
-sal_uInt16  GetStretchY() const { return nStretchY; }
+double  GetStretchX() const { return mnStretchX; }
+double  GetStretchY() const { return mnStretchY; }
 };
 
 class ContentInfo
diff --git a/editeng/source/editeng/impedit.hxx 
b/editeng/source/editeng/impedit.hxx
index b761e3bc4135..f75e71b7f509 100644
--- a/editeng/source/editeng/impedit.hxx
+++ b/editeng/source/editeng/impedit.hxx
@@ -528,8 +528,8 @@ private:
 
 Color   maBackgroundColor;
 
-sal_uInt16  nStretchX;
-sal_uInt16  nStretchY;
+double mnStretchX;
+double mnStretchY;
 
 CharCompressTypenAsianCompressionMode;
 
@@ -1080,8 +1080,8 @@ public:
 SvxCellJustifyMethodGetJustifyMethod( sal_Int32 nPara ) const;
 SvxCellVerJustify   GetVerJustification( sal_Int32 nPara ) const;
 
-voidSetCharStretching( sal_uInt16 nX, sal_uInt16 nY );
-inline void