[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/tiledrendering/tiledrendering.cxx | 41 +
sw/source/core/fields/docufld.cxx | 11 ++
2 files changed, 51 insertions(+), 1 deletion(-)
New commits:
commit cf9e91f4082a9b01014e99e112e14a12246ce5f2
Author: Dennis Francis
AuthorDate: Thu May 19 15:27:48 2022 +0530
Commit: Miklos Vajna
CommitDate: Tue Jan 3 07:27:10 2023 +
sw: prefer view's redline author name...
to expand SwAuthorFieldType. Redline author name is set in
SwXTextDocument::initializeForTiledRendering each time a new view is
created.
Change-Id: I316e0cae4399796682949de14b6d4b924833eb04
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134608
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Miklos Vajna
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143649
(cherry picked from commit 8be4a713e9f44bf05aebc0a3054654a18b4de065)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143585
Tested-by: Jenkins
diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx
b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index e39dc418f8a2..f9c4e77e1631 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx
@@ -19,6 +19,8 @@
#include
#include
#include
+#include
+#include
#include
#include
@@ -3790,6 +3792,45 @@ CPPUNIT_TEST_FIXTURE(SwTiledRenderingTest,
testDateContentControl)
CPPUNIT_ASSERT_EQUAL(OUString("2022-05-30"),
pTextNode->GetExpandText(pWrtShell->GetLayout()));
}
+CPPUNIT_TEST_FIXTURE(SwTiledRenderingTest, testAuthorField)
+{
+SwXTextDocument* pXTextDocument = createDoc();
+const OUString sAuthor("Abcd Xyz");
+
+uno::Sequence
aPropertyValues1(comphelper::InitPropertySequence(
+{
+{".uno:Author", uno::Any(sAuthor)},
+}));
+pXTextDocument->initializeForTiledRendering(aPropertyValues1);
+
+auto insertAuthorField = [this]()
+{
+uno::Reference const xMSF(mxComponent,
uno::UNO_QUERY_THROW);
+uno::Reference const xTD(mxComponent,
uno::UNO_QUERY_THROW);
+
+auto const xText = xTD->getText();
+auto const xTextCursor = xText->createTextCursor();
+CPPUNIT_ASSERT(xTextCursor.is());
+
+xTextCursor->gotoEnd(false);
+
+uno::Reference const xTextField(
+xMSF->createInstance("com.sun.star.text.textfield.Author"),
uno::UNO_QUERY_THROW);
+
+uno::Reference xTextFieldProps(xTextField,
uno::UNO_QUERY_THROW);
+xTextFieldProps->setPropertyValue("FullName", uno::Any(true));
+
+xText->insertTextContent(xTextCursor, xTextField, false);
+};
+
+insertAuthorField();
+Scheduler::ProcessEventsToIdle();
+
+xmlDocUniquePtr pXmlDoc = parseLayoutDump();
+
+assertXPath(pXmlDoc,
"/root/page[1]/body/txt[1]/SwParaPortion[1]/SwLineLayout[1]/SwFieldPortion[1]",
"expand", sAuthor);
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/fields/docufld.cxx
b/sw/source/core/fields/docufld.cxx
index 2015216f2a91..98010119566e 100644
--- a/sw/source/core/fields/docufld.cxx
+++ b/sw/source/core/fields/docufld.cxx
@@ -315,7 +315,16 @@ OUString SwAuthorFieldType::Expand(sal_uLong nFormat)
{
SvtUserOptions& rOpt = SW_MOD()->GetUserOptions();
if((nFormat & 0xff) == AF_NAME)
-return rOpt.GetFullName();
+{
+// Prefer the view's redline author name.
+// (set in SwXTextDocument::initializeForTiledRendering)
+std::size_t nAuthor = SW_MOD()->GetRedlineAuthor();
+OUString sAuthor = SW_MOD()->GetRedlineAuthor(nAuthor);
+if (sAuthor.isEmpty())
+return rOpt.GetFullName();
+
+return sAuthor;
+}
return rOpt.GetID();
}
[Libreoffice-commits] core.git: vcl/qa vcl/source
vcl/qa/cppunit/pdfexport/data/ref-to-kids.pdf |binary
vcl/qa/cppunit/pdfexport/pdfexport.cxx| 46 ++
vcl/source/gdi/pdfobjectcopier.cxx| 22
3 files changed, 68 insertions(+)
New commits:
commit 68540314ecc801ddff06b843ac2e332b02bd7a3b
Author: Dennis Francis
AuthorDate: Fri Dec 2 13:11:42 2022 +0530
Commit: Miklos Vajna
CommitDate: Tue Jan 3 07:26:25 2023 +
vcl: Copy the resource kind object itself if...
some of the items in that resource are themselves dictionaries instead
of references.
Change-Id: I427386b14fe5507dfdfc9745dad27a8fceefd929
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143564
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Miklos Vajna
(cherry picked from commit 4cb521b28e8582eda1a63bc4d92061fd111a2e3d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144438
Tested-by: Jenkins
diff --git a/vcl/qa/cppunit/pdfexport/data/ref-to-kids.pdf
b/vcl/qa/cppunit/pdfexport/data/ref-to-kids.pdf
index 0390ccad8410..fdda33f78231 100644
Binary files a/vcl/qa/cppunit/pdfexport/data/ref-to-kids.pdf and
b/vcl/qa/cppunit/pdfexport/data/ref-to-kids.pdf differ
diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
index ce070a711911..4cf31e708220 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
@@ -4247,6 +4247,52 @@ CPPUNIT_TEST_FIXTURE(PdfExportTest,
testRexportMediaBoxOrigin)
}
}
+CPPUNIT_TEST_FIXTURE(PdfExportTest, testRexportResourceItemReference)
+{
+// We need to enable PDFium import (and make sure to disable after the
test)
+bool bResetEnvVar = false;
+if (getenv("LO_IMPORT_USE_PDFIUM") == nullptr)
+{
+bResetEnvVar = true;
+osl_setEnvironment(OUString("LO_IMPORT_USE_PDFIUM").pData,
OUString("1").pData);
+}
+comphelper::ScopeGuard aPDFiumEnvVarGuard([&]() {
+if (bResetEnvVar)
+osl_clearEnvironment(OUString("LO_IMPORT_USE_PDFIUM").pData);
+});
+
+// Load the PDF and save as PDF
+vcl::filter::PDFDocument aDocument;
+load(u"ref-to-kids.pdf", aDocument);
+
+std::vector aPages = aDocument.GetPages();
+CPPUNIT_ASSERT_EQUAL(size_t(5), aPages.size());
+
+// Directly go to the inner XObject Im10 that has reference to Font in
page 2.
+auto pInnerIm = aDocument.LookupObject(10);
+CPPUNIT_ASSERT(pInnerIm);
+
+auto pResources
+=
dynamic_cast(pInnerIm->Lookup("Resources"));
+CPPUNIT_ASSERT(pResources);
+auto pFontsReference
+=
dynamic_cast(pResources->LookupElement("Font"));
+CPPUNIT_ASSERT(pFontsReference);
+
+auto pFontsObject = pFontsReference->LookupObject();
+CPPUNIT_ASSERT(pFontsObject);
+
+auto pFontDict
+=
dynamic_cast(pFontsObject->Lookup("FF132"));
+CPPUNIT_ASSERT(pFontDict);
+
+auto pFontDescriptor = pFontDict->LookupObject("FontDescriptor");
+CPPUNIT_ASSERT(pFontDescriptor);
+
+auto pFontWidths = pFontDict->LookupObject("Widths");
+CPPUNIT_ASSERT(pFontWidths);
+}
+
} // end anonymous namespace
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/vcl/source/gdi/pdfobjectcopier.cxx
b/vcl/source/gdi/pdfobjectcopier.cxx
index 67f70d10f2a9..2f32cdc27ce1 100644
--- a/vcl/source/gdi/pdfobjectcopier.cxx
+++ b/vcl/source/gdi/pdfobjectcopier.cxx
@@ -184,6 +184,7 @@ OString
PDFObjectCopier::copyExternalResources(filter::PDFObjectElement& rPage,
// Get the rKind subset of the resource dictionary.
std::map aItems;
+filter::PDFObjectElement* pKindObject = nullptr;
if (auto pResources =
dynamic_cast(rPage.Lookup("Resources")))
{
// Resources is a direct dictionary.
@@ -202,6 +203,7 @@ OString
PDFObjectCopier::copyExternalResources(filter::PDFObjectElement& rPage,
return {};
}
+pKindObject = pReferenced;
aItems = pReferenced->GetDictionaryItems();
}
}
@@ -210,23 +212,37 @@ OString
PDFObjectCopier::copyExternalResources(filter::PDFObjectElement& rPage,
// Resources is an indirect object.
filter::PDFElement* pValue = pPageResources->Lookup(rKind);
if (auto pDictionary =
dynamic_cast(pValue))
+{
// Kind is a direct dictionary.
aItems = pDictionary->GetItems();
+}
else if (filter::PDFObjectElement* pObject =
pPageResources->LookupObject(rKind))
+{
// Kind is an indirect object.
aItems = pObject->GetDictionaryItems();
+pKindObject = pObject;
+}
}
if (aItems.empty())
return {};
SvMemoryStream& rDocBuffer = rPage.GetDocument().GetEditBuffer();
+bool bHasDictValue = false;
for (const auto& rItem : aItems)
{
// For each item copy it over to our output then insert it into aRet.
auto pReference =
dynamic_cast(rItem.second);
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfobjectcopier.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit c060f449371cebc9e447568ae1e0aa0860137e2d
Author: Dennis Francis
AuthorDate: Fri Dec 2 12:50:44 2022 +0530
Commit: Miklos Vajna
CommitDate: Tue Jan 3 07:26:03 2023 +
vcl: copy /Pattern resources too
Change-Id: I3d99f9083fb67c68ddee24d2d285350230533fda
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143563
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Miklos Vajna
(cherry picked from commit cf923b7f892ee8d5c5122c7bd88cb40a2e390a56)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144437
Tested-by: Jenkins
diff --git a/vcl/source/gdi/pdfobjectcopier.cxx
b/vcl/source/gdi/pdfobjectcopier.cxx
index 999be92bd752..67f70d10f2a9 100644
--- a/vcl/source/gdi/pdfobjectcopier.cxx
+++ b/vcl/source/gdi/pdfobjectcopier.cxx
@@ -260,7 +260,7 @@ void
PDFObjectCopier::copyPageResources(filter::PDFObjectElement* pPage, OString
{
rLine.append(" /Resources <<");
static const std::initializer_list aKeys
-= { "ColorSpace", "ExtGState", "Font", "XObject", "Shading" };
+= { "ColorSpace", "ExtGState", "Font", "XObject", "Shading", "Pattern"
};
for (const auto& rKey : aKeys)
{
rLine.append(copyExternalResources(*pPage, rKey, rCopiedResources));
[Libreoffice-commits] core.git: vcl/qa vcl/source
vcl/qa/cppunit/pdfexport/data/ref-to-kids.pdf |binary
vcl/qa/cppunit/pdfexport/pdfexport.cxx| 61 ++
vcl/source/gdi/pdfwriter_impl.cxx | 29 ++--
3 files changed, 85 insertions(+), 5 deletions(-)
New commits:
commit e72f77b8164820569834f5459514c18d2bfd911b
Author: Dennis Francis
AuthorDate: Thu Dec 1 11:47:12 2022 +0530
Commit: Miklos Vajna
CommitDate: Tue Jan 3 07:25:42 2023 +
vcl: use /MediaBox origin in the ctm...
of the inner XObject, else the clip polypolygon may clip out partly or
whole contents. Adjusting the clip polypolygon is not straightforward.
Change-Id: If3b208ba850c3579c9e16c15e4fb2f947dad4406
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143561
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Miklos Vajna
(cherry picked from commit a67dcc248a103098de883a4dd2fa9ff2e1cc1f90)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144436
Tested-by: Jenkins
diff --git a/vcl/qa/cppunit/pdfexport/data/ref-to-kids.pdf
b/vcl/qa/cppunit/pdfexport/data/ref-to-kids.pdf
index 598358a636aa..0390ccad8410 100644
Binary files a/vcl/qa/cppunit/pdfexport/data/ref-to-kids.pdf and
b/vcl/qa/cppunit/pdfexport/data/ref-to-kids.pdf differ
diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
index 428f9d5a132a..ce070a711911 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
@@ -4186,6 +4186,67 @@ CPPUNIT_TEST_FIXTURE(PdfExportTest,
testRexportFilterSingletonArray)
CPPUNIT_ASSERT(it != pEnd);
}
+CPPUNIT_TEST_FIXTURE(PdfExportTest, testRexportMediaBoxOrigin)
+{
+// We need to enable PDFium import (and make sure to disable after the
test)
+bool bResetEnvVar = false;
+if (getenv("LO_IMPORT_USE_PDFIUM") == nullptr)
+{
+bResetEnvVar = true;
+osl_setEnvironment(OUString("LO_IMPORT_USE_PDFIUM").pData,
OUString("1").pData);
+}
+comphelper::ScopeGuard aPDFiumEnvVarGuard([&]() {
+if (bResetEnvVar)
+osl_clearEnvironment(OUString("LO_IMPORT_USE_PDFIUM").pData);
+});
+
+// Load the PDF and save as PDF
+vcl::filter::PDFDocument aDocument;
+load(u"ref-to-kids.pdf", aDocument);
+
+std::vector aPages = aDocument.GetPages();
+CPPUNIT_ASSERT_EQUAL(size_t(5), aPages.size());
+
+// Directly go to the inner XObject Im10 that contains the rectangle
drawings in page 2.
+auto pInnerIm = aDocument.LookupObject(10);
+CPPUNIT_ASSERT(pInnerIm);
+
+constexpr sal_Int32 aOrigin[2] = { -800, -600 };
+sal_Int32 aSize[2] = { 0, 0 };
+
+auto pBBox =
dynamic_cast(pInnerIm->Lookup("BBox"));
+CPPUNIT_ASSERT(pBBox);
+const auto& rElements2 = pBBox->GetElements();
+CPPUNIT_ASSERT_EQUAL(static_cast(4), rElements2.size());
+for (sal_Int32 nIdx = 0; nIdx < 4; ++nIdx)
+{
+const auto* pNumElement =
dynamic_cast(rElements2[nIdx]);
+CPPUNIT_ASSERT(pNumElement);
+if (nIdx < 2)
+CPPUNIT_ASSERT_EQUAL(aOrigin[nIdx],
static_cast(pNumElement->GetValue()));
+else
+aSize[nIdx - 2] = static_cast(pNumElement->GetValue())
- aOrigin[nIdx - 2];
+}
+
+auto pMatrix =
dynamic_cast(pInnerIm->Lookup("Matrix"));
+CPPUNIT_ASSERT(pMatrix);
+const auto& rElements = pMatrix->GetElements();
+CPPUNIT_ASSERT_EQUAL(static_cast(6), rElements.size());
+sal_Int32 aMatTranslate[6]
+= { // Rotation by $\theta$ $cos(\theta), sin(\theta), -sin(\theta),
cos(\theta)$
+0, -1, 1, 0,
+// Translate x,y
+-aOrigin[1] - aSize[1] / 2 + aSize[0] / 2, aOrigin[0] + aSize[0] /
2 + aSize[1] / 2
+ };
+
+for (sal_Int32 nIdx = 0; nIdx < 6; ++nIdx)
+{
+const auto* pNumElement =
dynamic_cast(rElements[nIdx]);
+CPPUNIT_ASSERT(pNumElement);
+CPPUNIT_ASSERT_EQUAL(aMatTranslate[nIdx],
static_cast(pNumElement->GetValue()));
+}
+}
+
} // end anonymous namespace
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx
b/vcl/source/gdi/pdfwriter_impl.cxx
index f4a3145c5085..d95a74aeb6af 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -8873,6 +8873,21 @@ void PDFWriterImpl::writeReferenceXObject(const
ReferenceXObjectEmit& rEmit)
return;
}
+double aOrigin[2] = { 0.0, 0.0 };
+if (auto* pArray =
dynamic_cast(pPage->Lookup("MediaBox")))
+{
+const auto& rElements = pArray->GetElements();
+if (rElements.size() >= 4)
+{
+// get x1, y1 of the rectangle.
+for (sal_Int32 nIdx = 0; nIdx < 2; ++nIdx)
+{
+if (const auto* pNumElement =
dynamic_cast(rElements[nIdx]))
+aOrigin[nIdx] = pNumElement->GetValue();
+}
+}
+}
+
[Libreoffice-bugs] [Bug 152856] New: Problem in editing Hindi Text in Writer.
https://bugs.documentfoundation.org/show_bug.cgi?id=152856 Bug ID: 152856 Summary: Problem in editing Hindi Text in Writer. Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: premda...@gmail.com I use LibreOffice for writing text in my language Hindi which is one among many Indian Languages . My problem is that when I try to edit any word in Hindi , problem crops up . I need to delete the entire line and write it afresh . Kindly look into it and fix it . The one feature I like about LibreOffice is that while saving a document , it automatically goes to the previous location where a similar document was saved earlier . -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148071] change about info Mac OS X to macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=148071 Sierk Bornemann changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||0286 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140286] CALC formula =INFO("OSVERSION") gives wrong output
https://bugs.documentfoundation.org/show_bug.cgi?id=140286 Sierk Bornemann changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||8071 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152855] florianawelkin1
https://bugs.documentfoundation.org/show_bug.cgi?id=152855 himajin100...@gmail.com changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152855] florianawelkin1
https://bugs.documentfoundation.org/show_bug.cgi?id=152855 himajin100...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID URL|https://techgloss.com/ok-go | |ogle-lumos-or-hey-google-lu | |mos/| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152855] florianawelkin1
https://bugs.documentfoundation.org/show_bug.cgi?id=152855 Sierk Bornemann changed: What|Removed |Added Component|Android Editor |deletionRequest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: solenv/gbuild
solenv/gbuild/UnoApiTarget.mk |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
New commits:
commit 9fdf6b4d8317df2a6ccc866fad93292b41c97274
Author: Stephan Bergmann
AuthorDate: Mon Jan 2 08:35:28 2023 +0100
Commit: Stephan Bergmann
CommitDate: Tue Jan 3 07:14:15 2023 +
More verbose unoidl-check errors
Change-Id: Ie9aa57c5fca730c7874a527cbe5a0d463a67a0e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144930
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/solenv/gbuild/UnoApiTarget.mk b/solenv/gbuild/UnoApiTarget.mk
index 25a53dfa0a59..67e8bccca906 100644
--- a/solenv/gbuild/UnoApiTarget.mk
+++ b/solenv/gbuild/UnoApiTarget.mk
@@ -35,9 +35,11 @@ $(if $(UNOAPI_ENTITIES), \
$(if $(UNOAPI_ENTITIES),&& rm -f $${RESPONSEFILE}) \
$(if $(UNOAPI_REFERENCE), \
$(call gb_Output_announce,$(2),$(true),DBc,3) \
- && $(gb_UnoApiTarget_UNOIDLCHECKCOMMAND) $(UNOAPI_REFERENCE) -- \
- $(foreach rdb,$(UNOAPI_DEPRDBS),$(call
gb_UnoApiTarget_get_target,$(rdb))) \
- $(1))
+ && { $(gb_UnoApiTarget_UNOIDLCHECKCOMMAND) $(UNOAPI_REFERENCE) -- \
+ $(foreach rdb,$(UNOAPI_DEPRDBS),$(call
gb_UnoApiTarget_get_target,$(rdb))) \
+ $(1) \
+ || { printf 'ERROR: Published UNO API must not be changed
incompatibly!\n(If published UNO API shall be changed incompatibly after all,
see\n.)\n';
\
+false; } })
endef
$(call gb_UnoApiTarget_get_target,%) :
[Libreoffice-commits] core.git: oox/qa
oox/qa/unit/shape.cxx |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit 1ce6ae04f7faa84d98b10b67f2ef5f24ac1b0129 Author: Stephan Bergmann AuthorDate: Mon Jan 2 13:18:33 2023 +0100 Commit: Stephan Bergmann CommitDate: Tue Jan 3 07:13:11 2023 + -Werror=maybe-uninitialized (Adding just CPPUNIT_ASSERT wasn't enough to silence the warnings at least for my GCC 13 trunk build, so also added the redundant initializations.) Change-Id: I8ec9e097d4725d22dd90e9278a37768a749e292d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144943 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/oox/qa/unit/shape.cxx b/oox/qa/unit/shape.cxx index 19b9f739ad60..094687ffe1df 100644 --- a/oox/qa/unit/shape.cxx +++ b/oox/qa/unit/shape.cxx @@ -336,8 +336,8 @@ CPPUNIT_TEST_FIXTURE(OoxShapeTest, testWriterFontwork) uno::Reference xShapeProps(xDrawPage->getByIndex(0), uno::UNO_QUERY); // Is it a Fontwork? -bool bTextBox; -xShapeProps->getPropertyValue(u"TextBox") >>= bTextBox; +bool bTextBox = bool(); +CPPUNIT_ASSERT(xShapeProps->getPropertyValue(u"TextBox") >>= bTextBox); CPPUNIT_ASSERT(!bTextBox); uno::Reference xTextFrame; @@ -354,8 +354,8 @@ CPPUNIT_TEST_FIXTURE(OoxShapeTest, testWriterFontwork) CPPUNIT_ASSERT(aTextPathSeq.getLength() > 0); comphelper::SequenceAsHashMap aTextPathPropMap(aTextPathSeq); -bool bTextPathOn; -aTextPathPropMap.getValue(u"TextPath") >>= bTextPathOn; +bool bTextPathOn = bool(); +CPPUNIT_ASSERT(aTextPathPropMap.getValue(u"TextPath") >>= bTextPathOn); CPPUNIT_ASSERT(bTextPathOn); // Is it the correct kind of Fontwork?
[Libreoffice-bugs] [Bug 152703] Skia - resizing StartCenter window with mouse leaves black undrawn areas until mouse button released
https://bugs.documentfoundation.org/show_bug.cgi?id=152703 Commit Notification changed: What|Removed |Added Whiteboard||target:7.6.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/osx
vcl/osx/salframeview.mm | 31 ++-
1 file changed, 30 insertions(+), 1 deletion(-)
New commits:
commit d118be7ed4dd6596a8b4d766e8507b6dcaf2b7f7
Author: Patrick Luby
AuthorDate: Mon Jan 2 19:53:46 2023 -0500
Commit: Noel Grandin
CommitDate: Tue Jan 3 07:12:20 2023 +
Related: tdf#152703 Eliminate empty window with Skia/Metal while resizing
The window will clear its background in [SalFrameWindow displayIfNeeded]
so when Skia/Metal is enabled, explicitly flush the Skia graphics to the
window during live resizing or else nothing will be drawn until after live
resizing has ended.
Also, when Skia/Metal is enabled, rapidly resizing a window has a noticeable
amount of flicker so don't send any paint events during live resizing. Also,
it appears that most of the LibreOffice layouts do not change their layout
much during live resizing so apply this change when Skia is not enabled to
ensure consistent behavior whether Skia is enabled or not.
Change-Id: If6423faa72529b9de8735e04e69c9511aceb2276
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144979
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/vcl/osx/salframeview.mm b/vcl/osx/salframeview.mm
index 2f35d3a057b7..de996654bc1d 100644
--- a/vcl/osx/salframeview.mm
+++ b/vcl/osx/salframeview.mm
@@ -36,6 +36,10 @@
#include
#include
+#if HAVE_FEATURE_SKIA
+#include
+#endif
+
#define WHEEL_EVENT_FACTOR 1.5
static sal_uInt16 ImplGetModifierMask( unsigned int nMask )
@@ -215,6 +219,21 @@ static AquaSalFrame* getMouseContainerFrame()
if( GetSalData() && GetSalData()->mpInstance )
{
SolarMutexGuard aGuard;
+
+#if HAVE_FEATURE_SKIA
+// Related: tdf#152703 Eliminate empty window with Skia/Metal while
resizing
+// The window will clear its background so when Skia/Metal is enabled,
+// explicitly flush the Skia graphics to the window during live
+// resizing or else nothing will be drawn until after live resizing
+// has ended.
+if ( [self inLiveResize] && SkiaHelper::isVCLSkiaEnabled() && mpFrame
&& AquaSalFrame::isAlive( mpFrame ) )
+{
+AquaSalGraphics* pGraphics = mpFrame->mpGraphics;
+if ( pGraphics )
+pGraphics->Flush();
+}
+#endif
+
[super displayIfNeeded];
}
}
@@ -317,7 +336,17 @@ static AquaSalFrame* getMouseContainerFrame()
{
mpFrame->UpdateFrameGeometry();
mpFrame->CallCallback( SalEvent::Resize, nullptr );
-mpFrame->SendPaintEvent();
+
+// Related: tdf#152703 Stop flicker with Skia/Metal while resizing
+// When Skia/Metal is enabled, rapidly resizing a window has a
+// noticeable amount of flicker so don't send any paint events during
+// live resizing.
+// Also, it appears that most of the LibreOffice layouts do not change
+// their layout much during live resizing so apply this change when
+// Skia is not enabled to ensure consistent behavior whether Skia is
+// enabled or not.
+if ( ![self inLiveResize] )
+mpFrame->SendPaintEvent();
}
}
[Libreoffice-commits] core.git: vcl/source vcl/unx
vcl/source/control/imp_listbox.cxx|8 ++--
vcl/source/control/listbox.cxx| 14 +++---
vcl/unx/gtk3/salnativewidgets-gtk.cxx | 20 +++-
3 files changed, 24 insertions(+), 18 deletions(-)
New commits:
commit ff7e00e12ff80bd708f31a1d886d000907ceb31a
Author: Ilhan Yesil
AuthorDate: Mon Mar 21 13:27:52 2022 +0100
Commit: Michael Weghorn
CommitDate: Tue Jan 3 07:03:55 2023 +
tdf#148109 Paint background color in listbox
The combobox described in 148109 is indeed a listbox.
If drop down list is not open and only the selected item
is shown without having the focus, the background color
will be paint either it's defined as native control
or not.
Change-Id: I210916fbe07f74aaa5835bf2c88e764b010c6d61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131904
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/vcl/source/control/imp_listbox.cxx
b/vcl/source/control/imp_listbox.cxx
index 531244925062..75bc1fd622e2 100644
--- a/vcl/source/control/imp_listbox.cxx
+++ b/vcl/source/control/imp_listbox.cxx
@@ -2603,6 +2603,10 @@ void ImplWin::ImplDraw(vcl::RenderContext&
rRenderContext, bool bLayout)
if( bMouseOver )
nState |= ControlState::ROLLOVER;
+Color aBackgroundColor = COL_AUTO;
+if (IsControlBackground())
+aBackgroundColor = GetControlBackground();
+
// if parent has no border, then nobody has drawn the background
// since no border window exists. so draw it here.
WinBits nParentStyle = pWin->GetStyle();
@@ -2610,11 +2614,11 @@ void ImplWin::ImplDraw(vcl::RenderContext&
rRenderContext, bool bLayout)
{
tools::Rectangle aParentRect( Point( 0, 0 ),
pWin->GetSizePixel() );
pWin->GetOutDev()->DrawNativeControl( ControlType::Listbox,
ControlPart::Entire, aParentRect,
- nState, aControlValue, OUString() );
+ nState, aControlValue, OUString(),
aBackgroundColor);
}
bNativeOK = rRenderContext.DrawNativeControl(ControlType::Listbox,
ControlPart::Entire, aCtrlRegion,
- nState,
aControlValue, OUString());
+ nState,
aControlValue, OUString(), aBackgroundColor);
}
if (bIsEnabled)
diff --git a/vcl/source/control/listbox.cxx b/vcl/source/control/listbox.cxx
index e463b2ff958c..ce3cbba69aec 100644
--- a/vcl/source/control/listbox.cxx
+++ b/vcl/source/control/listbox.cxx
@@ -771,17 +771,9 @@ void ListBox::StateChanged( StateChangedType nType )
mpImplLB->SetControlBackground( GetControlBackground() );
if ( mpImplWin )
{
-if ( mpImplWin->IsNativeControlSupported(ControlType::Listbox,
ControlPart::Entire) )
-{
-// Transparent background
-mpImplWin->SetBackground();
-mpImplWin->SetControlBackground();
-}
-else
-{
-mpImplWin->SetBackground(
mpImplLB->GetMainWindow()->GetControlBackground() );
-mpImplWin->SetControlBackground(
mpImplLB->GetMainWindow()->GetControlBackground() );
-}
+
+mpImplWin->SetBackground( GetControlBackground() );
+mpImplWin->SetControlBackground( GetControlBackground() );
mpImplWin->SetFont( mpImplLB->GetMainWindow()->GetFont() );
mpImplWin->Invalidate();
}
diff --git a/vcl/unx/gtk3/salnativewidgets-gtk.cxx
b/vcl/unx/gtk3/salnativewidgets-gtk.cxx
index 6fc1be3f8257..f55b45a8b92b 100644
--- a/vcl/unx/gtk3/salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk3/salnativewidgets-gtk.cxx
@@ -1005,9 +1005,8 @@ void GtkSalGraphics::PaintCombobox( GtkStateFlags flags,
cairo_t *cr,
else
{
render_common(mpListboxStyle, cr, aRect, flags);
-render_common(mpListboxBoxStyle, cr, aRect, flags);
-
render_common(mpListboxButtonStyle, cr, aRect, flags);
+render_common(mpListboxBoxStyle, cr, aRect, flags);
gtk_render_arrow(mpListboxButtonArrowStyle, cr,
G_PI,
@@ -1882,13 +1881,24 @@ bool GtkSalGraphics::drawNativeControl( ControlType
nType, ControlPart nPart, co
case RenderType::Combobox:
if (pBgCssProvider)
{
-gtk_style_context_add_provider(mpComboboxEntryStyle,
GTK_STYLE_PROVIDER(pBgCssProvider),
-
GTK_STYLE_PROVIDER_PRIORITY_APPLICATION);
+if (nType == ControlType::Combobox)
+{
+gtk_style_context_add_provider(mpComboboxEntryStyle,
GTK_STYLE_PROVIDER(pBgCssProvider),
+
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - sw/qa sw/source
sw/qa/core/text/data/number-portion-format.odt |binary
sw/qa/core/text/data/number-portion-noformat.docx |binary
sw/qa/core/text/text.cxx| 18 ++
sw/qa/extras/ooxmlexport/data/number-portion-format.odt |binary
sw/qa/extras/ooxmlexport/ooxmlexport13.cxx |6
sw/source/core/text/txtfld.cxx | 10
sw/source/core/unocore/unoportenum.cxx | 20
sw/source/filter/ww8/docxattributeoutput.cxx|2 -
sw/source/filter/ww8/wrtw8nds.cxx | 15 +---
9 files changed, 51 insertions(+), 20 deletions(-)
New commits:
commit 55906cca53315c1dd0018405f64ac386da3b6c2d
Author: Miklos Vajna
AuthorDate: Fri Dec 16 10:31:03 2022 +0100
Commit: Miklos Vajna
CommitDate: Tue Jan 3 07:01:46 2023 +
sw, numbering portion format: ignore char formats covering the entire
paragraph
The bugdoc has a single paragraph, where the numbering portion is bold
in Writer but not in Word.
The reason for this appears to be that Writer considers text node hints
for the formatting of the numbering portion where the hint covers the
entire paragraph, but Word doesn't do this. This behavior was added in
commits cb0e1b52d68aa6d5b505f91cb4ce577f7f3b2a8f (sw, numbering portion
format: consider full-para char formats as well, 2022-10-20) and DOCX
export was also adjusted in commit
f546f7573158e52359bbeae6194a83a1ff8ac52c (DOCX export, numbering portion
format: consider full-para char formats as well, 2022-10-28).
Fix the problem by partially reverting the above two commits and instead
only consider hints that both start and end at the paragraph end. The
revert of the first commit fixes the new bugdoc (its numbering portion
is no longer bold) and the old bugdoc keeps working if the sw UNO API's
text portion enumeration is extended to expose such empty autoformats at
paragraph end.
Related testcases:
- CppunitTest_sw_ooxmlexport13's testTdf123460 explicitly tested that we
don't expose the paragraph marker's formatting on the UNO API.
- CppunitTest_sw_core_text's testNumberPortionFormat now uses the new
ODT markup for these explicit paragraph marker char props (empty text
span at para end).
- CppunitTest_sw_uiwriter2's testTdfChangeNumberingListAutoFormat failed
when only the above first commit (layout) was reverted, so revert the
matching DOCX export commit as well, which is also good for consistency.
- CppunitTest_sw_ooxmlexport18's testNumberPortionFormatFromODT also
used the old ODT markup, updated.
(cherry picked from commit 99ed51bcad4008a4006dcec24aa33fd7f757a433)
Change-Id: Iee8acf72dabcd10b3f4d3d68b83ed248bf50c324
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144674
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144959
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Miklos Vajna
diff --git a/sw/qa/core/text/data/number-portion-format.odt
b/sw/qa/core/text/data/number-portion-format.odt
index 3047153b63af..19b23ae84420 100644
Binary files a/sw/qa/core/text/data/number-portion-format.odt and
b/sw/qa/core/text/data/number-portion-format.odt differ
diff --git a/sw/qa/core/text/data/number-portion-noformat.docx
b/sw/qa/core/text/data/number-portion-noformat.docx
new file mode 100644
index ..b289b9c69ef4
Binary files /dev/null and b/sw/qa/core/text/data/number-portion-noformat.docx
differ
diff --git a/sw/qa/core/text/text.cxx b/sw/qa/core/text/text.cxx
index 0bcd850073e9..38f984661ec5 100644
--- a/sw/qa/core/text/text.cxx
+++ b/sw/qa/core/text/text.cxx
@@ -751,6 +751,24 @@ CPPUNIT_TEST_FIXTURE(SwCoreTextTest,
testNumberPortionFormat)
assertXPath(pXmlDoc, "//Special[@nType='PortionType::Number']", "nHeight",
"480");
}
+CPPUNIT_TEST_FIXTURE(SwCoreTextTest, testNumberPortionNoformat)
+{
+// Given a document with a numbering and a single paragraph, the entire
run is red:
+createSwDoc(DATA_DIRECTORY, "number-portion-noformat.docx");
+
+// When laying out that document:
+xmlDocUniquePtr pXmlDoc = parseLayoutDump();
+
+// Then make sure that just because the entire run is red, the numbering
portion is not red:
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: (COL_AUTO)
+// - Actual : 00ff (COL_LIGHTRED)
+// i.e. the run color affected the color of the number portion in Writer,
but not in Word.
+CPPUNIT_ASSERT_EQUAL(
+OUString(""),
+getXPath(pXmlDoc, "//Special[@nType='PortionType::Number']/SwFont",
"color"));
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - 2 commits - sw/qa sw/source
sw/qa/core/text/data/number-portion-format.odt |binary
sw/qa/core/text/text.cxx| 18 +
sw/qa/extras/ooxmlexport/data/number-portion-format.odt |binary
sw/qa/extras/ooxmlexport/ooxmlexport18.cxx | 20 ++
sw/source/core/text/txtfld.cxx | 22
sw/source/filter/ww8/docxattributeoutput.cxx|2 -
sw/source/filter/ww8/wrtw8nds.cxx | 15 +-
7 files changed, 74 insertions(+), 3 deletions(-)
New commits:
commit 6f4836ae8b72a4f4a5f7a8cb7d32a435a4b96be6
Author: Miklos Vajna
AuthorDate: Fri Oct 28 16:39:31 2022 +0200
Commit: Miklos Vajna
CommitDate: Tue Jan 3 07:01:35 2023 +
DOCX export, numbering portion format: consider full-para char formats as
well
The bugdoc had a single paragraph with direct formatting (24pt font
size), numbering enabled and a bookmark covering half of the paragraph.
The numbering had default font size in the DOCX export result, not
inheriting from the paragraph.
In case the bookmark is removed, then the custom font size is not an
autoformat set on the whole text of the paragraph but rather a format on
the paragraph level, which does influence the formatting of the
numbering portion via the paragraph marker formatting, as expected.
Fix the problem in a way similar to what was done in commit
cb0e1b52d68aa6d5b505f91cb4ce577f7f3b2a8f (sw, numbering portion format:
consider full-para char formats as well, 2022-10-20), except that was
for the rendering and this is for the DOCX export.
This also required filtering out grab-bags in
lcl_writeParagraphMarkerProperties(), otherwise citation SDTs show up in
the export result at unexpected places, as shown by
CppunitTest_sw_ooxmlexport14's testTdf129353.
(cherry picked from commit f546f7573158e52359bbeae6194a83a1ff8ac52c)
Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
Change-Id: I7bb88e290f2a370d78ecc894f306bcb0a403545f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142103
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144958
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Miklos Vajna
diff --git a/sw/qa/extras/ooxmlexport/data/number-portion-format.odt
b/sw/qa/extras/ooxmlexport/data/number-portion-format.odt
new file mode 100644
index ..3047153b63af
Binary files /dev/null and
b/sw/qa/extras/ooxmlexport/data/number-portion-format.odt differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
index c0d3e7c6d161..a77e2ec98ca4 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport18.cxx
@@ -115,6 +115,26 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf152200)
assertXPath(pXmlDoc, "//w:fldChar", 3); // no field characters elsewhere
}
+CPPUNIT_TEST_FIXTURE(Test, testNumberPortionFormatFromODT)
+{
+// Given a document with a single paragraph, direct formatting asks 24pt
font size for the
+// numbering and the text portion:
+load(DATA_DIRECTORY, "number-portion-format.odt");
+
+// When saving to DOCX:
+save("Office Open XML Text", maTempFile);
+mbExported = true;
+
+// Then make sure that the paragraph marker's char format has that custom
font size:
+xmlDocUniquePtr pXmlDoc = parseExport("word/document.xml");
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: 1
+// - Actual : 0
+// - XPath '//w:pPr/w:rPr/w:sz' number of nodes is incorrect
+// i.e. was missing under 's .
+assertXPath(pXmlDoc, "//w:pPr/w:rPr/w:sz", "val", "48");
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx
b/sw/source/filter/ww8/docxattributeoutput.cxx
index b190bf38e581..0bff96233ce4 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -1407,7 +1407,7 @@ void
lcl_writeParagraphMarkerProperties(DocxAttributeOutput& rAttributeOutput, c
bool bFontSizeWritten = false;
while (nWhichId)
{
-if (rParagraphMarkerProperties.GetItemState(nWhichId, true, ) ==
SfxItemState::SET)
+if (rParagraphMarkerProperties.GetItemState(nWhichId, true, ) ==
SfxItemState::SET && nWhichId != RES_CHRATR_GRABBAG)
{
if (isCHRATR(nWhichId) || nWhichId == RES_TXTATR_CHARFMT)
{
diff --git a/sw/source/filter/ww8/wrtw8nds.cxx
b/sw/source/filter/ww8/wrtw8nds.cxx
index 89fe95801f85..42036c163eca 100644
--- a/sw/source/filter/ww8/wrtw8nds.cxx
+++ b/sw/source/filter/ww8/wrtw8nds.cxx
@@ -3211,6 +3211,7 @@ void MSWordExportBase::OutputTextNode( SwTextNode& rNode )
}
else if (const
[Libreoffice-commits] core.git: sw/source
sw/source/core/inc/UndoTable.hxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit 3d72e1f014637e0c1f690014f3f1d4dff32de3d6
Author: Miklos Vajna
AuthorDate: Mon Jan 2 20:10:04 2023 +0100
Commit: Miklos Vajna
CommitDate: Tue Jan 3 07:00:44 2023 +
sw: document SwUndoInsTable
Table autoformat & redlining causes most complications here.
Change-Id: I2639d119bf4cb0baf05919c6de3ce44108b52db1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144965
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/sw/source/core/inc/UndoTable.hxx b/sw/source/core/inc/UndoTable.hxx
index e0f8dd5fb58d..29850d2f07e2 100644
--- a/sw/source/core/inc/UndoTable.hxx
+++ b/sw/source/core/inc/UndoTable.hxx
@@ -53,6 +53,7 @@ void NotifyTableCollapsedParagraph(const SwContentNode*
pNode, SwCursorShell *co
}
+/// Implements undo/redo for Table -> Insert Table.
class SwUndoInsTable final : public SwUndo
{
OUString m_sTableName;
[Libreoffice-bugs] [Bug 152852] LibO writer looses connection to xlsx file as database for series letter and crash when trying to reconnect
https://bugs.documentfoundation.org/show_bug.cgi?id=152852 Robert Großkopf changed: What|Removed |Added CC||rob...@familiegrosskopf.de --- Comment #1 from Robert Großkopf --- Have tested this one. Created a *.xlsx-file. Connected a database file to this *.xslx-file. Created a series letter for this database. Close LO, reopened LO, reopened the Writer file. Could switch to data source. Datasource is almost available. Tested with different LO versions (LO 7.4.3.2, also LO 7.3.6.2). No problem with data source. Might be this is a special problem of packages of your Linux distribution. My system: OpenSUSE 15.3 64bit rpm Linux, packages for LO directly installed from libreoffice.org (not the packages from OpenSUSE). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152855] florianawelkin1
https://bugs.documentfoundation.org/show_bug.cgi?id=152855 florianawelkin1 changed: What|Removed |Added URL||https://techgloss.com/ok-go ||ogle-lumos-or-hey-google-lu ||mos/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152855] New: florianawelkin1
https://bugs.documentfoundation.org/show_bug.cgi?id=152855 Bug ID: 152855 Summary: florianawelkin1 Product: LibreOffice Version: 3.3.1 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Android Editor Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: florianawelk...@gmail.com Description: Google Assistant is Google’s version of a voice assistant similar to other known voice assistants like IOS Siri or Amazon Alexa. Initially launched in 2016, it was an extension of Google now, but after its removal, the Google Assistant can perform all the tasks Google Now could. Actual Results: Google Assistant is Google’s version of a voice assistant similar to other known voice assistants like IOS Siri or Amazon Alexa. Initially launched in 2016, it was an extension of Google now, but after its removal, the Google Assistant can perform all the tasks Google Now could. Expected Results: Google Assistant is Google’s version of a voice assistant similar to other known voice assistants like IOS Siri or Amazon Alexa. Initially launched in 2016, it was an extension of Google now, but after its removal, the Google Assistant can perform all the tasks Google Now could. Reproducible: Always User Profile Reset: Yes Additional Info: Google Assistant is Google’s version of a voice assistant similar to other known voice assistants like IOS Siri or Amazon Alexa. Initially launched in 2016, it was an extension of Google now, but after its removal, the Google Assistant can perform all the tasks Google Now could. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - cui/source include/vcl sc/inc sc/source sfx2/source sw/source vcl/jsdialog vcl/source
cui/source/dialogs/scriptdlg.cxx|3 +--
include/vcl/svapp.hxx |3 +--
sc/inc/validat.hxx |4
sc/source/core/data/validat.cxx | 11 +++
sfx2/source/appl/app.cxx|3 +--
sw/source/uibase/shells/translatehelper.cxx |9 -
vcl/jsdialog/jsdialogbuilder.cxx| 10 +++---
vcl/source/window/builder.cxx |3 +--
8 files changed, 30 insertions(+), 16 deletions(-)
New commits:
commit ac738382d63203965e13d3fe6f7745cdea95ea38
Author: Szymon Kłos
AuthorDate: Fri Dec 2 16:18:02 2022 +0100
Commit: Szymon Kłos
CommitDate: Tue Jan 3 06:36:09 2023 +
jsdialog: fix validation error dialog in Calc
Change-Id: Ie6551e386cd53f6b4bf4cceb6d7bd6170a2072ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143599
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Rashesh Padia
Reviewed-by: Aron Budea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144951
Tested-by: Jenkins
Reviewed-by: Szymon Kłos
diff --git a/cui/source/dialogs/scriptdlg.cxx b/cui/source/dialogs/scriptdlg.cxx
index fc27b3fbf3b6..a2d798e80a78 100644
--- a/cui/source/dialogs/scriptdlg.cxx
+++ b/cui/source/dialogs/scriptdlg.cxx
@@ -1327,8 +1327,7 @@ IMPL_STATIC_LINK( SvxScriptErrorDialog, ShowDialog,
void*, p, void )
xData->pParent,
VclMessageType::Warning,
VclButtonsType::Ok,
-message,
-comphelper::LibreOfficeKit::isActive()));
+message));
xBox->set_title(CuiResId(RID_CUISTR_ERROR_TITLE));
diff --git a/include/vcl/svapp.hxx b/include/vcl/svapp.hxx
index 398358f1bfad..55d7aa87adf2 100644
--- a/include/vcl/svapp.hxx
+++ b/include/vcl/svapp.hxx
@@ -1348,8 +1348,7 @@ public:
static std::unique_ptr CreateInterimBuilder(vcl::Window*
pParent, const OUString , bool bAllowCycleFocusOut, sal_uInt64
nLOKWindowId = 0);
static weld::MessageDialog* CreateMessageDialog(weld::Widget* pParent,
VclMessageType eMessageType,
-VclButtonsType
eButtonType, const OUString& rPrimaryMessage,
-bool bMobile = false);
+VclButtonsType
eButtonType, const OUString& rPrimaryMessage);
static weld::Window* GetFrameWeld(const
css::uno::Reference& rWindow);
diff --git a/sc/inc/validat.hxx b/sc/inc/validat.hxx
index 79eb9b75a334..f28da4a1c50b 100644
--- a/sc/inc/validat.hxx
+++ b/sc/inc/validat.hxx
@@ -30,6 +30,8 @@ struct RefUpdateContext;
}
+namespace vcl { class ILibreOfficeKitNotifier; }
+
class ScPatternAttr;
class ScTokenArray;
class ScTypedStrData;
@@ -80,6 +82,8 @@ private:
using ScConditionEntry::operator==;
+DECL_STATIC_LINK(ScValidationData, InstallLOKNotifierHdl, void*,
vcl::ILibreOfficeKitNotifier*);
+
public:
ScValidationData( ScValidationMode eMode, ScConditionMode eOper,
const OUString& rExpr1, const OUString& rExpr2,
diff --git a/sc/source/core/data/validat.cxx b/sc/source/core/data/validat.cxx
index 79f21d8de202..08f77ad4f862 100644
--- a/sc/source/core/data/validat.cxx
+++ b/sc/source/core/data/validat.cxx
@@ -366,6 +366,11 @@ void ScValidationData::DoCalcError( ScFormulaCell* pCell )
const
DoMacro( pCell->aPos, OUString(), pCell, nullptr );
}
+IMPL_STATIC_LINK_NOARG(ScValidationData, InstallLOKNotifierHdl, void*,
vcl::ILibreOfficeKitNotifier*)
+{
+return SfxViewShell::Current();
+}
+
// true -> abort
bool ScValidationData::DoError(weld::Window* pParent, const OUString& rInput,
@@ -399,12 +404,10 @@ bool ScValidationData::DoError(weld::Window* pParent,
const OUString& rInput,
break;
}
-bool bIsMobile = comphelper::LibreOfficeKit::isActive() &&
SfxViewShell::Current()
-&& SfxViewShell::Current()->isLOKMobilePhone();
-
std::unique_ptr
xBox(Application::CreateMessageDialog(pParent, eType,
- eStyle, aMessage, bIsMobile));
+ eStyle, aMessage));
xBox->set_title(aTitle);
+xBox->SetInstallLOKNotifierHdl(LINK(nullptr, ScValidationData,
InstallLOKNotifierHdl));
switch (eErrorStyle)
{
diff --git a/sfx2/source/appl/app.cxx b/sfx2/source/appl/app.cxx
index 3d3adb84bfe4..f225315d6ecd 100644
--- a/sfx2/source/appl/app.cxx
+++ b/sfx2/source/appl/app.cxx
@@ -413,8 +413,7 @@ IMPL_STATIC_LINK( SfxApplication, GlobalBasicErrorHdl_Impl,
StarBASIC*, pStarBas
pViewFrame ? pViewFrame->GetFrameWeld() : nullptr,
VclMessageType::Error,
VclButtonsType::Ok,
- aError,
- true));
+ aError));
[Libreoffice-bugs] [Bug 152854] Can't install Libre 7.4.3.2
https://bugs.documentfoundation.org/show_bug.cgi?id=152854 Stéphane Guillou (stragu) changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 CC||stephane.guillou@libreoffic ||e.org --- Comment #1 from Stéphane Guillou (stragu) --- Hi Jerry. This might be unrelated to LibreOffice. Have you tried troubleshooting with instruction like https://appuals.com/fix-the-feature-you-are-trying-to-use-in-on-a-network-resource-that-is-unavailable/ ? Or https://answers.microsoft.com/en-us/windows/forum/all/the-feature-you-are-trying-to-use-is-on-a-network/1ac69d0d-1a92-43f0-ace2-f3de73f07e93 Thanks! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152853] MISSING FEATURE
https://bugs.documentfoundation.org/show_bug.cgi?id=152853 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Stéphane Guillou (stragu) --- What do you mean by the "go back" feature? Could you please provide precise steps, including what kind of document you are using, and where that feature used to be located? Thank you! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: svx/source svx/uiconfig
svx/source/sidebar/shadow/ShadowPropertyPanel.cxx |2 +-
svx/uiconfig/ui/sidebarshadow.ui |4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 36de236836ee01f971744540688daad603583998
Author: Szymon Kłos
AuthorDate: Tue Nov 29 19:59:57 2022 +0100
Commit: Szymon Kłos
CommitDate: Tue Jan 3 06:06:24 2023 +
jsdialogs: fix generic color label name
update event was triggering other widget change:
when opened calc and selected shape first time
we saw color text next to other color label
Change-Id: I71670ac1273ce96fafc8d20126d9f32151e96d89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143471
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Pedro Silva
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144950
Tested-by: Jenkins
Reviewed-by: Szymon Kłos
diff --git a/svx/source/sidebar/shadow/ShadowPropertyPanel.cxx
b/svx/source/sidebar/shadow/ShadowPropertyPanel.cxx
index 93259adc27f0..914d13de695d 100644
--- a/svx/source/sidebar/shadow/ShadowPropertyPanel.cxx
+++ b/svx/source/sidebar/shadow/ShadowPropertyPanel.cxx
@@ -50,7 +50,7 @@ ShadowPropertyPanel::ShadowPropertyPanel(
mxFTDistance(m_xBuilder->weld_label("distance")),
mxFTTransparency(m_xBuilder->weld_label("transparency_label")),
mxFTBlur(m_xBuilder->weld_label("blur_label")),
-mxFTColor(m_xBuilder->weld_label("color")),
+mxFTColor(m_xBuilder->weld_label("shadowcolorlabel")),
mxShadowTransSlider(m_xBuilder->weld_scale("transparency_slider")),
mxShadowTransMetric(m_xBuilder->weld_metric_spin_button("FIELD_TRANSPARENCY",
FieldUnit::PERCENT)),
mxShadowBlurMetric(m_xBuilder->weld_metric_spin_button("LB_SHADOW_BLUR",
FieldUnit::POINT))
diff --git a/svx/uiconfig/ui/sidebarshadow.ui b/svx/uiconfig/ui/sidebarshadow.ui
index a2b170ffa792..26e2263134cc 100644
--- a/svx/uiconfig/ui/sidebarshadow.ui
+++ b/svx/uiconfig/ui/sidebarshadow.ui
@@ -89,10 +89,10 @@
-
+
True
False
-Color:
+Color:
True
LB_SHADOW_COLOR
0
[Libreoffice-bugs] [Bug 151009] Sorting, oCellRange.Sort(oSortDesc()), 3 columns by column#2 but column#3 sorted
https://bugs.documentfoundation.org/show_bug.cgi?id=151009 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Resolution|FIXED |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152601] Changes to Shape Text is Sometimes not Saved
https://bugs.documentfoundation.org/show_bug.cgi?id=152601 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152599] Indicate the default template in Start Center templates grid views
https://bugs.documentfoundation.org/show_bug.cgi?id=152599 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152590] UI WollMux sidebar dropdown menu appears detached
https://bugs.documentfoundation.org/show_bug.cgi?id=152590 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152571] Very slow save (macOS, ARM)
https://bugs.documentfoundation.org/show_bug.cgi?id=152571 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152571] Very slow save (macOS, ARM)
https://bugs.documentfoundation.org/show_bug.cgi?id=152571 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152649] Crash with activated SKIA Option
https://bugs.documentfoundation.org/show_bug.cgi?id=152649 --- Comment #9 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152649] Crash with activated SKIA Option
https://bugs.documentfoundation.org/show_bug.cgi?id=152649 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152571] Very slow save (macOS, ARM)
https://bugs.documentfoundation.org/show_bug.cgi?id=152571 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149456] No le permite al usuario la modificación de sus datos personales
https://bugs.documentfoundation.org/show_bug.cgi?id=149456 --- Comment #3 from QA Administrators --- Dear Camila Orjuela, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149456] No le permite al usuario la modificación de sus datos personales
https://bugs.documentfoundation.org/show_bug.cgi?id=149456 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96664] High CPU load when using Master Pages
https://bugs.documentfoundation.org/show_bug.cgi?id=96664 --- Comment #6 from QA Administrators --- Dear bugzilla, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 88749] Edit>Delete Contents should not allow to delete Pivot Table
https://bugs.documentfoundation.org/show_bug.cgi?id=88749 --- Comment #10 from QA Administrators --- Dear Pedro, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 82873] Default behaviour of inserting an image in a list
https://bugs.documentfoundation.org/show_bug.cgi?id=82873 --- Comment #12 from QA Administrators --- Dear Yousuf Philips (jay) (retired), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116251] Problem rendering background rectangle in PDF in LibreOffice Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=116251 --- Comment #4 from QA Administrators --- Dear Kevin Loughrey, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113687] Wrong cell attributes assumed
https://bugs.documentfoundation.org/show_bug.cgi?id=113687 --- Comment #12 from QA Administrators --- Dear Elmar, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152657] Slower graphical performance and laggy behavior on data entry with large window (GTK)
https://bugs.documentfoundation.org/show_bug.cgi?id=152657 --- Comment #13 from lp.allar...@gmail.com --- Created attachment 184455 --> https://bugs.documentfoundation.org/attachment.cgi?id=184455=edit Xorg -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152657] Slower graphical performance and laggy behavior on data entry with large window (GTK)
https://bugs.documentfoundation.org/show_bug.cgi?id=152657 --- Comment #12 from lp.allar...@gmail.com --- Not sure if relevant but I found out Xorg seems to be the one experiencing the most pain. When I simply hold a key down and experience the lag, Xorg goes up near to 100% CPU. Correlation is almost perfect. Same occurs when navigating a spreadsheet and dragging cells around, doing anything really... See attachement "Xorg.png" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152571] Very slow save (macOS, ARM)
https://bugs.documentfoundation.org/show_bug.cgi?id=152571 --- Comment #3 from Jeff Potter --- The files I edit are generated by a PHP script that merges data into an .odt template, but I've been using this script for 12 years and haven't had this issue. The text could not be simpler. I have installed and tested 7.5.0.1 and found it sluggish (a term that I know is hard to quantify) but much improved. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152700] How To Delete Cash App Transaction History And Create A New History Database?
https://bugs.documentfoundation.org/show_bug.cgi?id=152700 Michael Warner changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152700] How To Delete Cash App Transaction History And Create A New History Database?
https://bugs.documentfoundation.org/show_bug.cgi?id=152700 Michael Warner changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152700] How To Delete Cash App Transaction History And Create A New History Database?
https://bugs.documentfoundation.org/show_bug.cgi?id=152700 Michael Warner changed: What|Removed |Added Component|General |deletionRequest Product|cppunit |LibreOffice -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152802] Frequent Crashes when Closing LibreOffice (without data losses, tested on Calc only)
https://bugs.documentfoundation.org/show_bug.cgi?id=152802
Nicolás Adamo changed:
What|Removed |Added
Ever confirmed|0 |1
Resolution|INSUFFICIENTDATA|---
Status|RESOLVED|NEW
--- Comment #2 from Nicolás Adamo ---
Happened again, now with the new user profile:
1) konsole output:
45 -- exe=/usr/lib/libreoffice/program/soffice.bin
20 -- appname=soffice.bin
37 -- apppath=/usr/lib/libreoffice/program
10 -- signal=11
10 -- pid=71688
12 -- startupid=0
KCrash: crashing... crashRecursionCounter = 2
KCrash: Application Name = soffice.bin path = /usr/lib/libreoffice/program pid
= 71688
KCrash: Arguments: /usr/lib/libreoffice/program/soffice.bin --nocrashhandler
KCrash: Attempting to start /usr/lib/drkonqi
2) kcrash output:
Application: soffice (soffice), signal: Segmentation fault
[KCrash Handler]
#4 0x7fc5676df884 in () at /usr/lib/libreoffice/program/libuno_sal.so.3
#5 0x7fc566d391d5 in () at /usr/lib/libreoffice/program/libcomphelper.so
#6 0x7fc566d392f9 in () at /usr/lib/libreoffice/program/libcomphelper.so
#7 0x7fc567400fa5 in () at /usr/lib/libc.so.6
#8 0x7fc567401120 in () at /usr/lib/libc.so.6
#9 0x7fc5673e9297 in () at /usr/lib/libc.so.6
#10 0x7fc5673e934a in __libc_start_main () at /usr/lib/libc.so.6
#11 0x55dab883c065 in ()
[Inferior 1 (process 71688) detached]
3) kcrash output after installing (again) the debug symbols:
Application: soffice (soffice), signal: Segmentation fault
Content of s_kcrashErrorMessage: std::unique_ptr = {get() = }
[KCrash Handler]
#6 0x7fc5676df884 in () at /usr/lib/libreoffice/program/libuno_sal.so.3
#7 0x7fc566d391d5 in () at /usr/lib/libreoffice/program/libcomphelper.so
#8 0x7fc566d392f9 in () at /usr/lib/libreoffice/program/libcomphelper.so
#9 0x7fc567400fa5 in __run_exit_handlers (status=0, listp=0x7fc56759e760
<__exit_funcs>, run_list_atexit=run_list_atexit@entry=true,
run_dtors=run_dtors@entry=true) at exit.c:113
#10 0x7fc567401120 in __GI_exit (status=) at exit.c:143
#11 0x7fc5673e9297 in __libc_start_call_main
(main=main@entry=0x55dab883c020, argc=argc@entry=3,
argv=argv@entry=0x7ffe04c81fb8) at ../sysdeps/nptl/libc_start_call_main.h:74
#12 0x7fc5673e934a in __libc_start_main_impl (main=0x55dab883c020, argc=3,
argv=0x7ffe04c81fb8, init=, fini=,
rtld_fini=, stack_end=0x7ffe04c81fa8) at ../csu/libc-start.c:381
#13 0x55dab883c065 in ()
[Inferior 1 (process 71688) detached]
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152713] option for standard/classic formatting default rather than 'netspeak
https://bugs.documentfoundation.org/show_bug.cgi?id=152713 --- Comment #3 from David Melik --- Every new blank document I create--even on different PCs--has 'do not add space between paragraphs of the same style' deselected, when if it was how you say, it'd be default selected. I also have to repeatedly reselect it even editing same areas. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152854] New: Can't install Libre 7.4.3.2
https://bugs.documentfoundation.org/show_bug.cgi?id=152854 Bug ID: 152854 Summary: Can't install Libre 7.4.3.2 Product: LibreOffice Version: 7.4.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mrrjh...@gmail.com Description: I'm getting the below message- the msi is on my Desktop- never had this problem with previous Libre versions: 'The feature you are trying to use is on a network resource that is unavailable.' Actual Results: No steps to take after 5 install attempts with different downloads. Expected Results: Expected Libre Office to install. Reproducible: Always User Profile Reset: No Additional Info: Install. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152713] option for standard/classic formatting default rather than 'netspeak
https://bugs.documentfoundation.org/show_bug.cgi?id=152713 David Melik changed: What|Removed |Added Status|RESOLVED|REOPENED Ever confirmed|0 |1 Resolution|NOTABUG |--- --- Comment #2 from David Melik --- I did state such steps: if you don't want spacing between paragraphs, you have to select 'do not add space between paragraphs of the same style' every time you edit, which should work for all, anyway, not just same style. Then next time you view that, it's selected again. Please check that and see that it happens, and reopen this. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152853] New: MISSING FEATURE
https://bugs.documentfoundation.org/show_bug.cgi?id=152853 Bug ID: 152853 Summary: MISSING FEATURE Product: LibreOffice Version: 7.4.3.2 release Hardware: All OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: n...@grumpie.ca Description: A few Updates ago, the "Go Back" feature of LibreOffice was Quietly DROPPED. I'm working on an Office file, containing our family recipes. There are MANY instances to Another Recipe would be Very Helpful. Unfortunately, without the "Go Back" feature, returning to the MAIN recipe is a CONVOLUTED Navigation of Menu Items. Would REALLY like to get this feature back. Otherwise, Very Impressed in the capabilities of this program. Ciao, Grumpie Steps to Reproduce: 1.N/A 2. 3. Actual Results: NOT AVAILABLE Expected Results: N/A Reproducible: Always User Profile Reset: No Additional Info: Sorry, Don't know the version when this FIRST Happened; but definitely happening on 7.4.2.3 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152852] New: LibO writer looses connection to xlsx file as database for series letter and crash when trying to reconnect
https://bugs.documentfoundation.org/show_bug.cgi?id=152852 Bug ID: 152852 Summary: LibO writer looses connection to xlsx file as database for series letter and crash when trying to reconnect Product: LibreOffice Version: 7.3.7.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: klaus.ren...@gmx.de Description: Created a LibO writer series letter template using Addresses.xlsx file as database for e.g. addresses. First run after creation works fine. After closing LibO and reopening for working with the same document an error is shown when hitting the data source button: "The connection to the data source could not be established". Going into details it shows "File Addresses.xls could not be loaded". Apparently it looks for an xls file while the connection was made to an xlsx file. When I try to delete the connection and rebuilt it, LibO crashs when hitting 'ok' to save the changes. The bahaviour is the same independent from creating the connection from writer or through base. Steps to Reproduce: 1.Create database with e.g. address files in calc and store as xlsx 2.Create series letter in writer 3.Connect database through series letter assistant or through base 4.Link data fields in series letter with database and e.g. print a few letters 5.Close LibO 6.Reopen the series letter 7.Hit datasource button to select database Actual Results: Error message appears as described Expected Results: The previously linked database should be shown Reproducible: Always User Profile Reset: No Additional Info: none -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152851] New: Mathml import should work even when no xmlns attribute is present
https://bugs.documentfoundation.org/show_bug.cgi?id=152851 Bug ID: 152851 Summary: Mathml import should work even when no xmlns attribute is present Product: LibreOffice Version: 7.4.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Formula Editor Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: beton.10.pjo...@neverbox.com Description: In Html5 tags can be found without the attribute xmlns="http://www.w3.org/1998/Math/MathML;. It would make sense if we could import such mathml into LO ( At the moment it's not working at all). Steps to Reproduce: Go to eg. https://developer.mozilla.org/en-US/docs/Web/MathML/Examples, select an example (let say Pythagorean Theorem) and using you browser's "inspect" contextual menu (in Firefox or Chromium/Chrome, at least), select a tag representing a formula and Copy it. It gives : a 2 + b 2 = c 2 Then in LO formula editor try "Tools-> Import Mathml from clipboard" Actual Results: Nothing is pasted. Import from file would not work either. Expected Results: The selected tag has no xmlns attribute, yet it is perfectly valid Mathml (in the context of html5 which is everywhere now) and should pose no problem of interpretation. The absence of xmlns attribute in should not prevent import; Requiring its presence seems an artificial limit, and I see no good reason for it. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.4.3.2 / LibreOffice Community Build ID: 40(Build:2) CPU threads: 4; OS: Linux 6.0; UI render: default; VCL: gtk3 Locale: fr-FR (fr_FR.UTF-8); UI: en-US Debian package version: 1:7.4.3-2 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: i18npool/source
i18npool/source/localedata/data/ak_GH.xml | 11 +--
i18npool/source/localedata/data/an_ES.xml | 11 +--
i18npool/source/localedata/data/ast_ES.xml | 11 +--
i18npool/source/localedata/data/bm_ML.xml | 11 +--
i18npool/source/localedata/data/bs_BA.xml | 11 +--
i18npool/source/localedata/data/dv_MV.xml | 11 +--
i18npool/source/localedata/data/ee_GH.xml | 11 +--
i18npool/source/localedata/data/en_GH.xml | 11 +--
i18npool/source/localedata/data/fr_BF.xml | 11 +--
i18npool/source/localedata/data/fur_IT.xml | 11 +--
i18npool/source/localedata/data/fy_NL.xml | 11 +--
i18npool/source/localedata/data/gd_GB.xml | 11 +--
i18npool/source/localedata/data/gsc_FR.xml | 11 +--
i18npool/source/localedata/data/gug_PY.xml | 11 +--
i18npool/source/localedata/data/ha_Latn_GH.xml | 11 +--
i18npool/source/localedata/data/haw_US.xml | 11 +--
i18npool/source/localedata/data/hil_PH.xml | 11 +--
i18npool/source/localedata/data/hr_HR.xml | 11 +--
i18npool/source/localedata/data/ht_HT.xml | 11 +--
i18npool/source/localedata/data/jbo.xml| 11 +--
i18npool/source/localedata/data/kab_DZ.xml | 11 +--
i18npool/source/localedata/data/kk_KZ.xml | 11 +--
i18npool/source/localedata/data/kmr_Latn_TR.xml| 11 +--
i18npool/source/localedata/data/lg_UG.xml | 11 +--
i18npool/source/localedata/data/lgr_SB.xml | 11 +--
i18npool/source/localedata/data/lld_IT.xml | 11 +--
i18npool/source/localedata/data/ln_CD.xml | 11 +--
i18npool/source/localedata/data/mk_MK.xml | 11 +--
i18npool/source/localedata/data/mos_BF.xml | 11 +--
i18npool/source/localedata/data/mt_MT.xml | 11 +--
i18npool/source/localedata/data/myv_RU.xml | 11 +--
i18npool/source/localedata/data/ny_MW.xml | 11 +--
i18npool/source/localedata/data/oc_FR_lengadoc.xml | 11 +--
i18npool/source/localedata/data/om_ET.xml | 11 +--
i18npool/source/localedata/data/pap_CW.xml | 11 +--
i18npool/source/localedata/data/plt_MG.xml | 11 +--
i18npool/source/localedata/data/rue_SK.xml | 11 +--
i18npool/source/localedata/data/sc_IT.xml | 11 +--
i18npool/source/localedata/data/sg_CF.xml | 11 +--
i18npool/source/localedata/data/shs_CA.xml | 11 +--
i18npool/source/localedata/data/sid_ET.xml | 11 +--
i18npool/source/localedata/data/so_SO.xml | 11 +--
i18npool/source/localedata/data/ti_ET.xml | 11 +--
i18npool/source/localedata/data/tk_TM.xml | 11 +--
i18npool/source/localedata/data/tpi_PG.xml | 11 +--
i18npool/source/localedata/data/ug_CN.xml | 11 +--
i18npool/source/localedata/data/ur_PK.xml | 11 +--
i18npool/source/localedata/data/vi_VN.xml | 11 +--
48 files changed, 48 insertions(+), 480 deletions(-)
New commits:
commit ef3b7b7118c854d8ca67cc2249b6c08ddc1885eb
Author: Justin Luth
AuthorDate: Sat Dec 31 17:52:34 2022 -0500
Commit: Justin Luth
CommitDate: Mon Jan 2 22:53:58 2023 +
NFC tdf#56258 i18npool NumberingLevel: use ref="en_US"
In preparing to see what improvements can be made to
list defaults, it is helpful to see what customizations
have been made to the US defaults. Those that match
identically were changed to simple refs.
Thanks to https://www.linuxtopia.org/online_books/
linux_tool_guides/the_sed_faq/sedfaq4_013.html
The script there helped to generate sed expressions.
sed -f ref.sed *.xml
- ref.sed -
\##,\## {
:ack
N;
\##! b ack
s#\
\
\
\
\
\
\
\
\
##;
}
---
- ref2.sed -
\##,\## {
:ack
N;
\##! b ack
s#\
\
\
\
\
\
\
\
\
##;
}
Change-Id: I85d8a8ed095f19d08b035d7f2c4e2cd94ff08c76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144890
Tested-by: Justin Luth
Reviewed-by: Justin Luth
diff --git a/i18npool/source/localedata/data/ak_GH.xml
b/i18npool/source/localedata/data/ak_GH.xml
index 8a380241adf3..2c42a3d9f37b 100644
--- a/i18npool/source/localedata/data/ak_GH.xml
+++ b/i18npool/source/localedata/data/ak_GH.xml
[Libreoffice-bugs] [Bug 145988] macOS skia: colors not displayed correctly for all document previews e.g. start center or impress templates
https://bugs.documentfoundation.org/show_bug.cgi?id=145988 --- Comment #59 from خالد حسني --- (In reply to Patrick Luby from comment #58) > (In reply to خالد حسني from comment #57) > > With Skia/Metal: https://paste.debian.net/1265585/ > > With Skia/Raster: https://paste.debian.net/1265583/ > > Thank you for running the patch. The bad news, your output is the same as > mine: both machines are using the same pixel format and alpha types. > > Looking at the Skia source is a bit overwhelming so I am going to see if I > can implement a test when loading Skia/Metal. @Luboš Luñák already does a > test at launch so if can detect something unique on machines that have this > bug, I can then force LibreOffice to switch to Skia/Raster. > > The following patch prints out some debug messages that will tell me if your > machine has drawn red, green, blue, or alpha in an unexpected byte within > the pixel: > > https://gerrit.libreoffice.org/c/core/+/144814/5 > > Can you apply the patch and post the Terminal messages? There should only be > 8 messages: > > ./instdir/LibreOfficeDev.app/Contents/MacOS/soffice 2>&1 | grep > vcl.skia.colortest warn:vcl.skia.colortest:95652:3366207:vcl/skia/SkiaHelper.cxx:251: 24 bit red pixel: colorType: 6 warn:vcl.skia.colortest:95652:3366207:vcl/skia/SkiaHelper.cxx:259: 24 bit green pixel: ff00ff00 colorType: 6 warn:vcl.skia.colortest:95652:3366207:vcl/skia/SkiaHelper.cxx:267: 24 bit blue pixel: ffff colorType: 6 warn:vcl.skia.colortest:95652:3366207:vcl/skia/SkiaHelper.cxx:275: 24 bit white pixel: colorType: 6 warn:vcl.skia.colortest:95652:3366207:vcl/skia/SkiaHelper.cxx:298: 32 bit red pixel: colorType: 6 warn:vcl.skia.colortest:95652:3366207:vcl/skia/SkiaHelper.cxx:306: 32 bit green pixel: aa00aa00 colorType: 6 warn:vcl.skia.colortest:95652:3366207:vcl/skia/SkiaHelper.cxx:314: 32 bit blue pixel: aaaa colorType: 6 warn:vcl.skia.colortest:95652:3366207:vcl/skia/SkiaHelper.cxx:322: 32 bit white pixel: colorType: 6 Which seem identical to your output. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135990] Pasting Writer OLE objects into Impress with Math Formulas not rendering correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=135990 --- Comment #4 from Philippe --- Of course, same problem with Writer OLE in Draw as was reported here : https://www.reddit.com/r/libreoffice/comments/iaza62/how_to_add_math_equations_along_with_text_on/?utm_source=share_medium=web2x=3 That's too bad because embedding this kind of stuff would have been a workaround for https://bugs.documentfoundation.org/show_bug.cgi?id=35033 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 147783] Cannot undo typing in Hyperlink dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=147783 Eyal Rozenberg changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-ux-advise] [Bug 142801] Support partial transparency in table cell backgrounds
https://bugs.documentfoundation.org/show_bug.cgi?id=142801 Eyal Rozenberg changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 125542] Can't close editor via "X" of window manager
https://bugs.documentfoundation.org/show_bug.cgi?id=125542 Rajasekaran Karunanithi changed: What|Removed |Added CC||rajasekara...@gmail.com --- Comment #11 from Rajasekaran Karunanithi --- Still reproducable in LO 7.6 Dev alpha under Windows 10(x64).Couldn't close the formulae window. Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 44355a90b3450111ad87ad4b6607a564e41d7b54 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: en-IN (en_IN); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 80430] [META] Documentation gap for new features
https://bugs.documentfoundation.org/show_bug.cgi?id=80430 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||152296 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152296 [Bug 152296] Add Content Controls submenu to help page(s) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142801] Support partial transparency in table cell backgrounds
https://bugs.documentfoundation.org/show_bug.cgi?id=142801 Eyal Rozenberg changed: What|Removed |Added Keywords||needsUXEval -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142801] Support partial transparency in table cell backgrounds
https://bugs.documentfoundation.org/show_bug.cgi?id=142801 Eyal Rozenberg changed: What|Removed |Added Blocks||100366 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100366 [Bug 100366] [META] Impress/Draw table bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 100366] [META] Impress/Draw table bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=100366 Eyal Rozenberg changed: What|Removed |Added Depends on||142801 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142801 [Bug 142801] Support partial transparency in table cell backgrounds -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108640] [META] Object meta bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108640 Eyal Rozenberg changed: What|Removed |Added Depends on||143055 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143055 [Bug 143055] Snap-to-grid button should be on more toolbars, optionally or by default -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152548] Line numbering sizes inconsistent when decreasing font size
https://bugs.documentfoundation.org/show_bug.cgi?id=152548 --- Comment #4 from Eyal Rozenberg --- (In reply to Dieter from comment #3) > Eyal, I can see different font size, but don't know how to see the specific > value. Ah, yes, it's not like I got a notification about the size. I just compared it to numbers in the text itself, which are 6pt; and then I had another paragraph with text in larger size 7pt and sort of eyeballed it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152781] Format - Character: too many warnings in console with debug LO
https://bugs.documentfoundation.org/show_bug.cgi?id=152781 --- Comment #6 from BogdanB --- In /core/writerfilter/source/dmapper/ThemeHandler.cxx we have: case 0x540a: // lidSpanishUS in fromLCIDToScriptTag() -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152781] Format - Character: too many warnings in console with debug LO
https://bugs.documentfoundation.org/show_bug.cgi?id=152781
--- Comment #5 from BogdanB ---
(In reply to BogdanB from comment #4)
> (In reply to Eike Rathke from comment #2)
> > Regarding the
> > svtools/source/misc/langtab.cxx:244: Language
> > warnings, that's a good source of information what on-the-fly language tags
> > are added to the predefined list. Nothing to worry about.
> > To be investigated though is whether attempting to obtain some more than
> > once could be avoided.
> >
> > svl/source/items/itempool.cxx:442: old secondary pool
> > should be looked at.
>
> In my list of languages from Character window I see that some languages are
> checked, from example, French (Monaco). But in the list from description is
> just Spanish. So, I supose something is not well detected about Spanish
> language. ("Language: 0x7e0 with unknown name").
I searched in svtools/source/misc/langtab.cxx:244 and the number is formed by
0x plus the number for language.
-
warn:svtools.misc:86308:86308:svtools/source/misc/langtab.cxx:244: Language:
0x540a with unknown name, so returning lang-tag of: Spanish (United States)
{es-US}
For this warning for example in lang.h line 400 we have
#define LANGUAGE_SPANISH_UNITED_STATES LanguageType(0x540A)
Could be upper case the reason for error?
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/bitmap.hxx| 15 ++
vcl/source/bitmap/bitmappaint.cxx | 253 --
2 files changed, 150 insertions(+), 118 deletions(-)
New commits:
commit 5244e7cab70a3c1f567e2e3cda41bd753e5cb530
Author: Noel Grandin
AuthorDate: Mon Jan 2 19:21:34 2023 +0200
Commit: Noel Grandin
CommitDate: Mon Jan 2 20:23:10 2023 +
split OutputDevice::CreateMask method
to make it easier to understand, very little of the code is shared
between the nTol == 0 and the nTol != 0 cases.
Also flatten the code structure a little.
Change-Id: I601b9046a6678a5dcf2176dbfe565a9a4e7299d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144962
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/vcl/bitmap.hxx b/include/vcl/bitmap.hxx
index 123b48fcd752..a732e77f3a97 100644
--- a/include/vcl/bitmap.hxx
+++ b/include/vcl/bitmap.hxx
@@ -343,6 +343,19 @@ public:
*/
boolRotate( Degree10 nAngle10, const Color& rFillColor
);
+/** Create on-off mask from bitmap
+
+This method creates a bitmask from the bitmap, where every
+pixel that equals rTransColor is set transparent, the rest
+opaque.
+
+@param rTransColor
+Color value where the bitmask should be transparent
+
+@return the resulting bitmask.
+ */
+Bitmap CreateMask( const Color& rTransColor ) const;
+
/** Create on-off mask from bitmap
This method creates a bitmask from the bitmap, where every
@@ -359,7 +372,7 @@ public:
@return the resulting bitmask.
*/
-Bitmap CreateMask( const Color& rTransColor, sal_uInt8
nTol = 0 ) const;
+Bitmap CreateMask( const Color& rTransColor, sal_uInt8
nTol ) const;
/** Create region of similar colors in a given rectangle
diff --git a/vcl/source/bitmap/bitmappaint.cxx
b/vcl/source/bitmap/bitmappaint.cxx
index c0f6715238e7..cdece0f438ed 100644
--- a/vcl/source/bitmap/bitmappaint.cxx
+++ b/vcl/source/bitmap/bitmappaint.cxx
@@ -433,18 +433,19 @@ bool Bitmap::Rotate(Degree10 nAngle10, const Color&
rFillColor)
return bRet;
};
-Bitmap Bitmap::CreateMask(const Color& rTransColor, sal_uInt8 nTol) const
+Bitmap Bitmap::CreateMask(const Color& rTransColor) const
{
ScopedReadAccess pReadAcc(const_cast(*this));
+if (!pReadAcc)
+return Bitmap();
// Historically LO used 1bpp masks, but 8bpp masks are much faster,
// better supported by hardware, and the memory savings are not worth
// it anymore.
// TODO: Possibly remove the 1bpp code later.
-if (!nTol && pReadAcc
-&& (pReadAcc->GetScanlineFormat() == ScanlineFormat::N1BitLsbPal
-|| pReadAcc->GetScanlineFormat() == ScanlineFormat::N1BitMsbPal)
+if ((pReadAcc->GetScanlineFormat() == ScanlineFormat::N1BitLsbPal
+ || pReadAcc->GetScanlineFormat() == ScanlineFormat::N1BitMsbPal)
&& pReadAcc->GetBestMatchingColor(COL_WHITE) ==
pReadAcc->GetBestMatchingColor(rTransColor))
{
// if we're a 1 bit pixel already, and the transcolor matches the
color that would replace it
@@ -455,146 +456,164 @@ Bitmap Bitmap::CreateMask(const Color& rTransColor,
sal_uInt8 nTol) const
auto ePixelFormat = vcl::PixelFormat::N8_BPP;
Bitmap aNewBmp(GetSizePixel(), ePixelFormat, ::GetGreyPalette(256));
BitmapScopedWriteAccess pWriteAcc(aNewBmp);
-bool bRet = false;
+if (!pWriteAcc)
+return Bitmap();
-if (pWriteAcc && pReadAcc)
-{
-const tools::Long nWidth = pReadAcc->Width();
-const tools::Long nHeight = pReadAcc->Height();
-const BitmapColor aBlack(pWriteAcc->GetBestMatchingColor(COL_BLACK));
-const BitmapColor aWhite(pWriteAcc->GetBestMatchingColor(COL_WHITE));
+const tools::Long nWidth = pReadAcc->Width();
+const tools::Long nHeight = pReadAcc->Height();
+const BitmapColor aBlack(pWriteAcc->GetBestMatchingColor(COL_BLACK));
+const BitmapColor aWhite(pWriteAcc->GetBestMatchingColor(COL_WHITE));
+
+const BitmapColor aTest(pReadAcc->GetBestMatchingColor(rTransColor));
-if (!nTol)
+if (pWriteAcc->GetScanlineFormat() == pReadAcc->GetScanlineFormat() &&
aWhite.GetIndex() == 1
+&& (pReadAcc->GetScanlineFormat() == ScanlineFormat::N1BitLsbPal
+|| pReadAcc->GetScanlineFormat() == ScanlineFormat::N1BitMsbPal))
+{
+for (tools::Long nY = 0; nY < nHeight; ++nY)
{
-const BitmapColor
aTest(pReadAcc->GetBestMatchingColor(rTransColor));
+Scanline pSrc = pReadAcc->GetScanline(nY);
+Scanline pDst = pWriteAcc->GetScanline(nY);
+assert(pWriteAcc->GetScanlineSize() ==
pReadAcc->GetScanlineSize());
+const tools::Long nScanlineSize = pWriteAcc->GetScanlineSize();
+for (tools::Long nX = 0; nX < nScanlineSize; ++nX)
+
[Libreoffice-bugs] [Bug 152296] Add Content Controls submenu to help page(s)
https://bugs.documentfoundation.org/show_bug.cgi?id=152296 Olivier Hallot changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |olivier.hallot@libreoffice. |desktop.org |org -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151009] Sorting, oCellRange.Sort(oSortDesc()), 3 columns by column#2 but column#3 sorted
https://bugs.documentfoundation.org/show_bug.cgi?id=151009 Nick changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #6 from Nick --- Many thanks!!! In more than my humble opinion, the documentations NEEDS to be changed to show the index is from the the specified range. As far as I know, any other index is specified from the sheet. Note that Tammy found the same problem I did by using the sheet index. Again, thank you. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152850] New: bad scoping of sqrt after mathml import
https://bugs.documentfoundation.org/show_bug.cgi?id=152850 Bug ID: 152850 Summary: bad scoping of sqrt after mathml import Product: LibreOffice Version: 7.4.3.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Formula Editor Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: beton.10.pjo...@neverbox.com Description: import of mathml formula has incorrect structure Steps to Reproduce: import (eg. by paste from clipboard) http://www.w3.org/1998/Math/MathML;>ab/c Actual Results: the resulting formula is incorrect in LO Math: the sqrt encompasses the "c" Expected Results: the Mathml tag structure is clear : the "c" must remain outside the root. Reproducible: Always User Profile Reset: No Additional Info: The problem is not with the division by c : http://www.w3.org/1998/Math/MathML;>ab*c similarly imports the c under the root. Version: 7.4.3.2 / LibreOffice Community Build ID: 40(Build:2) CPU threads: 4; OS: Linux 6.0; UI render: default; VCL: gtk3 Locale: fr-FR (fr_FR.UTF-8); UI: en-US Debian package version: 1:7.4.3-2 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152296] Add Content Controls submenu to help page(s)
https://bugs.documentfoundation.org/show_bug.cgi?id=152296 Olivier Hallot changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113524] Crash linking text modules between writer docs and formatting templates; already had to re-install libreoffice
https://bugs.documentfoundation.org/show_bug.cgi?id=113524 --- Comment #14 from BogdanB --- (In reply to Ree from comment #13) > when I attempt to open an Open Office doc., I have to first RECOVER it, then > I OFTEN get message that can't open, and shows this link: > files:///C:/Program%20Files%20(x86)/OpenOffice%/204/Program/..Program/ > oleautobridge.uno.dll > Sometimes I can open in WordPad, but most often not, and the document is > lost (to me). > HELP, PLEASE!! > THANK YOU You are using OpenOffice, not LibreOffice. It's not the same thing. This bug reporting tools is for LibreOffice. Download LibreOffice, open the document with LibreOffice and see if the document open well. https://www.libreoffice.org/download/download-libreoffice/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 80430] [META] Documentation gap for new features
https://bugs.documentfoundation.org/show_bug.cgi?id=80430 Bug 80430 depends on bug 151169, which changed state. Bug 151169 Summary: [LOCALHELP] Add Chart table new feature Help page https://bugs.documentfoundation.org/show_bug.cgi?id=151169 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152849] New: conditional formatting entry field exists; but is not visible
https://bugs.documentfoundation.org/show_bug.cgi?id=152849 Bug ID: 152849 Summary: conditional formatting entry field exists; but is not visible Product: LibreOffice Version: 7.6.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: p...@pfortin.com Same as bug 139246. Is this dependent on desktop? The field exists; but without any visual indication, it leaves the user initially confused. See https://bugs.documentfoundation.org/attachment.cgi?id=139246 Operating System: Mageia 9 KDE Plasma Version: 5.26.4 KDE Frameworks Version: 5.101.0 Qt Version: 5.15.7 Kernel Version: 6.1.1-server-2.mga9 (64-bit) Graphics Platform: X11 Processors: 20 × 12th Gen Intel® Core™ i7-12700K Memory: 125.5 GiB of RAM Graphics Processor: AMD Radeon RX 6600 XT Manufacturer: Dell Inc. Product Name: XPS 8950 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152846] LibreOffice Writer Settings - Unnecessary unwanted white rectangular area behind list menus /w arrows (kf5)
https://bugs.documentfoundation.org/show_bug.cgi?id=152846 V Stuart Foote changed: What|Removed |Added Summary|LibreOffice Writer Settings |LibreOffice Writer Settings |- Unnecessary unwanted |- Unnecessary unwanted |white rectangular area |white rectangular area |behind list menus /w arrows |behind list menus /w arrows ||(kf5) CC||vsfo...@libreoffice.org -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sd/qa svx/sdi sw/sdi
sd/qa/unit/uiimpress.cxx |2 +-
svx/sdi/svx.sdi | 16
sw/sdi/swriter.sdi |4 ++--
3 files changed, 11 insertions(+), 11 deletions(-)
New commits:
commit cc4ead451cb3b6ce6994370b3a9263756ea284d1
Author: Caolán McNamara
AuthorDate: Thu Dec 29 19:37:57 2022 +
Commit: Caolán McNamara
CommitDate: Mon Jan 2 19:04:31 2023 +
Resolves: tdf#150339 two arguments called "Color"
from around:
commit 780d83771af89e6b27b3618d9c033c3fb29ba803
Date: Mon Nov 4 17:17:58 2019 +0100
jsdialogs: .uno:Color with string argument
and:
commit 1144712bb99cfb699e73b473ee44351c50a35613
Date: Mon Oct 28 10:19:50 2019 +0100
jsdialogs: make possible to set .uno:BackgroundColor in Writer
SvxColorItem Color SID_ATTR_CHAR_COLOR
(SfxStringItem Color SID_ATTR_COLOR_STR, SvxColorItem Color
SID_ATTR_CHAR_COLOR,...
^ ^
rename the most recently added to "ColorString"
Change-Id: I9e00be60c768af124be7df800df4b26df83b5267
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144866
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sd/qa/unit/uiimpress.cxx b/sd/qa/unit/uiimpress.cxx
index 13f072cf2488..0235cada8194 100644
--- a/sd/qa/unit/uiimpress.cxx
+++ b/sd/qa/unit/uiimpress.cxx
@@ -757,7 +757,7 @@ CPPUNIT_TEST_FIXTURE(SdUiImpressTest, testPageFillColor)
// Set FillPageColor
uno::Sequence
aPropertyValues(comphelper::InitPropertySequence({
-{ "Color", uno::Any(OUString("ff")) },
+{ "ColorString", uno::Any(OUString("ff")) },
}));
dispatchCommand(mxComponent, ".uno:FillPageColor", aPropertyValues);
diff --git a/svx/sdi/svx.sdi b/svx/sdi/svx.sdi
index d1f02f5b1d3b..f2e040712566 100644
--- a/svx/sdi/svx.sdi
+++ b/svx/sdi/svx.sdi
@@ -408,7 +408,7 @@ SfxVoidItem TableDesign SID_TABLEDESIGN
]
SvxColorItem BackgroundColor SID_BACKGROUND_COLOR
-(SfxStringItem Color SID_ATTR_COLOR_STR, SvxColorItem BackgroundColor
SID_BACKGROUND_COLOR)
+(SfxStringItem ColorString SID_ATTR_COLOR_STR, SvxColorItem BackgroundColor
SID_BACKGROUND_COLOR)
[
AutoUpdate = TRUE,
@@ -1506,7 +1506,7 @@ SfxVoidItem ClearOutline SID_OUTLINE_DELETEALL
SvxColorItem Color SID_ATTR_CHAR_COLOR
-(SfxStringItem Color SID_ATTR_COLOR_STR, SvxColorItem Color
SID_ATTR_CHAR_COLOR, SfxInt16Item ColorThemeIndex SID_ATTR_COLOR_THEME_INDEX,
SfxInt16Item ColorLumMod SID_ATTR_COLOR_LUM_MOD, SfxInt16Item ColorLumOff
SID_ATTR_COLOR_LUM_OFF)
+(SfxStringItem ColorString SID_ATTR_COLOR_STR, SvxColorItem Color
SID_ATTR_CHAR_COLOR, SfxInt16Item ColorThemeIndex SID_ATTR_COLOR_THEME_INDEX,
SfxInt16Item ColorLumMod SID_ATTR_COLOR_LUM_MOD, SfxInt16Item ColorLumOff
SID_ATTR_COLOR_LUM_OFF)
[
AutoUpdate = TRUE,
FastCall = FALSE,
@@ -1524,7 +1524,7 @@ SvxColorItem Color SID_ATTR_CHAR_COLOR
]
SvxColorItem CharBackColor SID_ATTR_CHAR_BACK_COLOR
-(SfxStringItem Color SID_ATTR_COLOR_STR, SvxColorItem CharBackColor
SID_ATTR_CHAR_BACK_COLOR)
+(SfxStringItem ColorString SID_ATTR_COLOR_STR, SvxColorItem CharBackColor
SID_ATTR_CHAR_BACK_COLOR)
[
AutoUpdate = TRUE,
FastCall = FALSE,
@@ -2798,7 +2798,7 @@ XFillBitmapItem FillPageBitmap SID_ATTR_PAGE_BITMAP
]
XFillColorItem FillColor SID_ATTR_FILL_COLOR
-(SfxStringItem Color SID_ATTR_COLOR_STR, XFillColorItem FillColor
SID_ATTR_FILL_COLOR, SfxInt16Item ColorThemeIndex SID_ATTR_COLOR_THEME_INDEX,
SfxInt16Item ColorLumMod SID_ATTR_COLOR_LUM_MOD, SfxInt16Item ColorLumOff
SID_ATTR_COLOR_LUM_OFF)
+(SfxStringItem ColorString SID_ATTR_COLOR_STR, XFillColorItem FillColor
SID_ATTR_FILL_COLOR, SfxInt16Item ColorThemeIndex SID_ATTR_COLOR_THEME_INDEX,
SfxInt16Item ColorLumMod SID_ATTR_COLOR_LUM_MOD, SfxInt16Item ColorLumOff
SID_ATTR_COLOR_LUM_OFF)
[
AutoUpdate = TRUE,
FastCall = FALSE,
@@ -2816,7 +2816,7 @@ XFillColorItem FillColor SID_ATTR_FILL_COLOR
]
XFillColorItem FillPageColor SID_ATTR_PAGE_COLOR
-(SfxStringItem Color SID_ATTR_COLOR_STR)
+(SfxStringItem ColorString SID_ATTR_COLOR_STR)
[
/* flags: */
AutoUpdate = TRUE,
@@ -5677,7 +5677,7 @@ SfxVoidItem ArrowsToolbox SID_DRAWTBX_ARROWS
]
SvxColorItem FrameLineColor SID_FRAME_LINECOLOR
-(SfxStringItem Color SID_ATTR_COLOR_STR, SvxColorItem FrameLineColor
SID_FRAME_LINECOLOR)
+(SfxStringItem ColorString SID_ATTR_COLOR_STR, SvxColorItem FrameLineColor
SID_FRAME_LINECOLOR)
[
AutoUpdate = TRUE,
FastCall = FALSE,
@@ -7874,7 +7874,7 @@ SdrOnOffItem FillShadow SID_ATTR_FILL_SHADOW
]
XColorItem FillShadowColor SID_ATTR_SHADOW_COLOR
-(SfxStringItem Color SID_ATTR_COLOR_STR)
+(SfxStringItem ColorString SID_ATTR_COLOR_STR)
[
AutoUpdate = TRUE,
@@ -9118,7 +9118,7 @@ SvxWordLineModeItem WordMode SID_ATTR_CHAR_WORDLINEMODE
XLineColorItem XLineColor SID_ATTR_LINE_COLOR
-(SfxStringItem Color SID_ATTR_COLOR_STR, XLineColorItem XLineColor
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - cui/source
cui/source/dialogs/SpellDialog.cxx |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) New commits: commit 9adcf14d9b2e9dffd47a26eae202da348675a5e4 Author: Rafael Lima AuthorDate: Wed Nov 2 18:54:24 2022 +0200 Commit: Caolán McNamara CommitDate: Mon Jan 2 19:03:52 2023 + tdf#116566 Make Spellcheck dialog respect dark background This patch makes the sentence in the spellcheck dialog respect the colors in the selected color scheme. More specifically, it uses the AutoSpellcheck color and the Font Color in the Edit Engine. Change-Id: I0f8e842417645250c9145d1e37d8cf52c290379e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142147 Tested-by: Jenkins Reviewed-by: Caolán McNamara (cherry picked from commit 1de8308d40fad8e9281d2b491f8c5c919fda82f4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144910 diff --git a/cui/source/dialogs/SpellDialog.cxx b/cui/source/dialogs/SpellDialog.cxx index 49e1415e744e..21f7f2b4da80 100644 --- a/cui/source/dialogs/SpellDialog.cxx +++ b/cui/source/dialogs/SpellDialog.cxx @@ -1140,6 +1140,7 @@ void SentenceEditWindow_Impl::SetDrawingArea(weld::DrawingArea* pDrawingArea) OutputDevice& rDevice = pDrawingArea->get_ref_device(); rDevice.SetBackground(aBgColor); m_xEditView->SetBackgroundColor(aBgColor); +m_xEditEngine->SetBackgroundColor(aBgColor); } SentenceEditWindow_Impl::~SentenceEditWindow_Impl() @@ -1671,8 +1672,13 @@ void SentenceEditWindow_Impl::MoveErrorMarkTo(sal_Int32 nStart, sal_Int32 nEnd, m_xEditEngine->RemoveAttribs(aAll, false, EE_CHAR_WEIGHT_CJK); m_xEditEngine->RemoveAttribs(aAll, false, EE_CHAR_WEIGHT_CTL); +// tdf#116566 Use color defined in the current Color Scheme +Color aSpellErrorCollor = svtools::ColorConfig().GetColorValue(svtools::SPELL).nColor; + +// TODO: Create a new Color Scheme entry for grammar mistakes and use it below +// instead of using hardcoded COL_LIGHTBLUE SfxItemSet aSet(m_xEditEngine->GetEmptyItemSet()); -aSet.Put(SvxColorItem(bGrammarError ? COL_LIGHTBLUE : COL_LIGHTRED, EE_CHAR_COLOR)); +aSet.Put(SvxColorItem(bGrammarError ? COL_LIGHTBLUE : aSpellErrorCollor, EE_CHAR_COLOR)); aSet.Put(SvxWeightItem(WEIGHT_BOLD, EE_CHAR_WEIGHT)); aSet.Put(SvxWeightItem(WEIGHT_BOLD, EE_CHAR_WEIGHT_CJK)); aSet.Put(SvxWeightItem(WEIGHT_BOLD, EE_CHAR_WEIGHT_CTL));
[Libreoffice-bugs] [Bug 113524] Crash linking text modules between writer docs and formatting templates; already had to re-install libreoffice
https://bugs.documentfoundation.org/show_bug.cgi?id=113524 --- Comment #13 from Ree --- when I attempt to open an Open Office doc., I have to first RECOVER it, then I OFTEN get message that can't open, and shows this link: files:///C:/Program%20Files%20(x86)/OpenOffice%/204/Program/..Program/oleautobridge.uno.dll Sometimes I can open in WordPad, but most often not, and the document is lost (to me). HELP, PLEASE!! THANK YOU -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152795] Black text on very dark grey background in menus after computer was locked
https://bugs.documentfoundation.org/show_bug.cgi?id=152795 V Stuart Foote changed: What|Removed |Added Resolution|--- |WORKSFORME Status|UNCONFIRMED |RESOLVED CC||vsfo...@libreoffice.org --- Comment #3 from V Stuart Foote --- Fixed for the 7.5.0 release, with 7.4.x builds you still need to enable experimental features from Tools -> Options -> Advanced tab. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152818] Type dt F3 and undo: warning in console with debug LO
https://bugs.documentfoundation.org/show_bug.cgi?id=152818 BogdanB changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #6 from BogdanB --- Changed to NEW based on comment 4 about messages in the console. (Please ignore the crash part of this bug.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 BogdanB changed: What|Removed |Added Depends on|152818 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152818 [Bug 152818] Type dt F3 and undo: warning in console with debug LO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105948] [META] Undo/Redo bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105948 BogdanB changed: What|Removed |Added Depends on|152818 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152818 [Bug 152818] Type dt F3 and undo: warning in console with debug LO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152818] Type dt F3 and undo: warning in console with debug LO
https://bugs.documentfoundation.org/show_bug.cgi?id=152818 BogdanB changed: What|Removed |Added Blocks|105948, 133092 | Summary|Crash with dt F3 and undo: |Type dt F3 and undo: |warning in console with |warning in console with |debug LO|debug LO --- Comment #5 from BogdanB --- I tried again a Restart in Safe Mode - Factory Settings and the crash is gone. Bad user profile. Just this warnings remains. warn:legacy.osl:293393:293393:xmloff/source/transform/OOo2Oasis.cxx:1945: duplicate doc handler warn:sw.core:293393:293393:sw/source/core/attr/format.cxx:215: ~SwFormat: format still has clients on death, but parent format is missing: Frameformat warn:legacy.osl:293393:293393:sw/source/core/access/accmap.cxx:1064: invalid event combination warn:legacy.osl:293393:293393:sw/source/core/access/accmap.cxx:1064: invalid event combination warn:legacy.osl:293393:293393:sw/source/core/access/accmap.cxx:1064: invalid event combination Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105948 [Bug 105948] [META] Undo/Redo bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=133092 [Bug 133092] [META] Crash bugs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152742] Writer tells me I'm writing Afrikaans - but I never chose that
https://bugs.documentfoundation.org/show_bug.cgi?id=152742 خالد حسني changed: What|Removed |Added Blocks|43808 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=43808 [Bug 43808] [META] Right-To-Left and Complex Text Layout language issues (RTL/CTL) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left and Complex Text Layout language issues (RTL/CTL)
https://bugs.documentfoundation.org/show_bug.cgi?id=43808 خالد حسني changed: What|Removed |Added Depends on|152742 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152742 [Bug 152742] Writer tells me I'm writing Afrikaans - but I never chose that -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/uibase/shells/shells.cxx | 31 +++
sw/source/uibase/shells/textfld.cxx | 10 ++
2 files changed, 41 insertions(+)
New commits:
commit a178a2ac6df8dc63a7ab8d4a19b90ae8a17baca4
Author: Miklos Vajna
AuthorDate: Mon Jan 2 14:45:53 2023 +0100
Commit: Miklos Vajna
CommitDate: Mon Jan 2 18:26:32 2023 +
sw UI: fix crash on inserting a fieldmark inside a fieldmark
Inserting a fieldmark using .uno:TextFormField, then entering into that
fieldmark using the cursor, finally doing in insertion again using
.uno:TextFormField resulted in a crash.
The problem is that lcl_SetFieldMarks() uses 3
IDocumentContentOperations().InsertString() calls to insert the field
start/separator/end, but right after inserting the field start we
already create an sw::InsertText hint, which works with an inconsistent
string (the start is already inserted but not the separator / end).
Fix the problem by just not allowing the insertion of fieldmarks inside
fieldmarks on the UI: these are meant to be read-only for the user, so
fieldmark insertion is OK to be not working, as long as a clear error
message is provided.
An alternative approach would be to insert the inner fieldmark in a way
similar to how import filters can do it, but that would be more work.
Change-Id: I7d1a7c638b179fd9149ccdc47215329e3433b6e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144947
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sw/qa/uibase/shells/shells.cxx b/sw/qa/uibase/shells/shells.cxx
index a6603984afbb..2f89720cf570 100644
--- a/sw/qa/uibase/shells/shells.cxx
+++ b/sw/qa/uibase/shells/shells.cxx
@@ -501,6 +501,37 @@ CPPUNIT_TEST_FIXTURE(SwUibaseShellsTest,
testUpdateBookmarks)
CPPUNIT_ASSERT_EQUAL(OUString("Anew result 1Cnew result 2E"), aActual);
}
+CPPUNIT_TEST_FIXTURE(SwUibaseShellsTest, testInsertFieldmarkReadonly)
+{
+// Given a document with a fieldmark, the cursor inside the fieldmark:
+createSwDoc();
+uno::Sequence aArgs = {
+comphelper::makePropertyValue("FieldType",
uno::Any(OUString(ODF_UNHANDLED))),
+comphelper::makePropertyValue("FieldCommand", uno::Any(OUString("my
command"))),
+comphelper::makePropertyValue("FieldResult", uno::Any(OUString("my
result"))),
+};
+dispatchCommand(mxComponent, ".uno:TextFormField", aArgs);
+SwDoc* pDoc = getSwDoc();
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+SwCursor* pCursor = pWrtShell->GetCursor();
+pCursor->SttEndDoc(/*bSttDoc=*/true);
+pWrtShell->Right(SwCursorSkipMode::Chars, /*bSelect=*/false, 1,
/*bBasicCall=*/false);
+
+// When trying to insert an inner fieldmark:
+// Without the accompanying fix in place, this test would have crashed.
+dispatchCommand(mxComponent, ".uno:TextFormField", aArgs);
+
+// Then make sure the read-only content refuses to accept that inner
fieldmark, so we still have
+// just one:
+size_t nActual = 0;
+IDocumentMarkAccess& rIDMA = *pDoc->getIDocumentMarkAccess();
+for (auto it = rIDMA.getFieldmarksBegin(); it != rIDMA.getFieldmarksEnd();
++it)
+{
+++nActual;
+}
+CPPUNIT_ASSERT_EQUAL(static_cast(1), nActual);
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/uibase/shells/textfld.cxx
b/sw/source/uibase/shells/textfld.cxx
index 12cc13a15bd2..aad7d0891bd9 100644
--- a/sw/source/uibase/shells/textfld.cxx
+++ b/sw/source/uibase/shells/textfld.cxx
@@ -719,6 +719,16 @@ FIELD_INSERT:
aFieldCode = pFieldCode->GetValue();
}
+if (rSh.HasReadonlySel())
+{
+// Inform the user that the request has been ignored.
+auto xInfo = std::make_shared(
+GetView().GetFrameWeld(),
"modules/swriter/ui/inforeadonlydialog.ui",
+"InfoReadonlyDialog");
+weld::DialogController::runAsync(xInfo, [](sal_Int32
/*nResult*/) {});
+break;
+}
+
rSh.GetDoc()->GetIDocumentUndoRedo().StartUndo(SwUndoId::INSERT_FORM_FIELD,
nullptr);
// Don't update the layout after inserting content and before
deleting temporary
// text nodes.
[Libreoffice-bugs] [Bug 152818] Crash with dt F3 and undo: warning in console with debug LO
https://bugs.documentfoundation.org/show_bug.cgi?id=152818 --- Comment #4 from Laurent Balland --- I was not able to reproduce with my own build based on master source of today: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 3a177c154470cbecf288e516760fb1d43d601ddb CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR Calc: threaded (In reply to BogdanB from comment #0) > In the dbg build of LibreOffice I get in terminal this warnings after dt/F3: > warn:legacy.osl:397371:397371:xmloff/source/transform/OOo2Oasis.cxx:1945: > duplicate doc handler > warn:sw.core:397371:397371:sw/source/core/attr/format.cxx:215: ~SwFormat: > format still has clients on death, but parent format is missing: Frameformat I get the same messages in console -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152845] no visible AutoText preview in high contrast mode (Windows)
https://bugs.documentfoundation.org/show_bug.cgi?id=152845 V Stuart Foote changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC||vsfo...@libreoffice.org --- Comment #1 from V Stuart Foote --- Confirmed, Win10 with each of the 3 of the 4 predefined HC modes. The Win10 "High Contrast White" mode the example auto text is fully readable. But, the dialog should perform some sort of fg/bg toggle as needed to make the example auto text visible. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/headless vcl/inc
vcl/headless/svpinst.cxx | 82 ---
vcl/inc/headless/svpinst.hxx |9 +++-
2 files changed, 22 insertions(+), 69 deletions(-)
New commits:
commit 91526a2f53d5c7a703b9fc5fbc1728ee50854cc1
Author: Tor Lillqvist
AuthorDate: Thu Dec 29 12:16:25 2022 +0200
Commit: Tor Lillqvist
CommitDate: Mon Jan 2 17:57:16 2023 +
Use std synchronisation APIs instead of a pipe
The immediate reason for this is that pipes are broken in the
Emscripten runtime, see
https://github.com/emscripten-core/emscripten/issues/13214. But if we
can drop the use of a pipe for other platforms, too, why not.
Without this, when attemting to run Collabora Online as WASM, I get:
Aborted(Assertion failed: nRet == 1, at:
.../vcl/headless/svpinst.cxx,538,DoYield)
It is quite possible that the code could be simplified drastically. I
only replaced the use of a pipe with hopefully equivalent use of a
queue, a condition variable, and a mutex.
Change-Id: I9259ba36afeabce6474a1aec827d01bcbbd4412b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144944
Reviewed-by: Michael Meeks
Tested-by: Jenkins
diff --git a/vcl/headless/svpinst.cxx b/vcl/headless/svpinst.cxx
index 5a86826423e3..19eef8997689 100644
--- a/vcl/headless/svpinst.cxx
+++ b/vcl/headless/svpinst.cxx
@@ -22,9 +22,6 @@
#include
-#include
-#include
-#include
#include
#include
#include
@@ -76,14 +73,13 @@ do { \
#define DBG_TESTSVPYIELDMUTEX() ((void)0)
#endif
-#if !defined(ANDROID) && !defined(IOS)
+#if !defined(ANDROID) && !defined(IOS) && !defined(EMSCRIPTEN)
static void atfork_child()
{
if (SvpSalInstance::s_pDefaultInstance != nullptr)
{
-SvpSalInstance::s_pDefaultInstance->CloseWakeupPipe(false);
-SvpSalInstance::s_pDefaultInstance->CreateWakeupPipe(false);
+SvpSalInstance::s_pDefaultInstance->CloseWakeupPipe();
}
}
@@ -97,10 +93,9 @@ SvpSalInstance::SvpSalInstance(
std::unique_ptr pMutex )
m_nTimeoutMS= 0;
m_MainThread = osl::Thread::getCurrentIdentifier();
-CreateWakeupPipe(true);
if( s_pDefaultInstance == nullptr )
s_pDefaultInstance = this;
-#if !defined(ANDROID) && !defined(IOS)
+#if !defined(ANDROID) && !defined(IOS) && !defined(EMSCRIPTEN)
pthread_atfork(nullptr, nullptr, atfork_child);
#endif
}
@@ -109,62 +104,16 @@ SvpSalInstance::~SvpSalInstance()
{
if( s_pDefaultInstance == this )
s_pDefaultInstance = nullptr;
-CloseWakeupPipe(true);
+CloseWakeupPipe();
}
-void SvpSalInstance::CloseWakeupPipe(bool log)
+void SvpSalInstance::CloseWakeupPipe()
{
SvpSalYieldMutex *const
pMutex(dynamic_cast(GetYieldMutex()));
if (!pMutex)
return;
-if (pMutex->m_FeedbackFDs[0] != -1)
-{
-if (log)
-{
-SAL_INFO("vcl.headless", "CloseWakeupPipe: Closing inherited
feedback pipe: [" << pMutex->m_FeedbackFDs[0] << "," <<
pMutex->m_FeedbackFDs[1] << "]");
-}
-close (pMutex->m_FeedbackFDs[0]);
-close (pMutex->m_FeedbackFDs[1]);
-pMutex->m_FeedbackFDs[0] = pMutex->m_FeedbackFDs[1] = -1;
-}
-}
-
-void SvpSalInstance::CreateWakeupPipe(bool log)
-{
-SvpSalYieldMutex *const
pMutex(dynamic_cast(GetYieldMutex()));
-if (!pMutex)
-return;
-if (pipe (pMutex->m_FeedbackFDs) == -1)
-{
-if (log)
-{
-SAL_WARN("vcl.headless", "Could not create feedback pipe: " <<
strerror(errno));
-std::abort();
-}
-}
-else
-{
-if (log)
-{
-SAL_INFO("vcl.headless", "CreateWakeupPipe: Created feedback pipe:
[" << pMutex->m_FeedbackFDs[0] << "," << pMutex->m_FeedbackFDs[1] << "]");
-}
-
-int flags;
-
-// set close-on-exec descriptor flag.
-if ((flags = fcntl (pMutex->m_FeedbackFDs[0], F_GETFD)) != -1)
-{
-flags |= FD_CLOEXEC;
-(void) fcntl(pMutex->m_FeedbackFDs[0], F_SETFD, flags);
-}
-if ((flags = fcntl (pMutex->m_FeedbackFDs[1], F_GETFD)) != -1)
-{
-flags |= FD_CLOEXEC;
-(void) fcntl(pMutex->m_FeedbackFDs[1], F_SETFD, flags);
-}
-
-// retain the default blocking I/O for feedback pipe
-}
+while (!pMutex->m_FeedbackPipe.empty())
+pMutex->m_FeedbackPipe.pop();
}
void SvpSalInstance::TriggerUserEventProcessing()
@@ -328,9 +277,6 @@ void SvpSalInstance::ProcessEvent( SalUserEvent aEvent )
SvpSalYieldMutex::SvpSalYieldMutex()
{
-#ifndef IOS
-m_FeedbackFDs[0] = m_FeedbackFDs[1] = -1;
-#endif
}
SvpSalYieldMutex::~SvpSalYieldMutex()
@@ -367,11 +313,11 @@ void SvpSalYieldMutex::doAcquire(sal_uInt32 const
nLockCount)
m_bNoYieldLock = true;
bool const bEvents = pInst->DoYield(false, request ==
SvpRequest::MainThreadDispatchAllEvents);
m_bNoYieldLock =
[Libreoffice-bugs] [Bug 152818] Crash with dt F3 and undo: warning in console with debug LO
https://bugs.documentfoundation.org/show_bug.cgi?id=152818 --- Comment #3 from BogdanB --- (In reply to Laurent Balland from comment #2) > I was not able to reproduce with master of 2022-12-29 Version: > 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community > Build ID: b9e3e20bfd102880d12384892eaeca094c38a519 > CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: > win > Locale: fr-FR (fr_FR); UI: fr-FR > Calc: CL threaded Maybe is just a Linux crash. We need more tests. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152722] NatNum12 number format (spell out): add/delete decimal places is loosing format
https://bugs.documentfoundation.org/show_bug.cgi?id=152722 Laurent Balland changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |jumbo4...@yahoo.fr |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152657] Slower graphical performance and laggy behavior on data entry with large window (GTK)
https://bugs.documentfoundation.org/show_bug.cgi?id=152657 Stéphane Guillou (stragu) changed: What|Removed |Added Blocks||149495 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149495 [Bug 149495] [META] Regressions from "weld InputBar" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149495] [META] Regressions from "weld InputBar"
https://bugs.documentfoundation.org/show_bug.cgi?id=149495 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||152657 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152657 [Bug 152657] Slower graphical performance and laggy behavior on data entry with large window (GTK) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108660] [META] Formula bar (input line) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108660 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||152657 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=152657 [Bug 152657] Slower graphical performance and laggy behavior on data entry with large window (GTK) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152657] Slower graphical performance and laggy behavior on data entry with large window (GTK)
https://bugs.documentfoundation.org/show_bug.cgi?id=152657 Stéphane Guillou (stragu) changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected CC||caol...@redhat.com Blocks||108660 --- Comment #11 from Stéphane Guillou (stragu) --- bisected with linux-64-7.1 repo to first bad commit: commit e087e25f05e689091cbf1c4f91b6e93878ac17ec author Caolán McNamara Mon Oct 05 14:19:05 2020 +0100 committer Caolán McNamara Fri Oct 16 12:54:14 2020 +0200 tree8adb7ccbfa34e45e549a17bd9ee0a85067db1671 parent d6b7cc3f7c07b98c90194e8b33cf44b94804b525 weld InputBar this also restores that DnD of a selection from the inputbar is pasted as plain text not rich text formatted with the happenstance formatting of the inputbar's EditEngine Change-Id: If4934f83c14357afec2e0a7e1d51c8a1aea1d292 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104037 Tested-by: Caolán McNamara Reviewed-by: Caolán McNamara Caolán, could you please have a look? Using the attachment, with a fullscreen window and the viewport zoomed out a fair bit, the jumps/lag with a single repeated character is noticeable. Removing the inputBar with "View > Formula Bar" stops the lag. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108660 [Bug 108660] [META] Formula bar (input line) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152228] Inconsistent "Show Boundaries" behavior based on document creation method
https://bugs.documentfoundation.org/show_bug.cgi?id=152228 --- Comment #10 from altasilvap...@gmail.com --- Following up on my last statement about suspecting a version mismatch, something caught my eye as I was just about to close this page: If you look at the file attachment section of this document, the "[ContextMenu]->New->Open Document Text" file is showing the type "application/vnd.oasis.opendocument.text" The "File->New->Text Document" file is showing the type "text/plain" I'm new to bugzilla. Is that an indication of a fundamental difference in the file structure of the two files? Because if so, that could be partly our culprit, if they're slightly different "flavors" of ODT and LO is reading them differently. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152848] New: When using accents in a table (spanish), a cell break occurs.
https://bugs.documentfoundation.org/show_bug.cgi?id=152848 Bug ID: 152848 Summary: When using accents in a table (spanish), a cell break occurs. Product: LibreOffice Version: 7.3.7.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: smarti...@gmail.com Created attachment 184454 --> https://bugs.documentfoundation.org/attachment.cgi?id=184454=edit screenshot bug libreoffice When using accents in a table, a cell break occurs. - Language: Spanish (Peru) SO openSUSE Leap 15.4 KDE: 5.24 Linux Kernel: 5.14 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152031] Reducing width of RTL table creates "stairway" effect
https://bugs.documentfoundation.org/show_bug.cgi?id=152031 Stéphane Guillou (stragu) changed: What|Removed |Added Status|RESOLVED|VERIFIED -- You are receiving this mail because: You are the assignee for the bug.
