[Libreoffice-bugs] [Bug 155401] Forms - Navigation: Moving by Tilde (Alt+…) only works with Tab Order = 0 for all fields
https://bugs.documentfoundation.org/show_bug.cgi?id=155401 Robert Großkopf changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=85 ||339 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 85339] FORMCONTROLS: Tabindex is ignored for fields withe the same name
https://bugs.documentfoundation.org/show_bug.cgi?id=85339 Robert Großkopf changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||5401 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 85339] FORMCONTROLS: Tabindex is ignored for fields withe the same name
https://bugs.documentfoundation.org/show_bug.cgi?id=85339 --- Comment #13 from Robert Großkopf --- Bug still exists: Version: 7.6.0.2 (X86_64) / LibreOffice Community Build ID: 41d6f628ba3f046f16b5fa9fa8db8d4c2ab3b582 CPU threads: 6; OS: Linux 5.14; UI render: default; VCL: kf5 (cairo+xcb) Locale: de-DE (de_DE.UTF-8); UI: de-DE Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156692] Crashing after update, no auto-save
https://bugs.documentfoundation.org/show_bug.cgi?id=156692 Kevin Neff changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #4 from Kevin Neff --- Still occurring after update, though less frequently. Windows 10 Pro, 64-bit. Not sure how to action suggestions in first step link and the only one that seems relevant right now is the user profile corruption. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156748] CALC adopting Excel border line weights has corrupted existing sheets especially with Conditional Formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=156748 --- Comment #1 from Colin --- Created attachment 188940 --> https://bugs.documentfoundation.org/attachment.cgi?id=188940=edit Screen dump demonstrating the impact of adopting the EXCEL line weights -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156748] New: CALC adopting Excel border line weights has corrupted existing sheets especially with Conditional Formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=156748 Bug ID: 156748 Summary: CALC adopting Excel border line weights has corrupted existing sheets especially with Conditional Formatting Product: LibreOffice Version: 7.4.7.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: that.man.co...@gmail.com Description: Existing sheet cells have been defined with the original LO line weights for outline borders. When cells are conditionally formatted, the border line weight is defined - initially as standard weight. Recent changes have implemented new line weights as the original LO standard weights clashed with the EXCEL heavier standard line weights. Original LO standard line weights in existing sheets remain as their former weights. New cell border weights in existing sheets are constructed using the new default so inconsistency of outlines is creeping into existing sheets If Conditional formatting is applied then the new EXCEL defaults are applied, thereby creating outline anomalies. SEE ATTACHED SCREEN IMAGE Steps to Reproduce: Using any sheet containing outline formatting created BEFORE the new line weights were adopted. Create any conditional formatting to change the characteristics of the fill colour and observe that the outline weight is now changed to the new weight. ISODD(ROW()) is a simple condition to flip fill colours This is probably to be expected as the new condition will imply the new weights but surely something needs to be in place to either update all existing line weights on all sheets to ensure consistency of weights or ensure the user is aware of the inconsistent line weights and any possible manual settings to obviate the anomaly. The obverse also applies. If an existing CF contains the original LO Line Weights and is applied to a newly outlined array then the CF corrupts the later EXCEL weight outlines with the original LO weights Actual Results: See Attached Image Expected Results: Consistent line weights Reproducible: Always User Profile Reset: No Additional Info: Version: 7.4.7.2 (x64) / LibreOffice Community Build ID: 723314e595e8007d3cf785c16538505a1c878ca5 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: sv-SE (en_GB); UI: en-GB Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156510] Support list styles or paragraph styles "not sticking" when the style in the other category changes
https://bugs.documentfoundation.org/show_bug.cgi?id=156510 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 156510] Support list styles or paragraph styles "not sticking" when the style in the other category changes
https://bugs.documentfoundation.org/show_bug.cgi?id=156510 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 156623] - Android Viewer can't open any office files and crashed
https://bugs.documentfoundation.org/show_bug.cgi?id=156623 --- Comment #56 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 156507] Ability to remove all "atypical" characters in a stretch of text
https://bugs.documentfoundation.org/show_bug.cgi?id=156507 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 156507] Ability to remove all "atypical" characters in a stretch of text
https://bugs.documentfoundation.org/show_bug.cgi?id=156507 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156623] - Android Viewer can't open any office files and crashed
https://bugs.documentfoundation.org/show_bug.cgi?id=156623 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 109087] [META] Calc sheet header and footer bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109087 Bug 109087 depends on bug 148814, which changed state. Bug 148814 Summary: When editing a footer/header in Libreoffice Calc, you cannot use keyboard shortcuts (such as CTRL+C/CTRL+V/CTRL+A) in your native language. Keyboard shortcuts work only in English. https://bugs.documentfoundation.org/show_bug.cgi?id=148814 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102593 Bug 102593 depends on bug 148814, which changed state. Bug 148814 Summary: When editing a footer/header in Libreoffice Calc, you cannot use keyboard shortcuts (such as CTRL+C/CTRL+V/CTRL+A) in your native language. Keyboard shortcuts work only in English. https://bugs.documentfoundation.org/show_bug.cgi?id=148814 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148814] When editing a footer/header in Libreoffice Calc, you cannot use keyboard shortcuts (such as CTRL+C/CTRL+V/CTRL+A) in your native language. Keyboard shortcuts work only
https://bugs.documentfoundation.org/show_bug.cgi?id=148814 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148814] When editing a footer/header in Libreoffice Calc, you cannot use keyboard shortcuts (such as CTRL+C/CTRL+V/CTRL+A) in your native language. Keyboard shortcuts work only
https://bugs.documentfoundation.org/show_bug.cgi?id=148814 --- Comment #9 from QA Administrators --- Dear Leonid, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 129661] [META] Right-To-Left (RTL) user interface issues
https://bugs.documentfoundation.org/show_bug.cgi?id=129661 Bug 129661 depends on bug 104318, which changed state. Bug 104318 Summary: CTL, CJK, and Western Language controls in the GUI cause confusion, handling languages and script selection needs rework--comfortable for a "Global" user community https://bugs.documentfoundation.org/show_bug.cgi?id=104318 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112139] [META] Options dialog's Language settings bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112139 Bug 112139 depends on bug 104318, which changed state. Bug 104318 Summary: CTL, CJK, and Western Language controls in the GUI cause confusion, handling languages and script selection needs rework--comfortable for a "Global" user community https://bugs.documentfoundation.org/show_bug.cgi?id=104318 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104318] CTL, CJK, and Western Language controls in the GUI cause confusion, handling languages and script selection needs rework--comfortable for a "Global" user community
https://bugs.documentfoundation.org/show_bug.cgi?id=104318 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 104318] CTL, CJK, and Western Language controls in the GUI cause confusion, handling languages and script selection needs rework--comfortable for a "Global" user community
https://bugs.documentfoundation.org/show_bug.cgi?id=104318 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEW |RESOLVED -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 104318] CTL, CJK, and Western Language controls in the GUI cause confusion, handling languages and script selection needs rework--comfortable for a "Global" user community
https://bugs.documentfoundation.org/show_bug.cgi?id=104318 --- Comment #37 from QA Administrators --- Dear Toby Anderson, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153428] Elements Sidebar area should be open itself when I insert Math formula into Writer document
https://bugs.documentfoundation.org/show_bug.cgi?id=153428 --- Comment #5 from QA Administrators --- Dear Roman Kuznetsov, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 104318] CTL, CJK, and Western Language controls in the GUI cause confusion, handling languages and script selection needs rework--comfortable for a "Global" user community
https://bugs.documentfoundation.org/show_bug.cgi?id=104318 --- Comment #37 from QA Administrators --- Dear Toby Anderson, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 95427] Filled cells coordinates showed in wrong locate in HTML format
https://bugs.documentfoundation.org/show_bug.cgi?id=95427 --- Comment #8 from QA Administrators --- Dear Feyza, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 89096] Pasting images and text from a website results in distorted images
https://bugs.documentfoundation.org/show_bug.cgi?id=89096 --- Comment #5 from QA Administrators --- Dear Aidas, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 85339] FORMCONTROLS: Tabindex is ignored for fields withe the same name
https://bugs.documentfoundation.org/show_bug.cgi?id=85339 --- Comment #12 from QA Administrators --- Dear Robert Großkopf, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 74862] FILEOPEN: DOC filter: embedded WAV (OLE) does not open properly on Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=74862 --- Comment #6 from QA Administrators --- Dear Sean Young, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 71954] EDITING: drag and drop text into database form fields will not get stored
https://bugs.documentfoundation.org/show_bug.cgi?id=71954 --- Comment #14 from QA Administrators --- Dear e325001, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 70533] EDITING: Drop caps prevents arrow down to move to next line
https://bugs.documentfoundation.org/show_bug.cgi?id=70533 --- Comment #11 from QA Administrators --- Dear Y, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143556] FILESAVE DOCX drawing lockedCanvas is destroyed on save
https://bugs.documentfoundation.org/show_bug.cgi?id=143556 --- Comment #2 from QA Administrators --- Dear Regina Henschel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 53007] VIEWING: In bar (and column) charts, can't totally remove space between bars
https://bugs.documentfoundation.org/show_bug.cgi?id=53007 --- Comment #14 from QA Administrators --- Dear Hyogapag, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135227] Empty image frame after moving an image
https://bugs.documentfoundation.org/show_bug.cgi?id=135227 --- Comment #7 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134509] FILEOPEN DOCX: Text behind image (confirmed MSWord layout bug)
https://bugs.documentfoundation.org/show_bug.cgi?id=134509 --- Comment #15 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 123417] File with lots of comments opens slower compared to LibO 4.4.7.2
https://bugs.documentfoundation.org/show_bug.cgi?id=123417 --- Comment #11 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113144] Selecting a Hebrew character with the mouse doesn't select its diacritics
https://bugs.documentfoundation.org/show_bug.cgi?id=113144 --- Comment #7 from QA Administrators --- Dear Yousuf Philips (jay) (retired), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108837] Graphic object size will be changed incorrectly under vertical writing mode
https://bugs.documentfoundation.org/show_bug.cgi?id=108837 --- Comment #14 from QA Administrators --- Dear Franklin Weng, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156723] [GRAMMAR CHECKER] False positives in pleonasms checkers for pt-BR
https://bugs.documentfoundation.org/show_bug.cgi?id=156723 Aaron changed: What|Removed |Added CC||aaronth...@gmail.com Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Aaron --- Thank you for reporting the bug. Unfortunately without clear steps to reproduce it, we cannot track down the origin of the problem. Please provide a clearer set of step-by-step instructions on how to reproduce the problem. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested information is provided. Please also use English to report the bug. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156747] Unsaved files not recovering on next launch.
https://bugs.documentfoundation.org/show_bug.cgi?id=156747 m.a.riosv changed: What|Removed |Added Ever confirmed|0 |1 CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEEDINFO --- Comment #2 from m.a.riosv --- Please test in safe mode, Menu/Help/Restart in Safe Mode Have you enable the option for recovery? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156746] Office Calc Selected Cell Highlight Color
https://bugs.documentfoundation.org/show_bug.cgi?id=156746 m.a.riosv changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- Please update to 7.5, there are a lot of improvements about dark mode. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156745] CLI PDF export: document is 2 pages instead of 7
https://bugs.documentfoundation.org/show_bug.cgi?id=156745 Aron Budea changed: What|Removed |Added CC||aron.bu...@gmail.com Keywords||bisected -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 109085] LO exits abruptly when logging off in Windows while LO is running
https://bugs.documentfoundation.org/show_bug.cgi?id=109085 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||6769 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146769] Reopen documents from previous session on start
https://bugs.documentfoundation.org/show_bug.cgi?id=146769 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||9085 CC||mikekagan...@hotmail.com Version|6.4.7.2 release |Inherited From OOo -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156730] FILESAVE: Unable To Save A Large Spreadsheet in Calc V7.5.5.2
https://bugs.documentfoundation.org/show_bug.cgi?id=156730 --- Comment #3 from m.a.riosv --- Then can you share the file that can be saved with 7.4.3.2, but not now? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155257] Document recovery dialog should not delay the opening of unrelated files
https://bugs.documentfoundation.org/show_bug.cgi?id=155257 Justin L changed: What|Removed |Added Version|7.4.5.1 release |Inherited From OOo --- Comment #4 from Justin L --- It sounds like a bad idea to me. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 129624] When recovering TAB-sep chart file, tabs are replaced by commas
https://bugs.documentfoundation.org/show_bug.cgi?id=129624 Justin L changed: What|Removed |Added Severity|normal |enhancement Priority|medium |lowest Hardware|x86-64 (AMD64) |All -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112970] [META] Document recovery bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112970 Bug 112970 depends on bug 137878, which changed state. Bug 137878 Summary: Too many error dialogs when a file is not found for recovery https://bugs.documentfoundation.org/show_bug.cgi?id=137878 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 34694] [META] Improve usability of error messages
https://bugs.documentfoundation.org/show_bug.cgi?id=34694 Bug 34694 depends on bug 137878, which changed state. Bug 137878 Summary: Too many error dialogs when a file is not found for recovery https://bugs.documentfoundation.org/show_bug.cgi?id=137878 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137878] Too many error dialogs when a file is not found for recovery
https://bugs.documentfoundation.org/show_bug.cgi?id=137878 Justin L changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED Assignee|libreoffice-b...@lists.free |jl...@mail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137878] Too many error dialogs when a file is not found for recovery
https://bugs.documentfoundation.org/show_bug.cgi?id=137878 Commit Notification changed: What|Removed |Added Whiteboard||target:24.2.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: framework/source
framework/source/services/autorecovery.cxx |3 +++
1 file changed, 3 insertions(+)
New commits:
commit f1c3526dee49927f7efb79bef285e3688264ec3f
Author: Justin Luth
AuthorDate: Thu Aug 10 15:42:58 2023 -0400
Commit: Justin Luth
CommitDate: Sat Aug 12 01:36:13 2023 +0200
tdf#137878 autorecovery: reduce "file not found" pop-ups
For a DOCX file, there were four of them during a recovery
if the file was on a USB or renamed or whatever.
Now there aren't any.
Change-Id: I5cbad6e4ed1a1bc1d3b8e805a6b493f4ee61ec68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155567
Reviewed-by: Justin Luth
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/framework/source/services/autorecovery.cxx
b/framework/source/services/autorecovery.cxx
index 2b62186b08fe..dfed8cfc6993 100644
--- a/framework/source/services/autorecovery.cxx
+++ b/framework/source/services/autorecovery.cxx
@@ -88,6 +88,7 @@
#include
#include
#include
+#include
#include
#include
@@ -3459,6 +3460,8 @@ void AutoRecovery::implts_openOneDoc(const OUString&
sURL ,
// TODO: remove load-process specific arguments from the
descriptor, e.g. the status indicator
xModel->attachResource( sURL,
lDescriptor.getAsConstPropertyValueList() );
}
+else if (!utl::UCBContentHelper::Exists(sURL))
+throw css::uno::Exception();
else
{
OUString sFilterName;
Re: Enhancement request for Bugzilla
Hi Xisco, Xisco Fauli schrieb am 11.08.2023 um 23:41: Hi Regina, it seems to work for me. For instance, in https://bugs.documentfoundation.org/show_bug.cgi?id=154074 I uploaded a .pptx file and Bugzilla detected it as application/vnd.openxmlformats-officedocument.presentationml.presentation. Could you please point to the ticket where you saw the problem you mentioned? It seems to work sometimes and fails sometimes. https://bugs.documentfoundation.org/buglist.cgi?f1=attachments.mimetype_id=1636496=changedfrom=LibreOffice_format=advanced=application%2Fzip That means in section "Custom Search" search for "Attachment mime type" "changed from" "application/zip". Kind regards, Regina On 10/8/23 19:33, Regina Henschel wrote: Hi all, I want to make an enhancement request for our Bugzilla, but where? Neither Bugzilla nor Redmine seem to have a suitable category. This is my problem: If I attach a pptx, docx, or xlsx file, the option 'auto-detect' in section 'Content Type' does not work. So I try option 'select from list', but that list has no items for the OOXML formats. So my request is to make the 'auto-detect' able to detect OOXML formats or extend the list with these formats. Kind regards, Regina -- Xisco Faulí LibreOffice QA Team IRC: x1sc0
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - sc/source
sc/source/ui/view/tabview4.cxx |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
New commits:
commit 48e03dfb8398fa7dc881f039f9d56b729e95ca8d
Author: Henry Castro
AuthorDate: Fri Aug 11 09:11:09 2023 -0400
Commit: Aron Budea
CommitDate: Sat Aug 12 00:53:20 2023 +0200
tdf#155799: sc: fix input formula reference
If the start point reference mark is selected
with mouse direction up, it should extend to show
the correct input formula reference.
Signed-off-by: Henry Castro
Change-Id: I41f2ea52bf7de341eccadfba80e91fd76a6fd2de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155618
Reviewed-by: Tomaž Vajngerl
Tested-by: Jenkins CollaboraOffice
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155593
Tested-by: Aron Budea
Reviewed-by: Aron Budea
diff --git a/sc/source/ui/view/tabview4.cxx b/sc/source/ui/view/tabview4.cxx
index 3ed71a5ef931..9ff3d41ef4df 100644
--- a/sc/source/ui/view/tabview4.cxx
+++ b/sc/source/ui/view/tabview4.cxx
@@ -229,9 +229,13 @@ void ScTabView::UpdateRef( SCCOL nCurX, SCROW nCurY, SCTAB
nCurZ )
ScRefType eType = aViewData.GetRefType();
if ( eType == SC_REFTYPE_REF )
{
+if ((nStartX > nEndX || nStartY > nEndY) &&
+rDoc.HasAttrib(nStartX, nStartY, nTab, HasAttrFlags::Merged))
+rDoc.ExtendMerge( nStartX, nStartY, nStartX, nStartY, nTab );
+
ScRange aRef(
-aViewData.GetRefStartX(), aViewData.GetRefStartY(),
aViewData.GetRefStartZ(),
-aViewData.GetRefEndX(), aViewData.GetRefEndY(),
aViewData.GetRefEndZ() );
+nStartX, nStartY, aViewData.GetRefStartZ(),
+nEndX, nEndY, aViewData.GetRefEndZ() );
SC_MOD()->SetReference( aRef, rDoc, );
ShowRefTip();
}
[Libreoffice-bugs] [Bug 128233] macOS: Can't save or open files using Finder dialog on Standard accounts (see comment 9)
https://bugs.documentfoundation.org/show_bug.cgi?id=128233 --- Comment #86 from Patrick Luby --- (In reply to Patrick Luby from comment #85) > I cannot reproduce this bug on macOS Monterey. I do *not* have Full Disk > Access granted to LibreOffice (either in my administrator or > non-administrator account) and I tried the following steps: > > 1. Install the 27 July 2023 nightly build and the French language pack in my > non-administrator user's Desktop: >https://bugs.documentfoundation.org/show_bug.cgi?id=144053#c33 > > 2. Add a space to LibreOfficeDev.app that I installed in step 1 and launch > it. > > 3. Create new writer file and save to Desktop, Downloads, or Documents > folders. I retested the above steps with the latest LibreOffice 7.6.0.3 download on macOS Monterey on my Silicon Mac. Still no problems for me. Anyone else still seeing problems with LibreOffice 7.6? -- You are receiving this mail because: You are the assignee for the bug.
Re: Enhancement request for Bugzilla
Hi Regina, it seems to work for me. For instance, in https://bugs.documentfoundation.org/show_bug.cgi?id=154074 I uploaded a .pptx file and Bugzilla detected it as application/vnd.openxmlformats-officedocument.presentationml.presentation. Could you please point to the ticket where you saw the problem you mentioned? On 10/8/23 19:33, Regina Henschel wrote: Hi all, I want to make an enhancement request for our Bugzilla, but where? Neither Bugzilla nor Redmine seem to have a suitable category. This is my problem: If I attach a pptx, docx, or xlsx file, the option 'auto-detect' in section 'Content Type' does not work. So I try option 'select from list', but that list has no items for the OOXML formats. So my request is to make the 'auto-detect' able to detect OOXML formats or extend the list with these formats. Kind regards, Regina -- Xisco Faulí LibreOffice QA Team IRC: x1sc0
[Libreoffice-bugs] [Bug 101522] [META] Media playback bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101522 Michael Weghorn changed: What|Removed |Added Keywords|accessibility | URL|https://getreminiapk.com/re | |mini-mod-apk/ | CC||m.wegh...@posteo.de -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 129661] [META] Right-To-Left (RTL) user interface issues
https://bugs.documentfoundation.org/show_bug.cgi?id=129661 Bug 129661 depends on bug 104318, which changed state. Bug 104318 Summary: CTL, CJK, and Western Language controls in the GUI cause confusion, handling languages and script selection needs rework--comfortable for a "Global" user community https://bugs.documentfoundation.org/show_bug.cgi?id=104318 What|Removed |Added Status|RESOLVED|NEW Resolution|INSUFFICIENTDATA|--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 104318] CTL, CJK, and Western Language controls in the GUI cause confusion, handling languages and script selection needs rework--comfortable for a "Global" user community
https://bugs.documentfoundation.org/show_bug.cgi?id=104318 V Stuart Foote changed: What|Removed |Added Resolution|INSUFFICIENTDATA|--- Keywords||needsUXEval Status|RESOLVED|NEW CC||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #36 from V Stuart Foote --- Sorry, but this is in no way resolved. It remains a subject for broader rework of both the UI for handling ODF distinction for Western, CJK, and CTL scripts but also of our template defaults for the PS/FS styles of each locale. Kicking it back to UX-Advise as discussion belongs there along with dev input on how we could broadly refactor to deliver more "global" UI. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 104318] CTL, CJK, and Western Language controls in the GUI cause confusion, handling languages and script selection needs rework--comfortable for a "Global" user community
https://bugs.documentfoundation.org/show_bug.cgi?id=104318 V Stuart Foote changed: What|Removed |Added Resolution|INSUFFICIENTDATA|--- Keywords||needsUXEval Status|RESOLVED|NEW CC||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #36 from V Stuart Foote --- Sorry, but this is in no way resolved. It remains a subject for broader rework of both the UI for handling ODF distinction for Western, CJK, and CTL scripts but also of our template defaults for the PS/FS styles of each locale. Kicking it back to UX-Advise as discussion belongs there along with dev input on how we could broadly refactor to deliver more "global" UI. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112139] [META] Options dialog's Language settings bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112139 Bug 112139 depends on bug 104318, which changed state. Bug 104318 Summary: CTL, CJK, and Western Language controls in the GUI cause confusion, handling languages and script selection needs rework--comfortable for a "Global" user community https://bugs.documentfoundation.org/show_bug.cgi?id=104318 What|Removed |Added Status|RESOLVED|NEW Resolution|INSUFFICIENTDATA|--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 127138] GNOME / KDE dark system themes don't automatically enable corresponding dark icon themes
https://bugs.documentfoundation.org/show_bug.cgi?id=127138 Stéphane Guillou (stragu) changed: What|Removed |Added Priority|medium |high --- Comment #26 from Stéphane Guillou (stragu) --- Raising the priority, given that there's 8 duplicates and it affects accessibility. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/view/viewsh.cxx | 54 ++--
1 file changed, 32 insertions(+), 22 deletions(-)
New commits:
commit 166d3f204aad40f2cd023e4860200182dbe48d8f
Author: Marco Cecchetti
AuthorDate: Mon Jul 10 17:26:52 2023 +0200
Commit: Miklos Vajna
CommitDate: Fri Aug 11 22:06:28 2023 +0200
Get LOKDocumentFocusListener to handle enable/disable a11y properly
This patch fix the following problems:
- Remove all children when accessibility is disabled
- Update the currently focused paragraph when accessibility is enabled
Change-Id: Ib65a14052ee8e0f965c0546897fd67641bba50ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155576
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/sfx2/source/view/viewsh.cxx b/sfx2/source/view/viewsh.cxx
index f204b03c3721..18208bb8e919 100644
--- a/sfx2/source/view/viewsh.cxx
+++ b/sfx2/source/view/viewsh.cxx
@@ -520,20 +520,23 @@ public:
/// @throws lang::IndexOutOfBoundsException
/// @throws uno::RuntimeException
void detachRecursive(
-const uno::Reference< accessibility::XAccessible >& xAccessible
+const uno::Reference< accessibility::XAccessible >& xAccessible,
+bool bForce = false
);
/// @throws lang::IndexOutOfBoundsException
/// @throws uno::RuntimeException
void detachRecursive(
-const uno::Reference< accessibility::XAccessibleContext >& xContext
+const uno::Reference< accessibility::XAccessibleContext >& xContext,
+bool bForce = false
);
/// @throws lang::IndexOutOfBoundsException
/// @throws uno::RuntimeException
void detachRecursive(
const uno::Reference< accessibility::XAccessibleContext >& xContext,
-const sal_Int64 nStateSet
+const sal_Int64 nStateSet,
+bool bForce = false
);
/// @throws lang::IndexOutOfBoundsException
@@ -1030,25 +1033,30 @@ void LOKDocumentFocusListener::attachRecursive(
{
// Usually, when the document is loaded, a CARET_CHANGED
accessibility event is automatically emitted
// for the first paragraph. That allows to notify the paragraph
content to the client, even if no input
-// event occurred yet. However, in Cypress tests no accessibility
event is automatically emitted until
-// some input event occurs. So we use the following workaround to
notify the content of the focused
-// paragraph, without waiting for an input event.
+// event occurred yet. However, when switching to a11y enabled in
the client and in Cypress tests
+// no accessibility event is automatically emitted until some
input event occurs.
+// So we use the following workaround to notify the content of the
focused paragraph,
+// without waiting for an input event.
// Here we update the paragraph info related to the focused
paragraph,
// later when afterCallbackRegistered is executed we notify the
paragraph content.
sal_Int64 nChildCount = xContext->getAccessibleChildCount();
if (nChildCount > 0)
{
-uno::Reference< accessibility::XAccessible > xChild(
xContext->getAccessibleChild( 0 ) );
-if( xChild.is() )
+for (sal_Int64 n = 0; n < nChildCount; ++n)
{
-uno::Reference
xAccText(xChild, uno::UNO_QUERY);
-if (xAccText.is())
+uno::Reference< accessibility::XAccessible >
xChild(xContext->getAccessibleChild(n));
+if (xChild.is())
{
-sal_Int32 nPos = xAccText->getCaretPosition();
-if (nPos >= 0)
+uno::Reference
xAccText(xChild, uno::UNO_QUERY);
+if (xAccText.is())
{
-attachRecursive(xChild);
-updateParagraphInfo(xAccText, false,
"LOKDocumentFocusListener::attachRecursive(3)");
+sal_Int32 nPos = xAccText->getCaretPosition();
+if (nPos >= 0)
+{
+attachRecursive(xChild);
+updateParagraphInfo(xAccText, false,
"LOKDocumentFocusListener::attachRecursive(3)");
+break;
+}
}
}
}
@@ -1058,18 +1066,20 @@ void LOKDocumentFocusListener::attachRecursive(
}
void LOKDocumentFocusListener::detachRecursive(
-const uno::Reference< accessibility::XAccessible >& xAccessible
+const uno::Reference< accessibility::XAccessible >& xAccessible,
+bool bForce
)
{
uno::Reference< accessibility::XAccessibleContext > xContext =
[Libreoffice-bugs] [Bug 101522] [META] Media playback bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101522 Robert Greer changed: What|Removed |Added URL||https://getreminiapk.com/re ||mini-mod-apk/ Keywords||accessibility --- Comment #5 from Robert Greer --- https://getreminiapk.com/remini-mod-apk/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156714] .uno:IndexMarktoIndex does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=156714 Julien Nabet changed: What|Removed |Added CC|serval2...@yahoo.fr | --- Comment #3 from Julien Nabet --- Thank you for the feedback. I don't know anything about TOX, I've just retrieved this part: 122 if( !pTextNd || !pTextNd->GetpSwpHints() ) (gdb) p pTextNd $3 = (SwTextNode * const) 0x561a3ae9ce60 (gdb) p pTextNd->GetpSwpHints() $4 = (SwpHints *) 0x0 (gdb) bt #0 SwDoc::GetCurTOXMark(SwPosition const&, std::__debug::vector >&) (rPos=SwPosition (node 18, offset 6), rArr=std::__debug::vector of length 0, capacity 0) at sw/source/core/doc/doctxm.cxx:122 #1 0x7f559220e4ef in SwCursorShell::GotoTOXMarkBase() (this=0x561a3afe4660) at sw/source/core/crsr/crstrvl.cxx:365 #2 0x7f55939b2cf2 in SwTextShell::ExecIdx(SfxRequest const&) (this=0x561a3b2339e0, rReq=...) at sw/source/uibase/shells/textidx.cxx:170 #3 0x7f55939b9085 in SfxStubSwTextShellExecIdx(SfxShell*, SfxRequest&) (pShell=0x561a3b2339e0, rReq=...) at workdir/SdiTarget/sw/sdi/swslots.hxx:3182 I click on different parts of a brand new doc with a Table of Index created (because I noticed that it didn't work on the attached file), clicking on IndexMarkToIndex after having put the cursor at different locations doesn't do anything. Since I'm not sure how it's supposed to work, I'll let this UNCONFIRMED. Hope this gdb part will help but as for me, I can't do more, so uncc myself. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156747] Unsaved files not recovering on next launch.
https://bugs.documentfoundation.org/show_bug.cgi?id=156747 --- Comment #1 from jd4...@hotmail.com --- I did just test it with ending writer via taskmanager, which would have the same effect as a system reset and the same thing happened. So it does not appear to be a user profile corruption issue. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156747] Unsaved files not recovering on next launch.
https://bugs.documentfoundation.org/show_bug.cgi?id=156747 jd4...@hotmail.com changed: What|Removed |Added Hardware|x86-64 (AMD64) |All -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156747] New: Unsaved files not recovering on next launch.
https://bugs.documentfoundation.org/show_bug.cgi?id=156747 Bug ID: 156747 Summary: Unsaved files not recovering on next launch. Product: LibreOffice Version: 7.5.4.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jd4...@hotmail.com Description: I am on version 7.5.4.2. I used to use version 5 couldnt say with sub version a lot. And i use to open up a dozen or so documents at a time, write some notes. Then i would turn off my computer, the next day, it would recover all those files perfectly fine. I did this daily for ages without issue. Had to reinstall windows recently and since then upgraded to the latest version and now it will still show the recover option when i launch libre office writer, however it just recovers a blank document with the (remote) in brackets, which again i never had during version 5, i never saw (remote) anywhere. Yes i know it is my fault for not saving however, this issue basically means the recovery system is not working, and i do not know if existing documents i have recovered recently have actually saved the changes or not, as i bounce between documents often i forget what changes i made recently. Steps to Reproduce: 1.turn off the computer with unsaved writer documents open. 2.turn on computer and open writer 3."successfully" recover those files, but instead it just opens blank remote files Actual Results: Any unsaved documents show up in the recovery window and show successful recovery but instead are replaced with empty (remote) documents and the unsaved documents are lost. Expected Results: As before in version 5. whatever it should successfully recover the unsaved documents, open them all back up with all the data still there as it used to. Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-GB Module: TextDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: yes I did not try resetting the user profile yet as i did not know that was a thing, and to test properly would require restarting windows and that would mean redoing this bug report, which is still relevant even if it ends up beign a user profile corruption issue. If its possible to update and add more information to this bug report later i can add to it if that did fix it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153428] Elements Sidebar area should be open itself when I insert Math formula into Writer document
https://bugs.documentfoundation.org/show_bug.cgi?id=153428 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEEDINFO|RESOLVED --- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> --- Strange, it works as I wanted in Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: e26aeb882dd236adf19679d5df9b7ba5da1ed226 CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL threaded Closed as WFM then -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156730] FILESAVE: Unable To Save A Large Spreadsheet in Calc V7.5.5.2
https://bugs.documentfoundation.org/show_bug.cgi?id=156730 --- Comment #2 from temp...@nospammers.ignorelist.com --- I did. I must have missed checking the box the last time I filled out the form. My apologies. The results were the same. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: canvas/source
canvas/source/cairo/cairo_canvas.hxx | 22 ++
canvas/source/cairo/cairo_canvasbitmap.hxx | 22 ++
canvas/source/cairo/cairo_canvascustomsprite.hxx | 22 ++
canvas/source/cairo/cairo_spritecanvas.hxx | 22 ++
canvas/source/opengl/ogl_spritecanvas.hxx| 22 ++
canvas/source/vcl/canvas.hxx | 22 ++
canvas/source/vcl/canvascustomsprite.hxx | 22 ++
canvas/source/vcl/spritecanvas.hxx | 22 ++
8 files changed, 144 insertions(+), 32 deletions(-)
New commits:
commit eb6110aae0af9e27f71dac95274b8f3879090deb
Author: Noel Grandin
AuthorDate: Fri Aug 11 15:00:18 2023 +0200
Commit: Noel Grandin
CommitDate: Fri Aug 11 20:32:35 2023 +0200
clang-tidy bugprone-parent-virtual-call in canvas
Change-Id: Ibaaec56e7cb42d113be07bb719de3534de24833c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155615
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/canvas/source/cairo/cairo_canvas.hxx
b/canvas/source/cairo/cairo_canvas.hxx
index 0c41a8a5c0d3..5d0b8e348caf 100644
--- a/canvas/source/cairo/cairo_canvas.hxx
+++ b/canvas/source/cairo/cairo_canvas.hxx
@@ -109,10 +109,24 @@ namespace cairocanvas
// Forwarding the XComponent implementation to the
// cppu::ImplHelper templated base
-// Classname Base doing refcounting
Base implementing the XComponent interface
-//| |
|
-//V V
V
-DECLARE_UNO3_XCOMPONENT_AGG_DEFAULTS( Canvas, GraphicDeviceBase_Base,
::cppu::WeakComponentImplHelperBase )
+virtual void SAL_CALL acquire() noexcept override {
GraphicDeviceBase_Base::acquire(); } \
+virtual void SAL_CALL release() noexcept override {
GraphicDeviceBase_Base::release(); } \
+virtual css::uno::Any SAL_CALL queryInterface(const css::uno::Type&
_rType) override
+{ return GraphicDeviceBase_Base::queryInterface(_rType); }
+virtual void SAL_CALL dispose() override
+{
+CanvasBaseSurfaceProvider_Base::dispose();
+}
+virtual void SAL_CALL addEventListener(
+css::uno::Reference< css::lang::XEventListener > const & xListener
) override
+{
+CanvasBaseSurfaceProvider_Base::addEventListener(xListener);
+}
+virtual void SAL_CALL removeEventListener(
+css::uno::Reference< css::lang::XEventListener > const & xListener
) override
+{
+CanvasBaseSurfaceProvider_Base::removeEventListener(xListener);
+}
// XServiceName
virtual OUString SAL_CALL getServiceName( ) override;
diff --git a/canvas/source/cairo/cairo_canvasbitmap.hxx
b/canvas/source/cairo/cairo_canvasbitmap.hxx
index f2371821023f..9e6d1d8a28cd 100644
--- a/canvas/source/cairo/cairo_canvasbitmap.hxx
+++ b/canvas/source/cairo/cairo_canvasbitmap.hxx
@@ -78,10 +78,24 @@ namespace cairocanvas
// Forwarding the XComponent implementation to the
// cppu::ImplHelper templated base
-//Classname Base doing
refcountingBase implementing the XComponent interface
-// | |
|
-// V V
V
-DECLARE_UNO3_XCOMPONENT_AGG_DEFAULTS( CanvasBitmap,
CanvasBitmapBase_Base, ::cppu::WeakComponentImplHelperBase )
+virtual void SAL_CALL acquire() noexcept override {
CanvasBitmapBase_Base::acquire(); }
+virtual void SAL_CALL release() noexcept override {
CanvasBitmapBase_Base::release(); }
+virtual css::uno::Any SAL_CALL queryInterface(const css::uno::Type&
_rType) override
+{ return CanvasBitmapBase_Base::queryInterface(_rType); }
+virtual void SAL_CALL dispose() override
+{
+CanvasBitmapSpriteSurface_Base::dispose();
+}
+virtual void SAL_CALL addEventListener(
+css::uno::Reference< css::lang::XEventListener > const & xListener
) override
+{
+CanvasBitmapSpriteSurface_Base::addEventListener(xListener);
+}
+virtual void SAL_CALL removeEventListener(
+css::uno::Reference< css::lang::XEventListener > const & xListener
) override
+{
+CanvasBitmapSpriteSurface_Base::removeEventListener(xListener);
+}
// XServiceInfo
virtual OUString SAL_CALL getImplementationName( ) override;
diff --git a/canvas/source/cairo/cairo_canvascustomsprite.hxx
[Libreoffice-bugs] [Bug 125067] Data segmentation in LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=125067 BogdanB changed: What|Removed |Added Summary|data segmentation in libre |Data segmentation in |office |LibreOffice -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156719] Insert menu contains duplicate accelerator hotkey
https://bugs.documentfoundation.org/show_bug.cgi?id=156719 BogdanB changed: What|Removed |Added Summary|duplicate menu hotkey |Insert menu contains ||duplicate accelerator ||hotkey -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156746] New: Office Calc Selected Cell Highlight Color
https://bugs.documentfoundation.org/show_bug.cgi?id=156746 Bug ID: 156746 Summary: Office Calc Selected Cell Highlight Color Product: LibreOffice Version: 7.2.0.4 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: johnwb...@gmail.com Description: Hello. The highlight color is black and there needs to be an option to change the color because myself and am sure millions of others prefer sheet in dark mode with black cell borders and the black selected cell color is virtually invisible. Thanks. Actual Results: na Expected Results: na Reproducible: Always User Profile Reset: No Additional Info: na -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156745] CLI PDF export: document is 2 pages instead of 7
https://bugs.documentfoundation.org/show_bug.cgi?id=156745 Gabor Kelemen (allotropia) changed: What|Removed |Added Status|UNCONFIRMED |NEW Regression By||Michael Stahl Ever confirmed|0 |1 CC||michael.st...@allotropia.de -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156724] Document layout changed in PDF export: content overlaps footnote
https://bugs.documentfoundation.org/show_bug.cgi?id=156724 Gabor Kelemen (allotropia) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||6745 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138327] [META] sw_redlinehide regressions (track changes)
https://bugs.documentfoundation.org/show_bug.cgi?id=138327 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on||156745 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=156745 [Bug 156745] CLI PDF export: document is 2 pages instead of 7 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156745] New: CLI PDF export: document is 2 pages instead of 7
https://bugs.documentfoundation.org/show_bug.cgi?id=156745 Bug ID: 156745 Summary: CLI PDF export: document is 2 pages instead of 7 Product: LibreOffice Version: 6.2.0.3 release Hardware: All OS: All Status: UNCONFIRMED Keywords: bibisected, regression Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kelem...@ubuntu.com Blocks: 138327 Created attachment 188939 --> https://bugs.documentfoundation.org/attachment.cgi?id=188939=edit Bad export PDF from fresh linux-bibisect 24.2 This is a followup to bug 156724 In command line PDF export mode attachment 69599 layout has changed. The document is 7 pages in the editor, but only the first two are exported to PDF in CLI export mode. 1. Download attachment 69599 2. in CLI save as PDF: --convert-to pdf -> resulting document is only 2 pages long instead of 7 Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 0d571ff8079f858a5650bf6cbb38296d22cc58e1 CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: hu-HU (hu_HU.UTF-8); UI: en-US Calc: threaded This started in 6.2 with: https://git.libreoffice.org/core/+/7e8b4756d95057f069467b34e7849f9354856578 author Michael Stahl Mon Sep 17 11:26:01 2018 +0200 committer Michael Stahl Wed Sep 19 10:18:33 2018 +0200 sw_redlinehide_2: disable layout-cache for now This also made the document appear only as first 2 pages in the editor. That issue was resolved later still in 6.2 with: https://git.libreoffice.org/core/+/232b467083dd3b55f261bebe084e696bee200ec9 author Michael Stahl Wed May 08 16:23:25 2019 +0200 committer Miklos Vajna Fri May 10 13:25:52 2019 +0200 tdf#124675 sw: fix crash when moving SwTextFrame in table to prev page Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=138327 [Bug 138327] [META] sw_redlinehide regressions (track changes) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 109090] Lang pref English (USA) shows as French (France) in spell checker dialogue (macOS only)
https://bugs.documentfoundation.org/show_bug.cgi?id=109090 --- Comment #17 from bunkem --- I'm having some difficulties determining how to reproduce this. Please confirm this replicates the issue. 1.Set language preference to "French (France)" 2.Create a new Writer document. 3.Make sure the language of the document is "French (France)" 4.Add French language text to the document. 5.Save document with a name.odt 6.Run Tools:Spelling. 7.Spelling doesn't work since it says "None" or "Aucun" as the dictionary. 8.Set the dictionary to "French (France)". Save. 9.Run Tools:Spelling. Spelling shows "None" or "Aucun" instead of "French (France)" If this is correct, then I can confirm it is present in Version: 7.5.5.2 (X86_64) / LibreOffice Community Build ID: ca8fe7424262805f223b9a2334bc7181abbcbf5e CPU threads: 8; OS: Mac OS X 12.6.8; UI render: default; VCL: osx Locale: fr-FR (en_CA.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/attr/swatrset.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit cf686f4586fb0a94643efdde1c36ddd714d7479c Author: Andrea Gelmini AuthorDate: Fri Aug 11 15:39:29 2023 +0200 Commit: Julien Nabet CommitDate: Fri Aug 11 19:19:52 2023 +0200 Fix typo Change-Id: I0336d39dd003f18383326b3f7806597612edf755 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155623 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/sw/source/core/attr/swatrset.cxx b/sw/source/core/attr/swatrset.cxx index f2761d7dec41..b319330e6ed8 100644 --- a/sw/source/core/attr/swatrset.cxx +++ b/sw/source/core/attr/swatrset.cxx @@ -122,7 +122,7 @@ void SwAttrSet::changeCallback(const SfxPoolItem* pOld, const SfxPoolItem* pNew) } } -// all given itmes are valid. If we got no WhichID != 0 then +// all given items are valid. If we got no WhichID != 0 then // pOld == pNew == nullptr or SfxVoidItem(0) and we have no // valid input. Also not needed if !IsWhich (aka > SFX_WHICH_MAX) if (0 == nWhich || !SfxItemPool::IsWhich(nWhich))
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - sc/source
sc/source/ui/view/tabview2.cxx | 20
1 file changed, 20 insertions(+)
New commits:
commit ee6d3d10ae7962d7eb6562e65abe9e1524a04e99
Author: Henry Castro
AuthorDate: Tue Jul 18 15:09:18 2023 -0400
Commit: Henry Castro
CommitDate: Fri Aug 11 19:18:02 2023 +0200
tdf#155799: sc: fix formula reference "key up"
When the formula reference mode is active and it process
the keyboard event UP, it should decrease -1 according
the merge attribute row, col span.
Signed-off-by: Henry Castro
Change-Id: I278bcd9d52caeb09e4a47336af8c8e9b522397c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154999
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Tomaž Vajngerl
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155628
diff --git a/sc/source/ui/view/tabview2.cxx b/sc/source/ui/view/tabview2.cxx
index d9fa2cb3f3d5..6c7cdadd4d48 100644
--- a/sc/source/ui/view/tabview2.cxx
+++ b/sc/source/ui/view/tabview2.cxx
@@ -197,6 +197,8 @@ void moveRefByCell(SCCOL& rNewX, SCROW& rNewY,
SCCOL nMovX, SCROW nMovY, SCTAB nRefTab,
const ScDocument& rDoc)
{
+SCCOL nOldX = rNewX;
+SCROW nOldY = rNewY;
bool bSelectLocked = true;
bool bSelectUnlocked = true;
const ScTableProtection* pTabProtection = rDoc.GetTabProtection(nRefTab);
@@ -223,6 +225,15 @@ void moveRefByCell(SCCOL& rNewX, SCROW& rNewY,
}
if (isCellQualified(, nTempX, rNewY, nRefTab, bSelectLocked,
bSelectUnlocked))
rNewX = nTempX;
+
+if (nMovX < 0 && rNewX > 0)
+{
+const ScMergeAttr* pMergeAttr = rDoc.GetAttr(rNewX, rNewY,
nRefTab, ATTR_MERGE);
+if (pMergeAttr && pMergeAttr->IsMerged() &&
+nOldX >= rNewX &&
+nOldX <= rNewX + pMergeAttr->GetRowMerge() - 1)
+rNewX = rNewX - 1;
+}
}
if (nMovY)
@@ -239,6 +250,15 @@ void moveRefByCell(SCCOL& rNewX, SCROW& rNewY,
}
if (isCellQualified(, rNewX, nTempY, nRefTab, bSelectLocked,
bSelectUnlocked))
rNewY = nTempY;
+
+if (nMovY < 0 && rNewY > 0)
+{
+const ScMergeAttr* pMergeAttr = rDoc.GetAttr(rNewX, rNewY,
nRefTab, ATTR_MERGE);
+if (pMergeAttr && pMergeAttr->IsMerged() &&
+nOldY >= rNewY &&
+nOldY <= rNewY + pMergeAttr->GetRowMerge() - 1)
+rNewY = rNewY - 1;
+}
}
rDoc.SkipOverlapped(rNewX, rNewY, nRefTab);
[Libreoffice-commits] core.git: include/sfx2 sc/source sd/source sfx2/source sw/source
include/sfx2/viewsh.hxx |2 +
sc/source/ui/view/tabvwshc.cxx |3 +
sd/source/ui/inc/ViewShellBase.hxx |2 -
sd/source/ui/view/ViewShellBase.cxx |5 ---
sfx2/source/view/viewsh.cxx | 58
sw/source/uibase/uiview/view.cxx|4 ++
6 files changed, 61 insertions(+), 13 deletions(-)
New commits:
commit 9de08c6f8f2b4150da628fe3e9311f5dc64137b0
Author: Marco Cecchetti
AuthorDate: Mon Jun 5 21:33:55 2023 +0200
Commit: Miklos Vajna
CommitDate: Fri Aug 11 19:13:38 2023 +0200
lok: a11y: get focused paragraph notified on document load
Usually, when the document is loaded, a CARET_CHANGED accessibility
event is automatically emitted for the first paragraph. That allows to
notify the paragraph content to the client, even if no input event
occurred yet. However, in Cypress tests no accessibility event is
automatically emitted until some input event occurs. So we use the
workaround in this patch to notify the content of the focused
paragraph, without waiting for an input event.
(cherry picked from commit d6f929c03ca08a0c1134937a1ff1a42f75221e93)
Change-Id: I8696c5f9ea069824614e9b541f4959b315dbda5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155575
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/include/sfx2/viewsh.hxx b/include/sfx2/viewsh.hxx
index 4adf62a196c4..c0628a0bd4fb 100644
--- a/include/sfx2/viewsh.hxx
+++ b/include/sfx2/viewsh.hxx
@@ -440,6 +440,8 @@ public:
const LanguageTag& GetLOKLanguageTag() const { return maLOKLanguageTag; }
/// Enable/Disable LibreOfficeKit AT support for this view.
void SetLOKAccessibilityState(bool bEnabled);
+/// Get LibreOfficeKit AT support state for this view.
+bool GetLOKAccessibilityState() const { return mbLOKAccessibilityEnabled; }
/// Get the LibreOfficeKit timezone of this view. See @SetLOKTimezone.
std::pair GetLOKTimezone() const
diff --git a/sc/source/ui/view/tabvwshc.cxx b/sc/source/ui/view/tabvwshc.cxx
index 997e710e18e9..56cfba5ddfdb 100644
--- a/sc/source/ui/view/tabvwshc.cxx
+++ b/sc/source/ui/view/tabvwshc.cxx
@@ -453,6 +453,9 @@ int ScTabViewShell::getPart() const
void ScTabViewShell::afterCallbackRegistered()
{
+// common tasks
+SfxViewShell::afterCallbackRegistered();
+
UpdateInputHandler(true, false);
ScInputHandler* pHdl = mpInputHandler ? mpInputHandler.get() :
SC_MOD()->GetInputHdl();
diff --git a/sd/source/ui/inc/ViewShellBase.hxx
b/sd/source/ui/inc/ViewShellBase.hxx
index 3f40123405f3..c2b2d16158e0 100644
--- a/sd/source/ui/inc/ViewShellBase.hxx
+++ b/sd/source/ui/inc/ViewShellBase.hxx
@@ -217,8 +217,6 @@ public:
int getEditMode() const override;
/// See SfxViewShell::setEditMode().
void setEditMode(int nMode);
-/// See SfxViewShell::afterCallbackRegistered().
-void afterCallbackRegistered() override;
/// See SfxViewShell::NotifyCursor().
void NotifyCursor(SfxViewShell* pViewShell) const override;
/// See SfxViewShell::GetColorConfigColor().
diff --git a/sd/source/ui/view/ViewShellBase.cxx
b/sd/source/ui/view/ViewShellBase.cxx
index 460e102e7796..6ad6d454be57 100644
--- a/sd/source/ui/view/ViewShellBase.cxx
+++ b/sd/source/ui/view/ViewShellBase.cxx
@@ -1010,11 +1010,6 @@ void ViewShellBase::setEditMode(int nMode)
}
}
-void ViewShellBase::afterCallbackRegistered()
-{
-// TODO: Add theme color palette changed callback
-}
-
void ViewShellBase::NotifyCursor(SfxViewShell* pOtherShell) const
{
ViewShell* pThisShell =
framework::FrameworkHelper::Instance(*const_cast(this))->GetViewShell(FrameworkHelper::msCenterPaneURL).get();
diff --git a/sfx2/source/view/viewsh.cxx b/sfx2/source/view/viewsh.cxx
index 0d61e2f3f005..f204b03c3721 100644
--- a/sfx2/source/view/viewsh.cxx
+++ b/sfx2/source/view/viewsh.cxx
@@ -554,8 +554,10 @@ public:
int getCaretPosition() const;
private:
-void updateParagraphInfo(const
uno::Reference& xAccText,
+bool updateParagraphInfo(const
uno::Reference& xAccText,
bool force, std::string msg = "");
+void updateAndNotifyParagraph(const
uno::Reference& xAccText,
+ bool force, std::string msg = "");
};
LOKDocumentFocusListener::LOKDocumentFocusListener(const SfxViewShell*
pViewShell)
@@ -676,12 +678,13 @@ void LOKDocumentFocusListener::disposing( const
lang::EventObject& aEvent )
}
-void LOKDocumentFocusListener::updateParagraphInfo(const
uno::Reference& xAccText,
+bool LOKDocumentFocusListener::updateParagraphInfo(const
uno::Reference& xAccText,
bool force, std::string msg)
{
if (!xAccText.is())
-return;
+return false;
+bool bNotify = false;
// If caret is present inside the paragraph (pos != -1), it means that
paragraph has focus in the current view.
[Libreoffice-bugs] [Bug 136524] [META] Performance/hang/lag/high CPU issues
https://bugs.documentfoundation.org/show_bug.cgi?id=136524 Bug 136524 depends on bug 150534, which changed state. Bug 150534 Summary: Hiding Recently Expanded Columns Results in Significant Performance Loss https://bugs.documentfoundation.org/show_bug.cgi?id=150534 What|Removed |Added Status|RESOLVED|NEW Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150534] Hiding Recently Expanded Columns Results in Significant Performance Loss
https://bugs.documentfoundation.org/show_bug.cgi?id=150534 Buovjaga changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|NEW --- Comment #25 from Buovjaga --- I showed your comments to Noel and he said further work would require vasts amounts of code changes and he is not planning to continue on this. So maybe I will change the status back to NEW and someone else can pick this up. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/vcl vcl/source vcl/unx
include/vcl/toolbox.hxx |1 -
vcl/source/app/idle.cxx |2 +-
vcl/source/app/salvtables.cxx |8
vcl/source/control/PriorityMergedHBox.cxx | 10 +-
vcl/source/control/combobox.cxx |8
vcl/source/control/imp_listbox.cxx|2 +-
vcl/source/control/spinfld.cxx|2 +-
vcl/source/edit/vclmedit.cxx |4 ++--
vcl/source/uitest/uiobject.cxx|6 +++---
vcl/source/window/menubarwindow.cxx |2 +-
vcl/source/window/toolbox.cxx |5 -
vcl/unx/gtk3/gtkinst.cxx |2 +-
12 files changed, 23 insertions(+), 29 deletions(-)
New commits:
commit 69972719542cd686687ddd91f2b5284483513608
Author: Noel Grandin
AuthorDate: Fri Aug 11 15:01:21 2023 +0200
Commit: Noel Grandin
CommitDate: Fri Aug 11 18:47:15 2023 +0200
clang-tidy bugprone-parent-virtual-call in vcl
Change-Id: I270bb35f577cc1ee56233c585665478cbaab9085
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155616
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/vcl/toolbox.hxx b/include/vcl/toolbox.hxx
index 6cf448a30b1d..aa24a6d5c2c4 100644
--- a/include/vcl/toolbox.hxx
+++ b/include/vcl/toolbox.hxx
@@ -291,7 +291,6 @@ public:
virtual voidResizing( Size& rSize ) override;
virtual SizeGetOptimalSize() const override;
virtual voiddoDeferredInit(WinBits nBits) override;
-virtual voidqueue_resize(StateChangedType eReason =
StateChangedType::Layout) override;
/// Insert a command (like '.uno:Save').
virtual voidInsertItem( const OUString& rCommand,
diff --git a/vcl/source/app/idle.cxx b/vcl/source/app/idle.cxx
index 7e5756537164..0aed942beb79 100644
--- a/vcl/source/app/idle.cxx
+++ b/vcl/source/app/idle.cxx
@@ -33,7 +33,7 @@ Idle::Idle( const char *pDebugName )
void Idle::Start(const bool bStartTimer)
{
-Task::Start(false);
+Timer::Start(false);
sal_uInt64 nPeriod = Scheduler::ImmediateTimeoutMs;
if (Scheduler::GetDeterministicMode())
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index 80772536adeb..1ce6cf936316 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -6227,22 +6227,22 @@ void SalInstanceDrawingArea::queue_draw_area(int x, int
y, int width, int height
void SalInstanceDrawingArea::connect_size_allocate(const Link& rLink)
{
-weld::Widget::connect_size_allocate(rLink);
+SalInstanceWidget::connect_size_allocate(rLink);
}
void SalInstanceDrawingArea::connect_key_press(const Link& rLink)
{
-weld::Widget::connect_key_press(rLink);
+SalInstanceWidget::connect_key_press(rLink);
}
void SalInstanceDrawingArea::connect_key_release(const Link& rLink)
{
-weld::Widget::connect_key_release(rLink);
+SalInstanceWidget::connect_key_release(rLink);
}
void SalInstanceDrawingArea::connect_style_updated(const Link&
rLink)
{
-weld::Widget::connect_style_updated(rLink);
+SalInstanceWidget::connect_style_updated(rLink);
}
void SalInstanceDrawingArea::set_cursor(PointerStyle ePointerStyle)
diff --git a/vcl/source/control/PriorityMergedHBox.cxx
b/vcl/source/control/PriorityMergedHBox.cxx
index fd5aa5814dac..5d5e6249ed16 100644
--- a/vcl/source/control/PriorityMergedHBox.cxx
+++ b/vcl/source/control/PriorityMergedHBox.cxx
@@ -46,18 +46,18 @@ PriorityMergedHBox::PriorityMergedHBox(vcl::Window* pParent)
void PriorityMergedHBox::Resize()
{
if (comphelper::LibreOfficeKit::isActive())
-return VclHBox::Resize();
+return PriorityHBox::Resize();
if (!m_bInitialized)
Initialize();
if (!m_bInitialized)
{
-return VclHBox::Resize();
+return PriorityHBox::Resize();
}
tools::Long nWidth = GetSizePixel().Width();
-tools::Long nCurrentWidth = VclHBox::calculateRequisition().getWidth() +
BUTTON_WIDTH;
+tools::Long nCurrentWidth =
PriorityHBox::calculateRequisition().getWidth() + BUTTON_WIDTH;
// Hide lower priority controls
for (int i = GetChildCount() - 1; i >= 0; i--)
@@ -104,7 +104,7 @@ void PriorityMergedHBox::Resize()
}
}
-VclHBox::Resize();
+PriorityHBox::Resize();
if (GetHiddenCount())
m_pButton->Show();
@@ -138,7 +138,7 @@ Size PriorityMergedHBox::calculateRequisition() const
{
if (!m_bInitialized)
{
-return VclHBox::calculateRequisition();
+return PriorityHBox::calculateRequisition();
}
sal_uInt16 nVisibleChildren = 0;
diff --git a/vcl/source/control/combobox.cxx b/vcl/source/control/combobox.cxx
index 05b7a50006b9..ac817ce2a426 100644
--- a/vcl/source/control/combobox.cxx
+++ b/vcl/source/control/combobox.cxx
@@ -575,7 +575,7 @@ void ComboBox::setPosSizePixel( tools::Long nX, tools::Long
nY, tools::Long nWid
void ComboBox::Resize()
{
-
[Libreoffice-bugs] [Bug 133776] No border when dragging columns (MacOS)
https://bugs.documentfoundation.org/show_bug.cgi?id=133776 --- Comment #17 from bunkem --- Sounds good. I had to go back to the version "release_lo-3.3.0_to_lo-5.4.3.2 " and I suspect that is why we got the long list of commits. I'm happy to retest when it gets addressed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156146] FILEOPEN ODT Paragraphs have greater indent than in 7.5
https://bugs.documentfoundation.org/show_bug.cgi?id=156146 Michael Stahl (allotropia) changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #3 from Michael Stahl (allotropia) --- this is exactly the case that was fixed with bug 114287. hmm... it was not what the bug was filed for though, there was a bit of confsion going on there, unfortunately the info is only in a mail, let me translate it... Regina: > > For the attached [note: (2) is the case being discussed below]: > > Word MS Office 365:(1) paragraph-Indent (2)(3) List-Indent > TextMarker, SoftMaker 2021: (1)(2)(3) mit paragraph-Indent > OnlyOffice 7.3.0.184: (1) paragraph-Indent, (2)(3) List-Indent > Google Docs: (1) paragraph-Indent, (2)(3) List-Indent > LO 7.6: (1)(2) paragraph-Indent, (3) List-Indent > > This does not look good. so this was a bit confusing but i found out that this (2) is a special case that our ODF import handles wrongly - if the list style referenced by the paragraph style and the one used by the list are different, the problem does *not* occur. > 19.880.22 > The text:style-name attribute specifies the name of a list style that is > applied to a list. > If this attribute is not included and therefore no list style is specified, > one of the following actions is taken: > • If a list is contained within another list, the list style defaults to > the style of the surrounding list. > • If there is no list style specified for the surrounding list, but the > list's list items contain paragraphs that have paragraph styles attached > specifying a list style, that list style is used. • An > implementation-dependent default list style is used. > To determine which formatting properties are applied to a list, the list > level and list style name are taken into account. ^ this takes precedence over paragraph / paragraph-style! fix: https://gerrit.libreoffice.org/c/core/+/147930 ... so this was a fix to do the same thing that Word and Google Docs and OnlyOffice do, in accordance with ODF. if i open the attachment here with Word 2013 it shows the same as the Writer 7.6 does now. one thing i wonder though: i think this document was artificially constructed by Regina, and we (at least i) had assumed that this would basically be non-existing in user-created documents. do we have any idea if this is a common thing, or is this just one document out of a million? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - sc/inc sc/source
sc/inc/postit.hxx |5 +
sc/source/core/data/postit.cxx | 41 +
2 files changed, 30 insertions(+), 16 deletions(-)
New commits:
commit ac40c3923580e4ec0e738d57ff8b885da93301ef
Author: Caolán McNamara
AuthorDate: Fri Aug 11 13:08:36 2023 +0100
Commit: Caolán McNamara
CommitDate: Fri Aug 11 18:14:15 2023 +0200
split out a common CreateNoteData
Change-Id: Ieeaf50f3a086d01b5492eb3ab9b211f132f045ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155611
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sc/inc/postit.hxx b/sc/inc/postit.hxx
index 92602e5150ac..c6ac3b5a4bd4 100644
--- a/sc/inc/postit.hxx
+++ b/sc/inc/postit.hxx
@@ -178,6 +178,9 @@ class SC_DLLPUBLIC ScNoteUtil
{
static ScPostIt* InsertNote(ScDocument& rDoc, const ScAddress& rPos,
ScNoteData&& rNoteData,
bool bAlwaysCreateCaption, sal_uInt32
nPostItId);
+
+static ScNoteData CreateNoteData(ScDocument& rDoc, const ScAddress& rPos,
const OutlinerParaObject& rOutlinerObj,
+ const tools::Rectangle& rCaptionRect,
bool bShown);
public:
/** Creates and returns a caption object for a temporary caption. */
diff --git a/sc/source/core/data/postit.cxx b/sc/source/core/data/postit.cxx
index 8fa13927d3d9..378323338eb1 100644
--- a/sc/source/core/data/postit.cxx
+++ b/sc/source/core/data/postit.cxx
@@ -929,17 +929,13 @@ ScPostIt* ScNoteUtil::CreateNoteFromCaption(
return pNote;
}
-ScPostIt* ScNoteUtil::CreateNoteFromObjectData(
-ScDocument& rDoc, const ScAddress& rPos, SfxItemSet&& rItemSet, const
OUString& rStyleName,
-const OutlinerParaObject& rOutlinerObj, const tools::Rectangle&
rCaptionRect,
-bool bShown )
+ScNoteData ScNoteUtil::CreateNoteData(ScDocument& rDoc, const ScAddress& rPos,
const OutlinerParaObject& rOutlinerObj,
+ const tools::Rectangle& rCaptionRect,
bool bShown)
{
ScNoteData aNoteData( bShown );
aNoteData.mxInitData = std::make_shared();
ScCaptionInitData& rInitData = *aNoteData.mxInitData;
-rInitData.moItemSet.emplace(std::move(rItemSet));
rInitData.mxOutlinerObj = rOutlinerObj;
-rInitData.maStyleName =
ScStyleNameConversion::ProgrammaticToDisplayName(rStyleName,
SfxStyleFamily::Frame);
// convert absolute caption position to relative position
rInitData.mbDefaultPosSize = rCaptionRect.IsEmpty();
@@ -952,6 +948,19 @@ ScPostIt* ScNoteUtil::CreateNoteFromObjectData(
rInitData.maCaptionSize = rCaptionRect.GetSize();
}
+return aNoteData;
+}
+
+ScPostIt* ScNoteUtil::CreateNoteFromObjectData(
+ScDocument& rDoc, const ScAddress& rPos, SfxItemSet&& rItemSet, const
OUString& rStyleName,
+const OutlinerParaObject& rOutlinerObj, const tools::Rectangle&
rCaptionRect,
+bool bShown )
+{
+ScNoteData aNoteData(CreateNoteData(rDoc, rPos, rOutlinerObj,
rCaptionRect, bShown));
+ScCaptionInitData& rInitData = *aNoteData.mxInitData;
+rInitData.moItemSet.emplace(std::move(rItemSet));
+rInitData.maStyleName =
ScStyleNameConversion::ProgrammaticToDisplayName(rStyleName,
SfxStyleFamily::Frame);
+
return InsertNote(rDoc, rPos, std::move(aNoteData),
/*bAlwaysCreateCaption*/false, 0/*nPostItId*/);
}
commit 5ae486eea7a381403a9f81e5aa8ef1a0a57b95b6
Author: Caolán McNamara
AuthorDate: Fri Aug 11 13:01:17 2023 +0100
Commit: Caolán McNamara
CommitDate: Fri Aug 11 18:14:05 2023 +0200
split out common ScPostIt insertion piece
Change-Id: Ie9d718293f907e19e29ed6f8aea4a2bf9d88dfe9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155610
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/sc/inc/postit.hxx b/sc/inc/postit.hxx
index 828d094e49d1..92602e5150ac 100644
--- a/sc/inc/postit.hxx
+++ b/sc/inc/postit.hxx
@@ -176,6 +176,8 @@ private:
class SC_DLLPUBLIC ScNoteUtil
{
+static ScPostIt* InsertNote(ScDocument& rDoc, const ScAddress& rPos,
ScNoteData&& rNoteData,
+bool bAlwaysCreateCaption, sal_uInt32
nPostItId);
public:
/** Creates and returns a caption object for a temporary caption. */
diff --git a/sc/source/core/data/postit.cxx b/sc/source/core/data/postit.cxx
index cbb2eff1ff14..8fa13927d3d9 100644
--- a/sc/source/core/data/postit.cxx
+++ b/sc/source/core/data/postit.cxx
@@ -23,8 +23,8 @@
#include
#include
#include
-#include
#include
+#include
#include
#include
#include
@@ -952,13 +952,18 @@ ScPostIt* ScNoteUtil::CreateNoteFromObjectData(
rInitData.maCaptionSize = rCaptionRect.GetSize();
}
+return InsertNote(rDoc, rPos, std::move(aNoteData),
/*bAlwaysCreateCaption*/false, 0/*nPostItId*/);
+}
+
+ScPostIt* ScNoteUtil::InsertNote(ScDocument& rDoc, const ScAddress& rPos,
ScNoteData&& rNoteData,
+ bool
[Libreoffice-commits] core.git: sc/source
sc/source/filter/oox/commentsbuffer.cxx | 43 +---
1 file changed, 34 insertions(+), 9 deletions(-)
New commits:
commit e11a0e646b8eb75e102f878dc70f5196c4efbea2
Author: Caolán McNamara
AuthorDate: Fri Aug 11 12:32:09 2023 +0100
Commit: Caolán McNamara
CommitDate: Fri Aug 11 18:13:48 2023 +0200
rearrange to collect the properties set on the annotation together
and set them in one block. No behavior change intended.
note: type passed as TextFitToSize seems to be wrong
Change-Id: I349aeba5176ef6c10163069a73d0367469aadd6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155588
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/sc/source/filter/oox/commentsbuffer.cxx
b/sc/source/filter/oox/commentsbuffer.cxx
index 55bcb7e2cc73..9307ad707006 100644
--- a/sc/source/filter/oox/commentsbuffer.cxx
+++ b/sc/source/filter/oox/commentsbuffer.cxx
@@ -169,10 +169,11 @@ void Comment::finalizeImport()
// setting a property triggers expensive process, so set them all at
once
// Add shape formatting properties (autoFill, colHidden and rowHidden
are dropped)
-static_cast(xAnnoShape.get())->setPropertyValues(
-Sequence { "TextFitToSize", "MoveProtect",
"TextHorizontalAdjust", "TextVerticalAdjust" },
-Sequence { Any(maModel.mbAutoScale), Any(maModel.mbLocked),
-Any(lcl_ToHorizAlign( maModel.mnTHA )), Any(lcl_ToVertAlign(
maModel.mnTVA )) });
+// vvv TODO vvv TextFitToSize should be a drawing::TextFitToSizeType
not bool
+Sequence aPropertyNames{ "TextFitToSize", "MoveProtect",
"TextHorizontalAdjust", "TextVerticalAdjust" };
+Sequence aPropertyValues{ Any(maModel.mbAutoScale),
Any(maModel.mbLocked),
+Any(lcl_ToHorizAlign( maModel.mnTHA )), Any(lcl_ToVertAlign(
maModel.mnTVA )) };
+
if( maModel.maAnchor.Width > 0 && maModel.maAnchor.Height > 0 )
{
xAnnoShape->setPosition( css::awt::Point( maModel.maAnchor.X,
maModel.maAnchor.Y ) );
@@ -191,18 +192,42 @@ void Comment::finalizeImport()
xAnnoShape->setSize(css::awt::Size(aShapeRect.Width,
aShapeRect.Height));
::oox::drawingml::ShapePropertyMap
aPropMap(pVmlNoteShape->makeShapePropertyMap());
-css::uno::Reference xShape(xAnnoShape);
-PropertySet(xShape).setProperties(aPropMap);
+
+Sequence aVMLPropNames;
+Sequence aVMLPropValues;
+aPropMap.fillSequences(aVMLPropNames, aVMLPropValues);
+
+sal_uInt32 nOldPropLen = aPropertyNames.getLength();
+sal_uInt32 nVMLPropLen = aVMLPropNames.getLength();
+aPropertyNames.realloc(nOldPropLen + nVMLPropLen);
+aPropertyValues.realloc(nOldPropLen + nVMLPropLen);
+OUString* pNames = aPropertyNames.getArray();
+Any* pValues = aPropertyValues.getArray();
+for (sal_uInt32 i = 0; i < nVMLPropLen; ++i)
+{
+pNames[nOldPropLen + i] = aVMLPropNames[i];
+pValues[nOldPropLen + i] = aVMLPropValues[i];
+}
}
+
// visibility
bVisible = pVmlNoteShape->getTypeModel().mbVisible;
// Setting comment text alignment
const ::oox::vml::ClientData* xClientData =
pVmlNoteShape->getClientData();
-static_cast(xAnnoShape.get())->setPropertyValues(
-Sequence { "TextVerticalAdjust", "ParaAdjust" },
-Sequence { Any(lcl_ToVertAlign( xClientData->mnTextVAlign
)), Any(lcl_ToParaAlign( xClientData->mnTextHAlign )) });
+sal_uInt32 nOldPropLen = aPropertyNames.getLength();
+aPropertyNames.realloc(nOldPropLen + 2);
+aPropertyValues.realloc(nOldPropLen + 2);
+OUString* pNames = aPropertyNames.getArray();
+Any* pValues = aPropertyValues.getArray();
+pNames[nOldPropLen] = "TextVerticalAdjust";
+pValues[nOldPropLen] <<=
lcl_ToVertAlign(xClientData->mnTextVAlign);
+pNames[nOldPropLen + 1] = "ParaAdjust";
+pValues[nOldPropLen + 1] <<= lcl_ToParaAlign(
xClientData->mnTextHAlign);
}
+
+
static_cast(xAnnoShape.get())->setPropertyValues(aPropertyNames,
aPropertyValues);
+
if (bVisible)
pDocShell->GetDocFunc().ShowNote( maModel.maRange.aStart, bVisible
);
[Libreoffice-commits] core.git: 2 commits - include/oox oox/source sc/source
include/oox/vml/vmlshape.hxx|8 +---
oox/source/vml/vmlshape.cxx | 25 +
sc/source/filter/oox/commentsbuffer.cxx |7 ++-
3 files changed, 24 insertions(+), 16 deletions(-)
New commits:
commit 6945d031e759823ab52bdf077e43196b67f594a4
Author: Caolán McNamara
AuthorDate: Fri Aug 11 11:37:28 2023 +0100
Commit: Caolán McNamara
CommitDate: Fri Aug 11 18:13:13 2023 +0200
move setting properties into note comments from oox to sc
no change in behavior intended, the SdrCaption doesn't support
the skipped conditions
Change-Id: Id909ae4ed115c1ad3398d2a62c6432ff1dfde453
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155585
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/include/oox/vml/vmlshape.hxx b/include/oox/vml/vmlshape.hxx
index 2aa2163653de..e95e44053330 100644
--- a/include/oox/vml/vmlshape.hxx
+++ b/include/oox/vml/vmlshape.hxx
@@ -267,9 +267,11 @@ public:
const css::uno::Reference< css::drawing::XShapes
>& rxShapes,
const ShapeParentAnchor* pParentAnchor = nullptr )
const;
-/** Converts formatting into the passed existing XShape and returns
position. */
-css::awt::Rectangle convertFormatting(
-const css::uno::Reference< css::drawing::XShape >&
rxShape ) const;
+/** Returns bounds of Shape */
+css::awt::Rectangle getShapeRectangle() const;
+
+/** Collects common shape properties such as formatting attributes. */
+oox::drawingml::ShapePropertyMap makeShapePropertyMap() const;
void setContainer(ShapeContainer* pContainer);
ShapeContainer* getContainer() const;
@@ -295,9 +297,6 @@ protected:
css::awt::Rectangle calcShapeRectangle(
const ShapeParentAnchor* pParentAnchor ) const;
-/** Collects common shape properties such as formatting attributes. */
-oox::drawingml::ShapePropertyMap makeShapePropertyMap() const;
-
/** Converts common shape properties such as formatting attributes. */
voidconvertShapeProperties(
const css::uno::Reference< css::drawing::XShape >&
rxShape ) const;
diff --git a/oox/source/vml/vmlshape.cxx b/oox/source/vml/vmlshape.cxx
index c297fc1563bb..81ba42ba0a48 100644
--- a/oox/source/vml/vmlshape.cxx
+++ b/oox/source/vml/vmlshape.cxx
@@ -484,20 +484,11 @@ Reference< XShape > ShapeBase::convertAndInsert( const
Reference< XShapes >& rxS
return xShape;
}
-awt::Rectangle ShapeBase::convertFormatting( const Reference< XShape >&
rxShape ) const
+awt::Rectangle ShapeBase::getShapeRectangle() const
{
-if( !rxShape.is() )
-return awt::Rectangle();
-
/* Calculate shape rectangle. Applications may do something special
according to some imported shape client data (e.g. Excel cell anchor).
*/
-awt::Rectangle aShapeRect = calcShapeRectangle( nullptr );
-
-// convert the shape, if the calculated rectangle is not empty
-if( (aShapeRect.Width > 0) || (aShapeRect.Height > 0) )
-convertShapeProperties( rxShape );
-
-return aShapeRect;
+return calcShapeRectangle(nullptr);
}
void ShapeBase::setContainer(ShapeContainer* pContainer) { mpContainer =
pContainer; }
diff --git a/sc/source/filter/oox/commentsbuffer.cxx
b/sc/source/filter/oox/commentsbuffer.cxx
index 555ddad3a924..55bcb7e2cc73 100644
--- a/sc/source/filter/oox/commentsbuffer.cxx
+++ b/sc/source/filter/oox/commentsbuffer.cxx
@@ -24,6 +24,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -183,11 +184,15 @@ void Comment::finalizeImport()
if( const ::oox::vml::ShapeBase* pVmlNoteShape =
getVmlDrawing().getNoteShape( maModel.maRange.aStart ) )
{
// position and formatting
-css::awt::Rectangle aShapeRect =
pVmlNoteShape->convertFormatting(xAnnoShape);
+css::awt::Rectangle aShapeRect =
pVmlNoteShape->getShapeRectangle();
if (aShapeRect.Width > 0 || aShapeRect.Height > 0)
{
xAnnoShape->setPosition(css::awt::Point(aShapeRect.X,
aShapeRect.Y));
xAnnoShape->setSize(css::awt::Size(aShapeRect.Width,
aShapeRect.Height));
+
+::oox::drawingml::ShapePropertyMap
aPropMap(pVmlNoteShape->makeShapePropertyMap());
+css::uno::Reference xShape(xAnnoShape);
+PropertySet(xShape).setProperties(aPropMap);
}
// visibility
bVisible = pVmlNoteShape->getTypeModel().mbVisible;
commit c88855c45a675cf28e2cfe4fa261c2b0339f5898
Author: Caolán McNamara
AuthorDate: Fri Aug 11 11:15:22 2023 +0100
Commit: Caolán McNamara
CommitDate: Fri Aug 11 18:13:04 2023 +0200
split ShapeBase::convertShapeProperties into two parts
Change-Id: I62f42e54c776f15ea83c5fc861bb4f4ff899e891
Reviewed-on:
[Libreoffice-commits] core.git: include/oox oox/source sc/source
include/oox/vml/vmlshape.hxx|4 ++--
oox/source/vml/vmlshape.cxx | 10 --
sc/source/filter/oox/commentsbuffer.cxx |7 ++-
3 files changed, 12 insertions(+), 9 deletions(-)
New commits:
commit 5aeb15e95d26ce6de28eb5f5933324828d553f41
Author: Caolán McNamara
AuthorDate: Fri Aug 11 10:46:53 2023 +0100
Commit: Caolán McNamara
CommitDate: Fri Aug 11 18:12:47 2023 +0200
refactor to return the position to be set by the caller instead
no change in behavior intended
Change-Id: I32043bdf1d29521d8503df315fa786236e272f7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155580
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/include/oox/vml/vmlshape.hxx b/include/oox/vml/vmlshape.hxx
index d46c23282324..8c63d8cbd26c 100644
--- a/include/oox/vml/vmlshape.hxx
+++ b/include/oox/vml/vmlshape.hxx
@@ -267,8 +267,8 @@ public:
const css::uno::Reference< css::drawing::XShapes
>& rxShapes,
const ShapeParentAnchor* pParentAnchor = nullptr )
const;
-/** Converts position and formatting into the passed existing XShape. */
-voidconvertFormatting(
+/** Converts formatting into the passed existing XShape and returns
position. */
+css::awt::Rectangle convertFormatting(
const css::uno::Reference< css::drawing::XShape >&
rxShape ) const;
void setContainer(ShapeContainer* pContainer);
diff --git a/oox/source/vml/vmlshape.cxx b/oox/source/vml/vmlshape.cxx
index 607ddf5354b4..328abeba7875 100644
--- a/oox/source/vml/vmlshape.cxx
+++ b/oox/source/vml/vmlshape.cxx
@@ -484,10 +484,10 @@ Reference< XShape > ShapeBase::convertAndInsert( const
Reference< XShapes >& rxS
return xShape;
}
-void ShapeBase::convertFormatting( const Reference< XShape >& rxShape ) const
+awt::Rectangle ShapeBase::convertFormatting( const Reference< XShape >&
rxShape ) const
{
if( !rxShape.is() )
-return;
+return awt::Rectangle();
/* Calculate shape rectangle. Applications may do something special
according to some imported shape client data (e.g. Excel cell anchor).
*/
@@ -495,11 +495,9 @@ void ShapeBase::convertFormatting( const Reference< XShape
>& rxShape ) const
// convert the shape, if the calculated rectangle is not empty
if( (aShapeRect.Width > 0) || (aShapeRect.Height > 0) )
-{
-rxShape->setPosition( awt::Point( aShapeRect.X, aShapeRect.Y ) );
-rxShape->setSize( awt::Size( aShapeRect.Width, aShapeRect.Height ) );
convertShapeProperties( rxShape );
-}
+
+return aShapeRect;
}
void ShapeBase::setContainer(ShapeContainer* pContainer) { mpContainer =
pContainer; }
diff --git a/sc/source/filter/oox/commentsbuffer.cxx
b/sc/source/filter/oox/commentsbuffer.cxx
index 05deae3ee876..555ddad3a924 100644
--- a/sc/source/filter/oox/commentsbuffer.cxx
+++ b/sc/source/filter/oox/commentsbuffer.cxx
@@ -183,7 +183,12 @@ void Comment::finalizeImport()
if( const ::oox::vml::ShapeBase* pVmlNoteShape =
getVmlDrawing().getNoteShape( maModel.maRange.aStart ) )
{
// position and formatting
-pVmlNoteShape->convertFormatting( xAnnoShape );
+css::awt::Rectangle aShapeRect =
pVmlNoteShape->convertFormatting(xAnnoShape);
+if (aShapeRect.Width > 0 || aShapeRect.Height > 0)
+{
+xAnnoShape->setPosition(css::awt::Point(aShapeRect.X,
aShapeRect.Y));
+xAnnoShape->setSize(css::awt::Size(aShapeRect.Width,
aShapeRect.Height));
+}
// visibility
bVisible = pVmlNoteShape->getTypeModel().mbVisible;
[Libreoffice-commits] core.git: sc/source
sc/source/filter/inc/workbookhelper.hxx | 48 +++
sc/source/filter/oox/stylesbuffer.cxx | 97 +++-
sc/source/filter/oox/workbookhelper.cxx |8 ++
3 files changed, 115 insertions(+), 38 deletions(-)
New commits:
commit de20853e5243843ac9f4c5927ce0b4cf0e407c15
Author: Caolán McNamara
AuthorDate: Thu Aug 10 21:49:59 2023 +0100
Commit: Caolán McNamara
CommitDate: Fri Aug 11 18:11:47 2023 +0200
xlsx with a lot of comments repeatedly calls OutputDevice::HasGlyphs
on the same font over and over again getting the same results
Change-Id: I0c301e3fd4c1838645c25d4f6f7b330acc988135
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155569
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sc/source/filter/inc/workbookhelper.hxx
b/sc/source/filter/inc/workbookhelper.hxx
index 7b3047759329..8e2aa221241a 100644
--- a/sc/source/filter/inc/workbookhelper.hxx
+++ b/sc/source/filter/inc/workbookhelper.hxx
@@ -21,10 +21,14 @@
#include
#include
+#include
+#include
#include
#include
+#include
+
namespace oox::drawingml::chart { class ChartConverter; }
namespace rtl { template class Reference; }
@@ -57,6 +61,22 @@ class ScRangeData;
namespace oox::xls {
+enum class FontClassification : sal_uInt8
+{
+None= 0x,
+Asian = 0x0001,
+Cmplx = 0x0002,
+Latin = 0x0004
+};
+
+}
+
+namespace o3tl {
+template<> struct typed_flags :
is_typed_flags {};
+}
+
+namespace oox::xls {
+
class ExcelFilter;
/** Functor for case-insensitive string comparison, usable in maps etc. */
@@ -87,6 +107,32 @@ class FormulaBuffer;
class WorkbookGlobals;
typedef std::shared_ptr< WorkbookGlobals > WorkbookGlobalsRef;
+struct FontDescriptorHash
+{
+size_t operator()( const css::awt::FontDescriptor& rKey) const
+{
+std::size_t seed = rKey.Name.hashCode();
+o3tl::hash_combine(seed, rKey.Height);
+o3tl::hash_combine(seed, rKey.Width);
+o3tl::hash_combine(seed, rKey.StyleName.hashCode());
+o3tl::hash_combine(seed, rKey.Family);
+o3tl::hash_combine(seed, rKey.CharSet);
+o3tl::hash_combine(seed, rKey.Pitch);
+o3tl::hash_combine(seed, rKey.CharacterWidth);
+o3tl::hash_combine(seed, rKey.Weight);
+o3tl::hash_combine(seed, rKey.Slant);
+o3tl::hash_combine(seed, rKey.Underline);
+o3tl::hash_combine(seed, rKey.Strikeout);
+o3tl::hash_combine(seed, rKey.Orientation);
+o3tl::hash_combine(seed, rKey.Kerning);
+o3tl::hash_combine(seed, rKey.WordLineMode);
+o3tl::hash_combine(seed, rKey.Type);
+return seed;
+}
+};
+
+typedef std::unordered_map FontClassificationMap;
+
/** Helper class to provide access to global workbook data.
All classes derived from this helper class will have access to a singleton
@@ -235,6 +281,8 @@ public:
PivotCacheBuffer& getPivotCaches() const;
/** Returns the collection of pivot tables. */
PivotTableBuffer& getPivotTables() const;
+/** Shared cache of Font Classifications to avoid repeated lookups */
+FontClassificationMap& getFontClassificationCache() const;
// converters -
diff --git a/sc/source/filter/oox/stylesbuffer.cxx
b/sc/source/filter/oox/stylesbuffer.cxx
index 25f273b1e1f2..e38b5cd13002 100644
--- a/sc/source/filter/oox/stylesbuffer.cxx
+++ b/sc/source/filter/oox/stylesbuffer.cxx
@@ -793,44 +793,65 @@ void Font::finalizeImport()
if( !maUsedFlags.mbNameUsed )
return;
-PropertySet aDocProps( getDocument() );
-Reference< XDevice > xDevice( aDocProps.getAnyProperty(
PROP_ReferenceDevice ), UNO_QUERY );
-if( !xDevice.is() )
-return;
-
-Reference< XFont2 > xFont( xDevice->getFont( maApiData.maDesc ), UNO_QUERY
);
-if( !xFont.is() )
-return;
-
-// #91658# CJK fonts
-bool bHasAsian =
-xFont->hasGlyphs( OUString( u'\x3041' ) ) ||// 3040-309F: Hiragana
-xFont->hasGlyphs( OUString( u'\x30A1' ) ) ||// 30A0-30FF: Katakana
-xFont->hasGlyphs( OUString( u'\x3111' ) ) ||// 3100-312F: Bopomofo
-xFont->hasGlyphs( OUString( u'\x3131' ) ) ||// 3130-318F: Hangul
Compatibility Jamo
-xFont->hasGlyphs( OUString( u'\x3301' ) ) ||// 3300-33FF: CJK
Compatibility
-xFont->hasGlyphs( OUString( u'\x3401' ) ) ||// 3400-4DBF: CJK
Unified Ideographs Extension A
-xFont->hasGlyphs( OUString( u'\x4E01' ) ) ||// 4E00-9FFF: CJK
Unified Ideographs
-xFont->hasGlyphs( OUString( u'\x7E01' ) ) ||// 4E00-9FFF: CJK
Unified Ideographs
-xFont->hasGlyphs( OUString( u'\xA001' ) ) ||// A001-A48F: Yi
Syllables
-xFont->hasGlyphs( OUString( u'\xAC01' ) ) ||// AC00-D7AF: Hangul
Syllables
-xFont->hasGlyphs( OUString( u'\xCC01' ) )
[Libreoffice-commits] core.git: svgio/source
svgio/source/svgreader/svgcharacternode.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 4db0a2c1c3b0a9c9868574b5c538bfd92adfb48a
Author: Caolán McNamara
AuthorDate: Fri Aug 11 11:02:29 2023 +0100
Commit: Caolán McNamara
CommitDate: Fri Aug 11 18:11:31 2023 +0200
cid#1539807 Uninitialized pointer field
Change-Id: I500c5d9f15c6a57622a28ea7cbf3b5f90761b5c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155582
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/svgio/source/svgreader/svgcharacternode.cxx
b/svgio/source/svgreader/svgcharacternode.cxx
index 6150fbb62953..2b88944aa8d0 100644
--- a/svgio/source/svgreader/svgcharacternode.cxx
+++ b/svgio/source/svgreader/svgcharacternode.cxx
@@ -78,7 +78,8 @@ namespace svgio::svgreader
SvgNode* pParent,
OUString aText)
: SvgNode(SVGToken::Character, rDocument, pParent),
-maText(std::move(aText))
+maText(std::move(aText)),
+mpTextParent(nullptr)
{
}
[Libreoffice-commits] core.git: sc/source
sc/source/ui/undo/undoblk.cxx |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) New commits: commit fa3cfa7ac8b9000aec943e13dc75f8d3828685b4 Author: Caolán McNamara AuthorDate: Fri Aug 11 11:00:49 2023 +0100 Commit: Caolán McNamara CommitDate: Fri Aug 11 18:11:15 2023 +0200 cid#1539806 Dereference after null check Change-Id: I5fe74e633e8374eb38cf39f5989f7d2e696e445e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155581 Tested-by: Caolán McNamara Reviewed-by: Caolán McNamara diff --git a/sc/source/ui/undo/undoblk.cxx b/sc/source/ui/undo/undoblk.cxx index 0ef3e22f66b1..d352ba143ba8 100644 --- a/sc/source/ui/undo/undoblk.cxx +++ b/sc/source/ui/undo/undoblk.cxx @@ -1148,8 +1148,10 @@ void ScUndoPaste::DoChange(bool bUndo) pDocShell->PostPaint(aDrawRanges, nPaint, nExtFlags); pDocShell->PostDataChanged(); -if (pViewShell) -pViewShell->CellContentChanged(); +if (!pViewShell) +return; + +pViewShell->CellContentChanged(); if (bColsAffected || bRowsAffected) ScTabViewShell::notifyAllViewsSheetGeomInvalidation(
[Libreoffice-bugs] [Bug 156610] Rename from Navigator context menu does not work on first try / tries
https://bugs.documentfoundation.org/show_bug.cgi?id=156610 --- Comment #4 from Jim Raykowski --- I agree this needs some tweaking. I think better behavior would be to start inline editing when an already selected entry is clicked on and to launch the rename dialog for the Rename... menu item. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103100 Eyal Rozenberg changed: What|Removed |Added Depends on||156736 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=156736 [Bug 156736] Table with mixed RTL/LTR cells & objects garbled after trivial width adjustment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156736] Table with mixed RTL/LTR cells & objects garbled after trivial width adjustment
https://bugs.documentfoundation.org/show_bug.cgi?id=156736 Eyal Rozenberg changed: What|Removed |Added Blocks||103100 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103100 [Bug 103100] [META] Writer table bugs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156736] Table with mixed RTL/LTR cells & objects garbled after trivial width adjustment
https://bugs.documentfoundation.org/show_bug.cgi?id=156736 Eyal Rozenberg changed: What|Removed |Added Summary|Table is garbled with mixed |Table with mixed RTL/LTR |RTL/LTR cells and objects |cells & objects garbled |after automatic adjustment |after trivial width |of column with |adjustment |double-clicking of border | --- Comment #2 from Eyal Rozenberg --- Wow, this is a fun bug :-( Hossein, can you create an ODT-only document for reproducing this? Perhaps will less rows (as few possible while still manifesting the bug)? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 42428] Split-pane window for side-by-side / above-and-below editing of a single document
https://bugs.documentfoundation.org/show_bug.cgi?id=42428 --- Comment #34 from Eyal Rozenberg --- (In reply to William from comment #33) > Please look at Nisus Writer Pro (Mac) – https://nisus.com/ – for > inspiration. It allows unlimited document window splitting in horizontal or > vertical direction, as well as synchronized scrolling between split screens > and/or multiple document windows (e.g. for visually comparing versions). > Have not seen this in any other WYSIWYG rich text word processor. Some plain > text coding editors come close, but those obviously have different use > cases. From the Nisus Writer Pro documentation: > https://nisus.com/pro/help/Views-Tabs-Sidebars-Splits-Focus.html#Splits. Those are very interesting ideas, but - they belong in a different bug report. This one is about just the side-by-side/above-and-below split (and MSO feature parity). Richer functionality would be appreciated, but should not block the more basic request. So, please file that extra bug and mark it related to this one. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: svl/source
svl/source/notify/SfxBroadcaster.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit ab4de498475930ba829a23262f82e32df36f1ea2
Author: Noel Grandin
AuthorDate: Fri Aug 11 14:23:34 2023 +0200
Commit: Noel Grandin
CommitDate: Fri Aug 11 17:42:53 2023 +0200
fix SfxBroadcaster::ForAllListeners
regression from
commit 7c66fc45239d2589e90fd694d54b3ff826b1bd15
Author: Noel Grandin
Date: Thu Jun 1 14:22:57 2023 +0200
use internal iterator for SfxBroadcaster
Change-Id: Ibd3abf23337c8fb0937d245474f2b89c8936a3ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155589
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/svl/source/notify/SfxBroadcaster.cxx
b/svl/source/notify/SfxBroadcaster.cxx
index e9b0e1e1a552..419c535f56dc 100644
--- a/svl/source/notify/SfxBroadcaster.cxx
+++ b/svl/source/notify/SfxBroadcaster.cxx
@@ -137,7 +137,8 @@ void
SfxBroadcaster::ForAllListeners(std::function f) const
{
SfxListener* const pListener = m_Listeners[i];
if (pListener)
-f(pListener);
+if (f(pListener))
+break;
}
}
[Libreoffice-bugs] [Bug 113144] Selecting a Hebrew character with the mouse doesn't select its diacritics
https://bugs.documentfoundation.org/show_bug.cgi?id=113144 Eyal Rozenberg changed: What|Removed |Added CC||kha...@libreoffice.org --- Comment #6 from Eyal Rozenberg --- Reproduced with: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5cd9de202765e243e41416802f3e4486b8a96f16 CPU threads: 4; OS: Linux 6.1; UI render: default; VCL: gtk3 Locale: he-IL (en_IL); UI: en-US -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 42428] Split-pane window for side-by-side / above-and-below editing of a single document
https://bugs.documentfoundation.org/show_bug.cgi?id=42428 --- Comment #33 from William --- Please look at Nisus Writer Pro (Mac) – https://nisus.com/ – for inspiration. It allows unlimited document window splitting in horizontal or vertical direction, as well as synchronized scrolling between split screens and/or multiple document windows (e.g. for visually comparing versions). Have not seen this in any other WYSIWYG rich text word processor. Some plain text coding editors come close, but those obviously have different use cases. From the Nisus Writer Pro documentation: https://nisus.com/pro/help/Views-Tabs-Sidebars-Splits-Focus.html#Splits. -- You are receiving this mail because: You are the assignee for the bug.
