[Libreoffice-bugs] [Bug 155195] FILEOPEN File on SMB share cannot be opened via file dialog of KDE

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155195

Michael Weghorn  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sc/source

2023-10-07 Thread Michael Weghorn (via logerrit)
 sc/source/ui/Accessibility/AccessibleCell.cxx |9 +
 1 file changed, 9 insertions(+)

New commits:
commit dc85ff37bf4265884d7d0ec5974557ead1cc5cfe
Author: Michael Weghorn 
AuthorDate: Tue Sep 26 10:30:27 2023 +0200
Commit: Michael Weghorn 
CommitDate: Sun Oct 8 06:39:36 2023 +0200

tdf#157299 sc a11y: Limit amount of reported cell relations

For the cells referenced in formulae, the a11y `CONTROLLED_BY`
relation is reported.

Since formulae can reference a large amount of cells, creating
the a11y objects for each of these cells can result in Calc freezing,
e.g. for the tdf#157299 `SUMIF` example that was referencing a whole
column (containing 1048576 cells).

Prevent that by limiting the maximimum amount of cells to handle
here to 1000, and just printing a warning to the log otherwise
and ignore cell ranges having more cells.

If there's a need to increase the limit, that should be possible
within certain bounds. My test with a modified SUMIF that just
uses 999 cells wasn't causing any noticeable delay and the
relations were shown in Accerciser as expected.

From a quick look at the Orca and NVDA source code,
they currently don't seem to make use of the
`CONTROLLED_BY` relation for LibreOffice at all.

Change-Id: Ia74e0e88d9dbd7650832664b9c027262367b428e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157265
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 
(cherry picked from commit c2d6ae1781ad4be5f9acefecce7e1504df02cf8f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157225
Reviewed-by: Patrick Luby 

diff --git a/sc/source/ui/Accessibility/AccessibleCell.cxx 
b/sc/source/ui/Accessibility/AccessibleCell.cxx
index 96020a08ef63..bb1a22117cc4 100644
--- a/sc/source/ui/Accessibility/AccessibleCell.cxx
+++ b/sc/source/ui/Accessibility/AccessibleCell.cxx
@@ -455,6 +455,15 @@ void ScAccessibleCell::AddRelation(const ScRange& rRange,
 const sal_uInt32 nCount(static_cast(rRange.aEnd.Col() -
 rRange.aStart.Col() + 1) * (rRange.aEnd.Row() -
 rRange.aStart.Row() + 1));
+
+// tdf#157299 avoid handling a large amount of cells for performance 
reasons
+if (nCount > 1000)
+{
+SAL_WARN("sc", "ScAccessibleCell::AddRelation: Not setting relations "
+   "for cell range with more than 1000 cells for 
performance reasons.");
+return;
+}
+
 uno::Sequence < uno::Reference < uno::XInterface > > aTargetSet( nCount );
 uno::Reference < uno::XInterface >* pTargetSet = aTargetSet.getArray();
 sal_uInt32 nPos(0);


[Libreoffice-bugs] [Bug 157305] [1] Feature request: linking sections without changing order of lists

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157305

--- Comment #7 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155195] FILEOPEN File on SMB share cannot be opened via file dialog of KDE

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155195

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152423] creating primary key/index in Base

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152423

--- Comment #3 from QA Administrators  ---
Dear arilaskin,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157392] Cannot input full-width commas and periods

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157392

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152623] Impress animation is utterly broken in version 7. Extra characters appear on slide.

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152623

--- Comment #4 from QA Administrators  ---
Dear gearhead,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155195] FILEOPEN File on SMB share cannot be opened via file dialog of KDE

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155195

--- Comment #9 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 154749] White space selection after selecting text

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154749

--- Comment #3 from QA Administrators  ---
Dear Szasz-Fabian Jozsef,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144403] FILEOPEN libreoffice crashes when opening/creating new document

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144403

--- Comment #12 from QA Administrators  ---
Dear florian.k2000,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 92950] No support for sqlite relations via Relations menu

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=92950

--- Comment #23 from QA Administrators  ---
Dear Rolf Leggewie,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144832] EDITING Add to list operation on an ordered/unordered list is not recorded as tracked change

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144832

--- Comment #4 from QA Administrators  ---
Dear NISZ LibreOffice Team,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 41189] Editing to change capitalized text does not work as expected

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=41189

--- Comment #11 from QA Administrators  ---
Dear Ed Servello,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 44293] FORMATTING: Format ordinal number suffixes (1st -> 1^st) doesn't work in Portuguese

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=44293

--- Comment #7 from QA Administrators  ---
Dear Gustavo Pacheco,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 128055] OPTIONS DIALOG: Impossibility to assign a precise tab stop and other values in mm

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128055

--- Comment #5 from QA Administrators  ---
Dear Ivan,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 128492] When opening HTML in Writer column and table width are not taken into account

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128492

--- Comment #7 from QA Administrators  ---
Dear Simon Urli,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112722] Issue on setting up Relationship

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112722

--- Comment #15 from QA Administrators  ---
Dear perie_gut,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 106471] FILESAVE DOCX: diamond bullet size increased because symbol changed (per comment 5)

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106471

--- Comment #14 from QA Administrators  ---
Dear Oliver Sander,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108170] Hyperlinks don't highlight 'Internet Link' entry in character styles list

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108170

--- Comment #9 from QA Administrators  ---
Dear Yousuf Philips (jay) (retired),

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 101370] Undo/Redo don't refresh page/slide pane thumbnail after changing page/slide properties

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101370

--- Comment #13 from QA Administrators  ---
Dear OfficeUser,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157650] Unhelpful (almost to the point of being useless) error when XML in content.xml is malformed

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157650

--- Comment #8 from m.a.riosv  ---
I think bibisect should wait for someone else confirmation.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157650] Unhelpful (almost to the point of being useless) error when XML in content.xml is malformed

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157650

Jambunathan K  changed:

   What|Removed |Added

   Keywords||bibisectRequest

--- Comment #7 from Jambunathan K  ---
Since the bug is a regression, I am marking the bug with a `bibisect request`

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157423] No entry possible directly after opening a CALC-file

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157423

Kira Tubo  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||kira.t...@gmail.com
 Status|UNCONFIRMED |NEEDINFO

--- Comment #4 from Kira Tubo  ---
@Roland, if you could also upload a sample doc for us to test, that would be
helpful for us to try and reproduce the bug. I have set the bug's status to
'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document
is provided. (Please note that the attachment will be public, remove any
sensitive information before attaching it. See
https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F
for help on how to do so.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157650] Unhelpful (almost to the point of being useless) error when XML in content.xml is malformed

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157650

--- Comment #6 from Jambunathan K  ---
Created attachment 190087
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190087=edit
lo 7.5 screenshot (Good)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157650] Unhelpful (almost to the point of being useless) error when XML in content.xml is malformed

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157650

--- Comment #5 from Jambunathan K  ---
Created attachment 190086
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190086=edit
lo 7.6 screenshot (Good)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157650] Unhelpful (almost to the point of being useless) error when XML in content.xml is malformed

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157650

--- Comment #4 from Jambunathan K  ---
(In reply to m.a.riosv from comment #3)
> Created attachment 190082 [details]
> Screnshoot with the message v 24.02
> 
> For me, it shows the number line/row.
> Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
> Build ID: 9eb419b0b0f019f5fbc48ff1a11977e8b041edee
> CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL:
> win
> Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Jumbo
> 
> There is the ODF validator, that shows a bit more information.
> https://odfvalidator.org/



I don't have a windows machine.  So, I can't confirm with Windows.


On linux side, I have mutiple builds installed, and I confirm that there 
this is a regression between 2 builds 4bcf6d9c905e7b5558ee8d9f7f616ce61eadb8f8
(ok) and  2a217a80bf383ddab0a5e0959ab2fd907dfd3406 (not ok)

Should be easy to spot the offending commit with simple change log tracking or
bisection 


Doesn't work with 

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2a217a80bf383ddab0a5e0959ab2fd907dfd3406
CPU threads: 4; OS: Linux 6.4; UI render: default; VCL: gtk3
Locale: en-IN (en_IN); UI: en-US
Calc: threaded


Works with the following two versions of LO

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 4bcf6d9c905e7b5558ee8d9f7f616ce61eadb8f8
CPU threads: 4; OS: Linux 6.4; UI render: default; VCL: gtk3
Locale: en-IN (en_IN); UI: en-US
Calc: threaded

Version: 7.5.5.2 (X86_64) / LibreOffice Community
Build ID: 50(Build:2)
CPU threads: 4; OS: Linux 6.4; UI render: default; VCL: gtk3
Locale: en-IN (en_IN); UI: en-US
Debian package version: 4:7.5.5-4
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157422] Wrap cell contents not being retained on libreoffice Calc

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157422

Kira Tubo  changed:

   What|Removed |Added

 CC||kira.t...@gmail.com

--- Comment #10 from Kira Tubo  ---
I am able to reproduce on Windows, but ONLY when whole sheet is selected. For
me, the issue is NOT reproducible if only columns or rows are selected.
(Checked this in safe mode as well)

Steps:
1. Open new calc spreadsheet
2. Type contents in A1 so that it would need to wrap
3. Select WHOLE sheet
4. Format > Cells > Alignment > check "Wrap text automatically", then click OK
5. Type contents in another cell so that it would need to wrap
6. Check Format > Cells > Alignment again to see that "Wrap text automatically"
is not checked for cells other than A1 (not expected)

Screencast: https://somup.com/c06jV9Bu2p

--

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: dd7fc07f83416a3d8a444947b7d28f7347520d6a
CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157654] EDITING - Converting a rectangle object with borders to bitmap it loses its right and bottom borders

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157654

m.a.riosv  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #3 from m.a.riosv  ---
Reproducible, but only with bitmap, looks as one pixel is lost, so the line
width to '0' is missing.

Version: 7.6.1.2 (X86_64) / LibreOffice Community
Build ID: f5defcebd022c5bc36bbb79be232cb6926d8f674
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (en_US); UI: en-US Calc: CL threaded

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9eb419b0b0f019f5fbc48ff1a11977e8b041edee
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: es-ES (en_US); UI: en-US Calc: CL threaded Jumbo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157654] EDITING - Converting a rectangle object with borders to bitmap it loses its right and bottom borders

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157654

--- Comment #2 from Leandro de Oliveira  ---
*** Bug 157655 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157655] EDITING - Converting a rectangle object with borders to bitmap it loses its right and bottom borders

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157655

Leandro de Oliveira  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Leandro de Oliveira  ---


*** This bug has been marked as a duplicate of bug 157654 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157654] EDITING - Converting a rectangle object with borders to bitmap it loses its right and bottom borders

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157654

--- Comment #1 from Leandro de Oliveira  ---
CHANGED TO 7.6.2.1 AND IT HAPPENED TOO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157654] EDITING - Converting a rectangle object with borders to bitmap it loses its right and bottom borders

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157654

Leandro de Oliveira  changed:

   What|Removed |Added

Version|7.6.0.3 release |7.6.2.1 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157655] New: EDITING - Converting a rectangle object with borders to bitmap it loses its right and bottom borders

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157655

Bug ID: 157655
   Summary: EDITING - Converting a rectangle object with borders
to bitmap it loses its right and bottom borders
   Product: LibreOffice
   Version: 7.6.2.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: leandro-...@hotmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155195] FILEOPEN File on SMB share cannot be opened via file dialog of KDE

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155195

--- Comment #8 from Ettore Atalan  ---
LibreOffice 7.6.1 was installed from the openSUSE Tumbleweed repositories.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157339] Libre insists that when I type Brandonites what I mean is Brandishes

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157339

Kira Tubo  changed:

   What|Removed |Added

 CC||kira.t...@gmail.com

--- Comment #2 from Kira Tubo  ---
@ubbish...@gmail.com, maybe you accidentally added those words to be
autocorrected to "Brandishes". To check: 

1. Go to Tools > Autocorrect > Autocorrect Options. 
2. Under Replace tab, search for "Brandonite" and "Brandonites" in the
"Replace" text box
3. If those entries exist, delete them, then click OK. 

---

Not reproducible with: 

Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

Version: 7.3.3.2 (x64) / LibreOffice Community
Build ID: d1d0ea68f081ee2800a922cac8f79445e4603348
CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157654] New: EDITING - Converting a rectangle object with borders to bitmap it loses its right and bottom borders

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157654

Bug ID: 157654
   Summary: EDITING - Converting a rectangle object with borders
to bitmap it loses its right and bottom borders
   Product: LibreOffice
   Version: 7.6.0.3 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: leandro-...@hotmail.com

Description:
Converting a rectangle object with borders to bitmap it loses its right and
bottom borders

Steps to Reproduce:
1 - create any rectangle shape
2 - right click over the shape > convert > bitmap
3 - observe the right and bottom borders desappear

Actual Results:
loses right and bottom borders

Expected Results:
keep right and bottom borders


Reproducible: Always


User Profile Reset: Yes

Additional Info:
happened to partial rectangle shapes too, only where the line is straight.

Version: 7.6.0.3 (X86_64) / LibreOffice Community
Build ID: 69edd8b8ebc41d00b4de3915dc82f8f0fc3b6265
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 75627] General number format change leads to inconsistent/lost formatting

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=75627

Kira Tubo  changed:

   What|Removed |Added

 CC||kira.t...@gmail.com

--- Comment #11 from Kira Tubo  ---
Reproduced on master build 

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: dd7fc07f83416a3d8a444947b7d28f7347520d6a
CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sfx2/source

2023-10-07 Thread Mihai Vasiliu (via logerrit)
 sfx2/source/sidebar/SidebarController.cxx |7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

New commits:
commit a37f77b8c297a28e6bb0072eb882f62a920aecf5
Author: Mihai Vasiliu 
AuthorDate: Thu Oct 5 16:28:02 2023 +0300
Commit: Patrick Luby 
CommitDate: Sun Oct 8 02:16:17 2023 +0200

tdf#150639 Fix sidebar width too narrow

The mnWidthOnSplitterButtonDown is initialized to 0 at program start.
This makes every call to take the else case until the user manually changes 
the
width, but some decks such as Master Slides have the mnMinimalWidth too low 
which
makes them too narrow for the content they should display to the user.

Change-Id: I8fc4924f70dedbdc8d162ceceb620ff80e59
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157596
Tested-by: Jenkins
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 
(cherry picked from commit 6e6db2a3360d7ee89cae14cbcfe386e7425daf98)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157621
Reviewed-by: Mihai Vasiliu 
Reviewed-by: Patrick Luby 

diff --git a/sfx2/source/sidebar/SidebarController.cxx 
b/sfx2/source/sidebar/SidebarController.cxx
index b967cbb10369..278c0ca34719 100644
--- a/sfx2/source/sidebar/SidebarController.cxx
+++ b/sfx2/source/sidebar/SidebarController.cxx
@@ -658,7 +658,12 @@ void SidebarController::OpenThenToggleDeck (
 if(mnWidthOnSplitterButtonDown > 0 && mnWidthOnSplitterButtonDown > 
nRequestedWidth){
 SetChildWindowWidth(mnWidthOnSplitterButtonDown);
 }else{
-SetChildWindowWidth(nRequestedWidth);
+// tdf#150639 The mnWidthOnSplitterButtonDown is initialized to 0 
at program start.
+// This makes every call to take the else case until the user 
manually changes the
+// width, but some decks such as Master Slides have the 
mnMinimalWidth too low which
+// makes them too narrow for the content they should display to 
the user.
+SetChildWindowWidth(nRequestedWidth > mnSavedSidebarWidth ? 
nRequestedWidth
+  : 
mnSavedSidebarWidth);
 }
 }
 }


[Libreoffice-bugs] [Bug 157653] (Not Responding) Message appears constantly when using Spreadsheet

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157653

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
Please try repairing the program in Add or Remove programs in Windows.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157640] PDF: Error converting pdf to xlsx format, source file could not be loaded

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157640

--- Comment #3 from m.a.riosv  ---
I think so.
https://ask.libreoffice.org/t/does-libreoffice-have-a-convert-from-pdf-to-csv-or-ods-function/38134

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157568] After deleting the content of a cell by pressing the delete key, Orca still speaks the content.

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157568

--- Comment #8 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/bf421456ac92b695e8a8e40d0d434c8e52782f90

tdf#157568 After deleting the content of a cell by pressing the delete..

It will be available in 7.6.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - editeng/source sc/CppunitTest_sc_a11y.mk sc/qa sc/source

2023-10-07 Thread Noel Grandin (via logerrit)
 editeng/source/accessibility/AccessibleStaticTextBase.cxx |   15 +--
 sc/CppunitTest_sc_a11y.mk |1 
 sc/qa/extras/accessibility/basics.cxx |   18 
 sc/source/ui/Accessibility/AccessibleContextBase.cxx  |   56 +-
 sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx  |   10 --
 sc/source/ui/inc/AccessibleContextBase.hxx|   18 +---
 sc/source/ui/inc/AccessibleSpreadsheet.hxx|3 
 7 files changed, 71 insertions(+), 50 deletions(-)

New commits:
commit bf421456ac92b695e8a8e40d0d434c8e52782f90
Author: Noel Grandin 
AuthorDate: Sat Oct 7 11:42:40 2023 +0200
Commit: Patrick Luby 
CommitDate: Sun Oct 8 01:33:09 2023 +0200

tdf#157568 After deleting the content of a cell by pressing the delete..

.. key, Orca still speaks the content.

this reverts
commit f22cb3dfab413a2917cd810b8e1b8f644a016327
Author: Noel Grandin 
Date:   Mon Jun 12 20:02:19 2023 +0200
tdf#155376 weakly cache ScAccessibleCell

which was a nice idea, but means that we would need to have
some way of updating the ScAccessibleCell when the associated
cell data changes. Which is likely to be complicated.

So return to creating new ScAccessibleCell objects all the time,
but fix them to not leak.

Change-Id: Ie17ee5c950c9809d4c7281f93761584f75256121
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157673
Tested-by: Jenkins
Reviewed-by: Noel Grandin 
(cherry picked from commit 8e886993f32b7db11a99bdecf06451e6de6c3842)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157627
Reviewed-by: Michael Weghorn 
Reviewed-by: Patrick Luby 

diff --git a/editeng/source/accessibility/AccessibleStaticTextBase.cxx 
b/editeng/source/accessibility/AccessibleStaticTextBase.cxx
index 954117189798..85082bc4cb21 100644
--- a/editeng/source/accessibility/AccessibleStaticTextBase.cxx
+++ b/editeng/source/accessibility/AccessibleStaticTextBase.cxx
@@ -121,8 +121,7 @@ namespace accessibility
 
 void SetEventSource( const uno::Reference< XAccessible >& rInterface )
 {
-
-mxThis = rInterface;
+mpThis = rInterface.get();
 }
 
 void SetOffset( const Point& );
@@ -163,8 +162,8 @@ namespace accessibility
 
 // our frontend class (the one implementing the actual
 // interface). That's not necessarily the one containing the impl
-// pointer
-uno::Reference< XAccessible > mxThis;
+// pointer. Note that this is not an uno::Reference to prevent 
ref-counting cycles and leaks.
+XAccessible* mpThis;
 
 // implements our functionality, we're just an adapter (guarded by 
solar mutex)
 mutable rtl::Reference mxTextParagraph;
@@ -207,7 +206,7 @@ namespace accessibility
 mxTextParagraph->Dispose();
 
 // drop references
-mxThis = nullptr;
+mpThis = nullptr;
 mxTextParagraph.clear();
 }
 
@@ -215,7 +214,7 @@ namespace accessibility
 {
 
 if( !mxTextParagraph.is() )
-throw lang::DisposedException ("object has been already disposed", 
mxThis );
+throw lang::DisposedException ("object has been already disposed", 
mpThis );
 
 // TODO: Have a different method on AccessibleEditableTextPara
 // that does not care about state changes
@@ -273,7 +272,7 @@ namespace accessibility
 
 if( nFlatIndex < 0 )
 throw 
lang::IndexOutOfBoundsException("AccessibleStaticTextBase_Impl::Index2Internal: 
character index out of bounds",
-  mxThis);
+  mpThis);
 // gratuitously accepting larger indices here, 
AccessibleEditableTextPara will throw eventually
 
 sal_Int32 nCurrPara, nCurrIndex, nParas, nCurrCount;
@@ -305,7 +304,7 @@ namespace accessibility
 
 // not found? Out of bounds
 throw 
lang::IndexOutOfBoundsException("AccessibleStaticTextBase_Impl::Index2Internal: 
character index out of bounds",
-  mxThis);
+  mpThis);
 }
 
 bool AccessibleStaticTextBase_Impl::SetSelection( sal_Int32 nStartPara, 
sal_Int32 nStartIndex,
diff --git a/sc/CppunitTest_sc_a11y.mk b/sc/CppunitTest_sc_a11y.mk
index e013beb987cc..3418f2fd4c44 100644
--- a/sc/CppunitTest_sc_a11y.mk
+++ b/sc/CppunitTest_sc_a11y.mk
@@ -16,6 +16,7 @@ $(eval $(call gb_CppunitTest_add_exception_objects,sc_a11y, \
 $(eval $(call gb_CppunitTest_use_libraries,sc_a11y, \
sal \
cppu \
+   cppuhelper \
subsequenttest \
test \
tl \
diff --git a/sc/qa/extras/accessibility/basics.cxx 
b/sc/qa/extras/accessibility/basics.cxx
index f07a24d1a353..03b5eadabe54 100644
--- a/sc/qa/extras/accessibility/basics.cxx
+++ 

[Libreoffice-bugs] [Bug 157568] After deleting the content of a cell by pressing the delete key, Orca still speaks the content.

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157568

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:24.2.0   |target:24.2.0 target:7.6.3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155195] FILEOPEN File on SMB share cannot be opened via file dialog of KDE

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155195

--- Comment #7 from Michael Weghorn  ---
(In reply to Ettore Atalan from comment #6)
> What has changed in LibreOffice version 7.6.2 compared to version 7.6.1 in
> dealing with SMB shares?

I don't know. I only see that it works for me with the 7.6.2 from the LO
website while it doesn't work for you with 7.6.1 (from whatever source you have
it, maybe from your distro?).

So it would be interesting to know whether the same version that I'm using on
Debian testing also works for you on OpenSUSE. If it doesn't, it might be some
distro-specific thing, or related to the kind of SMB share, or ...
(It would at least help to narrow potential causes down further. Same rationale
for the other questions in comment 5.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 101912] [META] Accessibility (a11y) bugs and enhancements

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101912
Bug 101912 depends on bug 157616, which changed state.

Bug 157616 Summary: Calc does not update accessible information when cell edited
https://bugs.documentfoundation.org/show_bug.cgi?id=157616

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157568] After deleting the content of a cell by pressing the delete key, Orca still speaks the content.

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157568

--- Comment #7 from Michael Weghorn  ---
*** Bug 157616 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157616] Calc does not update accessible information when cell edited

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157616

Michael Weghorn  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #6 from Michael Weghorn  ---
This works fine again with the fix for tdf#157568 in place.

Thanks, Noel!

Pending backport for 7.6:
https://gerrit.libreoffice.org/c/core/+/157627

*** This bug has been marked as a duplicate of bug 157568 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157568] After deleting the content of a cell by pressing the delete key, Orca still speaks the content.

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157568

Michael Weghorn  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157348] Bad font rendering with 7.5 and higher because freetype interpreter-version is ignored

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157348

--- Comment #11 from Frank Steiner  ---
Just realized that it also depends on your fontconfig settings. On my system, a
file in in /etc/fonts/conf.d set the autohint mode to "false" for Arial. When I
change that to true, Arial looks bold even with interpreter-version=35.

So, the sharper and leaner display for Arial (and all other MS fonts and
Anonymous Pro) is used only with autohinter disabled and interpreter-version=35 

Maybe Libreoffice > 7.4.7 has decided to enforce autohinter mode to all
truetype fonts no matter what the fontconfig settings are?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140568] Allow page gutter position 'Right' for left pages

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140568

Eyal Rozenberg  changed:

   What|Removed |Added

   Keywords||needsUXEval

--- Comment #12 from Eyal Rozenberg  ---
(In reply to Stéphane Guillou (stragu) from comment #11)
> From the comments, there is agreement that something needs to change, so
> setting to "new".

Agreement that _something_ needs to change does not mean agreement that the
change suggested in the title. 

I disagree with going further down the weird rabbit hole that we're in.

* We have implicit book-binding modes which only implicitly refer to, using
page layout names: "Right only" and "Left only".
* We have a distinction without a difference in gutter vs margin in pages which
are always to be on the same side of the spine/gutter - and pages which are not
going to be bound at all. This forces our users to think of binding and
gutters, when they should not have to, since they're just printing some pages.

This is already enough IMHO to reject this suggestion. But it's not all...

* We call the gutter options "top" and "left", even though that is typically
not the correct description. That is, the gutter is to _both_ sides of the
spine. (Yes, if you print sheets with one side empty, and bind them on one
side, then you could say the gutter is on the right and or on the left of the
pages; but again - why should we burden our users with this metaphor?)
* We have "Left only" and "Right only" page layouts, further confusing users.
* For more confusion, think about RTL books, where the page turning order is
opposite than for LTR; and about the fact that many places in the LO UI
conflate "Left" with "Start" and "Right" with "End".
* For even more confusion, There's a checkbox, separate from the "Gutter
Position" drop-down list box, entitled "Gutter on right side of page". 

I am already going insane with these...

So, let us not do this at all. Instead, let's:

* Drop the entire Page Layout option.
* Replace "Gutter on right side of page" with a choice of which side of the
page the gutter starts with. Or perhaps drop it too, and take that setting from
the choice of RTL/LTR page direction.
* The gutter value will now only save as gutter which is added on alternating
sides with each consecutive page.
* Have the Footer and Header options "Different for Right and Left pages"
replaced with "Different for odd and even pages". And perhaps mention they're
odd or even in the current sequence of pages (although then there's the
question of whether we want to draw users' attention to the concept of a page
sequence, which isn't well-fleshed-out in the UI despite its importance).


TBH, I'm not claiming that's the only reasonable thing to do. We could,
alternatively, be more explicit about sheets and not just pages, and about
binding, and things like folios, quartos etc. And have more meaningful and
illustrative previews. But I really dislike what we have now.

So, suggest marking INVALID or WONTFIX for the reason of going for a more
fundamental change.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157348] Bad font rendering with 7.5 and higher because freetype interpreter-version is ignored

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157348

--- Comment #10 from Frank Steiner  ---
I just tested with the 7.4.7 you can download from
https://www.libreoffice.org/download/download-libreoffice/
Anyway, the effect is way more visible with the microsoft fonts, so maybe your
distro has a package for fetching those. "fetchmsttfonts" on opensuse or
ttf-mscorefonts-installer on ubuntu for example.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120466] [META] DOCX (OOXML) anchor and text wrapping bugs and enhancements

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120466

BogdanB  changed:

   What|Removed |Added

 Depends on||157571


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157571
[Bug 157571] FILEOPEN: DOCX: Incorrect blank space after table
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157571] FILEOPEN: DOCX: Incorrect blank space after table

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157571

BogdanB  changed:

   What|Removed |Added

 Blocks||120466
 CC||buzea.bog...@libreoffice.or
   ||g


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=120466
[Bug 120466] [META] DOCX (OOXML) anchor and text wrapping bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157579] FILEOPEN: DOCX: Image not displayed

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157579

BogdanB  changed:

   What|Removed |Added

 Blocks||104468
 CC||buzea.bog...@libreoffice.or
   ||g


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104468
[Bug 104468] [META] DOCX (OOXML) image-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104468] [META] DOCX (OOXML) image-related issues

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104468

BogdanB  changed:

   What|Removed |Added

 Depends on||157579


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157579
[Bug 157579] FILEOPEN: DOCX: Image not displayed
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156905] Copy and paste a formula, now paste just the value

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156905

--- Comment #11 from BogdanB  ---
(In reply to Kira Tubo from comment #9)
> Created attachment 190085 [details]
> original file from OP saved in 7.5.5.2
> 
> It seems that there are issues bibisecting win64-7.6 repository with files
> saved using more recent builds. 

Indeed, I tried to bibisect with a new empty file and were problem also.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/mimo/mimo-7-5' - 13 commits - configure.ac connectivity/source dbaccess/source include/connectivity include/svx sc/qa sc/source svx/source sw/qa sw/sourc

2023-10-07 Thread Andras Timar (via logerrit)
 configure.ac   |2 
 connectivity/source/parse/sqliterator.cxx  |4 
 connectivity/source/parse/sqlnode.cxx  |7 
 dbaccess/source/core/api/SingleSelectQueryComposer.cxx |2 
 dbaccess/source/core/inc/SingleSelectQueryComposer.hxx |1 
 include/connectivity/sqlparse.hxx  |   10 -
 include/svx/ParseContext.hxx   |   11 +
 sc/qa/unit/helper/qahelper.cxx |   38 
 sc/source/core/data/dpoutput.cxx   |6 
 sc/source/filter/inc/rtfexp.hxx|8 -
 sc/source/filter/rtf/rtfexp.cxx|  135 +
 svx/source/form/ParseContext.cxx   |   16 ++
 sw/qa/extras/uiwriter/data/tdf62032_apply_style.odt|binary
 sw/qa/extras/uiwriter/uiwriter7.cxx|   20 ++
 sw/source/core/doc/docfmt.cxx  |5 
 ucb/source/ucp/webdav-curl/CurlSession.cxx |   15 +
 vcl/source/gdi/embeddedfontshelper.cxx |   31 +++
 17 files changed, 265 insertions(+), 46 deletions(-)

New commits:
commit 9d4bf91ba30c991aaed3b97dd4173f7705c6b5ae
Author: Andras Timar 
AuthorDate: Sat Oct 7 22:39:13 2023 +0200
Commit: Andras Timar 
CommitDate: Sat Oct 7 22:39:13 2023 +0200

Bump version to 7.5.7.1.M1

Change-Id: If271b729371e33867a99434bfc31bc07e1f7dd83

diff --git a/configure.ac b/configure.ac
index 58c53365d027..64168c1e1e1e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[7.5.7.1],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[7.5.7.1.M1],[],[],[http://documentfoundation.org/])
 
 dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just 
fine if it is installed
 dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails 
hard
commit f4b6dcaa110be8c4e3e6a7dede73548766f8e907
Author: Noel Grandin 
AuthorDate: Fri Aug 18 13:49:54 2023 +0200
Commit: Andras Timar 
CommitDate: Sat Oct 7 22:02:07 2023 +0200

Fix curl proxy access for non-authenticated proxy

If rSession.m_Proxy.aName is a simple host-name, the CurlUri constructor
will fail with CURLUE_BAD_SCHEME, so just ignore the error here,
we only care about parsing out the username/password

Change-Id: Iec2d6e7315a5899f6120a43199b75bf62db2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155834
Tested-by: Jenkins
Reviewed-by: Noel Grandin 
(cherry picked from commit 9b30b4b1678e8be15ba51d236bd9a3e693d8d3d6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157318
Reviewed-by: Michael Stahl 
(cherry picked from commit 4b5e94e3d718b6afc571db3cff8321c44436c1ad)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157322
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Aron Budea 

diff --git a/ucb/source/ucp/webdav-curl/CurlSession.cxx 
b/ucb/source/ucp/webdav-curl/CurlSession.cxx
index 5773fd2398f6..4839a1f85e03 100644
--- a/ucb/source/ucp/webdav-curl/CurlSession.cxx
+++ b/ucb/source/ucp/webdav-curl/CurlSession.cxx
@@ -1207,11 +1207,18 @@ auto CurlProcessor::ProcessRequest(
 ::std::optional oAuthProxy;
 if (pEnv && !rSession.m_isAuthenticatedProxy && 
!rSession.m_Proxy.aName.isEmpty())
 {
-// the hope is that this must be a URI
-CurlUri const uri(rSession.m_Proxy.aName);
-if (!uri.GetUser().isEmpty() || !uri.GetPassword().isEmpty())
+try
+{
+// the hope is that this must be a URI
+CurlUri const uri(rSession.m_Proxy.aName);
+if (!uri.GetUser().isEmpty() || !uri.GetPassword().isEmpty())
+{
+oAuthProxy.emplace(uri.GetUser(), uri.GetPassword(), 
CURLAUTH_ANY);
+}
+}
+catch (DAVException&)
 {
-oAuthProxy.emplace(uri.GetUser(), uri.GetPassword(), CURLAUTH_ANY);
+// ignore any parsing failure here
 }
 }
 decltype(CURLAUTH_ANY) const authSystem(CURLAUTH_NEGOTIATE | CURLAUTH_NTLM 
| CURLAUTH_NTLM_WB);
commit 8f4206c07dfaf433ede718c3018a7e9697f3c349
Author: Henry Castro 
AuthorDate: Wed Aug 30 10:25:51 2023 -0400
Commit: Andras Timar 
CommitDate: Sat Oct 7 22:02:06 2023 +0200

connectiviy: fix to detect column data type

if Base SQL query:

SELECT COUNT("test"."id") from Test

If changed to Spanish UI, detect the column type
from a neutral context parser.

Signed-off-by: Henry Castro 
Change-Id: I1faa8ff8417a0fc4996b289bd2ce0baad52fc00c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156298
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: 

[Libreoffice-commits] core.git: compilerplugins/clang solenv/CompilerTest_compilerplugins_clang.mk

2023-10-07 Thread Stephan Bergmann (via logerrit)
 compilerplugins/clang/ostr.cxx   |  286 +++
 compilerplugins/clang/test/ostr.cxx  |   98 +
 solenv/CompilerTest_compilerplugins_clang.mk |1 
 3 files changed, 385 insertions(+)

New commits:
commit 7ef3d937415185ef66e32dd3043783eddcd03db5
Author: Stephan Bergmann 
AuthorDate: Fri Oct 6 09:50:54 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Sat Oct 7 22:34:09 2023 +0200

loplugin:ostr: Rewrite some uses of O[U]String to use ""_ostr/u""_ustr 
literals

This is a first cut at rewriting uses of OUString constructed from u"..." as
u"..."_ustr.  It covers the same changes as
 "WIP: Delete OUString 
UTF-16
string literal ctor/assignment op", but does so with automatic rewriting 
(see
e0c33ec15f53a01fa3ee07489871bbe09bb5c9c3 "loplugin:ostr: automatic rewrite",
plus a handful of 002b0a9d5793e07609f953b9961b04bcab7a7e3f "loplugin:ostr:
manual modifications" where automatic rewriting wasn't set up to handle 
macro
bodies).

The compilation-time impact of all those changes appears to be negligible:  
For
some Windows build of mine, just touching the files that would be affected 
by
002b0a9d5793e07609f953b9961b04bcab7a7e3f and
e0c33ec15f53a01fa3ee07489871bbe09bb5c9c3 (but without actually applying 
those
changes yet) and doing `time /opt/lo/bin/make -O check screenshot PKGFORMAT=
gb_SUPPRESS_TESTS=x`, three times in a row reported sample real times of

  21m15.438s  23m17.840s  23m41.529s

and repeating all that with the two changes actually applied reported sample
real times of

  22m43.547s  21m42.687s  23m1.813s

The plugin itself is already prepared to do further rewrites (see the 
TODOs),
which will be done in follow-up commits.

Change-Id: I408ecf056dce1b9da683d7c377b8d9058df1558d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157676
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/ostr.cxx b/compilerplugins/clang/ostr.cxx
new file mode 100644
index ..13fd5df0b29a
--- /dev/null
+++ b/compilerplugins/clang/ostr.cxx
@@ -0,0 +1,286 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+#include 
+#include 
+
+#include "check.hxx"
+#include "compat.hxx"
+#include "plugin.hxx"
+
+// Rewrite some uses of O[U]String to use ""_ostr/u""_ustr literals.
+
+namespace
+{
+class Ostr : public loplugin::FilteringRewritePlugin
+{
+public:
+explicit Ostr(loplugin::InstantiationData const& data)
+: FilteringRewritePlugin(data)
+{
+}
+
+// Needed so that e.g.
+//
+//   struct S { OUString s; };
+//   S s = {u"foo"};
+//
+// is caught:
+bool shouldVisitImplicitCode() const { return true; }
+
+void run() override
+{
+if (compiler.getLangOpts().CPlusPlus)
+{
+TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
+}
+}
+
+bool TraverseParmVarDecl(ParmVarDecl* decl)
+{
+// Otherwise,
+//
+//   struct S { void f(int = 0); };
+//   void S::f(int) {}
+//
+// would visit the default argument twice:
+if (decl->hasDefaultArg() && !decl->hasUninstantiatedDefaultArg()
+&& !decl->hasUnparsedDefaultArg() && 
!defaultArgs_.insert(decl->getDefaultArg()).second)
+{
+return true;
+}
+return RecursiveASTVisitor::TraverseParmVarDecl(decl);
+}
+
+bool TraverseCXXFunctionalCastExpr(CXXFunctionalCastExpr* expr)
+{
+functionalCasts_.push(expr);
+auto const ret = 
RecursiveASTVisitor::TraverseCXXFunctionalCastExpr(expr);
+functionalCasts_.pop();
+return ret;
+}
+
+bool VisitCXXConstructExpr(CXXConstructExpr const* expr)
+{
+if (ignoreLocation(expr))
+{
+return true;
+}
+if (!loplugin::DeclCheck(expr->getConstructor()->getParent())
+ .Class("OUString")
+ .Namespace("rtl")
+ .GlobalNamespace())
+{
+return true;
+}
+if (expr->getNumArgs() != 2)
+{
+return true;
+}
+if (!loplugin::TypeCheck(expr->getArg(1)->getType())
+ .Struct("Dummy")
+ .Namespace("libreoffice_internal")
+ .Namespace("rtl")
+ .GlobalNamespace())
+{
+return true;
+}
+auto const e2 = 
dyn_cast(expr->getArg(0)->IgnoreParenImpCasts());
+if 

[Libreoffice-commits] core.git: sc/qa

2023-10-07 Thread Stephan Bergmann (via logerrit)
 sc/qa/extras/accessibility/basics.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2a92fe4c529f438421fad14cfbb1a76a45902fd9
Author: Stephan Bergmann 
AuthorDate: Sat Oct 7 21:32:51 2023 +0200
Commit: Stephan Bergmann 
CommitDate: Sat Oct 7 22:33:44 2023 +0200

loplugin:ostr

Change-Id: I6c5aefbf36d032751bc2b5a84995182adb2c83e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157682
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sc/qa/extras/accessibility/basics.cxx 
b/sc/qa/extras/accessibility/basics.cxx
index 06cce36ded49..06b6134ce10b 100644
--- a/sc/qa/extras/accessibility/basics.cxx
+++ b/sc/qa/extras/accessibility/basics.cxx
@@ -110,7 +110,7 @@ CPPUNIT_TEST_FIXTURE(test::AccessibleTestBase, 
Test64BitChildIndices)
 
 CPPUNIT_TEST_FIXTURE(test::AccessibleTestBase, tdf157568)
 {
-load(u"private:factory/scalc");
+load(u"private:factory/scalc"_ustr);
 
 uno::Reference sheet(
 
getDocumentAccessibleContext()->getAccessibleChild(0)->getAccessibleContext(), 
// sheet 1


[Libreoffice-bugs] [Bug 136372] [META] PPTX shape related issues

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136372
Bug 136372 depends on bug 156902, which changed state.

Bug 156902 Summary: FILEOPEN PPTX: graphics not shown (edit mode and 
presentation mode)
https://bugs.documentfoundation.org/show_bug.cgi?id=156902

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 122755] [META] Formulae in Writer tables bugs and enhancements

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122755
Bug 122755 depends on bug 156905, which changed state.

Bug 156905 Summary: Copy and paste a formula, now paste just the value
https://bugs.documentfoundation.org/show_bug.cgi?id=156905

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157132] LibreOffice 7.6.0 copying of formulas in writer table – relative distance of cells in formula not preserved after copying to other lines

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157132

Kira Tubo  changed:

   What|Removed |Added

 CC||ovari...@zoho.com

--- Comment #3 from Kira Tubo  ---
*** Bug 156905 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156905] Copy and paste a formula, now paste just the value

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156905

Kira Tubo  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #10 from Kira Tubo  ---


*** This bug has been marked as a duplicate of bug 157132 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156905] Copy and paste a formula, now paste just the value

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156905

Kira Tubo  changed:

   What|Removed |Added

 CC||kira.t...@gmail.com

--- Comment #9 from Kira Tubo  ---
Created attachment 190085
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190085=edit
original file from OP saved in 7.5.5.2

It seems that there are issues bibisecting win64-7.6 repository with files
saved using more recent builds. I resaved the original file using 7.5.5.2 (see
attached) and was able to successfully bibisect to the commit below. That being
said, it looks like this issue is the same as Bug 157132, and since Bjoern was
already contacted about it there, I'll go ahead and close this bug as a
duplicate. 

--

commit 7aa64323a7955693095c217d9a7d3bdaba3efc50
Author: Norbert Thiebaud 
Date:   Tue Mar 14 05:33:59 2023 -0700

source sha:8a3dc12a13a3b9e99dbd5000ca6a1d541cf472f7

--

commit  8a3dc12a13a3b9e99dbd5000ca6a1d541cf472f7[log]
author  Bjoern MichaelsenSat Mar 04
02:18:58 2023 +0100
committer   Michael Stahl  Tue Mar 14
10:25:01 2023 +
tree54604d51a119eef82d8b9e059e1da7dac60f12e1
parent  a224948ef44eadfb32aee002d5f0e9f10c9e47de [diff]

-

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: oox/qa oox/source

2023-10-07 Thread Regina Henschel (via logerrit)
 oox/qa/unit/data/tdf156902_GlowOnGroup.docx |binary
 oox/qa/unit/shape.cxx   |   12 
 oox/source/drawingml/shape.cxx  |3 ++-
 3 files changed, 14 insertions(+), 1 deletion(-)

New commits:
commit e84ae94270f0f0037fa2662a5f2765b37a50c33e
Author: Regina Henschel 
AuthorDate: Sat Oct 7 17:37:46 2023 +0200
Commit: Regina Henschel 
CommitDate: Sat Oct 7 21:52:48 2023 +0200

tdf#156902 Do not set glow on group shape in import

Currently a group is not able to use glow. But in MS Office it is
possible. When we try to set glow at the group, we produce an
exception and no children are imported. So for now the patch prevents
setting glow.

Change-Id: Ifa7245ebf3c38f8685239c2b62eefccd35aab870
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157679
Tested-by: Jenkins
Reviewed-by: Regina Henschel 

diff --git a/oox/qa/unit/data/tdf156902_GlowOnGroup.docx 
b/oox/qa/unit/data/tdf156902_GlowOnGroup.docx
new file mode 100644
index ..0c176eefa025
Binary files /dev/null and b/oox/qa/unit/data/tdf156902_GlowOnGroup.docx differ
diff --git a/oox/qa/unit/shape.cxx b/oox/qa/unit/shape.cxx
index 565ac39b52ad..5033ed660e30 100644
--- a/oox/qa/unit/shape.cxx
+++ b/oox/qa/unit/shape.cxx
@@ -817,6 +817,18 @@ CPPUNIT_TEST_FIXTURE(OoxShapeTest, testWordArtDefaultColor)
 CPPUNIT_ASSERT_EQUAL(uno::Any(Color(3, 74, 144)),
  xShapeProps->getPropertyValue(u"FillColor"_ustr));
 }
+
+CPPUNIT_TEST_FIXTURE(OoxShapeTest, testGlowOnGroup)
+{
+// The document contains a group of two shapes. A glow-effect is set on 
the group.
+// Without the fix, the children of the group were not imported at all.
+loadFromURL(u"tdf156902_GlowOnGroup.docx");
+uno::Reference 
xDrawPagesSupplier(mxComponent, uno::UNO_QUERY);
+uno::Reference 
xDrawPage(xDrawPagesSupplier->getDrawPages()->getByIndex(0),
+ uno::UNO_QUERY);
+uno::Reference xGroup(xDrawPage->getByIndex(0), 
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xGroup->getCount());
+}
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/oox/source/drawingml/shape.cxx b/oox/source/drawingml/shape.cxx
index 03a22dc441b4..f48b4d856a4a 100644
--- a/oox/source/drawingml/shape.cxx
+++ b/oox/source/drawingml/shape.cxx
@@ -1914,7 +1914,8 @@ Reference< XShape > const & Shape::createAndInsert(
 }
 
 // Set glow effect properties
-if ( aEffectProperties.maGlow.moGlowRad.has_value() )
+if (aEffectProperties.maGlow.moGlowRad.has_value()
+&& aServiceName != "com.sun.star.drawing.GroupShape")
 {
 uno::Reference propertySet (mxShape, 
uno::UNO_QUERY);
 propertySet->setPropertyValue("GlowEffectRadius", 
Any(convertEmuToHmm(aEffectProperties.maGlow.moGlowRad.value(;


[Libreoffice-bugs] [Bug 89683] delimited text files ('csv', 'tsv', etc.) are opened as text documents if Writer is the active window

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89683

--- Comment #32 from Turtle  ---
Comment on attachment 190074
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190074
patch for 7.5.6.2

I have now tested the patch on linux and it works as expected.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 89683] delimited text files ('csv', 'tsv', etc.) are opened as text documents if Writer is the active window

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89683

--- Comment #31 from Turtle  ---
(In reply to Mike Kaganski from comment #30)
> Created attachment 190080 [details]
> Opening a TXT in Excel
> 
> (In reply to Turtle from comment #27)
> > Also add:
> > 1.5 When in calc if one needs to open a .txt file and refer to it, the text
> > file should be opened with writer. As text/plain is not a spreadsheet 
> > format.
> 
> Same with Excel: opening a TXT from it, opens it in Excel, not in Word. This
> is what my point 2.1 in about; and no matter how hard you try, *many* (most
> - given how many are used to MS Office) users are accustomed to *this*
> (already existing) behavior implemented in LibreOffice currently.

I can't reproduce this behavior.
what would be an example work flow where this would be useful?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/mimo/mimo-7-5' - 7 commits - instsetoo_native/CustomTarget_install.mk officecfg/registry postprocess/CustomTarget_signing.mk postprocess/signing setup_na

2023-10-07 Thread Andras Timar (via logerrit)
 instsetoo_native/CustomTarget_install.mk   |2 +-
 officecfg/registry/schema/org/openoffice/Office/UI/Infobar.xcs |4 ++--
 officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs |2 +-
 postprocess/CustomTarget_signing.mk|2 +-
 postprocess/signing/signing.pl |3 ++-
 setup_native/source/packinfo/spellchecker_selection.txt|2 +-
 solenv/bin/modules/installer/epmfile.pm|2 +-
 7 files changed, 9 insertions(+), 8 deletions(-)

New commits:
commit dc2525480bf32192f249caf981e37d773da23c12
Author: Andras Timar 
AuthorDate: Tue Aug 23 21:57:10 2022 +0200
Commit: Andras Timar 
CommitDate: Sat Oct 7 20:46:59 2023 +0200

Debian package names must not contain uppercase letters

MIMO packageversion string contains capital M.

Change-Id: Iefa3d8102e1c7ebb779e84a246abb7262bbad384

diff --git a/solenv/bin/modules/installer/epmfile.pm 
b/solenv/bin/modules/installer/epmfile.pm
index 51d596dcb519..63e9a1bba06f 100644
--- a/solenv/bin/modules/installer/epmfile.pm
+++ b/solenv/bin/modules/installer/epmfile.pm
@@ -292,7 +292,7 @@ sub create_epm_header
 
installer::packagelist::resolve_packagevariables(\$installer::globals::packageversion,
 $variableshashref, 0);
 if ( $variableshashref->{'PACKAGEREVISION'} ) { 
$installer::globals::packagerevision = $variableshashref->{'PACKAGEREVISION'}; }
 
-$line = "%version" . " " . $installer::globals::packageversion . "\n";
+$line = "%version" . " " . lc $installer::globals::packageversion . "\n";
 push(@epmheader, $line);
 
 $line = "%release" . " " . $installer::globals::packagerevision . "\n";
commit 8a5c26a5c1aab9326bd2a140480f1b45790f502b
Author: Andras Timar 
AuthorDate: Tue Aug 23 21:14:10 2022 +0200
Commit: Andras Timar 
CommitDate: Sat Oct 7 20:46:56 2023 +0200

Linux languagepacks take the first from the language list

Change-Id: Id470e88f16b502aeb576a8512f55cd34c56f3500

diff --git a/setup_native/source/packinfo/spellchecker_selection.txt 
b/setup_native/source/packinfo/spellchecker_selection.txt
index d0627963f3ab..304fff501f0a 100644
--- a/setup_native/source/packinfo/spellchecker_selection.txt
+++ b/setup_native/source/packinfo/spellchecker_selection.txt
@@ -48,7 +48,7 @@ eo = "eo"
 es = "es,an,ca,fr,gl,oc,pt-PT"
 et = "et"
 fa = "fa"
-fr = "de,en,eo,es,fr,it,pt-PT"
+fr = "fr,de,en,eo,es,it,pt-PT"
 gd = "gd"
 gl = "gl,pt-PT,es"
 gu = "gu"
commit fb276df1bedd2ed4f0bc80ee3607e62e284035de
Author: Andras Timar 
AuthorDate: Wed Mar 30 11:08:43 2022 +0200
Commit: Andras Timar 
CommitDate: Sat Oct 7 20:46:33 2023 +0200

[MIMO] disable Donate and GetInvolved infobars

Change-Id: I991cf07a89b417fde332fb665a5d2df9930015a4

diff --git a/officecfg/registry/schema/org/openoffice/Office/UI/Infobar.xcs 
b/officecfg/registry/schema/org/openoffice/Office/UI/Infobar.xcs
index 6b29f0b47e6a..d919f7440571 100644
--- a/officecfg/registry/schema/org/openoffice/Office/UI/Infobar.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/UI/Infobar.xcs
@@ -34,13 +34,13 @@
 
   Whether the Infobar showing the call for donations is 
enabled
 
-true
+false
   
   
 
   Whether the Infobar showing the call to 'Get Involved' is 
enabled
 
-true
+false
   
   
 
commit 2779b7d4a8a60e41f51da707c849063e7f961e77
Author: Andras Timar 
AuthorDate: Mon Jun 7 09:00:47 2021 +0200
Commit: Andras Timar 
CommitDate: Sat Oct 7 20:46:33 2023 +0200

no MinimumWidth of Sidebar for MIMO

Change-Id: I66fc17b1d791e06debe95248a8952986171a4596

diff --git a/officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs 
b/officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs
index 4b5d13b63c5f..29ad0e7a69cc 100644
--- a/officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs
@@ -259,7 +259,7 @@
   Enables the calculation of the sidebar's minimum width based 
on the size of all decks.
   If false, the user has full control over the sidebar width.
 
-true
+false
   
 
 
commit cc8cdf89e3fe3e08b1dcc85df9fd63faa7038dc6
Author: Andras Timar 
AuthorDate: Tue May 25 10:16:03 2021 +0200
Commit: Andras Timar 
CommitDate: Sat Oct 7 20:46:29 2023 +0200

Dictionary list required by MIMO

Change-Id: Idefb9480460ae4ba946d7171811fde432c3c0927

diff --git a/setup_native/source/packinfo/spellchecker_selection.txt 
b/setup_native/source/packinfo/spellchecker_selection.txt
index 602bf0b51603..d0627963f3ab 100644
--- a/setup_native/source/packinfo/spellchecker_selection.txt
+++ b/setup_native/source/packinfo/spellchecker_selection.txt
@@ -48,7 +48,7 @@ eo = "eo"
 es = "es,an,ca,fr,gl,oc,pt-PT"
 et = "et"
 fa = "fa"
-fr = "fr,es"
+fr = 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - include/xmloff xmloff/source

2023-10-07 Thread Michael Stahl (via logerrit)
 include/xmloff/txtimp.hxx |2 -
 include/xmloff/xmlimp.hxx |1 
 xmloff/source/core/xmlimp.cxx |9 +
 xmloff/source/text/txtimp.cxx |   65 ++
 4 files changed, 70 insertions(+), 7 deletions(-)

New commits:
commit 4db3cdb9536594ee2b2700e63d4f0f98983814aa
Author: Michael Stahl 
AuthorDate: Tue Sep 26 15:03:58 2023 +0200
Commit: Caolán McNamara 
CommitDate: Sat Oct 7 20:47:43 2023 +0200

tdf#156146 xmloff: ODF import: add backward compatibility hack

As a follow-up to ade0a153f453500f15343380ac937252992733e0 "tdf#114287
xmloff: ODF import: fix text:list override of list style", add some ugly
compatibility hack to preserve the visual layout of documents produced
by LO versions before 7.6.

Override the left/first-line margin of the applied numbering rules with
what is in the paragraph or paragraph style, and try to do this only in
the specific situation where the list style is the same.

Change-Id: I1f4520c9bf9d2257d2e3864e4ddb2d28451bbd2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157284
Tested-by: Jenkins
Tested-by: Gabor Kelemen 
Reviewed-by: Thorsten Behrens 
(cherry picked from commit 7cf5faec6fdbc27dd77d2d36fb2ff205322cba0d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157325
Reviewed-by: Caolán McNamara 

diff --git a/include/xmloff/txtimp.hxx b/include/xmloff/txtimp.hxx
index 218db6fa7acd..24caf36e53d7 100644
--- a/include/xmloff/txtimp.hxx
+++ b/include/xmloff/txtimp.hxx
@@ -170,7 +170,7 @@ public:
 // Add parameter  (#i73509#)
 // Add parameter  in order to suppress the handling of the 
list attributes (#i80724#)
 OUString SetStyleAndAttrs(
-SvXMLImport const & rImport,
+SvXMLImport & rImport,
 const css::uno::Reference< css::text::XTextCursor >& rCursor,
 const OUString& rStyleName,
 bool bPara,
diff --git a/include/xmloff/xmlimp.hxx b/include/xmloff/xmlimp.hxx
index 664e26056cef..f833e2b9aedb 100644
--- a/include/xmloff/xmlimp.hxx
+++ b/include/xmloff/xmlimp.hxx
@@ -554,6 +554,7 @@ public:
 static const sal_uInt16 LO_6x = 60 | LO_flag;
 static const sal_uInt16 LO_63x = 63 | LO_flag;
 static const sal_uInt16 LO_7x = 70 | LO_flag;
+static const sal_uInt16 LO_76 = 76 | LO_flag;
 static const sal_uInt16 LO_New = 100 | LO_flag;
 static const sal_uInt16 ProductVersionUnknown = SAL_MAX_UINT16;
 
diff --git a/xmloff/source/core/xmlimp.cxx b/xmloff/source/core/xmlimp.cxx
index 1a177c5a11e5..98d4dc3f4971 100644
--- a/xmloff/source/core/xmlimp.cxx
+++ b/xmloff/source/core/xmlimp.cxx
@@ -219,7 +219,14 @@ public:
 }
 else if ('7' == loVersion[0])
 {
-mnGeneratorVersion = SvXMLImport::LO_7x;
+if (loVersion.getLength() > 2 && loVersion[2] == 
'6')
+{
+mnGeneratorVersion = SvXMLImport::LO_76; // 7.6
+}
+else
+{
+mnGeneratorVersion = SvXMLImport::LO_7x;
+}
 }
 else
 {
diff --git a/xmloff/source/text/txtimp.cxx b/xmloff/source/text/txtimp.cxx
index b31c2b6ab99b..1e17f9921df0 100644
--- a/xmloff/source/text/txtimp.cxx
+++ b/xmloff/source/text/txtimp.cxx
@@ -1003,8 +1003,40 @@ static bool lcl_HasListStyle( const OUString& sStyleName,
 
 return bRet;
 }
+
+namespace {
+
+auto IsPropertySet(uno::Reference const& 
rxParaStyles,
+uno::Reference const& rxPropSet,
+OUString const& rProperty)
+{
+uno::Reference const xPropState(rxPropSet, 
uno::UNO_QUERY);
+// note: this is true only if it is set in automatic style
+if (xPropState->getPropertyState(rProperty) == 
beans::PropertyState_DIRECT_VALUE)
+{
+return true;
+}
+// check if it is set by any parent common style
+OUString style;
+rxPropSet->getPropertyValue("ParaStyleName") >>= style;
+while (!style.isEmpty() && rxParaStyles.is() && 
rxParaStyles->hasByName(style))
+{
+uno::Reference const 
xStyle(rxParaStyles->getByName(style), uno::UNO_QUERY);
+assert(xStyle.is());
+uno::Reference const xStyleProps(xStyle, 
uno::UNO_QUERY);
+if (xStyleProps->getPropertyState(rProperty) == 
beans::PropertyState_DIRECT_VALUE)
+{
+return true;
+}
+style = xStyle->getParentStyle();
+}
+return false;
+};
+
+} // namespace
+
 OUString XMLTextImportHelper::SetStyleAndAttrs(
-SvXMLImport const & rImport,
+SvXMLImport & rImport,
 const Reference < XTextCursor >& rCursor,
 const OUString& rStyleName,
 bool bPara,
@@ -1086,13 +1118,16 @@ OUString 

[Libreoffice-bugs] [Bug 111768] Sidebar shows wrong paragraph alignment in shape

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111768

Kira Tubo  changed:

   What|Removed |Added

 CC||kira.t...@gmail.com
 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #9 from Kira Tubo  ---
No longer reproduced in daily master build. Closing ticket as WORKSFORME.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: dd7fc07f83416a3d8a444947b7d28f7347520d6a
CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

Reproduced in:

Version: 5.4.0.0.alpha1 (x64)
Build ID: 0b9f9bef65bb21ebb6a64aafad448f7f62dc824a
CPU threads: 6; OS: Windows 6.19; UI render: default; 
Locale: en-US (en_US); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103470] [META] Paragraph content panel of the Properties deck/tab of the sidebar

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103470
Bug 103470 depends on bug 111768, which changed state.

Bug 111768 Summary: Sidebar shows wrong paragraph alignment in shape
https://bugs.documentfoundation.org/show_bug.cgi?id=111768

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Changes to 'distro/mimo/mimo-7-5'

2023-10-07 Thread Christian Lohmaier (via logerrit)
New branch 'distro/mimo/mimo-7-5' available with the following commits:


[Libreoffice-bugs] [Bug 156040] Dark Mode - Category names are not visible in the Base control panel

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156040

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |caolan.mcnamara@collabora.c
   |desktop.org |om

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157653] (Not Responding) Message appears constantly when using Spreadsheet

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157653

Deanna  changed:

   What|Removed |Added

Summary|Spreadsheet Program - (Not  |(Not Responding) Message
   |Responding) Message |appears constantly when
   |constantly  |using Spreadsheet

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157653] New: Spreadsheet Program - (Not Responding) Message constantly

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157653

Bug ID: 157653
   Summary: Spreadsheet Program - (Not Responding) Message
constantly
   Product: LibreOffice
   Version: 7.5.6.2 release
  Hardware: x86-64 (AMD64)
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dmariaperez6...@yahoo.com

Description:
When I am using Spreadsheet, a "Not Responding" (NR) notice appears at the top
of the screen where document name is shown every time I attempt a new task. For
example, after I click to highlight a new row or new column; and, after I tab
from one cell to the next; and, after I click on PGUP; and, when I start typing
new text, etc., the program stops functioning for several seconds, that is, the
program freezes. Afterwards, the NR message pops up. The program has never
crashed on me while this happens. Spreadsheet eventually un-freezes and NR
disappears. After the NR message disappears, the program completes whatever
task I attempted. It takes several seconds for the entire process to complete;
I haven't counted but I believe about 5 seconds from when program freezes to
when program does whatever I typed on keyboard. 

Steps to Reproduce:
1. In Spreadsheet, tap any key (e.g., highlight row) or attempt any function
(e.g., CTRL + x) on keyboard
2. program freezes
3. Not Responding appears at top of screen
4. after several seconds, Not Responding disappears
5. Spreadsheet completes task

Actual Results:
N/A unless you mean step 5 above

Expected Results:
Software should not freeze


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Version: 7.5.6.2 (X86_64) / LibreOffice Community
Build ID: f654817fb68d6d4600d7d2f6b647e47729f55f15
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135859] [META] Formula-related issues

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135859
Bug 135859 depends on bug 144519, which changed state.

Bug 144519 Summary: EDITING: writer: deleting a formula leaves the cursor at 
the wrong place
https://bugs.documentfoundation.org/show_bug.cgi?id=144519

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144519] EDITING: writer: deleting a formula leaves the cursor at the wrong place

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144519

Buovjaga  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||ilmari.lauhakangas@libreoff
   ||ice.org
 Resolution|--- |WORKSFORME

--- Comment #3 from Buovjaga  ---
Indeed, repro in 7.1, but not with master.

Arch Linux 64-bit, X11
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b693d19884a09b5f841b30f2e8b586778584ed16
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 6 October 2023

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141790] VIEW: Keep position of document in second LO window still (1)

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141790

Buovjaga  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #8 from Buovjaga  ---
Repro with 7.1, but not with master.

Arch Linux 64-bit, X11
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b693d19884a09b5f841b30f2e8b586778584ed16
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 6 October 2023

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157348] Bad font rendering with 7.5 and higher because freetype interpreter-version is ignored

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157348

--- Comment #9 from Buovjaga  ---
Tried 35 and 40 with Anonymous Pro in the oldest of Linux 7.4 bibisect
repository, but there is no difference. So I can't compare it with the present
state. Hopefully someone else is able to do it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156040] Dark Mode - Category names are not visible in the Base control panel

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156040

--- Comment #8 from Caolán McNamara  ---
We use "ShadowColor" for the background and "LightColor" for the foreground in
this case. It look ok for the gtk case, so its probably a poor choice for
"LightColor" in windows dark mode.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157568] After deleting the content of a cell by pressing the delete key, Orca still speaks the content.

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157568

--- Comment #6 from Patrick Luby  ---
I can confirm that the fix works in my local macOS build:

Version: 24.2.0.0.alpha0+ (AARCH64) / LibreOffice Community
Build ID: 8e886993f32b7db11a99bdecf06451e6de6c3842
CPU threads: 8; OS: macOS 14.0; UI render: Skia/Metal; VCL: osx
Locale: en-CA (en_CA.UTF-8); UI: en-US
Calc: threaded

I also did some light memory leak analysis and I do not see any leaking of iVCL
native accessibility objects so all looks good to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 156884] Selection box lags navigation with keyboard arrows

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156884

--- Comment #7 from Walter Tross  ---
For me this bug _seems_ to have gone away after upgrading from 7.6.1.2 to
7.6.2.1. I have macOS 13.6 (Ventura) on an M2 Pro Mac.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157652] Fileopen DOCX: Glow effect has exchanged color and transparency

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157652

--- Comment #1 from Regina Henschel  ---
Created attachment 190084
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190084=edit
Rendering in Daily and in LO 7.6.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157652] New: Fileopen DOCX: Glow effect has exchanged color and transparency

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157652

Bug ID: 157652
   Summary: Fileopen DOCX: Glow effect has exchanged color and
transparency
   Product: LibreOffice
   Version: 24.2.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: regression
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Created attachment 190083
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190083=edit
Thick glow effect on shape

Open attached document. It has a shape with a thick glow effect. Notice that
the color and the transparency of the the glow effect are exchanged.

I see the problem in Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2902ab24ecc5ffbf4907ea83b2028508b9de6364
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: CL threaded

It is OK in Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 115052] Allow other keys than from US keyboard as shortcut keys

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115052

--- Comment #27 from V Stuart Foote  ---
defined keysyms for use are found in API:

https://api.libreoffice.org/docs/idl/ref/namespacecom_1_1sun_1_1star_1_1awt_1_1Key.html

and found in source:

https://opengrok.libreoffice.org/xref/core/include/vcl/keycodes.hxx

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 115052] Allow other keys than from US keyboard as shortcut keys

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115052

V Stuart Foote  changed:

   What|Removed |Added

URL||https://api.libreoffice.org
   ||/docs/idl/ref/namespacecom_
   ||1_1sun_1_1star_1_1awt_1_1Ke
   ||y.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 115052] Allow other keys than from US keyboard as shortcut keys

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115052

V Stuart Foote  changed:

   What|Removed |Added

 CC||ska...@yahoo.co.uk

--- Comment #26 from V Stuart Foote  ---
*** Bug 157645 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157645] Missing keyboard keys for shortcuts

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157645

V Stuart Foote  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||vsfo...@libreoffice.org
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from V Stuart Foote  ---
the defined keysyms available to LibreOffice UI currently are:

https://opengrok.libreoffice.org/xref/core/include/vcl/keycodes.hxx

with API defs:

https://api.libreoffice.org/docs/idl/ref/namespacecom_1_1sun_1_1star_1_1awt_1_1Key.html

discussion on dupe and friends.

*** This bug has been marked as a duplicate of bug 115052 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147132] Flatten Basic function implementations

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147132

--- Comment #18 from Commit Notification 
 ---
OmkarAcharekar committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/95df8cda94007e7e5b316a02176bed76259c21c4

tdf#147132 Flatten Basic function implementations

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: basic/source

2023-10-07 Thread OmkarAcharekar (via logerrit)
 basic/source/runtime/methods.cxx |   24 
 1 file changed, 8 insertions(+), 16 deletions(-)

New commits:
commit 95df8cda94007e7e5b316a02176bed76259c21c4
Author: OmkarAcharekar 
AuthorDate: Sat Oct 7 12:39:40 2023 +0530
Commit: Ilmari Lauhakangas 
CommitDate: Sat Oct 7 17:40:00 2023 +0200

tdf#147132 Flatten Basic function implementations

Change-Id: I91ab40003011a7c537faa40daf3db85a13946c69
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157669
Tested-by: Jenkins
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/basic/source/runtime/methods.cxx b/basic/source/runtime/methods.cxx
index 8bfb362f98c9..2e84e964d0be 100644
--- a/basic/source/runtime/methods.cxx
+++ b/basic/source/runtime/methods.cxx
@@ -1046,14 +1046,10 @@ void SbRtl_Log(StarBASIC *, SbxArray & rPar, bool)
 void SbRtl_LTrim(StarBASIC *, SbxArray & rPar, bool)
 {
 if (rPar.Count() < 2)
-{
-StarBASIC::Error( ERRCODE_BASIC_BAD_ARGUMENT );
-}
-else
-{
-OUString 
aStr(comphelper::string::stripStart(rPar.Get(1)->GetOUString(), ' '));
-rPar.Get(0)->PutString(aStr);
-}
+return StarBASIC::Error( ERRCODE_BASIC_BAD_ARGUMENT );
+
+OUString aStr(comphelper::string::stripStart(rPar.Get(1)->GetOUString(), ' 
'));
+rPar.Get(0)->PutString(aStr);
 }
 
 
@@ -1318,14 +1314,10 @@ void SbRtl_RTL(StarBASIC * pBasic, SbxArray & rPar, 
bool)
 void SbRtl_RTrim(StarBASIC *, SbxArray & rPar, bool)
 {
 if (rPar.Count() < 2)
-{
-StarBASIC::Error( ERRCODE_BASIC_BAD_ARGUMENT );
-}
-else
-{
-OUString aStr(comphelper::string::stripEnd(rPar.Get(1)->GetOUString(), 
' '));
-rPar.Get(0)->PutString(aStr);
-}
+return StarBASIC::Error( ERRCODE_BASIC_BAD_ARGUMENT );
+
+OUString aStr(comphelper::string::stripEnd(rPar.Get(1)->GetOUString(), ' 
'));
+rPar.Get(0)->PutString(aStr);
 }
 
 void SbRtl_Sgn(StarBASIC *, SbxArray & rPar, bool)


[Libreoffice-commits] core.git: cpp.hint

2023-10-07 Thread Mike Kaganski (via logerrit)
 cpp.hint |   50 ++
 1 file changed, 46 insertions(+), 4 deletions(-)

New commits:
commit 280985ba383b56e3d64fa64f20cd4cc584fb8622
Author: Mike Kaganski 
AuthorDate: Sat Oct 7 16:41:50 2023 +0300
Commit: Mike Kaganski 
CommitDate: Sat Oct 7 17:20:38 2023 +0200

Add some entries into cpp.hint

Improves VS integration: allows to find DECL_LINK implementations,
as well as CPP unit tests defined using CPPUNIT_TEST_FIXTURE.

The macros are stripped down to the minimum to allow IntelliSence
do its job efficiently.

Change-Id: I2de02196d44d72f79d8cd9e06e8093a7620bd9e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157677
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/cpp.hint b/cpp.hint
index fcc7da600731..63269345ce7c 100644
--- a/cpp.hint
+++ b/cpp.hint
@@ -1,4 +1,46 @@
-// Hint files help the Visual Studio IDE interpret Visual C++ identifiers
-// such as names of functions and macros.
-// For more information see https://go.microsoft.com/fwlink/?linkid=865984
-#define SAL_THROW_EXTERN_C()
+// Hint files help the Visual Studio IDE interpret Visual C++ identifiers
+// such as names of functions and macros.
+// For more information see https://go.microsoft.com/fwlink/?linkid=865984
+
+#define SAL_THROW_EXTERN_C()
+
+#define SAL_UNUSED_PARAMETER
+
+#define DECL_LINK(Member, ArgType, RetType) \
+RetType Member(ArgType)
+
+#define DECL_STATIC_LINK(Class, Member, ArgType, RetType) \
+static RetType Member(Class *, ArgType)
+
+#define DECL_DLLPRIVATE_LINK(Member, ArgType, RetType) \
+SAL_DLLPRIVATE RetType Member(ArgType)
+
+#define DECL_DLLPRIVATE_STATIC_LINK(Class, Member, ArgType, RetType) \
+SAL_DLLPRIVATE static RetType Member(Class *, ArgType)
+
+#define IMPL_LINK(Class, Member, ArgType, ArgName, RetType) \
+RetType Class::Member(ArgType ArgName)
+
+#define IMPL_LINK_NOARG(Class, Member, ArgType, RetType) \
+RetType Class::Member(ArgType)
+
+#define IMPL_STATIC_LINK(Class, Member, ArgType, ArgName, RetType) \
+RetType Class::Member(Class *, ArgType ArgName)
+
+#define IMPL_STATIC_LINK_NOARG(Class, Member, ArgType, RetType) \
+RetType Class::Member(Class *, ArgType)
+
+// From workdir/UnpackedTarball/cppunit/include/cppunit/plugin/TestPlugIn.h
+
+#define CPPUNIT_PLUGIN_IMPLEMENT()
+
+// From 
workdir/UnpackedTarball/cppunit/include/cppunit/extensions/HelperMacros.h
+// To allow searching for the test names, where they are defined using the 
macros
+
+#define CPPUNIT_TEST_FIXTURE(TestClass, TestName)  
\
+class TestName : public TestClass  
\
+{  
\
+public:
\
+void TestBody();   
\
+}; 
\
+void TestName::TestBody()


[Libreoffice-commits] core.git: svtools/source

2023-10-07 Thread Szymon Kłos (via logerrit)
 svtools/source/control/ctrlbox.cxx |   83 +++--
 1 file changed, 62 insertions(+), 21 deletions(-)

New commits:
commit d1da6fbf805e5b4c3f22f18941ac240cbd3d8277
Author: Szymon Kłos 
AuthorDate: Mon Aug 28 13:00:15 2023 +0200
Commit: Szymon Kłos 
CommitDate: Sat Oct 7 17:05:26 2023 +0200

jsdialog: cache only best quality font previews

to keep single cache for all the views, we downscale
result if needed when we draw on a target

Change-Id: I3b57ec08b2260029ff469a13da725feff04555d0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156190
Reviewed-by: Caolán McNamara 
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157671
Tested-by: Jenkins
Reviewed-by: Szymon Kłos 

diff --git a/svtools/source/control/ctrlbox.cxx 
b/svtools/source/control/ctrlbox.cxx
index e5b0883ad87e..22bfde7febe5 100644
--- a/svtools/source/control/ctrlbox.cxx
+++ b/svtools/source/control/ctrlbox.cxx
@@ -333,9 +333,32 @@ static int gFontNameBoxes;
 static size_t gPreviewsPerDevice;
 static std::vector> gFontPreviewVirDevs;
 static std::vector gRenderedFontNames;
+static int gHighestDPI = 0;
 
 namespace
 {
+std::vector>& getFontPreviewVirDevs()
+{
+return gFontPreviewVirDevs;
+}
+
+void clearFontPreviewVirDevs()
+{
+for (auto  : gFontPreviewVirDevs)
+rDev.disposeAndClear();
+gFontPreviewVirDevs.clear();
+}
+
+std::vector& getRenderedFontNames()
+{
+return gRenderedFontNames;
+}
+
+void clearRenderedFontNames()
+{
+gRenderedFontNames.clear();
+}
+
 void calcCustomItemSize(const weld::ComboBox& rComboBox)
 {
 gUserItemSz = Size(rComboBox.get_approximate_digit_width() * 52, 
rComboBox.get_text_height());
@@ -355,13 +378,14 @@ IMPL_LINK(FontNameBox, SettingsChangedHdl, 
VclSimpleEvent&, rEvent, void)
 if (rEvent.GetId() != VclEventId::ApplicationDataChanged)
 return;
 
+if (comphelper::LibreOfficeKit::isActive())
+return;
+
 DataChangedEvent* pData = 
static_cast(static_cast(rEvent).GetData());
 if (pData->GetType() == DataChangedEventType::SETTINGS)
 {
-for (auto  : gFontPreviewVirDevs)
-rDev.disposeAndClear();
-gFontPreviewVirDevs.clear();
-gRenderedFontNames.clear();
+clearFontPreviewVirDevs();
+clearRenderedFontNames();
 calcCustomItemSize(*m_xComboBox);
 if (mbWYSIWYG && mpFontList && !mpFontList->empty())
 {
@@ -398,10 +422,8 @@ FontNameBox::~FontNameBox()
 --gFontNameBoxes;
 if (!gFontNameBoxes)
 {
-for (auto  : gFontPreviewVirDevs)
-rDev.disposeAndClear();
-gFontPreviewVirDevs.clear();
-gRenderedFontNames.clear();
+clearFontPreviewVirDevs();
+clearRenderedFontNames();
 }
 }
 
@@ -769,16 +791,34 @@ OutputDevice& FontNameBox::CachePreview(size_t nIndex, 
Point* pTopLeft,
 const FontMetric& rFontMetric = (*mpFontList)[nIndex];
 const OUString& rFontName = rFontMetric.GetFamilyName();
 
+if (comphelper::LibreOfficeKit::isActive())
+{
+// we want to cache only best quality previews
+if (gHighestDPI < nDPIX || gHighestDPI < nDPIY)
+{
+clearRenderedFontNames();
+clearFontPreviewVirDevs();
+gHighestDPI = std::max(nDPIX, nDPIY);
+}
+else if (gHighestDPI > nDPIX || gHighestDPI > nDPIY)
+{
+nDPIX = gHighestDPI;
+nDPIY = gHighestDPI;
+}
+}
+
 size_t nPreviewIndex;
-auto xFind = std::find(gRenderedFontNames.begin(), 
gRenderedFontNames.end(), rFontName);
-bool bPreviewAvailable = xFind != gRenderedFontNames.end();
+auto& rFontNames = getRenderedFontNames();
+auto& rVirtualDevs = getFontPreviewVirDevs();
+auto xFind = std::find(rFontNames.begin(), rFontNames.end(), rFontName);
+bool bPreviewAvailable = xFind != rFontNames.end();
 if (!bPreviewAvailable)
 {
-nPreviewIndex = gRenderedFontNames.size();
-gRenderedFontNames.push_back(rFontName);
+nPreviewIndex = rFontNames.size();
+rFontNames.push_back(rFontName);
 }
 else
-nPreviewIndex = std::distance(gRenderedFontNames.begin(), xFind);
+nPreviewIndex = std::distance(rFontNames.begin(), xFind);
 
 size_t nPage = nPreviewIndex / gPreviewsPerDevice;
 size_t nIndexInPage = nPreviewIndex - (nPage * gPreviewsPerDevice);
@@ -787,15 +827,15 @@ OutputDevice& FontNameBox::CachePreview(size_t nIndex, 
Point* pTopLeft,
 
 if (!bPreviewAvailable)
 {
-if (nPage >= gFontPreviewVirDevs.size())
+if (nPage >= rVirtualDevs.size())
 {
 bool bIsLOK = comphelper::LibreOfficeKit::isActive();
 if (bIsLOK) // allow transparent background in LOK case
-

[Libreoffice-commits] core.git: svtools/source svx/source vcl/jsdialog

2023-10-07 Thread Szymon Kłos (via logerrit)
 svtools/source/control/ctrlbox.cxx |2 +-
 svx/source/tbxctrls/tbcontrl.cxx   |3 ++-
 vcl/jsdialog/enabled.cxx   |5 -
 3 files changed, 7 insertions(+), 3 deletions(-)

New commits:
commit 664a8658f720a7d784d717416170ca3d4b2498ad
Author: Szymon Kłos 
AuthorDate: Tue Aug 8 06:48:10 2023 +0200
Commit: Szymon Kłos 
CommitDate: Sat Oct 7 17:04:56 2023 +0200

jsdialog: enable font name & size combobox

This enables font selector with font rendering in Online

Change-Id: I2b57c0831e84a957374c2b1733f6526ca80ac7bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156242
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Szymon Kłos 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157503
Tested-by: Jenkins

diff --git a/svtools/source/control/ctrlbox.cxx 
b/svtools/source/control/ctrlbox.cxx
index 5c24d36e6607..e5b0883ad87e 100644
--- a/svtools/source/control/ctrlbox.cxx
+++ b/svtools/source/control/ctrlbox.cxx
@@ -510,7 +510,7 @@ static bool IsRunningUnitTest() { return 
getenv("LO_TESTNAME") != nullptr; }
 
 void FontNameBox::EnableWYSIWYG(bool bEnable)
 {
-if (comphelper::LibreOfficeKit::isActive() || IsRunningUnitTest())
+if (IsRunningUnitTest())
 return;
 if (mbWYSIWYG == bEnable)
 return;
diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx
index 9fdb74a73c21..94bfef34f44d 100644
--- a/svx/source/tbxctrls/tbcontrl.cxx
+++ b/svx/source/tbxctrls/tbcontrl.cxx
@@ -42,6 +42,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -1740,7 +1741,7 @@ 
SvxFontNameBox_Base::SvxFontNameBox_Base(std::unique_ptr xWidget
 
 SvxFontNameBox_Impl::SvxFontNameBox_Impl(vcl::Window* pParent, const 
Reference& rFrame,
  SvxFontNameToolBoxControl& rCtrl)
-: InterimItemWindow(pParent, "svx/ui/fontnamebox.ui", "FontNameBox")
+: InterimItemWindow(pParent, "svx/ui/fontnamebox.ui", "FontNameBox", true, 
reinterpret_cast(SfxViewShell::Current()))
 , SvxFontNameBox_Base(m_xBuilder->weld_combo_box("fontnamecombobox"), 
rFrame, rCtrl)
 {
 set_id("fontnamecombobox");
diff --git a/vcl/jsdialog/enabled.cxx b/vcl/jsdialog/enabled.cxx
index db4bd04f9f46..13d45dd06849 100644
--- a/vcl/jsdialog/enabled.cxx
+++ b/vcl/jsdialog/enabled.cxx
@@ -371,7 +371,10 @@ bool isBuilderEnabledForSidebar(std::u16string_view 
rUIFile)
 
 bool isInterimBuilderEnabledForNotebookbar(std::u16string_view rUIFile)
 {
-if (rUIFile == u"modules/scalc/ui/numberbox.ui" || rUIFile == 
u"svx/ui/stylespreview.ui")
+if (rUIFile == u"modules/scalc/ui/numberbox.ui"
+|| rUIFile == u"svx/ui/fontnamebox.ui"
+|| rUIFile == u"svx/ui/fontsizebox.ui"
+|| rUIFile == u"svx/ui/stylespreview.ui")
 {
 return true;
 }


[Libreoffice-bugs] [Bug 156902] FILEOPEN PPTX: graphics not shown (edit mode and presentation mode)

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156902

Regina Henschel  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |rb.hensc...@t-online.de
   |desktop.org |

--- Comment #8 from Regina Henschel  ---
Will do the mentioned "hot fix".

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157568] After deleting the content of a cell by pressing the delete key, Orca still speaks the content.

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157568

Noel Grandin  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157568] After deleting the content of a cell by pressing the delete key, Orca still speaks the content.

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157568

--- Comment #5 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8e886993f32b7db11a99bdecf06451e6de6c3842

tdf#157568 After deleting the content of a cell by pressing the delete..

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 157568] After deleting the content of a cell by pressing the delete key, Orca still speaks the content.

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157568

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:24.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: editeng/source sc/CppunitTest_sc_a11y.mk sc/qa sc/source

2023-10-07 Thread Noel Grandin (via logerrit)
 editeng/source/accessibility/AccessibleStaticTextBase.cxx |   15 +--
 sc/CppunitTest_sc_a11y.mk |1 
 sc/qa/extras/accessibility/basics.cxx |   18 
 sc/source/ui/Accessibility/AccessibleContextBase.cxx  |   56 +-
 sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx  |   10 --
 sc/source/ui/inc/AccessibleContextBase.hxx|   18 +---
 sc/source/ui/inc/AccessibleSpreadsheet.hxx|3 
 7 files changed, 71 insertions(+), 50 deletions(-)

New commits:
commit 8e886993f32b7db11a99bdecf06451e6de6c3842
Author: Noel Grandin 
AuthorDate: Sat Oct 7 11:42:40 2023 +0200
Commit: Noel Grandin 
CommitDate: Sat Oct 7 16:14:54 2023 +0200

tdf#157568 After deleting the content of a cell by pressing the delete..

.. key, Orca still speaks the content.

this reverts
commit f22cb3dfab413a2917cd810b8e1b8f644a016327
Author: Noel Grandin 
Date:   Mon Jun 12 20:02:19 2023 +0200
tdf#155376 weakly cache ScAccessibleCell

which was a nice idea, but means that we would need to have
some way of updating the ScAccessibleCell when the associated
cell data changes. Which is likely to be complicated.

So return to creating new ScAccessibleCell objects all the time,
but fix them to not leak.

Change-Id: Ie17ee5c950c9809d4c7281f93761584f75256121
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157673
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/editeng/source/accessibility/AccessibleStaticTextBase.cxx 
b/editeng/source/accessibility/AccessibleStaticTextBase.cxx
index 954117189798..85082bc4cb21 100644
--- a/editeng/source/accessibility/AccessibleStaticTextBase.cxx
+++ b/editeng/source/accessibility/AccessibleStaticTextBase.cxx
@@ -121,8 +121,7 @@ namespace accessibility
 
 void SetEventSource( const uno::Reference< XAccessible >& rInterface )
 {
-
-mxThis = rInterface;
+mpThis = rInterface.get();
 }
 
 void SetOffset( const Point& );
@@ -163,8 +162,8 @@ namespace accessibility
 
 // our frontend class (the one implementing the actual
 // interface). That's not necessarily the one containing the impl
-// pointer
-uno::Reference< XAccessible > mxThis;
+// pointer. Note that this is not an uno::Reference to prevent 
ref-counting cycles and leaks.
+XAccessible* mpThis;
 
 // implements our functionality, we're just an adapter (guarded by 
solar mutex)
 mutable rtl::Reference mxTextParagraph;
@@ -207,7 +206,7 @@ namespace accessibility
 mxTextParagraph->Dispose();
 
 // drop references
-mxThis = nullptr;
+mpThis = nullptr;
 mxTextParagraph.clear();
 }
 
@@ -215,7 +214,7 @@ namespace accessibility
 {
 
 if( !mxTextParagraph.is() )
-throw lang::DisposedException ("object has been already disposed", 
mxThis );
+throw lang::DisposedException ("object has been already disposed", 
mpThis );
 
 // TODO: Have a different method on AccessibleEditableTextPara
 // that does not care about state changes
@@ -273,7 +272,7 @@ namespace accessibility
 
 if( nFlatIndex < 0 )
 throw 
lang::IndexOutOfBoundsException("AccessibleStaticTextBase_Impl::Index2Internal: 
character index out of bounds",
-  mxThis);
+  mpThis);
 // gratuitously accepting larger indices here, 
AccessibleEditableTextPara will throw eventually
 
 sal_Int32 nCurrPara, nCurrIndex, nParas, nCurrCount;
@@ -305,7 +304,7 @@ namespace accessibility
 
 // not found? Out of bounds
 throw 
lang::IndexOutOfBoundsException("AccessibleStaticTextBase_Impl::Index2Internal: 
character index out of bounds",
-  mxThis);
+  mpThis);
 }
 
 bool AccessibleStaticTextBase_Impl::SetSelection( sal_Int32 nStartPara, 
sal_Int32 nStartIndex,
diff --git a/sc/CppunitTest_sc_a11y.mk b/sc/CppunitTest_sc_a11y.mk
index e013beb987cc..3418f2fd4c44 100644
--- a/sc/CppunitTest_sc_a11y.mk
+++ b/sc/CppunitTest_sc_a11y.mk
@@ -16,6 +16,7 @@ $(eval $(call gb_CppunitTest_add_exception_objects,sc_a11y, \
 $(eval $(call gb_CppunitTest_use_libraries,sc_a11y, \
sal \
cppu \
+   cppuhelper \
subsequenttest \
test \
tl \
diff --git a/sc/qa/extras/accessibility/basics.cxx 
b/sc/qa/extras/accessibility/basics.cxx
index 8e04c87dacda..06cce36ded49 100644
--- a/sc/qa/extras/accessibility/basics.cxx
+++ b/sc/qa/extras/accessibility/basics.cxx
@@ -108,5 +108,23 @@ CPPUNIT_TEST_FIXTURE(test::AccessibleTestBase, 
Test64BitChildIndices)
 CPPUNIT_ASSERT_EQUAL(nCol, xTable->getAccessibleColumn(nChildIndex));
 }
 

[Libreoffice-bugs] [Bug 157650] Unhelpful (almost to the point of being useless) error when XML in content.xml is malformed

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157650

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #3 from m.a.riosv  ---
Created attachment 190082
  --> https://bugs.documentfoundation.org/attachment.cgi?id=190082=edit
Screnshoot with the message v 24.02

For me, it shows the number line/row.
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9eb419b0b0f019f5fbc48ff1a11977e8b041edee
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Jumbo

There is the ODF validator, that shows a bit more information.
https://odfvalidator.org/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 155195] FILEOPEN File on SMB share cannot be opened via file dialog of KDE

2023-10-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155195

--- Comment #6 from Ettore Atalan  ---
(In reply to Michael Weghorn from comment #5)
> Can you please try 7.6.2 from the LibreOffice website?
> https://wiki.documentfoundation.org/Installing_in_parallel/Linux has
> instructions on how to use that in parallel to a distro-provided version and
> this would also help identify whether it may be related to your distro
> packages.

What has changed in LibreOffice version 7.6.2 compared to version 7.6.1 in
dealing with SMB shares?

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   >