[Bug 135983] Image gone after DOCX export (image frame anchored to Frame in Interactive frame)
https://bugs.documentfoundation.org/show_bug.cgi?id=135983 Gabor Kelemen (allotropia) changed: What|Removed |Added Blocks||120466 --- Comment #8 from Gabor Kelemen (allotropia) --- Difficult to say how to handle this. For simple shapes the anchoring is moved to character, meaning the shape is not lost, but positioned outside (and incorrectly compared to the original setting) of the frame. Another option would be anchoring inside the textbox as character, this kinda works for the usual caption objects, but for frame-in-frame objects, the outer one seems to overlap the inner one (I think I saw some docx export bug about this already). Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=120466 [Bug 120466] [META] DOCX (OOXML) anchor and text wrapping bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 120466] [META] DOCX (OOXML) anchor and text wrapping bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=120466 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on||135983 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135983 [Bug 135983] Image gone after DOCX export (image frame anchored to Frame in Interactive frame) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 121508] FILESAVE ODT->DOC(X) Shape in frame is lost after export
https://bugs.documentfoundation.org/show_bug.cgi?id=121508 Stéphane Guillou (stragu) changed: What|Removed |Added Summary|FILESAVE ODT->DOCX Shape in |FILESAVE ODT->DOC(X) Shape |frame is lost after export |in frame is lost after ||export -- You are receiving this mail because: You are the assignee for the bug.
[Bug 121508] FILESAVE ODT->DOCX Shape in frame is lost after export
https://bugs.documentfoundation.org/show_bug.cgi?id=121508 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||5983 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 40540] FILESAVE Losing shapes inside frame while saving to .DOC (MSO2003) (vector grafics)
https://bugs.documentfoundation.org/show_bug.cgi?id=40540 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||5983 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 104461] [META] DOCX (OOXML) frame-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104461 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||135983 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135983 [Bug 135983] Image gone after DOCX export (image frame anchored to Frame in Interactive frame) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 135983] Image gone after DOCX export (image frame anchored to Frame in Interactive frame)
https://bugs.documentfoundation.org/show_bug.cgi?id=135983 Stéphane Guillou (stragu) changed: What|Removed |Added Status|RESOLVED|NEW Blocks||104461 See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||1508, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=40 ||540 Summary|Image gone after DOC/DOCX |Image gone after DOCX |export (image frame |export (image frame |anchored to Frame in|anchored to Frame in |Interactive frame) |Interactive frame) CC||stephane.guillou@libreoffic ||e.org Keywords||filter:docx Resolution|DUPLICATE |--- --- Comment #7 from Stéphane Guillou (stragu) --- As mentioned in bug 121508 comment 9, this issue is distinct: Telesto's example document has a picture anchored to paragraph inside a frame, which is itself anchored to a paragraph inside another frame. Setting back to New, but as Gabor said in bug 121508 comment 9, we might need to phase out this babushka doll feature because of the interoperability issues it creates... Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104461 [Bug 104461] [META] DOCX (OOXML) frame-related issues -- You are receiving this mail because: You are the assignee for the bug.
[Bug 104461] [META] DOCX (OOXML) frame-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104461 Bug 104461 depends on bug 135983, which changed state. Bug 135983 Summary: Image gone after DOCX export (image frame anchored to Frame in Interactive frame) https://bugs.documentfoundation.org/show_bug.cgi?id=135983 What|Removed |Added Status|RESOLVED|NEW Resolution|DUPLICATE |--- -- You are receiving this mail because: You are the assignee for the bug.
[Bug 104461] [META] DOCX (OOXML) frame-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104461 Bug 104461 depends on bug 121508, which changed state. Bug 121508 Summary: FILESAVE ODT->DOCX Shape in frame is lost after export https://bugs.documentfoundation.org/show_bug.cgi?id=121508 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Bug 40540] FILESAVE Losing shapes inside frame while saving to .DOC (MSO2003) (vector grafics)
https://bugs.documentfoundation.org/show_bug.cgi?id=40540 --- Comment #37 from Gabor Kelemen (allotropia) --- *** Bug 121508 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 121508] FILESAVE ODT->DOCX Shape in frame is lost after export
https://bugs.documentfoundation.org/show_bug.cgi?id=121508 Gabor Kelemen (allotropia) changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEEDINFO|RESOLVED --- Comment #10 from Gabor Kelemen (allotropia) --- (In reply to Stéphane Guillou (stragu) from comment #9) > Like Justin, I can reproduce with the steps and document in bug 135983, but > that's different: it's an object anchored inside a frame, which is itself > anchored inside another frame. Yes and this should be overall phased out from the UI, since it's sooo un-interoperable :(. > So I'd vote to mark this as duplicate of bug > 40540, and setting bug 135983 back to new. Agree. For the doc case, saving this attachment is a duplicate, for docx it's a WFM. *** This bug has been marked as a duplicate of bug 40540 *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158827] Cant save cells borders to XLS, XLSX, but ODS all ok.
https://bugs.documentfoundation.org/show_bug.cgi?id=158827 --- Comment #6 from Mike Kaganski --- (In reply to Stanislav from comment #5) > This is not a bug this is a feature )) The sarcasm is unclear. If you save to, say, TXT, you won't expect to see bold, or different fonts, or inserted images. It would only be a bug, if XLS(X) allowed for such information; the creator (MS) didn't provide such an option in the format. It is not a feature, just not a bug. > But field "sheet name" is lost while save to xls. Look at Q33 on sheed #2 Absolutely same. There is *NO* feature in Excel - to insert fields. At all. Hence, no provision in the file format. If there were some way to store it in the format, not storing it would be a bug. But not in this case. -- You are receiving this mail because: You are the assignee for the bug.
core.git: editeng/source linguistic/source
editeng/source/misc/unolingu.cxx |6 +-
linguistic/source/dlistimp.cxx |6 +-
linguistic/source/misc.cxx |6 +-
3 files changed, 15 insertions(+), 3 deletions(-)
New commits:
commit 0de274e62c0b7154222178de234c504dc916ede4
Author: Mike Kaganski
AuthorDate: Fri Dec 22 13:29:01 2023 +0300
Commit: Mike Kaganski
CommitDate: Fri Dec 22 13:28:01 2023 +0100
Lok: make Ignore All list name independent on UI language
Fixes not working "Ignore All" context menu entry in e.g. German UI
in Online.
Change-Id: I761c9f65c89fb5c7e929ea20f2db4eff20f7d53d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161170
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/editeng/source/misc/unolingu.cxx b/editeng/source/misc/unolingu.cxx
index 1e7b69a25f27..bd1fae50654e 100644
--- a/editeng/source/misc/unolingu.cxx
+++ b/editeng/source/misc/unolingu.cxx
@@ -29,6 +29,7 @@
#include
#include
+#include
#include
#include
#include
@@ -595,7 +596,10 @@ uno::Reference< XDictionary > LinguMgr::GetIgnoreAll()
uno::Reference< XSearchableDictionaryList > xTmpDicList(
GetDictionaryList() );
if (xTmpDicList.is())
{
-std::locale loc(Translate::Create("svt"));
+const LanguageTag tag = comphelper::LibreOfficeKit::isActive()
+? LanguageTag("en-US")
+: SvtSysLocale().GetUILanguageTag();
+std::locale loc(Translate::Create("svt", tag));
xIgnoreAll = xTmpDicList->getDictionaryByName(
Translate::get(STR_DESCRIPTION_IGNOREALLLIST, loc) );
}
diff --git a/linguistic/source/dlistimp.cxx b/linguistic/source/dlistimp.cxx
index 281abce9e11a..ba39271eee0c 100644
--- a/linguistic/source/dlistimp.cxx
+++ b/linguistic/source/dlistimp.cxx
@@ -27,6 +27,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -586,7 +587,10 @@ void DicList::CreateDicList()
// create IgnoreAllList dictionary with empty URL (non persistent)
// and add it to list
-std::locale loc(Translate::Create("svt"));
+const LanguageTag tag = comphelper::LibreOfficeKit::isActive()
+? LanguageTag("en-US")
+: SvtSysLocale().GetUILanguageTag();
+std::locale loc(Translate::Create("svt", tag));
uno::Reference< XDictionary > xIgnAll(
createDictionary( Translate::get(STR_DESCRIPTION_IGNOREALLLIST,
loc), LinguLanguageToLocale( LANGUAGE_NONE ),
DictionaryType_POSITIVE, OUString() ) );
diff --git a/linguistic/source/misc.cxx b/linguistic/source/misc.cxx
index c315ad1270ee..5c50af6f1946 100644
--- a/linguistic/source/misc.cxx
+++ b/linguistic/source/misc.cxx
@@ -34,6 +34,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -690,7 +691,10 @@ uno::Reference< XDictionary > GetIgnoreAllList()
uno::Reference< XSearchableDictionaryList > xDL( GetDictionaryList() );
if (xDL.is())
{
-std::locale loc(Translate::Create("svt"));
+const LanguageTag tag = comphelper::LibreOfficeKit::isActive()
+? LanguageTag("en-US")
+: SvtSysLocale().GetUILanguageTag();
+std::locale loc(Translate::Create("svt", tag));
xRes = xDL->getDictionaryByName(
Translate::get(STR_DESCRIPTION_IGNOREALLLIST, loc) );
}
return xRes;
core.git: sw/source
sw/source/core/access/AccessibilityCheck.cxx | 22 ++
1 file changed, 14 insertions(+), 8 deletions(-)
New commits:
commit 1190623696c5664b13e874e047a96a50ce5bba30
Author: Xisco Fauli
AuthorDate: Fri Dec 22 10:38:52 2023 +0100
Commit: Xisco Fauli
CommitDate: Fri Dec 22 13:25:16 2023 +0100
sw: fix another null deref in a11y check
similar to
author Caolán McNamara 2023-12-21 16:47:18
+
committer Caolán McNamara 2023-12-21
21:15:03 +0100
commit ba712e9a35179c480cdc6f9d600d79040a273d53 (patch)
tree88e237265eb6ce884d2807b4c178a761d4c73956
parent 8cd01e5278b2be25a1186139e431591a85a5080f (diff)
crashreporting: apparent null deref in a11y check
Change-Id: I3fb6a916fcbcce4b599a925dcc7d39a12e60a972
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161149
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sw/source/core/access/AccessibilityCheck.cxx
b/sw/source/core/access/AccessibilityCheck.cxx
index 9ab27ba788fc..f1ec39b05949 100644
--- a/sw/source/core/access/AccessibilityCheck.cxx
+++ b/sw/source/core/access/AccessibilityCheck.cxx
@@ -132,7 +132,7 @@ class NoTextNodeAltTextCheck : public NodeCheck
sfx::AccessibilityIssueID::LINKED_GRAPHIC);
pIssue->setDoc(pNoTextNode->GetDoc());
pIssue->setIssueObject(IssueObject::LINKED);
-pIssue->setObjectID(pNoTextNode->GetFlyFormat()->GetName());
+pIssue->setObjectID(pFrameFormat->GetName());
pIssue->setNode(pNoTextNode);
pIssue->setAdditionalInfo({ aSystemPath });
}
@@ -161,7 +161,7 @@ class NoTextNodeAltTextCheck : public NodeCheck
sfx::AccessibilityIssueID::NO_ALT_GRAPHIC);
pIssue->setDoc(pNoTextNode->GetDoc());
pIssue->setIssueObject(IssueObject::GRAPHIC);
-pIssue->setObjectID(pNoTextNode->GetFlyFormat()->GetName());
+pIssue->setObjectID(pFrameFormat->GetName());
pIssue->setNode(pNoTextNode);
}
}
@@ -1226,14 +1226,20 @@ public:
return;
// If a node is in fly and if it is not anchored as char, throw
warning.
-const SwNode* startFly = pCurrent->FindFlyStartNode();
-if (startFly
-&& startFly->GetFlyFormat()->GetAnchor().GetAnchorId() !=
RndStdIds::FLY_AS_CHAR)
+const SwNode* pStartFly = pCurrent->FindFlyStartNode();
+if (!pStartFly)
+return;
+
+const SwFrameFormat* pFormat = pStartFly->GetFlyFormat();
+if (!pFormat)
+return;
+
+if (pFormat->GetAnchor().GetAnchorId() != RndStdIds::FLY_AS_CHAR)
{
SwNodeIndex aCurrentIdx(*pCurrent);
-SwNodeIndex aIdx(*startFly);
+SwNodeIndex aIdx(*pStartFly);
SwNode* pFirstTextNode = ();
-SwNodeOffset nEnd = startFly->EndOfSectionIndex();
+SwNodeOffset nEnd = pStartFly->EndOfSectionIndex();
while (aIdx < nEnd)
{
if (pFirstTextNode->IsContentNode() &&
pFirstTextNode->IsTextNode())
@@ -1242,7 +1248,7 @@ public:
{
auto pIssue = lclAddIssue(m_rIssueCollection,
SwResId(STR_FLOATING_TEXT));
pIssue->setIssueObject(IssueObject::TEXTFRAME);
-
pIssue->setObjectID(startFly->GetFlyFormat()->GetName());
+pIssue->setObjectID(pFormat->GetName());
pIssue->setDoc(pCurrent->GetDoc());
pIssue->setNode(pCurrent);
}
[Bug 112994] EDITING Unable to delete hyperlink from hyperlink dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=112994 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org Blocks|120543 | Component|Calc|LibreOffice Version|4.4 all versions|Inherited From OOo OS|Windows (All) |All --- Comment #5 from Stéphane Guillou (stragu) --- Reproduced on Linux, in Calc and Writer, in OOo 3.3 and a recent trunk build: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 0cd74b5be297f638d455b9b267462192f2e6620c CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=120543 [Bug 120543] [META] Bugs and enhancements around hyperlinks in Calc -- You are receiving this mail because: You are the assignee for the bug.
[Bug 120543] [META] Bugs and enhancements around hyperlinks in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=120543 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on|112994 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=112994 [Bug 112994] EDITING Unable to delete hyperlink from hyperlink dialog -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158588] Redesign font embedding options in sfx2/uiconfig/ui/documentfontspage.ui
https://bugs.documentfoundation.org/show_bug.cgi?id=158588 --- Comment #18 from Tomaz Vajngerl --- (In reply to Heiko Tietze from comment #16) > So you save 50MB Noto fonts just in case it might be used later? Quite > unlikely that you share a document with people around the world who want to > edit your document but don't have the proper font installed. The default > should be off. Read again what I wrote. I'm not saying embedded should be default. I'm saying "only used fonts" shouldn't be default, because you don't know if the user will use the unused styles in the future or not. > Why do we need the CTL/CJK/Latin options at all? Embedded should be enough. Because when you know you won't need embedded fonts for other languages you can disable those to be embedded and save you space. This is why I made the example with "Noto Sans", which explicitly show the benefit 31.7MB -> 1.5MB saving. -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-24-2' - cui/source include/svx svx/source
cui/source/dialogs/colorpicker.cxx |7 ---
include/svx/PaletteManager.hxx |2 +-
svx/source/tbxctrls/PaletteManager.cxx | 11 ++-
3 files changed, 11 insertions(+), 9 deletions(-)
New commits:
commit 2d02bb6c792350b7bc07b029f835bd0223402079
Author: Noel Grandin
AuthorDate: Wed Dec 20 11:21:27 2023 +0200
Commit: Xisco Fauli
CommitDate: Fri Dec 22 13:14:26 2023 +0100
tdf#156820 Fix crash in custom color picker
which requires
(*) keeping ColorPicker alive during the runAsync in
ColorPicker::startExecuteModal
(*) keeping the PaletteManager alive during the ExecuteAsync in
PaletteManager::PopupCOlorPicker
Noting that MattK debugged the cause of this.
Change-Id: I07efe8e6514f8882b1347c79c6150578c234bb9d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161054
Tested-by: Noel Grandin
Reviewed-by: Noel Grandin
(cherry picked from commit 78ccae0d42d168f845ddbd7cb694d80dfb04f84d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161161
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/cui/source/dialogs/colorpicker.cxx
b/cui/source/dialogs/colorpicker.cxx
index 87f50b534c26..71b0d0970fc3 100644
--- a/cui/source/dialogs/colorpicker.cxx
+++ b/cui/source/dialogs/colorpicker.cxx
@@ -1345,12 +1345,13 @@ void SAL_CALL ColorPicker::setDialogTitle( const
OUString& )
void SAL_CALL ColorPicker::startExecuteModal( const css::uno::Reference<
css::ui::dialogs::XDialogClosedListener >& xListener )
{
std::shared_ptr xDlg =
std::make_shared(Application::GetFrameWeld(mxParent),
mnColor, mnMode);
-weld::DialogController::runAsync(xDlg, [this, xDlg, xListener] (sal_Int32
nResult) {
+rtl::Reference xThis(this);
+weld::DialogController::runAsync(xDlg, [xThis, xDlg, xListener] (sal_Int32
nResult) {
if (nResult)
-mnColor = xDlg->GetColor();
+xThis->mnColor = xDlg->GetColor();
sal_Int16 nRet = static_cast(nResult);
-css::ui::dialogs::DialogClosedEvent aEvent( *this, nRet );
+css::ui::dialogs::DialogClosedEvent aEvent( *xThis, nRet );
xListener->dialogClosed( aEvent );
});
}
diff --git a/include/svx/PaletteManager.hxx b/include/svx/PaletteManager.hxx
index f2711b2e022a..81f30ea7de76 100644
--- a/include/svx/PaletteManager.hxx
+++ b/include/svx/PaletteManager.hxx
@@ -33,7 +33,7 @@ namespace svx { class ToolboxButtonColorUpdaterBase; }
namespace weld { class Window; }
namespace model { class ColorSet; }
-class SVXCORE_DLLPUBLIC PaletteManager
+class SVXCORE_DLLPUBLIC PaletteManager : public
std::enable_shared_from_this
{
const sal_uInt16mnMaxRecentColors;
diff --git a/svx/source/tbxctrls/PaletteManager.cxx
b/svx/source/tbxctrls/PaletteManager.cxx
index 234002006a5e..a98149ff30bb 100644
--- a/svx/source/tbxctrls/PaletteManager.cxx
+++ b/svx/source/tbxctrls/PaletteManager.cxx
@@ -405,15 +405,16 @@ void PaletteManager::PopupColorPicker(weld::Window*
pParent, const OUString& aCo
m_pColorDlg = std::make_unique();
m_pColorDlg->SetColor(rInitialColor);
m_pColorDlg->SetMode(svtools::ColorPickerMode::Modify);
-m_pColorDlg->ExecuteAsync(pParent, [this, aCommandCopy] (sal_Int32
nResult) {
+std::shared_ptr xSelf(shared_from_this());
+m_pColorDlg->ExecuteAsync(pParent, [xSelf, aCommandCopy] (sal_Int32
nResult) {
if (nResult == RET_OK)
{
-Color aLastColor = m_pColorDlg->GetColor();
+Color aLastColor = xSelf->m_pColorDlg->GetColor();
OUString sColorName = "#" +
aLastColor.AsRGBHexString().toAsciiUpperCase();
NamedColor aNamedColor(aLastColor, sColorName);
-SetSplitButtonColor(aNamedColor);
-AddRecentColor(aLastColor, sColorName);
-maColorSelectFunction(aCommandCopy, aNamedColor);
+xSelf->SetSplitButtonColor(aNamedColor);
+xSelf->AddRecentColor(aLastColor, sColorName);
+xSelf->maColorSelectFunction(aCommandCopy, aNamedColor);
}
});
}
[Bug 158827] Cant save cells borders to XLS, XLSX, but ODS all ok.
https://bugs.documentfoundation.org/show_bug.cgi?id=158827 --- Comment #5 from Stanislav --- Thank you! You are right. This is not a bug this is a feature )) But field "sheet name" is lost while save to xls. Look at Q33 on sheed #2 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155445] Wrong XHTML Footnotes/Endnotes IDs
https://bugs.documentfoundation.org/show_bug.cgi?id=155445 Julien Nabet changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #10 from Julien Nabet --- On pc Debian x86-64 with master sources updated today or with LO Debian testing package 7.6.4.1, I don't reproduce this. I got: 43 44 First1 45 46 47 Second2 48 49 50 Third3 51 52 11. Footnote 53 54 22. Footnote 55 56 33. Footnote 57 Could you give a try to LO 7.6.4 by using LO ppa? (see https://launchpad.net/~libreoffice/+archive/ubuntu/ppa) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158356] FORMATTING: cell format "Status" from xlsx are not transferred correctly to Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=158356 Buovjaga changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
dev-tools.git: help3/xhpeditor
help3/xhpeditor/snippets.js |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit bdfc82012f5b4d2a55ef94a0a56b688df62e8c3a
Author: Stéphane Guillou
AuthorDate: Fri Dec 22 12:39:33 2023 +0100
Commit: Ilmari Lauhakangas
CommitDate: Fri Dec 22 12:48:22 2023 +0100
Remove duplicate spaces inside tags
Change-Id: I5b0aac5382b337e470b550f451942f12330f276d
Reviewed-on: https://gerrit.libreoffice.org/c/dev-tools/+/161163
Tested-by: Ilmari Lauhakangas
Reviewed-by: Ilmari Lauhakangas
diff --git a/help3/xhpeditor/snippets.js b/help3/xhpeditor/snippets.js
index 207e493c..fd1564b8 100644
--- a/help3/xhpeditor/snippets.js
+++ b/help3/xhpeditor/snippets.js
@@ -19,7 +19,7 @@ function startNewXHPDoc() {
}
}
function docHeading() {
-var a1 = '
';
+var a1 = '
';
var a2 = 'CHANGE ME
';
var a3 = 'CHANGE
ME
';
editor.replaceRange(a1 + a2 + a3 , editor.doc.getCursor());
@@ -134,12 +134,12 @@ function bookmarkBranch() {
}
function bookmarkNoWidget() {
-var a1 = '
';
+var a1 = '
';
editor.replaceRange(a1, editor.doc.getCursor());
}
function bookmarkIndex() {
-var a1 = '
CHANGE ME;CHANGE ME TOO
';
+var a1 = '
CHANGE ME;CHANGE ME TOO
';
editor.replaceRange(a1, editor.doc.getCursor());
}
@@ -181,7 +181,7 @@ function switchXHP(type) {
function switchInline(type) {
var type_string = (type=='sys') ? "MAC | UNIX | WIN" : "WRITER | CALC |
IMPRESS | DRAW | BASE | MATH";
var a1 = '';
-var a2 = 'CHANGE ME';
+var a2 = 'CHANGE ME';
var a3 = 'DEFAULT STUFF';
editor.replaceRange(a1 + a2 + a3, editor.doc.getCursor());
}
[Bug 155445] Wrong XHTML Footnotes/Endnotes IDs
https://bugs.documentfoundation.org/show_bug.cgi?id=155445 JI changed: What|Removed |Added Ever confirmed|1 |0 Resolution|INSUFFICIENTDATA|--- Status|RESOLVED|UNCONFIRMED --- Comment #9 from JI --- a) soffice.bin --version LibreOffice 7.3.7.2 30(Build:2) uname -a Linux ji 5.15.0-91-generic #101-Ubuntu SMP Tue Nov 14 13:30:08 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux lsb_release -r Release: 22.04 b) soffice --convert-to "html:XHTML Writer File:UTF8" footnote.docx show result with: xmllint --format footnote.html First1 Second2 Third3 11. Footnote 22. Footnote 33. Footnote you can see footnote 2 and 3 has the same id, with is wrong. if you convert footnote.odt to xhtml it is fine. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155445] Wrong XHTML Footnotes/Endnotes IDs
https://bugs.documentfoundation.org/show_bug.cgi?id=155445 --- Comment #8 from JI --- Created attachment 191567 --> https://bugs.documentfoundation.org/attachment.cgi?id=191567=edit footnote docx version -- You are receiving this mail because: You are the assignee for the bug.
[Bug 100584] With an RTL sheet, make added sheets RTL as well
https://bugs.documentfoundation.org/show_bug.cgi?id=100584 --- Comment #35 from Commit Notification --- Andreas Heinisch committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/b3e86695022f8db57344f4115ee360072d671838 Revert "tdf#100584 - Arrange sheets in the tab bar depending on the RTL settings" It will be available in 24.2.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-24-2' - svtools/source
svtools/source/control/tabbar.cxx | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
New commits:
commit b3e86695022f8db57344f4115ee360072d671838
Author: Andreas Heinisch
AuthorDate: Thu Dec 21 20:33:20 2023 +0100
Commit: Xisco Fauli
CommitDate: Fri Dec 22 12:30:54 2023 +0100
Revert "tdf#100584 - Arrange sheets in the tab bar depending on the RTL
settings"
This reverts commit be86c8f2432623fdb8ed4f22ca08c35121fd8bec.
Reason for revert: To many regressions.
Change-Id: Id3fb8dc5d4edb84c0008b7834a80887aaa7d9f83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161154
Tested-by: Andreas Heinisch
Reviewed-by: Andreas Heinisch
(cherry picked from commit 3430a2c639a9f714259f9d319515464a653d21ab)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161159
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/svtools/source/control/tabbar.cxx
b/svtools/source/control/tabbar.cxx
index 1690269ba234..f9faa2bbe0dc 100644
--- a/svtools/source/control/tabbar.cxx
+++ b/svtools/source/control/tabbar.cxx
@@ -710,15 +710,10 @@ void TabBar::ImplFormat()
if (!mbFormat)
return;
+sal_uInt16 nItemIndex = 0;
tools::Long x = mnOffX;
-
-const size_t nItemListSize = mpImpl->maItemList.size();
-for (size_t nItemIndex = 0; nItemIndex < nItemListSize; nItemIndex++)
+for (auto & rItem : mpImpl->maItemList)
{
-// tdf#100584 - arrange sheets depending on the RTL settings
-auto& rItem = mbMirrored ? mpImpl->maItemList[nItemListSize -
nItemIndex - 1]
- : mpImpl->maItemList[nItemIndex];
-
// At all non-visible tabs an empty rectangle is set
if ((nItemIndex + 1 < mnFirstPos) || (x > mnLastOffX))
rItem.maRect.SetEmpty();
@@ -746,6 +741,8 @@ void TabBar::ImplFormat()
rItem.maRect.SetLeft(nNewLeft);
}
}
+
+nItemIndex++;
}
mbFormat = false;
[Bug 155445] Wrong XHTML Footnotes/Endnotes IDs
https://bugs.documentfoundation.org/show_bug.cgi?id=155445 --- Comment #7 from JI --- Created attachment 191566 --> https://bugs.documentfoundation.org/attachment.cgi?id=191566=edit footnote odt version -- You are receiving this mail because: You are the assignee for the bug.
[Bug 79787] Normal cell borders are showing dashed/dotted when export to xlsx/xls and reopen in MSO
https://bugs.documentfoundation.org/show_bug.cgi?id=79787 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||8827 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158827] Cant save cells borders to XLS, XLSX, but ODS all ok.
https://bugs.documentfoundation.org/show_bug.cgi?id=158827 Mike Kaganski changed: What|Removed |Added Resolution|--- |NOTABUG See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=79 ||787 Status|UNCONFIRMED |RESOLVED --- Comment #4 from Mike Kaganski --- This is not a bug. The optimal values of width available in Excel formats is chosen. There is no better option for *both* the default (0.75) and 1.75 exist, than Excel's "thin". See: https://opengrok.libreoffice.org/xref/core/sc/qa/unit/data/README.cellborders?r=620 Try opening the ODS in Excel to see that Excel itself is unable to use different thickness, even when it definitely *is* in the file (ODS has it, of course). Try using 2.25 (Thick) and greater thickness, to see that it works, *when* the target file format allows. Use ODS, to make sure you use all the features supported by LibreOffice. If you use external file formats, limit yourself to the features supported by both LibreOffice and MS Office in that file format simultaneously, otherwise there is no way to ensure interoperability. -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-24-2' - sc/CppunitTest_sc_uicalc2.mk sc/qa sc/source
sc/CppunitTest_sc_uicalc2.mk |1
sc/qa/unit/uicalc/uicalc2.cxx | 80 +
sc/source/core/data/table2.cxx | 17
3 files changed, 98 insertions(+)
New commits:
commit 4966d3a344c18d8ef47613fbd6c1b1b1e90eb8f3
Author: Mike Kaganski
AuthorDate: Thu Dec 21 16:57:27 2023 +0300
Commit: Xisco Fauli
CommitDate: Fri Dec 22 12:24:15 2023 +0100
tdf#154044: Also store default column data, when copying to Undo document
And restore from it un Undo.
Change-Id: I3e14b345cff25068d0555c5bceb4d6e97ce7cf76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161127
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
(cherry picked from commit 36b7ae36715cbf47b451e41e47aebe28cf594bd8)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161160
Reviewed-by: Xisco Fauli
diff --git a/sc/CppunitTest_sc_uicalc2.mk b/sc/CppunitTest_sc_uicalc2.mk
index 647d4ec7abed..fbc467622f40 100644
--- a/sc/CppunitTest_sc_uicalc2.mk
+++ b/sc/CppunitTest_sc_uicalc2.mk
@@ -23,6 +23,7 @@ $(eval $(call gb_CppunitTest_use_libraries,sc_uicalc2, \
comphelper \
cppu \
cppuhelper \
+editeng \
i18nlangtag \
sal \
sc \
diff --git a/sc/qa/unit/uicalc/uicalc2.cxx b/sc/qa/unit/uicalc/uicalc2.cxx
index 1eaeb5cac4e3..9be6d83840bb 100644
--- a/sc/qa/unit/uicalc/uicalc2.cxx
+++ b/sc/qa/unit/uicalc/uicalc2.cxx
@@ -8,6 +8,7 @@
*/
#include "../helper/qahelper.hxx"
+#include
#include
#include
#include
@@ -26,8 +27,10 @@
#include
#include
#include
+#include
#include
#include
+#include
#include
using namespace ::com::sun::star;
@@ -1489,6 +1492,83 @@ CPPUNIT_TEST_FIXTURE(ScUiCalcTest2, testTdf156174)
CPPUNIT_ASSERT(!pDBs->empty());
}
+CPPUNIT_TEST_FIXTURE(ScUiCalcTest2, testTdf154044)
+{
+createScDoc();
+ScDocument* pDoc = getScDoc();
+
+auto getBackColor = [pDoc](SCCOL c) {
+const ScPatternAttr* pattern = pDoc->GetPattern(c, 0, 0);
+const SvxBrushItem& brush = pattern->GetItemSet().Get(ATTR_BACKGROUND);
+return brush.GetColor();
+};
+
+CPPUNIT_ASSERT_EQUAL(INITIALCOLCOUNT, pDoc->GetAllocatedColumnsCount(0));
+for (SCCOL i = 0; i <= pDoc->MaxCol(); ++i)
+{
+OString msg = "i=" + OString::number(i);
+CPPUNIT_ASSERT_EQUAL_MESSAGE(msg.getStr(), COL_AUTO, getBackColor(i));
+}
+
+// Set the background color of A1:CV1
+auto aColorArg(
+comphelper::InitPropertySequence({ { "BackgroundColor",
uno::Any(COL_LIGHTBLUE) } }));
+goToCell("A1:CV1");
+dispatchCommand(mxComponent, ".uno:BackgroundColor", aColorArg);
+
+// Partial row range allocates necessary columns
+CPPUNIT_ASSERT_EQUAL(SCCOL(100), pDoc->GetAllocatedColumnsCount(0));
+
+// Check that settings are applied
+for (SCCOL i = 0; i < 100; ++i)
+{
+OString msg = "i=" + OString::number(i);
+CPPUNIT_ASSERT_EQUAL_MESSAGE(msg.getStr(), COL_LIGHTBLUE,
getBackColor(i));
+}
+
+// Undo
+SfxUndoManager* pUndoMgr = pDoc->GetUndoManager();
+CPPUNIT_ASSERT(pUndoMgr);
+pUndoMgr->Undo();
+
+// Check that all the cells have restored the setting
+for (SCCOL i = 0; i < 100; ++i)
+{
+OString msg = "i=" + OString::number(i);
+// Without the fix in place, this would fail with
+// - Expected: rgba[ff00]
+// - Actual : rgba[]
+// - i=1
+CPPUNIT_ASSERT_EQUAL_MESSAGE(msg.getStr(), COL_AUTO, getBackColor(i));
+}
+
+// Also check the whole row selection case - it is handled specially:
columns are not allocated.
+// See commit 3db91487e57277f75d64d95d06d4ddcc29f1c4e0 (set properly
attributes for cells in
+// unallocated Calc columns, 2022-03-04).
+goToCell("A1:" + pDoc->MaxColAsString() + "1");
+dispatchCommand(mxComponent, ".uno:BackgroundColor", aColorArg);
+
+// Check that settings are applied
+for (SCCOL i = 0; i <= pDoc->MaxCol(); ++i)
+{
+OString msg = "i=" + OString::number(i);
+CPPUNIT_ASSERT_EQUAL_MESSAGE(msg.getStr(), COL_LIGHTBLUE,
getBackColor(i));
+}
+
+// Undo
+pUndoMgr->Undo();
+
+// No additional columns have been allocated for whole-row range
+CPPUNIT_ASSERT_EQUAL(SCCOL(100), pDoc->GetAllocatedColumnsCount(0));
+
+// Check that all the cells have restored the setting
+for (SCCOL i = 0; i <= pDoc->MaxCol(); ++i)
+{
+OString msg = "i=" + OString::number(i);
+CPPUNIT_ASSERT_EQUAL_MESSAGE(msg.getStr(), COL_AUTO, getBackColor(i));
+}
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/core/data/table2.cxx b/sc/source/core/data/table2.cxx
index f527bb10f83e..4377bfcf452a 100644
--- a/sc/source/core/data/table2.cxx
+++ b/sc/source/core/data/table2.cxx
@@ -1319,6 +1319,13 @@ void ScTable::CopyToTable(
const bool bToUndoDoc = pDestTab->rDocument.IsUndo();
const bool
[Bug 157961] Sheet tab selection area UI direction flipped based on sheet direction
https://bugs.documentfoundation.org/show_bug.cgi?id=157961 --- Comment #12 from ady --- (In reply to Eyal Rozenberg from comment #11) > (In reply to ady from comment #10) > > (In reply to Eyal Rozenberg from comment #9) > > > > > although I think > > > that people will get used to sheet tabs just following the UI direction, > > > soon enough, > > > > That is not a realistic assumption for some users, IMO. > > I said I was just speculating and I can definitely be wrong. Bug 157784 shows at least one example of what I said several times. I personally would favor worksheet tab location based on UI RTL/LTR, but clearly some not-newbies RTL users prefer the older "jumping" behavior. I also agree with bugs 158768 and 158552 reporting the regression (now reverted) regarding the location of the Row header; it should always cross the Column header near column A, no matter where the side of the screen that would be. But maybe we are only 3 users that were bothered by that regression. Now that Andreas reverted the patch, we are back with the same problems as before regarding RTL. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 Bug 133092 depends on bug 156820, which changed state. Bug 156820 Summary: Crash when changing color with custom colour picker accessed from overflowing toolbar https://bugs.documentfoundation.org/show_bug.cgi?id=156820 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 112974] [META] Toolbar overflow/wrap/chevron button bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112974 Bug 112974 depends on bug 156820, which changed state. Bug 156820 Summary: Crash when changing color with custom colour picker accessed from overflowing toolbar https://bugs.documentfoundation.org/show_bug.cgi?id=156820 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 87064] [META] Color picker dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=87064 Bug 87064 depends on bug 156820, which changed state. Bug 156820 Summary: Crash when changing color with custom colour picker accessed from overflowing toolbar https://bugs.documentfoundation.org/show_bug.cgi?id=156820 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
core.git: cui/source include/svx svx/source
cui/source/dialogs/colorpicker.cxx |7 ---
include/svx/PaletteManager.hxx |2 +-
svx/source/tbxctrls/PaletteManager.cxx | 11 ++-
3 files changed, 11 insertions(+), 9 deletions(-)
New commits:
commit 78ccae0d42d168f845ddbd7cb694d80dfb04f84d
Author: Noel Grandin
AuthorDate: Wed Dec 20 11:21:27 2023 +0200
Commit: Noel Grandin
CommitDate: Fri Dec 22 12:20:27 2023 +0100
tdf#156820 Fix crash in custom color picker
which requires
(*) keeping ColorPicker alive during the runAsync in
ColorPicker::startExecuteModal
(*) keeping the PaletteManager alive during the ExecuteAsync in
PaletteManager::PopupCOlorPicker
Noting that MattK debugged the cause of this.
Change-Id: I07efe8e6514f8882b1347c79c6150578c234bb9d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161054
Tested-by: Noel Grandin
Reviewed-by: Noel Grandin
diff --git a/cui/source/dialogs/colorpicker.cxx
b/cui/source/dialogs/colorpicker.cxx
index 87f50b534c26..71b0d0970fc3 100644
--- a/cui/source/dialogs/colorpicker.cxx
+++ b/cui/source/dialogs/colorpicker.cxx
@@ -1345,12 +1345,13 @@ void SAL_CALL ColorPicker::setDialogTitle( const
OUString& )
void SAL_CALL ColorPicker::startExecuteModal( const css::uno::Reference<
css::ui::dialogs::XDialogClosedListener >& xListener )
{
std::shared_ptr xDlg =
std::make_shared(Application::GetFrameWeld(mxParent),
mnColor, mnMode);
-weld::DialogController::runAsync(xDlg, [this, xDlg, xListener] (sal_Int32
nResult) {
+rtl::Reference xThis(this);
+weld::DialogController::runAsync(xDlg, [xThis, xDlg, xListener] (sal_Int32
nResult) {
if (nResult)
-mnColor = xDlg->GetColor();
+xThis->mnColor = xDlg->GetColor();
sal_Int16 nRet = static_cast(nResult);
-css::ui::dialogs::DialogClosedEvent aEvent( *this, nRet );
+css::ui::dialogs::DialogClosedEvent aEvent( *xThis, nRet );
xListener->dialogClosed( aEvent );
});
}
diff --git a/include/svx/PaletteManager.hxx b/include/svx/PaletteManager.hxx
index f2711b2e022a..81f30ea7de76 100644
--- a/include/svx/PaletteManager.hxx
+++ b/include/svx/PaletteManager.hxx
@@ -33,7 +33,7 @@ namespace svx { class ToolboxButtonColorUpdaterBase; }
namespace weld { class Window; }
namespace model { class ColorSet; }
-class SVXCORE_DLLPUBLIC PaletteManager
+class SVXCORE_DLLPUBLIC PaletteManager : public
std::enable_shared_from_this
{
const sal_uInt16mnMaxRecentColors;
diff --git a/svx/source/tbxctrls/PaletteManager.cxx
b/svx/source/tbxctrls/PaletteManager.cxx
index 234002006a5e..a98149ff30bb 100644
--- a/svx/source/tbxctrls/PaletteManager.cxx
+++ b/svx/source/tbxctrls/PaletteManager.cxx
@@ -405,15 +405,16 @@ void PaletteManager::PopupColorPicker(weld::Window*
pParent, const OUString& aCo
m_pColorDlg = std::make_unique();
m_pColorDlg->SetColor(rInitialColor);
m_pColorDlg->SetMode(svtools::ColorPickerMode::Modify);
-m_pColorDlg->ExecuteAsync(pParent, [this, aCommandCopy] (sal_Int32
nResult) {
+std::shared_ptr xSelf(shared_from_this());
+m_pColorDlg->ExecuteAsync(pParent, [xSelf, aCommandCopy] (sal_Int32
nResult) {
if (nResult == RET_OK)
{
-Color aLastColor = m_pColorDlg->GetColor();
+Color aLastColor = xSelf->m_pColorDlg->GetColor();
OUString sColorName = "#" +
aLastColor.AsRGBHexString().toAsciiUpperCase();
NamedColor aNamedColor(aLastColor, sColorName);
-SetSplitButtonColor(aNamedColor);
-AddRecentColor(aLastColor, sColorName);
-maColorSelectFunction(aCommandCopy, aNamedColor);
+xSelf->SetSplitButtonColor(aNamedColor);
+xSelf->AddRecentColor(aLastColor, sColorName);
+xSelf->maColorSelectFunction(aCommandCopy, aNamedColor);
}
});
}
[Bug 43784] Show infobar when document has broken linked files
https://bugs.documentfoundation.org/show_bug.cgi?id=43784 --- Comment #11 from Stéphane Guillou (stragu) --- See also bug 158831, which requests also showing the information in the Edit Links dialog. Ideally, such a banner will have a button to open the Edit Links dialog directly, which should be the best dialog to go through multiple broken links and fix them. As Yousuf said in comment 5. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158831] Show broken link information in Edit Links dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=158831 Stéphane Guillou (stragu) changed: What|Removed |Added Blocks||112581 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=112581 [Bug 112581] [META] Linked (non-embedded) external files bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 112581] [META] Linked (non-embedded) external files bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112581 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||158831 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158831 [Bug 158831] Show broken link information in Edit Links dialog -- You are receiving this mail because: You are the assignee for the bug.
[Bug 154929] [META] Accessibility Check sidebar deck, Automatic Accessibility Checking
https://bugs.documentfoundation.org/show_bug.cgi?id=154929 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||158114 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158114 [Bug 158114] Make it easier to find (and deal with) broken linked images in Sidebar -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158827] Cant save cells borders to XLS, XLSX, but ODS all ok.
https://bugs.documentfoundation.org/show_bug.cgi?id=158827 --- Comment #3 from Stanislav --- Created attachment 191565 --> https://bugs.documentfoundation.org/attachment.cgi?id=191565=edit ODS files with borders 1. Create file 2. Make a table with cell borders default and 1.75 thicknesses. 3. Save ODS and Save as XLSX or XLS 4. Open XLSX or XLS file and all borders are same default thickest. 5. Open ODS and see that right borders thinkers. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 43784] Show infobar when document has broken linked files
https://bugs.documentfoundation.org/show_bug.cgi?id=43784 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||8831 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 112125] [META] Hyperlink dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112125 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||158831 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158831 [Bug 158831] Show broken link information in Edit Links dialog -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158831] New: Show broken link information in Edit Links dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=158831 Bug ID: 158831 Summary: Show broken link information in Edit Links dialog Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: stephane.guil...@libreoffice.org CC: heiko.tie...@documentfoundation.org Blocks: 112125 Steps: 1. Insert a linked image: Insert > Image > Link > OK/Open > Keep link 2. Move source file on filesystem to different directory (or delete it) 3. Save and reload the file: image not shown 4. Edit > Hyperlinks Result: the dialog does not allow easily finding the broken links. The "Status" column sounds like it would provide this information, but it is about the update method used (automatic or manual). (This could be renamed to "Update method" or something else that clarifies it, but it's a separate issue.) Expected: There should be an extra column, maybe named "Source found" (other suggestions welcome), which would help finding the broken link more easily, to then fix them with "Modify". The table should be sortable to make it easier to go through all broken links. Related to this request to make it easier to fix broken links: - broken links are listed in the Accessibility Check since 24.2, but the solution requested here is supposed to replace that. See commit 0156cba6e34026f8fa0f2912e503378a5ec2208d for bug 158114. - a broken link indicator was added to the Navigator for images in 24.8. See commit 4c2c900970d6484c6a92900213ece5c415e40f2d for bug 158114 as well. - bug 43784 requests a fileopen banner, which should ideally link to the Edit Links dialog with a button. Tested with OOo 3.3 and a recent trunk build at 24.8 alpha0+. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=112125 [Bug 112125] [META] Hyperlink dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155045] [META] RTF Floating table related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=155045 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on|124274 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124274 [Bug 124274] FILEOPEN: RTF: Shapes horizontal alignment incorrect -- You are receiving this mail because: You are the assignee for the bug.
[Bug 112765] [META] RTF (text) table bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112765 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on|124274 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124274 [Bug 124274] FILEOPEN: RTF: Shapes horizontal alignment incorrect -- You are receiving this mail because: You are the assignee for the bug.
[Bug 124274] FILEOPEN: RTF: Shapes horizontal alignment incorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=124274 Gabor Kelemen (allotropia) changed: What|Removed |Added Blocks|112765, 155045 | Summary|FILEOPEN: RTF: Importer BUG |FILEOPEN: RTF: Shapes ||horizontal alignment ||incorrect Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=112765 [Bug 112765] [META] RTF (text) table bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=155045 [Bug 155045] [META] RTF Floating table related issues -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158830] FILEOPEN RTF Table header gets extra bold formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=158830 Gabor Kelemen (allotropia) changed: What|Removed |Added Keywords||bibisected, regression Regression By||Oliver Specht CC||oliver.spe...@cib.de -- You are receiving this mail because: You are the assignee for the bug.
[Bug 113340] [META] RTF (text) paragraph-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=113340 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on||158830 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158830 [Bug 158830] FILEOPEN RTF Table header gets extra bold formatting -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158044] RTF import paragraph style attribute handling wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=158044 Gabor Kelemen (allotropia) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||8830 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158830] New: FILEOPEN RTF Table header gets extra bold formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=158830 Bug ID: 158830 Summary: FILEOPEN RTF Table header gets extra bold formatting Product: LibreOffice Version: 24.2.0.0 alpha0+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kelem...@ubuntu.com Blocks: 113340 Created attachment 191564 --> https://bugs.documentfoundation.org/attachment.cgi?id=191564=edit Minimal example file from Word Attached example file is minimized from attachment 123123 of bug 98321 The table header has Header 4 style with centered text alignment set. In Writer this becomes left alignment. 1. Open attached file -> The grey table headers text is left aligned instead of centered. The paragraph below it has also Header 4 set, and alignment is correct there, outside of table. Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 2eb428a8890dda29fbdc8b639fc1377080fab59f CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: threaded This was good in 7.6, broke with: https://git.libreoffice.org/core/+/fce18155052821756466ea043c638f4ed72f41d6 author Oliver Specht Thu Nov 02 16:34:50 2023 +0100 committer Thorsten BehrensFri Nov 10 22:29:40 2023 +0100 tdf#158044 handling of paragraph attributes in RTF import Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113340 [Bug 113340] [META] RTF (text) paragraph-related issues -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158829] Special characters using ALT and numeric keys do not work anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=158829 Mike Kaganski changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Mike Kaganski --- Please do not confirm your own bugs. Confirmation must be done independently. *** This bug has been marked as a duplicate of bug 158112 *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158112] Sidebar pane shortcuts conflict with Alt+NumPad input (comment 5, comment 9)
https://bugs.documentfoundation.org/show_bug.cgi?id=158112 Mike Kaganski changed: What|Removed |Added CC||fjgar...@senefro.org --- Comment #23 from Mike Kaganski --- *** Bug 158829 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158815] After downloading the latest LibreOffice update, the .msi file wouldn't open to install
https://bugs.documentfoundation.org/show_bug.cgi?id=158815 --- Comment #2 from snoopy198...@gmail.com --- (In reply to m.a.riosv from comment #1) > No issue for me to download and open the msi file on Win11. > > What browser do you use to download. I'm pretty sure I already said Firefox. but yeah, Firefox, and I keep it up to date... Oh, I just realized what the problem was, I have a program that monitors my browser and "Hijacks" anything I try to download. I have been having issues with videos (and other various files) either not finishing or saying it's finished but upon watching I can tell that it either stops abruptly or the video freezes and the audio is muted. (the other files tend to be incomplete or corrupt, tho it was primarily with videos over other files) The program is called XDM (Xtreme Download Manager), and simply turning off the browser monitoring extension and downloading it normally I was successfully able to run it, and it installed completely fine. I can't believe I didn't try that before, thank you for your time, I'm sorry to have taken it. -- You are receiving this mail because: You are the assignee for the bug.
core.git: vcl/commonfuzzer.mk
vcl/commonfuzzer.mk |1 + 1 file changed, 1 insertion(+) New commits: commit 5302adf0f74316db5471a2ba6a8e7a59a5dc Author: Caolán McNamara AuthorDate: Fri Dec 22 10:44:20 2023 + Commit: Caolán McNamara CommitDate: Fri Dec 22 11:45:43 2023 +0100 ofz#65252 Build failure Change-Id: Ifcfe7eb7331246c0f994f95b48ad72135949d40a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161171 Tested-by: Caolán McNamara Reviewed-by: Caolán McNamara diff --git a/vcl/commonfuzzer.mk b/vcl/commonfuzzer.mk index ef3e1d754130..476a68adb0a4 100644 --- a/vcl/commonfuzzer.mk +++ b/vcl/commonfuzzer.mk @@ -44,6 +44,7 @@ fuzzer_externals = \ hunspell \ zlib \ zxcvbn-c \ +argon2 \ fuzzer_statics = \ findsofficepath \
[Bug 158356] FORMATTING: cell format "Status" from xlsx are not transferred correctly to Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=158356 --- Comment #2 from Elisabeth Dapper --- Created attachment 191563 --> https://bugs.documentfoundation.org/attachment.cgi?id=191563=edit File with formatted cells, straight from Excel As requested, a sheet with the formatted fields that has never been saved with Calc. -- You are receiving this mail because: You are the assignee for the bug.
core.git: sc/inc sc/source
sc/inc/global.hxx| 29 +++--
sc/source/ui/inc/docfuncutil.hxx |2 +-
2 files changed, 16 insertions(+), 15 deletions(-)
New commits:
commit 514913074c9c3f503cbbc9b6130d52e055e2ac81
Author: Mike Kaganski
AuthorDate: Fri Dec 22 10:47:23 2023 +0300
Commit: Mike Kaganski
CommitDate: Fri Dec 22 11:28:33 2023 +0100
InsertDeleteFlags should be synchronized with css::sheet::CellFlags
They get casted to each other in sc/source/ui/unoobj/cellsuno.cxx
(see ScCellRangesBase::clearContents, which implements respective
method of css::sheet::XSheetOperation).
Commit 07b0c01857137de7e4bd02375e7c892d622d270e (CWS-TOOLING:
integrate CWS dr66, 2009-03-02) introduced IDF_NOCAPTIONS with
value of 0x0200, which conflicted with css::sheet::CellFlags::FORMATTED
(itself introduced in commit b4100bbf615fd3d1cbae200ae187ccbddf8e44a6
(INTEGRATION: CWS calcuno01 (1.5.284); FILE MERGED, 2005-03-23)).
Make the underlying type of InsertDeleteFlags consistent with the
IDL definition; and make sure to avoid the conflicting values.
Change-Id: Ic348f69a1e58db84ef6203391020f45b331e6967
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161145
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sc/inc/global.hxx b/sc/inc/global.hxx
index e140a7fb6ef0..fe7b8bb407b2 100644
--- a/sc/inc/global.hxx
+++ b/sc/inc/global.hxx
@@ -26,6 +26,7 @@
#include
#include
#include
+#include
#include "scdllapi.h"
#include
#include
@@ -145,21 +146,22 @@ namespace o3tl {
template<> struct typed_flags : is_typed_flags {};
}
-enum class InsertDeleteFlags : sal_uInt16
+enum class InsertDeleteFlags : sal_Int32
{
NONE = 0x,
-VALUE= 0x0001, /// Numeric values (and numeric results if
InsertDeleteFlags::FORMULA is not set).
-DATETIME = 0x0002, /// Dates, times, datetime values.
-STRING = 0x0004, /// Strings (and string results if
InsertDeleteFlags::FORMULA is not set).
-NOTE = 0x0008, /// Cell notes.
-FORMULA = 0x0010, /// Formula cells.
-HARDATTR = 0x0020, /// Hard cell attributes.
-STYLES = 0x0040, /// Cell styles.
-OBJECTS = 0x0080, /// Drawing objects.
-EDITATTR = 0x0100, /// Rich-text attributes.
+VALUE= css::sheet::CellFlags::VALUE, /// 0x0001 Numeric
values (and numeric results if InsertDeleteFlags::FORMULA is not set).
+DATETIME = css::sheet::CellFlags::DATETIME, /// 0x0002 Dates,
times, datetime values.
+STRING = css::sheet::CellFlags::STRING, /// 0x0004 Strings
(and string results if InsertDeleteFlags::FORMULA is not set).
+NOTE = css::sheet::CellFlags::ANNOTATION, /// 0x0008 Cell
notes.
+FORMULA = css::sheet::CellFlags::FORMULA,/// 0x0010 Formula
cells.
+HARDATTR = css::sheet::CellFlags::HARDATTR, /// 0x0020 Hard cell
attributes.
+STYLES = css::sheet::CellFlags::STYLES, /// 0x0040 Cell
styles.
+OBJECTS = css::sheet::CellFlags::OBJECTS,/// 0x0080 Drawing
objects.
+EDITATTR = css::sheet::CellFlags::EDITATTR, /// 0x0100 Rich-text
attributes.
+/// No value yet for css::sheet::CellFlags::FORMATTED (0x0200)
OUTLINE = 0x0800, /// Sheet / outlining (grouping) information
SPARKLINES = 0x4000, /// Sparklines in a cell.
-NOCAPTIONS = 0x0200, /// Internal use only (undo etc.): do not
copy/delete caption objects of cell notes.
+NOCAPTIONS = 0x8000, /// Internal use only (undo etc.): do not
copy/delete caption objects of cell notes.
ADDNOTES = 0x0400, /// Internal use only (copy from clip): do
not delete existing cell contents when pasting notes.
SPECIAL_BOOLEAN = 0x1000,
FORGETCAPTIONS = 0x2000, /// Internal use only (d undo): do not
delete caption objects of cell notes.
@@ -172,10 +174,9 @@ enum class InsertDeleteFlags : sal_uInt16
};
namespace o3tl
{
-template<> struct typed_flags :
is_typed_flags {};
+template<> struct typed_flags :
is_typed_flags {};
}
-// This doesn't work at the moment, perhaps when we have constexpr we can
modify InsertDeleteFlags to make it work.
-//static_assert((InsertDeleteFlags::ATTRIB & InsertDeleteFlags::CONTENTS) ==
InsertDeleteFlags::NONE, "these must match");
+static_assert((InsertDeleteFlags::ATTRIB & InsertDeleteFlags::CONTENTS) ==
InsertDeleteFlags::NONE, "these must match");
enum class ScPasteFunc {
diff --git a/sc/source/ui/inc/docfuncutil.hxx b/sc/source/ui/inc/docfuncutil.hxx
index c0b439d3e9be..2ec5bce703a7 100644
--- a/sc/source/ui/inc/docfuncutil.hxx
+++ b/sc/source/ui/inc/docfuncutil.hxx
@@ -13,7 +13,7 @@
class ScMarkData;
class ScRange;
-enum class InsertDeleteFlags : sal_uInt16;
+enum class InsertDeleteFlags : sal_Int32;
[Bug 158829] Special characters using ALT and numeric keys do not work anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=158829 Fernando changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
core.git: unodevtools/Executable_uno-skeletonmaker.mk unodevtools/source
unodevtools/Executable_uno-skeletonmaker.mk |2 --
unodevtools/source/skeletonmaker/cppcompskeleton.cxx | 10 +-
2 files changed, 5 insertions(+), 7 deletions(-)
New commits:
commit fdc1a42db0423e36bd512c7048a0be1fdd09f611
Author: Stephan Bergmann
AuthorDate: Fri Dec 22 09:51:05 2023 +0100
Commit: Stephan Bergmann
CommitDate: Fri Dec 22 11:17:45 2023 +0100
Don't use boost in code generated by uno-skeletonmaker
This had originally used a non-standard std::hash_map in
db4b02eea5b81b7be05fa8b1f18c9f423302a977 "INTEGRATION: CWS jsc3 (1.4.2);
FILE
MERGED", then switched to boost::unordered_map in
639825975e7657c7b3f4eeef208112780e71e545 "move sdk repo to boost unordered
containters". (And Executable_uno-skeletonmaker doesn't need boost during
the
build at all, so clean that up here, too.)
Change-Id: I80661d70a54ec5d69b8f124c12d5cb0d6f369887
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161147
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/unodevtools/Executable_uno-skeletonmaker.mk
b/unodevtools/Executable_uno-skeletonmaker.mk
index 87f8d3ca9b17..0bee9985434d 100644
--- a/unodevtools/Executable_uno-skeletonmaker.mk
+++ b/unodevtools/Executable_uno-skeletonmaker.mk
@@ -9,8 +9,6 @@
$(eval $(call gb_Executable_Executable,uno-skeletonmaker))
-$(eval $(call gb_Executable_use_external,uno-skeletonmaker,boost_headers))
-
$(eval $(call gb_Executable_set_include,uno-skeletonmaker,\
-I$(SRCDIR)/unodevtools/inc \
$$(INCLUDE) \
diff --git a/unodevtools/source/skeletonmaker/cppcompskeleton.cxx
b/unodevtools/source/skeletonmaker/cppcompskeleton.cxx
index 8fbb96c19452..0942d7cde694 100644
--- a/unodevtools/source/skeletonmaker/cppcompskeleton.cxx
+++ b/unodevtools/source/skeletonmaker/cppcompskeleton.cxx
@@ -689,10 +689,10 @@ static OString generateClassDefinition(std::ostream& o,
"virtual ~" << classname << "() {}
";
if (options.componenttype == 2) {
-o << "typedef boost::unordered_map< ::sal_Int32, OUString, "
-"boost::hash<::sal_Int32> > ParamMap;
"
-"typedef boost::unordered_map< OUString, ParamMap, "
-"OUStringHash > FunctionMap;
"
+o << "typedef std::map< ::sal_Int32, OUString "
+"> ParamMap;
"
+"typedef std::map< OUString, ParamMap "
+"> FunctionMap;
"
"OUString SAL_CALL getAddinProperty(const OUString & "
"funcName, const OUString & paramName, const char * propName) "
"throw (css::uno::RuntimeException);
";
@@ -1146,7 +1146,7 @@ void generateCalcAddin(ProgramOptions const & options,
"#include \"com/sun/star/container/XNameAccess.hpp\"
"
"#include \"com/sun/star/container/XHierarchicalNameAccess.hpp\"
"
"#include \"rtl/ustrbuf.hxx\"
"
-"#include
"
+"#include
"
"#include
";
// namespace
[Bug 158829] New: Special characters using ALT and numeric keys do not work anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=158829 Bug ID: 158829 Summary: Special characters using ALT and numeric keys do not work anymore Product: LibreOffice Version: 7.6.3.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: fjgar...@senefro.org Description: After the latest update (7.6.3.2) I cannot use ALT+numeric keys to write special characters any longer. After pressing ALT + number keys it changes the lateral menu. I know I can use the special characters tool, but it takes a longer time to write them than with the keyboard. In all previous versions it worked fine. Not now. Fernando Actual Results: To restore previous keyboard functions. Expected Results: To restore to the way it was in previous versions. Reproducible: Always User Profile Reset: No Additional Info: Not to mix up ALT key with lateral menu. ALT+numeric keys should be limited to special characters. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158612] Group border properties together in the UI
https://bugs.documentfoundation.org/show_bug.cgi?id=158612 Buovjaga changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Summary|Not able to select |Group border properties |different border thickness |together in the UI Keywords||needsUXEval Component|Calc|UI Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158612] Group border properties together in the UI
https://bugs.documentfoundation.org/show_bug.cgi?id=158612 Buovjaga changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Summary|Not able to select |Group border properties |different border thickness |together in the UI Keywords||needsUXEval Component|Calc|UI Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 158612] Not able to select different border thickness
https://bugs.documentfoundation.org/show_bug.cgi?id=158612 --- Comment #5 from marcu...@gmail.com --- My suggestion would apply to anything. In this case, border type, style, colour, thickness should be grouped together in one place with a drop down menu sort of thing from the 'border' icon (the short cut) & from top menu > Format > Border > Type > top > bottom > etc etc > Style > Single > Double > Thickness > etc > Colour > etc. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 133201] Linked Image: updating changed path does not make the image visible again; object lost after reopen
https://bugs.documentfoundation.org/show_bug.cgi?id=133201 Stéphane Guillou (stragu) changed: What|Removed |Added Keywords||dataLoss Summary|Linked Image: updating |Linked Image: updating |changed path does not make |changed path does not make |the image visible again |the image visible again; ||object lost after reopen Priority|medium |high CC||stephane.guillou@libreoffic ||e.org Version|7.0.0.0.alpha0+ |6.3.6.2 release Severity|normal |major --- Comment #6 from Stéphane Guillou (stragu) --- Commit was also cherrypicked to 6.3.6. Reproduced in recent trunk build: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 29b11fa3b5574dc3f42f55b0716f71054030c6c2 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Upping the importance because it's a dataloss regression, see step 7 here: 1. Insert a image with Insert > Image > Insert As Link, confirm "Keep link" in next dialog 2. Save the file (ODT) 3. Move the linked image file to a different directory 4. Reload file: image frame empty, (as expected) 5. Right-click > Properties > Rotation tab > Link > Browse to the new location of the file > confirm: preview is correct in dialog (as expected) 6. Click OK on dialog: image is not visible in document (broken) 7. Save and reload: image completely gone, nothing in Navigator (broken) I checked that before ddd7277b218204dca539b3f93d36098df0349b38 (which is build commit [ddd7277b218204dca539b3f93d36098df0349b38] in linux-64-6.3 bibisect repo), it works as expected with the same steps. Gülşah, can you please have another look? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 81234] [META] RTF filter issues
https://bugs.documentfoundation.org/show_bug.cgi?id=81234 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on||158808 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158808 [Bug 158808] Fileopen: DOCX checkbox color is missing -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158808] Fileopen: DOCX checkbox color is missing
https://bugs.documentfoundation.org/show_bug.cgi?id=158808 Gabor Kelemen (allotropia) changed: What|Removed |Added Version|5.2.0.4 release |Inherited From OOo Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC||kelem...@ubuntu.com Blocks||81234 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=81234 [Bug 81234] [META] RTF filter issues -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158808] Fileopen: DOCX checkbox color is missing
https://bugs.documentfoundation.org/show_bug.cgi?id=158808 --- Comment #1 from Gabor Kelemen (allotropia) --- Created attachment 191562 --> https://bugs.documentfoundation.org/attachment.cgi?id=191562=edit The example file in Word and current master Confirming in Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 2eb428a8890dda29fbdc8b639fc1377080fab59f CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: threaded Looks like a missing feature since forever, I can't set this coloring up on the UI. -- You are receiving this mail because: You are the assignee for the bug.
Re: [libreoffice-design] Re: Minutes from the UX/design meeting 2023-Dec-20
Hi all On 22/12/2023 10:15, Eyal Rozenberg wrote: The font embedding is an example of a deeper issue: If LibreOffice is a 'native' ODT editor; and if you open an ODT in it; and if you don't effect any changes in that ODT, but just save; is it legitimate for the resulting ODT to be in any way different than the original (other than meta-data regarding modification date etc.) ? I think it might be legitimate in various cases. One example I can think of is how fileopen checks on a few things depending on what the user has or doesn't have, notably linked files and images. I think there's some similarity: fonts might get embedded if the file properties ask to do it, depending on the font's availability on the system it is opened on. Do you think there should be feedback to the user when such a thing happens? (e.g. a message saying "Font XYZ found, embedding it into the file. See File > Properties > Fonts to change that option."). And why would you save the file in the first place, if you haven't changed anything? Sorry if I'm missing the point :) On 22/12/2023 9:11, Heiko Tietze wrote: On 21.12.23 20:05, Eyal Rozenberg wrote: "LibreOffice unexpectedly and strangely modifies an ODT file without they user having done anything, and embedding unnecessary fonts nobody asked it to." Sounds like another facet of the font embedding. I would treat bug 158588 about what fonts are embedded (CTL/CJK/Lat and used) and handle the situation of shared documents on another. I haven't tested what happens when one checks the embed fonts option and shares this document with another person. Assuming her fonts would also be included, silently, this is at least a privacy issue. Just curious, what concrete privacy concerns do you see here? But maybe the "notification" I suggested above would be enough to make the change transparent and the user aware. Cheers -- Stéphane Guillou Quality Assurance Analyst | The Document Foundation Email: stephane.guil...@libreoffice.org Matrix: @stragu:matrix.org Fediverse: @str...@mastodon.indie.host Web: https://stragu.gitlab.io/
[Bug 158588] Redesign font embedding options in sfx2/uiconfig/ui/documentfontspage.ui
https://bugs.documentfoundation.org/show_bug.cgi?id=158588 --- Comment #17 from Eyal Rozenberg --- (In reply to Heiko Tietze from comment #16) > (In reply to Eyal Rozenberg from comment #12) > > the Save/Save As... dialog didn't ask me whether I wanted to embed fonts. > I suggest to discuss the consequences of shared documents in an extra ticket. I'm not sure what you mean by shared documents, I was talking about plain ODT documents like the ones we have in the attachment. But perhaps I'm misunderstanding. (In reply to Tomaz Vajngerl from comment #14) > (In reply to Eyal Rozenberg from comment #12) > > First, I don't see why it's legitimate, that an editor whose native format > > is ODT would make changes to an opened ODT which is saved with no user > > actions. The input ODT is just fine as an output ODT. > > No idea what you're trying to say here. Let me try to clarify with an example. Suppose you had a text editor, which, for some text files, when opening them, then saving them without any keypress or editing action - would change the text in the saved file relative to the original. Wouldn't that be a rather weird thing? The user does not expect something like this to happen. The same (one can argue) goes for the native editor of any format: It can de-serialize it from a file, then re-serialize to the exact same document. And this would be unlike importing from a "foreign" format like DOCX, where, when saving to a DOCX, you can expect some changes due to the conversion. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157961] Sheet tab selection area UI direction flipped based on sheet direction
https://bugs.documentfoundation.org/show_bug.cgi?id=157961 --- Comment #11 from Eyal Rozenberg --- (In reply to ady from comment #10) > (In reply to Eyal Rozenberg from comment #9) > > > although I think > > that people will get used to sheet tabs just following the UI direction, > > soon enough, > > That is not a realistic assumption for some users, IMO. I said I was just speculating and I can definitely be wrong. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158827] Cant save cells borders to XLS, XLSX, but ODS all ok.
https://bugs.documentfoundation.org/show_bug.cgi?id=158827 --- Comment #2 from Mike Kaganski --- What steps specifically don't work? E.g., setting some cell borders to thick, and some to thin definitely works with XLSX in Version: 7.6.4.1 (X86_64) / LibreOffice Community Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1 CPU threads: 24; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: ru-RU (en_US); UI: en-US Calc: CL threaded So please describe specific steps, or maybe just attach a sample ODS, which can't be saved to XLSX without formatting loss, and describe which cell looses what. Note that Excel formats are limited in what border formatting they can store. E.g., border thickness is represented there as a limited set of values, defined in OOXML's ST_BorderStyle (valid values are only 'dashDot', 'dashDotDot', 'dashed', 'dotted', 'double', 'hair', 'medium', 'mediumDashDot', 'mediumDashDotDot', 'mediumDashed', 'none', 'slantDashDot', 'thick', 'thin'). You may see that it's not much of freedom to represent different thickness plus different style - which is easy in ODF. So possibly what you expect is simply impossible in the limited XLSX file format. -- You are receiving this mail because: You are the assignee for the bug.
Re: Commit 70ef230 causes GTK4 build to fail
On 2023-12-22 08:48, Michael Weghorn wrote: Does https://gerrit.libreoffice.org/c/core/+/161144 make the build work again for you? I've merged that change to master now, so hopefully a `git pull` makes things work again. (Feedback appreciated.) OpenPGP_signature.asc Description: OpenPGP digital signature
Re: [libreoffice-design] Re: Minutes from the UX/design meeting 2023-Dec-20
The font embedding is an example of a deeper issue: If LibreOffice is a 'native' ODT editor; and if you open an ODT in it; and if you don't effect any changes in that ODT, but just save; is it legitimate for the resulting ODT to be in any way different than the original (other than meta-data regarding modification date etc.) ? On 22/12/2023 9:11, Heiko Tietze wrote: On 21.12.23 20:05, Eyal Rozenberg wrote: "LibreOffice unexpectedly and strangely modifies an ODT file without they user having done anything, and embedding unnecessary fonts nobody asked it to." Sounds like another facet of the font embedding. I would treat bug 158588 about what fonts are embedded (CTL/CJK/Lat and used) and handle the situation of shared documents on another. I haven't tested what happens when one checks the embed fonts option and shares this document with another person. Assuming her fonts would also be included, silently, this is at least a privacy issue.
core.git: vcl/unx
vcl/unx/gtk4/gtkaccessibleeventlistener.cxx |4
vcl/unx/gtk4/gtkaccessibleregistry.cxx |4
2 files changed, 8 insertions(+)
New commits:
commit f557e22a675164a1b9b0286a263a81d634959733
Author: Michael Weghorn
AuthorDate: Fri Dec 22 08:45:26 2023 +0100
Commit: Michael Weghorn
CommitDate: Fri Dec 22 10:14:47 2023 +0100
gtk4 a11y: Fix build for Gtk < 4.9
The code in `vcl/unx/gtk4/a11y.cxx` is
#if GTK_CHECK_VERSION(4, 9, 0)
, so should the code using that be.
Should fix this issue reported in [1]:
> Hi, building on Linux (Debian 12) breaks with the following error:
>
> [LNK] Library/libvclplug_gtk4lo.so
> ld.lld: error: undefined symbol: lo_accessible_new(_GdkDisplay*,
_GtkAccessible*,
com::sun::star::uno::Reference
const&)
> >>> referenced by gtkaccessibleregistry.cxx
> >>>
/home/etna/Tmpdir/libreoffice/build/workdir/CxxObject/vcl/unx/gtk4/gtkaccessibleregistry.o:(GtkAccessibleRegistry::getLOAccessible(com::sun::star::uno::Reference,
_GdkDisplay*, _GtkAccessible*))
> clang-15: error: linker command failed with exit code 1 (use -v to see
invocation)
> make[1]: ***
[/home/etna/Tmpdir/libreoffice/vcl/Library_vclplug_gtk4.mk:20:
/home/etna/Tmpdir/libreoffice/build/instdir/program/libvclplug_gtk4lo.so] Error
1
> make[1]: *** Waiting for unfinished jobs
>
> I was able to get the build to succeed by rolling back commit 70ef230 (
https://github.com/LibreOffice/core/commit/70ef230aae4f961c8197cc11a7ff5feaf1d96c20
)
[1]
https://lists.freedesktop.org/archives/libreoffice/2023-December/091330.html
Change-Id: Ifc359bd8b96af8eaa5427a7949259beb607e105d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161144
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/vcl/unx/gtk4/gtkaccessibleeventlistener.cxx
b/vcl/unx/gtk4/gtkaccessibleeventlistener.cxx
index 256073805e7c..4211340d7ee3 100644
--- a/vcl/unx/gtk4/gtkaccessibleeventlistener.cxx
+++ b/vcl/unx/gtk4/gtkaccessibleeventlistener.cxx
@@ -14,6 +14,8 @@
#include "gtkaccessibleeventlistener.hxx"
#include "gtkaccessibleregistry.hxx"
+#if GTK_CHECK_VERSION(4, 9, 0)
+
GtkAccessibleEventListener::GtkAccessibleEventListener(LoAccessible*
pLoAccessible)
: m_pLoAccessible(pLoAccessible)
{
@@ -65,4 +67,6 @@ void GtkAccessibleEventListener::notifyEvent(
}
}
+#endif
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/unx/gtk4/gtkaccessibleregistry.cxx
b/vcl/unx/gtk4/gtkaccessibleregistry.cxx
index 3f5df43ed40e..e29a86bdb648 100644
--- a/vcl/unx/gtk4/gtkaccessibleregistry.cxx
+++ b/vcl/unx/gtk4/gtkaccessibleregistry.cxx
@@ -12,6 +12,8 @@
#include
+#if GTK_CHECK_VERSION(4, 9, 0)
+
std::map
GtkAccessibleRegistry::m_aMapping = {};
LoAccessible*
@@ -38,4 +40,6 @@ void
GtkAccessibleRegistry::remove(css::uno::Reference
Re: ESC meeting minutes: 2023-12-21
On 2023-12-21 16:51, Colomban Wendling wrote: Le 21/12/2023 à 16:27, Stephan Bergmann a écrit : […] 14 CppunitTest_test_a11y gerrit_windows That doesn't look too good… From a couple failing jobs, I see a weird error that barely seem related: [_RUN_] SelfTestIncorrectDialog::TestBody warn:sfx.appl:16560:16772:sfx2/source/appl/app.cxx:147: No DDE-Service possible. Error: 16399 warn:unotools.misc:16560:16772:unotools/source/misc/mediadescriptor.cxx:372: url: 'private:factory/swriter' com.sun.star.ucb.ContentCreationException message: "No Content Provider available for URL: private:factory/swriter at C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/ucbhelper/source/client/content.cxx:205" eError: (com.sun.star.ucb.ContentCreationError) NO_CONTENT_PROVIDER Any idea of what that can be? I think that that warning should be unrelated to the failing test. At least I see a similar warning locally when just running Writer from a local master build on Linux. Or has this been solved already somehow? Though, it seems flaky, at least from https://gerrit.libreoffice.org/c/core/+/160450 in which it looks like a mere re-trigger "fixed" it. Unfortunately, I don't see anything useful in the backtrace (where the SIGABRT might come from). (It might be an actual issue somewhere in LO source code not even directly related to a11y.) OpenPGP_signature.asc Description: OpenPGP digital signature
core.git: include/svl
include/svl/itemset.hxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit e9e3576ada06d53de12efed041fb309fe5388e01
Author: Xisco Fauli
AuthorDate: Thu Dec 21 22:49:27 2023 +0100
Commit: Xisco Fauli
CommitDate: Fri Dec 22 10:11:29 2023 +0100
svl: fix build with --enable-debug
After
author Armin Le Grand (allotropia)
2023-12-20 19:42:28 +0100
committer Armin Le Grand 2023-12-21 21:13:55
+0100
commit 789a737ac92c4f2b0eb9820b99c43cc8253c8b29 (patch)
treebc167ec04de29e63168844be973f59980fa36ac2
parent 3430a2c639a9f714259f9d319515464a653d21ab (diff)
Remove DeleteItemOnIdlex
it fails with
/home/xisco/libreoffice/include/svl/itemset.hxx: In member function
‘SfxItemPool& SfxPoolItemHolder::getPool() const’:
/home/xisco/libreoffice/include/svl/itemset.hxx:64:44: error: ‘isDeleted’
was not declared in this scope
64 | SfxItemPool& getPool() const { assert(!isDeleted() &&
"Destructed instance used (!)"); return *m_pPool; }
|^
/home/xisco/libreoffice/include/svl/itemset.hxx: In member function ‘const
SfxPoolItem* SfxPoolItemHolder::getItem() const’:
/home/xisco/libreoffice/include/svl/itemset.hxx:65:50: error: ‘isDeleted’
was not declared in this scope
65 | const SfxPoolItem* getItem() const { assert(!isDeleted() &&
"Destructed instance used (!)"); return m_pItem; }
| ^
make[1]: *** [/home/xisco/libreoffice/solenv/gbuild/LinkTarget.mk:340:
/home/xisco/libreoffice/workdir/CxxObject/svl/source/items/itemiter.o] Error 1
make[1]: *** Se espera a que terminen otras tareas
In file included from /usr/include/c++/12/cassert:44,
from
/home/xisco/libreoffice/include/svl/whichranges.hxx:16,
from /home/xisco/libreoffice/include/svl/itemset.hxx:30,
from /home/xisco/libreoffice/svl/source/items/sitem.cxx:23:
/home/xisco/libreoffice/include/svl/itemset.hxx: In member function
‘SfxItemPool& SfxPoolItemHolder::getPool() const’:
/home/xisco/libreoffice/include/svl/itemset.hxx:64:44: error: ‘isDeleted’
was not declared in this scope
64 | SfxItemPool& getPool() const { assert(!isDeleted() &&
"Destructed instance used (!)"); return *m_pPool; }
|^
/home/xisco/libreoffice/include/svl/itemset.hxx: In member function ‘const
SfxPoolItem* SfxPoolItemHolder::getItem() const’:
/home/xisco/libreoffice/include/svl/itemset.hxx:65:50: error: ‘isDeleted’
was not declared in this scope
65 | const SfxPoolItem* getItem() const { assert(!isDeleted() &&
"Destructed instance used (!)"); return m_pItem; }
| ^
make[1]: *** [/home/xisco/libreoffice/solenv/gbuild/LinkTarget.mk:337:
/home/xisco/libreoffice/workdir/CxxObject/svl/source/items/sitem.o] Error 1
In file included from /usr/include/c++/12/cassert:44,
from
/home/xisco/libreoffice/include/svl/whichranges.hxx:16,
from /home/xisco/libreoffice/include/svl/itemset.hxx:30,
from
/home/xisco/libreoffice/svl/source/items/itemset.cxx:30:
/home/xisco/libreoffice/include/svl/itemset.hxx: In member function
‘SfxItemPool& SfxPoolItemHolder::getPool() const’:
/home/xisco/libreoffice/include/svl/itemset.hxx:64:44: error: ‘isDeleted’
was not declared in this scope
64 | SfxItemPool& getPool() const { assert(!isDeleted() &&
"Destructed instance used (!)"); return *m_pPool; }
|^
/home/xisco/libreoffice/include/svl/itemset.hxx: In member function ‘const
SfxPoolItem* SfxPoolItemHolder::getItem() const’:
/home/xisco/libreoffice/include/svl/itemset.hxx:65:50: error: ‘isDeleted’
was not declared in this scope
65 | const SfxPoolItem* getItem() const { assert(!isDeleted() &&
"Destructed instance used (!)"); return m_pItem; }
| ^
In file included from /usr/include/c++/12/cassert:44,
from
/home/xisco/libreoffice/include/o3tl/sorted_vector.hxx:15,
from /home/xisco/libreoffice/include/svl/itempool.hxx:30,
from
/home/xisco/libreoffice/svl/source/items/itemset.cxx:31:
/home/xisco/libreoffice/svl/source/items/itemset.cxx: In member function
‘const SfxPoolItemHolder& SfxPoolItemHolder::operator=(const
SfxPoolItemHolder&)’:
/home/xisco/libreoffice/svl/source/items/itemset.cxx:120:13: error:
‘isDeleted’ was not declared in this scope
120 | assert(!isDeleted() && "Destructed instance used (!)");
| ^
core.git: Branch 'libreoffice-7-6' - include/sfx2 sfx2/source sw/inc sw/qa sw/source
include/sfx2/viewsh.hxx |4
sfx2/source/view/viewfrm.cxx |3 +++
sw/inc/view.hxx |9 ++---
sw/qa/uibase/uiview/uiview.cxx | 19 +++
sw/source/uibase/uiview/view.cxx |8 +++-
5 files changed, 39 insertions(+), 4 deletions(-)
New commits:
commit 1f4e1b84722c4387f65614ad7f1765dcddb8aeb9
Author: Miklos Vajna
AuthorDate: Mon Dec 18 17:21:15 2023 +0100
Commit: Xisco Fauli
CommitDate: Fri Dec 22 10:10:26 2023 +0100
tdf#158686 sw floattable: fix print preview crash
Regression from commit b8521d969ab5be4fc947e467d4afe969f9d3b563
(tdf#157263 sw floattable: prefer join over split after moving fwd,
2023-09-25), enabling Options -> Writer -> Formatting Aids -> Hidden
Characters, then opening the bugdoc, finally Toggle Print Preview on the
toolbar resulted in a crash.
We have a memory corruption here:
==11968==ERROR: AddressSanitizer: heap-use-after-free on address
0x60f734e0 at pc 0x7f473822d2ee bp 0x7fffdadd3660 sp 0x7fffdadd3658
READ of size 8 at 0x60f734e0 thread T0
#0 0x7f473822d2ed in rtl::Reference::operator->()
const /include/rtl/ref.hxx:216:9
#1 0x7f473821feeb in FmFormShell::IsActiveControl() const
/svx/source/form/fmshell.cxx:1227:12
#2 0x7f46dad4d52a in SwView::SelectShell()
/sw/source/uibase/uiview/view.cxx:296:40
#3 0x7f46dad496a6 in SwView::AttrChangedNotify(LinkParamNone*)
/sw/source/uibase/uiview/view.cxx:572:13
...
#32 0x7f4748944cda in
SfxViewFrame::SwitchToViewShell_Impl(unsigned short, bool)
/sfx2/source/view/viewfrm.cxx:2552:32
#33 0x7f47488f4e3b in SfxViewFrame::ExecView_Impl(SfxRequest&)
/sfx2/source/view/viewfrm.cxx:2637:29
freed by thread T0 here:
#0 0x5568ff2f9a7b in operator delete(void*, unsigned long)
/home/abuild/rpmbuild/BUILD/llvm-15.0.7.src/build/../projects/compiler-rt/lib/asan/asan_new_delete.cpp:164:3
#1 0x7f4738214346 in FmFormShell::~FmFormShell()
/svx/source/form/fmshell.cxx:181:1
#2 0x7f4746b04b9d in SfxDispatcher::FlushImpl()
/sfx2/source/control/dispatch.cxx:1412:13
#3 0x7f4746aff767 in SfxDispatcher::Flush()
/sfx2/source/control/dispatch.cxx:157:26
#4 0x7f47489100dc in
SfxViewFrame::PopShellAndSubShells_Impl(SfxViewShell&)
/sfx2/source/view/viewfrm.cxx:1100:24
#5 0x7f47489441a3 in
SfxViewFrame::SwitchToViewShell_Impl(unsigned short, bool)
/sfx2/source/view/viewfrm.cxx:2538:13
#6 0x7f47488f4e3b in SfxViewFrame::ExecView_Impl(SfxRequest&)
/sfx2/source/view/viewfrm.cxx:2637:29
I.e. a new SwPagePreview replaces the old SwView, but the order is that
SfxViewFrame::SwitchToViewShell_Impl() starts with deleting the
SfxShells of the old SwView in PopShellAndSubShells_Impl(), then it
creates the new shell, finally deletes the old shell. Given that the new
shell hides hidden characters and the old shell did not, this triggers a
size notification for the half-deleted old shell and we crash.
Seeing that SwView::AttrChangedNotify() already had code to delay the
selection of an SfxShell in the old SwView, fix the problem by
introducing a new flag that allows not selecting an SfxShell at all if
the old view is known to be deleted in the near future anyway.
An alternative would be to make sure that all relevant pointers are
maintained using an SfxBroadcaster / SfxListener protocol, but after
fixing some 4 of them and that's still not enough, probably it's better
to handle this at a higher level. It's also a bit unclear how this
"worked" in the past; looks like the old view didn't get the size change
notification by accident.
Change-Id: I423ff946f8235848cc3a870bc52fcf88a721fd2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160925
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
(cherry picked from commit 164fb25f7b2db7d833d6d0f28e49c5cac68426b3)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160935
Signed-off-by: Xisco Fauli
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160972
diff --git a/include/sfx2/viewsh.hxx b/include/sfx2/viewsh.hxx
index b805f1cf99d4..f6cbc16f5268 100644
--- a/include/sfx2/viewsh.hxx
+++ b/include/sfx2/viewsh.hxx
@@ -226,6 +226,10 @@ public:
SfxViewShell( SfxViewFrame& rFrame,
SfxViewShellFlags nFlags );
virtual ~SfxViewShell() override;
+/// Informs the view shell that it'll be deleted before the main loop
processes the next user
+/// input.
+virtual void SetDying() {}
+
SfxInPlaceClient* GetIPClient() const;
SfxInPlaceClient* GetUIActiveClient() const;
SfxInPlaceClient* FindIPClient( const css::uno::Reference <
[Bug 123983] Read Error if embedded images are not into the Pictures directory
https://bugs.documentfoundation.org/show_bug.cgi?id=123983 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||7556 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157556] Incorrect image link leads to corrupted document AFTER being saved in LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=157556 Stéphane Guillou (stragu) changed: What|Removed |Added Version|7.3.7.2 release |7.3.6.2 release Priority|medium |high Blocks||107943 CC||stephane.guillou@libreoffic ||e.org Severity|normal |major Regression By||Tomaž Vajngerl See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||3983 --- Comment #5 from Stéphane Guillou (stragu) --- Upping the importance as it it a regression that results in a corrupt file. (see https://wiki.documentfoundation.org/images/0/06/Prioritizing_Bugs_Flowchart.jpg) Thanks Kira for the bibisect. Commit is a cherrypick of d449da36086409e3cc440036193c4fc8a10a37a1, for bug 123983. Still reproduced in: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 29b11fa3b5574dc3f42f55b0716f71054030c6c2 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Quikee, what do you think? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107943 [Bug 107943] [META] Save bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 107943] [META] Save bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107943 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||157556 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=157556 [Bug 157556] Incorrect image link leads to corrupted document AFTER being saved in LibreOffice -- You are receiving this mail because: You are the assignee for the bug.
[Bug 112765] [META] RTF (text) table bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112765 Bug 112765 depends on bug 148540, which changed state. Bug 148540 Summary: FILEOPEN RTF Paragraph style extends to more table cells in a row https://bugs.documentfoundation.org/show_bug.cgi?id=148540 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 148540] FILEOPEN RTF Paragraph style extends to more table cells in a row
https://bugs.documentfoundation.org/show_bug.cgi?id=148540 Gabor Kelemen (allotropia) changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 148540] FILEOPEN RTF Paragraph style extends to more table cells in a row
https://bugs.documentfoundation.org/show_bug.cgi?id=148540 --- Comment #6 from Gabor Kelemen (allotropia) --- Created attachment 191561 --> https://bugs.documentfoundation.org/attachment.cgi?id=191561=edit The example file in Word and current master Looks good in Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 2eb428a8890dda29fbdc8b639fc1377080fab59f CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: threaded Thanks Justin! -- You are receiving this mail because: You are the assignee for the bug.
Question About Advanced UNO
Hi. I am reading this link to get an understanding of UNO https://wiki.documentfoundation.org/Documentation/DevGuide/Advanced_UNO Close to the end, it is mentioned that "The disadvantage of the above function is that it must acquire and release the *mutex* every time it is called. The double-checked locking idiom was developed to reduce the need for locking, leading to the following modified function. Do not use.:" But locking is not needed in C++11 https://stackoverflow.com/a/449823. The documentation mentions that "Implementing a UNO component that is instantiated on demand from any other language at the global service manager. In addition to 2) above, a binding must provide the code that starts up the runtime engine of the target environment. For example, when a Java UNO component is instantiated by the LibreOffice process, the Java VM must be loaded and initialized, before the actual component is loaded (bidirectional binding)" Where is the global service manager? Is it in C++? How to implement a UNO Component in C++? How to instantiate a UNO Component at the global service manager in C++. Best, Hassan Sajjad
[Bug 158652] List of comments in Navigator does not update automatically
https://bugs.documentfoundation.org/show_bug.cgi?id=158652 --- Comment #3 from Commit Notification --- Oliver Specht committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0097f8595791f4bbf499ebd423f4f80ec8e38dbe tdf#158652 notify navigator on insert/edit/delete comment It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158652] List of comments in Navigator does not update automatically
https://bugs.documentfoundation.org/show_bug.cgi?id=158652 Commit Notification changed: What|Removed |Added Whiteboard||target:24.8.0 -- You are receiving this mail because: You are the assignee for the bug.
core.git: sc/qa sc/source
sc/qa/uitest/calc_tests8/navigator.py | 27 +++
sc/source/ui/navipi/navipi.cxx|1 +
2 files changed, 28 insertions(+)
New commits:
commit 0097f8595791f4bbf499ebd423f4f80ec8e38dbe
Author: Oliver Specht
AuthorDate: Tue Dec 12 15:51:42 2023 +0100
Commit: Thorsten Behrens
CommitDate: Fri Dec 22 09:59:04 2023 +0100
tdf#158652 notify navigator on insert/edit/delete comment
links changes of the drawing engine to comments as it was
done before with pictures, shapes and OLE objects
ui unit test included
Change-Id: I4fde3a82b80e73758fb3da94ed2553453d09e9ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160624
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
diff --git a/sc/qa/uitest/calc_tests8/navigator.py
b/sc/qa/uitest/calc_tests8/navigator.py
index ec8fa2ae9a2e..9c1769dcf49d 100644
--- a/sc/qa/uitest/calc_tests8/navigator.py
+++ b/sc/qa/uitest/calc_tests8/navigator.py
@@ -10,6 +10,7 @@
from uitest.framework import UITestCase
from libreoffice.uno.propertyvalue import mkPropertyValues
from uitest.uihelper.common import get_state_as_dict, get_url_for_data_file
+from uitest.uihelper.calc import enter_text_to_cell
class navigator(UITestCase):
@@ -181,4 +182,30 @@ class navigator(UITestCase):
self.xUITest.executeCommand(".uno:Sidebar")
+
+def test_tdf158652(self):
+with self.ui_test.create_doc_in_start_center("calc"):
+xCalcDoc = self.xUITest.getTopFocusWindow()
+xGridWin = xCalcDoc.getChild("grid_window")
+
+self.xUITest.executeCommand(".uno:Sidebar")
+
+xGridWin.executeAction("SIDEBAR", mkPropertyValues({"PANEL":
"ScNavigatorPanel"}))
+
+xCalcDoc = self.xUITest.getTopFocusWindow()
+xNavigatorPanel = xCalcDoc.getChild("NavigatorPanel")
+xContentBox = xNavigatorPanel.getChild('contentbox')
+enter_text_to_cell(xGridWin, "A1", "1")
+
+commentText = mkPropertyValues({"Text":"CommentText"})
+self.xUITest.executeCommandWithParameters(".uno:InsertAnnotation",
commentText)
+xComments = xContentBox.getChild("6")
+self.assertEqual(len(xComments.getChildren()), 1)
+
+self.xUITest.executeCommand(".uno:DeleteNote")
+xComments = xContentBox.getChild("6")
+self.assertEqual(len(xComments.getChildren()), 0)
+
+self.xUITest.executeCommand(".uno:Sidebar")
+
# vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/sc/source/ui/navipi/navipi.cxx b/sc/source/ui/navipi/navipi.cxx
index 5fc6fee82122..ae95220eeffb 100644
--- a/sc/source/ui/navipi/navipi.cxx
+++ b/sc/source/ui/navipi/navipi.cxx
@@ -540,6 +540,7 @@ void ScNavigatorDlg::Notify( SfxBroadcaster&, const
SfxHint& rHint )
m_xLbEntries->Refresh( ScContentId::GRAPHIC );
m_xLbEntries->Refresh( ScContentId::OLEOBJECT );
m_xLbEntries->Refresh( ScContentId::DRAWING );
+m_xLbEntries->Refresh( ScContentId::NOTE );
break;
case SfxHintId::ScAreaLinksChanged:
[Bug 158067] Replace O(U)StringLiterals with custom O(U)String literals in code
https://bugs.documentfoundation.org/show_bug.cgi?id=158067 --- Comment #5 from Buovjaga --- (In reply to Devansh Varshney from comment #4) > Hi Team, > I am looking for a starting point to contribute to the project. > > I followed this blog from the recent tweet > -https://dev.blog.documentfoundation.org/2023/12/21/custom-string-literals- > two-easyhacks/ > > and apologies as I assigned this bug to myself without asking I was going > through this https://wiki.documentfoundation.org/Development/EasyHacks This is a task that multiple people can work on at the same time. Therefore there is no need to assign it to a single person. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158828] bugs in libraoffice
https://bugs.documentfoundation.org/show_bug.cgi?id=158828 Julien Nabet changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158828] bugs in libraoffice
https://bugs.documentfoundation.org/show_bug.cgi?id=158828 Julien Nabet changed: What|Removed |Added Resolution|--- |INVALID Status|UNCONFIRMED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155045] [META] RTF Floating table related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=155045 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on|118828 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=118828 [Bug 118828] FILEOPEN: RTF: Incorrect row's height in table if there's a shape inside -- You are receiving this mail because: You are the assignee for the bug.
[Bug 112765] [META] RTF (text) table bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112765 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on||118828 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=118828 [Bug 118828] FILEOPEN: RTF: Incorrect row's height in table if there's a shape inside -- You are receiving this mail because: You are the assignee for the bug.
[Bug 118828] FILEOPEN: RTF: Incorrect row's height in table if there's a shape inside
https://bugs.documentfoundation.org/show_bug.cgi?id=118828 Gabor Kelemen (allotropia) changed: What|Removed |Added Blocks|155045 |112765 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=112765 [Bug 112765] [META] RTF (text) table bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=155045 [Bug 155045] [META] RTF Floating table related issues -- You are receiving this mail because: You are the assignee for the bug.
[Bug 118828] FILEOPEN: RTF: Incorrect row's height in table if there's a shape inside
https://bugs.documentfoundation.org/show_bug.cgi?id=118828 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||kelem...@ubuntu.com --- Comment #7 from Gabor Kelemen (allotropia) --- Created attachment 191560 --> https://bugs.documentfoundation.org/attachment.cgi?id=191560=edit Wrap settings of the image in Word and Writer This image (I replace the purple MS heading in Word with this) has a Behind Text wrap originally, but becomes No Wrap in Writer. Changing to In background with the context menu fixes the firs rows height. More interesting is: why is there an empty paragraph before the B1 cells "C", and why is there a B3 cell appearing from nothing? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158828] New: bugs in libraoffice
https://bugs.documentfoundation.org/show_bug.cgi?id=158828 Bug ID: 158828 Summary: bugs in libraoffice Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: priyamule...@gmail.com Description: bugs in libraoffice Steps to Reproduce: 1.writer 2.libraoffice 3.paint Actual Results: ddedfhiu Expected Results: sdjfl;wj Reproducible: Always User Profile Reset: No Additional Info: eljouptij4ew -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158827] Cant save cells borders to XLS, XLSX, but ODS all ok.
https://bugs.documentfoundation.org/show_bug.cgi?id=158827 --- Comment #1 from Stanislav --- Version: 7.5.9.2 (X86_64) / LibreOffice Community Build ID: cdeefe45c17511d326101eed8008ac4092f278a9 CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: ru-RU Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158827] New: Cant save cells borders to XLS, XLSX, but ODS all ok.
https://bugs.documentfoundation.org/show_bug.cgi?id=158827 Bug ID: 158827 Summary: Cant save cells borders to XLS, XLSX, but ODS all ok. Product: LibreOffice Version: 7.5.9.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sts...@bk.ru Hi everyone! Cells with different thick borders and fields like 'sheet name' cannot be saved to XLS or XLSX, but ODS saves perfectly. I saw bugreeports #75130, #88827, #151755 and other But problems still exist. Windows 7 SP1 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 118828] FILEOPEN: RTF: Incorrect row's height in table if there's a shape inside
https://bugs.documentfoundation.org/show_bug.cgi?id=118828 --- Comment #6 from Gabor Kelemen (allotropia) --- Created attachment 191559 --> https://bugs.documentfoundation.org/attachment.cgi?id=191559=edit Minimal example file with non-floating table I played with this a bit, and it seems like the issue happens even if the table is not floating. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 118828] FILEOPEN: RTF: Incorrect row's height in table if there's a shape inside
https://bugs.documentfoundation.org/show_bug.cgi?id=118828 Gabor Kelemen (allotropia) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||8826 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158826] FILEOPEN RTF Floating table with image creates unexpected page break
https://bugs.documentfoundation.org/show_bug.cgi?id=158826 Gabor Kelemen (allotropia) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||8828 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157649] Dialog button accelerators should work without Alt key on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=157649 Samuel Mehrbrodt (allotropia) changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |samuel.mehrbrodt@allotropia |desktop.org |.de Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.
