core.git: Branch 'distro/collabora/co-24.04' - vcl/inc vcl/jsdialog

2024-03-04 Thread Noel Grandin (via logerrit)
 vcl/inc/jsdialog/jsdialogbuilder.hxx |   19 ++--
 vcl/jsdialog/jsdialogbuilder.cxx |  156 ---
 2 files changed, 81 insertions(+), 94 deletions(-)

New commits:
commit 571a1ab88a41bfc4f8024bd1531c9f34b1023e43
Author: Noel Grandin 
AuthorDate: Mon Mar 4 19:15:43 2024 +0200
Commit: Noel Grandin 
CommitDate: Tue Mar 5 08:57:34 2024 +0100

reduce heap allocation in JSDialogNotifyIdle

makes the code simpler too

Change-Id: Ic452895a20fb2908f7383082069a84ef3fa6a4d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164395
Tested-by: Jenkins
Reviewed-by: Noel Grandin 
(cherry picked from commit 70f2c6f87ae3dd6c8e4b808cbee3ab81f17f6a36)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164380
Reviewed-by: Mike Kaganski 
Tested-by: Jenkins CollaboraOffice 

diff --git a/vcl/inc/jsdialog/jsdialogbuilder.hxx 
b/vcl/inc/jsdialog/jsdialogbuilder.hxx
index edd49c1804a7..7ef9c1cfc833 100644
--- a/vcl/inc/jsdialog/jsdialogbuilder.hxx
+++ b/vcl/inc/jsdialog/jsdialogbuilder.hxx
@@ -125,16 +125,15 @@ public:
  std::unique_ptr pData = nullptr);
 
 private:
-void send(tools::JsonWriter& aJsonWriter);
-std::unique_ptr generateFullUpdate() const;
-std::unique_ptr 
generateWidgetUpdate(VclPtr pWindow) const;
-std::unique_ptr generateCloseMessage() const;
-std::unique_ptr
-generateActionMessage(VclPtr pWindow,
-  std::unique_ptr pData) 
const;
-std::unique_ptr
-generatePopupMessage(VclPtr pWindow, OUString sParentId, 
OUString sCloseId) const;
-std::unique_ptr generateClosePopupMessage(OUString 
sWindowId) const;
+void send(const OString& sMsg);
+OString generateFullUpdate() const;
+OString generateWidgetUpdate(VclPtr pWindow) const;
+OString generateCloseMessage() const;
+OString generateActionMessage(VclPtr pWindow,
+  std::unique_ptr 
pData) const;
+OString generatePopupMessage(VclPtr pWindow, OUString 
sParentId,
+ OUString sCloseId) const;
+OString generateClosePopupMessage(OUString sWindowId) const;
 };
 
 class JSDialogSender
diff --git a/vcl/jsdialog/jsdialogbuilder.cxx b/vcl/jsdialog/jsdialogbuilder.cxx
index f5e3a9c65325..7eda7861fc8d 100644
--- a/vcl/jsdialog/jsdialogbuilder.cxx
+++ b/vcl/jsdialog/jsdialogbuilder.cxx
@@ -81,31 +81,22 @@ JSDialogNotifyIdle::JSDialogNotifyIdle(VclPtr 
aNotifierWindow,
 
 void JSDialogNotifyIdle::forceUpdate() { m_bForce = true; }
 
-void JSDialogNotifyIdle::send(tools::JsonWriter& aJsonWriter)
+void JSDialogNotifyIdle::send(const OString& sMsg)
 {
 if (!m_aNotifierWindow)
 {
-aJsonWriter.finishAndGetAsOString();
 return;
 }
 
 const vcl::ILibreOfficeKitNotifier* pNotifier = 
m_aNotifierWindow->GetLOKNotifier();
 if (pNotifier)
 {
-if (m_bForce || !aJsonWriter.isDataEquals(m_LastNotificationMessage))
+if (m_bForce || sMsg != m_LastNotificationMessage)
 {
 m_bForce = false;
-m_LastNotificationMessage = aJsonWriter.finishAndGetAsOString();
+m_LastNotificationMessage = sMsg;
 pNotifier->libreOfficeKitViewCallback(LOK_CALLBACK_JSDIALOG, 
m_LastNotificationMessage);
 }
-else
-{
-aJsonWriter.finishAndGetAsOString();
-}
-}
-else
-{
-aJsonWriter.finishAndGetAsOString();
 }
 }
 
@@ -138,91 +129,89 @@ void 
JSDialogNotifyIdle::sendMessage(jsdialog::MessageType eType, VclPtr JSDialogNotifyIdle::generateFullUpdate() 
const
+OString JSDialogNotifyIdle::generateFullUpdate() const
 {
-std::unique_ptr aJsonWriter(new tools::JsonWriter());
-
 if (!m_aContentWindow || !m_aNotifierWindow)
-return aJsonWriter;
+return OString();
 
-m_aContentWindow->DumpAsPropertyTree(*aJsonWriter);
+tools::JsonWriter aJsonWriter;
+
+m_aContentWindow->DumpAsPropertyTree(aJsonWriter);
 if (m_aNotifierWindow)
-aJsonWriter->put("id", m_aNotifierWindow->GetLOKWindowId());
-aJsonWriter->put("jsontype", m_sTypeOfJSON);
+aJsonWriter.put("id", m_aNotifierWindow->GetLOKWindowId());
+aJsonWriter.put("jsontype", m_sTypeOfJSON);
 
-return aJsonWriter;
+return aJsonWriter.finishAndGetAsOString();
 }
 
-std::unique_ptr
-JSDialogNotifyIdle::generateWidgetUpdate(VclPtr pWindow) const
+OString JSDialogNotifyIdle::generateWidgetUpdate(VclPtr pWindow) 
const
 {
-std::unique_ptr aJsonWriter(new tools::JsonWriter());
-
 if (!pWindow || !m_aNotifierWindow)
-return aJsonWriter;
+return OString();
 
-aJsonWriter->put("jsontype", m_sTypeOfJSON);
-aJsonWriter->put("action", "update");
+tools::JsonWriter aJsonWriter;
+
+aJsonWriter.put("jsontype", m_sTypeOfJSON);
+aJsonWriter.put("action", "update");
 if (m_aNotifierWindow)
-aJsonWriter->put("id", m_aNotifierWindow->GetLOKWindowId());

[Bug 160042] numbering style bugs

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160042

DuyN  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from DuyN  ---
Thank you for reporting the bug. I can confirm that the bug is present in:

Version: 24.2.1.2 (X86_64) / LibreOffice Community
Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160043] Calc crashes on Gnome Wayland when saving document while closing other windows

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160043

Kevin Suo  changed:

   What|Removed |Added

 CC||caolan.mcnamara@collabora.c
   ||om

--- Comment #1 from Kevin Suo  ---
Caolán: I add you to cc. Maybe you are interested in this one.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159909] FILESAVE DOCX PAC tool complains about too small contrast of paragraph with background color

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159909

Thorsten Behrens (allotropia)  changed:

   What|Removed |Added

 CC||t...@libreoffice.org
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160043] New: Calc crashes on Gnome Wayland when saving document while closing other windows

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160043

Bug ID: 160043
   Summary: Calc crashes on Gnome Wayland when saving document
while closing other windows
   Product: LibreOffice
   Version: 24.8.0.0 alpha0+ Master
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: suokunl...@126.com

Created attachment 192957
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192957=edit
Doc1.ods

Steps To Reproduce:

1. On Fedora 39 Gnome 45.4, install and activate the Dash to Dock Gnome
extension.

2. In Dash to Dock Settings > Behavior > Click Action, use "Focus, minimize or
show previews", OK.

3. Open the attached ods file (I name it as "Doc1" below) in a LibreOffice
debug build.

(debug build is needed here because on a release build the following saving
process would be too fast for you to do the other steps. If you do want to use
a release build, you may need to duplicate 10 copies of the sheet in the test
doc, to make the file large enough to slow down the saving process)

4. Click the toolbar icon to create 2 new Calc empty documents (I name them
Doc2 and Doc3).

5. Ctrl+S to trigger the saving of Doc1.

6. While Doc1 is in the process of saving, click the LibreOffice Calc icon in
Dash To Dock, you get Doc1, Doc2 and Doc3 as Previews. Click Doc2 and then
click the "X (i.e. close button)" on the top-right of the window manager. Do
the same for Doc3. (Now the two windows are not responding because they are
waiting for Doc1 to finish saving, fine)

7. Click the Dash to Dock icon to switch to Doc2 window, then switch to Doc3
window.

8. Wait.

> Crash. All Doc1, Doc2 and Doc3 are closed.
It is expected that only Doc2 and Doc3 are closed. Doc1 should remain open.

Actually it seems not a crash when I do this in gdb. Gdb bt gives no backtrace.
The terminal gives the following message which may be relevant:
Gdk-Message: 14:52:24.450: Lost connection to Wayland compositor.

It is noted that it does not crash if I use "Minimize or show previews" in Dock
Settings > Behavior > Click Action. So the "Focus" here makes a difference.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9574a62add8e4901405e12117e75c86c2d2c2f21
CPU threads: 8; OS: Linux 6.7; UI render: default; VCL: gtk3
Locale: zh-CN (zh_CN.UTF-8); UI: en-US
Calc: threaded

## Hardware Information:
- **Hardware Model:**Lenovo ThinkPad X1 Carbon Gen 8
- **Memory:**16.0 GiB
- **CPU:**   Intel® Core™ i5-10210U × 8
- ** Graphic:**  Intel® UHD Graphics (CML GT2)

## Software Information:
- **OS:**Fedora Linux 39 (Workstation Edition)
- **OS Type:**   64 bit
- **GNOME Version:** 45.4
- **Window System:** Wayland
- **Kernel:**Linux 6.7.6-200.fc39.x86_64

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 146242] calc row highlighting in numbers column misaligned to selected cell (Skia metal)

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146242

--- Comment #19 from ady  ---
(In reply to Robert Kisteleki from comment #17)
> > Test to see if the bug is still present with the latest version of
> > LibreOffice from https://www.libreoffice.org/download/
> 
> I'm using 2024.2.0.3 now, and cannot reproduce the issue.

Please provide the complete version information, in the same way as you did in
your comment 12. The "UI render" data used by/in your new version is relevant.
TIA.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 49602] Remove deprecated OSL Profile functionality

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=49602

--- Comment #15 from Stephan Bergmann  ---
(In reply to seturajmatroja from comment #14)
> Does it even reach that point?

The relevant code in expandMacros would be reached for a reference of the form

> ${::}

which is likely not encountered in a typical LO installation set.  (So you
would likely set up some test code for it.  There already is e.g.
sal/qa/rtl/bootstrap/expand.cxx.)


Caveat:  The existing rtl/bootstrap code just effectively ignores "[section]"
markers in the ini-files it processes.  It uniformly consumes all key=value
pairs regardless of what sections, if any, they are in.  (It nominally requires
that bootstrap variables are in "[bootstrap]" sections, but does not enforce
that.  And, for backwards compatibility, we should likely continue with this
behavior.)  So there would be a problem how to treat the  part in the
above reference, if we were to change the processing code from osl/profile to
existing rtl/bootsrap functionality.  The change proposed here might or might
not be such a bright idea after all, and might or might not actually be an easy
hack (though it already has the high category "interesting", for a reason).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160042] New: numbering style bugs

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160042

Bug ID: 160042
   Summary: numbering style bugs
   Product: LibreOffice
   Version: 24.2.1.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lmiro...@yandex.ru

Created attachment 192956
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192956=edit
faint numbering selection sample

* Open styles pane (F11)
* Go to 'body text-list-numbering 1' style and edit it (rightclick, edit style)
* Go to Outline tab
* Set List style to 'Numbering 123'
* Click 'Edit Style' button (wait a minute, aren't we editing a style already?
Terminology is confusing - bug1)
* Set Ordered to '1.' and Outline to '1.1.1.1.'
* Click Ok - and style list selection jumps from 'Numbering 1' to 'Body Style'
- why? (bug2)
* Find 'numbering 1' style agaon, edit, go to Outline - Numbering 123
style is saved.
* Click 'Edit Style' button - Ordered and Outline settings are NOT saved, first
items in both lists are selected (bug3) Also the initial unfocused selection in
this dialogue is way too faint. Even though my eyesight is not at all bad, I
have to do a double take, image attached (bug4)


Version: 24.2.1.2 (X86_64) / LibreOffice Community
Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac
CPU threads: 8; OS: Windows 10.0 Build 17763; UI render: Skia/Vulkan; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 146242] calc row highlighting in numbers column misaligned to selected cell (Skia metal)

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146242

--- Comment #18 from Buovjaga  ---
(In reply to Robert Kisteleki from comment #17)
> > Test to see if the bug is still present with the latest version of
> > LibreOffice from https://www.libreoffice.org/download/
> 
> I'm using 2024.2.0.3 now, and cannot reproduce the issue.

Even with Skia active?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160041] spam

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160041

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Summary|Volkswagen Golf Common  |spam
   |Problems: A Comprehensive   |
   |Guide   |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160041] Volkswagen Golf Common Problems: A Comprehensive Guide

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160041

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

  Component|General |deletionRequest
 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED
Version|1.0.1   |unspecified
Product|Impress Remote  |LibreOffice
 CC||stephane.guillou@libreoffic
   ||e.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 146242] calc row highlighting in numbers column misaligned to selected cell (Skia metal)

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146242

--- Comment #17 from Robert Kisteleki  ---

> Test to see if the bug is still present with the latest version of
> LibreOffice from https://www.libreoffice.org/download/

I'm using 2024.2.0.3 now, and cannot reproduce the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'distro/vector/vector-7.5.9' - sw/qa sw/source

2024-03-04 Thread Mike Kaganski (via logerrit)
 sw/qa/extras/htmlexport/data/char_border_and_font_color.fodt |   14 
 sw/qa/extras/htmlexport/htmlexport.cxx   |   24 
 sw/source/filter/html/css1atr.cxx|6 
 sw/source/filter/html/htmlatr.cxx|  416 +--
 4 files changed, 233 insertions(+), 227 deletions(-)

New commits:
commit b13693d88f9a3f2a0ded26651b36d5c9f80673ac
Author: Mike Kaganski 
AuthorDate: Mon Mar 4 12:20:13 2024 +0600
Commit: Mike Kaganski 
CommitDate: Tue Mar 5 00:16:17 2024 +0600

tdf160017: make sure to emit the closing tags in correct order

This reimplements how the starts and ends of attributes are stored in
HTMLEndPosLst. Instead of a plain list, now it is a sorted map, with
positions as keys, and a vector of HTMLStartEndPos* as values.

In commit b94b1fe936ddc4a9b86fbeb9c9c6ab0fca52f0bc (CharBrd 9.1: HTML
filters, 2013-09-08), the character borders attributes started to be
set in a special order, in front of the position's other attributes,
to allow merging them. But that created a problem of knowing in which
order to close respective tags.

The change here sorts the closing tags for the current node only when
writing them. At this point, it is possible to consider the opening
positions correctly.

Change-Id: I466ffa1c0eb28874ded003035e0cf772e31585b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164325
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sw/qa/extras/htmlexport/data/char_border_and_font_color.fodt 
b/sw/qa/extras/htmlexport/data/char_border_and_font_color.fodt
new file mode 100644
index ..bda2ec63133c
--- /dev/null
+++ b/sw/qa/extras/htmlexport/data/char_border_and_font_color.fodt
@@ -0,0 +1,14 @@
+
+
+
+ 
+  
+   
+  
+ 
+ 
+  
+   foo
+  
+ 
+
\ No newline at end of file
diff --git a/sw/qa/extras/htmlexport/htmlexport.cxx 
b/sw/qa/extras/htmlexport/htmlexport.cxx
index 0e2396c39fd5..4afef396 100644
--- a/sw/qa/extras/htmlexport/htmlexport.cxx
+++ b/sw/qa/extras/htmlexport/htmlexport.cxx
@@ -3023,6 +3023,30 @@ CPPUNIT_TEST_FIXTURE(SwHtmlDomExportTest, 
testReqIF_NoBrClearForImageWrap)
 0);
 }
 
+CPPUNIT_TEST_FIXTURE(SwHtmlDomExportTest, testReqIF_Tdf160017_spanClosingOrder)
+{
+// Given a document with a paragraph having explicit font color and 
character border properties:
+createSwDoc("char_border_and_font_color.fodt");
+// When exporting to reqif:
+ExportToReqif();
+SvMemoryStream aStream;
+WrapReqifFromTempFile(aStream);
+xmlDocUniquePtr pXmlDoc = parseXmlStream();
+// Without the fix, this would fail, because there was an extra closing 

+CPPUNIT_ASSERT(pXmlDoc);
+}
+
+CPPUNIT_TEST_FIXTURE(SwHtmlDomExportTest, testHTML_Tdf160017_spanClosingOrder)
+{
+// Given a document with a paragraph having explicit font color and 
character border properties:
+createSwDoc("char_border_and_font_color.fodt");
+// When exporting to HTML:
+save("HTML (StarWriter)");
+// Parse it as XML (strict!)
+// Without the fix, this would fail, because span and font elements closed 
in wrong order
+CPPUNIT_ASSERT(parseXml(maTempFile));
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/filter/html/css1atr.cxx 
b/sw/source/filter/html/css1atr.cxx
index 27d0c645ad56..af2fe301c96c 100644
--- a/sw/source/filter/html/css1atr.cxx
+++ b/sw/source/filter/html/css1atr.cxx
@@ -3335,14 +3335,16 @@ Writer& OutCSS1_SvxBox( Writer& rWrt, const 
SfxPoolItem& rHt )
 
 if( rHt.Which() == RES_CHRATR_BOX )
 {
+constexpr std::string_view inline_block("inline-block");
 if( rHTMLWrt.m_bTagOn )
 {
 // Inline-block to make the line height changing correspond to the 
character border
-rHTMLWrt.OutCSS1_PropertyAscii(sCSS1_P_display, "inline-block");
+rHTMLWrt.OutCSS1_PropertyAscii(sCSS1_P_display, inline_block);
 }
 else
 {
-HTMLOutFuncs::Out_AsciiTag( rWrt.Strm(), 
Concat2View(rHTMLWrt.GetNamespace() + OOO_STRING_SVTOOLS_HTML_span), false );
+if (!IgnorePropertyForReqIF(rHTMLWrt.mbReqIF, sCSS1_P_display, 
inline_block))
+HTMLOutFuncs::Out_AsciiTag( rWrt.Strm(), 
Concat2View(rHTMLWrt.GetNamespace() + OOO_STRING_SVTOOLS_HTML_span), false );
 return rWrt;
 }
 }
diff --git a/sw/source/filter/html/htmlatr.cxx 
b/sw/source/filter/html/htmlatr.cxx
index a99140564301..247b22e5ff2f 100644
--- a/sw/source/filter/html/htmlatr.cxx
+++ b/sw/source/filter/html/htmlatr.cxx
@@ -1056,7 +1056,7 @@ public:
 
 HTMLStartEndPos( const SfxPoolItem& rItem, sal_Int32 nStt, sal_Int32 nE );
 
-const SfxPoolItem* GetItem() const { return m_pItem.get(); }
+const SfxPoolItem& GetItem() const { return *m_pItem; }
 
 void SetStart(sal_Int32 nStt) { m_nStart = nStt; }
 sal_Int32 

[Bug 160041] Volkswagen Golf Common Problems: A Comprehensive Guide

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160041

--- Comment #1 from Ithar Falak  ---
i M a [writer](https://www.apsense.com/) and https://servicemycar.com/uae/car-battery-replacement-dubai;>car battery
serviceand [url=https://www.apsense.com/]dancer[/url]

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160041] New: Volkswagen Golf Common Problems: A Comprehensive Guide

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160041

Bug ID: 160041
   Summary: Volkswagen Golf Common Problems: A Comprehensive Guide
   Product: Impress Remote
   Version: 1.0.1
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: General
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: radhwaanaza...@gmail.com

Description:
i M a [writer](https://www.apsense.com/) and https://servicemycar.com/uae/car-battery-replacement-dubai;>car battery
serviceand [url=https://www.apsense.com/]dancer[/url]

Actual Results:
car service

Expected Results:
car service


Reproducible: Always


User Profile Reset: No

Additional Info:
car service

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: vcl/inc vcl/jsdialog

2024-03-04 Thread Noel Grandin (via logerrit)
 vcl/inc/jsdialog/jsdialogbuilder.hxx |   19 ++--
 vcl/jsdialog/jsdialogbuilder.cxx |  156 ---
 2 files changed, 81 insertions(+), 94 deletions(-)

New commits:
commit 81d4f14e5968453b72ba754a7b3e6c13a30abbf4
Author: Noel Grandin 
AuthorDate: Mon Mar 4 19:15:43 2024 +0200
Commit: Noel Grandin 
CommitDate: Tue Mar 5 07:21:51 2024 +0100

reduce heap allocation in JSDialogNotifyIdle

makes the code simpler too

Change-Id: Ic452895a20fb2908f7383082069a84ef3fa6a4d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164395
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/vcl/inc/jsdialog/jsdialogbuilder.hxx 
b/vcl/inc/jsdialog/jsdialogbuilder.hxx
index e24ff1589655..315b8605582f 100644
--- a/vcl/inc/jsdialog/jsdialogbuilder.hxx
+++ b/vcl/inc/jsdialog/jsdialogbuilder.hxx
@@ -125,16 +125,15 @@ public:
  std::unique_ptr pData = nullptr);
 
 private:
-void send(tools::JsonWriter& aJsonWriter);
-std::unique_ptr generateFullUpdate() const;
-std::unique_ptr 
generateWidgetUpdate(VclPtr pWindow) const;
-std::unique_ptr generateCloseMessage() const;
-std::unique_ptr
-generateActionMessage(VclPtr pWindow,
-  std::unique_ptr pData) 
const;
-std::unique_ptr
-generatePopupMessage(VclPtr pWindow, OUString sParentId, 
OUString sCloseId) const;
-std::unique_ptr generateClosePopupMessage(OUString 
sWindowId) const;
+void send(const OString& sMsg);
+OString generateFullUpdate() const;
+OString generateWidgetUpdate(VclPtr pWindow) const;
+OString generateCloseMessage() const;
+OString generateActionMessage(VclPtr pWindow,
+  std::unique_ptr 
pData) const;
+OString generatePopupMessage(VclPtr pWindow, OUString 
sParentId,
+ OUString sCloseId) const;
+OString generateClosePopupMessage(OUString sWindowId) const;
 };
 
 class JSDialogSender
diff --git a/vcl/jsdialog/jsdialogbuilder.cxx b/vcl/jsdialog/jsdialogbuilder.cxx
index a7199e2ed960..38b3a9e2922d 100644
--- a/vcl/jsdialog/jsdialogbuilder.cxx
+++ b/vcl/jsdialog/jsdialogbuilder.cxx
@@ -81,31 +81,22 @@ JSDialogNotifyIdle::JSDialogNotifyIdle(VclPtr 
aNotifierWindow,
 
 void JSDialogNotifyIdle::forceUpdate() { m_bForce = true; }
 
-void JSDialogNotifyIdle::send(tools::JsonWriter& aJsonWriter)
+void JSDialogNotifyIdle::send(const OString& sMsg)
 {
 if (!m_aNotifierWindow)
 {
-aJsonWriter.finishAndGetAsOString();
 return;
 }
 
 const vcl::ILibreOfficeKitNotifier* pNotifier = 
m_aNotifierWindow->GetLOKNotifier();
 if (pNotifier)
 {
-if (m_bForce || !aJsonWriter.isDataEquals(m_LastNotificationMessage))
+if (m_bForce || sMsg != m_LastNotificationMessage)
 {
 m_bForce = false;
-m_LastNotificationMessage = aJsonWriter.finishAndGetAsOString();
+m_LastNotificationMessage = sMsg;
 pNotifier->libreOfficeKitViewCallback(LOK_CALLBACK_JSDIALOG, 
m_LastNotificationMessage);
 }
-else
-{
-aJsonWriter.finishAndGetAsOString();
-}
-}
-else
-{
-aJsonWriter.finishAndGetAsOString();
 }
 }
 
@@ -139,91 +130,89 @@ void 
JSDialogNotifyIdle::sendMessage(jsdialog::MessageType eType,
 m_aMessageQueue.push_back(aMessage);
 }
 
-std::unique_ptr JSDialogNotifyIdle::generateFullUpdate() 
const
+OString JSDialogNotifyIdle::generateFullUpdate() const
 {
-std::unique_ptr aJsonWriter(new tools::JsonWriter());
-
 if (!m_aContentWindow || !m_aNotifierWindow)
-return aJsonWriter;
+return OString();
 
-m_aContentWindow->DumpAsPropertyTree(*aJsonWriter);
+tools::JsonWriter aJsonWriter;
+
+m_aContentWindow->DumpAsPropertyTree(aJsonWriter);
 if (m_aNotifierWindow)
-aJsonWriter->put("id", m_aNotifierWindow->GetLOKWindowId());
-aJsonWriter->put("jsontype", m_sTypeOfJSON);
+aJsonWriter.put("id", m_aNotifierWindow->GetLOKWindowId());
+aJsonWriter.put("jsontype", m_sTypeOfJSON);
 
-return aJsonWriter;
+return aJsonWriter.finishAndGetAsOString();
 }
 
-std::unique_ptr
-JSDialogNotifyIdle::generateWidgetUpdate(VclPtr pWindow) const
+OString JSDialogNotifyIdle::generateWidgetUpdate(VclPtr pWindow) 
const
 {
-std::unique_ptr aJsonWriter(new tools::JsonWriter());
-
 if (!pWindow || !m_aNotifierWindow)
-return aJsonWriter;
+return OString();
 
-aJsonWriter->put("jsontype", m_sTypeOfJSON);
-aJsonWriter->put("action", "update");
+tools::JsonWriter aJsonWriter;
+
+aJsonWriter.put("jsontype", m_sTypeOfJSON);
+aJsonWriter.put("action", "update");
 if (m_aNotifierWindow)
-aJsonWriter->put("id", m_aNotifierWindow->GetLOKWindowId());
+aJsonWriter.put("id", m_aNotifierWindow->GetLOKWindowId());
 {
-auto aEntries = aJsonWriter->startNode("control");
-

[Bug 49994] TABLES : jumps on selecting text in table in big cell on neighboring pages

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=49994

--- Comment #14 from Commit Notification 
 ---
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cf6c6db51eada17408c412173331db0820a23e5d

tdf#49994 Fix text selection over pages for multi column tables

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 49994] TABLES : jumps on selecting text in table in big cell on neighboring pages

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=49994

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:24.8.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sw/source

2024-03-04 Thread Jim Raykowski (via logerrit)
 sw/source/core/crsr/crsrsh.cxx |   19 ---
 1 file changed, 12 insertions(+), 7 deletions(-)

New commits:
commit cf6c6db51eada17408c412173331db0820a23e5d
Author: Jim Raykowski 
AuthorDate: Tue Feb 27 19:22:50 2024 -0900
Commit: Jim Raykowski 
CommitDate: Tue Mar 5 07:21:02 2024 +0100

tdf#49994 Fix text selection over pages for multi column tables

with repeated headings

Change-Id: I6cddeb132ff4f8ff27ea03701067d7a3d4c4cf82
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/79113
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sw/source/core/crsr/crsrsh.cxx b/sw/source/core/crsr/crsrsh.cxx
index 04c904f13905..3e9ca93b3380 100644
--- a/sw/source/core/crsr/crsrsh.cxx
+++ b/sw/source/core/crsr/crsrsh.cxx
@@ -1994,22 +1994,27 @@ void SwCursorShell::UpdateCursor( sal_uInt16 eFlags, 
bool bIdleEnd )
 {
 pTableFrame = nullptr;
 
-SwMoveFnCollection const & fnPosSect = *pPos <  
*pITmpCursor->GetMark()
-? fnSectionStart
-: fnSectionEnd;
-
 // then only select inside the Box
 if( m_pTableCursor )
 {
+SwMoveFnCollection const & fnPosSect = *pPos <  
*pITmpCursor->GetMark()
+? fnSectionStart
+: fnSectionEnd;
+
 m_pCurrentCursor->SetMark();
 *m_pCurrentCursor->GetMark() = *m_pTableCursor->GetMark();
 m_pCurrentCursor->GetMkPos() = m_pTableCursor->GetMkPos();
 m_pTableCursor->DeleteMark();
 m_pTableCursor->SwSelPaintRects::Hide();
-}
 
-*m_pCurrentCursor->GetPoint() = *m_pCurrentCursor->GetMark();
-GoCurrSection( *m_pCurrentCursor, fnPosSect );
+*m_pCurrentCursor->GetPoint() = 
*m_pCurrentCursor->GetMark();
+GoCurrSection( *m_pCurrentCursor, fnPosSect );
+}
+else
+{
+eFlags &= SwCursorShell::UPDOWN;
+*m_pCurrentCursor->GetPoint() = 
*m_pCurrentCursor->GetMark();
+}
 }
 }
 


pierre foucou license statement

2024-03-04 Thread Pierre-Yves Foucou

 All of my past and future contributions to LibreOffice may be
   licensed under the MPLv2/LGPLv3+ dual license.

Additionally, to the extent possible under law, I waive all
   copyright and related or neighboring rights to my past & future
   Artwork and Design contributions to the LibreOffice project, and
   similarly to The Document Foundation, placing such contributions
   under CC0: https://creativecommons.org/publicdomain/zero/1.0



[Bug 160037] General Input/Output Error when saving document

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160037

Kevin Suo  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Kevin Suo  ---
The problem is gone after I reboot the system. Not sure what is going on -
close for now.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159904] Menu bar disappears when coming out of full screen if template selection dialog is open

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159904

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||1471
 CC||m.wegh...@posteo.de

--- Comment #8 from Stéphane Guillou (stragu) 
 ---
(In reply to maloureiro from comment #6)
> My desktop environment is Unity and I'm not using global menus.
OK, so you are using Unity's global menu, but Unity has been dropped from
Ubuntu for a while now, and it's status as a community project seems unsure.

Are other applications affected by the same issue?

I'd suggest moving to GNOME if you can, and if you want to keep using the same
global menus, install one of the global menu addins to emulate the same
behaviour.

Michael, what's your opinion on this? "Won't fix" as we can hardly continue
supporting Unity in its current state?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159808] Date and Time field variants should be named "fixed" instead of "fix"

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159808

--- Comment #5 from Commit Notification 
 ---
Stéphane Guillou committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/4e69e855e524c31af3592fd9925489ad76f4c842

tdf#159808: update menu entries with fixed vs variable

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: helpcontent2

2024-03-04 Thread Stéphane Guillou (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 357b43e7d7c1bd91e908f4fb92ba8c7472fe39dc
Author: Stéphane Guillou 
AuthorDate: Tue Mar 5 06:50:59 2024 +0100
Commit: Gerrit Code Review 
CommitDate: Tue Mar 5 06:50:59 2024 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 4e69e855e524c31af3592fd9925489ad76f4c842
  - tdf#159808: update menu entries with fixed vs variable

Change-Id: Ifb1ec0faa41c22ed61ea6fb78adbf5e1de21754b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164378
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index 0fb58194a065..4e69e855e524 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 0fb58194a0658fe83ca170a9cb8adf72371c8c3e
+Subproject commit 4e69e855e524c31af3592fd9925489ad76f4c842


help.git: source/text

2024-03-04 Thread Stéphane Guillou (via logerrit)
 source/text/swriter/00/0404.xhp |6 --
 source/text/swriter/02/18030100.xhp |4 ++--
 source/text/swriter/02/18030200.xhp |4 +---
 3 files changed, 7 insertions(+), 7 deletions(-)

New commits:
commit 4e69e855e524c31af3592fd9925489ad76f4c842
Author: Stéphane Guillou 
AuthorDate: Tue Mar 5 01:48:11 2024 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Tue Mar 5 06:50:58 2024 +0100

tdf#159808: update menu entries with fixed vs variable

Change-Id: Ifb1ec0faa41c22ed61ea6fb78adbf5e1de21754b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164378
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/source/text/swriter/00/0404.xhp 
b/source/text/swriter/00/0404.xhp
index 434441fa2b..e38616b5b2 100644
--- a/source/text/swriter/00/0404.xhp
+++ b/source/text/swriter/00/0404.xhp
@@ -57,8 +57,10 @@
CommandCtrl
 + F2
 
 
-Choose Insert - Field - 
Date
-Choose Insert - Field - 
Time
+Choose Insert - Field - Date 
(Fixed)
+  Choose Insert - Field - Date 
(Variable)
+Choose Insert - Field - Time 
(Fixed)
+Choose Insert - Field - Time 
(Variable)
 Choose Insert - Field - Page 
Number
 Choose Insert - Field - Page 
Count
 Choose Insert - Field - 
Subject
diff --git a/source/text/swriter/02/18030100.xhp 
b/source/text/swriter/02/18030100.xhp
index 898f43e416..4a0cc8c6cc 100644
--- a/source/text/swriter/02/18030100.xhp
+++ b/source/text/swriter/02/18030100.xhp
@@ -18,11 +18,11 @@
  *   except in compliance with the License. You may obtain a copy of
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  -->
-   
+
 
 
 
-Date
+Date (Fixed)
 /text/swriter/02/18030100.xhp
 
 
diff --git a/source/text/swriter/02/18030200.xhp 
b/source/text/swriter/02/18030200.xhp
index be0139922a..661e81df99 100644
--- a/source/text/swriter/02/18030200.xhp
+++ b/source/text/swriter/02/18030200.xhp
@@ -22,7 +22,7 @@
 
 
 
-Time
+Time (Fixed)
 /text/swriter/02/18030200.xhp
 
 
@@ -30,8 +30,6 @@
 
 
 
-  
-  
   
   time 
fields;insertingfields;inserting 
time
 


[Bug 100643] Numbering of rows in tables changes on horizontal split of neighbouring cells

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=100643

--- Comment #11 from andis.lazd...@gmail.com ---
The issue is still presented.
Version: 24.2.1.2 (X86_64) / LibreOffice Community
Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: lv-LV (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 142635] Copy+paste a sheet with chart results in incorrect chart's data ranges

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142635

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||4129

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 87351] [META] Conditional formatting bugs and enhancements

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=87351
Bug 87351 depends on bug 124129, which changed state.

Bug 124129 Summary: sheet names containing a dot and used in conditional 
formatting formulas cause a non-existent external link to the "documents" user 
folder
https://bugs.documentfoundation.org/show_bug.cgi?id=124129

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 124129] sheet names containing a dot and used in conditional formatting formulas cause a non-existent external link to the "documents" user folder

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124129

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0
 Status|NEW |RESOLVED
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||2635
 CC||er...@redhat.com,
   ||stephane.guillou@libreoffic
   ||e.org
  Regression By||Tor Lillqvist
Summary|sheet names containing a|sheet names containing a
   |dot and are used in |dot and used in conditional
   |conditional formatting  |formatting formulas cause a
   |formulas cause an non   |non-existent external link
   |existent external link to   |to the "documents" user
   |the "documents" user folder |folder
 Resolution|--- |FIXED

--- Comment #8 from Stéphane Guillou (stragu) 
 ---
Not reproduced anymore in:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: e939685f9c6918830bd3097062790bfccbce937e
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Fix bibisected in linux-64-7.4 repo to firs _good_ build
[18b2eb81462e7695d52e9018a7e17ed7a5c915bf] which is:

commit  fe687d1b8f5305edfb167152a4fb19ffa20c5404
author  Eike Rathke Thu May 12 00:20:05 2022 +0200
Related: tdf#142635 Remove address parsing failback code
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134212

Thanks Eike!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 140868] Copy-pasted chart references source sheet instead of self if target sheet moved before source sheet after copying

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140868

--- Comment #9 from Mike Kaganski  ---
(In reply to Stéphane Guillou (stragu) from comment #8)

I saw this bug.
However, I have no idea if it is possible to handle it at all, without a deep
reimplementation of a huge part of Calc internals. A *calc document* is created
for placement to clipboard; the selected part plus its references are copied to
it from the current document; there is a way to tell that this calc document is
based on "this specific normal document", which avoids creation of internal
data set for charts when pasting to itself. But in any case, pasting back, it's
the structure of the clipboard document that defines the references, not the
structure of the (updated) source document. There is no way for clipboard to
know that "the sheet number X, which was the source for the chart, is now sheer
number Y in the source document". (See how the sheets are referenced by numbers
internally, not by names (which would not help, since you can rename freely),
nor by pointers / references, etc.).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 140868] Copy-pasted chart references source sheet instead of self if target sheet moved before source sheet after copying

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140868

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||mikekagan...@hotmail.com

--- Comment #8 from Stéphane Guillou (stragu) 
 ---
Mike, given your recent work on copy-pasting of cell ranges containing a chart
object, I thought you might be interested in this one. See comment 7.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 45085] VIEWING: Notes/comments are (in most cases) displayed in background of form controls

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45085

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   Priority|low |medium
   Severity|enhancement |normal
Summary|VIEWING: Notes/comments are |VIEWING: Notes/comments are
   |displayed in background of  |(in most cases) displayed
   |FORMCONTROLS (when not in   |in background of form
   |Design mode)|controls

--- Comment #18 from Stéphane Guillou (stragu) 
 ---
Arranging the comments to front and the control to back has no effect.

And it is inconsistent:

+-++---+
| Design mode | Comments shown | Popup comment |
+-++---+
| On  | Behind | Above |
| Off | Behind | Behind|
+-++---+

3 duplicates here, various comments on the AOO bug report also contesting the
"won't fix" decision, and UX agreeing that it needs fixing in bug 150592
comment 5.

So I am setting it back to bug instead of enhancement, as (on top of the above)
I can't see a reason why anyone would like or expect the current behaviour (at
least as a default).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160040] status bar labels mostly hidden in RTL UI

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160040

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=83
   ||350

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 83350] RTL: Status bar fields aligned to the left

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=83350

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=16
   ||0040
   Hardware|Other   |All

--- Comment #11 from Stéphane Guillou (stragu) 
 ---
(In reply to BogdanB from comment #9)
> Created attachment 191322 [details]
> screenshot
> 
> Everything seems worse in the status bar in RTL.
Saw the same, I reported this 7.4 regression in bug 160040.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160040] status bar labels mostly hidden in RTL UI

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160040

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

  Regression By||Luboš Luňák
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 129661] [META] Right-To-Left (RTL) user interface issues

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129661

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||160040


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160040
[Bug 160040] status bar labels mostly hidden in RTL UI
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160040] New: status bar labels mostly hidden in RTL UI

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160040

Bug ID: 160040
   Summary: status bar labels mostly hidden in RTL UI
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: bibisected, bisected, regression
  Severity: normal
  Priority: high
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: stephane.guil...@libreoffice.org
Blocks: 86066, 129661

Created attachment 192955
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192955=edit
Screenshot on Ubuntu 22.04 + GNOME 42.9, gtk3 VCL plugin

Since LO 7.4, the status bar in RTL UI displays only the very end of various
strings.

To test:
- On Linux:
SAL_RTL_ENABLED=1 path-to/soffice

- On Windows:
SET SAL_RTL_ENABLED=1
path-to/soffice.exe

All components affected.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: e939685f9c6918830bd3097062790bfccbce937e
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

...and gen VCL plugin too, and win:

Version: 7.6.5.2 (X86_64) / LibreOffice Community
Build ID: 38d5f62f85355c192ef5f1dd47c5c0c0c6d6598b
CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

Bibisected with linux-64-7.4 repo to first bad build
[71b903398dd76deab2aae5c1df309b6f2b36fac1] which points to:

commit  22191901bc91535121a5e8dc7ee6137233824d36
author  Luboš Luňák Tue May 03 14:02:12 2022 +0200
committer   Luboš Luňák Wed May 04 05:59:07 2022 +0200
do not allow reusing already used SalLayoutGlyphs (tdf#148477)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133758

Luboš is not active anymore, upping the importance.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=86066
[Bug 86066] [META] Bugs and improvements to the statusbar
https://bugs.documentfoundation.org/show_bug.cgi?id=129661
[Bug 129661] [META] Right-To-Left (RTL) user interface issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 86066] [META] Bugs and improvements to the statusbar

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=86066

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||160040


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160040
[Bug 160040] status bar labels mostly hidden in RTL UI
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160039] New: Base does not show SQLException error messages

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160039

Bug ID: 160039
   Summary: Base does not show SQLException error messages
   Product: LibreOffice
   Version: 7.3.2.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: prrv...@gmail.com

Description:
The jdbcDriverOOo[1] driver allows you to rename table columns.
If a column is part of a view then it is possible that the underlying driver
generates an exception during the SQL command allowing the column to be
renamed.

The UNO interface used to perform column renaming is
com.sun.star.sdbcx.XAlterTable and handles com.sun.star.sdbc.SQLException.

Wouldn't it be possible to display the SQLException message generated by the
underlying driver, in order to keep the user aware of the underlying problems?

Steps to Reproduce:
1. Install jdbcDriverOOo[1] extension
2. Trying to rename a column that is part of a view.
3. The command will fail silently.

Actual Results:
The command cannot be executed but no error message appears to the user.

Expected Results:
The command cannot be executed but an error message explains the reason to the
user.



Reproducible: Always


User Profile Reset: No

Additional Info:
[1] https://prrvchr.github.io/jdbcDriverOOo/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160038] VBA Compatibility:VBA functions in protected libraries don't work

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160038

--- Comment #1 from Saburo  ---
Created attachment 192954
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192954=edit
samplefile

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160038] New: VBA Compatibility:VBA functions in protected libraries don't work

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160038

Bug ID: 160038
   Summary: VBA Compatibility:VBA functions in protected libraries
don't work
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: yosi3260+li...@gmail.com

Description:
Works when library is unprotected, but not when protected
ex. Round function

Steps to Reproduce:
1.Open attached file
2.Tools > Macros >  Run Macro
3.attached file > Library1 > Module1 - Main run

Actual Results:
BASIC runtime error.

Expected Results:
Run Macro  like an unprotected library.


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.2.0.3 (x86) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: ja-JP (ja_JP); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160037] New: General Input/Output Error when saving document

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160037

Bug ID: 160037
   Summary: General Input/Output Error when saving document
   Product: LibreOffice
   Version: 7.4.7.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: suokunl...@126.com

Created attachment 192953
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192953=edit
ioerror.ods

Steps to Reproduce:
1. Open the attached document.
2. Select cell range B2:D313605, Sheet > Fill Cells > Fill Random Number, use
the default Uniform distribution, click OK.
3. Save.

--> General Input/Output Error

Reproduced on

Version: 7.4.7.0.0+ / LibreOffice Community
Build ID: 1b33ec542c1a584f0eb2a1df662fc1bfcac2e012
CPU threads: 8; OS: Linux 6.7; UI render: default; VCL: gtk3
Locale: zh-CN (zh_CN.UTF-8); UI: en-US
Calc: threaded

Also on today's master builds.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159251] After using the navigator w/rtl user interface, text is garbled during selection / after hovering

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159251

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #22 from Stéphane Guillou (stragu) 
 ---
Thank you Khaled! Fix verified in:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: e939685f9c6918830bd3097062790bfccbce937e
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159779] Monospaced ligatures intermingle with Arabic text

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159779

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159380] close all (documents / windows) Writer

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159380

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 159682] The first 500 pages are instantly shown, the other 1000 are added incrementally

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159682

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159777] A11Y sidebar: No warning about paragraph DF used

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159777

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159592] Permanent items in styles dropdown have irregular formatting

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159592

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159380] close all (documents / windows) Writer

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159380

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159380] close all (documents / windows) Writer

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159380

--- Comment #8 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 156519] Dates for the year 2000 do not format correctly when entered as xx/xx/2000

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156519

--- Comment #6 from QA Administrators  ---
Dear Bob Steen,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156519] Dates for the year 2000 do not format correctly when entered as xx/xx/2000

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156519

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159380] close all (documents / windows) Writer

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159380

--- Comment #8 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 155838] PDF Conversion Removing Dropdown and Checkbox Input values

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155838

--- Comment #9 from QA Administrators  ---
Dear Steph,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 146242] calc row highlighting in numbers column misaligned to selected cell (Skia metal)

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146242

--- Comment #16 from QA Administrators  ---
Dear steve,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 135151] Special Paste RTF: Missing image/frames

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135151

--- Comment #7 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 124077] Broken roundtrip (save/load) for impress/draw document including tables

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124077

--- Comment #10 from QA Administrators  ---
Dear Callegar,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 123674] Main entry number in index loses character style after inserting new entry with 1st key

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123674

--- Comment #11 from QA Administrators  ---
Dear Chris Hargrave,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 122716] IMPORT Writer can lose encoding for some multibyte symbols when copy-paste from XLSX/Calc

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122716

--- Comment #9 from QA Administrators  ---
Dear Maxim Britov,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 100643] Numbering of rows in tables changes on horizontal split of neighbouring cells

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=100643

--- Comment #10 from QA Administrators  ---
Dear andis.lazdins,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160036] New: ACCESSIBILITY: Selection invisible in High Contrast mode with SKIA/Raster

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160036

Bug ID: 160036
   Summary: ACCESSIBILITY: Selection invisible in High Contrast
mode with SKIA/Raster
   Product: LibreOffice
   Version: 24.2.0.2 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: saywel...@gmail.com

Created attachment 192952
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192952=edit
Comparison screenshots of Calc and Writer from 24.2 and 7.6.3.2

In 24.2.0.2 and also 24.1.2, with a new user profile, in Options select in View
*Force Skia software rendering* and in Accessibility select *High Contrast
mode*

Result: There is no highlight for selection and you cannot tell what has been
selected. In Calc the blue highlight in the row and column headers is visible
but the actual cell has no special selection border. In Writer the selected
text looks identical to unselected text.

Compare to LibreOffice 7.6.3.2 where there is a heavy black outline for the
selected Calc cell and in Writer the selected text has reversed colour. 

See attached image for comparison between the two versions.

Arisen in question
https://ask.libreoffice.org/t/24-2-1-selected-text-cells-not-highlighted-in-windows-10-high-contrast-mode/102965

Version: 24.2.1.2 (X86_64) / LibreOffice Community
Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac
CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-NZ (en_NZ); UI: en-GB
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 45085] VIEWING: Notes/comments are displayed in background of FORMCONTROLS (when not in Design mode)

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45085

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   Hardware|x86 (IA32)  |All
Summary|VIEWING: Notes/comments are |VIEWING: Notes/comments are
   |displayed in background of  |displayed in background of
   |FORMCONTROLS|FORMCONTROLS (when not in
   ||Design mode)
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #17 from Stéphane Guillou (stragu) 
 ---
(In reply to Wolfgang Jäger from comment #14)
> Result: 
> 1. This bug is resolved for annotations created with 7.5.
Are you sure you tested with Design Mode turned off? (Tools > Forms > Design
Mode)
I tested with 24.2.1 and can still reproduce from scratch.

Version: 24.2.1.1 (X86_64) / LibreOffice Community
Build ID: 359ef544e625d2ffbfced462ab37bd593ca85fa7
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 45085] VIEWING: Notes/comments are displayed in background of FORMCONTROLS

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45085

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||that.man.co...@gmail.com

--- Comment #16 from Stéphane Guillou (stragu) 
 ---
*** Bug 159994 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159994] comments do not place themselves in front of adjacent objects

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159994

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #8 from Stéphane Guillou (stragu) 
 ---
Thanks for the report. I can reproduce the issue with the sample file in OOo
3.3, as well as in a recent trunk build:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: e939685f9c6918830bd3097062790bfccbce937e
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

(In reply to m_a_riosv from comment #7)
> Seems changing the 'Arrange' for the shape on O6 solves the issue.
I believe that if you exit Design mode again, the comment will still pop behind
the form controls.

This is already tracked in bug 45085, so I am marking as duplicate.

*** This bug has been marked as a duplicate of bug 45085 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 45085] VIEWING: Notes/comments are displayed in background of FORMCONTROLS

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45085

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=15 |
   |0592|
 CC||ovari...@zoho.com

--- Comment #15 from Stéphane Guillou (stragu) 
 ---
*** Bug 150592 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 101216] [META] Calc comment bugs and enhancements

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101216

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on|150592  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=150592
[Bug 150592] Comments should be shown over all form controls (eg push button)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 150592] Comments should be shown over all form controls (eg push button)

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150592

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=45 |
   |085 |
 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED
 Blocks|101216  |

--- Comment #7 from Stéphane Guillou (stragu) 
 ---
Same issue as in bug 45085. Let's mark as duplicate.

*** This bug has been marked as a duplicate of bug 45085 ***


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101216
[Bug 101216] [META] Calc comment bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159808] Date and Time field variants should be named "fixed" instead of "fix"

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159808

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
Help fix is in gerrit: https://gerrit.libreoffice.org/c/help/+/164378

We still need:
- dedicated pages for the two variable UNO commands
- link to them in e.g.
https://opengrok.libreoffice.org/xref/help/source/text/swriter/02/1904.xhp
or
https://opengrok.libreoffice.org/xref/help/source/text/swriter/02/1803.xhp
(this page is duplicated, see bug 160035)
- list them in https://opengrok.libreoffice.org/xref/help/helpers/unocmds.txt,
with:
  * .uno:InsertDateFieldVar;swriter/...
  * .uno:InsertTimeFieldVar;swriter/...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 113969] [META] Bugs to reduce localization efforts by translators

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113969

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||160035


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160035
[Bug 160035] duplicated help page for .uno:InsertFieldCtrl
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 106040] [META] Help bugs and enhancements

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106040

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||160035


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160035
[Bug 160035] duplicated help page for .uno:InsertFieldCtrl
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160035] New: duplicated help page for .uno:InsertFieldCtrl

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160035

Bug ID: 160035
   Summary: duplicated help page for .uno:InsertFieldCtrl
   Product: LibreOffice
   Version: 24.2.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: stephane.guil...@libreoffice.org
CC: olivier.hal...@libreoffice.org
Blocks: 106040, 113969

We have two pages for the same toolbar split button for inserting fields:
-
https://opengrok.libreoffice.org/xref/help/source/text/swriter/02/1803.xhp
(which is actually linked to the UNO command) online at
https://help.libreoffice.org/latest/en-US/text/swriter/02/1803.html
-
https://opengrok.libreoffice.org/xref/help/source/text/swriter/02/1904.xhp
(which is not linked to the UNO command), online at
https://help.libreoffice.org/latest/en-US/text/swriter/02/1904.html

One needs to disappear, making sure all existing links to it are redirected to
the surviving one.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106040
[Bug 106040] [META] Help bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113969
[Bug 113969] [META] Bugs to reduce localization efforts by translators
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 115610] print range: "rows/columns to repeat" does not conform to the specification (xlsx files)

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115610

Andreas Heinisch  changed:

   What|Removed |Added

 CC||andreas.heini...@yahoo.de

--- Comment #13 from Andreas Heinisch  ---
Imho, openpyxl writes Sheet!1:2 whereas Excel saves Sheet!$1:$2.

Maybe generating it using the following line does the trick?
  ws.print_title_rows = '$1:$1' # the first row

Should we add the missing absolute reference to the values delievered by
openpyxl or close it with NOTOURBUG?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160029] LibreOffice Writer cannot save/load round-trip a particular bullet style.

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160029

--- Comment #5 from Rafael Lima  ---
Also present in

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b0791dd9216224bdb266fd0d8c87df253b6d0583
CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 103369] [META] Bullet, numbered, and outline list bugs and enhancements

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103369

Rafael Lima  changed:

   What|Removed |Added

 Depends on||160029


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160029
[Bug 160029] LibreOffice Writer cannot save/load round-trip a particular bullet
style.
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160029] LibreOffice Writer cannot save/load round-trip a particular bullet style.

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160029

Rafael Lima  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Blocks||103369
 Status|UNCONFIRMED |NEW

--- Comment #4 from Rafael Lima  ---
I can reproduce the issue in

Version: 7.6.5.2 (X86_64) / LibreOffice Community
Build ID: 60(Build:2)
CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Ubuntu package version: 4:7.6.5-0ubuntu0.23.10.1
Calc: threaded

Saving and reopening the file will lose the applied formatting.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103369
[Bug 103369] [META] Bullet, numbered, and outline list bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 139552] Crash with button "Add more galleries via extension"

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139552

Matt K  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #3 from Matt K  ---
(In reply to Tex2002ans from comment #2)
> NO CRASH in:

Also no crash in:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: fc9c15ec702d8a06e8747ee5b858751e5a90e30a
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

Setting to NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 95193] Wrong bookmarks in Impress PDF export with notes pages, notes not bookmarked but slides bookmarks doubled

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=95193

Rafael Lima  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9821

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 103378] [META] PDF export bugs and enhancements

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103378

Rafael Lima  changed:

   What|Removed |Added

 Depends on||159821


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=159821
[Bug 159821] Bookmarks broken when selection of slides are exported to PDF
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159821] Bookmarks broken when selection of slides are exported to PDF

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159821

Rafael Lima  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=95
   ||193
 Blocks||103378


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103378
[Bug 103378] [META] PDF export bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 138367] Direct PDF export crashes LO Writer when the program window isn't in fullscreen

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138367

Matt K  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #9 from Matt K  ---
(In reply to info from comment #8)
> Mac OSx 12.4 with LibraOffice 7.3.2.2
> 
> Export as PDF crashes every time - I can select the folder to save in, but
> when I hit save, goes into the document recovery interface. I tried turning
> off all the toolbars etc, and still same problem.
> 
> However, for me the Export Direct to PDF does not crash. 
> 
> Not sure if this is the same bug, but it's related.

I'm not able to repro any crash using either "Export as PDF" or "Direct export
to PDF"(notebookbar).

Using:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: fc9c15ec702d8a06e8747ee5b858751e5a90e30a
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

Setting to NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 140394] There should be a warning, if print range would exceed the maximum number of rows

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140394

--- Comment #8 from Andreas Heinisch  ---
Should unify the two dialogs or just check the range and show an error message
as a tooltip like comment 4 suggests?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 140394] There should be a warning, if print range would exceed the maximum number of rows

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140394

--- Comment #7 from Andreas Heinisch  ---
Created attachment 192951
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192951=edit
Manage Names error message

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 140394] There should be a warning, if print range would exceed the maximum number of rows

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140394

Andreas Heinisch  changed:

   What|Removed |Added

 CC||andreas.heini...@yahoo.de

--- Comment #6 from Andreas Heinisch  ---
Created attachment 192950
  --> https://bugs.documentfoundation.org/attachment.cgi?id=192950=edit
Edit print ranges dialog error message

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 138230] I tried to open a web site pdf in Libre Office and Libre Office crashed.

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138230

Matt K  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #9 from Matt K  ---
(In reply to Tex2002ans from comment #8)
> The PDF opened okay for me in Draw:
The PDF opened okay for me in Draw too using:

Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

Setting to NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159821] Bookmarks broken when selection of slides are exported to PDF

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159821

DuyN  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #1 from DuyN  ---
Thank you for reporting the bug. I can confirm that the bug is present in:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: e939685f9c6918830bd3097062790bfccbce937e
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 148170] Calc: setting print range with the whole column not remember in XLS/X

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148170

Andreas Heinisch  changed:

   What|Removed |Added

   Assignee|andreas.heini...@yahoo.de   |libreoffice-b...@lists.free
   ||desktop.org
 Status|ASSIGNED|NEW

--- Comment #9 from Andreas Heinisch  ---
So I checked the implementation and the only way to solve this is to change the
address of the form $A$1:$A$1048576 to the form $Sheet1.$A:$A

This can be done using the ScCompiler for the print range dialog. However,
under print ranges -> define it already selects the correct range without the
ScCompiler. Hence, the compiler doesn't reduce the address to the form
$Sheet1.$A:$A. 

I could not find the other way round (creating a reduced ScRange).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160011] Hidden columns should not prevent text from preceding columns from overflowing over their cells

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160011

--- Comment #5 from ady  ---
FWIW, Google Sheets has 3 "wrap text" settings for each cell:

* The usual wrap text that we know in Calc and other spreadsheet tools.
* Clip.
* Text overflow.

I have not been able to reproduce the request from comment 0 with any of these
3 settings in GSheets. They only react differently when the adjacent cell is
empty.

Additionally, these 3 wrapping options are independent of the alignment for the
cell, at least in terms of the available icons in the toolbar. I have not
tested each possible combination to see their respective results.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160011] Hidden columns should not prevent text from preceding columns from overflowing over their cells

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160011

--- Comment #4 from ady  ---
Perhaps this should not be an "automatic" reaction. A manual setting could
possibly achieve the visual effect, meaning "do not clip" (whichever the
potential normal clipping would be in each case), and instead, leave the
content to overflow.

IOW, a setting to disable the clip, for each cell. This visual setting would
not be reactive, depending on the content of the adjacent cells, but rather an
ON/OFF toggle. I am not sure whether there would be some potential third
alternative (and based on what? Based on the adjacent cell being empty?).

By avoiding the "automatic" part of the request, the reaction would not be (so)
"volatile".

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160011] Hidden columns should not prevent text from preceding columns from overflowing over their cells

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160011

--- Comment #3 from ady  ---
(In reply to Dan Dascalescu from comment #2)

> If you mean hidden columns are used to force text clipping in cells instead
> of overflowing, that's a dubious practice

Why is that dubious? Are you saying that other spreadsheet tools have been
doing it differently during the last 3 decades? Please clarify by sharing
examples of such tools (with versions please).


>  LibreCalc should have a
> "Clip" option under Format Cells -> Alignment -> Properties.

@Dan,

While I think your request is worth a discussion, let's not mix things. Your
request is about a visual behavior, but it is not really an alignment setting
for the cell.

It is still possible that some other spreadsheet tool has this kind of setting
and that it calls this an "alignment" alternative. It would be helpful to have
specific examples of such tools.

The cell could be, say, centered, and still have some kind of overflow, exactly
as you described.

Moreover, if a "clipped" overflow would be some kind of cell attribute, what
would be the possible other ("non-clipped") settings? Depending on alignment
and content, you could have clipped overflow on one side of the cell, or the
other, or both, or none (and for each case, we have several possible
alignments).

Now, assuming this kind of visual re-fresh would happen as you request, I would
be concerned about its performance consequences. Changing one cell (or an
entire column, as you described in comment 0) would affect another column (not
only the adjacent ones), even when the affected columns would have unrelated
content (e.g. formulas that don't relate these columns in any way). That sounds
similar to volatile formulas, and such scenario is expensive (i.e. can have
negative performance consequences).

To sum up: worth a discussion; not yet convinced; visual behavior; not
necessarily an alignment setting (but related in its influence on the visual
result); an example of some other spreadsheet tool with this behavior/setting
would help.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 49602] Remove deprecated OSL Profile functionality

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=49602

--- Comment #14 from seturajmatr...@gmail.com ---
Does it even reach that point?
As when I tried to run it in full debug mode and added breakpoints to the
profile , it never hit that line.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: cui/source cui/uiconfig editeng/source include/editeng include/unotools include/xmloff offapi/com offapi/UnoApi_offapi.mk svx/sdi sw/CppunitTest_sw_odfexport2.mk sw/inc sw/qa sw/source xmlof

2024-03-04 Thread László Németh (via logerrit)
 cui/source/inc/paragrph.hxx   |5 
 cui/source/tabpages/paragrph.cxx  |   37 -
 cui/uiconfig/ui/textflowpage.ui   |  100 --
 editeng/source/items/paraitem.cxx |   32 
 include/editeng/editrids.hrc  |5 
 include/editeng/hyphenzoneitem.hxx|4 
 include/editeng/memberids.h   |1 
 include/unotools/linguprops.hxx   |2 
 include/xmloff/xmltypes.hxx   |1 
 offapi/UnoApi_offapi.mk   |1 
 offapi/com/sun/star/style/ParagraphProperties.idl |8 +
 offapi/com/sun/star/text/ParagraphHyphenationKeepType.idl |   63 
 svx/sdi/svxitems.sdi  |1 
 sw/CppunitTest_sw_odfexport2.mk   |1 
 sw/inc/inspectorproperties.hrc|1 
 sw/inc/unoprnms.hxx   |1 
 sw/qa/extras/odfexport/data/tdf132599_auto.fodt   |   49 ++
 sw/qa/extras/odfexport/data/tdf132599_page.fodt   |   49 ++
 sw/qa/extras/odfexport/odfexport2.cxx |   27 +++
 sw/qa/uitest/styleInspector/styleInspector.py |   20 +-
 sw/qa/uitest/styleInspector/tdf137513.py  |2 
 sw/source/core/text/inftxt.cxx|   16 +-
 sw/source/core/text/itrform2.cxx  |1 
 sw/source/core/text/porlay.hxx|3 
 sw/source/core/text/widorp.cxx|   42 +
 sw/source/core/unocore/unomapproperties.hxx   |2 
 sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx |1 
 xmloff/inc/xmlprop.hxx|1 
 xmloff/source/text/txtprhdl.cxx   |   13 +
 xmloff/source/text/txtprmap.cxx   |1 
 30 files changed, 423 insertions(+), 67 deletions(-)

New commits:
commit 9574a62add8e4901405e12117e75c86c2d2c2f21
Author: László Németh 
AuthorDate: Thu Feb 29 14:07:34 2024 +0100
Commit: László Németh 
CommitDate: Mon Mar 4 23:39:51 2024 +0100

tdf#132599 cui offapi sw xmloff: implement hyphenate-keep

Both parts of a hyphenated word shall lie within a single
page with ODF paragraph setting fo:hyphenation-keep="page".
The implementation follows the default page layout of
MSO 2016 and newer by shifting the bottom hyphenated line
to the next page (and to the next column, see last note).

Note: this is a MSO DOCX interoperability feature, used
also in DTP software, XSL and CSS.

* Add checkbox/combobox to Text Flow in paragraph dialog
* Store property in paragraph model 
(com::sun::star::style::ParagraphProperties::ParaHyphenationKeep)
* Add ODF import/export
* Add ODF unit tests

New constants of com::sun::star::text::ParagraphHyphenationKeepType,
containing ODF AUTO and PAGE (borrowed from XSL), and for the
planned extension ParaHyphenationKeepType of ParagraphProperties:

– COLUMN (standard XSL value, defined in
  https://www.w3.org/TR/2001/REC-xsl-20011015/slice7.html#hyphenation-keep)

– SPREAD and ALWAYS (CSS 4 values of hyphenate-limit-last,
  equivalent of hyphenation-keep, defined in
  https://www.w3.org/TR/css-text-4/#hyphenate-line-limits).

Note: the implementation truncates only a single hyphenated
line, like MSO does: the pages can end in hyphenated
lines (i.e. in the case of consecutive hyphenated lines),
but less often, than before.

Clean-up hyphenation dialog by collecting "Don't hyphenate"
options at the end of the hyphenation settings, and negating them
(similar to MSO and DTP), adding also the new option
"Hyphenate across column and page":

[x] Hyphenate words in CAPS
[x] Hyphenate last word
[x] Hyphenate across column and page

Note: ODF fo:hyphenation-keep has got only "auto" and
"page" attributes, while XSL defines also "column".
Because of the interoperability with MSO and DTP,
fo:hyphenation-keep="page" is interpreted as
XSL "column", avoiding hyphenation at the end
of column, not only at the end of page.

Change-Id: I5c6b7adc0671a5a790568e7bf1d33256e607f85f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164158
Tested-by: László Németh 
Reviewed-by: László Németh 

diff --git a/cui/source/inc/paragrph.hxx b/cui/source/inc/paragrph.hxx
index 9e78c8311015..0972203be73f 100644
--- a/cui/source/inc/paragrph.hxx
+++ b/cui/source/inc/paragrph.hxx
@@ -223,6 +223,7 @@ private:
 weld::TriStateEnabled aKeepParaState;
 weld::TriStateEnabled aOrphanState;
 weld::TriStateEnabled aWidowState;
+weld::TriStateEnabled aKeepState;
 
 

[Bug 160034] New: Cant' paste file name into save dialog with command-v

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160034

Bug ID: 160034
   Summary: Cant' paste file name into save dialog with command-v
   Product: LibreOffice
   Version: 24.2.1.2 release
  Hardware: x86-64 (AMD64)
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: es...@ieee.org

It simple. Copy some text.
Click on save
type command-v (on mac)
nothing happens
Rt-click in file name field
click paste
the text on the clipboard is pasted

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159254] Paper tray settings ignored in rtf and docx import

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159254

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9793

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 103304] [META] Page style dialog bugs and enhancements

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103304
Bug 103304 depends on bug 159793, which changed state.

Bug 159793 Summary: Paper tray settings not saved in RTF and DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=159793

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 134397] Crash dragging an image in a certain position

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134397

Matt K  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #15 from Matt K  ---
(In reply to Tex2002ans from comment #14)

No crash using:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: fc9c15ec702d8a06e8747ee5b858751e5a90e30a
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

Setting NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159931] Exported pptx cannot be opened in PowerPoint because a referenced part does not exist

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159931

--- Comment #3 from Balázs Varga (allotropia)  ---
(In reply to Aron Budea from comment #2)
> I bibisected the change when 'slideLayout0.xml' first exists in the unzipped
> output PPTX using repo bibisect-linux-64-24.2 (haven't tested the result in
> PP), and it is the 24.2 backport of the following commit. Adding CC: to
> Balazs Varga.
> 
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=bff76421e234df7246a7f49c71a11432f86e09d1
> authorBalazs Varga 
> 2023-12-03 23:41:01
> +0100
> committer Balazs Varga 
> 2023-12-18
> 15:10:54 +0100
> 
> tdf#157740 FILESAVE PPTX: fix explosion of the number of master slides

Will take a look at tmr. Thanks for the bibisect and infos.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 150443] Track changes: Crash rejecting a grouped change

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150443

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.5.0 target:7.4.1   |target:7.5.0 target:7.4.1
   ||target:24.8.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sw/qa

2024-03-04 Thread Xisco Fauli (via logerrit)
 sw/qa/uitest/data/tdf150443.docx|binary
 sw/qa/uitest/writer_tests8/tdf150443.py |4 +---
 2 files changed, 1 insertion(+), 3 deletions(-)

New commits:
commit 2eba8bb8d43d39eb229a81947907e70f50859a76
Author: Xisco Fauli 
AuthorDate: Mon Mar 4 17:40:48 2024 +0100
Commit: Xisco Fauli 
CommitDate: Mon Mar 4 22:46:36 2024 +0100

tdf#150443: replace missing fonts in testfile

This commit reverts 0b21e2a404c114529376dc50764dc0286dafc745
"sw: UITest_writer_tests8 test_tdf150443 more tolerant"

Change-Id: If83a7b0a8dc2289aba3201edfdf19d0ca839459a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164392
Tested-by: Xisco Fauli 
Reviewed-by: Xisco Fauli 
Tested-by: Jenkins

diff --git a/sw/qa/uitest/data/tdf150443.docx b/sw/qa/uitest/data/tdf150443.docx
index 162aec01f928..f1897c4712aa 100644
Binary files a/sw/qa/uitest/data/tdf150443.docx and 
b/sw/qa/uitest/data/tdf150443.docx differ
diff --git a/sw/qa/uitest/writer_tests8/tdf150443.py 
b/sw/qa/uitest/writer_tests8/tdf150443.py
index 1dbb74b58918..fb39bd8a0375 100644
--- a/sw/qa/uitest/writer_tests8/tdf150443.py
+++ b/sw/qa/uitest/writer_tests8/tdf150443.py
@@ -26,9 +26,7 @@ class tdf150443(UITestCase):
 xsearch = xDialog.getChild("search")
 xsearch.executeAction("CLICK", tuple())  #first search
 xToolkit.processEventsToIdle()
-page = get_state_as_dict(xWriterEdit)["CurrentPage"]
-# page may depend on font substitution, just check it moved
-self.assertTrue(page == "4" or page == "5")
+
self.assertEqual(get_state_as_dict(xWriterEdit)["CurrentPage"], "4")
 
 # reject the tracked table row in Manage Changes dialog window
 with 
self.ui_test.execute_modeless_dialog_through_command(".uno:AcceptTrackedChanges",
 close_button="close") as xTrackDlg:


[Bug 159994] comments do not place themselves in front of adjacent objects

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159994

--- Comment #7 from m_a_riosv  ---
Seems changing the 'Arrange' for the shape on O6 solves the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160011] Hidden columns should not prevent text from preceding columns from overflowing over their cells

2024-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160011

--- Comment #2 from Dan Dascalescu  ---
(In reply to m_a_riosv from comment #1)
> I'm not for change the behavior, it is right as it is.
> The change breaks the way it works now, perhaps used on purpose.

Can you clarify that please?

If you mean hidden columns are used to force text clipping in cells instead of
overflowing, that's a dubious practice, and LibreCalc should have a "Clip"
option under Format Cells -> Alignment -> Properties.

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   3   4   >