[Bug 157031] Character dialog opens with small but annoying lag (3 seconds) every time when opening (macOS)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157031

--- Comment #7 from sneakers-the-...@protonmail.com ---
haha yes i knew that having a disgusting quantity of fonts installed would be
useful one day. it's definitely `fontd` that's spinning, as the window becomes
unresponsive, fontd spikes, and then the window becomes responsive again as
soon as fontd relaxes. 

i shall do a bisect another night, can't look at computer anymore tonight <3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160295] Positioning jumps upon marking an image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160295

raal  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #5 from raal  ---
(In reply to Jens-D Doll from comment #3)
> You need an image on first page and an image on second. Then scroll and then
> click.

Yes, I do it. Please test it with newer version. If the bug still occurs,
attach test file. Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: vcl/inc vcl/source

[Tomaž Vajngerl (via logerrit)]

 vcl/inc/impgraph.hxx|   13 +++---
 vcl/source/gdi/impgraph.cxx |   92 +---
 2 files changed, 35 insertions(+), 70 deletions(-)

New commits:
commit 4dd52211794adc7da2c19cb3defcdef16985c278
Author: Tomaž Vajngerl 
AuthorDate: Tue Mar 12 12:07:33 2024 +0900
Commit: Tomaž Vajngerl 
CommitDate: Fri Mar 22 05:50:07 2024 +0100

vcl: simplify constructors of ImpGraphic

Change-Id: I6df0da16d777549e6187327271868774498d073b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164694
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/vcl/inc/impgraph.hxx b/vcl/inc/impgraph.hxx
index 15d68d00157c..9ef10d19061d 100644
--- a/vcl/inc/impgraph.hxx
+++ b/vcl/inc/impgraph.hxx
@@ -73,19 +73,20 @@ private:
 std::shared_ptr mpContext;
 std::shared_ptr mpSwapFile;
 std::shared_ptr mpGfxLink;
-GraphicType  meType;
-mutable sal_uLongmnSizeBytes;
-bool mbSwapOut;
-bool mbDummyContext;
 std::shared_ptr maVectorGraphicData;
+
+GraphicType  meType = GraphicType::NONE;
+mutable sal_uLongmnSizeBytes = 0;
+bool mbSwapOut = false;
+bool mbDummyContext = false;
 // cache checksum computation
 mutable BitmapChecksum   mnChecksum = 0;
 
 std::optional mxGraphicID;
 GraphicExternalLink  maGraphicExternalLink;
 
-std::chrono::high_resolution_clock::time_point maLastUsed;
-bool mbPrepared;
+mutable std::chrono::high_resolution_clock::time_point maLastUsed = 
std::chrono::high_resolution_clock::now();
+bool mbPrepared = false;
 
 public:
 ImpGraphic();
diff --git a/vcl/source/gdi/impgraph.cxx b/vcl/source/gdi/impgraph.cxx
index 7150aab6b0e6..2c9f03f3a02e 100644
--- a/vcl/source/gdi/impgraph.cxx
+++ b/vcl/source/gdi/impgraph.cxx
@@ -81,13 +81,7 @@ SvStream* ImpGraphic::getSwapFileStream() const
 return nullptr;
 }
 
-ImpGraphic::ImpGraphic() :
-meType  ( GraphicType::NONE ),
-mnSizeBytes ( 0 ),
-mbSwapOut   ( false ),
-mbDummyContext  ( false ),
-maLastUsed (std::chrono::high_resolution_clock::now()),
-mbPrepared  ( false )
+ImpGraphic::ImpGraphic()
 {
 }
 
@@ -98,18 +92,18 @@ ImpGraphic::ImpGraphic(const ImpGraphic& rImpGraphic)
 , mpContext(rImpGraphic.mpContext)
 , mpSwapFile(rImpGraphic.mpSwapFile)
 , mpGfxLink(rImpGraphic.mpGfxLink)
+, maVectorGraphicData(rImpGraphic.maVectorGraphicData)
 , meType(rImpGraphic.meType)
 , mnSizeBytes(rImpGraphic.mnSizeBytes)
 , mbSwapOut(rImpGraphic.mbSwapOut)
 , mbDummyContext(rImpGraphic.mbDummyContext)
-, maVectorGraphicData(rImpGraphic.maVectorGraphicData)
 , maGraphicExternalLink(rImpGraphic.maGraphicExternalLink)
-, maLastUsed (std::chrono::high_resolution_clock::now())
-, mbPrepared (rImpGraphic.mbPrepared)
+, mbPrepared(rImpGraphic.mbPrepared)
 {
-if( rImpGraphic.mpAnimation )
+// Special case for animations
+if (rImpGraphic.mpAnimation)
 {
-mpAnimation = std::make_unique( *rImpGraphic.mpAnimation );
+mpAnimation = std::make_unique(*rImpGraphic.mpAnimation);
 maBitmapEx = mpAnimation->GetBitmapEx();
 }
 }
@@ -122,13 +116,12 @@ ImpGraphic::ImpGraphic(ImpGraphic&& rImpGraphic) noexcept
 , mpContext(std::move(rImpGraphic.mpContext))
 , mpSwapFile(std::move(rImpGraphic.mpSwapFile))
 , mpGfxLink(std::move(rImpGraphic.mpGfxLink))
+, maVectorGraphicData(std::move(rImpGraphic.maVectorGraphicData))
 , meType(rImpGraphic.meType)
 , mnSizeBytes(rImpGraphic.mnSizeBytes)
 , mbSwapOut(rImpGraphic.mbSwapOut)
 , mbDummyContext(rImpGraphic.mbDummyContext)
-, maVectorGraphicData(std::move(rImpGraphic.maVectorGraphicData))
 , maGraphicExternalLink(rImpGraphic.maGraphicExternalLink)
-, maLastUsed (std::chrono::high_resolution_clock::now())
 , mbPrepared (rImpGraphic.mbPrepared)
 {
 rImpGraphic.clear();
@@ -138,11 +131,7 @@ ImpGraphic::ImpGraphic(ImpGraphic&& rImpGraphic) noexcept
 ImpGraphic::ImpGraphic(std::shared_ptr xGfxLink, sal_Int32 nPageIndex)
 : mpGfxLink(std::move(xGfxLink))
 , meType(GraphicType::Bitmap)
-, mnSizeBytes(0)
 , mbSwapOut(true)
-, mbDummyContext(false)
-, maLastUsed (std::chrono::high_resolution_clock::now())
-, mbPrepared (false)
 {
 maSwapInfo.mbIsTransparent = true;
 maSwapInfo.mbIsAlpha = true;
@@ -152,59 +141,34 @@ ImpGraphic::ImpGraphic(std::shared_ptr xGfxLink, 
sal_Int32 nPageIndex)
 maSwapInfo.mnPageIndex = nPageIndex;
 }
 
-ImpGraphic::ImpGraphic(GraphicExternalLink aGraphicExternalLink) :
-meType  ( GraphicType::Default ),
-mnSizeBytes ( 0 ),
-mbSwapOut   ( false ),
-mbDummyContext  ( false ),
-

[Bug 158353] FILEOPEN XLSX Wrong round

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158353

--- Comment #12 from Mike Kaganski  ---
Aha: I already tried to fix the save problem in
https://gerrit.libreoffice.org/c/core/+/151383 ...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160005] Windows installer Online Update component option: description misleading/unclear on role/purpose

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160005

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||sberg@gmail.com,
   ||stephane.guillou@libreoffic
   ||e.org
 Whiteboard| QA:needsComment|

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Stephan, would you mind commenting on this issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160084] Simplify comparison with zero when using basegfx::fTools::* implementation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160084

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #2 from Stéphane Guillou (stragu) 
 ---
Confirmed by Mike on gerrit -> New.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 114983] Unable to make any docked toolbar floating (wayland)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114983

--- Comment #11 from Stéphane Guillou (stragu) 
 ---
wayland-protocols version 1.34 might help with its new protocol
"xdg-toplevel-drag"[1]:

"This protocol enhances regular drag and drop by allowing attaching a
toplevel window to a drag. This can be used to implement e.g. detachable
toolbars and browser tab drag behavior that can be seen in other
platforms."

[1]:
https://lists.freedesktop.org/archives/wayland-devel/2024-March/043537.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 109323] [META] Graphic export bugs and enhancements (jpg, png, eps, tiff, gif ...)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109323

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||160305


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160305
[Bug 160305] Export WebP : does not support transparency
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160305] Export WebP : does not support transparency

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160305

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 OS|Windows (All)   |All
Version|24.2.1.2 release|7.4.0.3 release
 Status|UNCONFIRMED |NEW
 Blocks||109323, 36766
 Ever confirmed|0   |1


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=36766
[Bug 36766] [META] Impress Gradient and Transparency issues
https://bugs.documentfoundation.org/show_bug.cgi?id=109323
[Bug 109323] [META] Graphic export bugs and enhancements (jpg, png, eps, tiff,
gif ...)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 36766] [META] Impress Gradient and Transparency issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=36766

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||160305


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160305
[Bug 160305] Export WebP : does not support transparency
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160305] Export WebP : does not support transparency

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160305

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Created attachment 193235
  --> https://bugs.documentfoundation.org/attachment.cgi?id=193235=edit
sample ODP to export

Reproduced with:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 53c5d570cab036b23f4969b858a648c8f0c24f93
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

And already in 7.4, when WebP was introduced:

Version: 7.4.0.3 / LibreOffice Community
Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 109040] [META] RTF paste special bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109040

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||160303


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160303
[Bug 160303] Table layout loop in complex table structure after paste RTF
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 101280] [META] Layout loops

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101280

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||160303


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160303
[Bug 160303] Table layout loop in complex table structure after paste RTF
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160303] Table layout loop in complex table structure after paste RTF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160303

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Blocks||101280, 109040
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #2 from Stéphane Guillou (stragu) 
 ---
Also on Linux:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 53c5d570cab036b23f4969b858a648c8f0c24f93
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101280
[Bug 101280] [META] Layout loops
https://bugs.documentfoundation.org/show_bug.cgi?id=109040
[Bug 109040] [META] RTF paste special bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 103378] [META] PDF export bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103378
Bug 103378 depends on bug 156437, which changed state.

Bug 156437 Summary: FILEOPEN: PDF opened with incorrect font "DummyName"
https://bugs.documentfoundation.org/show_bug.cgi?id=156437

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160079] difficult to save format in docx files and style display box

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160079

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 148184] FORMATTING create a means to represent an integer as an IP Address

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148184

--- Comment #7 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 160295] Positioning jumps upon marking an image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160295

--- Comment #4 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160275] LibreOffice Calc crashes immediately when trying to use fcitx in the input line under Wayland

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160275

--- Comment #9 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 148184] FORMATTING create a means to represent an integer as an IP Address

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148184

--- Comment #7 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: svl/qa svl/source

[Mike Kaganski (via logerrit)]

 svl/qa/unit/svl.cxx|   20 
 svl/source/numbers/zformat.cxx |2 ++
 2 files changed, 22 insertions(+)

New commits:
commit 805dd6bee49164d9a77de4ea9e0d53b416daca7a
Author: Mike Kaganski 
AuthorDate: Thu Mar 21 22:46:26 2024 +0500
Commit: Mike Kaganski 
CommitDate: Fri Mar 22 04:00:45 2024 +0100

tdf#160306: make sure that SvNumberFormatter agrees with ROUND output

After commit 9eb9083ff2fdaeb96399a0830a4394de4e29ef64 (Use Dragonbox
to implement doubleTo*String*, 2022-02-18), the rounding that is used
in SvNumberFormatter became strictly more correct; however, it now
differed from what ROUND spreadsheet function returned, because the
latter uses rtl_math_round, which calls rtl::math::approxFloor.

To make the visual number representation consistent, this change uses
rtl_math_round in SvNumberformat::ImpGetNumberOutput.

Change-Id: I05b0bed7d3a6c73584a77adbae2835c95be249fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165142
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/svl/qa/unit/svl.cxx b/svl/qa/unit/svl.cxx
index d24729bc7f43..118016de3b68 100644
--- a/svl/qa/unit/svl.cxx
+++ b/svl/qa/unit/svl.cxx
@@ -1995,6 +1995,26 @@ CPPUNIT_TEST_FIXTURE(Test, testLanguageNone)
 CPPUNIT_ASSERT_EQUAL(OUString("dd.mm."), 
pFormat->GetMappedFormatstring(keywords, ldw));
 }
 
+CPPUNIT_TEST_FIXTURE(Test, testTdf160306)
+{
+// Check some cases, where the output of ROUND and of number formatter 
differed
+SvNumberFormatter aFormatter(m_xContext, LANGUAGE_ENGLISH_US);
+sal_uInt32 format = aFormatter.GetEntryKey(u"0.00", LANGUAGE_ENGLISH_US);
+CPPUNIT_ASSERT(format != NUMBERFORMAT_ENTRY_NOT_FOUND);
+OUString output;
+const Color* color;
+aFormatter.GetOutputString(2697.06496, format, output, );
+// Without the fix in place, this would fail with
+// - Expected: 2697.07
+// - Actual  : 2697.06
+CPPUNIT_ASSERT_EQUAL(u"2697.07"_ustr, output);
+aFormatter.GetOutputString(57.3749993, format, output, );
+// Without the fix in place, this would fail with
+// - Expected: 57.38
+// - Actual  : 57.37
+CPPUNIT_ASSERT_EQUAL(u"57.38"_ustr, output);
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(Test);
 
 }
diff --git a/svl/source/numbers/zformat.cxx b/svl/source/numbers/zformat.cxx
index 5977294b0075..db720493943c 100644
--- a/svl/source/numbers/zformat.cxx
+++ b/svl/source/numbers/zformat.cxx
@@ -4415,6 +4415,8 @@ bool SvNumberformat::ImpGetNumberOutput(double fNumber,
 {
 nPrecExp = 0;
 }
+// Make sure that Calc's ROUND and formatted output agree
+fNumber = rtl_math_round(fNumber, rInfo.nCntPost, 
rtl_math_RoundingMode_Corrected);
 if (rInfo.nCntPost) // Decimal places
 {
 if ((rInfo.nCntPost + nPrecExp) > 15 && nPrecExp < 15)

[Bug 136328] [META] DOCX Grouped shape related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136328

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||160307


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160307
[Bug 160307] Cannot place cursor in field/content control/table when a
group-shape wraps behind it
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160307] Cannot place cursor in field/content control/table when a group-shape wraps behind it

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160307

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
 Ever confirmed|0   |1
   Priority|low |medium
 Status|UNCONFIRMED |NEW
 Blocks||136328

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
reproduced in:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 53c5d570cab036b23f4969b858a648c8f0c24f93
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Clicking on text selects Group 9. Deleting Group 9 allows selecting the field.

Attila is not active anymore, so I am upping the priority back to "medium".

(Note I just reported a crash using the same file in bug 160309)


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=136328
[Bug 136328] [META] DOCX Grouped shape related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156603] Crash on opening docx file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156603

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 OS|Windows (All)   |All
   Severity|normal  |critical
 CC||stephane.guillou@libreoffic
   ||e.org
Crash report or||["google_breakpad::Exceptio
crash signature||nHandler::HandlePureVirtual
   ||Call()","SwAnchoredObject::
   ||GetObjRectWithSpaces()
   ||const"]
  Regression By||Attila Bakos
Version|7.5.4.2 release |7.4.0.3 release

--- Comment #9 from Stéphane Guillou (stragu) 
 ---
Repro on Linux with 7.4.0.3 with signature
"SwAnchoredObject::GetObjRectWithSpaces() const":
https://crashreport.libreoffice.org/stats/crash_details/71fb341f-e183-4339-9495-d1b7da48e1c1

However, no crash anymore on Windows nor on Linux.

For all 3 files shared here, crash in master of linux-64-7.4 repo, but no crash
in oldest of linux-64-7.5. So couldn't bibisect any fix.

Can someone else confirm that the files don't crash on opening anymore?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 101280] [META] Layout loops

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101280

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||158281


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=158281
[Bug 158281] Writer does not open DOCX correctly, objects jumbled on first
page, freezes
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158281] Writer does not open DOCX correctly, objects jumbled on first page, freezes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158281

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Blocks||101280
 CC||stephane.guillou@libreoffic
   ||e.org
Summary|Writer does not open DOCX   |Writer does not open DOCX
   |correctly   |correctly, objects jumbled
   ||on first page, freezes
  Regression By||Attila Bakos
   Severity|normal  |major
   Priority|medium  |high

--- Comment #5 from Stéphane Guillou (stragu) 
 ---
Still current in:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 53c5d570cab036b23f4969b858a648c8f0c24f93
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Jumbled objects on first page; freezes, have to kill it to exit. Setting
severity to "major".


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101280
[Bug 101280] [META] Layout loops
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160309] Crash after ungroup - undo - ungroup in SwUndoDelLayFormat::SwUndoDelLayFormat(SwFrameFormat*)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160309

Aron Budea  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||aron.bu...@gmail.com
 Status|UNCONFIRMED |NEW
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||8687,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||9173,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||9546

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160309] Crash after ungroup - undo - ungroup in SwUndoDelLayFormat::SwUndoDelLayFormat(SwFrameFormat*)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160309

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

  Regression By||Attila Bakos

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156603] Crash on opening docx file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156603

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=16
   ||0309

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158281] Writer does not open DOCX correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158281

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=16
   ||0309

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 136328] [META] DOCX Grouped shape related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136328

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||160309


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160309
[Bug 160309] Crash after ungroup - undo - ungroup in
SwUndoDelLayFormat::SwUndoDelLayFormat(SwFrameFormat*)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160309] New: Crash after ungroup - undo - ungroup in SwUndoDelLayFormat::SwUndoDelLayFormat(SwFrameFormat*)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160309

Bug ID: 160309
   Summary: Crash after ungroup - undo - ungroup in
SwUndoDelLayFormat::SwUndoDelLayFormat(SwFrameFormat*)
   Product: LibreOffice
   Version: 7.4.0.3 release
  Hardware: x86-64 (AMD64)
OS: All
Status: UNCONFIRMED
  Keywords: bibisected, bisected, regression
  Severity: critical
  Priority: high
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: stephane.guil...@libreoffice.org
CC: bakos.attilakar...@nisz.hu, nem...@numbertext.org
Blocks: 133092, 136328

Steps:
1. Open attachment 193233
2. Select group 9 (double-click it in Navigator)
3. Ungroup it
4. Undo
5. Ungroup it again

Result: crash

Reproduced in 7.4.0.3 and recent trunk build:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 53c5d570cab036b23f4969b858a648c8f0c24f93
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

* Crash report for 7.6 with signature
"SwUndoDelLayFormat::SwUndoDelLayFormat(SwFrameFormat*)":
https://crashreport.libreoffice.org/stats/crash_details/220fff47-66a6-4bda-9016-46c417caefc3
* Crash report for 24.2, with signature "":
https://crashreport.libreoffice.org/stats/crash_details/7b4074be-3256-4480-8dc4-5c340f213c76

Also crashes on Windows 11 with signature "static SwUndoId
lcl_GetSwUndoId(const class SwFrameFormat *)":
https://crashreport.libreoffice.org/stats/crash_details/269a2e29-083f-4cd7-9a72-939797e40167
Bibisected with linux-64-7.4 repository to first bad build
[0d1ffc14abf43c7830cee6369710d8e63e2fd0ef] which points to
44eef5f494825a26594ba3d50ef1f3211ae73b9b which is a cherrypick of:

commit  1d3d2a995239c3c71432006cb795324c56a0412a
author  Attila Bakos (NISZ) Mon Jun 20 17:27:53 2022 +0200
committer   László Németh   Mon Jul 11 14:09:09 2022 +0200
tdf#148687 tdf#149173 tdf#149546 sw: fix crash with textboxes
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136192

Attila seems inactive, let's up increase the priority.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=133092
[Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=136328
[Bug 136328] [META] DOCX Grouped shape related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 133092] [META] Crash bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=133092

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||160309


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160309
[Bug 160309] Crash after ungroup - undo - ungroup in
SwUndoDelLayFormat::SwUndoDelLayFormat(SwFrameFormat*)
-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: include/vcl vcl/source

[Tomaž Vajngerl (via logerrit)]

 include/vcl/bitmapex.hxx   |1 -
 vcl/source/bitmap/BitmapEx.cxx |   17 ++---
 2 files changed, 6 insertions(+), 12 deletions(-)

New commits:
commit 71efd6046488b952f679936ea1c4a415f4989b18
Author: Tomaž Vajngerl 
AuthorDate: Sun Mar 17 22:46:07 2024 +0900
Commit: Tomaž Vajngerl 
CommitDate: Fri Mar 22 01:48:12 2024 +0100

vcl: remove SetSizePixel from BitmapEx

Makes no sense (and would case serious problems) to set the size
(pixel) from the outside of the BitmapEx.

Change-Id: Iab597f755d45be2380884ec6685d119fcc8b1e98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164946
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/vcl/bitmapex.hxx b/include/vcl/bitmapex.hxx
index aa2684d14b22..b102ced8ba9b 100644
--- a/include/vcl/bitmapex.hxx
+++ b/include/vcl/bitmapex.hxx
@@ -71,7 +71,6 @@ public:
 const AlphaMask &   GetAlphaMask() const { return maAlphaMask; }
 
 const Size& GetSizePixel() const { return maBitmapSize; }
-SAL_DLLPRIVATE void SetSizePixel(const Size& rNewSize);
 
 const Size& GetPrefSize() const { return maBitmap.GetPrefSize(); }
 voidSetPrefSize( const Size& rPrefSize ) { 
maBitmap.SetPrefSize( rPrefSize ); }
diff --git a/vcl/source/bitmap/BitmapEx.cxx b/vcl/source/bitmap/BitmapEx.cxx
index 4246861679e4..87c500272160 100644
--- a/vcl/source/bitmap/BitmapEx.cxx
+++ b/vcl/source/bitmap/BitmapEx.cxx
@@ -63,7 +63,7 @@ BitmapEx::BitmapEx( const BitmapEx& rBitmapEx, Point aSrc, 
Size aSize )
 return;
 
 maBitmap = Bitmap(aSize, rBitmapEx.maBitmap.getPixelFormat());
-SetSizePixel(aSize);
+maBitmapSize = aSize;
 if( rBitmapEx.IsAlpha() )
 maAlphaMask = AlphaMask( aSize );
 
@@ -75,7 +75,7 @@ BitmapEx::BitmapEx( const BitmapEx& rBitmapEx, Point aSrc, 
Size aSize )
 BitmapEx::BitmapEx(Size aSize, vcl::PixelFormat ePixelFormat)
 {
 maBitmap = Bitmap(aSize, ePixelFormat);
-SetSizePixel(aSize);
+maBitmapSize = aSize;
 }
 
 BitmapEx::BitmapEx( const OUString& rIconName )
@@ -251,11 +251,6 @@ BitmapChecksum BitmapEx::GetChecksum() const
 return nCrc;
 }
 
-void BitmapEx::SetSizePixel(const Size& rNewSize)
-{
-maBitmapSize = rNewSize;
-}
-
 bool BitmapEx::Invert()
 {
 bool bRet = false;
@@ -294,7 +289,7 @@ bool BitmapEx::Scale( const double& rScaleX, const double& 
rScaleY, BmpScaleFlag
 maAlphaMask.Scale( rScaleX, rScaleY, nScaleFlag );
 }
 
-SetSizePixel(maBitmap.GetSizePixel());
+maBitmapSize = maBitmap.GetSizePixel();
 
 SAL_WARN_IF( !maAlphaMask.IsEmpty() && maBitmap.GetSizePixel() != 
maAlphaMask.GetSizePixel(), "vcl",
 "BitmapEx::Scale(): size mismatch for bitmap and alpha 
mask." );
@@ -352,7 +347,7 @@ bool BitmapEx::Rotate( Degree10 nAngle10, const Color& 
rFillColor )
 maAlphaMask.Rotate( nAngle10, COL_ALPHA_TRANSPARENT );
 }
 
-SetSizePixel(maBitmap.GetSizePixel());
+maBitmapSize = maBitmap.GetSizePixel();
 
 SAL_WARN_IF(!maAlphaMask.IsEmpty() && maBitmap.GetSizePixel() != 
maAlphaMask.GetSizePixel(), "vcl",
 "BitmapEx::Rotate(): size mismatch for bitmap and alpha 
mask.");
@@ -372,7 +367,7 @@ bool BitmapEx::Crop( const tools::Rectangle& rRectPixel )
 if( bRet && !maAlphaMask.IsEmpty() )
 maAlphaMask.Crop( rRectPixel );
 
-SetSizePixel(maBitmap.GetSizePixel());
+maBitmapSize = maBitmap.GetSizePixel();
 
 SAL_WARN_IF(!maAlphaMask.IsEmpty() && maBitmap.GetSizePixel() != 
maAlphaMask.GetSizePixel(), "vcl",
 "BitmapEx::Crop(): size mismatch for bitmap and alpha 
mask.");
@@ -401,7 +396,7 @@ void BitmapEx::Expand( sal_Int32 nDX, sal_Int32 nDY, bool 
bExpandTransparent )
 maAlphaMask.Expand( nDX, nDY,  );
 }
 
-SetSizePixel(maBitmap.GetSizePixel());
+maBitmapSize = maBitmap.GetSizePixel();
 
 SAL_WARN_IF(!maAlphaMask.IsEmpty() && maBitmap.GetSizePixel() != 
maAlphaMask.GetSizePixel(), "vcl",
 "BitmapEx::Expand(): size mismatch for bitmap and alpha 
mask.");

core.git: 2 commits - svx/source

[Tomaž Vajngerl (via logerrit)]

 svx/source/core/graphichelper.cxx |  250 --
 1 file changed, 106 insertions(+), 144 deletions(-)

New commits:
commit 397d87b9786bebd1ab76f18b472c731bd9ed7884
Author: Tomaž Vajngerl 
AuthorDate: Sat Mar 16 12:02:37 2024 +0900
Commit: Tomaž Vajngerl 
CommitDate: Fri Mar 22 01:47:57 2024 +0100

svx: graphichelper - organize UNO types

Change-Id: I08ac95f8065518efb9f46f86a384ed73ab45db23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164945
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/svx/source/core/graphichelper.cxx 
b/svx/source/core/graphichelper.cxx
index 314573780e00..e52594b15c31 100644
--- a/svx/source/core/graphichelper.cxx
+++ b/svx/source/core/graphichelper.cxx
@@ -55,20 +55,7 @@
 
 #include 
 
-using namespace css::uno;
-using namespace css::lang;
-using namespace css::graphic;
-using namespace css::ucb;
-using namespace css::beans;
-using namespace css::io;
-using namespace css::document;
-using namespace css::ui::dialogs;
-using namespace css::container;
-using namespace com::sun::star::task;
-
-using namespace sfx2;
-
-namespace drawing = com::sun::star::drawing;
+using namespace css;
 
 namespace
 {
@@ -151,15 +138,15 @@ OUString GraphicHelper::GetImageType(const Graphic& 
rGraphic)
 namespace {
 
 
-bool lcl_ExecuteFilterDialog( const Sequence< PropertyValue >& rPropsForDialog,
-  Sequence< PropertyValue >& rFilterData )
+bool lcl_ExecuteFilterDialog(const uno::Sequence& 
rPropsForDialog,
+ uno::Sequence& rFilterData)
 {
 bool bStatus = false;
 try
 {
-Reference< XExecutableDialog > xFilterDialog(
-comphelper::getProcessServiceFactory()->createInstance( 
"com.sun.star.svtools.SvFilterOptionsDialog" ), UNO_QUERY );
-Reference< XPropertyAccess > xFilterProperties( xFilterDialog, 
UNO_QUERY );
+uno::Reference xFilterDialog(
+comphelper::getProcessServiceFactory()->createInstance( 
"com.sun.star.svtools.SvFilterOptionsDialog" ), uno::UNO_QUERY);
+uno::Reference xFilterProperties( 
xFilterDialog, uno::UNO_QUERY);
 
 if( xFilterDialog.is() && xFilterProperties.is() )
 {
@@ -167,7 +154,7 @@ bool lcl_ExecuteFilterDialog( const Sequence< PropertyValue 
>& rPropsForDialog,
 if( xFilterDialog->execute() )
 {
 bStatus = true;
-const Sequence< PropertyValue > aPropsFromDialog = 
xFilterProperties->getPropertyValues();
+const uno::Sequence aPropsFromDialog = 
xFilterProperties->getPropertyValues();
 for ( const auto& rProp : aPropsFromDialog )
 {
 if (rProp.Name == "FilterData")
@@ -178,19 +165,19 @@ bool lcl_ExecuteFilterDialog( const Sequence< 
PropertyValue >& rPropsForDialog,
 }
 }
 }
-catch( const NoSuchElementException& e )
+catch (container::NoSuchElementException const& exception)
 {
 // the filter name is unknown
-throw ErrorCodeIOException(
+throw task::ErrorCodeIOException(
 ("lcl_ExecuteFilterDialog: NoSuchElementException"
- " \"" + e.Message + "\": ERRCODE_IO_ABORT"),
-Reference< XInterface >(), 
sal_uInt32(ERRCODE_IO_INVALIDPARAMETER));
+ " \"" + exception.Message + "\": ERRCODE_IO_ABORT"),
+uno::Reference(), 
sal_uInt32(ERRCODE_IO_INVALIDPARAMETER));
 }
-catch( const ErrorCodeIOException& )
+catch (const task::ErrorCodeIOException&)
 {
 throw;
 }
-catch( const Exception& )
+catch (const uno::Exception&)
 {
 TOOLS_WARN_EXCEPTION("sfx.doc", "ignoring");
 }
@@ -201,11 +188,11 @@ bool lcl_ExecuteFilterDialog( const Sequence< 
PropertyValue >& rPropsForDialog,
 
 OUString GraphicHelper::ExportGraphic(weld::Window* pParent, const Graphic& 
rGraphic, const OUString& rGraphicName)
 {
-FileDialogHelper 
aDialogHelper(TemplateDescription::FILESAVE_AUTOEXTENSION, 
FileDialogFlags::NONE, pParent);
-Reference < XFilePicker3 > xFilePicker = aDialogHelper.GetFilePicker();
+sfx2::FileDialogHelper 
aDialogHelper(ui::dialogs::TemplateDescription::FILESAVE_AUTOEXTENSION, 
FileDialogFlags::NONE, pParent);
+uno::Reference xFilePicker = 
aDialogHelper.GetFilePicker();
 
 // fish out the graphic's name
-aDialogHelper.SetContext(FileDialogHelper::ExportImage);
+aDialogHelper.SetContext(sfx2::FileDialogHelper::ExportImage);
 aDialogHelper.SetTitle( SvxResId(RID_SVXSTR_EXPORT_GRAPHIC_TITLE));
 INetURLObject aURL;
 aURL.SetSmartURL( rGraphicName );
@@ -287,16 +274,17 @@ OUString GraphicHelper::ExportGraphic(weld::Window* 
pParent, const Graphic& rGra
 if ( rGraphic.GetType() == GraphicType::Bitmap )
 {
 Graphic aGraphic = rGraphic;
-Reference xGraphic = aGraphic.GetXGraphic();
+

[Bug 105762] Implement WIA based scanner support for LO Windows builds

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105762

--- Comment #15 from salmawisoky  ---
Start a 32 bit subtask which use  32 bits LO scan code and return obtained
image to main task 
https://drift-boss.pro

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160186] Changing Table Auto value or Entry required results in full libreoffice suite crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160186

--- Comment #7 from Stéphane Guillou (stragu) 
 ---
Still unable to reproduce the crash. I've:
1. Downloaded
https://thefrugalcomputerguy.com/downloads/15/odb59-Clean%20up%20and%20Review%20part%202.odb
2. Opened it with Lo 7.6.5
3. Edited the table tbl_Department
4. Added a new numeric field, changed its decimal places, changed the first
field's autoValue from Yes to No back to Yes... no crash.

If you get a crash report dialog after the crash, please submit that and share
the link to it.
Otherwise, you could:
1. get a debug ("-dbg") build from here:
https://dev-builds.libreoffice.org/daily/master/current.html
2. see if it crashes too
3. if it does, get a backtrace by following these steps:
https://wiki.documentfoundation.org/QA/BugReport/Debug_Information#GNU.2FLinux:_How_to_get_a_backtrace

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 146606] Field "Position X" under "Position and size" right-sidebar sometimes is empty.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146606

Regina Henschel  changed:

   What|Removed |Added

 CC||dev...@sapo.pt

--- Comment #9 from Regina Henschel  ---
*** Bug 160308 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160308] Writer: Image Properties Position and Size missing information

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160308

Regina Henschel  changed:

   What|Removed |Added

   Assignee|dev...@sapo.pt  |libreoffice-b...@lists.free
   ||desktop.org
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE
 CC||rb.hensc...@t-online.de

--- Comment #2 from Regina Henschel  ---
The problem has been reported already in bug 146606.

You have set yourself as 'Assignee'. That means, that you are going to develop
a fix for the problem. If that is really true, do it in bug 146606.

*** This bug has been marked as a duplicate of bug 146606 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160303] Table layout loop in complex table structure after paste RTF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160303

m_a_riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m_a_riosv  ---
Crash for me with:
Version: 24.2.2.1 (X86_64) / LibreOffice Community
Build ID: bf759d854b5ab45b6ef0bfd22e51c6dc4fb8b882
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: default; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded
hangs with
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 0020fc1167b3760d0631001689a44427b72b816e
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 77590] Make LO's Start Center thumbnail views available for use from within components

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=77590

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9120

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 145531] FILEOPEN PPTX: 3D button/cuboid with perspective shows as rectangle

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145531

--- Comment #10 from Regina Henschel  ---
You are right. A similar front face color is more important than lighter
extrusion faces. I'll revert the change.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160308] Writer: Image Properties Position and Size missing information

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160308

Raul  changed:

   What|Removed |Added

 CC||dev...@sapo.pt
   Assignee|libreoffice-b...@lists.free |dev...@sapo.pt
   |desktop.org |

--- Comment #1 from Raul  ---
Created attachment 193234
  --> https://bugs.documentfoundation.org/attachment.cgi?id=193234=edit
Write:Image: Sidebar Properties Width/Height missing values

After upgrade to new version 7.6.5.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160308] New: Writer: Image Properties Position and Size missing information

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160308

Bug ID: 160308
   Summary: Writer: Image Properties Position and Size missing
information
   Product: LibreOffice
   Version: 7.6.5.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dev...@sapo.pt

Description:
LibreOffice:Writer
on Image : Sidebar --> Properties --> Position and Size --> Width / Height ,
losses information data after first dimension change, but if open Position and
Size Window, information exists.

Steps to Reproduce:
1. Insert a image to document
2. Change image position and size in properties sidebar 
3. rearrange position in document
4. click image to see properties sidebar and Position and Size 
5. Width/Height missing values
6. click to see Position and Size dialog window
7. Width/Height has values 

Actual Results:
Sidebar --> Properties --> Position and Size --> Width / Height, missing values
after change

Expected Results:
Writer: Image: Sidebar --> Properties --> Position and Size --> Width / Height,
show values 


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.6.5.2 (X86_64) / LibreOffice Community
Build ID: 38d5f62f85355c192ef5f1dd47c5c0c0c6d6598b
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: pt-PT (pt_PT); UI: en-GB
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

Import of 3D-Image from pptx

[Regina Henschel]

Hi all,

at the moment, a 3D image is imported as an image and displayed in 
Impress without 3D. The 3D properties are in the InteropGrabBag and are 
written out again on export, in addition to a rotation or mirroring that 
the user has made with the image in LO.


The 3D image could be treated in the same way as an image that has been 
cropped to a shape in PowerPoint. Such an image is imported as a custom 
shape with bitmap filling. Such a custom shape can then be displayed in 
3D mode. When saving, however, as with the cropped image, the result 
would not be a pure image but a shape with a bitmap fill.


What do you think? Should I implement this or should I continue to 
import a 3D image as a pure image?


Kind regards,
Regina

core.git: bin/find-can-be-private-symbols.functions.results include/svl

[Caolán McNamara (via logerrit)]

 bin/find-can-be-private-symbols.functions.results |1 -
 include/svl/numformat.hxx |   12 ++--
 2 files changed, 6 insertions(+), 7 deletions(-)

New commits:
commit 97b0090938b7031cf88622c9e4aeb9cc55030953
Author: Caolán McNamara 
AuthorDate: Thu Mar 21 16:28:36 2024 +
Commit: Caolán McNamara 
CommitDate: Thu Mar 21 22:32:19 2024 +0100

Related: tdf#160056 can be private and not exported

Change-Id: I3da15340809603b991d3a41beb2af7a0ba375acc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165137
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/bin/find-can-be-private-symbols.functions.results 
b/bin/find-can-be-private-symbols.functions.results
index 2782bdc631a7..baeda98d9686 100644
--- a/bin/find-can-be-private-symbols.functions.results
+++ b/bin/find-can-be-private-symbols.functions.results
@@ -6496,7 +6496,6 @@ SvNumberFormatter::InvalidateDateAcceptancePatterns()
 SvNumberFormatter::IsDecimalSep(std::basic_string_view >) const
 SvNumberFormatter::IsLocaleInstalled(o3tl::strong_int)
 SvNumberFormatter::PutandConvertEntrySystem(rtl::OUString&, int&, 
SvNumFormatType&, unsigned int&, o3tl::strong_int, o3tl::strong_int)
-SvNumberFormatter::ReplaceSystemCL(o3tl::strong_int)
 SvNumberFormatter::SetDefaultSystemCurrency(std::basic_string_view >, o3tl::strong_int)
 SvNumberFormatter::SetNoZero(bool)
 SvNumberformat::GetCal() const
diff --git a/include/svl/numformat.hxx b/include/svl/numformat.hxx
index 52ffa46d7920..076994eb9f76 100644
--- a/include/svl/numformat.hxx
+++ b/include/svl/numformat.hxx
@@ -682,6 +682,12 @@ private:
 // called by SvNumberFormatterRegistry_Impl::Notify if the default system 
currency changes
 SVL_DLLPRIVATE void ResetDefaultSystemCurrency();
 
+// Replace the SYSTEM language/country format codes. Called upon change of
+// the user configurable locale.
+// Old compatibility codes are replaced, user defined are converted, and
+// new format codes are appended.
+SVL_DLLPRIVATE void ReplaceSystemCL(LanguageType eOldLanguage);
+
 // own mutex, may also be used by internal class 
SvNumberFormatterRegistry_Impl
 static ::osl::Mutex& GetGlobalMutex();
 ::osl::Mutex& GetInstanceMutex() const { return m_aMutex; }
@@ -691,12 +697,6 @@ public:
 // date acceptance patterns change.
 void InvalidateDateAcceptancePatterns();
 
-// Replace the SYSTEM language/country format codes. Called upon change of
-// the user configurable locale.
-// Old compatibility codes are replaced, user defined are converted, and
-// new format codes are appended.
-void ReplaceSystemCL(LanguageType eOldLanguage);
-
 const css::uno::Reference& 
GetComponentContext() const;
 
 //! The following method is not to be used from outside but must be

core.git: solenv/gbuild

[Stephan Bergmann (via logerrit)]

 solenv/gbuild/gbuild.help.txt |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 70c3e8d89983320e4815d92dd232a2840432f620
Author: Stephan Bergmann 
AuthorDate: Wed Mar 20 13:31:28 2024 +0100
Commit: Stephan Bergmann 
CommitDate: Thu Mar 21 22:01:42 2024 +0100

Fix text layout in gbuild.help.txt

...left inconsistent by recent 76a986da868c52e9bd1cc6d219ed8f9441afd32b 
"Drop
upper-case DBGLEVEL, consolidate on lower-case dbglevel"

Change-Id: Ie10c011f2942a013e90c75e0fadd123695d97374
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165131
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/solenv/gbuild/gbuild.help.txt b/solenv/gbuild/gbuild.help.txt
index fc857b734a4d..fb12142d4aff 100644
--- a/solenv/gbuild/gbuild.help.txt
+++ b/solenv/gbuild/gbuild.help.txt
@@ -113,8 +113,7 @@ INTERACTIVE VARIABLES:
DEBUG / debug   If not empty, build as with --enable-debug.
ENABLE_SYMBOLS / enable_symbols
If not empty, build as with --enable-symbols.
-   dbglevel
-   If not empty, force the debug level to the specified 
value. The
+   dbglevelIf not empty, force the debug level to the specified 
value. The
debug level is passed to the source code through 
OSL_DEBUG_LEVEL
macro.
0 = no debug (as with --disable-debug)

core.git: Branch 'libreoffice-24-2' - include/svtools include/vcl sc/source svtools/source vcl/source vcl/unx

[Patrick Luby (via logerrit)]

 include/svtools/scrolladaptor.hxx|2 +
 include/vcl/toolkit/scrbar.hxx   |3 ++
 include/vcl/weld.hxx |1 
 sc/source/ui/inc/tabview.hxx |2 -
 sc/source/ui/view/tabview.cxx|   22 +--
 sc/source/ui/view/tabview4.cxx   |   45 +--
 svtools/source/control/scrolladaptor.cxx |2 +
 vcl/source/app/salvtables.cxx|2 +
 vcl/source/control/scrbar.cxx|6 ++--
 vcl/unx/gtk3/gtkinst.cxx |5 +++
 10 files changed, 76 insertions(+), 14 deletions(-)

New commits:
commit 227e51b6b4b3e6664c6ed9cc72c85ff3c3d03ab9
Author: Patrick Luby 
AuthorDate: Sun Mar 17 19:04:21 2024 -0400
Commit: Adolfo Jayme Barrientos 
CommitDate: Thu Mar 21 21:56:23 2024 +0100

tdf#93352 Fix horizontal swiping and scrolling when using an RTL UI

Starting with commit bfa21ce5fa08f2c634ccb6162914be55aef9f3c2,
horizontal swiping in Calc moved in the wrong direction scrollbars
were drawn mirrored.

So, revert parts of commit bfa21ce5fa08f2c634ccb6162914be55aef9f3c2
so that we are using Calc's previous "negative scrollbar range"
implementation for RTL UIs, but only for horizontal scrollbars since
vertical scrollbars are the same in LTR and RTL UIs.

Also, always disable RTL for scrollbars. Enabling RTL causes the
following bugs when clicking or dragging the mouse in scrollbars in
Calc's RTL UI:
- Click or drag events get mirrored so you must click or drag in
  unexpected locations to move the scrollbar thumb in the desired
  direction
- Repeatedly dragging the scrollbar thumb leftward can only move
  no highter than the R, S, or T columns

Note: even though RTL is always disabled for Calc scrollbars, the arrows
must still be swapped in vcl's ScrollBar class.

Change-Id: I85aac94ffaf7df2eeb251a3ff150cc0363b5d770
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164959
Reviewed-by: Stéphane Guillou 
Tested-by: Jenkins
Reviewed-by: Patrick Luby 
(cherry picked from commit ac1024765d203496bc7d28cb3ed3a6d2215c53ad)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165116
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/include/svtools/scrolladaptor.hxx 
b/include/svtools/scrolladaptor.hxx
index cdc507078cf8..1eba1dfdf844 100644
--- a/include/svtools/scrolladaptor.hxx
+++ b/include/svtools/scrolladaptor.hxx
@@ -71,6 +71,8 @@ public:
 
 void SetThickness(int nThickness);
 
+void SetSwapArrows(bool bSwap = true);
+
 ScrollAdaptor(vcl::Window* pParent, bool bHori);
 virtual void dispose() override;
 };
diff --git a/include/vcl/toolkit/scrbar.hxx b/include/vcl/toolkit/scrbar.hxx
index 6981b64fa622..363755fc4168 100644
--- a/include/vcl/toolkit/scrbar.hxx
+++ b/include/vcl/toolkit/scrbar.hxx
@@ -57,6 +57,7 @@ private:
 ScrollType  meScrollType;
 boolmbCalcSize;
 boolmbFullDrag;
+boolmbSwapArrows;
 Link   maScrollHdl;
 Link   maEndScrollHdl;
 
@@ -132,6 +133,8 @@ public:
 voidSetEndScrollHdl( const Link& rLink ) { 
maEndScrollHdl = rLink; }
 
 virtual SizeGetOptimalSize() const override;
+
+voidSetSwapArrows( bool bSwap ) { mbSwapArrows = bSwap; }
 };
 
 
diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index 2d8c4db085d6..fc585bdb1071 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -2576,6 +2576,7 @@ public:
 
 virtual int get_scroll_thickness() const = 0;
 virtual void set_scroll_thickness(int nThickness) = 0;
+virtual void set_scroll_swap_arrows(bool bSwap) = 0;
 
 virtual ScrollType get_scroll_type() const = 0;
 
diff --git a/sc/source/ui/inc/tabview.hxx b/sc/source/ui/inc/tabview.hxx
index 66bbc010eae1..e13488e3026a 100644
--- a/sc/source/ui/inc/tabview.hxx
+++ b/sc/source/ui/inc/tabview.hxx
@@ -241,7 +241,7 @@ private:
 voidUpdateVarZoom();
 
 static void SetScrollBar( ScrollAdaptor& rScroll, tools::Long 
nRangeMax, tools::Long nVisible, tools::Long nPos, bool bLayoutRTL );
-static tools::Long GetScrollBarPos( const ScrollAdaptor& rScroll );
+static tools::Long GetScrollBarPos( const ScrollAdaptor& rScroll, bool 
bLayoutRTL );
 
 voidGetAreaMoveEndPosition(SCCOL nMovX, SCROW nMovY, 
ScFollowMode eMode,
SCCOL& rAreaX, SCROW& rAreaY, 
ScFollowMode& rMode,
diff --git a/sc/source/ui/view/tabview.cxx b/sc/source/ui/view/tabview.cxx
index 9eff50195e84..a69ab1447f6c 100644
--- a/sc/source/ui/view/tabview.cxx
+++ b/sc/source/ui/view/tabview.cxx
@@ -1091,7 +1091,7 @@ void ScTabView::ScrollHdl(ScrollAdaptor* pScroll)
 nViewPos = aViewData.GetPosY( (pScroll == aVScrollTop.get()) ?
 SC_SPLIT_TOP : SC_SPLIT_BOTTOM );
 
-bool bLayoutRTL = 

core.git: sw/source

[Noel Grandin (via logerrit)]

 sw/source/core/unocore/unoobj2.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 6c7cec6525378aacf873f183b1e03eb959fc998d
Author: Noel Grandin 
AuthorDate: Wed Mar 20 15:53:05 2024 +0200
Commit: Noel Grandin 
CommitDate: Thu Mar 21 21:41:58 2024 +0100

remove unnecessary statement

we already have the SwTextFootnote, no need to retrieve
it again.
Add an assert in case I'm wrong.

Change-Id: I30d79de243dbd4aff587c0653c495150e21a755a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165063
Tested-by: Noel Grandin 
Reviewed-by: Noel Grandin 

diff --git a/sw/source/core/unocore/unoobj2.cxx 
b/sw/source/core/unocore/unoobj2.cxx
index effb9d36c853..9e67f927db54 100644
--- a/sw/source/core/unocore/unoobj2.cxx
+++ b/sw/source/core/unocore/unoobj2.cxx
@@ -1325,14 +1325,14 @@ CreateParentXText(SwDoc & rDoc, const SwPosition& rPos)
 for (size_t n = 0; n < nFootnoteCnt; ++n )
 {
 const SwTextFootnote* pTextFootnote = rDoc.GetFootnoteIdxs()[ 
n ];
-const SwFormatFootnote& rFootnote = 
pTextFootnote->GetFootnote();
-pTextFootnote = rFootnote.GetTextFootnote();
+const SwFormatFootnote& rFormatFootnote = 
pTextFootnote->GetFootnote();
+assert(pTextFootnote == rFormatFootnote.GetTextFootnote());
 
 if (pSttNode == pTextFootnote->GetStartNode()->GetNode().
 FindSttNodeByType(SwFootnoteStartNode))
 {
 xParentText = SwXFootnote::CreateXFootnote(rDoc,
-_cast(rFootnote));
+_cast(rFormatFootnote));
 break;
 }
 }

[Bug 157285] FILEOPEN PPTX: Textbox too tall - import needs to look at the shape on the slide instead of the master page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157285

Tibor Nagy  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |tibor.nagy.extern@allotropi
   |desktop.org |a.de
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

core.git: chart2/source cui/source editeng/source include/svl include/svx sc/source sd/source sfx2/source svl/source svx/inc svx/source sw/source

[Armin Le Grand (allotropia) (via logerrit)]

 chart2/source/controller/dialogs/res_DataTableProperties.cxx |8 
 chart2/source/controller/dialogs/res_ErrorBar.cxx|8 
 chart2/source/controller/dialogs/res_Trendline.cxx   |8 
 chart2/source/controller/dialogs/tp_AxisLabel.cxx|   10 -
 chart2/source/controller/itemsetwrapper/ItemConverter.cxx|2 
 chart2/source/controller/main/DrawCommandDispatch.cxx|2 
 cui/source/tabpages/align.cxx|   14 -
 cui/source/tabpages/chardlg.cxx  |   42 ++--
 cui/source/tabpages/measure.cxx  |   16 -
 cui/source/tabpages/numfmt.cxx   |2 
 cui/source/tabpages/paragrph.cxx |   26 +-
 cui/source/tabpages/textattr.cxx |   20 +-
 cui/source/tabpages/tparea.cxx   |2 
 cui/source/tabpages/tpbitmap.cxx |   20 +-
 cui/source/tabpages/tpline.cxx   |   24 +-
 cui/source/tabpages/tplnedef.cxx |2 
 cui/source/tabpages/tpshadow.cxx |   32 +--
 cui/source/tabpages/tptrans.cxx  |4 
 editeng/source/editeng/editdbg.cxx   |2 
 editeng/source/uno/unofored.cxx  |6 
 editeng/source/uno/unotext.cxx   |   12 -
 include/svl/itemset.hxx  |2 
 include/svl/poolitem.hxx |8 
 include/svx/sdr/properties/properties.hxx|2 
 sc/source/core/data/documen8.cxx |2 
 sc/source/core/data/patattr.cxx  |4 
 sc/source/core/data/stlpool.cxx  |6 
 sc/source/core/tool/editutil.cxx |6 
 sc/source/filter/html/htmlexp.cxx|2 
 sc/source/filter/rtf/eeimpars.cxx|4 
 sc/source/ui/app/inputhdl.cxx|8 
 sc/source/ui/attrdlg/tabpages.cxx|2 
 sc/source/ui/docshell/docsh6.cxx |2 
 sc/source/ui/drawfunc/drtxtob.cxx|   14 -
 sc/source/ui/sidebar/AlignmentPropertyPanel.cxx  |2 
 sc/source/ui/sidebar/CellAppearancePropertyPanel.cxx |6 
 sc/source/ui/unoobj/cellsuno.cxx |2 
 sc/source/ui/vba/vbafont.cxx |   18 -
 sc/source/ui/vba/vbaformat.cxx   |4 
 sc/source/ui/vba/vbarange.cxx|6 
 sc/source/ui/view/editsh.cxx |4 
 sc/source/ui/view/formatsh.cxx   |   22 +-
 sc/source/ui/view/viewfun2.cxx   |4 
 sc/source/ui/view/viewutil.cxx   |2 
 sd/source/ui/dlg/tpaction.cxx|4 
 sd/source/ui/func/fuconrec.cxx   |2 
 sd/source/ui/unoidl/unopback.cxx |2 
 sd/source/ui/view/drtxtob.cxx|4 
 sd/source/ui/view/drtxtob1.cxx   |2 
 sd/source/ui/view/drviews2.cxx   |6 
 sd/source/ui/view/drviewsf.cxx   |8 
 sfx2/source/control/bindings.cxx |6 
 sfx2/source/control/ctrlitem.cxx |4 
 sfx2/source/control/shell.cxx|4 
 sfx2/source/control/unoctitm.cxx |6 
 sfx2/source/dialog/tabdlg.cxx|2 
 sfx2/source/doc/objcont.cxx  |2 
 sfx2/source/toolbox/tbxitem.cxx  |8 
 svl/source/items/itemset.cxx |   26 --
 svx/inc/sdr/properties/e3dcompoundproperties.hxx |2 
 svx/inc/sdr/properties/e3dsceneproperties.hxx|2 
 svx/inc/sdr/properties/groupproperties.hxx   |2 
 svx/source/dialog/connctrl.cxx   |2 
 svx/source/dialog/rlrcitem.cxx   |2 
 svx/source/dialog/srchdlg.cxx|9 
 svx/source/dialog/weldeditview.cxx   |6 
 svx/source/engine3d/float3d.cxx  |  110 +--
 svx/source/sdr/properties/e3dsceneproperties.cxx |2 
 svx/source/sdr/properties/groupproperties.cxx|2 
 svx/source/sidebar/paragraph/ParaLineSpacingControl.cxx  |2 
 svx/source/svdraw/constructhelper.cxx

core.git: 2 commits - drawinglayer/source include/drawinglayer svx/source

[Armin Le Grand (allotropia) (via logerrit)]

 drawinglayer/source/primitive2d/Tools.cxx |2 +
 drawinglayer/source/primitive2d/sceneprimitive2d.cxx  |2 -
 drawinglayer/source/primitive2d/texthierarchyprimitive2d.cxx  |9 +++
 drawinglayer/source/processor2d/vclpixelprocessor2d.cxx   |   11 -
 include/drawinglayer/primitive2d/texthierarchyprimitive2d.hxx |   12 +-
 svx/source/sdr/contact/objectcontactofpageview.cxx|6 +++--
 6 files changed, 23 insertions(+), 19 deletions(-)

New commits:
commit 1f912bdbf7848f8d4073be62ccb589927d60a95f
Author: Armin Le Grand (allotropia) 
AuthorDate: Thu Mar 21 17:02:54 2024 +0100
Commit: Armin Le Grand 
CommitDate: Thu Mar 21 21:39:45 2024 +0100

ITEM: Enable MultiThreaded 3D rendering

Change-Id: I3155b075b150f04d0dc93833ab9b6f57eefe71db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165130
Tested-by: Jenkins
Reviewed-by: Armin Le Grand 

diff --git a/drawinglayer/source/primitive2d/sceneprimitive2d.cxx 
b/drawinglayer/source/primitive2d/sceneprimitive2d.cxx
index 5dac8e5c7223..11807e459b7f 100644
--- a/drawinglayer/source/primitive2d/sceneprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/sceneprimitive2d.cxx
@@ -422,7 +422,7 @@ namespace drawinglayer::primitive2d
 nOversampleValue ? nRasterHeight * nOversampleValue : 
nRasterHeight);
 
 // check for parallel execution possibilities
-static bool bMultithreadAllowed = false; // 
loplugin:constvars:ignore
+static bool bMultithreadAllowed = true; // 
loplugin:constvars:ignore
 sal_Int32 nThreadCount(0);
 comphelper::ThreadPool& 
rThreadPool(comphelper::ThreadPool::getSharedOptimalPool());
 
commit 0cc4333e6fce741c1316c7591e7a4a3e579cec49
Author: Armin Le Grand (allotropia) 
AuthorDate: Thu Mar 21 16:59:22 2024 +0100
Commit: Armin Le Grand 
CommitDate: Thu Mar 21 21:39:34 2024 +0100

Disable EditViewActive when Metafile output

This was missing in the mechanism to suppress
EditView exclusive content, so it is now also
suppressed in PDF export.
Also changed TextHierarchyEditPrimitive2D to
also decide inside it's local get2DDecomposition
implementation, so it does not need to be#
supported in PrimitiveProcessors (and cannot be
forgotten in future implementations).
Also added support for EditView exclusive
Primitive's name in idToString (missed that).

Change-Id: I61efc9dddb7d6f0190c7b1fb4b0acf98ab5767f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165109
Tested-by: Jenkins
Reviewed-by: Armin Le Grand 

diff --git a/drawinglayer/source/primitive2d/Tools.cxx 
b/drawinglayer/source/primitive2d/Tools.cxx
index 9c09ef24ee0c..e20c34a6c4f7 100644
--- a/drawinglayer/source/primitive2d/Tools.cxx
+++ b/drawinglayer/source/primitive2d/Tools.cxx
@@ -231,6 +231,8 @@ OUString idToString(sal_uInt32 nId)
 return "FILLEDRECTANGLEPRIMITIVE";
 case PRIMITIVE2D_ID_SINGLELINEPRIMITIVE2D:
 return "SINGLELINEPRIMITIVE";
+case PRIMITIVE2D_ID_EXCLUSIVEEDITVIEWPRIMITIVE2D:
+return "EXCLUSIVEEDITVIEWPRIMITIVE2D";
 default:
 return OUString::number((nId >> 16) & 0xFF) + "|" + 
OUString::number(nId & 0xFF);
 }
diff --git a/drawinglayer/source/primitive2d/texthierarchyprimitive2d.cxx 
b/drawinglayer/source/primitive2d/texthierarchyprimitive2d.cxx
index 172e8c758797..655918904cfb 100644
--- a/drawinglayer/source/primitive2d/texthierarchyprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/texthierarchyprimitive2d.cxx
@@ -141,6 +141,15 @@ namespace drawinglayer::primitive2d
 {
 }
 
+void TextHierarchyEditPrimitive2D::get2DDecomposition(
+Primitive2DDecompositionVisitor& rVisitor,
+const geometry::ViewInformation2D& rViewInformation) const
+{
+// check if TextEdit is active. If not, process. If yes, suppress 
the content
+if (!rViewInformation.getTextEditActive())
+GroupPrimitive2D::get2DDecomposition(rVisitor, 
rViewInformation);
+}
+
 // provide unique ID
 sal_uInt32 TextHierarchyEditPrimitive2D::getPrimitive2DID() const
 {
diff --git a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx 
b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
index bb3e29bf8044..754b8cef2592 100644
--- a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
+++ b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
@@ -343,17 +343,6 @@ void VclPixelProcessor2D::processBasePrimitive2D(const 
primitive2d::BasePrimitiv
 processInvertPrimitive2D(rCandidate);
 break;
 }
-case PRIMITIVE2D_ID_TEXTHIERARCHYEDITPRIMITIVE2D:
-{
-// check if TextEdit is active
-if (getViewInformation2D().getTextEditActive())
-// suppress text display
-

core.git: sd/qa sfx2/source

[Miklos Vajna (via logerrit)]

 sd/qa/unit/tiledrendering/tiledrendering.cxx |   24 
 sfx2/source/sidebar/SidebarController.cxx|   18 --
 2 files changed, 32 insertions(+), 10 deletions(-)

New commits:
commit d8061151acf4e287b60a055a67b84c56989a37af
Author: Miklos Vajna 
AuthorDate: Thu Mar 21 17:01:20 2024 +0100
Commit: Miklos Vajna 
CommitDate: Thu Mar 21 21:30:17 2024 +0100

cool#8278 sfx2 lok: fix lost hide notification on sidebar switch

Similar to commit 55feb670ca28e0a48ac82a65b5559598704d993e (cool#8278
sfx2 lok: fix unexpected non-json sidebar status update, 2024-03-21),
the trouble here was not around hiding the sidebar but around switching
between decks.

This went wrong in commit aaf6ce108e91b1504befe19afcee471e3316ae7a
(cool#7492 sfx2 lok: set language/locale on async sidebar update,
2024-01-11), where I didn't notice that
SidebarController::SwitchToDeck() may emit two callbacks, so the effort
to avoid code duplication went a bit too far: the hide+show case only
emitted a show callback.

Fix this by building a list of state changes to emit, so once se switch
decks, not only the new one is "on", but also the old one is "off".

Change-Id: I1678ee61e004697a6a5c6ecaf40a18b2d1d47e61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165108
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/sd/qa/unit/tiledrendering/tiledrendering.cxx 
b/sd/qa/unit/tiledrendering/tiledrendering.cxx
index 8f0fd9cfc4ae..d270579e6c07 100644
--- a/sd/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sd/qa/unit/tiledrendering/tiledrendering.cxx
@@ -2983,6 +2983,30 @@ CPPUNIT_TEST_FIXTURE(SdTiledRenderingTest, 
testSidebarHide)
 CPPUNIT_ASSERT(it != aView.m_aStateChanges.end());
 }
 
+CPPUNIT_TEST_FIXTURE(SdTiledRenderingTest, testSidebarSwitchDeck)
+{
+// Given an impress document, with a visible sidebar (ModifyPage deck):
+createDoc("dummy.odp");
+ViewCallback aView;
+sfx2::sidebar::Sidebar::Setup(u"");
+Scheduler::ProcessEventsToIdle();
+aView.m_aStateChanges.clear();
+
+// When switching to the MasterSlidesPanel deck:
+dispatchCommand(mxComponent, ".uno:MasterSlidesPanel", {});
+
+// Then make sure notifications are sent for both the old and the new 
decks:
+auto it = aView.m_aStateChanges.find(".uno:ModifyPage");
+// Without the accompanying fix in place, this test would have failed, the 
notification for the
+// old deck was missing.
+CPPUNIT_ASSERT(it != aView.m_aStateChanges.end());
+boost::property_tree::ptree aTree = it->second;
+CPPUNIT_ASSERT(aTree.get_child_optional("state").has_value());
+CPPUNIT_ASSERT_EQUAL(std::string("false"), 
aTree.get_child("state").get_value());
+it = aView.m_aStateChanges.find(".uno:MasterSlidesPanel");
+CPPUNIT_ASSERT(it != aView.m_aStateChanges.end());
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sfx2/source/sidebar/SidebarController.cxx 
b/sfx2/source/sidebar/SidebarController.cxx
index 468ad56f080f..2437f7167db3 100644
--- a/sfx2/source/sidebar/SidebarController.cxx
+++ b/sfx2/source/sidebar/SidebarController.cxx
@@ -816,30 +816,28 @@ void SidebarController::SwitchToDeck (
 {
 if (const SfxViewShell* pViewShell = mpViewFrame->GetViewShell())
 {
-boost::property_tree::ptree aTree;
-aTree.put("locale", 
comphelper::LibreOfficeKit::getLocale().getBcp47());
-bool bStateChanged = false;
+std::vector> aStateChanges;
 if (msCurrentDeckId != rDeckDescriptor.msId)
 {
 const std::string hide = UnoNameFromDeckId(msCurrentDeckId, 
GetCurrentContext());
 if (!hide.empty())
 {
-aTree.put("commandName", hide);
-aTree.put("state", "false");
-bStateChanged = true;
+aStateChanges.push_back({hide, std::string("false")});
 }
 }
 
 const std::string show = UnoNameFromDeckId(rDeckDescriptor.msId, 
GetCurrentContext());
 if (!show.empty())
 {
-aTree.put("commandName", show);
-aTree.put("state", "true");
-bStateChanged = true;
+aStateChanges.push_back({show, std::string("true")});
 }
 
-if (bStateChanged)
+for (const auto& rStateChange : aStateChanges)
 {
+boost::property_tree::ptree aTree;
+aTree.put("locale", 
comphelper::LibreOfficeKit::getLocale().getBcp47());
+aTree.put("commandName", rStateChange.first);
+aTree.put("state", rStateChange.second);
 std::stringstream aStream;
 boost::property_tree::write_json(aStream, aTree);
 

[Bug 158556] DOCX Document That Opens/Loads Extremely Slowly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158556

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:24.8.0   |target:24.8.0
   |target:24.2.0.0.beta2   |target:24.2.0.0.beta2
   ||target:24.2.3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158773

--- Comment #32 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/d83d68f120ad3ccfc036e25cf9d5b04fb36f7c8b

tdf#158773 reduce cost of TextProperties::Notify

It will be available in 24.2.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158773] FILEOPEN PPTX Slow loading of file with lots of unused master pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158773

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:24.8.0   |target:24.8.0 target:24.2.3

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'libreoffice-24-2' - 2 commits - svx/source sw/inc sw/source

[Noel Grandin (via logerrit)]

 svx/source/sdr/properties/textproperties.cxx |   60 ---
 sw/inc/doc.hxx   |1 
 sw/source/core/doc/docfly.cxx|   19 
 sw/source/core/unocore/unoframe.cxx  |   13 -
 4 files changed, 48 insertions(+), 45 deletions(-)

New commits:
commit e4519e38d3598c3e26f2585bbc2553bc7ff5db4c
Author: Noel Grandin 
AuthorDate: Wed Mar 20 09:59:09 2024 +0200
Commit: Xisco Fauli 
CommitDate: Thu Mar 21 21:21:57 2024 +0100

tdf#158556 speedup docx load

Avoid O(n^2) loop in SwXFrame::setPropertyValue, we even have an index
to search for this stuff

Reduces load time from 325s to 172s

Change-Id: I6c6c03206ef81be1d7d7702a4313acd23d75442d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165044
Tested-by: Jenkins
Reviewed-by: Noel Grandin 
(cherry picked from commit 241e2d68664e0e53cf02fe9986462c4a9ecd8d42)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165110
Reviewed-by: Xisco Fauli 

diff --git a/sw/inc/doc.hxx b/sw/inc/doc.hxx
index ea95cef85636..99cb33c75826 100644
--- a/sw/inc/doc.hxx
+++ b/sw/inc/doc.hxx
@@ -838,6 +838,7 @@ public:
 std::vector GetFlyFrameFormats(
 FlyCntType eType,
 bool bIgnoreTextBoxes);
+SwFrameFormat* GetFlyFrameFormatByName( const OUString& sFrameFormatName );
 
 // Copy formats in own arrays and return them.
 SwFrameFormat  *CopyFrameFormat ( const SwFrameFormat& );
diff --git a/sw/source/core/doc/docfly.cxx b/sw/source/core/doc/docfly.cxx
index c492212487c3..203894123007 100644
--- a/sw/source/core/doc/docfly.cxx
+++ b/sw/source/core/doc/docfly.cxx
@@ -149,6 +149,25 @@ SwFrameFormat* SwDoc::GetFlyNum( size_t nIdx, FlyCntType 
eType, bool bIgnoreText
 return pRetFormat;
 }
 
+SwFrameFormat* SwDoc::GetFlyFrameFormatByName( const OUString& 
rFrameFormatName )
+{
+auto pFrameFormats = GetSpzFrameFormats();
+auto it = pFrameFormats->findByTypeAndName( RES_FLYFRMFMT, 
rFrameFormatName );
+auto endIt = pFrameFormats->typeAndNameEnd();
+for ( ; it != endIt; ++it)
+{
+sw::SpzFrameFormat* pFlyFormat = *it;
+const SwNodeIndex* pIdx = pFlyFormat->GetContent().GetContentIdx();
+if( !pIdx || !pIdx->GetNodes().IsDocNodes() )
+continue;
+
+const SwNode* pNd = GetNodes()[ pIdx->GetIndex() + 1 ];
+if( !pNd->IsNoTextNode())
+return pFlyFormat;
+}
+return nullptr;
+}
+
 std::vector SwDoc::GetFlyFrameFormats(
 FlyCntType const eType, bool const bIgnoreTextBoxes)
 {
diff --git a/sw/source/core/unocore/unoframe.cxx 
b/sw/source/core/unocore/unoframe.cxx
index 7880a749b95c..62c4c76ac3ab 100644
--- a/sw/source/core/unocore/unoframe.cxx
+++ b/sw/source/core/unocore/unoframe.cxx
@@ -1713,18 +1713,7 @@ void SwXFrame::setPropertyValue(const OUString& 
rPropertyName, const ::uno::Any&
 }
 else
 {
-const size_t nCount = pDoc->GetFlyCount(FLYCNTTYPE_FRM);
-
-SwFrameFormat* pChain = nullptr;
-for( size_t i = 0; i < nCount; ++i )
-{
-SwFrameFormat* pFormat2 = pDoc->GetFlyNum(i, 
FLYCNTTYPE_FRM);
-if(sChainName == pFormat2->GetName() )
-{
-pChain = pFormat2;
-break;
-}
-}
+SwFrameFormat* pChain = 
pDoc->GetFlyFrameFormatByName(sChainName);
 if(pChain)
 {
 SwFrameFormat* pSource = bNextFrame ? pFormat : pChain;
commit d83d68f120ad3ccfc036e25cf9d5b04fb36f7c8b
Author: Noel Grandin 
AuthorDate: Wed Mar 6 14:12:51 2024 +0200
Commit: Xisco Fauli 
CommitDate: Thu Mar 21 21:21:49 2024 +0100

tdf#158773 reduce cost of TextProperties::Notify

Shaves 30% off the load time here, by re-arranging the logic so we do th
expensive dynamic_cast less often

Change-Id: If7a1605994e620dbdb61010506c624cc738359a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164466
Tested-by: Jenkins
Reviewed-by: Noel Grandin 
(cherry picked from commit 3b784236d7c3bf386deeeadcf79d9e9b289bf991)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165112
Reviewed-by: Xisco Fauli 

diff --git a/svx/source/sdr/properties/textproperties.cxx 
b/svx/source/sdr/properties/textproperties.cxx
index 55b366bdc03b..17f63d044dcf 100644
--- a/svx/source/sdr/properties/textproperties.cxx
+++ b/svx/source/sdr/properties/textproperties.cxx
@@ -554,50 +554,44 @@ namespace sdr::properties
 if(!rObj.HasText())
 return;
 
+SfxHintId nId(rHint.GetId());
 const svx::ITextProvider& rTextProvider(getTextProvider());
-if(dynamic_cast() != nullptr)
-{
-SfxHintId nId(rHint.GetId());
 
-if(SfxHintId::DataChanged == nId)
+

[Bug 159730] RTF table split document layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159730

--- Comment #10 from Commit Notification 
 ---
Oliver Specht committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/fad1f551ebc2db9c13e2f1f8f6c748b1ac45793b

Revert "tdf#159730 add compatibility option in RTF import"

It will be available in 7.6.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159730] RTF table split document layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159730

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:24.8.0 target:24.2.2 |target:24.8.0 target:24.2.2
   |target:7.6.6|target:7.6.6 target:7.6.7

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'libreoffice-7-6' - writerfilter/source

[Oliver Specht (via logerrit)]

 writerfilter/source/dmapper/DomainMapper.cxx |3 ---
 writerfilter/source/dmapper/PropertyIds.cxx  |1 -
 writerfilter/source/dmapper/PropertyIds.hxx  |1 -
 3 files changed, 5 deletions(-)

New commits:
commit fad1f551ebc2db9c13e2f1f8f6c748b1ac45793b
Author: Oliver Specht 
AuthorDate: Wed Mar 20 16:25:17 2024 +0100
Commit: Xisco Fauli 
CommitDate: Thu Mar 21 21:21:05 2024 +0100

Revert "tdf#159730 add compatibility option in RTF import"

This reverts commit 3b04e74503ec6d07dc4befdb756e6abdc3de4e58.

Reason for revert: The compatibility option is the wrong approach. This 
results in wrong line calculation as seen in tdf#159730#c6.
The problem that really needs to be fixed is the 9pt attribute of the 
hidden line breaks in the first paragraph that are used to calculate the height 
of the first paragraph.
Only the 1pt font attribute of the remaining visible space should define 
the line height.

Change-Id: I6e0a1a499adaf2df9f68afbcfd6afcd6677e8f76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165006
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
Signed-off-by: Xisco Fauli 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165104

diff --git a/writerfilter/source/dmapper/DomainMapper.cxx 
b/writerfilter/source/dmapper/DomainMapper.cxx
index ecd6ad6b242a..c4001cf0fe61 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -129,9 +129,6 @@ DomainMapper::DomainMapper( const uno::Reference< 
uno::XComponentContext >& xCon
 m_pImpl->SetDocumentSettingsProperty(
 getPropertyName(PROP_APPLY_PARAGRAPH_MARK_FORMAT_TO_NUMBERING),
 uno::Any(true));
-m_pImpl->SetDocumentSettingsProperty(
-getPropertyName(PROP_TABS_AND_BLANKS_FOR_LINE_CALCULATION),
-uno::Any(true));
 
 // Don't load the default style definitions to avoid weird mix
 m_pImpl->SetDocumentSettingsProperty("StylesNoDefault", 
uno::Any(true));
diff --git a/writerfilter/source/dmapper/PropertyIds.cxx 
b/writerfilter/source/dmapper/PropertyIds.cxx
index 4069a9ac7fe5..11ef07230fad 100644
--- a/writerfilter/source/dmapper/PropertyIds.cxx
+++ b/writerfilter/source/dmapper/PropertyIds.cxx
@@ -378,7 +378,6 @@ namespace
 { PROP_CURSOR_NOT_IGNORE_TABLES_IN_HF, u"CursorNotIgnoreTables"},
 { PROP_PARA_CONNECT_BORDERS, u"ParaIsConnectBorder"},
 { PROP_DECORATIVE, u"Decorative"},
-{ PROP_TABS_AND_BLANKS_FOR_LINE_CALCULATION, 
u"IgnoreTabsAndBlanksForLineCalculation"},
 });
 } // end anonymous ns
 
diff --git a/writerfilter/source/dmapper/PropertyIds.hxx 
b/writerfilter/source/dmapper/PropertyIds.hxx
index 25099a684dcd..6708c6dfbf35 100644
--- a/writerfilter/source/dmapper/PropertyIds.hxx
+++ b/writerfilter/source/dmapper/PropertyIds.hxx
@@ -377,7 +377,6 @@ enum PropertyIds
 ,PROP_RTL_GUTTER
 ,PROP_CURSOR_NOT_IGNORE_TABLES_IN_HF
 ,PROP_PARA_CONNECT_BORDERS
-,PROP_TABS_AND_BLANKS_FOR_LINE_CALCULATION
 };
 
 //Returns the UNO string equivalent to eId.

core.git: sw/CppunitTest_sw_uibase_uiview.mk sw/qa

[Miklos Vajna (via logerrit)]

 sw/CppunitTest_sw_uibase_uiview.mk|4 
 sw/qa/uibase/uiview/data/update-replacement-nosetting.odt |binary
 sw/qa/uibase/uiview/data/updateall-objectreplacements.odt |binary
 3 files changed, 4 insertions(+)

New commits:
commit a91bb0fe19a24c0473937af82a352901a08e2933
Author: Miklos Vajna 
AuthorDate: Thu Mar 21 08:14:51 2024 +0100
Commit: Miklos Vajna 
CommitDate: Thu Mar 21 21:12:05 2024 +0100

CppunitTest_sw_uibase_uiview: turn on set_non_application_font_use

Similar to commit dc4d7500c9d283e26d1553ce11366a217cf1f69d (Fix
CppunitTest_sd_import_tests-smartart non_application_font_use,
2023-10-23), replaced fonts as suggested by the failing assert.

Change-Id: I528ba0bc7e463c09fb86b424918f7e645cdb552f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165091
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/sw/CppunitTest_sw_uibase_uiview.mk 
b/sw/CppunitTest_sw_uibase_uiview.mk
index 3a5f8aafef05..6cf98a03d7cc 100644
--- a/sw/CppunitTest_sw_uibase_uiview.mk
+++ b/sw/CppunitTest_sw_uibase_uiview.mk
@@ -74,4 +74,8 @@ $(eval $(call gb_CppunitTest_use_uiconfigs,sw_uibase_uiview, \
 
 $(eval $(call gb_CppunitTest_use_more_fonts,sw_uibase_uiview))
 
+ifneq ($(filter MORE_FONTS,$(BUILD_TYPE)),)
+$(eval $(call 
gb_CppunitTest_set_non_application_font_use,sw_uibase_uiview,abort))
+endif
+
 # vim: set noet sw=4 ts=4:
diff --git a/sw/qa/uibase/uiview/data/update-replacement-nosetting.odt 
b/sw/qa/uibase/uiview/data/update-replacement-nosetting.odt
index 055c3d1a2c2a..757ee9c43e8b 100644
Binary files a/sw/qa/uibase/uiview/data/update-replacement-nosetting.odt and 
b/sw/qa/uibase/uiview/data/update-replacement-nosetting.odt differ
diff --git a/sw/qa/uibase/uiview/data/updateall-objectreplacements.odt 
b/sw/qa/uibase/uiview/data/updateall-objectreplacements.odt
index 35decf73f895..6a8beebc8e8e 100644
Binary files a/sw/qa/uibase/uiview/data/updateall-objectreplacements.odt and 
b/sw/qa/uibase/uiview/data/updateall-objectreplacements.odt differ

core.git: sw/inc

[Noel Grandin (via logerrit)]

 sw/inc/ring.hxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 2326d6a2273e1a5d7c012e0c496fc5275a8e5d94
Author: Noel Grandin 
AuthorDate: Wed Mar 20 14:47:34 2024 +0200
Commit: Noel Grandin 
CommitDate: Thu Mar 21 21:08:29 2024 +0100

fix some typos in sw::Ring

introduced by
commit d150ace12b6d8fbb30664d1de1001622720bd53b
Author: Bjoern Michaelsen 
Date:   Fri Dec 5 03:54:55 2014 +0100
stick to code conventions for new code

Change-Id: I97b257b85fba5734c6f5dedb141c448e6d30ee46
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165058
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/inc/ring.hxx b/sw/inc/ring.hxx
index e152899ec87a..194ed47db10b 100644
--- a/sw/inc/ring.hxx
+++ b/sw/inc/ring.hxx
@@ -144,7 +144,7 @@ namespace sw
 }
 
 /**
- * helper class that provides Svalue_typeL-style container iteration to 
the ring
+ * helper class that provides STL-style container iteration to the ring
  */
 template 
 class SAL_WARN_UNUSED RingContainer final
@@ -226,7 +226,7 @@ namespace sw
 value_type& dereference() const
 { return m_pCurrent ? *m_pCurrent : * m_pStart; }
 /**
- * value_type is:
+ * This is:
  * - pointing to the current item in the iteration in general
  * - nullptr if on the first item (begin())
  * - m_pStart when beyond the last item (end())

Re: VS 2022 version 17.9.1 has a bug preventing building cli_ure

[Oliver Brinzing]

Am 20.03.2024 um 06:01 schrieb Mike Kaganski:

On 24.02.2024 21:50, Mike Kaganski wrote:

After upgrading my VS v.17.9.0 to v.17.9.1, building cli_ure started to fail 
like this:


LINK : error LNK2034: metadata inconsistent with COFF symbol table: symbol
'?rtl_ustr_asciil_reverseEquals_WithLength@@$$J0YAEPEB_SPEBDJ@Z' (06000579) has 
inconsistent
metadata with (0A000A1A) in climaker_emit.o
climaker_emit.o : error LNK2020: unresolved token (0A000A1A) "extern "C" 
unsigned char __cdecl
rtl_ustr_asciil_reverseEquals_WithLength(char16_t const *,char const *,long)"
(?rtl_ustr_asciil_reverseEquals_WithLength@@$$J0YAEPEB_SPEBDJ@Z)
C:\lo\build\instdir\sdk\bin\climaker.exe : fatal error LNK1120: 1 unresolved 
externals


I have filed a bug to Microsoft:

https://developercommunity.visualstudio.com/t/LINK-:-error-LNK2034:-metadata-inconsis/10599604?port=1025=fdff4046-995a-4c06-8c64-1c14b9752c8f


This problem is fixed in VS 2022 version 17.9.4:
https://learn.microsoft.com/en-us/visualstudio/releases/2022/release-notes#17.9.4



yes, it works again with VS 2022

btw: i had a build break after a "clean build":

cd /cygdrive/d/sources/libo-core
./g checkout master
./g fetch --tags
./g pull -r

/opt/lo/bin/make clean gb_COLOR=1 gb_TITLES=1

/cygdrive/d/sources/libo-core/autogen.sh \
--with-external-tar=/cygdrive/d/sources/lo-externalsrc \
--with-junit=/cygdrive/d/sources/junit-4.10.jar \
--with-ant-home=/cygdrive/d/sources/apache-ant-1.9.5 \
--with-jdk-home=/cygdrive/d/Programme/Java/jdk-17 \
--enable-pch \
--disable-ccache \
--enable-debug \
--disable-odk \
--disable-online-update \
--with-visual-studio=2022

/opt/lo/bin/make build gb_COLOR=1 gb_TITLES=1 2>&1 | tee build.log

[...]
[PAT] icu
[BIN] dragonbox
[MOD] frozen
[BIN] glm
Configuring OpenSSL version 3.0.13 for target VC-WIN64A
Using os-specific seed configuration
/cygdrive/d/sources/libo-core/workdir/UnpackedTarball/openssl/crypto/sha/../providers:
 No such file
or directory at Configure line 3419.
make[1]: *** 
[D:/sources/libo-core/external/openssl/ExternalProject_openssl.mk:67:
D:/sources/libo-core/workdir/ExternalProject/openssl/build] Error 1
make[1]: *** Waiting for unfinished jobs

but folder "providers" is located at:

/cygdrive/d/sources/libo-core/workdir/UnpackedTarball/openssl/providers

workaround: copy folder "providers" to:

/cygdrive/d/sources/libo-core/workdir/UnpackedTarball/openssl/crypto

[Bug 106810] set transparent background color in form controls

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106810

--- Comment #12 from b3achfr...@aol.com ---
(In reply to u2nBz from comment #11)
> Shouldn't the title be just "Set transparent background in form controls"
> since 'transparent' is not a color (in the lowest four dimensions anyway
> lol).
> 
> Could not use LO in one application due to this missing feature. Been
> subscribed here a long time. Hope it gets fixed soon.

Me too, and it took a while to find one that would let me use the font I
wanted.  Very frustrating!  Would rather just use LO since I use it for
everything else I do :/  I also donate to them yearly. Not a huge amount but I
try to support them at least a little.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: external/gpgmepp

[Patrick Luby (via logerrit)]

 external/gpgmepp/macos-tdf152524.patch |   66 ++---
 1 file changed, 52 insertions(+), 14 deletions(-)

New commits:
commit 3c6c5ef5d1c4f555b465bf56cf9d99e4d67224cc
Author: Patrick Luby 
AuthorDate: Thu Mar 21 10:00:49 2024 -0400
Commit: Patrick Luby 
CommitDate: Thu Mar 21 20:42:53 2024 +0100

tdf#152524 fix crash by skipping second fork()

Instead of calling a second fork() in the child process, replace
execv() with posix_spawn(). posix_spawn() does not call any atfork
handlers so the atfork handler that crashes will be skipped.

Change-Id: Iffb70fe4f51b6b324f13e4ac24b740da0a25da99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165103
Tested-by: Jenkins
Reviewed-by: Patrick Luby 

diff --git a/external/gpgmepp/macos-tdf152524.patch 
b/external/gpgmepp/macos-tdf152524.patch
index a69fbd1cf139..2d328e4bde7d 100644
--- a/external/gpgmepp/macos-tdf152524.patch
+++ b/external/gpgmepp/macos-tdf152524.patch
@@ -1,20 +1,25 @@
 --- src/posix-io.c 2023-02-01 11:50:48
-+++ src/posix-io.c 2024-02-05 19:16:00
-@@ -62,6 +62,10 @@
- # endif
- #endif
- #include 
 /Users/pluby/posix-io.c2024-03-21 09:50:24
+@@ -67,6 +67,13 @@
+ #include "priv-io.h"
+ #include "sema.h"
+ #include "debug.h"
 +
 +#if HAVE_MACOS_SYSTEM
 +#include 
++#include 
++
++extern char **environ;
 +#endif
  
- #include "util.h"
- #include "priv-io.h"
-@@ -517,12 +521,50 @@
- }
- 
  
+ #ifdef USE_LINUX_GETDENTS
+@@ -515,6 +522,15 @@
+ }
+   return 0;
+ }
++
++
 +#if HAVE_MACOS_SYSTEM
 +static int
 +_gpgme_io_spawn_macos (const char *path, char *const argv[], unsigned int 
flags,
@@ -22,11 +27,10 @@
 + void (*atfork) (void *opaque, int reserved),
 + void *atforkvalue, pid_t *r_pid);
 +#endif /*HAVE_MACOS_SYSTEM*/
-+
-+
+ 
+ 
  /* Returns 0 on success, -1 on error.  */
- int
- _gpgme_io_spawn (const char *path, char *const argv[], unsigned int flags,
+@@ -523,6 +539,35 @@
 struct spawn_fd_item_s *fd_list,
 void (*atfork) (void *opaque, int reserved),
 void *atforkvalue, pid_t *r_pid)
@@ -62,3 +66,37 @@
  {
pid_t pid;
int i;
+@@ -552,8 +597,15 @@
+   if (!pid)
+ {
+   /* Intermediate child to prevent zombie processes.  */
++#if HAVE_MACOS_SYSTEM
++  /* tdf#152524 fix crash by skipping second fork()
++   * Instead of calling a second fork() in the child process, replace
++   * execv() with posix_spawn(). posix_spawn() does not call any atfork
++   * handlers so the atfork handler that crashes will be skipped.  */
++#else /*HAVE_MACOS_SYSTEM*/
+   if ((pid = fork ()) == 0)
+   {
++#endif /*HAVE_MACOS_SYSTEM*/
+ /* Child.  */
+   int max_fds = -1;
+   int fd;
+@@ -664,6 +716,9 @@
+   close (fd);
+   }
+ 
++#if HAVE_MACOS_SYSTEM
++_exit(posix_spawn(NULL, path, NULL, NULL, argv, environ));
++#else /*HAVE_MACOS_SYSTEM*/
+ execv (path, (char *const *) argv);
+ /* Hmm: in that case we could write a special status code to the
+status-pipe.  */
+@@ -674,6 +729,7 @@
+   _exit (1);
+   else
+   _exit (0);
++#endif /*HAVE_MACOS_SYSTEM*/
+ }
+ 
+   TRACE_LOG  ("waiting for child process pid=%i", pid);

core.git: sc/source

[Caolán McNamara (via logerrit)]

 sc/source/core/data/documen6.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit de148aa512e02457e43c6db966472a37059fbb14
Author: Caolán McNamara 
AuthorDate: Thu Mar 21 15:24:24 2024 +
Commit: Caolán McNamara 
CommitDate: Thu Mar 21 20:35:01 2024 +0100

Related: tdf#160056 replace with wrapper GetFormatTable()

GetFormatTable calls mxPoolHelper->GetFormTable()

but asserts if this happens during threaded calculation

so replace the first with the latter

Change-Id: I7027f66a929159525842bfabbf8cf4ab0e55ed23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165107
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/core/data/documen6.cxx b/sc/source/core/data/documen6.cxx
index 931cb9002bee..96c625eaf9af 100644
--- a/sc/source/core/data/documen6.cxx
+++ b/sc/source/core/data/documen6.cxx
@@ -118,9 +118,9 @@ SvtScriptType ScDocument::GetCellScriptType( const 
ScAddress& rPos, sal_uInt32 n
 const Color* pColor;
 OUString aStr;
 if( pCell )
-aStr = ScCellFormat::GetString(*pCell, nNumberFormat, , 
*mxPoolHelper->GetFormTable(), *this);
+aStr = ScCellFormat::GetString(*pCell, nNumberFormat, , 
*GetFormatTable(), *this);
 else
-aStr = ScCellFormat::GetString(*this, rPos, nNumberFormat, , 
*mxPoolHelper->GetFormTable());
+aStr = ScCellFormat::GetString(*this, rPos, nNumberFormat, , 
*GetFormatTable());
 
 SvtScriptType nRet = GetStringScriptType( aStr );
 
@@ -146,7 +146,7 @@ SvtScriptType ScDocument::GetScriptType( SCCOL nCol, SCROW 
nRow, SCTAB nTab, con
 if ( !pPattern->GetItem(ATTR_CONDITIONAL).GetCondFormatData().empty() )
 pCondSet = GetCondResult( nCol, nRow, nTab );
 
-sal_uInt32 nFormat = pPattern->GetNumberFormat( 
mxPoolHelper->GetFormTable(), pCondSet );
+sal_uInt32 nFormat = pPattern->GetNumberFormat( GetFormatTable(), pCondSet 
);
 
 return GetCellScriptType(aPos, nFormat, pCell);
 }

core.git: 2 commits - bin/find-can-be-private-symbols.functions.results include/svl sc/source svl/source svx/source sw/source xmloff/source

[Caolán McNamara (via logerrit)]

 bin/find-can-be-private-symbols.functions.results |1 -
 include/svl/numformat.hxx |6 +-
 sc/source/ui/view/formatsh.cxx|2 +-
 svl/source/numbers/zforlist.cxx   |9 +++--
 svx/source/items/numfmtsh.cxx |2 +-
 sw/source/core/fields/fldbas.cxx  |   10 --
 xmloff/source/style/xmlnumfe.cxx  |2 +-
 xmloff/source/style/xmlnumfi.cxx  |2 +-
 8 files changed, 16 insertions(+), 18 deletions(-)

New commits:
commit e8d01d2447b3350f1bd24e07580402c4c699756c
Author: Caolán McNamara 
AuthorDate: Wed Mar 20 17:22:46 2024 +
Commit: Caolán McNamara 
CommitDate: Thu Mar 21 20:34:52 2024 +0100

Related: tdf#160056 this can be be a local function

Change-Id: I0ffebd5a1f871b86507d0c1b3946b32993d76365
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165106
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/bin/find-can-be-private-symbols.functions.results 
b/bin/find-can-be-private-symbols.functions.results
index 31b9cef633aa..2782bdc631a7 100644
--- a/bin/find-can-be-private-symbols.functions.results
+++ b/bin/find-can-be-private-symbols.functions.results
@@ -6491,7 +6491,6 @@ SvNumberFormatter::GetNumThousandSep() const
 SvNumberFormatter::GetTransliteration() const
 SvNumberFormatter::GetUserDefColor(unsigned short) const
 SvNumberFormatter::ImpLookupCurrencyEntryLoopBody(NfCurrencyEntry const*&, 
bool&, NfCurrencyEntry const*, unsigned short, std::basic_string_view >)
-SvNumberFormatter::ImpPosToken(rtl::OUStringBuffer const&, char16_t, int) const
 SvNumberFormatter::ImpSubstituteEntry(SvNumberformat*, unsigned int*)
 SvNumberFormatter::InvalidateDateAcceptancePatterns()
 SvNumberFormatter::IsDecimalSep(std::basic_string_view >) const
diff --git a/include/svl/numformat.hxx b/include/svl/numformat.hxx
index ffbc5f8f9769..52ffa46d7920 100644
--- a/include/svl/numformat.hxx
+++ b/include/svl/numformat.hxx
@@ -673,10 +673,6 @@ private:
 // link to be set at 
SvtSysLocaleOptions::SetCurrencyChangeLink()
 DECL_DLLPRIVATE_STATIC_LINK(SvNumberFormatter, CurrencyChangeLink, 
LinkParamNone*, void);
 
-// return position of a special character
-sal_Int32 ImpPosToken(const OUStringBuffer& sFormat, sal_Unicode token,
-  sal_Int32 nStartPos = 0) const;
-
 // Substitute a format during GetFormatEntry(), i.e. system formats.
 SvNumberformat* ImpSubstituteEntry(SvNumberformat* pFormat, sal_uInt32* 
o_pRealKey = nullptr);
 
diff --git a/svl/source/numbers/zforlist.cxx b/svl/source/numbers/zforlist.cxx
index 1a5d57437b08..b4ef00d2a96c 100644
--- a/svl/source/numbers/zforlist.cxx
+++ b/svl/source/numbers/zforlist.cxx
@@ -3084,8 +3084,10 @@ void SvNumberFormatter::ImpGenerateAdditionalFormats( 
sal_uInt32 CLOffset,
 pStdFormat->SetLastInsertKey( static_cast(nPos - CLOffset), 
SvNumberformat::FormatterPrivateAccess() );
 }
 
+namespace {
 
-sal_Int32 SvNumberFormatter::ImpPosToken ( const OUStringBuffer & sFormat, 
sal_Unicode token, sal_Int32 nStartPos /* = 0*/ ) const
+// return position of a special character
+sal_Int32 ImpPosToken(const OUStringBuffer & sFormat, sal_Unicode token, 
sal_Int32 nStartPos = 0)
 {
 sal_Int32 nLength = sFormat.getLength();
 for ( sal_Int32 i=nStartPos; i=0 ; i++ )
@@ -3118,6 +3120,8 @@ sal_Int32 SvNumberFormatter::ImpPosToken ( const 
OUStringBuffer & sFormat, sal_U
 return -2;
 }
 
+}
+
 OUString SvNumberFormatter::GenerateFormat(sal_uInt32 nIndex,
LanguageType eLnge,
bool bThousand,
commit 49189bb8823adc6a76d3f33b34c02d6a640df96a
Author: Caolán McNamara 
AuthorDate: Wed Mar 20 16:43:26 2024 +
Commit: Caolán McNamara 
CommitDate: Thu Mar 21 20:34:44 2024 +0100

Related: tdf#160056 this can be static

Change-Id: I1172854a1bf00e74adbe350c54e4e98ea38b0b35
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165072
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/include/svl/numformat.hxx b/include/svl/numformat.hxx
index e28bd3a1af94..ffbc5f8f9769 100644
--- a/include/svl/numformat.hxx
+++ b/include/svl/numformat.hxx
@@ -356,7 +356,7 @@ public:
 NF_INDEX_TABLE_ENTRIES if it's not a builtin format.
 @see NfIndexTableOffset
  */
-NfIndexTableOffset GetIndexTableOffset(sal_uInt32 nFormat) const;
+static NfIndexTableOffset GetIndexTableOffset(sal_uInt32 nFormat);
 
 /** Set evaluation type and order of input date strings
 @see NfEvalDateFormat
diff --git a/sc/source/ui/view/formatsh.cxx b/sc/source/ui/view/formatsh.cxx
index c57aa34a57ce..d95c5e09810c 100644
--- a/sc/source/ui/view/formatsh.cxx
+++ b/sc/source/ui/view/formatsh.cxx
@@ -1736,7 +1736,7 @@ void ScFormatShell::GetNumFormatState( SfxItemSet& rSet )
   // 

[Bug 160298] Shrink size of side panel manually

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160298

V Stuart Foote  changed:

   What|Removed |Added

 CC||vsfo...@libreoffice.org

--- Comment #2 from V Stuart Foote  ---
And, if you need greater width reduction, edit the Expert Configuration stanza
"MinimumWidth" to its 'False' value.  Tools -> Options -> Advanced -> Open
Expert Configuration  and search for MinimumWidth. Click the 'Edit' button at
the bottom to toggle this Boolean. Then OK out.

YMMV, but you can now drag all the SideBar decks narrower than their
minimum--until each will collapse the SB.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158353] FILEOPEN XLSX Wrong round

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158353

--- Comment #11 from Mike Kaganski  ---
https://gerrit.libreoffice.org/c/core/+/165142 will take care of the display
issue. However, let me make this issue strictly about the problem of wrong
number roundtrip: the value of 57.3749993, that is stored in the
original file, must stay 57.3749993 (or 57.374999, which
represents the same IEEE 754 64-bit binary value) on export, and must not be
rounded to 57.375 in the file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 143148] Use pragma once instead of include guards (Episode 2: Endgame)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143148

--- Comment #128 from Commit Notification 
 ---
Christopher Loi committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7c76332b52d9b3b967beecc1fe163eea783c471e

tdf#143148: Replace include guards with pragma once

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: svx/source

[Christopher Loi (via logerrit)]

 svx/source/inc/celltypes.hxx |5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

New commits:
commit 7c76332b52d9b3b967beecc1fe163eea783c471e
Author: Christopher Loi 
AuthorDate: Thu Mar 21 05:24:32 2024 -0700
Commit: Ilmari Lauhakangas 
CommitDate: Thu Mar 21 18:54:30 2024 +0100

tdf#143148: Replace include guards with pragma once

Change-Id: I00cee3dc61231a0cc344d404eed4cedda41f4d7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165100
Reviewed-by: Christopher Loi 
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/svx/source/inc/celltypes.hxx b/svx/source/inc/celltypes.hxx
index f70e386db8a4..7dfc9d10b4df 100644
--- a/svx/source/inc/celltypes.hxx
+++ b/svx/source/inc/celltypes.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_SVX_SOURCE_INC_CELLTYPES_HXX
-#define INCLUDED_SVX_SOURCE_INC_CELLTYPES_HXX
+#pragma once
 
 #include 
 #include 
@@ -81,6 +80,4 @@ private:
 };
 }
 
-#endif
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

[Bug 160306] Formatting decimals can result in wrong rounding

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160306

Mike Kaganski  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com
   |desktop.org |
 Status|NEW |ASSIGNED

--- Comment #6 from Mike Kaganski  ---
https://gerrit.libreoffice.org/c/core/+/165142

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 107658] Display of hidden text when toggling formatting marks should be enabled by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107658

--- Comment #17 from Justin L  ---
(In reply to Justin L from comment #16)
> If this default ever changes to default to enabled, that patch can be
> reverted.
The patch has already been reverted. Turns out that it is really bad during
collaboration for SOME people to see text with hidden content and others to not
be seeing hidden content.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 145734] [META] Qt6 VCL plugin bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145734

--- Comment #13 from Michael Weghorn  ---
(In reply to Dashon from comment #12)
> Hey, would this be the correct place to track an issue on Arch where using
> `SAL_USE_VCLPLUGIN=qt6 libreoffice` ui is too big compared to
> `SAL_USE_VCLPLUGIN=qt5 libreoffice`? Arch is currently shipping plasma 6 and
> this is something I have noticed after the update. I saw an issue that may
> be related to this matter, but that issue talked about having different
> display scaling per screen where as I am using 125% scaling on both of my
> monitors at the same resolution.

This sounds like it might be the same as tdf#159915, which has been fixed in
the meanwhile.
If not, please create a new issue and set its "Blocks" field to "145734" (i.e.
this bug, so it automatically shows up as a dependency).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160307] New: Cannot place cursor in field/content control/table when a group-shape wraps behind it

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160307

Bug ID: 160307
   Summary: Cannot place cursor in field/content control/table
when a group-shape wraps behind it
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: bibisected, bisected
  Severity: trivial
  Priority: low
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jl...@mail.com
CC: bakos.attilakar...@nisz.hu, jl...@mail.com

Created attachment 193233
  --> https://bugs.documentfoundation.org/attachment.cgi?id=193233=edit
Restaurant brochure.docx: hard to place cursor inside the table

Starting in LO 7.4, I have to delete (or move out of the way) the entire-page
group-shape before I can get my cursor into the content controls. (Note that
the text is white on white in the cell.) I focused on the input control "Put a
quote here to highlight this issue of your newsletter."

The content control itself is a blockSDT in a table cell. There is some kind of
pseudo-object that runs top-to-bottom in the middle of the page that seems to
be causing the grief.

7.4 commit 2951cbdf3a6e2b62461665546b47e1d253fcb834
Author: Attila Bakos (NISZ) on Wed Nov 10 14:10:11 2021 +0100
tdf#143574 OOXML export/import of textboxes in group shapes

I assume this is just a "consequential regression", and not a flaw in the patch
itself.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157115] crash on inserting chart (gtk3): Assertion `m_pBody != NULL' failed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157115

--- Comment #3 from xamigi56  ---
Great knowledge, do anyone mind merely reference back to it  Strands nyt game  
https://strandsgame.net/

-- 
You are receiving this mail because:
You are the assignee for the bug.

translations.git: Changes to 'refs/tags/libreoffice-7.6.6.3'

[Christian Lohmaier (via logerrit)]

Tag 'libreoffice-7.6.6.3' created by Christian Lohmaier 
 at 2024-03-21 17:21 +

Tag libreoffice-7.6.6.3
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmX8bH4ACgkQ9DSh76/u
rqOOfRAAwA7aKy7s6ddh6mH5tg2no7kcZX9D+9N4jt/jKgTOv5ZIPfDyDeInF8xQ
JleKmsWx1WmCvfSSN195t9PmaFRiaA3DI2FcswvwGKVVEvjgTkzbVkLMBW81UW26
T7QimVZOkEHK7SsEQXnu0Y6tIDlXT2XRuUZk08f9lNW09Njr/dpFJIua4aUEaMCR
0QV6L05nsvgjhkk2iGwzGhj5OZAUb8fBo1Zi3SdSaUMI16GmSN43ch/O5ZXPR9BR
NFmA5VsyVrM6X9v76IGX8vL+dwC7flb3JOsXbFxUMxn5w8ONfCg7Cxb2xMX98ORx
wSIfip43cBerBnKDNnI0KcMCqV6kLrjIssjbAVVgzWduzIy8oViC7h0zbrYmBOVK
c9Pjqv9KtK4vBAEM0Y81Zd+8HjXAdtxUgSZI2eoR5UMmlrGiUEm8kqtKwQzpmSjv
oGrFCPxOAULo0wpwxLiKmC+dU27W8Z6tbnUCPKnikK7ZMKtvGgLNepbpF3t9wVgo
f0FwB8wJQHLgKds9bNmJWQY4vPMreAbNUEc6puZ3cKu+2serC/ltjOx3/jPbgYYR
S2fA+tngqYiAdjiN734QjDJ9I/8BNkt25vxdUQDMYIPy9u3o2WAkmEuOGA1zAMD8
/12l/OV6bCYtUHx1q23BnW/pgDmxdqAdDBkaqQMSulUWwKdzKW8=
=jPh4
-END PGP SIGNATURE-

Changes since libreoffice-7-6-branch-point-33:
---
 0 files changed
---

help.git: Changes to 'refs/tags/libreoffice-7.6.6.3'

[Christian Lohmaier (via logerrit)]

Tag 'libreoffice-7.6.6.3' created by Christian Lohmaier 
 at 2024-03-21 17:21 +

Tag libreoffice-7.6.6.3
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmX8bH4ACgkQ9DSh76/u
rqNQ2Q/9GYhpkiuBe45THFMoTGrI1UHoflQ3sUzVy9R147QXRBNZlYndijdmWtvC
lTHBJNrkq42ed46TRCgn2z9tSXeRFkapdWctiu6NFXmYQCS/6eSTq+KNZ2O8EqHI
nncqLsth1Vf6MPXe5epCkTurE6lDmDlvmIo181D0boeGNs71mrxfSPxtd8cjV+Rc
IxJjjrPYREeSo1X28SURVRydFYqHKB5RSl9o0yLlknTTXX2Y8I7zmjntlkkVMeFL
OPGQKyqy2jC7WY4VIB9p5UvA0K12KoJxxypD1kG8YEM/S9FPdA51ZlU9pHk3LuDB
V0ybbsLJT5udZeHbPJdkolIEBS8M2CTj5ghw0tEZFa37EiZBxOs8ze/pHgdspLWT
D56ek7jZfwPi9Zphk7QOufRt6gPjsoMbM3nsQdGbfbtlA0MRGd4t0/1RLkGKu79n
2xPch841+o5pqZQe615eoPVgV4wIN/yi2IBeo45yrP5qcKl8q2R+CY/7pJWY1l1U
8Yx9vy+6pMYgbFw5Oc0fiP6SbKW2Z4X7Tz7zqHL0J/9+Ap8G+u3y27YG+gvrNYuT
uZwjGf56mOgKuUaEG9ORaAZMKHLznFhMsUou4EiZsL+d6HleJpnftmTUn4FL72sl
zbgCPJxBg8MjByDg8dVZet7aS2Yg2MKs4oKq4NTgCbP5zWXegIY=
=BQe8
-END PGP SIGNATURE-

Changes since libreoffice-7-6-branch-point-35:
---
 0 files changed
---

core.git: Changes to 'refs/tags/libreoffice-7.6.6.3'

[Christian Lohmaier (via logerrit)]

Tag 'libreoffice-7.6.6.3' created by Christian Lohmaier 
 at 2024-03-21 17:21 +

Tag libreoffice-7.6.6.3
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmX8bH4ACgkQ9DSh76/u
rqPiQRAAixFdsMCCZSaeo9oIizHdb4jMJTp+iKgcHSih6Imm/fTQSmdqc3pfEl0L
tSxcoggIhwD2jWWxDkVblUbUyabYQSxYWPAxoAkOb2sPu8ZkhiJAITAmpWmtWRCm
DIl0OUDqImnkmmp1/0i37ehjW9xUJLjvyd++ULL41mosAy+HEqwuduty0canaT+h
OK6bhjEong2ewtBRw/PkeHKGCVjMVtG+D/2vw9galFasLc2TI3UJvUN9rK8rvCo+
A2KUEmJ97/bydHuNchxBwci9221rapLSHLVJTbdjUBk/y6faFv+3XsaSYx+uTqZf
TP3tJdAgproaIaDeCP5MXIDJe//O7+pU4IyZVvZN3DGKCOFjNJDQe8SmiLXHep3Q
RtfBBfYvX0jlfnktKDB4dVVrIpwcYpYgW5zIEyysAV60e20Ro2y2vE8QB3KSeOb6
jI+y5r6giV46Gem2eyyX0EY1s8Q9gaH44Kn5EqUrXEF0cvqIr3wCx6NZJg7S4tLL
IViBO7fqyX+hNwwit6btoGQ+G81P9Vb1S9fgsPSg8iQ5sizM55aVn2JIhYE19F9A
sVADEZ3uePPc2g5ZLzHT4lzlCcz/9joCQWuKlfaHHrOzegmO1bcIedkG3l76/ShL
nasF0sgqXSEoS30PAHGHlBFFyJ7UIicHFdgF554YV1yY+Tr1368=
=jFAM
-END PGP SIGNATURE-

Changes since libreoffice-7-6-branch-point-1265:
---
 0 files changed
---

dictionaries.git: Changes to 'refs/tags/libreoffice-7.6.6.3'

[Christian Lohmaier (via logerrit)]

Tag 'libreoffice-7.6.6.3' created by Christian Lohmaier 
 at 2024-03-21 17:20 +

Tag libreoffice-7.6.6.3
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmX8bHoACgkQ9DSh76/u
rqOwng/9EVHX1u5cSwVDv7cJlrEZ+etzd5OMT7S6J3xKKtGK8GIPhJB5pKVzN1d5
eQkIrxXsTC24Z5rvpiv4m6t0t12MmUOLNHsjshGg5vRGQF/wtp9gv7y3E7vMa+VM
d3lwkDuyth7RI7qRyedlvkQLbiIHs6eC13VQyYpz8KhHJbDAs9JMod2P1IsW9Rg6
JfuyphrBmx7LFxyBXW8kqgtmoY9jHO86KBwuuDgq2mZ73jtlNZ0LHAoEu2Uk39aP
/zfdARYbS+YO5az0G/NJuats9JXsfzvX1TOPz77tpTbxhaWK3mw6PwHC/pkagixU
HW8AyD+p+FLsMzCiikJjzhlVvsS1vrtM3WkGNMjf2i7EfUkRu/eohq3aQY5BAeYQ
T2hTsjCQtUEjGVJZPSbFKzJZslLUBrENsMqqcCb5Yzyq5vfNY6Pj1WtIbB5IHAnt
Zg7dR/edxkH1jXzP3sXpF2Eg5V2ZuTB5Jgda6Ke4HSpV4FWb8sOhYgO6H/+tFjrg
S4gZ4su28WlpY23lXS72kA4cEzLAgUxAI9vIw3pQ+PSW7LxRS5ABWklMeExn6+HB
DnAmOuPptoiluYl8MAadmc5spW3YLwRqJhTT5fhFHhTjthM9IA5QBnaeNrOblKjm
6umQgXf79KLTs28Ht6asqa4QpsHmhTOIwhNYqRx8DQmOj+xu01k=
=+rY5
-END PGP SIGNATURE-

Changes since libreoffice-7-6-branch-point-8:
---
 0 files changed
---

core.git: Branch 'libreoffice-7-6-6' - configure.ac

[Christian Lohmaier (via logerrit)]

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a18f1488bc234b6a374af7677cab5b684d70718d
Author: Christian Lohmaier 
AuthorDate: Thu Mar 21 18:21:23 2024 +0100
Commit: Christian Lohmaier 
CommitDate: Thu Mar 21 18:21:23 2024 +0100

bump product version to 7.6.6.3.0+

Change-Id: Id5ad25330e617fba9b44692b48a916ab3e23491d

diff --git a/configure.ac b/configure.ac
index 8801f9cb0850..79b3da5085cd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[7.6.6.2.0+],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[7.6.6.3.0+],[],[],[http://documentfoundation.org/])
 
 dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just 
fine if it is installed
 dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails 
hard

[Bug 147565] Browsing comments in the navigation pane also browses hidden solved comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147565

--- Comment #48 from xamigi56  ---
I would like to use the opportunity of saying thanks to you for your
professional direction I have constantly enjoyed checking out your site.
Strands nyt game  https://strandsgame.net/

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'libreoffice-7-6-6' - translations

[Christian Lohmaier (via logerrit)]

 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3f4604deb964892cd68c89de6cbaedb7bfb668ee
Author: Christian Lohmaier 
AuthorDate: Thu Mar 21 18:16:01 2024 +0100
Commit: Gerrit Code Review 
CommitDate: Thu Mar 21 18:16:01 2024 +0100

Update git submodules

* Update translations from branch 'libreoffice-7-6-6'
  to 1bfa04948ba57c372badcb8880cd2f12533d2db0
  - update translations for 7.6.6 rc3

and force-fix errors using pocheck

Change-Id: I27666de13601bf7a1fa144f13385426b3d16dbf8
(cherry picked from commit ee46af8eb1eeef8147c439b7b89b1779be2d1bbe)

diff --git a/translations b/translations
index 971622e0f2da..1bfa04948ba5 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit 971622e0f2da9d21bc0e2944776a0abe2fd260c8
+Subproject commit 1bfa04948ba57c372badcb8880cd2f12533d2db0

translations.git: Branch 'libreoffice-7-6-6' - source/ast source/bg source/ca source/dsb source/es source/gl source/gug source/hsb source/pl

[Christian Lohmaier (via logerrit)]

 source/ast/cui/messages.po |4 
 source/ast/helpcontent2/source/text/scalc/guide.po |4 
 source/ast/helpcontent2/source/text/sdatabase.po   |   10 
 source/ast/helpcontent2/source/text/shared/guide.po|4 
 source/ast/helpcontent2/source/text/simpress/01.po |4 
 source/ast/helpcontent2/source/text/swriter/00.po  |4 
 source/ast/helpcontent2/source/text/swriter/guide.po   |6 
 source/ast/officecfg/registry/data/org/openoffice/Office/UI.po |7 
 source/ast/sw/messages.po  |   14 
 source/bg/officecfg/registry/data/org/openoffice/Office/UI.po  |8 
 source/ca/helpcontent2/source/text/sdatabase.po|   10 
 source/ca/helpcontent2/source/text/swriter.po  |8 
 source/ca/helpcontent2/source/text/swriter/00.po   |4 
 source/dsb/helpcontent2/source/text/shared/02.po   |  166 
+-
 source/dsb/helpcontent2/source/text/swriter/02.po  |4 
 source/es/chart2/messages.po   |8 
 source/es/cui/messages.po  |6 
 source/es/helpcontent2/source/text/scalc/01.po |4 
 source/es/helpcontent2/source/text/scalc/guide.po  |4 
 source/es/helpcontent2/source/text/schart/01.po|6 
 source/es/helpcontent2/source/text/sdatabase.po|8 
 source/es/helpcontent2/source/text/swriter.po  |   18 -
 source/es/helpcontent2/source/text/swriter/00.po   |4 
 source/gl/chart2/messages.po   |   11 
 source/gl/officecfg/registry/data/org/openoffice/Office/UI.po  |8 
 source/gl/sc/messages.po   |   11 
 source/gug/helpcontent2/source/text/scalc/01.po|4 
 source/gug/helpcontent2/source/text/scalc/guide.po |4 
 source/gug/helpcontent2/source/text/schart/01.po   |6 
 source/gug/helpcontent2/source/text/sdatabase.po   |8 
 source/gug/helpcontent2/source/text/swriter.po |   18 -
 source/gug/helpcontent2/source/text/swriter/00.po  |4 
 source/hsb/helpcontent2/source/text/shared/02.po   |   14 
 source/hsb/helpcontent2/source/text/swriter/02.po  |4 
 source/pl/editeng/messages.po  |   10 
 35 files changed, 204 insertions(+), 213 deletions(-)

New commits:
commit 1bfa04948ba57c372badcb8880cd2f12533d2db0
Author: Christian Lohmaier 
AuthorDate: Thu Mar 21 18:10:57 2024 +0100
Commit: Christian Lohmaier 
CommitDate: Thu Mar 21 18:16:16 2024 +0100

update translations for 7.6.6 rc3

and force-fix errors using pocheck

Change-Id: I27666de13601bf7a1fa144f13385426b3d16dbf8
(cherry picked from commit ee46af8eb1eeef8147c439b7b89b1779be2d1bbe)

diff --git a/source/ast/cui/messages.po b/source/ast/cui/messages.po
index c392eae6389..3f4290196ce 100644
--- a/source/ast/cui/messages.po
+++ b/source/ast/cui/messages.po
@@ -4,7 +4,7 @@ msgstr ""
 "Project-Id-Version: PACKAGE VERSION
"
 "Report-Msgid-Bugs-To: 
https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice_status=UNCONFIRMED=UI
"
 "POT-Creation-Date: 2024-03-18 14:55+0100
"
-"PO-Revision-Date: 2024-03-19 10:56+
"
+"PO-Revision-Date: 2024-03-20 16:37+
"
 "Last-Translator: Adolfo Jayme Barrientos 
"
 "Language-Team: Asturian 

"
 "Language: ast
"
@@ -5877,7 +5877,7 @@ msgstr "Triba:"
 #: cui/uiconfig/ui/bulletandposition.ui:280
 msgctxt "bulletandposition|extended_tip|numfmtlb"
 msgid "Select the level(s) that you want to modify. To apply the options to 
all the levels, select “1-10”."
-msgstr ""
+msgstr "Esbilla los niveles que quies modificar. P'aplicar les opciones a 
tolos niveles, esbilla «1-10»."
 
 #. mp5Si
 #: cui/uiconfig/ui/bulletandposition.ui:293
diff --git a/source/ast/helpcontent2/source/text/scalc/guide.po 
b/source/ast/helpcontent2/source/text/scalc/guide.po
index 1abc501b093..610b0a95280 100644
--- a/source/ast/helpcontent2/source/text/scalc/guide.po
+++ b/source/ast/helpcontent2/source/text/scalc/guide.po
@@ -4,7 +4,7 @@ msgstr ""
 "Project-Id-Version: guide
"
 "Report-Msgid-Bugs-To: 
https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice_status=UNCONFIRMED=UI
"
 "POT-Creation-Date: 2023-05-31 16:28+0200
"
-"PO-Revision-Date: 2024-03-16 16:37+
"
+"PO-Revision-Date: 2024-03-21 17:00+
"
 "Last-Translator: Adolfo Jayme Barrientos 
"
 "Language-Team: Asturian 

"
 "Language: ast
"
@@ -4155,7 +4155,7 @@ msgctxt ""
 "par_id3151075
"
 "help.text"
 msgid "You can change the currency format in the Format Cells dialog (choose 

core.git: Branch 'libreoffice-7-6' - translations

[Christian Lohmaier (via logerrit)]

 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6e659fd1947a2f78570868a41333f4a0808e993d
Author: Christian Lohmaier 
AuthorDate: Thu Mar 21 18:15:23 2024 +0100
Commit: Gerrit Code Review 
CommitDate: Thu Mar 21 18:15:23 2024 +0100

Update git submodules

* Update translations from branch 'libreoffice-7-6'
  to ee46af8eb1eeef8147c439b7b89b1779be2d1bbe
  - update translations for 7.6.6 rc3

and force-fix errors using pocheck

Change-Id: I27666de13601bf7a1fa144f13385426b3d16dbf8

diff --git a/translations b/translations
index 2c72d6fd1b78..ee46af8eb1ee 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit 2c72d6fd1b7800164baf7a3d5afbeb53b7734e49
+Subproject commit ee46af8eb1eeef8147c439b7b89b1779be2d1bbe

translations.git: Branch 'libreoffice-7-6' - source/ast source/bg source/ca source/dsb source/es source/gl source/gug source/hsb source/pl

[Christian Lohmaier (via logerrit)]

 source/ast/cui/messages.po |4 
 source/ast/helpcontent2/source/text/scalc/guide.po |4 
 source/ast/helpcontent2/source/text/sdatabase.po   |   10 
 source/ast/helpcontent2/source/text/shared/guide.po|4 
 source/ast/helpcontent2/source/text/simpress/01.po |4 
 source/ast/helpcontent2/source/text/swriter/00.po  |4 
 source/ast/helpcontent2/source/text/swriter/guide.po   |6 
 source/ast/officecfg/registry/data/org/openoffice/Office/UI.po |7 
 source/ast/sw/messages.po  |   14 
 source/bg/officecfg/registry/data/org/openoffice/Office/UI.po  |8 
 source/ca/helpcontent2/source/text/sdatabase.po|   10 
 source/ca/helpcontent2/source/text/swriter.po  |8 
 source/ca/helpcontent2/source/text/swriter/00.po   |4 
 source/dsb/helpcontent2/source/text/shared/02.po   |  166 
+-
 source/dsb/helpcontent2/source/text/swriter/02.po  |4 
 source/es/chart2/messages.po   |8 
 source/es/cui/messages.po  |6 
 source/es/helpcontent2/source/text/scalc/01.po |4 
 source/es/helpcontent2/source/text/scalc/guide.po  |4 
 source/es/helpcontent2/source/text/schart/01.po|6 
 source/es/helpcontent2/source/text/sdatabase.po|8 
 source/es/helpcontent2/source/text/swriter.po  |   18 -
 source/es/helpcontent2/source/text/swriter/00.po   |4 
 source/gl/chart2/messages.po   |   11 
 source/gl/officecfg/registry/data/org/openoffice/Office/UI.po  |8 
 source/gl/sc/messages.po   |   11 
 source/gug/helpcontent2/source/text/scalc/01.po|4 
 source/gug/helpcontent2/source/text/scalc/guide.po |4 
 source/gug/helpcontent2/source/text/schart/01.po   |6 
 source/gug/helpcontent2/source/text/sdatabase.po   |8 
 source/gug/helpcontent2/source/text/swriter.po |   18 -
 source/gug/helpcontent2/source/text/swriter/00.po  |4 
 source/hsb/helpcontent2/source/text/shared/02.po   |   14 
 source/hsb/helpcontent2/source/text/swriter/02.po  |4 
 source/pl/editeng/messages.po  |   10 
 35 files changed, 204 insertions(+), 213 deletions(-)

New commits:
commit ee46af8eb1eeef8147c439b7b89b1779be2d1bbe
Author: Christian Lohmaier 
AuthorDate: Thu Mar 21 18:10:57 2024 +0100
Commit: Christian Lohmaier 
CommitDate: Thu Mar 21 18:10:57 2024 +0100

update translations for 7.6.6 rc3

and force-fix errors using pocheck

Change-Id: I27666de13601bf7a1fa144f13385426b3d16dbf8

diff --git a/source/ast/cui/messages.po b/source/ast/cui/messages.po
index c392eae6389..3f4290196ce 100644
--- a/source/ast/cui/messages.po
+++ b/source/ast/cui/messages.po
@@ -4,7 +4,7 @@ msgstr ""
 "Project-Id-Version: PACKAGE VERSION
"
 "Report-Msgid-Bugs-To: 
https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice_status=UNCONFIRMED=UI
"
 "POT-Creation-Date: 2024-03-18 14:55+0100
"
-"PO-Revision-Date: 2024-03-19 10:56+
"
+"PO-Revision-Date: 2024-03-20 16:37+
"
 "Last-Translator: Adolfo Jayme Barrientos 
"
 "Language-Team: Asturian 

"
 "Language: ast
"
@@ -5877,7 +5877,7 @@ msgstr "Triba:"
 #: cui/uiconfig/ui/bulletandposition.ui:280
 msgctxt "bulletandposition|extended_tip|numfmtlb"
 msgid "Select the level(s) that you want to modify. To apply the options to 
all the levels, select “1-10”."
-msgstr ""
+msgstr "Esbilla los niveles que quies modificar. P'aplicar les opciones a 
tolos niveles, esbilla «1-10»."
 
 #. mp5Si
 #: cui/uiconfig/ui/bulletandposition.ui:293
diff --git a/source/ast/helpcontent2/source/text/scalc/guide.po 
b/source/ast/helpcontent2/source/text/scalc/guide.po
index 1abc501b093..610b0a95280 100644
--- a/source/ast/helpcontent2/source/text/scalc/guide.po
+++ b/source/ast/helpcontent2/source/text/scalc/guide.po
@@ -4,7 +4,7 @@ msgstr ""
 "Project-Id-Version: guide
"
 "Report-Msgid-Bugs-To: 
https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice_status=UNCONFIRMED=UI
"
 "POT-Creation-Date: 2023-05-31 16:28+0200
"
-"PO-Revision-Date: 2024-03-16 16:37+
"
+"PO-Revision-Date: 2024-03-21 17:00+
"
 "Last-Translator: Adolfo Jayme Barrientos 
"
 "Language-Team: Asturian 

"
 "Language: ast
"
@@ -4155,7 +4155,7 @@ msgctxt ""
 "par_id3151075
"
 "help.text"
 msgid "You can change the currency format in the Format Cells dialog (choose Format - Cells - Numbers tab) by two country settings. 
In the Language 

core.git: Branch 'libreoffice-7-6-6' - configure.ac download.lst

[Michael Stahl (via logerrit)]

 configure.ac |2 +-
 download.lst |4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit c3f1a904180abed14779bc165382406e1d20b4bd
Author: Michael Stahl 
AuthorDate: Wed Mar 20 10:52:09 2024 +0100
Commit: Christian Lohmaier 
CommitDate: Thu Mar 21 18:13:57 2024 +0100

python3: upgrade to release 3.8.19

Fixes CVE-2023-6597 and also CVE-2024-0450

Change-Id: Iebca2608e16a966356736201c63f1be5185430d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165053
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 0633e4b4205334dd65ec64d7f3e306ee125e31be)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165009
Reviewed-by: Xisco Fauli 
(cherry picked from commit a65cb686e8e9bf842c354b77945a0dad252c4188)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165115
Tested-by: Christian Lohmaier 
Reviewed-by: Christian Lohmaier 

diff --git a/configure.ac b/configure.ac
index 29f6ba8bfd2f..8801f9cb0850 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9955,7 +9955,7 @@ if test \( "$cross_compiling" = yes -a -z 
"$PYTHON_FOR_BUILD" \) -o "$enable_pyt
 SYSTEM_PYTHON=
 PYTHON_VERSION_MAJOR=3
 PYTHON_VERSION_MINOR=8
-PYTHON_VERSION=${PYTHON_VERSION_MAJOR}.${PYTHON_VERSION_MINOR}.18
+PYTHON_VERSION=${PYTHON_VERSION_MAJOR}.${PYTHON_VERSION_MINOR}.19
 if ! grep -q -i python.*${PYTHON_VERSION} ${SRC_ROOT}/download.lst; then
 AC_MSG_ERROR([PYTHON_VERSION ${PYTHON_VERSION} but no matching file in 
download.lst])
 fi
diff --git a/download.lst b/download.lst
index 5743c6c951a3..21c6aa046ffb 100644
--- a/download.lst
+++ b/download.lst
@@ -470,8 +470,8 @@ POSTGRESQL_TARBALL := postgresql-13.11.tar.bz2
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts
-PYTHON_SHA256SUM := 
3ffb71cd349a326ba7b2fadc7e7df86ba577dd9c4917e52a8401adbda7405e3f
-PYTHON_TARBALL := Python-3.8.18.tar.xz
+PYTHON_SHA256SUM := 
d2807ac69f69b84fd46a0b93bbd02a4fa48d3e70f4b2835ff0f72a2885040076
+PYTHON_TARBALL := Python-3.8.19.tar.xz
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts

[Bug 159730] RTF table split document layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159730

--- Comment #9 from Commit Notification 
 ---
Oliver Specht committed a patch related to this issue.
It has been pushed to "libreoffice-7-6-6":

https://git.libreoffice.org/core/commit/b4c354aa8ba941071ef5fe848eb8eb7ccacd8380

Revert "tdf#159730 add compatibility option in RTF import"

It will be available in 7.6.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'libreoffice-7-6-6' - writerfilter/source

[Oliver Specht (via logerrit)]

 writerfilter/source/dmapper/DomainMapper.cxx |3 ---
 writerfilter/source/dmapper/PropertyIds.cxx  |1 -
 writerfilter/source/dmapper/PropertyIds.hxx  |1 -
 3 files changed, 5 deletions(-)

New commits:
commit b4c354aa8ba941071ef5fe848eb8eb7ccacd8380
Author: Oliver Specht 
AuthorDate: Wed Mar 20 16:25:17 2024 +0100
Commit: Christian Lohmaier 
CommitDate: Thu Mar 21 18:13:34 2024 +0100

Revert "tdf#159730 add compatibility option in RTF import"

This reverts commit 3b04e74503ec6d07dc4befdb756e6abdc3de4e58.

Reason for revert: The compatibility option is the wrong approach. This 
results in wrong line calculation as seen in tdf#159730#c6.
The problem that really needs to be fixed is the 9pt attribute of the 
hidden line breaks in the first paragraph that are used to calculate the height 
of the first paragraph.
Only the 1pt font attribute of the remaining visible space should define 
the line height.

Change-Id: I6e0a1a499adaf2df9f68afbcfd6afcd6677e8f76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165006
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
Signed-off-by: Xisco Fauli 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165120
Tested-by: Christian Lohmaier 
Reviewed-by: Christian Lohmaier 

diff --git a/writerfilter/source/dmapper/DomainMapper.cxx 
b/writerfilter/source/dmapper/DomainMapper.cxx
index ecd6ad6b242a..c4001cf0fe61 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -129,9 +129,6 @@ DomainMapper::DomainMapper( const uno::Reference< 
uno::XComponentContext >& xCon
 m_pImpl->SetDocumentSettingsProperty(
 getPropertyName(PROP_APPLY_PARAGRAPH_MARK_FORMAT_TO_NUMBERING),
 uno::Any(true));
-m_pImpl->SetDocumentSettingsProperty(
-getPropertyName(PROP_TABS_AND_BLANKS_FOR_LINE_CALCULATION),
-uno::Any(true));
 
 // Don't load the default style definitions to avoid weird mix
 m_pImpl->SetDocumentSettingsProperty("StylesNoDefault", 
uno::Any(true));
diff --git a/writerfilter/source/dmapper/PropertyIds.cxx 
b/writerfilter/source/dmapper/PropertyIds.cxx
index 4069a9ac7fe5..11ef07230fad 100644
--- a/writerfilter/source/dmapper/PropertyIds.cxx
+++ b/writerfilter/source/dmapper/PropertyIds.cxx
@@ -378,7 +378,6 @@ namespace
 { PROP_CURSOR_NOT_IGNORE_TABLES_IN_HF, u"CursorNotIgnoreTables"},
 { PROP_PARA_CONNECT_BORDERS, u"ParaIsConnectBorder"},
 { PROP_DECORATIVE, u"Decorative"},
-{ PROP_TABS_AND_BLANKS_FOR_LINE_CALCULATION, 
u"IgnoreTabsAndBlanksForLineCalculation"},
 });
 } // end anonymous ns
 
diff --git a/writerfilter/source/dmapper/PropertyIds.hxx 
b/writerfilter/source/dmapper/PropertyIds.hxx
index 25099a684dcd..6708c6dfbf35 100644
--- a/writerfilter/source/dmapper/PropertyIds.hxx
+++ b/writerfilter/source/dmapper/PropertyIds.hxx
@@ -377,7 +377,6 @@ enum PropertyIds
 ,PROP_RTL_GUTTER
 ,PROP_CURSOR_NOT_IGNORE_TABLES_IN_HF
 ,PROP_PARA_CONNECT_BORDERS
-,PROP_TABS_AND_BLANKS_FOR_LINE_CALCULATION
 };
 
 //Returns the UNO string equivalent to eId.

[Bug 158353] FILEOPEN XLSX Wrong round

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158353

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=16
   ||0306

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160306] Formatting decimals can result in wrong rounding

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160306

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||8353

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158190] Calc ROUND() function issue in specific range

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158190

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=16
   ||0306

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160306] Formatting decimals can result in wrong rounding

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160306

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||8190

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160186] Changing Table Auto value or Entry required results in full libreoffice suite crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160186

--- Comment #6 from cont...@bluesanta.io ---
(In reply to Stéphane Guillou (stragu) from comment #5)
> (In reply to contact from comment #2)
> > Created attachment 193114 [details]
> Thank you, but I still can't reproduce. I tried setting the 2 tables'
> integer fields to AutoValue = Yes and then editing the tables further, but
> no crash.
> 
> (In reply to contact from comment #0)
> > 4. Attempt to Change auto value increment etc. so that it is no longer
> > required etc.
> How do you do that?
> 
> Any chance you could provide steps starting from your attachment, that
> consistently crash it for you?
> 
> Thank you

Hi Stephane,

I don't know why I would be receiving the error and you would not. I am on
Mantic 23.10, which has created instabilities in other software distributions
that I also use. Perhaps there's something there?

The issue is persistent and has occurred on around 5 more occasions since last
we spoke.

Here is the tutorial series I am following:
https://www.youtube.com/watch?v=ry7xn4VG0S4_channel=TheFrugalComputerGuy

Here is the link to the demo database download page that the tutorial creator
provides: https://thefrugalcomputerguy.com/seriespg.php?ser=15#Vid59

I am going through the tutorial series step-by-step and following everything
the tutorial provides gives, without variation. I frequently download the demo
sample databases found on the second link above, and the same issue repeats.

To repeat the issue, you should be able to download one of the databases from
the above page, open it up, edit a table column to have a new setting, and then
it will crash. I've had this happening while dealing with auto incrementing
values, changing the number of decimal places in a numeric, and other settings
as well.

Are there any queries or bug tracing commands I could run to help you pin point
the issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: 3 commits - sfx2/source sw/qa sw/source vcl/win

[Mike Kaganski (via logerrit)]

 sfx2/source/control/bindings.cxx |1 +
 sw/qa/extras/unowriter/unowriter.cxx |   21 +
 sw/source/core/unocore/unoobj.cxx|   12 +---
 vcl/win/dtrans/MtaOleClipb.cxx   |   35 +--
 vcl/win/dtrans/WinClipboard.cxx  |   14 +-
 5 files changed, 61 insertions(+), 22 deletions(-)

New commits:
commit 1c52e94b2d926875d1a108c54988dbcb2dc9d017
Author: Mike Kaganski 
AuthorDate: Wed Mar 20 16:24:07 2024 +0500
Commit: Mike Kaganski 
CommitDate: Thu Mar 21 17:51:23 2024 +0100

tdf#160278: restore cursor bounds properly

The passed string length is not a correct measure of how many steps
should the selection expand in the resulting text: the cursor goes
over glyphs, not over UTF-16 code units. Thus, it's easier to store
the position prior to insertion, and restore it from the indexes.

Change-Id: I1d592ff30199007ba3a99d7e1a6d2db2da35f1cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165056
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sw/qa/extras/unowriter/unowriter.cxx 
b/sw/qa/extras/unowriter/unowriter.cxx
index c4bcbb7f5dd6..a11e928e8c1d 100644
--- a/sw/qa/extras/unowriter/unowriter.cxx
+++ b/sw/qa/extras/unowriter/unowriter.cxx
@@ -1200,6 +1200,27 @@ CPPUNIT_TEST_FIXTURE(SwUnoWriter, testTdf129841)
 CPPUNIT_ASSERT_EQUAL(aRefColor, aColor);
 }
 
+CPPUNIT_TEST_FIXTURE(SwUnoWriter, testTdf160278)
+{
+createSwDoc();
+auto xTextDocument(mxComponent.queryThrow());
+auto xText(xTextDocument->getText());
+xText->setString(u"123"_ustr);
+CPPUNIT_ASSERT_EQUAL(u"123"_ustr, xText->getString());
+auto xCursor = xText->createTextCursorByRange(xText->getEnd());
+xCursor->goLeft(1, true);
+CPPUNIT_ASSERT_EQUAL(u"3"_ustr, xCursor->getString());
+// Insert an SMP character U+1f702 (so it's two UTF-16 code units, 0xd83d 
0xdf02):
+xCursor->setString(u""_ustr);
+// Without the fix, the replacement would expand the cursor one too many 
characters to the left,
+// and the cursor text would become "2", failing the next test:
+CPPUNIT_ASSERT_EQUAL(u""_ustr, xCursor->getString());
+xCursor->setString(u"test"_ustr);
+CPPUNIT_ASSERT_EQUAL(u"test"_ustr, xCursor->getString());
+// This test would fail, too; the text would be "1test":
+CPPUNIT_ASSERT_EQUAL(u"12test"_ustr, xText->getString());
+}
+
 } // end of anonymous namespace
 CPPUNIT_PLUGIN_IMPLEMENT();
 
diff --git a/sw/source/core/unocore/unoobj.cxx 
b/sw/source/core/unocore/unoobj.cxx
index 3c5f34f1940a..69fa9d3be300 100644
--- a/sw/source/core/unocore/unoobj.cxx
+++ b/sw/source/core/unocore/unoobj.cxx
@@ -752,13 +752,19 @@ void SwXTextCursor::DeleteAndInsert(std::u16string_view 
aText,
 }
 if(nTextLen)
 {
+// Store node and content indexes prior to insertion: to select 
the inserted text,
+// we need to account for possible surrogate pairs, combining 
characters, etc.; it
+// is easier to just restore the correct position from the indexes.
+const auto start = pCurrent->Start();
+const auto nodeIndex = start->GetNodeIndex();
+const auto contentIndex = start->GetContentIndex();
 const bool bSuccess(
 SwUnoCursorHelper::DocInsertStringSplitCR(
-rDoc, *pCurrent, aText, bool(eMode & 
::sw::DeleteAndInsertMode::ForceExpandHints)));
+rDoc, SwPaM(*start, pCurrent), aText, bool(eMode & 
::sw::DeleteAndInsertMode::ForceExpandHints)));
 OSL_ENSURE( bSuccess, "Doc->Insert(Str) failed." );
 
-SwUnoCursorHelper::SelectPam(*pUnoCursor, true);
-pCurrent->Left(aText.size());
+pCurrent->SetMark();
+pCurrent->GetPoint()->Assign(nodeIndex, contentIndex);
 }
 pCurrent = pCurrent->GetNext();
 } while (pCurrent != pUnoCursor);
commit f4ade8244bf984712e65c2eb82cf3319d2679eeb
Author: Mike Kaganski 
AuthorDate: Thu Mar 21 10:01:36 2024 +0500
Commit: Mike Kaganski 
CommitDate: Thu Mar 21 17:51:14 2024 +0100

Downgrade sfx::SfxBindings aAutoTimer to an idle

This is a follow-up to commit f45402ae3f5241b460d9f1dcb04183893e1f91f7
(Fix a spurious JunitTest_sw_unoapi_3 failure, 2024-03-15). As noted
by Stephan, the failure persisted; it was because the update of slots
also accessed the changing document model, and it wasn't prevented by
IdlesLockGuard, because aAutoTimer had a default priority.

Change-Id: Iad8dfadcd35d9611e61e4c011511d6155a343f58
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165090
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sfx2/source/control/bindings.cxx b/sfx2/source/control/bindings.cxx
index 549a9fc45e67..458ef0431fc7 100644
--- a/sfx2/source/control/bindings.cxx
+++ b/sfx2/source/control/bindings.cxx
@@ -148,6 +148,7 @@ 

[Bug 160306] Formatting decimals can result in wrong rounding

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160306

--- Comment #5 from Mike Kaganski  ---
(In reply to Michael from comment #0)
> We have a contractor who submits bills in xlsx format, and 4 times in 2023
> this bug caused us to pay a penny different than they expected (it was
> caught by auditors at the first of this year).

(In reply to ady from comment #2)
> IDK when Calc will be usable again. Four major versions with incorrect
> results is more than enough.

(In reply to ady from comment #4)
> FWIW and JIC someone is tempted to suggest using ROUND()...

1. The change is caused by https://gerrit.libreoffice.org/c/core/+/129948; and
it made the display more *correct* WRT the actual value of 2697.06496,
which is rightfully rounded to 2697.07. The reason why the calculation produces
that value is explained in FAQ [1].

2. In the specific case that Michael describes, where the rounding is not
intended just for display, but is the actual result of the calculation, the
*correct* thing to do *is* use of ROUND function.

3. But generally, the difference between the ROUND and display rounding is not
nice. I need to think how to fix this problem.

4. ady: please avoid emotional, unrelated phrases that don't add anything
useful to the issue, but make indirectly make others feel bad. I don't feel
comfortable working on this issue now, after your "contribution".

[1] https://wiki.documentfoundation.org/Faq/Calc/Accuracy

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 107636] [META] User profile (user data/settings) bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107636
Bug 107636 depends on bug 159120, which changed state.

Bug 159120 Summary: Recent documents: Show only documents from the current 
module by default
https://bugs.documentfoundation.org/show_bug.cgi?id=159120

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 61174] [META] Recent Documents List

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=61174
Bug 61174 depends on bug 159120, which changed state.

Bug 159120 Summary: Recent documents: Show only documents from the current 
module by default
https://bugs.documentfoundation.org/show_bug.cgi?id=159120

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

Christopher Loi License Statement

[Chris Loi]

Dear LibreOffice Team,

I, Christopher Loi, hereby declare that all of my past and future
contributions to the LibreOffice project may be licensed under the
MPLv2/LGPLv3+ dual license.

Additionally, to the extent possible under law, I waive all copyright and
related or neighboring rights to my past and future Artwork and Design
contributions to the LibreOffice project, and similarly to The Document
Foundation, placing such contributions under CC0:
https://creativecommons.org/publicdomain/zero/1.0

Thank you for the opportunity to contribute to this incredible project.

Sincerely,
Christopher Loi

[Bug 160306] Formatting decimals can result in wrong rounding

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160306

--- Comment #4 from ady  ---
FWIW and JIC someone is tempted to suggest using ROUND()...

Using ROUND() only on the last formula, might or might not get the expected
result, because of similar issues in prior calculations (i.e. accumulation of
"errors").

Maybe there is some mix-up with "precision as shown"(???).

Users would expect to see 5+ rounded up, with whichever method. This would be a
reasonable expectation.

-- 
You are receiving this mail because:
You are the assignee for the bug.