[Bug 155637] Forms: Form controls for multi line text aren't shown with background when input data (Linux-KDE).
https://bugs.documentfoundation.org/show_bug.cgi?id=155637 Heinz-Dieter changed: What|Removed |Added Component|Writer |Base Version|7.5.4.2 release |24.2.3.2 release --- Comment #9 from Heinz-Dieter --- Retesting for the error described below did not reveal any new findings. The error still exists. There are further inconsistencies in the area of the text fields. There are three options to choose from on text fields. However, only the “flat” option is saved. It is not possible to display fields with the 3D option after save-close-open. -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'feature/cib_contract49c' - translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 97adcac03436f6ec2ef01f4292584ece0fdcc5e7 Author: Thorsten Behrens AuthorDate: Sat May 11 05:58:43 2024 +0200 Commit: Gerrit Code Review CommitDate: Sat May 11 05:58:43 2024 +0200 Update git submodules * Update translations from branch 'feature/cib_contract49c' to 69dfa90e38f72469befa115568d1b4e448f2992a - Update DE translations Change-Id: I652c650e3c2c7cb4f2cd39c0708dd2908fec79d4 diff --git a/translations b/translations index 160edf80fc3c..69dfa90e38f7 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit 160edf80fc3c9def8c6a1af8d143de9acf59 +Subproject commit 69dfa90e38f72469befa115568d1b4e448f2992a
translations.git: Changes to 'feature/cib_contract49c'
New branch 'feature/cib_contract49c' available with the following commits: commit 69dfa90e38f72469befa115568d1b4e448f2992a Author: Thorsten Behrens Date: Sat May 11 05:57:42 2024 +0200 Update DE translations Change-Id: I652c650e3c2c7cb4f2cd39c0708dd2908fec79d4
core.git: sw/source
sw/source/core/frmedt/tblsel.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 8088bd350da2a38f7e582c6452d506a572a19cae
Author: Andrea Gelmini
AuthorDate: Fri May 10 16:59:36 2024 +0200
Commit: Adolfo Jayme Barrientos
CommitDate: Sat May 11 05:22:55 2024 +0200
Fix typo
Change-Id: Ia2aa4d36dcb056171bcf2aaac0f0f326db1deb3b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167483
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/sw/source/core/frmedt/tblsel.cxx b/sw/source/core/frmedt/tblsel.cxx
index 74ec7fe7a106..ccaa3d2ae9b1 100644
--- a/sw/source/core/frmedt/tblsel.cxx
+++ b/sw/source/core/frmedt/tblsel.cxx
@@ -1883,7 +1883,7 @@ void MakeSelUnions( SwSelUnions& rUnions, const
SwLayoutFrame *pStart,
{
SwRowFrame* pRowFrame = pTable->GetFirstNonHeadlineRow();
//tdf#159027: follow returns a frame without height if
-// merged cells are invoved
+// merged cells are involved
if (pRowFrame->getFrameArea().IsEmpty())
pRowFrame = static_cast(pRowFrame->GetNext());
pRow = pRowFrame;
[Bug 160834] Unclear meaning of "Ignore pieces of length"
https://bugs.documentfoundation.org/show_bug.cgi?id=160834 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160824] Print dialogue box is scrollable for number of copies leading to excess copies being printed on accident
https://bugs.documentfoundation.org/show_bug.cgi?id=160824 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157674] Heading Indent lost on Reopening File in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=157674 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157494] Track-pad scrolling in Flatpak Writer is slow and laggy.
https://bugs.documentfoundation.org/show_bug.cgi?id=157494 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157674] Heading Indent lost on Reopening File in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=157674 --- Comment #7 from QA Administrators --- Dear Tim Chambers, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157494] Track-pad scrolling in Flatpak Writer is slow and laggy.
https://bugs.documentfoundation.org/show_bug.cgi?id=157494 --- Comment #4 from QA Administrators --- Dear n1729, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 89813] Open new -> Visit Card : ending to page with cards but without any text
https://bugs.documentfoundation.org/show_bug.cgi?id=89813 --- Comment #7 from QA Administrators --- Dear Antoine, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 90204] External links to other ods file - behaving strange after closing the file where the link refers to
https://bugs.documentfoundation.org/show_bug.cgi?id=90204 --- Comment #8 from QA Administrators --- Dear ville_blois, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 143496] misplaced smartTags with XRangeBasedSmartTagRecognizer / commitTextRangeMarkup
https://bugs.documentfoundation.org/show_bug.cgi?id=143496 --- Comment #2 from QA Administrators --- Dear K Antal, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 148997] Gratuitous page break in table-of-contents of ODT in Linux (OK Win)
https://bugs.documentfoundation.org/show_bug.cgi?id=148997 --- Comment #6 from QA Administrators --- Dear Eyal Rozenberg, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 146727] Import strings that matches specific LO Math operators in MSO equations as text
https://bugs.documentfoundation.org/show_bug.cgi?id=146727 --- Comment #8 from QA Administrators --- Dear Francisco, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 130851] When allowed to auto-update external links, Calc accesses them without need
https://bugs.documentfoundation.org/show_bug.cgi?id=130851 --- Comment #4 from QA Administrators --- Dear Mike Kaganski, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 126364] In the status bar, the scale indicator does not update when the page is scaled when you press Ctrl + scroll the mouse (LibreOffice for Windows)
https://bugs.documentfoundation.org/show_bug.cgi?id=126364 --- Comment #8 from QA Administrators --- Dear adollo, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161035] Spinning wheel hang on MacOS when using the Zotero plugin.
https://bugs.documentfoundation.org/show_bug.cgi?id=161035 Peter N. Steinmetz changed: What|Removed |Added CC||nd...@steinmetz.org --- Comment #1 from Peter N. Steinmetz --- Created attachment 194079 --> https://bugs.documentfoundation.org/attachment.cgi?id=194079=edit test030.odt This file does not cause the spin and hang, but does not allow the integration to work. Attempting to insert a citation just does nothing. This is likely related. I have a much larger file which causes the hang, but thought I should submit this smaller one first. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161035] New: Spinning wheel hang on MacOS when using the Zotero plugin.
https://bugs.documentfoundation.org/show_bug.cgi?id=161035 Bug ID: 161035 Summary: Spinning wheel hang on MacOS when using the Zotero plugin. Product: LibreOffice Version: 24.2.3.2 release Hardware: Other OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: nd...@steinmetz.org Description: Trying to insert a citation from Zotero using the LibreOffice Zotero integration causes a spinning wheel to appear. LibreOffice is then hung and must be force quite. Zotero is also hung and must be force quit. Steps to Reproduce: 1. This starts with a specific type of .odt document which must contain a bookmark. 2. Try inserting a citation to a Zotero reference just after the bookmark. The cursor will turn to the spinning ball and LibreOffice must be force quit as must Zotero. 3. Actual Results: Pop up of the citation search and insertion bar. Expected Results: Spinning wheel and hang. Reproducible: Always User Profile Reset: Yes Additional Info: LibreOffice version 24.2.3.2 (AARCH64) does this. version 7.6.7.2 (AARCH64) does not. Zotero version 7.0.0-beta.77+adaa61f2c Zotero LibreOffice Integration 6.0.3 MacOS 14.2.1 I can provide a test file if needed. Since this depends on the extension, a safe mode test will not work here. -- You are receiving this mail because: You are the assignee for the bug.
core.git: sc/source
sc/source/ui/undo/undobase.cxx | 23 ---
1 file changed, 16 insertions(+), 7 deletions(-)
New commits:
commit 2b85bceca88ab119fff5cbdc41fe913435a479ca
Author: Pranam Lashkari
AuthorDate: Fri May 10 02:02:18 2024 +0300
Commit: Pranam Lashkari
CommitDate: Sat May 11 01:48:33 2024 +0200
sc: undo: unify height adjust logic in undo with regular logic
in ScBlockUndo::AdjustHeight now we use device like
ScViewFunc::SetWidthOrHeight
This provides unified behavior with user adjusting height or triggered it
by undo
problem:
in online sometimes undoing would cause wrong selection due to incorrect
height set
steps to reproduce(happened in certain files only):
1. autofill down a couple of cells
2. undo it
3. try to select the same cell again
cell selection will act like auto filled cells are merged cells
Change-Id: I81b798c4150284792ac3953caf822fefab0ccee2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167424
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Caolán McNamara
(cherry picked from commit 726b133fd8c823c7f05a30c1995de26db372174d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167454
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari
diff --git a/sc/source/ui/undo/undobase.cxx b/sc/source/ui/undo/undobase.cxx
index 8ce66d95d0c4..a99dec962d89 100644
--- a/sc/source/ui/undo/undobase.cxx
+++ b/sc/source/ui/undo/undobase.cxx
@@ -36,6 +36,7 @@
#include
#include
#include
+#include
ScSimpleUndo::ScSimpleUndo( ScDocShell* pDocSh ) :
@@ -285,18 +286,26 @@ bool ScBlockUndo::AdjustHeight()
{
ScDocument& rDoc = pDocShell->GetDocument();
-ScopedVclPtrInstance< VirtualDevice > pVirtDev;
+ScSizeDeviceProvider aProv(pDocShell);
Fraction aZoomX( 1, 1 );
Fraction aZoomY = aZoomX;
double nPPTX, nPPTY;
ScTabViewShell* pViewShell = ScTabViewShell::GetActiveViewShell();
if (pViewShell)
{
-ScViewData& rData = pViewShell->GetViewData();
-nPPTX = rData.GetPPTX();
-nPPTY = rData.GetPPTY();
-aZoomX = rData.GetZoomX();
-aZoomY = rData.GetZoomY();
+if (aProv.IsPrinter())
+{
+nPPTX = aProv.GetPPTX();
+nPPTY = aProv.GetPPTY();
+}
+else
+{
+ScViewData& rData = pViewShell->GetViewData();
+nPPTX = rData.GetPPTX();
+nPPTY = rData.GetPPTY();
+aZoomX = rData.GetZoomX();
+aZoomY = rData.GetZoomY();
+}
}
else
{
@@ -305,7 +314,7 @@ bool ScBlockUndo::AdjustHeight()
nPPTY = ScGlobal::nScreenPPTY;
}
-sc::RowHeightContext aCxt(rDoc.MaxRow(), nPPTX, nPPTY, aZoomX, aZoomY,
pVirtDev);
+sc::RowHeightContext aCxt(rDoc.MaxRow(), nPPTX, nPPTY, aZoomX, aZoomY,
aProv.GetDevice());
bool bRet = rDoc.SetOptimalHeight(
aCxt, aBlockRange.aStart.Row(), aBlockRange.aEnd.Row(),
aBlockRange.aStart.Tab(), true);
[Bug 161034] New: Creating list style messes up paragraph formating
https://bugs.documentfoundation.org/show_bug.cgi?id=161034 Bug ID: 161034 Summary: Creating list style messes up paragraph formating Product: LibreOffice Version: 7.6.5.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: marli...@proton.me Created attachment 194078 --> https://bugs.documentfoundation.org/attachment.cgi?id=194078=edit Example document When changing the indent settings of list items, there could be a good idea to create a new style using these new indent settings by selecting a list item and click "new style from selection". But when doing so, the selected list item changes style to the default. However the style is created. The style settings looks good. But when applied to a new list, it doesn't take the settings from the style. And even worse, after applying the style, when creating a new list item, the new list item gets yet another style. Please see the attached document. It tells all steps how to reproduce, and shows the results on the way there. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160816] Can't paste text copied from PDFs
https://bugs.documentfoundation.org/show_bug.cgi?id=160816 --- Comment #5 from stokest...@gmail.com --- Looks like Mac-only then. I just tried it again with a fresh doc and it was immediately reproducible. -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'feature/cib_contract49c' - 21 commits - configure.ac cui/source dictionaries .gitreview helpcontent2 readlicense_oo/license sc/qa sc/source sfx2/source sw/qa sw/source translations v
Rebased ref, commits from common ancestor: commit 773389a9304bfe2769f6cb5b730aa9e1a014079e Merge: 5c64e56aa858 433d9c2ded56 Author: Thorsten Behrens AuthorDate: Sat May 11 00:47:54 2024 +0200 Commit: Thorsten Behrens CommitDate: Sat May 11 00:47:54 2024 +0200 Merge tag 'libreoffice-24.2.3.2' into feature/cib_contract49c Tag libreoffice-24.2.3.2 Change-Id: I1ba238eb2cfff7a7d083e54ec4953dc910fd595d diff --cc .gitreview index df751098db2e,6bfe828d7bca..509db4a7a5e0 --- a/.gitreview +++ b/.gitreview @@@ -3,6 -3,5 +3,4 @@@ host=gerrit.libreoffice.or port=29418 project=core defaultremote=logerrit -defaultbranch=libreoffice-24-2-3 - +defaultbranch=feature/cib_contract49c - - diff --cc helpcontent2 index 83b1b76cb728,6de232b9e354..7356d60bbf41 --- a/helpcontent2 +++ b/helpcontent2 @@@ -1,1 -1,1 +1,1 @@@ - Subproject commit 83b1b76cb72845dd5d605337cb8253b914086911 -Subproject commit 6de232b9e35466d34942f1365881828b15e70239 ++Subproject commit 7356d60bbf41f801b13b64bbeef17123f5729d6e commit 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba Author: Christian Lohmaier AuthorDate: Mon Apr 29 20:46:10 2024 +0200 Commit: Christian Lohmaier CommitDate: Mon Apr 29 20:46:10 2024 +0200 Version 24.2.3.2, tag libreoffice-24.2.3.2 diff --git a/dictionaries b/dictionaries index 7449b540bccb..e4efb45d4188 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit 7449b540bccbb09ae2226510e97c38950cca967e +Subproject commit e4efb45d41881cad0a45587007d9e396b51a0066 diff --git a/helpcontent2 b/helpcontent2 index eb843d3b83f8..6de232b9e354 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit eb843d3b83f89d11a531d379f4299339cbf85615 +Subproject commit 6de232b9e35466d34942f1365881828b15e70239 diff --git a/translations b/translations index abc5b4da9d1c..160edf80fc3c 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit abc5b4da9d1c382d8f76eec58b3c6b0ba17f92bd +Subproject commit 160edf80fc3c9def8c6a1af8d143de9acf59 commit 890ac6263b2f3348ddfe11075c921d8454bc2826 Author: Christian Lohmaier AuthorDate: Mon Apr 29 20:45:58 2024 +0200 Commit: Christian Lohmaier CommitDate: Mon Apr 29 20:45:58 2024 +0200 bump product version to 24.2.3.2 Change-Id: Ie10184cc8b4b860b20a270f8845d1059ce93a6d8 diff --git a/configure.ac b/configure.ac index 5872d2973f79..453ff1c563ab 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([LibreOffice],[24.2.3.1.0+],[],[],[http://documentfoundation.org/]) +AC_INIT([LibreOffice],[24.2.3.2],[],[],[http://documentfoundation.org/]) dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just fine if it is installed dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails hard commit ab4fd05c26289147ac1cab686a93a84fda85be5f Author: Christian Lohmaier AuthorDate: Mon Apr 29 20:36:41 2024 +0200 Commit: Christian Lohmaier CommitDate: Mon Apr 29 20:42:10 2024 +0200 update credits Change-Id: I92481956d041c4a5077aa7a56af2df3ab72fd9bf (cherry picked from commit e729fec8a9e73e9d013cb634d4bcbd8c43be4200) (cherry picked from commit 6b20b3abc70c210ae52ecde24076ad08c4594fe0) diff --git a/readlicense_oo/license/CREDITS.fodt b/readlicense_oo/license/CREDITS.fodt index e08695d232b5..ec7d2eba89a9 100644 --- a/readlicense_oo/license/CREDITS.fodt +++ b/readlicense_oo/license/CREDITS.fodt @@ -1,10 +1,10 @@ http://www.w3.org/TR/css3-text/; xmlns:grddl="http://www.w3.org/2003/g/data-view#; xmlns:xhtml="http://www.w3.org/1999/xhtml; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xmlns:xsd="http://www.w3.org/2001/XMLSchema; xmlns:xforms="http://www.w3.org/2002/xforms; xmlns:dom="http://www.w3.org/2001/xml-events; xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:math="http://www.w3.org/1998/Math/MathML; xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0" xmlns:ooo="http://openoffice.org/2004/office; xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" xmlns:ooow="http://openoffice.org/2004/writer; xmlns:xlink="http://www.w3.org/1999/xlink; xmlns:drawooo="http://openoffice.org/2010/draw; xmlns:oooc="http://openoffice.org/2004/calc; xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:c alcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0" xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0" xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0" xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" xmlns:tableooo="http://openoffice.org/2009/table;
core.git: Branch 'feature/cib_contract49c' - helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 376b0c955f346969b5171adbaa91ff26aaf58d3f Author: Juan José González AuthorDate: Fri May 10 16:47:32 2024 -0600 Commit: Gerrit Code Review CommitDate: Sat May 11 00:47:32 2024 +0200 Update git submodules * Update helpcontent2 from branch 'feature/cib_contract49c' to 7356d60bbf41f801b13b64bbeef17123f5729d6e - Move z-index rule to CSS stylesheet we control Previously a fix was pushed to prism css file, which can be changed by the upstream project. Instead overwrite the rule in our files. Change-Id: I549b05d4a359343ae0fe09831644a2eed8fb0474 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166076 Tested-by: Jenkins Reviewed-by: Olivier Hallot (cherry picked from commit 2b438594148c4ee94cb632e7a3d3b64b547706d5) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166211 Reviewed-by: Adolfo Jayme Barrientos - Version 24.2.3.2, tag libreoffice-24.2.3.2 Change-Id: Ia9f54ebb3486608fc59ba4fa84fc0f865433da2b - Branch libreoffice-24-2-3 This is 'libreoffice-24-2-3' - the stable branch for the 24.2.3 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 24.2.x release, please use the 'libreoffice-24-2' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: I3c21262555fd902e0951245187ea81af99dff7ea diff --git a/helpcontent2 b/helpcontent2 index 83b1b76cb728..7356d60bbf41 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 83b1b76cb72845dd5d605337cb8253b914086911 +Subproject commit 7356d60bbf41f801b13b64bbeef17123f5729d6e
help.git: Changes to 'feature/cib_contract49c'
New branch 'feature/cib_contract49c' available with the following commits: commit 7356d60bbf41f801b13b64bbeef17123f5729d6e Author: Juan José González Date: Sun Apr 14 11:14:21 2024 -0600 Move z-index rule to CSS stylesheet we control Previously a fix was pushed to prism css file, which can be changed by the upstream project. Instead overwrite the rule in our files. Change-Id: I549b05d4a359343ae0fe09831644a2eed8fb0474 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166076 Tested-by: Jenkins Reviewed-by: Olivier Hallot (cherry picked from commit 2b438594148c4ee94cb632e7a3d3b64b547706d5) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166211 Reviewed-by: Adolfo Jayme Barrientos
core.git: Branch 'feature/cib_contract49c' - sd/source
sd/source/ui/view/NotesPanelView.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 5c64e56aa858cf6aa6c39e2ff58bae2000f837f7 Author: Sarper Akdemir AuthorDate: Fri May 10 18:38:02 2024 +0200 Commit: Thorsten Behrens CommitDate: Fri May 10 23:52:21 2024 +0200 tdf#33603: sd: notes pane: force proper flush on page change After clearing the notes pane outliner and filling with then new content, if the new content didn't overfill the previous' area there was a residue from the last content visible. Make sure it is flushed by triggering onResize() on page change. Which also fixes the notespane sometimes keeping the scrollbar & scrollarea from the previous content. Change-Id: Ibbcb0f4f316bd283e5e65bb2ebd9cf17a3b38c0e diff --git a/sd/source/ui/view/NotesPanelView.cxx b/sd/source/ui/view/NotesPanelView.cxx index a2ae58e48331..3a4d4df4b0ac 100644 --- a/sd/source/ui/view/NotesPanelView.cxx +++ b/sd/source/ui/view/NotesPanelView.cxx @@ -286,6 +286,7 @@ IMPL_LINK(NotesPanelView, EventMultiplexerListener, tools::EventMultiplexerEvent case EventMultiplexerEventId::MainViewRemoved: case EventMultiplexerEventId::MainViewAdded: FillOutliner(); +onResize(); break; default: break;
[Bug 90486] [META] Chart bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=90486 Bug 90486 depends on bug 96944, which changed state. Bug 96944 Summary: FORMATTING Stacked column chart does not show connection lines https://bugs.documentfoundation.org/show_bug.cgi?id=96944 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161033] New: Installed languages not available for automatic spell checking until user changes locale setting
https://bugs.documentfoundation.org/show_bug.cgi?id=161033 Bug ID: 161033 Summary: Installed languages not available for automatic spell checking until user changes locale setting Product: LibreOffice Version: 24.2.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: daniel.scha...@gmail.com Description: When I want to select a language for automatic spell checking, only English (UK), and possibly one single additional language are available. I have several other language extensions installed. This is a problem in all LibrOffice applications. Steps to Reproduce: 1. Install LibreOffice with English (UK) as default language, and several additional dictionaries. 2. Create a new document in Writer, Calc, ... 3. Select "Tools > Language > For All Text". Actual Results: Only "English (UK)" is available as language for automatic spell checking. Expected Results: All installed languages should be available for automatic spell checking. Reproducible: Always User Profile Reset: Yes Additional Info: When I change the Locale setting (Tools > Options > Language and Locales > General > Formats > Locale settings) to a different language, that language gets available for spell checking in addition to English (UK). Still, no other languages are available, although the corresponding extensions are installed. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159547] of-pie connector lines aren't quite geometrically correct
https://bugs.documentfoundation.org/show_bug.cgi?id=159547 kurt.nordb...@protonmail.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |kurt.nordb...@protonmail.co |desktop.org |m -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-24-2' - sw/source
sw/source/uibase/utlui/content.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 9f5757c3cbd1f9252f2ea82bc8bacab24d26822c
Author: Michael Stahl
AuthorDate: Wed May 8 13:28:52 2024 +0200
Commit: Thorsten Behrens
CommitDate: Fri May 10 23:35:20 2024 +0200
sw: Navigator: don't show virtual drawing objects
These can return a non-empty name now, so exclude them explicitly.
(regression from commit ae132145ff42a95dc24fb124847c04af4b8c8dab)
Change-Id: Ia7f7b9fd7abe67f3302e95b38e3b9fa30b769b5b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167349
Reviewed-by: Michael Stahl
Tested-by: Jenkins
(cherry picked from commit 609d1e353cfd7a9b138fcbe656a2faae9f84c36a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167451
Reviewed-by: Thorsten Behrens
diff --git a/sw/source/uibase/utlui/content.cxx
b/sw/source/uibase/utlui/content.cxx
index 4e6704140334..c75f08430cea 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -1010,7 +1010,7 @@ void SwContentType::FillMemberList(bool* pbContentChanged)
for (const rtl::Reference& pTemp : *pPage)
{
// #i51726# - all drawing objects can be named now
-if (!pTemp->GetName().isEmpty())
+if (!pTemp->IsVirtualObj() && !pTemp->GetName().isEmpty())
{
tools::Long nYPos = LONG_MIN;
const bool bIsVisible =
rIDDMA.IsVisibleLayerId(pTemp->GetLayer());
core.git: Branch 'libreoffice-24-2' - solenv/gbuild
solenv/gbuild/Rdb.mk |1 + 1 file changed, 1 insertion(+) New commits: commit c1198a8c0594308a06b29cc887850f8d50216d43 Author: Michael Stahl AuthorDate: Wed May 8 14:53:05 2024 +0200 Commit: Thorsten Behrens CommitDate: Fri May 10 23:34:54 2024 +0200 gbuild: don't create empty services.rdb on "make postprocess" Since commit db3a61cd958f4a70417929cf8e1fa9bfd0bfe5a3 "make postprocess.clea; make postprocess" will result in an empty services.rdb, because the components are added in makefiles in other modules. Detect the problem and tell the user to run top-level make. Change-Id: Iab1a15efa5a4c9bb3e90e44f82a9510dff724c80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167354 Reviewed-by: Michael Stahl Tested-by: Jenkins (cherry picked from commit baaeca870f5c8ae40d33eff2b530bd4b3670ee45) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167453 Reviewed-by: Thorsten Behrens diff --git a/solenv/gbuild/Rdb.mk b/solenv/gbuild/Rdb.mk index 136e1c2ee4dd..fff774dcb5b8 100644 --- a/solenv/gbuild/Rdb.mk +++ b/solenv/gbuild/Rdb.mk @@ -10,6 +10,7 @@ gb_Rdb__get_install_target = $(INSTROOT)/$(LIBO_ETC_FOLDER)/services/$(1).rdb define gb_Rdb__command +$(if $(COMPONENTS),,$(call gb_Output_error,Rdb without components: partial build of module postprocess is not possible currently - only top-level make works)) $(call gb_Helper_abbreviate_dirs,\ RESPONSEFILE=$(call gb_var2file,$(shell $(call gb_MKTEMP)),\ \
core.git: Branch 'libreoffice-24-2' - include/svx svx/source sw/source
include/svx/svdobj.hxx |8
include/svx/svdovirt.hxx |4
svx/source/svdraw/svdobj.cxx | 10 ++
svx/source/svdraw/svdovirt.cxx | 20
sw/source/core/draw/dcontact.cxx |5 +++--
5 files changed, 41 insertions(+), 6 deletions(-)
New commits:
commit da7e1d686a586fa93b1e96adb3d837ea3ae59b98
Author: Michael Stahl
AuthorDate: Wed May 8 14:20:26 2024 +0200
Commit: Thorsten Behrens
CommitDate: Fri May 10 23:34:35 2024 +0200
tdf#156484 svx,sw: fix visibility of shapes in header/footer
Similar to commit ae132145ff42a95dc24fb124847c04af4b8c8dab, also forward
IsVisible() and IsPrintable() from SdrVirtObj to its real object;
evidently the properties aren't copied when creating SdrVirtObj but
there is no reason for that to have these properties independent.
This triggers an assert in VOCOfDrawVirtObj::createPrimitive2DSequence()
because that is called during layout from getObjectRange(); the assert
was added in commit ae3ec0d53a22ae5d2b7fb244a6056d0627b71873 and
intended for painting, but this isn't painting, and it's not easily
possible to detect if the function is called during painting, so remove
the assert.
Change-Id: Id2a04a5d07f43b86eb9c524b30ba74ecaf6a95c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167350
Reviewed-by: Michael Stahl
Tested-by: Jenkins
(cherry picked from commit 9fb9bd54a82ee20f5916aa68e428e0fb67f02ed6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167452
Reviewed-by: Thorsten Behrens
diff --git a/include/svx/svdobj.hxx b/include/svx/svdobj.hxx
index 892beb56668c..396c09e8cd94 100644
--- a/include/svx/svdobj.hxx
+++ b/include/svx/svdobj.hxx
@@ -752,10 +752,10 @@ public:
bool IsMoveProtect() const { return m_bMovProt;}
void SetResizeProtect(bool bProt);
bool IsResizeProtect() const { return m_bSizProt;}
-void SetPrintable(bool bPrn);
-bool IsPrintable() const { return !m_bNoPrint;}
-void SetVisible(bool bVisible);
-bool IsVisible() const { return mbVisible;}
+virtual void SetPrintable(bool isPrintable);
+virtual bool IsPrintable() const;
+virtual void SetVisible(bool isVisible);
+virtual bool IsVisible() const;
void SetMarkProtect(bool bProt);
bool IsMarkProtect() const { return m_bMarkProt;}
virtual bool IsSdrTextObj() const { return false; }
diff --git a/include/svx/svdovirt.hxx b/include/svx/svdovirt.hxx
index 17c869313067..ca5f6858ecaa 100644
--- a/include/svx/svdovirt.hxx
+++ b/include/svx/svdovirt.hxx
@@ -61,6 +61,10 @@ public:
const SdrObject& GetReferencedObj() const;
virtual void NbcSetAnchorPos(const Point& rAnchorPos) override;
+virtual void SetPrintable(bool isPrintable) override;
+virtual bool IsPrintable() const override;
+virtual void SetVisible(bool isVisible) override;
+virtual bool IsVisible() const override;
virtual void TakeObjInfo(SdrObjTransformInfoRec& rInfo) const override;
virtual SdrInventor GetObjInventor() const override;
virtual SdrObjKind GetObjIdentifier() const override;
diff --git a/svx/source/svdraw/svdobj.cxx b/svx/source/svdraw/svdobj.cxx
index f4d13219db0d..b23e18a6a4d3 100644
--- a/svx/source/svdraw/svdobj.cxx
+++ b/svx/source/svdraw/svdobj.cxx
@@ -2675,6 +2675,11 @@ void SdrObject::SetResizeProtect(bool bProt)
}
}
+bool SdrObject::IsPrintable() const
+{
+return !m_bNoPrint;
+}
+
void SdrObject::SetPrintable(bool bPrn)
{
if( bPrn == m_bNoPrint )
@@ -2689,6 +2694,11 @@ void SdrObject::SetPrintable(bool bPrn)
}
}
+bool SdrObject::IsVisible() const
+{
+return mbVisible;
+}
+
void SdrObject::SetVisible(bool bVisible)
{
if( bVisible != mbVisible )
diff --git a/svx/source/svdraw/svdovirt.cxx b/svx/source/svdraw/svdovirt.cxx
index b1fe6f5cb9bb..2e1641d3864e 100644
--- a/svx/source/svdraw/svdovirt.cxx
+++ b/svx/source/svdraw/svdovirt.cxx
@@ -97,6 +97,26 @@ void SdrVirtObj::NbcSetAnchorPos(const Point& rAnchorPos)
m_aAnchor=rAnchorPos;
}
+bool SdrVirtObj::IsPrintable() const
+{
+return mxRefObj->IsPrintable();
+}
+
+void SdrVirtObj::SetPrintable(bool const isPrintable)
+{
+mxRefObj->SetPrintable(isPrintable);
+}
+
+bool SdrVirtObj::IsVisible() const
+{
+return mxRefObj->IsVisible();
+}
+
+void SdrVirtObj::SetVisible(bool const isVisible)
+{
+mxRefObj->SetVisible(isVisible);
+}
+
void SdrVirtObj::TakeObjInfo(SdrObjTransformInfoRec& rInfo) const
{
mxRefObj->TakeObjInfo(rInfo);
diff --git a/sw/source/core/draw/dcontact.cxx b/sw/source/core/draw/dcontact.cxx
index aac8f2393c61..115887a368dc 100644
--- a/sw/source/core/draw/dcontact.cxx
+++ b/sw/source/core/draw/dcontact.cxx
@@ -2216,8 +2216,9 @@ namespace sdr::contact
void VOCOfDrawVirtObj::createPrimitive2DSequence(const DisplayInfo&
rDisplayInfo, drawinglayer::primitive2d::Primitive2DDecompositionVisitor&
rVisitor) const
{
-
[Bug 161032] French and Spanish spelling dictionaries are default extensions that can not be removed in a UK English LibreOffice set up.
https://bugs.documentfoundation.org/show_bug.cgi?id=161032 vena.c...@virgin.net changed: What|Removed |Added Component|LibreOffice |Writer -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161032] New: French and Spanish spelling dictionaries are default extensions that can not be removed in a UK English LibreOffice set up.
https://bugs.documentfoundation.org/show_bug.cgi?id=161032 Bug ID: 161032 Summary: French and Spanish spelling dictionaries are default extensions that can not be removed in a UK English LibreOffice set up. Product: LibreOffice Version: 24.8.0.0 alpha0+ Master Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: vena.c...@virgin.net Description: I use LibreOffice in UK English with an option to use USA English. However, the extensions include default Spanish and French spelling dictionaries that can not be removed. On my setup, the Spanish and French spelling dictionaries do not appear to have any function whatsoever. Why are they included as default spelling dictionaries and why are they not removable? Is this buggy? Steps to Reproduce: 1. Click on the relevant tabs and look at the extensions. 2. French and Spanish spelling dictionaries are included in a UK or USA setup. 3. There is no option to delete the unwanted dictionaries. Actual Results: As above. Expected Results: I do not expect to find unwanted spelling dictionaries included. I would expect to be able to delete (or uninstall) unwanted dictionaries. Reproducible: Always User Profile Reset: No Additional Info: As above. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 56408] Writer always breaks lines at text direction change, leaving orphan bracket
https://bugs.documentfoundation.org/show_bug.cgi?id=56408 --- Comment #30 from Eyal Rozenberg --- (In reply to خالد حسني from comment #29) > You are checking the word break opportunities not the line break > opportunities. You're right! Sorry. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 56408] Writer always breaks lines at text direction change, leaving orphan bracket
https://bugs.documentfoundation.org/show_bug.cgi?id=56408 --- Comment #29 from خالد حسني --- (In reply to Eyal Rozenberg from comment #28) > (In reply to خالد حسني from comment #26) > > There is no line break opportunity after the opening parentheses (or before > > closing parentheses). > > I'm sorry, Khaled, but yes, there is, at least according to the online > Unicode utility at: https://util.unicode.org/UnicodeJsps/breaks.jsp > > it shows opportunities before and after each of the parentheses - the > opening and the closing one. You are checking the word break opportunities not the line break opportunities. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161010] FILEOPEN DOCX: One page document extends table to two pages instead of one
https://bugs.documentfoundation.org/show_bug.cgi?id=161010 m_a_riosv changed: What|Removed |Added Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 154117] Line break removed when applying a hyperlink
https://bugs.documentfoundation.org/show_bug.cgi?id=154117 --- Comment #2 from Eyal Rozenberg --- Still manifesting with: Version: 24.2.3.2 (X86_64) / LibreOffice Community Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba CPU threads: 4; OS: Linux 6.6; UI render: default; VCL: gtk3 Locale: en-IL (en_IL); UI: en-US -- You are receiving this mail because: You are the assignee for the bug.
[Bug 56408] Writer always breaks lines at text direction change, leaving orphan bracket
https://bugs.documentfoundation.org/show_bug.cgi?id=56408 --- Comment #28 from Eyal Rozenberg --- (In reply to خالد حسني from comment #26) > There is no line break opportunity after the opening parentheses (or before > closing parentheses). I'm sorry, Khaled, but yes, there is, at least according to the online Unicode utility at: https://util.unicode.org/UnicodeJsps/breaks.jsp it shows opportunities before and after each of the parentheses - the opening and the closing one. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161022] [META] Word-breaking / line-breaking issues
https://bugs.documentfoundation.org/show_bug.cgi?id=161022 Hossein changed: What|Removed |Added Depends on||71329 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=71329 [Bug 71329] No linebreak between Latin text and Ideographic punctuation -- You are receiving this mail because: You are the assignee for the bug.
[Bug 71329] No linebreak between Latin text and Ideographic punctuation
https://bugs.documentfoundation.org/show_bug.cgi?id=71329 Hossein changed: What|Removed |Added Blocks||161022 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=161022 [Bug 161022] [META] Word-breaking / line-breaking issues -- You are receiving this mail because: You are the assignee for the bug.
core.git: dbaccess/source
dbaccess/source/core/dataaccess/databasedocument.cxx | 36 +++---
dbaccess/source/core/dataaccess/documenteventnotifier.hxx | 32
2 files changed, 18 insertions(+), 50 deletions(-)
New commits:
commit 14f65dc1ad3dc7bdc2e8638b5fb0130f8f22eaaa
Author: Noel Grandin
AuthorDate: Tue May 7 14:15:03 2024 +0200
Commit: Noel Grandin
CommitDate: Fri May 10 21:53:55 2024 +0200
replace createFromAscii with OUString literals in DocumentEventNotifier
Change-Id: I6987033a461ec91b59de8e2aabef513471f887f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167493
Reviewed-by: Noel Grandin
Tested-by: Jenkins
diff --git a/dbaccess/source/core/dataaccess/databasedocument.cxx
b/dbaccess/source/core/dataaccess/databasedocument.cxx
index 82c1b66954cc..413b53a0f763 100644
--- a/dbaccess/source/core/dataaccess/databasedocument.cxx
+++ b/dbaccess/source/core/dataaccess/databasedocument.cxx
@@ -124,7 +124,7 @@ bool ViewMonitor::onSetCurrentController( const Reference<
XController >& _rxCon
// notify the respective events
if ( bLoadFinished )
-m_rEventNotifier.notifyDocumentEventAsync( m_bIsNewDocument ? "OnNew"
: "OnLoad" );
+m_rEventNotifier.notifyDocumentEventAsync( m_bIsNewDocument ?
u"OnNew"_ustr : u"OnLoad"_ustr, nullptr, Any() );
return bLoadFinished;
}
@@ -480,12 +480,12 @@ void SAL_CALL ODatabaseDocument::initNew( )
impl_setInitialized();
-m_aEventNotifier.notifyDocumentEventAsync( "OnTitleChanged" );
+m_aEventNotifier.notifyDocumentEventAsync( u"OnTitleChanged"_ustr,
nullptr, Any() );
impl_setModified_nothrow( false, aGuard );
// <- SYNCHRONIZED
-m_aEventNotifier.notifyDocumentEvent( "OnCreate" );
+m_aEventNotifier.notifyDocumentEvent( u"OnCreate"_ustr, nullptr, Any() );
impl_notifyStorageChange_nolck_nothrow( xTempStor );
}
@@ -763,7 +763,7 @@ bool ODatabaseDocument::impl_attachResource( const
OUString& i_rLogicalDocumentU
_rDocGuard.clear();
// <- SYNCHRONIZED
-m_aEventNotifier.notifyDocumentEvent( "OnLoadFinished" );
+m_aEventNotifier.notifyDocumentEvent( u"OnLoadFinished"_ustr, nullptr,
Any() );
}
return true;
@@ -808,7 +808,7 @@ void SAL_CALL ODatabaseDocument::connectController( const
Reference< XController
m_aControllers.push_back( _xController );
-m_aEventNotifier.notifyDocumentEventAsync( "OnViewCreated", Reference<
XController2 >( _xController, UNO_QUERY ) );
+m_aEventNotifier.notifyDocumentEventAsync( u"OnViewCreated"_ustr,
Reference< XController2 >( _xController, UNO_QUERY ), Any() );
bool bFirstControllerEver = m_aViewMonitor.onControllerConnected(
_xController );
if ( !bFirstControllerEver )
@@ -845,7 +845,7 @@ void SAL_CALL ODatabaseDocument::disconnectController(
const Reference< XControl
// <- SYNCHRONIZED
if ( bNotifyViewClosed )
-m_aEventNotifier.notifyDocumentEvent( "OnViewClosed", Reference<
XController2 >( _xController, UNO_QUERY ) );
+m_aEventNotifier.notifyDocumentEvent( u"OnViewClosed"_ustr, Reference<
XController2 >( _xController, UNO_QUERY ), Any() );
if ( !bLastControllerGone || bIsClosing )
return;
@@ -1013,7 +1013,7 @@ void ODatabaseDocument::impl_storeAs_throw( const
OUString& _rURL, const ::comph
if ( !bIsInitializationProcess )
{
_rGuard.clear();
-m_aEventNotifier.notifyDocumentEvent( _eType == SAVE ? "OnSave" :
"OnSaveAs", nullptr, Any( _rURL ) );
+m_aEventNotifier.notifyDocumentEvent( _eType == SAVE ? u"OnSave"_ustr
: u"OnSaveAs"_ustr, nullptr, Any( _rURL ) );
_rGuard.reset();
}
@@ -1073,13 +1073,13 @@ void ODatabaseDocument::impl_storeAs_throw( const
OUString& _rURL, const ::comph
catch( const IOException& )
{
if ( !bIsInitializationProcess )
-m_aEventNotifier.notifyDocumentEventAsync( _eType == SAVE ?
"OnSaveFailed" : "OnSaveAsFailed", nullptr, Any( _rURL ) );
+m_aEventNotifier.notifyDocumentEventAsync( _eType == SAVE ?
u"OnSaveFailed"_ustr : u"OnSaveAsFailed"_ustr, nullptr, Any( _rURL ) );
throw;
}
catch( const RuntimeException& )
{
if ( !bIsInitializationProcess )
-m_aEventNotifier.notifyDocumentEventAsync( _eType == SAVE ?
"OnSaveFailed" : "OnSaveAsFailed", nullptr, Any( _rURL ) );
+m_aEventNotifier.notifyDocumentEventAsync( _eType == SAVE ?
u"OnSaveFailed"_ustr : u"OnSaveAsFailed"_ustr, nullptr, Any( _rURL ) );
throw;
}
catch( const Exception& )
@@ -1088,14 +1088,14 @@ void ODatabaseDocument::impl_storeAs_throw( const
OUString& _rURL, const ::comph
// notify the failure
if ( !bIsInitializationProcess )
-m_aEventNotifier.notifyDocumentEventAsync( _eType == SAVE ?
"OnSaveFailed" : "OnSaveAsFailed", nullptr, Any( _rURL ) );
+m_aEventNotifier.notifyDocumentEventAsync( _eType == SAVE
core.git: download.lst external/libmwaw
download.lst |4 ++-- external/libmwaw/Library_mwaw.mk |3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) New commits: commit 16357c68bdb2fb9c1b7eb77fdbcb50c41948c6db Author: Xisco Fauli AuthorDate: Fri May 10 14:28:41 2024 +0200 Commit: Xisco Fauli CommitDate: Fri May 10 21:52:28 2024 +0200 libmwaw: Upgrade to 0.3.22 Change-Id: I95169f11e7b188ab9b4667b2d4736bd0d5a4a083 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167477 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/download.lst b/download.lst index c8146984bbf3..aa98bee9730b 100644 --- a/download.lst +++ b/download.lst @@ -466,8 +466,8 @@ MSPUB_TARBALL := libmspub-0.1.4.tar.xz # three static lines # so that git cherry-pick # will not run into conflicts -MWAW_SHA256SUM := e8750123a78d61b943cef78b7736c8a7f20bb0a649aa112402124fba794fc21c -MWAW_VERSION_MICRO := 21 +MWAW_SHA256SUM := a1a39ffcea3ff2a7a7aae0c23877ddf4918b554bf82b0de5d7ce8e7f61ea8e32 +MWAW_VERSION_MICRO := 22 MWAW_TARBALL := libmwaw-0.3.$(MWAW_VERSION_MICRO).tar.xz # three static lines # so that git cherry-pick diff --git a/external/libmwaw/Library_mwaw.mk b/external/libmwaw/Library_mwaw.mk index 30e71443f5a0..2b7c2286fa51 100644 --- a/external/libmwaw/Library_mwaw.mk +++ b/external/libmwaw/Library_mwaw.mk @@ -201,9 +201,12 @@ $(eval $(call gb_Library_add_generated_exception_objects,mwaw,\ UnpackedTarball/libmwaw/src/lib/RagTimeSpreadsheet \ UnpackedTarball/libmwaw/src/lib/RagTimeStruct \ UnpackedTarball/libmwaw/src/lib/RagTimeText \ + UnpackedTarball/libmwaw/src/lib/ReadySetGoGraph \ UnpackedTarball/libmwaw/src/lib/ReadySetGoParser \ + UnpackedTarball/libmwaw/src/lib/ReadySetGoStyleManager \ UnpackedTarball/libmwaw/src/lib/ScoopParser \ UnpackedTarball/libmwaw/src/lib/ScriptWriterParser \ + UnpackedTarball/libmwaw/src/lib/SpringBoardParser \ UnpackedTarball/libmwaw/src/lib/StudentWritingCParser \ UnpackedTarball/libmwaw/src/lib/StyleParser \ UnpackedTarball/libmwaw/src/lib/SuperPaintParser \
core.git: accessibility/inc accessibility/source
accessibility/inc/standard/vclxaccessibleedit.hxx |3 +
accessibility/inc/standard/vclxaccessibletextcomponent.hxx|5 ++
accessibility/source/standard/vclxaccessibleedit.cxx | 16
accessibility/source/standard/vclxaccessibletextcomponent.cxx | 18 +-
4 files changed, 41 insertions(+), 1 deletion(-)
New commits:
commit ab7a94b8403e7fc89398a603a10e9002bd7e2077
Author: Michael Weghorn
AuthorDate: Fri May 10 15:35:23 2024 +0200
Commit: Michael Weghorn
CommitDate: Fri May 10 21:49:49 2024 +0200
tdf#160971 a11y: Send full text on changed combobox text
When the text of an editable combobox is changed
(e.g. using the up/down keys), the Orca screen
reader on Linux announces the newly inserted text.
This has been the case for other GTK or Qt
applications for a while, and with recent Orca
commit [1]
commit 3a9e6b8d7b16bf2fc7919868cfd1a16e44422710
Author: Michael Weghorn
Date: Fri May 10 10:16:58 2024 +0200
soffice: Use default logic for editable combobox value change
, the same logic is used for LibreOffice as well.
For the gtk3 VCL plugin which has a custom combobox
implementation using native GTK widgets, this generally
works since
commit 9f078ed7b625e86182d64d5ccfbb410cdd38081c
Author: Michael Weghorn
Date: Tue May 7 10:04:16 2024 +0200
tdf#160971 gtk3 a11y: Set role for custom editable combobox
However, the qt6 VCL plugin uses the VCL combobox
implementation, and only the actual difference between
the text of the previous and current entry was sent
in the TEXT_CHANGED event, resulting in Orca only
announcing those letters that were added/changed,
e.g. just "ans Narrow" when changing the font in the
Writer formatting toolbar from "Liberation Serif"
to "Liberation Sans Narrow".
This doesn't really make clear what entry is selected.
Align the a11y event with what GTK and Qt do
and set the full old and new entry texts in the event.
To do that, add a new virtual
`VCLXAccessibleTextComponent:PreferFullTextInTextChangedEvent`
that defaults to false to keep the previous behavior as default,
and override it for `VCLXAccessibleEdit` to return true
in the case that the edit is the subedit of a combobox
(the parent has a combobox role).
Use this in `VCLXAccessibleTextComponent::SetText` to
determine whether to notify just of the changed characters
or to send the whole old/new text.
With this in place, Orca also announces the whole new
entry text (e.g. "Liberation Sans Narrow" for the above
example) when using the qt6 VCL plugin.
(It currently additionally announces an extra "Selection
deleted" when switching entries, as the text selection
also changes, but that aspect is to be handled separate
from this change here.)
[1]
https://gitlab.gnome.org/GNOME/orca/-/commit/3a9e6b8d7b16bf2fc7919868cfd1a16e44422710
Change-Id: I240aa0ad5ac9585e007d67a8c69e305cf1f38185
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167479
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/accessibility/inc/standard/vclxaccessibleedit.hxx
b/accessibility/inc/standard/vclxaccessibleedit.hxx
index b3b6a239b9d7..187a03264718 100644
--- a/accessibility/inc/standard/vclxaccessibleedit.hxx
+++ b/accessibility/inc/standard/vclxaccessibleedit.hxx
@@ -50,6 +50,9 @@ protected:
virtual OUStringimplGetText() override;
virtual voidimplGetSelection( sal_Int32& nStartIndex,
sal_Int32& nEndIndex ) override;
+// VCLXAccessibleTextComponent
+virtual boolPreferFullTextInTextChangedEvent() override;
+
public:
VCLXAccessibleEdit( VCLXWindow* pVCLXindow );
diff --git a/accessibility/inc/standard/vclxaccessibletextcomponent.hxx
b/accessibility/inc/standard/vclxaccessibletextcomponent.hxx
index 3585dd778574..9678eb15469b 100644
--- a/accessibility/inc/standard/vclxaccessibletextcomponent.hxx
+++ b/accessibility/inc/standard/vclxaccessibletextcomponent.hxx
@@ -40,6 +40,11 @@ class VCLXAccessibleTextComponent : public
cppu::ImplInheritanceHelper<
protected:
voidSetText( const OUString& sText );
+// Whether text segments for old/new value in
AccessibleEventId::TEXT_CHANGED
+// event should always include the whole old and new text instead of just
+// the characters that changed between the two
+virtual boolPreferFullTextInTextChangedEvent()
{ return false; };
+
virtual voidProcessWindowEvent( const
VclWindowEvent& rVclWindowEvent ) override;
// OCommonAccessibleText
diff --git a/accessibility/source/standard/vclxaccessibleedit.cxx
[Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 BogdanB changed: What|Removed |Added Depends on||161019 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=161019 [Bug 161019] Visual fidelity issues when exporting spreadsheets with merged cells to PDF after changes to cell data management -- You are receiving this mail because: You are the assignee for the bug.
[Bug 108320] [META] Calc cells merging and splitting bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108320 BogdanB changed: What|Removed |Added Depends on||161019 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=161019 [Bug 161019] Visual fidelity issues when exporting spreadsheets with merged cells to PDF after changes to cell data management -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161019] Visual fidelity issues when exporting spreadsheets with merged cells to PDF after changes to cell data management
https://bugs.documentfoundation.org/show_bug.cgi?id=161019 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Blocks||103378, 108320 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103378 [Bug 103378] [META] PDF export bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=108320 [Bug 108320] [META] Calc cells merging and splitting bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102593 BogdanB changed: What|Removed |Added Depends on||138506 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=138506 [Bug 138506] Retain modified style format (instead of using the default built-in style format) when copy cell range and paste as GDI format in Draw -- You are receiving this mail because: You are the assignee for the bug.
[Bug 138506] Retain modified style format (instead of using the default built-in style format) when copy cell range and paste as GDI format in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=138506 BogdanB changed: What|Removed |Added Blocks||102593 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102593 [Bug 102593] [META] Paste bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161027] EDITING: Copying and pasting loses formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=161027 BogdanB changed: What|Removed |Added Blocks||102593 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102593 [Bug 102593] [META] Paste bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102593 BogdanB changed: What|Removed |Added Depends on||161027 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=161027 [Bug 161027] EDITING: Copying and pasting loses formatting -- You are receiving this mail because: You are the assignee for the bug.
core.git: vcl/source
vcl/source/app/svapp.cxx | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
New commits:
commit b1c77f927aced5eeaebd5c17c30efdc1df74c4f9
Author: Michael Meeks
AuthorDate: Fri May 10 17:13:55 2024 +0100
Commit: Michael Meeks
CommitDate: Fri May 10 21:25:15 2024 +0200
lok: dumpState should truncate very long JSON messages.
Otherwise we get huge dumps which can overwhelm our logging and hide
more useful information, and/or the journal can drop them on the ground.
Change-Id: Ie942c70a90a6df60ccd8986444362d622c213e15
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167456
Tested-by: Jenkins
Reviewed-by: Michael Meeks
diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx
index 8bfcb5e03d66..b3a63cd05a46 100644
--- a/vcl/source/app/svapp.cxx
+++ b/vcl/source/app/svapp.cxx
@@ -1750,11 +1750,17 @@ void dumpState(rtl::OStringBuffer )
vcl::Window *pWin = Application::GetFirstTopLevelWindow();
while (pWin)
{
-tools::JsonWriter props;
-pWin->DumpAsPropertyTree(props);
+tools::JsonWriter aProps;
+pWin->DumpAsPropertyTree(aProps);
rState.append("
Window: ");
-rState.append(props.finishAndGetAsOString());
+OString aPropStr = aProps.finishAndGetAsOString();
+if (aPropStr.getLength() > 256)
+{
+rState.append(aPropStr.subView(0, 256));
+rState.append("...");
+} else
+rState.append(aPropStr);
pWin = Application::GetNextTopLevelWindow( pWin );
}
[Bug 161022] [META] Word-breaking / line-breaking issues
https://bugs.documentfoundation.org/show_bug.cgi?id=161022 Hossein changed: What|Removed |Added Depends on||94030 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=94030 [Bug 94030] line wrap at non-breaking space when recording changes -- You are receiving this mail because: You are the assignee for the bug.
[Bug 94030] line wrap at non-breaking space when recording changes
https://bugs.documentfoundation.org/show_bug.cgi?id=94030 Hossein changed: What|Removed |Added Blocks||161022 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=161022 [Bug 161022] [META] Word-breaking / line-breaking issues -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160892] "Write Error. Error in writing sub-document SfxBaseModel::storeSelf: 0x70c23..."
https://bugs.documentfoundation.org/show_bug.cgi?id=160892
--- Comment #8 from rgz92 ---
Issue is still present on my end.
I tried moving the "user" folder
("/home/pc/.var/app/org.libreoffice.LibreOffice/config/libreoffice/4") to a
different location and having LibreOffice generate a new one in its place. The
issue remained, so it's not related to a corrupt user folder. However as
mentioned, the issue is not present with the same file on another PC with
inferior specs, so it may still be a corrupt file issue, just not a file in the
user folder. What should I check?
--
You are receiving this mail because:
You are the assignee for the bug.
core.git: chart2/qa chart2/source
chart2/qa/extras/chart2export.cxx | 14 --
chart2/source/view/inc/VDataSeries.hxx |1 -
chart2/source/view/main/SeriesPlotterContainer.cxx |2 ++
3 files changed, 6 insertions(+), 11 deletions(-)
New commits:
commit 4425741937fbd240fe414a68a7d5e9ac4b40affd
Author: Kurt Nordback
AuthorDate: Fri May 10 09:59:52 2024 -0600
Commit: Noel Grandin
CommitDate: Fri May 10 19:57:15 2024 +0200
tdf#161013 Rendering error when changing chart type for saved of-pie chart
Reset pie sub-type property in XDiagram after passing it down,
so that it does not persist and overwrite the modified sub-type
Change-Id: If23ef2b1cff29efa5232d49381676592a0f39d17
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167487
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/chart2/qa/extras/chart2export.cxx
b/chart2/qa/extras/chart2export.cxx
index 1c4977f5d38b..4335ee9ff887 100644
--- a/chart2/qa/extras/chart2export.cxx
+++ b/chart2/qa/extras/chart2export.cxx
@@ -1147,11 +1147,8 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest, tdf50934_barOfPie)
xChartType->getChartType());
// Verify that it saves and loads as bar-of-pie
-Reference< chart2::XDiagram> xDia(xChartDoc->getFirstDiagram());
-CPPUNIT_ASSERT(xDia.is());
-uno::Reference< beans::XPropertySet > xDiaProp( xDia, uno::UNO_QUERY );
-CPPUNIT_ASSERT(xDiaProp.is());
-uno::Any aAny = xDiaProp->getPropertyValue(u"SubPieType"_ustr);
+Reference< beans::XPropertySet > xPropSet( xChartType,
uno::UNO_QUERY_THROW );
+uno::Any aAny = xPropSet->getPropertyValue(u"SubPieType"_ustr);
CPPUNIT_ASSERT(aAny.hasValue());
chart2::PieChartSubType subPieType;
aAny >>= subPieType;
@@ -1173,11 +1170,8 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest, tdf50934_pieOfPie)
xChartType->getChartType());
// Verify that it saves and loads as pie-of-pie
-Reference< chart2::XDiagram> xDia(xChartDoc->getFirstDiagram());
-CPPUNIT_ASSERT(xDia.is());
-uno::Reference< beans::XPropertySet > xDiaProp( xDia, uno::UNO_QUERY );
-CPPUNIT_ASSERT(xDiaProp.is());
-uno::Any aAny = xDiaProp->getPropertyValue(u"SubPieType"_ustr);
+Reference< beans::XPropertySet > xPropSet( xChartType,
uno::UNO_QUERY_THROW );
+uno::Any aAny = xPropSet->getPropertyValue(u"SubPieType"_ustr);
CPPUNIT_ASSERT(aAny.hasValue());
chart2::PieChartSubType subPieType;
aAny >>= subPieType;
diff --git a/chart2/source/view/inc/VDataSeries.hxx
b/chart2/source/view/inc/VDataSeries.hxx
index dd5054d26bd8..72f5fca80089 100644
--- a/chart2/source/view/inc/VDataSeries.hxx
+++ b/chart2/source/view/inc/VDataSeries.hxx
@@ -26,7 +26,6 @@
#include
#include
#include
-#include
#include
#include
diff --git a/chart2/source/view/main/SeriesPlotterContainer.cxx
b/chart2/source/view/main/SeriesPlotterContainer.cxx
index 557bbdae3c11..c76d96a4f20f 100644
--- a/chart2/source/view/main/SeriesPlotterContainer.cxx
+++ b/chart2/source/view/main/SeriesPlotterContainer.cxx
@@ -232,6 +232,8 @@ void
SeriesPlotterContainer::initializeCooSysAndSeriesPlotter(ChartModel& rChart
{
xChartType->setFastPropertyValue(PROP_PIECHARTTYPE_SUBTYPE,
uno::Any(ePieChartSubType));
+// Reset the diagram-level property so it's not persistent.
+xDiagram->setPropertyValue(u"SubPieType"_ustr,
uno::Any(PieChartSubType_NONE));
}
if (nT == 0)
core.git: cui/source
cui/source/options/optpath.cxx | 35 ---
1 file changed, 16 insertions(+), 19 deletions(-)
New commits:
commit 3563fca550f678a6797769cd3b5e529e95ca7e36
Author: Noel Grandin
AuthorDate: Tue May 7 13:57:38 2024 +0200
Commit: Noel Grandin
CommitDate: Fri May 10 19:55:57 2024 +0200
replace createFromAscii with OUString literals in SvxPathTabPage
Change-Id: I831bc78f4934c7d1c137ad70c7bb189d75237e88
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167473
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/cui/source/options/optpath.cxx b/cui/source/options/optpath.cxx
index e81d12043ed2..6357989e5fb9 100644
--- a/cui/source/options/optpath.cxx
+++ b/cui/source/options/optpath.cxx
@@ -92,42 +92,39 @@ struct PathUserData_Impl
struct Handle2CfgNameMapping_Impl
{
SvtPathOptions::Paths m_nHandle;
-const char* m_pCfgName;
+OUString m_aCfgName;
};
}
-Handle2CfgNameMapping_Impl const Hdl2CfgMap_Impl[] =
+constexpr Handle2CfgNameMapping_Impl Hdl2CfgMap_Impl[]
{
-{ SvtPathOptions::Paths::AutoCorrect, "AutoCorrect" },
-{ SvtPathOptions::Paths::AutoText,"AutoText" },
-{ SvtPathOptions::Paths::Backup, "Backup" },
-{ SvtPathOptions::Paths::Gallery, "Gallery" },
-{ SvtPathOptions::Paths::Graphic, "Graphic" },
-{ SvtPathOptions::Paths::Temp,"Temp" },
-{ SvtPathOptions::Paths::Template,"Template" },
-{ SvtPathOptions::Paths::Work,"Work" },
-{ SvtPathOptions::Paths::Dictionary,"Dictionary" },
-{ SvtPathOptions::Paths::Classification, "Classification" },
+{ SvtPathOptions::Paths::AutoCorrect, u"AutoCorrect"_ustr },
+{ SvtPathOptions::Paths::AutoText,u"AutoText"_ustr },
+{ SvtPathOptions::Paths::Backup, u"Backup"_ustr },
+{ SvtPathOptions::Paths::Gallery, u"Gallery"_ustr },
+{ SvtPathOptions::Paths::Graphic, u"Graphic"_ustr },
+{ SvtPathOptions::Paths::Temp,u"Temp"_ustr },
+{ SvtPathOptions::Paths::Template,u"Template"_ustr },
+{ SvtPathOptions::Paths::Work,u"Work"_ustr },
+{ SvtPathOptions::Paths::Dictionary, u"Dictionary"_ustr },
+{ SvtPathOptions::Paths::Classification, u"Classification"_ustr },
#if OSL_DEBUG_LEVEL > 1
-{ SvtPathOptions::Paths::Linguistic,"Linguistic" },
+{ SvtPathOptions::Paths::Linguistic, u"Linguistic"_ustr },
#endif
-{ SvtPathOptions::Paths::LAST, nullptr }
};
static OUString getCfgName_Impl( SvtPathOptions::Paths _nHandle )
{
OUString sCfgName;
-sal_uInt16 nIndex = 0;
-while ( Hdl2CfgMap_Impl[ nIndex ].m_nHandle != SvtPathOptions::Paths::LAST
)
+for (const auto & rMapping : Hdl2CfgMap_Impl)
{
-if ( Hdl2CfgMap_Impl[ nIndex ].m_nHandle == _nHandle )
+if ( rMapping.m_nHandle == _nHandle )
{
// config name found
-sCfgName = OUString::createFromAscii( Hdl2CfgMap_Impl[ nIndex
].m_pCfgName );
+sCfgName = rMapping.m_aCfgName;
break;
}
-++nIndex;
}
return sCfgName;
[Bug 158617] Underlining no vertical separation from text
https://bugs.documentfoundation.org/show_bug.cgi?id=158617 --- Comment #4 from Regis Perdreau --- Please indicate : - Font used - Do you see the same behaviour in Calc? - Windows version Tks -- You are receiving this mail because: You are the assignee for the bug.
Re: tdf132599_frames_* tests needs hu-HU hyphenation for english text
Hi again, Am 10.05.24 um 17:27 schrieb Rene Engelhard: Am 10.05.24 um 17:18 schrieb Rene Engelhard: [...] The test code sets en_US as locale, and the text files have english text. Well, sets is wrong, by bad. But it checks for it and skips the test if en_US isn't there. But LibreOffice suggests to install hu-HU hyphenation patterns when opening the .fodt. Indeed, the text is formatted as Hungarian. but as said it expects hu-HU since the text is formatted as Hungarian. I think the files should be fixed to set the text language to English (USA) instead? https://gerrit.libreoffice.org/c/core/+/167486. (Probably bigger than needed since I used my workstations Debian stable LO for it. Feel free to do it less invasive to the .fodt diff if possible :) I don't know how minimal the diff was is if one edited it with a newer LO.) But I got only down to Test name: (anonymous namespace)::testTdf132599_frames_on_same_page_hyphenation::TestBody equality assertion failed - Expected: cept that it - Actual : space, ex - In <>, attribute 'portion' of '/root/page/body/txt/anchored/fly[2]/txt/SwParaPortion/SwLineLayout[1]' incorrect value. xmltesttools.cxx:170:Assertion Test name: (anonymous namespace)::testTdf132599_frames_on_spread_hyphenation::TestBody equality assertion failed - Expected: cept that it - Actual : space, - In <>, attribute 'portion' of '/root/page[3]/body/txt/anchored/fly/txt/SwParaPortion/SwLineLayout[1]' incorrect value. Failures !!! Run: 95 Failure total: 2 Failures: 2 Errors: 0 make: *** [/home/rene/LibreOffice/git/master/solenv/gbuild/CppunitTest.mk:130: /home/rene/LibreOffice/git/master/workdir/CppunitTest/sw_layoutwriter3.test] Error 1 and yes, I see that in that (obviously, since this is with 7.6.7) when I open the document. But shouldn' t that be a non-issue if tested with a "correct" LO? Interestingly Jenkins' builds work fine here even with my new documents.. Do I miss something here? Regards, Rene
[Bug 161031] Form creating is too niche to merit a main menu item visible by default
https://bugs.documentfoundation.org/show_bug.cgi?id=161031 Eyal Rozenberg changed: What|Removed |Added CC||eyalr...@gmx.com, ||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval -- You are receiving this mail because: You are the assignee for the bug.
[Bug 107742] [META] Form control bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107742 Eyal Rozenberg changed: What|Removed |Added Depends on||161031 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=161031 [Bug 161031] Form creating is too niche to merit a main menu item visible by default -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161031] Form creating is too niche to merit a main menu item visible by default
https://bugs.documentfoundation.org/show_bug.cgi?id=161031 Eyal Rozenberg changed: What|Removed |Added CC||eyalr...@gmx.com, ||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 161031] Form creating is too niche to merit a main menu item visible by default
https://bugs.documentfoundation.org/show_bug.cgi?id=161031 Eyal Rozenberg changed: What|Removed |Added Blocks||107742 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107742 [Bug 107742] [META] Form control bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161031] New: Form creating is too niche to merit a main menu item visible by default
https://bugs.documentfoundation.org/show_bug.cgi?id=161031 Bug ID: 161031 Summary: Form creating is too niche to merit a main menu item visible by default Product: LibreOffice Version: 24.8.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eyalr...@gmx.com LO Writer currently has the following main menu items: File | Edit | View | Insert | Format | Styles | Table | Form | Tools | Window | Help I submit, that the creation of forms and form control, in a document without forms to begin with, is niche enough, that it does not merit its own main menubar item, it's own top-level menu. Instead, I suggest that the menu become visible under any of the following conditions: 1. Activating it, using a checkbox to be placed in one of the other menus (e.g. Tools) 2. Having made a setting in Toos | Options... to always have the Forms menu visible 3. (Perhaps) opening a document which has forms/form controls, in non-Read-Only mode What say you? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161027] EDITING: Copying and pasting loses formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=161027 --- Comment #4 from m_a_riosv --- Looks like a duplicate of tdf#138506 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161027] EDITING: Copying and pasting loses formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=161027 m_a_riosv changed: What|Removed |Added Ever confirmed|0 |1 CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEW --- Comment #3 from m_a_riosv --- Reproducible Version: 24.2.3.2 (X86_64) / LibreOffice Community Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: default; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Those text boxes have 'Default drawing style', but in the source file the style has no background, while in a new file has. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 107742] [META] Form control bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107742 Eyal Rozenberg changed: What|Removed |Added Depends on||160938 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160938 [Bug 160938] FORMCONTROLS: Add ability to Find and Replace field names -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160938] FORMCONTROLS: Add ability to Find and Replace field names
https://bugs.documentfoundation.org/show_bug.cgi?id=160938 Eyal Rozenberg changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval Blocks||107742 --- Comment #1 from Eyal Rozenberg --- Support this. UI-wise, it could be as easy as adding another checkbox in the F dialog: [ ] Field Names like we have [ ] Comments Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107742 [Bug 107742] [META] Form control bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160938] FORMCONTROLS: Add ability to Find and Replace field names
https://bugs.documentfoundation.org/show_bug.cgi?id=160938 Eyal Rozenberg changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval Blocks||107742 --- Comment #1 from Eyal Rozenberg --- Support this. UI-wise, it could be as easy as adding another checkbox in the F dialog: [ ] Field Names like we have [ ] Comments Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107742 [Bug 107742] [META] Form control bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug.
core.git: include/vcl vcl/backendtest vcl/headless vcl/inc vcl/jsdialog vcl/qa vcl/qt5 vcl/skia vcl/source vcl/unx vcl/workben
include/vcl/textfilter.hxx |2 include/vcl/weldutils.hxx |4 vcl/backendtest/GraphicsRenderTests.cxx| 440 ++--- vcl/backendtest/VisualBackendTest.cxx |4 vcl/backendtest/outputdevice/text.cxx |4 vcl/headless/svpframe.cxx |2 vcl/headless/svpprn.cxx|4 vcl/inc/font/FontSelectPattern.hxx |2 vcl/inc/headless/SvpGraphicsBackend.hxx|2 vcl/inc/qt5/QtGraphics.hxx |2 vcl/inc/qt5/QtSvpGraphics.hxx |2 vcl/inc/salinst.hxx|2 vcl/inc/skia/gdiimpl.hxx |2 vcl/inc/unx/gtk/gtkgdi.hxx |2 vcl/inc/vclstatuslistener.hxx |2 vcl/jsdialog/executor.cxx | 76 +- vcl/jsdialog/jsdialogbuilder.cxx | 26 vcl/qa/api/XGraphicTest.cxx| 42 - vcl/qa/cppunit/BackendTest.cxx | 234 +++--- vcl/qa/cppunit/BitmapFilterTest.cxx| 18 vcl/qa/cppunit/BitmapScaleTest.cxx | 18 vcl/qa/cppunit/FontFeatureTest.cxx | 34 - vcl/qa/cppunit/GraphicFormatDetectorTest.cxx | 86 +- vcl/qa/cppunit/GraphicTest.cxx | 34 - vcl/qa/cppunit/PDFiumLibraryTest.cxx | 32 vcl/qa/cppunit/VectorGraphicSearchTest.cxx | 32 vcl/qa/cppunit/app/test_IconThemeInfo.cxx |6 vcl/qa/cppunit/app/test_IconThemeScanner.cxx |8 vcl/qa/cppunit/app/test_IconThemeSelector.cxx | 34 - vcl/qa/cppunit/blocklistparsertest.cxx | 34 - vcl/qa/cppunit/cjktext.cxx | 14 vcl/qa/cppunit/complextext.cxx | 22 vcl/qa/cppunit/errorhandler.cxx|4 vcl/qa/cppunit/filter/ipdf/ipdf.cxx| 11 vcl/qa/cppunit/font.cxx|8 vcl/qa/cppunit/gen/gen.cxx |4 vcl/qa/cppunit/graphicfilter/filters-pict-test.cxx |8 vcl/qa/cppunit/graphicfilter/filters-test.cxx |6 vcl/qa/cppunit/graphicfilter/filters-tiff-test.cxx |2 vcl/qa/cppunit/graphicfilter/filters-webp-test.cxx |6 vcl/qa/cppunit/jpeg/JpegWriterTest.cxx |2 vcl/qa/cppunit/logicalfontinstance.cxx |2 vcl/qa/cppunit/mnemonic.cxx| 34 - vcl/qa/cppunit/outdev.cxx |4 vcl/qa/cppunit/pdfexport/pdfexport.cxx | 88 +- vcl/qa/cppunit/pdfexport/pdfexport2.cxx| 261 +++ vcl/qa/cppunit/physicalfontcollection.cxx | 101 +- vcl/qa/cppunit/physicalfontface.cxx| 42 - vcl/qa/cppunit/physicalfontfamily.cxx | 38 - vcl/qa/cppunit/png/PngFilterTest.cxx | 40 - vcl/qa/cppunit/text.cxx| 70 +- vcl/qa/cppunit/textlayout.cxx | 12 vcl/qa/cppunit/widgetdraw/WidgetDefinitionReaderTest.cxx | 16 vcl/qt5/QtClipboard.cxx|7 vcl/qt5/QtDragAndDrop.cxx | 20 vcl/qt5/QtFilePicker.cxx | 14 vcl/qt5/QtFrame.cxx|8 vcl/qt5/QtInstance.cxx |2 vcl/skia/SkiaHelper.cxx| 22 vcl/source/accessibility/AccessibleTextAttributeHelper.cxx | 32 vcl/source/app/IconThemeSelector.cxx |4 vcl/source/app/brand.cxx |4 vcl/source/app/salplug.cxx |4 vcl/source/app/salvtables.cxx | 40 - vcl/source/app/session.cxx |4 vcl/source/app/settings.cxx| 26 vcl/source/app/svapp.cxx |6 vcl/source/app/svdata.cxx |2 vcl/source/app/svmain.cxx |2 vcl/source/app/weldutils.cxx |6 vcl/source/cnttype/mcnttfactory.cxx|4 vcl/source/components/dtranscomp.cxx | 24 vcl/source/components/fontident.cxx
core.git: include/sfx2 sfx2/inc sfx2/qa sfx2/source
include/sfx2/basedlgs.hxx |4 include/sfx2/tplpitem.hxx |2 sfx2/inc/preventduplicateinteraction.hxx |2 sfx2/qa/cppunit/doc.cxx | 36 +-- sfx2/qa/cppunit/test_classification.cxx | 38 +-- sfx2/qa/cppunit/test_metadatable.cxx | 12 - sfx2/qa/cppunit/test_misc.cxx | 18 - sfx2/qa/cppunit/view.cxx |4 sfx2/source/appl/app.cxx |2 sfx2/source/appl/appdata.cxx |2 sfx2/source/appl/appdispatchprovider.cxx |6 sfx2/source/appl/appinit.cxx |4 sfx2/source/appl/appmisc.cxx |2 sfx2/source/appl/appopen.cxx | 36 +-- sfx2/source/appl/appserv.cxx | 68 +++--- sfx2/source/appl/appuno.cxx | 56 ++-- sfx2/source/appl/childwin.cxx |4 sfx2/source/appl/fileobj.cxx |4 sfx2/source/appl/helpinterceptor.cxx |2 sfx2/source/appl/impldde.cxx | 12 - sfx2/source/appl/linkmgr2.cxx |4 sfx2/source/appl/lnkbase2.cxx |2 sfx2/source/appl/macroloader.cxx |8 sfx2/source/appl/newhelp.cxx | 182 sfx2/source/appl/newhelp.hxx |8 sfx2/source/appl/sfxhelp.cxx | 36 +-- sfx2/source/appl/shutdownicon.cxx | 18 - sfx2/source/appl/workwin.cxx |2 sfx2/source/appl/xpackcreator.cxx |4 sfx2/source/bastyp/fltfnc.cxx | 20 - sfx2/source/bastyp/frmhtmlw.cxx | 18 - sfx2/source/bastyp/helper.cxx |8 sfx2/source/bastyp/sfxhtml.cxx|2 sfx2/source/commandpopup/CommandPopup.cxx | 11 sfx2/source/config/evntconf.cxx |2 sfx2/source/control/bindings.cxx |2 sfx2/source/control/charmapcontrol.cxx| 16 - sfx2/source/control/charwin.cxx | 13 - sfx2/source/control/dispatch.cxx | 18 - sfx2/source/control/listview.cxx |8 sfx2/source/control/recentdocsviewitem.cxx| 10 sfx2/source/control/request.cxx |2 sfx2/source/control/statcach.cxx |2 sfx2/source/control/templatedefaultview.cxx |4 sfx2/source/control/templatedlglocalview.cxx | 46 ++-- sfx2/source/control/templatelocalview.cxx |2 sfx2/source/control/thumbnailview.cxx |8 sfx2/source/control/thumbnailviewacc.cxx |8 sfx2/source/control/thumbnailviewitem.cxx |2 sfx2/source/control/unoctitm.cxx |2 sfx2/source/devtools/DevelopmentToolDockingWindow.cxx | 16 - sfx2/source/devtools/DocumentModelTreeHandler.cxx | 10 sfx2/source/devtools/ObjectInspectorTreeHandler.cxx | 25 +- sfx2/source/devtools/ObjectInspectorWidgets.cxx | 18 - sfx2/source/dialog/StyleList.cxx | 50 ++-- sfx2/source/dialog/alienwarn.cxx | 11 sfx2/source/dialog/backingcomp.cxx| 24 +- sfx2/source/dialog/backingwindow.cxx | 92 sfx2/source/dialog/backingwindow.hxx |2 sfx2/source/dialog/basedlgs.cxx |8 sfx2/source/dialog/charmappopup.cxx |4 sfx2/source/dialog/checkin.cxx|8 sfx2/source/dialog/dinfdlg.cxx| 204 +- sfx2/source/dialog/documentfontsdialog.cxx| 36 +-- sfx2/source/dialog/filedlghelper.cxx | 142 ++-- sfx2/source/dialog/filtergrouping.cxx |4 sfx2/source/dialog/infobar.cxx| 20 - sfx2/source/dialog/inputdlg.cxx | 12 - sfx2/source/dialog/mailmodel.cxx | 28 +- sfx2/source/dialog/mgetempl.cxx | 24 +- sfx2/source/dialog/navigat.cxx|2 sfx2/source/dialog/newstyle.cxx |6 sfx2/source/dialog/partwnd.cxx|2 sfx2/source/dialog/passwd.cxx | 40 +-- sfx2/source/dialog/printopt.cxx | 86 +++ sfx2/source/dialog/recfloat.cxx |6 sfx2/source/dialog/securitypage.cxx | 10
core.git: 2 commits - cui/source
cui/source/customize/eventdlg.cxx |2
cui/source/customize/macropg.cxx | 162 ++-
cui/source/inc/macropg.hxx| 14 ---
cui/source/options/treeopt.cxx| 173 ++
4 files changed, 168 insertions(+), 183 deletions(-)
New commits:
commit e888503ee0aecbce8f3075b106243cf68b8dddc7
Author: Noel Grandin
AuthorDate: Tue May 7 14:02:33 2024 +0200
Commit: Noel Grandin
CommitDate: Fri May 10 18:42:22 2024 +0200
replace createFromAscii with OUString literals in OfaTreeOptionsDialog
Change-Id: Ibe4de7e2ac6f0f00ba495ecbd18d97154283169c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167474
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/cui/source/options/treeopt.cxx b/cui/source/options/treeopt.cxx
index 646b3bdee917..f010df6f42a1 100644
--- a/cui/source/options/treeopt.cxx
+++ b/cui/source/options/treeopt.cxx
@@ -293,112 +293,109 @@ namespace {
struct OptionsMapping_Impl
{
-const char* m_pGroupName;
-const char* m_pPageName;
+OUString m_aGroupName;
+OUString m_aPageName;
sal_uInt16 m_nPageId;
};
}
-OptionsMapping_Impl const OptionsMap_Impl[] =
+constexpr OptionsMapping_Impl OptionsMap_Impl[]
{
//GROUP PAGEPAGE-ID
-{ "ProductName",nullptr,SID_GENERAL_OPTIONS },
-{ "ProductName","UserData", RID_SFXPAGE_GENERAL },
-{ "ProductName","General", OFA_TP_MISC },
-{ "ProductName","View", OFA_TP_VIEW },
-{ "ProductName","Print",RID_SFXPAGE_PRINTOPTIONS },
-{ "ProductName","Paths",RID_SFXPAGE_PATH },
-{ "ProductName","Fonts",RID_SVX_FONT_SUBSTITUTION
},
-{ "ProductName","Security", RID_SVXPAGE_INET_SECURITY
},
-{ "ProductName","Personalization",
RID_SVXPAGE_PERSONALIZATION },
-{ "ProductName","Appearance", RID_SVXPAGE_COLORCONFIG },
-{ "ProductName","Accessibility",
RID_SVXPAGE_ACCESSIBILITYCONFIG },
-{ "ProductName","Java", RID_SVXPAGE_OPTIONS_JAVA },
-{ "ProductName","BasicIDEOptions",
RID_SVXPAGE_BASICIDE_OPTIONS },
-{ "ProductName","OnlineUpdate", RID_SVXPAGE_ONLINEUPDATE },
-{ "LanguageSettings", nullptr,SID_LANGUAGE_OPTIONS },
-{ "LanguageSettings", "Languages",OFA_TP_LANGUAGES },
-{ "LanguageSettings", "WritingAids", RID_SFXPAGE_LINGU },
-{ "LanguageSettings", "SearchingInJapanese",
RID_SVXPAGE_JSEARCH_OPTIONS },
-{ "LanguageSettings", "AsianLayout", RID_SVXPAGE_ASIAN_LAYOUT },
-{ "LanguageSettings", "ComplexTextLayout",RID_SVXPAGE_OPTIONS_CTL },
-{ "Internet", nullptr,SID_INET_DLG },
-{ "Internet", "Proxy",RID_SVXPAGE_INET_PROXY },
-{ "Internet", "Email",RID_SVXPAGE_INET_MAIL },
-{ "LoadSave", nullptr,SID_FILTER_DLG },
-{ "LoadSave", "General", RID_SFXPAGE_SAVE },
-{ "LoadSave", "VBAProperties",SID_OPTFILTER_MSOFFICE },
-{ "LoadSave", "MicrosoftOffice", RID_OFAPAGE_MSFILTEROPT2 },
-{ "LoadSave", "HTMLCompatibility",RID_OFAPAGE_HTMLOPT },
-{ "Writer", nullptr,SID_SW_EDITOPTIONS },
-{ "Writer", "General", RID_SW_TP_OPTLOAD_PAGE },
-{ "Writer", "View", RID_SW_TP_CONTENT_OPT },
-{ "Writer", "FormattingAids", RID_SW_TP_OPTSHDWCRSR },
-{ "Writer", "Grid", RID_SVXPAGE_GRID },
-{ "Writer", "BasicFontsWestern",RID_SW_TP_STD_FONT },
-{ "Writer", "BasicFontsAsian", RID_SW_TP_STD_FONT_CJK },
-{ "Writer", "BasicFontsCTL",RID_SW_TP_STD_FONT_CTL },
-{ "Writer", "Print",RID_SW_TP_OPTPRINT_PAGE },
-{ "Writer", "Table",RID_SW_TP_OPTTABLE_PAGE },
-{ "Writer", "Changes", RID_SW_TP_REDLINE_OPT },
-{ "Writer", "Comparison", RID_SW_TP_COMPARISON_OPT },
-{ "Writer", "Compatibility",
RID_SW_TP_OPTCOMPATIBILITY_PAGE },
-{ "Writer", "AutoCaption", RID_SW_TP_OPTCAPTION_PAGE
},
-{ "Writer", "MailMerge",RID_SW_TP_MAILCONFIG },
-{ "WriterWeb", nullptr,SID_SW_ONLINEOPTIONS },
-{ "WriterWeb", "View", RID_SW_TP_HTML_CONTENT_OPT
},
-{ "WriterWeb", "FormattingAids", RID_SW_TP_HTML_OPTSHDWCRSR
},
-{ "WriterWeb", "Grid",
[Bug 158617] Underlining no vertical separation from text
https://bugs.documentfoundation.org/show_bug.cgi?id=158617 --- Comment #3 from Regis Perdreau --- UP ! I'm interested by any information . -- You are receiving this mail because: You are the assignee for the bug.
[Bug 147549] Track changes: bullet does show, until change is reject (except if save & reload in between)
https://bugs.documentfoundation.org/show_bug.cgi?id=147549 --- Comment #4 from Dieter --- Retested with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 7c2ed9919d6d9d286d9062b91577d6bb2b7de8aa CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL threaded Actual result after step 4: Second bullet disappears Expected result after step 4: All bullets are present (same as after step 8) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161019] Visual fidelity issues when exporting spreadsheets with merged cells to PDF after changes to cell data management
https://bugs.documentfoundation.org/show_bug.cgi?id=161019 m_a_riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEW Keywords||bibisectRequest, regression Ever confirmed|0 |1 --- Comment #1 from m_a_riosv --- Reproducible Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: ad1f0bdeac30fca1dc56a08803ef23f2aca4db05 CPU threads: 16; OS: Windows 11 (10.0 build 22631); UI render: default; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Last working Version: 7.6.6.3 (X86_64) / LibreOffice Community Build ID: d97b2716a9a4a2ce1391dee1765565ea469b0ae7 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: es-ES Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160843] Page numbers do not reset
https://bugs.documentfoundation.org/show_bug.cgi?id=160843 Buovjaga changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=16 | |0958| -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160958] Hidding section covering at least two pages doesn't work properly
https://bugs.documentfoundation.org/show_bug.cgi?id=160958 Buovjaga changed: What|Removed |Added See Also|https://bugs.documentfounda |https://bugs.documentfounda |tion.org/show_bug.cgi?id=16 |tion.org/show_bug.cgi?id=15 |0843|9565 Version|24.2.3.2 release|24.8.0.0 alpha0+ Master Keywords||bisected Regression By||Mike Kaganski -- You are receiving this mail because: You are the assignee for the bug.
[Bug 131133] FILESAVE TXT: Text of endnotes and footnotes disappears when saving as txt
https://bugs.documentfoundation.org/show_bug.cgi?id=131133 --- Comment #7 from Dieter --- Still reproducible for me with Version: 24.2.3.2 (X86_64) / LibreOffice Community Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'distro/collabora/co-24.04' - binaryurp/source comphelper/source cppuhelper/source desktop/source include/rtl oox/source package/inc package/source sal/rtl sc/source stoc/source svl/s
binaryurp/source/bridge.cxx|4 --
comphelper/source/misc/docpasswordhelper.cxx |4 --
comphelper/source/misc/random.cxx |4 --
comphelper/source/misc/storagehelper.cxx |6
comphelper/source/xml/xmltools.cxx |8 +
cppuhelper/source/bootstrap.cxx|6
desktop/source/deployment/misc/dp_misc.cxx |5 ---
include/rtl/random.h | 29 +++--
oox/source/crypto/Standard2007Engine.cxx |4 --
package/inc/ZipPackageEntry.hxx|4 --
package/inc/ZipPackageFolder.hxx |6 +---
package/inc/ZipPackageStream.hxx |3 --
package/source/zippackage/ZipPackage.cxx | 28
package/source/zippackage/ZipPackageFolder.cxx | 14 --
package/source/zippackage/ZipPackageStream.cxx |7 ++---
sal/rtl/random.cxx |5 +--
sal/rtl/uuid.cxx | 26 +++---
sc/source/filter/excel/xeroot.cxx |4 --
sc/source/filter/excel/xestream.cxx|4 --
stoc/source/javaloader/javaloader.cxx |5 ---
svl/source/passwordcontainer/passwordcontainer.cxx |3 --
svl/source/passwordcontainer/passwordcontainer.hxx | 23
sw/source/filter/ww8/wrtww8.cxx|4 --
sw/source/filter/ww8/ww8par.cxx|4 --
xmlsecurity/source/xmlsec/nss/ciphercontext.cxx|4 --
25 files changed, 54 insertions(+), 160 deletions(-)
New commits:
commit 3f15ad602da8a68d7cb63b02d9b456b0bd1d623b
Author: Caolán McNamara
AuthorDate: Fri May 3 16:33:11 2024 +0100
Commit: Michael Meeks
CommitDate: Fri May 10 18:25:27 2024 +0200
drop requirement for rtl_random_getBytes to have "Pool" arg
Seeing as since:
commit e9531b792ddf0cfc2db11713b574c5fc7ae09e2c
Date: Tue Feb 6 14:39:47 2024 +0100
sal: rtlRandomPool: require OS random device, abort if not present
Both rtl_random_createPool() and rtl_random_getBytes() first try to get
random data from the OS, via /dev/urandom or rand_s() (documented to
call RtlGenRandom(), see [1]).
we don't use the initial arg to rtl_random_getBytes anymore, drop the
requirement to have one. Then simplify our usages of that, and
addtionally deprecate rtl_random_createPool and rtl_random_destroyPool.
Change-Id: I13dcc067714a8a741a4e8f2bfcf2006373f832c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167335
Reviewed-by: Michael Meeks
Tested-by: Jenkins CollaboraOffice
diff --git a/binaryurp/source/bridge.cxx b/binaryurp/source/bridge.cxx
index 523bbbf14ac5..f8c4cb232562 100644
--- a/binaryurp/source/bridge.cxx
+++ b/binaryurp/source/bridge.cxx
@@ -74,9 +74,7 @@ namespace {
sal_Int32 random() {
sal_Int32 n;
-rtlRandomPool pool = rtl_random_createPool();
-rtl_random_getBytes(pool, , sizeof n);
-rtl_random_destroyPool(pool);
+(void)rtl_random_getBytes(nullptr, , sizeof n);
return n;
}
diff --git a/comphelper/source/misc/docpasswordhelper.cxx
b/comphelper/source/misc/docpasswordhelper.cxx
index 1f73bd8d7026..9082efa054e0 100644
--- a/comphelper/source/misc/docpasswordhelper.cxx
+++ b/comphelper/source/misc/docpasswordhelper.cxx
@@ -426,12 +426,10 @@ OUString DocPasswordHelper::GetOoxHashAsBase64(
{
uno::Sequence< sal_Int8 > aResult( nLength );
-rtlRandomPool aRandomPool = rtl_random_createPool ();
-if (rtl_random_getBytes(aRandomPool, aResult.getArray(), nLength) !=
rtl_Random_E_None)
+if (rtl_random_getBytes(nullptr, aResult.getArray(), nLength) !=
rtl_Random_E_None)
{
throw uno::RuntimeException("rtl_random_getBytes failed");
}
-rtl_random_destroyPool ( aRandomPool );
return aResult;
}
diff --git a/comphelper/source/misc/random.cxx
b/comphelper/source/misc/random.cxx
index b8358344e5b0..4e5ad979b171 100644
--- a/comphelper/source/misc/random.cxx
+++ b/comphelper/source/misc/random.cxx
@@ -60,10 +60,8 @@ struct RandomNumberGenerator
}
size_t seed = -1;
-rtlRandomPool aRandomPool = rtl_random_createPool();
-if (rtl_random_getBytes(aRandomPool, , sizeof(seed)) !=
rtl_Random_E_None)
+if (rtl_random_getBytes(nullptr, , sizeof(seed)) !=
rtl_Random_E_None)
seed = -1;
-rtl_random_destroyPool(aRandomPool);
// initialises the state of the global random number generator
// should only be called once.
diff --git a/comphelper/source/misc/storagehelper.cxx
b/comphelper/source/misc/storagehelper.cxx
index 1d504cb91725..5ba710862d6d 100644
--- a/comphelper/source/misc/storagehelper.cxx
+++ b/comphelper/source/misc/storagehelper.cxx
@@ -443,17 +443,13 @@ uno::Sequence<
[Bug 147311] Redo of anchor position change does brake object position (DOCX)
https://bugs.documentfoundation.org/show_bug.cgi?id=147311 Dieter changed: What|Removed |Added Summary|Undo of anchor position |Redo of anchor position |change does brake object|change does brake object |position (DOCX) |position (DOCX) Blocks||105948 --- Comment #4 from Dieter --- Behaviour changed a bit with Version: 24.2.3.2 (X86_64) / LibreOffice Community Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL threaded Steps: 1. Open attachment 169076 [details] 2. Select 'Details' frame (Frame 1 in navigator) 3. The anchor shows up after 'Hughes' 4. Drag it to 'authoring' 5. Press undo (looks good now) 6. Press redo Actual Results: Position off (DOCX) Expected Results: Same layout as after step 4 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105948 [Bug 105948] [META] Undo/Redo bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 105948] [META] Undo/Redo bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105948 Dieter changed: What|Removed |Added Depends on||147311 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147311 [Bug 147311] Redo of anchor position change does brake object position (DOCX) -- You are receiving this mail because: You are the assignee for the bug.
core.git: config_host.mk.in
config_host.mk.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 51a970b8b0c8f8d5e8d33cd50c88930be3a653d8 Author: Christian Lohmaier AuthorDate: Wed May 8 14:35:11 2024 +0200 Commit: Christian Lohmaier CommitDate: Fri May 10 18:21:55 2024 +0200 make sure KEEP_AWAKE_CMD gets only evaluated once if using deferred evaluation then the creation of targets via $(call gb_Top_GbuildModuleRules,foo) would result in it getting processed over 900 times, and on windows spawning a shell with the two ps and awk command that takes 5 minutes. If future commands need to be run when the rule is run, then an alternative is to escape the variable in the define for the gb_Top_GbuildModuleRules macro via double-$ → $$(KEEP_AWAKE_CMD) - but I cannot think of any method where that should be necessary Change-Id: I126e4d317bd77f359ca9f39adf00cc88846af281 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167351 Tested-by: Jenkins Reviewed-by: Christian Lohmaier diff --git a/config_host.mk.in b/config_host.mk.in index 3ffe88380180..fe1fb546a6d1 100644 --- a/config_host.mk.in +++ b/config_host.mk.in @@ -790,7 +790,7 @@ include $(BUILDDIR)/config_$(gb_Side)_lang.mk # does use some of the variables defined above include @SRC_ROOT@/download.lst -KEEP_AWAKE_CMD=@KEEP_AWAKE_CMD@ +KEEP_AWAKE_CMD:=@KEEP_AWAKE_CMD@ # used for WSL-as-helper-builds where the build runs from within git-bash/MSYS that otherwise would # mess with anything that looks like a path (starts with a /) but cannot be resolved to a target
[Bug 161018] EDITING Calc says "adapt row height" for a short amount of time whenever I select a cell
https://bugs.documentfoundation.org/show_bug.cgi?id=161018 m_a_riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #2 from m_a_riosv --- Please attach a sample file, reduce the size as much as possible without private information, and paste the information in Menu/Help/About LibreOffice, there is a copy icon. You can test, cleaning the direct format outside of ranges with data. If it doesn't work, please test in Menu/Help/Restart in Safe Mode -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160958] Hidding section covering at least two pages doesn't work properly
https://bugs.documentfoundation.org/show_bug.cgi?id=160958 gladys changed: What|Removed |Added CC||mikekagan...@hotmail.com Keywords|bibisectRequest |bibisected --- Comment #7 from gladys --- bibisect windows10, version 24.8 to 0c96119895b347f8eb5bb89f393351bd3c02b9f1 tdf#159565 prerequisite: make hidden sections have zero-height frames Date: Fri Feb 09 11:56:19 2024 +0600 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 134178] Style formatting lost from 5.1 again after paste undo redo in new Writer document
https://bugs.documentfoundation.org/show_bug.cgi?id=134178 Dieter changed: What|Removed |Added CC||michael.st...@allotropia.de --- Comment #14 from Dieter --- (In reply to Buovjaga from comment #6) > Adding Cc: to Michael Stahl Michael, I've just recognized, that you wasn't in cc. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 134178] Style formatting lost from 5.1 again after paste undo redo in new Writer document
https://bugs.documentfoundation.org/show_bug.cgi?id=134178 --- Comment #13 from Dieter --- Still present in Version: 24.2.3.2 (X86_64) / LibreOffice Community Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161016] LibreOffice_7.6.6_Win_x86-64.msi does not run
https://bugs.documentfoundation.org/show_bug.cgi?id=161016 m_a_riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m_a_riosv --- Maybe the download was not successful. Please try again. -- You are receiving this mail because: You are the assignee for the bug.
core.git: external/cppunit
external/cppunit/UnpackedTarball_cppunit.mk |1
external/cppunit/help-msvc-analyzer.patch | 60
2 files changed, 61 insertions(+)
New commits:
commit eb8f353f8b201dd2a1e24b03c7cc496b5ed32f22
Author: Caolán McNamara
AuthorDate: Fri May 10 11:53:19 2024 +0100
Commit: Caolán McNamara
CommitDate: Fri May 10 18:02:05 2024 +0200
help msvc -analyzer out wrt CPPUNIT_ASSERT
so it can code following the CPPUNIT_ASSERT doesn't need
to check what condition might have failed in the assert
Change-Id: Ife7e5e54b17a8316425222d2a0efd694c9467089
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167480
Reviewed-by: Caolán McNamara
Tested-by: Jenkins
diff --git a/external/cppunit/UnpackedTarball_cppunit.mk
b/external/cppunit/UnpackedTarball_cppunit.mk
index 7efe5c4f92bf..207c7e76f283 100644
--- a/external/cppunit/UnpackedTarball_cppunit.mk
+++ b/external/cppunit/UnpackedTarball_cppunit.mk
@@ -37,6 +37,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,cppunit,\
external/cppunit/sprintf.patch.0 \
external/cppunit/clang.patch.0 \
external/cppunit/0001-cid-1546460-COPY_INSTEAD_OF_MOVE.patch.1 \
+ external/cppunit/help-msvc-analyzer.patch \
))
ifeq ($(DISABLE_DYNLOADING),TRUE)
$(eval $(call gb_UnpackedTarball_add_patches,cppunit,\
diff --git a/external/cppunit/help-msvc-analyzer.patch
b/external/cppunit/help-msvc-analyzer.patch
new file mode 100644
index ..26d7fe6e89e6
--- /dev/null
+++ b/external/cppunit/help-msvc-analyzer.patch
@@ -0,0 +1,60 @@
+--- misc/cppunit-1.14.0/include/cppunit/TestAssert.h
misc/build/cppunit-1.14.0/include/cppunit/TestAssert.h
+@@ -261,6 +261,13 @@
+message );
+ }
+ }
++
++#ifdef _MSC_VER
++# define ANALYSIS_ASSUME(condition) __analysis_assume(condition)
++#else
++# define ANALYSIS_ASSUME(condition) static_cast(0)
++#endif
++
+ /* A set of macros which allow us to get the line number
+ * and file name at the point of an error.
+ * Just goes to show that preprocessors do have some
+@@ -271,15 +278,17 @@
+ * \ingroup Assertions
+ */
+ #define CPPUNIT_ASSERT(condition)
\
+- ( CPPUNIT_NS::Asserter::failIf( !(condition),
\
++ do { ( CPPUNIT_NS::Asserter::failIf( !(condition),
\
+ CPPUNIT_NS::Message( "assertion failed",
\
+ "Expression: "
#condition), \
+- CPPUNIT_SOURCELINE() ) )
++ CPPUNIT_SOURCELINE() ) );
\
++ ANALYSIS_ASSUME(condition); } while(0)
+ #else
+ #define CPPUNIT_ASSERT(condition)\
+- ( CPPUNIT_NS::Asserter::failIf( !(condition), \
++ do { ( CPPUNIT_NS::Asserter::failIf( !(condition), \
+ CPPUNIT_NS::Message( "assertion failed" ), \
+- CPPUNIT_SOURCELINE() ) )
++ CPPUNIT_SOURCELINE() ) ); \
++ ANALYSIS_ASSUME(condition); } while(0)
+ #endif
+
+ /** Assertion with a user specified message.
+@@ -289,13 +298,14 @@
+ * \param condition If this condition evaluates to + * test
failed.
+ */
+-#define CPPUNIT_ASSERT_MESSAGE(message,condition) \
+- ( CPPUNIT_NS::Asserter::failIf( !(condition),\
+- CPPUNIT_NS::Message( "assertion failed", \
+- "Expression: " \
+- #condition, \
+-
CPPUNIT_NS::message_to_string(message) ), \
+- CPPUNIT_SOURCELINE() ) )
++#define CPPUNIT_ASSERT_MESSAGE(message,condition)
\
++ do { ( CPPUNIT_NS::Asserter::failIf( !(condition),
\
++ CPPUNIT_NS::Message( "assertion failed",
\
++ "Expression: "
\
++ #condition,
\
++
CPPUNIT_NS::message_to_string(message) ), \
++ CPPUNIT_SOURCELINE() ) );
\
++ ANALYSIS_ASSUME(condition); } while(0)
+
+ /** Fails with the specified message.
+ * \ingroup Assertions
test_tdf159102_smart_justify_with_automatic_hyphenation and es_ES hyphenation
Hi,
while writing my other mail and doing the mentioned patch I noticed I
never actually forwarded the
test_tdf159102_smart_justify_with_automatic_hyphenation failure.
That test does
def test_tdf159102_smart_justify_with_automatic_hyphenation(self):
supported_locale = self.is_supported_locale("en", "US")
if not supported_locale:
self.skipTest("no hyphenation patterns for en_US available")
initally and says
# we must not depend on the installed hyphenation patterns,
# so extend user dictionary temporarily with the
hyphenation cur=sus and ege=stas
later on
which apparently didn't work. When I open the test document LO suggests
me to actually install es hyphenation, and after installing that
hyphen-es that made the test pass.
Actually in the meanwhile
commit 1b83ebf42c535528b73baac2407b347f19070d07
Author: Noel Grandin
Date: Thu Jan 25 13:53:26 2024 +0200
disabling UITest tdf159102
because it still fails on my machine reliably
Change-Id: I482b8235cd910ff16b1b15bb0427c5d6a8140751
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162567
Tested-by: Jenkins
Reviewed-by: Noel Grandin
happened, disabling the actual test after the above-mentioned if.
Regards,
Rene
Re: tdf132599_frames_* tests needs hu-HU hyphenation for english text
Hi, Am 10.05.24 um 17:18 schrieb Rene Engelhard: [...] The test code sets en_US as locale, and the text files have english text. Well, sets is wrong, by bad. But it checks for it and skips the test if en_US isn't there. But LibreOffice suggests to install hu-HU hyphenation patterns when opening the .fodt. Indeed, the text is formatted as Hungarian. but as said it expects hu-HU since the text is formatted as Hungarian. I think the files should be fixed to set the text language to English (USA) instead? (I just work around it by adding hyphen-hu as a build dependency, but that should be fixed). https://salsa.debian.org/libreoffice-team/libreoffice/libreoffice/-/commit/1330f842bec975ba616359d9a0cc05a2f37e7a00 Regards, Rene
tdf132599_frames_* tests needs hu-HU hyphenation for english text
Hi, I just got Test name: (anonymous namespace)::testTdf132599_frames_on_right_pages_no_hyphenation::TestBody equality assertion failed - Expected: space, ex - Actual : space, - In <>, attribute 'portion' of '/root/page[3]/body/txt/anchored/fly/txt/SwParaPortion/SwLineLayout[1]' incorrect value. xmltesttools.cxx:170:Assertion Test name: (anonymous namespace)::testTdf132599_frames_on_same_page_hyphenation::TestBody equality Test name: (anonymous namespace)::testTdf132599_frames_on_right_pages_no_hyphenation::TestBody equality assertion failed - Expected: space, ex - Actual : space, - In <>, attribute 'portion' of '/root/page[3]/body/txt/anchored/fly/txt/SwParaPortion/SwLineLayout[1]' incorrect value. xmltesttools.cxx:170:Assertion Test name: (anonymous namespace)::testTdf132599_frames_on_same_page_hyphenation::TestBody equality assertion failed - Expected: cept that it - Actual : space, - In <>, attribute 'portion' of '/root/page/body/txt/anchored/fly[2]/txt/SwParaPortion/SwLineLayout[1]' incorrect value. xmltesttools.cxx:170:Assertion Test name: (anonymous namespace)::testTdf132599_frames_on_same_page_no_hyphenation::TestBody equality assertion failed - Expected: space, ex - Actual : space, - In <>, attribute 'portion' of '/root/page/body/txt/anchored/fly[2]/txt/SwParaPortion/SwLineLayout[1]' incorrect value. xmltesttools.cxx:170:Assertion Test name: (anonymous namespace)::testTdf132599_frames_on_spread_hyphenation::TestBody equality assertion failed - Expected: cept that it - Actual : space, - In <>, attribute 'portion' of '/root/page[3]/body/txt/anchored/fly/txt/SwParaPortion/SwLineLayout[1]' incorrect value. Failures !!! Run: 95 Failure total: 4 Failures: 4 Errors: 0 assertion failed - Expected: cept that it - Actual : space, - In <>, attribute 'portion' of '/root/page/body/txt/anchored/fly[2]/txt/SwParaPortion/SwLineLayout[1]' incorrect value. xmltesttools.cxx:170:Assertion Test name: (anonymous namespace)::testTdf132599_frames_on_same_page_no_hyphenation::TestBody equality assertion failed - Expected: space, ex - Actual : space, - In <>, attribute 'portion' of '/root/page/body/txt/anchored/fly[2]/txt/SwParaPortion/SwLineLayout[1]' incorrect value. xmltesttools.cxx:170:Assertion Test name: (anonymous namespace)::testTdf132599_frames_on_spread_hyphenation::TestBody equality assertion failed - Expected: cept that it - Actual : space, - In <>, attribute 'portion' of '/root/page[3]/body/txt/anchored/fly/txt/SwParaPortion/SwLineLayout[1]' incorrect value. Failures !!! Run: 95 Failure total: 4 Failures: 4 Errors: 0 in my master test build. Wondering why I looked at the test itself and the .fdot. The test code sets en_US as locale, and the text files have english text. But LibreOffice suggests to install hu-HU hyphenation patterns when opening the .fodt. Indeed, the text is formatted as Hungarian. Probably wrong? (I just work around it by adding hyphen-hu as a build dependency, but that should be fixed). Regards, Rene
[Bug 154792] Calc Round Down is Rounding Up for some values
https://bugs.documentfoundation.org/show_bug.cgi?id=154792 --- Comment #27 from b. --- @erAck, you are sure about 8.23456789013 in the roundup unit-tests? Didn't run the tests, just looked into the code and consider them questionable, think 8.23456789014 fits better. And about the concept, while you accept / provoke contradictions to 'math' in 'digits behind 12' you'll - IMHO - always have cases which fail 'left of that' as the devias propagate left in chains of '000...' or '999...' . And pls. don't answer it has to be like that, it's not a consequence of math, only partly a consequence of IEEE, and mostly resulting from Calc's combination of decisions and algorithms. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161030] Vertical Tab dialogs--width available for Tab name is too narrow with jumping view of Tab names
https://bugs.documentfoundation.org/show_bug.cgi?id=161030 V Stuart Foote changed: What|Removed |Added Summary|Vertical Tab dialogs--width |Vertical Tab dialogs--width |available for Tab name is |available for Tab name is |too narrow |too narrow with jumping ||view of Tab names -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161030] Vertical Tab dialogs--width available for Tab name is too narrow with jumping view of Tab names
https://bugs.documentfoundation.org/show_bug.cgi?id=161030 V Stuart Foote changed: What|Removed |Added Summary|Vertical Tab dialogs--width |Vertical Tab dialogs--width |available for Tab name is |available for Tab name is |too narrow |too narrow with jumping ||view of Tab names -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 161030] Vertical Tab dialogs--width available for Tab name is too narrow
https://bugs.documentfoundation.org/show_bug.cgi?id=161030 V Stuart Foote changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||samuel.mehrbrodt@allotropia ||.de, ||vsfo...@libreoffice.org See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=99 ||528 Keywords||needsUXEval --- Comment #1 from V Stuart Foote --- Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 505803e2cb4d60153be2218a17ede8e34d95b42e CPU threads: 8; OS: Windows 10 (10.0 build 19045); UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 161030] Vertical Tab dialogs--width available for Tab name is too narrow
https://bugs.documentfoundation.org/show_bug.cgi?id=161030 V Stuart Foote changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||samuel.mehrbrodt@allotropia ||.de, ||vsfo...@libreoffice.org See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=99 ||528 Keywords||needsUXEval --- Comment #1 from V Stuart Foote --- Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 505803e2cb4d60153be2218a17ede8e34d95b42e CPU threads: 8; OS: Windows 10 (10.0 build 19045); UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161030] New: Vertical Tab dialogs--width available for Tab name is too narrow
https://bugs.documentfoundation.org/show_bug.cgi?id=161030 Bug ID: 161030 Summary: Vertical Tab dialogs--width available for Tab name is too narrow Product: LibreOffice Version: 24.8.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: vsfo...@libreoffice.org Noticed when confirming bug 161020 that the available width of the vertical tab bar is fixed and is too narrow to show the full name of each tab. Resizing dialog wider does not help. Unfortunately with D down cursor movement between Tab items, landing on a wider label, the shown entry of the Tab bar jumps to the ending of the name and the start of each entry is hidden. Strangely, with U up cursor movement it jumps to the start of the name. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160939] table of authorities missing in writer
https://bugs.documentfoundation.org/show_bug.cgi?id=160939 --- Comment #1 from Eyal Rozenberg --- (In reply to johnks from comment #0) John, please explain this in more detail for those of us who are not familiar with some of the terminology - as it seems you are asking for multiple (related) features at once. What is an "authority"? Also, why do you "mark" citation eons written manually rather than add a citation using a preexisting bibliographic source? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160057] Document Calc's separate Footer and Header tabs if "Same content on first page" is off
https://bugs.documentfoundation.org/show_bug.cgi?id=160057 Olivier Hallot changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |olivier.hallot@libreoffice. |desktop.org |org -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161021] LO hangs (endless loop) when footnote is on the wrong page
https://bugs.documentfoundation.org/show_bug.cgi?id=161021 --- Comment #5 from Markus Grob --- Created attachment 194077 --> https://bugs.documentfoundation.org/attachment.cgi?id=194077=edit Error-Window of Visual Studio while LO is running Error-Window of Visual Studio while LO is running with a lot of warnings... -- You are receiving this mail because: You are the assignee for the bug.
