[Bug 160690] Animated GIF completely invisible in Edit mode (GIF has alpha-transparency)
https://bugs.documentfoundation.org/show_bug.cgi?id=160690 --- Comment #6 from gladys --- Hi Noel, let me check it again. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160690] Animated GIF completely invisible in Edit mode (GIF has alpha-transparency)
https://bugs.documentfoundation.org/show_bug.cgi?id=160690 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160846] Flathub Libreoffice (24.2.2.2) Failed to open display terminal message. Crashes seconds later
https://bugs.documentfoundation.org/show_bug.cgi?id=160846 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160839] "Recent Documents" file open menu items filenames from remote sources have %20 instead of spaces (URI entities not unquoted)
https://bugs.documentfoundation.org/show_bug.cgi?id=160839 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 77999] [META] Autosave/Autorecovery/Backup copy issues
https://bugs.documentfoundation.org/show_bug.cgi?id=77999 Bug 77999 depends on bug 157458, which changed state. Bug 157458 Summary: Unsaved changes lost in recovered document after changing settings and restarting LibreOffice as prompted https://bugs.documentfoundation.org/show_bug.cgi?id=157458 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157458] Unsaved changes lost in recovered document after changing settings and restarting LibreOffice as prompted
https://bugs.documentfoundation.org/show_bug.cgi?id=157458 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157458] Unsaved changes lost in recovered document after changing settings and restarting LibreOffice as prompted
https://bugs.documentfoundation.org/show_bug.cgi?id=157458 --- Comment #11 from QA Administrators --- Dear nador2, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158160] Libre Writer does not remember default language for documents
https://bugs.documentfoundation.org/show_bug.cgi?id=158160 --- Comment #11 from QA Administrators --- Dear Andras Horvath, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 77722] Excel file with VBA goes into an infinite error loop upon load
https://bugs.documentfoundation.org/show_bug.cgi?id=77722 --- Comment #11 from QA Administrators --- Dear ssrsh82, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157834] Add simple arithmetic to pdf forms
https://bugs.documentfoundation.org/show_bug.cgi?id=157834 --- Comment #8 from QA Administrators --- Dear Mike Sapsard, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 148990] IME does not seem to work with multiline textbox in property editor
https://bugs.documentfoundation.org/show_bug.cgi?id=148990 --- Comment #2 from QA Administrators --- Dear himajin10, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 148632] Point Bookmarks are not removed when the Table of Contents are removed. Can't get rid of them
https://bugs.documentfoundation.org/show_bug.cgi?id=148632 --- Comment #10 from QA Administrators --- Dear Eldar, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 135068] Writer clipboard omits sm OLE formula objects, so not present on clipboard for paste -- affecting all clipboard formats
https://bugs.documentfoundation.org/show_bug.cgi?id=135068 --- Comment #13 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 121044] Form-Control: Button lost icon
https://bugs.documentfoundation.org/show_bug.cgi?id=121044 --- Comment #6 from QA Administrators --- Dear BGWitt, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 133808] Moving a sheet with a chart based on a datarange to a different tab position takes 30 seconds until moved an still unusable for 40 seconds afterwards
https://bugs.documentfoundation.org/show_bug.cgi?id=133808 --- Comment #9 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 133241] Redo increases memory usage
https://bugs.documentfoundation.org/show_bug.cgi?id=133241 --- Comment #4 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 131903] Deleting a chart based on a large dataset rather slow
https://bugs.documentfoundation.org/show_bug.cgi?id=131903 --- Comment #6 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 118190] EDITING Pasting font formatted cells in a new sheet skews new text (with Japanese locale)
https://bugs.documentfoundation.org/show_bug.cgi?id=118190 --- Comment #20 from QA Administrators --- Dear Emil Tanev, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 100306] bar chart x-axis and y-axis settings are swapped
https://bugs.documentfoundation.org/show_bug.cgi?id=100306 --- Comment #7 from QA Administrators --- Dear JoNi, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
core.git: canvas/inc canvas/source editeng/source scripting/source
canvas/inc/verifyinput.hxx |6 -
canvas/source/directx/dx_config.cxx |2
canvas/source/directx/dx_surfacebitmap.cxx |2
editeng/source/accessibility/AccessibleEditableTextPara.cxx | 25 ++---
editeng/source/accessibility/AccessibleStaticTextBase.cxx | 23 +---
scripting/source/dlgprov/dlgevtatt.cxx | 59 +---
scripting/source/dlgprov/dlgevtatt.hxx |1
scripting/source/dlgprov/dlgprov.cxx|7 -
8 files changed, 53 insertions(+), 72 deletions(-)
New commits:
commit ccdb98c0e590281f63a8c180a2eb87086210efbd
Author: Mike Kaganski
AuthorDate: Sat May 4 13:04:41 2024 +0500
Commit: Mike Kaganski
CommitDate: Sun May 12 05:04:57 2024 +0200
Drop some uses of css::uno::Sequence::getConstArray
where it was obsoleted by commits 2484de6728bd11bb7949003d112f1ece2223c7a1
(Remove non-const Sequence::begin()/end() in internal code, 2021-10-15) and
fb3c04bd1930eedacd406874e1a285d62bbf27d9 (Drop non-const
Sequence::operator[]
in internal code 2021-11-05).
Change-Id: I64683093afc48ddf2307dc1dee2302cf0b3cbecc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167110
Reviewed-by: Mike Kaganski
Tested-by: Jenkins
diff --git a/canvas/inc/verifyinput.hxx b/canvas/inc/verifyinput.hxx
index b37468ebbe24..7dd956c92882 100644
--- a/canvas/inc/verifyinput.hxx
+++ b/canvas/inc/verifyinput.hxx
@@ -360,10 +360,8 @@ namespace canvas
const css::uno::Reference< css::uno::XInterface >& xIf,
::sal_Int16
nArgPos )
{
-const SequenceContent* pCurr = rSequence.getConstArray();
-const SequenceContent* pEnd = pCurr + rSequence.getLength();
-while( pCurr != pEnd )
-verifyInput( *pCurr++, pStr, xIf, nArgPos );
+for (auto& element : rSequence)
+verifyInput(element, pStr, xIf, nArgPos);
}
/// Catch-all, to handle cases that DON'T need input checking (i.e.
the Integer geometry ones)
diff --git a/canvas/source/directx/dx_config.cxx
b/canvas/source/directx/dx_config.cxx
index c1d9020845a2..643877659edd 100644
--- a/canvas/source/directx/dx_config.cxx
+++ b/canvas/source/directx/dx_config.cxx
@@ -48,7 +48,7 @@ namespace dxcanvas
uno::Sequence< uno::Any > aProps( GetProperties( {
"DeviceDenylist" } ));
uno::Sequence< sal_Int32 > aValues;
-if( aProps.getLength() > 0 &&
+if (aProps.hasElements() &&
(aProps[0] >>= aValues) )
{
const sal_Int32* pValues = aValues.getConstArray();
diff --git a/canvas/source/directx/dx_surfacebitmap.cxx
b/canvas/source/directx/dx_surfacebitmap.cxx
index 5a3992eea221..c425af2911ce 100644
--- a/canvas/source/directx/dx_surfacebitmap.cxx
+++ b/canvas/source/directx/dx_surfacebitmap.cxx
@@ -542,7 +542,7 @@ namespace dxcanvas
if(FAILED(mpSurface->LockRect(,nullptr,D3DLOCK_NOSYSLOCK|D3DLOCK_READONLY)))
throw uno::RuntimeException("failed to lock directx surface to
surface memory");
-sal_uInt8 const *pSrc = reinterpret_cast(data.getConstArray());
+auto* pSrc = data.getConstArray();
sal_uInt8 *pDst = (static_cast(aLockedRect.pBits)+(rect.Y1*aLockedRect.Pitch))+rect.X1;
sal_uInt32 nSegmentSizeInBytes = nWidth<<4;
for(sal_uInt32 y=0; y& m_rValues;
+explicit IndexCompare(const uno::Sequence&
rValues)
+: m_rValues(rValues)
+{
+}
bool operator() ( sal_Int32 a, sal_Int32 b ) const
{
-return pValues[a].Name < pValues[b].Name;
+return m_rValues[a].Name < m_rValues[b].Name;
}
};
@@ -1228,19 +1231,13 @@ namespace accessibility
//sort property values
// build sorted index array
sal_Int32 nLength = aRes.getLength();
-const beans::PropertyValue* pPairs = aRes.getConstArray();
-std::unique_ptr pIndices(new sal_Int32[nLength]);
-sal_Int32 i = 0;
-for( i = 0; i < nLength; i++ )
-pIndices[i] = i;
-std::sort( [0], [nLength], IndexCompare(pPairs)
);
+std::vector indices(nLength);
+std::iota(indices.begin(), indices.end(), 0);
+std::sort(indices.begin(), indices.end(), IndexCompare(aRes));
// create sorted sequences according to index array
uno::Sequence aNewValues( nLength );
-beans::PropertyValue* pNewValues = aNewValues.getArray();
-for( i = 0; i < nLength; i++ )
-{
-pNewValues[i] = pPairs[pIndices[i]];
-}
+std::transform(indices.begin(), indices.end(),
aNewValues.getArray(),
+
[Bug 161049] New: Format Cells dialog in recent 24.8 alpha is too small
https://bugs.documentfoundation.org/show_bug.cgi?id=161049 Bug ID: 161049 Summary: Format Cells dialog in recent 24.8 alpha is too small Product: LibreOffice Version: 24.8.0.0 alpha0+ Master Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: adylo811...@gmail.com CC: miguelange...@libreoffice.org I am seeing this on MS Windows with LO Dev 24.8 alpha built on 2024-05-11. I have not tested other OSes. STR: 1. Open new Calc. 2. [CTRL]+[1]. The Format Cells dialog opens, but it is too small (and unusable if not modified) compared to what it used to be up until a few days ago with 24.8 alpha (and older versions, including current Stable versions 7.6 and 24.2). To be clear, it is not just smaller than before; it is too small, so for any practical usage I have to re-size the dialog, every single time. The dialog should have the same default size as before, and, if a user wants to change its size, I guess the new size should rather be remembered. Both these things are failing on LO Dev 24.8 alpha built on 2024-05-11. Let's focus this report on reverting the default size to what it used to be. Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 2b85bceca88ab119fff5cbdc41fe913435a479ca CPU threads: 4; OS: Windows 10 (10.0 build 19045); UI render: Skia/Raster; VCL: win Locale: en-US (es_AR); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161048] New: Background processes are left opened by LO Dev install on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=161048 Bug ID: 161048 Summary: Background processes are left opened by LO Dev install on Windows Product: LibreOffice Version: 24.8.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: adylo811...@gmail.com CC: vsfo...@libreoffice.org Install LO Dev 24.8 on MS Windows, in addition to some LO Stable version. They are of course installed in parallel, in their own directories, and never executed simultaneously. A few days ago I noticed that _each_ run of LibreOfficeDev leaves a process opened in the background, seen listed in Windows' Task Manager, after I have closed the program normally. In the installation procedure, I never select to automatically start LO with the OS. Every run is executed manually. No repro when installing LibreOfficeDev_24.8.0.0.alpha0_Win_x86-64.msi built as of 2024-04-30 – I re-installed that version, tested it, and then again installing the msi built on 2024-05-11 – so this started at some point after build date 2024-04-30. Downloaded from TB77 (not from TB78). We are approaching alpha1 status of LO 24.8, so this should rather have a higher-than-normal priority, IMHO. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160754] Footnote indent is broken in this example
https://bugs.documentfoundation.org/show_bug.cgi?id=160754 --- Comment #8 from Mike Kaganski --- 1. There is no indentation between the footnote number and the rest of the text for documents that use the MS compatibility flag, hence the behavior. You may use Tools->Footnote/Endnote Settings, and add a space in the "After" field. This would make the space added automatically. 2. As said, the setting should eventually be added to the compatibility options available in the UI, which would enable users to control it. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161047] New: Vertical tab dialogs--Page style dialog is too small and not resizeable
https://bugs.documentfoundation.org/show_bug.cgi?id=161047 Bug ID: 161047 Summary: Vertical tab dialogs--Page style dialog is too small and not resizeable Product: LibreOffice Version: 24.8.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rb.hensc...@t-online.de Created attachment 194090 --> https://bugs.documentfoundation.org/attachment.cgi?id=194090=edit page style dialog screenshot The page style dialog in Writer is too small, see attached screenshot. And worse, it is not resizable. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161046] New: No substitute fonts when opening a file without the file's font installed locally
https://bugs.documentfoundation.org/show_bug.cgi?id=161046 Bug ID: 161046 Summary: No substitute fonts when opening a file without the file's font installed locally Product: LibreOffice Version: 24.2.0.3 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jondotandr...@fastmail.fm When I open a file which uses a font not installed on my computer, almost all of the letters show up as small rectangles rather than substituting the font (for display) with a locally installed font. This also happens on another computer, using the same OS, but with version 24.2.3.2 installed. Surely this isn't a "feature", right? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158475] EDITING an email address with URL Recognition enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=158475 --- Comment #4 from ady --- There is positive consequence of the use of the equal sign with URL/emails, which is a workaround for bug 103447: (In reply to ady from bug 103447 comment #16) > FWIW (url/hyperlink/email address)... > > From: > > https://ask.libreoffice.org/t/cant-edit-a-url-in-a-calc-cell/98712/9 > > With minor rewording: > > 1. Focus on the cell containing the URL you want to edit. > 2. Click the "=" icon in the formula bar. > 3. Edit the URL text in the formula bar. > > Step 2 is key. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158475] EDITING an email address with URL Recognition enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=158475 --- Comment #3 from loic_dup...@hotmail.com --- As I was completing Bug 103447 ...because I had this issue (from Bug 103447), it may be correlated to your bug. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160127] Grammar context menu is not displayed if no suggestions exist
https://bugs.documentfoundation.org/show_bug.cgi?id=160127 --- Comment #13 from Marco A.G.Pinto --- Heya, I am sorry if I am pressuring you guys, but there are around three months left for LibreOffice 24.8 to be released, and I can't even use 24.2 because LanguageTool doesn't work. Could there be made a quick workaround for it to work, please? Thanks! -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103447] Cell containing hyperlink (URL or email), is not synchronized properly between cell and input line (mismatch in display, edit and selection)
https://bugs.documentfoundation.org/show_bug.cgi?id=103447 --- Comment #17 from loic_dup...@hotmail.com --- Can still reproduce this bug on latest Version: 24.2.3.2 (X86_64) / LibreOffice Community Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba CPU threads: 24; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: fr-FR (fr_FR); UI: fr-FR Calc: CL threaded 1.open new calc doc 2.choose any cell 3.type "someth...@somewhere.com additional text" (without "" of course) 4.this bug will happen ONLY when the email is automatically recognized as an EMAIL by Calc. => To do so, you have to "do something" until the email is automatically underlined and color changed. NOW it's a recognized email. (not sure how to make Calc recognize it's an email, it's erratic... Best way is to add/remove a letter in the email and press [ENTER]. If it doesn't work, try to reduce the email to something like t...@test.com and press [ENTER]). (4bis : NOW you have an email, you can copy/paste this cell to duplicate it and keep this email for mutliple test) 5. Now we have a email in the cell, try to select the text "addionnal" and modify it (like delete it) and press [ENTER]. => Expected : string "someth...@somewhere.com text" in the cell. => actual result / BUG : text is not modified, the string is unmodified. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161043] CALC Error in SUBTOTAL(9;range) when the source values are minutes and seconds exceeding 60 minutes
https://bugs.documentfoundation.org/show_bug.cgi?id=161043 --- Comment #3 from ady --- (In reply to m_a_riosv from comment #2) > What if you use to format the cell > [HH]:MM:SS,00 Or [HH]:MM:SS.00 if your decimal separator is the period dot rather than the comma. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161045] New: Crash in: libc.so.6
https://bugs.documentfoundation.org/show_bug.cgi?id=161045 Bug ID: 161045 Summary: Crash in: libc.so.6 Product: LibreOffice Version: 24.2.3.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: j...@lauterbachandassociates.net This bug was filed from the crash reporting server and is br-3ba5f59f-0400-40aa-b0e4-a522fd84bed4. = These bugs are caused by the Spell Checking routine to recognize the language used in the document. Language is always English USA -- You are receiving this mail because: You are the assignee for the bug.
core.git: connectivity/source cui/source dbaccess/source framework/source include/unotools reportdesign/source sfx2/source svx/source sw/source uui/source vcl/source
connectivity/source/commontools/DriversConfig.cxx|6 -
connectivity/source/commontools/dbtools2.cxx |4
connectivity/source/drivers/jdbc/JConnection.cxx |2
cui/source/customize/CustomNotebookbarGenerator.cxx |2
cui/source/dialogs/toolbarmodedlg.cxx|2
cui/source/options/optsave.cxx | 14 +-
dbaccess/source/ui/browser/unodatbr.cxx |2
dbaccess/source/ui/dlg/generalpage.cxx |2
framework/source/uielement/toolbarmodemenucontroller.cxx | 12 +-
include/unotools/confignode.hxx |5
reportdesign/source/ui/report/propbrw.cxx|2
sfx2/source/appl/appserv.cxx | 14 +-
sfx2/source/dialog/filtergrouping.cxx|6 -
sfx2/source/notebookbar/SfxNotebookBar.cxx | 10 -
sfx2/source/sidebar/ResourceManager.cxx | 76 +++
svx/source/form/databaselocationinput.cxx|2
svx/source/form/fmPropBrw.cxx|2
sw/source/ui/fldui/fldtdlg.cxx |3
uui/source/iahndl.cxx|4
vcl/source/app/settings.cxx |2
vcl/source/window/toolbox2.cxx |4
21 files changed, 85 insertions(+), 91 deletions(-)
New commits:
commit d4f07d4c08724602d0a13045bec957e285d45c0d
Author: Noel Grandin
AuthorDate: Wed May 8 11:24:50 2024 +0200
Commit: Noel Grandin
CommitDate: Sat May 11 23:05:38 2024 +0200
replace createFromAscii with OUString literals in OConfigurationNode
Change-Id: I19017bc993f0adafdae32313e0e01e69e1bbe80b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167517
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/connectivity/source/commontools/DriversConfig.cxx
b/connectivity/source/commontools/DriversConfig.cxx
index 3c5fe27e8327..fac2feb872ed 100644
--- a/connectivity/source/commontools/DriversConfig.cxx
+++ b/connectivity/source/commontools/DriversConfig.cxx
@@ -61,17 +61,17 @@ namespace
return;
OUString sParentURLPattern;
-aURLPatternNode.getNodeValue("ParentURLPattern") >>= sParentURLPattern;
+aURLPatternNode.getNodeValue(u"ParentURLPattern"_ustr) >>=
sParentURLPattern;
if ( !sParentURLPattern.isEmpty() )
lcl_readURLPatternNode(_aInstalled,sParentURLPattern,_rInstalledDriver);
OUString sDriverFactory;
-aURLPatternNode.getNodeValue("Driver") >>= sDriverFactory;
+aURLPatternNode.getNodeValue(u"Driver"_ustr) >>= sDriverFactory;
if ( !sDriverFactory.isEmpty() )
_rInstalledDriver.sDriverFactory = sDriverFactory;
OUString sDriverTypeDisplayName;
-aURLPatternNode.getNodeValue("DriverTypeDisplayName") >>=
sDriverTypeDisplayName;
+aURLPatternNode.getNodeValue(u"DriverTypeDisplayName"_ustr) >>=
sDriverTypeDisplayName;
OSL_ENSURE(!sDriverTypeDisplayName.isEmpty(),"No valid
DriverTypeDisplayName property!");
if ( !sDriverTypeDisplayName.isEmpty() )
_rInstalledDriver.sDriverTypeDisplayName = sDriverTypeDisplayName;
diff --git a/connectivity/source/commontools/dbtools2.cxx
b/connectivity/source/commontools/dbtools2.cxx
index e6088c513711..8590878dbcf6 100644
--- a/connectivity/source/commontools/dbtools2.cxx
+++ b/connectivity/source/commontools/dbtools2.cxx
@@ -947,7 +947,7 @@ OUString getDefaultReportEngineServiceName(const Reference<
XComponentContext >&
if ( aReportEngines.isValid() )
{
OUString sDefaultReportEngineName;
-aReportEngines.getNodeValue("DefaultReportEngine") >>=
sDefaultReportEngineName;
+aReportEngines.getNodeValue(u"DefaultReportEngine"_ustr) >>=
sDefaultReportEngineName;
if ( !sDefaultReportEngineName.isEmpty() )
{
::utl::OConfigurationNode aReportEngineNames =
aReportEngines.openNode(u"ReportEngineNames"_ustr);
@@ -957,7 +957,7 @@ OUString getDefaultReportEngineServiceName(const Reference<
XComponentContext >&
if ( aReportEngine.isValid() )
{
OUString sRet;
-aReportEngine.getNodeValue("ServiceName") >>= sRet;
+aReportEngine.getNodeValue(u"ServiceName"_ustr) >>= sRet;
return sRet;
}
}
diff --git a/connectivity/source/drivers/jdbc/JConnection.cxx
b/connectivity/source/drivers/jdbc/JConnection.cxx
index ed92faf87dba..00a868d92595 100644
--- a/connectivity/source/drivers/jdbc/JConnection.cxx
+++ b/connectivity/source/drivers/jdbc/JConnection.cxx
@@ -702,7 +702,7 @@ OUString
java_sql_Connection::impl_getJavaDriverClassPath_nothrow(const OUString
if ( aNamesRoot.isValid() && aNamesRoot.hasByName( _sDriverClass ) )
{
core.git: 2 commits - connectivity/source cui/source framework/source include/unotools sfx2/source uui/source
connectivity/source/commontools/dbtools2.cxx |2 -
cui/source/customize/CustomNotebookbarGenerator.cxx |4 +-
framework/source/uiconfiguration/imagemanagerimpl.cxx | 28 +-
include/unotools/confignode.hxx |5 ---
sfx2/source/dialog/filtergrouping.cxx |4 +-
sfx2/source/notebookbar/SfxNotebookBar.cxx|2 -
uui/source/iahndl.cxx |2 -
7 files changed, 21 insertions(+), 26 deletions(-)
New commits:
commit 9dac3118ee80bea900cede71e4ef616bad165401
Author: Noel Grandin
AuthorDate: Wed May 8 10:36:51 2024 +0200
Commit: Noel Grandin
CommitDate: Sat May 11 23:05:30 2024 +0200
replace createFromAscii with OUString literals in OConfigurationNode
Change-Id: I6029cd4c894c6ab079cc508ba15df41ec5d4f8db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167516
Reviewed-by: Noel Grandin
Tested-by: Jenkins
diff --git a/connectivity/source/commontools/dbtools2.cxx
b/connectivity/source/commontools/dbtools2.cxx
index f43cd2f77d89..e6088c513711 100644
--- a/connectivity/source/commontools/dbtools2.cxx
+++ b/connectivity/source/commontools/dbtools2.cxx
@@ -950,7 +950,7 @@ OUString getDefaultReportEngineServiceName(const Reference<
XComponentContext >&
aReportEngines.getNodeValue("DefaultReportEngine") >>=
sDefaultReportEngineName;
if ( !sDefaultReportEngineName.isEmpty() )
{
-::utl::OConfigurationNode aReportEngineNames =
aReportEngines.openNode("ReportEngineNames");
+::utl::OConfigurationNode aReportEngineNames =
aReportEngines.openNode(u"ReportEngineNames"_ustr);
if ( aReportEngineNames.isValid() )
{
::utl::OConfigurationNode aReportEngine =
aReportEngineNames.openNode(sDefaultReportEngineName);
diff --git a/cui/source/customize/CustomNotebookbarGenerator.cxx
b/cui/source/customize/CustomNotebookbarGenerator.cxx
index 20610dc9b096..df065fb81e7b 100644
--- a/cui/source/customize/CustomNotebookbarGenerator.cxx
+++ b/cui/source/customize/CustomNotebookbarGenerator.cxx
@@ -258,7 +258,7 @@ Sequence
CustomNotebookbarGenerator::getCustomizedUIItem(OUString sNot
const utl::OConfigurationTreeRoot
aAppNode(::comphelper::getProcessComponentContext(), aPath,
false);
-const utl::OConfigurationNode aModesNode = aAppNode.openNode("Modes");
+const utl::OConfigurationNode aModesNode =
aAppNode.openNode(u"Modes"_ustr);
const utl::OConfigurationNode
aModeNode(aModesNode.openNode(sNotebookbarConfigType));
const Any aValue = aModeNode.getNodeValue("UIItemProperties");
Sequence aValues;
@@ -272,7 +272,7 @@ void CustomNotebookbarGenerator::setCustomizedUIItem(const
Sequence& r
OUString aPath = getAppNameRegistryPath();
const utl::OConfigurationTreeRoot
aAppNode(::comphelper::getProcessComponentContext(), aPath,
true);
-const utl::OConfigurationNode aModesNode = aAppNode.openNode("Modes");
+const utl::OConfigurationNode aModesNode =
aAppNode.openNode(u"Modes"_ustr);
const utl::OConfigurationNode
aModeNode(aModesNode.openNode(rNotebookbarConfigType));
css::uno::Any aUIItemProperties(rUIItemProperties);
diff --git a/include/unotools/confignode.hxx b/include/unotools/confignode.hxx
index 946825aa4821..c95acd8bdbdb 100644
--- a/include/unotools/confignode.hxx
+++ b/include/unotools/confignode.hxx
@@ -81,11 +81,6 @@ namespace utl
*/
OConfigurationNode openNode(const OUString& _rPath) const noexcept;
-OConfigurationNode openNode( const char* _pAsciiPath ) const
-{
-return openNode( OUString::createFromAscii( _pAsciiPath ) );
-}
-
/** create a new child node
If the object represents a set node, this method may be used to
create a new child. For non-set-nodes, the
diff --git a/sfx2/source/dialog/filtergrouping.cxx
b/sfx2/source/dialog/filtergrouping.cxx
index e4f210c59765..dfa9d0295466 100644
--- a/sfx2/source/dialog/filtergrouping.cxx
+++ b/sfx2/source/dialog/filtergrouping.cxx
@@ -254,7 +254,7 @@ namespace sfx2
// go for all the single class entries
OConfigurationNode aFilterClassesNode =
-_rFilterClassification.openNode( "GlobalFilters/Classes" );
+_rFilterClassification.openNode( u"GlobalFilters/Classes"_ustr );
const Sequence< OUString > aFilterClasses =
aFilterClassesNode.getNodeNames();
::std::for_each(
aFilterClasses.begin(),
@@ -298,7 +298,7 @@ namespace sfx2
// the node for the local classes
OConfigurationNode aFilterClassesNode =
-_rFilterClassification.openNode( "LocalFilters/Classes" );
+_rFilterClassification.openNode( u"LocalFilters/Classes"_ustr );
const Sequence< OUString > aFilterClasses =
[Bug 160690] Animated GIF completely invisible in Edit mode (GIF has alpha-transparency)
https://bugs.documentfoundation.org/show_bug.cgi?id=160690 --- Comment #5 from Noel Grandin --- I don't think that bisect result is right. This was broken somewhere before my commit. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161043] CALC Error in SUBTOTAL(9;range) when the source values are minutes and seconds exceeding 60 minutes
https://bugs.documentfoundation.org/show_bug.cgi?id=161043 m_a_riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #2 from m_a_riosv --- What if you use to format the cell [HH]:MM:SS,00 https://help.libreoffice.org/24.2/en-US/text/shared/01/05020301.html?=CALC=WIN#:~:text=to%20display%20hours%2C%20minutes%20and%20seconds%20use%20the%20following%20number%20format%20codes%3A -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161039] LibreOffice crashed and i lost my document
https://bugs.documentfoundation.org/show_bug.cgi?id=161039 m_a_riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m_a_riosv --- Please take a look at https://ask.libreoffice.org/t/program-shut-down-and-lost-text-w-o-saving-libreoffice-writer/96780/4 -- You are receiving this mail because: You are the assignee for the bug.
core.git: compilerplugins/clang sd/source
compilerplugins/clang/mergeclasses.results |1
sd/source/ui/app/optsitem.cxx | 55 -
sd/source/ui/inc/optsitem.hxx | 23
3 files changed, 1 insertion(+), 78 deletions(-)
New commits:
commit c2ec1708ea58cb723c9dc2f35683dc2f318136d3
Author: Gabor Kelemen
AuthorDate: Thu Apr 25 10:24:13 2024 +0200
Commit: Gabor Kelemen
CommitDate: Sat May 11 21:09:01 2024 +0200
Drop now unused SdOptionsZoom class
Change-Id: I73100a18f9edb37bb93b7612e7e34fdf510a5308
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166630
Reviewed-by: Gabor Kelemen
Tested-by: Jenkins
diff --git a/compilerplugins/clang/mergeclasses.results
b/compilerplugins/clang/mergeclasses.results
index 1801fcd073af..00f3238b0bb0 100644
--- a/compilerplugins/clang/mergeclasses.results
+++ b/compilerplugins/clang/mergeclasses.results
@@ -177,7 +177,6 @@ merge SceneObject with (anonymous namespace)::Iris
maybe merge SdImportTestSkia with testTdf156856, in modules sd and workdir
merge SdNavigatorWin with sd::sidebar::NavigatorWrapper
merge SdOptionsGrid with SdOptions
-merge SdOptionsZoom with SdOptions
merge SdTransferable::UserData with
sd::slidesorter::controller::TransferableData
merge SdUnoSearchReplaceShape with SdGenericDrawPage
merge SdrCreateView with SdrView
diff --git a/sd/source/ui/app/optsitem.cxx b/sd/source/ui/app/optsitem.cxx
index 2ad6448099fc..ac67a935e16d 100644
--- a/sd/source/ui/app/optsitem.cxx
+++ b/sd/source/ui/app/optsitem.cxx
@@ -680,59 +680,6 @@ void SdOptionsSnapItem::SetOptions( SdOptions* pOpts )
const
pOpts->SetEliminatePolyPointLimitAngle(
maOptionsSnap.GetEliminatePolyPointLimitAngle() );
}
-/*
-|*
-|* SdOptionsZoom
-|*
-\/
-
-SdOptionsZoom::SdOptionsZoom( bool bImpress ) :
-SdOptionsGeneric( bImpress, bImpress ?
- OUString() :
- OUString("Office.Draw/Zoom") ),
-nX( 1 ),
-nY( 1 )
-
-{
-EnableModify( true );
-}
-
-void SdOptionsZoom::GetPropNameArray( const char**& ppNames, sal_uLong& rCount
) const
-{
-static const char* aPropNames[] =
-{
-"ScaleX",
-"ScaleY"
-};
-
-rCount = !IsImpress() ? SAL_N_ELEMENTS(aPropNames) : 0;
-ppNames = aPropNames;
-}
-
-bool SdOptionsZoom::ReadData( const Any* pValues )
-{
-sal_Int32 x = 1, y = 1;
-
-if( pValues[0].hasValue() ) x = *o3tl::doAccess(pValues[ 0 ]);
-if( pValues[1].hasValue() ) y = *o3tl::doAccess(pValues[ 1 ]);
-
-SetScale( x, y );
-
-return true;
-}
-
-bool SdOptionsZoom::WriteData( Any* pValues ) const
-{
-sal_Int32 x, y;
-
-GetScale( x, y );
-
-pValues[ 0 ] <<= x;
-pValues[ 1 ] <<= y;
-
-return true;
-}
-
/*
|*
|* SdOptionsGrid
@@ -1136,7 +1083,6 @@ void SdOptionsPrintItem::SetOptions( SdOptions* pOpts )
const
SdOptions::SdOptions(bool bImpress) :
SdOptionsMisc( bImpress, true ),
SdOptionsSnap( bImpress, true ),
-SdOptionsZoom( bImpress ),
SdOptionsGrid( bImpress ),
SdOptionsPrint( bImpress, true )
{
@@ -1150,7 +1096,6 @@ void SdOptions::StoreConfig()
{
SdOptionsMisc::Store();
SdOptionsSnap::Store();
-SdOptionsZoom::Store();
SdOptionsGrid::Store();
SdOptionsPrint::Store();
}
diff --git a/sd/source/ui/inc/optsitem.hxx b/sd/source/ui/inc/optsitem.hxx
index 7e02cb2ceb4b..403c7b88e312 100644
--- a/sd/source/ui/inc/optsitem.hxx
+++ b/sd/source/ui/inc/optsitem.hxx
@@ -321,27 +321,6 @@ private:
SdOptionsSnap maOptionsSnap;
};
-class SdOptionsZoom : public SdOptionsGeneric
-{
-private:
-
-sal_Int32 nX; // Zoom/ScaleX
-sal_Int32 nY; // Zoom/ScaleY
-
-protected:
-
-virtual void GetPropNameArray( const char**& ppNames, sal_uLong& rCount )
const override;
-virtual bool ReadData( const css::uno::Any* pValues ) override;
-virtual bool WriteData( css::uno::Any* pValues ) const override;
-
-public:
-
-explicit SdOptionsZoom(bool bImpress);
-
-voidGetScale( sal_Int32& rX, sal_Int32& rY ) const { Init(); rX = nX;
rY = nY; }
-voidSetScale( sal_Int32 nInX, sal_Int32 nInY ) { if( nX != nInX || nY
!= nInY ) { OptionsChanged(); nX = nInX; nY = nInY; } }
-};
-
class SdOptionsGrid : public SdOptionsGeneric, public SvxOptionsGrid
{
protected:
@@ -488,7 +467,7 @@ private:
class SdOptions final :
public SdOptionsMisc, public SdOptionsSnap,
- public SdOptionsZoom, public SdOptionsGrid,
+ public SdOptionsGrid,
public SdOptionsPrint
{
public:
[Bug 161044] Libreoffice Writer crashes when opening certain odt file
https://bugs.documentfoundation.org/show_bug.cgi?id=161044 lehiwo7...@ahieh.com changed: What|Removed |Added Summary|Libreoffice Writer crashes |Libreoffice Writer crashes |when openen odt file|when opening certain odt ||file -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161044] Libreoffice Writer crashes when openen odt file
https://bugs.documentfoundation.org/show_bug.cgi?id=161044 lehiwo7...@ahieh.com changed: What|Removed |Added Summary|Write crashes when openen |Libreoffice Writer crashes |odt file|when openen odt file -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161044] New: Write crashes when openen odt file
https://bugs.documentfoundation.org/show_bug.cgi?id=161044 Bug ID: 161044 Summary: Write crashes when openen odt file Product: LibreOffice Version: 24.2.3.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: lehiwo7...@ahieh.com Hello, I am running Libreoffice 24.2.3.2 flatpak version. As soon as I try to open a certain odt file Libreoffice crashes. It just happens with this file, other files are fine. The crash is reproducable, happens 100% of the time. I cannot share the file here unfortunately because it contains personal information but I can see in the terminal this error: /usr/include/c++/13.2.0/string_view:258: constexpr const std::basic_string_view<_CharT, _Traits>::value_type& std::basic_string_view<_CharT, _Traits>::operator[](size_type) const [with _CharT = char16_t; _Traits = std::char_traits; const_reference = const char16_t&; size_type = long unsigned int]: Assertion '__pos < this->_M_len' failed. Unspecified Application Error -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'distro/collabora/co-24.04' - external/nss sal/osl
external/nss/UnpackedTarball_nss.mk |1 +
external/nss/nss.disablefsync.patch | 18 ++
sal/osl/unx/file.cxx|6 +-
3 files changed, 24 insertions(+), 1 deletion(-)
New commits:
commit 90bd45d7a96c8c7084db13e4b6f86753db67655a
Author: Michael Meeks
AuthorDate: Fri May 10 17:47:19 2024 +0100
Commit: Caolán McNamara
CommitDate: Sat May 11 20:07:19 2024 +0200
lok: add SAL_DISABLE_FSYNC environment to disable fsync.
For state-less containers there is no benefit in fsync'ing,
file data is safe when it is up-loaded back to storage - but
profiling shows latency from stray fsyncs.
Change-Id: I9f03d5866dec05e5507deb56b0dca93b6876225e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167490
Tested-by: Michael Meeks
Reviewed-by: Caolán McNamara
diff --git a/external/nss/UnpackedTarball_nss.mk
b/external/nss/UnpackedTarball_nss.mk
index 6b69dd9b1631..7a9010bdf743 100644
--- a/external/nss/UnpackedTarball_nss.mk
+++ b/external/nss/UnpackedTarball_nss.mk
@@ -27,6 +27,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,nss,\
external/nss/nss-restore-manual-pre-dependencies.patch.1 \
external/nss/Wincompatible-function-pointer-types.patch.0 \
$(if $(filter LINUX,$(OS)), \
+external/nss/nss.disablefsync.patch \
external/nss/nss.getrandom.patch) \
$(if $(filter iOS,$(OS)), \
external/nss/nss-ios.patch) \
diff --git a/external/nss/nss.disablefsync.patch
b/external/nss/nss.disablefsync.patch
new file mode 100644
index ..8c5d84b553ce
--- /dev/null
+++ b/external/nss/nss.disablefsync.patch
@@ -0,0 +1,18 @@
+--- a/nss/nss/lib/sqlite/sqlite3.c
b/nss/nss/lib/sqlite/sqlite3.c
+@@ -36136,6 +36136,15 @@
+ static int full_fsync(int fd, int fullSync, int dataOnly){
+ int rc;
+
++ static int disabledKnown = 0, disabled = 0;
++ if (!disabledKnown)
++ {
++disabled = getenv("SAL_DISABLE_FSYNC") != NULL;
++disabledKnown = 1;
++ }
++ if (disabled)
++return 0;
++
+ /* The following "ifdef/elif/else/" block has the same structure as
+ ** the one below. It is replicated here solely to avoid cluttering
+ ** up the real code with the UNUSED_PARAMETER() macros.
diff --git a/sal/osl/unx/file.cxx b/sal/osl/unx/file.cxx
index 912d61a50614..a82a0bcf7f71 100644
--- a/sal/osl/unx/file.cxx
+++ b/sal/osl/unx/file.cxx
@@ -1387,7 +1387,11 @@ oslFileError SAL_CALL osl_syncFile(oslFileHandle Handle)
if (result != osl_File_E_None)
return result;
-if (fsync(pImpl->m_fd) == -1)
+static bool disabled = getenv("SAL_DISABLE_FSYNC") != nullptr;
+
+if (disabled)
+SAL_INFO("sal.file", "fsync(" << pImpl->m_fd << "): Disabled");
+else if (fsync(pImpl->m_fd) == -1)
{
int e = errno;
SAL_INFO("sal.file", "fsync(" << pImpl->m_fd << "): " <<
UnixErrnoString(e));
core.git: 2 commits - vcl/win
vcl/win/app/saltimer.cxx |1
vcl/win/dtrans/APNDataObject.cxx |4
vcl/win/dtrans/DTransHelper.cxx |3
vcl/win/dtrans/Fetc.cxx |3
vcl/win/dtrans/FmtFilter.cxx | 22 ++---
vcl/win/dtrans/MtaOleClipb.cxx | 12 +-
vcl/win/dtrans/XTDataObject.cxx |2
vcl/win/gdi/gdiimpl.cxx | 30 +++
vcl/win/gdi/salbmp.cxx | 160 +--
vcl/win/gdi/salprn.cxx |3
10 files changed, 132 insertions(+), 108 deletions(-)
New commits:
commit 8e4643d9653e18e5c1690289e72f589907550970
Author: Caolán McNamara
AuthorDate: Sat May 11 15:03:15 2024 +0100
Commit: Caolán McNamara
CommitDate: Sat May 11 20:05:35 2024 +0200
WaE: C6011 Dereferencing NULL pointer warnings
Change-Id: I95441e62c33bdc5c22dad2fc25a072d9ce93e4d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167514
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/win/gdi/gdiimpl.cxx b/vcl/win/gdi/gdiimpl.cxx
index ee85f7c341c2..2c4c9a38e121 100644
--- a/vcl/win/gdi/gdiimpl.cxx
+++ b/vcl/win/gdi/gdiimpl.cxx
@@ -545,20 +545,22 @@ void ImplDrawBitmap( HDC hDC, const SalTwoRect& rPosAry,
const WinSalBitmap& rSa
if( hDrawDIB )
{
-PBITMAPINFO pBI = static_cast(GlobalLock(
hDrawDIB ));
-PBYTE pBits = reinterpret_cast(pBI) +
pBI->bmiHeader.biSize +
-WinSalBitmap::ImplGetDIBColorCount(
hDrawDIB ) * sizeof( RGBQUAD );
-const int nOldStretchMode = SetStretchBltMode( hDC,
STRETCH_DELETESCANS );
-
-StretchDIBits( hDC,
- static_cast(rPosAry.mnDestX),
static_cast(rPosAry.mnDestY),
- static_cast(rPosAry.mnDestWidth),
static_cast(rPosAry.mnDestHeight),
- static_cast(rPosAry.mnSrcX),
static_cast(pBI->bmiHeader.biHeight - rPosAry.mnSrcHeight -
rPosAry.mnSrcY),
- static_cast(rPosAry.mnSrcWidth),
static_cast(rPosAry.mnSrcHeight),
- pBits, pBI, DIB_RGB_COLORS, nDrawMode );
-
-GlobalUnlock( hDrawDIB );
-SetStretchBltMode( hDC, nOldStretchMode );
+if (PBITMAPINFO pBI = static_cast(GlobalLock(
hDrawDIB )))
+{
+PBYTE pBits = reinterpret_cast(pBI) +
pBI->bmiHeader.biSize +
+
WinSalBitmap::ImplGetDIBColorCount( hDrawDIB ) * sizeof( RGBQUAD );
+const int nOldStretchMode = SetStretchBltMode( hDC,
STRETCH_DELETESCANS );
+
+StretchDIBits( hDC,
+ static_cast(rPosAry.mnDestX),
static_cast(rPosAry.mnDestY),
+ static_cast(rPosAry.mnDestWidth),
static_cast(rPosAry.mnDestHeight),
+ static_cast(rPosAry.mnSrcX),
static_cast(pBI->bmiHeader.biHeight - rPosAry.mnSrcHeight -
rPosAry.mnSrcY),
+ static_cast(rPosAry.mnSrcWidth),
static_cast(rPosAry.mnSrcHeight),
+ pBits, pBI, DIB_RGB_COLORS, nDrawMode );
+
+GlobalUnlock( hDrawDIB );
+SetStretchBltMode( hDC, nOldStretchMode );
+}
}
else if( hDrawDDB && !bPrintDDB )
{
diff --git a/vcl/win/gdi/salbmp.cxx b/vcl/win/gdi/salbmp.cxx
index c6bd5f3ae7a0..b4960d08c8b9 100644
--- a/vcl/win/gdi/salbmp.cxx
+++ b/vcl/win/gdi/salbmp.cxx
@@ -439,15 +439,18 @@ bool WinSalBitmap::Create( HANDLE hBitmap )
if( mhDIB )
{
-PBITMAPINFOHEADER pBIH = static_cast(GlobalLock(
mhDIB ));
-
-maSize = Size( pBIH->biWidth, pBIH->biHeight );
-mnBitCount = pBIH->biBitCount;
+if (PBITMAPINFOHEADER pBIH =
static_cast(GlobalLock( mhDIB )))
+{
+maSize = Size( pBIH->biWidth, pBIH->biHeight );
+mnBitCount = pBIH->biBitCount;
-if( mnBitCount )
-mnBitCount = ( mnBitCount <= 1 ) ? 1 : ( mnBitCount <= 4 ) ? 4 : (
mnBitCount <= 8 ) ? 8 : 24;
+if( mnBitCount )
+mnBitCount = ( mnBitCount <= 1 ) ? 1 : ( mnBitCount <= 4 ) ? 4
: ( mnBitCount <= 8 ) ? 8 : 24;
-GlobalUnlock( mhDIB );
+GlobalUnlock( mhDIB );
+}
+else
+bRet = false;
}
else if( mhDDB )
{
@@ -522,43 +525,45 @@ bool WinSalBitmap::Create( const SalBitmap& rSSalBitmap )
bool WinSalBitmap::Create( const SalBitmap& rSSalBmp, SalGraphics* pSGraphics )
{
-bool bRet = false;
-
const WinSalBitmap& rSalBmp = static_cast(rSSalBmp);
+if(!rSalBmp.mhDIB)
+return false;
+
+PBITMAPINFO pBI = static_cast(GlobalLock( rSalBmp.mhDIB ));
+if (!pBI)
+return false;
+
+bool bRet = false;
WinSalGraphics* pGraphics = static_cast(pSGraphics);
-if( rSalBmp.mhDIB )
-{
-PBITMAPINFO
[Bug 113072] [META] Numbering format presets for lists, pages, etc
https://bugs.documentfoundation.org/show_bug.cgi?id=113072 BogdanB changed: What|Removed |Added Depends on||138462 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=138462 [Bug 138462] Adding bullet/footnote/endnote/page number in Bengali language -- You are receiving this mail because: You are the assignee for the bug.
[Bug 138462] Adding bullet/footnote/endnote/page number in Bengali language
https://bugs.documentfoundation.org/show_bug.cgi?id=138462 BogdanB changed: What|Removed |Added Blocks||113072 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113072 [Bug 113072] [META] Numbering format presets for lists, pages, etc -- You are receiving this mail because: You are the assignee for the bug.
[Bug 107738] [META] Section bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107738 BogdanB changed: What|Removed |Added Depends on||159574 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159574 [Bug 159574] Writer: instant freeze on document containing endnotes at end of section -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159574] Writer: instant freeze on document containing endnotes at end of section
https://bugs.documentfoundation.org/show_bug.cgi?id=159574 BogdanB changed: What|Removed |Added Blocks||103164, 107738 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103164 [Bug 103164] [META] Footnote and Endnote bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=107738 [Bug 107738] [META] Section bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103164] [META] Footnote and Endnote bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103164 BogdanB changed: What|Removed |Added Depends on||159574 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159574 [Bug 159574] Writer: instant freeze on document containing endnotes at end of section -- You are receiving this mail because: You are the assignee for the bug.
[Bug 109195] [META] DOCX (OOXML) Footnote and Endnote bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109195 BogdanB changed: What|Removed |Added Depends on||160984 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160984 [Bug 160984] FILEOPEN DOCX: endnote is on separate page, not inline -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103164] [META] Footnote and Endnote bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103164 BogdanB changed: What|Removed |Added Depends on|160984 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160984 [Bug 160984] FILEOPEN DOCX: endnote is on separate page, not inline -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103164] [META] Footnote and Endnote bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103164 BogdanB changed: What|Removed |Added Depends on||160984 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160984 [Bug 160984] FILEOPEN DOCX: endnote is on separate page, not inline -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161043] CALC Error in SUBTOTAL(9;range) when the source values are minutes and seconds exceeding 60 minutes
https://bugs.documentfoundation.org/show_bug.cgi?id=161043 --- Comment #1 from Colin --- Created attachment 194087 --> https://bugs.documentfoundation.org/attachment.cgi?id=194087=edit Simple Calc Demonstrating the Error -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161043] New: CALC Error in SUBTOTAL(9;range) when the source values are minutes and seconds exceeding 60 minutes
https://bugs.documentfoundation.org/show_bug.cgi?id=161043 Bug ID: 161043 Summary: CALC Error in SUBTOTAL(9;range) when the source values are minutes and seconds exceeding 60 minutes Product: LibreOffice Version: 7.5.9.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: that.man.co...@gmail.com Description: Time values which individually are only a few minutes and seconds but accumulate to many hours are being presented as just the "mantissa" portion of the the total time ie. the cumulative total of 547:12:52 in the attached sample only returns 12:52:00. Steps to Reproduce: The seconds in column C have been converted to minutes and seconds by the use of =TIME(;;Cn) in the adjacent column D. The mask has been set to just present MM:SS. The individual calculations are correct unless the seconds (3600) are equal to or exceed 60 minutes whereby it just presents the "mantissa" minutes and seconds. One could argue that an incorrect mask is the culprit but there is no indication that the number has overflowed into hours and I would argue that when it does overflow but doesn't indicate perhaps 65:25 it is incorrect. The SUBTOTAL() function at the top has not been limited by a mask and still only presents the "mantissa" for the correct total of 547:12:52. Actual Results: Hours are dropped/discarded from all "masked" calculations Expected Results: 1. Accumulate and display any excess minutes within the confines of the mask ie. 65:25 or 2. Indicate an error condition to permit reassessment of the mask or 3. Force a more appropriate mask Reproducible: Always User Profile Reset: No Additional Info: Version: 7.5.9.2 (X86_64) / LibreOffice Community Build ID: cdeefe45c17511d326101eed8008ac4092f278a9 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-GB (en_GB); UI: en-GB Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103202] [META] About dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103202 Bug 103202 depends on bug 96671, which changed state. Bug 96671 Summary: Correctly detect windows 64-bit OS https://bugs.documentfoundation.org/show_bug.cgi?id=96671 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
core.git: forms/source
forms/source/component/clickableimage.cxx |2
forms/source/helper/controlfeatureinterception.cxx |4 -
forms/source/helper/formnavigation.cxx | 81 -
forms/source/helper/urltransformer.cxx |6 -
forms/source/inc/controlfeatureinterception.hxx|2
forms/source/inc/formnavigation.hxx|4 -
forms/source/inc/frm_strings.hxx | 24 --
forms/source/inc/urltransformer.hxx|5 -
8 files changed, 39 insertions(+), 89 deletions(-)
New commits:
commit f2545fffcbdd9d88a57abd4842719b40d0ed45ec
Author: Noel Grandin
AuthorDate: Wed May 8 09:56:13 2024 +0200
Commit: Noel Grandin
CommitDate: Sat May 11 19:27:55 2024 +0200
replace createFromAscii with OUString literals in ControlFeatureInterception
Change-Id: If0fbaafbaa318ec541341fde723f92f3e8e92cfa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167510
Reviewed-by: Noel Grandin
Tested-by: Jenkins
diff --git a/forms/source/component/clickableimage.cxx
b/forms/source/component/clickableimage.cxx
index 6ab579072e1b..9d57272274a0 100644
--- a/forms/source/component/clickableimage.cxx
+++ b/forms/source/component/clickableimage.cxx
@@ -233,7 +233,7 @@ namespace frm
case FormButtonType_SUBMIT:
{
// if some outer component can provide an interaction handler,
use it
-Reference< XInteractionHandler > xHandler(
m_aFeatureInterception.queryDispatch( "private:/InteractionHandler" ),
UNO_QUERY );
+Reference< XInteractionHandler > xHandler(
m_aFeatureInterception.queryDispatch( u"private:/InteractionHandler"_ustr ),
UNO_QUERY );
try
{
implSubmit( rEvt, xHandler );
diff --git a/forms/source/helper/controlfeatureinterception.cxx
b/forms/source/helper/controlfeatureinterception.cxx
index e8a4ebb337d3..c83b61308395 100644
--- a/forms/source/helper/controlfeatureinterception.cxx
+++ b/forms/source/helper/controlfeatureinterception.cxx
@@ -133,9 +133,9 @@ namespace frm
}
-Reference< XDispatch > ControlFeatureInterception::queryDispatch( const
char* _pAsciiURL )
+Reference< XDispatch > ControlFeatureInterception::queryDispatch( const
OUString& _rURL )
{
-return queryDispatch( m_pUrlTransformer->getStrictURLFromAscii(
_pAsciiURL ) );
+return queryDispatch( m_pUrlTransformer->getStrictURL( _rURL ) );
}
diff --git a/forms/source/helper/formnavigation.cxx
b/forms/source/helper/formnavigation.cxx
index a43287463b40..8178382d5fb5 100644
--- a/forms/source/helper/formnavigation.cxx
+++ b/forms/source/helper/formnavigation.cxx
@@ -364,11 +364,11 @@ namespace frm
bool OFormNavigationMapper::getFeatureURL( sal_Int16 _nFeatureId, URL& /*
[out] */ _rURL )
{
// get the ascii version of the URL
-const char* pAsciiURL = getFeatureURLAscii( _nFeatureId );
+std::optional pAsciiURL = getFeatureURL( _nFeatureId );
if ( pAsciiURL )
-_rURL = m_pUrlTransformer->getStrictURLFromAscii( pAsciiURL );
+_rURL = m_pUrlTransformer->getStrictURL( *pAsciiURL );
-return ( pAsciiURL != nullptr );
+return pAsciiURL.has_value();
}
@@ -377,65 +377,50 @@ namespace frm
struct FeatureURL
{
const sal_Int16 nFormFeature;
-const char* pAsciiURL;
-
-FeatureURL( const sal_Int16 _nFormFeature, const char* _pAsciiURL )
-:nFormFeature( _nFormFeature )
-,pAsciiURL( _pAsciiURL )
-{
-}
+OUString aAsciiURL;
};
-const FeatureURL* lcl_getFeatureTable()
+constexpr FeatureURL s_aFeatureURLs[]
{
-static const FeatureURL s_aFeatureURLs[] =
-{
-FeatureURL( FormFeature::MoveAbsolute,
URL_FORM_POSITION ),
-FeatureURL( FormFeature::TotalRecords,
URL_FORM_RECORDCOUNT ),
-FeatureURL( FormFeature::MoveToFirst,
URL_RECORD_FIRST ),
-FeatureURL( FormFeature::MoveToPrevious,
URL_RECORD_PREV ),
-FeatureURL( FormFeature::MoveToNext,
URL_RECORD_NEXT ),
-FeatureURL( FormFeature::MoveToLast,
URL_RECORD_LAST ),
-FeatureURL( FormFeature::SaveRecordChanges,
URL_RECORD_SAVE ),
-FeatureURL( FormFeature::UndoRecordChanges,
URL_RECORD_UNDO ),
-FeatureURL( FormFeature::MoveToInsertRow,
URL_RECORD_NEW ),
-FeatureURL( FormFeature::DeleteRecord,
URL_RECORD_DELETE ),
-FeatureURL( FormFeature::ReloadForm,
URL_FORM_REFRESH ),
-FeatureURL( FormFeature::RefreshCurrentControl,
URL_FORM_REFRESH_CURRENT_CONTROL ),
-
core.git: 2 commits - dbaccess/source
dbaccess/source/ui/browser/unodatbr.cxx| 16
dbaccess/source/ui/control/opendoccontrols.cxx | 21 +
dbaccess/source/ui/dlg/generalpage.cxx |2 +-
dbaccess/source/ui/inc/opendoccontrols.hxx |5 +
4 files changed, 15 insertions(+), 29 deletions(-)
New commits:
commit b4f2dbe6001109a61f009fc0df74f14071ac8645
Author: Noel Grandin
AuthorDate: Tue May 7 14:39:41 2024 +0200
Commit: Noel Grandin
CommitDate: Sat May 11 18:16:46 2024 +0200
replace createFromAscii with OUString literals in OpenDocumentButton
Change-Id: I989f5f82fe65e0f877d86b7eb98ba8ad57147988
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167509
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/dbaccess/source/ui/control/opendoccontrols.cxx
b/dbaccess/source/ui/control/opendoccontrols.cxx
index f8b9d6721ab6..bb2558afd435 100644
--- a/dbaccess/source/ui/control/opendoccontrols.cxx
+++ b/dbaccess/source/ui/control/opendoccontrols.cxx
@@ -52,12 +52,8 @@ namespace dbaui
using ::com::sun::star::ui::XImageManager;
using ::com::sun::star::graphic::XGraphic;
-Reference< XGraphic> GetCommandIcon( const char* _pCommandURL, const
OUString& _rModuleName )
+Reference< XGraphic> GetCommandIcon( const OUString& sCommandURL,
const OUString& _rModuleName )
{
-if ( !_pCommandURL || !*_pCommandURL )
-return nullptr;
-
-OUString sCommandURL = OUString::createFromAscii( _pCommandURL );
try
{
do
@@ -94,24 +90,17 @@ namespace dbaui
// OpenButton
-OpenDocumentButton::OpenDocumentButton(std::unique_ptr
xControl, const char* _pAsciiModuleName)
-: m_xControl(std::move(xControl))
+OpenDocumentButton::OpenDocumentButton(std::unique_ptr
xControl, const OUString& _rAsciiModuleName)
+: m_sModule( _rAsciiModuleName )
+, m_xControl(std::move(xControl))
{
-impl_init( _pAsciiModuleName );
-}
-
-void OpenDocumentButton::impl_init( const char* _pAsciiModuleName )
-{
-OSL_ENSURE( _pAsciiModuleName, "OpenDocumentButton::impl_init: invalid
module name!" );
-m_sModule = OUString::createFromAscii( _pAsciiModuleName );
-
// our label should equal the UI text of the "Open" command
auto aProperties =
vcl::CommandInfoProvider::GetCommandProperties(u".uno:Open"_ustr, m_sModule);
OUString
sLabel(vcl::CommandInfoProvider::GetLabelForCommand(aProperties));
m_xControl->set_label(" " + sLabel.replaceAll("~", ""));
// Place icon left of text and both centered in the button.
-m_xControl->set_image(GetCommandIcon(".uno:Open", m_sModule));
+m_xControl->set_image(GetCommandIcon(u".uno:Open"_ustr, m_sModule));
}
// OpenDocumentListBox
diff --git a/dbaccess/source/ui/dlg/generalpage.cxx
b/dbaccess/source/ui/dlg/generalpage.cxx
index 03887054becb..bd87bb8a0f1b 100644
--- a/dbaccess/source/ui/dlg/generalpage.cxx
+++ b/dbaccess/source/ui/dlg/generalpage.cxx
@@ -453,7 +453,7 @@ namespace dbaui
, m_xEmbeddedDBType(m_xBuilder->weld_combo_box(u"embeddeddbList"_ustr))
, m_xFT_DocListLabel(m_xBuilder->weld_label(u"docListLabel"_ustr))
, m_xLB_DocumentList(new
OpenDocumentListBox(m_xBuilder->weld_combo_box(u"documentList"_ustr),
"com.sun.star.sdb.OfficeDatabaseDocument"))
-, m_xPB_OpenDatabase(new
OpenDocumentButton(m_xBuilder->weld_button(u"openDatabase"_ustr),
"com.sun.star.sdb.OfficeDatabaseDocument"))
+, m_xPB_OpenDatabase(new
OpenDocumentButton(m_xBuilder->weld_button(u"openDatabase"_ustr),
u"com.sun.star.sdb.OfficeDatabaseDocument"_ustr))
,
m_xFT_NoEmbeddedDBLabel(m_xBuilder->weld_label(u"noembeddeddbLabel"_ustr))
, m_eOriginalCreationMode(eCreateNew)
, m_bInitEmbeddedDBList(true)
diff --git a/dbaccess/source/ui/inc/opendoccontrols.hxx
b/dbaccess/source/ui/inc/opendoccontrols.hxx
index 8448a047dc7b..d0bfe63e8214 100644
--- a/dbaccess/source/ui/inc/opendoccontrols.hxx
+++ b/dbaccess/source/ui/inc/opendoccontrols.hxx
@@ -38,13 +38,10 @@ namespace dbaui
std::unique_ptr m_xControl;
public:
-OpenDocumentButton(std::unique_ptr xControl, const char*
_pAsciiModuleName);
+OpenDocumentButton(std::unique_ptr xControl, const
OUString& _rAsciiModuleName);
void set_sensitive(bool bSensitive) {
m_xControl->set_sensitive(bSensitive); }
void connect_clicked(const Link& rLink) {
m_xControl->connect_clicked(rLink); }
-
-private:
-voidimpl_init( const char* _pAsciiModuleName );
};
// OpenDocumentListBox
commit 1ea8e12e50579c60ccc244fc8e3414026ad82c61
Author: Noel Grandin
AuthorDate: Tue May 7 14:36:09 2024 +0200
Commit: Noel Grandin
CommitDate: Sat May 11 18:16:32 2024 +0200
replace createFromAscii with OUString literals in SbaTableQueryBrowser
[Bug 161042] New: LO local instances hang when a network document save is executed
https://bugs.documentfoundation.org/show_bug.cgi?id=161042 Bug ID: 161042 Summary: LO local instances hang when a network document save is executed Product: LibreOffice Version: 24.2.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: myrbourf...@gmail.com Description: In Linux Mint 21.3 I work a lot with network documents (documents on a remote shared location also running linux and accessed through ssh). If I open one network document (calc) and one local document (calc) and run a "save" on the network document, during the save even the local instance hangs. As I work with very large documents, the whole libreoffice local and network instance can hang for more than 1 minute in every save. My question is why the local file also hangs if the upload of the network save is slow. Shouldn't they two instances be independent? I understand the hanging of the remote document but I don't justify the hanging of the local document. Steps to Reproduce: 1. Open a big (> 30MB) network shared document (preferably through ssh) 2. Open a local document 3. Click "Save" on the network shared document 4. Try to use / edit the local document. It's impossible because even the local instance of LO is hanging! Actual Results: Both local and network edited LO instances hang when a save is executed on the remote document. Expected Results: Only the network edited LO instance should hang when a save is executed on the remote document. The local opened document/instance should be fully functional without hanging and without being affected by the network edited instance. Reproducible: Always User Profile Reset: No Additional Info: I'm using the following LO version: Version: 24.2.4.0.0+ (X86_64) / LibreOffice Community Build ID: aa225b41352f22c60f41fb9fa03c23b4e9359266 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: el-GR (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
core.git: vcl/win
vcl/win/app/salinst.cxx | 23 ++-
1 file changed, 22 insertions(+), 1 deletion(-)
New commits:
commit dc03e4fd524384963bafc529d0843d048e159106
Author: kubak
AuthorDate: Sun May 5 00:51:50 2024 +0200
Commit: Mike Kaganski
CommitDate: Sat May 11 17:46:31 2024 +0200
tdf#96671 - Correctly detect windows 64-bit OS
Adds detection:
- Windows X86_64,
- Windows X86_32
- WoW64 (Windows 32 on Windows 64).
Change-Id: Ic40ec8bdfb206a7ad3045edf7ecef3cb97cc08f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167144
Reviewed-by: Mike Kaganski
Tested-by: Jenkins
diff --git a/vcl/win/app/salinst.cxx b/vcl/win/app/salinst.cxx
index 4fc2b5e57e72..1a047853a3e1 100644
--- a/vcl/win/app/salinst.cxx
+++ b/vcl/win/app/salinst.cxx
@@ -948,10 +948,31 @@ typedef LONG NTSTATUS;
typedef NTSTATUS(WINAPI* RtlGetVersion_t)(PRTL_OSVERSIONINFOW);
constexpr NTSTATUS STATUS_SUCCESS = 0x;
+static OUString getWinBits()
+{
+#if _WIN64
+
+return " X86_64";
+
+#else
+
+BOOL isWow64 = FALSE;
+
+IsWow64Process(GetCurrentProcess(), );
+
+if (isWow64)
+return " X86_64"; //32-bit process on 64-bit Windows.
+else
+return " X86_32";
+
+#endif
+}
+
static OUString getOSVersionString(const OUString& aNtVersionString, DWORD
nBuildNumber)
{
+OUString winArch = getWinBits();
OUString aVersionPlusBuild
-= " (" + aNtVersionString + " build " + OUString::number(nBuildNumber)
+ ")";
+= winArch + " (" + aNtVersionString + " build " +
OUString::number(nBuildNumber) + ")";
if (aNtVersionString == "6.1")
return "Windows 7 Service Pack 1" + aVersionPlusBuild;
[Bug 103239] [META] Toolbars bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103239 Jérôme changed: What|Removed |Added Depends on||161040 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=161040 [Bug 161040] application colors scheme : offer a drop-down list in toolbars -- You are receiving this mail because: You are the assignee for the bug.
[Bug 102062] [META] Notebookbar: bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102062 Jérôme changed: What|Removed |Added Depends on||161040 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=161040 [Bug 161040] application colors scheme : offer a drop-down list in toolbars -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161040] application colors scheme : offer a drop-down list in toolbars
https://bugs.documentfoundation.org/show_bug.cgi?id=161040 Jérôme changed: What|Removed |Added Blocks||102062, 103239 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102062 [Bug 102062] [META] Notebookbar: bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=103239 [Bug 103239] [META] Toolbars bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157858] Can't remove the main content element, nor the title, from a Master Slide
https://bugs.documentfoundation.org/show_bug.cgi?id=157858 Eyal Rozenberg changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #6 from Eyal Rozenberg --- (In reply to Stéphane Guillou (stragu) from comment #5) > Eyal, don't the layouts "Centered Text" and "Title Only" cover your use case > already? No, for two reasons. First, with the "Centered Text" layout, it seems I don't actually get the text formatting as in the master's main element content. Not sure if this is a bug or intended behavior, but that's how it is,. Second, I may not want to let the user have the false idea that it is a valid design choice to use elements which I do not "support" in terms of my design choices of the master. Third, I want to be able to edit the master slide without the gratuitous item getting in my way. > Having a master slide with either one of those placeholders missing would > mean having layout icons not matching the result when applying them. Perhaps they could be grayed out? Or adjusted to account for this fact? -- You are receiving this mail because: You are the assignee for the bug.
Weekly Status Update
Hi, this is my weekly status update for Improving User Experience Around Windows. -Learn about uno commands and dispatcher concepts which will be needed throughout the project. -Learn how to use the startmodule dispatcher in the implementation. -Provided an implementation for tdf#159380 which prompts the user for unsaved documents and opens the start center on successful closure. -Working on code review suggestions for tdf#159380. -Working on refining the second part of the project plan. I will be unavailable on May 12 - 14 most of the time due to travels.
Re: tdf132599_frames_* tests needs hu-HU hyphenation for english text
Hi, Am 10.05.24 um 18:58 schrieb Rene Engelhard: I think the files should be fixed to set the text language to English (USA) instead? https://gerrit.libreoffice.org/c/core/+/167486. FTR that one didn't work (as written in my mail)but Laszlo did https://gerrit.libreoffice.org/c/core/+/167512 which fixes it (and got just merged). Thanks for the quick fix. Regards, Rene
[Bug 157685] Impress: Mirrored images in print preview and printed pages are not mirrored
https://bugs.documentfoundation.org/show_bug.cgi?id=157685 Kurt Huwig changed: What|Removed |Added Version|7.5.4.2 release |24.2.0.3 release OS|Windows (All) |All -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157685] Impress: Mirrored images in print preview and printed pages are not mirrored
https://bugs.documentfoundation.org/show_bug.cgi?id=157685 --- Comment #4 from Kurt Huwig --- I've attached a file that reproduces the problem. I only have a wrong preview but correct printing and PDF export. Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: 420(Build:3) CPU threads: 12; OS: Linux 6.8; UI render: default; VCL: gtk3 Locale: de-DE (de_DE.utf8); UI: de-DE 24.2.0-2 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 148305] Can't switch the column placement direction between LTR and RTL (see comment #12)
https://bugs.documentfoundation.org/show_bug.cgi?id=148305 Eyal Rozenberg changed: What|Removed |Added Summary|Can't switch the column |Can't switch the column |placement direction between |placement direction between |LTR and RTL |LTR and RTL (see comment ||#12) --- Comment #12 from Eyal Rozenberg --- Possibility of switching column progression direction not added. Let me clarify the reproduction instructions: 1. Open attachment 179657 2. Right-click inside the table-of-contents area 3. On the context menu, click "Edit Index" 4. Bring up the "Columns" tab Expected result: The tab should have a checkbox or other control for the column progression direction: RTL, LTR, perhaps Inherit. Actual result: No such control for the column progrgression direction. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157685] Impress: Mirrored images in print preview and printed pages are not mirrored
https://bugs.documentfoundation.org/show_bug.cgi?id=157685 --- Comment #3 from Kurt Huwig --- Created attachment 194086 --> https://bugs.documentfoundation.org/attachment.cgi?id=194086=edit file with mirrored images print preview does not match document and printed version -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103184] [META] UI theming bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103184 Jérôme changed: What|Removed |Added Depends on||161041 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=161041 [Bug 161041] memorize in the user environment the colors scheme to be used for each document -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161040] application colors scheme : offer a drop-down list in toolbars
https://bugs.documentfoundation.org/show_bug.cgi?id=161040 Jérôme changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=16 ||1041 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161041] memorize in the user environment the colors scheme to be used for each document
https://bugs.documentfoundation.org/show_bug.cgi?id=161041 Jérôme changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=16 ||1040 Blocks||103184 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103184 [Bug 103184] [META] UI theming bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161041] New: memorize in the user environment the colors scheme to be used for each document
https://bugs.documentfoundation.org/show_bug.cgi?id=161041 Bug ID: 161041 Summary: memorize in the user environment the colors scheme to be used for each document Product: LibreOffice Version: 7.4.7.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jerome.bo...@laposte.net I'm trying to edit documents with a dark colors scheme. However, many documents aren't readable with this colors scheme and I need to switch back to an other colors scheme. I would like a feature which memorize into the user environment the colors scheme to be used for each document. This choice wouldn't be stored into the document. I'm already using this feature with Firefox and its Dark Reader extension. I'm deactivating the feature only for the web sites that aren't readable with the color transformation that Dark Reader does. The next time I'm visiting again a web site, the extension apply the choice I made during my last visit. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 113943] [META] Options dialog's Calc settings bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113943 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||160904 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160904 [Bug 160904] Remove "= and <>" from "Search criteria = and <> must apply to whole cells" -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160904] Remove "= and <>" from "Search criteria = and <> must apply to whole cells"
https://bugs.documentfoundation.org/show_bug.cgi?id=160904 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||113943 CC||79045_79...@mail.ru, ||er...@redhat.com --- Comment #3 from Roman Kuznetsov <79045_79...@mail.ru> --- Eike, do you have some opinion here? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113943 [Bug 113943] [META] Options dialog's Calc settings bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158874] Want MS-Word like auto-formatting of beginning of list item
https://bugs.documentfoundation.org/show_bug.cgi?id=158874 Eyal Rozenberg changed: What|Removed |Added CC||heiko.tietze@documentfounda ||tion.org --- Comment #13 from Eyal Rozenberg --- Heiko FYI. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 158874] Want MS-Word like auto-formatting of beginning of list item
https://bugs.documentfoundation.org/show_bug.cgi?id=158874 Eyal Rozenberg changed: What|Removed |Added CC||heiko.tietze@documentfounda ||tion.org --- Comment #13 from Eyal Rozenberg --- Heiko FYI. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158874] Want MS-Word like auto-formatting of beginning of list item
https://bugs.documentfoundation.org/show_bug.cgi?id=158874 Eyal Rozenberg changed: What|Removed |Added Resolution|INSUFFICIENTDATA|--- Status|RESOLVED|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103341 Bug 103341 depends on bug 158874, which changed state. Bug 158874 Summary: Want MS-Word like auto-formatting of beginning of list item https://bugs.documentfoundation.org/show_bug.cgi?id=158874 What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|INSUFFICIENTDATA|--- -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158874] Want MS-Word like auto-formatting of beginning of list item
https://bugs.documentfoundation.org/show_bug.cgi?id=158874 Eyal Rozenberg changed: What|Removed |Added Resolution|INSUFFICIENTDATA|--- Status|RESOLVED|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158874] Want MS-Word like auto-formatting of beginning of list item
https://bugs.documentfoundation.org/show_bug.cgi?id=158874 --- Comment #12 from Eyal Rozenberg --- Created attachment 194085 --> https://bugs.documentfoundation.org/attachment.cgi?id=194085=edit Screencast of MS Word behavior Screencast of how MS Word autoformats initial phrase on a line, based on the formatting of that phrase on the previous line, in a bulleted list. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 158874] Want MS-Word like auto-formatting of beginning of list item
https://bugs.documentfoundation.org/show_bug.cgi?id=158874 --- Comment #12 from Eyal Rozenberg --- Created attachment 194085 --> https://bugs.documentfoundation.org/attachment.cgi?id=194085=edit Screencast of MS Word behavior Screencast of how MS Word autoformats initial phrase on a line, based on the formatting of that phrase on the previous line, in a bulleted list. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160930] The Shift+esc combination key cannot search for all menu items. (zh-CN locale)
https://bugs.documentfoundation.org/show_bug.cgi?id=160930 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||151228 Summary|The Shift+esc combination |The Shift+esc combination |key cannot search for all |key cannot search for all |menu items. |menu items. (zh-CN locale) Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=151228 [Bug 151228] [META] Search for commands -- You are receiving this mail because: You are the assignee for the bug.
[Bug 151228] [META] Search for commands
https://bugs.documentfoundation.org/show_bug.cgi?id=151228 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||160930 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160930 [Bug 160930] The Shift+esc combination key cannot search for all menu items. (zh-CN locale) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160951] Navigator: Present sort options per radio button
https://bugs.documentfoundation.org/show_bug.cgi?id=160951 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160951] Navigator: Present sort options per radio button
https://bugs.documentfoundation.org/show_bug.cgi?id=160951 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 160978] [META] WiX based MSI installer packaging
https://bugs.documentfoundation.org/show_bug.cgi?id=160978 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Set to NEW -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103184] [META] UI theming bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103184 Jérôme changed: What|Removed |Added Depends on||161040 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=161040 [Bug 161040] application colors scheme : offer a drop-down list in toolbars -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161040] application colors scheme : offer a drop-down list in toolbars
https://bugs.documentfoundation.org/show_bug.cgi?id=161040 Jérôme changed: What|Removed |Added Blocks||103184 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103184 [Bug 103184] [META] UI theming bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161040] New: application colors scheme : offer a drop-down list in toolbars
https://bugs.documentfoundation.org/show_bug.cgi?id=161040 Bug ID: 161040 Summary: application colors scheme : offer a drop-down list in toolbars Product: LibreOffice Version: 7.4.7.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jerome.bo...@laposte.net I'm trying to edit documents with a dark colors scheme. However, many documents aren't readable with this colors scheme and I need to switch back to an other colors scheme. I would like to quickly switch between the application colors schemes, depending a the document that I'm working on. Therefore a drop-down list into the toolbar (or notebook bar) would be useful. I'm already using this feature with Firefox and its Dark Reader extension. I'm deactivating the feature only for the web sites that aren't readable with the color transformation that Dark Reader does. -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/qa
sw/qa/extras/layout/data/tdf132599_frames_on_right_pages_no_hyphenation.fodt | 6 +++--- sw/qa/extras/layout/data/tdf132599_frames_on_same_page_hyphenation.fodt | 6 +++--- sw/qa/extras/layout/data/tdf132599_frames_on_same_page_no_hyphenation.fodt | 6 +++--- sw/qa/extras/layout/data/tdf132599_frames_on_spread_hyphenation.fodt | 6 +++--- 4 files changed, 12 insertions(+), 12 deletions(-) New commits: commit 016d61f529f9d9ec2520fb7a808da41cf17d7295 Author: László Németh AuthorDate: Sat May 11 14:26:09 2024 +0200 Commit: René Engelhard CommitDate: Sat May 11 16:29:15 2024 +0200 tdf#132599 sw: fix unit tests for hyphenation-keep with frames Fix en_US language of the test documents to be consistent with the hyphenator condition in the related unit tests of commit d4304cd0a4fedd0117fea3625dff1fca2945a0e6 "tdf132599 sw: fix hyphenation-keep for linked frames, also for spreads". The problem was reported by René Engelhard. Change-Id: Iee7fd83aea294fb32c5f358cd25a1d1cb9a76d27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167512 Reviewed-by: René Engelhard Tested-by: Jenkins Tested-by: René Engelhard diff --git a/sw/qa/extras/layout/data/tdf132599_frames_on_right_pages_no_hyphenation.fodt b/sw/qa/extras/layout/data/tdf132599_frames_on_right_pages_no_hyphenation.fodt index 5d8f21a81c26..c3df7b605f3a 100644 --- a/sw/qa/extras/layout/data/tdf132599_frames_on_right_pages_no_hyphenation.fodt +++ b/sw/qa/extras/layout/data/tdf132599_frames_on_right_pages_no_hyphenation.fodt @@ -129,11 +129,11 @@ - + - + @@ -210,7 +210,7 @@ - out there in space. It merely moves along in space inertially. Even just one inch above the surface of the Earth is space, except that it has an atmosphere. Earth is. The Earth is no different to any other celestial body + Space. It merely moves along in space inertially. Even just one inch above the surface of the Earth is space, except that it has an atmosphere. Earth is. The Earth is no different to any other celestial body diff --git a/sw/qa/extras/layout/data/tdf132599_frames_on_same_page_hyphenation.fodt b/sw/qa/extras/layout/data/tdf132599_frames_on_same_page_hyphenation.fodt index 34933cba9007..f92358ad0ea3 100644 --- a/sw/qa/extras/layout/data/tdf132599_frames_on_same_page_hyphenation.fodt +++ b/sw/qa/extras/layout/data/tdf132599_frames_on_same_page_hyphenation.fodt @@ -124,11 +124,11 @@ - + - + @@ -198,7 +198,7 @@ - out there in space. It merely moves along in space inertially. Even just one inch above the surface of the Earth is space, except that it has an atmosphere. Earth is. The Earth is no different to any other celestial body + Space. It merely moves along in space inertially. Even just one inch above the surface of the Earth is space, except that it has an atmosphere. Earth is. The Earth is no different to any other celestial body diff --git a/sw/qa/extras/layout/data/tdf132599_frames_on_same_page_no_hyphenation.fodt b/sw/qa/extras/layout/data/tdf132599_frames_on_same_page_no_hyphenation.fodt index 75a0dc00ce6e..64bd33b5aada 100644 --- a/sw/qa/extras/layout/data/tdf132599_frames_on_same_page_no_hyphenation.fodt +++ b/sw/qa/extras/layout/data/tdf132599_frames_on_same_page_no_hyphenation.fodt @@ -124,11 +124,11 @@ - + - + @@ -198,7 +198,7 @@ - out there in space. It merely moves along in space inertially. Even just one inch above the surface of the Earth is space, except that it has an atmosphere. Earth is. The Earth is no different to any other celestial body + Space. It merely moves along in space inertially. Even just one inch above the surface of the Earth is space, except that it has an atmosphere. Earth is. The Earth is no different to any other celestial body diff --git a/sw/qa/extras/layout/data/tdf132599_frames_on_spread_hyphenation.fodt b/sw/qa/extras/layout/data/tdf132599_frames_on_spread_hyphenation.fodt index 92cf5ef4773b..b1c16ad6db59 100644 --- a/sw/qa/extras/layout/data/tdf132599_frames_on_spread_hyphenation.fodt +++ b/sw/qa/extras/layout/data/tdf132599_frames_on_spread_hyphenation.fodt @@ -129,11 +129,11 @@ - + - + @@ -213,7 +213,7 @@ - out there in space. It merely moves along in space inertially. Even just one inch above the surface of the Earth is space, except that it has an atmosphere. Earth is. The Earth is no different to any other celestial body + Space. It merely moves along in space inertially. Even just one inch above the surface of the Earth is space, except that it has an atmosphere. Earth is. The Earth is no different to any other
[Bug 86899] [META] Requests for the addition of UNO commands
https://bugs.documentfoundation.org/show_bug.cgi?id=86899 V Stuart Foote changed: What|Removed |Added Depends on||161037 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=161037 [Bug 161037] UNO Sidebar 'Hide' and 'Show' sidebar deck (splitwin) -- a new function (available for assigning a shortcut key to it) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161037] UNO Sidebar 'Hide' and 'Show' sidebar deck (splitwin) -- a new function (available for assigning a shortcut key to it)
https://bugs.documentfoundation.org/show_bug.cgi?id=161037 V Stuart Foote changed: What|Removed |Added URL||https://wiki.documentfounda ||tion.org/File:LO-HIG_SideeB ||ar-Terminology.png CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||rayk...@gmail.com, ||vsfo...@libreoffice.org Summary|close sidebar deck -- a new |UNO Sidebar 'Hide' and |function (available for |'Show' sidebar deck |assigning a shortkey to it) |(splitwin) -- a new ||function (available for ||assigning a shortcut key to ||it) Keywords||needsUXEval Blocks||86899 --- Comment #1 from V Stuart Foote --- This is expected with the current +F5 toggle (.uno:Sidebar) which *closes* or *opens a new instance* of the SB framework. Its workflow and UI behavior is pretty consistent, as is that of the F11 "Stylist". Also, UNO are already available and assigned to open each SB Deck (bug 84502); +[1-9] with 1-4 common (uno:PropertyDeck, uno:StyleListDeck, uno:GalleryDeck, uno:NavigatorDeck) across the modules. IMHO what *would* be useful would be creating an additional UNO action supporting a keyboard toggle of the current 'Hide'/'Show' (vcl/splitwin) thumb/grip button actions for an active Sidebar instance. Currently just available to mouse click on the buttons. While clicking on a Deck's Tab in the Tab bar will toggle the Deck collapsed or open, the "Hide" thumb button fully collapses the Sidebar (exposing a 'Show' thumb button on the opposite SB edge). While the 'Show' button restores the Sidebar, either just Tab bar, or Tab bar and Deck depending on state when hidden. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=86899 [Bug 86899] [META] Requests for the addition of UNO commands -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161037] UNO Sidebar 'Hide' and 'Show' sidebar deck (splitwin) -- a new function (available for assigning a shortcut key to it)
https://bugs.documentfoundation.org/show_bug.cgi?id=161037 V Stuart Foote changed: What|Removed |Added URL||https://wiki.documentfounda ||tion.org/File:LO-HIG_SideeB ||ar-Terminology.png CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||rayk...@gmail.com, ||vsfo...@libreoffice.org Summary|close sidebar deck -- a new |UNO Sidebar 'Hide' and |function (available for |'Show' sidebar deck |assigning a shortkey to it) |(splitwin) -- a new ||function (available for ||assigning a shortcut key to ||it) Keywords||needsUXEval Blocks||86899 --- Comment #1 from V Stuart Foote --- This is expected with the current +F5 toggle (.uno:Sidebar) which *closes* or *opens a new instance* of the SB framework. Its workflow and UI behavior is pretty consistent, as is that of the F11 "Stylist". Also, UNO are already available and assigned to open each SB Deck (bug 84502); +[1-9] with 1-4 common (uno:PropertyDeck, uno:StyleListDeck, uno:GalleryDeck, uno:NavigatorDeck) across the modules. IMHO what *would* be useful would be creating an additional UNO action supporting a keyboard toggle of the current 'Hide'/'Show' (vcl/splitwin) thumb/grip button actions for an active Sidebar instance. Currently just available to mouse click on the buttons. While clicking on a Deck's Tab in the Tab bar will toggle the Deck collapsed or open, the "Hide" thumb button fully collapses the Sidebar (exposing a 'Show' thumb button on the opposite SB edge). While the 'Show' button restores the Sidebar, either just Tab bar, or Tab bar and Deck depending on state when hidden. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=86899 [Bug 86899] [META] Requests for the addition of UNO commands -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 161039] New: LibreOffice crashed and i lost my document
https://bugs.documentfoundation.org/show_bug.cgi?id=161039 Bug ID: 161039 Summary: LibreOffice crashed and i lost my document Product: LibreOffice Version: 3.3 all versions Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: trivial Priority: medium Component: Documentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: masagujani...@gmail.com CC: olivier.hal...@libreoffice.org Description: Libreoffice crashed about half an hour ago while i was finishing up a really important story i was writing and then it exited from Libreoffice and when i tried to doubleclick on it to go in, it presented me with a blank document and now i do not have my document. I need my document back. Actual Results: i do not have the steps above ypu should tell me how to get my document back Expected Results: there are no steps Reproducible: Sometimes User Profile Reset: No Additional Info: It should not have crashed. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 113380] UI: Media Player Dialog: Buttons overlapping
https://bugs.documentfoundation.org/show_bug.cgi?id=113380 Emma Smith changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|FIXED |--- Ever confirmed|1 |0 --- Comment #8 from Emma Smith --- https://taraweehkidua.com/ https://surahjuma.site/ https://meaninginhindi.org/ https://gbapps.site/ https://futemax2.online/ https://meaningintamil.org/ https://girlsnumberfree.in/ https://meaninginmarathi.in/ https://dostishayaris.in/ https://armycut.in/ https://blousebackdesign.org/ https://sattamattamatka.online/ https://garageclarity.com/ https://girlsdpreal.in https://meaninginhindi.org/ https://mehandidesigns.org/ https://howtovoteindia.in/ https://mpbhulekh.site/ https://pmawasgraminonline.in/ https://telugunews24.in/ https://yojananews.in/ https://cutewhatsappdp.com/ https://vehicleownerdetails.site/ -- You are receiving this mail because: You are the assignee for the bug.
[Bug 112589] [META] Media player dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112589 Bug 112589 depends on bug 113380, which changed state. Bug 113380 Summary: UI: Media Player Dialog: Buttons overlapping https://bugs.documentfoundation.org/show_bug.cgi?id=113380 What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.
[Bug 146727] Import strings that matches specific LO Math operators in MSO equations as text
https://bugs.documentfoundation.org/show_bug.cgi?id=146727 --- Comment #9 from Francisco --- (In reply to QA Administrators from comment #8) > Dear Francisco, > > To make sure we're focusing on the bugs that affect our users today, > LibreOffice QA is asking bug reporters and confirmers to retest open, > confirmed bugs which have not been touched for over a year. > Dear QA administrator, the bug is still present in LibO 7.4.7, and for sure it's still present in the newest versions bc if nobody corrects it, it won't be solved. Best regards -- You are receiving this mail because: You are the assignee for the bug.
core.git: framework/source
framework/source/uiconfiguration/CommandImageResolver.cxx | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
New commits:
commit 89d35be82851d820f36e31ac1866b1d58be0aa07
Author: Noel Grandin
AuthorDate: Wed May 8 10:01:08 2024 +0200
Commit: Noel Grandin
CommitDate: Sat May 11 15:04:15 2024 +0200
replace createFromAscii with OUString literals in CommandImageResolver
Change-Id: I668062d2e6e220be16e3aa74b01db281d54876ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167511
Reviewed-by: Noel Grandin
Tested-by: Jenkins
diff --git a/framework/source/uiconfiguration/CommandImageResolver.cxx
b/framework/source/uiconfiguration/CommandImageResolver.cxx
index a431ae320b35..e6c0c8ba850d 100644
--- a/framework/source/uiconfiguration/CommandImageResolver.cxx
+++ b/framework/source/uiconfiguration/CommandImageResolver.cxx
@@ -21,11 +21,11 @@ namespace vcl
namespace
{
-const o3tl::enumarray ImageType_Prefixes =
+constexpr o3tl::enumarray ImageType_Prefixes
{
-"cmd/sc_",
-"cmd/lc_",
-"cmd/32/"
+u"cmd/sc_"_ustr,
+u"cmd/lc_"_ustr,
+u"cmd/32/"_ustr
};
OUString lclConvertToCanonicalName(const OUString& rFileName)
@@ -129,7 +129,7 @@ ImageList* CommandImageResolver::getImageList(ImageType
nImageType)
if (!m_pImageList[nImageType])
{
-OUString sIconPath =
OUString::createFromAscii(ImageType_Prefixes[nImageType]);
+OUString sIconPath = ImageType_Prefixes[nImageType];
m_pImageList[nImageType].reset( new ImageList(m_aImageNameVector,
sIconPath) );
}
core.git: Branch 'distro/collabora/co-24.04' - vcl/source
vcl/source/app/svapp.cxx | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
New commits:
commit 7b61926fd6704dd244682a965c17e7141ffc1fc5
Author: Michael Meeks
AuthorDate: Fri May 10 17:13:55 2024 +0100
Commit: Noel Grandin
CommitDate: Sat May 11 14:51:38 2024 +0200
lok: dumpState should truncate very long JSON messages.
Otherwise we get huge dumps which can overwhelm our logging and hide
more useful information, and/or the journal can drop them on the ground.
Change-Id: Ie942c70a90a6df60ccd8986444362d622c213e15
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167488
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Noel Grandin
diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx
index 79b8f5873df8..34b2774995f1 100644
--- a/vcl/source/app/svapp.cxx
+++ b/vcl/source/app/svapp.cxx
@@ -1758,11 +1758,17 @@ void dumpState(rtl::OStringBuffer )
vcl::Window *pWin = Application::GetFirstTopLevelWindow();
while (pWin)
{
-tools::JsonWriter props;
-pWin->DumpAsPropertyTree(props);
+tools::JsonWriter aProps;
+pWin->DumpAsPropertyTree(aProps);
rState.append("
Window: ");
-rState.append(props.finishAndGetAsOString());
+OString aPropStr = aProps.finishAndGetAsOString();
+if (aPropStr.getLength() > 256)
+{
+rState.append(aPropStr.subView(0, 256));
+rState.append("...");
+} else
+rState.append(aPropStr);
pWin = Application::GetNextTopLevelWindow( pWin );
}
core.git: 2 commits - dbaccess/source pyuno/source vcl/source
dbaccess/source/filter/xml/xmlfilter.cxx |8 +++-
pyuno/source/module/pyuno_module.cxx | 27 +++
vcl/source/image/ImplImageTree.cxx | 14 --
3 files changed, 26 insertions(+), 23 deletions(-)
New commits:
commit 0652885ffeddac94c47fe7c53a58c172a63f9d56
Author: Noel Grandin
AuthorDate: Tue May 7 14:28:40 2024 +0200
Commit: Noel Grandin
CommitDate: Sat May 11 14:50:40 2024 +0200
replace createFromAscii with OUString literals in ReadThroughComponent
Change-Id: Ic92b15ea369e420faf6bfc40f509bba6e454710f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167500
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/dbaccess/source/filter/xml/xmlfilter.cxx
b/dbaccess/source/filter/xml/xmlfilter.cxx
index 06b6db1edd95..18a1d223df86 100644
--- a/dbaccess/source/filter/xml/xmlfilter.cxx
+++ b/dbaccess/source/filter/xml/xmlfilter.cxx
@@ -125,12 +125,11 @@ static ErrCode ReadThroughComponent(
static ErrCode ReadThroughComponent(
const uno::Reference< embed::XStorage >& xStorage,
const uno::Reference& xModelComponent,
-const char* pStreamName,
+const OUString& sStreamName,
const uno::Reference & rxContext,
ODBFilter& _rFilter)
{
OSL_ENSURE( xStorage.is(), "Need storage!");
-OSL_ENSURE(nullptr != pStreamName, "Please, please, give me a name!");
if ( !xStorage )
// TODO/LATER: better error handling
@@ -141,7 +140,6 @@ static ErrCode ReadThroughComponent(
try
{
// open stream (and set parser input)
-OUString sStreamName = OUString::createFromAscii(pStreamName);
if ( !xStorage->hasByName( sStreamName ) ||
!xStorage->isStreamElement( sStreamName ) )
{
// stream name not found! return immediately with OK signal
@@ -323,7 +321,7 @@ bool ODBFilter::implImport( const Sequence< PropertyValue
>& rDescriptor )
uno::Reference xModel(GetModel());
ErrCode nRet = ReadThroughComponent( xStorage
,xModel
-,"settings.xml"
+,u"settings.xml"_ustr
,GetComponentContext()
,*this
);
@@ -331,7 +329,7 @@ bool ODBFilter::implImport( const Sequence< PropertyValue
>& rDescriptor )
if ( nRet == ERRCODE_NONE )
nRet = ReadThroughComponent( xStorage
,xModel
-,"content.xml"
+,u"content.xml"_ustr
,GetComponentContext()
,*this
);
commit ed699baa9226f94d912cd2646ed8e2ce37bb1869
Author: Noel Grandin
AuthorDate: Fri May 10 21:51:11 2024 +0200
Commit: Noel Grandin
CommitDate: Sat May 11 14:50:28 2024 +0200
workaround clang segfault on macos-intel
Change-Id: Icfced4a990e2d02995bff4078f14b8ee26e9cca3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167497
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/pyuno/source/module/pyuno_module.cxx
b/pyuno/source/module/pyuno_module.cxx
index 2a70e80285fe..53527df35780 100644
--- a/pyuno/source/module/pyuno_module.cxx
+++ b/pyuno/source/module/pyuno_module.cxx
@@ -196,21 +196,24 @@ void fillStruct(
}
}
-OUString getLibDir()
+OUString getLibDir();
+OUString getLibDirImpl()
{
-static OUString sLibDir = []() {
-OUString libDir;
+OUString libDir;
-// workarounds the $(ORIGIN) until it is available
-if
(Module::getUrlFromAddress(reinterpret_cast(getLibDir),
libDir))
-{
-libDir = libDir.copy(0, libDir.lastIndexOf('/'));
-OUString name(u"PYUNOLIBDIR"_ustr);
-rtl_bootstrap_set(name.pData, libDir.pData);
-}
-return libDir;
-}();
+// workarounds the $(ORIGIN) until it is available
+if
(Module::getUrlFromAddress(reinterpret_cast(getLibDir),
libDir))
+{
+libDir = libDir.copy(0, libDir.lastIndexOf('/'));
+OUString name(u"PYUNOLIBDIR"_ustr);
+rtl_bootstrap_set(name.pData, libDir.pData);
+}
+return libDir;
+}
+OUString getLibDir()
+{
+static OUString sLibDir = getLibDirImpl();
return sLibDir;
}
diff --git a/vcl/source/image/ImplImageTree.cxx
b/vcl/source/image/ImplImageTree.cxx
index 55fb4ee2f349..f565461f8607 100644
--- a/vcl/source/image/ImplImageTree.cxx
+++ b/vcl/source/image/ImplImageTree.cxx
@@ -108,15 +108,17 @@ OUString createPath(std::u16string_view name, sal_Int32
pos, std::u16string_view
return OUString::Concat(name.substr(0, pos + 1)) + locale +
name.substr(pos);
}
+OUString getIconCacheUrlImpl()
+{
+OUString sDir = u"${$BRAND_BASE_DIR/" LIBO_ETC_FOLDER "/"
SAL_CONFIGFILE("bootstrap")
[Bug 160944] LO Calc Crashes after inserting a row in spreadsheet (or after saving directly after)
https://bugs.documentfoundation.org/show_bug.cgi?id=160944 --- Comment #10 from Regina Henschel --- The example document has Zombie-shape anchored to the first cell in the last row. Repair instructions: Insert a shape. Leave insert mode. Select the newly inserted shape. Press Tab-key (that will select the next shape) and wait a little bit. The view will change to the last row. There you see the anchor in the first cell. Press Delete-key. Now the Zombie-shape is deleted. Go back to the newly inserted shape and delete it too. Save the document. This Zombie-shape itself is a 180° rotated, skewed "Striped Right Arrow". It is anchored "To cell (resize with cell). The crash itself happens somewhere in export, likely in OpenRow, when it gets a nStartRow=1048576. There is somewhere a check missing, whether the row really exists. But I don't now where. So there are two problems: 1. How could this Zombie-shape come into being? 2. Prevent invalid row access. -- You are receiving this mail because: You are the assignee for the bug.
