[Bug 161153] Inserting tashdid (a.k.a. shaddah) character (Unicode 0651) breaks or distorts Persian text
https://bugs.documentfoundation.org/show_bug.cgi?id=161153 --- Comment #6 from افشین --- Persian fonts of the IR series for example "IR Nazanin" also have no problem in displaying the tashdid character. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 135072] Crash undo comparing documents BigPtrArray::Index2Block+0xc8
https://bugs.documentfoundation.org/show_bug.cgi?id=135072 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||5073 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 135073] Crash of the document recovery window (comment 11)
https://bugs.documentfoundation.org/show_bug.cgi?id=135073 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org OS|All |Windows (All) See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||5072 --- Comment #14 from Stéphane Guillou (stragu) --- With comment 12 steps: No repro on Linux: BigPtrArray crash at step 6, but at step 9, but LO closes, and Ubuntu Apport catches the crash. Reopening LO goes directly to reporting the step 6 crash, and then the document recovery works. Version: 7.6.6.3 (X86_64) / LibreOffice Community Build ID: d97b2716a9a4a2ce1391dee1765565ea469b0ae7 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL threaded On Windows 11, I get the crash at step 6, and then "Document are being saved" is stuck on step 9 with progress bar not moving. If I close that dialog and restart LO, I get the crash report dialog, with signature "BigPtrArray::Index2Block(long)": - https://crashreport.libreoffice.org/stats/crash_details/fa9252b3-d5df-4605-9d10-6edc7f42a120 - https://crashreport.libreoffice.org/stats/crash_details/99030566-c721-4ae7-b885-26253eab36a4 ... but that's the step 6 (bug 135072) crash that's reported after, correct? After the crash report dialog, the document recovery works as expected. Version: 7.6.6.3 (X86_64) / LibreOffice Community Build ID: d97b2716a9a4a2ce1391dee1765565ea469b0ae7 CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded Version: 24.2.2.2 (X86_64) / LibreOffice Community Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01 CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded So, is the issue that the "Documents are being saved" freezes? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 92545] Spell Check "Correct All" Ignores final Word
https://bugs.documentfoundation.org/show_bug.cgi?id=92545 --- Comment #7 from Shantanu --- Reproduced. Version: 24.2.1.2 (AARCH64) / LibreOffice Community Build ID: 420(Build:2) CPU threads: 2; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-US (C.UTF-8); UI: en-US Ubuntu package version: 4:24.2.1~rc2-0ubuntu0.22.04.1~lo1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 145734] [META] Qt6 VCL plugin bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=145734 Bug 145734 depends on bug 160565, which changed state. Bug 160565 Summary: KDE/Qt UI - Program freezes after "save as" https://bugs.documentfoundation.org/show_bug.cgi?id=160565 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
core.git: 3 commits - vcl/qt5
vcl/qt5/QtFrame.cxx | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) New commits: commit 2f4103da5625a9b90eb41d5c767a248a8d0b4255 Author: Michael Weghorn AuthorDate: Fri May 17 17:02:49 2024 +0200 Commit: Michael Weghorn CommitDate: Sat May 18 06:55:31 2024 +0200 tdf#160565 tdf#145735 qt: Avoid native window handles for Qt 6 Similar to the tdf#122293 scenario with Qt 5 on Wayland, using native windows causes unresponsive UI even with the xcb Qt QPA plugin when using Qt 6. Therefore, don't call `QWidget::winId()` at all when using Qt 6, but just refuse to resolve a native window handle, the same way that is already done here for the wayland Qt QPA plugin with qt5. Add a comment based on the one originally added with commit 0e3c3b842e14b9646d3697cf1266be21359e0f13 Author: Michael Weghorn Date: Sat May 11 21:31:33 2019 +0200 tdf#122293 qt5: Use "alien widgets" by default on Wayland that was later dropped during a refactoring. This code path is triggered when trying to resolve the parent window for a file picker (s. `QtFilePicker::initialize`). In a quick test in a KDE Plasma 5 Wayland session on Debian testing, the modality behavior was unchanged with or without this change in place: * With qt6 xcb, the main window nicely gets grayed out and is unresponsive while the file dialog gets shown when using e.g. "File" -> "Open" in Writer. * With qt6 wayland, the main window is not grayed out and looks more "active" still, but doesn't actually accept keyboard or mouse input. This is basically the same in other Qt/KDE applications, e.g. a self-compiled Kate from git master, so not LO-specific. If resolving the parent for the file picker turns out to be necessary, maybe something similar to what commit commit 3ff4800fe400de916c97f587322104af06cc0879 Author: Caolán McNamara Date: Wed Apr 4 10:22:34 2018 +0100 weld SvInsertOleDlg and weld SfxInsertFloatingFrameDialog and smuggle in the parent widget for the Gtk File dialog via an XWindow interface did for gtk3 might be worth looking into. However, I can at least not reproduce issues like the one described for gtk3 in commit 203d96787969f707c78101be18d51b44ace98f93 Author: Caolán McNamara Date: Mon Jun 21 13:01:52 2021 +0100 give folderpicker an optional parent so, like a file picker, it can make its parent modal while its operating. Otherwise its possible to interact with the parent dialog in undesirable ways, e.g. file, export as, export as epub, the folder picker of 'media directory' with the qt6 VCL plugin even with this commit in place. Another scenario relying on a native window handle is video playback with GStreamer's x11 video sink. That still works for qt5 with the xcb plugin as the handle is still returned for that one. For qt6 with the xcb plugin, that didn't work properly without this commit either (at least not in my tests with current qtbase dev as of commit 70a2e7f32b9f9ce19d1538f14fbde7b0d1e77ffd), s. tdf#145735 comment 7. It's now broken a different way than before (extra windows show up instead of no video being shown). This will be further tracked together with a solution for Wayland in tdf#125219. As a side note, forcing native windows for everything using `QT_USE_NATIVE_WINDOWS=1` as described at [1] causes more sever brokenness with the qt6 xcb plugin (mostly black window in Writer instead of showing the actual content). [1] https://doc.qt.io/qt-6/qwidget.html#native-widgets-vs-alien-widgets Change-Id: I9718c680bd8bc4ff0574f171403d965c1beac781 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167783 Reviewed-by: Michael Weghorn Tested-by: Jenkins diff --git a/vcl/qt5/QtFrame.cxx b/vcl/qt5/QtFrame.cxx index 0ff940408769..0950b520cb77 100644 --- a/vcl/qt5/QtFrame.cxx +++ b/vcl/qt5/QtFrame.cxx @@ -35,6 +35,7 @@ #include #endif +#include #include #include #include @@ -1355,8 +1356,17 @@ void QtFrame::ResolveWindowHandle(SystemEnvData& rData) const if (!rData.pWidget) return; assert(rData.platform != SystemEnvData::Platform::Invalid); -if (rData.platform != SystemEnvData::Platform::Wayland) +// Calling QWidget::winId() implicitly enables native windows to be used instead +// of "alien widgets" that don't have a native widget asscoiated with them, +// s. https://doc.qt.io/qt-6/qwidget.html#native-widgets-vs-alien-widgets +// Avoid native widgets with Qt 5 on Wayland and with Qt 6
[Bug 138749] Add function LAMBDA for interoperability with MS Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=138749 --- Comment #7 from Óvári --- "eta lambda" (short for "eta reduced lambda") functions [1] https://exceljet.net/glossary/eta-lambda [2] https://techcommunity.microsoft.com/t5/excel/on-the-bleeding-edge-with-eta-reduced-lambda-functions/m-p/4023901 [3] https://www.icaew.com/technical/technology/excel-community/excel-community-articles/2024/excel-new-functions-might-change-data-analysis-forever [4] Excel LAMBDA, LAMBDA Helper Functions & Eta-LAMBDAs: the Complete Story – Updated 2024: 365 MECS 10 https://www.youtube.com/watch?v=OxV-F0vXj8I -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160680] GIF looks worse in HiDPI mode
https://bugs.documentfoundation.org/show_bug.cgi?id=160680 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160918] FORMCONTROLS: Add ability to sort tab order by alphanumeric based on form control name
https://bugs.documentfoundation.org/show_bug.cgi?id=160918 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160912] Export an *.odt document towards a *.pdf file (source), containing at least one relative hyperlink \ URL pointing to another *.pdf file (target)
https://bugs.documentfoundation.org/show_bug.cgi?id=160912 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 150379] LO Ignoring some print trays from Konica Minolta c284e
https://bugs.documentfoundation.org/show_bug.cgi?id=150379 --- Comment #2 from QA Administrators --- Dear onyx, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 89588] .DOC file with password: I can draw into file without password
https://bugs.documentfoundation.org/show_bug.cgi?id=89588 --- Comment #7 from QA Administrators --- Dear raal, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 54743] [FORMATTING] Shift+F3 works unexpected (uppercase and lowercase)
https://bugs.documentfoundation.org/show_bug.cgi?id=54743 --- Comment #15 from QA Administrators --- Dear Kü, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 136727] Special Paste RTF for large table slowish
https://bugs.documentfoundation.org/show_bug.cgi?id=136727 --- Comment #9 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 46928] EDITING Insert Field Filename inserts Path+Filename instead of Filename
https://bugs.documentfoundation.org/show_bug.cgi?id=46928 --- Comment #16 from QA Administrators --- Dear Joachim Wilder, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 138749] Add function LAMBDA for interoperability with MS Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=138749 --- Comment #6 from Óvári --- Should ISOMITTED (IsOmitted) https://bettersolutions.com/excel/functions/isomitted-function.htm be added with LAMBDA, BYCOL (ByCol), BYROW (MyRow), MAKEARRAY (MakeArray), MAP, REDUCE, SCAN https://bettersolutions.com/excel/functions/lambda-functions.htm Thank you -- You are receiving this mail because: You are the assignee for the bug.
[Bug 145882] Edit button missing in LibreOffice Online
https://bugs.documentfoundation.org/show_bug.cgi?id=145882 Stéphane Guillou (stragu) changed: What|Removed |Added Resolution|FIXED |INSUFFICIENTDATA --- Comment #4 from Stéphane Guillou (stragu) --- Thanks for getting back to it! Fair enough, but let's close as "insufficient data" as "fixed" is for when we know of a patch that fixed the issue. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161143] Updated to version 24.2.3.2 (x86_64) and Calc autofilter format error when file re-opened to continue working on it
https://bugs.documentfoundation.org/show_bug.cgi?id=161143 --- Comment #4 from ady --- Was attachment 194181 created in LO? Or was this file created by some other tool instead? Was the file initially created using an ODS format? Or was it originally created with some other file format and then converted to ODS? Once those questions are answered... The next question is why in older versions there was no visual problem (e.g. LO 7.5). So, is this some modification in newer LO versions that is intentional and there is no solution other than having to modify the file? Or, instead, is this really a bug in newer LO versions? -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'feature/cib_contract57d' - 14 commits - configure.ac download.lst drawinglayer/source external/libtommath external/libxml2 external/libxslt filter/source helpcompiler/source include/
Rebased ref, commits from common ancestor:
commit cd6de67c3c9904b9eddb75693e3d094ec3a5c775
Author: Thorsten Behrens
AuthorDate: Fri May 17 15:08:38 2024 +0200
Commit: Thorsten Behrens
CommitDate: Sat May 18 00:55:31 2024 +0200
Release 6.3.6.30
Change-Id: Ibc748fa574e6e1c51cf831cb05bd74539a39f659
diff --git a/configure.ac b/configure.ac
index 60aeedba4c1b..4866a9848474 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
# several non-alphanumeric characters, those are split off and used only for
the
# ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no
idea.
-AC_INIT([LibreOffice],[6.3.6.29],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[6.3.6.30],[],[],[http://documentfoundation.org/])
dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just
fine if it is installed
dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails
hard
commit 6583a93ad2a6e9ff7d64d119a4da8c5c12cfc61d
Author: Caolán McNamara
AuthorDate: Thu Jan 4 17:00:06 2024 +
Commit: Thorsten Behrens
CommitDate: Sat May 18 00:55:30 2024 +0200
std::size/SAL_N_ELEMENTS also counts the null terminator
which libxml2 2.12 will fail on with error:
'Extra content at the end of the document'
Change-Id: I9d5da9fdd826cce8462ede8c510eaea7281b760f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161627
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
(cherry picked from commit cbb17a548b5cc6a99b6ed7735479bb4f2bc40f26)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161643
Reviewed-by: Xisco Fauli
diff --git a/unoxml/qa/unit/domtest.cxx b/unoxml/qa/unit/domtest.cxx
index 15e337772314..0129c85cfe4b 100644
--- a/unoxml/qa/unit/domtest.cxx
+++ b/unoxml/qa/unit/domtest.cxx
@@ -207,9 +207,9 @@ struct BasicTest : public test::BootstrapFixture
mxErrHandler.set( new ErrorHandler() );
uno::Reference xDB(
getMultiServiceFactory()->createInstance("com.sun.star.xml.dom.DocumentBuilder"),
uno::UNO_QUERY_THROW );
mxDomBuilder.set( xDB );
-mxValidInStream.set( new
SequenceInputStream(css::uno::Sequence(reinterpret_cast(validTestFile), SAL_N_ELEMENTS(validTestFile))) );
-mxWarningInStream.set( new
SequenceInputStream(css::uno::Sequence(reinterpret_cast(warningTestFile), SAL_N_ELEMENTS(warningTestFile))) );
-mxErrorInStream.set( new
SequenceInputStream(css::uno::Sequence(reinterpret_cast(errorTestFile), SAL_N_ELEMENTS(errorTestFile))) );
+mxValidInStream.set( new
SequenceInputStream(css::uno::Sequence(reinterpret_cast(validTestFile), SAL_N_ELEMENTS(validTestFile)-1)) );
+mxWarningInStream.set( new
SequenceInputStream(css::uno::Sequence(reinterpret_cast(warningTestFile), SAL_N_ELEMENTS(warningTestFile)-1)) );
+mxErrorInStream.set( new
SequenceInputStream(css::uno::Sequence(reinterpret_cast(errorTestFile), SAL_N_ELEMENTS(errorTestFile)-1)) );
mxDomBuilder->setErrorHandler(mxErrHandler.get());
}
@@ -293,7 +293,7 @@ struct SerializerTest : public test::BootstrapFixture
mxErrHandler.set( new ErrorHandler() );
uno::Reference xDB(
getMultiServiceFactory()->createInstance("com.sun.star.xml.dom.DocumentBuilder"),
uno::UNO_QUERY_THROW );
mxDomBuilder.set( xDB );
-mxInStream.set( new
SequenceInputStream(css::uno::Sequence(reinterpret_cast(validTestFile), SAL_N_ELEMENTS(validTestFile))) );
+mxInStream.set( new
SequenceInputStream(css::uno::Sequence(reinterpret_cast(validTestFile), SAL_N_ELEMENTS(validTestFile)-1)) );
mxDomBuilder->setErrorHandler(mxErrHandler.get());
mxHandler.set( new DocumentHandler );
mxTokHandler.set( new TokenHandler );
commit dd30c1add7b14c4da7b8fbea46aacf4ee2f50720
Author: Michael Stahl
AuthorDate: Fri Mar 8 13:40:44 2024 +0100
Commit: Thorsten Behrens
CommitDate: Sat May 18 00:55:30 2024 +0200
sal: the old MSVC doesn't know _Pragma, only __pragma
Change-Id: I139922d9cfabb3772782589f097234fd33e41809
diff --git a/include/sal/types.h b/include/sal/types.h
index f702708cff9c..d9aef75c1df8 100644
--- a/include/sal/types.h
+++ b/include/sal/types.h
@@ -497,10 +497,10 @@ template< typename T1, typename T2 > inline T1
static_int_cast(T2 n) {
_Pragma(SAL_STRINGIFY_ARG(GCC diagnostic pop))
#elif defined LIBO_INTERNAL_ONLY && defined _MSC_VER
#define SAL_WNODEPRECATED_DECLARATIONS_PUSH \
-_Pragma(SAL_STRINGIFY_ARG(warning(push))) \
-_Pragma(SAL_STRINGIFY_ARG(warning(disable : 4996)))
+__pragma(warning(push)) \
+__pragma(warning(disable : 4996))
#define SAL_WNODEPRECATED_DECLARATIONS_POP \
-_Pragma(SAL_STRINGIFY_ARG(warning(pop)))
+__pragma(warning(pop))
#else
# define SAL_WNODEPRECATED_DECLARATIONS_PUSH
# define SAL_WNODEPRECATED_DECLARATIONS_POP
commit 7087d79c9ae9769eb0f3bee12dd8c52e31b8eff4
[Bug 161076] Deleting row in one sheet moves background highlight in referenced sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=161076 ady changed: What|Removed |Added Keywords|dataLoss| --- Comment #7 from ady --- (In reply to ady from comment #6) > IMHO, this is not just a "normal" bug, as it can generate DATA LOSS, without > the user even being aware of such. Well, perhaps "Data Loss" is not the most adequate term in this case, but at least "formatting lost". -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161076] Deleting row in one sheet moves background highlight in referenced sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=161076 ady changed: What|Removed |Added Keywords||dataLoss CC||xiscofa...@libreoffice.org --- Comment #6 from ady --- IMHO, this is not just a "normal" bug, as it can generate DATA LOSS, without the user even being aware of such. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161061] [UI] Grid lines are visible on all cells when option 'Show on colored cells' is chosen
https://bugs.documentfoundation.org/show_bug.cgi?id=161061 --- Comment #8 from ady --- Possible improvement for consideration... Change the wording from: "Show on colored cells" to: "Show on colored cells too" While it is not perfect for users that don't know the meaning of it (nor to what other cells the "too" is referring), the change would avoid the potential (recurrent) confusion with "Show on colored cells only", which is not the intention of this setting (IIUC). -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161135] OOM Crash Skia Vulkan rendering dragging full LO appframe wider
https://bugs.documentfoundation.org/show_bug.cgi?id=161135 Julien Nabet changed: What|Removed |Added CC|serval2...@yahoo.fr | --- Comment #5 from Julien Nabet --- Can't help here=>uncc myself. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160783] Skia lib based Vulkan driver reporting issue, affect on GPU testing and deny listing
https://bugs.documentfoundation.org/show_bug.cgi?id=160783 Julien Nabet changed: What|Removed |Added CC|serval2...@yahoo.fr | --- Comment #19 from Julien Nabet --- No more interested in this one, too complicated (patch and what to do with deny list). -- You are receiving this mail because: You are the assignee for the bug.
[Bug 129179] UI Print dialog page sizes list has redundant items
https://bugs.documentfoundation.org/show_bug.cgi?id=129179 Adolfo Jayme Barrientos changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=16 | |0567| -- You are receiving this mail because: You are the assignee for the bug.
core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 028ac95c0e9991b59a835527b6fed2f8d3e2bddf Author: Dione Maddern AuthorDate: Sat May 18 00:34:40 2024 +0200 Commit: Gerrit Code Review CommitDate: Sat May 18 00:34:40 2024 +0200 Update git submodules * Update helpcontent2 from branch 'master' to d2649657002eeabbf686333faccd2b141d3bc9dc - tdf#161091 Document new bar-of-pie and pie-of-pie chart types In text/schart/01/type_pie.xhp: - Updated "How to get" section to include specific instruction on how to access the Pie chart type, instead of just the Chart Wizard. - Added a description for the Bar-of-pie and Pie-of-pie chart subtypes. Change-Id: I3b8e53abd5bfde03c2e266de4953e4e99bf68379 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167681 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/helpcontent2 b/helpcontent2 index 0d5b1a072e02..d2649657002e 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 0d5b1a072e025a692cee803310d2ceff0296b083 +Subproject commit d2649657002eeabbf686333faccd2b141d3bc9dc
help.git: source/text
source/text/schart/01/type_pie.xhp | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) New commits: commit d2649657002eeabbf686333faccd2b141d3bc9dc Author: Dione Maddern AuthorDate: Thu May 16 20:35:36 2024 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Sat May 18 00:34:39 2024 +0200 tdf#161091 Document new bar-of-pie and pie-of-pie chart types In text/schart/01/type_pie.xhp: - Updated "How to get" section to include specific instruction on how to access the Pie chart type, instead of just the Chart Wizard. - Added a description for the Bar-of-pie and Pie-of-pie chart subtypes. Change-Id: I3b8e53abd5bfde03c2e266de4953e4e99bf68379 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167681 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/source/text/schart/01/type_pie.xhp b/source/text/schart/01/type_pie.xhp index 6d607c25ae..d0800d048e 100644 --- a/source/text/schart/01/type_pie.xhp +++ b/source/text/schart/01/type_pie.xhp @@ -35,14 +35,22 @@ On the first page of the Chart Wizard you can choose a chart type. - + +Choose Insert - Chart - Chart Type - Pie + +Choose Insert - Chart - Chart Type - Pie + + +- then in the Chart Wizard choose Chart Type - Pie Pie A pie chart shows values as circular sectors of the total circle. The length of the arc, or the area of each sector, is proportional to its value. - Pie - this subtype shows sectors as colored areas of the total pie, for one data column only. In the created chart, you can click and drag any sector to separate that sector from the remaining pie or to join it back. - Exploded pie - this subtype shows the sectors already separated from each other. In the created chart, you can click and drag any sector to move it along a radial from the pie's center. - Donut - this subtype can show multiple data columns. Each data column is shown as one donut shape with a hole inside, where the next data column can be shown. In the created chart, you can click and drag an outer sector to move it along a radial from the donut's center. - Exploded donut - this subtype shows the outer sectors already separated from the remaining donut. In the created chart, you can click and drag an outer sector to move it along a radial from the donut's center. + Pie: This subtype shows sectors as colored areas of the total pie, for one data column only. In the created chart, you can click and drag any sector to separate that sector from the remaining pie or to join it back. + Exploded pie: This subtype shows the sectors already separated from each other. In the created chart, you can click and drag any sector to move it along a radial from the pie's center. + Donut: This subtype can show multiple data columns. Each data column is shown as one donut shape with a hole inside, where the next data column can be shown. In the created chart, you can click and drag an outer sector to move it along a radial from the donut's center. + Exploded donut: This subtype shows the outer sectors already separated from the remaining donut. In the created chart, you can click and drag an outer sector to move it along a radial from the donut's center. + Bar-of-pie: This subtype shows a pie chart on the left, with the last three entries in the data column aggregated as a "composite" sector. The composite sector is broken down in a bar chart on the right. + Pie-of-pie: This subtype shows a pie chart on the left, with the last three entries in the data column aggregated as a "composite" sector. The composite sector is displayed on the right as another pie chart.
[Bug 161048] Background processes are left opened by LO Dev on Windows since 2024.05.08
https://bugs.documentfoundation.org/show_bug.cgi?id=161048 --- Comment #17 from ady --- (In reply to m_a_riosv from comment #16) > I use https://dev-builds.libreoffice.org/si-gui/setup.exe to install > parallel versions, you can easily choose where to install, it also allows > you to select the version to download. > > There is also a Java version in the same folder, which works also on other > operating systems besides Windows. Thank you. I considered it at one point in the past. Since I am already performing my tests with msiexec "/a" as Stuart suggested (together with additional arguments), and considering other current factors related to SI-GUI, the result will be the same as I have already experienced. Important note (JIC): When LO Dev is still running, the processes in Task Manager are listed under the "Applications" Group (if TM is set to display the list with the "Group by type" view). Once I completely close LO Dev, the left-over processes are seen under the _background_ processes Group. The original processes/lines/rows under the aforementioned "Applications" Group are no longer present when LO Dev is closed. That means that the left-over processes (if there are such) are seen under the second Group in the list, not in the same place as the original "Applications" Group. Whoever attempts to reproduce the problem, please be sure that you are searching/looking for the left-over processes where they are supposed to be listed, not in the typical "Applications" Group in the Task Manager list. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157365] Options > LibreOffice Writer changes page color scheme from Dark to Light (steps in comment 2)
https://bugs.documentfoundation.org/show_bug.cgi?id=157365 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #7 from Julien Nabet --- Just for information, I reproduce this on pc Debian x86-64 with master sources updated today. I noticed that after setting Dark mode and opening any page, I get indeed white background BUT if I close LO and reopen it, background is dark. Then if I open any of the page from comment 2, the background stays dark. In the same way, if after all this, I put back light theme, it works but if I open any page as in comment 2, the background is dark again. Taking a look at the comment of Paris' patch, I'm not sure to understand what was the purpose. I mean either you want dark theme or you want light theme. But ok, let's say it might be useful to compare both look and feel (personally, I'd have used a screenshot but that's another story), when closing LO, what should be retained? The config of the last view closed? the config of first view opened? Other? -- You are receiving this mail because: You are the assignee for the bug.
core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0e40ccfa6749ab2fe86124a28e1ceee1462ba302 Author: László Németh AuthorDate: Sat May 18 00:12:07 2024 +0200 Commit: Gerrit Code Review CommitDate: Sat May 18 00:12:07 2024 +0200 Update git submodules * Update helpcontent2 from branch 'master' to 0d5b1a072e025a692cee803310d2ceff0296b083 - tdf#132599 add "Hyphenation across" -> Last full line of paragraph Document new option of LO 24.8 to control hyphenation in last full line of a paragraph. Fix also the changed IDs of the other "Hyphenation across" options. Follow-up to commit c8a99cb8dce54de506ba66d1cc0818b9b5f7858b "tdf#132599 sw schema xmloff: add hyphenation-keep-type='always'". Change-Id: If38c922c379506d3dc4a9c11cd428f7a28039b1d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167773 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/helpcontent2 b/helpcontent2 index 0672dfb42c29..0d5b1a072e02 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 0672dfb42c298cc3411bfb74b2eaf662427a4e4c +Subproject commit 0d5b1a072e025a692cee803310d2ceff0296b083
help.git: source/text
source/text/swriter/01/05030200.xhp | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) New commits: commit 0d5b1a072e025a692cee803310d2ceff0296b083 Author: László Németh AuthorDate: Fri May 17 13:22:41 2024 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Sat May 18 00:12:07 2024 +0200 tdf#132599 add "Hyphenation across" -> Last full line of paragraph Document new option of LO 24.8 to control hyphenation in last full line of a paragraph. Fix also the changed IDs of the other "Hyphenation across" options. Follow-up to commit c8a99cb8dce54de506ba66d1cc0818b9b5f7858b "tdf#132599 sw schema xmloff: add hyphenation-keep-type='always'". Change-Id: If38c922c379506d3dc4a9c11cd428f7a28039b1d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167773 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/source/text/swriter/01/05030200.xhp b/source/text/swriter/01/05030200.xhp index 6722ef29b4..38ef3df3ff 100644 --- a/source/text/swriter/01/05030200.xhp +++ b/source/text/swriter/01/05030200.xhp @@ -73,16 +73,19 @@ Hyphenate last word Hyphenate the last word of paragraphs. Disabling this feature prevents the creation of almost empty lines containing only half a word. Hyphenation across -Control hyphenation in the last line of a column, page or spread. - +Control hyphenation in the last line of a column, page or spread, and last full line of a paragraph, according to certain typographical rules to improve readability. + +Last full line of paragraph +Deselect this check box to prevent last full line of a paragraph from being hyphenated. The hyphenated word is moved to the next line if there is enough space for it. As a result, the last line of the paragraph becomes longer, reducing the blank space between paragraphs. + Column -Deselect this check box to prevent words from being hyphenated across a column or page. - +Deselect this check box to prevent words from being hyphenated across a column, linked frame or page. The hyphenated line is moved to the next column, frame or page. + Page -Deselect this check box to prevent words from being hyphenated across a page. - +Deselect this check box to prevent words from being hyphenated across a page. The hyphenated line is moved to the next page. + Spread -Deselect this check box to prevent words from being hyphenated across a spread. (A spread is a set of two pages that are visible to the reader at the same time.) +Deselect this check box to prevent words from being hyphenated across a spread. (A spread is a set of two pages that are visible to the reader at the same time.) The hyphenated line is moved to the next spread. Breaks Specify the page or column break options.
[Bug 161035] Spinning wheel hang on MacOS when using the Zotero plugin.
https://bugs.documentfoundation.org/show_bug.cgi?id=161035 --- Comment #23 from Peter N. Steinmetz --- Sorry, I guess I can't delete the prior comment, but I see the remark in the email about permissions. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161035] Spinning wheel hang on MacOS when using the Zotero plugin.
https://bugs.documentfoundation.org/show_bug.cgi?id=161035 --- Comment #22 from Peter N. Steinmetz --- Daily build for aarch64 is not working on my system so I can't test. I guess I will wait for 24.8.0. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161143] Updated to version 24.2.3.2 (x86_64) and Calc autofilter format error when file re-opened to continue working on it
https://bugs.documentfoundation.org/show_bug.cgi?id=161143 m_a_riosv changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161143] Updated to version 24.2.3.2 (x86_64) and Calc autofilter format error when file re-opened to continue working on it
https://bugs.documentfoundation.org/show_bug.cgi?id=161143 --- Comment #3 from m_a_riosv --- Even simplest, for the header cells, select them, click on background color button and click in No fill. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161143] Updated to version 24.2.3.2 (x86_64) and Calc autofilter format error when file re-opened to continue working on it
https://bugs.documentfoundation.org/show_bug.cgi?id=161143 --- Comment #2 from m_a_riosv --- Created attachment 194181 --> https://bugs.documentfoundation.org/attachment.cgi?id=194181=edit Sample from the reporter Please use this site to answer and attach files. The file has a format that shows in white those header fields. The default style has a green as background color, that makes their text showed in white. The text in first line have a default style with modifications. Editing Default style and put their background to none. For that first line, apply Default style, and set up the bold and the size you like. -- You are receiving this mail because: You are the assignee for the bug.
Build fail in mariadb on fedora 40
Hi, I'm getting: workdir/UnpackedTarball/mariadb-connector-c/libmariadb/ma_client_plugin.c:87:207: error: initialization of ‘struct st_mysql_client_plugin *’ from incompatible pointer type ‘struct st_mysql_client_plugin_AUTHENTICATION *’ [-Wincompatible-pointer-types] 87 |(struct st_mysql_client_plugin *)_socket_client_plugin, (struct st_mysql_client_plugin *)_sha2_password_client_plugin, (struct st_mysql_client_plugin *)_native_password_client_plugin, (struct st_mysql_client_plugin_AUTHENTICATION *)_gssapi_client_client_plugin, | ^ /discs/fast/core/workdir/UnpackedTarball/mariadb-connector-c/libmariadb/ma_client_plugin.c:87:207: note: (near initialization for ‘mysql_client_builtins[3]’) make[1]: *** [/discs/fast/core/solenv/gbuild/LinkTarget.mk:366: /discs/fast/core/workdir/GenCObject/UnpackedTarball/mariadb-connector-c/libmariadb/ma_client_plugin.o] Error 1 make[1]: *** Waiting for unfinished jobs make: *** [Makefile:294: build] Error 2 Host: Fedora 40, x86-64 configured with: ./configure --srcdir=/discs/fast/core --enable-option-checking=fatal --enable-debug using --with-system-mariadb fixed it. I originally filed this as: https://bugs.documentfoundation.org/show_bug.cgi?id=161141 However Ilmari pointed out that being a build bug it should be here. See the bug for my config.log. (cc'ing Julien since I see they did some stuff around there.) Dave -- -Open up your eyes, open up your mind, open up your code --- / Dr. David Alan Gilbert| Running GNU/Linux | Happy \ \dave @ treblig.org | | In Hex / \ _|_ http://www.treblig.org |___/
[Bug 161057] [24.8] Changing dark/light application colour scheme in Draw and Impress does not switch text colour anymore in text boxes
https://bugs.documentfoundation.org/show_bug.cgi?id=161057 Caolán McNamara changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |caolan.mcnamara@collabora.c |desktop.org |om --- Comment #4 from Caolán McNamara --- I think the font color is getting set in the DrawViewShell ctor, and while we are listening to the color configuration we aren't updating that font color, though we do update the background color -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161156] New: Scrollwheel Delay in LibreWriter on OpenBSD
https://bugs.documentfoundation.org/show_bug.cgi?id=161156 Bug ID: 161156 Summary: Scrollwheel Delay in LibreWriter on OpenBSD Product: LibreOffice Version: 24.2.1.2 release Hardware: x86-64 (AMD64) OS: OpenBSD Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: det...@dettus.net Description: For some reason, scrolling through the document does not work as expected. Whenever I am turning the scrollwheel, it takes a second or so before the view changes. Scrolling with the Keyboard seems to work as expected, so it is not REALLY serious. However, it is a nuisance. Steps to Reproduce: 1. Start a document 2. Make it longer than 3 pages 3. Scroll up and down. Actual Results: It. Takes. A. While. BeforeTheViewChanges. Expected Results: The Change should come instantaneously. Reproducible: Always User Profile Reset: No Additional Info: Version: 24.2.1.2 (X86_64) / LibreOffice Community Build ID: 420(Build:2) CPU threads: 16; OS: OpenBSD 7.5; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161133] Date field in Table Control's read-only column can be edited with date picker
https://bugs.documentfoundation.org/show_bug.cgi?id=161133 Caolán McNamara changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |caolan.mcnamara@collabora.c |desktop.org |om --- Comment #2 from Caolán McNamara --- https://gerrit.libreoffice.org/c/core/+/167802 should fix that -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'feature/cib_contract57d' - 31 commits - avmedia/source configure.ac dbaccess/source download.lst drawinglayer/source embeddedobj/source external/curl external/liblangtag external/lib
Rebased ref, commits from common ancestor:
commit 7e50a30160bbe8df1d03c03d6a0cd8c837f16269
Author: Caolán McNamara
AuthorDate: Thu Jan 4 17:00:06 2024 +
Commit: Thorsten Behrens
CommitDate: Fri May 17 21:50:26 2024 +0200
std::size/SAL_N_ELEMENTS also counts the null terminator
which libxml2 2.12 will fail on with error:
'Extra content at the end of the document'
Change-Id: I9d5da9fdd826cce8462ede8c510eaea7281b760f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161627
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
(cherry picked from commit cbb17a548b5cc6a99b6ed7735479bb4f2bc40f26)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161643
Reviewed-by: Xisco Fauli
diff --git a/unoxml/qa/unit/domtest.cxx b/unoxml/qa/unit/domtest.cxx
index 15e337772314..0129c85cfe4b 100644
--- a/unoxml/qa/unit/domtest.cxx
+++ b/unoxml/qa/unit/domtest.cxx
@@ -207,9 +207,9 @@ struct BasicTest : public test::BootstrapFixture
mxErrHandler.set( new ErrorHandler() );
uno::Reference xDB(
getMultiServiceFactory()->createInstance("com.sun.star.xml.dom.DocumentBuilder"),
uno::UNO_QUERY_THROW );
mxDomBuilder.set( xDB );
-mxValidInStream.set( new
SequenceInputStream(css::uno::Sequence(reinterpret_cast(validTestFile), SAL_N_ELEMENTS(validTestFile))) );
-mxWarningInStream.set( new
SequenceInputStream(css::uno::Sequence(reinterpret_cast(warningTestFile), SAL_N_ELEMENTS(warningTestFile))) );
-mxErrorInStream.set( new
SequenceInputStream(css::uno::Sequence(reinterpret_cast(errorTestFile), SAL_N_ELEMENTS(errorTestFile))) );
+mxValidInStream.set( new
SequenceInputStream(css::uno::Sequence(reinterpret_cast(validTestFile), SAL_N_ELEMENTS(validTestFile)-1)) );
+mxWarningInStream.set( new
SequenceInputStream(css::uno::Sequence(reinterpret_cast(warningTestFile), SAL_N_ELEMENTS(warningTestFile)-1)) );
+mxErrorInStream.set( new
SequenceInputStream(css::uno::Sequence(reinterpret_cast(errorTestFile), SAL_N_ELEMENTS(errorTestFile)-1)) );
mxDomBuilder->setErrorHandler(mxErrHandler.get());
}
@@ -293,7 +293,7 @@ struct SerializerTest : public test::BootstrapFixture
mxErrHandler.set( new ErrorHandler() );
uno::Reference xDB(
getMultiServiceFactory()->createInstance("com.sun.star.xml.dom.DocumentBuilder"),
uno::UNO_QUERY_THROW );
mxDomBuilder.set( xDB );
-mxInStream.set( new
SequenceInputStream(css::uno::Sequence(reinterpret_cast(validTestFile), SAL_N_ELEMENTS(validTestFile))) );
+mxInStream.set( new
SequenceInputStream(css::uno::Sequence(reinterpret_cast(validTestFile), SAL_N_ELEMENTS(validTestFile)-1)) );
mxDomBuilder->setErrorHandler(mxErrHandler.get());
mxHandler.set( new DocumentHandler );
mxTokHandler.set( new TokenHandler );
commit 231b80960c322389963a7e1d85f29b868ac7e4c2
Author: Michael Stahl
AuthorDate: Fri Mar 8 13:40:44 2024 +0100
Commit: Thorsten Behrens
CommitDate: Fri May 17 21:31:06 2024 +0200
sal: the old MSVC doesn't know _Pragma, only __pragma
Change-Id: I139922d9cfabb3772782589f097234fd33e41809
diff --git a/include/sal/types.h b/include/sal/types.h
index f702708cff9c..d9aef75c1df8 100644
--- a/include/sal/types.h
+++ b/include/sal/types.h
@@ -497,10 +497,10 @@ template< typename T1, typename T2 > inline T1
static_int_cast(T2 n) {
_Pragma(SAL_STRINGIFY_ARG(GCC diagnostic pop))
#elif defined LIBO_INTERNAL_ONLY && defined _MSC_VER
#define SAL_WNODEPRECATED_DECLARATIONS_PUSH \
-_Pragma(SAL_STRINGIFY_ARG(warning(push))) \
-_Pragma(SAL_STRINGIFY_ARG(warning(disable : 4996)))
+__pragma(warning(push)) \
+__pragma(warning(disable : 4996))
#define SAL_WNODEPRECATED_DECLARATIONS_POP \
-_Pragma(SAL_STRINGIFY_ARG(warning(pop)))
+__pragma(warning(pop))
#else
# define SAL_WNODEPRECATED_DECLARATIONS_PUSH
# define SAL_WNODEPRECATED_DECLARATIONS_POP
commit 293854f22b42ea35c9610101f5db7dce8a0ae949
Author: Mike Kaganski
AuthorDate: Wed Feb 21 22:27:37 2024 +0600
Commit: Thorsten Behrens
CommitDate: Fri May 17 21:30:36 2024 +0200
Implement SAL_WNODEPRECATED_DECLARATIONS_[PUSH/POP] on MSVC
Required for --disable-nss build on Windows, which needs the same fix as in
commit 71d4abc51b556e147ab53a9a52b15be36fc710a3
(-Werror,-Wdeprecated-declarations
(Emscripten), 2024-01-18).
Change-Id: I4206cbc0cb80be7ddee1c3f21de50d853828300e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163704
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
(cherry picked from commit 6329a56f601748f5a8dd6da9f0a90d3e57efcaf2)
diff --git a/include/sal/types.h b/include/sal/types.h
index e2442ea6c998..f702708cff9c 100644
--- a/include/sal/types.h
+++ b/include/sal/types.h
@@ -495,6 +495,12 @@ template< typename T1, typename T2 > inline T1
static_int_cast(T2 n) {
_Pragma(SAL_STRINGIFY_ARG(GCC diagnostic ignored
Re: Build fail in mariadb on fedora 40
On 17/05/2024 15:47, Dr. David Alan Gilbert wrote: Hi, I'm getting: workdir/UnpackedTarball/mariadb-connector-c/libmariadb/ma_client_plugin.c:87:207: error: initialization of ‘struct st_mysql_client_plugin *’ from incompatible pointer type ‘struct st_mysql_client_plugin_AUTHENTICATION *’ [-Wincompatible-pointer-types] 87 |(struct st_mysql_client_plugin *)_socket_client_plugin, (struct st_mysql_client_plugin *)_sha2_password_client_plugin, (struct st_mysql_client_plugin *)_native_password_client_plugin, (struct st_mysql_client_plugin_AUTHENTICATION *)_gssapi_client_client_plugin, | ^ /discs/fast/core/workdir/UnpackedTarball/mariadb-connector-c/libmariadb/ma_client_plugin.c:87:207: note: (near initialization for ‘mysql_client_builtins[3]’) make[1]: *** [/discs/fast/core/solenv/gbuild/LinkTarget.mk:366: /discs/fast/core/workdir/GenCObject/UnpackedTarball/mariadb-connector-c/libmariadb/ma_client_plugin.o] Error 1 make[1]: *** Waiting for unfinished jobs make: *** [Makefile:294: build] Error 2 Host: Fedora 40, x86-64 configured with: ./configure --srcdir=/discs/fast/core --enable-option-checking=fatal --enable-debug using --with-system-mariadb fixed it. Hello David, Sorry, I don't know why you encounter this :-( If it can help, here's the content of my autogen.input: CC=clang CXX=clang++ --enable-ld=lld --enable-online-update --enable-dbgutil --enable-evolution2 --enable-gtk4 --enable-qt5 --enable-kf5 --enable-gtk3-kde5 --enable-skia=debug --enable-ext-nlpsolver --enable-ext-numbertext --enable-ext-wiki-publisher --enable-dbus --enable-werror --enable-dependency-tracking --enable-python=fully-internal --without-system-mariadb --enable-bundle-mariadb --enable-symbols --enable-avahi --enable-eot --enable-odk --with-lang=en-US de es fr hu it ja nl pt pt-BR ru nb nn --with-myspell-dicts Julien
[Bug 105582] [META] Function wizard dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105582 Bug 105582 depends on bug 160835, which changed state. Bug 160835 Summary: Unclear meaning of "a basic total population" https://bugs.documentfoundation.org/show_bug.cgi?id=160835 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
core.git: sc/inc
sc/inc/scfuncs.hrc |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 8d16b7a9e6dad1c3590c74af3eee952bd8fc3284
Author: Rafael Lima
AuthorDate: Fri May 17 19:09:17 2024 +0200
Commit: Adolfo Jayme Barrientos
CommitDate: Fri May 17 21:57:15 2024 +0200
tdf#160835 Fix the use of "population" in Calc functions
Change-Id: If72058a34534dc477d07e9683c0d38d7169eecf1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167688
Tested-by: Adolfo Jayme Barrientos
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/sc/inc/scfuncs.hrc b/sc/inc/scfuncs.hrc
index d193625cd982..79348fed8e39 100644
--- a/sc/inc/scfuncs.hrc
+++ b/sc/inc/scfuncs.hrc
@@ -1757,7 +1757,7 @@ const TranslateId SC_OPCODE_VAR_A_ARY[] =
{
NC_("SC_OPCODE_VAR_A", "Returns the variance based on a sample. Text is
evaluated as zero."),
NC_("SC_OPCODE_VAR_A", "Value "),
-NC_("SC_OPCODE_VAR_A", "Value 1; value 2; ... are arguments representing a
sample taken from a basic total population.")
+NC_("SC_OPCODE_VAR_A", "Value 1; value 2; ... are arguments representing a
sample taken from the population.")
};
// -=*# Resource for function VARP #*=-
@@ -1805,7 +1805,7 @@ const TranslateId SC_OPCODE_ST_DEV_A_ARY[] =
{
NC_("SC_OPCODE_ST_DEV_A", "Returns the standard deviation based on a
sample. Text is evaluated as zero."),
NC_("SC_OPCODE_ST_DEV_A", "Value "),
-NC_("SC_OPCODE_ST_DEV_A", "Value 1; value 2; ... are arguments
representing a sample taken from a basic total population.")
+NC_("SC_OPCODE_ST_DEV_A", "Value 1; value 2; ... are arguments
representing a sample taken from the population.")
};
// -=*# Resource for function STDEVP #*=-
@@ -1845,7 +1845,7 @@ const TranslateId SC_OPCODE_AVERAGE_A_ARY[] =
{
NC_("SC_OPCODE_AVERAGE_A", "Returns the average value for a sample. Text
is evaluated as zero."),
NC_("SC_OPCODE_AVERAGE_A", "Value "),
-NC_("SC_OPCODE_AVERAGE_A", "Value 1; value 2; ... are arguments
representing a sample taken from a basic total population.")
+NC_("SC_OPCODE_AVERAGE_A", "Value 1; value 2; ... are arguments
representing a sample taken from the population.")
};
// -=*# Resource for function DEVSQ #*=-
[Bug 145882] Edit button missing in LibreOffice Online
https://bugs.documentfoundation.org/show_bug.cgi?id=145882 Christian Lampe changed: What|Removed |Added Resolution|--- |FIXED Status|NEEDINFO|RESOLVED --- Comment #3 from Christian Lampe --- As I moved to Sweden (and thus changed school) and no longer have access to IServ I cannot test if this bug still exists. So I'll close it now as it doesn't seem to have affected me more than that one time almost three years ago. And hey, maybe the admin just had misconfigured the server to disable edit mode and the button didn't show up for that reason? I don't know, has been a while since I talked to him. And to everyone reading this: have a nice day :) -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/source
sw/source/core/unocore/SwXTextDefaults.cxx | 16 +-
sw/source/core/unocore/swunohelper.cxx |6 -
sw/source/core/unocore/unobkm.cxx| 30 ++---
sw/source/core/unocore/unochart.cxx | 30 ++---
sw/source/core/unocore/unocoll.cxx | 50 -
sw/source/core/unocore/unocontentcontrol.cxx | 22 ++--
sw/source/core/unocore/unocrsrhelper.cxx | 20 +--
sw/source/core/unocore/unodraw.cxx | 40 +++
sw/source/core/unocore/unoevent.cxx |8 -
sw/source/core/unocore/unofield.cxx | 26 ++--
sw/source/core/unocore/unoflatpara.cxx | 10 -
sw/source/core/unocore/unoframe.cxx | 46
sw/source/core/unocore/unoftn.cxx|4
sw/source/core/unocore/unoidx.cxx| 46
sw/source/core/unocore/unolinebreak.cxx |6 -
sw/source/core/unocore/unoobj.cxx| 40 +++
sw/source/core/unocore/unoobj2.cxx | 62 +--
sw/source/core/unocore/unoparagraph.cxx | 28 ++---
sw/source/core/unocore/unoport.cxx | 24 ++--
sw/source/core/unocore/unoportenum.cxx |4
sw/source/core/unocore/unoredline.cxx|4
sw/source/core/unocore/unoredlines.cxx |4
sw/source/core/unocore/unorefmk.cxx | 58 +-
sw/source/core/unocore/unosect.cxx | 18 +--
sw/source/core/unocore/unosett.cxx | 48
sw/source/core/unocore/unosrch.cxx |4
sw/source/core/unocore/unostyle.cxx | 66 ++--
sw/source/core/unocore/unotbl.cxx| 148 +--
sw/source/core/unocore/unotext.cxx | 36 +++---
29 files changed, 453 insertions(+), 451 deletions(-)
New commits:
commit 359ae74cc138c59d18285cea301a7382da14668d
Author: Noel Grandin
AuthorDate: Fri May 17 12:42:04 2024 +0200
Commit: Noel Grandin
CommitDate: Fri May 17 21:38:42 2024 +0200
loplugin:ostr in sw/../unocore
Change-Id: Ibf48c1fcdc2ed53784bb73ca718d8f9886d983d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167769
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/core/unocore/SwXTextDefaults.cxx
b/sw/source/core/unocore/SwXTextDefaults.cxx
index f129eff219eb..66ea89e3d3f0 100644
--- a/sw/source/core/unocore/SwXTextDefaults.cxx
+++ b/sw/source/core/unocore/SwXTextDefaults.cxx
@@ -213,7 +213,7 @@ Any SAL_CALL SwXTextDefaults::getPropertyDefault( const
OUString& rPropertyName
OUString SAL_CALL SwXTextDefaults::getImplementationName( )
{
-return "SwXTextDefaults";
+return u"SwXTextDefaults"_ustr;
}
sal_Bool SAL_CALL SwXTextDefaults::supportsService( const OUString&
rServiceName )
@@ -223,13 +223,13 @@ sal_Bool SAL_CALL SwXTextDefaults::supportsService( const
OUString& rServiceName
uno::Sequence< OUString > SAL_CALL SwXTextDefaults::getSupportedServiceNames(
)
{
-return { "com.sun.star.text.Defaults",
- "com.sun.star.style.CharacterProperties",
- "com.sun.star.style.CharacterPropertiesAsian",
- "com.sun.star.style.CharacterPropertiesComplex",
- "com.sun.star.style.ParagraphProperties",
- "com.sun.star.style.ParagraphPropertiesAsian",
- "com.sun.star.style.ParagraphPropertiesComplex" };
+return { u"com.sun.star.text.Defaults"_ustr,
+ u"com.sun.star.style.CharacterProperties"_ustr,
+ u"com.sun.star.style.CharacterPropertiesAsian"_ustr,
+ u"com.sun.star.style.CharacterPropertiesComplex"_ustr,
+ u"com.sun.star.style.ParagraphProperties"_ustr,
+ u"com.sun.star.style.ParagraphPropertiesAsian"_ustr,
+ u"com.sun.star.style.ParagraphPropertiesComplex"_ustr };
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/unocore/swunohelper.cxx
b/sw/source/core/unocore/swunohelper.cxx
index 0aab2a681acf..b5b1d2adb36a 100644
--- a/sw/source/core/unocore/swunohelper.cxx
+++ b/sw/source/core/unocore/swunohelper.cxx
@@ -64,7 +64,7 @@ bool UCB_DeleteFile( const OUString& rURL )
ucbhelper::Content aTempContent( rURL,
css::uno::Reference<
css::ucb::XCommandEnvironment >(),
comphelper::getProcessComponentContext() );
-aTempContent.executeCommand("delete", css::uno::Any( true ) );
+aTempContent.executeCommand(u"delete"_ustr, css::uno::Any( true ) );
bRemoved = true;
}
catch( css::uno::Exception& )
@@ -94,7 +94,7 @@ bool UCB_MoveFile( const OUString& rURL, std::u16string_view
rNewURL )
aInfo.NewTitle = sName;
aInfo.SourceURL = rURL;
aInfo.MoveData = true;
-aTempContent.executeCommand( "transfer", uno::Any(aInfo) );
+aTempContent.executeCommand( u"transfer"_ustr, uno::Any(aInfo) );
}
catch( css::uno::Exception& )
{
@@ -138,7 +138,7 @@ bool
[Bug 90825] Cannot remove trend line entry from the legend (without removing series legend)
https://bugs.documentfoundation.org/show_bug.cgi?id=90825 Mihai Vasiliu changed: What|Removed |Added CC||mihai.vasiliu...@gmail.com --- Comment #5 from Mihai Vasiliu --- I am too interested in this enhancement. I would like to keep a one legend entry for both the line and the trend line, but not both entries, while keeping both lines shown. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 108697] New default set of bullet characters
https://bugs.documentfoundation.org/show_bug.cgi?id=108697 --- Comment #25 from V Stuart Foote --- (In reply to Heiko Tietze from comment #24) > (In reply to V Stuart Foote from comment #22) > > The typographic hyphen "-" U+002D HYPHEN-MINUS was only bcz OpenSymbol does > > not cover it. The "‐" U+2010 HYPHEN would be fine if we move outside > > OpenSymbol. > True, most of the glyphs in my comment 21 are not covered by OpenSymbol. > However, why do we need a hyphen (U+002D) and the EN-dash (U+2013)? We could > add the left-ward pointing arrow (U+2190) instead of the simple hyphen for > the RTL folks. > IIRC there have been statements that the hyphen/en-dash was an *expected* stylistic bullet format in some EU locales. I know it was requested. > And a small and big circular bullet seems to be a bit redundant. Perhaps > replace U+2022 with the hand-pointer (U+E205)? No can do, U+E205 is a PUA glyph, so would be the glyph at U+261E. Also should reverse U+261C for bullet lists in RTL locales But I do think there is some slot sequence of the bullets to consider when used in 1-10 level lists/outlines. Why I'd thought to leave the small/large alone. And why the tooltips for each quick pick slot also will need to be adjusted (couldn't find them in source though). -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161153] Inserting tashdid (a.k.a. shaddah) character (Unicode 0651) breaks or distorts Persian text
https://bugs.documentfoundation.org/show_bug.cgi?id=161153 --- Comment #5 from arham.amo...@gmail.com --- When I change the font of the same document to "Noto Sans Arabic" in Ubuntu, the tashdid character is always displayed perfectly. So this seems to be a font-dependent issue. -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'distro/collabora/co-23.05' - desktop/source
desktop/source/lib/init.cxx | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
New commits:
commit eb08961598c52ad236980023149a0907f23525d7
Author: Michael Meeks
AuthorDate: Fri May 17 17:49:32 2024 +0100
Commit: Noel Grandin
CommitDate: Fri May 17 20:42:58 2024 +0200
lok: stop amazing waste of pretty-printed JSON sent over the API.
before:
INCOMING: commandvalues: {
"commandName": ".uno:CharFontName",
"commandValues": {
"Albany AMT": [
"6",
"7",
"8",
"9",
"10",
"10.5",
"11",
"12",
after:
INCOMING: commandvalues: {"commandName":".uno:CharFontName","commandValues":
{"Albany AMT":["6","7","8","9","10","10.5","11","12","13","14","15","16",
"18","20","21","22","24","26","28","32","36","40","42","44","48","54",
"60","66","72","80","88","96"],"Amiri":["6","7"
A 3x size saving.
Change-Id: I574b8bdf790078c61b7605137a47a531dee16f1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167686
Reviewed-by: Noel Grandin
Tested-by: Jenkins CollaboraOffice
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 81366621ec15..dec02b7c3103 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -5959,7 +5959,7 @@ static char* getDocReadOnly(LibreOfficeKitDocument* pThis)
aTree.put("success", pObjectShell->IsLoadReadonly());
std::stringstream aStream;
-boost::property_tree::write_json(aStream, aTree);
+boost::property_tree::write_json(aStream, aTree, false /* pretty */);
char* pJson = static_cast(malloc(aStream.str().size() + 1));
if (!pJson)
return nullptr;
@@ -6006,7 +6006,7 @@ static char* getLanguages(const char* pCommand)
addLocale(aValues, rLocale);
aTree.add_child("commandValues", aValues);
std::stringstream aStream;
-boost::property_tree::write_json(aStream, aTree);
+boost::property_tree::write_json(aStream, aTree, false /* pretty */);
char* pJson = static_cast(malloc(aStream.str().size() + 1));
assert(pJson); // Don't handle OOM conditions
strcpy(pJson, aStream.str().c_str());
@@ -6047,7 +6047,7 @@ static char* getFonts (const char* pCommand)
}
aTree.add_child("commandValues", aValues);
std::stringstream aStream;
-boost::property_tree::write_json(aStream, aTree);
+boost::property_tree::write_json(aStream, aTree, false /* pretty */);
char* pJson = static_cast(malloc(aStream.str().size() + 1));
assert(pJson); // Don't handle OOM conditions
strcpy(pJson, aStream.str().c_str());
@@ -6082,7 +6082,7 @@ static char* getFontSubset (std::string_view aFontName)
aTree.add_child("commandValues", aValues);
std::stringstream aStream;
-boost::property_tree::write_json(aStream, aTree);
+boost::property_tree::write_json(aStream, aTree, false /* pretty */);
char* pJson = static_cast(malloc(aStream.str().size() + 1));
assert(pJson); // Don't handle OOM conditions
strcpy(pJson, aStream.str().c_str());
@@ -6205,7 +6205,7 @@ static char* getStyles(LibreOfficeKitDocument* pThis,
const char* pCommand)
aTree.add_child("commandValues", aValues);
std::stringstream aStream;
-boost::property_tree::write_json(aStream, aTree);
+boost::property_tree::write_json(aStream, aTree, false /* pretty */);
char* pJson = static_cast(malloc(aStream.str().size() + 1));
assert(pJson); // Don't handle OOM conditions
strcpy(pJson, aStream.str().c_str());
core.git: sd/source
sd/source/ui/dlg/tpoption.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1b0686234cc72f562ec5ec695c4594894838a46e Author: Caolán McNamara AuthorDate: Fri May 17 19:41:32 2024 +0100 Commit: Caolán McNamara CommitDate: Fri May 17 20:42:29 2024 +0200 WaE: C6011 Dereferencing NULL pointer warnings Change-Id: I92ff04181d3c4ec4f0e1cd9f63ce5a1dc869ffc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167797 Tested-by: Caolán McNamara Reviewed-by: Caolán McNamara diff --git a/sd/source/ui/dlg/tpoption.cxx b/sd/source/ui/dlg/tpoption.cxx index fdd199f6a7d5..823baef412c8 100644 --- a/sd/source/ui/dlg/tpoption.cxx +++ b/sd/source/ui/dlg/tpoption.cxx @@ -416,7 +416,7 @@ SdTpOptionsMisc::SdTpOptionsMisc(weld::Container* pPage, weld::DialogController* // determine PoolUnit SfxItemPool* pPool = rInAttrs.GetPool(); -DBG_ASSERT( pPool, "Where is the Pool?" ); +assert(pPool && "Where is the Pool?"); ePoolUnit = pPool->GetMetric( SID_ATTR_FILL_HATCH ); // Fill the CB
core.git: Branch 'distro/collabora/co-24.04' - desktop/source
desktop/source/lib/init.cxx | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
New commits:
commit 457f24c004590a28d200fdda79bf468d363fff69
Author: Michael Meeks
AuthorDate: Fri May 17 17:49:32 2024 +0100
Commit: Noel Grandin
CommitDate: Fri May 17 20:42:26 2024 +0200
lok: stop amazing waste of pretty-printed JSON sent over the API.
before:
INCOMING: commandvalues: {
"commandName": ".uno:CharFontName",
"commandValues": {
"Albany AMT": [
"6",
"7",
"8",
"9",
"10",
"10.5",
"11",
"12",
after:
INCOMING: commandvalues: {"commandName":".uno:CharFontName","commandValues":
{"Albany AMT":["6","7","8","9","10","10.5","11","12","13","14","15","16",
"18","20","21","22","24","26","28","32","36","40","42","44","48","54",
"60","66","72","80","88","96"],"Amiri":["6","7"
A 3x size saving.
Change-Id: I574b8bdf790078c61b7605137a47a531dee16f1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167789
Reviewed-by: Noel Grandin
Tested-by: Jenkins CollaboraOffice
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 298d15b4ddf6..9608c5374da7 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -6013,7 +6013,7 @@ static char* getDocReadOnly(LibreOfficeKitDocument* pThis)
aTree.put("success", pObjectShell->IsLoadReadonly());
std::stringstream aStream;
-boost::property_tree::write_json(aStream, aTree);
+boost::property_tree::write_json(aStream, aTree, false /* pretty */);
char* pJson = static_cast(malloc(aStream.str().size() + 1));
if (!pJson)
return nullptr;
@@ -6072,7 +6072,7 @@ static char* getLanguages(const char* pCommand)
addLocale(aValues, rLocale);
aTree.add_child("commandValues", aValues);
std::stringstream aStream;
-boost::property_tree::write_json(aStream, aTree);
+boost::property_tree::write_json(aStream, aTree, false /* pretty */);
char* pJson = static_cast(malloc(aStream.str().size() + 1));
assert(pJson); // Don't handle OOM conditions
strcpy(pJson, aStream.str().c_str());
@@ -6113,7 +6113,7 @@ static char* getFonts (const char* pCommand)
}
aTree.add_child("commandValues", aValues);
std::stringstream aStream;
-boost::property_tree::write_json(aStream, aTree);
+boost::property_tree::write_json(aStream, aTree, false /* pretty */);
char* pJson = static_cast(malloc(aStream.str().size() + 1));
assert(pJson); // Don't handle OOM conditions
strcpy(pJson, aStream.str().c_str());
@@ -6148,7 +6148,7 @@ static char* getFontSubset (std::string_view aFontName)
aTree.add_child("commandValues", aValues);
std::stringstream aStream;
-boost::property_tree::write_json(aStream, aTree);
+boost::property_tree::write_json(aStream, aTree, false /* pretty */);
char* pJson = static_cast(malloc(aStream.str().size() + 1));
assert(pJson); // Don't handle OOM conditions
strcpy(pJson, aStream.str().c_str());
@@ -6271,7 +6271,7 @@ static char* getStyles(LibreOfficeKitDocument* pThis,
const char* pCommand)
aTree.add_child("commandValues", aValues);
std::stringstream aStream;
-boost::property_tree::write_json(aStream, aTree);
+boost::property_tree::write_json(aStream, aTree, false /* pretty */);
char* pJson = static_cast(malloc(aStream.str().size() + 1));
assert(pJson); // Don't handle OOM conditions
strcpy(pJson, aStream.str().c_str());
[Bug 161155] New: flag when paging through sheets & the first/last sheet is passed +pageUP/pageDOWN
https://bugs.documentfoundation.org/show_bug.cgi?id=161155 Bug ID: 161155 Summary: flag when paging through sheets & the first/last sheet is passed +pageUP/pageDOWN Product: LibreOffice Version: 24.2.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: traceyad2...@gmail.com I noticed that when I am paging through sheets, that when I get to the beginning or end it just loops around (this is GOOD!). However, when I am paging through sheets I am NOT watching the tabs but I am watching the contents of the sheets. I would like to be notified by a (bell / ding) that I am passing the end or the beginning and looping around again. Thanks, Tracey -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161078] Allow direct formatting for page sequences instead of editing the style
https://bugs.documentfoundation.org/show_bug.cgi?id=161078 --- Comment #24 from Telesto --- (In reply to Eyal Rozenberg from comment #22) > (In reply to Telesto from comment #21) > > Given what you've said, why did you mark this WONTFIX? Unintentionally. The status was WONTFIX at the point writing the message. The status changed at the point of posting the message. I got there is a conflict, but opted for post anyway. > > > Apparently others can work with it... > > Or give up on LibreOffice and go back to MSO ? A) I'm not a heavy Office Suite user at this point in time. More a simple home user B) I'm still in the 'testing phase' for LibreOffice. An Office suite is primary a tool to make myself productive. I will use MSO if I can't get the desired result or only - in my perception - with disproportional effort (including workarounds) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161144] Query wizard confuses columns with the same name in different tables
https://bugs.documentfoundation.org/show_bug.cgi?id=161144 Buovjaga changed: What|Removed |Added Ever confirmed|0 |1 CC|ilmari.lauhakangas@libreoff | |ice.org | Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
3 new defect(s) introduced to LibreOffice found with Coverity Scan.
5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 1598237: Error handling issues (UNCAUGHT_EXCEPT)
/canvas/workben/canvasdemo.cxx: 608 in ::DemoApp::Main()()
*** CID 1598237: Error handling issues (UNCAUGHT_EXCEPT)
/canvas/workben/canvasdemo.cxx: 608 in ::DemoApp::Main()()
602 void Init() override;
603 void DeInit() override;
604 };
605
606 }
607
>>> CID 1598237: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "::DemoApp::Main()" an exception of type
>>> "com::sun::star::uno::DeploymentException" is thrown and never caught.
608 int DemoApp::Main()
609 {
610 bool bHelp = false;
611
612 for( unsigned int i = 0; i < GetCommandLineParamCount(); i++ )
613 {
** CID 1598236: Error handling issues (CHECKED_RETURN)
/sw/source/uibase/app/apphdl.cxx: 417 in
::SwMailMergeWizardExecutor::ExecuteMailMergeWizard(const SfxItemSet
*)()
*** CID 1598236: Error handling issues (CHECKED_RETURN)
/sw/source/uibase/app/apphdl.cxx: 417 in
::SwMailMergeWizardExecutor::ExecuteMailMergeWizard(const SfxItemSet
*)()
411 using namespace org::freedesktop::PackageKit;
412 using namespace svtools;
413 css::uno::Reference< XSyncDbusSessionHelper >
xSyncDbusSessionHelper(SyncDbusSessionHelper::create(comphelper::getProcessComponentContext()));
414 const css::uno::Sequence< OUString > vPackages{
"libreoffice-base" };
415 xSyncDbusSessionHelper->InstallPackageNames(vPackages,
OUString());
416 SolarMutexGuard aGuard;
>>> CID 1598236: Error handling issues (CHECKED_RETURN)
>>> Calling "executeRestartDialog" without checking return value (as is
>>> done elsewhere 6 out of 7 times).
417
executeRestartDialog(comphelper::getProcessComponentContext(), nullptr,
RESTART_REASON_MAILMERGE_INSTALL);
418 }
419 catch (const css::uno::Exception &)
420 {
421 TOOLS_INFO_EXCEPTION(
422 "sw.core",
** CID 1598235: Uninitialized members (UNINIT_CTOR)
/sd/source/ui/framework/module/NotesPaneModule.cxx: 45 in
sd::framework::NotesPaneModule::NotesPaneModule(const
rtl::Reference &)()
*** CID 1598235: Uninitialized members (UNINIT_CTOR)
/sd/source/ui/framework/module/NotesPaneModule.cxx: 45 in
sd::framework::NotesPaneModule::NotesPaneModule(const
rtl::Reference &)()
39 NotesPaneModule::NotesPaneModule(const
rtl::Reference<::sd::DrawController>& rxController)
40 : mxBottomImpressPaneId(FrameworkHelper::CreateResourceId(
41 FrameworkHelper::msNotesPanelViewURL,
FrameworkHelper::msBottomImpressPaneURL))
42 ,
mxMainViewAnchorId(FrameworkHelper::CreateResourceId(FrameworkHelper::msCenterPaneURL))
43 {
44 if (!rxController.is())
>>> CID 1598235: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "mpViewShellBase" is not initialized in this
>>> constructor nor in any functions that it calls.
45 return;
46
47 mpViewShellBase = rxController->GetViewShellBase();
48
49 mxConfigurationController =
rxController->getConfigurationController();
50 if (!mxConfigurationController.is())
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DUNj__A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGt2K6Hw1GZzA8I67sWF7NG-2BWh2ziA0r8iMXl5wP1qzlfk0Dfqxvgy-2FkqoVaqRqr41NGqxPEjODcl0dG35QNb05uV-2Bnp1CQtO-2B-2BhlHqfXVc8i6Kdeb6DZDPH7nawi1mFkZK9c4xfec5YCSIaJZlPEKtGzv-2BF3fRk2xfl6wFahW9qXc-3D
core.git: Branch 'distro/collabora/co-24.04' - 26 commits - dbaccess/source download.lst forms/source framework/source officecfg/registry readlicense_oo/license sal/rtl sc/Library_vbaobj.mk sc/source
dbaccess/source/ui/relationdesign/RTableConnection.cxx|2 download.lst |8 forms/source/richtext/parametrizedattributedispatcher.cxx | 14 forms/source/richtext/parametrizedattributedispatcher.hxx |6 forms/source/richtext/specialdispatchers.cxx | 14 forms/source/richtext/specialdispatchers.hxx |2 framework/source/uielement/menubarmanager.cxx | 11 officecfg/registry/data/org/openoffice/Office/Paths.xcu |5 readlicense_oo/license/CREDITS.fodt | 2026 +++--- sal/rtl/strtmpl.hxx |5 sc/Library_vbaobj.mk |1 sc/source/ui/app/transobj.cxx | 31 sd/qa/unit/PNGExportTests.cxx |8 solenv/gbuild/Rdb.mk |1 svx/source/dialog/framelinkarray.cxx |8 sw/qa/core/layout/calcmove.cxx| 24 sw/qa/core/layout/data/ignore-top-margin-fly.odt |binary sw/qa/extras/uiwriter/data/tdf160842.fodt | 75 sw/qa/extras/uiwriter/uiwriter6.cxx | 157 + sw/qa/extras/unowriter/data/tdf161035.fodt|9 sw/qa/extras/unowriter/unowriter.cxx | 27 sw/source/core/access/accfrmobj.cxx | 15 sw/source/core/doc/docdraw.cxx| 12 sw/source/core/draw/dview.cxx | 129 sw/source/core/frmedt/fecopy.cxx | 25 sw/source/core/frmedt/fefly1.cxx | 13 sw/source/core/frmedt/feshview.cxx| 59 sw/source/core/layout/anchoreddrawobject.cxx |4 sw/source/core/layout/anchoredobject.cxx | 11 sw/source/core/layout/calcmove.cxx|6 sw/source/core/layout/fly.cxx |4 sw/source/core/layout/flylay.cxx | 41 sw/source/core/layout/frmtool.cxx | 40 sw/source/core/layout/pagechg.cxx | 19 sw/source/core/layout/trvlfrm.cxx | 39 sw/source/core/txtnode/atrflyin.cxx |3 sw/source/core/undo/undraw.cxx| 31 sw/source/core/unocore/unoportenum.cxx|4 sw/source/uibase/docvw/edtwin.cxx | 10 sw/source/uibase/uiview/viewtab.cxx |2 sw/source/uibase/utlui/content.cxx|2 vcl/osx/salinst.cxx | 17 vcl/skia/gdiimpl.cxx | 20 vcl/source/filter/igif/gifread.cxx| 36 vcl/unx/gtk3/hudawareness.cxx |2 45 files changed, 1752 insertions(+), 1226 deletions(-) New commits: commit f12e69cc4ccbc02ebb920dd9788b9273f8b8bdf8 Author: Noel Grandin AuthorDate: Tue May 14 09:08:16 2024 +0200 Commit: Andras Timar CommitDate: Fri May 17 19:57:46 2024 +0200 tdf#161019 tdf#159846 spreadsheet border rendering regression from commit e27d4cc31e04be4c47b5085dfa2363ee45457e8a Author: Noel Grandin Date: Mon Jun 19 12:23:55 2023 +0200 tdf#150534 reduce the memory consumption of cells when calculating Change-Id: Id8b52a3a0880bbb6a7aff28f55bcd57cb1cae048 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167617 Tested-by: Jenkins Reviewed-by: Noel Grandin (cherry picked from commit 6f8a73a379d97829080367b21d54f9b5fab781c9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167682 Reviewed-by: Xisco Fauli diff --git a/svx/source/dialog/framelinkarray.cxx b/svx/source/dialog/framelinkarray.cxx index fa5829438698..897012611151 100644 --- a/svx/source/dialog/framelinkarray.cxx +++ b/svx/source/dialog/framelinkarray.cxx @@ -936,7 +936,7 @@ void Array::SetAddMergedLeftSize( sal_Int32 nCol, sal_Int32 nRow, sal_Int32 nAdd return; Cell aTempCell(*pTempCell); aTempCell.mnAddLeft = nAddSize; -mxImpl->PutCell( nCol, nRow, aTempCell ); +mxImpl->PutCell( aIt.Col(), aIt.Row(), aTempCell ); } } @@ -951,7 +951,7 @@ void Array::SetAddMergedRightSize( sal_Int32 nCol, sal_Int32 nRow, sal_Int32 nAd return; Cell aTempCell(*pTempCell); aTempCell.mnAddRight = nAddSize; -mxImpl->PutCell( nCol, nRow, aTempCell ); +mxImpl->PutCell( aIt.Col(), aIt.Row(), aTempCell ); } } @@ -966,7 +966,7 @@ void Array::SetAddMergedTopSize( sal_Int32 nCol, sal_Int32 nRow, sal_Int32 nAddS return; Cell aTempCell(*pTempCell); aTempCell.mnAddTop = nAddSize; -
[Bug 108663] [META] AutoText bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108663 Bug 108663 depends on bug 161137, which changed state. Bug 161137 Summary: Inserting autotext converts style into direct formatting https://bugs.documentfoundation.org/show_bug.cgi?id=161137 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161137] Inserting autotext converts style into direct formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=161137 Michael Stahl (allotropia) changed: What|Removed |Added Resolution|--- |FIXED CC||michael.st...@allotropia.de Status|UNCONFIRMED |RESOLVED Assignee|libreoffice-b...@lists.free |michael.st...@allotropia.de |desktop.org | --- Comment #7 from Michael Stahl (allotropia) --- should be fixed on master -- You are receiving this mail because: You are the assignee for the bug.
[Bug 148041] Clicking text will make line spacing change for no reason in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=148041 Rafael Lima changed: What|Removed |Added CC||mikekagan...@hotmail.com --- Comment #9 from Rafael Lima --- Hi Mike, I noticed you've been working on some text rendering bugs. Do you have any idea what might be happening here? This bug is still happening for me... it seems like a miscalculation of the text size. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161137] Inserting autotext converts style into direct formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=161137 --- Comment #6 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2bcaa374ea418cd81f9dbf62cd7e896f5977992a tdf#161137 sw: AutoText or Paste should copy paragraph indents for lists It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/inc sw/qa sw/source
sw/inc/doc.hxx |8 +-
sw/qa/extras/uiwriter/uiwriter8.cxx | 46 -
sw/source/core/doc/DocumentContentOperationsManager.cxx | 11 ++-
sw/source/core/doc/docnum.cxx | 55 +++-
4 files changed, 109 insertions(+), 11 deletions(-)
New commits:
commit 2bcaa374ea418cd81f9dbf62cd7e896f5977992a
Author: Michael Stahl
AuthorDate: Fri May 17 13:58:41 2024 +0200
Commit: Michael Stahl
CommitDate: Fri May 17 19:24:29 2024 +0200
tdf#161137 sw: AutoText or Paste should copy paragraph indents for lists
The first commit made the start and end node of the paste look like the
list it was inserted into, but the middle nodes may have different
paragraph styles and may have different left margin / first line indent.
In addition to the SwNumRule, also copy any left margin or first line
indent if it is effective on the node that the SwNumRule was taken from.
Now all the list labels should be in the same place.
Change-Id: Ia5794687ea0ff542f23289b1ca63ea99dae85bc3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/16
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sw/inc/doc.hxx b/sw/inc/doc.hxx
index 659af3ba1e91..b1b68bec2dba 100644
--- a/sw/inc/doc.hxx
+++ b/sw/inc/doc.hxx
@@ -1073,7 +1073,9 @@ public:
const SwNumRule&,
SetNumRuleMode mode,
SwRootFrame const* pLayout = nullptr,
- const OUString& sContinuedListId = OUString());
+ const OUString& sContinuedListId = OUString(),
+ SvxTextLeftMarginItem const* pTextLeftMarginToPropagate =
nullptr,
+ SvxFirstLineIndentItem const* pFirstLineIndentToPropagate
= nullptr);
void SetCounted(const SwPaM&, bool bCounted, SwRootFrame const* pLayout);
void MakeUniqueNumRules(const SwPaM & rPaM);
@@ -1151,7 +1153,9 @@ public:
int nNonEmptyAllowed,
OUString& sListId,
SwRootFrame const* pLayout,
-const bool bInvestigateStartNode = false );
+const bool bInvestigateStartNode = false,
+SvxTextLeftMarginItem const**
o_ppTextLeftMargin = nullptr,
+SvxFirstLineIndentItem const**
o_ppFirstLineIndent = nullptr);
// Paragraphs without numbering but with indents.
bool NoNum( const SwPaM& );
diff --git a/sw/qa/extras/uiwriter/uiwriter8.cxx
b/sw/qa/extras/uiwriter/uiwriter8.cxx
index 2ff8bc3472b6..e1924b16a512 100644
--- a/sw/qa/extras/uiwriter/uiwriter8.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter8.cxx
@@ -25,6 +25,7 @@
#include
#include
#include
+#include
#include
#include
@@ -877,7 +878,7 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest8,
testInsertAutoTextIntoListFromParaStyle)
pWrtShell->FwdPara();
pWrtShell->EndPara(/*bSelect=*/false);
// expands autotext (via F3)
-pWrtShell->Insert(" dt");
+pWrtShell->Insert(" jacr");
SwXTextDocument* pTextDoc =
dynamic_cast(mxComponent.get());
pTextDoc->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, KEY_F3);
@@ -886,6 +887,10 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest8,
testInsertAutoTextIntoListFromParaStyle)
pWrtShell->SttEndDoc(/*bStt=*/true);
pWrtShell->FwdPara();
+SwNumRule* pNumRule;
+SvxTextLeftMarginItem const* pTextLeftMargin;
+SvxFirstLineIndentItem const* pFirstLineIndent;
+
{
SwTextNode& rNode{
*pWrtShell->GetCursor()->GetPoint()->GetNode().GetTextNode() };
// numrule from paragraph style, but not from direct formatting
@@ -902,7 +907,32 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest8,
testInsertAutoTextIntoListFromParaStyle)
CPPUNIT_ASSERT_EQUAL(SfxItemState::DEFAULT,
pSet->GetItemState(RES_MARGIN_TEXTLEFT, false));
CPPUNIT_ASSERT_EQUAL(SfxItemState::SET,
pSet->GetItemState(RES_MARGIN_TEXTLEFT, true));
CPPUNIT_ASSERT_EQUAL(u"ListAndIndents"_ustr,
rNode.GetTextColl()->GetName());
-CPPUNIT_ASSERT(rNode.GetText().startsWith("Item He heard quiet
steps"));
+CPPUNIT_ASSERT_EQUAL(u"Item We confirm receipt of your application
material."_ustr,
+ rNode.GetText());
+pNumRule = rNode.GetNumRule();
+pTextLeftMargin = (RES_MARGIN_TEXTLEFT);
+pFirstLineIndent = (RES_MARGIN_FIRSTLINE);
+}
+
+pWrtShell->FwdPara();
+
+{
+SwTextNode& rNode{
*pWrtShell->GetCursor()->GetPoint()->GetNode().GetTextNode() };
+auto pSet{ rNode.GetpSwAttrSet() };
+CPPUNIT_ASSERT(pSet);
+// list id was set
+CPPUNIT_ASSERT_EQUAL(SfxItemState::SET,
pSet->GetItemState(RES_PARATR_LIST_ID, false));
+// middle paragraph was pasted - has numrule and
[Bug 161137] Inserting autotext converts style into direct formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=161137 --- Comment #5 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7698f386413e514a4478a1af69a8a3be93dfecab tdf#161137 sw: fix AutoText or Paste overriding paragraph indents It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/inc sw/qa sw/source
sw/inc/doc.hxx | 26 +-
sw/qa/extras/uiwriter/data/stylewithlistandindents.fodt | 182
sw/qa/extras/uiwriter/uiwriter8.cxx | 81 +++
sw/source/core/doc/DocumentContentOperationsManager.cxx |7
sw/source/core/doc/docnum.cxx | 47 ++--
sw/source/core/edit/autofmt.cxx |2
sw/source/core/edit/ednumber.cxx| 12 -
sw/source/core/undo/unnum.cxx |4
sw/source/core/unocore/unocrsrhelper.cxx|8
sw/source/filter/basflt/fltshell.cxx|2
10 files changed, 332 insertions(+), 39 deletions(-)
New commits:
commit 7698f386413e514a4478a1af69a8a3be93dfecab
Author: Michael Stahl
AuthorDate: Thu May 16 18:09:18 2024 +0200
Commit: Michael Stahl
CommitDate: Fri May 17 19:23:45 2024 +0200
tdf#161137 sw: fix AutoText or Paste overriding paragraph indents
The problem is that when a paragraph style specifies a SwNumRule, then
this style's indents override the indents of the SwNumRule, but if the
same SwNumRule is also added to the SwTextNode's mpAttrSet, then the
style's indents no longer take effect.
This happens both when inserting an AutoText, and when Pasting, into a
list item, because DocumentContentOperationsManager::CopyImplImpl()
sets the pNumRuleToPropagate as direct formatting on every pasted node.
Add another flag to SwDoc::SetNumRule() to check if pNumRuleToPropagate
was already in effect due to the paragraph style.
Change-Id: Id98ad2a21eab4f8636fb36f9298a054cfe4f7784
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167766
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sw/inc/doc.hxx b/sw/inc/doc.hxx
index b4d3d0e54f86..659af3ba1e91 100644
--- a/sw/inc/doc.hxx
+++ b/sw/inc/doc.hxx
@@ -1052,23 +1052,28 @@ public:
SW_DLLPUBLIC bool GotoOutline(SwPosition& rPos, const OUString& rName,
SwRootFrame const* = nullptr) const;
-/** Accept changes of outline styles for OutlineRule.
- @param bResetIndentAttrs Optional parameter - default value false:
- If equals true, the indent attributes "before text"
- and "first line indent" are additionally reset at the provided PaM, if
- the list style makes use of the new list level attributes.
- @param bCreateNewList indicates if a new list is created by applying the
given list style.
+enum class SetNumRuleMode {
+Default = 0,
+/// indicates if a new list is created by applying the given list
style.
+CreateNewList = 1,
+DontSetItem = 2,
+/** If enabled, the indent attributes "before text" and
+ "first line indent" are additionally reset at the provided PaM,
+ if the list style makes use of the new list level attributes. */
+ResetIndentAttrs = 4,
+DontSetIfAlreadyApplied = 8
+};
+
+/** Set or change numbering rule on text nodes, as direct formatting.
@param sContinuedListId If bCreateNewList is false, may contain the
list Id of a list which has to be continued by applying the given list
style
@return the set ListId if bSetItem is true */
OUString SetNumRule( const SwPaM&,
const SwNumRule&,
- bool bCreateNewList,
+ SetNumRuleMode mode,
SwRootFrame const* pLayout = nullptr,
- const OUString& sContinuedListId = OUString(),
- bool bSetItem = true,
- const bool bResetIndentAttrs = false );
+ const OUString& sContinuedListId = OUString());
void SetCounted(const SwPaM&, bool bCounted, SwRootFrame const* pLayout);
void MakeUniqueNumRules(const SwPaM & rPaM);
@@ -1705,6 +1710,7 @@ private:
namespace o3tl {
template<> struct typed_flags :
is_typed_flags {};
+template<> struct typed_flags :
is_typed_flags {};
}
// This method is called in Dtor of SwDoc and deletes cache of ContourObjects.
diff --git a/sw/qa/extras/uiwriter/data/stylewithlistandindents.fodt
b/sw/qa/extras/uiwriter/data/stylewithlistandindents.fodt
new file mode 100644
index ..afb7ae06aac2
--- /dev/null
+++ b/sw/qa/extras/uiwriter/data/stylewithlistandindents.fodt
@@ -0,0 +1,182 @@
+
+http://www.w3.org/TR/css3-text/;
xmlns:grddl="http://www.w3.org/2003/g/data-view#;
xmlns:xhtml="http://www.w3.org/1999/xhtml;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xmlns:xsd="http://www.w3.org/2001/XMLSchema;
xmlns:xforms="http://www.w3.org/2002/xforms;
xmlns:dom="http://www.w3.org/2001/xml-events;
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0"
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0"
xmlns:math="http://www.w3.org/1998/Math/MathML;
[Bug 161137] Inserting autotext converts style into direct formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=161137 Commit Notification changed: What|Removed |Added Whiteboard||target:24.8.0 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161143] Updated to version 24.2.3.2 (x86_64) and Calc autofilter format error when file re-opened to continue working on it
https://bugs.documentfoundation.org/show_bug.cgi?id=161143 m_a_riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m_a_riosv --- Please attach a sample file. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160835] Unclear meaning of "a basic total population"
https://bugs.documentfoundation.org/show_bug.cgi?id=160835 Rafael Lima changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |rafael.palma.l...@gmail.com |desktop.org | Status|NEW |ASSIGNED --- Comment #9 from Rafael Lima --- This patch fixes the affected strings: https://gerrit.libreoffice.org/c/core/+/167688 I guess we'd better treat this compatibility issue in a separate ticket. Anyways, if anyone can confirm it, please let me know. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161142] DATA LOSS!!! Libreoffice calc comments vanished
https://bugs.documentfoundation.org/show_bug.cgi?id=161142 m_a_riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #3 from m_a_riosv --- What file format do you use to save? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160455] LibreOffice Writer crashes when hitting Ctrl+F
https://bugs.documentfoundation.org/show_bug.cgi?id=160455 --- Comment #9 from m_a_riosv --- To use Skia, try updating your graphics driver from the vendor, they have their own update program. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161003] Footnote separator should offer automatic color
https://bugs.documentfoundation.org/show_bug.cgi?id=161003 --- Comment #1 from ardv --- this problem also occurs with: table borders and frame borders. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 145735] qt6: Support video playback in Impress presentations on Wayland
https://bugs.documentfoundation.org/show_bug.cgi?id=145735 Michael Weghorn changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |m.wegh...@posteo.de |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160835] Unclear meaning of "a basic total population"
https://bugs.documentfoundation.org/show_bug.cgi?id=160835 --- Comment #8 from Rafael Lima --- Created attachment 194180 --> https://bugs.documentfoundation.org/attachment.cgi?id=194180=edit Compatibility issue with AVERAGE in Calc vs Excel In short, indeed this is simply a "population". The main difference between AVERAGE and AVERAGEA is how logical values (TRUE / FALSE) or empty text is treated. See below: https://support.microsoft.com/en-us/office/averagea-function-a5ae0aea-11ad-4bba-856a-031e08567df0 The problem is that there I've just detected a compatibility issue in LO Calc, where the function AVERAGE does not work as in Excel. See attached image for an example. Apparently, Calc's AVERAGE works like AVERAGEA in Excel (beware that the Excel file in the screenshot is using pt-BR, hence the formulas are translated). Can anyone else confirm? Should we treat this compatibility issue on a separate ticket? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161048] Background processes are left opened by LO Dev on Windows since 2024.05.08
https://bugs.documentfoundation.org/show_bug.cgi?id=161048 --- Comment #16 from m_a_riosv --- I use https://dev-builds.libreoffice.org/si-gui/setup.exe to install parallel versions, you can easily choose where to install, it also allows you to select the version to download. There is also a Java version in the same folder, which works also on other operating systems besides Windows. -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'distro/collabora/co-24.04' - i18nlangtag/source
i18nlangtag/source/isolang/mslangid.cxx |9 +
1 file changed, 9 insertions(+)
New commits:
commit 18102e3d7f832b8d5e445e427b55654f5bfd30b0
Author: Noel Grandin
AuthorDate: Fri May 17 15:59:45 2024 +0200
Commit: Noel Grandin
CommitDate: Fri May 17 18:58:13 2024 +0200
cool#8570 single-element cache in MsLangId::getScriptType
this method is hit pretty hard, so try a single element cache
Change-Id: I7c9f9285037a181ee24fbdf04cabc15b40a2ff03
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167781
Reviewed-by: Michael Meeks
Tested-by: Jenkins CollaboraOffice
diff --git a/i18nlangtag/source/isolang/mslangid.cxx
b/i18nlangtag/source/isolang/mslangid.cxx
index 3a420dba2d2c..4e0a5584a28d 100644
--- a/i18nlangtag/source/isolang/mslangid.cxx
+++ b/i18nlangtag/source/isolang/mslangid.cxx
@@ -364,6 +364,13 @@ bool MsLangId::needsSequenceChecking( LanguageType nLang )
// static
sal_Int16 MsLangId::getScriptType( LanguageType nLang )
{
+// single-element cache
+static thread_local LanguageType nCachedLang =
LANGUAGE_MONGOLIAN_MONGOLIAN_MONGOLIA;
+static thread_local sal_Int16 nCachedScript =
css::i18n::ScriptType::COMPLEX;
+
+if (nCachedLang == nLang)
+return nCachedScript;
+
sal_Int16 nScript;
// CTL
@@ -471,6 +478,8 @@ sal_Int16 MsLangId::getScriptType( LanguageType nLang )
{
nScript = css::i18n::ScriptType::LATIN;
}
+nCachedLang = nLang;
+nCachedScript = nScript;
return nScript;
}
[Bug 59284] [META] Calc cell border related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=59284 Rafael Lima changed: What|Removed |Added Depends on||160693 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160693 [Bug 160693] Top borders of merged cells are not painted when the merged cell is partially visible -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160693] Top borders of merged cells are not painted when the merged cell is partially visible
https://bugs.documentfoundation.org/show_bug.cgi?id=160693 Rafael Lima changed: What|Removed |Added Blocks||59284 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=59284 [Bug 59284] [META] Calc cell border related issues -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160693] Top borders of merged cells are not painted when the merged cell is partially visible
https://bugs.documentfoundation.org/show_bug.cgi?id=160693 Rafael Lima changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Keywords||bibisectRequest, regression --- Comment #4 from Rafael Lima --- Based on Comment #3 I am setting this to NEW. Seems like a regression to me. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160455] LibreOffice Writer crashes when hitting Ctrl+F
https://bugs.documentfoundation.org/show_bug.cgi?id=160455 --- Comment #8 from wilmargutierrezpel...@gmail.com --- I haven't seen this bug again since I followed the last instructions: Please then try disabling Skia Menu/Tools/Options/LibreOffice/View Thank you very much! -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'feature/cib_contract57d' - 27 commits - avmedia/source configure.ac dbaccess/source download.lst drawinglayer/source embeddedobj/source external/curl external/liblangtag external/lib
Rebased ref, commits from common ancestor:
commit 5669f498e84622dd969bb7ee83583701087df82b
Author: Mike Kaganski
AuthorDate: Sun Feb 25 08:48:08 2024 +0600
Commit: Thorsten Behrens
CommitDate: Fri May 17 18:29:59 2024 +0200
Use SAL_WNODEPRECATED_DECLARATIONS_(PUSH|POP)
Change-Id: I2810d22e8f5e1c81647b9e9b15519de65939630a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163895
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/filter/source/xsltfilter/LibXSLTTransformer.cxx
b/filter/source/xsltfilter/LibXSLTTransformer.cxx
index 2acc7dba07b5..14088a70ee2a 100644
--- a/filter/source/xsltfilter/LibXSLTTransformer.cxx
+++ b/filter/source/xsltfilter/LibXSLTTransformer.cxx
@@ -478,21 +478,9 @@ namespace XSLT
params = args;
}
-#ifdef __GNUC__
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
-#endif
-#if defined(_MSC_VER)
-#pragma warning(push)
-#pragma warning(disable:4996)
-#endif
+SAL_WNODEPRECATED_DECLARATIONS_PUSH
xmlSubstituteEntitiesDefault(0);
-#if defined(_MSC_VER)
-#pragma warning(pop)
-#endif
-#ifdef __GNUC__
-#pragma GCC diagnostic pop
-#endif
+SAL_WNODEPRECATED_DECLARATIONS_POP
m_parameters.clear();
for (int i = 0; i < params.getLength(); i++)
diff --git a/helpcompiler/source/HelpCompiler.cxx
b/helpcompiler/source/HelpCompiler.cxx
index 98fd7f6eb55d..9cd0425c2e05 100644
--- a/helpcompiler/source/HelpCompiler.cxx
+++ b/helpcompiler/source/HelpCompiler.cxx
@@ -44,21 +44,9 @@ HelpCompiler::HelpCompiler(StreamTable _streamTable,
const fs::path _input
src(in_src), zipdir(in_zipdir), module(in_module), lang(in_lang),
resCompactStylesheet(in_resCompactStylesheet),
resEmbStylesheet(in_resEmbStylesheet), bExtensionMode( in_bExtensionMode )
{
-#ifdef __GNUC__
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
-#endif
-#if defined(_MSC_VER)
-#pragma warning(push)
-#pragma warning(disable:4996)
-#endif
+SAL_WNODEPRECATED_DECLARATIONS_PUSH
xmlKeepBlanksDefaultValue = 0;
-#if defined(_MSC_VER)
-#pragma warning(pop)
-#endif
-#ifdef __GNUC__
-#pragma GCC diagnostic pop
-#endif
+SAL_WNODEPRECATED_DECLARATIONS_POP
char* os = getenv("OS");
if (os)
{
diff --git a/vcl/unx/generic/printer/cupsmgr.cxx
b/vcl/unx/generic/printer/cupsmgr.cxx
index 3c910f3b39df..6651f23bdf68 100644
--- a/vcl/unx/generic/printer/cupsmgr.cxx
+++ b/vcl/unx/generic/printer/cupsmgr.cxx
@@ -82,14 +82,9 @@ struct GetPPDAttribs
{
// This CUPS method is not at all thread-safe we need
// to dup the pointer to a static buffer it returns ASAP
-#ifdef __GNUC__
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
-#endif
+SAL_WNODEPRECATED_DECLARATIONS_PUSH
OString aResult = cupsGetPPD(m_aParameter.getStr());
-#ifdef __GNUC__
-#pragma GCC diagnostic pop
-#endif
+SAL_WNODEPRECATED_DECLARATIONS_POP
MutexGuard aGuard( *m_pSyncMutex );
m_aResult = aResult;
m_aCondition.set();
@@ -222,10 +217,7 @@ void CUPSManager::runDests()
// n#722902 - do a fast-failing check for cups working *at all* first
http_t* p_http;
-#ifdef __GNUC__
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
-#endif
+SAL_WNODEPRECATED_DECLARATIONS_PUSH
if( (p_http=httpConnectEncrypt(
cupsServer(),
ippPort(),
@@ -242,9 +234,7 @@ void CUPSManager::runDests()
httpClose(p_http);
}
-#ifdef __GNUC__
-#pragma GCC diagnostic pop
-#endif
+SAL_WNODEPRECATED_DECLARATIONS_POP
}
void CUPSManager::initialize()
@@ -454,14 +444,9 @@ const PPDParser* CUPSManager::createCUPSParser( const
OUString& rPrinter )
rtl_TextEncoding aEncoding = osl_getThreadTextEncoding();
OUString aFileName( OStringToOUString( aPPDFile, aEncoding
) );
// update the printer info with context information
-#ifdef __GNUC__
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
-#endif
+SAL_WNODEPRECATED_DECLARATIONS_PUSH
ppd_file_t* pPPD = ppdOpenFile( aPPDFile.getStr() );
-#ifdef __GNUC__
-#pragma GCC diagnostic pop
-#endif
+SAL_WNODEPRECATED_DECLARATIONS_POP
if( pPPD )
{
// create the new parser
@@ -469,14 +454,9 @@ const PPDParser* CUPSManager::createCUPSParser( const
OUString& rPrinter )
pCUPSParser->m_aFile = rPrinter;
pNewParser = pCUPSParser;
-#ifdef __GNUC__
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
-#endif
+SAL_WNODEPRECATED_DECLARATIONS_PUSH
/*int nConflicts =*/ cupsMarkOptions( pPPD,
pDest->num_options, pDest->options );
-#ifdef __GNUC__
-#pragma GCC diagnostic pop
-#endif
+SAL_WNODEPRECATED_DECLARATIONS_POP
[Bug 161153] Inserting tashdid (a.k.a. shaddah) character (Unicode 0651) breaks or distorts Persian text
https://bugs.documentfoundation.org/show_bug.cgi?id=161153 افشین changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #4 from افشین --- I tested too with B Nazanin font and other Persian font (B Mitra) and confirm this bug. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 101522] [META] Media playback bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101522 --- Comment #29 from proi...@gmail.com --- The only photo and video enhancer you'll ever need https://remiini.com/;>Remini MOD APK Transformative technology gives your low-quality visuals a stunning HD upgrade. Restore old photos to incredible detail and elevate your content to a professional level. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 149907] Standard Filter demands change on "Value" field, otherwise it does not update results
https://bugs.documentfoundation.org/show_bug.cgi?id=149907 --- Comment #21 from pavelz --- Still reproducible in Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 658a212585c56540a17c4e6829716d4ef4e3 CPU threads: 4; OS: Linux 6.8; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161153] Inserting tashdid (a.k.a. shaddah) character (Unicode 0651) breaks or distorts Persian text
https://bugs.documentfoundation.org/show_bug.cgi?id=161153 arham.amo...@gmail.com changed: What|Removed |Added Summary|Inserting shaddah (a.k.a. |Inserting tashdid (a.k.a. |tashdid) character (unicode |shaddah) character (Unicode |0651 )breaks the text |0651) breaks or distorts ||Persian text Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #3 from arham.amo...@gmail.com --- ّIn some cases, inserting a tashdid character (Unicode 0651) in a Persian text breaks it or causes the text to be rendered in a bad way. Since Arabic and Persian writing systems are very similar, this may also affect Arabic texts. I have also observed instances where inserting this character does not cause any problems. I am not certain about the specific conditions that lead to this issue; however, it appears to be font-dependent. Thus far, I have encountered this problem in Writer 7.3.7.2 (on Xubuntu 22.04) and Writer 24.2.2.2 (on Ubuntu 24.04). When this occurs, pressing Ctrl+Z does not restore the text to its normal appearance, necessitating a document reload. The attached file (example.zip) contains a sample Persian document, the font I have used, and screenshots illustrating the text before and after the insertion of the tashdid character. This font is widely used for Persian script, and we do not encounter this issue in Microsoft Word. I am willing to conduct any tests you suggest and provide any additional information required. Thank you for your excellent work! -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161153] Inserting shaddah (a.k.a. tashdid) character (unicode 0651 )breaks the text
https://bugs.documentfoundation.org/show_bug.cgi?id=161153 --- Comment #2 from arham.amo...@gmail.com --- Created attachment 194179 --> https://bugs.documentfoundation.org/attachment.cgi?id=194179=edit a sample Persian document, its font, and screenshots illustrating the text before and after the insertion of the tashdid character -- You are receiving this mail because: You are the assignee for the bug.
[Bug 98053] Print preview closes the read-only infobar
https://bugs.documentfoundation.org/show_bug.cgi?id=98053 --- Comment #10 from pavelz --- Still reproducible in Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 658a212585c56540a17c4e6829716d4ef4e3 CPU threads: 4; OS: Linux 6.8; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161154] Text rendering problem in 24.8 on Windows with Skia disabled
https://bugs.documentfoundation.org/show_bug.cgi?id=161154 Mike Kaganski changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Ever confirmed|0 |1 Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | --- Comment #2 from Mike Kaganski --- https://gerrit.libreoffice.org/c/core/+/167786 -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/source
sw/source/filter/ww8/ww8atr.cxx | 24 ++--
1 file changed, 14 insertions(+), 10 deletions(-)
New commits:
commit 3ddd11d18a24ebd8cbc3e5ac8d460b4888cade07
Author: Caolán McNamara
AuthorDate: Fri May 17 14:15:23 2024 +0100
Commit: Caolán McNamara
CommitDate: Fri May 17 17:43:03 2024 +0200
WaE: C6011 Dereferencing NULL pointer warnings
Change-Id: I18b18f5d430e626dea9163aec0bf99ab09c5c71b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167780
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx
index 30fbebc4fbc3..e1787614f732 100644
--- a/sw/source/filter/ww8/ww8atr.cxx
+++ b/sw/source/filter/ww8/ww8atr.cxx
@@ -5521,17 +5521,21 @@ static void ParaTabStopDelAdd( WW8Export& rWrt,
aTab.Add(*pTN, nLParaMgn); // must be inserted
nN++;
}
-else if (lcl_IsEqual(nOP, *pTO, nNP, *pTN)) // tabs are equal
-{
-nO++; // nothing to do
-nN++;
-}
-else// tabs same position,
different type
+else
{
-aTab.Del(*pTO, nLStypeMgn); // delete old one
-aTab.Add(*pTN, nLParaMgn); // insert new one
-nO++;
-nN++;
+assert(pTO && pTN);
+if (lcl_IsEqual(nOP, *pTO, nNP, *pTN)) // tabs are equal
+{
+nO++; // nothing to do
+nN++;
+}
+else// tabs same position,
different type
+{
+aTab.Del(*pTO, nLStypeMgn); // delete old one
+aTab.Add(*pTN, nLParaMgn); // insert new one
+nO++;
+nN++;
+}
}
} while( true );
core.git: Branch 'distro/collabora/co-24.04' - desktop/source include/sfx2 include/vcl sfx2/source vcl/source
desktop/source/lib/init.cxx |2 +-
include/sfx2/viewsh.hxx |1 +
include/vcl/IDialogRenderable.hxx |3 +++
include/vcl/svapp.hxx |2 +-
sfx2/source/view/lokhelper.cxx|3 ++-
sfx2/source/view/viewsh.cxx | 23 +++
vcl/source/app/svapp.cxx | 16
7 files changed, 47 insertions(+), 3 deletions(-)
New commits:
commit 8d979fae0c435b820302c76fcfdc2642b4820360
Author: Michael Meeks
AuthorDate: Thu May 16 19:35:51 2024 +0100
Commit: Michael Meeks
CommitDate: Fri May 17 17:41:40 2024 +0200
lok: dump more SfxViewShell state, and LOK notifier state on Windows.
This should help to associate the right view-ids, with the right
windows, and help to catch any stray / lingering windows from closed
sessions - hopefully.
Change-Id: I197a3280d5d2aeddd356ee037c51e4887f43278b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167765
Reviewed-by: Miklos Vajna
Tested-by: Jenkins CollaboraOffice
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index a61eb3ff0879..298d15b4ddf6 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -1660,7 +1660,7 @@ void
CallbackFlushHandler::libreOfficeKitViewUpdatedCallbackPerViewId(int nType,
void CallbackFlushHandler::dumpState(rtl::OStringBuffer )
{
// NB. no locking
-rState.append("
View: ");
+rState.append("
View: ");
rState.append(static_cast(m_viewId));
rState.append("
DisableCallbacks: ");
rState.append(static_cast(m_nDisableCallbacks));
diff --git a/include/sfx2/viewsh.hxx b/include/sfx2/viewsh.hxx
index e68f556c1072..d098d76d0031 100644
--- a/include/sfx2/viewsh.hxx
+++ b/include/sfx2/viewsh.hxx
@@ -274,6 +274,7 @@ public:
// ILibreOfficeKitNotifier
virtual voidnotifyWindow(vcl::LOKWindowId nLOKWindowId,
const OUString& rAction, const std::vector& rPayload =
std::vector()) const override;
+virtual OString dumpNotifyState() const override;
// Focus, KeyInput, Cursor
virtual voidShowCursor( bool bOn = true );
diff --git a/include/vcl/IDialogRenderable.hxx
b/include/vcl/IDialogRenderable.hxx
index 49e22c3c5357..11a7adfb0f27 100644
--- a/include/vcl/IDialogRenderable.hxx
+++ b/include/vcl/IDialogRenderable.hxx
@@ -42,6 +42,9 @@ public:
/// Emits a LOK_CALLBACK_INVALIDATE_TILES.
virtual void notifyInvalidation(tools::Rectangle const *) const = 0;
+
+/// Debugging
+virtual OString dumpNotifyState() const = 0;
};
} // namespace vcl
diff --git a/include/vcl/svapp.hxx b/include/vcl/svapp.hxx
index 36d7eeb1fc06..be1e80090576 100644
--- a/include/vcl/svapp.hxx
+++ b/include/vcl/svapp.hxx
@@ -1326,7 +1326,7 @@ public:
const std::vector& rPayload
= std::vector()) const override;
virtual void libreOfficeKitViewCallback(int nType, const OString&
pPayload) const override;
virtual void notifyInvalidation(tools::Rectangle const *) const override;
-
+virtual OString dumpNotifyState() const override;
private:
DECL_DLLPRIVATE_STATIC_LINK( Application, PostEventHandler, void*, void );
diff --git a/sfx2/source/view/lokhelper.cxx b/sfx2/source/view/lokhelper.cxx
index 8df19c359442..99f39fbf4e8b 100644
--- a/sfx2/source/view/lokhelper.cxx
+++ b/sfx2/source/view/lokhelper.cxx
@@ -733,7 +733,8 @@ void
SfxLokHelper::notifyPartSizeChangedAllViews(vcl::ITiledRenderable* pDoc, in
SfxViewShell* pViewShell = SfxViewShell::GetFirst();
while (pViewShell)
{
-if (pViewShell->getPart() == nPart)
+if (// FIXME should really filter on pViewShell->GetDocId() too
+pViewShell->getPart() == nPart)
SfxLokHelper::notifyDocumentSizeChanged(pViewShell, ""_ostr, pDoc,
false);
pViewShell = SfxViewShell::GetNext(*pViewShell);
}
diff --git a/sfx2/source/view/viewsh.cxx b/sfx2/source/view/viewsh.cxx
index 75731ecf1ccd..0b6c07c68d5c 100644
--- a/sfx2/source/view/viewsh.cxx
+++ b/sfx2/source/view/viewsh.cxx
@@ -3181,6 +3181,20 @@ SfxLokCallbackInterface*
SfxViewShell::getLibreOfficeKitViewCallback() const
void SfxViewShell::dumpLibreOfficeKitViewState(rtl::OStringBuffer )
{
+rState.append("
SfxViewShell: ");
+rState.append(OString::number(reinterpret_cast(this), 16));
+rState.append("
DocId: ");
+auto nDocId = static_cast(GetDocId());
+rState.append(static_cast(nDocId));
+rState.append("
ViewId: ");
+rState.append(static_cast(GetViewShellId()));
+rState.append("
Part: ");
+rState.append(static_cast(getPart()));
+rState.append("
Lang: ");
+rState.append(OUStringToOString(GetLOKLanguageTag().getBcp47(),
RTL_TEXTENCODING_UTF8));
+rState.append("
A11y: ");
+rState.append(GetLOKAccessibilityState() ? "enabled" : "disabled");
+
if
[Bug 161154] Text rendering problem in 24.8 on Windows with Skia disabled
https://bugs.documentfoundation.org/show_bug.cgi?id=161154 --- Comment #1 from Mike Kaganski --- The problem is specific to Windows default renderer, i.e. with Skia disabled. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 134226] Arabic diacritics and shadda overlap when shadda is in a separate span
https://bugs.documentfoundation.org/show_bug.cgi?id=134226 Jonathan Clark changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |jonat...@libreoffice.org |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161154] Text rendering problem in 24.8 on Windows with Skia disabled
https://bugs.documentfoundation.org/show_bug.cgi?id=161154 Mike Kaganski changed: What|Removed |Added Summary|Text rendering problem in |Text rendering problem in |24.8|24.8 on Windows with Skia ||disabled -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161154] New: Text rendering problem in 24.8
https://bugs.documentfoundation.org/show_bug.cgi?id=161154 Bug ID: 161154 Summary: Text rendering problem in 24.8 Product: LibreOffice Version: 24.8.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Keywords: bibisectNotNeeded, regression Severity: normal Priority: medium Component: graphics stack Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikekagan...@hotmail.com Created attachment 194178 --> https://bugs.documentfoundation.org/attachment.cgi?id=194178=edit A fit-to-size text sample After commit 85c82ad23c64db500e607a3ffb76e3aebfb18102 (tdf#160901: partially revert 8557ea84c9336ba8061246f1f46ddb6e02f413a1, 2024-03-03), the attachment is rendered incorrectly: its text "itititititititititititititi2" gets truncated at some random place, so that it doesn't show the trailing "2", and actually ends with either "i" or "t", depending on zoom. -- You are receiving this mail because: You are the assignee for the bug.
core.git: cli_ure/Executable_climaker.mk include/sal include/sfx2 sfx2/source solenv/gbuild solenv/vs
cli_ure/Executable_climaker.mk |2 ++
include/sal/types.h | 17 +++--
include/sfx2/objsh.hxx | 12 ++--
include/sfx2/viewfrm.hxx|8
include/sfx2/viewsh.hxx | 12 ++--
sfx2/source/doc/objxtor.cxx |8 +++-
sfx2/source/view/viewfrm.cxx|8
sfx2/source/view/viewsh.cxx | 11 ---
solenv/gbuild/platform/com_MSC_class.mk | 14 +++---
solenv/gbuild/platform/com_MSC_defs.mk |5 +
solenv/vs/LibreOffice.ruleset |6 ++
11 files changed, 66 insertions(+), 37 deletions(-)
New commits:
commit 1148d6ad13b444c179aacdb693bd82e37d0ed32d
Author: Caolán McNamara
AuthorDate: Mon Apr 29 20:45:05 2024 +0100
Commit: Caolán McNamara
CommitDate: Fri May 17 17:37:58 2024 +0200
introduce SAL_RET_MAYBENULL
which for debug builds and MSVC uses _Ret_maybenull_ and -analyze to
enforce null checking
Change-Id: Id7f0ad854be7841819fdbdcd56c862d1a2df86c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166734
Reviewed-by: Caolán McNamara
Tested-by: Jenkins
diff --git a/cli_ure/Executable_climaker.mk b/cli_ure/Executable_climaker.mk
index f0769b627cb2..2c2aaaf8a33e 100644
--- a/cli_ure/Executable_climaker.mk
+++ b/cli_ure/Executable_climaker.mk
@@ -13,9 +13,11 @@ $(eval $(call gb_Executable_use_package,climaker,\
cli_basetypes_copy \
))
+# -analyze- to turn that off due to internal compiler error
$(eval $(call gb_Executable_add_cxxclrflags,climaker,\
-LN \
-wd4715 \
+ -analyze- \
))
$(eval $(call gb_Executable_add_ldflags,climaker,\
diff --git a/include/sal/types.h b/include/sal/types.h
index a2ef256239e1..61e12c8eb4d5 100644
--- a/include/sal/types.h
+++ b/include/sal/types.h
@@ -273,10 +273,10 @@ typedef void * sal_Handle;
#endif
/** Use this as markup for functions and methods whose return value must be
-checked.
+used.
Compilers that support a construct of this nature will emit a compile
-time warning on unchecked return value.
+time warning on unused return value.
*/
#if defined LIBO_INTERNAL_ONLY && defined __cplusplus
#define SAL_WARN_UNUSED_RESULT [[nodiscard]]
@@ -288,6 +288,19 @@ typedef void * sal_Handle;
# define SAL_WARN_UNUSED_RESULT
#endif
+/** Use this as markup for functions and methods whose return value may be
+null and should not be derefenced unconditionally.
+
+Compilers that support a construct of this nature will emit a compile
+time warning on unconditional dereference of returned pointer.
+*/
+#ifdef _MSC_VER
+# define SAL_RET_MAYBENULL _Ret_maybenull_
+#else
+# define SAL_RET_MAYBENULL
+#endif
+
+
/** Use this for pure virtual classes, e.g. class SAL_NO_VTABLE Foo { ...
This hinders the compiler from setting a generic vtable stating that
a pure virtual function was called and thus slightly reduces code size.
diff --git a/include/sfx2/objsh.hxx b/include/sfx2/objsh.hxx
index e0b0d3f411a3..eececb850bd9 100644
--- a/include/sfx2/objsh.hxx
+++ b/include/sfx2/objsh.hxx
@@ -249,12 +249,12 @@ public:
static OUString CreateShellID( const SfxObjectShell* pShell );
// Document-Shell Iterator
-SAL_WARN_UNUSED_RESULT static SfxObjectShell* GetFirst( const
std::function& isObjectShell = nullptr,
- bool bOnlyVisible = true );
-SAL_WARN_UNUSED_RESULT static SfxObjectShell* GetNext( const
SfxObjectShell& rPrev,
- const std::function& isObjectShell = nullptr,
- bool bOnlyVisible = true );
-SAL_WARN_UNUSED_RESULT static SfxObjectShell* Current();
+SAL_RET_MAYBENULL static SfxObjectShell* GetFirst( const
std::function& isObjectShell = nullptr,
+ bool bOnlyVisible = true );
+SAL_RET_MAYBENULL static SfxObjectShell* GetNext( const SfxObjectShell&
rPrev,
+ const std::function&
isObjectShell = nullptr,
+ bool bOnlyVisible = true );
+SAL_RET_MAYBENULL static SfxObjectShell* Current();
static css::uno::Reference< css::uno::XInterface >
GetCurrentComponent();
static void SetCurrentComponent( const
css::uno::Reference< css::uno::XInterface >& _rxComponent );
diff --git a/include/sfx2/viewfrm.hxx b/include/sfx2/viewfrm.hxx
index 3d0bf2fcc08a..4622ff167fcf 100644
--- a/include/sfx2/viewfrm.hxx
+++ b/include/sfx2/viewfrm.hxx
@@ -96,11 +96,11 @@ public:
static SfxViewFrame*LoadDocumentIntoFrame( SfxObjectShell const &
i_rDoc, const css::uno::Reference< css::frame::XFrame >& i_rFrameItem );
static SfxViewFrame*DisplayNewDocument( SfxObjectShell const & i_rDoc,
const SfxRequest& i_rCreateDocRequest );
-SAL_WARN_UNUSED_RESULT static
core.git: include/vcl sw/qa sw/source vcl/inc vcl/qa vcl/source
include/vcl/outdev.hxx | 10 +
include/vcl/vcllayout.hxx | 10 +
sw/qa/extras/uiwriter/uiwriter7.cxx|3
sw/qa/extras/ww8export/data/tdf92281.doc |binary
sw/source/core/inc/drawfont.hxx| 163 -
sw/source/core/inc/swporlayoutcontext.hxx | 27
sw/source/core/text/guess.cxx | 39 +++---
sw/source/core/text/inftxt.cxx | 34 +++---
sw/source/core/text/inftxt.hxx | 19 ++-
sw/source/core/text/itrcrsr.cxx|9 -
sw/source/core/text/itrform2.cxx | 48
sw/source/core/text/porlin.hxx | 11 +
sw/source/core/text/portxt.cxx |2
sw/source/core/txtnode/fntcache.cxx| 100 -
sw/source/core/txtnode/fntcap.cxx | 10 -
vcl/inc/sallayout.hxx |6 +
vcl/qa/cppunit/complextext.cxx | 66 +++
vcl/qa/cppunit/pdfexport/data/tdf61444.odt |binary
vcl/qa/cppunit/pdfexport/pdfexport2.cxx| 49
vcl/qa/cppunit/text.cxx| 33 +
vcl/source/gdi/sallayout.cxx | 82 ++
vcl/source/outdev/text.cxx | 70 +++-
22 files changed, 606 insertions(+), 185 deletions(-)
New commits:
commit 30d376fb7ded4c96c85ad1112a0e44b5929657c9
Author: Jonathan Clark
AuthorDate: Mon Apr 29 04:30:43 2024 -0600
Commit: Jonathan Clark
CommitDate: Fri May 17 17:35:41 2024 +0200
tdf#61444 Correct Writer text layout across formatting changes
Previously, Writer performed text layout for each span of text
separately. This caused incorrect kerning when the text style changed
mid-word, for example by highlighting or changing the color of a single
letter.
This change updates Writer so it will also consider neighboring text
while performing text layout.
Change-Id: I511096c009343f39cc1b9ba745909c5b8cbad86f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167016
Tested-by: Jenkins
Reviewed-by: Jonathan Clark
diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index 5ed43d0cf299..ab1758835ce1 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -1059,6 +1059,16 @@ public:
vcl::text::TextLayoutCache
const* = nullptr,
SalLayoutGlyphs const*const
pLayoutCache = nullptr) const;
+void DrawPartialTextArray(const Point& rStartPt, const OUString& rStr,
KernArraySpan aKernArray,
+ std::span pKashidaAry, sal_Int32
nIndex,
+ sal_Int32 nLen, sal_Int32 nPartIndex, sal_Int32
nPartLen,
+ SalLayoutFlags flags = SalLayoutFlags::NONE,
+ const SalLayoutGlyphs* pLayoutCache = nullptr);
+double GetPartialTextArray(const OUString& rStr, KernArray* pDXAry,
sal_Int32 nIndex,
+ sal_Int32 nLen, sal_Int32 nPartIndex, sal_Int32
nPartLen,
+ bool bCaret = false, const
vcl::text::TextLayoutCache* = nullptr,
+ const SalLayoutGlyphs* pLayoutCache = nullptr)
const;
+
SAL_DLLPRIVATE void GetCaretPositions( const OUString&, KernArray&
rCaretXArray,
sal_Int32 nIndex, sal_Int32 nLen,
const SalLayoutGlyphs* pGlyphs =
nullptr ) const;
diff --git a/include/vcl/vcllayout.hxx b/include/vcl/vcllayout.hxx
index c946f6f67884..dd0747eae3ec 100644
--- a/include/vcl/vcllayout.hxx
+++ b/include/vcl/vcllayout.hxx
@@ -97,6 +97,16 @@ public:
virtual sal_Int32 GetTextBreak(double nMaxWidth, double nCharExtra, int
nFactor) const = 0;
virtual double FillDXArray( std::vector* pDXArray, const
OUString& rStr ) const = 0;
virtual double GetTextWidth() const { return FillDXArray( nullptr, {} ); }
+
+virtual double FillPartialDXArray(std::vector* pDXArray, const
OUString& rStr,
+ sal_Int32 skipStart, sal_Int32 amt) const
+= 0;
+
+virtual double GetPartialTextWidth(sal_Int32 skipStart, sal_Int32 amt)
const
+{
+return FillPartialDXArray(nullptr, {}, skipStart, amt);
+}
+
virtual voidGetCaretPositions( std::vector& rCaretPositions,
const OUString& rStr ) const = 0;
virtual boolIsKashidaPosValid ( int /*nCharPos*/, int /*nNextCharPos*/
) const = 0; // i60594
diff --git a/sw/qa/extras/uiwriter/uiwriter7.cxx
b/sw/qa/extras/uiwriter/uiwriter7.cxx
index 9347eecfcde6..e824974bef45 100644
--- a/sw/qa/extras/uiwriter/uiwriter7.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter7.cxx
@@ -2507,7 +2507,8 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest7, testTdf87922)
const OUString& rText = aNodeIndex.GetNode().GetTextNode()->GetText();
sal_Int32
[Bug 145735] qt6: Support video playback in Impress presentations on Wayland
https://bugs.documentfoundation.org/show_bug.cgi?id=145735 Michael Weghorn changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=16 ||0565 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 146494] Inserting LibreOffice OLE objects in other applications fail
https://bugs.documentfoundation.org/show_bug.cgi?id=146494 --- Comment #3 from Hossein --- The same issue still exist in LibreOffice 24.2 and WordPad on Windows 11. Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 20; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161144] Query wizard confuses columns with the same name in different tables
https://bugs.documentfoundation.org/show_bug.cgi?id=161144 Hossein changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=67 ||664 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161153] Inserting shaddah (a.k.a. tashdid) character (unicode 0651 )breaks the text
https://bugs.documentfoundation.org/show_bug.cgi?id=161153 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Xisco Faulí --- Thank you for reporting the bug. Unfortunately without clear steps to reproduce it, we cannot track down the origin of the problem. Please provide a clearer set of step-by-step instructions on how to reproduce the problem. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the steps are provided -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161144] Query wizard confuses columns with the same name in different tables
https://bugs.documentfoundation.org/show_bug.cgi?id=161144 Hossein changed: What|Removed |Added CC||mentoring@documentfoundatio ||n.org Keywords||difficultyMedium, easyHack, ||skillJava, skillSql -- You are receiving this mail because: You are the assignee for the bug.
[Bug 112970] [META] Document recovery bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112970 BogdanB changed: What|Removed |Added Depends on||160769 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=160769 [Bug 160769] LibreOffice 24.2 Document recovery (from timed autoSave) doesn't restore all open files after crash -- You are receiving this mail because: You are the assignee for the bug.
