core.git: Branch 'libreoffice-24-2-2' - configure.ac
configure.ac |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit 78629e74e1e046a9ae4945088e2f7afde6db88d6 Author: Fridrich Strba AuthorDate: Tue Mar 12 11:34:52 2024 +0100 Commit: Stephan Bergmann CommitDate: Fri Mar 15 14:32:43 2024 +0100 Fix build with autoconf 2.72 This commit http://git.savannah.gnu.org/gitweb/ ?p=autoconf.git;a=commitdiff; h=cf09f48841b66fe76f606dd6018bb3a93242a7c9 changed the internal cache variable name and its content The effects show later in message like /tmp/ccyB6wS6.ltrans9.ltrans.o: in function `comphelper::DocPasswordHelper::decryptGpgSession(com::sun::star::uno::Sequence > const&)': /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/docpasswordhelper.cxx:705:(.text+0x4fb7): undefined reference to `GpgME::Data::seek(long, int)' /usr/bin/ld.bfd: /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/docpasswordhelper.cxx:716:(.text+0x5402): undefined reference to `GpgME::Data::seek(long, int)' /usr/bin/ld.bfd: /tmp/ccyB6wS6.ltrans13.ltrans.o: in function `comphelper::OStorageHelper::CreateGpgPackageEncryptionData()': /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/storagehelper.cxx:507:(.text+0x64e3): undefined reference to `GpgME::Data::seek(long, int)' /usr/bin/ld.bfd: /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/storagehelper.cxx:520:(.text+0x6583): undefined reference to `GpgME::Data::seek(long, int)' collect2: error: ld returned 1 exit status Where the type 'off_t' at the time of inclusion of the header and at the time of compilation of the library differ. Change-Id: Ie0486dbc869e84f5fb2688473334cfe464abd570 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164704 Tested-by: Jenkins Reviewed-by: Stephan Bergmann Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164715 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164764 Reviewed-by: Miklos Vajna Reviewed-by: Michael Meeks Tested-by: Stephan Bergmann diff --git a/configure.ac b/configure.ac index 8101a2b2e1dd..758e160400ba 100644 --- a/configure.ac +++ b/configure.ac @@ -7197,7 +7197,9 @@ if test "$_os" != "WINNT"; then dnl Check for large file support AC_SYS_LARGEFILE -if test -n "$ac_cv_sys_file_offset_bits" -a "$ac_cv_sys_file_offset_bits" != "no"; then +if test -n "$ac_cv_sys_largefile_opts" -a "$ac_cv_sys_largefile_opts" != "none needed" -a "$ac_cv_sys_largefile_opts" != "support not detected"; then +LFS_CFLAGS="$ac_cv_sys_largefile_opts" +elif test -n "$ac_cv_sys_file_offset_bits" -a "$ac_cv_sys_file_offset_bits" != "no"; then LFS_CFLAGS="-D_FILE_OFFSET_BITS=$ac_cv_sys_file_offset_bits" fi if test -n "$ac_cv_sys_large_files" -a "$ac_cv_sys_large_files" != "no"; then
core.git: Branch 'libreoffice-24-2' - configure.ac
configure.ac |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit 01d39c444a62d69dedcaa1d9f6b2bed47a5dadee Author: Fridrich Strba AuthorDate: Tue Mar 12 11:34:52 2024 +0100 Commit: Stephan Bergmann CommitDate: Wed Mar 13 07:58:58 2024 +0100 Fix build with autoconf 2.72 This commit http://git.savannah.gnu.org/gitweb/ ?p=autoconf.git;a=commitdiff; h=cf09f48841b66fe76f606dd6018bb3a93242a7c9 changed the internal cache variable name and its content The effects show later in message like /tmp/ccyB6wS6.ltrans9.ltrans.o: in function `comphelper::DocPasswordHelper::decryptGpgSession(com::sun::star::uno::Sequence > const&)': /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/docpasswordhelper.cxx:705:(.text+0x4fb7): undefined reference to `GpgME::Data::seek(long, int)' /usr/bin/ld.bfd: /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/docpasswordhelper.cxx:716:(.text+0x5402): undefined reference to `GpgME::Data::seek(long, int)' /usr/bin/ld.bfd: /tmp/ccyB6wS6.ltrans13.ltrans.o: in function `comphelper::OStorageHelper::CreateGpgPackageEncryptionData()': /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/storagehelper.cxx:507:(.text+0x64e3): undefined reference to `GpgME::Data::seek(long, int)' /usr/bin/ld.bfd: /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/storagehelper.cxx:520:(.text+0x6583): undefined reference to `GpgME::Data::seek(long, int)' collect2: error: ld returned 1 exit status Where the type 'off_t' at the time of inclusion of the header and at the time of compilation of the library differ. Change-Id: Ie0486dbc869e84f5fb2688473334cfe464abd570 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164704 Tested-by: Jenkins Reviewed-by: Stephan Bergmann Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164715 diff --git a/configure.ac b/configure.ac index 51e1e55a404b..b8dbb3c0e7be 100644 --- a/configure.ac +++ b/configure.ac @@ -7197,7 +7197,9 @@ if test "$_os" != "WINNT"; then dnl Check for large file support AC_SYS_LARGEFILE -if test -n "$ac_cv_sys_file_offset_bits" -a "$ac_cv_sys_file_offset_bits" != "no"; then +if test -n "$ac_cv_sys_largefile_opts" -a "$ac_cv_sys_largefile_opts" != "none needed" -a "$ac_cv_sys_largefile_opts" != "support not detected"; then +LFS_CFLAGS="$ac_cv_sys_largefile_opts" +elif test -n "$ac_cv_sys_file_offset_bits" -a "$ac_cv_sys_file_offset_bits" != "no"; then LFS_CFLAGS="-D_FILE_OFFSET_BITS=$ac_cv_sys_file_offset_bits" fi if test -n "$ac_cv_sys_large_files" -a "$ac_cv_sys_large_files" != "no"; then
core.git: configure.ac
configure.ac |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit 06dd867d05b807b346b24d9b1e7535d376d4c14d Author: Fridrich Strba AuthorDate: Tue Mar 12 11:34:52 2024 +0100 Commit: Stephan Bergmann CommitDate: Tue Mar 12 16:07:58 2024 +0100 Fix build with autoconf 2.72 This commit http://git.savannah.gnu.org/gitweb/ ?p=autoconf.git;a=commitdiff; h=cf09f48841b66fe76f606dd6018bb3a93242a7c9 changed the internal cache variable name and its content The effects show later in message like /tmp/ccyB6wS6.ltrans9.ltrans.o: in function `comphelper::DocPasswordHelper::decryptGpgSession(com::sun::star::uno::Sequence > const&)': /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/docpasswordhelper.cxx:705:(.text+0x4fb7): undefined reference to `GpgME::Data::seek(long, int)' /usr/bin/ld.bfd: /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/docpasswordhelper.cxx:716:(.text+0x5402): undefined reference to `GpgME::Data::seek(long, int)' /usr/bin/ld.bfd: /tmp/ccyB6wS6.ltrans13.ltrans.o: in function `comphelper::OStorageHelper::CreateGpgPackageEncryptionData()': /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/storagehelper.cxx:507:(.text+0x64e3): undefined reference to `GpgME::Data::seek(long, int)' /usr/bin/ld.bfd: /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/storagehelper.cxx:520:(.text+0x6583): undefined reference to `GpgME::Data::seek(long, int)' collect2: error: ld returned 1 exit status Where the type 'off_t' at the time of inclusion of the header and at the time of compilation of the library differ. Change-Id: Ie0486dbc869e84f5fb2688473334cfe464abd570 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164704 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/configure.ac b/configure.ac index 94a7c2fe6d9b..051934a3cce1 100644 --- a/configure.ac +++ b/configure.ac @@ -7222,7 +7222,9 @@ if test "$_os" != "WINNT"; then dnl Check for large file support AC_SYS_LARGEFILE -if test -n "$ac_cv_sys_file_offset_bits" -a "$ac_cv_sys_file_offset_bits" != "no"; then +if test -n "$ac_cv_sys_largefile_opts" -a "$ac_cv_sys_largefile_opts" != "none needed" -a "$ac_cv_sys_largefile_opts" != "support not detected"; then +LFS_CFLAGS="$ac_cv_sys_largefile_opts" +elif test -n "$ac_cv_sys_file_offset_bits" -a "$ac_cv_sys_file_offset_bits" != "no"; then LFS_CFLAGS="-D_FILE_OFFSET_BITS=$ac_cv_sys_file_offset_bits" fi if test -n "$ac_cv_sys_large_files" -a "$ac_cv_sys_large_files" != "no"; then
Re: writing attribute style:background-transparency
On 22/09/16 00:58, Thorsten Behrens wrote: > Hi Regina, > > you wrote: >> Do you know a situation where LibreOffice writes the attribute >> style:background-transparency ? >> > lotuswordpro/source/filter/xfilter/xfframestyle.cxx does - and perhaps > other libs from DLP do as well? For the while, the only background-* variable that is relevant to transparency/opacity that DLP libraries -- at least those that I maintain -- write is fo:background-opacity for text. Obviously, this does not work and is happily ignored :) Cheers F. -- Please avoid sending me Word, Excel or PowerPoint attachments. See http://www.gnu.org/philosophy/no-word-attachments.html signature.asc Description: OpenPGP digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] libvisio: Fix tests without tools
Could you send it as "git format-patch" or submit to gerrit, so that I can credit you properly? Cheers F. On 07/02/16 15:28, Andreas Sturmlechner wrote: > I'd like to submit an easy patch that fixes the tests when libvisio is built > without tools (in that case it was missing librevenge-stream reference). > > Regards, > Andreas Sturmlechner > > > > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/libreoffice > -- Please avoid sending me Word, Excel or PowerPoint attachments. See http://www.gnu.org/philosophy/no-word-attachments.html signature.asc Description: OpenPGP digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] libvisio: Fix tests without tools
Actually, it is ok, I managed to massage it a bit and commit like this: https://cgit.freedesktop.org/libreoffice/libvisio/commit/?id=13431c9e425d93f61a7fc16f99f8d8c6e71ed82b Thanks a lot for noticing this. Cheers Fridrich On 07/02/16 21:09, Fridrich Strba wrote: > Could you send it as "git format-patch" or submit to gerrit, so that I > can credit you properly? -- Please avoid sending me Word, Excel or PowerPoint attachments. See http://www.gnu.org/philosophy/no-word-attachments.html signature.asc Description: OpenPGP digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Two svg import filters
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/11/15 13:11, Caolán McNamara wrote: > We have svgio which is being used for insert->image->from file and > filter/source/svg which is being used for open file. The first is renderer of the svg files. If you insert the file as you mentioned, it will be stored as a svg file and svgio will render it using the drawing layer. The second is document importer. It imports the svg into Draw shape by shape and mappable style property by mappable style property. The result of such import (because there is no matching exporter) is basically an odg file, since our importer API is internally using flag ODF anyway. > Which one is "the future", and what prevents us from using it in > both places ? There might be a possibility to share some code, I guess. Although, I am not sure whether the parsers use the same approach. The filter/source/svg one is basically constructing DOM and then several "visitors" are running through the structure and extracting useful information. Cheers F. -BEGIN PGP SIGNATURE- Version: GnuPG v2 iEYEARECAAYFAlY6KPMACgkQu9a1imXPdA9+lgCeL+2A2ccg/VqX8LeXGlVKoa8Q fq8An3kNvcQz/A18dE3l33SPg4ocLd2c =D+56 -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Changes to 'refs/changes/92/2592/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/21/5021/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/95/5095/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/96/4196/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/96/4196/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/95/5095/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: GSoC mid-term evaluations NOW
I see all mentor evaluation being filled. So this should be ok by now. F. On 26/06/14 16:14, Bjoern Michaelsen wrote: Hi Cedric, Hi Fridrich, melange is crapping out on me. Neither my bjoern.michael...@gmail.com nor my bjoern.michael...@canonical.com account lets me take any action/evaluation. As mst (co-mentor) is on vacation too and possibly hasnt filed this, please handle this for me. Thanks. Best, Bjoern On Tue, Jun 17, 2014 at 08:06:30AM +0200, Cedric Bosdonnat wrote: The mid-term evaluations are just now! So, head to Google Melange and submit them before Friday. In case you really can't fill the evaluation your self, ask either your co-mentor or one of your beloved admins (Fridrich, Thorsten or myself) to do it. Below are the questions of the form. 1. How many years have you been a mentor for Google Summer of Code (Total - this doesn’t have to be consecutive)? 1. This is my first year 2. 2-3 years 2. 2-3 years 3. More than 3 years 2. If you answered “2-3 years” or “more than 3 years” as a mentor, what years did you participate? 3. How many years have you been a student in Google Summer of Code? 1. I have never been a student 1. I have never been a student 2. 1 year 3. 2 years 4. 3+ years 4. If you answered 2 years or 3+ years, what years did you participate as a student? 5. At what point did you first make contact with your student? 1. Before the program was announced 2. After my organization was selected to participate in Google Summer of Code 3. During the student application/acceptance phase of the program 3. During the student application/acceptance phase of the program 4. During the community bonding period 5. After the start of coding 6. How often do you and your student interact? 1. Daily 2. Every few days 3. Weekly 4. Every few weeks 4. Every few weeks 5. Monthly 6. Less than once a month 7. How do you communicate with your student? (Check all that apply) 1. Google+ Hangout 2. Voice (phone, Skype, etc.) 3. IM/IRC 3. IM/IRC 4. Private emails 5. Mailing Lists 5. Mailing Lists 6. Student blog updates 7. In-person meeting(s) 8. Other 8. Of the communication methods listed above, which do you use most frequently? IRC 9. How much time do you spend on Google Summer of Code per week (take into consideration your interactions with your student as well as time working with your org and on your own)? 1. 1-5 hours 1. 1-5 hours 2. 5-10 hours 3. 10-15 hours 4. 15-20 hours 5. More than 20 hours per week 10. How many time zones apart from your student are you? 1. Less than 3 2. 3-6 3. More than 6 11. How often do you require status updates from your student? 1. Daily 2. Every few days 3. Weekly 3. Weekly 4. Only when explicitly asked for by me 12. Please rate the quality of your interactions and communications with the student (consider his/her communication with you as well as your responses). 1. Very Good (Student is regularly responsive and the quality of communication is high) 1. Very Good (Student is regularly responsive and the quality of communication is high) 2. Good (Student is somewhat responsive and the quality of communication is okay) 3. Bad (Student is only somewhat or not at all responsive and the quality of communication is low) 13. Please rate the quality of
Bern conference and arrivals information
Since there was quite a confusion of people trying to book flights to Bern Belp airport, here is a useful information: Bern Belp is a small airport and there is no point to try to book until there. Bern is located in the middle way between Geneva Airport and Zurich Airport. About 150 km from each side, might be 10 less from Zurich. Both Geneva and Zurich airport have train station inside the airport, so it is really convenient to get a train and the train between Bern and those location go every 30 minutes at least. That is why the best is to check which of the two places gives you better price and then add to it the need of train ticket. Zurich Airport - Bern or Geneva Airport - Bern ticket price is 53CHF in normal 2nd class. And it will bring you to the main station of Bern that is in the center of the town. Cheers F. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [GSoc 14] On Improve Text Boxes in Draw - towards a more specific description and starting directions
Hello, Matteo, Un piacere di vederti interessato in questo progetto. On 18/03/14 06:23, Matteo Campanelli wrote: - /text background color:/ It seems to me that it is possible to specify a text box background in color in Draw. Are we then referring to background color of the text only? Yes, it is possible to specify the colour of the text box itself, but it is not possible to specify the background of the text itself. The problem can be seen in import filters, where in the original applications the text, that has non-transparent (i.e. white) background, is describing lines (like in technical drawings). Because the background is transparent, the text is basically unreadable because of the line that is under it. Would that be, in other words, some colored rectangle around only part of the text in the box (a bit like text background color in Writer)? Exactly, including different degrees of transparency. - /flow of contents from one frame to another:/ I am not sure I know what we are talking about here, but I would imagine it as The text in a frame may (dynamically) constitute part of the text in another frame. Let me illustrate this: Alice has two text frames, named respectively TF1 and TF2. The text in TF1 may look like: Lorem ipsum... As illustrated in the box above: [TF2.text] Ut enim ad minim... Here, the macro TF2.text would expand to whatever text is contained in the other frame. In the ODF file-format, there is a possibility to specify a sequence of frames where text, when arrives at the end of one frame overflows into the next one. Is this in any way close to what the project description is talking about? Is there already something like this in Draw or LO in general, i..e ways. to reference other objects' properties explicitly? Not in Draw yet. We have in LibreOffice already this feature implemented for Writer, where you can do this kind of linked frames. The goal would be to implement something similar in Draw. What exists in Draw is a code that actually detects whether a text overflows beyond a height of a frame. This code is used for frames whose height is (in the file-format) specified as a minimum height and where if the text does not fit, you have to grow the frame. Ideally, it would be possible to reuse that code, but I am not sure completely. - /hyphenation:/ About this point, I wanted to ask a more technical and at the same time general type of question: from the documentation on the class ImpEditEngine ([2] http://docs.libreoffice.org/editeng/html/classImpEditEngine.html#a6163e18b8db452f3324561f92542) I see that there are getters and setters for hyphenators and a method called ImpBreakLine. This suggests to me that ImpEditEngine may be involved directly in how or whether hyphenation is done in text frames. How does this class actually works? What are its responsibilities (since it seems to deal with a LOT of stuff)? Could anyone exemplify or point how this class affects hyphenation in, say, Writer or any other parts of LO? (or alternatively could anyone redirect me to some semi-digestible snippets of code in LOI see where this magic happens?) This is something that Thorsten or Kohei could answer better, since they are more conversant with the edit engine. - /support of style:/ I see that Draw already has a Style and Formatting dialog offering several options. What would be the specific enhancements for this point? I would in the first time look what is possible to specify in the Style and Formatting in Draw and what is possible in Writer. The first goal would be to bring them at the same level. Now, be aware that we might discover that any of this task is more complicated then what we think. Therefore, the work could be done from the highest to the lowest priority. The priorities go roughly in the order of your questions. First the text background, then linked frames and then the other two in whichever order. Even though the hyphenation is slightly more important since having it would allow Draw to start to function as a simple DTP application. Thanks for your interest. I hope that I answered at least some of your questions. Cheers Fridrich ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Late feature: AbiWord import filter
Dearest developer community, As discussed today at ESC, I will need 3 reviews for the AbiWord import filter for 4-2 branch. As the translators have no problem with one additional string, they suggested that 4-2-0 could go to. That is why I submitted 2 patches to gerrit: 1) https://gerrit.libreoffice.org/7478 for 4-2, and 2) https://gerrit.libreoffice.org/7479 for 4-2-1 I would appreciate your review for both and if it is possible the sooner the better. Thanks for your good will Fridrich ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Google Summer of Code 2014
Friends, Just to keep you updated that the organization applications for the Google Summer of Code 2014 will start the Monday after FOSDEM[1]. We volunteer with Cedric to administer it this year too. But we would need your help to update the ideas page with whatever idea you might have and clean out the ideas that were finished in the previous cycle. We will update the wiki little by little with the important dates. Cheers Fridrich [1] http://www.google-melange.com/gsoc/document/show/gsoc_program/google/gsoc2014/help_page#2._What_is_the_program_timeline [2] https://wiki.documentfoundation.org/Development/Gsoc/Ideas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: OpenDocument text (Flat XML) .fodt
Hello, On 02/01/14 16:04, John Robson wrote: Thank you, but not solve, the lines continue large. But, this is not a bug, is just a good feature. As I said before, break lines in smaller columns will improve the versioning results when you work in a collaborative way. The Flat ODF filter uses DocumentHandlerAdapter from sax/tools/documenthandleradapter.hxx What you need basically is to modify somehow the characters method so that it iterates through the aChars and spit a serie of calls of m_handler-characters split at the word boundaries. Something like iterating through the string and keep the position of the last white-space and if you are over the position 80 pass a sub-string until the last white-space found before the position 80. And do that until the string is passed completely. Not sure what kind of performance penalty would this create. But one could do that only if pretty printing is selected. Hope the pointers are good enough F. -- Please avoid sending me Word, Excel or PowerPoint attachments. See http://www.gnu.org/philosophy/no-word-attachments.html signature.asc Description: OpenPGP digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
License statement
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 All of my past future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. Cheers, Fridrich -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlJyHyMACgkQu9a1imXPdA9trACfX/ms89eRhm04qFH08rtvQBrd GM0AniEL8dx+jJ9ZH9bddSbNAGk6G/C3 =E+qZ -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: License statement
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 31/10/13 10:13, Fridrich Strba wrote: All of my past future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. Where the past clearly was covered by http://lists.freedesktop.org/archives/libreoffice/2011-October/019659.html already Cheers, Fridrich -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlJyH34ACgkQu9a1imXPdA8GVACeNdj41Gl+kqFurTcjgJpgsMrJ UjUAnA+jfV7EQIzRAadTSYKO2I/SOCvH =FhJO -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: gcc-wrapper / liborcus bustage ...
Hello, On 18/09/13 18:13, Michael Meeks wrote: Apparently other people don't build on windows in /opt ;-) but - I'd like to fix this; I pushed this to at least give a more helpful warning - though I guess it will trigger for everyone as of now: We consistently instructed Windows builders since several years to build in something that they accessed by /cygdrive/ Building in cygwin virtual paths is a sure way to doom. Seriously! You might find many more hideous problems and waste more of your precious time. F. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [BUG] or [EVOL] about arrow enlargement in libreoffice draw ?
On 12/09/13 23:53, Jan Holesovsky wrote: LibreOffice is missing a feature to scale attributes like line thickness, font size, etc. [...] But of course would be useful to have a modifier to allow this. Moreover, in CorelDraw, there is a line property that determines whether the line scales with the image or not. So whatever default one would use (were it possible within LO Draw), one would find a number of people having the opposite opinion. The rule of the thumb we had when reverse-engineering and implementing the filter was to provide as good as possible static conversion. That means that we are trying to find a way to scale the width of a line in cases where the width is scaled in CDR by different ratios for x and y axes and so on. We were always aware that the result will not be perfect in all cases, but it will be ok in most of them. That was our vision then :) F. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] add automatic git hook setting in autogen.sh
, $_, $src_limited);
+}
+if (/property name=use_markupTrue\/property/)
+{
+bad_line(use font attributes instead of use-markup, $_,
$src_limited);
+}
+}
+}
+if ( $found_bad)
+{
+exit($found_bad);
+}
+}
+
+# Do the work :-)
+
+# Initial commit: diff against an empty tree object
+my $against=4b825dc642cb6eb9a060e54bf8d69288fbee4904;
+if ( system( git rev-parse --verify HEAD /dev/null 21 ) == 0 )
+{
+$against=HEAD
+}
+
+# If you want to allow non-ascii filenames set this variable to true.
+my $allownonascii=`git config hooks.allownonascii`;
+
+# Cross platform projects tend to avoid non-ascii filenames; prevent
+# them from being added to the repository. We exploit the fact that the
+# printable range starts at the space character and ends with tilde.
+if ( $allownonascii ne true
+# Note that the use of brackets around a tr range is ok here, (it's
+# even required, for portability to Solaris 10's /usr/bin/tr), since
+# the square bracket bytes happen to fall in the designated range.
+`git diff --cached --name-only --diff-filter=A -z $against | \
+ LC_ALL=C tr -d '[ -~]\\0'` ne )
+{
+print EOM;
+Error: Attempt to add a non-ascii file name.
+
+This can cause problems if you want to work
+with people on other platforms.
+
+To be portable it is advisable to rename the file ...
+
+If you know what you are doing you can disable this
+check using:
+
+ git config hooks.allownonascii true
+
+EOM
+exit( 1 );
+}
+
+# fix whitespace in code
+check_whitespaces( $against);
+
+# all OK
+exit( 0 );
+# vi:set shiftwidth=4 expandtab:
diff --git a/autogen.sh b/autogen.sh
index 02903a2..fcb084b 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -1,4 +1,20 @@
#!/bin/sh
+
+set_git_hooks()
+{
+# assume that the current directory is the source tree
+if [ -d .git ] ; then
+for hook in $(ls -1 .git-hooks) ; do
+cd .git/hooks
+if [ ! -e ${hook?} -o -L ${hook?} ] ; then
+rm -f ${hook?}
+ln -sf ../../.git-hooks/${hook?} ${hook?}
+fi
+cd - /dev/null
+done
+fi
+}
+
TESTLIBTOOLIZE=glibtoolize libtoolize
LIBTOOLIZEFOUND=0
@@ -8,6 +24,8 @@
olddir=`pwd`
cd $srcdir
+
+set_git_hooks
aclocal --version /dev/null 2 /dev/null || {
echo error: aclocal not found
@@ -19,16 +37,16 @@
}
for i in $TESTLIBTOOLIZE; do
- if which $i /dev/null 21; then
- LIBTOOLIZE=$i
- LIBTOOLIZEFOUND=1
- break
- fi
+if which $i /dev/null 21; then
+LIBTOOLIZE=$i
+LIBTOOLIZEFOUND=1
+break
+fi
done
if [ $LIBTOOLIZEFOUND = 0 ]; then
- echo $0: need libtoolize tool to build libvisio 2
- exit 1
+echo $0: need libtoolize tool to build libvisio 2
+exit 1
fi
amcheck=`automake --version | grep 'automake (GNU automake) 1.5'`
--
To view, visit https://gerrit.libreoffice.org/5748
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I95eb02dc2d347337d7b85f85d6459353278fb137
Gerrit-PatchSet: 1
Gerrit-Project: libvisio
Gerrit-Branch: master
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] add automatic git hook setting in autogen.sh
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/5745 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/5745 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95eb02dc2d347337d7b85f85d6459353278fb137 Gerrit-PatchSet: 2 Gerrit-Project: libcdr Gerrit-Branch: master Gerrit-Owner: Norbert Thiebaud nthieb...@gmail.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] add automatic git hook setting in autogen.sh
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/5748 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/5748 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95eb02dc2d347337d7b85f85d6459353278fb137 Gerrit-PatchSet: 2 Gerrit-Project: libvisio Gerrit-Branch: master Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] add automatic git hook setting in autogen.sh
, $_, $src_limited);
+}
+if (/property name=use_markupTrue\/property/)
+{
+bad_line(use font attributes instead of use-markup, $_,
$src_limited);
+}
+}
+}
+if ( $found_bad)
+{
+exit($found_bad);
+}
+}
+
+# Do the work :-)
+
+# Initial commit: diff against an empty tree object
+my $against=4b825dc642cb6eb9a060e54bf8d69288fbee4904;
+if ( system( git rev-parse --verify HEAD /dev/null 21 ) == 0 )
+{
+$against=HEAD
+}
+
+# If you want to allow non-ascii filenames set this variable to true.
+my $allownonascii=`git config hooks.allownonascii`;
+
+# Cross platform projects tend to avoid non-ascii filenames; prevent
+# them from being added to the repository. We exploit the fact that the
+# printable range starts at the space character and ends with tilde.
+if ( $allownonascii ne true
+# Note that the use of brackets around a tr range is ok here, (it's
+# even required, for portability to Solaris 10's /usr/bin/tr), since
+# the square bracket bytes happen to fall in the designated range.
+`git diff --cached --name-only --diff-filter=A -z $against | \
+ LC_ALL=C tr -d '[ -~]\\0'` ne )
+{
+print EOM;
+Error: Attempt to add a non-ascii file name.
+
+This can cause problems if you want to work
+with people on other platforms.
+
+To be portable it is advisable to rename the file ...
+
+If you know what you are doing you can disable this
+check using:
+
+ git config hooks.allownonascii true
+
+EOM
+exit( 1 );
+}
+
+# fix whitespace in code
+check_whitespaces( $against);
+
+# all OK
+exit( 0 );
+# vi:set shiftwidth=4 expandtab:
diff --git a/autogen.sh b/autogen.sh
index 25eef51..252f93d 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -1,4 +1,20 @@
#!/bin/sh
+
+set_git_hooks()
+{
+# assume that the current directory is the source tree
+if [ -d .git ] ; then
+for hook in $(ls -1 .git-hooks) ; do
+cd .git/hooks
+if [ ! -e ${hook?} -o -L ${hook?} ] ; then
+rm -f ${hook?}
+ln -sf ../../.git-hooks/${hook?} ${hook?}
+fi
+cd - /dev/null
+done
+fi
+}
+
TESTLIBTOOLIZE=glibtoolize libtoolize
LIBTOOLIZEFOUND=0
@@ -8,6 +24,8 @@
olddir=`pwd`
cd $srcdir
+
+set_git_hooks
aclocal --version /dev/null 2 /dev/null || {
echo error: aclocal not found
@@ -19,16 +37,16 @@
}
for i in $TESTLIBTOOLIZE; do
- if which $i /dev/null 21; then
- LIBTOOLIZE=$i
- LIBTOOLIZEFOUND=1
- break
- fi
+if which $i /dev/null 21; then
+LIBTOOLIZE=$i
+LIBTOOLIZEFOUND=1
+break
+fi
done
if [ $LIBTOOLIZEFOUND = 0 ]; then
- echo $0: need libtoolize tool to build libmspub 2
- exit 1
+echo $0: need libtoolize tool to build libmspub 2
+exit 1
fi
amcheck=`automake --version | grep 'automake (GNU automake) 1.5'`
--
To view, visit https://gerrit.libreoffice.org/5749
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I95eb02dc2d347337d7b85f85d6459353278fb137
Gerrit-PatchSet: 1
Gerrit-Project: libmspub
Gerrit-Branch: master
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] add automatic git hook setting in autogen.sh
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/5749 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/5749 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95eb02dc2d347337d7b85f85d6459353278fb137 Gerrit-PatchSet: 2 Gerrit-Project: libmspub Gerrit-Branch: master Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
libcdr/libvisio/libmspub and gerrit
I just pushed Norbert's contribution to libcdr/libmspub/libvisio. They are commit hooks that should make it much easier to collaborate. After one sets the gerrit access according to this wiki article: https://wiki.documentfoundation.org/Development/gerrit/setup#Setting_yourself_up_for_gerrit_-_the_manual_way And one runs ./autogen.sh in the git checkout, one can push the work into gerrit directly using git push origin HEAD:refs/for/master It is then trivial for me to review patches in gerrit even from my phone or public computer. It is still good to drop me an e-mail to fridrich dot strba at bluewin dot ch so that I know quickly that there is something to review. In case some of the steps are not clear, I am here to give answers :) F. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: build difficulty
Sometimes my question is why on the earth one does not make something non-copyable by declaring and not defining private copy constructor and operator= and bothers with the complexity of boost for just this little thing. Get me right, I love boost, since it simplifies many things, but then noncopyable is not one of those things that were difficult without it. Cheers Fridrich On 29/08/13 21:30, Kohei Yoshida wrote: On 08/29/2013 03:27 PM, Stephan van den Akker wrote: Kohei: Can you explain what your change does? I might try that too. No idea exactly, other than that it avoids the lines that cause error in my build. I got the idea by reading the offending boost header file boost/boost/noncopyable.hpp. Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: build difficulty
On 30/08/13 11:11, Stephan Bergmann wrote: ...because boost::noncopyable has become the de-facto standard idiom for this, at least for pre-C++11 code that depends on Boost anyway. [citation missing] Sure, nice to have standard idiom that causes us to have to work-around implementation bugs. Where two private declarations could be enough. But then maybe I am too low-level for the modern C++ developers. I even know how to manage my memory myself :) F. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: build difficulty
On 30/08/13 12:15, bjoern wrote: There are two kinds of people making this statement: Those that have been wrong and those that will be. ;) Sure, don't worry, I'll shut up :) F. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Changed the Corel Draw versions for udta
Hi,
I would like you to review the following patch:
https://gerrit.libreoffice.org/5716
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/libcdr refs/changes/16/5716/1
Changed the Corel Draw versions for udta
Change-Id: I56858984c6ce67d732294020669687053b7b8b50
---
M src/lib/CDRParser.cpp
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/CDRParser.cpp b/src/lib/CDRParser.cpp
index 9308ff3..06280b7 100644
--- a/src/lib/CDRParser.cpp
+++ b/src/lib/CDRParser.cpp
@@ -3285,7 +3285,7 @@
void libcdr::CDRParser::readUdta(WPXInputStream *input)
{
CDR_DEBUG_MSG((libcdr::CDRParser::readUdta\n));
- if (m_version == 1400)
+ if (m_version = 1300 m_version = 1500)
{
input-seek(6, WPX_SEEK_CUR); // Not sure what these bytes are for. Field
id?
std::vectorunsigned char name;
--
To view, visit https://gerrit.libreoffice.org/5716
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I56858984c6ce67d732294020669687053b7b8b50
Gerrit-PatchSet: 1
Gerrit-Project: libcdr
Gerrit-Branch: master
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Little tiny nit
Hi,
I would like you to review the following patch:
https://gerrit.libreoffice.org/5717
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/libcdr refs/changes/17/5717/1
Little tiny nit
Change-Id: Ib4fed604412afdaeb3ec0b03c1c8328eae554842
---
M src/lib/CDRParser.cpp
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/CDRParser.cpp b/src/lib/CDRParser.cpp
index 06280b7..1b1dcc9 100644
--- a/src/lib/CDRParser.cpp
+++ b/src/lib/CDRParser.cpp
@@ -3285,7 +3285,7 @@
void libcdr::CDRParser::readUdta(WPXInputStream *input)
{
CDR_DEBUG_MSG((libcdr::CDRParser::readUdta\n));
- if (m_version = 1300 m_version = 1500)
+ if (m_version = 1300 m_version 1600)
{
input-seek(6, WPX_SEEK_CUR); // Not sure what these bytes are for. Field
id?
std::vectorunsigned char name;
--
To view, visit https://gerrit.libreoffice.org/5717
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4fed604412afdaeb3ec0b03c1c8328eae554842
Gerrit-PatchSet: 1
Gerrit-Project: libcdr
Gerrit-Branch: master
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Little tiny nit
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/5717 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/5717 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4fed604412afdaeb3ec0b03c1c8328eae554842 Gerrit-PatchSet: 2 Gerrit-Project: libcdr Gerrit-Branch: master Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Fix windows libo crash with graphite fonts.
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/5644 Approvals: LibreOffice gerrit bot: Verified Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/5644 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c5825420d9ea5768564253789a28412f3c1900a Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Martin Hosken martin_hos...@sil.org Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: openSuse fbembed/fbclient linking issues due to incorrect fbembed.pc
On 20/08/13 13:58, Andrzej Hunt wrote: There is the (very remote) possibility that someone might want to specifically build against fbclient -- however that's probably very rare and most of the time fbclient would only be used accidentally, so the above possibility does seem best -- I'll try and add that. I really don't know whether one should really bother with this. It was clearly a packaging/patch error and -- at least in openSUSE -- it is on the way to be solved (repository server:database has already fixed packages). So, I would not give it much importance :) F. -- Please avoid sending me Word, Excel or PowerPoint attachments. See http://www.gnu.org/philosophy/no-word-attachments.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-1] fdo#67093 Change traduction of Header in it to avoid conflic...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/5093 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/5093 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2c7d4c7df2f492a6a10081c9ed4e99ac9e61e73 Gerrit-PatchSet: 2 Gerrit-Project: translations Gerrit-Branch: libreoffice-4-1 Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fdo#67093 Change traduction of Header in it to avoid conflic...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/5092 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/5092 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2c7d4c7df2f492a6a10081c9ed4e99ac9e61e73 Gerrit-PatchSet: 2 Gerrit-Project: translations Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: starmath/inc starmath/source
starmath/inc/document.hxx|2 --
starmath/source/document.cxx |7 ---
2 files changed, 4 insertions(+), 5 deletions(-)
New commits:
commit 5dd1cd72f45df0ec13842d4ee9c849726cb74ea9
Author: Fridrich Strba fridr...@documentfoundation.org
Date: Thu Jul 25 08:55:35 2013 +
Revert Fix memory leak in Math, by holding SmModel pointer
Breaks unit tests of rtf import
This reverts commit ef66cc105e0051fa1414b72c5ee2bf1b2f9331cb
Change-Id: I95c13fc2bc3f9494a33153c62a7d52eb6f8efdd9
Reviewed-on: https://gerrit.libreoffice.org/5095
Reviewed-by: Fridrich Strba fridr...@documentfoundation.org
Tested-by: Fridrich Strba fridr...@documentfoundation.org
diff --git a/starmath/inc/document.hxx b/starmath/inc/document.hxx
index f86207d..4446ad0 100644
--- a/starmath/inc/document.hxx
+++ b/starmath/inc/document.hxx
@@ -39,7 +39,6 @@
#include format.hxx
#include parse.hxx
#include smmod.hxx
-#include unomodel.hxx
class SmNode;
class SfxMenuBarManager;
@@ -96,7 +95,6 @@ class SmDocShell : public SfxObjectShell, public SfxListener
OUStringaText;
SmFormataFormat;
SmParseraInterpreter;
-SmModel*pModel;
OUStringaAccText;
SmNode *pTree;
SfxMenuBarManager *pMenuMgr;
diff --git a/starmath/source/document.cxx b/starmath/source/document.cxx
index edc635e..e49faec 100644
--- a/starmath/source/document.cxx
+++ b/starmath/source/document.cxx
@@ -684,7 +684,6 @@ void SmDocShell::Repaint()
SmDocShell::SmDocShell( const sal_uInt64 i_nSfxCreationFlags ) :
SfxObjectShell( i_nSfxCreationFlags ),
-pModel ( new SmModel(this) ),
pTree ( 0 ),
pEditEngineItemPool ( 0 ),
pEditEngine ( 0 ),
@@ -704,9 +703,11 @@ SmDocShell::SmDocShell( const sal_uInt64
i_nSfxCreationFlags ) :
StartListening(aFormat);
StartListening(*pp-GetConfig());
-SetBaseModel( pModel );
+SetBaseModel( new SmModel(this) );
}
+
+
SmDocShell::~SmDocShell()
{
SAL_INFO( starmath, starmath: SmDocShell::~SmDocShell );
@@ -716,6 +717,7 @@ SmDocShell::~SmDocShell()
EndListening(aFormat);
EndListening(*pp-GetConfig());
+
if(pCursor)
delete pCursor;
pCursor = NULL;
@@ -724,7 +726,6 @@ SmDocShell::~SmDocShell()
SfxItemPool::Free(pEditEngineItemPool);
delete pTree;
delete pPrinter;
-delete pModel;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: starmath/inc starmath/source
starmath/inc/ElementsDockingWindow.hxx|1 -
starmath/source/ElementsDockingWindow.cxx |5 -
2 files changed, 6 deletions(-)
New commits:
commit f9e981ba0e2da6ce122e3ef30aef057c439c8fb8
Author: Fridrich Strba fridr...@documentfoundation.org
Date: Mon Jul 22 09:22:31 2013 +
Revert Math: Fix memory leak with SmDocShell
It breaks make check
This reverts commit d3cf684146162a1528046ab2bcd7d9fa94443c69
Change-Id: Iae8ef2a49a395e885aa8ab3658244836c9ce71c5
Reviewed-on: https://gerrit.libreoffice.org/5021
Reviewed-by: Fridrich Strba fridr...@documentfoundation.org
Tested-by: Fridrich Strba fridr...@documentfoundation.org
diff --git a/starmath/inc/ElementsDockingWindow.hxx
b/starmath/inc/ElementsDockingWindow.hxx
index 9a98cf9..c46cf79 100644
--- a/starmath/inc/ElementsDockingWindow.hxx
+++ b/starmath/inc/ElementsDockingWindow.hxx
@@ -100,7 +100,6 @@ class SmElementsControl : public Control
public:
SmElementsControl(Window *pParent, const ResId rResId);
-~SmElementsControl();
void setElementSetId(sal_uInt16 aSetId);
diff --git a/starmath/source/ElementsDockingWindow.cxx
b/starmath/source/ElementsDockingWindow.cxx
index d7656f5..8f71602 100644
--- a/starmath/source/ElementsDockingWindow.cxx
+++ b/starmath/source/ElementsDockingWindow.cxx
@@ -178,11 +178,6 @@ SmElementsControl::SmElementsControl(Window *pParent,
const ResId rResId) :
maFormat.SetBaseSize(PixelToLogic(Size(0, 24)));
}
-SmElementsControl::~SmElementsControl()
-{
-delete mpDocShell;
-}
-
void SmElementsControl::setVerticalMode(bool bVerticalMode)
{
mbVerticalMode = bVerticalMode;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] Downgraded the Dutch spellchecker to version 2.00 ( fdo#6303...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4987 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4987 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e21a40f03b44a336355500bb617865ca2704125 Gerrit-PatchSet: 4 Gerrit-Project: dictionaries Gerrit-Branch: master Gerrit-Owner: Thomas van der meulen meulentho...@gmail.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fdo#67093 Change traduction of Title for some more languages
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/5038 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/5038 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibcd7d03c9ea7608c8963d1cb9b7c2d7cbe2415d5 Gerrit-PatchSet: 2 Gerrit-Project: translations Gerrit-Branch: master Gerrit-Owner: Christian Lohmaier lohmaier+libreoff...@googlemail.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-1] fdo#67093 Change traduction of Title in french to avoid conf...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4995 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4995 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia87132d3593097cc9d7b81a254c300de8b9fa3a5 Gerrit-PatchSet: 3 Gerrit-Project: translations Gerrit-Branch: libreoffice-4-1 Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fdo#67093 Change traduction of Title in french to avoid conf...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4994 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4994 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia87132d3593097cc9d7b81a254c300de8b9fa3a5 Gerrit-PatchSet: 3 Gerrit-Project: translations Gerrit-Branch: master Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-1] updated Spanish dictionary pack to 0.7
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4985 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4985 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c852b6b7796822cb5c72c4633fab48003fdc147 Gerrit-PatchSet: 2 Gerrit-Project: dictionaries Gerrit-Branch: libreoffice-4-1 Gerrit-Owner: Andras Timar ati...@suse.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-0] updated Spanish dictionary pack to 0.7
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4986 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4986 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae6fef300292f1df2753f7bdb45040d66c168bb6 Gerrit-PatchSet: 2 Gerrit-Project: dictionaries Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Andras Timar ati...@suse.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] module sot: String, bool and other clean-up
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4710 Approvals: LibreOffice gerrit bot: Verified Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4710 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe2bfdf20c500e9fd98c3baef66d36aa79ca4b52 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Norbert Thiebaud nthieb...@gmail.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] OUString convertion for unotools
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4659 Approvals: LibreOffice gerrit bot: Verified Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4659 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifae7f344e3827875e32afa3cda23c771f5735707 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Norbert Thiebaud nthieb...@gmail.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] MSVC build fixes
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4581 Approvals: LibreOffice gerrit bot: Verified Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4581 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I189fe3635f94fdd6b91bd7930c7abf02e70368aa Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Tor Lillqvist t...@iki.fi Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#43460 sc: use isEmpty()
Hello Tor Lillqvist, LibreOffice gerrit bot, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/4316 to look at the new rebased patch set (#3). Change subject: fdo#43460 sc: use isEmpty() .. fdo#43460 sc: use isEmpty() Change-Id: I062570091ebea0ad30f09b0358ab664a3ff949ef --- M sc/source/core/data/documen3.cxx M sc/source/core/data/postit.cxx M sc/source/core/tool/compiler.cxx M sc/source/core/tool/dbdata.cxx M sc/source/core/tool/interpr2.cxx M sc/source/filter/oox/pagesettings.cxx M sc/source/filter/oox/querytablebuffer.cxx M sc/source/filter/xml/XMLStylesExportHelper.cxx M sc/source/filter/xml/xmlexprt.cxx M sc/source/filter/xml/xmltabi.cxx M sc/source/ui/docshell/docsh.cxx M sc/source/ui/unoobj/chart2uno.cxx M sc/source/ui/vba/vbafont.cxx M sc/source/ui/view/dbfunc3.cxx 14 files changed, 26 insertions(+), 26 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/16/4316/3 -- To view, visit https://gerrit.libreoffice.org/4316 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I062570091ebea0ad30f09b0358ab664a3ff949ef Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jelle van der Waa je...@vdwaa.nl Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fdo#43460 sc: use isEmpty()
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4316 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4316 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I062570091ebea0ad30f09b0358ab664a3ff949ef Gerrit-PatchSet: 4 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jelle van der Waa je...@vdwaa.nl Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-1] Add Amharic (am) auxiliary files
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4551 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4551 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ef1018e8b40b3c1626d5add7ffa217da6419a0c Gerrit-PatchSet: 3 Gerrit-Project: help Gerrit-Branch: libreoffice-4-1 Gerrit-Owner: Andras Timar ati...@suse.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-qa] [ANN] LibreOffice 3.6.7 RC1 test builds available
Hi *, for the upcoming new version 3.6.7, the RC1 builds now start to be available on pre-releases. This build is slated to be first release candidate build on the way towards 3.6.7, please refer to our release plan timings here: http://wiki.documentfoundation.org/ReleasePlan#3.6_release Builds are now being uploaded to a public (but non-mirrored - so don't spread news too widely!) place, as soon as they're available. Grab them here: http://dev-builds.libreoffice.org/pre-releases/ If you've a bit of time, please give them a try report *critical* bugs not yet in bugzilla here, so we can incorporate them into the release notes. Please note that it takes approximately 24 hours to populate the mirrors, so that's about the time we have to collect feedback. NOTE: This build is in a release configuration and _will_ replace your existing LibreOffice install on Windows. The list of fixed bugs relative to 3.6.6 is here: http://dev-builds.libreoffice.org/pre-releases/src/bugs-libreoffice-3-6-7-release-3.6.7.1.log So playing with the areas touched there also greatly appreciated - and validation that those bugs are really fixed. Thanks a lot for your help, Fridrich ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] [ANN] LibreOffice 4.1.0 RC1 test builds available
Hi *, for the upcoming new version 4.1.0, the RC1 builds now start to be available on pre-releases. This build is slated to be first release candidate build on the way towards 4.1.0, please refer to our release plan timings here: http://wiki.documentfoundation.org/ReleasePlan#4.1_release Builds are now being uploaded to a public (but non-mirrored - so don't spread news too widely!) place, as soon as they're available. Grab them here: http://dev-builds.libreoffice.org/pre-releases/ If you've a bit of time, please give them a try report *critical* bugs not yet in bugzilla here, so we can incorporate them into the release notes. Please note that it takes approximately 24 hours to populate the mirrors, so that's about the time we have to collect feedback. NOTE: This build is in a release configuration and _will_ replace your existing LibreOffice install on Windows. The list of fixed bugs relative to 4.1.0 beta2 is here: http://dev-builds.libreoffice.org/pre-releases/src/bugs-libreoffice-4-1-release-4.1.0.1.log So playing with the areas touched there also greatly appreciated - and validation that those bugs are really fixed. Thanks a lot for your help, Fridrich ___ LibreOffice mailing list libreoff...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[ANN] LibreOffice 4.1.0 RC1 test builds available
Hi *, for the upcoming new version 4.1.0, the RC1 builds now start to be available on pre-releases. This build is slated to be first release candidate build on the way towards 4.1.0, please refer to our release plan timings here: http://wiki.documentfoundation.org/ReleasePlan#4.1_release Builds are now being uploaded to a public (but non-mirrored - so don't spread news too widely!) place, as soon as they're available. Grab them here: http://dev-builds.libreoffice.org/pre-releases/ If you've a bit of time, please give them a try report *critical* bugs not yet in bugzilla here, so we can incorporate them into the release notes. Please note that it takes approximately 24 hours to populate the mirrors, so that's about the time we have to collect feedback. NOTE: This build is in a release configuration and _will_ replace your existing LibreOffice install on Windows. The list of fixed bugs relative to 4.1.0 beta2 is here: http://dev-builds.libreoffice.org/pre-releases/src/bugs-libreoffice-4-1-release-4.1.0.1.log So playing with the areas touched there also greatly appreciated - and validation that those bugs are really fixed. Thanks a lot for your help, Fridrich ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Please hold off modifying sc in the next few weeks
On 14/06/13 16:11, Bjoern Michaelsen wrote: Im not too happy with essentially shutting down all development on master on one application for an undefined timeframe. Can we make this a bit more bearable by: Bjoern, just read it again. He is asking not to merge changes like german comments or the wholesale string/sal_Bool changes that are low priority but complicate life when one tries to rebase changes. He also did not speak about indefinite. Kohei is know to be a fast and concise fellow, so don't worry, it will not take the same time as chart2. He just implores the clemency of the pears to make his re-factoring less of PITA. F. a/ a concrete timeframe, I would suggest until the 2013-06-30 (with the option to extend the block another week a few days before the end should the need arise) b/ make that work trackable and visible on a regularly pushed branch (maybe even regularly rebased), so it easier to see where possible conflicts arise c/ instead of suggesting to stop all work on calc, divert those changes to gerrit, were those could stay on hold until the refactoring is done, and be merged in due time afterwards ... Note also that some string refactorings or friends are global (e.g. removing a member function), and excluding these would block all of LO, which is obviously not a good thing. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[ANN] LibreOffice 4.0.4 RC2 test builds available
Hi *, for the upcoming new version 4.0.4, the RC2 builds now start to be available on pre-releases. This build is slated to be second release candidate build on the way towards 4.0.4, please refer to our release plan timings here: http://wiki.documentfoundation.org/ReleasePlan#4.0.4_release Builds are now being uploaded to a public (but non-mirrored - so don't spread news too widely!) place, as soon as they're available. Grab them here: http://dev-builds.libreoffice.org/pre-releases/ If you've a bit of time, please give them a try report *critical* bugs not yet in bugzilla here, so we can incorporate them into the release notes. Please note that it takes approximately 24 hours to populate the mirrors, so that's about the time we have to collect feedback. NOTE: This build is in a release configuration and _will_ replace your existing LibreOffice install on Windows. The list of fixed bugs relative to 4.0.4 RC1 is here: http://dev-builds.libreoffice.org/pre-releases/src/bugs-libreoffice-4-0-4-release-4.0.4.2.log So playing with the areas touched there also greatly appreciated - and validation that those bugs are really fixed. Thanks a lot for your help, Fridrich ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-qa] [ANN] LibreOffice 4.1.0.0 beta2 available for testing
Hi *, for the upcoming new version 4.1.0, we today upload a second beta2 build that is feature-complete. For further milestones on the way towards 4.1.0, please refer to our release plan timings here: http://wiki.documentfoundation.org/ReleasePlan#4.1_release Builds are now being uploaded to a public (but non-mirrored - so don't spread news too widely!) place, as soon as they're available. Grab them here: http://dev-builds.libreoffice.org/pre-releases/ If you've a bit of time, please give them a try report *critical* bugs not yet in bugzilla here, so we can incorporate them into the release notes. Please note that it takes approximately 24 hours to populate the mirrors, so that's about the time we have to collect feedback. The list of fixed bugs relative to 4.1.0 beta1 is here: http://dev-builds.libreoffice.org/pre-releases/src/bugs-libreoffice-4-1-release-4.1.0.0.beta2.log So playing with the areas touched there also greatly appreciated - and validation that those bugs are really fixed. Thanks a lot for your help, Fridrich ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[PUSHED libreoffice-4-0] copy values from the original item set
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4145 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4145 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9100dbe05c418a9dd1b819534a08076c9a4aed1c Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: David Tardon dtar...@redhat.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-0] jvmfwk: de-Pascalize do_msvcr71_magic
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4135 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4135 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77b3b591a94f4dfbb373938e3787f75e6a8e09c5 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Michael Stahl mst...@redhat.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Remove Tango icon duplicates using symlinks
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4113 Approvals: Mathias M: Looks good to me, but someone else must approve Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4113 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a4c09cdf6d60b90236663a4b7f30456a8c32e86 Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Rodolfo Ribeiro Gomes l...@rodolfo.eng.br Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org Gerrit-Reviewer: Mathias M m...@gmx.fr Gerrit-Reviewer: Rodolfo Ribeiro Gomes l...@rodolfo.eng.br ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fdo#60924 autoinstall - gbuild/scp2: add math module
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4065 Approvals: LibreOffice gerrit bot: Verified Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4065 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I466dd68069576d57740ef34b8f6fcd8f9025c5c8 Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza marcos.souza@gmail.com Gerrit-Reviewer: David Tardon dtar...@redhat.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org Gerrit-Reviewer: Marcos Souza marcos.souza@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-0] fix copying of MSVC2008 runtime DLLs
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4110 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4110 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3ba5bdb1f28b619add7d2e255cd9e1edc0d1bd1 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Michael Stahl mst...@redhat.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-0] libcdr: fix build with MSVC2008
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4109 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4109 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70731e13ab4ef0d6eadd803b8f6a24f565be5346 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Michael Stahl mst...@redhat.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Fix crash with ooo120774-1.doc
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/4114
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/14/4114/1
Fix crash with ooo120774-1.doc
Do not try to remove line breaks from empty string
Change-Id: Ieb12c541d42944aac813cee10ce479207b1c674b
---
M sw/source/core/doc/doctxm.cxx
1 file changed, 2 insertions(+), 0 deletions(-)
diff --git a/sw/source/core/doc/doctxm.cxx b/sw/source/core/doc/doctxm.cxx
index d56cf61..f5372a7 100644
--- a/sw/source/core/doc/doctxm.cxx
+++ b/sw/source/core/doc/doctxm.cxx
@@ -1533,6 +1533,8 @@
/// to a single space, and trailing space removed.
String lcl_RemoveLineBreaks( String sRet )
{
+if (!sRet.Len())
+return sRet;
xub_StrLen nOffset = 0;
sRet.SearchAndReplaceAll('\n', ' ');
for (xub_StrLen i = 1; i sRet.Len(); i++)
--
To view, visit https://gerrit.libreoffice.org/4114
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb12c541d42944aac813cee10ce479207b1c674b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Fix crash with ooo120774-1.doc
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4114 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4114 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb12c541d42944aac813cee10ce479207b1c674b Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Release configuration QA builds for Windows from 4-1 branch
Hello, all beta testers, To make it a bit easier to test the Windows versions of our upcoming 4.1 release, we set a tinderbox that produces in principle every day a build of the libreoffice-4-1 branch in the release configuration with all supported languages and with all helppacks that are normally distributed in the release builds. Please, when confirming bugs for Windows, or looking for regressions, please use those builds so that we have a early alert in case a regression is introduced between an official build and the time of testing. Note, that properly triaged bug with a good instructions to reproduce will have increased chance to be fixed quickly. Cheers and thanks for your hard work Fridrich ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Fix crash with fdo60063-1.docx
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/4091
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/91/4091/1
Fix crash with fdo60063-1.docx
Change-Id: I11d036c2d54cde2d3c311a77c115011246f38d0a
---
M oox/source/docprop/docprophandler.cxx
1 file changed, 11 insertions(+), 27 deletions(-)
diff --git a/oox/source/docprop/docprophandler.cxx
b/oox/source/docprop/docprophandler.cxx
index d81199f..60e425f 100644
--- a/oox/source/docprop/docprophandler.cxx
+++ b/oox/source/docprop/docprophandler.cxx
@@ -25,6 +25,8 @@
#include osl/time.h
+#include boost/algorithm/string.hpp
+
#include oox/helper/attributelist.hxx
using namespace ::com::sun::star;
@@ -158,37 +160,19 @@
{
if ( !aChars.isEmpty() )
{
-uno::Sequence OUString aResult( 20 );
-sal_Int32 nCounter = 0;
+std::string aUtf8Chars = OUStringToOString(aChars,
RTL_TEXTENCODING_UTF8).getStr();
+std::vectorstd::string aUtf8Result;
+boost::split(aUtf8Result, aUtf8Chars, boost::is_any_of( ,;:\t));
-const sal_Unicode* pStr = aChars.getStr();
-for( sal_Int32 nInd = 0; nInd aChars.getLength() pStr[nInd] != 0;
nInd++ )
+if (!aUtf8Result.empty())
{
-switch( pStr[nInd] )
-{
-case (sal_Unicode)' ':
-case (sal_Unicode)',':
-case (sal_Unicode)';':
-case (sal_Unicode)':':
-case (sal_Unicode)'\t':
-// this is a delimiter
-// unfortunately I did not find any specification for the
possible delimiters
-if ( !aResult[nCounter].isEmpty() )
-{
-if ( nCounter = aResult.getLength() )
-aResult.realloc( nCounter + 10 );
-nCounter++;
-}
-break;
+uno::Sequence OUString aResult(aUtf8Result.size());
+OUString* pResultValues = aResult.getArray();
+for (std::vectorstd::string::const_iterator i =
aUtf8Result.begin(); i != aUtf8Result.end(); ++i, ++pResultValues)
+*pResultValues = OUString(i-c_str(),
static_castsal_Int32(i-size()),RTL_TEXTENCODING_UTF8);
-default:
-// this should be a part of keyword
-aResult[nCounter] += OUString( (sal_Unicode)pStr[nInd] );
-}
+return aResult;
}
-
-aResult.realloc( nCounter + 1 );
-return aResult;
}
return uno::Sequence OUString ();
--
To view, visit https://gerrit.libreoffice.org/4091
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11d036c2d54cde2d3c311a77c115011246f38d0a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Fix crash with fdo60063-1.docx
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4091 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4091 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11d036c2d54cde2d3c311a77c115011246f38d0a Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH libreoffice-4-0] Fix crash with fdo60063-1.docx
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/4093
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/93/4093/1
Fix crash with fdo60063-1.docx
Compared to the original version, this one tries hard
not to produce empty keywords.
Reviewed-on: https://gerrit.libreoffice.org/4091
Reviewed-by: Fridrich Strba fridr...@documentfoundation.org
Tested-by: Fridrich Strba fridr...@documentfoundation.org
(cherry picked from commit b2f97d77237cde249b4c40acc8ad3f7f8755e768)
(cherry picked from commit 693707e338922d8dc7578975a1990e8a1cba6a53)
Conflicts:
oox/source/docprop/docprophandler.cxx
Change-Id: I11d036c2d54cde2d3c311a77c115011246f38d0a
---
M oox/source/docprop/docprophandler.cxx
1 file changed, 13 insertions(+), 28 deletions(-)
diff --git a/oox/source/docprop/docprophandler.cxx
b/oox/source/docprop/docprophandler.cxx
index 1067315..ff6d170 100644
--- a/oox/source/docprop/docprophandler.cxx
+++ b/oox/source/docprop/docprophandler.cxx
@@ -25,6 +25,9 @@
#include osl/time.h
+#include vector
+#include boost/algorithm/string.hpp
+
#include oox/helper/attributelist.hxx
using namespace ::com::sun::star;
@@ -157,39 +160,21 @@
{
if ( !aChars.isEmpty() )
{
-uno::Sequence ::rtl::OUString aResult( 20 );
-sal_Int32 nCounter = 0;
+std::string aUtf8Chars = rtl::OUStringToOString( aChars,
RTL_TEXTENCODING_UTF8 ).getStr();
+std::vectorstd::string aUtf8Result;
+boost::split( aUtf8Result, aUtf8Chars, boost::is_any_of( ,;:\t),
boost::token_compress_on );
-const sal_Unicode* pStr = aChars.getStr();
-for( sal_Int32 nInd = 0; nInd aChars.getLength() pStr[nInd] != 0;
nInd++ )
+if (!aUtf8Result.empty())
{
-switch( pStr[nInd] )
-{
-case (sal_Unicode)' ':
-case (sal_Unicode)',':
-case (sal_Unicode)';':
-case (sal_Unicode)':':
-case (sal_Unicode)'\t':
-// this is a delimiter
-// unfortunately I did not find any specification for the
possible delimiters
-if ( !aResult[nCounter].isEmpty() )
-{
-if ( nCounter = aResult.getLength() )
-aResult.realloc( nCounter + 10 );
-nCounter++;
-}
-break;
+uno::Sequence rtl::OUString aResult( aUtf8Result.size() );
+OUString* pResultValues = aResult.getArray();
+for ( std::vector std::string ::const_iterator i =
aUtf8Result.begin();
+ i != aUtf8Result.end(); ++i, ++pResultValues )
+*pResultValues = rtl::OUString( i-c_str(), static_cast
sal_Int32 ( i-size() ),RTL_TEXTENCODING_UTF8 );
-default:
-// this should be a part of keyword
-aResult[nCounter] += ::rtl::OUString(
(sal_Unicode)pStr[nInd] );
-}
+return aResult;
}
-
-aResult.realloc( nCounter + 1 );
-return aResult;
}
-
return uno::Sequence ::rtl::OUString ();
}
//
--
To view, visit https://gerrit.libreoffice.org/4093
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11d036c2d54cde2d3c311a77c115011246f38d0a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH libreoffice-4-0] Accept even more corrupted zip documents as long as we can r...
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4094 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/94/4094/1 Accept even more corrupted zip documents as long as we can read them Change-Id: I8d039664d6c33d978b9addc3f35cbeae86d6c710 (cherry picked from commit 1b049bd2dae52dc154ea6bee075a254a9b6cc318) (cherry picked from commit d360333f83e3115219c3928525060c6c2a8711db) --- M package/source/zipapi/ZipFile.cxx 1 file changed, 0 insertions(+), 1 deletion(-) diff --git a/package/source/zipapi/ZipFile.cxx b/package/source/zipapi/ZipFile.cxx index 0da4c33..23d33c0 100644 --- a/package/source/zipapi/ZipFile.cxx +++ b/package/source/zipapi/ZipFile.cxx @@ -694,7 +694,6 @@ // with timestamp difference in the central directory entry and local // file header. bBroken = rEntry.nVersion != nVersion -|| (rEntry.nFlag ~6L) != (nFlag ~6L) || rEntry.nPathLen != nPathLen || !rEntry.sPath.equals( sLOCPath ); } -- To view, visit https://gerrit.libreoffice.org/4094 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8d039664d6c33d978b9addc3f35cbeae86d6c710 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Release configuration QA builds for Windows from 4-1 branch
Ah, sorry, On 30/05/13 13:04, Nino Novak wrote: where can I find these builds? http://dev-builds.libreoffice.org/daily/libreoffice-4-1/Win-x86_9-Voreppe/ Cheers F. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: idlec.exe crashed during build in cygwin
I saw it here on a machine where 8 processes were possible but then the memory amount only 4 GB. Is it possible that your builder is low on memory? In that case, could possible forcing 2 processes or even 1 help? Fridrich On 30/05/13 13:13, Michael Stahl wrote: On 20/05/13 11:53, Yuan Yeow Leow wrote: Hi, I followed the intructions listed in https://wiki.documentfoundation.org/Development/Windows_Build_Dependencies to build Libre Office in cygwin. Somewhere in the build, a windows error messaged popped up saying that idlec.exe had stopped responding. My ./autogen.sh and /opt/lo/bin/make logs are here: http://pastebin.com/eFa7qi6w Does anyone have an idea on how to get around it? that's a very odd problem, never seen anything like that. does it happen if you pull the latest master and try again? guess you'd need to do a bit of debugging if the problem did not disappear by itself. perhaps add a sleep to idlc/source/idlcmain.cxx so you can attach the debugger. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH libreoffice-4-0-4] Fix crash with fdo60063-1.docx
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/4103
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/03/4103/1
Fix crash with fdo60063-1.docx
Compared to the original version, this one tries hard
not to produce empty keywords.
Reviewed-on: https://gerrit.libreoffice.org/4091
Reviewed-by: Fridrich Strba fridr...@documentfoundation.org
Tested-by: Fridrich Strba fridr...@documentfoundation.org
(cherry picked from commit b2f97d77237cde249b4c40acc8ad3f7f8755e768)
(cherry picked from commit 693707e338922d8dc7578975a1990e8a1cba6a53)
Conflicts:
oox/source/docprop/docprophandler.cxx
Change-Id: I11d036c2d54cde2d3c311a77c115011246f38d0a
Reviewed-on: https://gerrit.libreoffice.org/4093
Reviewed-by: Miklos Vajna vmik...@suse.cz
Tested-by: Miklos Vajna vmik...@suse.cz
(cherry picked from commit d60f81a3e9d020ff1ae0db2e73551bff45c43256)
---
M oox/source/docprop/docprophandler.cxx
1 file changed, 13 insertions(+), 28 deletions(-)
diff --git a/oox/source/docprop/docprophandler.cxx
b/oox/source/docprop/docprophandler.cxx
index 1067315..ff6d170 100644
--- a/oox/source/docprop/docprophandler.cxx
+++ b/oox/source/docprop/docprophandler.cxx
@@ -25,6 +25,9 @@
#include osl/time.h
+#include vector
+#include boost/algorithm/string.hpp
+
#include oox/helper/attributelist.hxx
using namespace ::com::sun::star;
@@ -157,39 +160,21 @@
{
if ( !aChars.isEmpty() )
{
-uno::Sequence ::rtl::OUString aResult( 20 );
-sal_Int32 nCounter = 0;
+std::string aUtf8Chars = rtl::OUStringToOString( aChars,
RTL_TEXTENCODING_UTF8 ).getStr();
+std::vectorstd::string aUtf8Result;
+boost::split( aUtf8Result, aUtf8Chars, boost::is_any_of( ,;:\t),
boost::token_compress_on );
-const sal_Unicode* pStr = aChars.getStr();
-for( sal_Int32 nInd = 0; nInd aChars.getLength() pStr[nInd] != 0;
nInd++ )
+if (!aUtf8Result.empty())
{
-switch( pStr[nInd] )
-{
-case (sal_Unicode)' ':
-case (sal_Unicode)',':
-case (sal_Unicode)';':
-case (sal_Unicode)':':
-case (sal_Unicode)'\t':
-// this is a delimiter
-// unfortunately I did not find any specification for the
possible delimiters
-if ( !aResult[nCounter].isEmpty() )
-{
-if ( nCounter = aResult.getLength() )
-aResult.realloc( nCounter + 10 );
-nCounter++;
-}
-break;
+uno::Sequence rtl::OUString aResult( aUtf8Result.size() );
+OUString* pResultValues = aResult.getArray();
+for ( std::vector std::string ::const_iterator i =
aUtf8Result.begin();
+ i != aUtf8Result.end(); ++i, ++pResultValues )
+*pResultValues = rtl::OUString( i-c_str(), static_cast
sal_Int32 ( i-size() ),RTL_TEXTENCODING_UTF8 );
-default:
-// this should be a part of keyword
-aResult[nCounter] += ::rtl::OUString(
(sal_Unicode)pStr[nInd] );
-}
+return aResult;
}
-
-aResult.realloc( nCounter + 1 );
-return aResult;
}
-
return uno::Sequence ::rtl::OUString ();
}
//
--
To view, visit https://gerrit.libreoffice.org/4103
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11d036c2d54cde2d3c311a77c115011246f38d0a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0-4
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH libreoffice-4-0-4] Accept even more corrupted zip documents as long as we can r...
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4104 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/04/4104/1 Accept even more corrupted zip documents as long as we can read them Change-Id: I8d039664d6c33d978b9addc3f35cbeae86d6c710 (cherry picked from commit 1b049bd2dae52dc154ea6bee075a254a9b6cc318) (cherry picked from commit d360333f83e3115219c3928525060c6c2a8711db) (cherry picked from commit 0ed9f3a30ae2069d88d6a45d4f73817aa8596fbf) --- M package/source/zipapi/ZipFile.cxx 1 file changed, 0 insertions(+), 1 deletion(-) diff --git a/package/source/zipapi/ZipFile.cxx b/package/source/zipapi/ZipFile.cxx index 0da4c33..23d33c0 100644 --- a/package/source/zipapi/ZipFile.cxx +++ b/package/source/zipapi/ZipFile.cxx @@ -694,7 +694,6 @@ // with timestamp difference in the central directory entry and local // file header. bBroken = rEntry.nVersion != nVersion -|| (rEntry.nFlag ~6L) != (nFlag ~6L) || rEntry.nPathLen != nPathLen || !rEntry.sPath.equals( sLOCPath ); } -- To view, visit https://gerrit.libreoffice.org/4104 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8d039664d6c33d978b9addc3f35cbeae86d6c710 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0-4 Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[ANN] LibreOffice 4.0.4 RC1 test builds available
Hi *, for the upcoming new version 4.0.4, the RC1 builds now start to be available on pre-releases. This build is slated to be first release candidate build on the way towards 4.0.4, please refer to our release plan timings here: http://wiki.documentfoundation.org/ReleasePlan#4.0.4_release Builds are now being uploaded to a public (but non-mirrored - so don't spread news too widely!) place, as soon as they're available. Grab them here: http://dev-builds.libreoffice.org/pre-releases/ If you've a bit of time, please give them a try report *critical* bugs not yet in bugzilla here, so we can incorporate them into the release notes. Please note that it takes approximately 24 hours to populate the mirrors, so that's about the time we have to collect feedback. NOTE: This build is in a release configuration and _will_ replace your existing LibreOffice install on Windows. The list of fixed bugs relative to 4.0.3 is here: http://dev-builds.libreoffice.org/pre-releases/src/bugs-libreoffice-4-0-4-release-4.0.4.1.log So playing with the areas touched there also greatly appreciated - and validation that those bugs are really fixed. Thanks a lot for your help, Fridrich ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-qa] Release configuration QA builds for Windows from 4-1 branch
Hello, all beta testers, To make it a bit easier to test the Windows versions of our upcoming 4.1 release, we set a tinderbox that produces in principle every day a build of the libreoffice-4-1 branch in the release configuration with all supported languages and with all helppacks that are normally distributed in the release builds. Please, when confirming bugs for Windows, or looking for regressions, please use those builds so that we have a early alert in case a regression is introduced between an official build and the time of testing. Note, that properly triaged bug with a good instructions to reproduce will have increased chance to be fixed quickly. Cheers and thanks for your hard work Fridrich ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Release configuration QA builds for Windows from 4-1 branch
Ah, sorry, On 30/05/13 13:04, Nino Novak wrote: where can I find these builds? http://dev-builds.libreoffice.org/daily/libreoffice-4-1/Win-x86_9-Voreppe/ Cheers F. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: Import filters and Features
Hello, Tomas, On 27/05/13 21:49, Tomas Hlavaty wrote: it was great talking to you at the Linux Tag in Berlin on Saturday. I hope you don't mind me CCing the mailing list, in case somebody else finds it interesting and could provide some info. It was also delight to chat with you in the rainy Berlin. And for sure a guy that writes in 2013 in Lisp is a good guy for sure :) Inspired by your talk about import filters, I would like to ask what is the usual strategy to addressing impedance mismatch between features covered in an input file format and LibreOffice internal representation? E.g. when a feature is missing in the ODF format? OK, ODF is not exactly LO's internal representation, there is a subtle difference there, but that is not a topic of this e-mail, so we will not lose potential reader in writing essay on the differences ;) Since the filters I was speaking about actually use the flat ODF as an exchange file-format (read Linux Magazine 5/13, side 26 onwards). Besides what Miklos already answered, there are several potential ways to handle the conceptual differences: 1) If the file-format allows it and LO only does not implement that part of the file-format, we document it and pray that someone will work on it. Eventually the prayer is answered or we try to work on it ourselves. 2) If the file-format does not allow that and the internal representation does not either, we try to emulate the feature in the library. For instance for Visio arrows (line-end markers) we basically try to output the paths that ODF uses pre-scaled in the library itself according to the line width. In a similar way one could emulate things like HSK gradients where one would have to emulate them with a serie of linear RGB gradients in a way that they would look reasonably similar to the HSK ones. There are also cases where we just cannot express a feature and we drop some elements of it, still trying to retain as much information as possible so that we keep a need of manual tweaking to minimum. 3) If the internal representation allows something, but the file-format does not, we use the ODF extended format where we put our own draft features and implement them. For example, MS Word have list numbering restarts which ODF doesn't have. In such cases the documents don't import and export correctly. I guess you hit similar issues with your import filters even though they were less about word processing and more about picture drawing iirc. In case of my example, I figured out that I can parse the exported DOC file (e.g. using http://logand.com/sw/cl-olefs.html which I wrote based on MS spec and which gives me as a bonus file positions for every data record), find out where the numbering restart bit is located in the DOC file and set it accordingly. It would be better though if no such postprocessing was needed. In such case, is it permissible to accomodate the feature in the internal LibreOffice representation or is the internal representation strictly dictated/limited by the ODF spec? If the later, I guess input filters can never be made to work correctly? OK, it might be slightly naive to think that the fidelity might ever be 100% compared to original. But yes, we try to evolve the standard to cover the features used out there. Btw, I really really really enjoyed our talk and look forward to you hanging at #libreoffice-dev at irc.freenode.net :) Cheers F. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-3-6] fdo#65039 UI: Oxygen theme has wrong icon for Power regressi...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4064 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4064 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86b927d5c2e6a643beac8b9a151f572c028c18f3 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-3-6 Gerrit-Owner: Andras Timar ati...@suse.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Source files shouldn't have executable bit set.
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4070 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4070 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafad6249a7998d7c749c1ca2979a606078cfcb5e Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Mark Wielaard m...@klomp.org Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Uploading libwps 0.2.9
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4033 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4033 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3307208226ffa8bc06e7b860d10e92c9a6e04758 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Uploading libwps 0.2.9
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4033 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/33/4033/1 Uploading libwps 0.2.9 Change-Id: I3307208226ffa8bc06e7b860d10e92c9a6e04758 --- M download.lst M libwps/UnpackedTarball_libwps.mk 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/download.lst b/download.lst index 50ecc7f..5398cc2 100644 --- a/download.lst +++ b/download.lst @@ -86,7 +86,7 @@ export VIGRA_TARBALL := ea91f2fb4212a21d708aced277e6e85a-vigra1.4.0.tar.gz export WPD_TARBALL := 972afb8fdf02d9e7517e258b7fa7f0eb-libwpd-0.9.8.tar.bz2 export WPG_TARBALL := b85436266b2ac91d351ab5684b181151-libwpg-0.2.2.tar.bz2 -export WPS_TARBALL := 78196c097db366fac66841d032b1ddac-libwps-0.2.8.tar.bz2 +export WPS_TARBALL := 46eb0e7f213ad61bd5dee0c494132cb0-libwps-0.2.9.tar.bz2 export XPDF_TARBALL := 599dc4cc65a07ee868cf92a667a913d2-xpdf-3.02.tar.gz export XSLTML_TARBALL := a7983f859eafb2677d7ff386a023bc40-xsltml_2.1.2.zip export ZLIB_TARBALL := 2ab442d169156f34c379c968f3f482dd-zlib-1.2.7.tar.bz2 diff --git a/libwps/UnpackedTarball_libwps.mk b/libwps/UnpackedTarball_libwps.mk index 7c31bf8..1fd633a 100644 --- a/libwps/UnpackedTarball_libwps.mk +++ b/libwps/UnpackedTarball_libwps.mk @@ -11,11 +11,4 @@ $(eval $(call gb_UnpackedTarball_set_tarball,libwps,$(WPS_TARBALL))) -# HACK to avoid the need to deliver the headers to $(OUTDIR). This -# should be removed when libwps is updated. -$(eval $(call gb_UnpackedTarball_set_post_action,libwps,\ - mkdir -p inc/libwps \ - cp -f src/lib/libwps.h src/lib/WPSDocument.h inc/libwps \ -)) - # vim: set noet sw=4 ts=4: -- To view, visit https://gerrit.libreoffice.org/4033 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3307208226ffa8bc06e7b860d10e92c9a6e04758 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH libreoffice-4-1] Uploading libwps 0.2.9
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4034 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/34/4034/1 Uploading libwps 0.2.9 Change-Id: I3307208226ffa8bc06e7b860d10e92c9a6e04758 Reviewed-on: https://gerrit.libreoffice.org/4033 Reviewed-by: Fridrich Strba fridr...@documentfoundation.org Tested-by: Fridrich Strba fridr...@documentfoundation.org (cherry picked from commit 989da70779af441436fc46bbe7b95902e1da837e) --- M download.lst M libwps/ExternalPackage_libwps.mk 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/download.lst b/download.lst index 38466ab..040b6b4 100644 --- a/download.lst +++ b/download.lst @@ -86,7 +86,7 @@ export VIGRA_TARBALL := ea91f2fb4212a21d708aced277e6e85a-vigra1.4.0.tar.gz export WPD_TARBALL := 972afb8fdf02d9e7517e258b7fa7f0eb-libwpd-0.9.8.tar.bz2 export WPG_TARBALL := b85436266b2ac91d351ab5684b181151-libwpg-0.2.2.tar.bz2 -export WPS_TARBALL := 78196c097db366fac66841d032b1ddac-libwps-0.2.8.tar.bz2 +export WPS_TARBALL := 46eb0e7f213ad61bd5dee0c494132cb0-libwps-0.2.9.tar.bz2 export XPDF_TARBALL := 599dc4cc65a07ee868cf92a667a913d2-xpdf-3.02.tar.gz export XSLTML_TARBALL := a7983f859eafb2677d7ff386a023bc40-xsltml_2.1.2.zip export ZLIB_TARBALL := 2ab442d169156f34c379c968f3f482dd-zlib-1.2.7.tar.bz2 diff --git a/libwps/ExternalPackage_libwps.mk b/libwps/ExternalPackage_libwps.mk index 995ec7c..5bf77ff 100644 --- a/libwps/ExternalPackage_libwps.mk +++ b/libwps/ExternalPackage_libwps.mk @@ -10,8 +10,8 @@ $(eval $(call gb_ExternalPackage_ExternalPackage,libwps,libwps)) $(eval $(call gb_ExternalPackage_add_unpacked_files,libwps,inc/external/libwps,\ - src/lib/libwps.h \ - src/lib/WPSDocument.h \ + inc/libwps/libwps.h \ + inc/libwps/WPSDocument.h \ )) $(eval $(call gb_ExternalPackage_use_external_project,libwps,libwps)) -- To view, visit https://gerrit.libreoffice.org/4034 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3307208226ffa8bc06e7b860d10e92c9a6e04758 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: libreoffice-4-1 Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-1] Uploading libwps 0.2.9
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4034 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4034 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3307208226ffa8bc06e7b860d10e92c9a6e04758 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-1 Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Splitter::ImplInitHorVer(bool) should always initialize all ...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4007 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4007 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If84e8bff4c87d208416de3583202ce88d6982a99 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Mark Wielaard m...@klomp.org Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Gerrit submissions
Dear developers and other contributors to our wonderful Office Suite. I love you all and I love the work you are doing. However, if you have a submission in Gerrit that is having negative review and you are not planning to work on that patch or that patch is obsolete, please consider abandoning it in Gerrit, since now there are ~3/4 of patches in this state. That will also make it easier to review new patches. As I said already, I love you. Fridrich ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Gerrit submissions
As for me, this was more a reminder for authors to do their cleaning up which is preferable to me doing it manu militari. f. On 23/05/13 14:50, Bjoern Michaelsen wrote: On Thu, May 23, 2013 at 02:32:50PM +0200, Noel Grandin wrote: Maybe what you need is a new feature in Gerrit which doesn't display patches to you that have received negative review and have no further work? No new feature needed, e.g.: https://gerrit.libreoffice.org/#/q/project:core+age:1month+status:open+label:CodeReview%253C%253D-1,n,z shows changes, that: - are open - have not seen any change since a month - have seen a -1 or -2 code review see http://gerrit-documentation.googlecode.com/svn/Documentation/2.5.2/user-search.html for details. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-0] fdo#52540 fix hyphenation of Graphite ligatures
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3999 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3999 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c6aef6d845a7494d54b3c902654b21f3939e8cf Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Németh László nem...@numbertext.org Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-1] fdo#52540 fix hyphenation of Graphite ligatures
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4000 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4000 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c6aef6d845a7494d54b3c902654b21f3939e8cf Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-1 Gerrit-Owner: Németh László nem...@numbertext.org Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-1] Ensure SolarMutex is locked at DBG_TESTSOLARMUTEX checkpoint...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4003 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4003 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I017acf2886b813adb4d44562c5f1e22dd24aa884 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-1 Gerrit-Owner: Stephan Bergmann sberg...@redhat.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fdo#64870 Duplicate shortcut on Text Import dialogue
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4004 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4004 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia25f03e437378c49e90376dff8aa0826d53265a6 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Joren De Cuyper joren.libreoff...@telenet.be Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-1] fdo#64870 Duplicate shortcut on Text Import dialogue
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4005 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4005 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia25f03e437378c49e90376dff8aa0826d53265a6 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-1 Gerrit-Owner: Joren De Cuyper joren.libreoff...@telenet.be Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Add mouse rollover effect to menubar on KDE and Windows
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3856 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3856 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ececd8a7089918ac63c5f2027c0c2f361a9d227 Gerrit-PatchSet: 34 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Isamu Mogi saturda...@gmail.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org Gerrit-Reviewer: Isamu Mogi saturda...@gmail.com Gerrit-Reviewer: Luboš Luňák l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] AppendAscii cleanup
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3974 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3974 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7398272de0bd340ebfb5f31b314d32fcff007eec Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ricardo Montania rica...@linuxafundo.com.br Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org Gerrit-Reviewer: Marcos Souza marcos.souza@gmail.com Gerrit-Reviewer: Matteo Casalin matteo.casa...@yahoo.com Gerrit-Reviewer: Ricardo Montania rica...@linuxafundo.com.br ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[ABANDONED libreoffice-4-0] fdo#64870 Duplicate shortcut on Text Import dialogue
Fridrich Strba has abandoned this change. Change subject: fdo#64870 Duplicate shortcut on Text Import dialogue .. Patch Set 1: Abandoned This file does not exist in libreoffice-4-0 branch -- To view, visit https://gerrit.libreoffice.org/4006 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ia25f03e437378c49e90376dff8aa0826d53265a6 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Joren De Cuyper joren.libreoff...@telenet.be Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-0] fdo#64652 remove length restriction of Replace edit box
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3986 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3986 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0141dc06d940e64244909ddcb8b7e5bb797c337f Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Andras Timar ati...@suse.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Fix two SfxFilterMatcher_Impl memory leaks.
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3989 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3989 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7840aaddc861f609fbe14d5b6c0ea20d997f690f Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Mark Wielaard m...@klomp.org Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-0] fdo#46553 Update embedded manifest on win32 builds to declar...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3987 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3987 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71a3960b21f2c996b97e1a5707f20b30819fd6bd Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Andras Timar ati...@suse.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
