Re: [Libreoffice] Dumping to valgrind.log from soffice shell script needed?
On 01/12/2012 05:46 PM, Petr Mladek wrote: Ah, I am sorry for the troubles. I have somehow missed this mail. You probably did not keep me in CC and I overlooked it on the mailing list :-( Sorry, likely I accidentally used Reply List instead of Reply All. I think that the main problem is that valgrind is invoked two ways, either by exporting the variable VALGRIND or using the --valgrind option The variable was introduced to make debugging easier when running unit- and subsequent-test. The option was introduced for normal users. Ah, right, had somehow managed to not notice this. What about the following solution: + print log on the standart output when invoking via the variable + print to valgrind.log when using the --valgrind option Perfect. :) Pushed as http://cgit.freedesktop.org/libreoffice/core/commit/?id=7a00472067403ebe1cfbedbfabfde03cc19c9c34. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Dumping to valgrind.log from soffice shell script needed?
On 11/11/2011 09:36 AM, Stephan Bergmann wrote: On 10/26/2011 09:00 PM, Stephan Bergmann wrote: On 10/26/2011 01:55 PM, Petr Mladek wrote: What is your preferred way of use? What exactly do you hate and/or miss? One problem is output of multiple (batched, like make subsequentcheck) valgrind'ed invocations of soffice.bin is lost. Another problem is attaching a debugger (VALGRIND_OPTS=--db-attach=yes) does not work. So, meanwhile I had thought that I can somehow live with the inconvenience the automatic-valgrind.log feature brings, trying to remember to remove the relevant line from the soffice script in scenarios where it matters. But today I had to find out that even a single invocation of the sw/qa_complex test internally starts multiple soffice instances in a row, and coming back to a multi-hour valgrind run of that test all I got was a most unhelpful valgrind.log for a single soffice invocation. This feature turns out to be a real productivity problem for me after all. Petr, can you please re-consider whether it is really too much to ask your clients to type VALGRIND=memcheck soffice 2valgrind.log instead of VALGRIND=memcheck soffice Removed that feature now, after yet another round of frustrations. http://cgit.freedesktop.org/libreoffice/core/commit/?id=4f00cdfec54a574e25f47dab2f65b299ea64ec73 Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Dumping to valgrind.log from soffice shell script needed?
Stephan Bergmann píše v Čt 12. 01. 2012 v 11:37 +0100: On 11/11/2011 09:36 AM, Stephan Bergmann wrote: On 10/26/2011 09:00 PM, Stephan Bergmann wrote: But today I had to find out that even a single invocation of the sw/qa_complex test internally starts multiple soffice instances in a row, and coming back to a multi-hour valgrind run of that test all I got was a most unhelpful valgrind.log for a single soffice invocation. This feature turns out to be a real productivity problem for me after all. Petr, can you please re-consider whether it is really too much to ask your clients to type Ah, I am sorry for the troubles. I have somehow missed this mail. You probably did not keep me in CC and I overlooked it on the mailing list :-( VALGRIND=memcheck soffice 2valgrind.log instead of VALGRIND=memcheck soffice Removed that feature now, after yet another round of frustrations. http://cgit.freedesktop.org/libreoffice/core/commit/?id=4f00cdfec54a574e25f47dab2f65b299ea64ec73 I think that the main problem is that valgrind is invoked two ways, either by exporting the variable VALGRIND or using the --valgrind option The variable was introduced to make debugging easier when running unit- and subsequent-test. The option was introduced for normal users. What about the following solution: + print log on the standart output when invoking via the variable + print to valgrind.log when using the --valgrind option Would it fit your needs? Best Regards, Petr PS: I wonder why I did not get this idea earlier. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Dumping to valgrind.log from soffice shell script needed?
Does it make sense to do --log-file=valgrind.out.%p ? August Sodora aug...@gmail.com (201) 280-8138 On Thu, Jan 12, 2012 at 11:46 AM, Petr Mladek pmla...@suse.cz wrote: Stephan Bergmann píše v Čt 12. 01. 2012 v 11:37 +0100: On 11/11/2011 09:36 AM, Stephan Bergmann wrote: On 10/26/2011 09:00 PM, Stephan Bergmann wrote: But today I had to find out that even a single invocation of the sw/qa_complex test internally starts multiple soffice instances in a row, and coming back to a multi-hour valgrind run of that test all I got was a most unhelpful valgrind.log for a single soffice invocation. This feature turns out to be a real productivity problem for me after all. Petr, can you please re-consider whether it is really too much to ask your clients to type Ah, I am sorry for the troubles. I have somehow missed this mail. You probably did not keep me in CC and I overlooked it on the mailing list :-( VALGRIND=memcheck soffice 2valgrind.log instead of VALGRIND=memcheck soffice Removed that feature now, after yet another round of frustrations. http://cgit.freedesktop.org/libreoffice/core/commit/?id=4f00cdfec54a574e25f47dab2f65b299ea64ec73 I think that the main problem is that valgrind is invoked two ways, either by exporting the variable VALGRIND or using the --valgrind option The variable was introduced to make debugging easier when running unit- and subsequent-test. The option was introduced for normal users. What about the following solution: + print log on the standart output when invoking via the variable + print to valgrind.log when using the --valgrind option Would it fit your needs? Best Regards, Petr PS: I wonder why I did not get this idea earlier. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Dumping to valgrind.log from soffice shell script needed?
On 10/26/2011 09:00 PM, Stephan Bergmann wrote: On 10/26/2011 01:55 PM, Petr Mladek wrote: What is your preferred way of use? What exactly do you hate and/or miss? One problem is output of multiple (batched, like make subsequentcheck) valgrind'ed invocations of soffice.bin is lost. Another problem is attaching a debugger (VALGRIND_OPTS=--db-attach=yes) does not work. So, meanwhile I had thought that I can somehow live with the inconvenience the automatic-valgrind.log feature brings, trying to remember to remove the relevant line from the soffice script in scenarios where it matters. But today I had to find out that even a single invocation of the sw/qa_complex test internally starts multiple soffice instances in a row, and coming back to a multi-hour valgrind run of that test all I got was a most unhelpful valgrind.log for a single soffice invocation. This feature turns out to be a real productivity problem for me after all. Petr, can you please re-consider whether it is really too much to ask your clients to type VALGRIND=memcheck soffice 2valgrind.log instead of VALGRIND=memcheck soffice Thanks, Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Dumping to valgrind.log from soffice shell script needed?
Stephan Bergmann píše v St 26. 10. 2011 v 13:39 +0200: On 10/03/2011 03:11 PM, Petr Mladek wrote: Stephan Bergmann píše v Po 19. 09. 2011 v 11:02 +0200: Petr, following is an excerpt from #libreoffice-dev this morning: sberg caolan, btw valgrind, is there any good reason for (a)valgrind.log in soffice script (for child output, VALGRIND_OPTS=--log-file=...%p... would help, no?); The option was primary added for normal users, so that they could provide debug information easily. This is why I have chosen the single output file valgrind.log. Other solution would be to pack the generated logs into a tarball. To be honest, I do not have much experiences with valgrind. I used my experience with strace where I prefer single output file. It is easier for searching. :-) Is this an often-used feature, normal users producing a valgrind.log? And could those users be educated to use valgrind.log 21 instead? I open for any changes but I would like to keep it as easy a possible. I would really like to get rid of the code in the soffice start script, as it makes more elaborate uses of valgrind painful I wonder if we could somehow improve the current state for your needed? What is your preferred way of use? What exactly do you hate and/or miss? (sure, you can always remove the code locally, but I tend to forget it, and if you need to do it repeatedly its a PITA, anyway). Sure, this is annoying. We need to improve it, so that you need not do it. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Dumping to valgrind.log from soffice shell script needed?
On 10/26/2011 01:55 PM, Petr Mladek wrote: What is your preferred way of use? What exactly do you hate and/or miss? One problem is output of multiple (batched, like make subsequentcheck) valgrind'ed invocations of soffice.bin is lost. Another problem is attaching a debugger (VALGRIND_OPTS=--db-attach=yes) does not work. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
