Crash test update

[Crashtest VM]

New crashtest update available at 
http://dev-builds.libreoffice.org/crashtest/b017f869e80993679d17e27b76c5c0edc1a22452/


exportCrashes.csv
Description: Binary data


importCrash.csv
Description: Binary data


validationErrors.csv
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'ports/macosx10.5/master' - 152 commits - accessibility/inc accessibility/source android/Bootstrap animations/source apple_remote/Library_AppleRemote.mk avmedia/

[Douglas Mencken]

Rebased ref, commits from common ancestor:
commit 9e8445ee3cfbe5728fc69e4c2ef743f6cbe1e9c3
Author: Douglas Mencken 
Date:   Tue Feb 2 22:08:25 2016 -0500

try to fix build of external:firebird

Change-ID: Ia07a2e34208763228bd78f5b6cbda78c78015d4b

diff --git a/external/firebird/InputDevices-darwin.patch 
b/external/firebird/InputDevices-darwin.patch
new file mode 100644
index 000..b5adbed
--- /dev/null
+++ b/external/firebird/InputDevices-darwin.patch
@@ -0,0 +1,15 @@
+--- src/isql/InputDevices.cpp
 src/isql/InputDevices.cpp
+@@ -22,11 +22,10 @@
+  */
+ 
+ #include "firebird.h"
++
+ #if defined(DARWIN) && !defined(IOS)
+ #if defined(i386) || defined(__x86_64__)
+ #include 
+-#else
+-#include 
+ #endif
+ #endif
+ 
diff --git 
a/external/firebird/Make-the-generated-code-compatible-with-gcc-6-in-C-1.patch 
b/external/firebird/Make-the-generated-code-compatible-with-gcc-6-in-C-1.patch
new file mode 100644
index 000..02e7363
--- /dev/null
+++ 
b/external/firebird/Make-the-generated-code-compatible-with-gcc-6-in-C-1.patch
@@ -0,0 +1,46 @@
+From: asfernandes 
+Date: Sat, 5 Mar 2016 03:39:36 +
+Subject: Make the generated code compatible with gcc 6 in C++-14 mode.
+ (cherry picked from commit 3618aa2171674babf79ef935aa049c40a3db1321)
+Patch-mainline: 
+Git-commit: 3618aa2171674babf79ef935aa049c40a3db1321
+References: bsc#964466 CORE-5099
+​
+--- src/gpre/c_cxx.cpp
 src/gpre/c_cxx.cpp
+@@ -2004,7 +2004,7 @@
+   int ident = CMP_next_ident();
+   init->nod_arg[2] = (gpre_nod*)(IPTR)ident;
+ 
+-  printa(0, "static %schar\n   *isc_%da, *isc_%db;", CONST_STR, ident, 
ident);
++  printa(0, "static %sunsigned char\n   *isc_%da, *isc_%db;", CONST_STR, 
ident, ident);
+   printa(0, "static short\n   isc_%dl;", ident);
+ 
+   const gpre_nod* list = init->nod_arg[1];
+@@ -2820,7 +2820,7 @@
+   printa(0, "static %sshort\n   isc_%dl = %d;",
+  (request->req_flags & REQ_extend_dpb) ? "" : 
CONST_STR,
+  request->req_ident, request->req_length);
+-  printa(0, "static %schar\n   isc_%d [] = {", CONST_STR, 
request->req_ident);
++  printa(0, "static %sunsigned char\n   isc_%d [] = {", 
CONST_STR, request->req_ident);
+ 
+   const TEXT* string_type = "blr";
+   if (gpreGlob.sw_raw)
+@@ -2891,7 +2891,7 @@
+   {
+   printa(0, "static %sshort\n   isc_%dl = %d;", 
CONST_STR,
+  reference->ref_sdl_ident, 
reference->ref_sdl_length);
+-  printa(0, "static %schar\n   isc_%d [] = {", 
CONST_STR, reference->ref_sdl_ident);
++  printa(0, "static %sunsigned char\n   isc_%d [] 
= {", CONST_STR, reference->ref_sdl_ident);
+   if (gpreGlob.sw_raw)
+   gen_raw(reference->ref_sdl, 
reference->ref_sdl_length);
+   else if (PRETTY_print_sdl(reference->ref_sdl, 
gen_blr, 0, 0))
+@@ -2909,7 +2909,7 @@
+   {
+   if (blob->blb_bpb_length)
+   {
+-  printa(0, "static %schar\n   isc_%d [] = {", CONST_STR, 
blob->blb_bpb_ident);
++  printa(0, "static %sunsigned char\n   isc_%d [] = {", 
CONST_STR, blob->blb_bpb_ident);
+   gen_raw(blob->blb_bpb, blob->blb_bpb_length);
+   printa(INDENT, "};\n");
+   }
diff --git 
a/external/firebird/Provide-sized-global-delete-operators-when-compiled-.patch 
b/external/firebird/Provide-sized-global-delete-operators-when-compiled-.patch
new file mode 100644
index 000..6f171db
--- /dev/null
+++ 
b/external/firebird/Provide-sized-global-delete-operators-when-compiled-.patch
@@ -0,0 +1,27 @@
+From: Michal Kubecek 
+Date: Mon, 25 Apr 2016 08:55:36 +0200
+Subject: Provide sized global delete operators when compiled in C++14 mode
+Patch-mainline: submitted
+Git-commit: 038f9fbf559e56032e4cb49eb7ce4c3ead23fda9
+References: bsc#964466 CORE-5099
+​
+--- src/common/classes/alloc.h
 src/common/classes/alloc.h
+@@ -331,6 +331,17 @@
+   MemoryPool::globalFree(mem);
+ }
+ 
++#if __cplusplus >= 201402L
++inline void operator delete(void* mem, std::size_t s ALLOC_PARAMS) throw()
++{
++  MemoryPool::globalFree(mem);
++}
++inline void operator delete[](void* mem, std::size_t s ALLOC_PARAMS) throw()
++{
++  MemoryPool::globalFree(mem);
++}
++#endif
++
+ #ifdef DEBUG_GDS_ALLOC
+ 
+ #ifdef __clang__
diff --git a/external/firebird/UnpackedTarball_firebird.mk 
b/external/firebird/UnpackedTarball_firebird.mk
index 0e9277a..3c87133 100644
--- a/external/firebird/UnpackedTarball_firebird.mk
+++ b/external/firebird/UnpackedTarball_firebird.mk
@@ -14,13 +14,17 @@ $(eval $(call 
gb_UnpackedTarball_set_tarball,firebird,$(FIREBIRD_TARBALL)))
 

[Libreoffice-commits] core.git: Repository.mk testtools/Library_bridgetest-common.mk testtools/Library_bridgetest.mk testtools/Library_cppobj.mk testtools/Module_testtools.mk testtools/source testtool

[Stephan Bergmann]

 Repository.mk |1 
 testtools/Library_bridgetest-common.mk|   38 ++
 testtools/Library_bridgetest.mk   |5 --
 testtools/Library_cppobj.mk   |5 --
 testtools/Module_testtools.mk |2 
 testtools/StaticLibrary_bridgetest.mk |   28 -
 testtools/source/bridgetest/currentcontextchecker.hxx |6 +-
 testtools/source/bridgetest/dllapi.hxx|   25 +++
 testtools/source/bridgetest/multi.hxx |3 +
 9 files changed, 74 insertions(+), 39 deletions(-)

New commits:
commit 16bbeb5713f4f9894e81ecf34a0e00f56a425f96
Author: Stephan Bergmann 
Date:   Wed Sep 14 15:52:04 2016 +0200

Change the shared bridgetest code from static to dynamic library

...so ASan builds do not complain about ODR violations due to multiple 
instances
of vtable for testtools::bridgetest::CurrentContextChecker after
a53808c0ed577468393aced90963af6496706959 "loplugin:dllprivate" removed the
SAL_DLLPRIVATE from class CurrentContextChecker (which apparently /did/ 
have an
impact with -fvisibility-ms-compat, as used by Linux Clang ASan/UBSan 
builds).

Change-Id: Ifb1ba1819f7ea989300f4696d44f9599a1436563

diff --git a/Repository.mk b/Repository.mk
index c4ebc7a..7d29e12 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -487,6 +487,7 @@ $(eval $(call gb_Helper_register_libraries,PLAINLIBS_NONE, \
test-setupvcl \
testtools_cppobj \
testtools_bridgetest \
+   testtools_bridgetest-common \
testtools_constructors \
unobootstrapprotector \
unoexceptionprotector \
diff --git a/testtools/Library_bridgetest-common.mk 
b/testtools/Library_bridgetest-common.mk
new file mode 100644
index 000..1ca38bc
--- /dev/null
+++ b/testtools/Library_bridgetest-common.mk
@@ -0,0 +1,38 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_Library_Library,testtools_bridgetest-common))
+
+$(eval $(call gb_Library_add_defs,testtools_bridgetest-common, \
+-DLO_DLLIMPLEMENTATION_TESTTOOLS \
+))
+
+$(eval $(call 
gb_Library_use_external,testtools_bridgetest-common,boost_headers))
+
+$(eval $(call gb_Library_use_internal_api,testtools_bridgetest-common,\
+bridgetest \
+))
+
+$(eval $(call gb_Library_use_libraries,testtools_bridgetest-common, \
+cppu \
+cppuhelper \
+sal \
+))
+
+$(eval $(call gb_Library_use_api,testtools_bridgetest-common,\
+udkapi \
+))
+
+$(eval $(call gb_Library_add_exception_objects,testtools_bridgetest-common,\
+testtools/source/bridgetest/currentcontextchecker \
+testtools/source/bridgetest/multi \
+))
+
+# vim: set noet sw=4 ts=4:
diff --git a/testtools/Library_bridgetest.mk b/testtools/Library_bridgetest.mk
index 7953b66..52f3357 100644
--- a/testtools/Library_bridgetest.mk
+++ b/testtools/Library_bridgetest.mk
@@ -19,16 +19,13 @@ $(eval $(call gb_Library_use_api,testtools_bridgetest,\
 udkapi \
 ))
 
-$(eval $(call gb_Library_use_static_libraries,testtools_bridgetest,\
-testtools_bridgetest_s \
-))
-
 $(eval $(call gb_Library_use_external,testtools_bridgetest,boost_headers))
 
 $(eval $(call gb_Library_use_libraries,testtools_bridgetest,\
 cppu \
 cppuhelper \
 sal \
+testtools_bridgetest-common \
 ))
 
 $(eval $(call gb_Library_add_exception_objects,testtools_bridgetest,\
diff --git a/testtools/Library_cppobj.mk b/testtools/Library_cppobj.mk
index f2d50d7..086b1fa 100644
--- a/testtools/Library_cppobj.mk
+++ b/testtools/Library_cppobj.mk
@@ -26,14 +26,11 @@ $(eval $(call gb_Library_use_api,testtools_cppobj,\
 
 $(eval $(call gb_Library_use_external,testtools_cppobj,boost_headers))
 
-$(eval $(call gb_Library_use_static_libraries,testtools_cppobj,\
-testtools_bridgetest_s \
-))
-
 $(eval $(call gb_Library_use_libraries,testtools_cppobj,\
 cppu \
 cppuhelper \
 sal \
+testtools_bridgetest-common \
 ))
 
 $(eval $(call gb_Library_add_exception_objects,testtools_cppobj,\
diff --git a/testtools/Module_testtools.mk b/testtools/Module_testtools.mk
index 9ffb252..a1b84e1 100644
--- a/testtools/Module_testtools.mk
+++ b/testtools/Module_testtools.mk
@@ -15,9 +15,9 @@ $(eval $(call gb_Module_add_targets,testtools,\
CustomTarget_bridgetest \
InternalUnoApi_bridgetest \
InternalUnoApi_performance \
-   StaticLibrary_bridgetest \
Library_cppobj \
Library_bridgetest \
+   Library_bridgetest-common \
Library_constructors \
Rdb_uno_services \
 ))
diff --git a/testtools/StaticLibrary_bridgetest.mk 

[Libreoffice-commits] core.git: vcl/inc vcl/osx vcl/quartz

[Stephan Bergmann]

 vcl/inc/osx/a11ylistener.hxx  |2 +-
 vcl/inc/osx/salframe.h|2 +-
 vcl/inc/osx/salinst.h |2 +-
 vcl/inc/osx/salmenu.h |4 ++--
 vcl/inc/osx/salobj.h  |2 +-
 vcl/inc/osx/salprn.h  |4 ++--
 vcl/inc/osx/salsys.h  |2 +-
 vcl/inc/osx/saltimer.h|2 +-
 vcl/inc/quartz/salbmp.h   |2 +-
 vcl/inc/quartz/salgdi.h   |4 ++--
 vcl/inc/quartz/salvd.h|2 +-
 vcl/osx/DataFlavorMapping.cxx |2 +-
 vcl/osx/DragSource.hxx|2 +-
 vcl/osx/DragSourceContext.hxx |2 +-
 vcl/osx/DropTarget.hxx|2 +-
 vcl/osx/OSXTransferable.hxx   |2 +-
 vcl/osx/a11yfocuslistener.hxx |2 +-
 vcl/osx/clipboard.hxx |2 +-
 vcl/quartz/ctlayout.cxx   |2 +-
 19 files changed, 22 insertions(+), 22 deletions(-)

New commits:
commit bd132e558df9e1cfe48beb7a67f9237ed78465c5
Author: Stephan Bergmann 
Date:   Wed Sep 14 12:53:30 2016 +0200

loplugin:override

Change-Id: Ica137897f02c5caa4c4891f75531ada3957025d9

diff --git a/vcl/inc/osx/a11ylistener.hxx b/vcl/inc/osx/a11ylistener.hxx
index 525446c..353b642 100644
--- a/vcl/inc/osx/a11ylistener.hxx
+++ b/vcl/inc/osx/a11ylistener.hxx
@@ -35,7 +35,7 @@ class AquaA11yEventListener :
 
 public:
 AquaA11yEventListener(id wrapperObject, sal_Int16 role);
-virtual ~AquaA11yEventListener();
+virtual ~AquaA11yEventListener() override;
 
 // XEventListener
 virtual void SAL_CALL disposing( const css::lang::EventObject& Source )
diff --git a/vcl/inc/osx/salframe.h b/vcl/inc/osx/salframe.h
index 81e1614..94afaf3 100644
--- a/vcl/inc/osx/salframe.h
+++ b/vcl/inc/osx/salframe.h
@@ -103,7 +103,7 @@ public:
 */
 AquaSalFrame( SalFrame* pParent, SalFrameStyleFlags salFrameStyle );
 
-virtual ~AquaSalFrame();
+virtual ~AquaSalFrame() override;
 
 virtual SalGraphics*AcquireGraphics() override;
 virtual voidReleaseGraphics( SalGraphics* pGraphics ) 
override;
diff --git a/vcl/inc/osx/salinst.h b/vcl/inc/osx/salinst.h
index fbc4319..b56b8df 100644
--- a/vcl/inc/osx/salinst.h
+++ b/vcl/inc/osx/salinst.h
@@ -79,7 +79,7 @@ public:
 
 public:
 AquaSalInstance();
-virtual ~AquaSalInstance();
+virtual ~AquaSalInstance() override;
 
 virtual SalFrame*   CreateChildFrame( SystemParentData* pParent, 
SalFrameStyleFlags nStyle ) override;
 virtual SalFrame*   CreateFrame( SalFrame* pParent, SalFrameStyleFlags 
nStyle ) override;
diff --git a/vcl/inc/osx/salmenu.h b/vcl/inc/osx/salmenu.h
index f4407f3..f21c750 100644
--- a/vcl/inc/osx/salmenu.h
+++ b/vcl/inc/osx/salmenu.h
@@ -53,7 +53,7 @@ private:
 static void statusLayout();
 public:
 AquaSalMenu( bool bMenuBar );
-virtual ~AquaSalMenu();
+virtual ~AquaSalMenu() override;
 
 virtual bool VisibleMenuBar() override;
 // must return true to actually display native menu bars
@@ -100,7 +100,7 @@ class AquaSalMenuItem : public SalMenuItem
 {
 public:
 AquaSalMenuItem( const SalItemParams* );
-virtual ~AquaSalMenuItem();
+virtual ~AquaSalMenuItem() override;
 
 sal_uInt16  mnId; // Item ID
 VclPtrmpVCLMenu;// VCL Menu into which this 
MenuItem is inserted
diff --git a/vcl/inc/osx/salobj.h b/vcl/inc/osx/salobj.h
index 19a0090..c5d4465 100644
--- a/vcl/inc/osx/salobj.h
+++ b/vcl/inc/osx/salobj.h
@@ -52,7 +52,7 @@ public:
 void setClippedPosSize();
 
 AquaSalObject( AquaSalFrame* pFrame, SystemWindowData* pWinData );
-virtual ~AquaSalObject();
+virtual ~AquaSalObject() override;
 
 virtual voidResetClipRegion() override;
 virtual voidBeginSetClipRegion( sal_uLong nRects ) 
override;
diff --git a/vcl/inc/osx/salprn.h b/vcl/inc/osx/salprn.h
index bfedb08..f47a32b 100644
--- a/vcl/inc/osx/salprn.h
+++ b/vcl/inc/osx/salprn.h
@@ -62,7 +62,7 @@ class AquaSalInfoPrinter : public SalInfoPrinter
 
 public:
 AquaSalInfoPrinter( const SalPrinterQueueInfo& pInfo );
-virtual ~AquaSalInfoPrinter();
+virtual ~AquaSalInfoPrinter() override;
 
 voidSetupPrinterGraphics( CGContextRef i_xContext 
) const;
 
@@ -117,7 +117,7 @@ class AquaSalPrinter : public SalPrinter
 AquaSalInfoPrinter* mpInfoPrinter;  // pointer to the 
compatible InfoPrinter
 public:
 AquaSalPrinter( AquaSalInfoPrinter* i_pInfoPrinter );
-virtual ~AquaSalPrinter();
+virtual ~AquaSalPrinter() override;
 
 virtual boolStartJob( const OUString* i_pFileName,
   const OUString& i_rJobName,
diff --git a/vcl/inc/osx/salsys.h b/vcl/inc/osx/salsys.h
index b667b31..e1b18f9 100644
--- a/vcl/inc/osx/salsys.h
+++ b/vcl/inc/osx/salsys.h
@@ -29,7 +29,7 @@ class VCL_DLLPUBLIC AquaSalSystem : public SalSystem
 {
 public:
 AquaSalSystem() {}
-virtual ~AquaSalSystem();
+

Re: QtCreator - problem in compiling hpp files

[Michael Stahl]

On 14.09.2016 09:40, Jan Iversen wrote:
> 
>> I installed QtCreator to work on the LO project. But then, at the first 
>> attempt to compile, I get the following message. 
>> /.../libreoffice/desktop/inc/app.hxx:24: error: com / sun / star / lang / 
>> XMultiServiceFactory.hpp: No such file or directory.
> Currently our support for IDE is merely to be able to look at the files more 
> easily, we have a project running to actually be able to also compile, I am 
> however not sure it will cover QtCreator (but it can be easy expanded, to do 
> so). The focus right now is:
> - Xcode for Mac
> - Visual studio for Windows
> - Eclipse for linux
> That is once we are able to generate e.g. structured tree from the makefile 
> output.

actually these are currently implemented in bin/gbuild-to-ide:

'eclipsecdt': EclipseCDTIntegrationGenerator,
'kdevelop': KdevelopIntegrationGenerator,
'xcode': XcodeIntegrationGenerator,
'vs2012': VisualStudioIntegrationGenerator,
'vs2013': VisualStudioIntegrationGenerator,
'vim': VimIntegrationGenerator,
'debug': DebugIntegrationGenerator,
'qtcreator': QtCreatorIntegrationGenerator,

how many of them actually work is anybody's guess, but it's a python
script so you can just fix it if it doesn't work.

> To build LibreOffice you need to use make.

yes you first need to do a complete build with make, then you can use
the IDE stuff to do changes (and also rebuild, i think).

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.1' - editeng/source

[Andras Timar]

 editeng/source/editeng/editeng.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 09df3dbc5b1bb8764b96200e6905545b900afebb
Author: Andras Timar 
Date:   Wed Sep 14 13:55:51 2016 +0200

missing header

Change-Id: I7a31c08c25df1b72ac748550ac0c9c22f210941d

diff --git a/editeng/source/editeng/editeng.cxx 
b/editeng/source/editeng/editeng.cxx
index 0902da3..baa5008 100644
--- a/editeng/source/editeng/editeng.cxx
+++ b/editeng/source/editeng/editeng.cxx
@@ -17,6 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
+#include 
 #include 
 #include 
 #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: connectivity/source

[Stephan Bergmann]

 connectivity/source/drivers/macab/MacabConnection.hxx|2 +-
 connectivity/source/drivers/macab/MacabDatabaseMetaData.hxx  |2 +-
 connectivity/source/drivers/macab/MacabHeader.hxx|2 +-
 connectivity/source/drivers/macab/MacabPreparedStatement.hxx |2 +-
 connectivity/source/drivers/macab/MacabResultSet.hxx |2 +-
 connectivity/source/drivers/macab/MacabResultSetMetaData.hxx |2 +-
 connectivity/source/drivers/macab/MacabStatement.hxx |4 ++--
 connectivity/source/drivers/macab/macabcondition.hxx |2 +-
 connectivity/source/drivers/macab/macaborder.hxx |2 +-
 9 files changed, 10 insertions(+), 10 deletions(-)

New commits:
commit c765a6757fd3908ad88e759c5cd7742c2f27eaec
Author: Stephan Bergmann 
Date:   Wed Sep 14 14:35:36 2016 +0200

loplugin:override

Change-Id: I0cd2007c9169fe480e28e684cfe1bd8b24da7123

diff --git a/connectivity/source/drivers/macab/MacabConnection.hxx 
b/connectivity/source/drivers/macab/MacabConnection.hxx
index 0ee4d4b..6312be2 100644
--- a/connectivity/source/drivers/macab/MacabConnection.hxx
+++ b/connectivity/source/drivers/macab/MacabConnection.hxx
@@ -68,7 +68,7 @@ namespace connectivity
 virtual void construct( const OUString& url,const 
css::uno::Sequence< css::beans::PropertyValue >& info) 
throw(css::sdbc::SQLException);
 
 explicit MacabConnection(MacabDriver* _pDriver);
-virtual ~MacabConnection();
+virtual ~MacabConnection() override;
 
 void closeAllStatements () throw( css::sdbc::SQLException);
 
diff --git a/connectivity/source/drivers/macab/MacabDatabaseMetaData.hxx 
b/connectivity/source/drivers/macab/MacabDatabaseMetaData.hxx
index c8fde13..56eb1fd 100644
--- a/connectivity/source/drivers/macab/MacabDatabaseMetaData.hxx
+++ b/connectivity/source/drivers/macab/MacabDatabaseMetaData.hxx
@@ -44,7 +44,7 @@ namespace connectivity
 inline MacabConnection* getOwnConnection() const { return 
m_xConnection.get(); }
 
 explicit MacabDatabaseMetaData(MacabConnection* _pCon);
-virtual ~MacabDatabaseMetaData();
+virtual ~MacabDatabaseMetaData() override;
 
 // this interface is really BIG
 // XDatabaseMetaData
diff --git a/connectivity/source/drivers/macab/MacabHeader.hxx 
b/connectivity/source/drivers/macab/MacabHeader.hxx
index 177dcbc..c77ae2d 100644
--- a/connectivity/source/drivers/macab/MacabHeader.hxx
+++ b/connectivity/source/drivers/macab/MacabHeader.hxx
@@ -32,7 +32,7 @@ namespace connectivity
 public:
 MacabHeader();
 MacabHeader(const sal_Int32 _size, macabfield **_fields);
-virtual ~MacabHeader();
+virtual ~MacabHeader() override;
 void operator+= (const MacabHeader *r);
 OUString getString(const sal_Int32 i) const;
 void sortRecord();
diff --git a/connectivity/source/drivers/macab/MacabPreparedStatement.hxx 
b/connectivity/source/drivers/macab/MacabPreparedStatement.hxx
index 6e48350..c548b0f 100644
--- a/connectivity/source/drivers/macab/MacabPreparedStatement.hxx
+++ b/connectivity/source/drivers/macab/MacabPreparedStatement.hxx
@@ -57,7 +57,7 @@ namespace connectivity
 
 virtual void resetParameters() const 
throw(css::sdbc::SQLException) override;
 virtual void getNextParameter(OUString ) const 
throw(css::sdbc::SQLException) override;
-virtual ~MacabPreparedStatement();
+virtual ~MacabPreparedStatement() override;
 
 public:
 DECLARE_SERVICE_INFO();
diff --git a/connectivity/source/drivers/macab/MacabResultSet.hxx 
b/connectivity/source/drivers/macab/MacabResultSet.hxx
index 940115b..0865885 100644
--- a/connectivity/source/drivers/macab/MacabResultSet.hxx
+++ b/connectivity/source/drivers/macab/MacabResultSet.hxx
@@ -87,7 +87,7 @@ namespace connectivity
 sal_Int32 nHandle) const override;
 
 // you can't delete objects of this type
-virtual ~MacabResultSet();
+virtual ~MacabResultSet() override;
 
 public:
 DECLARE_SERVICE_INFO();
diff --git a/connectivity/source/drivers/macab/MacabResultSetMetaData.hxx 
b/connectivity/source/drivers/macab/MacabResultSetMetaData.hxx
index 9f40ce3..205ee53 100644
--- a/connectivity/source/drivers/macab/MacabResultSetMetaData.hxx
+++ b/connectivity/source/drivers/macab/MacabResultSetMetaData.hxx
@@ -44,7 +44,7 @@ namespace connectivity
 //  of the 
corresponding AddressBook field
 
 protected:
-virtual ~MacabResultSetMetaData();
+virtual ~MacabResultSetMetaData() override;
 
 public:
 MacabResultSetMetaData(MacabConnection* _pConnection, OUString 
const & _sTableName);
diff --git 

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.1' - 2 commits - configure.ac editeng/source

[Andras Timar]

 configure.ac   |2 +-
 editeng/source/editeng/editeng.cxx |5 -
 2 files changed, 5 insertions(+), 2 deletions(-)

New commits:
commit cdc3aaea0b1acf492eb70c1099019ff94cb89c37
Author: Andras Timar 
Date:   Wed Sep 14 13:54:08 2016 +0200

Bump version to 5.1-6

Change-Id: I421d2e67ff8b1f94184dfebc02a4475cdf85e13d

diff --git a/configure.ac b/configure.ac
index e92986d..a5cc28c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([Collabora Office],[5.1.10.5],[],[],[https://collaboraoffice.com/])
+AC_INIT([Collabora Office],[5.1.10.6],[],[],[https://collaboraoffice.com/])
 
 AC_PREREQ([2.59])
 
commit 6c4dfb6ca0727c6e5f9d561e496f448dffb4d87a
Author: Andras Timar 
Date:   Wed Sep 14 13:52:38 2016 +0200

fix weird selection problem in desktop editeng

Change-Id: I78c68b5a79db816ea4d0bdf3d75dd1ba4c269106

diff --git a/editeng/source/editeng/editeng.cxx 
b/editeng/source/editeng/editeng.cxx
index bf2746c..0902da3 100644
--- a/editeng/source/editeng/editeng.cxx
+++ b/editeng/source/editeng/editeng.cxx
@@ -1351,7 +1351,10 @@ bool EditEngine::PostKeyEvent( const KeyEvent& 
rKeyEvent, EditView* pEditView, v
 }
 
 pEditView->pImpEditView->SetEditSelection( aCurSel );
-pEditView->pImpEditView->DrawSelection();
+if (comphelper::LibreOfficeKit::isActive())
+{
+pEditView->pImpEditView->DrawSelection();
+}
 pImpEditEngine->UpdateSelections();
 
 if ( ( !IsVertical() && ( nCode != KEY_UP ) && ( nCode != KEY_DOWN ) ) ||
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sd/qa svx/source

[Miklos Vajna]

 sd/qa/unit/tiledrendering/tiledrendering.cxx |   69 +++
 svx/source/svdraw/svdedxv.cxx|2 
 2 files changed, 71 insertions(+)

New commits:
commit eefccb4a103729e73ba7dcb512c615bc161d7b2b
Author: Miklos Vajna 
Date:   Wed Sep 14 12:51:05 2016 +0200

sd lok draw text: make sure watching views have no cursors

These additional views are only created to follow the updates done in
the editing view, not to contribute additional cursors.

With this, if the first view edits a shape text and the second view is
created, then no unwanted text view cursor is created in the first view
for the shape text from the second view.

Be precise in the unit test and make sure that cursors from all views
are hidden, because even without a fix the cursor of view #2 is hidden,
but not from view #3, so the test wouldn't fail without the fix. (But
hardcoding the 0-1 and 2-3 view IDs exposed by Impress before/after
initializeForRendering() would be ugly.)

Change-Id: Idf64f7bfcc35c98a5eada9a0a523a9b45b65a211

diff --git a/sd/qa/unit/tiledrendering/tiledrendering.cxx 
b/sd/qa/unit/tiledrendering/tiledrendering.cxx
index a80a8de..28e0ac8 100644
--- a/sd/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sd/qa/unit/tiledrendering/tiledrendering.cxx
@@ -71,6 +71,7 @@ public:
 void testViewLock();
 void testUndoLimiting();
 void testCreateViewGraphicSelection();
+void testCreateViewTextCursor();
 
 CPPUNIT_TEST_SUITE(SdTiledRenderingTest);
 CPPUNIT_TEST(testRegisterCallback);
@@ -97,6 +98,7 @@ public:
 CPPUNIT_TEST(testViewLock);
 CPPUNIT_TEST(testUndoLimiting);
 CPPUNIT_TEST(testCreateViewGraphicSelection);
+CPPUNIT_TEST(testCreateViewTextCursor);
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -870,6 +872,8 @@ public:
 bool m_bCursorVisibleChanged;
 bool m_bViewLock;
 bool m_bTilesInvalidated;
+std::map m_aViewCursorInvalidations;
+std::map m_aViewCursorVisibilities;
 
 ViewCallback()
 : m_bGraphicSelectionInvalidated(false),
@@ -923,6 +927,24 @@ public:
 m_bViewLock = 
aTree.get_child("rectangle").get_value() != "EMPTY";
 }
 break;
+case LOK_CALLBACK_INVALIDATE_VIEW_CURSOR:
+{
+std::stringstream aStream(pPayload);
+boost::property_tree::ptree aTree;
+boost::property_tree::read_json(aStream, aTree);
+int nViewId = aTree.get_child("viewId").get_value();
+m_aViewCursorInvalidations[nViewId] = true;
+}
+break;
+case LOK_CALLBACK_VIEW_CURSOR_VISIBLE:
+{
+std::stringstream aStream(pPayload);
+boost::property_tree::ptree aTree;
+boost::property_tree::read_json(aStream, aTree);
+int nViewId = aTree.get_child("viewId").get_value();
+m_aViewCursorVisibilities[nViewId] = OString("true") == pPayload;
+}
+break;
 }
 }
 };
@@ -1152,6 +1174,53 @@ void 
SdTiledRenderingTest::testCreateViewGraphicSelection()
 comphelper::LibreOfficeKit::setActive(false);
 }
 
+void SdTiledRenderingTest::testCreateViewTextCursor()
+{
+comphelper::LibreOfficeKit::setActive();
+
+// Load a document and register a callback.
+SdXImpressDocument* pXImpressDocument = createDoc("title-shape.odp");
+ViewCallback aView1;
+
SfxViewShell::Current()->registerLibreOfficeKitViewCallback(::callback,
 );
+
+// Begin text edit.
+pXImpressDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, awt::Key::TAB);
+pXImpressDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, awt::Key::TAB);
+pXImpressDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 'x', 0);
+pXImpressDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 'x', 0);
+Scheduler::ProcessEventsToIdle();
+sd::ViewShell* pViewShell = 
pXImpressDocument->GetDocShell()->GetViewShell();
+SdrView* pSdrView = pViewShell->GetView();
+CPPUNIT_ASSERT(pSdrView->IsTextEdit());
+
+// Make sure that creating a new view either doesn't affect the previous
+// one, or at least the effect is not visible at the end.
+aView1.m_aViewCursorInvalidations.clear();
+aView1.m_aViewCursorVisibilities.clear();
+SfxLokHelper::createView();
+pXImpressDocument->initializeForTiledRendering({});
+ViewCallback aView2;
+
SfxViewShell::Current()->registerLibreOfficeKitViewCallback(::callback,
 );
+bool bFoundCursor = false;
+for (const auto& rInvalidation : aView1.m_aViewCursorInvalidations)
+{
+auto itVisibility = 
aView1.m_aViewCursorVisibilities.find(rInvalidation.first);
+// For each cursor invalidation: if there is no visibility or the 
visibility is true, that's a problem.
+if (itVisibility == aView1.m_aViewCursorVisibilities.end() || 
(itVisibility != aView1.m_aViewCursorVisibilities.end() && 
itVisibility->second))
+  

[Libreoffice-commits] core.git: 2 commits - avmedia/source fpicker/source

[Stephan Bergmann]

 avmedia/source/macavf/framegrabber.hxx|2 +-
 avmedia/source/macavf/manager.hxx |2 +-
 avmedia/source/macavf/player.hxx  |2 +-
 avmedia/source/macavf/window.hxx  |2 +-
 fpicker/source/aqua/SalAquaFilePicker.hxx |2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit b932b199602b418ae1d71a8e1751e30339e2fcaa
Author: Stephan Bergmann 
Date:   Wed Sep 14 14:25:06 2016 +0200

loplugin:override

Change-Id: I1971301f2b07a6d0608d13d1ab60c6339a079468

diff --git a/fpicker/source/aqua/SalAquaFilePicker.hxx 
b/fpicker/source/aqua/SalAquaFilePicker.hxx
index 869c5aa..03fc487 100644
--- a/fpicker/source/aqua/SalAquaFilePicker.hxx
+++ b/fpicker/source/aqua/SalAquaFilePicker.hxx
@@ -178,7 +178,7 @@ private:
 
 public:
 
-virtual ~SalAquaFilePicker();
+virtual ~SalAquaFilePicker() override;
 
 void filterControlChanged();
 
commit f734b24f4f7d1096f393a66ee87feb48c551d996
Author: Stephan Bergmann 
Date:   Wed Sep 14 14:19:44 2016 +0200

loplugin:override

Change-Id: I73f96cb391a430443f9bb80a5406627c5564dcd9

diff --git a/avmedia/source/macavf/framegrabber.hxx 
b/avmedia/source/macavf/framegrabber.hxx
index b30a2b2..4567690 100644
--- a/avmedia/source/macavf/framegrabber.hxx
+++ b/avmedia/source/macavf/framegrabber.hxx
@@ -33,7 +33,7 @@ class FrameGrabber : public ::cppu::WeakImplHelper< 
css::media::XFrameGrabber,
 public:
 
 explicit FrameGrabber( const css::uno::Reference< 
css::lang::XMultiServiceFactory >& );
-virtual  ~FrameGrabber();
+virtual  ~FrameGrabber() override;
 
 boolcreate( const ::rtl::OUString& rURL );
 boolcreate( AVAsset* pMovie );
diff --git a/avmedia/source/macavf/manager.hxx 
b/avmedia/source/macavf/manager.hxx
index fe1a4a3..6044df0 100644
--- a/avmedia/source/macavf/manager.hxx
+++ b/avmedia/source/macavf/manager.hxx
@@ -34,7 +34,7 @@ class Manager : public ::cppu::WeakImplHelper< 
css::media::XManager,
 public:
 
 Manager( const css::uno::Reference< css::lang::XMultiServiceFactory >& 
rxMgr );
-virtual ~Manager();
+virtual ~Manager() override;
 
 // XManager
 virtual css::uno::Reference< css::media::XPlayer > SAL_CALL createPlayer( 
const ::rtl::OUString& aURL ) throw (css::uno::RuntimeException) override;
diff --git a/avmedia/source/macavf/player.hxx b/avmedia/source/macavf/player.hxx
index d603ec1..86373b8 100644
--- a/avmedia/source/macavf/player.hxx
+++ b/avmedia/source/macavf/player.hxx
@@ -35,7 +35,7 @@ class Player
 {
 public:
 explicit Player( const css::uno::Reference< 
css::lang::XMultiServiceFactory >& );
-virtual  ~Player();
+virtual  ~Player() override;
 
 bool create( const ::rtl::OUString& rURL );
 bool create( AVAsset* );
diff --git a/avmedia/source/macavf/window.hxx b/avmedia/source/macavf/window.hxx
index 2fe7290..fc9387e 100644
--- a/avmedia/source/macavf/window.hxx
+++ b/avmedia/source/macavf/window.hxx
@@ -49,7 +49,7 @@ public:
 Player& i_rPlayer,
 NSView* i_pParentView
 );
-virtual ~Window();
+virtual ~Window() override;
 
 voidprocessGraphEvent();
 voidupdatePointer();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: lingucomponent/source

[Stephan Bergmann]

 lingucomponent/source/spellcheck/macosxspell/macspellimp.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0f6cb25be8ef72ec1e3cadded38f0698edf08cb4
Author: Stephan Bergmann 
Date:   Wed Sep 14 14:48:18 2016 +0200

loplugin:override

Change-Id: If6d03fd0d3b5b69f3b07e697c4f6d7a3668ee69a

diff --git a/lingucomponent/source/spellcheck/macosxspell/macspellimp.hxx 
b/lingucomponent/source/spellcheck/macosxspell/macspellimp.hxx
index b51a804..ceb370d 100644
--- a/lingucomponent/source/spellcheck/macosxspell/macspellimp.hxx
+++ b/lingucomponent/source/spellcheck/macosxspell/macspellimp.hxx
@@ -86,7 +86,7 @@ class MacSpellChecker :
 
 public:
 MacSpellChecker();
-virtual ~MacSpellChecker();
+virtual ~MacSpellChecker() override;
 
 // XSupportedLocales (for XSpellChecker)
 virtual Sequence< Locale > SAL_CALL getLocales() throw(RuntimeException) 
override;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sfx2/source

[Stephan Bergmann]

 sfx2/source/appl/shutdowniconaqua.mm |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 386aeda1f09936866881d272e7cff94ba59604a7
Author: Stephan Bergmann 
Date:   Wed Sep 14 14:15:31 2016 +0200

loplugin:override

Change-Id: Id9c234d605b4f8107833980825b402006e4f0031

diff --git a/sfx2/source/appl/shutdowniconaqua.mm 
b/sfx2/source/appl/shutdowniconaqua.mm
index 87bd931..c28cf0c 100644
--- a/sfx2/source/appl/shutdowniconaqua.mm
+++ b/sfx2/source/appl/shutdowniconaqua.mm
@@ -133,7 +133,7 @@ class RecentFilesStringLength : public 
::cppu::WeakImplHelper< css::util::XStrin
 {
 public:
 RecentFilesStringLength() {}
-virtual ~RecentFilesStringLength() {}
+virtual ~RecentFilesStringLength() override {}
 
 // XStringWidth
 sal_Int32 SAL_CALL queryStringWidth( const ::rtl::OUString& aString )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/Module_sc.mk

[Eike Rathke]

 sc/Module_sc.mk |9 +
 1 file changed, 9 insertions(+)

New commits:
commit b9a27d5856f60688456762bfcc29c38670009254
Author: Eike Rathke 
Date:   Wed Sep 14 12:56:31 2016 +0200

sc: disable function test documents for 32-bit PLATFORMID=linux_x86

Change-Id: I18ee46abbb5de79a35c4c78292dc9d6d43017de2
Reviewed-on: https://gerrit.libreoffice.org/28893
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/Module_sc.mk b/sc/Module_sc.mk
index 05af307..642c6b8 100644
--- a/sc/Module_sc.mk
+++ b/sc/Module_sc.mk
@@ -64,8 +64,17 @@ $(eval $(call gb_Module_add_slowcheck_targets,sc, \
CppunitTest_sc_html_export_test \
CppunitTest_sc_opencl_test \
CppunitTest_sc_copypaste \
+))
+
+# Various function tests fail in 32-bit linux_x86 build due to dreaded floating
+# point weirdness (x87, registers, compiler optimization, ... whatever),
+# disable them until someone finds a real cure.
+
+ifneq ($(PLATFORMID),linux_x86)
+$(eval $(call gb_Module_add_slowcheck_targets,sc, \
CppunitTest_sc_functions_test \
 ))
+endif
 
 # Disabled to allow the check tinderbox execute the sd tests
 # CppunitTest_sc_chart_regression_test \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Test File: sc/qa/unit/data/functions/fods/chiinv.fods: fails with Assertion

[Eike Rathke]

Hi Alex,

On Wednesday, 2016-09-14 08:56:21 +0200, Eike Rathke wrote:

> > 1. either stepping through the code
> 
> Well, you can try, but it's a more general problem not restricted to
> just one or two functions. Entry point for the CHIINV function would be
> in sc/source/core/tool/interpr3.cxx ScInterpreter::ScChiInv()

If you want to get a working build without disabling all checks then you
can use
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=b9a27d5856f60688456762bfcc29c38670009254

that disables the function tests for linux_x86 builds.

However, if you'd find a general solution that does not involve
disabling the tests that would be more than welcomed.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/
Care about Free Software, support the FSFE https://fsfe.org/support/?erack


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: bin/gbuild-to-ide Makefile.in

[Michael Stahl]

 Makefile.in   |2 +-
 bin/gbuild-to-ide |4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 999499ab25df8b293c009ddfa2e0bedbe5e6ce3d
Author: Michael Stahl 
Date:   Wed Sep 14 13:44:27 2016 +0200

gbuild-to-ide: MSVC 2012 no longer supported, replace with 2015

Of course not tested in any way but with any luck the project file
format hasn't changed and it will "just work".

Change-Id: I81c5043259feeabd69ef31ea7ef160901ac7ebdc

diff --git a/Makefile.in b/Makefile.in
index 5a21a51..15bbf4b 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -421,8 +421,8 @@ endef
 $(foreach ide,\
debug \
kdevelop \
-   vs2012 \
vs2013 \
+   vs2015 \
vim \
xcode \
qtcreator \
diff --git a/bin/gbuild-to-ide b/bin/gbuild-to-ide
index 0492920..069b7c5f 100755
--- a/bin/gbuild-to-ide
+++ b/bin/gbuild-to-ide
@@ -833,7 +833,7 @@ class 
VisualStudioIntegrationGenerator(IdeIntegrationGenerator):
 }
 
 def retrieve_toolset(self, ide):
-ide_toolset_map = {'vs2012': 'v110', 'vs2013': 'v120'}
+ide_toolset_map = {'vs2013': 'v120', 'vs2015': 'v140'}
 return ide_toolset_map[ide]
 
 def module_make_command(self, targets):
@@ -1705,8 +1705,8 @@ if __name__ == '__main__':
 'eclipsecdt': EclipseCDTIntegrationGenerator,
 'kdevelop': KdevelopIntegrationGenerator,
 'xcode': XcodeIntegrationGenerator,
-'vs2012': VisualStudioIntegrationGenerator,
 'vs2013': VisualStudioIntegrationGenerator,
+'vs2015': VisualStudioIntegrationGenerator,
 'vim': VimIntegrationGenerator,
 'debug': DebugIntegrationGenerator,
 'qtcreator': QtCreatorIntegrationGenerator,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: editeng/source

[Andras Timar]

 editeng/source/editeng/editeng.cxx |5 +
 1 file changed, 5 insertions(+)

New commits:
commit 486f9064367fd99029ba34a36486e3d70773131a
Author: Andras Timar 
Date:   Wed Sep 14 15:59:56 2016 +0200

Revert 8c4dbcef8f and provide a better fix

This reverts commit 8c4dbcef8f92c9bd1c2208e7de7971f184f8a3ff.

bccu#1781 bug was in LibreOffice Online. After deletion of the selected
editeng text, the selection did not disappear. By making the fix conditional
to LibreOfficeKit::isActive(), we can avoid the weird selection problem in
desktop editeng.

Change-Id: I78c68b5a79db816ea4d0bdf3d75dd1ba4c269106
Reviewed-on: https://gerrit.libreoffice.org/28900
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/editeng/source/editeng/editeng.cxx 
b/editeng/source/editeng/editeng.cxx
index 4a87e92..3047c4c 100644
--- a/editeng/source/editeng/editeng.cxx
+++ b/editeng/source/editeng/editeng.cxx
@@ -17,6 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
+#include 
 #include 
 #include 
 #include 
@@ -1349,6 +1350,10 @@ bool EditEngine::PostKeyEvent( const KeyEvent& 
rKeyEvent, EditView* pEditView, v
 }
 
 pEditView->pImpEditView->SetEditSelection( aCurSel );
+if (comphelper::LibreOfficeKit::isActive())
+{
+pEditView->pImpEditView->DrawSelection();
+}
 pImpEditEngine->UpdateSelections();
 
 if ( ( !IsVertical() && ( nCode != KEY_UP ) && ( nCode != KEY_DOWN ) ) ||
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: external/firebird

[Stephan Bergmann]

 external/firebird/ExternalProject_firebird.mk |5 +
 1 file changed, 5 insertions(+)

New commits:
commit 15f92676f74d58b0af8578d6c45d0faa3de19164
Author: Stephan Bergmann 
Date:   Wed Sep 14 16:18:49 2016 +0200

external/firebird: Hack around detection of clock_gettime on Mac OS X

...where the 10.12 SDK includes clock_gettime, marked as

  __attribute__((availability(macosx,introduced=10.12)))

in time.h.  However, the way firebird's configure checks for it, it gets
detected as available regardless of the used -mmacosx-version-min value (and
even if the configure check would go via the time.h header, the availability
attribute would only cause a -Wpartial-availability warning, not an error, 
so
we'd need to pass CFLAGS=-Werror=partial-availability into firebird's
configure.)

Change-Id: I67e12743e1df0574e7fc4b2121add9fe1fb7677b

diff --git a/external/firebird/ExternalProject_firebird.mk 
b/external/firebird/ExternalProject_firebird.mk
index 2fe2e8bc..09c4463 100644
--- a/external/firebird/ExternalProject_firebird.mk
+++ b/external/firebird/ExternalProject_firebird.mk
@@ -86,6 +86,11 @@ $(call gb_ExternalProject_get_state_target,firebird,build):
, \
--enable-shared --disable-static \
) \
+   $(if $(filter MACOSX,$(OS)), \
+   $(if $(filter 1, \
+   $(shell expr 
'$(MAC_OS_X_VERSION_MIN_REQUIRED)' \
+   '<' 101200)), \
+   ac_cv_func_clock_gettime=no)) \
&& if [ -n "$${FB_CPU_ARG}" ]; then \
   $(MAKE_PRE) $(MAKE) $(INVOKE_FPA) SHELL='$(SHELL)' 
$(MAKE_POST); \
else \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.1' - 3 commits - desktop/qa desktop/source sd/qa sfx2/source svx/source

[Miklos Vajna]

 desktop/qa/data/2slides.odp  |binary
 desktop/qa/desktop_lib/test_desktop_lib.cxx  |   74 +++
 desktop/source/lib/init.cxx  |   24 
 sd/qa/unit/tiledrendering/tiledrendering.cxx |   69 +
 sfx2/source/view/lokhelper.cxx   |6 --
 svx/source/svdraw/svdedxv.cxx|2 
 6 files changed, 171 insertions(+), 4 deletions(-)

New commits:
commit 106cd072747a48ba064d8522cc15f581abffab51
Author: Miklos Vajna 
Date:   Wed Sep 14 19:47:47 2016 +0200

desktop lok: avoid unnecessary setPart() in paintPartTile()

If possible, switch views, not parts, that way started Impress text
edits don't end as a side-effect.

Change-Id: I3f18d4dda6bc24235bf1219416f153248a867fa4
(cherry picked from commit bee4ff508a456a1552aacdf6fc838b8b7cffb9ec)

diff --git a/desktop/qa/data/2slides.odp b/desktop/qa/data/2slides.odp
new file mode 100644
index 000..8be376f
Binary files /dev/null and b/desktop/qa/data/2slides.odp differ
diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index 5485da3..a6c256d 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -99,6 +99,7 @@ public:
 void testRedlineWriter();
 void testTrackChanges();
 void testRedlineCalc();
+void testPaintPartTile();
 
 CPPUNIT_TEST_SUITE(DesktopLOKTest);
 CPPUNIT_TEST(testModifiedStatus);
@@ -129,6 +130,7 @@ public:
 CPPUNIT_TEST(testRedlineWriter);
 CPPUNIT_TEST(testTrackChanges);
 CPPUNIT_TEST(testRedlineCalc);
+CPPUNIT_TEST(testPaintPartTile);
 CPPUNIT_TEST_SUITE_END();
 
 uno::Reference mxComponent;
@@ -1241,6 +1243,78 @@ void DesktopLOKTest::testRedlineCalc()
 comphelper::LibreOfficeKit::setActive(false);
 }
 
+class ViewCallback
+{
+public:
+bool m_bTilesInvalidated;
+
+ViewCallback()
+: m_bTilesInvalidated(false)
+{
+}
+
+static void callback(int nType, const char* pPayload, void* pData)
+{
+static_cast(pData)->callbackImpl(nType, pPayload);
+}
+
+void callbackImpl(int nType, const char* /*pPayload*/)
+{
+switch (nType)
+{
+case LOK_CALLBACK_INVALIDATE_TILES:
+{
+m_bTilesInvalidated = true;
+}
+break;
+}
+}
+};
+
+void DesktopLOKTest::testPaintPartTile()
+{
+// Load an impress doc of 2 slides.
+comphelper::LibreOfficeKit::setActive();
+LibLODocument_Impl* pDocument = loadDoc("2slides.odp");
+pDocument->m_pDocumentClass->initializeForRendering(pDocument, "{}");
+ViewCallback aView1;
+pDocument->m_pDocumentClass->registerCallback(pDocument, 
::callback, );
+int nView1 = pDocument->m_pDocumentClass->getView(pDocument);
+
+// Create a second view.
+pDocument->m_pDocumentClass->createView(pDocument);
+pDocument->m_pDocumentClass->initializeForRendering(pDocument, "{}");
+ViewCallback aView2;
+pDocument->m_pDocumentClass->registerCallback(pDocument, 
::callback, );
+
+// Go to the second slide in the second view.
+pDocument->m_pDocumentClass->setPart(pDocument, 1);
+
+// Switch back to the first view and start typing.
+pDocument->m_pDocumentClass->setView(pDocument, nView1);
+pDocument->m_pDocumentClass->postKeyEvent(pDocument, 
LOK_KEYEVENT_KEYINPUT, 0, awt::Key::TAB);
+pDocument->m_pDocumentClass->postKeyEvent(pDocument, LOK_KEYEVENT_KEYUP, 
0, awt::Key::TAB);
+pDocument->m_pDocumentClass->postKeyEvent(pDocument, 
LOK_KEYEVENT_KEYINPUT, 'x', 0);
+pDocument->m_pDocumentClass->postKeyEvent(pDocument, LOK_KEYEVENT_KEYUP, 
'x', 0);
+
+// Call paintPartTile() to paint the second part (in whichever view it 
finds suitable for this).
+unsigned char pPixels[256 * 256 * 4];
+pDocument->m_pDocumentClass->paintPartTile(pDocument, pPixels, 1, 256, 
256, 0, 0, 256, 256);
+
+// Type again.
+Scheduler::ProcessEventsToIdle();
+aView1.m_bTilesInvalidated = false;
+pDocument->m_pDocumentClass->postKeyEvent(pDocument, 
LOK_KEYEVENT_KEYINPUT, 'x', 0);
+pDocument->m_pDocumentClass->postKeyEvent(pDocument, LOK_KEYEVENT_KEYUP, 
'x', 0);
+Scheduler::ProcessEventsToIdle();
+// This failed: paintPartTile() (as a side-effect) ended the text edit of
+// the first view, so there were no invalidations.
+CPPUNIT_ASSERT(aView1.m_bTilesInvalidated);
+
+mxComponent->dispose();
+mxComponent.clear();
+comphelper::LibreOfficeKit::setActive(false);
+}
 CPPUNIT_TEST_SUITE_REGISTRATION(DesktopLOKTest);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index f678d69..582c52c 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -1486,6 +1486,7 @@ void doc_paintPartTile(LibreOfficeKitDocument* pThis,
const int 

Re: Test File: sc/qa/unit/data/functions/fods/chiinv.fods: fails with Assertion

[Alex McMurchy]

Hi Erike

Every so often I compile and test LibreOffice to ensure that no 
regressions have occurred. I've encountered a few over the years that 
have even got into the Still version of LibreOffice.


As to whatever CHIINV and MINVERSE does doesn't bother me I don't use 
them at all. So, I just delete the offending test in the .fods file and 
move on. I never push anything back. That way if any other tests fail 
I'll know about them


On my day job I've got a deadline looming for this Friday, 16th August 
2016. Once that's out of the way, I may have another look at CHIINV next 
week. I'm intrigued why the same binary of LO 5.1.4.2 works on some 
environments but not on others.


Alex

On 14/09/16 16:52, Eike Rathke wrote:

Hi Alex,

On Wednesday, 2016-09-14 08:56:21 +0200, Eike Rathke wrote:


1. either stepping through the code

Well, you can try, but it's a more general problem not restricted to
just one or two functions. Entry point for the CHIINV function would be
in sc/source/core/tool/interpr3.cxx ScInterpreter::ScChiInv()

If you want to get a working build without disabling all checks then you
can use
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=b9a27d5856f60688456762bfcc29c38670009254

that disables the function tests for linux_x86 builds.

However, if you'd find a general solution that does not involve
disabling the tests that would be more than welcomed.

   Eike



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Changes to 'private/jmux/master-fixes_7'

[Jan-Marek Glogowski]

New branch 'private/jmux/master-fixes_7' available with the following commits:
commit a308b0f157509d06a56a91d11378ee0ce1ead059
Author: Jan-Marek Glogowski 
Date:   Wed Sep 14 18:17:18 2016 +0200

Don't poll busy documents via idle task

Creates a very busy idle-loop, for non-task work like mail merge.

Change-Id: If7be82e4675008f23e6f4f6be5c40df40a231a8b

commit cec52e7c071b45d452bb5e0a29d102f1b30f8924
Author: Jan-Marek Glogowski 
Date:   Wed Sep 14 15:33:54 2016 +0200

Really schedule Idle tasks immediatly

There is really no reason to wait a millisecond for an idle.

Change-Id: I7665d5f2e7d6ba3e01290a692bbc8e42c36b9986

commit 538748ffa8c99ca3d41a98d24e2a27de0f998143
Author: Jan-Marek Glogowski 
Date:   Wed Sep 14 13:48:02 2016 +0200

Change Idle to be a actually a Timer subclass

Drops a lot of duplicated code and actually reflects the Scheduler
handling of "idle" in the source code.

Change-Id: I847592e92e86d15ab1cab168bf0e667322e48048

commit 90736abcb6dc16d172c70f4710cf50267571669c
Author: Jan-Marek Glogowski 
Date:   Mon Sep 12 18:24:14 2016 +0200

Handle all main loop and task events

Change-Id: I75ed5a38b0e24966dafcfdd2ea4cb8afc93a8a0c

commit 3ff040114fa985bc5c0c6b2c7c8d966137930e12
Author: Jan-Marek Glogowski 
Date:   Wed Aug 10 12:00:53 2016 +0200

Reorganize Scheduler priority classes

This is based on glibs classification of tasks, but while glib uses
an int for more fine grained priority, we stay with our enum.

1. Timers start with DEFAULT priority, which directly corresponds
   with the previous HIGH priority
2. Idles start with DEFAULT_IDLE priority instead of the previous
   HIGH priority, so idle default becomes "really run when idle".

As RESIZE and REPAINT are special, and the DEFAULTS are set, there
is just one primary decision for the programmer: should my idle
run before paint (AKA HIGH_IDLE)?

If we really need a more fine-grained classification, we can add it
later, or also switch to a real int. As a result, this drops many
classifications from the code and drastically changes behaviour,
AKA a mail merge from KDE is now as fast as Gtk+ again.

Conflicts:
cui/source/tabpages/macroass.cxx
desktop/source/deployment/gui/dp_gui_dialog2.cxx
include/vcl/scheduler.hxx
sc/source/core/tool/dbdata.cxx
sc/source/ui/formdlg/dwfunctr.cxx
sc/source/ui/miscdlgs/anyrefdg.cxx
sd/source/ui/dlg/dlgass.cxx
sd/source/ui/slideshow/slideshowimpl.cxx
svx/source/inc/eventhandler.hxx
svx/source/sdr/overlay/overlaymanagerbuffered.cxx
sw/source/uibase/docvw/srcedtw.cxx
sw/source/uibase/utlui/unotools.cxx
vcl/source/app/idle.cxx
vcl/source/app/scheduler.cxx
vcl/source/app/timer.cxx

Change-Id: I498a73fd02d5fb6f5d7e9f742f3bce972de9b1f9

commit f1b7fee442f49c00bb5f8c964a784bb70c6a4179
Author: Jan-Marek Glogowski 
Date:   Tue Sep 13 12:20:45 2016 +0200

Don't wait in Yield with pending events

This re-introduces some functionality of commit
  87199d3829257420429057336283c55be6ae7481

I'm not sure, if we really want to skip the wait on pendig events.

Change-Id: Ie88c2945acb066e312bab7d0f5b2f3b525fa1c4c

commit 4f8007b315283902df596a5186ff70132b652cd1
Author: Jan-Marek Glogowski 
Date:   Sun Jul 31 17:31:07 2016 +0200

Just schedule tasks, if timeout has ellapsed

As the native main loop wakes up on new events and not just by
timer timeouts, make sure there is really an ellapsed event.

Probably we should just schedule events via the system timeout.
At least this will prevent expensive re-scheduling.

Conflicts:
vcl/source/app/scheduler.cxx

Change-Id: I248c9b8acb7df026295d10f256871b9fc8d39c07

commit f7d671c7eea7d155f669195f26c7ee3c75642a1a
Author: Jan-Marek Glogowski 
Date:   Mon Sep 12 17:03:29 2016 +0200

Drop special idle handling

Idles are just instant, mainly low-priority timers.
So we'll just schedule by priority.

Change-Id: I446eaea0077f45a5b7daa0aa06dcb80010ac0bd5

commit 05a01453fce18dea541d4f1d5f06c5829c76b4de
Author: Jan-Marek Glogowski 
Date:   Thu Sep 8 06:55:30 2016 +0200

Revert all SalYieldResult changes => bool

All we want to know is, if any event was processed. Actually the
result was never indicating, if a timeout was processed at all.

Change-Id: Ia0b91b06dffb77af066f01838d8f9483523bf67d

commit 518fabe383f6d8adf5e3d495ae52232b940cc758
Author: Jan-Marek Glogowski 
Date:   Sun Jul 31 16:35:49 2016 +0200

Don't update document stats for non-idle views

This functionality should be 

[Libreoffice-commits] core.git: desktop/qa desktop/source

[Miklos Vajna]

 desktop/qa/data/2slides.odp |binary
 desktop/qa/desktop_lib/test_desktop_lib.cxx |   74 
 desktop/source/lib/init.cxx |   24 +
 3 files changed, 98 insertions(+)

New commits:
commit bee4ff508a456a1552aacdf6fc838b8b7cffb9ec
Author: Miklos Vajna 
Date:   Wed Sep 14 19:47:47 2016 +0200

desktop lok: avoid unnecessary setPart() in paintPartTile()

If possible, switch views, not parts, that way started Impress text
edits don't end as a side-effect.

Change-Id: I3f18d4dda6bc24235bf1219416f153248a867fa4

diff --git a/desktop/qa/data/2slides.odp b/desktop/qa/data/2slides.odp
new file mode 100644
index 000..8be376f
Binary files /dev/null and b/desktop/qa/data/2slides.odp differ
diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index 9e58327..28d78bc 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -99,6 +99,7 @@ public:
 void testRedlineWriter();
 void testTrackChanges();
 void testRedlineCalc();
+void testPaintPartTile();
 
 CPPUNIT_TEST_SUITE(DesktopLOKTest);
 CPPUNIT_TEST(testGetStyles);
@@ -129,6 +130,7 @@ public:
 CPPUNIT_TEST(testRedlineWriter);
 CPPUNIT_TEST(testTrackChanges);
 CPPUNIT_TEST(testRedlineCalc);
+CPPUNIT_TEST(testPaintPartTile);
 CPPUNIT_TEST_SUITE_END();
 
 uno::Reference mxComponent;
@@ -1472,6 +1474,78 @@ void DesktopLOKTest::testRedlineCalc()
 comphelper::LibreOfficeKit::setActive(false);
 }
 
+class ViewCallback
+{
+public:
+bool m_bTilesInvalidated;
+
+ViewCallback()
+: m_bTilesInvalidated(false)
+{
+}
+
+static void callback(int nType, const char* pPayload, void* pData)
+{
+static_cast(pData)->callbackImpl(nType, pPayload);
+}
+
+void callbackImpl(int nType, const char* /*pPayload*/)
+{
+switch (nType)
+{
+case LOK_CALLBACK_INVALIDATE_TILES:
+{
+m_bTilesInvalidated = true;
+}
+break;
+}
+}
+};
+
+void DesktopLOKTest::testPaintPartTile()
+{
+// Load an impress doc of 2 slides.
+comphelper::LibreOfficeKit::setActive();
+LibLODocument_Impl* pDocument = loadDoc("2slides.odp");
+pDocument->m_pDocumentClass->initializeForRendering(pDocument, "{}");
+ViewCallback aView1;
+pDocument->m_pDocumentClass->registerCallback(pDocument, 
::callback, );
+int nView1 = pDocument->m_pDocumentClass->getView(pDocument);
+
+// Create a second view.
+pDocument->m_pDocumentClass->createView(pDocument);
+pDocument->m_pDocumentClass->initializeForRendering(pDocument, "{}");
+ViewCallback aView2;
+pDocument->m_pDocumentClass->registerCallback(pDocument, 
::callback, );
+
+// Go to the second slide in the second view.
+pDocument->m_pDocumentClass->setPart(pDocument, 1);
+
+// Switch back to the first view and start typing.
+pDocument->m_pDocumentClass->setView(pDocument, nView1);
+pDocument->m_pDocumentClass->postKeyEvent(pDocument, 
LOK_KEYEVENT_KEYINPUT, 0, awt::Key::TAB);
+pDocument->m_pDocumentClass->postKeyEvent(pDocument, LOK_KEYEVENT_KEYUP, 
0, awt::Key::TAB);
+pDocument->m_pDocumentClass->postKeyEvent(pDocument, 
LOK_KEYEVENT_KEYINPUT, 'x', 0);
+pDocument->m_pDocumentClass->postKeyEvent(pDocument, LOK_KEYEVENT_KEYUP, 
'x', 0);
+
+// Call paintPartTile() to paint the second part (in whichever view it 
finds suitable for this).
+unsigned char pPixels[256 * 256 * 4];
+pDocument->m_pDocumentClass->paintPartTile(pDocument, pPixels, 1, 256, 
256, 0, 0, 256, 256);
+
+// Type again.
+Scheduler::ProcessEventsToIdle();
+aView1.m_bTilesInvalidated = false;
+pDocument->m_pDocumentClass->postKeyEvent(pDocument, 
LOK_KEYEVENT_KEYINPUT, 'x', 0);
+pDocument->m_pDocumentClass->postKeyEvent(pDocument, LOK_KEYEVENT_KEYUP, 
'x', 0);
+Scheduler::ProcessEventsToIdle();
+// This failed: paintPartTile() (as a side-effect) ended the text edit of
+// the first view, so there were no invalidations.
+CPPUNIT_ASSERT(aView1.m_bTilesInvalidated);
+
+mxComponent->dispose();
+mxComponent.clear();
+comphelper::LibreOfficeKit::setActive(false);
+}
 CPPUNIT_TEST_SUITE_REGISTRATION(DesktopLOKTest);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 37a65d1..18cb053 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -1483,6 +1483,7 @@ static void doc_paintPartTile(LibreOfficeKitDocument* 
pThis,
   const int nTilePosX, const int nTilePosY,
   const int nTileWidth, const int nTileHeight)
 {
+SolarMutexGuard aGuard;
 SAL_INFO( "lok.tiledrendering", "paintPartTile: painting @ " << nPart << " 
["
<< nTileWidth << "x" << 

[Libreoffice-commits] core.git: Branch 'private/jmux/master-fixes_7' - 8 commits - avmedia/source basctl/source cui/source dbaccess/source desktop/qa desktop/source editeng/source formula/source frame

[Jan-Marek Glogowski]

Rebased ref, commits from common ancestor:
commit 63a4a23496d43e78e24ad947e9d268cfa1d37eff
Author: Jan-Marek Glogowski 
Date:   Wed Sep 14 18:17:18 2016 +0200

Don't poll busy documents via idle task

Creates a very busy idle-loop, for non-task work like mail merge.

Change-Id: If7be82e4675008f23e6f4f6be5c40df40a231a8b

diff --git a/sw/source/core/doc/DocumentTimerManager.cxx 
b/sw/source/core/doc/DocumentTimerManager.cxx
index 3c1369d..cb96054 100644
--- a/sw/source/core/doc/DocumentTimerManager.cxx
+++ b/sw/source/core/doc/DocumentTimerManager.cxx
@@ -40,47 +40,50 @@ namespace sw
 DocumentTimerManager::DocumentTimerManager( SwDoc& i_rSwdoc ) : m_rDoc( 
i_rSwdoc ),
 
mbStartIdleTimer( false ),
 
mIdleBlockCount( 0 ),
-
maIdle("DocumentTimerManagerIdleTimer")
+
maDocIdleTimer("DocumentTimerManagerIdleTimer")
 {
-maIdle.SetPriority( SchedulerPriority::LOWEST );
-maIdle.SetIdleHdl( LINK( this, DocumentTimerManager, DoIdleJobs) );
-maIdle.SetDebugName( "sw::DocumentTimerManager maIdle" );
+maDocIdleTimer.SetPriority( SchedulerPriority::LOWEST );
+maDocIdleTimer.SetTimeoutHdl( LINK( this, DocumentTimerManager, 
DoIdleJobs) );
+maDocIdleTimer.SetDebugName( "sw::DocumentTimerManager maDocIdleTimer" );
 }
 
 void DocumentTimerManager::StartIdling()
 {
 mbStartIdleTimer = true;
 if( !mIdleBlockCount )
-maIdle.Start();
+{
+maDocIdleTimer.SetTimeout( 0 );
+maDocIdleTimer.Start();
+}
 }
 
 void DocumentTimerManager::StopIdling()
 {
 mbStartIdleTimer = false;
-maIdle.Stop();
+maDocIdleTimer.Stop();
 }
 
 void DocumentTimerManager::BlockIdling()
 {
-maIdle.Stop();
+maDocIdleTimer.Stop();
 ++mIdleBlockCount;
 }
 
 void DocumentTimerManager::UnblockIdling()
 {
 --mIdleBlockCount;
-if( !mIdleBlockCount && mbStartIdleTimer && !maIdle.IsActive() )
-maIdle.Start();
+if( !mIdleBlockCount && mbStartIdleTimer && !maDocIdleTimer.IsActive() )
+maDocIdleTimer.Start();
 }
 
 void DocumentTimerManager::StartBackgroundJobs()
 {
 // Trigger DoIdleJobs(), asynchronously.
-if (!maIdle.IsActive()) //fdo#73165 if the timer is already running don't 
restart from 0
-maIdle.Start();
+if (!maDocIdleTimer.IsActive()) //fdo#73165 if the timer is already 
running don't restart from 0
+maDocIdleTimer.Start();
 }
 
-IMPL_LINK_TYPED( DocumentTimerManager, DoIdleJobs, Idle*, pIdle, void )
+IMPL_LINK_TYPED( DocumentTimerManager, DoIdleJobs, Timer*, pTimer, void )
 {
 #ifdef TIMELOG
 static ::rtl::Logfile* pModLogFile = 0;
@@ -97,7 +100,8 @@ IMPL_LINK_TYPED( DocumentTimerManager, DoIdleJobs, Idle*, 
pIdle, void )
 {
 if( rSh.ActionPend() )
 {
-pIdle->Start();
+pTimer->SetTimeout( 2000 );
+pTimer->Start();
 return;
 }
 }
@@ -121,7 +125,8 @@ IMPL_LINK_TYPED( DocumentTimerManager, DoIdleJobs, Idle*, 
pIdle, void )
 (*pLayIter)->GetCurrShell()->LayoutIdle();
 
 // Defer the remaining work.
-pIdle->Start();
+pTimer->SetTimeout( 2000 );
+pTimer->Start();
 return;
 }
 }
@@ -137,7 +142,8 @@ IMPL_LINK_TYPED( DocumentTimerManager, DoIdleJobs, Idle*, 
pIdle, void )
 if ( 
m_rDoc.getIDocumentFieldsAccess().GetUpdateFields().IsInUpdateFields() ||
  m_rDoc.getIDocumentFieldsAccess().IsExpFieldsLocked() )
 {
-pIdle->Start();
+pTimer->SetTimeout( 2000 );
+pTimer->Start();
 return;
 }
 
diff --git a/sw/source/core/inc/DocumentTimerManager.hxx 
b/sw/source/core/inc/DocumentTimerManager.hxx
index cf6b580..2644e45 100644
--- a/sw/source/core/inc/DocumentTimerManager.hxx
+++ b/sw/source/core/inc/DocumentTimerManager.hxx
@@ -48,7 +48,7 @@ public:
 void StartBackgroundJobs() override;
 
 // Our own 'IdleTimer' calls the following method
-DECL_LINK_TYPED( DoIdleJobs, Idle *, void );
+DECL_LINK_TYPED( DoIdleJobs, Timer *, void );
 
 virtual ~DocumentTimerManager() override;
 
@@ -61,7 +61,7 @@ private:
 
 bool mbStartIdleTimer; //< idle timer mode start/stop
 sal_Int32 mIdleBlockCount;
-Idle  maIdle;
+Timer maDocIdleTimer;
 };
 
 }
commit 953c162c55a2882dcb4146cd1f6a225b4ae03f96
Author: Jan-Marek Glogowski 
Date:   Wed Sep 14 15:33:54 2016 +0200

Really schedule Idle tasks immediatly

There is really no reason to wait a millisecond for an idle.

Change-Id: I7665d5f2e7d6ba3e01290a692bbc8e42c36b9986

diff --git 

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 165 commits - accessibility/inc accessibility/source animations/source avmedia/inc avmedia/source basctl/source basegfx/source basic/

[Khaled Hosny]

Rebased ref, commits from common ancestor:
commit 1a7c54d75046d75d09f94d9105941b5adad8a040
Author: Khaled Hosny 
Date:   Sun Sep 11 10:25:46 2016 +0200

Override GetCharWidths and ApplyDXArray in CSL

A much simpler and saner implementation. This also unbreaks Awami
Nastaliq.

Break kashida justification, will need to rewrite that one as well.

Change-Id: I843679e937f2881e77df61f5cbd9516b6df1b3b6

diff --git a/vcl/inc/CommonSalLayout.hxx b/vcl/inc/CommonSalLayout.hxx
index 83de5c1..179eee88 100644
--- a/vcl/inc/CommonSalLayout.hxx
+++ b/vcl/inc/CommonSalLayout.hxx
@@ -65,4 +65,7 @@ public:
 virtual boolLayoutText(ImplLayoutArgs&) override;
 virtual voidDrawText( SalGraphics& ) const override;
 std::shared_ptr CreateTextLayoutCache(OUString 
const&) const override;
+
+virtual boolGetCharWidths(DeviceCoordinate* pCharWidths) const;
+virtual voidApplyDXArray(ImplLayoutArgs&);
 };
diff --git a/vcl/inc/sallayout.hxx b/vcl/inc/sallayout.hxx
index cfb2930..1050943 100644
--- a/vcl/inc/sallayout.hxx
+++ b/vcl/inc/sallayout.hxx
@@ -326,7 +326,7 @@ public:
 voidAppendGlyph( const GlyphItem& );
 voidReserve(int size) { m_GlyphItems.reserve(size + 1); }
 virtual voidAdjustLayout( ImplLayoutArgs& ) override;
-voidApplyDXArray( ImplLayoutArgs& );
+virtual voidApplyDXArray( ImplLayoutArgs& );
 voidJustify( DeviceCoordinate nNewWidth );
 voidKashidaJustify( long nIndex, int nWidth );
 voidApplyAsianKerning(const OUString& rStr);
@@ -352,7 +352,7 @@ protected:
 virtual voidDropGlyph( int nStart ) override;
 virtual voidSimplify( bool bIsBase ) override;
 
-boolGetCharWidths( DeviceCoordinate* pCharWidths ) const;
+virtual boolGetCharWidths( DeviceCoordinate* pCharWidths ) const;
 
 std::vector m_GlyphItems;
 
diff --git a/vcl/source/gdi/CommonSalLayout.cxx 
b/vcl/source/gdi/CommonSalLayout.cxx
index 509086d..f526f28 100644
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -486,3 +486,53 @@ bool CommonSalLayout::LayoutText(ImplLayoutArgs& rArgs)
 
 return true;
 }
+
+bool CommonSalLayout::GetCharWidths(DeviceCoordinate* pCharWidths) const
+{
+int nCharCount = mnEndCharPos - mnMinCharPos;
+
+for (int i = 0; i < nCharCount; ++i)
+pCharWidths[i] = 0;
+
+for (auto const& aGlyphItem : m_GlyphItems)
+pCharWidths[aGlyphItem.mnCharPos - mnMinCharPos] += 
aGlyphItem.mnNewWidth;
+
+return true;
+}
+
+void CommonSalLayout::ApplyDXArray(ImplLayoutArgs& rArgs)
+{
+int nCharCount = mnEndCharPos - mnMinCharPos;
+long pOldCharWidths[nCharCount];
+long pNewCharWidths[nCharCount];
+
+GetCharWidths(pOldCharWidths);
+
+for (int i = 0; i < nCharCount; ++i)
+{
+if (i == 0)
+  pNewCharWidths[i] = rArgs.mpDXArray[i];
+else
+  pNewCharWidths[i] = rArgs.mpDXArray[i] - rArgs.mpDXArray[i - 1];
+}
+
+long nDelta = 0;
+size_t i = 0;
+while (i < m_GlyphItems.size())
+{
+int nCharPos = m_GlyphItems[i].mnCharPos - mnMinCharPos;
+long nDiff = pNewCharWidths[nCharPos] - pOldCharWidths[nCharPos];
+
+m_GlyphItems[i].maLinearPos.X() += nDelta;
+size_t j = i;
+while (++j < m_GlyphItems.size())
+{
+if (m_GlyphItems[j].mnCharPos != m_GlyphItems[i].mnCharPos)
+  break;
+m_GlyphItems[j].maLinearPos.X() += nDelta;
+}
+
+nDelta += nDiff;
+i = j;
+}
+}
commit 216b57abd086ed6c28c5836306d4f40791a8bb99
Author: Khaled Hosny 
Date:   Wed Sep 7 23:26:14 2016 +0200

Don’t check glyph class unnecessarily

Don’t call hb_ot_layout_get_glyph_class() unless the glyph advance width
is zero, as we really do not use its result otherwise.

Change-Id: Id02238abef91b9343931f1886d54d966d7157f25

diff --git a/vcl/source/gdi/CommonSalLayout.cxx 
b/vcl/source/gdi/CommonSalLayout.cxx
index 88afecc..509086d 100644
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -439,9 +439,8 @@ bool CommonSalLayout::LayoutText(ImplLayoutArgs& rArgs)
 if (hb_ot_layout_has_glyph_classes(pHbFace))
 {
 // the font has GDEF table
-bool bMark = hb_ot_layout_get_glyph_class(pHbFace, 
nGlyphIndex) == HB_OT_LAYOUT_GLYPH_CLASS_MARK;
-if (bMark && pHbPositions[i].x_advance == 0)
-bDiacritic = true;
+if (pHbPositions[i].x_advance == 0)
+bDiacritic = hb_ot_layout_get_glyph_class(pHbFace, 
nGlyphIndex) == HB_OT_LAYOUT_GLYPH_CLASS_MARK;
 }
 else
 {
commit 56d26cba9ec38cbcef703a4b47067944b8a252b0
Author: Khaled Hosny 

[Libreoffice-commits] online.git: 2 commits - loleaflet/src

[Pranav Kant]

 loleaflet/src/control/Parts.js|1 
 loleaflet/src/layer/tile/TileLayer.js |   59 ++
 2 files changed, 40 insertions(+), 20 deletions(-)

New commits:
commit 8bd7d83bdcaa2d9654633954f43695a53e07be91
Author: Pranav Kant 
Date:   Thu Sep 15 00:12:17 2016 +0530

loleaflet: Handle multiview text selections for part documents

Change-Id: I56425cde49b2b3b319204d7172f4ec4080b5bed1

diff --git a/loleaflet/src/control/Parts.js b/loleaflet/src/control/Parts.js
index 55e9dbb..cdde4d1 100644
--- a/loleaflet/src/control/Parts.js
+++ b/loleaflet/src/control/Parts.js
@@ -34,6 +34,7 @@ L.Map.include({
docLayer.eachView(docLayer._viewCursors, 
docLayer._onUpdateViewCursor, docLayer);
docLayer.eachView(docLayer._cellViewCursors, 
docLayer._onUpdateCellViewCursor, docLayer);
docLayer.eachView(docLayer._graphicViewMarkers, 
docLayer._onUpdateGraphicViewSelection, docLayer);
+   docLayer.eachView(docLayer._viewSelections, 
docLayer._onUpdateTextViewSelection, docLayer);
docLayer._clearSelections();
docLayer._updateOnChangePart();
docLayer._pruneTiles();
diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index 030b4b4..e6e2c7c 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -719,8 +719,8 @@ L.TileLayer = L.GridLayer.extend({
}
 
// Remove selection, if any.
-   if (this._viewSelections[viewId]) {
-   
this._viewSelectionsGroup.removeLayer(this._viewSelections[viewId]);
+   if (this._viewSelections[viewId] && 
this._viewSelections[viewId].selection) {
+   
this._viewSelectionsGroup.removeLayer(this._viewSelections[viewId].selection);
}
 
// Remove the view and update (to refresh as needed).
@@ -914,6 +914,7 @@ L.TileLayer = L.GridLayer.extend({
textMsg = textMsg.substring('textviewselection:'.length + 1);
var obj = JSON.parse(textMsg);
var viewId = parseInt(obj.viewId);
+   var viewPart = parseInt(obj.part);
 
// Ignore if viewid is same as ours
if (viewId === this._viewId) {
@@ -921,9 +922,7 @@ L.TileLayer = L.GridLayer.extend({
}
 
var strTwips = obj.selection.match(/\d+/g);
-   if (this._viewSelections[viewId]) {
-   
this._viewSelectionsGroup.removeLayer(this._viewSelections[viewId]);
-   }
+   this._viewSelections[viewId] = this._viewSelections[viewId] || 
{};
if (strTwips != null) {
var rectangles = [];
for (var i = 0; i < strTwips.length; i += 4) {
@@ -935,16 +934,13 @@ L.TileLayer = L.GridLayer.extend({
rectangles.push([bottomLeftTwips, 
bottomRightTwips, topLeftTwips, topRightTwips]);
}
 
-   var polygons = 
L.PolyUtil.rectanglesToPolygons(rectangles, this);
-   var selection = new L.Polygon(polygons, {
-   pointerEvents: 'none',
-   fillColor: L.LOUtil.getViewIdHexColor(viewId),
-   fillOpacity: 0.25,
-   weight: 2,
-   opacity: 0.25});
-   this._viewSelections[viewId] = selection;
-   this._viewSelectionsGroup.addLayer(selection);
+   this._viewSelections[viewId].part = viewPart;
+   this._viewSelections[viewId].polygons = 
L.PolyUtil.rectanglesToPolygons(rectangles, this);
+   } else {
+   this._viewSelections[viewId].polygons = null;
}
+
+   this._onUpdateTextViewSelection(viewId);
},
 
_onTextSelectionContentMsg: function (textMsg) {
@@ -1177,6 +1173,35 @@ L.TileLayer = L.GridLayer.extend({
}
},
 
+   _onUpdateTextViewSelection: function (viewId) {
+   viewId = parseInt(viewId);
+   var viewPolygons = this._viewSelections[viewId].polygons;
+   var viewSelection = this._viewSelections[viewId].selection;
+   var viewPart = this._viewSelections[viewId].part;
+
+   if (viewPolygons &&
+   (this._docType === 'text' || this._selectedPart === 
viewPart)) {
+
+   // Reset previous selections
+   if (viewSelection) {
+   
this._viewSelectionsGroup.removeLayer(viewSelection);
+   }
+
+   viewSelection = new L.Polygon(viewPolygons, {
+   pointerEvents: 'none',
+  

[Libreoffice-commits] core.git: basctl/source include/sfx2 include/svx sfx2/source svx/source sw/inc sw/source

[Jochen Nitschke]

 basctl/source/basicide/basides1.cxx  |5 +-
 basctl/source/basicide/basidesh.cxx  |2 -
 basctl/source/inc/basidesh.hxx   |5 --
 include/sfx2/objface.hxx |8 ++--
 include/sfx2/shell.hxx   |   32 ++
 include/svx/fmshell.hxx  |2 -
 sfx2/source/control/dispatch.cxx |8 ++--
 sfx2/source/control/objface.cxx  |   20 +--
 sfx2/source/control/shell.cxx|2 -
 svx/source/form/fmshell.cxx  |   59 ++-
 sw/inc/view.hxx  |7 +---
 sw/source/uibase/uiview/view0.cxx|4 +-
 sw/source/uibase/uiview/viewstat.cxx |   13 ---
 13 files changed, 92 insertions(+), 75 deletions(-)

New commits:
commit 0f33526ec27a3abcfa1ca9348a46238b1432e5e4
Author: Jochen Nitschke 
Date:   Wed Sep 14 19:33:42 2016 +0200

put all SfxShell feature flags in one typed_flags class

make values unique across modules.
check if flag used in correct module.

Change-Id: I656ffd3d527dd895777e14e1cc933c8b9b3f6e46
Reviewed-on: https://gerrit.libreoffice.org/28906
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/basctl/source/basicide/basides1.cxx 
b/basctl/source/basicide/basides1.cxx
index 4546873..5f41f79 100644
--- a/basctl/source/basicide/basides1.cxx
+++ b/basctl/source/basicide/basides1.cxx
@@ -952,11 +952,12 @@ void Shell::GetState(SfxItemSet )
 pCurWin->GetState( rSet );
 }
 
-bool Shell::HasUIFeature( sal_uInt32 nFeature )
+bool Shell::HasUIFeature(SfxShellFeature nFeature) const
 {
+assert((nFeature & ~SfxShellFeature::BasicMask) == SfxShellFeature::NONE);
 bool bResult = false;
 
-if ( (nFeature & BASICIDE_UI_FEATURE_SHOW_BROWSER) == 
BASICIDE_UI_FEATURE_SHOW_BROWSER )
+if (nFeature & SfxShellFeature::BasicShowBrowser)
 {
 // fade out (in) property browser in module (dialog) windows
 if (dynamic_cast(pCurWin.get()) && 
!pCurWin->IsReadOnly())
diff --git a/basctl/source/basicide/basidesh.cxx 
b/basctl/source/basicide/basidesh.cxx
index e48d820..75a75c0 100644
--- a/basctl/source/basicide/basidesh.cxx
+++ b/basctl/source/basicide/basidesh.cxx
@@ -136,7 +136,7 @@ SFX_IMPL_INTERFACE(basctl_Shell, SfxViewShell)
 void basctl_Shell::InitInterface_Impl()
 {
 GetStaticInterface()->RegisterChildWindow(SID_SEARCH_DLG);
-GetStaticInterface()->RegisterChildWindow(SID_SHOW_PROPERTYBROWSER, false, 
BASICIDE_UI_FEATURE_SHOW_BROWSER);
+GetStaticInterface()->RegisterChildWindow(SID_SHOW_PROPERTYBROWSER, false, 
SfxShellFeature::BasicShowBrowser);
 
GetStaticInterface()->RegisterChildWindow(SfxInfoBarContainerChild::GetChildWindowId());
 
 GetStaticInterface()->RegisterPopupMenu("dialog");
diff --git a/basctl/source/inc/basidesh.hxx b/basctl/source/inc/basidesh.hxx
index 763ca12..e756caa 100644
--- a/basctl/source/inc/basidesh.hxx
+++ b/basctl/source/inc/basidesh.hxx
@@ -39,9 +39,6 @@ class StarBASIC;
 
 namespace basctl
 {
-
-const sal_uLong BASICIDE_UI_FEATURE_SHOW_BROWSER = 0x0001;
-
 class Layout;
 class ModulWindow;
 class ModulWindowLayout;
@@ -180,7 +177,7 @@ public:
 voidExecuteBasic( SfxRequest& rReq );
 voidExecuteDialog( SfxRequest& rReq );
 
-virtual boolHasUIFeature( sal_uInt32 nFeature ) override;
+virtual boolHasUIFeature(SfxShellFeature nFeature) const override;
 
 boolCallBasicErrorHdl( StarBASIC* pBasic );
 longCallBasicBreakHdl( StarBASIC* pBasic );
diff --git a/include/sfx2/objface.hxx b/include/sfx2/objface.hxx
index babbc9f..a0dfc16 100644
--- a/include/sfx2/objface.hxx
+++ b/include/sfx2/objface.hxx
@@ -65,16 +65,16 @@ public:
 const SfxInterface* GetGenoType() const { return pGenoType; }
 
 voidRegisterObjectBar(sal_uInt16, sal_uInt32 nResId);
-voidRegisterObjectBar(sal_uInt16, sal_uInt32 nResId, 
sal_uInt32 nFeature);
+voidRegisterObjectBar(sal_uInt16, sal_uInt32 nResId, 
SfxShellFeature nFeature);
 voidRegisterChildWindow(sal_uInt16, bool bContext = 
false);
-voidRegisterChildWindow(sal_uInt16, bool bContext, 
sal_uInt32 nFeature);
+voidRegisterChildWindow(sal_uInt16, bool bContext, 
SfxShellFeature nFeature);
 voidRegisterStatusBar(sal_uInt32 nResId);
 sal_uInt32  GetObjectBarId(sal_uInt16 nNo) const;
 sal_uInt16  GetObjectBarPos( sal_uInt16 nNo ) const;
-sal_uInt32  GetObjectBarFeature( sal_uInt16 nNo ) const;
+SfxShellFeature GetObjectBarFeature(sal_uInt16 nNo) const;
 sal_uInt16  GetObjectBarCount() const;
 boolIsObjectBarVisible( sal_uInt16 nNo) const;
-sal_uInt32 

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-1-9' - 26 commits - loleaflet/Makefile loleaflet/src loolwsd/bundled loolwsd/ChildSession.cpp loolwsd/configure.ac loolwsd/D

[Andras Timar]

 loleaflet/Makefile   |2 
 loleaflet/src/control/Parts.js   |4 
 loleaflet/src/layer/marker/Cursor.js |   33 +
 loleaflet/src/layer/tile/TileLayer.js|  191 +++
 loleaflet/src/map/Map.js |4 
 loolwsd/ChildSession.cpp |1 
 loolwsd/DocumentBroker.cpp   |   29 -
 loolwsd/LOOLKit.cpp  |   33 -
 loolwsd/LOOLStress.cpp   |5 
 loolwsd/LibreOfficeKit.hpp   |   11 
 loolwsd/MessageQueue.cpp |2 
 loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKit.h  |4 
 loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKitEnums.h |2 
 loolwsd/configure.ac |2 
 loolwsd/test/data/viewcursor.odp |binary
 loolwsd/test/helpers.hpp |1 
 loolwsd/test/httpwstest.cpp  |  165 +
 17 files changed, 372 insertions(+), 117 deletions(-)

New commits:
commit b63c9a6ee45fa24b50e3072f6482d0091bc0e470
Author: Andras Timar 
Date:   Wed Sep 14 22:04:14 2016 +0200

Bump version to 1.9.1

diff --git a/loleaflet/Makefile b/loleaflet/Makefile
index d249a5a..1e1d7f1 100644
--- a/loleaflet/Makefile
+++ b/loleaflet/Makefile
@@ -3,7 +3,7 @@
 # ("micro") part: Between releases odd, even for releases (no other
 # changes inbetween).
 
-VERSION=1.9.0
+VERSION=1.9.1
 
 # Version number of the bundled 'draw' thing
 DRAW_VERSION=0.2.4
diff --git a/loolwsd/configure.ac b/loolwsd/configure.ac
index f301f60..06b511c 100644
--- a/loolwsd/configure.ac
+++ b/loolwsd/configure.ac
@@ -3,7 +3,7 @@
 
 AC_PREREQ([2.69])
 
-AC_INIT([loolwsd], [1.9.0], [libreoffice@lists.freedesktop.org])
+AC_INIT([loolwsd], [1.9.1], [libreoffice@lists.freedesktop.org])
 LT_INIT([shared, disable-static, dlopen])
 
 AM_INIT_AUTOMAKE([1.11 silent-rules subdir-objects])
commit 40c5b26cb2839dbfb3d63ce9c8539767bfe0ce6e
Author: Pranav Kant 
Date:   Thu Sep 15 00:12:17 2016 +0530

loleaflet: Handle multiview text selections for part documents

Change-Id: I56425cde49b2b3b319204d7172f4ec4080b5bed1
(cherry picked from commit 8bd7d83bdcaa2d9654633954f43695a53e07be91)

diff --git a/loleaflet/src/control/Parts.js b/loleaflet/src/control/Parts.js
index 55e9dbb..cdde4d1 100644
--- a/loleaflet/src/control/Parts.js
+++ b/loleaflet/src/control/Parts.js
@@ -34,6 +34,7 @@ L.Map.include({
docLayer.eachView(docLayer._viewCursors, 
docLayer._onUpdateViewCursor, docLayer);
docLayer.eachView(docLayer._cellViewCursors, 
docLayer._onUpdateCellViewCursor, docLayer);
docLayer.eachView(docLayer._graphicViewMarkers, 
docLayer._onUpdateGraphicViewSelection, docLayer);
+   docLayer.eachView(docLayer._viewSelections, 
docLayer._onUpdateTextViewSelection, docLayer);
docLayer._clearSelections();
docLayer._updateOnChangePart();
docLayer._pruneTiles();
diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index 030b4b4..e6e2c7c 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -719,8 +719,8 @@ L.TileLayer = L.GridLayer.extend({
}
 
// Remove selection, if any.
-   if (this._viewSelections[viewId]) {
-   
this._viewSelectionsGroup.removeLayer(this._viewSelections[viewId]);
+   if (this._viewSelections[viewId] && 
this._viewSelections[viewId].selection) {
+   
this._viewSelectionsGroup.removeLayer(this._viewSelections[viewId].selection);
}
 
// Remove the view and update (to refresh as needed).
@@ -914,6 +914,7 @@ L.TileLayer = L.GridLayer.extend({
textMsg = textMsg.substring('textviewselection:'.length + 1);
var obj = JSON.parse(textMsg);
var viewId = parseInt(obj.viewId);
+   var viewPart = parseInt(obj.part);
 
// Ignore if viewid is same as ours
if (viewId === this._viewId) {
@@ -921,9 +922,7 @@ L.TileLayer = L.GridLayer.extend({
}
 
var strTwips = obj.selection.match(/\d+/g);
-   if (this._viewSelections[viewId]) {
-   
this._viewSelectionsGroup.removeLayer(this._viewSelections[viewId]);
-   }
+   this._viewSelections[viewId] = this._viewSelections[viewId] || 
{};
if (strTwips != null) {
var rectangles = [];
for (var i = 0; i < strTwips.length; i += 

Re: Recommended build instructions ...

[Bjoern Michaelsen]

Hi,

On Wed, Sep 14, 2016 at 01:23:46PM -0700, slacka wrote:
> Does anyone has a version of make that works with make
> vs2013-ide-integration? If so, could you please share it on a cloud storage
> service? 

Clinging to ancient toolchains isnt sustainable, Better: Adapt the script to
work with current versions of make.

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Recommended build instructions ...

[slacka]

Is the  "make vs2013-ide-integration" script working for anyone? With a clean
Win 10 install + VS 2013 + LODE, I always get:
make[1]: *** [cmd] Error 127 

From, 
http://nabble.documentfoundation.org/Error-building-Visual-Studio-2013-project-file-for-LibreOffice-on-Windows-tp4140307p4140941.html

"The "make version 4.0" do it wrong, I build ONLY the VS-Solution with "make
version 3.82"
The size is 517.746 Bytes when you have trouble to found, call me, I have
forget where I downloaded."

Lode used to download 3.82, but now it downloads 4.0. So new users are out
of luck.

Does anyone has a version of make that works with make
vs2013-ide-integration? If so, could you please share it on a cloud storage
service? 



--
View this message in context: 
http://nabble.documentfoundation.org/Recommended-build-instructions-tp4193014p4193568.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] online.git: loolwsd/DocumentBroker.cpp

[Michael Meeks]

 loolwsd/DocumentBroker.cpp |   29 -
 1 file changed, 24 insertions(+), 5 deletions(-)

New commits:
commit 787ee1d2d2719f4fed161dd66eb7d3e21c512bd3
Author: Michael Meeks 
Date:   Wed Sep 14 22:15:43 2016 +0100

Revert "loolwsd: don't combine tiles by row to allow for better culling"

This breaks combine-tiles very significantly, viewing images
in documents with this appears to show each tile scaling and
rendering individually.

This reverts commit 99d0ee2ac111e7199626f6c17fb7ce723dac9126.

diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp
index fe73d63..043218f 100644
--- a/loolwsd/DocumentBroker.cpp
+++ b/loolwsd/DocumentBroker.cpp
@@ -532,7 +532,8 @@ void 
DocumentBroker::handleTileCombinedRequest(TileCombined& tileCombined,
 Log::trace() << "TileCombined request for " << tileCombined.serialize() << 
Log::end;
 
 // Satisfy as many tiles from the cache.
-std::vector tiles;
+// The rest, group by rows.
+std::map rows;
 for (auto& tile : tileCombined.getTiles())
 {
 std::unique_ptr cachedTile = 
_tileCache->lookupTile(tile);
@@ -586,16 +587,34 @@ void 
DocumentBroker::handleTileCombinedRequest(TileCombined& tileCombined,
 }
 }
 
-tiles.push_back(tile);
+const auto tilePosY = tile.getTilePosY();
+auto it = rows.lower_bound(tilePosY);
+if (it != rows.end())
+{
+it->second.emplace_back(tile);
+}
+else
+{
+rows.emplace_hint(it, tilePosY, std::vector({ tile }));
+}
 }
 
-for (auto& tile : tiles)
+if (rows.empty())
 {
-const auto tileMsg = tile.serialize("tile ");
+// Done.
+return;
+}
+
+auto& tiles = tileCombined.getTiles();
+for (auto& row : rows)
+{
+tiles = row.second;
+const auto tileMsg = tileCombined.serialize();
 Log::debug() << "TileCombined residual request for " << tileMsg << 
Log::end;
 
 // Forward to child to render.
-_childProcess->getWebSocket()->sendFrame(tileMsg.data(), 
tileMsg.size());
+const std::string request = "tilecombine " + tileMsg;
+_childProcess->getWebSocket()->sendFrame(request.data(), 
request.size());
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svtools/source

[Norbert Thiebaud]

 svtools/source/graphic/grfmgr2.cxx |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit 91cc48f3d4b8e11f44a366e395b010203ff9c5bc
Author: Norbert Thiebaud 
Date:   Tue Sep 13 12:35:43 2016 +0200

cid#1372878 modulo by zero

Change-Id: I37ed251597f44d382fde96c39ff9d07e4d14c50a
Reviewed-on: https://gerrit.libreoffice.org/28859
Reviewed-by: Norbert Thiebaud 
Tested-by: Norbert Thiebaud 

diff --git a/svtools/source/graphic/grfmgr2.cxx 
b/svtools/source/graphic/grfmgr2.cxx
index 67ead4c..408bee5 100644
--- a/svtools/source/graphic/grfmgr2.cxx
+++ b/svtools/source/graphic/grfmgr2.cxx
@@ -1675,8 +1675,10 @@ bool GraphicObject::ImplRenderTempTile( VirtualDevice& 
rVDev,
 }
 
 // one less
-nMSBFactor /= nExponent;
-
+if(nMSBFactor > 1)
+{
+nMSBFactor /= nExponent;
+}
 ImplTileInfo aTileInfo;
 
 // #105229# Switch off mapping (converting to logic and back to
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/build loleaflet/src

[Henry Castro]

 loleaflet/build/deps.js  |3 -
 loleaflet/src/layer/vector/Path.Popup.js |   72 +++
 loleaflet/src/layer/vector/SVG.js|   21 +
 3 files changed, 95 insertions(+), 1 deletion(-)

New commits:
commit 44c3d5dfdec440164abbae9833fe9a7b6a96aa0f
Author: Henry Castro 
Date:   Wed Sep 14 19:22:31 2016 -0400

loleaflet: add Path.Popup

diff --git a/loleaflet/build/deps.js b/loleaflet/build/deps.js
index cb83325..58a2ff1 100644
--- a/loleaflet/build/deps.js
+++ b/loleaflet/build/deps.js
@@ -119,7 +119,8 @@ var deps = {
Path: {
src: [
'layer/vector/Renderer.js',
-   'layer/vector/Path.js'
+   'layer/vector/Path.js',
+   'layer/vector/Path.Popup.js'
],
desc: 'Vector rendering core.',
heading: 'Vector layers'
diff --git a/loleaflet/src/layer/vector/Path.Popup.js 
b/loleaflet/src/layer/vector/Path.Popup.js
new file mode 100644
index 000..a3dcef5
--- /dev/null
+++ b/loleaflet/src/layer/vector/Path.Popup.js
@@ -0,0 +1,72 @@
+/*
+ * Popup extension to L.Path (polylines, polygons, circles), adding 
popup-related methods.
+ */
+
+L.Path.include({
+
+   bindPopup: function (content, options) {
+
+   if (content instanceof L.Popup) {
+   this._popup = content;
+   } else {
+   if (!this._popup || options) {
+   this._popup = new L.Popup(options, this);
+   }
+   this._popup.setContent(content);
+   }
+
+   if (!this._popupHandlersAdded) {
+   this.on({
+   mouseover: this._openPopup,
+   mouseout: this._delayClose,
+   remove: this.closePopup,
+   add: this.firstPopup
+   });
+
+   this._popupHandlersAdded = true;
+   }
+
+   return this;
+   },
+
+   unbindPopup: function () {
+   if (this._popup) {
+   this._popup = null;
+   this.off({
+   mouseover: this._openPopup,
+   mouseout: this._delayClose,
+   remove: this.closePopup,
+   add: this.firstPopup
+   });
+
+   this._popupHandlersAdded = false;
+   }
+   return this;
+   },
+
+   firstPopup: function (e) {
+   if (this._popup) {
+   this._openPopup({latlng: this._bounds.getCenter()});
+   }
+   },
+
+   closePopup: function () {
+   if (this._popup) {
+   this._popup._close();
+   }
+   return this;
+   },
+
+   _delayClose: function () {
+   clearTimeout(this._timer);
+   this._timer = setTimeout(L.bind(this.closePopup, this), 3000);
+   },
+
+   _openPopup: function (e) {
+   if (!this._map.hasLayer(this._popup)) {
+   this._popup.setLatLng(e.latlng);
+   this._map.openPopup(this._popup);
+   this._delayClose();
+   }
+   }
+});
diff --git a/loleaflet/src/layer/vector/SVG.js 
b/loleaflet/src/layer/vector/SVG.js
index 3b203df..9d0affb 100644
--- a/loleaflet/src/layer/vector/SVG.js
+++ b/loleaflet/src/layer/vector/SVG.js
@@ -45,11 +45,32 @@ L.SVG = L.Renderer.extend({
 
if (layer.options.interactive) {
L.DomUtil.addClass(path, 'leaflet-interactive');
+
+   var events = ['mouseenter', 'mouseout'];
+   for (var i = 0; i < events.length; i++) {
+   L.DomEvent.on(path, events[i], 
this._fireMouseEvent, this);
+   }
}
 
this._updateStyle(layer);
},
 
+   _fireMouseEvent: function (e) {
+   if (!this._map || !this.hasEventListeners(e.type)) { return; }
+
+   var map = this._map,
+   containerPoint = map.mouseEventToContainerPoint(e),
+   layerPoint = map.containerPointToLayerPoint(containerPoint),
+   latlng = map.layerPointToLatLng(layerPoint);
+
+   this.fire(e.type, {
+   latlng: latlng,
+   layerPoint: layerPoint,
+   containerPoint: containerPoint,
+   originalEvent: e
+   });
+   },
+
_addPath: function (layer) {
this._container.appendChild(layer._path);
layer.addInteractiveTarget(layer._path);

[Libreoffice-commits] online.git: loleaflet/src

[Henry Castro]

 loleaflet/src/layer/tile/TileLayer.js |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 7cb35bff635df9da6917dac4a8857eeb4c2c1208
Author: Henry Castro 
Date:   Wed Sep 14 19:30:26 2016 -0400

loleaflet: view name bind to popup

diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index e6e2c7c..89320d4 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -1211,10 +1211,11 @@ L.TileLayer = L.GridLayer.extend({
   (this._docType === 'text' || this._selectedPart === 
viewPart)) {
if (!viewMarker) {
viewMarker = L.rectangle(viewBounds, {
-   pointerEvents: 'none',
+   pointerEvents: 'auto',
fill: false,
color: 
L.LOUtil.getViewIdHexColor(viewId)
});
+   
viewMarker.bindPopup(this._map.getViewName(viewId), {autoClose: false});
this._graphicViewMarkers[viewId].marker = 
viewMarker;
}
else {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Changes to 'private/Ashod/tileprioritization'

[Ashod Nakashian]

New branch 'private/Ashod/tileprioritization' available with the following 
commits:
commit 9eab90410a0b676f426d9f5fa0dc8b595128d899
Author: Ashod Nakashian 
Date:   Wed Sep 14 17:43:56 2016 -0400

loolwsd: unittest runner improvement and logging

Change-Id: I4ddce1775b620e9140366ae7965b37b6cce8689e

commit aa60674c53781b87dba0d331d3a8d8498e56dc85
Author: Ashod Nakashian 
Date:   Wed Sep 14 17:43:29 2016 -0400

loolwsd: unittest for tile prioritization

Change-Id: Ib5ea6b94d651124106069f8d796b7359c92639a8

commit b52bc26374c6d262837d0d519f2992ad79db639d
Author: Ashod Nakashian 
Date:   Wed Sep 14 17:42:50 2016 -0400

loolwsd: tile prioritization per view cursor

Change-Id: I1410b64982ac2db04e5a47d744a95b8d2eab5f7e

commit 663c14250324a8cc358643adc07b3cb9c663cb60
Author: Ashod Nakashian 
Date:   Tue Sep 13 18:40:23 2016 -0400

loolwsd: log tile version in stats

Change-Id: Ia8a466b50f5236cb555c962830843c4d7d77fa97

commit 0e2b0c476643ccb1bc6bafbc879e60be26661cb3
Author: Ashod Nakashian 
Date:   Sun Sep 11 13:18:22 2016 -0400

loolwsd: queue -> tileQueue

Change-Id: If61de6807fa7f52a703fe45948df911fe162f69a

commit 5a502be7448984dec7e3088794d7c4852d1bb6ae
Author: Ashod Nakashian 
Date:   Sun Sep 11 14:29:49 2016 -0400

loolwsd: better unittest context logging

Change-Id: Ie96cf8d1e086bbbeb594b5494318cfd31960b55c

commit d20c377710d2fe047b8f86ee901dba4a5bc98976
Author: Ashod Nakashian 
Date:   Sun Sep 11 14:29:09 2016 -0400

loolwsd: cleanup of unittests and helpers

Change-Id: I03a5cb29b51409f3b8cc51981b522248a29a6ba3

commit 3626e233c9cacddcb44903e0732c9d8ad51d02e7
Author: Ashod Nakashian 
Date:   Sun Sep 11 14:22:24 2016 -0400

loolstress: improved benchmarking and stats

Change-Id: I8b9c2879dbc3ebc37df27eb5c4138bf48c4408c2

commit b1570055bf84df089fa70b058113a2cd0053bddf
Author: Ashod Nakashian 
Date:   Fri Sep 2 17:50:59 2016 -0400

loolwsd: benchmark iterations count as argument to the cli

Change-Id: I2598937ec01dbc4672f88f86d642b32b1b000d91

commit 01186c61b15199cbcd02d0ca718a677176fb5c5b
Author: Ashod Nakashian 
Date:   Fri Sep 2 16:35:44 2016 -0400

loolstress: cout <-> cerr

Change-Id: I5bd530ccddab357054a9093bec54807a649dbe05

commit 595c8c81d07701343c7db956653cca64e86ec631
Author: Ashod Nakashian 
Date:   Tue Sep 13 18:44:57 2016 -0400

Revert "loolwsd: we use callbacks latch for not missing messages

... sent very early"

This reverts commit ed983f17cbf2627ff7b1b1a04af03449bd18ff6b.

This restores unit-tests which fail with the reverted patch.

Change-Id: Ica9fd28220a76316af6948b3b4a77b008d988397

commit dd430a3367d49c021dc6d64202702b102f1a6eb6
Author: Ashod Nakashian 
Date:   Sun Sep 11 13:33:25 2016 -0400

Revert "Revert "loolwsd: remove tile queue and simplify tile response""

This reverts commit 1bb09798f63e3c47bc5863e5df68d77a123f44a3.

commit d0ff08eeb587ad0584fa7d5a666437976c6eea74
Author: Ashod Nakashian 
Date:   Sun Sep 11 13:31:19 2016 -0400

Revert "Revert "loolwsd: canceltiles re-designed using tilecache instead of 
queue""

This reverts commit 112a1949bd365a53985cc37890c6b233fbf72ca8.

commit 0d24df6064acb5976f1afd0a1020ea4e804b29d1
Author: Ashod Nakashian 
Date:   Sun Sep 11 13:26:19 2016 -0400

Revert "Revert "loolwsd: remove queue thread from child socket handler""

This reverts commit 77f117a695056c8f79a0e5eae05c9d54b7c172f9.

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'private/Ashod/tileprioritization' - loolwsd/LOOLKit.cpp

[Ashod Nakashian]

 loolwsd/LOOLKit.cpp |1 +
 1 file changed, 1 insertion(+)

New commits:
commit b7c1225f193c5afbd3459b0096cd34460a6552ba
Author: Ashod Nakashian 
Date:   Wed Sep 14 18:02:03 2016 -0400

loolwsd: remove cursor of unloading views

Change-Id: I4281a5aa101f034007aa227bb18b14eeba806ea0

diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 0f925a6..e707a79 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -933,6 +933,7 @@ private:
 
 // Broadcast the demise and removal of session.
 notifyOtherSessions(sessionId, "remview: " + 
std::to_string(session.getViewId()));
+_tileQueue->removeCursorPosition(session.getViewId());
 
 if (_loKitDocument == nullptr)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: 4 commits - loolwsd/LOOLKit.cpp loolwsd/MessageQueue.cpp loolwsd/MessageQueue.hpp

[Ashod Nakashian]

 loolwsd/LOOLKit.cpp  |   39 +--
 loolwsd/MessageQueue.cpp |   78 ---
 loolwsd/MessageQueue.hpp |   50 +-
 3 files changed, 158 insertions(+), 9 deletions(-)

New commits:
commit c01629ab2a52f6f4243df458b0505f231e392c49
Author: Ashod Nakashian 
Date:   Wed Sep 14 18:18:08 2016 -0400

loolwsd: only prioritize tile messages and not tilecombine

Change-Id: Ia292e5b499dd4409dc3a672e4d5360c868d6c71f

diff --git a/loolwsd/MessageQueue.cpp b/loolwsd/MessageQueue.cpp
index 756e568..0660d2b 100644
--- a/loolwsd/MessageQueue.cpp
+++ b/loolwsd/MessageQueue.cpp
@@ -158,6 +158,11 @@ void TileQueue::reprioritize(const CursorPosition& 
cursorPosition)
 {
 auto& it = _queue[i];
 const std::string msg(it.data(), it.size());
+if (msg.compare(0, 5, "tile ") != 0)
+{
+continue;
+}
+
 auto tile = TileDesc::parse(msg); //FIXME: Expensive, avoid.
 
 if (tile.intersectsWithRect(cursorPosition.X, cursorPosition.Y, 
cursorPosition.Width, cursorPosition.Height))
@@ -178,6 +183,11 @@ void TileQueue::reprioritize(const CursorPosition& 
cursorPosition)
 
 bool TileQueue::priority(const std::string& tileMsg)
 {
+if (tileMsg.compare(0, 5, "tile ") != 0)
+{
+return false;
+}
+
 auto tile = TileDesc::parse(tileMsg); //FIXME: Expensive, avoid.
 
 for (auto& pair : _cursorPositions)
commit ad6d77cd3b4ccaeb1da16f100fb3bc3ac4d4c947
Author: Ashod Nakashian 
Date:   Wed Sep 14 18:02:03 2016 -0400

loolwsd: remove cursor of unloading views

Change-Id: I4281a5aa101f034007aa227bb18b14eeba806ea0

diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 387a0d5..583b173 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -940,6 +940,7 @@ private:
 
 // Broadcast the demise and removal of session.
 notifyOtherSessions(sessionId, "remview: " + 
std::to_string(session.getViewId()));
+_tileQueue->removeCursorPosition(session.getViewId());
 
 if (_loKitDocument == nullptr)
 {
commit 2db1db06c75fd67bbc73ba86707f89ee7e4f24c6
Author: Ashod Nakashian 
Date:   Sun Sep 11 13:18:22 2016 -0400

loolwsd: queue -> tileQueue

Change-Id: If61de6807fa7f52a703fe45948df911fe162f69a

diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 2207e7d..387a0d5 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -398,14 +398,14 @@ public:
  const std::string& jailId,
  const std::string& docKey,
  const std::string& url,
- std::shared_ptr queue,
+ std::shared_ptr tileQueue,
  const std::shared_ptr& ws)
   : _multiView(std::getenv("LOK_VIEW_CALLBACK")),
 _loKit(loKit),
 _jailId(jailId),
 _docKey(docKey),
 _url(url),
-_queue(std::move(queue)),
+_tileQueue(std::move(tileQueue)),
 _ws(ws),
 _docPassword(""),
 _haveDocPassword(false),
@@ -419,6 +419,7 @@ public:
 Log::info("Document ctor for url [" + _url + "] on child [" + _jailId +
   "] LOK_VIEW_CALLBACK=" + std::to_string(_multiView) + ".");
 assert(_loKit && _loKit->get());
+
 _callbackThread.start(*this);
 }
 
@@ -1230,7 +1231,7 @@ private:
 {
 while (true)
 {
-const auto input = pThis->_queue->get();
+const auto input = pThis->_tileQueue->get();
 const std::string message(input.data(), input.size());
 StringTokenizer tokens(message, " ", 
StringTokenizer::TOK_IGNORE_EMPTY | StringTokenizer::TOK_TRIM);
 
@@ -1269,7 +1270,7 @@ private:
 std::string _renderOpts;
 
 std::shared_ptr _loKitDocument;
-std::shared_ptr _queue;
+std::shared_ptr _tileQueue;
 std::shared_ptr _ws;
 
 // Document password provided
commit ece87da287433d665a175e92a576f00c639695a2
Author: Ashod Nakashian 
Date:   Wed Sep 14 17:42:50 2016 -0400

loolwsd: tile prioritization per view cursor

Change-Id: I1410b64982ac2db04e5a47d744a95b8d2eab5f7e

diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 73ade5b..2207e7d 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -813,6 +813,35 @@ private:
 
 std::unique_lock lock(pDescr->Doc->_mutex);
 
+if (nType == LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR ||
+nType == LOK_CALLBACK_CELL_CURSOR)
+{
+Poco::StringTokenizer tokens(payload, ",", 
Poco::StringTokenizer::TOK_IGNORE_EMPTY | Poco::StringTokenizer::TOK_TRIM);
+auto cursorX = std::stoi(tokens[0]);
+auto cursorY = std::stoi(tokens[1]);
+auto cursorWidth = std::stoi(tokens[2]);
+auto cursorHeight = 

Re: Test File: sc/qa/unit/data/functions/fods/chiinv.fods: fails with Assertion

[slacka]

Eike Rathke-2 wrote
> If you want to get a working build without disabling all checks then you
> can use
> https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=b9a27d5856f60688456762bfcc29c38670009254
> 
> that disables the function tests for linux_x86 builds.
> 
> However, if you'd find a general solution that does not involve
> disabling the tests that would be more than welcomed.
> 
>   Eike

We are only failing 3 individual tests. And we fail the same tests Excel
fails. Instead of disabling all test for x86 Linux , why not disable or
change the rounding accuracy of the individual tests? 

For example, CHIINV can be made to work with both x86, x86-64 and Excel by
changing 
C8=ROUND(A8,3)=ROUND(B8,3) 
 
VDS can be made to work with x86, x86-64, and Excel by changing
C11=ROUND(A11,10)=ROUND(B11,10)

MINVERSE x86 and Excel get similar results. Unless there is some evidences
we have the same bug in our x86 code as Excel, the test is invalid or the
bug is with the x86-64 code. So shouldn’t we disable that individual test?



Eike Rathke-2 wrote
> So you actually *do* see it. Or only not in chiinv.fods? 

 
Sorry I was not clear. MINVERSE is the first test to fail on my AMD desktop. 
CHIINV does fail but only when I run it manually. I assume the tests are not
run sequentially. Are they? If they are something weird is going on and I
can try disabling MINVERSE and VDS to see if that's enough for a successful 
build. 





--
View this message in context: 
http://nabble.documentfoundation.org/Test-File-sc-qa-unit-data-functions-fods-chiinv-fods-fails-with-Assertion-tp4192267p4193577.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] online.git: Branch 'private/Ashod/tileprioritization' - loolwsd/MessageQueue.cpp

[Ashod Nakashian]

 loolwsd/MessageQueue.cpp |   10 ++
 1 file changed, 10 insertions(+)

New commits:
commit b2a1f06ed084030307b737a3c05facd66e86bb9c
Author: Ashod Nakashian 
Date:   Wed Sep 14 18:18:08 2016 -0400

loolwsd: only prioritize tile messages and not tilecombine

Change-Id: Ia292e5b499dd4409dc3a672e4d5360c868d6c71f

diff --git a/loolwsd/MessageQueue.cpp b/loolwsd/MessageQueue.cpp
index 756e568..0660d2b 100644
--- a/loolwsd/MessageQueue.cpp
+++ b/loolwsd/MessageQueue.cpp
@@ -158,6 +158,11 @@ void TileQueue::reprioritize(const CursorPosition& 
cursorPosition)
 {
 auto& it = _queue[i];
 const std::string msg(it.data(), it.size());
+if (msg.compare(0, 5, "tile ") != 0)
+{
+continue;
+}
+
 auto tile = TileDesc::parse(msg); //FIXME: Expensive, avoid.
 
 if (tile.intersectsWithRect(cursorPosition.X, cursorPosition.Y, 
cursorPosition.Width, cursorPosition.Height))
@@ -178,6 +183,11 @@ void TileQueue::reprioritize(const CursorPosition& 
cursorPosition)
 
 bool TileQueue::priority(const std::string& tileMsg)
 {
+if (tileMsg.compare(0, 5, "tile ") != 0)
+{
+return false;
+}
+
 auto tile = TileDesc::parse(tileMsg); //FIXME: Expensive, avoid.
 
 for (auto& pair : _cursorPositions)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: canvas/source chart2/source comphelper/source configmgr/source connectivity/source cui/source dbaccess/source include/canvas include/comphelper include/connectivity

[Noel Grandin]

 canvas/source/cairo/cairo_cachedbitmap.cxx  |2 
 canvas/source/tools/cachedprimitivebase.cxx |9 --
 canvas/source/vcl/cachedbitmap.cxx  |2 
 chart2/source/controller/dialogs/TextDirectionListBox.cxx   |4 -
 chart2/source/controller/inc/MultipleChartConverters.hxx|6 -
 chart2/source/controller/inc/TextDirectionListBox.hxx   |3 
 chart2/source/controller/itemsetwrapper/MultipleChartConverters.cxx |   10 +-
 comphelper/source/misc/servicedecl.cxx  |6 +
 configmgr/source/access.cxx |2 
 configmgr/source/components.cxx |5 -
 configmgr/source/components.hxx |3 
 connectivity/source/commontools/TIndexColumns.cxx   |2 
 connectivity/source/commontools/TKeyColumns.cxx |3 
 connectivity/source/drivers/dbase/DIndex.cxx|2 
 connectivity/source/drivers/dbase/DIndexColumns.cxx |3 
 connectivity/source/drivers/dbase/dindexnode.cxx|4 -
 connectivity/source/drivers/hsqldb/HUser.cxx|2 
 connectivity/source/drivers/hsqldb/HView.cxx|2 
 connectivity/source/drivers/mork/MorkParser.cxx |4 -
 connectivity/source/drivers/mork/MorkParser.hxx |2 
 connectivity/source/drivers/mysql/YUser.cxx |2 
 connectivity/source/drivers/mysql/YViews.cxx|1 
 connectivity/source/inc/OColumn.hxx |   37 
+++---
 connectivity/source/inc/dbase/DIndexIter.hxx|8 --
 connectivity/source/inc/dbase/dindexnode.hxx|4 -
 connectivity/source/sdbcx/VIndex.cxx|4 -
 connectivity/source/sdbcx/VIndexColumn.cxx  |9 --
 connectivity/source/sdbcx/VKey.cxx  |2 
 connectivity/source/sdbcx/VKeyColumn.cxx|9 --
 connectivity/source/sdbcx/VView.cxx |3 
 cui/source/dialogs/hangulhanjadlg.cxx   |   14 +--
 cui/source/dialogs/iconcdlg.cxx |   24 
--
 cui/source/dialogs/newtabledlg.cxx  |4 -
 cui/source/dialogs/scriptdlg.cxx|5 -
 cui/source/factory/dlgfact.cxx  |4 -
 cui/source/inc/autocdlg.hxx |4 -
 cui/source/inc/iconcdlg.hxx |8 --
 cui/source/inc/newtabledlg.hxx  |2 
 cui/source/inc/numfmt.hxx   |2 
 cui/source/inc/scriptdlg.hxx|2 
 cui/source/options/connpoolconfig.cxx   |4 -
 cui/source/options/connpoolsettings.cxx |4 -
 cui/source/options/connpoolsettings.hxx |2 
 cui/source/tabpages/numfmt.cxx  |4 -
 dbaccess/source/core/api/View.cxx   |2 
 include/canvas/base/cachedprimitivebase.hxx |   11 --
 include/comphelper/servicedecl.hxx  |6 -
 include/connectivity/sdbcx/VIndexColumn.hxx |3 
 include/connectivity/sdbcx/VKeyColumn.hxx   |3 
 include/connectivity/sdbcx/VView.hxx|1 
 50 files changed, 89 insertions(+), 175 deletions(-)

New commits:
commit 1e49e33c26950b606714c0dafb26cbcb2aeb3877
Author: Noel Grandin 
Date:   Mon Sep 12 13:10:16 2016 +0200

loplugin:constantparam in chart2..connectivity

Change-Id: Ic9e1bd36a11c7148fa7595a2b6c6de9bd7a8653d
Reviewed-on: https://gerrit.libreoffice.org/28834
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/canvas/source/cairo/cairo_cachedbitmap.cxx 
b/canvas/source/cairo/cairo_cachedbitmap.cxx
index 2528a68..13e88f1 100644
--- a/canvas/source/cairo/cairo_cachedbitmap.cxx
+++ b/canvas/source/cairo/cairo_cachedbitmap.cxx
@@ -38,7 +38,7 @@ namespace cairocanvas
 const rendering::ViewState& 
rUsedViewState,
 const rendering::RenderState&   
rUsedRenderState,
 const uno::Reference< rendering::XCanvas >& 
rTarget ) :
-CachedPrimitiveBase( rUsedViewState, 

Re: Test File: sc/qa/unit/data/functions/fods/chiinv.fods: fails with Assertion

[Eike Rathke]

Hi Alex,

On Monday, 2016-09-12 20:09:27 +0100, Alex McMurchy wrote:

> Is there anything else I can usefully do? Like
> 
> 1. either stepping through the code

Well, you can try, but it's a more general problem not restricted to
just one or two functions. Entry point for the CHIINV function would be
in sc/source/core/tool/interpr3.cxx ScInterpreter::ScChiInv()

> 2. or bisecting the code

That wouldn't gain anything. You'd just discover that the build error
goes away once bisecting removed the test documents ;-)

> I beginning to wonder whether the problem is environmental and outside of
> LibreOffice.

It's somehow related to how floating point doubles are handled on that
specific 32-bit platform. Different register width, different
instruction set, different compiler optimization; the range of possible
causes is wide.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/
Care about Free Software, support the FSFE https://fsfe.org/support/?erack


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

AW: Recommended build instructions ...

[Juergen Funk Mailinglist]

The other problem with Visual Studio Project file is, some projects included 
not completely or are missing complete

With that solution
http://nabble.documentfoundation.org/Error-building-Visual-Studio-2013-project-file-for-LibreOffice-on-Windows-tp4140307p4140799.html
 
I don't now is the make wrong or the python-script

juergen

Von: LibreOffice  im Auftrag von 
slacka 
Gesendet: Montag, 12. September 2016 23:08
An: libreoffice@lists.freedesktop.org
Betreff: Re: Recommended build instructions ...

Speaking of wiki build instructions, the IDE instructions for Windows have
not worked for almost a year now.
Both the  IDE instructions

and  Windows Instructions

say to build with  build with "--enable-debug" and then "make
vs2013-ide-integration".  This results in the following error:

cd E:/core && (LC_MESSAGES=C E:/lode/opt/bin/make
cmd="E:/cygwin/home/Hearthstone/lode/opt/bin/make -npf Makefile.gbuild all"
cmd || true) | E:/core/bin/gbuild-to-ide --ide vs2013

make[1]: *** [cmd] Error 127

According this thread

, You need an old version of make.

Could someone please verify these instructions, and put them on the wiki
with a *working* download location? None of the versions of make that I was
able to find work with the script in that thread.




--
View this message in context: 
http://nabble.documentfoundation.org/Recommended-build-instructions-tp4193014p4193353.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

QtCreator - problem in compiling hpp files

[Pierre Lepage]

Hello,

I installed QtCreator to work on the LO project. But then, at the first
attempt to compile, I get the following message.
/.../libreoffice/desktop/inc/app.hxx:24: error: com / sun / star / lang /
XMultiServiceFactory.hpp: No such file or directory.

An idea to get out of this impasse with Qt Creator?

Thank you.


Pierre
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] test-files.git: loperf_suites/calc

[Markus Mohrhard]

 loperf_suites/calc/100709.cfg|2 --
 loperf_suites/calc/tdf100709.cfg |2 ++
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 2d0e801aa5fb9f2aefeb43730f14a2c31dd11383
Author: Markus Mohrhard 
Date:   Wed Sep 14 08:28:38 2016 +0200

the tdf prefix was missing

diff --git a/loperf_suites/calc/100709.cfg b/loperf_suites/calc/tdf100709.cfg
similarity index 100%
rename from loperf_suites/calc/100709.cfg
rename to loperf_suites/calc/tdf100709.cfg
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-1-0' - 3 commits - loolwsd/favicon.ico loolwsd/FileServer.hpp loolwsd/LOOLWSD.cpp loolwsd/LOOLWSD.hpp loolwsd/loolwsd.spec.i

[Andras Timar]

 loolwsd/FileServer.hpp  |2 +-
 loolwsd/LOOLWSD.cpp |   41 +
 loolwsd/LOOLWSD.hpp |7 +++
 loolwsd/Makefile.am |2 ++
 loolwsd/Storage.cpp |2 +-
 loolwsd/favicon.ico |binary
 loolwsd/loolwsd.spec.in |1 +
 loolwsd/loolwsd.xml.in  |1 +
 8 files changed, 50 insertions(+), 6 deletions(-)

New commits:
commit af71a9be15953c2b0c72004243e8a04d6c7afa9a
Author: Andras Timar 
Date:   Sun Aug 28 21:41:28 2016 +0200

loolwsd: add support of SSL termination

diff --git a/loolwsd/FileServer.hpp b/loolwsd/FileServer.hpp
index 874db99..3bcf113 100644
--- a/loolwsd/FileServer.hpp
+++ b/loolwsd/FileServer.hpp
@@ -217,7 +217,7 @@ private:
 {
 HTMLForm form(request, request.stream());
 
-const auto host = (LOOLWSD::isSSLEnabled() ? "wss://" : "ws://") + 
(LOOLWSD::ServerName.empty() ? request.getHost() : LOOLWSD::ServerName);
+const auto host = ((LOOLWSD::isSSLEnabled() || 
LOOLWSD::isSSLTermination()) ? "wss://" : "ws://") + 
(LOOLWSD::ServerName.empty() ? request.getHost() : LOOLWSD::ServerName);
 const auto path = Poco::Path(LOOLWSD::FileServerRoot, 
getRequestPathname(request));
 
 Log::debug("Preprocessing file: " + path.toString());
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index c14e986..e9ce1d6 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -782,7 +782,7 @@ private:
 const std::string urlsrc = "urlsrc";
 const auto& config = Application::instance().config();
 const std::string loleafletHtml = config.getString("loleaflet_html", 
"loleaflet.html");
-const std::string uriValue = (LOOLWSD::isSSLEnabled() ? "https://; : 
"http://;) +
+const std::string uriValue = ((LOOLWSD::isSSLEnabled() || 
LOOLWSD::isSSLTermination()) ? "https://; : "http://;) +
 (LOOLWSD::ServerName.empty() ? request.getHost() : 
LOOLWSD::ServerName) +
 "/loleaflet/" LOOLWSD_VERSION_HASH "/" + loleafletHtml + "?";
 
@@ -1240,7 +1240,7 @@ std::string lcl_getLaunchURI()
 aAbsTopSrcDir = Poco::Path(aAbsTopSrcDir).absolute().toString();
 
 std::string aLaunchURI("");
-aLaunchURI += ((LOOLWSD::isSSLEnabled()) ? "https://; : "http://;);
+aLaunchURI += ((LOOLWSD::isSSLEnabled() || LOOLWSD::isSSLTermination()) ? 
"https://; : "http://;);
 aLaunchURI += LOOLWSD_TEST_HOST ":";
 aLaunchURI += std::to_string(ClientPortNumber);
 aLaunchURI += LOOLWSD_TEST_LOLEAFLET_UI;
@@ -1263,6 +1263,7 @@ std::string LOOLWSD::ServerName;
 std::string LOOLWSD::FileServerRoot;
 std::string LOOLWSD::LOKitVersion;
 Util::RuntimeConstant LOOLWSD::SSLEnabled;
+Util::RuntimeConstant LOOLWSD::SSLTermination;
 
 static std::string UnitTestLibrary;
 
@@ -1322,6 +1323,7 @@ void LOOLWSD::initialize(Application& self)
 { "logging.color", "true" },
 { "logging.level", "trace" },
 { "ssl.enable", "true" },
+{ "ssl.termination", "true" },
 { "ssl.cert_file_path", LOOLWSD_CONFIGDIR "/cert.pem" },
 { "ssl.key_file_path", LOOLWSD_CONFIGDIR "/key.pem" },
 { "ssl.ca_file_path", LOOLWSD_CONFIGDIR "/ca-chain.cert.pem" },
@@ -1367,6 +1369,12 @@ void LOOLWSD::initialize(Application& self)
 Log::warn("SSL support: SSL is disabled.");
 }
 
+#if ENABLE_SSL
+LOOLWSD::SSLTermination.set(getConfigValue(conf, "ssl.termination", 
true));
+#else
+LOOLWSD::SSLTermination.set(false);
+#endif
+
 Cache = getPathFromConfig("tile_cache_path");
 SysTemplate = getPathFromConfig("sys_template_path");
 LoTemplate = getPathFromConfig("lo_template_path");
diff --git a/loolwsd/LOOLWSD.hpp b/loolwsd/LOOLWSD.hpp
index ff282d6..bfc1310 100644
--- a/loolwsd/LOOLWSD.hpp
+++ b/loolwsd/LOOLWSD.hpp
@@ -57,6 +57,12 @@ public:
 {
 return LOOLWSD::SSLEnabled.get();
 }
+static
+bool isSSLTermination()
+{
+return LOOLWSD::SSLTermination.get();
+}
+
 
 protected:
 void initialize(Poco::Util::Application& self) override;
@@ -67,6 +73,7 @@ protected:
 
 private:
 static Util::RuntimeConstant SSLEnabled;
+static Util::RuntimeConstant SSLTermination;
 
 void initializeSSL();
 void displayHelp();
diff --git a/loolwsd/Storage.cpp b/loolwsd/Storage.cpp
index 3fc75b7..9f1694e 100644
--- a/loolwsd/Storage.cpp
+++ b/loolwsd/Storage.cpp
@@ -241,7 +241,7 @@ namespace {
 static inline
 Poco::Net::HTTPClientSession* lcl_getHTTPClientSession(const Poco::URI& uri)
 {
-return (LOOLWSD::isSSLEnabled()) ? new 
Poco::Net::HTTPSClientSession(uri.getHost(), uri.getPort(), 
Poco::Net::SSLManager::instance().defaultClientContext())
+return (LOOLWSD::isSSLEnabled() || LOOLWSD::isSSLTermination()) ? new 
Poco::Net::HTTPSClientSession(uri.getHost(), uri.getPort(), 
Poco::Net::SSLManager::instance().defaultClientContext())
: new Poco::Net::HTTPClientSession(uri.getHost(), 
uri.getPort());
 }
 
diff --git 

Re: Test File: sc/qa/unit/data/functions/fods/chiinv.fods: fails with Assertion

[Eike Rathke]

Hi slacka,

On Sunday, 2016-09-11 01:09:30 -0700, slacka wrote:

> This may be a regression, but I'm not seeing it with the 32-bit 5.1.4.2
> official LibreOffice for Ubuntu 16.04. With minverse.fods, C10 changes to
> FALSE after pressing Shift+Ctrl+F9. With vdb.fods, C11 changes to FALSE
> after a force recalculate.

So you actually *do* see it. Or only not in chiinv.fods?

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/
Care about Free Software, support the FSFE https://fsfe.org/support/?erack


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] online.git: loolwsd/LOOLStress.cpp

[Miklos Vajna]

 loolwsd/LOOLStress.cpp |5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit a652a013aac06a848c9c7b82671b43d7be5cbbc1
Author: Miklos Vajna 
Date:   Wed Sep 14 09:20:35 2016 +0200

LOOLStress: unused using declaration

Change-Id: If20c38a4575074e7ca30069115002aadd1a1847f

diff --git a/loolwsd/LOOLStress.cpp b/loolwsd/LOOLStress.cpp
index 8290298..a296571 100644
--- a/loolwsd/LOOLStress.cpp
+++ b/loolwsd/LOOLStress.cpp
@@ -66,7 +66,6 @@ protected:
 
 using namespace LOOLProtocol;
 
-using Poco::Net::HTTPClientSession;
 using Poco::Net::HTTPRequest;
 using Poco::Net::HTTPResponse;
 using Poco::Runnable;
@@ -503,12 +502,12 @@ int Stress::main(const std::vector& args)
 std::cout << "Tile best: " << renderingStats[0] << " microsecs, 
rendering 95th percentile: " << percentile(renderingStats, 95) << " microsecs." 
<< std::endl;
 std::cout << "Cached best: " << cachedStats[0] << " microsecs, tile 
95th percentile: " << percentile(cachedStats, 95) << " microsecs." << std::endl;
 
-const auto renderingTime = std::accumulate(renderingStats.begin(), 
renderingStats.end(), 0);
+const auto renderingTime = std::accumulate(renderingStats.begin(), 
renderingStats.end(), 0L);
 const double renderedPixels = 256 * 256 * renderingStats.size();
 const auto pixelsPerSecRendered = renderedPixels / renderingTime;
 std::cout << "Rendering power: " << pixelsPerSecRendered << " 
MPixels/sec." << std::endl;
 
-const auto cacheTime = std::accumulate(cachedStats.begin(), 
cachedStats.end(), 0);
+const auto cacheTime = std::accumulate(cachedStats.begin(), 
cachedStats.end(), 0L);
 const double cachePixels = 256 * 256 * cachedStats.size();
 const auto pixelsPerSecCached = cachePixels / cacheTime;
 std::cout << "Cache power: " << pixelsPerSecCached << " MPixels/sec." 
<< std::endl;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - vcl/inc vcl/source

[Khaled Hosny]

 vcl/inc/CommonSalLayout.hxx|3 ++
 vcl/inc/sallayout.hxx  |4 +-
 vcl/source/gdi/CommonSalLayout.cxx |   50 +
 3 files changed, 55 insertions(+), 2 deletions(-)

New commits:
commit 380a5d8ebe08d4431214e84b0f1b8d43f4730fd0
Author: Khaled Hosny 
Date:   Sun Sep 11 10:25:46 2016 +0200

Override GetCharWidths and ApplyDXArray in CSL

A much simpler and saner implementation. This also unbreaks Awami
Nastaliq.

Break kashida justification, will need to rewrite that one as well.

Change-Id: I843679e937f2881e77df61f5cbd9516b6df1b3b6

diff --git a/vcl/inc/CommonSalLayout.hxx b/vcl/inc/CommonSalLayout.hxx
index 34cca79..f9ba70c 100755
--- a/vcl/inc/CommonSalLayout.hxx
+++ b/vcl/inc/CommonSalLayout.hxx
@@ -65,4 +65,7 @@ public:
 virtual boolLayoutText(ImplLayoutArgs&) override;
 virtual voidDrawText( SalGraphics& ) const override;
 std::shared_ptr CreateTextLayoutCache(OUString 
const&) const override;
+
+virtual boolGetCharWidths(DeviceCoordinate* pCharWidths) const;
+virtual voidApplyDXArray(ImplLayoutArgs&);
 };
diff --git a/vcl/inc/sallayout.hxx b/vcl/inc/sallayout.hxx
index 7b044fb..8f0ad9b 100644
--- a/vcl/inc/sallayout.hxx
+++ b/vcl/inc/sallayout.hxx
@@ -326,7 +326,7 @@ public:
 voidAppendGlyph( const GlyphItem& );
 voidReserve(int size) { m_GlyphItems.reserve(size + 1); }
 virtual voidAdjustLayout( ImplLayoutArgs& ) override;
-voidApplyDXArray( ImplLayoutArgs& );
+virtual voidApplyDXArray( ImplLayoutArgs& );
 voidJustify( DeviceCoordinate nNewWidth );
 voidKashidaJustify( long nIndex, int nWidth );
 voidApplyAsianKerning(const OUString& rStr);
@@ -352,7 +352,7 @@ protected:
 virtual voidDropGlyph( int nStart ) override;
 virtual voidSimplify( bool bIsBase ) override;
 
-boolGetCharWidths( DeviceCoordinate* pCharWidths ) const;
+virtual boolGetCharWidths( DeviceCoordinate* pCharWidths ) const;
 
 std::vector m_GlyphItems;
 
diff --git a/vcl/source/gdi/CommonSalLayout.cxx 
b/vcl/source/gdi/CommonSalLayout.cxx
index 71fc186..8d4bfbe 100755
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -483,3 +483,53 @@ bool CommonSalLayout::LayoutText(ImplLayoutArgs& rArgs)
 
 return true;
 }
+
+bool CommonSalLayout::GetCharWidths(DeviceCoordinate* pCharWidths) const
+{
+int nCharCount = mnEndCharPos - mnMinCharPos;
+
+for (int i = 0; i < nCharCount; ++i)
+pCharWidths[i] = 0;
+
+for (auto const& aGlyphItem : m_GlyphItems)
+pCharWidths[aGlyphItem.mnCharPos - mnMinCharPos] += 
aGlyphItem.mnNewWidth;
+
+return true;
+}
+
+void CommonSalLayout::ApplyDXArray(ImplLayoutArgs& rArgs)
+{
+int nCharCount = mnEndCharPos - mnMinCharPos;
+long pOldCharWidths[nCharCount];
+long pNewCharWidths[nCharCount];
+
+GetCharWidths(pOldCharWidths);
+
+for (int i = 0; i < nCharCount; ++i)
+{
+if (i == 0)
+  pNewCharWidths[i] = rArgs.mpDXArray[i];
+else
+  pNewCharWidths[i] = rArgs.mpDXArray[i] - rArgs.mpDXArray[i - 1];
+}
+
+long nDelta = 0;
+size_t i = 0;
+while (i < m_GlyphItems.size())
+{
+int nCharPos = m_GlyphItems[i].mnCharPos - mnMinCharPos;
+long nDiff = pNewCharWidths[nCharPos] - pOldCharWidths[nCharPos];
+
+m_GlyphItems[i].maLinearPos.X() += nDelta;
+size_t j = i;
+while (++j < m_GlyphItems.size())
+{
+if (m_GlyphItems[j].mnCharPos != m_GlyphItems[i].mnCharPos)
+  break;
+m_GlyphItems[j].maLinearPos.X() += nDelta;
+}
+
+nDelta += nDiff;
+i = j;
+}
+}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Recommended build instructions ...

[Jan Iversen]

I have added a red mine, so everybody can follow the progress.

https://redmine.documentfoundation.org/issues/2057

rgds
jan I.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: accessibility/source basctl/source basic/source canvas/source

[Jochen Nitschke]

 accessibility/source/extended/accessibleiconchoicectrl.cxx  |8 ++---
 accessibility/source/extended/accessibleiconchoicectrlentry.cxx |8 ++---
 accessibility/source/extended/accessiblelistbox.cxx |8 ++---
 accessibility/source/extended/accessiblelistboxentry.cxx|8 ++---
 accessibility/source/standard/vclxaccessiblelistitem.cxx|8 ++---
 accessibility/source/standard/vclxaccessibletoolboxitem.cxx |   10 ++
 basctl/source/basicide/basicrenderable.cxx  |   15 
--
 basctl/source/basicide/baside2b.cxx |6 +---
 basic/source/uno/dlgcont.cxx|7 +---
 basic/source/uno/scriptcont.cxx |7 +---
 canvas/source/tools/parametricpolypolygon.cxx   |9 ++
 11 files changed, 34 insertions(+), 60 deletions(-)

New commits:
commit f1018190a8f791b7dca195f223b9c987a73a83af
Author: Jochen Nitschke 
Date:   Tue Sep 13 13:48:00 2016 +0200

tdf#88205 use list ctor for uno::Sequence a11y to canvas

Change-Id: Ib719c94c0488b8a48fdb013bc8fbd1a988595d18
Reviewed-on: https://gerrit.libreoffice.org/28866
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/accessibility/source/extended/accessibleiconchoicectrl.cxx 
b/accessibility/source/extended/accessibleiconchoicectrl.cxx
index aa9d9ab..7b4708c 100644
--- a/accessibility/source/extended/accessibleiconchoicectrl.cxx
+++ b/accessibility/source/extended/accessibleiconchoicectrl.cxx
@@ -146,11 +146,9 @@ namespace accessibility
 
 Sequence< OUString > 
AccessibleIconChoiceCtrl::getSupportedServiceNames_Static() throw 
(RuntimeException)
 {
-Sequence< OUString > aSupported(3);
-aSupported[0] = "com.sun.star.accessibility.AccessibleContext";
-aSupported[1] = "com.sun.star.accessibility.AccessibleComponent";
-aSupported[2] = "com.sun.star.awt.AccessibleIconChoiceControl";
-return aSupported;
+return {"com.sun.star.accessibility.AccessibleContext",
+"com.sun.star.accessibility.AccessibleComponent",
+"com.sun.star.awt.AccessibleIconChoiceControl"};
 }
 
 OUString AccessibleIconChoiceCtrl::getImplementationName_Static() throw 
(RuntimeException)
diff --git a/accessibility/source/extended/accessibleiconchoicectrlentry.cxx 
b/accessibility/source/extended/accessibleiconchoicectrlentry.cxx
index 119e603..d60fe59 100644
--- a/accessibility/source/extended/accessibleiconchoicectrlentry.cxx
+++ b/accessibility/source/extended/accessibleiconchoicectrlentry.cxx
@@ -249,11 +249,9 @@ throw(RuntimeException, std::exception)
 
 Sequence< OUString > 
AccessibleIconChoiceCtrlEntry::getSupportedServiceNames_Static() throw( 
RuntimeException )
 {
-Sequence< OUString > aSupported(3);
-aSupported[0] = "com.sun.star.accessibility.AccessibleContext";
-aSupported[1] = "com.sun.star.accessibility.AccessibleComponent";
-aSupported[2] = "com.sun.star.awt.AccessibleIconChoiceControlEntry";
-return aSupported;
+return {"com.sun.star.accessibility.AccessibleContext",
+"com.sun.star.accessibility.AccessibleComponent",
+"com.sun.star.awt.AccessibleIconChoiceControlEntry"};
 }
 
 OUString AccessibleIconChoiceCtrlEntry::getImplementationName_Static() 
throw( RuntimeException )
diff --git a/accessibility/source/extended/accessiblelistbox.cxx 
b/accessibility/source/extended/accessiblelistbox.cxx
index 30bd2c7..4436500 100644
--- a/accessibility/source/extended/accessiblelistbox.cxx
+++ b/accessibility/source/extended/accessiblelistbox.cxx
@@ -337,11 +337,9 @@ namespace accessibility
 
 Sequence< OUString > AccessibleListBox::getSupportedServiceNames_Static() 
throw( RuntimeException )
 {
-Sequence< OUString > aSupported(3);
-aSupported[0] = "com.sun.star.accessibility.AccessibleContext";
-aSupported[1] = "com.sun.star.accessibility.AccessibleComponent";
-aSupported[2] = "com.sun.star.awt.AccessibleTreeListBox";
-return aSupported;
+return {"com.sun.star.accessibility.AccessibleContext",
+"com.sun.star.accessibility.AccessibleComponent",
+"com.sun.star.awt.AccessibleTreeListBox"};
 }
 
 OUString AccessibleListBox::getImplementationName_Static() throw( 
RuntimeException )
diff --git a/accessibility/source/extended/accessiblelistboxentry.cxx 
b/accessibility/source/extended/accessiblelistboxentry.cxx
index a087d6f..cd70de1 100644
--- a/accessibility/source/extended/accessiblelistboxentry.cxx
+++ b/accessibility/source/extended/accessiblelistboxentry.cxx
@@ -274,11 +274,9 @@ namespace accessibility
 
 Sequence< OUString > 
AccessibleListBoxEntry::getSupportedServiceNames_Static() throw( 
RuntimeException )

[Libreoffice-commits] core.git: Branch 'ports/macosx10.5/master' - 665 commits - accessibility/inc accessibility/source android/Bootstrap android/source animations/source apple_remote/Library_AppleRem

[Douglas Mencken]

Rebased ref, commits from common ancestor:
commit 7e1c67ce29927d691eafdef88f8c49499a9ede23
Author: Douglas Mencken 
Date:   Tue Feb 2 22:08:25 2016 -0500

try to fix build of external/firebird

Change-ID: Ia07a2e34208763228bd78f5b6cbda78c78015d4b

diff --git a/external/firebird/InputDevices-darwin.patch 
b/external/firebird/InputDevices-darwin.patch
new file mode 100644
index 000..b5adbed
--- /dev/null
+++ b/external/firebird/InputDevices-darwin.patch
@@ -0,0 +1,15 @@
+--- src/isql/InputDevices.cpp
 src/isql/InputDevices.cpp
+@@ -22,11 +22,10 @@
+  */
+ 
+ #include "firebird.h"
++
+ #if defined(DARWIN) && !defined(IOS)
+ #if defined(i386) || defined(__x86_64__)
+ #include 
+-#else
+-#include 
+ #endif
+ #endif
+ 
diff --git 
a/external/firebird/Make-the-generated-code-compatible-with-gcc-6-in-C-1.patch 
b/external/firebird/Make-the-generated-code-compatible-with-gcc-6-in-C-1.patch
new file mode 100644
index 000..02e7363
--- /dev/null
+++ 
b/external/firebird/Make-the-generated-code-compatible-with-gcc-6-in-C-1.patch
@@ -0,0 +1,46 @@
+From: asfernandes 
+Date: Sat, 5 Mar 2016 03:39:36 +
+Subject: Make the generated code compatible with gcc 6 in C++-14 mode.
+ (cherry picked from commit 3618aa2171674babf79ef935aa049c40a3db1321)
+Patch-mainline: 
+Git-commit: 3618aa2171674babf79ef935aa049c40a3db1321
+References: bsc#964466 CORE-5099
+​
+--- src/gpre/c_cxx.cpp
 src/gpre/c_cxx.cpp
+@@ -2004,7 +2004,7 @@
+   int ident = CMP_next_ident();
+   init->nod_arg[2] = (gpre_nod*)(IPTR)ident;
+ 
+-  printa(0, "static %schar\n   *isc_%da, *isc_%db;", CONST_STR, ident, 
ident);
++  printa(0, "static %sunsigned char\n   *isc_%da, *isc_%db;", CONST_STR, 
ident, ident);
+   printa(0, "static short\n   isc_%dl;", ident);
+ 
+   const gpre_nod* list = init->nod_arg[1];
+@@ -2820,7 +2820,7 @@
+   printa(0, "static %sshort\n   isc_%dl = %d;",
+  (request->req_flags & REQ_extend_dpb) ? "" : 
CONST_STR,
+  request->req_ident, request->req_length);
+-  printa(0, "static %schar\n   isc_%d [] = {", CONST_STR, 
request->req_ident);
++  printa(0, "static %sunsigned char\n   isc_%d [] = {", 
CONST_STR, request->req_ident);
+ 
+   const TEXT* string_type = "blr";
+   if (gpreGlob.sw_raw)
+@@ -2891,7 +2891,7 @@
+   {
+   printa(0, "static %sshort\n   isc_%dl = %d;", 
CONST_STR,
+  reference->ref_sdl_ident, 
reference->ref_sdl_length);
+-  printa(0, "static %schar\n   isc_%d [] = {", 
CONST_STR, reference->ref_sdl_ident);
++  printa(0, "static %sunsigned char\n   isc_%d [] 
= {", CONST_STR, reference->ref_sdl_ident);
+   if (gpreGlob.sw_raw)
+   gen_raw(reference->ref_sdl, 
reference->ref_sdl_length);
+   else if (PRETTY_print_sdl(reference->ref_sdl, 
gen_blr, 0, 0))
+@@ -2909,7 +2909,7 @@
+   {
+   if (blob->blb_bpb_length)
+   {
+-  printa(0, "static %schar\n   isc_%d [] = {", CONST_STR, 
blob->blb_bpb_ident);
++  printa(0, "static %sunsigned char\n   isc_%d [] = {", 
CONST_STR, blob->blb_bpb_ident);
+   gen_raw(blob->blb_bpb, blob->blb_bpb_length);
+   printa(INDENT, "};\n");
+   }
diff --git 
a/external/firebird/Provide-sized-global-delete-operators-when-compiled-.patch 
b/external/firebird/Provide-sized-global-delete-operators-when-compiled-.patch
new file mode 100644
index 000..6f171db
--- /dev/null
+++ 
b/external/firebird/Provide-sized-global-delete-operators-when-compiled-.patch
@@ -0,0 +1,27 @@
+From: Michal Kubecek 
+Date: Mon, 25 Apr 2016 08:55:36 +0200
+Subject: Provide sized global delete operators when compiled in C++14 mode
+Patch-mainline: submitted
+Git-commit: 038f9fbf559e56032e4cb49eb7ce4c3ead23fda9
+References: bsc#964466 CORE-5099
+​
+--- src/common/classes/alloc.h
 src/common/classes/alloc.h
+@@ -331,6 +331,17 @@
+   MemoryPool::globalFree(mem);
+ }
+ 
++#if __cplusplus >= 201402L
++inline void operator delete(void* mem, std::size_t s ALLOC_PARAMS) throw()
++{
++  MemoryPool::globalFree(mem);
++}
++inline void operator delete[](void* mem, std::size_t s ALLOC_PARAMS) throw()
++{
++  MemoryPool::globalFree(mem);
++}
++#endif
++
+ #ifdef DEBUG_GDS_ALLOC
+ 
+ #ifdef __clang__
diff --git a/external/firebird/UnpackedTarball_firebird.mk 
b/external/firebird/UnpackedTarball_firebird.mk
index 0e9277a..3c87133 100644
--- a/external/firebird/UnpackedTarball_firebird.mk
+++ b/external/firebird/UnpackedTarball_firebird.mk
@@ -14,13 +14,17 @@ $(eval $(call 
gb_UnpackedTarball_set_tarball,firebird,$(FIREBIRD_TARBALL)))
 

Re: Recommended build instructions ...

[Jan Iversen]

> On 13 Sep 2016, at 08:45, Juergen Funk Mailinglist  
> wrote:
> 
> The other problem with Visual Studio Project file is, some projects included 
> not completely or are missing complete
This is a known challenge. the current gbuild_to_ide was not meant to enable a 
complete make in VS, but merely to look at the sources and help with debugging.

There are open BZ:
https://bugs.documentfoundation.org/show_bug.cgi?id=96020
https://bugs.documentfoundation.org/show_bug.cgi?id=96021

Patches are very welcome.

The general idea is to update/replace the current script to include all parts 
of libreoffice, so theoretically it would be possible to build LO from within 
VS (and other IDE).

If you have time, I am happy to assist.

rgds
jan I.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: QtCreator - problem in compiling hpp files

[Jan Iversen]

> I installed QtCreator to work on the LO project. But then, at the first 
> attempt to compile, I get the following message. 
> /.../libreoffice/desktop/inc/app.hxx:24: error: com / sun / star / lang / 
> XMultiServiceFactory.hpp: No such file or directory.
Currently our support for IDE is merely to be able to look at the files more 
easily, we have a project running to actually be able to also compile, I am 
however not sure it will cover QtCreator (but it can be easy expanded, to do 
so). The focus right now is:
- Xcode for Mac
- Visual studio for Windows
- Eclipse for linux
That is once we are able to generate e.g. structured tree from the makefile 
output.

To build LibreOffice you need to use make.

rgds
jan I.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] online.git: Changes to 'refs/tags/1.8.3'

[Andras Timar]

Tag '1.8.3' created by Andras Timar  at 2016-09-14 
09:07 +

1.8.3

Changes since 1.7.2-1-36:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-1-0' - loleaflet/Makefile loolwsd/configure.ac

[Andras Timar]

 loleaflet/Makefile   |2 +-
 loolwsd/configure.ac |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit fd80abd639e7d1a4530f215d09e1804058a9c7ef
Author: Andras Timar 
Date:   Wed Sep 14 11:11:15 2016 +0200

Bump version to 1.8.4

diff --git a/loleaflet/Makefile b/loleaflet/Makefile
index de2e40e..8c2a690 100644
--- a/loleaflet/Makefile
+++ b/loleaflet/Makefile
@@ -3,7 +3,7 @@
 # ("micro") part: Between releases odd, even for releases (no other
 # changes inbetween).
 
-VERSION=1.8.3
+VERSION=1.8.4
 
 # Version number of the bundled 'draw' thing
 DRAW_VERSION=0.2.4
diff --git a/loolwsd/configure.ac b/loolwsd/configure.ac
index 4278a5f..3887c0a 100644
--- a/loolwsd/configure.ac
+++ b/loolwsd/configure.ac
@@ -3,7 +3,7 @@
 
 AC_PREREQ([2.69])
 
-AC_INIT([loolwsd], [1.8.3], [libreoffice@lists.freedesktop.org])
+AC_INIT([loolwsd], [1.8.4], [libreoffice@lists.freedesktop.org])
 LT_INIT([shared, disable-static, dlopen])
 
 AM_INIT_AUTOMAKE([1.11 silent-rules subdir-objects])
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sfx2/source

[Miklos Vajna]

 sfx2/source/view/lokhelper.cxx |6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

New commits:
commit ecc29bf323a83b0379ffed31057c8ab409e0d2d2
Author: Miklos Vajna 
Date:   Wed Sep 14 09:12:44 2016 +0200

sfx2: use range-based for loop in lokhelper

Change-Id: I7c3421231dd74c8d1e2678a6aee92288fdd3221a

diff --git a/sfx2/source/view/lokhelper.cxx b/sfx2/source/view/lokhelper.cxx
index 8225474..36203ce 100644
--- a/sfx2/source/view/lokhelper.cxx
+++ b/sfx2/source/view/lokhelper.cxx
@@ -40,9 +40,8 @@ void SfxLokHelper::destroyView(int nId)
 unsigned nViewShellId = nId;
 SfxViewShellArr_Impl& rViewArr = SfxGetpApp()->GetViewShells_Impl();
 
-for (std::size_t i = 0; i < rViewArr.size(); ++i)
+for (SfxViewShell* pViewShell : rViewArr)
 {
-SfxViewShell* pViewShell = rViewArr[i];
 if (pViewShell->GetViewShellId() == nViewShellId)
 {
 SfxViewFrame* pViewFrame = pViewShell->GetViewFrame();
@@ -58,9 +57,8 @@ void SfxLokHelper::setView(int nId)
 unsigned nViewShellId = nId;
 SfxViewShellArr_Impl& rViewArr = SfxGetpApp()->GetViewShells_Impl();
 
-for (std::size_t i = 0; i < rViewArr.size(); ++i)
+for (SfxViewShell* pViewShell : rViewArr)
 {
-SfxViewShell* pViewShell = rViewArr[i];
 if (pViewShell->GetViewShellId() == nViewShellId)
 {
 if (pViewShell == SfxViewShell::Current())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Caolán McNamara]

 sw/source/uibase/utlui/content.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit fc6744603ab8bb5a00c4f97435b5e509bdeaeb94
Author: Caolán McNamara 
Date:   Wed Sep 14 10:04:28 2016 +0100

Resolves: tdf#101859 dispose unused popupmenu before dtor

Change-Id: I097a342f29aa88ab2d0a6a80b9ac6e1e9a5e3d5a

diff --git a/sw/source/uibase/utlui/content.cxx 
b/sw/source/uibase/utlui/content.cxx
index 0479e72..b495034 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -1097,6 +1097,7 @@ VclPtr SwContentTree::CreateContextMenu()
 VclPtrInstance pSubPop2;
 VclPtrInstance pSubPop3;
 VclPtrInstance pSubPop4; // Edit
+bool bSubPop4 = false;
 
 for(int i = 1; i <= MAXLEVEL; ++i)
 {
@@ -1172,7 +1173,6 @@ VclPtr SwContentTree::CreateContextMenu()
 
 if(!bReadonly && (bEditable || bDeletable))
 {
-bool bSubPop4 = false;
 if(ContentTypeId::INDEX == nContentType)
 {
 bSubPop4 = true;
@@ -1247,8 +1247,9 @@ VclPtr SwContentTree::CreateContextMenu()
 pPop->SetPopupMenu( 1, pSubPop1 );
 pPop->SetPopupMenu( 2, pSubPop2 );
 pPop->SetPopupMenu( 3, pSubPop3 );
+if (!bSubPop4)
+pSubPop4.disposeAndClear();
 return pPop;
-
 }
 
 // Indentation for outlines (and sections)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [ANN] mdds 1.2.2 hits master

[Eike Rathke]

Hi Markus,

On Sunday, 2016-09-11 05:39:05 +0200, Markus Mohrhard wrote:

> On Sat, Sep 10, 2016 at 4:28 PM, Kohei Yoshida  wrote:
> > I'd recommend backporting this to a stable branch, since in theory
> > these crashers have probably existed for several releases at least.
> 
> I absolutely agree.
> 
> For anyone wondering the only two changes against 1.2.1 are:
> 
> https://gitlab.com/mdds/mdds/commit/22c0057292431e76fef690ed2856c3acb8eac20e
> https://gitlab.com/mdds/mdds/commit/0d840a43d062f0df033c10e115a6d6e37de754da
> 
> I suppose that there is no difference to a normal bug fix at least for 5.2
> as there are no new features in the code. If nobody complains I would
> backport the change to 5-2 soon.

Fine with me.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/
Care about Free Software, support the FSFE https://fsfe.org/support/?erack


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: writerfilter/source

[Justin Luth]

 writerfilter/source/dmapper/StyleSheetTable.cxx |5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit e44addfd5d227123928d1295bb8582799aaac6a0
Author: Justin Luth 
Date:   Tue Sep 13 16:56:38 2016 +0300

writerfilter style: use emplace_back, avoiding typedef

Change-Id: I106f94ad4b8c8711a563971cb43d71aa90b139f8
Reviewed-on: https://gerrit.libreoffice.org/28868
Reviewed-by: Miklos Vajna 
Tested-by: Miklos Vajna 

diff --git a/writerfilter/source/dmapper/StyleSheetTable.cxx 
b/writerfilter/source/dmapper/StyleSheetTable.cxx
index 081845f..ae00da4 100644
--- a/writerfilter/source/dmapper/StyleSheetTable.cxx
+++ b/writerfilter/source/dmapper/StyleSheetTable.cxx
@@ -51,7 +51,6 @@ namespace dmapper
 {
 
 typedef ::std::map< OUString, OUString> StringPairMap_t;
-typedef ::std::pair> 
ParentOfStylePair_t;
 
 
 StyleSheetEntry::StyleSheetEntry() :
@@ -917,7 +916,7 @@ void StyleSheetTable::ApplyStyleSheets( const FontTablePtr& 
rFontTable )
 xStyleFamilies->getByName("NumberingStyles") >>= xNumberingStyles;
 if(xCharStyles.is() && xParaStyles.is())
 {
-std::vector< ParentOfStylePair_t > aMissingParent;
+std::vector< ::std::pair 
> aMissingParent;
 std::vector aTableStylesVec;
 std::vector< StyleSheetEntryPtr >::iterator aIt = 
m_pImpl->m_aStyleSheetEntries.begin();
 while( aIt != m_pImpl->m_aStyleSheetEntries.end() )
@@ -1152,7 +1151,7 @@ void StyleSheetTable::ApplyStyleSheets( const 
FontTablePtr& rFontTable )
 {
 const OUString sParentStyle = xStyle->getParentStyle();
 if( !sParentStyle.isEmpty() && !xStyles->hasByName( 
sParentStyle ) )
-aMissingParent.push_back( 
ParentOfStylePair_t(sParentStyle, xStyle) );
+aMissingParent.emplace_back( sParentStyle, xStyle 
);
 
 xStyles->insertByName( sConvertedStyleName, 
uno::makeAny( xStyle) );
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: basic/source canvas/source compilerplugins/clang include/basic include/svx sc/inc sc/source sd/source sot/source svl/source svx/source sw/inc sw/source vcl/source

[Noel Grandin]

 basic/source/classes/sb.cxx|2 
 basic/source/classes/sbxmod.cxx|4 -
 basic/source/inc/sbjsmeth.hxx  |2 
 basic/source/sbx/sbxvar.cxx|2 
 canvas/source/cairo/cairo_canvashelper.cxx |6 --
 canvas/source/cairo/cairo_canvashelper.hxx |3 -
 compilerplugins/clang/constantparam.cxx|   87 +++--
 compilerplugins/clang/constantparam.py |   43 ++
 include/basic/sbxvar.hxx   |2 
 include/svx/svdpage.hxx|2 
 sc/inc/conditio.hxx|2 
 sc/source/core/data/conditio.cxx   |   20 ++
 sc/source/core/inc/interpre.hxx|   10 +--
 sc/source/core/tool/bulkdatahint.cxx   |6 +-
 sc/source/core/tool/interpr1.cxx   |   17 ++---
 sd/source/ui/inc/ShellFactory.hxx  |5 -
 sd/source/ui/view/FormShellManager.cxx |7 --
 sd/source/ui/view/ViewShellManager.cxx |2 
 sd/source/ui/view/viewshel.cxx |   10 ---
 sot/source/sdstor/ucbstorage.cxx   |   10 +--
 svl/source/misc/inettype.cxx   |   12 +---
 svx/source/engine3d/obj3d.cxx  |2 
 svx/source/svdraw/svdpage.cxx  |4 -
 sw/inc/fesh.hxx|7 --
 sw/inc/ftninfo.hxx |2 
 sw/source/core/doc/docftn.cxx  |6 +-
 sw/source/core/frmedt/fefly1.cxx   |   11 +--
 sw/source/filter/inc/fltshell.hxx  |5 -
 vcl/source/gdi/pdfwriter_impl.cxx  |8 +-
 vcl/source/gdi/pdfwriter_impl.hxx  |2 
 30 files changed, 116 insertions(+), 185 deletions(-)

New commits:
commit 20a9e101d909cb1953101e5962b74731e1265400
Author: Noel Grandin 
Date:   Wed Sep 14 09:01:06 2016 +0200

loplugin:constantparam

clean up the plugin a little, and try to catch params which are default
constructed, which doesn't seem to be working yet

Change-Id: Ife45f18502a45cd26306424b7432c55fcbb0fd12
Reviewed-on: https://gerrit.libreoffice.org/28861
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/basic/source/classes/sb.cxx b/basic/source/classes/sb.cxx
index 1696e66..58e6834 100644
--- a/basic/source/classes/sb.cxx
+++ b/basic/source/classes/sb.cxx
@@ -427,7 +427,7 @@ SbxBase* SbiFactory::Create( sal_uInt16 nSbxId, sal_uInt32 
nCreator )
 case SBXID_JSCRIPTMOD:
 return new SbJScriptModule( "" );
 case SBXID_JSCRIPTMETH:
-return new SbJScriptMethod( "", SbxVARIANT, nullptr );
+return new SbJScriptMethod( "", SbxVARIANT );
 }
 }
 return nullptr;
diff --git a/basic/source/classes/sbxmod.cxx b/basic/source/classes/sbxmod.cxx
index 0082d9f..d4b7e37 100644
--- a/basic/source/classes/sbxmod.cxx
+++ b/basic/source/classes/sbxmod.cxx
@@ -2168,8 +2168,8 @@ void SbMethod::Broadcast( sal_uInt32 nHintId )
 
 // Implementation of SbJScriptMethod (method class as a wrapper for 
JavaScript-functions)
 
-SbJScriptMethod::SbJScriptMethod( const OUString& r, SbxDataType t, SbModule* 
p )
-: SbMethod( r, t, p )
+SbJScriptMethod::SbJScriptMethod( const OUString& r, SbxDataType t )
+: SbMethod( r, t, nullptr )
 {
 }
 
diff --git a/basic/source/inc/sbjsmeth.hxx b/basic/source/inc/sbjsmeth.hxx
index 0c7ce34..3403b39 100644
--- a/basic/source/inc/sbjsmeth.hxx
+++ b/basic/source/inc/sbjsmeth.hxx
@@ -30,7 +30,7 @@
 class SbJScriptMethod : public SbMethod
 {
 public:
-SbJScriptMethod( const OUString&, SbxDataType, SbModule* );
+SbJScriptMethod( const OUString&, SbxDataType );
 virtual ~SbJScriptMethod() override;
 
 SBX_DECL_PERSIST_NODATA(SBXID_JSCRIPTMETH,2);
diff --git a/basic/source/sbx/sbxvar.cxx b/basic/source/sbx/sbxvar.cxx
index 784e9d1..908c88f 100644
--- a/basic/source/sbx/sbxvar.cxx
+++ b/basic/source/sbx/sbxvar.cxx
@@ -116,7 +116,7 @@ void SbxEnsureParentVariable::SetParent(SbxObject* p)
 assert(GetParent() == xParent.get());
 }
 
-SbxVariable::SbxVariable( SbxDataType t, void* p ) : SbxValue( t, p )
+SbxVariable::SbxVariable( SbxDataType t ) : SbxValue( t, nullptr )
 {
 pCst = nullptr;
 pParent = nullptr;
diff --git a/canvas/source/cairo/cairo_canvashelper.cxx 
b/canvas/source/cairo/cairo_canvashelper.cxx
index 4f28f5d..c5e3419 100644
--- a/canvas/source/cairo/cairo_canvashelper.cxx
+++ b/canvas/source/cairo/cairo_canvashelper.cxx
@@ -1088,14 +1088,12 @@ namespace cairocanvas
 void CanvasHelper::doPolyPolygonPath( const uno::Reference< 
rendering::XPolyPolygon2D >& xPolyPolygon,
 Operation aOperation,
 bool bNoLineJoin,
-const uno::Sequence< rendering::Texture >* pTextures,
-cairo_t* pCairo ) const
+const uno::Sequence< rendering::Texture >* pTextures ) 
const
 {
 

[Libreoffice-commits] core.git: include/xmloff sc/source writerfilter/source xmlhelp/source xmloff/inc xmloff/source

[Noel Grandin]

 include/xmloff/XMLShapeStyleContext.hxx|2 +-
 include/xmloff/numehelp.hxx|6 +++---
 include/xmloff/prstylei.hxx|2 +-
 include/xmloff/xmlexp.hxx  |4 ++--
 include/xmloff/xmlexppr.hxx|6 +++---
 sc/source/filter/xml/xmlstyle.hxx  |8 
 writerfilter/source/dmapper/PropertyMap.hxx|2 +-
 xmlhelp/source/cxxhelp/inc/tvread.hxx  |2 +-
 xmlhelp/source/cxxhelp/provider/urlparameter.cxx   |2 +-
 xmloff/inc/PageMasterImportContext.hxx |2 +-
 xmloff/inc/SchXMLExport.hxx|2 +-
 xmloff/inc/XMLChartPropertySetMapper.hxx   |4 ++--
 xmloff/inc/txtflde.hxx |2 +-
 xmloff/inc/xexptran.hxx|2 +-
 xmloff/source/draw/sdpropls.hxx|6 +++---
 xmloff/source/draw/sdxmlexp_impl.hxx   |2 +-
 xmloff/source/draw/shapeimport.cxx |2 +-
 xmloff/source/forms/controlpropertymap.hxx |2 +-
 xmloff/source/style/PageMasterExportPropMapper.hxx |4 ++--
 xmloff/source/style/impastpl.hxx   |2 +-
 xmloff/source/style/xmlbahdl.hxx   |   12 ++--
 xmloff/source/text/XMLChangeImportContext.hxx  |2 +-
 xmloff/source/text/XMLTextListItemContext.hxx  |2 +-
 xmloff/source/text/txtexppr.hxx|4 ++--
 xmloff/source/transform/EventOOoTContext.hxx   |2 +-
 xmloff/source/transform/StyleOASISTContext.cxx |2 +-
 xmloff/source/transform/StyleOASISTContext.hxx |4 ++--
 xmloff/source/transform/TransformerBase.hxx|4 ++--
 xmloff/source/xforms/TokenContext.hxx  |4 ++--
 29 files changed, 50 insertions(+), 50 deletions(-)

New commits:
commit 0ea50b5b43a934f2ab080f50585e386ebce0b805
Author: Noel Grandin 
Date:   Wed Sep 14 09:02:16 2016 +0200

loplugin:countusersofdefaultparams in xmloff

Change-Id: Ia92a878ac97b3cc668594946e77a718f27a3e3ed
Reviewed-on: https://gerrit.libreoffice.org/28890
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/include/xmloff/XMLShapeStyleContext.hxx 
b/include/xmloff/XMLShapeStyleContext.hxx
index 1c5aa01..6907537 100644
--- a/include/xmloff/XMLShapeStyleContext.hxx
+++ b/include/xmloff/XMLShapeStyleContext.hxx
@@ -49,7 +49,7 @@ public:
 const OUString& rLName,
 const css::uno::Reference< css::xml::sax::XAttributeList >& xAttrList,
 SvXMLStylesContext& rStyles,
-sal_uInt16 nFamily = XML_STYLE_FAMILY_SD_GRAPHICS_ID);
+sal_uInt16 nFamily);
 virtual ~XMLShapeStyleContext() override;
 
 SvXMLImportContext * CreateChildContext(
diff --git a/include/xmloff/numehelp.hxx b/include/xmloff/numehelp.hxx
index 077ea02..97bec3f 100644
--- a/include/xmloff/numehelp.hxx
+++ b/include/xmloff/numehelp.hxx
@@ -83,7 +83,7 @@ public:
 const sal_Int16 nTypeKey,
 const double& rValue,
 const OUString& rCurrencySymbol,
-bool bExportValue = true);
+bool bExportValue);
 static bool GetCurrencySymbol(const sal_Int32 nNumberFormat, OUString& 
rCurrencySymbol,
 css::uno::Reference< css::util::XNumberFormatsSupplier > & 
xNumberFormatsSupplier);
 static sal_Int16 GetCellType(const sal_Int32 nNumberFormat, bool& 
bIsStandard,
@@ -95,7 +95,7 @@ public:
 static void SetNumberFormatAttributes(SvXMLExport& rXMLExport,
   const OUString& rValue,
   const OUString& rCharacters,
-  bool bExportValue = true,
+  bool bExportValue,
   bool bExportTypeAttribute = true);
 
 bool GetCurrencySymbol(const sal_Int32 nNumberFormat, OUString& 
rCurrencySymbol);
@@ -103,7 +103,7 @@ public:
 void WriteAttributes(const sal_Int16 nTypeKey,
   const double& rValue,
   const OUString& rCurrencySymbol,
-  bool bExportValue = true, sal_uInt16 
nNamespace = XML_NAMESPACE_OFFICE);
+  bool bExportValue, sal_uInt16 
nNamespace = XML_NAMESPACE_OFFICE);
 void SetNumberFormatAttributes(const sal_Int32 nNumberFormat,
   const double& rValue,
   bool bExportValue = true,
diff --git a/include/xmloff/prstylei.hxx b/include/xmloff/prstylei.hxx
index c60c0f3..95a7357 100644
--- a/include/xmloff/prstylei.hxx
+++ 

[Libreoffice-commits] core.git: sw/qa sw/source

[Miklos Vajna]

 sw/qa/extras/tiledrendering/tiledrendering.cxx |4 
 sw/source/core/crsr/crsrsh.cxx |7 +++
 2 files changed, 11 insertions(+)

New commits:
commit 7b784e4e3927d91a96cd0b54fc43c9b488822e47
Author: Miklos Vajna 
Date:   Wed Sep 14 09:16:56 2016 +0200

sw draw text: emit LOK_CALLBACK_VIEW_LOCK from registerCallback()

With this, in case the first view has an active text edit and a new view
is created, then the shape text lock is instantly visible in the second
view, even if the first view does not end + begin the text edit again
later.

Change-Id: I82d98ab1431a54a1a8897d16ce7fa0856baa2a10

diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx 
b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index eeef56d..d5bcf1d 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx
@@ -1209,6 +1209,7 @@ void SwTiledRenderingTest::testShapeTextUndoGroupShells()
 ViewCallback aView2;
 aView2.m_aViewCursor = Rectangle();
 aView2.m_bViewSelectionSet = false;
+aView2.m_bViewLock = false;
 
SfxViewShell::Current()->registerLibreOfficeKitViewCallback(::callback,
 );
 // Difference was 935 twips, the new view didn't see the editeng cursor of
 // the old one. The new difference should be <1px, but here we deal with 
twips.
@@ -1216,6 +1217,9 @@ void SwTiledRenderingTest::testShapeTextUndoGroupShells()
 // This was false, editeng text selection of the first view wasn't noticed
 // by the second view.
 CPPUNIT_ASSERT(aView2.m_bViewSelectionSet);
+// This was false, the new view wasn't aware of the shape text lock created
+// by the old view.
+CPPUNIT_ASSERT(aView2.m_bViewLock);
 
 mxComponent->dispose();
 mxComponent.clear();
diff --git a/sw/source/core/crsr/crsrsh.cxx b/sw/source/core/crsr/crsrsh.cxx
index f14f617..d0ffa27 100644
--- a/sw/source/core/crsr/crsrsh.cxx
+++ b/sw/source/core/crsr/crsrsh.cxx
@@ -1205,6 +1205,13 @@ void SwCursorShell::NotifyCursor(SfxViewShell* 
pOtherShell) const
 rEditView.RegisterOtherShell(nullptr);
 // Text selection, if any.
 rEditView.DrawSelection(pOtherShell);
+
+// Shape text lock.
+if (OutlinerView* pOutlinerView = pView->GetTextEditOutlinerView())
+{
+OString sRect = pOutlinerView->GetOutputArea().toString();
+SfxLokHelper::notifyOtherView(GetSfxViewShell(), pOtherShell, 
LOK_CALLBACK_VIEW_LOCK, "rectangle", sRect);
+}
 }
 else
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.1' - 4 commits - editeng/source include/editeng include/sfx2 sfx2/source svx/source sw/qa sw/source

[Miklos Vajna]

 editeng/source/editeng/editview.cxx|   12 +
 editeng/source/editeng/impedit.cxx |   36 +--
 editeng/source/editeng/impedit.hxx |4 +
 include/editeng/editview.hxx   |4 +
 include/editeng/outliner.hxx   |2 
 include/sfx2/viewsh.hxx|2 
 sfx2/source/view/viewsh.cxx|9 +++
 svx/source/svdraw/svdmrkv.cxx  |5 +-
 sw/qa/extras/tiledrendering/tiledrendering.cxx |   57 +
 sw/source/core/crsr/crsrsh.cxx |   34 --
 10 files changed, 153 insertions(+), 12 deletions(-)

New commits:
commit 977a0ca8c388a51ad13d51681d28b9ed986f27fa
Author: Miklos Vajna 
Date:   Wed Sep 14 09:16:56 2016 +0200

sw draw text: emit LOK_CALLBACK_VIEW_LOCK from registerCallback()

With this, in case the first view has an active text edit and a new view
is created, then the shape text lock is instantly visible in the second
view, even if the first view does not end + begin the text edit again
later.

Change-Id: I82d98ab1431a54a1a8897d16ce7fa0856baa2a10
(cherry picked from commit 7b784e4e3927d91a96cd0b54fc43c9b488822e47)

diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx 
b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index 56f087a..c72a961 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx
@@ -1210,6 +1210,7 @@ void SwTiledRenderingTest::testShapeTextUndoGroupShells()
 ViewCallback aView2;
 aView2.m_aViewCursor = Rectangle();
 aView2.m_bViewSelectionSet = false;
+aView2.m_bViewLock = false;
 
SfxViewShell::Current()->registerLibreOfficeKitViewCallback(::callback,
 );
 // Difference was 935 twips, the new view didn't see the editeng cursor of
 // the old one. The new difference should be <1px, but here we deal with 
twips.
@@ -1217,6 +1218,9 @@ void SwTiledRenderingTest::testShapeTextUndoGroupShells()
 // This was false, editeng text selection of the first view wasn't noticed
 // by the second view.
 CPPUNIT_ASSERT(aView2.m_bViewSelectionSet);
+// This was false, the new view wasn't aware of the shape text lock created
+// by the old view.
+CPPUNIT_ASSERT(aView2.m_bViewLock);
 
 mxComponent->dispose();
 mxComponent.clear();
diff --git a/sw/source/core/crsr/crsrsh.cxx b/sw/source/core/crsr/crsrsh.cxx
index 3a9ebe9..99f75a4 100644
--- a/sw/source/core/crsr/crsrsh.cxx
+++ b/sw/source/core/crsr/crsrsh.cxx
@@ -1237,6 +1237,13 @@ void SwCursorShell::NotifyCursor(SfxViewShell* 
pOtherShell) const
 rEditView.RegisterOtherShell(nullptr);
 // Text selection, if any.
 rEditView.DrawSelection(pOtherShell);
+
+// Shape text lock.
+if (OutlinerView* pOutlinerView = pView->GetTextEditOutlinerView())
+{
+OString sRect = pOutlinerView->GetOutputArea().toString();
+SfxLokHelper::notifyOtherView(GetSfxViewShell(), pOtherShell, 
LOK_CALLBACK_VIEW_LOCK, "rectangle", sRect);
+}
 }
 else
 {
commit 1ac8217f6114943002730502ebafd8617d2fd5c1
Author: Miklos Vajna 
Date:   Tue Sep 13 16:49:03 2016 +0200

sw draw text: emit LOK_CALLBACK_TEXT_VIEW_SELECTION from registerCallback()

With this, in case the first view has an active text edit selection and
a new view is created, then the text selection is instantly visible in
the second view, even if the first view's text selection does not change
later.

Change-Id: I3255febd5d65d6576ddbc57cf96836bdf0b06a72
(cherry picked from commit 2ea385a54b53797ab3960869012f3ce3268eab2c)

diff --git a/editeng/source/editeng/editview.cxx 
b/editeng/source/editeng/editview.cxx
index 51d9cd4..ee6a864 100644
--- a/editeng/source/editeng/editview.cxx
+++ b/editeng/source/editeng/editview.cxx
@@ -1361,4 +1361,11 @@ void EditView::SetCursorLogicPosition(const Point& 
rPosition, bool bPoint, bool
 ShowCursor(/*bGotoCursor=*/false);
 }
 
+void EditView::DrawSelection(OutlinerViewShell* pOtherShell)
+{
+pImpEditView->RegisterOtherShell(pOtherShell);
+pImpEditView->DrawSelection();
+pImpEditView->RegisterOtherShell(nullptr);
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/editeng/source/editeng/impedit.cxx 
b/editeng/source/editeng/impedit.cxx
index 3fa2b51..83a8e35 100644
--- a/editeng/source/editeng/impedit.cxx
+++ b/editeng/source/editeng/impedit.cxx
@@ -375,8 +375,8 @@ void ImpEditView::DrawSelection( EditSelection aTmpSel, 
vcl::Region* pRegion, Ou
 aOrigin = pOutWin->GetMapMode().GetOrigin();
 
 OString sRectangle;
-// If we are not in selection mode, then the exported selection 
should be empty.
-if (pEditEngine->pImpEditEngine->IsInSelectionMode())
+// If we are not in selection mode, 

[Libreoffice-commits] core.git: accessibility/inc accessibility/source basic/source include/basic

[Noel Grandin]

 accessibility/inc/extended/AccessibleGridControlTableCell.hxx|3 +--
 accessibility/inc/standard/vclxaccessiblemenuseparator.hxx   |2 +-
 accessibility/source/extended/AccessibleGridControlTable.cxx |6 +++---
 accessibility/source/extended/AccessibleGridControlTableCell.cxx |5 ++---
 accessibility/source/standard/vclxaccessiblemenuseparator.cxx|4 ++--
 basic/source/sbx/sbxbase.cxx |   10 
+-
 include/basic/sbxfac.hxx |4 +---
 7 files changed, 11 insertions(+), 23 deletions(-)

New commits:
commit 0761f97525b3f3ce2cd73f8db28bf389a3c44f57
Author: Noel Grandin 
Date:   Wed Sep 14 08:53:38 2016 +0200

loplugin:constantparam in accessibility to basic

Change-Id: Id77cbcaefebf310a5d99c6ac12d154e182fd0a1c
Reviewed-on: https://gerrit.libreoffice.org/28860
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/accessibility/inc/extended/AccessibleGridControlTableCell.hxx 
b/accessibility/inc/extended/AccessibleGridControlTableCell.hxx
index 7b3bba6..6edf28c 100644
--- a/accessibility/inc/extended/AccessibleGridControlTableCell.hxx
+++ b/accessibility/inc/extended/AccessibleGridControlTableCell.hxx
@@ -76,8 +76,7 @@ namespace accessibility
 AccessibleGridControlTableCell( const css::uno::Reference< 
css::accessibility::XAccessible >& _rxParent,
 ::svt::table::IAccessibleTable& _rTable,
 sal_Int32 _nRowId,
-sal_uInt16 _nColId,
-svt::table::AccessibleTableControlObjType  
eObjType);
+sal_uInt16 _nColId);
 
 // XInterface 
-
 
diff --git a/accessibility/inc/standard/vclxaccessiblemenuseparator.hxx 
b/accessibility/inc/standard/vclxaccessiblemenuseparator.hxx
index 556e461..c477caa 100644
--- a/accessibility/inc/standard/vclxaccessiblemenuseparator.hxx
+++ b/accessibility/inc/standard/vclxaccessiblemenuseparator.hxx
@@ -29,7 +29,7 @@
 class VCLXAccessibleMenuSeparator : public OAccessibleMenuItemComponent
 {
 public:
-VCLXAccessibleMenuSeparator( Menu* pParent, sal_uInt16 nItemPos, Menu* 
pMenu = nullptr );
+VCLXAccessibleMenuSeparator( Menu* pParent, sal_uInt16 nItemPos );
 virtual ~VCLXAccessibleMenuSeparator() override;
 
 // XServiceInfo
diff --git a/accessibility/source/extended/AccessibleGridControlTable.cxx 
b/accessibility/source/extended/AccessibleGridControlTable.cxx
index 5ac584f..38a0474 100644
--- a/accessibility/source/extended/AccessibleGridControlTable.cxx
+++ b/accessibility/source/extended/AccessibleGridControlTable.cxx
@@ -66,7 +66,7 @@ AccessibleGridControlTable::getAccessibleChild( sal_Int32 
nChildIndex )
 }
 if(!m_pAccessCellVector[nChildIndex].is())
 {
-AccessibleGridControlTableCell* pCell = new 
AccessibleGridControlTableCell(this, m_aTable, 
nChildIndex/m_aTable.GetColumnCount(), nChildIndex%m_aTable.GetColumnCount(), 
TCTYPE_TABLECELL);
+AccessibleGridControlTableCell* pCell = new 
AccessibleGridControlTableCell(this, m_aTable, 
nChildIndex/m_aTable.GetColumnCount(), nChildIndex%m_aTable.GetColumnCount());
 m_pCellVector[nChildIndex] = pCell;
 m_pAccessCellVector[nChildIndex] = pCell;
 }
@@ -99,7 +99,7 @@ AccessibleGridControlTable::getAccessibleAtPoint( const 
awt::Point& rPoint )
 sal_Int32 nRow = 0;
 sal_Int32 nColumnPos = 0;
 if( m_aTable.ConvertPointToCellAddress( nRow, nColumnPos, VCLPoint( rPoint 
) ) )
-xChild = new AccessibleGridControlTableCell(this, m_aTable, nRow, 
nColumnPos, TCTYPE_TABLECELL);
+xChild = new AccessibleGridControlTableCell(this, m_aTable, nRow, 
nColumnPos);
 return xChild;
 }
 
@@ -219,7 +219,7 @@ Reference< XAccessible > SAL_CALL 
AccessibleGridControlTable::getAccessibleCellA
 }
 if(!m_pAccessCellVector[nChildIndex].is())
 {
-AccessibleGridControlTableCell* pCell = new 
AccessibleGridControlTableCell(this, m_aTable, nRow, nColumn, TCTYPE_TABLECELL);
+AccessibleGridControlTableCell* pCell = new 
AccessibleGridControlTableCell(this, m_aTable, nRow, nColumn);
 m_pCellVector[nChildIndex] = pCell;
 m_pAccessCellVector[nChildIndex] = pCell;
 }
diff --git a/accessibility/source/extended/AccessibleGridControlTableCell.cxx 
b/accessibility/source/extended/AccessibleGridControlTableCell.cxx
index 85bd002..7703b3f 100644
--- a/accessibility/source/extended/AccessibleGridControlTableCell.cxx
+++ b/accessibility/source/extended/AccessibleGridControlTableCell.cxx
@@ -103,9 +103,8 @@ namespace accessibility
 AccessibleGridControlTableCell::AccessibleGridControlTableCell(const 
css::uno::Reference& _rxParent,
 

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - vcl/inc vcl/source

[Khaled Hosny]

Rebased ref, commits from common ancestor:
commit 237c3792711ff7a6dd376369c307c1901f379bc1
Author: Khaled Hosny 
Date:   Sun Sep 11 10:25:46 2016 +0200

Override GetCharWidths and ApplyDXArray in CSL

A much simpler and saner implementation. This also unbreaks Awami
Nastaliq.

Break kashida justification, will need to rewrite that one as well.

Change-Id: I843679e937f2881e77df61f5cbd9516b6df1b3b6

diff --git a/vcl/inc/CommonSalLayout.hxx b/vcl/inc/CommonSalLayout.hxx
index 83de5c1..179eee88 100644
--- a/vcl/inc/CommonSalLayout.hxx
+++ b/vcl/inc/CommonSalLayout.hxx
@@ -65,4 +65,7 @@ public:
 virtual boolLayoutText(ImplLayoutArgs&) override;
 virtual voidDrawText( SalGraphics& ) const override;
 std::shared_ptr CreateTextLayoutCache(OUString 
const&) const override;
+
+virtual boolGetCharWidths(DeviceCoordinate* pCharWidths) const;
+virtual voidApplyDXArray(ImplLayoutArgs&);
 };
diff --git a/vcl/inc/sallayout.hxx b/vcl/inc/sallayout.hxx
index cfb2930..1050943 100644
--- a/vcl/inc/sallayout.hxx
+++ b/vcl/inc/sallayout.hxx
@@ -326,7 +326,7 @@ public:
 voidAppendGlyph( const GlyphItem& );
 voidReserve(int size) { m_GlyphItems.reserve(size + 1); }
 virtual voidAdjustLayout( ImplLayoutArgs& ) override;
-voidApplyDXArray( ImplLayoutArgs& );
+virtual voidApplyDXArray( ImplLayoutArgs& );
 voidJustify( DeviceCoordinate nNewWidth );
 voidKashidaJustify( long nIndex, int nWidth );
 voidApplyAsianKerning(const OUString& rStr);
@@ -352,7 +352,7 @@ protected:
 virtual voidDropGlyph( int nStart ) override;
 virtual voidSimplify( bool bIsBase ) override;
 
-boolGetCharWidths( DeviceCoordinate* pCharWidths ) const;
+virtual boolGetCharWidths( DeviceCoordinate* pCharWidths ) const;
 
 std::vector m_GlyphItems;
 
diff --git a/vcl/source/gdi/CommonSalLayout.cxx 
b/vcl/source/gdi/CommonSalLayout.cxx
index 509086d..ea4e5f9 100644
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -486,3 +486,53 @@ bool CommonSalLayout::LayoutText(ImplLayoutArgs& rArgs)
 
 return true;
 }
+
+bool CommonSalLayout::GetCharWidths(DeviceCoordinate* pCharWidths) const
+{
+int nCharCount = mnEndCharPos - mnMinCharPos;
+
+for (int i = 0; i < nCharCount; ++i)
+pCharWidths[i] = 0;
+
+for (auto const& aGlyphItem : m_GlyphItems)
+pCharWidths[aGlyphItem.mnCharPos - mnMinCharPos] += 
aGlyphItem.mnNewWidth;
+
+return true;
+}
+
+void CommonSalLayout::ApplyDXArray(ImplLayoutArgs& rArgs)
+{
+int nCharCount = mnEndCharPos - mnMinCharPos;
+DeviceCoordinate pOldCharWidths[nCharCount];
+DeviceCoordinate pNewCharWidths[nCharCount];
+
+GetCharWidths(pOldCharWidths);
+
+for (int i = 0; i < nCharCount; ++i)
+{
+if (i == 0)
+  pNewCharWidths[i] = rArgs.mpDXArray[i];
+else
+  pNewCharWidths[i] = rArgs.mpDXArray[i] - rArgs.mpDXArray[i - 1];
+}
+
+DeviceCoordinate nDelta = 0;
+size_t i = 0;
+while (i < m_GlyphItems.size())
+{
+int nCharPos = m_GlyphItems[i].mnCharPos - mnMinCharPos;
+DeviceCoordinate nDiff = pNewCharWidths[nCharPos] - 
pOldCharWidths[nCharPos];
+
+m_GlyphItems[i].maLinearPos.X() += nDelta;
+size_t j = i;
+while (++j < m_GlyphItems.size())
+{
+if (m_GlyphItems[j].mnCharPos != m_GlyphItems[i].mnCharPos)
+  break;
+m_GlyphItems[j].maLinearPos.X() += nDelta;
+}
+
+nDelta += nDiff;
+i = j;
+}
+}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: Changes to 'refs/tags/cp-5.1-6'

[Miklos Vajna]

Tag 'cp-5.1-6' created by Andras Timar  at 
2016-09-14 22:42 +

cp-5.1-6

Changes since libreoffice-5-1-branch-point-11:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-1-9' - 5 commits - loolwsd/DocumentBroker.cpp loolwsd/LOOLKit.cpp loolwsd/MessageQueue.cpp loolwsd/MessageQueue.hpp

[Ashod Nakashian]

 loolwsd/DocumentBroker.cpp |   29 +---
 loolwsd/LOOLKit.cpp|   39 --
 loolwsd/MessageQueue.cpp   |   78 ++---
 loolwsd/MessageQueue.hpp   |   50 
 4 files changed, 182 insertions(+), 14 deletions(-)

New commits:
commit 72c1988bc922ba7e5c9d072a2e16c62243a06bea
Author: Ashod Nakashian 
Date:   Wed Sep 14 18:18:08 2016 -0400

loolwsd: only prioritize tile messages and not tilecombine

Change-Id: Ia292e5b499dd4409dc3a672e4d5360c868d6c71f
(cherry picked from commit c01629ab2a52f6f4243df458b0505f231e392c49)

diff --git a/loolwsd/MessageQueue.cpp b/loolwsd/MessageQueue.cpp
index 756e568..0660d2b 100644
--- a/loolwsd/MessageQueue.cpp
+++ b/loolwsd/MessageQueue.cpp
@@ -158,6 +158,11 @@ void TileQueue::reprioritize(const CursorPosition& 
cursorPosition)
 {
 auto& it = _queue[i];
 const std::string msg(it.data(), it.size());
+if (msg.compare(0, 5, "tile ") != 0)
+{
+continue;
+}
+
 auto tile = TileDesc::parse(msg); //FIXME: Expensive, avoid.
 
 if (tile.intersectsWithRect(cursorPosition.X, cursorPosition.Y, 
cursorPosition.Width, cursorPosition.Height))
@@ -178,6 +183,11 @@ void TileQueue::reprioritize(const CursorPosition& 
cursorPosition)
 
 bool TileQueue::priority(const std::string& tileMsg)
 {
+if (tileMsg.compare(0, 5, "tile ") != 0)
+{
+return false;
+}
+
 auto tile = TileDesc::parse(tileMsg); //FIXME: Expensive, avoid.
 
 for (auto& pair : _cursorPositions)
commit 20428860cc7e3caa2d165df746dffc7443611031
Author: Ashod Nakashian 
Date:   Wed Sep 14 18:02:03 2016 -0400

loolwsd: remove cursor of unloading views

Change-Id: I4281a5aa101f034007aa227bb18b14eeba806ea0
(cherry picked from commit ad6d77cd3b4ccaeb1da16f100fb3bc3ac4d4c947)

diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 387a0d5..583b173 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -940,6 +940,7 @@ private:
 
 // Broadcast the demise and removal of session.
 notifyOtherSessions(sessionId, "remview: " + 
std::to_string(session.getViewId()));
+_tileQueue->removeCursorPosition(session.getViewId());
 
 if (_loKitDocument == nullptr)
 {
commit bbcde1d091ba51beaae37402a10b757d41fc8e49
Author: Ashod Nakashian 
Date:   Sun Sep 11 13:18:22 2016 -0400

loolwsd: queue -> tileQueue

Change-Id: If61de6807fa7f52a703fe45948df911fe162f69a
(cherry picked from commit 2db1db06c75fd67bbc73ba86707f89ee7e4f24c6)

diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 2207e7d..387a0d5 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -398,14 +398,14 @@ public:
  const std::string& jailId,
  const std::string& docKey,
  const std::string& url,
- std::shared_ptr queue,
+ std::shared_ptr tileQueue,
  const std::shared_ptr& ws)
   : _multiView(std::getenv("LOK_VIEW_CALLBACK")),
 _loKit(loKit),
 _jailId(jailId),
 _docKey(docKey),
 _url(url),
-_queue(std::move(queue)),
+_tileQueue(std::move(tileQueue)),
 _ws(ws),
 _docPassword(""),
 _haveDocPassword(false),
@@ -419,6 +419,7 @@ public:
 Log::info("Document ctor for url [" + _url + "] on child [" + _jailId +
   "] LOK_VIEW_CALLBACK=" + std::to_string(_multiView) + ".");
 assert(_loKit && _loKit->get());
+
 _callbackThread.start(*this);
 }
 
@@ -1230,7 +1231,7 @@ private:
 {
 while (true)
 {
-const auto input = pThis->_queue->get();
+const auto input = pThis->_tileQueue->get();
 const std::string message(input.data(), input.size());
 StringTokenizer tokens(message, " ", 
StringTokenizer::TOK_IGNORE_EMPTY | StringTokenizer::TOK_TRIM);
 
@@ -1269,7 +1270,7 @@ private:
 std::string _renderOpts;
 
 std::shared_ptr _loKitDocument;
-std::shared_ptr _queue;
+std::shared_ptr _tileQueue;
 std::shared_ptr _ws;
 
 // Document password provided
commit 2bcbdf3362433d3472e2c2ce172b5b52875f
Author: Ashod Nakashian 
Date:   Wed Sep 14 17:42:50 2016 -0400

loolwsd: tile prioritization per view cursor

Change-Id: I1410b64982ac2db04e5a47d744a95b8d2eab5f7e
(cherry picked from commit ece87da287433d665a175e92a576f00c639695a2)

diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 73ade5b..2207e7d 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -813,6 +813,35 @@ private:
 
 std::unique_lock lock(pDescr->Doc->_mutex);
 
+if (nType == LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR ||
+nType == LOK_CALLBACK_CELL_CURSOR)
+   

[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-5.1-6'

[Miklos Vajna]

Tag 'cp-5.1-6' created by Andras Timar  at 
2016-09-14 22:42 +

cp-5.1-6

Changes since cp-5.1-5-24:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/cp-5.1-6'

[Andras Timar]

Tag 'cp-5.1-6' created by Andras Timar  at 
2016-09-14 22:42 +

cp-5.1-6

Changes since cp-5.1-3:
Andras Timar (1):
  Update pt_PT dictionary to version 16.7.4.1

---
 pt_PT/description.xml |2 -
 pt_PT/pt_PT.aff   |   25 +++--
 pt_PT/pt_PT.dic   |   93 +++---
 3 files changed, 74 insertions(+), 46 deletions(-)
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] translations.git: Changes to 'refs/tags/cp-5.1-6'

[Christian Lohmaier]

Tag 'cp-5.1-6' created by Andras Timar  at 
2016-09-14 22:42 +

cp-5.1-6

Changes since cp-5.1-3-1:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Changes to 'refs/tags/1.9.1'

[Ashod Nakashian]

Tag '1.9.1' created by Andras Timar  at 2016-09-14 
22:52 +

1.9.1

Changes since 1.9.0-30:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa

[Zdeněk Crhonek]

 sc/qa/unit/data/functions/fods/rows.fods | 3899 +++
 1 file changed, 3899 insertions(+)

New commits:
commit dc73f699da8e20f5753d481cf8680c761e62c468
Author: Zdeněk Crhonek 
Date:   Wed Sep 14 21:25:56 2016 +0200

add ROWS test case

Change-Id: Ied7286dc5fa480ef3403ed5cfed3ab9b6a30b049
Reviewed-on: https://gerrit.libreoffice.org/28914
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/sc/qa/unit/data/functions/fods/rows.fods 
b/sc/qa/unit/data/functions/fods/rows.fods
new file mode 100644
index 000..85a95a6
--- /dev/null
+++ b/sc/qa/unit/data/functions/fods/rows.fods
@@ -0,0 +1,3899 @@
+
+
+http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr
 ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:form
 x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.spreadsheet">
+ 
2016-09-07T04:51:27.950112016P0D1LibreOfficeDev/5.3.0.0.alpha0$Linux_X86_64
 
LibreOffice_project/e1822c809b137859382139aace0c08be4547c157
+ 
+  
+   0
+   0
+   24248
+   2786
+   
+
+ view1
+ 
+  
+   2
+   8
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   75
+   60
+   true
+   false
+  
+  
+   2
+   1
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   75
+   60
+   true
+   false
+  
+ 
+ Sheet2
+ 1241
+ 0
+ 75
+ 60
+ false
+ true
+ true
+ true
+ 12632256
+ true
+ true
+ true
+ true
+ false
+ false
+ false
+ 1270
+ 1270
+ 1
+ 1
+ true
+ false
+
+   
+  
+  
+   7
+   false
+   false
+   true
+   true
+   false
+   false
+   false
+   1270
+   1270
+   true
+   true
+   true
+   true
+   true
+   false
+   12632256
+   false
+   Lexmark-E352dn
+   
+
+ cs
+ CZ
+ 
+ 
+ 
+
+
+ en
+ US
+ 
+ 
+ 
+
+
+ nl
+ NL
+ 
+ 
+ 
+
+   
+   true
+   true
+   3
+   1
+   true
+   1
+   true
+   sgH+/0xleG1hcmstRTM1MmRuQ1VQUzpMZXhtYXJrLUUzNTJkbgAWAAMA0wAIAFZUAAAkbQAASm9iRGF0YSAxCnByaW50ZXI9TGV4bWFyay1FMzUyZG4Kb3JpZW50YXRpb249UG9ydHJhaXQKY29waWVzPTEKY29sbGF0ZT1mYWxzZQptYXJnaW5kYWp1c3RtZW50PTAsMCwwLDAKY29sb3JkZXB0aD0yNApwc2xldmVsPTAKcGRmZGV2aWNlPTEKY29sb3JkZXZpY2U9MApQUERDb250ZXhEYXRhClBhZ2VTaXplOkxldHRlcgBJbnB1dFNsb3Q6VHJheTEARHVwbGV4Ok5vbmUAABIAQ09NUEFUX0RVUExFWF9NT0RFDwBEdXBsZXhNb2RlOjpPZmY=
+   false
+   0
+  
+ 
+ 
+  
+   http://openoffice.org/2004/office; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
+
+   
+  
+ 
+ 
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+ 
+ 
+  
+   
+   
+  
+  
+   
+  
+  
+   
+
+   Kč
+  
+  
+   
+   -
+   
+
+   Kč
+   
+  
+  
+
+   
+
+  
+  
+
+   (
+   
+   )
+  
+  
+
+   -
+   
+
+  
+  
+   
+
+   
+   
+   
+  
+  
+   
+
+   Kč
+  
+  
+   -
+   
+
+   Kč
+   
+  
+  
+   
+
+   Kč
+  
+  
+   -
+   
+
+   Kč
+   
+  
+  
+   
+
+   Kč
+  
+  
+ 

[Libreoffice-commits] core.git: sc/qa

[Zdeněk Crhonek]

 sc/qa/unit/data/functions/fods/forecast.ets.mult.fods |12237 ++
 1 file changed, 12237 insertions(+)

New commits:
commit 7a49cffaed5fe8db9199f5af6d7c1227d1bfd9c5
Author: Zdeněk Crhonek 
Date:   Wed Sep 14 20:51:20 2016 +0200

add FORECAST.ETS.MULT test case

Change-Id: Ibc555a9a3c3c7158012b6809b2d8c7d9bf4fda2f
Reviewed-on: https://gerrit.libreoffice.org/28912
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/sc/qa/unit/data/functions/fods/forecast.ets.mult.fods 
b/sc/qa/unit/data/functions/fods/forecast.ets.mult.fods
new file mode 100644
index 000..f5ae353
--- /dev/null
+++ b/sc/qa/unit/data/functions/fods/forecast.ets.mult.fods
@@ -0,0 +1,12237 @@
+
+
+http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr
 ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:form
 x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.spreadsheet">
+ 
2016-07-24T08:15:55.36200P0D1LibreOfficeDev/5.3.0.0.alpha0$Linux_X86_64
 
LibreOffice_project/e1822c809b137859382139aace0c08be4547c157
+ 
+  
+   0
+   0
+   162119
+   145635
+   
+
+ view1
+ 
+  
+   2
+   8
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   75
+   60
+   true
+   false
+  
+  
+   4
+   8
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   14
+   0
+   75
+   60
+   true
+   false
+  
+ 
+ Sheet2
+ 1241
+ 0
+ 75
+ 60
+ false
+ true
+ true
+ true
+ 12632256
+ true
+ true
+ true
+ true
+ false
+ false
+ false
+ 1270
+ 1270
+ 1
+ 1
+ true
+ false
+
+   
+  
+  
+   7
+   false
+   false
+   true
+   true
+   false
+   false
+   false
+   1270
+   1270
+   true
+   true
+   true
+   true
+   true
+   false
+   12632256
+   false
+   Lexmark-E352dn
+   
+
+ cs
+ CZ
+ 
+ 
+ 
+
+
+ de
+ DE
+ 
+ 
+ 
+
+
+ en
+ US
+ 
+ 
+ 
+
+
+ nl
+ NL
+ 
+ 
+ 
+
+   
+   true
+   true
+   3
+   1
+   true
+   1
+   true
+   sgH+/0xleG1hcmstRTM1MmRuQ1VQUzpMZXhtYXJrLUUzNTJkbgAWAAMA0wAIAFZUAAAkbQAASm9iRGF0YSAxCnByaW50ZXI9TGV4bWFyay1FMzUyZG4Kb3JpZW50YXRpb249UG9ydHJhaXQKY29waWVzPTEKY29sbGF0ZT1mYWxzZQptYXJnaW5kYWp1c3RtZW50PTAsMCwwLDAKY29sb3JkZXB0aD0yNApwc2xldmVsPTAKcGRmZGV2aWNlPTEKY29sb3JkZXZpY2U9MApQUERDb250ZXhEYXRhClBhZ2VTaXplOkxldHRlcgBJbnB1dFNsb3Q6VHJheTEARHVwbGV4Ok5vbmUAABIAQ09NUEFUX0RVUExFWF9NT0RFDwBEdXBsZXhNb2RlOjpPZmY=
+   false
+   0
+  
+ 
+ 
+  
+   http://openoffice.org/2004/office; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
+
+   
+  
+ 
+ 
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+ 
+ 
+  
+   
+   
+  
+  
+   
+  
+  
+   
+
+   Kč
+  
+  
+   
+   -
+   
+
+   Kč
+   
+  
+  
+
+   
+
+  
+  
+
+   (
+   
+   )
+  
+  
+
+   -
+   
+
+  
+  
+   
+
+   
+   
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   

[Libreoffice-commits] core.git: helpcontent2

[Gabor Kelemen]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c77b933f907e1d3c4778dd63cb4295c08d4d3f31
Author: Gabor Kelemen 
Date:   Wed Sep 14 16:56:31 2016 +0200

Updated core
Project: help  eb949d8e2f087ea0358719948e75a4aeacddd74f

tdf#102198 Fix references to the "Save As Template" menu item

Change-Id: I63a78ca9b99447bf8e458377419b0ba92550fe37
Reviewed-on: https://gerrit.libreoffice.org/28903
Reviewed-by: jan iversen 
Tested-by: jan iversen 

diff --git a/helpcontent2 b/helpcontent2
index 6c8c4a5..eb949d8 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 6c8c4a5e044c5c22ca3acc7d968b096340562627
+Subproject commit eb949d8e2f087ea0358719948e75a4aeacddd74f
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa

[Zdeněk Crhonek]

 sc/qa/unit/data/functions/fods/offset.fods | 4400 +
 1 file changed, 4400 insertions(+)

New commits:
commit 8697d18f717c75ddeedfe08161091da71007b859
Author: Zdeněk Crhonek 
Date:   Tue Sep 13 22:26:54 2016 +0200

add OFFSET test case

Change-Id: Ifdb1a0d83ba9b539ea5bda0345f292330e691277
Reviewed-on: https://gerrit.libreoffice.org/28881
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/sc/qa/unit/data/functions/fods/offset.fods 
b/sc/qa/unit/data/functions/fods/offset.fods
new file mode 100644
index 000..4e3d1ca
--- /dev/null
+++ b/sc/qa/unit/data/functions/fods/offset.fods
@@ -0,0 +1,4400 @@
+
+
+http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr
 ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:form
 x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.spreadsheet">
+ 
2016-09-07T04:51:27.950112016P0D1LibreOfficeDev/5.3.0.0.alpha0$Linux_X86_64
 
LibreOffice_project/a8a7b7114d96b2013b00e9bc0ced81aad5495457
+ 
+  
+   0
+   0
+   35214
+   18393
+   
+
+ view1
+ 
+  
+   2
+   8
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   75
+   60
+   true
+   false
+  
+  
+   0
+   6
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   75
+   60
+   true
+   false
+  
+ 
+ Sheet2
+ 1241
+ 0
+ 75
+ 60
+ false
+ true
+ true
+ true
+ 12632256
+ true
+ true
+ true
+ true
+ false
+ false
+ false
+ 1270
+ 1270
+ 1
+ 1
+ true
+ false
+
+   
+  
+  
+   7
+   false
+   false
+   true
+   true
+   false
+   false
+   false
+   1270
+   1270
+   true
+   true
+   true
+   true
+   true
+   false
+   12632256
+   false
+   Lexmark-E352dn
+   
+
+ cs
+ CZ
+ 
+ 
+ 
+
+
+ en
+ US
+ 
+ 
+ 
+
+
+ nl
+ NL
+ 
+ 
+ 
+
+   
+   true
+   true
+   3
+   1
+   true
+   1
+   true
+   rQH+/0xleG1hcmstRTM1MmRuQ1VQUzpMZXhtYXJrLUUzNTJkbgAWAAMA0wAIAFZUAAAkbQAASm9iRGF0YSAxCnByaW50ZXI9TGV4bWFyay1FMzUyZG4Kb3JpZW50YXRpb249UG9ydHJhaXQKY29waWVzPTEKY29sbGF0ZT1mYWxzZQptYXJnaW5kYWp1c3RtZW50PTAsMCwwLDAKY29sb3JkZXB0aD0yNApwc2xldmVsPTAKcGRmZGV2aWNlPTEKY29sb3JkZXZpY2U9MApQUERDb250ZXhEYXRhCkR1cGxleDpOb25lAElucHV0U2xvdDpUcmF5MQBQYWdlU2l6ZTpMZXR0ZXIAABIAQ09NUEFUX0RVUExFWF9NT0RFCgBEVVBMRVhfT0ZG
+   false
+   0
+  
+ 
+ 
+  
+   http://openoffice.org/2004/office; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
+
+   
+  
+ 
+ 
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+ 
+ 
+  
+   
+   
+  
+  
+   
+  
+  
+   
+
+   Kč
+  
+  
+   
+   -
+   
+
+   Kč
+   
+  
+  
+
+   
+
+  
+  
+
+   (
+   
+   )
+  
+  
+
+   -
+   
+
+  
+  
+   
+
+   
+   
+   
+  
+  
+   
+
+   Kč
+  
+  
+   -
+   
+
+   Kč
+   
+  
+  
+   
+
+   Kč
+  
+  
+   -
+   
+
+   Kč
+   
+  
+  
+   
+
+   Kč
+  
+  

[Libreoffice-commits] help.git: source/text

[Gabor Kelemen]

 source/text/shared/01/0107.xhp |2 +-
 source/text/shared/guide/standard_template.xhp |4 ++--
 source/text/simpress/guide/background.xhp  |2 +-
 source/text/swriter/guide/template_create.xhp  |6 +++---
 4 files changed, 7 insertions(+), 7 deletions(-)

New commits:
commit eb949d8e2f087ea0358719948e75a4aeacddd74f
Author: Gabor Kelemen 
Date:   Wed Sep 14 16:56:31 2016 +0200

tdf#102198 Fix references to the "Save As Template" menu item

Change-Id: I63a78ca9b99447bf8e458377419b0ba92550fe37
Reviewed-on: https://gerrit.libreoffice.org/28903
Reviewed-by: jan iversen 
Tested-by: jan iversen 

diff --git a/source/text/shared/01/0107.xhp 
b/source/text/shared/01/0107.xhp
index e4ab584..5e44eab 100644
--- a/source/text/shared/01/0107.xhp
+++ b/source/text/shared/01/0107.xhp
@@ -42,7 +42,7 @@
   
 
 The following sections describe the %PRODUCTNAME Save as dialog. To activate the 
%PRODUCTNAME Open and 
Save dialog boxes, choose %PRODUCTNAME - 
PreferencesTools - 
Options - %PRODUCTNAME- General, and then select the 
Use %PRODUCTNAME dialogs in the Open/Save dialogs 
area.
-To save a document as a template, use the command File - Save 
As Template.
+To save a document as a template, use the command File - 
Templates - Save As Template.
 
 
 Connect 
To Server
diff --git a/source/text/shared/guide/standard_template.xhp 
b/source/text/shared/guide/standard_template.xhp
index 36134af..afa7554 100644
--- a/source/text/shared/guide/standard_template.xhp
+++ b/source/text/shared/guide/standard_template.xhp
@@ -52,7 +52,7 @@
 You can define a document template for each $[officename] module. 
The following describes how to proceed for text documents.
 
 
-Save the document by choosing File - Save As 
Templateand saving the document in the My Templates 
category.
+Save the document by choosing File - Templates - Save As 
Templateand saving the document in the My Templates 
category.
 
 
 Choose File - New - Templates.
@@ -67,7 +67,7 @@
 Using Custom Templates
 There are several ways to make your work easier by using your own 
custom templates. 
 Templates in the Template Folder
-You can save a new template with File - Save As 
Template or by selecting "Template" file type in any Save dialog. Save 
the template in the user directory specified under %PRODUCTNAME - 
PreferencesTools - 
Options - %PRODUCTNAME - 
Paths to be able to access the template from within the File - New 
- Templates dialog.
+You can save a new template with File - Templates - Save As 
Template or by selecting "Template" file type in any Save dialog. Save 
the template in the user directory specified under %PRODUCTNAME - 
PreferencesTools - 
Options - %PRODUCTNAME - 
Paths to be able to access the template from within the File - New 
- Templates dialog.
 To open the template for editing, choose File - New - 
Templates, select the template and click the Edit 
button.
 
 
diff --git a/source/text/simpress/guide/background.xhp 
b/source/text/simpress/guide/background.xhp
index 15df7ed..aafd1fa 100644
--- a/source/text/simpress/guide/background.xhp
+++ b/source/text/simpress/guide/background.xhp
@@ -90,7 +90,7 @@
 Choose View - Normal to close the master 
view.
 
 
-Choose File - Save As Template to save the document as 
a template.
+Choose File - Templates - Save As Template to save the 
document as a template.
 
 
 Enter a name for the template. Do not change the category from "My 
Templates". Click OK.
diff --git a/source/text/swriter/guide/template_create.xhp 
b/source/text/swriter/guide/template_create.xhp
index 412323b..ace0558 100644
--- a/source/text/swriter/guide/template_create.xhp
+++ b/source/text/swriter/guide/template_create.xhp
@@ -41,7 +41,7 @@
 Create a 
document and add the content and formatting styles that you want.
   
   
-Choose 
File - Save As Template.
+Choose 
File - Templates - Save As Template.
   
   
 In the 
New Template box, type a name for the new 
template.
@@ -59,8 +59,8 @@
 
 
 
-File - Save 
As Template
+File - Templates - Save As Template
 
 
 
-
\ No newline at end of file
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 39667] Enable accessible/tagged PDF export options by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39667

Cor Nouws  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=45
   ||636

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45636] Add support for PDF/UA (PDF/Universal Accessibility) - ISO 14289

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45636

Cor Nouws  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=39
   ||667

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51071] FILESAVE: CSV form .odt should be an export, not a save-as target

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=51071

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #12 from Heiko Tietze  ---
(In reply to Aron Budea from comment #11)
> My general question to the UX team:
> could repeated saving in different, less sophisticated formats be improved
> to give better warnings to the user, and prevent unintended data loss?

The dialog says "This document may contain formatting or content that cannot be
saved in the currently selected file format Text CSV. Use the default ODF file
format to be sure that the document is saved correctly." It has an option for
CSV users to not pop-up regularly as well as means to use ODF anyway. I think
that's enough.

GIMP, for example, changed the way images are saved. Save and Save As produce
the internal format only, and you need to _export_ in order to save as PDF, JPG
etc. Very annoying, and I agree with comment 1 (closing this ticket as INVALID
as suggested in comment 3).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34391] FORMATTING: Implementing Table Styles

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=34391

Heiko Tietze  changed:

   What|Removed |Added

 Depends on||57344


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=57344
[Bug 57344] UI: 'Edit Style' item superfluous in TABLE related context menus if
not all table is selected
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57344] UI: 'Edit Style' item superfluous in TABLE related context menus if not all table is selected

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57344

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 Blocks||34391
   Severity|normal  |enhancement

--- Comment #9 from Heiko Tietze  ---
Table styles as known in Writer (see bug 34391) should be also available at
Draw/Impress.

normal -> enhancement, ux -> /done


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=34391
[Bug 34391] FORMATTING: Implementing Table Styles
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 57344] UI: 'Edit Style' item superfluous in TABLE related context menus if not all table is selected

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57344

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 Blocks||34391
   Severity|normal  |enhancement

--- Comment #9 from Heiko Tietze  ---
Table styles as known in Writer (see bug 34391) should be also available at
Draw/Impress.

normal -> enhancement, ux -> /done


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=34391
[Bug 34391] FORMATTING: Implementing Table Styles
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 54990] Feature request: Ability to create line hops/ jumps for crossing lines

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=54990

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 86672] MAILMERGE: Add dialog to choose pages from document and number of copies to print

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86672

--- Comment #11 from Heiko Tietze  ---
Apparently I was wrong and the proposal makes sense. Did a quick poll with the
community https://plus.google.com/107566594492891737454/posts/jW1cXUDEgtt, and
while many do not known the feature mail merge more than 50% of the yes/no
replies agree with the idea to have more print options.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 86672] MAILMERGE: Add dialog to choose pages from document and number of copies to print

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86672

--- Comment #11 from Heiko Tietze  ---
Apparently I was wrong and the proposal makes sense. Did a quick poll with the
community https://plus.google.com/107566594492891737454/posts/jW1cXUDEgtt, and
while many do not known the feature mail merge more than 50% of the yes/no
replies agree with the idea to have more print options.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 56899] UI: Export dialogue for graphics should remember settings for consecutive exports (within session)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=56899

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 56899] UI: Export dialogue for graphics should remember settings for consecutive exports (within session)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=56899

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 48015] Option to export all sheet from Drawing and Presentation module

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=48015

jan iversen  changed:

   What|Removed |Added

   Keywords||skillCpp

--- Comment #17 from jan iversen  ---
No need to add needsDevlEval for easyhacks (but ok it does not hurt).

need code pointer, difficulty

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101914] Page format dialog, missing Import Image for page Area -> Fill -> Bitmap as a background image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101914

Xisco Faulí  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||kris.kr...@gmail.com

--- Comment #8 from Xisco Faulí  ---
Regression introduced in range
eee5d67d06c8e0c81ab0874171af0d5c4de18860..1485074d84f7804a2942d4942d7d194039948d05
where there are two commits changing code reagarding bitmap:

author  Rishabh Kumar 2016-07-26 17:24:24 (GMT)
committer   Samuel Mehrbrodt   2016-07-26
18:33:01 (GMT)
commit  a44a0690da6d7cdc173fffea2b87ca899eb41ecd (patch)
tree416f12fc49e144e448110a24dbbdeb2ec5effe7c
parent  c9b2af045acc92c8665a8523407f530cc691d5bf (diff)
[GSoC] Add Bitmap tab to area dialog

author  Rishabh Kumar 2016-07-07 21:18:42 (GMT)
committer   Samuel Mehrbrodt   2016-07-26
19:31:28 (GMT)
commit  7438bc1f0c4fd42420460a144cc074bfb8091705 (patch)
tree9f8fc5ca96905884c75534d9387674c8239afa4d
parent  a44a0690da6d7cdc173fffea2b87ca899eb41ecd (diff)
[GSoC] Remove bitmap controls from area tab

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102195] New: Text between two animated lines disappears in slideshow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102195

Bug ID: 102195
   Summary: Text between two animated lines disappears in
slideshow
   Product: LibreOffice
   Version: 4.4.7.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: katarina.behr...@cib.de

Created attachment 127331
  --> https://bugs.documentfoundation.org/attachment.cgi?id=127331=edit
1-slide presentation to demonstrate the issue

It's this time of the year (= conference time) to report some bugs in Impress
again ;-)

Attached is a slide from my LibO Con presentation, reduced to minimum to show
the bug. It contains a paragraph of text and the whole text is normally visible
in edit mode.

2 lines of the paragraph however have an animation assigned (Emphasis > Change
font colour) - 'Toggle = TRUE' and 'Toolbox = TRUE'. So far so good.

Now start the slideshow (F5)

Expected: The whole paragraph will be visible 

Actual: The chunk of text between the two animated lines is NOT visible and
doesn't appear ever, not even after the animations have run.

4.4.7 is the oldes version I've been able to reproduce the bug with. I see the
issue w/ ~relatively recent self-built master too

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89072] Template Manager: long files names or titles are not fully displayed (also not in popup)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89072

Harald Koester  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

--- Comment #5 from Harald Koester  ---
Checked with version 5.2.1. Works as expected. Hence bug closed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 58685] Add *option* for proposing a file name based on the content of the document on first save

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=58685

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

   Keywords|easyHack, needsDevEval, |
   |skillCpp, topicUI   |
 Status|NEEDINFO|NEW

--- Comment #15 from Samuel Mehrbrodt (CIB)  ---
Too complex for an easy hack, removing the keywords.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 58685] Add *option* for proposing a file name based on the content of the document on first save

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=58685

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

   Keywords|easyHack, needsDevEval, |
   |skillCpp, topicUI   |
 Status|NEEDINFO|NEW

--- Comment #15 from Samuel Mehrbrodt (CIB)  ---
Too complex for an easy hack, removing the keywords.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 48015] Option to export all sheet from Drawing and Presentation module

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=48015

jan iversen  changed:

   What|Removed |Added

   Keywords||skillCpp

--- Comment #17 from jan iversen  ---
No need to add needsDevlEval for easyhacks (but ok it does not hurt).

need code pointer, difficulty

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 53856] FILEOPEN: Docx import results in partially incorrect paragraph style ( adds italics style to font property)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=53856

Justin L  changed:

   What|Removed |Added

   Keywords||preBibisect
 CC||jl...@mail.com
Version|4.0.0.0.beta1   |Inherited From OOo
   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |

--- Comment #4 from Justin L  ---
Marking as inherited from OOo - bibisected back to last35onmaster.
Still present in 5.3dev  (Ubuntu 16.04)

Paragraph style "Caption" -> "Text" is a default Writer style, so we have a
name conflict.

proposed fix: https://gerrit.libreoffice.org/#/c/28894/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46988] VIEWING: Screen jumps when scrolling down with arrow keys

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46988

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #20 from Heiko Tietze  ---
There are clearly pros versus cons, you either keep the current line focused or
loose the ability to read whole paragraphs. 

An alternative solution could be to introduce "smooth scrolling", as known from
Mozilla Firefox, and scroll slowly up the 8 lines. Doing so supports the
physiological capabilities of eye movements. On the other hand there is not
much to say against an option how many lines to scroll per arrow.

(There is an _expert_ option ooO.Writer/WriterWeb > Layout > Window >
SmoothScroll that defaults to false, but I don't see any effect when changing
it)

(Removing needsUX but CC'ing the mailing list)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101171] Cursor lost if jumping to a bookmark from the status bar ( GTK2)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101171

Xisco Faulí  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected
 CC||caol...@redhat.com,
   ||xiscofa...@libreoffice.org
Summary|Cursor lost if jumping to a |Cursor lost if jumping to a
   |bookmark from the status|bookmark from the status
   |bar |bar (GTK2)

--- Comment #3 from Xisco Faulí  ---
I can only reproduce it with GTK2, not with GTK3. Adding it to the summary...

Regression introduced in range
c1b90fa342e09ab30068f6294fc866c63d7ae4c4..00cf864e5d317016d7224c199aa982d07bd70113

Caolán, One for you?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102070] Menubar button to change the toolbar layout/mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102070

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 CC||s.mehrbr...@gmail.com

--- Comment #9 from Samuel Mehrbrodt (CIB)  ---
Havent read everything in here, but atm we shouldn't add any easy discoverable
means to activate the Notebookbar. It is only a proof-of-concept currently and
far from finished.

Please leave it hidden for now, as we did with the Sidebar in earlier days.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 102070] Menubar button to change the toolbar layout/mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102070

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 CC||s.mehrbr...@gmail.com

--- Comment #9 from Samuel Mehrbrodt (CIB)  ---
Havent read everything in here, but atm we shouldn't add any easy discoverable
means to activate the Notebookbar. It is only a proof-of-concept currently and
far from finished.

Please leave it hidden for now, as we did with the Sidebar in earlier days.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 94427] UI: Show indicator of currently applied style when a different style is selected in styles sidebar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94427

--- Comment #17 from Cor Nouws  ---
(In reply to Heiko Tietze from comment #15)

> > What do you mean with the last part, drop right click access?
> 
> Today, you can modify a style that is not active by right clicking the
> entry. With single selection this could still be possible, but likely adds a
> lot of coding effort and makes not much sense, workflow wise.

It happens regularly that one edits a style that is not selected. Can also be a
style from which others inherit. Or a style from a type that is not active in
the selection (frame, lists..) So I would be rather reluctant dropping that.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 94427] UI: Show indicator of currently applied style when a different style is selected in styles sidebar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94427

--- Comment #17 from Cor Nouws  ---
(In reply to Heiko Tietze from comment #15)

> > What do you mean with the last part, drop right click access?
> 
> Today, you can modify a style that is not active by right clicking the
> entry. With single selection this could still be possible, but likely adds a
> lot of coding effort and makes not much sense, workflow wise.

It happens regularly that one edits a style that is not selected. Can also be a
style from which others inherit. Or a style from a type that is not active in
the selection (frame, lists..) So I would be rather reluctant dropping that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 45864] UI: Add "Glue Point deletion" tool

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45864

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs