[Libreoffice-commits] core.git: sc/inc sc/source

[Noel Grandin (via logerrit)]

 sc/inc/docuno.hxx   |2 +
 sc/source/filter/oox/commentsbuffer.cxx |   60 +++-
 sc/source/ui/docshell/docfunc.cxx   |   23 
 sc/source/ui/inc/docfunc.hxx|4 +-
 4 files changed, 64 insertions(+), 25 deletions(-)

New commits:
commit 4992d61600536fe14b97b718dbb11f00e936c6a9
Author: Noel Grandin 
AuthorDate: Sun Dec 29 14:00:14 2019 +0200
Commit: Noel Grandin 
CommitDate: Wed Jan 1 09:37:37 2020 +0100

tdf#129228 speedup opening of xlsx file with lots of comments

de-UNOise the Comment::finalizeImport method, so we can build
a better custom import code path, that does not touch all the stuff
that updating a running UI needs.

The primary improvements comes from using setPropertyValues
to set a bunch of props together.

This takes the opening time from 61s to 53s for me.

Change-Id: I5506a5a37a9b4b84b6930f0563a775a8aa0a9e2c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85947
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/sc/inc/docuno.hxx b/sc/inc/docuno.hxx
index b80933783761..f2adcda7a80f 100644
--- a/sc/inc/docuno.hxx
+++ b/sc/inc/docuno.hxx
@@ -673,6 +673,8 @@ public:
 
 virtual voidNotify( SfxBroadcaster& rBC, const SfxHint& rHint 
) override;
 
+ScDocShell* GetDocShell() const { return pDocShell; }
+
 /// XSheetAnnotations
 virtual void SAL_CALL   insertNew( const css::table::CellAddress& 
aPosition,
 const OUString& aText ) override;
diff --git a/sc/source/filter/oox/commentsbuffer.cxx 
b/sc/source/filter/oox/commentsbuffer.cxx
index 43b133aad4fe..097e86b176d9 100644
--- a/sc/source/filter/oox/commentsbuffer.cxx
+++ b/sc/source/filter/oox/commentsbuffer.cxx
@@ -23,6 +23,7 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -34,8 +35,16 @@
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
 #include 
 #include 
+#include 
+#include 
+#include 
+#include 
+#include 
 
 namespace oox {
 namespace xls {
@@ -149,28 +158,27 @@ void Comment::finalizeImport()
 // BIFF12 stores cell range instead of cell address, use first cell of 
this range
 OSL_ENSURE( maModel.maRange.aStart == maModel.maRange.aEnd,
 "Comment::finalizeImport - comment anchor should be a single cell" );
-if( getAddressConverter().checkCellAddress( maModel.maRange.aStart, true ) 
&& maModel.mxText.get() ) try
+if( !getAddressConverter().checkCellAddress( maModel.maRange.aStart, true 
) || !maModel.mxText.get() )
+return;
+
+try
 {
-CellAddress aNotePos( maModel.maRange.aStart.Tab(), 
maModel.maRange.aStart.Col(), maModel.maRange.aStart.Row() );
-Reference< XSheetAnnotationsSupplier > xAnnosSupp( getSheet(), 
UNO_QUERY_THROW );
-Reference< XSheetAnnotations > xAnnos( xAnnosSupp->getAnnotations(), 
UNO_SET_THROW );
+ScTableSheetObj* pAnnosSupp = 
static_cast(getSheet().get());
+rtl::Reference xAnnos = 
static_cast(pAnnosSupp->getAnnotations().get());
+ScDocShell* pDocShell = xAnnos->GetDocShell();
 // non-empty string required by note implementation (real text will be 
added below)
-xAnnos->insertNew( aNotePos, OUString( ' ' ) );
+ScPostIt* pPostIt = pDocShell->GetDocFunc().ImportNote( 
maModel.maRange.aStart, OUString( ' ' ), nullptr, nullptr );
+SdrCaptionObj* pCaption = pPostIt->GetOrCreateCaption( 
maModel.maRange.aStart );
 
-// receive created note from cell (insertNew does not return the note)
-Reference< XSheetAnnotationAnchor > xAnnoAnchor( getCell( 
maModel.maRange.aStart ), UNO_QUERY_THROW );
-Reference< XSheetAnnotation > xAnno( xAnnoAnchor->getAnnotation(), 
UNO_SET_THROW );
-Reference< XSheetAnnotationShapeSupplier > xAnnoShapeSupp( xAnno, 
UNO_QUERY_THROW );
-Reference< XShape > xAnnoShape( xAnnoShapeSupp->getAnnotationShape(), 
UNO_SET_THROW );
+Reference< XShape > xAnnoShape( pCaption->getUnoShape(), 
UNO_QUERY_THROW ); // SvxShapeText
+// setting a property triggers expensive process, so set them all at 
once
+Reference< css::beans::XMultiPropertySet > 
xAnnoShapeMultiPropSet(xAnnoShape, UNO_QUERY_THROW);
 
-// convert shape formatting and visibility
-bool bVisible = true;
 // Add shape formatting properties (autoFill, colHidden and rowHidden 
are dropped)
-PropertySet aCommentPr( xAnnoShape );
-aCommentPr.setProperty( PROP_TextFitToSize, maModel.mbAutoScale );
-aCommentPr.setProperty( PROP_MoveProtect, maModel.mbLocked );
-aCommentPr.setProperty( PROP_TextHorizontalAdjust, lcl_ToHorizAlign( 
maModel.mnTHA ) );
-aCommentPr.setProperty( PROP_TextVerticalAdjust, lcl_ToVertAlign( 
maModel.mnTVA ) );
+xAnnoShapeMultiPropSet->setPropertyValues(
+Sequence { 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - sc/inc sc/source

[Noel Grandin (via logerrit)]

 sc/inc/patattr.hxx  |4 
 sc/source/core/data/patattr.cxx |   34 +-
 2 files changed, 33 insertions(+), 5 deletions(-)

New commits:
commit 3208e69e5ff7a4d151a108d7f2af134664a26bab
Author: Noel Grandin 
AuthorDate: Sat Dec 28 12:49:41 2019 +0200
Commit: Noel Grandin 
CommitDate: Wed Jan 1 09:39:21 2020 +0100

tdf#129228 speedup opening of xlsx file with lots of comments

by avoid some of the EqualPatternSets memcmp cost by using a
hashcode, memcmp with lots of large and similar arrays ends up
blowing the L1/L2 cache

Takes the time from 64s to 59s for me.

Change-Id: I6961aa34f4e7457a70cb75a37dfae50d5f328589
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85918
Tested-by: Jenkins
Reviewed-by: Noel Grandin 
Signed-off-by: Xisco Fauli 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85948

diff --git a/sc/inc/patattr.hxx b/sc/inc/patattr.hxx
index 19c4df01c345..c0e7c39fa6aa 100644
--- a/sc/inc/patattr.hxx
+++ b/sc/inc/patattr.hxx
@@ -52,6 +52,7 @@ enum ScAutoFontColorMode
 class SC_DLLPUBLIC ScPatternAttr final : public SfxSetItem
 {
 boost::optional  pName;
+mutable boost::optional mxHashCode;
 ScStyleSheet*  pStyle;
 sal_uInt64 mnKey;
 public:
@@ -143,6 +144,9 @@ public:
 
 voidSetKey(sal_uInt64 nKey);
 sal_uInt64  GetKey() const;
+
+private:
+voidCalcHashCode() const;
 };
 
 #endif
diff --git a/sc/source/core/data/patattr.cxx b/sc/source/core/data/patattr.cxx
index f7e4010d5518..1538ab6aebe7 100644
--- a/sc/source/core/data/patattr.cxx
+++ b/sc/source/core/data/patattr.cxx
@@ -61,6 +61,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using sc::HMMToTwips;
 using sc::TwipsToHMM;
@@ -139,9 +140,17 @@ bool ScPatternAttr::operator==( const SfxPoolItem& rCmp ) 
const
 {
 // #i62090# Use quick comparison between ScPatternAttr's ItemSets
 
-return SfxPoolItem::operator==(rCmp) &&
-EqualPatternSets( GetItemSet(), static_cast(rCmp).GetItemSet() ) &&
-StrCmp( GetStyleName(), static_cast(rCmp).GetStyleName() );
+if (!SfxPoolItem::operator==(rCmp) )
+return false;
+if (!mxHashCode)
+CalcHashCode();
+auto const & rOther = static_cast(rCmp);
+if (!rOther.mxHashCode)
+rOther.CalcHashCode();
+if (*mxHashCode != *rOther.mxHashCode)
+return false;
+return EqualPatternSets( GetItemSet(), rOther.GetItemSet() ) &&
+StrCmp( GetStyleName(), rOther.GetStyleName() );
 }
 
 SvxCellOrientation ScPatternAttr::GetCellOrientation( const SfxItemSet& 
rItemSet, const SfxItemSet* pCondSet )
@@ -880,8 +889,10 @@ void ScPatternAttr::GetFromEditItemSet( SfxItemSet& 
rDestSet, const SfxItemSet&
 
 void ScPatternAttr::GetFromEditItemSet( const SfxItemSet* pEditSet )
 {
-if( pEditSet )
-GetFromEditItemSet( GetItemSet(), *pEditSet );
+if( !pEditSet )
+return;
+GetFromEditItemSet( GetItemSet(), *pEditSet );
+mxHashCode.reset();
 }
 
 void ScPatternAttr::FillEditParaItems( SfxItemSet* pEditSet ) const
@@ -922,13 +933,19 @@ void ScPatternAttr::DeleteUnchanged( const ScPatternAttr* 
pOldAttrs )
 {
 //  item is set in OldAttrs (or its parent) -> compare pointers
 if ( pThisItem == pOldItem )
+{
 rThisSet.ClearItem( nSubWhich );
+mxHashCode.reset();
+}
 }
 else if ( eOldState != SfxItemState::DONTCARE )
 {
 //  not set in OldAttrs -> compare item value to default item
 if ( *pThisItem == rThisSet.GetPool()->GetDefaultItem( 
nSubWhich ) )
+{
 rThisSet.ClearItem( nSubWhich );
+mxHashCode.reset();
+}
 }
 }
 }
@@ -948,6 +965,7 @@ void ScPatternAttr::ClearItems( const sal_uInt16* pWhich )
 SfxItemSet& rSet = GetItemSet();
 for (sal_uInt16 i=0; pWhich[i]; i++)
 rSet.ClearItem(pWhich[i]);
+mxHashCode.reset();
 }
 
 static SfxStyleSheetBase* lcl_CopyStyleToPool
@@ -1345,4 +1363,10 @@ sal_uInt64 ScPatternAttr::GetKey() const
 return mnKey;
 }
 
+void ScPatternAttr::CalcHashCode() const
+{
+auto const & rSet = GetItemSet();
+mxHashCode = boost::hash_range(rSet.GetItems_Impl(), rSet.GetItems_Impl() 
+ rSet.Count());
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa

[Andrea Gelmini (via logerrit)]

 sc/qa/unit/subsequent_export-test.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 75eac8f2ef2ea0d15612d38f38a994df52bb00c9
Author: Andrea Gelmini 
AuthorDate: Wed Jan 1 09:48:54 2020 +0100
Commit: Julien Nabet 
CommitDate: Wed Jan 1 10:01:53 2020 +0100

Fix typo

Change-Id: I9b7183be9bc5cbfef9ab1538fd20554217fa4b70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86062
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/sc/qa/unit/subsequent_export-test.cxx 
b/sc/qa/unit/subsequent_export-test.cxx
index f4a603749633..38f024ae22a4 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -4667,7 +4667,7 @@ void ScExportTest::testTdf128976()
 void ScExportTest::testTdf120502()
 {
 // Create an empty worksheet; resize last column on its first sheet; 
export to XLSX, and check
-// that the last exportd column number is correct
+// that the last exported column number is correct
 css::uno::Reference xDesktop
 = 
css::frame::Desktop::create(comphelper::getProcessComponentContext());
 CPPUNIT_ASSERT(xDesktop);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa

[Caolán McNamara (via logerrit)]

 sc/qa/uitest/calc_dialogs/openDialogs.py |3 ++-
 sc/qa/uitest/calc_tests2/dataform.py |   27 +++
 2 files changed, 29 insertions(+), 1 deletion(-)

New commits:
commit f0fc4ac88d0d82ee81e0a55bdc54421f955705f0
Author: Caolán McNamara 
AuthorDate: Tue Dec 31 19:49:41 2019 +
Commit: Caolán McNamara 
CommitDate: Wed Jan 1 13:19:05 2020 +0100

explicit uitest for uno:DataForm

Change-Id: I795ec97e663708fa36feae8f537e2138dfd77547
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86052
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/qa/uitest/calc_dialogs/openDialogs.py 
b/sc/qa/uitest/calc_dialogs/openDialogs.py
index 94a7ca916c14..7d38ba004da1 100644
--- a/sc/qa/uitest/calc_dialogs/openDialogs.py
+++ b/sc/qa/uitest/calc_dialogs/openDialogs.py
@@ -103,7 +103,8 @@ dialogs = [
 # tested in sc/qa/uitest/validity/validity.py
 # {"command": ".uno:DataSubTotals", "closeButton": "cancel"},
 # tested in sc/qa/uitest/calc_tests2/subtotals.py
-{"command": ".uno:DataForm", "closeButton": "close"},
+# {"command": ".uno:DataForm", "closeButton": "close"},
+# tested in sc/qa/uitest/calc_tests2/dataform.py
 # {"command": ".uno:DataConsolidate", "closeButton": "cancel"},
 # tested in sc/qa/uitest/calc_tests2/consolidate.py
 {"command": ".uno:Group", "closeButton": "cancel"},
diff --git a/sc/qa/uitest/calc_tests2/dataform.py 
b/sc/qa/uitest/calc_tests2/dataform.py
new file mode 100644
index ..0ffe0e70d2c1
--- /dev/null
+++ b/sc/qa/uitest/calc_tests2/dataform.py
@@ -0,0 +1,27 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+from uitest.framework import UITestCase
+from libreoffice.uno.propertyvalue import mkPropertyValues
+import org.libreoffice.unotest
+
+#dataformdialog.ui
+class dataform(UITestCase):
+def test_dataform(self):
+calc_doc = self.ui_test.create_doc_in_start_center("calc")
+
+xCalcDoc = self.xUITest.getTopFocusWindow()
+gridwin = xCalcDoc.getChild("grid_window")
+gridwin.executeAction("SELECT", mkPropertyValues({"RANGE": "A1:A10"}))
+
+self.ui_test.execute_dialog_through_command(".uno:DataForm")
+xDialog = self.xUITest.getTopFocusWindow()
+
+xCloseBtn = xDialog.getChild("close")
+self.ui_test.close_dialog_through_button(xCloseBtn)
+self.ui_test.close_doc()
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: hwpfilter/source

[Caolán McNamara (via logerrit)]

 hwpfilter/source/hwpreader.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 75778a50f730568fee2466b6e794401f1e2a8f67
Author: Caolán McNamara 
AuthorDate: Tue Dec 31 19:44:36 2019 +
Commit: Caolán McNamara 
CommitDate: Wed Jan 1 13:20:24 2020 +0100

crashtesting: footnote-layout doesn't exist

presumably should be page-layout-properties instead

presumably triggered since a FastParser API change over

Change-Id: Ic4f5e9c30921adb26bb05028f2a3f75d8c0d731e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86051
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx
index 58eab6a8ed84..0cd9f831d59d 100644
--- a/hwpfilter/source/hwpreader.cxx
+++ b/hwpfilter/source/hwpreader.cxx
@@ -1775,8 +1775,8 @@ void HwpReader::makePageStyle()
  rendEl("style:properties");
  rendEl("style:footer-style");
 
-/* Footnote style, but it fell in the dtd, the specification has been 
defined. REALKING */
- rstartEl("style:footnote-layout", mxList.get());
+/* Footnote style */
+ rstartEl("style:page-layout-properties", mxList.get());
 
  padd("style:distance-before-sep", sXML_CDATA,
   Double2Str(WTI(hwpinfo.splinetext)) + "inch");
@@ -1798,7 +1798,7 @@ void HwpReader::makePageStyle()
  mxList->clear();
  rendEl("style:footnote-sep");
 
- rendEl("style:footnote-layout");
+ rendEl("style:page-layout-properties");
 
  rendEl("style:page-master");
  }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: chart2/qa

[Mike Kaganski (via logerrit)]

 chart2/qa/extras/chart2export.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 386771e25d35f846c16f9ba7ddbf135c3cba3565
Author: Mike Kaganski 
AuthorDate: Mon Dec 30 00:26:37 2019 +0300
Commit: Mike Kaganski 
CommitDate: Wed Jan 1 11:44:56 2020 +0100

Fix Chart2ExportTest::testAxisTitlePositionDOCX test for 150% UI scaling

On Windows, with 150% UI scaling, the three values whose tolerance are
fixed are 0.698077301660214, 0.80537743278209, and 0.0255266093575694
respectively.

Change-Id: Ifae5eecff7fc8aa71bb2e15f3d82c934e51fa966
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85966
Tested-by: Jenkins
Reviewed-by: Balazs Varga 
Reviewed-by: Mike Kaganski 

diff --git a/chart2/qa/extras/chart2export.cxx 
b/chart2/qa/extras/chart2export.cxx
index 181645b437e3..62aa0764a69a 100644
--- a/chart2/qa/extras/chart2export.cxx
+++ b/chart2/qa/extras/chart2export.cxx
@@ -2023,15 +2023,15 @@ void Chart2ExportTest::testAxisTitlePositionDOCX()
 // test X Axis title position
 OUString aXVal = getXPath(pXmlDoc, 
"/c:chartSpace/c:chart/c:plotArea/c:catAx/c:title/c:layout/c:manualLayout/c:x", 
"val");
 double nX = aXVal.toDouble();
-CPPUNIT_ASSERT_DOUBLES_EQUAL(0.698208543867708, nX, 1e-7);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(0.698208543867708, nX, 1e-3);
 OUString aYVal = getXPath(pXmlDoc, 
"/c:chartSpace/c:chart/c:plotArea/c:catAx/c:title/c:layout/c:manualLayout/c:y", 
"val");
 double nY = aYVal.toDouble();
-CPPUNIT_ASSERT_DOUBLES_EQUAL(0.805152435594555, nY, 1e-7);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(0.805152435594555, nY, 1e-3);
 
 // test Y Axis title position
 aXVal = getXPath(pXmlDoc, 
"/c:chartSpace/c:chart/c:plotArea/c:valAx/c:title/c:layout/c:manualLayout/c:x", 
"val");
 nX = aXVal.toDouble();
-CPPUNIT_ASSERT_DOUBLES_EQUAL(0.0253953671500755, nX, 1e-7);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(0.0253953671500755, nX, 1e-3);
 aYVal = getXPath(pXmlDoc, 
"/c:chartSpace/c:chart/c:plotArea/c:valAx/c:title/c:layout/c:manualLayout/c:y", 
"val");
 nY = aYVal.toDouble();
 // just test the first two decimal digits because it is not perfect in 
docx yet.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] translations.git: Branch 'libreoffice-6-4' - source/sl

[Andras Timar (via logerrit)]

 source/sl/cui/messages.po |4 
 source/sl/helpcontent2/source/text/scalc.po   |6 
 source/sl/helpcontent2/source/text/scalc/01.po|   50 
 source/sl/helpcontent2/source/text/schart.po  |8 
 source/sl/helpcontent2/source/text/shared.po  |   10 
 source/sl/helpcontent2/source/text/shared/01.po   |8 
 source/sl/helpcontent2/source/text/shared/06.po   |   22 
 source/sl/helpcontent2/source/text/simpress/guide.po  |   10 
 source/sl/helpcontent2/source/text/swriter/01.po  |8 
 source/sl/helpcontent2/source/text/swriter/04.po  |8 
 source/sl/helpcontent2/source/text/swriter/guide.po   |   10 
 source/sl/officecfg/registry/data/org/openoffice/Office/UI.po |   44 
 source/sl/sc/messages.po  |   38 
 source/sl/sw/messages.po  | 1837 +-
 source/sl/xmlsecurity/messages.po |   25 
 15 files changed, 1089 insertions(+), 999 deletions(-)

New commits:
commit 51e009dadcd8769a9902b98ec00d03e26b1ebd54
Author: Andras Timar 
AuthorDate: Wed Jan 1 17:41:22 2020 +0100
Commit: Andras Timar 
CommitDate: Wed Jan 1 17:41:22 2020 +0100

Updated Slovenian translation

Change-Id: I25d9bf193f1a804df7b3240b535eab16f3efe762

diff --git a/source/sl/cui/messages.po b/source/sl/cui/messages.po
index fa4061a89c0..b6c07e0715b 100644
--- a/source/sl/cui/messages.po
+++ b/source/sl/cui/messages.po
@@ -3,14 +3,14 @@ msgid ""
 msgstr ""
 "Project-Id-Version: LibreOffice 6.4\n"
 "Report-Msgid-Bugs-To: 
https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice_status=UNCONFIRMED=UI\n;
-"POT-Creation-Date: 2019-12-16 23:56+0100\n"
+"POT-Creation-Date: 2019-12-19 13:19+0100\n"
 "PO-Revision-Date: 2019-12-17 00:52+0200\n"
 "Last-Translator: Martin Srebotnjak \n"
 "Language-Team: sl.libreoffice.org\n"
-"Language: sl\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
+"Language: sl\n"
 "Plural-Forms: nplurals=4; plural=(n%100==1 ? 0 : n%100==2 ? 1 : n%100==3 || 
n%100==4 ? 2 : 3);\n"
 "X-Generator: Virtaal 0.7.1\n"
 "X-Accelerator-Marker: ~\n"
diff --git a/source/sl/helpcontent2/source/text/scalc.po 
b/source/sl/helpcontent2/source/text/scalc.po
index e23e3c737d4..fb8dc482097 100644
--- a/source/sl/helpcontent2/source/text/scalc.po
+++ b/source/sl/helpcontent2/source/text/scalc.po
@@ -3,8 +3,8 @@ msgid ""
 msgstr ""
 "Project-Id-Version: LibreOffice 6.4\n"
 "Report-Msgid-Bugs-To: 
https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice_status=UNCONFIRMED=UI\n;
-"POT-Creation-Date: 2019-12-13 11:22+0100\n"
-"PO-Revision-Date: 2019-12-08 19:28+0200\n"
+"POT-Creation-Date: 2019-12-28 18:41+0100\n"
+"PO-Revision-Date: 2019-12-19 22:33+0200\n"
 "Last-Translator: Martin Srebotnjak \n"
 "Language-Team: sl.libreoffice.org\n"
 "MIME-Version: 1.0\n"
@@ -231,7 +231,7 @@ msgctxt ""
 "par_id03302017024610704\n"
 "help.text"
 msgid "Display the cell formula expression instead of the calculated result."
-msgstr "Shrani formule celic namesto izračunanih vrednosti"
+msgstr "Shrani formule celic namesto izračunanih vrednosti."
 
 #: main0103.xhp
 msgctxt ""
diff --git a/source/sl/helpcontent2/source/text/scalc/01.po 
b/source/sl/helpcontent2/source/text/scalc/01.po
index 2c7aa7639ea..08e0eba5d56 100644
--- a/source/sl/helpcontent2/source/text/scalc/01.po
+++ b/source/sl/helpcontent2/source/text/scalc/01.po
@@ -3,14 +3,14 @@ msgid ""
 msgstr ""
 "Project-Id-Version: LibreOffice 6.4\n"
 "Report-Msgid-Bugs-To: 
https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice_status=UNCONFIRMED=UI\n;
-"POT-Creation-Date: 2019-12-15 19:52+0100\n"
-"PO-Revision-Date: 2019-12-13 18:39+0200\n"
+"POT-Creation-Date: 2019-12-28 18:41+0100\n"
+"PO-Revision-Date: 2019-12-28 22:30+0200\n"
 "Last-Translator: Martin Srebotnjak \n"
 "Language-Team: sl.libreoffice.org\n"
+"Language: sl\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
-"Language: sl\n"
 "Plural-Forms: nplurals=4; plural=(n%100==1 ? 0 : n%100==2 ? 1 : n%100==3 || 
n%100==4 ? 2 : 3);\n"
 "X-Generator: Virtaal 0.7.1\n"
 "X-Accelerator-Marker: ~\n"
@@ -54006,7 +54006,7 @@ msgctxt ""
 "func_opt_barrier.xhp\n"
 "par_id371575067051846\n"
 "help.text"
-msgid "OPT_BARRIER(Spot; Volatility; Rate; Foreign Rate; Maturity; Strike; 
Lower Barrier; Upper Barrier; Rebate; Put or Call; In or Out; Barrier 
Monitoring; Greek)"
+msgid "OPT_BARRIER(Spot; Volatility; Rate; Foreign Rate; Maturity; Strike; 
LowerBarrier; UpperBarrier; Rebate; PutCall; InOut; BarrierMonitoring; Greek)"
 msgstr "OPT_BARRIER(prompt; nestanovitnost; obrestna mera; tuja obrestna mera; 
dospetje; izvršilna; spodnja meja; zgornja meja; povračilo; prodajna ali 
nakupna; pričetek ali zaključek veljavnosti; spremljanje meje; limite)"
 
 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - translations

[Andras Timar (via logerrit)]

 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f393fe3febb82a9c5da184307ff0fc00fafb9417
Author: Andras Timar 
AuthorDate: Wed Jan 1 17:41:29 2020 +0100
Commit: Gerrit Code Review 
CommitDate: Wed Jan 1 17:41:29 2020 +0100

Update git submodules

* Update translations from branch 'libreoffice-6-4'
  to 51e009dadcd8769a9902b98ec00d03e26b1ebd54
  - Updated Slovenian translation

Change-Id: I25d9bf193f1a804df7b3240b535eab16f3efe762

diff --git a/translations b/translations
index f217c955342d..51e009dadcd8 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit f217c955342dcb27ea404ebb639e9521b72a270b
+Subproject commit 51e009dadcd8769a9902b98ec00d03e26b1ebd54
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: icon-themes/sifr

[Andrea Gelmini (via logerrit)]

 0 files changed

New commits:
commit 3dd79ff0bb9fcbac7338447785da8e1aff53434e
Author: Andrea Gelmini 
AuthorDate: Wed Jan 1 09:50:32 2020 +0100
Commit: Julien Nabet 
CommitDate: Wed Jan 1 10:03:05 2020 +0100

Removed executable flags on images

Change-Id: Ifd1923bd2202b92f59e5aabec442a3b800a13502
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86063
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/icon-themes/sifr/avmedia/res/avaudiologo.png 
b/icon-themes/sifr/avmedia/res/avaudiologo.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/avmedia/res/avemptylogo.png 
b/icon-themes/sifr/avmedia/res/avemptylogo.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/areas3d_52x60.png 
b/icon-themes/sifr/chart2/res/areas3d_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/areas_52x60.png 
b/icon-themes/sifr/chart2/res/areas_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/areasfull3d_52x60.png 
b/icon-themes/sifr/chart2/res/areasfull3d_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/areasfull_52x60.png 
b/icon-themes/sifr/chart2/res/areasfull_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/areaspiled3d_52x60.png 
b/icon-themes/sifr/chart2/res/areaspiled3d_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/areaspiled_52x60.png 
b/icon-themes/sifr/chart2/res/areaspiled_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/bar3d_52x60.png 
b/icon-themes/sifr/chart2/res/bar3d_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/bar3ddeep_52x60.png 
b/icon-themes/sifr/chart2/res/bar3ddeep_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/bar_52x60.png 
b/icon-themes/sifr/chart2/res/bar_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/barpercent3d_52x60.png 
b/icon-themes/sifr/chart2/res/barpercent3d_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/barpercent_52x60.png 
b/icon-themes/sifr/chart2/res/barpercent_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/barstack3d_52x60.png 
b/icon-themes/sifr/chart2/res/barstack3d_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/barstack_52x60.png 
b/icon-themes/sifr/chart2/res/barstack_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/columnline_52x60.png 
b/icon-themes/sifr/chart2/res/columnline_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/columnpercent3d_52x60.png 
b/icon-themes/sifr/chart2/res/columnpercent3d_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/columnpercent_52x60.png 
b/icon-themes/sifr/chart2/res/columnpercent_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/columns3d_52x60.png 
b/icon-themes/sifr/chart2/res/columns3d_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/columns3ddeep_52x60.png 
b/icon-themes/sifr/chart2/res/columns3ddeep_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/columns_52x60.png 
b/icon-themes/sifr/chart2/res/columns_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/columnstack3d_52x60.png 
b/icon-themes/sifr/chart2/res/columnstack3d_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/columnstack_52x60.png 
b/icon-themes/sifr/chart2/res/columnstack_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/columnstackline_52x60.png 
b/icon-themes/sifr/chart2/res/columnstackline_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/cone_52x60.png 
b/icon-themes/sifr/chart2/res/cone_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/conedeep_52x60.png 
b/icon-themes/sifr/chart2/res/conedeep_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/conehori_52x60.png 
b/icon-themes/sifr/chart2/res/conehori_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/conehorideep_52x60.png 
b/icon-themes/sifr/chart2/res/conehorideep_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/conehoristack_52x60.png 
b/icon-themes/sifr/chart2/res/conehoristack_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/conepercent_52x60.png 
b/icon-themes/sifr/chart2/res/conepercent_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/conestack_52x60.png 
b/icon-themes/sifr/chart2/res/conestack_52x60.png
old mode 100755
new mode 100644
diff --git a/icon-themes/sifr/chart2/res/cylinder_52x60.png 

[Libreoffice-commits] online.git: loleaflet/src

[Michael Meeks (via logerrit)]

 loleaflet/src/control/Control.JSDialogBuilder.js |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 4c43a5622e75f17a6f86389dfdd6c76abbfb1853
Author: Michael Meeks 
AuthorDate: Wed Jan 1 16:00:53 2020 +
Commit: Michael Meeks 
CommitDate: Wed Jan 1 16:01:27 2020 +

Avoid broken icons: provide an empty alt="" for mobile panel icons.

Change-Id: I3cec930fdd16c5ad40970d939cceadde2245a822

diff --git a/loleaflet/src/control/Control.JSDialogBuilder.js 
b/loleaflet/src/control/Control.JSDialogBuilder.js
index fa252cba8..b704ddfdf 100644
--- a/loleaflet/src/control/Control.JSDialogBuilder.js
+++ b/loleaflet/src/control/Control.JSDialogBuilder.js
@@ -245,6 +245,7 @@ L.Control.JSDialogBuilder = L.Control.extend({
if (iconPath) {
var icon = L.DomUtil.create('img', 'menu-entry-icon', 
leftDiv);
icon.src = iconPath;
+   icon.alt = '';
titleClass = 'menu-entry-with-icon'
}
var titleSpan = L.DomUtil.create('span', titleClass, leftDiv);
@@ -901,6 +902,7 @@ L.Control.JSDialogBuilder = L.Control.extend({
var image = L.DomUtil.create('img', 'spinfieldimage', 
div);
var icon = builder._createIconPath(data.id);
image.src = icon;
+   icon.alt = '';
}
 
var spinfield = L.DomUtil.create('input', 'spinfield', div);
@@ -1421,6 +1423,7 @@ L.Control.JSDialogBuilder = L.Control.extend({
var iconPath = 'images/lc_' + commandName.toLowerCase() 
+ '.svg';
icon = L.DomUtil.create('img', '', iconSpan);
icon.src = iconPath;
+   icon.alt = '';
}
if (data.checked && data.checked === true) {
L.DomUtil.addClass(menuEntry, 'menu-entry-checked');
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - include/tools tools/source

[Miklos Vajna (via logerrit)]

 include/tools/debug.hxx  |6 +++---
 tools/source/debug/debug.cxx |4 
 2 files changed, 3 insertions(+), 7 deletions(-)

New commits:
commit 522b68aa1c8a0d4720534ca4078cd669f7d7f867
Author: Miklos Vajna 
AuthorDate: Wed Dec 18 10:46:43 2019 +0100
Commit: Tor Lillqvist 
CommitDate: Wed Jan 1 16:12:32 2020 +0200

tools: define DbgTestSolarMutex() unconditionally

See the discussion at , and
this came up on IRC today again.

The above change broke the invariant that you can mix product and debug
(but not dbgutil) builds. Restore this, without mandating dbgutil for
the solar mutex assert code, which is useful for plain debug builds as
well.

Change-Id: I1f8bdb114b129fc4f39f186ba917e35e346a16b5
Reviewed-on: https://gerrit.libreoffice.org/85369
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/include/tools/debug.hxx b/include/tools/debug.hxx
index b66a9b2866ef..c72da4d06887 100644
--- a/include/tools/debug.hxx
+++ b/include/tools/debug.hxx
@@ -34,14 +34,14 @@
 standard assert.
 */
 
-#ifndef NDEBUG
-// we want the solar mutex checking to be enabled in the assert-enabled builds 
that the QA people use
-
 typedef void (*DbgTestSolarMutexProc)();
 
 TOOLS_DLLPUBLIC void DbgSetTestSolarMutex( DbgTestSolarMutexProc pParam );
 TOOLS_DLLPUBLIC void DbgTestSolarMutex();
 
+#ifndef NDEBUG
+// we want the solar mutex checking to be enabled in the assert-enabled builds 
that the QA people use
+
 #define DBG_TESTSOLARMUTEX()   \
 do \
 {  \
diff --git a/tools/source/debug/debug.cxx b/tools/source/debug/debug.cxx
index 0691ee7a05a0..661e734b79b7 100644
--- a/tools/source/debug/debug.cxx
+++ b/tools/source/debug/debug.cxx
@@ -72,8 +72,6 @@
 #include 
 #endif
 
-#ifndef NDEBUG
-
 struct DebugData
 {
 DbgTestSolarMutexProc   pDbgTestSolarMutex;
@@ -104,8 +102,6 @@ void DbgTestSolarMutex()
 aDebugData.pDbgTestSolarMutex();
 }
 
-#endif
-
 OString exceptionToString(const css::uno::Any & caught)
 {
 auto toOString = [](OUString const & s) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Cannot review Gerrit patch

[Chris Sherlock]

On 30 Dec 2019, at 10:06 pm, Chris Sherlock  wrote:
> 
> Hi all, 
> 
> Does anyone know why I can’t review the following?
> 
> https://gerrit.libreoffice.org/#/c/core/+/83439/ 
> 
> 
> I click on the hex/cxx files and it doesn’t open in the old classic UI. 
> 
> Any ideas?
> 
> Chris

Quick ping. Anyone able to assist?

Chris___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: include/svx sc/source sc/uiconfig svx/source svx/uiconfig svx/UIConfig_svx.mk vcl/unx

[Caolán McNamara (via logerrit)]

 include/svx/tbcontrl.hxx   |8 
 sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx |  194 ++---
 sc/source/ui/sidebar/NumberFormatPropertyPanel.hxx |   35 +--
 sc/uiconfig/scalc/ui/sidebarnumberformat.ui|   59 +++---
 svx/UIConfig_svx.mk|1 
 svx/source/tbxctrls/tbcontrl.cxx   |  154 
 svx/uiconfig/ui/currencywindow.ui  |   95 ++
 vcl/unx/gtk3/gtk3gtkinst.cxx   |   54 +
 8 files changed, 447 insertions(+), 153 deletions(-)

New commits:
commit b199e335c01f265ba2604c020928b63356b42d15
Author: Caolán McNamara 
AuthorDate: Fri Dec 27 17:18:44 2019 +
Commit: Caolán McNamara 
CommitDate: Wed Jan 1 13:19:28 2020 +0100

weld NumberFormatPropertyPanel

including GtkMenuToolButton hackery to support a toggled state

Change-Id: Ia1cf5fd7d56c2e475194cd2d0431611f278f5a33
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85873
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/include/svx/tbcontrl.hxx b/include/svx/tbcontrl.hxx
index 9e6c387d2dda..315fd9e1c57e 100644
--- a/include/svx/tbcontrl.hxx
+++ b/include/svx/tbcontrl.hxx
@@ -264,6 +264,9 @@ private:
 OUString m_aFormatString;
 LanguageType m_eLanguage;
 sal_uInt32   m_nFormatKey;
+
+weld::Toolbar* m_pToolbar;
+std::unique_ptr m_xPopover;
 public:
 static void GetCurrencySymbols( std::vector& rList, bool bFlag,
 std::vector& rCurrencyList );
@@ -274,9 +277,14 @@ public:
 // XToolbarController
 virtual void SAL_CALL execute( sal_Int16 nSelectModifier ) override;
 
+// XComponent
+virtual void SAL_CALL dispose() override;
+
 using svt::ToolboxController::createPopupWindow;
 virtual VclPtr createPopupWindow( vcl::Window* pParent ) 
override;
 
+void EndPopupMode();
+
 // XServiceInfo
 virtual OUString SAL_CALL getImplementationName() override;
 virtual css::uno::Sequence SAL_CALL getSupportedServiceNames() 
override;
diff --git a/sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx 
b/sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx
index 7d8a8401ac84..a1d3c4eb7461 100644
--- a/sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx
+++ b/sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx
@@ -38,26 +38,25 @@ NumberFormatPropertyPanel::NumberFormatPropertyPanel(
 vcl::Window* pParent,
 const css::uno::Reference& rxFrame,
 SfxBindings* pBindings)
-  : PanelLayout(pParent,"NumberFormatPropertyPanel", 
"modules/scalc/ui/sidebarnumberformat.ui", rxFrame),
-maNumFormatControl(SID_NUMBER_TYPE_FORMAT, *pBindings, *this),
-maFormatControl(SID_NUMBER_FORMAT, *pBindings, *this),
-
-mnCategorySelected(0),
-maContext(),
-mpBindings(pBindings)
+: PanelLayout(pParent,"NumberFormatPropertyPanel", 
"modules/scalc/ui/sidebarnumberformat.ui", rxFrame, true)
+, mxLbCategory(m_xBuilder->weld_combo_box("category"))
+, mxTBCategory(m_xBuilder->weld_toolbar("numberformat"))
+, mxCatagoryDispatch(new ToolbarUnoDispatcher(*mxTBCategory, rxFrame))
+, mxFtDecimals(m_xBuilder->weld_label("decimalplaceslabel"))
+, mxEdDecimals(m_xBuilder->weld_spin_button("decimalplaces"))
+, mxFtDenominator(m_xBuilder->weld_label("denominatorplaceslabel"))
+, mxEdDenominator(m_xBuilder->weld_spin_button("denominatorplaces"))
+, mxFtLeadZeroes(m_xBuilder->weld_label("leadingzeroeslabel"))
+, mxEdLeadZeroes(m_xBuilder->weld_spin_button("leadingzeroes"))
+, mxBtnNegRed(m_xBuilder->weld_check_button("negativenumbersred"))
+, mxBtnThousand(m_xBuilder->weld_check_button("thousandseparator"))
+, mxBtnEngineering(m_xBuilder->weld_check_button("engineeringnotation"))
+, maNumFormatControl(SID_NUMBER_TYPE_FORMAT, *pBindings, *this)
+, maFormatControl(SID_NUMBER_FORMAT, *pBindings, *this)
+, mnCategorySelected(0)
+, maContext()
+, mpBindings(pBindings)
 {
-get(mpLbCategory, "category");
-get(mpTBCategory, "numberformat");
-get(mpFtDecimals, "decimalplaceslabel");
-get(mpEdDecimals, "decimalplaces");
-get(mpFtDenominator,  "denominatorplaceslabel");
-get(mpEdDenominator,  "denominatorplaces");
-get(mpFtLeadZeroes,   "leadingzeroeslabel");
-get(mpEdLeadZeroes,   "leadingzeroes");
-get(mpBtnNegRed,  "negativenumbersred");
-get(mpBtnThousand,"thousandseparator");
-get(mpBtnEngineering, "engineeringnotation");
-
 Initialize();
 }
 
@@ -68,17 +67,18 @@ NumberFormatPropertyPanel::~NumberFormatPropertyPanel()
 
 void NumberFormatPropertyPanel::dispose()
 {
-mpLbCategory.clear();
-mpTBCategory.clear();
-mpFtDecimals.clear();
-mpEdDecimals.clear();
-mpFtDenominator.clear();
-mpEdDenominator.clear();
-mpFtLeadZeroes.clear();
-mpEdLeadZeroes.clear();
-mpBtnNegRed.clear();
- 

Re: Cannot review Gerrit patch

[Thorsten Behrens]

Hey Chris,

Chris Sherlock wrote:
> Quick ping. Anyone able to assist?
> 
Not really - seems to work fine here, though not using the old UI.

Cheers,

-- Thorsten


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: basctl/source

[U-DESKTOP-8OSNV7RDrRobotto (via logerrit)]

 basctl/source/basicide/basides1.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 83955c30405b086fb9b753f2734827c63e951c91
Author: U-DESKTOP-8OSNV7R\DrRobotto 
AuthorDate: Tue Dec 31 18:35:10 2019 +0100
Commit: Tomaž Vajngerl 
CommitDate: Wed Jan 1 19:20:55 2020 +0100

tdf#126506 - Adjusted height margin of the tab bar

Adjusted the height margin of the tab bar in the Basic IDE in order
to reflect the new look of the TabBar from tdf#124572.

Change-Id: I4fadec983405b05c7330f762f4ed2e12d3a40d27
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86048
Reviewed-by: Tomaž Vajngerl 
Tested-by: Jenkins

diff --git a/basctl/source/basicide/basides1.cxx 
b/basctl/source/basicide/basides1.cxx
old mode 100644
new mode 100755
index 3e2b585ad320..79c809927fb2
--- a/basctl/source/basicide/basides1.cxx
+++ b/basctl/source/basicide/basides1.cxx
@@ -56,6 +56,8 @@
 #include 
 #include 
 
+constexpr sal_Int32 TAB_HEIGHT_MARGIN = 10;
+
 namespace basctl
 {
 
@@ -1329,7 +1331,7 @@ void Shell::AdjustPosSizePixel( const Point , const 
Size  )
 return;
 
 Size aTabBarSize;
-aTabBarSize.setHeight( 
GetViewFrame()->GetWindow().GetFont().GetFontHeight() + 4 );
+aTabBarSize.setHeight( 
GetViewFrame()->GetWindow().GetFont().GetFontHeight() + TAB_HEIGHT_MARGIN );
 aTabBarSize.setWidth( rSize.Width() );
 
 Size aSz( rSize );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: drawinglayer/source include/drawinglayer solenv/clang-format

[Tomaž Vajngerl (via logerrit)]

 drawinglayer/source/primitive2d/baseprimitive2d.cxx  |  666 ++-
 include/drawinglayer/primitive2d/baseprimitive2d.hxx |  540 ---
 solenv/clang-format/blacklist|2 
 3 files changed, 664 insertions(+), 544 deletions(-)

New commits:
commit a3569c7b89a7ddee06149ece91ce608b1252fa82
Author: Tomaž Vajngerl 
AuthorDate: Tue Dec 31 13:39:33 2019 +0100
Commit: Tomaž Vajngerl 
CommitDate: Wed Jan 1 20:58:56 2020 +0100

drawinglayer: clang-format BasePrimitive2D + remove from blacklist

No functional change was made, only formatting of the code.

The code was formatted with clang-format and moves the files
baseprimitve2d.{cxx,hxx} out of blacklist so it will be auto
formatted with every change from now on.

Change-Id: If49ec94f91e58825f7aa94dc54cff8374467aa30
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86078
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 
Tested-by: Tomaž Vajngerl 

diff --git a/drawinglayer/source/primitive2d/baseprimitive2d.cxx 
b/drawinglayer/source/primitive2d/baseprimitive2d.cxx
index 4db80991dd93..72b0f33734ee 100644
--- a/drawinglayer/source/primitive2d/baseprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/baseprimitive2d.cxx
@@ -28,349 +28,433 @@
 #include 
 #include 
 
-
 using namespace com::sun::star;
 
-
 namespace drawinglayer
 {
-namespace primitive2d
-{
-Primitive2DDecompositionVisitor::~Primitive2DDecompositionVisitor() {}
-
-BasePrimitive2D::BasePrimitive2D()
-:   BasePrimitive2DImplBase(m_aMutex)
-{
-}
-
-BasePrimitive2D::~BasePrimitive2D()
-{
-}
-
-bool BasePrimitive2D::operator==( const BasePrimitive2D& rPrimitive ) 
const
-{
-return (getPrimitive2DID() == rPrimitive.getPrimitive2DID());
-}
+namespace primitive2d
+{
+Primitive2DDecompositionVisitor::~Primitive2DDecompositionVisitor() {}
 
-namespace {
-
-// Visitor class to get the B2D range from a tree of 
Primitive2DReference's
-//
-class B2DRangeVisitor : public Primitive2DDecompositionVisitor {
-public:
-const geometry::ViewInformation2D& mrViewInformation;
-basegfx::B2DRange maRetval;
-B2DRangeVisitor(const geometry::ViewInformation2D& 
rViewInformation) : mrViewInformation(rViewInformation) {}
-virtual void append(const Primitive2DReference& r) override {
-maRetval.expand(getB2DRangeFromPrimitive2DReference(r, 
mrViewInformation));
-}
-virtual void append(const Primitive2DContainer& r) override {
-maRetval.expand(r.getB2DRange(mrViewInformation));
-}
-virtual void append(Primitive2DContainer&& r) override {
-maRetval.expand(r.getB2DRange(mrViewInformation));
-}
-};
+BasePrimitive2D::BasePrimitive2D()
+: BasePrimitive2DImplBase(m_aMutex)
+{
+}
 
-}
+BasePrimitive2D::~BasePrimitive2D() {}
 
-basegfx::B2DRange BasePrimitive2D::getB2DRange(const 
geometry::ViewInformation2D& rViewInformation) const
-{
-B2DRangeVisitor aVisitor(rViewInformation);
-get2DDecomposition(aVisitor, rViewInformation);
-return aVisitor.maRetval;
-}
+bool BasePrimitive2D::operator==(const BasePrimitive2D& rPrimitive) const
+{
+return (getPrimitive2DID() == rPrimitive.getPrimitive2DID());
+}
 
-void 
BasePrimitive2D::get2DDecomposition(Primitive2DDecompositionVisitor& 
/*rVisitor*/, const geometry::ViewInformation2D& /*rViewInformation*/) const
-{
-}
+namespace
+{
+// Visitor class to get the B2D range from a tree of Primitive2DReference's
+//
+class B2DRangeVisitor : public Primitive2DDecompositionVisitor
+{
+public:
+const geometry::ViewInformation2D& mrViewInformation;
+basegfx::B2DRange maRetval;
+B2DRangeVisitor(const geometry::ViewInformation2D& rViewInformation)
+: mrViewInformation(rViewInformation)
+{
+}
+virtual void append(const Primitive2DReference& r) override
+{
+maRetval.expand(getB2DRangeFromPrimitive2DReference(r, 
mrViewInformation));
+}
+virtual void append(const Primitive2DContainer& r) override
+{
+maRetval.expand(r.getB2DRange(mrViewInformation));
+}
+virtual void append(Primitive2DContainer&& r) override
+{
+maRetval.expand(r.getB2DRange(mrViewInformation));
+}
+};
+}
 
-css::uno::Sequence< ::css::uno::Reference< 
::css::graphic::XPrimitive2D > > SAL_CALL BasePrimitive2D::getDecomposition( 
const uno::Sequence< beans::PropertyValue >& rViewParameters )
-{
-const geometry::ViewInformation2D 
aViewInformation(rViewParameters);
-Primitive2DContainer aContainer;
-get2DDecomposition(aContainer, aViewInformation);
-return 

[Libreoffice-commits] core.git: cui/uiconfig

[Caolán McNamara (via logerrit)]

 cui/uiconfig/ui/lineendstabpage.ui  |3 +++
 cui/uiconfig/ui/linestyletabpage.ui |3 +++
 cui/uiconfig/ui/linetabpage.ui  |9 +
 3 files changed, 15 insertions(+)

New commits:
commit 4bee505eb9ddea8ffa2f6b9c846d0daaf3f7a11f
Author: Caolán McNamara 
AuthorDate: Wed Jan 1 18:52:11 2020 +
Commit: Caolán McNamara 
CommitDate: Wed Jan 1 21:18:44 2020 +0100

missing previews in line comboboxes

since...

commit 6cdc0dbfadfcbfa4f53a3c21a494ab225ba5d955
Date:   Tue Nov 5 01:53:23 2019 +0100

linetab dialog page update

and similar

Change-Id: Iafb2933434d76472bab7297962e0803a6568e61b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86076
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/uiconfig/ui/lineendstabpage.ui 
b/cui/uiconfig/ui/lineendstabpage.ui
index a602914fb9d4..136095571fd0 100644
--- a/cui/uiconfig/ui/lineendstabpage.ui
+++ b/cui/uiconfig/ui/lineendstabpage.ui
@@ -118,6 +118,9 @@
 
 
   
+  
+3
+  
 
   
   
diff --git a/cui/uiconfig/ui/linestyletabpage.ui 
b/cui/uiconfig/ui/linestyletabpage.ui
index 0ca67941ec1a..dd41b79750c3 100644
--- a/cui/uiconfig/ui/linestyletabpage.ui
+++ b/cui/uiconfig/ui/linestyletabpage.ui
@@ -293,6 +293,9 @@
 
 
   
+  
+3
+  
 
   
   
diff --git a/cui/uiconfig/ui/linetabpage.ui b/cui/uiconfig/ui/linetabpage.ui
index ab02246ef9b5..17fb192d2c70 100644
--- a/cui/uiconfig/ui/linetabpage.ui
+++ b/cui/uiconfig/ui/linetabpage.ui
@@ -191,6 +191,9 @@
 
 
   
+  
+3
+  
 
   
   
@@ -411,6 +414,9 @@
 
 
   
+  
+3
+  
 
   
   
@@ -523,6 +529,9 @@
 
 
   
+  
+3
+  
 
   
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: cui/source include/svx svx/source sw/source sw/uiconfig

[Caolán McNamara (via logerrit)]

 cui/source/tabpages/page.cxx |   13 -
 include/svx/dlgctrl.hxx  |5 
 include/svx/itemwin.hxx  |4 
 include/svx/pagenumberlistbox.hxx|5 
 svx/source/dialog/dlgctrl.cxx|   16 ++
 svx/source/tbxctrls/itemwin.cxx  |   76 ++
 sw/source/uibase/sidebar/PageStylesPanel.cxx |  194 +--
 sw/source/uibase/sidebar/PageStylesPanel.hxx |   32 ++--
 sw/uiconfig/swriter/ui/pagestylespanel.ui|  164 --
 9 files changed, 312 insertions(+), 197 deletions(-)

New commits:
commit 4a0d34fc4ec875d14d09156f7b4b3a51fb2f5e30
Author: Caolán McNamara 
AuthorDate: Wed Jan 1 17:28:23 2020 +
Commit: Caolán McNamara 
CommitDate: Wed Jan 1 22:30:10 2020 +0100

weld PageStylesPanel

Change-Id: I8e6842a342b242eeaa6d7a27e268dbe5691a9703
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86081
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/source/tabpages/page.cxx b/cui/source/tabpages/page.cxx
index c2592f0d944b..8cecd26a51c5 100644
--- a/cui/source/tabpages/page.cxx
+++ b/cui/source/tabpages/page.cxx
@@ -370,15 +370,7 @@ void SvxPageDescPage::Reset( const SfxItemSet* rSet )
 LayoutHdl_Impl( *m_xLayoutBox );
 
 //adjust numeration type of the page style
-//Get the Position of the saved NumType
-for (int i=0; i < m_xNumberFormatBox->get_count(); ++i)
-{
-if (eNumType == m_xNumberFormatBox->get_id(i).toInt32())
-{
-m_xNumberFormatBox->set_active(i);
-break;
-}
-}
+m_xNumberFormatBox->set_active_id(eNumType);
 
 m_xPaperTrayBox->clear();
 sal_uInt8 nPaperBin = PAPERBIN_PRINTER_SETTINGS;
@@ -689,10 +681,9 @@ bool SvxPageDescPage::FillItemSet( SfxItemSet* rSet )
 }
 
 //Get the NumType value
-nPos = m_xNumberFormatBox->get_active();
-SvxNumType nEntryData = 
static_cast(m_xNumberFormatBox->get_id(nPos).toInt32());
 if (m_xNumberFormatBox->get_value_changed_from_saved())
 {
+SvxNumType nEntryData = m_xNumberFormatBox->get_active_id();
 aPage.SetNumType( nEntryData );
 bMod = true;
 }
diff --git a/include/svx/dlgctrl.hxx b/include/svx/dlgctrl.hxx
index e68f881f8bce..eb7f19c79f91 100644
--- a/include/svx/dlgctrl.hxx
+++ b/include/svx/dlgctrl.hxx
@@ -215,11 +215,12 @@ public:
 
 class SAL_WARN_UNUSED SVX_DLLPUBLIC FillTypeLB : public ListBox
 {
-
 public:
- FillTypeLB( vcl::Window* pParent, WinBits aWB ) : ListBox( pParent, 
aWB ) {}
+FillTypeLB( vcl::Window* pParent, WinBits aWB ) : ListBox( pParent, aWB ) 
{}
 
 void Fill();
+
+static void Fill(weld::ComboBox& rListBox);
 };
 
 //
diff --git a/include/svx/itemwin.hxx b/include/svx/itemwin.hxx
index 13a63557f147..4f4c3ec140a0 100644
--- a/include/svx/itemwin.hxx
+++ b/include/svx/itemwin.hxx
@@ -112,6 +112,10 @@ public:
 void Fill( const XBitmapListRef);
 void Fill( const XPatternListRef   );
 
+static void Fill(weld::ComboBox&, const XHatchListRef );
+static void Fill(weld::ComboBox&, const XBitmapListRef );
+static void Fill(weld::ComboBox&, const XPatternListRef );
+
 private:
 virtual boolPreNotify( NotifyEvent& rNEvt ) override;
 virtual boolEventNotify( NotifyEvent& rNEvt ) override;
diff --git a/include/svx/pagenumberlistbox.hxx 
b/include/svx/pagenumberlistbox.hxx
index 16307c03e0a9..e416fcb8d507 100644
--- a/include/svx/pagenumberlistbox.hxx
+++ b/include/svx/pagenumberlistbox.hxx
@@ -20,6 +20,7 @@
 #ifndef INCLUDED_SVX_PAGENUMBERINGHELPER_HXX
 #define INCLUDED_SVX_PAGENUMBERINGHELPER_HXX
 
+#include 
 #include 
 #include 
 #include 
@@ -41,11 +42,13 @@ private:
 public:
 SvxPageNumberListBox(std::unique_ptr pControl);
 int get_count() const { return m_xControl->get_count(); }
-OUString get_id(int pos) const { return m_xControl->get_id(pos); }
+SvxNumType get_active_id() const { return 
static_cast(m_xControl->get_active_id().toInt32()); }
+void set_active_id(SvxNumType eId) const { 
m_xControl->set_active_id(OUString::number(static_cast(eId))); }
 int get_active() const { return m_xControl->get_active(); }
 void set_active(int pos) { m_xControl->set_active(pos); }
 void save_value() { m_xControl->save_value(); }
 bool get_value_changed_from_saved() const { return 
m_xControl->get_value_changed_from_saved(); }
+void connect_changed(const Link& rLink) { 
m_xControl->connect_changed(rLink); }
 weld::ComboBox& get_widget() const { return *m_xControl; }
 };
 
diff --git a/svx/source/dialog/dlgctrl.cxx b/svx/source/dialog/dlgctrl.cxx
index 7a9b7186a257..cb79d09cd6d2 100644
--- a/svx/source/dialog/dlgctrl.cxx
+++ b/svx/source/dialog/dlgctrl.cxx
@@ -915,6 +915,22 @@ void FillTypeLB::Fill()
 SetUpdateMode( true );
 }
 
+void 

[Libreoffice-commits] core.git: unotools/source

[Jan Holesovsky (via logerrit)]

 unotools/source/i18n/resmgr.cxx |8 
 1 file changed, 8 insertions(+)

New commits:
commit beb758215b898dcb2605c4d5bebbd736aa1e493d
Author: Jan Holesovsky 
AuthorDate: Wed Dec 18 23:07:11 2019 +0100
Commit: Michael Meeks 
CommitDate: Wed Jan 1 23:43:24 2020 +0100

android: Use correct path for the .mo resource files.

They are read by boost::locale, so we cannot have them as normal assets,
instead we have to have them in asset's 'unpack', so that they are
unpacked to the filesystem and can be read as normal files.

Change-Id: I5e902ee4b5294d1f693f51993b8bc2069f1c835a
Reviewed-on: https://gerrit.libreoffice.org/85442
Reviewed-by: Michael Meeks 
Tested-by: Jenkins CollaboraOffice 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85458
Tested-by: Michael Meeks 

diff --git a/unotools/source/i18n/resmgr.cxx b/unotools/source/i18n/resmgr.cxx
index 4e899aa9ea26..df5283d71292 100644
--- a/unotools/source/i18n/resmgr.cxx
+++ b/unotools/source/i18n/resmgr.cxx
@@ -51,6 +51,10 @@
 #include 
 #include 
 
+#ifdef ANDROID
+#include 
+#endif
+
 #if defined(_WIN32) && defined(DBG_UTIL)
 #include 
 #include 
@@ -123,11 +127,15 @@ namespace Translate
 boost::locale::generator gen;
 gen.characters(boost::locale::char_facet);
 gen.categories(boost::locale::message_facet | 
boost::locale::information_facet);
+#if defined(ANDROID)
+OString sPath(OString(lo_get_app_data_dir()) + "/program/resource");
+#else
 OUString uri("$BRAND_BASE_DIR/$BRAND_SHARE_RESOURCE_SUBDIR/");
 rtl::Bootstrap::expandMacros(uri);
 OUString path;
 osl::File::getSystemPathFromFileURL(uri, path);
 OString sPath(OUStringToOString(path, osl_getThreadTextEncoding()));
+#endif
 gen.add_messages_path(sPath.getStr());
 #if defined UNX && !defined MACOSX && !defined IOS && !defined ANDROID
 bindtextdomain(pPrefixName, sPath.getStr());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: extras/source

[Laurent BP (via logerrit)]

 extras/source/templates/presnt/DNA/styles.xml |   50 +--
 extras/source/templates/presnt/Focus/styles.xml   |  120 
 extras/source/templates/presnt/Forestbird/styles.xml  |  130 -
 extras/source/templates/presnt/Impress/styles.xml |   88 +++---
 extras/source/templates/presnt/Inspiration/styles.xml |   60 ++--
 extras/source/templates/presnt/Lights/styles.xml  |  106 +++
 extras/source/templates/presnt/LushGreen/content.xml  |2 
 extras/source/templates/presnt/LushGreen/styles.xml   |  130 -
 extras/source/templates/presnt/Metropolis/styles.xml  |   72 ++---
 extras/source/templates/presnt/Midnightblue/styles.xml|  128 -
 extras/source/templates/presnt/Nature_Illustration/styles.xml |   82 ++---
 extras/source/templates/presnt/Pencil/styles.xml  |   84 +++---
 extras/source/templates/presnt/Piano/styles.xml   |   82 ++---
 extras/source/templates/presnt/Portfolio/styles.xml   |  106 +++
 extras/source/templates/presnt/Sunset/content.xml |2 
 extras/source/templates/presnt/Sunset/styles.xml  |   60 ++--
 extras/source/templates/presnt/Vintage/content.xml|4 
 extras/source/templates/presnt/Vintage/styles.xml |  140 +-
 extras/source/templates/presnt/Vivid/content.xml  |4 
 extras/source/templates/presnt/Vivid/styles.xml   |  110 +++
 20 files changed, 780 insertions(+), 780 deletions(-)

New commits:
commit fcf1e5b44429ce639cdd0f10def92a9d1822a0b1
Author: Laurent BP 
AuthorDate: Wed Jan 1 18:12:32 2020 +0100
Commit: Laurent BP 
CommitDate: Wed Jan 1 19:13:32 2020 +0100

tdf#114746 Restore asian and complex tags in templates

Manually add tags to fix size, bold and italic:
style:font-size-asian
style:font-size-complex
style:font-style-asian
style:font-style-complex
style:font-weight-asian
style:font-weight-complex

to Impress templates

Change-Id: Ib1b3995721cd8aa723784e920df9d1e109632961
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86073
Tested-by: Jenkins
Reviewed-by: Laurent BP 

diff --git a/extras/source/templates/presnt/DNA/styles.xml 
b/extras/source/templates/presnt/DNA/styles.xml
index 7c633ee78847..261af83a1da7 100644
--- a/extras/source/templates/presnt/DNA/styles.xml
+++ b/extras/source/templates/presnt/DNA/styles.xml
@@ -11,7 +11,7 @@
   
 
   
-  
+  
 
 
   
@@ -59,7 +59,7 @@
 
   
   
-  
+  
 
 
   
@@ -75,7 +75,7 @@
 
 
   
-  
+  
 
 
   
@@ -87,36 +87,36 @@
 
 
   
-  
+  
 
 
   
   
-  
+  
 
 
   
   
-  
+  
 
 
   
   
-  
+  
 
 
   
   
-  
+  
 
 
   
   
-  
+  
 
 
   
-  
+  
 
 
   
@@ -125,12 +125,12 @@
 
   
   
-  
+  
 
 
   
   
-  
+  
 
 
   
@@ -178,19 +178,19 @@
 
   
   
-  
+  
 
 
   
-  
+  
 
 
   
-  
+  
 
 
   
-  
+  
 
 
   
@@ -253,7 +253,7 @@
 
   
   
-  
+  
 
 
   
@@ -301,7 +301,7 @@
 
   
   
-  
+  
 
 
   
@@ -348,20 +348,20 @@
   
 
 
-  
+  
 
 
   
-  
+  
 
 
   
-  
+  
 
 
   
   
-  
+  
 
 
   
@@ -370,13 +370,13 @@
 
   
   
-  
+  
 
 
-  
+  
 
 
-  
+  
 
 
   
diff --git a/extras/source/templates/presnt/Focus/styles.xml 
b/extras/source/templates/presnt/Focus/styles.xml
index 1bdda8e48a60..3310960edc4e 100644
--- a/extras/source/templates/presnt/Focus/styles.xml
+++ b/extras/source/templates/presnt/Focus/styles.xml
@@ -13,7 +13,7 @@
   
 
   
-  
+  
 
 
   
@@ -61,7 +61,7 @@
 
   
   
-  
+  
 
 
   
@@ -77,7 +77,7 @@
 
 
   
-  
+  
 
 
   
@@ -89,36 +89,36 @@
 
 
   
-  
+  
 
 
   
   
-  
+  
 
 
   
   
-  
+  
 
 
   
   
-  
+  
 
 
   
   
-  
+  
 
 
   
   
-  
+  
 
 
   
-  
+  
 
 
   
@@ -126,12 +126,12 @@
 
 
   
-  
+  
 
 
   
   
-  
+  
 
 
   
@@ -181,7 +181,7 @@
   
 
   
-  
+  
 
 
   
@@ -265,7 +265,7 @@
 
   
   
-  
+  
 
 
 

[Libreoffice-commits] core.git: basic/source sc/CppunitTest_sc_macros_test.mk sc/qa

[Mike Kaganski (via logerrit)]

 basic/source/classes/image.cxx  |   54 +---
 basic/source/inc/filefmt.hxx|2 
 sc/CppunitTest_sc_macros_test.mk|   47 -
 sc/qa/extras/macros-test.cxx|   84 +++-
 sc/qa/extras/testdocuments/tdf57113.ods |binary
 5 files changed, 133 insertions(+), 54 deletions(-)

New commits:
commit 4abb191916916c7003deedcfdcf46287faccaf01
Author: Mike Kaganski 
AuthorDate: Wed Jan 1 13:54:05 2020 +0300
Commit: Mike Kaganski 
CommitDate: Wed Jan 1 19:21:50 2020 +0100

tdf#57113: store UTF-16 stringpool data after legacy 1-byte data

This allows to correctly store and read Unicode strings used in
password-protected libraries. The additional data stored after all
legacy data of the stringpool record (after a magic number to mark
its presence), and so is invisible for older versions of program:
this allows to keep the version of data and backward compatibility.
Of course, older versions will only see legacy data, with broken
Unicode strings; and password-protected libraries edited and saved
in older versions will not contain Unicode data.

read_uInt16s_ToOUString and write_uInt16s_FromOUString are used
for correct handling of UTF-16 strings on LE/BE systems.

Change-Id: I990bc27b5cc7d499e71c43d45b7f263af41911e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86065
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/basic/source/classes/image.cxx b/basic/source/classes/image.cxx
index fc2cbf0b154c..959681636dcd 100644
--- a/basic/source/classes/image.cxx
+++ b/basic/source/classes/image.cxx
@@ -90,6 +90,27 @@ static void SbiCloseRecord( SvStream& r, sal_uInt64 nOff )
 r.Seek( nPos );
 }
 
+static constexpr sal_uInt32 nUnicodeDataMagicNumber = 0x556E6920; // "Uni " BE
+
+static bool GetToUnicodePoolData(SvStream& r, sal_uInt64 nLen, sal_uInt64 
nNext)
+{
+const auto nPos = r.Tell();
+// Check space for legacy data, magic number and Unicode data
+bool bResult = nPos + nLen + sizeof(sal_uInt32) + nLen * 
sizeof(sal_Unicode) <= nNext;
+if (bResult)
+{
+r.SeekRel(nLen); // Skip legacy data
+sal_uInt32 nMagic = 0;
+r.ReadUInt32(nMagic);
+if (nMagic != nUnicodeDataMagicNumber)
+{
+r.Seek(nPos); // return
+bResult = false;
+}
+}
+return bResult;
+}
+
 bool SbiImage::Load( SvStream& r, sal_uInt32& nVersion )
 {
 
@@ -189,6 +210,11 @@ bool SbiImage::Load( SvStream& r, sal_uInt32& nVersion )
 break;
 case FileOffset::StringPool:
 {
+// the data layout is: nCount of 32-bit offsets into both 
legacy 1-byte char stream
+// and resulting char buffer (1:1 correspondence assumed; 16 
of 32 bits used);
+// 32-bit length N of following 1-byte char stream (16 bits 
used); N bytes of 1-byte
+// char stream; then optional magic number and stream of N 
sal_Unicode characters.
+
 if( bBadVer ) break;
 //assuming an empty string with just the lead 32bit len 
indicator
 const sal_uInt64 nMinStringSize = 4;
@@ -211,13 +237,21 @@ bool SbiImage::Load( SvStream& r, sal_uInt32& nVersion )
 pStrings.reset(new sal_Unicode[ nLen ]);
 nStringSize = static_cast(nLen);
 
-std::unique_ptr pByteStrings(new char[ nLen ]);
-r.ReadBytes(pByteStrings.get(), nStringSize);
-for( size_t j = 0; j < mvStringOffsets.size(); j++ )
+if (GetToUnicodePoolData(r, nLen, nNext))
 {
-sal_uInt16 nOff2 = 
static_cast(mvStringOffsets[ j ]);
-OUString aStr( pByteStrings.get() + nOff2, 
strlen(pByteStrings.get() + nOff2), eCharSet );
-memcpy( pStrings.get() + nOff2, aStr.getStr(), 
(aStr.getLength() + 1) * sizeof( sal_Unicode ) );
+OUString s = read_uInt16s_ToOUString(r, nLen);
+memcpy(pStrings.get(), s.getStr(), s.getLength() * 
sizeof(sal_Unicode));
+}
+else
+{
+std::unique_ptr pByteStrings(new char[nLen]);
+r.ReadBytes(pByteStrings.get(), nLen);
+for (size_t j = 0; j < mvStringOffsets.size(); j++)
+{
+sal_uInt16 nOff2 = 
static_cast(mvStringOffsets[j]);
+OUString aStr(pByteStrings.get() + nOff2, 
strlen(pByteStrings.get() + nOff2), eCharSet);
+memcpy(pStrings.get() + nOff2, aStr.getStr(), 
(aStr.getLength() + 1) * sizeof(sal_Unicode));
+}
 }
 }
 break;
@@ -435,8 +469,14 @@ 

[Libreoffice-commits] core.git: basctl/source

[Andrea Gelmini (via logerrit)]

 0 files changed

New commits:
commit 98bdce2ce881fc8795a3de5068c56e5ed42475f9
Author: Andrea Gelmini 
AuthorDate: Wed Jan 1 21:52:21 2020 +0100
Commit: Julien Nabet 
CommitDate: Wed Jan 1 21:53:49 2020 +0100

Removed executable permission on file

Change-Id: Id84b58da363210a3ff54aacebfcfc5c3ead3f5be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86085
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/basctl/source/basicide/basides1.cxx 
b/basctl/source/basicide/basides1.cxx
old mode 100755
new mode 100644
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: solenv/bin

[Michael Meeks (via logerrit)]

 solenv/bin/native-code.py |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 0189b87349f0589cb2e85897ef83c67b331024f0
Author: Michael Meeks 
AuthorDate: Thu Dec 19 11:09:02 2019 +
Commit: Michael Meeks 
CommitDate: Wed Jan 1 23:41:56 2020 +0100

mobile: add missing chart & calc sidebar panels.

Amazing that these were missing.

Change-Id: Ic5f22dfa80169630badd5834632b8632922cd04b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86087
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 

diff --git a/solenv/bin/native-code.py b/solenv/bin/native-code.py
index 6cf959234563..adb71e6e3bc3 100755
--- a/solenv/bin/native-code.py
+++ b/solenv/bin/native-code.py
@@ -124,6 +124,7 @@ core_constructor_list = [
 "com_sun_star_comp_chart2_ChartDocumentWrapper_get_implementation",
 "com_sun_star_comp_chart2_ChartFrameLoader_get_implementation",
 "com_sun_star_comp_chart2_WizardDialog_get_implementation",
+"org_libreoffice_comp_chart2_sidebar_ChartPanelFactory",
 # comphelper/util/comphelp.component
 "com_sun_star_comp_MemoryStream",
 "com_sun_star_comp_task_OfficeRestartManager",
@@ -387,6 +388,8 @@ calc_factory_list = [
 calc_constructor_list = [
 # avmedia/util/avmedia.component
 "com_sun_star_comp_framework_SoundHandler_get_implementation",
+# sc/util/sc.component
+"ScPanelFactory_get_implementation",
 # sc/util/scd.component
 "com_sun_star_comp_calc_ExcelBiffFormatDetector_get_implementation",
 "com_sun_star_comp_calc_FormatDetector_get_implementation",
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/headless

[Jan Holesovsky (via logerrit)]

 vcl/headless/svpgdi.cxx |8 
 1 file changed, 8 insertions(+)

New commits:
commit 736c330308e117a6536ef111fa09293c6ba0d2d8
Author: Jan Holesovsky 
AuthorDate: Fri Dec 20 15:27:50 2019 +0100
Commit: Michael Meeks 
CommitDate: Wed Jan 1 23:42:25 2020 +0100

android: Make the Calc input bar working on the Android device too.

Thanks to Marco Ceccheti! - he's found what was wrong there.

Change-Id: I45500f7f55ced60965a42ad6cb8032481594b409
Reviewed-on: https://gerrit.libreoffice.org/85612
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86089
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 

diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index 7554ab1337ed..1bd55104c491 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -2170,14 +2170,21 @@ bool 
SvpSalGraphics::supportsOperation(OutDevSupportType eType) const
 
 void dl_cairo_surface_set_device_scale(cairo_surface_t *surface, double 
x_scale, double y_scale)
 {
+#ifdef ANDROID
+cairo_surface_set_device_scale(surface, x_scale, y_scale);
+#else
 static auto func = reinterpret_cast(
 dlsym(nullptr, "cairo_surface_set_device_scale"));
 if (func)
 func(surface, x_scale, y_scale);
+#endif
 }
 
 void dl_cairo_surface_get_device_scale(cairo_surface_t *surface, double* 
x_scale, double* y_scale)
 {
+#ifdef ANDROID
+cairo_surface_get_device_scale(surface, x_scale, y_scale);
+#else
 static auto func = reinterpret_cast(
 dlsym(nullptr, "cairo_surface_get_device_scale"));
 if (func)
@@ -2189,6 +2196,7 @@ void dl_cairo_surface_get_device_scale(cairo_surface_t 
*surface, double* x_scale
 if (y_scale)
 *y_scale = 1.0;
 }
+#endif
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Duplicate .uno commands

[Kaganski Mike]

Hi!

In tdf#129549 [1], two .uno commands were identified as duplicating: 
.uno:BulletsAndNumberingDialog and .uno:OutlineBullet. First of them is 
Writer-specific [2]; second is not [3].

In Writer, both of them are routed to SwTextShell::ExecEnterNum, and 
handled identically (in the same switch case), opening the bullets and 
numbering dialog.

They have identical UI names ("Bullets and Numbering"); similar (but not 
identical) icons (see [4] for screenshot of them side by side using 
Colibre icon set); and they both are used in Writer's UI: 
.uno:BulletsAndNumberingDialog in main menu [5], .uno:OutlineBullet in 
context menu [6].

The problem with this, besides duplication itself (including e.g. 
drawing icons), is that both of them appear in customization dialog, and 
that's confusing. Having two elements in customization dialog with same 
name, but different operation, as often happening, is already bad enough 
(user has to experiment to find the one that is needed; that was handled 
partially in tdf#108458); but having two totally identical elements is 
too much IMO. Users would struggle to find the difference; and anyway 
assume they just didn't find the scenario where they act differently.

The question is: how to handle this? I suppose that one of them 
(.uno:BulletsAndNumberingDialog) should be deprecated and hidden from 
the customization UI, and its uses replaced with the other. I suppose we 
can't drop it completely for compatibility reasons (might it be used in 
user code?).

So is there something I miss about these two commands behaving 
identically? Might there be a reason to keep it as is? and is there an 
existing mechanism to hide some .uno commands from the customization UI?

[1] https://bugs.documentfoundation.org/show_bug.cgi?id=129549
[2] 
https://opengrok.libreoffice.org/xref/core/sw/sdi/swriter.sdi?r=7efae60f#452
[3] 
https://opengrok.libreoffice.org/xref/core/svx/sdi/svx.sdi?r=ef6e2b50#5897
[4] https://i.imgur.com/tTAMjDb.png
[5] 
https://opengrok.libreoffice.org/search?project=core=%22uno%3ABulletsAndNumberingDialog%22
[6] 
https://opengrok.libreoffice.org/search?project=core=%22uno%3AOutlineBullet%22
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: include/xmloff xmloff/inc xmloff/source

[Tamas Bunth (via logerrit)]

 include/xmloff/xmltoken.hxx   |1 
 xmloff/inc/SchXMLImport.hxx   |1 
 xmloff/source/chart/SchXMLExport.cxx  |   55 --
 xmloff/source/chart/SchXMLImport.cxx  |1 
 xmloff/source/chart/SchXMLPlotAreaContext.cxx |  100 ++
 xmloff/source/chart/SchXMLPlotAreaContext.hxx |   47 +++-
 xmloff/source/chart/SchXMLSeries2Context.cxx  |   18 ++--
 xmloff/source/chart/transporttypes.hxx|7 +
 xmloff/source/core/xmltoken.cxx   |1 
 xmloff/source/token/tokens.txt|1 
 10 files changed, 186 insertions(+), 46 deletions(-)

New commits:
commit 7d2c7e7af04d9604d86d2d605ef95b9abb10966c
Author: Tamas Bunth 
AuthorDate: Wed Dec 18 13:08:11 2019 +0100
Commit: Tamás Bunth 
CommitDate: Wed Jan 1 17:35:50 2020 +0100

tdf#123206 Store custom label as chart:data-label

Use the chart:data-label element instead of using the
loext:custom-label-field attribute.

chart:data-label stores can be a child of chart:data-point and it may
contain a text:o element for holding one or more paragraphs of custom
label text.

This commit aims to export and import chart:data-label with paragraphs
put into different text:span elements. These span elements may hold a
text:style-name attribute in order to achieve formatted text.

This structure is already in the ODF format.

Change-Id: I0bea7ce1a16af9c47b33555e18545bdaae7e95ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85659
Tested-by: Jenkins
Reviewed-by: Tamás Bunth 

diff --git a/include/xmloff/xmltoken.hxx b/include/xmloff/xmltoken.hxx
index 02bd9702d980..1175958548ff 100644
--- a/include/xmloff/xmltoken.hxx
+++ b/include/xmloff/xmltoken.hxx
@@ -551,6 +551,7 @@ namespace xmloff { namespace token {
 XML_DATA_BAR,
 XML_DATA_BAR_ENTRY,
 XML_DATA_CELL_RANGE_ADDRESS,
+XML_DATA_LABEL,
 XML_DATA_LABEL_NUMBER,
 XML_DATA_LABEL_SYMBOL,
 XML_DATA_LABEL_TEXT,
diff --git a/xmloff/inc/SchXMLImport.hxx b/xmloff/inc/SchXMLImport.hxx
index 51aec6dc5c46..2a1080bf1eec 100644
--- a/xmloff/inc/SchXMLImport.hxx
+++ b/xmloff/inc/SchXMLImport.hxx
@@ -73,6 +73,7 @@ enum SchXMLPlotAreaElemTokenMap
 enum SchXMLSeriesElemTokenMap
 {
 XML_TOK_SERIES_DATA_POINT,
+XML_TOK_SERIES_DATA_LABEL,
 XML_TOK_SERIES_DOMAIN,
 XML_TOK_SERIES_MEAN_VALUE_LINE,
 XML_TOK_SERIES_REGRESSION_CURVE,
diff --git a/xmloff/source/chart/SchXMLExport.cxx 
b/xmloff/source/chart/SchXMLExport.cxx
index 25ec8022bf70..b3d18c7c758c 100644
--- a/xmloff/source/chart/SchXMLExport.cxx
+++ b/xmloff/source/chart/SchXMLExport.cxx
@@ -113,11 +113,13 @@ using ::std::vector;
 
 namespace
 {
+using CustomLabelSeq = 
Sequence>;
+
 struct SchXMLDataPointStruct
 {
 OUString   maStyleName;
 sal_Int32  mnRepeat;
-OUString   msCustomLabelText;
+CustomLabelSeq   mCustomLabelText;
 
 SchXMLDataPointStruct() : mnRepeat( 1 ) {}
 };
@@ -225,6 +227,8 @@ public:
 const css::uno::Reference< css::chart2::XDiagram > & xDiagram,
 bool bExportContent );
 
+void exportCustomLabel(const CustomLabelSeq & xCustomLabel);
+
 void exportRegressionCurve(
 const css::uno::Reference& xSeries,
 const css::awt::Size& rPageSize,
@@ -273,31 +277,26 @@ public:
 namespace
 {
 
-OUString lcl_getCustomLabelField(sal_Int32 nDataPointIndex,
+CustomLabelSeq lcl_getCustomLabelField(sal_Int32 nDataPointIndex,
 const uno::Reference< chart2::XDataSeries >& rSeries)
 {
 if( !rSeries.is() )
-return OUString{};
+return CustomLabelSeq();
 
 const SvtSaveOptions::ODFDefaultVersion nCurrentODFVersion( 
SvtSaveOptions().GetODFDefaultVersion() );
 if( nCurrentODFVersion <= SvtSaveOptions::ODFVER_012 )//do not export to 
ODF 1.2 or older
-return OUString{};
+return CustomLabelSeq();
 
-// export custom label text
 if(Reference xLabels = 
rSeries->getDataPointByIndex(nDataPointIndex); xLabels.is())
 {
 if(Any aAny = xLabels->getPropertyValue("CustomLabelFields"); 
aAny.hasValue())
 {
 Sequence> 
aCustomLabels;
 aAny >>= aCustomLabels;
-OUString sLabel;
-// TODO export formatted string instead of simple characters
-for(auto& aLabel : aCustomLabels)
-sLabel += aLabel->getString();
-return sLabel;
+return aCustomLabels;
 }
 }
-return OUString{};
+return CustomLabelSeq();
 }
 
 class lcl_MatchesRole
@@ -3261,7 +3260,7 @@ void SchXMLExportHelper_Impl::exportDataPoints(
 SchXMLDataPointStruct aPoint;
 aPoint.maStyleName = maAutoStyleNameQueue.front();
 if(bExportNumFmt)
-aPoint.msCustomLabelText = 

[Libreoffice-commits] core.git: chart2/source offapi/com oox/source

[Tamas Bunth (via logerrit)]

 chart2/source/view/charttypes/VSeriesPlotter.cxx |5 +
 offapi/com/sun/star/chart2/DataPointCustomLabelFieldType.idl |5 +++--
 oox/source/drawingml/chart/seriesconverter.cxx   |2 ++
 3 files changed, 10 insertions(+), 2 deletions(-)

New commits:
commit fa0df1035bbede2ad93b08366abb1d7a508bd3d6
Author: Tamas Bunth 
AuthorDate: Wed Jan 1 15:31:40 2020 +0100
Commit: Tamás Bunth 
CommitDate: Wed Jan 1 17:36:04 2020 +0100

tdf#125444 Percentage as custom chart label

Support importing ooxml charts with a field of type "PERCENTAGE" as
custom label.

Change-Id: Ie8931f77e3b6199d98635422d11d776e675f6e5c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86067
Tested-by: Jenkins
Reviewed-by: Tamás Bunth 

diff --git a/chart2/source/view/charttypes/VSeriesPlotter.cxx 
b/chart2/source/view/charttypes/VSeriesPlotter.cxx
index 2a814e2fd73a..8189ece987e9 100644
--- a/chart2/source/view/charttypes/VSeriesPlotter.cxx
+++ b/chart2/source/view/charttypes/VSeriesPlotter.cxx
@@ -528,6 +528,11 @@ uno::Reference< drawing::XShape > 
VSeriesPlotter::createDataLabel( const uno::Re
 aTextList[i] = DataSeriesHelper::getDataSeriesLabel( 
xSeries, aRole );
 break;
 }
+case DataPointCustomLabelFieldType_PERCENTAGE:
+{
+aTextList[i] = getLabelTextForValue( rDataSeries, 
nPointIndex, fValue, true );
+break;
+}
 case DataPointCustomLabelFieldType_CELLREF:
 {
 // TODO: for now doesn't show placeholder
diff --git a/offapi/com/sun/star/chart2/DataPointCustomLabelFieldType.idl 
b/offapi/com/sun/star/chart2/DataPointCustomLabelFieldType.idl
index 0b7f925342a6..05c26a738684 100644
--- a/offapi/com/sun/star/chart2/DataPointCustomLabelFieldType.idl
+++ b/offapi/com/sun/star/chart2/DataPointCustomLabelFieldType.idl
@@ -23,11 +23,12 @@ enum DataPointCustomLabelFieldType
 SERIESNAME,
 CATEGORYNAME,
 CELLREF,
-NEWLINE
+NEWLINE,
+PERCENTAGE
 };
 
 }; }; }; };
 
 #endif
 
-/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
\ No newline at end of file
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/oox/source/drawingml/chart/seriesconverter.cxx 
b/oox/source/drawingml/chart/seriesconverter.cxx
index a310549e0535..10edab47fd11 100644
--- a/oox/source/drawingml/chart/seriesconverter.cxx
+++ b/oox/source/drawingml/chart/seriesconverter.cxx
@@ -245,6 +245,8 @@ DataPointCustomLabelFieldType 
lcl_ConvertFieldNameToFieldEnum( const OUString& r
 return 
DataPointCustomLabelFieldType::DataPointCustomLabelFieldType_CATEGORYNAME;
 else if (rField == "CELLREF")
 return 
DataPointCustomLabelFieldType::DataPointCustomLabelFieldType_CELLREF;
+else if (rField == "PERCENTAGE")
+return 
DataPointCustomLabelFieldType::DataPointCustomLabelFieldType_PERCENTAGE;
 else
 return 
DataPointCustomLabelFieldType::DataPointCustomLabelFieldType_TEXT;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: compilerplugins/LICENSE.TXT cui/inc odk/docs odk/examples odk/index.html odk/index_online.html readlicense_oo/license setup_native/source sfx2/uiconfig

[Adolfo Jayme Barrientos (via logerrit)]

 compilerplugins/LICENSE.TXT   |2 
 cui/inc/strings.hrc   |2 
 odk/docs/install.html |2 
 odk/docs/tools.html   |2 
 odk/examples/DevelopersGuide/examples.html|2 
 odk/examples/examples.html|2 
 odk/index.html|2 
 odk/index_online.html |2 
 readlicense_oo/license/license.xml|2 
 setup_native/source/packinfo/packinfo_brand.txt   |   16 +-
 setup_native/source/packinfo/packinfo_extensions.txt  |8 -
 setup_native/source/packinfo/packinfo_office.txt  |  118 +-
 setup_native/source/packinfo/packinfo_office_help.txt |2 
 setup_native/source/packinfo/packinfo_office_lang.txt |   20 +--
 setup_native/source/packinfo/packinfo_sdkoo.txt   |2 
 setup_native/source/packinfo/packinfo_ure.txt |4 
 sfx2/uiconfig/ui/licensedialog.ui |2 
 17 files changed, 95 insertions(+), 95 deletions(-)

New commits:
commit a526e85a0d6371781482a9b7de4e05b8b2578de2
Author: Adolfo Jayme Barrientos 
AuthorDate: Wed Jan 1 23:22:03 2020 -0600
Commit: Adolfo Jayme Barrientos 
CommitDate: Thu Jan 2 07:05:24 2020 +0100

Bump copyright year to 2020

Change-Id: I6fb736591f32907c8977fbac8fbf1dcbaef1bb97
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86092
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/compilerplugins/LICENSE.TXT b/compilerplugins/LICENSE.TXT
index d3bf81a9d1c4..88b93d448864 100644
--- a/compilerplugins/LICENSE.TXT
+++ b/compilerplugins/LICENSE.TXT
@@ -1,7 +1,7 @@
 University of Illinois/NCSA
 Open Source License
 
-Copyright (c) 2012-2019 The Document Foundation
+Copyright (c) 2012-2020 The Document Foundation
 All rights reserved.
 
 Developed by:
diff --git a/cui/inc/strings.hrc b/cui/inc/strings.hrc
index 3169862f2e54..099174d752cf 100644
--- a/cui/inc/strings.hrc
+++ b/cui/inc/strings.hrc
@@ -382,7 +382,7 @@
 #define RID_SVXSTR_CANNOTCONVERTURL_ERR 
NC_("RID_SVXSTR_CANNOTCONVERTURL_ERR", "The URL <%1> cannot be converted to a 
filesystem path.")
 
 #define RID_SVXSTR_ABOUT_VERSION
NC_("aboutdialog|textbuffer1", "Version: 
%ABOUTBOXPRODUCTVERSION%ABOUTBOXPRODUCTVERSIONSUFFIX")
-#define RID_SVXSTR_ABOUT_COPYRIGHT  
NC_("aboutdialog|copyright", "Copyright © 2000–2019 LibreOffice contributors.")
+#define RID_SVXSTR_ABOUT_COPYRIGHT  
NC_("aboutdialog|copyright", "Copyright © 2000–2020 LibreOffice contributors.")
 #define RID_SVXSTR_ABOUT_CREDITS_URLNC_("aboutdialog|link", 
"https://www.libreoffice.org/about-us/credits/;)
 #define RID_SVXSTR_ABOUT_BUILDIDNC_("aboutdialog|buildid", 
"Build ID: $BUILDID")
 #define RID_SVXSTR_ABOUT_VENDOR NC_("aboutdialog|vendor", 
"This release was supplied by %OOOVENDOR.")
diff --git a/odk/docs/install.html b/odk/docs/install.html
index eef4cbfe7833..4b94f7fd564c 100644
--- a/odk/docs/install.html
+++ b/odk/docs/install.html
@@ -538,7 +538,7 @@
 
 
   
-Copyright © 2000–2019 LibreOffice contributors. All rights
+Copyright © 2000–2020 LibreOffice contributors. All rights
   reserved.
   LibreOffice was created by The Document Foundation, based on
   Apache OpenOffice, which is Copyright 2011 The Apache Software
diff --git a/odk/docs/tools.html b/odk/docs/tools.html
index 646ca80c1c4e..1e1769c8761c 100644
--- a/odk/docs/tools.html
+++ b/odk/docs/tools.html
@@ -911,7 +911,7 @@ types the specified types depend on.
 
 
 
-Copyright © 2000–2019 LibreOffice contributors. 
All rights reserved.
+Copyright © 2000–2020 LibreOffice contributors. 
All rights reserved.
 
 LibreOffice was created by The Document Foundation,
 based on Apache OpenOffice, which is Copyright 
2011,
diff --git a/odk/examples/DevelopersGuide/examples.html 
b/odk/examples/DevelopersGuide/examples.html
index 9d11058c531f..252366025f8c 100644
--- a/odk/examples/DevelopersGuide/examples.html
+++ b/odk/examples/DevelopersGuide/examples.html
@@ -2856,7 +2856,7 @@ for the Office application.
 
 
 
-Copyright © 2000–2019 LibreOffice contributors. 
All rights reserved.
+Copyright © 2000–2020 LibreOffice contributors. 
All rights reserved.
 
 LibreOffice was created by The Document Foundation,
 based on Apache OpenOffice, which is 

Using SourceTrail as additional explorer tool detection

[William Gathoye (LibreOffice)]

Hello everyone,

By spending most of my LibreOffice time on Twitter for the LibreOfficeFR
twitter account, I noticed quite a few sponsored tweets for a recent
code explorer tool called SourceTrail.

Regis [1], from the LibreOfficeFR community, mentioned this tool as well.

Could we see in SourceTrail a more recent alternative to our OpenGrok
instance? Is this a tool we can recommend newcomers to use to get to
know the LibreOffice source code?

Regards,

[1] https://twitter.com/regmoi/status/1209959677183827968

-- 
William Gathoye
Hypertive volunteer for LibreOffice
Proud member of The Document Foundation
Member of LaMouette - French based association promoting ODF and LibreOffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 117684] soffice.bin uses 100% CPU -- resolves when 'saving' document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117684

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 OS|Linux (All) |All
 Status|RESOLVED|REOPENED
 Resolution|INSUFFICIENTDATA|---
 CC||sdc.bla...@youmail.dk

--- Comment #12 from sdc.bla...@youmail.dk ---
Have experienced similar situations in Windows 10, at least up to LO 6.3.3.2,
so changed hardware to ALL.

Unfortunately, it is not systematic or file-specific - but here is what I
notice.

1.  Only happens after "sleeping/"hibernating" Windows (leaving LO open with
several files open) and then continuing -- but only occasionally, not every
time, but sufficiently frequently to be irritating. (not exactly 100% CPU, more
like 30%)

2.  Sometimes the CPU use can be returned to normal by saving an unsaved
document.  (there can still be others that are unsaved).

3.  Sometimes the CPU use can be returned to normal by closing a saved
document.

4.  But as noted, no obvious pattern as why this starts or what gets it to
stop.  Maybe this will remain a NEEDINFO or RESOLVED-INSUFFICIENTDATA.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108458] Label changes for Toolbar use degrade function listing in the Customize dialog--have duplicate entries on the list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108458

--- Comment #49 from sdc.bla...@youmail.dk ---
(In reply to Xisco Faulí from comment #47)
> *** Bug 129549 has been marked as a duplicate of this bug. ***

Tested with:

Version: 6.5.0.0.alpha0+ (x64)
Build ID: 444f0d256957544d26b9af9a0898364e829df1b5
CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: GL; VCL: win; 
Locale: da-DK (en_DK); UI-Language: en-US
Calc: CL

but still same problem as reported in bug 129549 – though now it is easier to
see the situation with the the new tooltips.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129228] FILEOPEN XLSX: file won't open then very slow (2 speedups in this bug)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129228

--- Comment #16 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4992d61600536fe14b97b718dbb11f00e936c6a9

tdf#129228 speedup opening of xlsx file with lots of comments

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129228] FILEOPEN XLSX: file won't open then very slow (2 speedups in this bug)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129228

--- Comment #17 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/3208e69e5ff7a4d151a108d7f2af134664a26bab

tdf#129228 speedup opening of xlsx file with lots of comments

It will be available in 6.4.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129381] Crash when using "edit > cut" on a picture in impress on iOS using app version 4.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129381

Tor Lillqvist  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #3 from Tor Lillqvist  ---
Nicolas, could you please attach a .odp (or .ppt or .pptx) document with an
image where this crash can be reproduced, thanks. I can't reproduce it in a
current build.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84838] trying to Copy text causes crash shutdown on windows document in SUSE

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84838

--- Comment #13 from podesigara  ---
it's an office program I love. I had a problem with my site,
https://www.esigaramtr.com/ thanks to you. Thank you for your help

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 73593] add more formula items to Elements pane, provide LibreOffice with more complete coverage of MathML and LaTex symbol definitions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=73593

--- Comment #15 from mirko.piero...@studenti.polito.it ---
Finally when I say that writing formulas is painful I mean that e.g. I need to
do "{bar{bold{h}}}^{ (k) }" in order to get what in Latex would simply be
"\bar{\boldsymbol{h}}^{(k)}"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122218] After Update to 6.1.4 on macOS fonts are blurred on retina display (xcode 10)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122218

--- Comment #139 from nabili  ---
does this bug report is also about blurry icons of the toolbar, or does it only
concerns blurry fonts as suggested on it's title?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129716] New: error 519 (#VALUE) description in caLc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129716

Bug ID: 129716
   Summary: error 519 (#VALUE) description in caLc
   Product: LibreOffice
   Version: 6.0.7.3 release
  Hardware: x86 (IA32)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: adamm...@o2.pl

Hi,

I have Ubuntu 18.04 LTS and 
LibreOffice calc: 
Wersja: 6.0.7.3
Build ID: 1:6.0.7-0ubuntu0.18.04.10
Wątki CPU: 8; OS:Linux 4.15; UI render:domyślny; VCL: gtk3; 
Ustawienia regionalne: pl-PL (pl_PL.UTF-8); Calc: group

When I import csv with numbers ( english), for example
http://www.kennethmoreland.com/color-advice/bent-cool-warm/bent-cool-warm-table-float-0256.csv

I have to choose english language to have decimal separator comma.
( in csv is dot)
Now I have numbers not text

When I choose polish language then I will have dot as an decimal separator.
and I have text not numbers so I can't use fformula = error 519.

It is described here : 
http://przepis-na-lo.pl/2013/05/poprawne-rozpoznawanie-liczb-skopiowanych-z-internetu/


Is it possible to expand error description : 
https://help.libreoffice.org/Calc/Error_Codes_in_Calc

and add some info that 
" number with some decimal separators can be recognised as a text so such error
can occur."

TIA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129718] New: Textbox continuously updates

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129718

Bug ID: 129718
   Summary: Textbox continuously updates
   Product: LibreOffice
   Version: 6.3.3.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mdgi...@tiscali.co.uk

Description:
I have two spreadsheets:

1) "Textbox foible 0.ods" has one sheet containing some tables, a chart and a
Textbox which is linked to a cell.

2) "Textbox foible 1.ods" has two sheets: the first has the same tables as in
the Textbox foible 0.ods and the second contains the chart and Textbox.

When I open "Textbox foible 0.ods" and add a new value in column B the Textbox
updates and then flickers rapidly. Resmon shows soffice.bin using 25% of the
CPU.

When I open "Textbox foible 1.ods" and add a new value in column B the Textbox
updates but does not flicker. Resmon shows soffice.bin using 0% of the CPU.

I hope that this helps,
Mike.
I will try to attach the two spreadsheets to this report but, in case that
doesn't work, I have put the two versions of the spreadsheet in my Dropbox; you
can find them here:
https://www.dropbox.com/sh/l4wt8odrmeglsm2/AAALfH_nl7vupjy6UTyCULePa?dl=0

Steps to Reproduce:
1. Open "Textbox foible 0.ods" and add a new value, say 80, to cell B8 - press
enter.
2. Take a look at the Textbox just below the X axis and you will notice it
flickering.
3. Do the same for"Textbox foible 1.ods" and you will notice that the Textbox,
which is on sheet "Jan chart" is not flickering.

Actual Results:
Flickering in case 2. of "Steps to Reproduce"

Expected Results:
_No_ flickering in case 2. of "Steps to Reproduce"


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: SpreadsheetDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129719] New: Index: "run-on" entries need to be separated by semicolons (not commas)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129719

Bug ID: 129719
   Summary: Index: "run-on" entries need to be separated by
semicolons (not commas)
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: greenandpleasant2000-supp...@yahoo.co.uk

Created attachment 156886
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156886=edit
Writer file with example index, showing "run-on" entries

1. Open the attached writer file. Inspect the index edit dialogue, Entries tab.
Note that "Key separated by commas" has been ticked.

2. Now close, the dialogue and view the index.

Expected result: Entries should be separated by semicolons, e.g. "could 1;
dead-end 2, 3; disappeared 2, 3;" etc.

Actual result: Index looks like this, "could 1, dead-end 2, 3, disappeared 2,
3," etc.

In other words, the entries should be separated by semicolons, not commas. See
"New Hart's Rules" (Oxford University Press): Indexing > Layout.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129722] New: Writer - Hide white-space mode is buggy with impact on document content

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129722

Bug ID: 129722
   Summary: Writer - Hide white-space mode is buggy with impact on
document content
   Product: LibreOffice
   Version: 6.3.4.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: granj...@gmail.com

Description:
When editing a document with "hide whitespace" activated, LO behave weirdly:
- a lot of page brakes are displayed (grey lines) where there is actually none
- in one case, I have an (empty) table, each time I add a line above it, a line
break appears for each line of the table
- when I delete the begining of my document, an empty page is kept at the
begening of the document, whereas there is nothing left in it
- page footnotes sometimes vanish
See attachments for screenshots.
Thanks in advance for your help

Steps to Reproduce:
1.Activate "Hide whitespaces"
2.update your document
3.see LO doing nonsense

Actual Results:
See attachment for screenshots

Expected Results:
"Hide whitespaces" mode is a very important feature :-(


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.3.4.2
Build ID: 1:6.3.4-0ubuntu0.19.04.1~lo1
CPU threads: 4; OS: Linux 5.0; UI render: default; VCL: kde5; 
Locale: fr-FR (fr_FR.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129722] Writer - Hide white-space mode is buggy with impact on document content

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129722

--- Comment #1 from jul  ---
Created attachment 156888
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156888=edit
Screenshots of the bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129723] New: Index: allow each level to be "Run On" or "Set Out" independently of others

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129723

Bug ID: 129723
   Summary: Index: allow each level to be "Run On" or "Set Out"
independently of others
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: greenandpleasant2000-supp...@yahoo.co.uk

In LibreOffice alphabetical indexes:

* If "Key separated by commas" is unticked (Index edit > Entries), ALL entries
start on a new line (i.e. SET OUT).

* If "Key separated by commas" is ticked, ALL entries are entered one after the
other, separated by a semicolon and a space (i.e. RUN ON).

Suggestion for improvement:

1. Each Index Level (1,2,3) can be set to RUN ON or SET OUT, independently of
other levels.

2. If "Key separated by commas" is TICKED (i.e. index entries for that level
are RUN ON), then all subentries (i.e. higher-numbered levels in the "Entries"
tab) are disallowed.

3. If  "Key separated by commas" is UNTICKED (i.e. index entries for that level
are SET OUT) then subentries are enabled.

This will allow the following combinations:

Level 1 | Run On | Set Out | Set Out | Set Out|
Level 2 | Disallowed | Set Out | Set Out | Run On |
Level 3 | Disallowed | Set Out | N/A | Disallowed |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103859] [META] EMF/WMF (Enhanced/Windows Metafile) bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103859
Bug 103859 depends on bug 129675, which changed state.

Bug 129675 Summary: Rendering EMF image embedded into a presentation slide uses 
too much memory
https://bugs.documentfoundation.org/show_bug.cgi?id=129675

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 77383] Cell comments disappear in calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=77383

--- Comment #12 from Mark Mclean  ---
Thought I had similar problem. But I learned that comments are delete when info
is deleted in the cell that there in. Knowing that help much in not putting
comments in cells that may be deleted.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129715] LibreOffice crash after viewing signed with OpenPGP *.odt file properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129715

lach...@gmail.com changed:

   What|Removed |Added

Crash report or||Application: soffice
crash signature||(soffice), signal:
   ||Segmentation fault Using
   ||host libthread_db library
   ||"/lib/x86_64-linux-gnu/libt
   ||hread_db.so.1". To enable
   ||execution of this file add
   ||add-auto-load-safe-path
   ||/opt/libreoffice6.3/program
   ||/libpython3.5m.so.1.0-gdb.p
   ||y lin

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129583] INSERT INDEX ENTRY DIALOG: Insert button ignores "Entry" field when multiple entries made

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129583

--- Comment #6 from R. Green  ---
DP commented: "Not clear to me, if you have enabled "Apply to all similar
texts" and "Match Case" in Insert Entry Dialog."

The answer is NO, I haven't enabled them.


BTW, this issue only occurs when the "Entry" field is exactly the same as the
first word selected. If for example you repeat the procedure but this time add
the word "steps" to "quiet" in step 1 (to give "quiet steps"), the bug does not
occur. Instead you get

quiet steps... 1p.

which is correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 47608] Allow "see" and "see also" entries in an Alphabetical Index

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=47608

--- Comment #3 from R. Green  ---
I would like to second this enhancement request: cross-references are common in
book indexes.

There are two types:

1. One where the cross reference supplants the preceding text entry. e.g.

"Canton, see Guangzhou"
"farming, see agriculture"

2a. Where the cross reference supplements the text entry. e.g.

"birds, 21, 88-99; see also chickens"

2b. Where the cross reference supplements the main entry but is entered at the
end of the list of subentries. e.g.

sacrifice
   animal, 74-75
   see also rituals

Details in "New Hart's Rules" (Oxford University Press) Indexing >
Cross-references.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 129480] Index: f. and ff. should be used instead of p. and pp.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129480

R. Green  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from R. Green  ---
This is a duplicate of Bug 94411.

*** This bug has been marked as a duplicate of bug 94411 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 122497] [META] Table of Contents and Indexes dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122497
Bug 122497 depends on bug 129480, which changed state.

Bug 129480 Summary: Index: f. and ff. should be used instead of p. and pp.
https://bugs.documentfoundation.org/show_bug.cgi?id=129480

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129480] Index: f. and ff. should be used instead of p. and pp.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129480

R. Green  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from R. Green  ---
This is a duplicate of Bug 94411.

*** This bug has been marked as a duplicate of bug 94411 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94411] Editing alphabetic index allows page references Np, Npp - not UK english usage

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94411

R. Green  changed:

   What|Removed |Added

 CC||greenandpleasant2000-suppor
   ||t...@yahoo.co.uk

--- Comment #6 from R. Green  ---
*** Bug 129480 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128910] DocumentFormat.OpenXml cannot open LibreOffice spreadsheet due to FileFormatException in WindowsBase.dll MS.Internal.IO.Zip.ZipIOLocalFileBlock.Validate

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128910

--- Comment #14 from Julien Nabet  ---
On pc Debian x86-64 with LO Debian package 6.3.4, here is a test I did:
- retrieve the problematic file
- add "test" on a cell
- resave
- rename extension file to zip
- unzip -t
=> no error and no warning.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129720] New: Populate the Description box of the Customize dialog with multiline tooltip from bug 108458

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129720

Bug ID: 129720
   Summary: Populate the Description box of the Customize dialog
with multiline tooltip from bug 108458
   Product: LibreOffice
   Version: 6.5.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: vstuart.fo...@utsa.edu

Would the multiline tooltip implemented for bug 108458 be suitable to insert
into the 'Description' box of the customize dialog, and so resolve bug 61210. 

Also, the description box will otherwise remain blank until for bug 118148 the
 tags can again be parsed from the New Help system and provided in the
translated help packs for use when offline 'Local Help' is installed.

Even then, some folks might prefer the multiline tip entry to the extended tip
entry from the . So could the Tools -> Options -> General 'Extended
tips' also toggle use here? 

Likewise, content of the multiline tooltip would be sufficient for needs of bug
112237 if the Description box can be made to show tip for controls that have
already been added to the UI, i.e. entries on the right column of the dialog.

All of it centered on populating the 'Description' box.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129721] New: Cell Comments disappear after opening file up.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129721

Bug ID: 129721
   Summary: Cell Comments disappear after opening file up.
   Product: LibreOffice
   Version: 6.3.3.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mclean8...@gmail.com

Description:
Made comments in a few cell, again, closed file, reopened, comments gone on
some sheets.

Steps to Reproduce:
1.made comment in cells
2.close file
3.open file and comments gone on one sheet.

Actual Results:
comment in a cell, close file. open file. may or may not be there.

Expected Results:
some comments in cells gone


Reproducible: Sometimes


User Profile Reset: No



Additional Info:
kept all comments in cells

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129714] Cursor not in cell when editing xls file.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129714

Oliver Brinzing  changed:

   What|Removed |Added

Version|6.2.8.2 release |Inherited From OOo
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||oliver.brinz...@gmx.de

--- Comment #1 from Oliver Brinzing  ---
reproducible with:

AOO 4.1.5

Version: 6.5.0.0.alpha0+ (x64)
Build ID: 75778a50f730568fee2466b6e794401f1e2a8f67
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129718] Textbox continuously updates

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129718

Oliver Brinzing  changed:

   What|Removed |Added

 CC||oliver.brinz...@gmx.de
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #2 from Oliver Brinzing  ---
I cannot reproduce it with:

Version: 6.3.4.2 (x64)
Build-ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa
CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: 

And i think this issue is a duplicate of:
Bug 121963 - button flashing - mouse wheel zooming breaks

Should be fixed with LO 6.3.4

Can you please update and check?

I have set the bug's status to 'NEEDINFO'. 
Please change it back to 'UNCONFIRMED' once the requested info is provided.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 73593] add more formula items to Elements pane, provide LibreOffice with more complete coverage of MathML and LaTex symbol definitions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=73593

--- Comment #14 from mirko.piero...@studenti.polito.it ---
I also copy here a comment from
https://bugs.documentfoundation.org/show_bug.cgi?id=96208:

It'd be nice if formulas were inserted at the current position of the cursor,
rather than at the center of the page (in LO Impress) and if the box containing
the formula was able to adaptively change its size according to the content, as
after a few characters it's impossible to see what is inside the box, and
trying to enlarge the box manually does not work.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 73593] add more formula items to Elements pane, provide LibreOffice with more complete coverage of MathML and LaTex symbol definitions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=73593

--- Comment #13 from mirko.piero...@studenti.polito.it ---
Hello, I'd like to add a few points that require some thought in my opinion,
even if some of them are different issues than those outlined so far:
1) It'd be nice that formulas could start where one places the cursor on the
slide or document
2) Could making TexMaths native to LibreOffice a good idea? We might try to
contact and involve the developer who made the extension.
3) Formulas are very painful to write at the moment and it's difficult to
displace them to the right place (would be cool if they could be written "in
line" with the text). It's not currently possible to group formulas and text
into one single object.
4) bad rendering in some cases (e.g. "underline y") and no "mathcal" command
available
5) The transition between "normal" mode and "formula" mode and viceversa is
quite painful in terms of user experience.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129715] New: LibreOffice crash after viewing signed with OpenPGP *.odt file properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129715

Bug ID: 129715
   Summary: LibreOffice crash after viewing signed with OpenPGP
*.odt file properties
   Product: LibreOffice
   Version: 6.3.4.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lach...@gmail.com

Description:
Signed with OpenPGP signature ODT document doesn't show in its properties as
"signed". In one case, LOffice breaks exactly after entering to menu
"File->Properties", another case - breaks after closing the signed file.
So, crash analyzer gives an output:

Application: soffice (soffice), signal: Segmentation fault
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
To enable execution of this file add
add-auto-load-safe-path
/opt/libreoffice6.3/program/libpython3.5m.so.1.0-gdb.py
line to your configuration file "/home/dodo/.gdbinit".
To completely disable this security protection add
set auto-load safe-path /
line to your configuration file "/home/dodo/.gdbinit".
For more information about this security protection see the
"Auto-loading safe path" section in the GDB manual.  E.g., run from the shell:
info "(gdb)Auto-loading safe path"
[Current thread is 1 (Thread 0x7f2696d55d00 (LWP 2938))]

Thread 20 (Thread 0x7f260affd700 (LWP 3014)):
#0  futex_abstimed_wait_cancelable (private=,
abstime=0x7f260affbfb0, clockid=, expected=0,
futex_word=0x7a0a778) at ../sysdeps/unix/sysv/linux/futex-internal.h:208
#1  __pthread_cond_wait_common (abstime=0x7f260affbfb0, clockid=, mutex=0x7a0a728, cond=0x7a0a750) at pthread_cond_wait.c:520
#2  __pthread_cond_timedwait (cond=0x7a0a750, mutex=0x7a0a728,
abstime=0x7f260affbfb0) at pthread_cond_wait.c:656
#3  0x7f2659643246 in ?? () from
/usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so
#4  0x7f26596174a8 in ?? () from
/usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so
#5  0x7f265978d586 in ?? () from
/usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so
#6  0x7f265937b88a in JVM_MonitorWait () from
/usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so
#7  0x7f263c947990 in ?? ()
#8  0x00071d9e6cb0 in ?? ()
#9  0x7f260affc1b0 in ?? ()
#10 0x in ?? ()

Thread 19 (Thread 0x7f26301d0700 (LWP 3013)):
#0  futex_abstimed_wait_cancelable (private=,
abstime=0x7f26301cf6f0, clockid=, expected=0,
futex_word=0x7a0747c) at ../sysdeps/unix/sysv/linux/futex-internal.h:208
#1  __pthread_cond_wait_common (abstime=0x7f26301cf6f0, clockid=, mutex=0x7a07428, cond=0x7a07450) at pthread_cond_wait.c:520
#2  __pthread_cond_timedwait (cond=0x7a07450, mutex=0x7a07428,
abstime=0x7f26301cf6f0) at pthread_cond_wait.c:656
#3  0x7f2659643246 in ?? () from
/usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so
#4  0x7f26595f6ff9 in ?? () from
/usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so
#5  0x7f26595f7a49 in ?? () from
/usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so
#6  0x7f26597c4699 in ?? () from
/usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so
#7  0x7f26597c473d in ?? () from
/usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so
#8  0x7f26597ca7c8 in ?? () from
/usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so
#9  0x7f265963ca36 in ?? () from
/usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so
#10 0x7f2693c31669 in start_thread (arg=) at
pthread_create.c:479
#11 0x7f2698d2a323 in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 18 (Thread 0x7f260b7fe700 (LWP 3012)):
#0  futex_wait_cancelable (private=, expected=0,
futex_word=0x7a04e7c) at ../sysdeps/unix/sysv/linux/futex-internal.h:80
#1  __pthread_cond_wait_common (abstime=0x0, clockid=0, mutex=0x7a04e28,
cond=0x7a04e50) at pthread_cond_wait.c:508
#2  __pthread_cond_wait (cond=0x7a04e50, mutex=0x7a04e28) at
pthread_cond_wait.c:638
#3  0x7f265964589b in ?? () from
/usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so
#4  0x7f26595f6f38 in ?? () from
/usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so
#5  0x7f26595f7a49 in ?? () from
/usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so
#6  0x7f26596fa621 in ?? () from
/usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so
#7  0x7f26597cf77f in ?? () from
/usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so
#8  0x7f26597cfb60 in ?? () from
/usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so
#9  0x7f26597ca7c8 in ?? () from
/usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so
#10 0x7f265963ca36 in ?? () from
/usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so
#11 0x7f2693c31669 in start_thread (arg=) at
pthread_create.c:479
#12 0x7f2698d2a323 in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 17 

[Libreoffice-bugs] [Bug 125536] Garbled combo box within Format / Character / Font dialog box on macOS

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125536

Thorsten Wagner  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |thorsten.wagne...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129715] LibreOffice crash after viewing signed with OpenPGP *.odt file properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129715

lach...@gmail.com changed:

   What|Removed |Added

 CC||lach...@gmail.com
  Alias||Lumino

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 30940] Allow more than one Alphabetical Index

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=30940

--- Comment #12 from R. Green  ---
I'd like to second this enhancement request. It is quite a common feature of
non-fiction books. The kind of indexes supported include:

General Index
Index of Names
Index of Subjects
Index of Places

and so on.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128731] exporting a selection crops the result

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128731

Gerhard Weydt  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #6 from Gerhard Weydt  ---
I can now confirm the bug, following your instructions I get the same result as
you, in 6.3.3.2 as well as in 
Version: 6.4.0.0.alpha1 (x64)
Build ID: cc57df8f942f239d29cb575ea5a7cb01405db787
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: default; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-GB
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129712] Crash in: mergedlo.dll after changing of Line Spacing to Fixed in Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129712

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||s.mehrbr...@gmail.com
   Keywords|bibisectRequest |bibisected, bisected

--- Comment #3 from Roman Kuznetsov <79045_79...@mail.ru> ---
I bisected it, result is

$ git bisect good
fcc506eebf021045ab3d4647a8706e5e057e8a15 is the first bad commit
commit fcc506eebf021045ab3d4647a8706e5e057e8a15
Author: Norbert Thiebaud 
Date:   Tue Dec 17 01:05:01 2019 -0800

source sha:64233bbaa0e91ddf14d59ae7547df6bbfa60adcc

https://gerrit.libreoffice.org/plugins/gitiles/core/+/64233bbaa0e91ddf14d59ae7547df6bbfa60adcc

Adding CC: to Samuel Mehrbrodt

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128244] OD* files can't be opened if Zip64 was used in their creation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128244

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=82
   ||984

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82984] FILEOPEN: Error opening XLSX file in zip64 format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82984

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||8244

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84838] trying to Copy text causes crash shutdown on windows document in SUSE

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84838

--- Comment #14 from saltlikit  ---
A very good program I was able to overcome a lot of things problem solved for
my site thanks for your help.https://www.saltlikitim.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114746] Improve CJK and CTL fonts setting in default Impress templates

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114746

--- Comment #18 from Laurent BP  ---
@Hiunn-hé: thanks for your tests.
Size, style and weight are now forced to be the same. These properties can be
defined inside XML code of templates. Modifications of templates are on the
way.

Unfortunately, I don't know how to fix font changing for the issues you
mentioned.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125811] [META] Toolbars tab of Customization dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125811
Bug 125811 depends on bug 129549, which changed state.

Bug 129549 Summary: Bullet and Numbering icon appears twice in Customize 
Toolbars
https://bugs.documentfoundation.org/show_bug.cgi?id=129549

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|DUPLICATE   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129549] Bullet and Numbering icon appears twice in Customize Toolbars

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129549

Mike Kaganski  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Resolution|DUPLICATE   |---
 Status|RESOLVED|NEW

--- Comment #4 from Mike Kaganski  ---
This is not a duplicate.

Yes, these two UNO commands do exactly the same. Having different names, and
different slots (.uno:BulletsAndNumberingDialog maps to FN_NUMBER_BULLETS, and 
.uno:OutlineBullet to SID_OUTLINE_BULLET), when in Writer, they both are routed
to SwTextShell::ExecEnterNum, where they are treated identically. The
difference between them is only that there is a code handling
SID_OUTLINE_BULLET also in sd, while FN_NUMBER_BULLETS is specific only to sw.
Thus, the latter is better deprecated (although kept for compatibility) and
made hidden, so that it doesn't appear in the customization UI.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128731] exporting a selection crops the result

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128731

cson...@halmai.hu changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #5 from cson...@halmai.hu ---
My previous LO version was:

Version: 6.3.0.4 (x64)
Build ID: 057fc023c990d676a43019934386b85b21a9ee99
CPU threads: 12; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-AU (en_AU); UI-Language: en-US
Calc: threaded

I did this:

- open "proof.odg" (first attachment in this ticket)
- do NOT select anything
- File -> Export ... -> save as type=PNG, checkbox "Selection" is ticked (!),
File name="a.png", Save
- in the PNG options dialog, keep all the default values and keep the two
checkboxes ticked. 
- click OK
- open the resulting a.png in an image viewer. It contains only the lower right
quarter of the ellipse, plus a huge clear transparent area. (*)

- keep the odt file open
- Edit -> Select All
- File -> Export ... -> save as type=PNG, checkbox "Selection" is ticked (!),
File name="b.png", Save
- in the PNG options, keep all the default values and keep the two checkboxes
ticked. 
- click OK
- open the resulting b.png in an image viewer. It contains the whole ellipse
within its bounding box, including the part that is beyond the margin, but
nothing else.

My original complaint in the first comment of this ticket needs a
clarification. In the first case a large png is generated that contains
everything _within the margins_ but nothing beyond them. In the second case the
selected objects are exported, even if they are beyond the margins.

I installed the new version:

Version: 6.3.3.2 (x64)
Build ID: a64200df03143b798afd1ec74a12ab50359878ed
CPU threads: 12; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-AU (en_AU); UI-Language: en-US
Calc: threaded

and the behaviour is still the same. 

I still believe that hiding this difference is confusing. If the user, by
accident, puts an object partly beyond the margins then the exported image will
be silently truncated.

Instead of the current behaviour, LO should ask the following dialog, when
Export Selection is ticked but nothing was selected. 

> Nothing is selected. What do you want to export?
> [Everything, even beyond margins]
> [Everything within the margins]
> [Nothing, I will select something]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96401] FILEOPEN: DOCX - Specific file reported as corrupted (openable in MSO but not in other programs because of unzip error)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96401

--- Comment #13 from petur  ---
OP here... since less and less people use the MSO version that had this
specific quirk, be my guest and close this. 4 years waiting has been enough
anyway.

And for the last time, it is not corrupt, you can unzip the file perfectly. It
merely doesn't follow the standard.

I am removing myself of this thread and community

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128298] CALC - it doesn't work Paste Special (unformatted text)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128298

Timur  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #10 from Timur  ---
This bug is loosing sense. 
Kabilo's issue is not clear and if he said it wasn't the same as bug 116983, he
didn't explain why, what makes this one specific.
Rick is adding another request for different paste formats (original issue
mentioned Paste Special - Unformatted text) and speaks about  bug 128803.
I set back Needinfo for Kabilo to explain.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112237] Cannot get description of used commands in new customize dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112237

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||9720

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103238] [META] Customize dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103238

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||129720


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129720
[Bug 129720] Populate the Description box of the Customize dialog with
multiline tooltip from bug 108458
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129720] Populate the Description box of the Customize dialog with multiline tooltip from bug 108458

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129720

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||103238
 Depends on||118148
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||momonas...@gmail.com,
   ||rayk...@gmail.com,
   ||vstuart.fo...@utsa.edu
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||8458,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=61
   ||210,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||2237
   Keywords||needsUXEval


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103238
[Bug 103238] [META] Customize dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=118148
[Bug 118148] [NEWHELP] Handle  tags in the UI
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108458] Label changes for Toolbar use degrade function listing in the Customize dialog--have duplicate entries on the list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108458

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||9720

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 129720] Populate the Description box of the Customize dialog with multiline tooltip from bug 108458

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129720

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||103238
 Depends on||118148
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||momonas...@gmail.com,
   ||rayk...@gmail.com,
   ||vstuart.fo...@utsa.edu
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||8458,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=61
   ||210,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||2237
   Keywords||needsUXEval


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103238
[Bug 103238] [META] Customize dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=118148
[Bug 118148] [NEWHELP] Handle  tags in the UI
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 122218] After Update to 6.1.4 on macOS fonts are blurred on retina display (xcode 10)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122218

--- Comment #138 from majormahonia  ---
Confirming that 6.5.0.0 from 31 December 2019 tested on Macbook 12 running
Mojave 10.14.6 still has blurry fonts

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125544] Table cell alignment is recalculated on opening documents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125544

Heiko Tietze  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125532] Characters rendered black on selected dialog tabs on macOS

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125532

Thorsten Wagner  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |thorsten.wagne...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129715] LibreOffice crash after viewing signed with OpenPGP *.odt file properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129715

--- Comment #1 from lach...@gmail.com ---
Created attachment 156869
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156869=edit
Missing files, needed for an automatic bug report

some text in Ukrainian

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129715] LibreOffice crash after viewing signed with OpenPGP *.odt file properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129715

lach...@gmail.com changed:

   What|Removed |Added

   Hardware|All |x86-64 (AMD64)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129715] LibreOffice crash after viewing signed with OpenPGP *.odt file properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129715

lach...@gmail.com changed:

   What|Removed |Added

Crash report or|Application: soffice|
crash signature|(soffice), signal:  |
   |Segmentation fault Using|
   |host libthread_db library   |
   |"/lib/x86_64-linux-gnu/libt |
   |hread_db.so.1". To enable   |
   |execution of this file add  |
   |add-auto-load-safe-path |
   |/opt/libreoffice6.3/program |
   |/libpython3.5m.so.1.0-gdb.p |
   |y lin   |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94411] In alphabetical indexes f. and ff. should be used - not p. or pp.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94411

R. Green  changed:

   What|Removed |Added

Summary|Editing alphabetic index|In alphabetical indexes f.
   |allows page references Np,  |and ff. should be used -
   |Npp - not UK english usage  |not p. or pp.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129712] Crash in: mergedlo.dll after changing of Line Spacing to Fixed in Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129712

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression

--- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> ---
don't repro in 6.3.3.2

so it is a regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129717] New: Index: allow subentry layout to differ from main entry

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129717

Bug ID: 129717
   Summary: Index: allow subentry layout to differ from main entry
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: greenandpleasant2000-supp...@yahoo.co.uk

In LibreOffice alphabetical indexes:

* If "Key separated by commas" is unticked, ALL entries starts on a new line
(i.e. SET OUT).

* If "Key separated by commas" is ticked, ALL entries are entered one after the
other, separated by a semicolon and a space (i.e. RUN ON)

Request that you allow the user the option of setting the lowest sublevel of an
index to RUN ON, even if the main entry is SET OUT. This is a
useful-space-saving option.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96401] FILEOPEN: DOCX - Specific file reported as corrupted (openable in MSO but not in other programs because of unzip error)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96401

Julien Nabet  changed:

   What|Removed |Added

 CC|serval2...@yahoo.fr |

--- Comment #14 from Julien Nabet  ---
It was just a suggestion.
uncc myself since I can't do anything about this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 50172] Request for "Convert to values..." function

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=50172

s5t1e3v4e3...@hotmail.com  changed:

   What|Removed |Added

 CC||s5t1e3v4e3...@hotmail.com

--- Comment #4 from s5t1e3v4e3...@hotmail.com  ---
Calc 6.3.4.2 (on Linux) does have a "Values" option, it is the "$0" button on
the top left of the paste special dialog.
So this request can be closed as resolved?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129717] Index: allow subentry layout to differ from main entry

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129717

R. Green  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from R. Green  ---
Reported elsewhere as part of a wider enhancement request.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118148] [NEWHELP] Handle tags in the UI

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=118148

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||129720


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129720
[Bug 129720] Populate the Description box of the Customize dialog with
multiline tooltip from bug 108458
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 61210] Descriptions of menu/toolbar elements in Customize don’t appear if help is not installed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=61210

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||9720

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108458] Label changes for Toolbar use degrade function listing in the Customize dialog--have duplicate entries on the list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108458

V Stuart Foote  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #50 from V Stuart Foote  ---
So the multiline tooltips Heiko & Jim worked up clearly resolves this issue of
ambiguous labels.

As a sidebar, opened bug 129720 to use this multiline tooltip as text for the
Description box (absent a Local Help installation).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129721] Cell Comments disappear after opening file up.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129721

--- Comment #2 from Mark Mclean  ---
Did you search for existing bugs? Yes, was old,
https://bugs.documentfoundation.org/show_bug.cgi?id=77383
What is file save format? Calc
You need to attach a sample file and write reproducible steps. I wrote steps
But I can not get it to do it again, at first I believed it was because I
deleted the numbers in cells, they do delete with numbers, but after I stopped
doing that, I still lost them, but only on one sheet in the file! Must be me. I
will watch closer. I will post again if I get it to do it each time.
"Sometimes" cannot be confirmed as a bug.

Thanks for your times.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57113] Macros: Unicode vs. password protected user libraries

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57113

Mike Kaganski  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com
   |desktop.org |

--- Comment #17 from Mike Kaganski  ---
https://gerrit.libreoffice.org/c/core/+/86065

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94411] In alphabetical indexes f. and ff. should be used - not p. or pp.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94411

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 CC||sdc.bla...@youmail.dk

--- Comment #8 from sdc.bla...@youmail.dk ---
(In reply to Bernard Moreton from comment #5)
> The only entry for combining page references is still (in the EN-UK
> environment) 'p/pp', where it should be 'f/ff'.

I believe the actual behavior is p. / pp.

Also, at present, the en_GB locale is defined as identical to en_US, which has
a period after the p. and pp.  Will that be acceptable (if the p/pp is changed
to f./ff.)?

(In reply to R. Green from comment #7)
> The correct abbreviations which should be substituted are f. (and the
> following page); and ff. (and the following pages). 

As a workaround, try setting "Locale setting" to Danish (in Tools > Options >
Language Settings - Language)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129549] Bullet and Numbering icon appears twice in Customize Toolbars

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129549

--- Comment #6 from Mike Kaganski  ---
(In reply to V Stuart Foote from comment #5)

I'm sorry: specifically what is WONTFIX here? The bug is not about distinct
*icons* here: it's about two *identical* elements in the command list. The
names of uno commands are different - but they are doing absolutely the same,
absolutely the same. What is the purpose to have those *two* entries for one
function? They are not two functions with one name, but different actions.

I disagree with WONTFIX.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129549] Bullet and Numbering icon appears twice in Customize Toolbars

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129549

--- Comment #7 from V Stuart Foote  ---
@Mike, understand these UNO controls happen to have same end result and could
be unified (or one hidden), but the search of controls in the customization
dialog is generic--a search pulls in entries from all components. 

The "bul" search here is just one of multiple that can return 'Label' matches
from widgets intended for different modules. Try "incre" or "decre"

Do you really want to keep this open to factor in target module for the widget
search in the customize dialog?

IMHO search results and duplicate labels made this a duplicate of bug 108458,
and doing more with search in the Customize... dialog isn't worth it. => WF.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129549] Bullet and Numbering icon appears twice in Customize Toolbars

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129549

--- Comment #8 from Mike Kaganski  ---
I believe that this issue is strictly about two correctly identified
duplicates, one of which should be hidden - that's a good small target.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs