Introduction and problems compiling
I don't know why but my previous e-mail got "header flagged". Here's the original: " Hello, I'm David Hernandez and I'm too an aspiring GSoC student. I want to further broaden my experience by participating in an open source project. Even if I don't get admited to the program I will likely contribute this summer anyway. I'm gonna look at the easy hacks list and see what I can do. Btw, the GSoC page https://summerofcode.withgoogle.com/organizations/4535835748204544/ mentions the existence of some ideas with mentors. I assume it refers to this page? https://wiki.documentfoundation.org/Development/GSoC/Ideas When I'm done with the easy hacks, I should investigate about the issues presented there and write a formal application, right? Thank you, David. PS: My IRC nickname is davidhm and my education is 4th year CS undergrad student in Universitat Politècnica de Catalunya, Spain. " Also, my build fails in unit testing, this is my prompt: SigningTest::testODFBrokenDsigGPG finished in: 6633ms /home/david/Partitions/Almacen3/Universidad/GSoC/libreoffice/unotest/source/cpp/macros_test.cxx:52:SigningTest::testODFEncryptedGPG assertion failed - Expression: xComponent.is() - loading failed: file:///home/david/Partitions/Almacen3/Universidad/GSoC/libreoffice//xmlsecurity/qa/unit/signing/data/encryptedGPG.odt SigningTest::testODFEncryptedGPG finished in: 10265ms macros_test.cxx:52:Assertion Test name: SigningTest::testODFEncryptedGPG assertion failed - Expression: xComponent.is() - loading failed: file:///home/david/Partitions/Almacen3/Universidad/GSoC/libreoffice//xmlsecurity/qa/unit/signing/data/encryptedGPG.odt Failures !!! Run: 24 Failure total: 1 Failures: 1 Errors: 0 Error: a unit test failed, please do one of: make CppunitTest_xmlsecurity_signing CPPUNITTRACE="gdb --args" # for interactive debugging on Linux make CppunitTest_xmlsecurity_signing VALGRIND=memcheck # for memory checking make CppunitTest_xmlsecurity_signing DEBUGCPPUNIT=TRUE # for exception catching You can limit the execution to just one particular test by: make CPPUNIT_TEST_NAME="testXYZ" ...above mentioned params... /home/david/Partitions/Almacen3/Universidad/GSoC/libreoffice/solenv/gbuild/CppunitTest.mk:114: recipe for target '/home/david/Partitions/Almacen3/Universidad/GSoC/libreoffice/workdir/CppunitTest/xmlsecurity_signing.test' failed make[1]: *** [/home/david/Partitions/Almacen3/Universidad/GSoC/libreoffice/workdir/CppunitTest/xmlsecurity_signing.test] Error 1 make[1]: *** Waiting for unfinished jobs Makefile:280: recipe for target 'build' failed make: *** [build] Error 2 Any ideas on what should I do? I tried debugging but I can't understand what's going on. Thanks, David. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Question re the uno-skeletonmaker'-t' CLI qualifier
Hello Stephan, Yes, this is a Linux system and I'm invoking uno-skeletonmaker thus: david@anon:~> "$OFFICE_HOME"/sdk/bin/uno-skeletonmaker calc-add-in --java5 -l "$OFFICE_PROGRAM_PATH"/types.rdb -n org.openoffice.adl.util.CalcDL1 -t CalcDL1 ERROR: Unknown entity 'CalcDL1' david@anon:~> I'd already found the '-l' trap for the unwary the hard way (and it also occurs in 'javamaker')! My problem now is that a value for '-t' is apparently mandatory for the 'calc-add-in' command but I don't understand what to put there. The uno-skeletonmaker source code, its help text, and every other reference have identical wording: "-t specifies a UNOIDL type name, e.g. com.sun.star.text.XText (can be used more than once)”. Since '-l' already points to types.rdb you'd think '-t' wouldn't be needed. The phrasing "-t CalcDL1" was just a guess as I'd read some source code which seemed to imply a service-name was required. _ __Regards, David_ On 24/1/23 01:15, Stephan Bergmann wrote: > On 23/01/2023 03:45, David wrote: >> According to >> https://api.libreoffice.org/docs/tools.html#uno-skeletonmaker the >> argument ‘-t’ “specifies a UNOIDL type name, e.g. >> com.sun.star.text.XText (can be used more than once)”. This wording is >> the same as both the uno-skeletonmaker command-line ‘help’ and the >> introductory comments in the source code for 'skeletonmaker.cxx'. >> >> However I don't understand which entity the UNOIDL type name is intended >> to qualify. For example, is it the type of the skeleton code to be >> generated (presumably not, since that’s defined by the ‘calc-add-in’ >> command), the type of each value returned by the Java methods >> implemented in this addIn, or something else? Anything I've tried >> results in an "unknown entity" diagnostic. > uno-skeletonmaker apparently needs to be explicitly told where to find > any referenced UNOIDL entities, via the -l option. So adding something like >> -l "$OFFICE_HOME"/program/types.rdb -l >> "$OFFICE_HOME"/program/types/offapi.rdb > should work (in an SDK shell, on Linux at least). >
Question re the uno-skeletonmaker'-t' CLI qualifier
Hello, I've been referred to this mailing list for an answer to the following question, originally posted at https://ask.libreoffice.org/t/the-sdk-uno-skeletonmaker-t-argument/86641 According to https://api.libreoffice.org/docs/tools.html#uno-skeletonmaker the argument ‘-t’ “specifies a UNOIDL type name, e.g. com.sun.star.text.XText (can be used more than once)”. This wording is the same as both the uno-skeletonmaker command-line ‘help’ and the introductory comments in the source code for 'skeletonmaker.cxx'. However I don't understand which entity the UNOIDL type name is intended to qualify. For example, is it the type of the skeleton code to be generated (presumably not, since that’s defined by the ‘calc-add-in’ command), the type of each value returned by the Java methods implemented in this addIn, or something else? Anything I've tried results in an "unknown entity" diagnostic. About seven years ago I wrote an addIn which works well, but it was developed by hand-coding everything from scratch and modifying the 'make' file given in the SDK examples. My reference document was the "OpenOffice.org 3.1 Developer's Guide" published by Sun Microsystems in 2009. I'm now attempting to recompile this addIn using the LO SDK toolset before embarking on a new project. I'd be grateful for any light which members of this list can shed. Regards, David Lochrin
Re: Question re the uno-skeletonmaker'-t' CLI qualifier
On 25/1/23 20:05, Stephan Bergmann wrote: > On 25/01/2023 05:14, David [minor edit] wrote: >> However treating the '-t' option as a service rather than an interface, as >> follows, works. An directory tree is created in >> the directory where the skeletonmaker CLI command was run, and a very >> plausible skeleton CalcDL1.java file was created in though I haven't >> been through it in detail. >> Your comment "[...] So I would assume that -t must specify that interface >> type." is what I'd expect too. That's reinforced by the HELP text which >> states: "-t specifies a UNOIDL type name, e.g. >> com.sun.star.text.XText (can be used more than once". Not much doubt >> there... > So the uno-skeletonmaker help and diagnostic output apparently uses, somewhat > consistently but maybe also somewhat confusingly, the term "type" to mean > both UNOIDL interfaces and UNOIDL services. That's the problem in a nutshell. In common programming terminology, the word "type" refers to a single variable or symbol. A strongly-typed language will flag a compilation error if incompatible types are used, for example 'i=x' where 'i' is declared to be an integer type and 'x' is declared floating-point. Extending this concept of "type" to a complex structure like a UNOIDL interface, which may include many different atomic types, makes sense. But I can't see how it can possibly refer to a "service". An IDL interface and an IDL service are different things entirely, conventionally distinguished by prefixing 'X' to interface names. And in the case of the uno-skeletonmaker 'calc-add-in command', specifying a service works but specifying an interface fails. So I argue that the documentation and HELP text are plainly wrong and should be corrected. After all, skeletonmaker is only at version 0.4! Perhaps it would be worthwhile checking that this inconsistency doesn't hide some deeper problem. It feels to me like the result of a misunderstanding or a sudden change of design which may have further ramifications. D.
Re: Question re the uno-skeletonmaker'-t' CLI qualifier
I think we're getting somewhere...! On 24/1/23 18:03, Stephan Bergmann wrote: > I don't know much about skeletonmaker or Calc add-ins, but > <https://wiki.documentfoundation.org/Documentation/DevGuide/Spreadsheet_Documents#Spreadsheet_Add-Ins> > > <<https://wiki.documentfoundation.org/Documentation/DevGuide/Spreadsheet_Documents#Spreadsheet_Add-Ins>> > says "The functions that the add-in component exports to the spreadsheet > application have to be defined in a new interface." So I would assume that -t > must specify that interface type. And one or more -l will be needed to make > available that interface type and all the other UNOIDL entities recursively > referenced from it. So if you have your own type com.example.XMyAddIn in your > own local mytypes.rdb, you'd probably need something like >> -t com.example.XMyAddIn -l "$OFFICE_HOME"/program/types.rdb -l >> "$OFFICE_HOME"/program/types/offapi.rdb -l mytypes.rdb Using the three '-l' options shown above and in the following test command with *no**'-t' option* results in a skeletonmaker error, presumably because '-t' and '-n' are mandatory in the 'calc-add-in' command (BUG: the '-t' is displayed in upper case, which can be misleading given case-sensitivity): david@anon:~> "$OFFICE_HOME"/sdk/bin/uno-skeletonmaker calc-add-in --java5 -l "$OFFICE_PROGRAM_PATH"/types.rdb -l "$OFFICE_HOME"/program/types/offapi.rdb -l /home/david/<...path...>/XCalcDL1.rdb -n org.openoffice.adl.util.CalcDL1 Error: no type is specified, use the -T option at least once Changing the last '-l' to '-t' results in: ERROR: Unknown entity '/home/david/<...path...>/XCalcDL1.rdb' However treating the '-t' option as a service rather than an interface, as follows, works. An directory tree is created in the directory where the skeletonmaker CLI command was run, and a very plausible skeleton CalcDL1.java file was created in though I haven't been through it in detail. david@anon:~> "$OFFICE_HOME"/sdk/bin/uno-skeletonmaker calc-add-in --java5 -l "$OFFICE_PROGRAM_PATH"/types.rdb -l "$OFFICE_HOME"/program/types/offapi.rdb -l /home/david/<...path...>/XCalcDL1.rdb -n org.openoffice.adl.util.CalcDL1 -t org.openoffice.adl.util.CalcDL1 david@anon:~> *COMMENTS* Your comment "[...] So I would assume that -t must specify that interface type." is what I'd expect too. That's reinforced by the HELP text which states: "-t specifies a UNOIDL type name, e.g. com.sun.star.text.XText (can be used more than once". Not much doubt there... There's evidently a discrepancy between the LibreOffice Developer's Guide, the skeletonmaker HELP text, introductory comments in the skeletonmaker source code, all other API guides which repeat the HELP text, and what actually works. Most of the initial command & option validation seems to be done by 'skeletonmaker.cxx' which calls generatePackage() in 'javacompskeleton.cxx' to do the work. But as I mentioned in an earlier email, I've come across a suggestion somewhere that '-t' defines a service, not an interface; maybe a change was made which hasn't been reflected in the Developer's Guide? I don't have the time and expertise in C to untangle the source code and in any case the sources I've looked at are completely devoid of comments (without which ongoing maintenance is far more difficult and unreliable!) apart from the introduction to skeletonmaker.cxx. Should I post another bug report in Bugzilla? - the first was marked NOTABUG. Thanks for your help, Stephan. _David Lochrin _
David Carter License statement
All of my past & future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. Very Respectfully, David Carter
Re: [Libreoffice] C{,PP}FLAGS ignored in sal
On Thu, Oct 14, 2010 at 09:33:45AM +0100, Caolán McNamara wrote: On Thu, 2010-10-14 at 08:37 +0200, Thomas Klausner wrote: On Wed, Oct 13, 2010 at 05:25:59PM +0200, Thomas Klausner wrote: I don't see my CFLAGS nor CPPFLAGS, which would make it find boost, in the gcc arguments. How can I make them used in this part of the build? I don't think we have any proper support to pass CFLAGS and CPPFLAGS down to everything correctly. You can try using ARCH_FLAGS as a route to pass extra flags down to the final compiler line. There is ENVCFLAGS for flags to add to $CC and ENVCFLAGSCXX for flags to add to $CXX . D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [LibreOffice][Patch] Replace ASSERT and DBG_ASSERT with OSL_ENSURE + some translations, comment removal
On Thu, Oct 14, 2010 at 09:11:26AM +0100, Caolán McNamara wrote: On Wed, 2010-10-13 at 22:34 +0200, Jacek Wolszczak wrote: http://wiki.services.openoffice.org/wiki/Debug_Levels. Some additional questions. What should I replace DBG_ERROR with? Hmm, DBG_ERROR takes no condition, and just a message, I suggest that DBG_ERROR(horrible failure); can become OSL_ENSURE(false, horrible failure); Yeah, that's the path I've taken in the past. Additionally, I suggest to turn both DBG_WARNING and DBG_TRACE (not that I remember ever seeing either of them :) into OSL_TRACE. Should RTL_LOGFILE_CONTEXT_AUTHOR as in http://bit.ly/buiBlA be updated somehow as it contains a lot of hardcoded e-mail addresses? *shrug*, nah, leave 'em alone I suggest. Given the description of rtl::Logfile: The intended use for class Logfile is to write time stamp information for profiling purposes. Profiling output should only be generated for a special product version of OpenOffice which is compiled with a defined preprocessor symbol 'TIMELOG'. Therefore we have provided a set of macros that uses the class Logfile only if this symbol is defined. If the macros are not sufficient, i.e. you need more then three arguments for a printf style message, then you have to insert an #ifdef TIMELOG/#endif brace yourself. Additionally the environment variable RTL_LOGFILE has to be defined in order to generate logging information. If the variable is not empty, it creates a file with the name $(RTL_LOGFILE)_$(PID).log, where $(PID) is the process id of the running process. It can be used as a run time switch for enabling or disabling the logging. Note that this variable is evaluated only once at the first attempt to write a message. The class LogFile collects runtime data within its constructor and destructor. It can be used for timing whole functions. If you want to write timing data without context you can use the RTL_LOGFILE_TRACE-macros which are defined inside rtl/logfile.h. The class LogFile should not be used directly, instead use the RTL_LOGFILE_CONTEXT/ RTL_LOGFILE_TRACE-macros. , I suggest to scrap them entirely. There are far better ways to profile code, like gprof or callgrind (esp. combined with kcachegrind). OT: This comment // POLICY: Don't use RTL_LOGFILE_PRODUCT_* for your personal logging information. // Be aware that these logs make it into the product shipped to customers. // If you have good reasons for doing this, please contact product management. really amused me :) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Newbie dev question: no rawbuild directory after git clone
I tried this in an empty folder and found that: Yes, rawbuild is created by running make in loroot. And yes, bin/unpack contains code to create the rawbuild directory. (line 310) However, the instructions at http://wiki.documentfoundation.org/Development#Required_Libraries.2FDepscontain no mention of this, and will confuse a novice developer (such as myself. This email is the reason I am now able to build LO from source, which my computer is currently in the middle of doing.) So I guess we need to update both Code_Overview and Development David Norton On Sat, Oct 16, 2010 at 02:01, Michael Meeks michael.me...@novell.comwrote: Hi Terrell, On Fri, 2010-10-15 at 20:07 -0400, Terrell Prude' Jr. wrote: I'm attempting to get a proper development environment to build LibreOffice. Pulled a clone of the git repository, and it looks like I have everything except for the loroot/rawbuild directory. Problem: looks like the rawbuild directory is needed for building LibreOffice. Here's what I did. .. After that, an ls shows everything on the development Wiki page except for rawbuild/. Odd :-) it is possible that rawbuild is created by 'bin/unpack' which is run as you do your first 'make' - if so, we should update the wiki page that describes the directories; can you test see ? http://wiki.documentfoundation.org/Development/Code_Overview Thanks ! Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] final SAL_N_ELEMENTS
On Tue, Oct 19, 2010 at 09:42:17PM +0200, Kenneth Venken wrote: hi, these patches will replace the last occurrences of sizeof(foo)/sizeof(foo[0]) with SAL_N_ELEMENTS(foo) -- Kenneth Hi, I pushed sal_n_elements.libs-gui.diff and sal_n_elements.ure.diff. The changes the other two do seem to have been done already. Oh, and I forgot to set you as the author... I'm really sorry! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] credits page is 403 access forbidden
Hm, I'm a newcomer and at this point of state I can't real help. (I will be a helper for correct spelling German) But let me point out an important issue: Sebastian, Your list isn't correct. It shows only the contributors since the - harding to say - fork. What about all the contributors for the codebase of it? Please have a look here: https://www.ohloh.net/p/libreoffice/contributors Regards and sorry for misspelling English, if so. David___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] suspect code in extentions/sdext/source/presenter/PresenterClock.cxx
On Mon, Nov 01, 2010 at 09:24:09AM +, Caolán McNamara wrote: On Sun, 2010-10-31 at 23:04 -0500, Norbert Thiebaud wrote: ::osl::MutexGuard aSolarGuard (::osl::Mutex::getGlobalMutex()); Paint(rEvent.UpdateRect); I'm thinking I should change this guard with a SolarMutexGuard aSolarGuard; Someone has an opinion on this ? Because it's protecting a Paint which generally would use the VCL drawing/widget stuff which is not thread-safe, (http://wiki.services.openoffice.org/wiki/Terms/Solar_Mutex I reckon you're right and it should be a SolarMutexGuard that's taken there. caolanm-dtardon: Did you have something vaguely similiar in the desktop extension gui-updating thread at one stage, any opinion ? Yes, but the situation here is different. The Paint method is actually defined in the same class and has nothing in common with VCL's Window::Paint. The actual painting is done through Canvas. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Easy Hacks : RTL_CONSTASCII_USTRINGPARAM in libs-core 1
On Thu, Nov 04, 2010 at 09:54:20PM +0100, Gert Faller wrote: Hi, here are some in 'libs-core'. Regards. Thanks! I removed some changes * in BasicManager::SetGlobalUNOConstant, because the variable is function parameter, not a string constant. * in ModuleContainer_Impl::getByName, because the variable is a pointer, not an array (that means sizeof does not return the size you expected) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] build.pl dead code, spelling fixes
On Mon, Nov 08, 2010 at 08:10:51PM -0600, Jordan Ayers wrote: Miscellaneous cleanup to build.pl. Mostly removal of dead code, with a few spelling / German-English fixes. LGPLv3+/MPL Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] 4 patches of rtl goodness
On Tue, Nov 09, 2010 at 03:11:40PM -0500, Kevin Hunter wrote: At 12:44pm -0500 Tue, 09 Nov 2010, Kevin Hunter wrote: Here are four more patch conversions from createFromAscii to RTL_CONST... applied against: basebmp/ binfilter/ bridges/ connectivity/ I apologize, I temporarily forgot about the automatic whitespace handling and flat committed those files. Here's the same payload patches, this time with about 95% less whitespace-only hunks. Sorry about that. Kevin Pushed. Keep them coming! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM in svx
On Tue, Nov 09, 2010 at 09:30:22PM +0100, Joost Eekhoorn wrote: Is it correct to have the RTL_CONSTASCII_USTRINGPARAM directly in the *.hxx file. If so, why not do that also at other places? MPL 1.1 / GPLv3+ / LGPLv3+ Joost Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] more spelling mistakes, dead code removal for Base
On Tue, Nov 09, 2010 at 10:24:20PM +, Wols Lists wrote: Cheers, Wol Looks fine. Pushed. From cb03ee788ea81661ae83ae611806c6050d16af57 Mon Sep 17 00:00:00 2001 -// use keys and indexes for excat postioning Would that mean positioning of a dead cat (aka ex-parrot)? :-D D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] script providers as extensions
Hi all, just a heads up: recently I was working on removing the script providers for BeanShell, JavaScript and Python from standard installation, as they are only marginally useful and (at least on Fedora) require quite a slew of dependencies. So, from now on, they are available as plain extensions (they are still built unconditionally, but maybe we should change even that and add some --enable-ext-foo configure opts for them). The oxts are placed in $SOLARVER/$INPATH/bin/script-provider-for-*.oxt . There should be pkgs created for them by epm, but I admit I haven't tested that part very much. If it breaks something, yell loudly and I'll do what I can to fix it :) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Another bunch of misc spelling mistakes, translations, code removal for Base
On Wed, Nov 10, 2010 at 12:54:32PM +, Wols Lists wrote: Cheers, Wol Pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] RTL_CONSTASCII_USTRINGPARAM in libs-core 5
On Wed, Nov 10, 2010 at 02:16:20PM +0100, Gert Faller wrote: Hi, some more... Regards. Pushed, with several changes from rtl::OUString foo = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(blah)); or rtl::OUString foo(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(blah))); to rtl::OUString foo(RTL_CONSTASCII_USTRINGPARAM(blah)); D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Patch] + Question about compilation warning on sd/source/ui/view/drviewsj.cxx
On Wed, Nov 10, 2010 at 11:53:07PM +0100, julien wrote: Hello, The patch contains only the removing of comments. I haven't removed 1 line of comment because i don't know what Wieder raus mean. Pushed. I would have like to remove a warning too since during compilation, I got this : /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/sd/source/ui/view/drviewsj.cxx: In member function 'void sd::DrawViewShell::GetMenuStateSel(SfxItemSet)': /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/sd/source/ui/view/drviewsj.cxx:301: warning: declaration of 'rMarkList' shadows a previous local /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/sd/source/ui/view/drviewsj.cxx:79: warning: shadowed declaration is here The lines 79 and 301 contain this : const SdrMarkList rMarkList = mpDrawView-GetMarkedObjectList(); So i tried on line 301 to remove const SdrMarkList to have this : rMarkList = mpDrawView-GetMarkedObjectList(); I got this : /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/sd/source/ui/view/drviewsj.cxx: In member function 'void sd::DrawViewShell::GetMenuStateSel(SfxItemSet)': /home/serval/libreoffice-source/build/build/libreoffice-3.2.99.2/sd/source/ui/view/drviewsj.cxx:301: error: passing 'const SdrMarkList' as 'this' argument of 'void SdrMarkList::operator=(const SdrMarkList)' discards qualifiers Perhaps line 301 is just a bad copy-paste but it would be surprising. What do you think ? I removed the latter declaration, because it's initialized to the same thing as the former one anyway, and the if( rMarkList.GetMarkCount() == 1 ) test below it, because this's already been tested on line 81. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] + Question about compilation warning on sd/source/ui/view/drviewsj.cxx
And now once more with PUSHED in subject... D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Canonical has a vacancy for a LibO specialist software engineer
Hi Rene, :-) On Thu, Nov 11, 2010 at 18:23, Rene Engelhard r...@debian.org wrote: On Thu, Nov 11, 2010 at 05:55:44PM +0800, David Nelson wrote: I'm just giving you a heads-up because I was contacted by Jason Warner of Canonical ([1]jason.war...@canonical.com and jasoncwarner on Freenode) And because of this you spam this list with a unsolicited job offer? Well, I did not think of it as *spamming* as such, because it concerns a vacancy of specific interest to LibO developers, with one of the projects valued supporters and partners, and I am *certain* there are guys out there who will be interested in the idea. :-) David Nelson ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Replaced createFromAscii with RTL_CONSTASCII_USTRINGPARAM in /dbaccess/source/ in base repo
On Thu, Nov 11, 2010 at 06:03:31PM -0300, Santiago Alessandri wrote: Hi! I'm attaching the patch for changing the use of createFromAscii with RTL_CONSTASCII_USTRINGPARAM in the directories: /dbaccess/source/shared/ /dbaccess/source/ui/app/ /dbaccess/source/ui/browser/ /dbaccess/source/ui/control/ /dbaccess/source/ui/dlg/ /dbaccess/source/ui/misc/ from the base repository. Released under LGPLv3+ / MPL. -- Santiago Alessandri I only changed lines like rtl::OUString aFoo = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(blah)); to rtl::OUString aFoo(RTL_CONSTASCII_USTRINGPARAM(blah)); , which is the form we prefer. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM for calc_ui
On Thu, Nov 11, 2010 at 07:45:53PM +0100, Julien Nabet wrote: Hello, Here's a patch for calc/sc/source/ui (except unoobj previously sent). Julien. (LGPLv3+ / MPL) Good, but I changed lines like rtl::OUString foo = rtl::OUString(RTL_CONSTASCII_STRINGPARAM(foo)); to rtl::OUString foo(RTL_CONSTASCII_STRINGPARAM(foo)); , which is the form we prefer. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Remove bogus comments in libs-gui
On Fri, Nov 12, 2010 at 12:50:37PM +0500, Alexander O. Anisimov wrote: Hi all, patch is in attachment .''`. With best regards, : :' : Alexander Anisimov `. `' JID alenyas...@gmail.com `- Debian - when you have better things to do than fixing systems Wonderful! Keep them coming! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Easy Hacks : RTL_CONSTASCII_USTRINGPARAM in libs-core 6
On Fri, Nov 12, 2010 at 07:44:28PM +0100, Gert Faller wrote: Hi, another patch for libs-core. Regards. Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM for writer_starmath
On Fri, Nov 12, 2010 at 11:22:06PM +0100, Julien Nabet wrote: Hello, Here's a small patch as there was only 1 file in the starmath part which needed modifications. Julien. (LGPLv3+ / MPL) Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Proposal: Enhancements in Easy_Hacks Wiki Page
Hi*, I'm quite sure, I'm on the wrong list because I am not a developer, but reading this list is a private fun and a remember of an old time 15 years ago. Back to topic again: I found that the Wiki Page needs some improvements for the view of all people reading: Here I have 4 proposals after the skills I could insert: 1) Still working here: - names of volunteers 2) Need more help in: - e.g. calc isn't reviewed, than calc 3) coordinator for this issue: - contact the maintainer 4) work in progress - percent of DONE or some in this mind. I can't write just one line of C++ or another computer language, but I can help to maintain the wiki, helping QA and translation to German and yes, if you find a German string you can't translate and need it for a perfect patch, please contact me, just for 3 words if needed. Regards/Greetings David ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSH] Replaced createFromAscii with RTL_CONSTASCII_USTRINGPARAM in base repo
On Sat, Nov 13, 2010 at 12:53:43PM -0300, Santiago Alessandri wrote: With this patch I think there are no more misuses of createFromAscii in the base repository. It is released under MPL 1.1 / GPLv3+ / LGPLv3+ -- Santiago Alessandri Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [gentoo-dev] LibreOffice project: request for contributors and mentoring
Hi, :-) After I posted on the Gentoo devs list, there was this reply, which I'm posting here. I was wondering whether someone from the LibreOffice devs would like to jump in and respond? (I posted this follow-up to both lists.) To sign up for the Gentoo devs list: gentoo-...@lists.gentoo.org To sign-up for the LibO devs list: http://lists.freedesktop.org/mailman/listinfo/libreoffice To view this message entirely: http://archives.gentoo.org/gentoo-dev/msg_6d65d86d8ff498eedb95435c35fc4fad.xml On Fri, Nov 12, 2010 at 09:13, Stuart Longland wrote: On Thu, Nov 11, 2010 at 05:40:03PM +0800, David Nelson wrote: A number of Linux distributions have announced their intention to ship LibreOffice with their future releases. We know that they frequently do re-branding work to integrate their chosen office suite in lines with their project's thinking. So we are keen to involve you in our project branding and development, so that we ship releases that better fit your needs. Do we even brand OpenOffice? I can't spot the difference between the self-built OpenOffice.org binary I have, and the official Sun binary I had previously. My concern with LibreOffice would be more to do with compiling it... it'd be a nice package to have on the Yeeloong, but AFAIK it needs Java..? Something I've been trying to bootstrap unsuccessfully for the best part of two years now. (gcj-jdk is a long way from usable, and there's a chicken-egg issue with icedtea6.) It also needs _lots_ of RAM and disk space ... not a plentiful resource on MIPS. HTH. David Nelson ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM in svx
On Sat, Nov 13, 2010 at 09:43:18PM +0100, Joost Eekhoorn wrote: MPL 1.1 / GPLv3+ / LGPLv3+ Joost Pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM for libs-core/connectivity
On Sat, Nov 13, 2010 at 10:44:36PM +0100, Julien Nabet wrote: Hello, Here's again a small patch for the last changes to do that I've seen in libs-core/connectivity Julien. (LGPLv3+ / MPL) Pushed. I have changed two lines: -::rtl::OUStringBuffer sVal= (::rtl::OUStringBuffer) ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(0x)); +::rtl::OUStringBuffer sVal(::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(0x)); and -::rtl::OUStringBuffer aSql = rtl::OUString::createFromAscii(CREATE TABLE ); +::rtl::OUStringBuffer aSql(::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(CREATE TABLE ))); D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SW build error
On Sun, Nov 14, 2010 at 12:52:39PM +0100, Gert Faller wrote: Hi, I get a build error in sw : with : 'sw/source/filter/rtf/rtffly.cxx' 1311 error: 'PictPropertyNameValuePairs' has not been declared PictPropertyNameValuePairs is only a typedef in ' libs-core/editeng/inc/editeng/svxrtf.hxx' It seems it due to the last commit in writer. Just rebuild svtools and editeng before. The typedef has been newly added too, so the header file in your solver doesn't contain it. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM in svx
On Sun, Nov 14, 2010 at 08:32:31PM +0100, Joost Eekhoorn wrote: MPL 1.1 / GPLv3+ / LGPLv3+ (Hope 13e patch on the 13 has no mistakes in it:) ) Joost Thanks, pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM cleaning in components - dialogs
On Sun, Nov 14, 2010 at 09:36:08PM +0100, Pierre-André Jacquod wrote: regards MPL/ GPLv3+ / LGPLv3+ pjacquod Again, I changed lines like rtl::OUString foo = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(foo)) to rtl::OUString foo(RTL_CONSTASCII_USTRINGPARAM(foo)) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] + question RTL_CONSTASCII_USTRINGPARAM for libs-core/connectivity/source/drivers/adabas/
On Sun, Nov 14, 2010 at 10:57:57PM +0100, Julien Nabet wrote: Hello, Here's a patch (LGPLv3+ / MPL) for libs-core/connectivity/source/drivers/adabas/ Pushed. Concerning the file connectivity/source/drivers/adabas/Buser.cxx, in the function : ::rtl::OUString OAdabasUser::getPrivilegeString(sal_Int32 nRights) const from the file : connectivity/source/drivers/adabas/Buser.cxx Should'nt there be a block like this for INSERT part (at the beginning of the function) : if(sPrivs.getLength()) sPrivs += ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(,)); ? No, because you do know that the length is 0 .-) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Preferred indentation for LibreOffice
On Sun, Nov 14, 2010 at 07:44:30PM -0300, Júlio Hoffimann wrote: Hi, I was looking Starmath code and see a new indentation style: */* vim:set shiftwidth=4 softtabstop=4 expandtab: */* * * This will be the preferred style for LibreOffice project? Yes, this is the preferred style. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Clean code at writer [source/core/layout]
On Mon, Nov 15, 2010 at 01:05:43PM -0800, Kayo Hamid wrote: Hello, please can someone review this? I do not known exactly what I need to remove or not, so I'll known a bit more after someone reviewing it. So I'll be able to clean better and at once. I pushed it. Nice big chunk of dead code removed. Keep them coming :) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Re: Problem building sw (writer) in debug mode under Linux
On Tue, Nov 16, 2010 at 05:22:48PM +0100, Giuseppe Castagno wrote: Tor Lillqvist wrote: Now what it's the right flag to use to surround a debug specific code: OSL_DEBUG_LEVEL 1 or DBG_UTIL ? I recently did a build with --enable-dbgutil so that it would use the debugging C++ library on Windows. (As such that was mostly useless, it didn't help me find the cause of the problem I was seeing.) (I did not use --enable-debug or any debug=x options to individual build commands, which would have set OSL_DEBUG_LEVEL, too.) That build revealed several places in the code where as far as I could see there was a mixup between these two things and I got compilation errors. I fixed things up so that my --enable-dbgutil build compiled and linked. But it is entirely possible that this then broken stuff for a build with just --enable-debug or debug=true but not --enable-dbgutil. I confess I'm a little confused :-). So am I, and disgusted. I am not sure at all that we really want to keep this distinction between --enable-dbgutil and --enable-debug (and then there is also --enable-symbols) in LibreOffice. Nobody understands it. I added a patch that should refine the work started by tml and others re: DBG_UTIL - OSL_DEBUG_LEVEL mixup. The patch changes some of the DBG_UTIL to OSL_DEBUG_LEVEL, so they won't break the build with debug=true. Though a couple of warning popped up while building in debug mode. beppec56. Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Disable GCC optimizations when building with --enable-symbols
On Thu, Nov 18, 2010 at 03:19:39AM -0700, Tor Lillqvist wrote: On a related note, what is your take on --enable-dbgutil vs. --enable-debug? Are they designed to do clearly separate things? IMHO no. Both allow to: * use assertions * insert arbitrary debugging code that is only present in 'special' builds: #ifdef DBG_UTIL and #if OSL_DEBUG_LEVEL n * track object lifetime: that's what all these DBG_CHKTHIS, DBG_CHKOBJ, DBG_NAME etc. in vcl, sfx2, svtools and maybe in a few other places are for. OSL's counterpart is osl::DebugBase, that is AFAIK only used at a few places in sd. (And we have valgrind for that anyway, don't we?) * profile code (isn't there enough profilers available?) Do people in general understand the difference? IMHO the main difference is that DBG_ family is older and bound to VCL (it has that configuration dialog that can be started by Ctrl+Shift+Alt+D in non-pro build ... but hardly anyone would know what to do with it anyway .-) If either answer is no, should these two concepts be merged? I'm fully for discarding the old DBG_* tools entirely. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Disable GCC optimizations when building with --enable-symbols
On Wed, Nov 17, 2010 at 03:50:33PM -0300, Santiago Bosio wrote: Hi! When LibO is built using --enable-symbols, it still uses -O2 optimizations, making hard to debug execution with GDB. You can export nopt=true before building to turn optimizations off. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] use dbglevel=1 for --enable-debug builds?
Hi all, currently, configuring with --enable-debug means that dbglevel is set to 2, which in turns means that OSL_DEBUG_LEVEL is set to 2. This enables all the OSL_ debugging stuff there is (well, maybe there is some really rare stuff that is only enabled for OSL_DEBUG_LEVEL 2, but I don't know about any), which spews unbelievable amount of stuff on stdout. If we used dbglevel=1 as default, only assertions would be enabled and the output would be much more manageable (practically nonexistent in most cases, from my experience). My hope is that more devs would just be configuring with --enable-debug and using/fixing assertions. The full debug build would still be easily available: one would just run build -- dbglevel=2 in the desired module similarly as one runs build -- debug=true today. From impl. standpoint: AFAIK this would require one-line change in solenv/inc/settins.mk . As an alternative, we could add optional level argument to --enable-debug or add another option, say, --enable-assertions, that would do the same thing as --enable-debug and export dbglevel=1 in addition. Both would require change to configure.in and set_soenv.in (to export proper dbglevel). I would accept either of these two, but IMHO it is complicating things too much. Opinions? D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] More clean code at writer [source/core/{docnode, draw, edit}]
On Thu, Nov 18, 2010 at 12:12:41PM -0800, Kayo Hamid wrote: Sorry ;-) Hello, sending this for review. I think that cleaniness is better than the previous. revol_ Pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] LibreOffice Beta 3
I am running LibreOffice Beta 3 under Ubuntu 10.10 (64-bit) and it seems to gradually bog down with use, so that I have to exit and restart it several times a day. It gets so that cursor movement is very slow. This was also a problem with Beta 2, and I was hoping that Beta 3 would fix it, but not so... ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] RTL easy hack against bridges/
On Fri, Nov 19, 2010 at 10:11:49AM -0500, Kevin Hunter wrote: Hullo List, A simple one against but test cases, but, as I said in the commit message, they were in my (grep) road! Kevin Pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Location of SfxPoolItem.Type() method
On Sun, Nov 21, 2010 at 12:21:08AM +1100, Mattias Johnsson wrote:
Hello all,
I've been trying to fix a bug in the search and replace code, and
after a bit of hacking have discovered that in findattr.cxx there's a
function
int CmpAttr( const SfxPoolItem rItem1, const SfxPoolItem rItem2 )
{
...
return rItem1 == rItem2;
}
In the bugged case this returns true, and in the correctly functioning
case it returns false. I'm trying to figure out exactly how rItem1 and
rItem2 differ in the correct case to help me find out what's wrong in
the bugged case.
If I'm understanding things correctly, and I may not be, since the
search and replace code is quite convoluted, in this case these
SfxPoolItems are lists of attributes that one can search and replace
for; in this case I'm searching for a specific font size and replacing
it with another.
The overloaded comparison operator is defined as
int SfxPoolItem::operator==( const SfxPoolItem rCmp ) const
{
DBG_CHKTHIS(SfxPoolItem, 0);
return rCmp.Type() == Type();
}
but for the life of me I can't find out where the Type() method is defined.
Does anyone have any pointers?
The SfxPoolItem::operator== is virtual, so you may actually need to look
at the definition in some derived class.
set print object on
p rItem1
p rItem2
in gdb in the CmpAttr func will tell you the real classes of the items.
Or, alternatively, you can step into the operator.
D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM for libs-core/framework
On Sun, Nov 21, 2010 at 08:39:42AM +0100, Julien Nabet wrote: Hello, Here's a patch for libs-core/framework Julien. (LGPLv3+ / MPL) Thanks, pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] some cleanup #if 0 deletion
On Sat, Nov 20, 2010 at 11:20:34PM +0100, Pierre-André Jacquod wrote: Hello, was just tired to try reading code like: #if 0 read a lot here #else cool I will be compiled #endif So I started to track it down systematically. Just hope I was not to much aggressive. So I submit for review / proposal this first pack in little chunk. Will be easier to reject some part... regards ps : really boring to do this #if 1 ps2: never though there are so many places like this #endif I left out a couple of hunks that removed (potentially) useful comments and a couple of others that removed TODO code. Someone with detailed knowledge of calc (hi, Kohei :) should look at these and decide if they can still be useful. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM in svx
On Mon, Nov 22, 2010 at 07:37:28AM +0100, David Tardon wrote: On Sun, Nov 21, 2010 at 02:58:35PM +0100, Joost Eekhoorn wrote: MPL 1.1 / GPLv3+ / LGPLv3+ Joost The patch contains duplicate changes for svx/source/fmcomp/fmgridif.cxx and svx/source/gengal/gengal.cxx .-) Otherwise good. Update: not pushed :( Gert Faller has already done those changes. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM for libs-core/scripting + SAL_N_ELEMENTS (last one ?)
On Sun, Nov 21, 2010 at 04:20:26PM +0100, Julien Nabet wrote: Hello, Here's a patch for libs-core/scripting + 1 patch for filter_msfilter (I thought i did it before but i must have deleted it by mistake). It seems, by reading the result of grep, it's the last SAL_N_ELEMENTS macro to put in place. So it would be a task to put in Completed_easy_hacks. Someone to confirm (or to tell where the last ones are) ? Julien. (LGPLv3+ / MPL) Pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] use dbglevel=1 for --enable-debug builds?
On Thu, Nov 18, 2010 at 01:08:49PM +0100, Sebastian Spaeth wrote: On Thu, 18 Nov 2010 13:01:42 +0100, David Tardon wrote: 1) one would just run build -- dbglevel=2 in the desired module similarly as one runs build -- debug=true today. 2) As an alternative, we could add optional level argument to --enable-debug or add another option, say, --enable-assertions, that would do the same thing as --enable-debug and export dbglevel=1 in addition. 2) is more complicated, but also more discoverable and explicitely documented. I dislike secret ENVVARIABLE incarnations that enable things and not easily discoverable without trawling through READMEs. But you'd need the variable anyway, because, as I have said, full dbglevel=2 build is hardly a sensible thing to do. You'd be drowned in the output :-) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] quickstarter causes crash on end of desktop session
Hi all, we have been getting quite a lot of crashes from abrt (crash catching and reporting tool) on Fedora that had been caused by XIOError. After some investigation, we have found that they are caused by quickstarter continuing to run after end of desktop session (see https://bugzilla.redhat.com/show_bug.cgi?id=650170, comments 5-14). The fix lets quickstarter shutdown the process when it gets destroy signal and avoids recursive call of Desktop::terminate. I've pushed the fix to libs-core, changeset 5dfa2bcf6f4a7699c2acae87caa96de739f82636 . Question: do we want that in 3.3? D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] quickstarter causes crash on end of desktop session
On Mon, Nov 22, 2010 at 11:45:16AM +, Michael Meeks wrote: On Mon, 2010-11-22 at 09:42 +, Caolán McNamara wrote: *I* think we should try and fix it in LibreOffice 3.3 seeing as we're flooded with these over in RH land. Agreed, if I never see the crash recovery dialog on re-start again, it will be too soon :-) I'm assuming that we should merge obvious crasher fixes until RC1 is out. Okay, pushed this to 3.3. Thanks for your comments! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Removed some commented out code
On Mon, Nov 22, 2010 at 06:52:47PM +0200, Timo Heino wrote: Check attachment and comments please. (so i know can i search more these) Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Location of SfxPoolItem.Type() method
On Tue, Nov 23, 2010 at 04:14:01PM +1100, Mattias Johnsson wrote: On a semi-related note, I'm doing a lot of stepping through the search and replace code trying to track the problem down. Because LO seems to be compiled using -O2 and -O3, there's a lot of optimization which means the way the code gets stepped through is often bizarre, and the values of useful variables have been optimized out by the compiler. Is there a simple option for building the LO project using a lower optimization level? I can't seem to find one... You can either do nopt=true make or reconfigure with --enable-debug (debug build only enables assertions by default since yesterday, so the amount of output is quite manageable). D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] OSL_DEBUG_LEVEL question
On Mon, Nov 22, 2010 at 11:33:42PM +0100, Miklos Vajna wrote: On Mon, Nov 22, 2010 at 10:38:31PM +0100, Miklos Vajna vmik...@frugalware.org wrote: Does anyone have an idea when (and why) this changed, and what's the new way of getting the OSL_TRACE() output? Oh, I guess this is related to David's recent 47d0946 in bootstrap.git. The attached patch fixes the problem for me - David, OK to push? Thanks. Please, don't! The whole purpose of the change was to get more manageable debugging output by default, i.e., only assertions. You can see my reasoning in message I sent to the ML last week: http://lists.freedesktop.org/archives/libreoffice/2010-November/002894.html (for some reason I only see a half of the message there...). The new way to do a full debug build in a module is build -- debug=t dbglevel=2 or, if you've configured with --enable-debug, build -- dbglevel=2 D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] remove dead codes and undesired comments
On Tue, Nov 23, 2010 at 02:01:57PM +0900, Takeshi Abe wrote: Hi, Easy Hacks on base, some of indentions are left unchanged for clarity. Thanks! I pushed it except one hunk containing the magical word TODO :) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [stephan.bergm...@oracle.com: Re: [releases] Minutes for release status meeting from 2010-11-15]
Hi, :-) On Tue, Nov 16, 2010 at 21:03, Rene Engelhard r...@debian.org wrote: The effect is that an office installation based on OOo before 3.3 cannot share a URE installation with an office installation based on OOo 3.3 or later. Sharing URE installations is only relevant on Linux and Solaris, not on Windows and Mac OS X, and is probably more of theoretical than practical concern. Do you happen to have any more information about this? Could you maybe explain what the implications are, please? Thanks if so. :-) David Nelson ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] RTL_CONSTASCII_USTRINGPARAM for components/cui
On Tue, Nov 23, 2010 at 10:14:03PM +0100, Julien Nabet wrote: Hello, Here's a patch for components/cui. I made this : git commit -a git format-patch HEAD~1 Hope it's ok. Julien. (LGPLv3+ / MPL) Nice, pushed! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] timers in calc
On Wed, Nov 24, 2010 at 08:14:08AM +0100, Julien Nabet wrote: Le 24/11/2010 08:11, Julien Nabet a écrit : Date: Tue, 23 Nov 2010 22:20:36 -0500 From: Kohei Yoshidakyosh...@novell.com Subject: Re: [Libreoffice] [PATCH] try to correct some timers in sc + question To:libreoffice@lists.freedesktop.org Message-ID:1290568836.2532.14.ca...@localhost Content-Type: text/plain; charset=UTF-8 Hi Julien, On Sat, 2010-11-20 at 01:19 +0100, Julien Nabet wrote: Hello, Here's a try to correct some timers in scmod.cxx. Here's what I did and why. 1) In IMPL_LINK( ScModule, SpellTimerHdl, Timer*, EMPTYARG ) I just added aSpellTimer.Stop() when there's neither input from keyboard nor ContinueOnlineSpelling. + I changed the function to have 1 return only. 2) In IMPL_LINK( ScModule, IdleHandler, Timer*, EMPTYARG ) I removed all the things with bSpell since it seems that ContinueOnlineSpelling is managed by SpellTimerHdl I'd like to add a stop but i'd like first to understand what's the use of all the SC_IDLE_STEP, SC_IDLE_MAX, nIdleCount... I repeat, this patch is just a try. If I'm all wrong, sorry for the noise and please, explain my mistakes. Well, I applaud your attempt to challenge this rather difficult task, and sorry it took me so long to get back to you. I took a closer look at this issue, and while I don't yet have a complete picture of how this can be fixed, I can at least see that the problem is not with the spell check timer, but the idle timer. The spell check timer itself actually turns itself off rather nicely after it does what it needs. The idle timer, OTOH, keeps on running pretty much forever. I guess my previous comment about the spell check timer may have given you the wrong impression. Sorry about that. So, let's not change the spell check timer since it doesn't look broken, and let's focus on fixing the idle timer itself. Hello, To know how to fix the idle timer I'd like first understand well how it works since it seems to be simpler than idletimer. Could you tell me when and how the spelltimer is stopped ? (I haven't seen where it had a stop). Julien. Hi Julien, a timer is stopped after it expired, unless it's explicitly restarted or unless it's an auto timer (see Timer::ImplTimerCallbackProc in vcl/source/app/timer.cxx). If you look at sc/source/ui/app/scmod.cxx, you see that aSpellTimer is only restared (in SpellTimerHdl) if there is a fresh keyboard input or if spell checking of the whole sheet hasn't been finished yet, but aIdleTimer is restarted (in IdleHandler) unconditionally. HTH, D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] quick starter applet/systray defaults and various confusion
Yet another argument for quickstarter not being on by default is that it doesn't survive update, i.e., 1. start quickstarter 2. update OO.o (or LibO) 3. try to create new text document through quickstarter (or click on existing one, or... do whatever else) - crash (see https://bugzilla.redhat.com/show_bug.cgi?id=610103; 63 users in CC currently). Does anyone have any clever idea how to prevent that? D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] timers in calc
On Wed, Nov 24, 2010 at 11:37:53PM +0100, Julien Nabet wrote: You said that aSpellTimer is only restarted in SpellTimerHdl but i saw line 1915 in the function IMPL_LINK( ScModule, IdleHandler, Timer*, EMPTYARG ) BOOL bSpell = pDoc-ContinueOnlineSpelling(); if ( bSpell ) aSpellTimer.Start();// da ist noch was What I meant was restarted during run of the handler. I wanted to show the difference between the two timers: the idle timer is restarted _always_, but the spell timer may or may not be restarted, depending on circumstances. Of course the timer may be started from another place, otherwise it wouldn't be possible to run it again once it stopped. Is it normal we find a Start calling of aSpellTimer in IMPL_LINK of IdleHandler ? The spell timer must be restarted when there is something new to check spelling of. I suppose it's done from idle timer because it's convenient: the idle timer is always running and it's in one place. For the rest, i understand that aIdleTimer is always started because of this following line at the end of this same function, there's an unconditionnal : aIdleTimer.Start(); It could help if we had the english translation of german comments (i know there's currently an easy task for this and that it must be quite tedious to translate all the comments) but could someone just translate this ? // ueberhaupt noch was? and above all, this ? // SC_IDLE_COUNT mal mit initialem Timeout, dann hochzaehlen Perhaps just an idea for this timer. If it should be started only if there's something to do, i'd move these lines : aIdleTimer.Start(); return 0; at the end of the block : if ( bMore ) That would mean the timer runs while there is something to do, then stops and is never started again, which is obviously wrong. The timer will have to be started from other parts of code, when the right conditions are recreated (or maybe just started unconditionally; it will stop immediately if there is nothing to do, anyway). Don't ask me what the other parts are; I don't know that .-) As for the spell timer, the right place to restart it could be ScInputHandler::KeyInput or ScTabViewShell::KeyInput. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Clean code at writer [source/ui]
On Wed, Nov 24, 2010 at 12:52:19PM -0800, Kayo Hamid wrote:
Covering
source/ui/{app,cctrl,chrdlg,config,dbui,dialog,dochdll,docvw,envelp}, sending
for review. Curiously 'ui' is the most clean I have seen.
revol_
Pushed with some changes.
D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Fwd: Extensions code cleanup with patch
On Thu, Nov 25, 2010 at 10:15:52PM +0200, Roth Robert wrote: -- Forwarded message -- From: Roth Robert robert.roth@gmail.com Date: Thu, Nov 25, 2010 at 9:27 PM Subject: Extensions code cleanup To: libreoffice@lists.freedesktop.org Some more dead code and bogus comments removed from extensions. The license, as always is LGPLv3+ / MPL. --- a/extensions/source/ole/unotypewrapper.hxx +++ b/extensions/source/ole/unotypewrapper.hxx @@ -36,7 +36,7 @@ #define _WIN32_WINNT 0x0403 #define _WIN32_DCOM #if OSL_DEBUG_LEVEL 0 -//#define _ATL_DEBUG_INTERFACES + #endif #include atlbase.h extern CComModule _Module; I've done -#if OSL_DEBUG_LEVEL 0 -//#define _ATL_DEBUG_INTERFACES +#if OSL_DEBUG_LEVEL 2 +#define _ATL_DEBUG_INTERFACES instead. No reason the debugging shouldn't be available when someone needs it. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Are ISC/BSD-licensed contributions acceptable?
On Thu, Nov 25, 2010 at 12:52:49PM +, Michael Meeks wrote: On Mon, 2010-11-22 at 09:47 +0100, Gioele Barabucci wrote: in bug #31633 I proposed a patch to one of the export filters. I've just committed it; sorry for delay. It's great to have you prodding at this piece of the code. One of the sad things about the XSLT filters is that they require Java - yielding not only a performance problem, but a nightmare for those without Java installed. Perhaps this underlies some reluctance here too: https://bugs.freedesktop.org/show_bug.cgi?id=31624 around associating with this file type by default (in case you have no working Java). It would be simply wonderful to re-use the libxslt code (that we already ship) for the XSLT filter. I wonder if you might be interested in that ? if not - adding an easy hack to the wiki would be good [ and pointing me at it so we can add some code pointers as to how to do that ]. I think that's not possible, because some of the filters (like WordprocessorML) use XSLT 2.0, which is not supported by libxslt (wasn't supported the last time I looked, at least). So either we throw out (or rewrite to XSLT 1.0) all XSLT 2.0 filters and declare that we only support XSLT 1.0 or we're stuck with saxon (and java). D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice WikiHelp
Hi Kendy, :-) On Fri, Nov 26, 2010 at 17:19, Jan Holesovsky ke...@suse.cz wrote: Hi David, On 2010-11-26 at 16:44 +0800, David Nelson wrote: I suppose that logically this is something for the documentation team to get involved in... We're having a phone conference this weekend... Shall I add it to the agenda? Indeed - that would be cool! I am not sure if I can show up on the call this weekend, but will try to - are there any details when / how to join? If you need a docs person to liaise with about this, please feel free to include me in the loop. Sure, will do. Thank you, Kendy All the details are here [1]. Feel free to jump in and add to the agenda. ;-) [1] http://wiki.documentfoundation.org/Documentation/ConfCalls David Nelson ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice WikiHelp
Hi, :-) On Fri, Nov 26, 2010 at 18:22, Jonathan Aquilina eagles051...@gmail.com wrote: how do you guys carry out the conference calls are they carried out on skype? It's on Talkyoo, Jonathan. David Nelson ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice WikiHelp
Hi Kendy, :-) On Fri, Nov 26, 2010 at 17:19, Jan Holesovsky ke...@suse.cz wrote: I suppose that logically this is something for the documentation team to get involved in... We're having a phone conference this weekend... Shall I add it to the agenda? Indeed - that would be cool! I am not sure if I can show up on the call this weekend, but will try to - are there any details when / how to join? OK, I've added the subject of WikiHelp to the docs confcall agenda [1], so we have this on the radar. HTH. ;-) David Nelson [1] http://wiki.documentfoundation.org/Documentation/ConfCalls#Agenda ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice WikiHelp
Hi, :-) On Fri, Nov 26, 2010 at 21:04, Christian Lohmaier lohma...@googlemail.com wrote: (BTW, *where* is this Pootle web to be found?) It would help to write why the answer: http://pootle.documentfoundation.org/ (alias http://translations.documentfoundation.org/ ) didn't make you happy... Sorry, I was trying to multitask on a client's job and this thread at the same time... Thanks for *all* the answers! :-D I got what I need to reflect on ATM. ;-) David Nelson ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice WikiHelp
Hi Sophie, Kendy, Christian, :-) Thanks for the answers and info... I'll talk about this with other docs people, and we'll probably have input about this in a couple of days... David Nelson ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice WikiHelp
Hi, :-) I suppose that logically this is something for the documentation team to get involved in... We're having a phone conference this weekend... Shall I add it to the agenda? If you need a docs person to liaise with about this, please feel free to include me in the loop. David Nelson On Fri, Nov 26, 2010 at 16:00, Jan Holesovsky ke...@suse.cz wrote: Hi Christian, On 2010-11-25 at 22:24 +0100, Christian Lohmaier wrote: Hm... how will the help be exported? What's easiest for you? MediaWiki, any other interface? The question is whether you want people to just read the content there, or whether you want people to update content. I'd say: provide only readonly access, maybe with a commenting feature, but keep the editing to pootle. Let me actually take this to the ML, because this is a really good question, and I probably did not explain much about the WikiHelp so far. So first - what is WikiHelp? It is going to be a help.libreoffice.org site, where the LibreOffice help will be stored. The intention is that it will be a Wiki - because the Wiki concept and format is widely used for information exchange, and because it is so easy to edit and improve. For the first cut, it will be read-only, to debug the converter; I'll announce it in a few days for feedback + testing. In the long run [around LibreOffice final ;-)], we should allow editing there when 'good enough', so that the wikihelp becomes the source of the help for LibreOffice, instead of the xhp files. I am still doing the final experiments there, but the hope is that I'll get it to the state where the developer can just commit code that should have some help, provide a stub article, and the first time a user hits that, she/he can update it with more information. And the off-line (installed) help will be generated from this wikihelp in the next releases. Additionally, thanks to wiki being versioned, we will still be able to merge changes from OOo. I can imagine that getting the help files into a wiki require some manual work, so we should chose the web interface that's easiest for us to use. :-) Simplest would probably just a small xstl conversion to html of the application help files. The tooling is now written, just needs testing and polishing: cd clone/help/helpcontent2 ./help-to-wiki.py And you'll see the current result in a wiki/ subdir. Whoever interested in this - patches appreciated! :-) Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Remove dead codes and confusing comments
On Sat, Nov 27, 2010 at 01:56:33AM +0900, Takeshi Abe wrote: Hi, More cleanup on base. Cheers, -- Takeshi Abe Pushed, thanks! D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Are ISC/BSD-licensed contributions acceptable?
On Sat, Nov 27, 2010 at 12:02:18AM +, Wols Lists wrote: On 26/11/10 09:05, David Tardon wrote: I think that's not possible, because some of the filters (like WordprocessorML) use XSLT 2.0, which is not supported by libxslt (wasn't supported the last time I looked, at least). So either we throw out (or rewrite to XSLT 1.0) all XSLT 2.0 filters and declare that we only support XSLT 1.0 or we're stuck with saxon (and java). Just throwing an idea out ... There's a lexer/parser project called Antlr that creates either Java or C++ back ends. They may (or may not) already have an XSLT 2 parser etc. Is that worth investigating? If they've got it, it'll give us a tree for free that we'll then have to analyse ourselves. Not at all. XSLT _is_ XML, therefore a parser is relatively trivial thing. What we need is XSLT 2.0 processor... D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Clean code at writer [source/ui]
On Fri, Nov 26, 2010 at 02:02:16PM -0800, Kayo Hamid wrote:
Covering {fldui,fmtui,frmdlg,globdoc,index,lingu,misc}, sending for review.
My patchs are ok? I see so many changes, I want to known if i'm doing
something wrong.
revol_
Pushed.
D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] libreoffice3.3-freedesktop-menus-3.3.1.noarch.rpm - what distri is this for
Hi Christian, :-) On Sun, Nov 28, 2010 at 08:36, Christian Lohmaier lohmaier+libreoff...@googlemail.com wrote: for all distros that support the freedesktop specifications/recommendations. Nowadays more or less every distro follows them/supports them, so that one should be usable on any distro. But at the time it was added to OOo, many distros did use their own magic to have their desktop-environments be aware of installed/removed applications and had their own way of registering mimetypes. The freedesktop.org specifications/proposal did standardize this to some well known paths and utilities to update that info. Affected are the icon-theme specification, the mime-types one and the one for the desktop files (application launcher definitions) Thanks for that info. I've included a note about this in the revised readme I've drafted. David Nelson ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] opening oxt from command line
On Mon, Nov 29, 2010 at 05:02:06PM -0500, Arno Teigseth wrote: Hi I have LibreOffice 3.3.0 OOO330m9 (Build:1) libreoffice-build 3.2.99.2 It hangs when I do libreoffice extension.oxt from the command line. No error messages on stdout. Adding the extension from the menu Tools | Extension manager works fine. Arno Thanks for the report! Confirmed. I'll look into it. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Last patch to clean code at writer [source/ui]
I retained some hunks that IMHO have documentary value. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Last patch to clean code at writer [source/ui]
On Tue, Nov 30, 2010 at 04:46:47PM +0100, David Tardon wrote: I retained some hunks that IMHO have documentary value. ... and pushed the rest, too .-) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LO status bar annoyances
On Tue, Nov 30, 2010 at 11:26:54AM +0100, Sebastian Spaeth wrote: - I have to single-click on the INSRT and STD-EXT-ADD-BLK and language selection thingies, but to double-click on the Page 1/1 and Default for something to happen. I just found out by coincidence today that I can launch some action for the latter. - Despite being a heavy writer user, I have no clue what EXT/ADD/BLK mean, or what they are being used for (so I never use it). They have no tooltip whatsoever to give me a clue either. The toolbar help button unfortunately launches the generic help, rather then the more useful what's this. In a what's this mode, I do see a tooltip help (why not always), saying this is about the selection mode. What the selection mode EXTEND, ADD, or BLOCK are, I have still no clue about. Perhaps a right-click on that thing could offer to open a more elaborate help page? (keep the tooltip always in any case). EXT extends the current selection to the new position of cursor (really nice for selecting long chunks of text) ADD is for creating multiselections BLK selects (roughly) rectangular blocks (is this useful for anything?) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice WikiHelp
Hi, :-) I was just wondering if there are any updates about progress with the WikiHelp? ;-) David Nelson ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [libreoffice-documentation] LibreOffice WikiHelp
Hi Kendy, :-) On Tue, Dec 7, 2010 at 00:04, Jan Holesovsky ke...@suse.cz wrote: Hi, I am sorry - I promised the LibO online help (WikiHelp) already the last week, but it haven't happened; it needed more work than anticipated :-( Either way, the good news is that I am currently uploading the files, and I'll make the site online as soon as it finishes, and I do few trivial checks; it should be later today (ETA 5 more hours, I am populating the database through the Mediawiki API, not directly). So far I am uploading only the English version. It will be read-only until RC2, so that it is easy to report bugs against the tooling that converts the help from the format that is used in the source code. After RC2, I plan to open it for your edits improvements :-) That's great... I'm sure we'll all be looking forward to seeing it. ;-) David Nelson ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg
Hi, Michael, On Mon, Dec 06, 2010 at 03:59:17PM +, Michael Meeks wrote: Hi David, On Mon, 2010-12-06 at 15:18 +0100, David Tardon wrote: On Mon, Dec 06, 2010 at 02:08:36PM +, Michael Meeks wrote: Really ? as soon as the X server dies, we'll get all manner of XErrors that will kill us nastily; I don't see a feature there, but perhaps I'm missing it. And that dying on XIOError is something we (i.e., Caolan and me) wanted to avoid. Sure - but I don't believe you'll do that here; And you're absolutely right--I was so focused on the quickstarter I didn't see the forest for the trees... The real problem is elsewhere (see below). as you destroy the windows, you'll do a lot of X calls to free server resources that will just fail (surely). vcl/unx/source/app/saldata.cxx-int X11SalData::XIOErrorHdl( Display * ) does (essentially) _exit(0); which is about all you can do at that stage if you don't want to crash. Because otherwise abrt (Fedora's crash catching tool) dutifully saves it and lets the user report it as a crash and we are flooded (again) by reports like https://bugzilla.redhat.com/show_bug.cgi?id=650170 . Hmm, obviously not good. I couldn't see a stack trace there that I could read. I have attached one. However - I don't see why the systray should be any different to having a top-level window open, or indeed any normal gtk+ app getting getting nailed by a zapped X server. [ do you really file 10x bugs for different apps if someone does ctrl-alt-backspace to zap the server ? ]. I recognize this is not of general interest, though. Nah - we should fix it; but - ... getting a good trace for it would really help. Is it from the g_error in the gtk+ X error handler ? do we really get a good grace period to cleanup from the session manager ? [ and just don't cleanup the systray applet there ? ] or ... The problem is that SessionManagerClient is only initialized with the first sal frame (IOW, GtkSalFrame::Show calls SessionManagerClient::open). Obviously, if there has never been any frame opened, which, I suppose, happens in a lot of cases, this hadn't happened. So the app is not aware that the desktop session is ending and continues to run, till it's killed by an XIOError. I think the simplest thing here is to run SessionManagerClient::open when initializing the quickstarter (the function is exported, so there should be no problem with that), but there might be a cleaner solution. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg
On Tue, Dec 07, 2010 at 09:34:52AM +0100, David Tardon wrote: The problem is that SessionManagerClient is only initialized with the first sal frame (IOW, GtkSalFrame::Show calls SessionManagerClient::open). Obviously, if there has never been any frame opened, which, I suppose, happens in a lot of cases, this hadn't happened. So the app is not aware that the desktop session is ending and continues to run, till it's killed by an XIOError. I think the simplest thing here is to run SessionManagerClient::open when initializing the quickstarter (the function is exported, so there should be no problem with that), but there might be a cleaner solution. Bah, the header where it's declared is not public :( D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg
On Tue, Dec 07, 2010 at 12:39:19PM +, Michael Meeks wrote: Hi David, On Tue, 2010-12-07 at 10:54 +0100, David Tardon wrote: I think the simplest thing here is to run SessionManagerClient::open when initializing the quickstarter (the function is exported, so there should be no problem with that), but there might be a cleaner solution. What if we do this when SalSession is created? Does anyone see any problem with that approach ? There are some potential risks here; we don't want to do this if we are just going to push our arguments off to another process or before we start the splash (that is prolly the legacy explanation for deferring it - since it is a set of synchronous calls AFAICS). Luckily the new standalone unix splash / quick-starter handles both of these before we even start, and deprecates those concerns, so I suspect there is no issue here. Having said that - this is another miracle of UNO-isation - with the SessionManagerClient stuff being instantiated in framework/ via a service, which itself is (presuambly) instantiated via another service etc. etc. - making the code not only slower, but far more difficult to follow :-) Yeah, that one is created as com.sun.star.frame.SessionListener service in desktop::Desktop::OpenClients :-) So - anyhow, I'd say whack the patch in, and hopefully it will solve your abrt issues in an elegant way :-) Okay, pushing. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [libreoffice-documentation] Re: LibreOffice WikiHelp
Hi Kendy, :-) On Tue, Dec 7, 2010 at 23:45, Jan Holesovsky ke...@suse.cz wrote: Hi all, On 2010-12-06 at 17:04 +0100, Jan Holesovsky wrote: Either way, the good news is that I am currently uploading the files, and I'll make the site online as soon as it finishes, and I do few trivial checks; it should be later today (ETA 5 more hours, I am populating the database through the Mediawiki API, not directly). So far I am uploading only the English version. It will be read-only until RC2, so that it is easy to report bugs against the tooling that converts the help from the format that is used in the source code. After RC2, I plan to open it for your edits improvements :-) http://help.libreoffice.org is now up and running. As explained above, it is not open for public editing yet. There are few known bugs already filed in the bugzilla, should you find more, please report them too, with 'wikihelp: ' in the subject, and assign them directly to me. The already reported bugs are: https://bugs.freedesktop.org/show_bug.cgi?id=32173 https://bugs.freedesktop.org/show_bug.cgi?id=32174 You can either test the wikihelp directly from LibreOffice RC1, by issuing help on various parts of the suite (if you find something that leads to non-existing page, please report it too), or just from your browser, using 'Random page' in the left hand menu, and visually scanning it :-) I'll improve the tooling according to your findings, and upload the improved versions of the pages. I'll be exploring it and will give you constructive feedback. David Nelson ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] libreoffice -quickstart
On Wed, Dec 08, 2010 at 02:19:02AM +0100, Miguel (ON) wrote: Hi : ) I've noticed that a process is added at the startup when LibreOffice is installed. The process is libreoffice -quickstart -nologo -nodefault and it must be removed in LibreOffice options (enable quick start in System Tray). I would like to know if this issue is known by the developers, and if this is going to be like this in final version. IMHO Linux users don't like programs to execute by default at startup unless it's completly necessary. Please take it as a constructive criticism. Yes, it is known and should be fixed in RC1: http://lists.freedesktop.org/archives/libreoffice/2010-November/002987.html D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice WikiHelp
Hi Kendy, :-) On Sat, Dec 11, 2010 at 06:42, Jan Holesovsky ke...@suse.cz wrote: I got just 2 additional bugreports, I am not sure it is enough ;-) https://bugs.freedesktop.org/show_bug.cgi?id=32290 https://bugs.freedesktop.org/show_bug.cgi?id=32291 All four are fixed now, but please - really test it. Until we are sure that the quality of the conversion tool is good enough, it makes no sense to upload the l10n versions of the help - it would unnecessarily blow the size of the database with every improvement of the conversion tool. I have heard quite some complaints about the missing native language versions already; I am not sure I've explained it well enough previously, but this testing is blocking it. So please - help me :-) Personally, I'm taken up this weekend with other work for LibO but, next week when I have more time, I will definitely look at the WikiHelp and do my best to provide practical help. David Nelson ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice WikiHelp discussion
Hi Michael, :-) On Mon, Dec 13, 2010 at 18:24, Michael Meeks michael.me...@novell.com wrote: So - there is no need to open the wiki for editing ever, if that is a huge problem for people, and certainly we don't have to do this for 3.3, and certainly we don't have to open the wiki so just anyone can turn up from the street and spam it :-) [ it is easy to have approved translators only eg. ]. We can provide solutions for off-line editing, and there is certainly no need to switch tooling to make the wiki the authoritative data source now / yesterday :-) we can do that in a month / never if there is some insuperable problem. Personally, I like the idea of editing the help on the wiki rather than offline. But could the problem be solved by creating a user group on the wiki and only allowing editing rights for that group's users? Then we could add selected devs, i10n and docs people to that group? Is that a feasible solution? David Nelson ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] what's SfxMenuControl::aHelpText good for?
Hi all, recently I've been looking at fdo#31716 and have found out that the reading of help indexes that seems to cause the slowdown serves to no purpose, because the result is then just ignored. To be more precise, the result is assigned (through SfxMenuControl::Bind) to SfxMenuControl::aHelpText, that can only be accessed through SfxMenuControl::GetHelpText, that is only called from SfxVirtualMenu::GetItemHelpText, that is not called from anywhere :-) (For reference, the files involved are sfx2/inc/sfx2/mnuitem.hxx, sfx2/source/inc/virtmenu.hxx, sfx2/source/menu/mnuitem.cxx and sfx2/source/menu/virtmenu.cxx) My question is: was it used for some purpose in the past and has been obsoleted? Or is it just an example of purposeless overengineering? Or should it actually be used for something? Unless someone answers the last question positively, I'm going to wreak havoc upon the attribute and the functions associated with it on master in a few days :-) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Fix for pdfimport (fdo#32330) needs review
On Wed, Dec 15, 2010 at 02:36:56AM +0100, Thorsten Behrens wrote: Hi, could someone quickly review attached patch - a fairly safe fix I'd like to include in -3-3, since it quite spectacularly break graphics on PDF import. Hi Thorsten, looks fine to me. Simple and clear :) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Failed while building module nss
On Thu, Dec 16, 2010 at 02:25:41AM +0800, imacat wrote: Dear all, Hi. This is imacat from Taiwan. I try to compile LibreOffice on my Debian Lenny 5.0.6 x86_64, gcc 4.3.2, glibc 2.7. It fails when building module nss: == % make Making all in po ... Module 'canvas' delivered successfully. 0 files copied, 40 files unchanged = Building module nss = Entering /usr/local/src/libreoffice-3.2.99.2-20101215/build/libreoffice-3.2.99.2/nss dmake: Error: -- `./unxlngx6.pro/misc/71474203939fafbe271e1263e61d083e-nss-3.12.8-with-nspr-4.8.6.unpack' not found, and can't be made You don't have the nss tarball. Run ./download in the root of the build tree. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Review needed - fix for 'wikihelp is not context sensitive'
On Wed, Dec 15, 2010 at 11:14:33PM +0100, Jan Holesovsky wrote: Hi, https://bugs.freedesktop.org/show_bug.cgi?id=32338 Can you please review, sign-off and push the attached patch to libreoffice-3-3? The root of the problem is that in case of the built-in help, when a help-id is not referenced there, the code tries to traverse over the parent windows to find at least something. In the case of the on-line help, we rather want to directly use that (potentially missing) help id directly - otherwise we always end up on the 'main' help page. [And also we can fix the missing help id in the wikihelp, without the app recompilation.] Regards, Kendy Done. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Features list
Hi Sophie, :-) Thanks for that, I will include them on the site ASAP. ;-) David Nelson ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] The download link still shows Beta?
Hi Yi Fan Jiang, :-) On Fri, Dec 17, 2010 at 00:37, Yi Fan Jiang yfji...@novell.com wrote: To whom may concern, The links here looks a bit strange with 'Beta' while we have been in RC phase for some while: http://www.documentfoundation.org/download/ The content on those pages is out of date. We're nearly finished preparing the new LibreOffice site now. You can view it at http://test.libreoffice.org, and the downloads page there is up to date. The documentfoundation page will need to be updated. David Nelson ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Failed at slideshow(fpicker) with ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’
On Fri, Dec 17, 2010 at 02:18:04PM +0800, imacat wrote: Dear all, Hi. This is imacat from Taiwan. I tried to compile LibreOffice 3.3.0.1 on my Debian Lenny x86_64 5.0.6, gcc 4.3.2, glibc 2.7. It failed at the slideshow module, and when I digged inside as suggested, it complainted ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’. Your KDE is too old--the setConfirmOverwrite function was added in 4.2 (http://api.kde.org/4.5-api/kdelibs-apidocs/kio/html/classKFileDialog.html#558b1932c57dfd55e278e17fc4a34dd8). Any suggestion how to solve this? Thank you very much. Update KDE .-) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Detailed instructions for installing LibreOffice on Macintosh
Hi, :-) I'm currently working on the content of the upcoming libreoffice.org website. Obviously, on the site, there are going to be detailed installation instructions for our users. I don't have a Macintosh, unfortunately, and I need detailed instructions for installing LibreOffice on Mac, *also* covering installation of a language pack I also need to know whether it is necessary to de-install a previous version of LibO (or of OOo) before installing a new version. If so, I need detailed instructions on how to de-install an existing version. Could one of you Mac users out there help me out with this? (I need to finalize the content this weekend, so that we can roll-out the site.) If you're able to provide screenshots, this would be a great optional extra. in that case, please feel free to mail them to me directly. A big thanks if so! ;-) David Nelson ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Failed at slideshow(fpicker) with ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’
On Fri, Dec 17, 2010 at 09:27:40AM +0100, Rene Engelhard wrote: On Fri, Dec 17, 2010 at 07:27:12AM +0100, David Tardon wrote: On Fri, Dec 17, 2010 at 02:18:04PM +0800, imacat wrote: Dear all, Hi. This is imacat from Taiwan. I tried to compile LibreOffice 3.3.0.1 on my Debian Lenny x86_64 5.0.6, gcc 4.3.2, glibc 2.7. It failed at the slideshow module, and when I digged inside as suggested, it complainted ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’. Your KDE is too old--the setConfirmOverwrite function was added in 4.2 (http://api.kde.org/4.5-api/kdelibs-apidocs/kio/html/classKFileDialog.html#558b1932c57dfd55e278e17fc4a34dd8). Then configure should check for that. True. I'll add a test for it. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Failed at slideshow(fpicker) with ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’
On Fri, Dec 17, 2010 at 10:23:24AM +0100, Rene Engelhard wrote: On Fri, Dec 17, 2010 at 09:27:40AM +0100, Rene Engelhard wrote: On Fri, Dec 17, 2010 at 07:27:12AM +0100, David Tardon wrote: On Fri, Dec 17, 2010 at 02:18:04PM +0800, imacat wrote: Dear all, Hi. This is imacat from Taiwan. I tried to compile LibreOffice 3.3.0.1 on my Debian Lenny x86_64 5.0.6, gcc 4.3.2, glibc 2.7. It failed at the slideshow module, and when I digged inside as suggested, it complainted ‘class KFileDialog’ has no member named ‘setConfirmOverwrite’. Your KDE is too old--the setConfirmOverwrite function was added in 4.2 (http://api.kde.org/4.5-api/kdelibs-apidocs/kio/html/classKFileDialog.html#558b1932c57dfd55e278e17fc4a34dd8). Then configure should check for that. Please someone review and sign-off for libreoffice-3-3 (probably we should check for the function and not for the version, but anyways ;)): Done. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [libreoffice-users] Re: Detailed instructions for installing LibreOffice on Macintosh
Hi Alex, :-) A big thanks for that. ;-) David Nelson ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
