[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser (error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #60 from Pierre C  ---
(In reply to Mike Kaganski from comment #59)
> 
> Why? Which problems do you expect to prevent by that? Have you read and
> understood the part with "installed extensions and document with macros with
> the error would continue to work until edited in the IDE"?

Yes I read the bug comments

By the way suggested, only dev working on their extension will have a message
with the error

All extensions will not have any message, but bugs maybe present (no bug if the
default choice made bay the compiler is the right choice). Anyway it's a good
thing to have a complete syntax in programming language, not assuming that the
compiler will make a good choice.

If the original commit is in the master branch, people like me, using the
master branch, alpha and beta releases, will notice the problem with some
extensions and contact the dev to correct the bug. As I did some years ago

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser (error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #59 from Mike Kaganski  ---
(In reply to Pierre C from comment #58)
> Shouldn't this commit be activated in the master branch and reversed in all
> the sub branches.

Why? Which problems do you expect to prevent by that? Have you read and
understood the part with "installed extensions and document with macros with
the error would continue to work until edited in the IDE"?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser (error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #58 from Pierre C  ---
Shouldn't this commit be activated in the master branch and reversed in all the
sub branches.
In this way devs will updated their extensions, and maybe find errors

It could also be activated in all x.x.0 versions with a proper announcement and
reverted for the next versions

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser (error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #57 from Mike Kaganski  ---
https://gerrit.libreoffice.org/81616 aims to reinstate the fix reverted here in
comment 50, so that the error would only be thrown when using IDE (so that
installed extensions and document with macros with the error would continue to
work until edited in the IDE, which supposedly must mean that a developer is
ready to finally fix this missing parenthesis error). Please review.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #56 from Xisco Faulí  ---
Yep, I agree, this can be closed now

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #55 from Timur  ---
Looks to me this one may be closed because Bug 80731 is open. 

Only thing missing is an explanation why this is reverted in then-master:
(In reply to Commit Notification from comment #53)
> Katarina Behrens committed a patch related to this issue.
> tdf#106529: Revert "tdf#80731 Closing parenthesis is now detected"
> It will be available in 5.4.0.

when it was discussed to revert in point releases and keep in master.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #54 from Xisco Faulí  ---
Hello,
Is this bug fixed?
If so, could you please close it as RESOLVED FIXED?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #53 from Commit Notification 
 ---
Katarina Behrens committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=351dead74b4c213b13102f81b5ae9bb47ad8ca39

tdf#106529: Revert "tdf#80731 Closing parenthesis is now detected"

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #52 from Volga  ---
This bug also affect Writer2ePub
(https://extensions.libreoffice.org/extensions/writer2epub/1-1-2.8)

Version: 5.3.2.1 (x64)
Build ID: 7f6693c08cc110b9721245fc4bd4f1712e0c086c
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; Layout Engine:
new; 
Locale: zh-CN (zh_CN); Calc: CL

And AltSearch extension put a bugfix release 1.4.2 to work around this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

Xisco Faulí  changed:

   What|Removed |Added

 CC||cg...@free.fr

--- Comment #51 from Xisco Faulí  ---
*** Bug 106869 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #50 from Commit Notification 
 ---
Katarina Behrens committed a patch related to this issue.
It has been pushed to "libreoffice-5-3-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=4725c2a282f2c6468125073ba9cb5ba66f488e08=libreoffice-5-3-2

tdf#106529: Revert "tdf#80731 Closing parenthesis is now detected"

It will be available in 5.3.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.3.3 target:5.4.0   |target:5.3.3 target:5.4.0
   ||target:5.3.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #49 from Julien Nabet  ---
*** Bug 106549 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #48 from Commit Notification 
 ---
Andreas Säger committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7fb7b091e963d8c45abf1db1202a88f2e188e9b0=libreoffice-5-3

tdf#106529: fix closing parentheses of bundled macros

It will be available in 5.3.3.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #47 from Commit Notification 
 ---
Andreas Säger committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ad4857211bcc39ccd4c84c670bfab1b937f65089

tdf#106529: fix closing parentheses of bundled macros

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.3.3|target:5.3.3 target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #46 from Andreas Säger  ---
(In reply to Mike Kaganski from comment #45)
> (In reply to Andreas Säger from comment #43)
> 
> access2base is fixed in bug 106710. Gimmicks fixed by commit
> 6bb6ca1fb30f786385c2357e5435077066a49f82.
> 
> The other fixes are submitted to gerrit in
> https://gerrit.libreoffice.org/35726. Andreas, could you please send your
> license statement (as described on
> https://wiki.documentfoundation.org/Development/Developers), that is
> required to merge your contribution? Thank you!

Done

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #45 from Mike Kaganski  ---
(In reply to Andreas Säger from comment #43)

access2base is fixed in bug 106710. Gimmicks fixed by commit
6bb6ca1fb30f786385c2357e5435077066a49f82.

The other fixes are submitted to gerrit in
https://gerrit.libreoffice.org/35726. Andreas, could you please send your
license statement (as described on
https://wiki.documentfoundation.org/Development/Developers), that is required
to merge your contribution? Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #44 from Andreas Säger  ---
Sorry, the correct base dir is ${INSTALLDIR}/share/basic/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #43 from Andreas Säger  ---
I'll attach a zip with all fixed Basic modules in ${INSTALLDIR}/basic/.
I appended a closing brace to all lines where the new Basic compiler complained
since this is what the old compiler assumed when one was missing.

Library.Module  Line_Numbers_in_Basic_IDE
--
Access2Base.Application 917,1149
Access2Base.Database 1443,
Access2Base.Event 255,
Access2Base.Recordset 1120
Access2Base.Trace 183
Access2Base.Utils 832
Depot.Currency 73
Depot.Internet 207
FormWizard.DBMeta 289,290
FormWizard.FormWizard 137,140,141
FormWizard.Language 48,//113,118,140,141,142,143
Gimmicks.ReadDir 247


FormWizard.Language had a comment starting with // in line 113.
Syntax highlighting indicates that this is a valid comment. But the compiler
does not accept this line. I've never seen a //comment in Basic.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #42 from Andreas Säger  ---
Created attachment 132144
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132144=edit
Fixed Basic modules

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi,
   ||ville...@t-online.de

--- Comment #41 from Buovjaga  ---
Andreas: see previous comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #40 from Mike Kaganski  ---
(In reply to Andreas Säger from comment #39)

I assume that you took the effort and found some places with modules shipped
with LO? So why not to tell exactly where did you find them, instead of posting
uninformative messages that essentially say "I found them but not telling
where; go and find yourself". And better yet, file a dedicated bug for that,
because that's part of LO (unlike external extensions), and should be tracked
by LO developers. The new bug report should reference this one in its See Also.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #39 from Andreas Säger  ---
Almost every Library shipped with LibreOffice shows the same problem as you can
prove by brwosing module by module and click the compile button.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #38 from Gerhard Weydt  ---
Concerning extension DCM:
I supplied the missing parentheses and tested with rel. 5.3.1.2: the error no
longer occurred after the changes.
I added a new release to my extension, but it does not show there as the
current release. It is visible at the bottom of the list, nevertheless, which
is out of the normal order. I can download and install it, and it works
properly.
So the remaining problem is that it should be displayed as the current release.
Can anybody help?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #37 from Dorange-Pattoret Didier  ---
Hello,
I corrected the code in two extensions Gdmath and Dmaths.
I added the missing ).
It works fine.
Yhanks for your job.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #36 from Mike Kaganski  ---
To conclude the problematic extensions known at this moment:

- access2base - the author (Jean-Pierre Ledure) is subscribed to tdf#106710.
- decroise' author is informed and is said to work on it (tdf#106676).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #35 from Mike Kaganski  ---
Read Text extension: a new issue filed
https://github.com/jimholgate/readtextextension/issues/9

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #34 from Mike Kaganski  ---
... as well as author of DCM Direct Colour Management - Gerhard Weydt.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #33 from Mike Kaganski  ---
AltSearch author (Tomáš Bílek) has been sent an email.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #32 from Mike Kaganski  ---
(In reply to Katarina Behrens (CIB) from comment #26)
> So I wonder if we can coordinate the activity somewhere, which extensions
> are fixed or at the least their author(s) are notified and which are still
> missing 
> ...
> I've seen TexMath has a ticket (and possibly also a fix already), anyone
> else?

Typography extension developer (Lazlo Nemeth) is notified and answered that
he'll look at this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||6710

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

Xisco Faulí  changed:

   What|Removed |Added

 CC||jorojma...@gmail.com

--- Comment #31 from Xisco Faulí  ---
*** Bug 106710 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #30 from Katarina Behrens (CIB)  ---

> Conclusion 2: it is a problem that the Macro editor silently refuses to
> edit, rather than giving some positive indication that editing is not
> permitted. It could have the UI say "Read-only". It could put up an error
> alert. It could have a different background colour.

This is a long-standing issue -- if the macro is read-only, there's no
indication whatsoever (e.g. this yellow-ish "This document is read-only" info
bar normal documents have) that this is the case. I'm sure it is already filed
somewhere.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #29 from Jim DeLaHunt  ---
OK, I've done a careful check. I think JBF may have been correct. However, I
think this may be a different Extensions Manager bug.

Procedure 1:
Install Typography toolbar extension, for All Users
Restart Libreoffice
Create new Writer document with "text123679"
Change text to Linux Libertine G font.
View... Toolbars... Typography... Make toolbar visible in window.
Select text.
Click "Oldstyle figures" button in Typography toolbar.
BASIC Syntax error occurs.
My Macros & Dialogs.typo appears.
"typo" is listed under "My Macro & Dialogs" not under "LibreOffice Macros &
Dialogs"
Line of sub prg, with syntax error, indicated by orange arrow.
Result 1: Not able to edit the contents of the macro.

Procedure 2:
Install Typography toolbar extension, click button "Only for me"
Then same as Procedure 1.
Result 1: Yes, able to edit the contents of the macro.

Test system:
LibreOffice 5.3.1.2, Mac OS X El Capitan 10.11.6, Typography toolbar extension
1.1.

Conclusion 1: Jean-Baptiste Faure (from comment #24) is correct, the Macro
Editor does not permit editing macros installed for All Users. My problem
editing is not evidence of a connection to the syntax error or the macro editor
state after a syntax error.

Conclusion 2: it is a problem that the Macro editor silently refuses to edit,
rather than giving some positive indication that editing is not permitted. It
could have the UI say "Read-only". It could put up an error alert. It could
have a different background colour.

Conclusion 3: it is strange to me that the typo macro, when installed for "All
Users", appears under "My Macros & Dialogs". I would expect it to appear under
"LibreOffice Macros & Dialogs".

I will look into filing Conclusions 2 and 3 as an Extensions Manager or Macro
Editor bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #28 from Jim DeLaHunt  ---
(In reply to Jean-Baptiste Faure from comment #24)
> (In reply to Jim DeLaHunt from comment #23)
> > By the way, after bug 106687 occurred I noticed that I was not able to edit
> > the failing macro in my macro editor. I'm not sure this is part of this bug
> > or not. 
> 
> I disagree: I had the same problem with the Altsearch extension and the
> Basic editor was opened with the offended code allowing me to fix the bug
> for myself

JBF, thank you for your report.

Let me be clear, on my system (LO 5.3.1.2 on Mac OS X 10.11 El Capitan), LO
opened the Basic editor, had an orange arrow pointing to the line with the
error, but did not let me make any changes to the code.  The Macro editor was
read-only for me.

JBF, what LO version and OS are you using?  Maybe I am seeing a problem limited
to the Mac build of LO.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #27 from sergio.calleg...@gmail.com ---
I confirm that TeXMaths is affected and has a fixed version that is ready (but
not yet officially announced and released)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #26 from Katarina Behrens (CIB)  ---
So I wonder if we can coordinate the activity somewhere, which extensions are
fixed or at the least their author(s) are notified and which are still missing 

As in 5.3.3 (possibly 5.3.2 already) the errors in Basic code will be silently
ignored again and only couple of brave souls actually uses extensions w/
unstable 5.4, hardly ever will we learn there's actually an issue.

I've seen TexMath has a ticket (and possibly also a fix already), anyone else?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

Xisco Faulí  changed:

   What|Removed |Added

 CC||topaz3...@seznam.cz

--- Comment #25 from Xisco Faulí  ---
*** Bug 106685 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #24 from Jean-Baptiste Faure  ---
(In reply to Jim DeLaHunt from comment #23)
> By the way, after bug 106687 occurred I noticed that I was not able to edit
> the failing macro in my macro editor. I'm not sure this is part of this bug
> or not. 

I disagree: I had the same problem with the Altsearch extension and the Basic
editor was opened with the offended code allowing me to fix the bug for myself.
That said the editor was opened behind the current window and it was not clear
with the error message only that the user can do something to fix the problem.
It would be better if the error message dialog had a button to open the Basic
editor at the line containing the error.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #23 from Jim DeLaHunt  ---
By the way, after bug 106687 occurred I noticed that I was not able to edit the
failing macro in my macro editor. I'm not sure this is part of this bug or not. 

If it's the case that the macro editor is not capable of editing a macro which
has the "missing closing parenthesis" error, after the parser throws its syntax
error, then the parser is creating a situation where it's hard to correct buggy
macros.  

When this syntax check is applied again, I would suggest a test which confirms
that macros with a variety of syntax errors are still editable in the Macro
editor.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #22 from Jim DeLaHunt  ---
Is there anything in the BASIC parser which _warns_ about syntax errors, like
missing parentheses, short of throwing an error and making the Extension fail? 
It would be good to have a middle ground: a warning which the Extension
developer can see, letting them know there's a problem to fix, while not
breaking the Extension for all its users.  Contrariwise, if the BASIC parser
without this patch does NOT complain, does it mean that the syntax is actually
correct, and will continue to work even with a stricter parser?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

Mike Kaganski  changed:

   What|Removed |Added

Summary|LibO 5.3.1.x breaks |LibO 5.3.1.x breaks
   |extensions for changes in   |extensions for changes in
   |BASIC parser|BASIC parser (error
   ||message: "Basic Syntax
   ||error. Expected: ).")

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||6676

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

Mike Kaganski  changed:

   What|Removed |Added

 CC||from.documentfoundation@jdl
   ||h.com

--- Comment #21 from Mike Kaganski  ---
*** Bug 106687 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.3.3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #20 from Commit Notification 
 ---
Katarina Behrens committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=660e394b893a045a077ccded263f94a1be03fcf9=libreoffice-5-3

tdf#106529: Revert "tdf#80731 Closing parenthesis is now detected"

It will be available in 5.3.3.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #19 from Johnny_M  ---
> ok, does this mean that it's FIXED with target 5.3.2.x?

It's pending review: https://gerrit.libreoffice.org/35340

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #18 from tommy27  ---
(In reply to Katarina Behrens (CIB) from comment #17)
> > it sounds horrible...
> > let's consider a patch revert and an extra 5.3.1 rc3 then...
> 
> So I've reverted. For 5.3.1 we're sadly too late to a party (released
> yesterday)

ok, does this mean that it's FIXED with target 5.3.2.x?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=80
   ||731

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #17 from Katarina Behrens (CIB)  ---
> it sounds horrible...
> let's consider a patch revert and an extra 5.3.1 rc3 then...

So I've reverted. For 5.3.1 we're sadly too late to a party (released
yesterday)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

tommy27  changed:

   What|Removed |Added

   Priority|medium  |high

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #16 from tommy27  ---
(In reply to Katarina Behrens (CIB) from comment #15)
> ...
> 
> And not only extensions, I guess there's now thousands of macros that don't
> work anymore

it sounds horrible...
let's consider a patch revert and an extra 5.3.1 rc3 then...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #15 from Katarina Behrens (CIB)  ---
> But I do not know if the patch was pushed to 5.3.x as an effective bugfix
> for something (because not doing so immediately would have left broken some
> core parte of LibO).

Nah, as you can see, it was more like "this fixes a bug and looks otherwise
harmless, let's backport it". Some core parts of LibO were left broken, but
only as aftermath (as they were not free of missign-closing-parenthesis errors
either) 

> Still, I do not know if there are other "published" extensions affected.
> Furthermore, there may be users relying on "unpublished" extensions (i.e.,
> extensions they had someone develop for them only to address some need) that
> may be affected.

And not only extensions, I guess there's now thousands of macros that don't
work anymore

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #14 from tommy27  ---
maybe too late to revert the patch in 5.3.1
that should be probably done in 5.3.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #13 from Caolán McNamara  ---
re https://gerrit.libreoffice.org/#/c/33341 I don't remember any specific
reason for backporting it to 5.3, maybe the author asked how to get it into 5.3
or something like that, I don't know of anything that will immediately break if
it goes the other direction.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #12 from sergio.calleg...@gmail.com ---
> You mean if this can be reverted for 5.3.x?

If the patch breaks extensions, having a "deprecation period" before the
"quirk" the extensions relied upon is removed would seem good practice to me.
In this sense, reverting it in 5.3.x, while leaving it in 5.4 while adding a
visible deprecation note to the 5.3 release notes and a similarly visible note
about the parser change in the 5.4 release notes (as they are being built)
would seem fit.

But I do not know if the patch was pushed to 5.3.x as an effective bugfix for
something (because not doing so immediately would have left broken some core
parte of LibO). In the latter case, the balance would change in favor of
leaving the patch in the 5.3.x series.

As another ingredient to the discussion I can point out that the TeXMaths
authors is being extremely responsive in working to fix his widely used
extension. I am already testing a pre-release of a new version which addresses
the problem.

Still, I do not know if there are other "published" extensions affected.
Furthermore, there may be users relying on "unpublished" extensions (i.e.,
extensions they had someone develop for them only to address some need) that
may be affected.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #11 from tommy27  ---
(In reply to Katarina Behrens (CIB) from comment #10)
>  ...
> 
> > Can this be pushed back for 5.4, having the 5.3.x point releases from now on
> > carry a clear deprecation statement in the release notes?
> 
> You mean if this can be reverted for 5.3.x?

yes, I mean to keep the patch in 5.4.x and revert it in 5.3.x to avoid breakage
of extensions and give more time to extension authors to fix their code before
5.4.x

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

Katarina Behrens (CIB)  changed:

   What|Removed |Added

 CC||caol...@redhat.com

--- Comment #10 from Katarina Behrens (CIB)  ---
> Is there any good reason why a change with the potential to break extensions
> has gone into a point release?

The original author of the patch (Pierre Lepage) committed the change to master
( = 5.4) only. It was someone else who cherry-picked it for 5.3.1 and yet
someone else who reviewed it in ...

https://gerrit.libreoffice.org/#/c/33341

So let's ask Caolan what his intention was ...

> Can this be pushed back for 5.4, having the 5.3.x point releases from now on
> carry a clear deprecation statement in the release notes?

You mean if this can be reverted for 5.3.x?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #9 from tommy27  ---
I agree with Sergio.

this fix, though correct from a technical point of view, will probably create
more negative effects from a user point of view.

It would be probably better to post-pone it to 5.4.x and alert extension
creators that requirement changed and that they have to fix their own codes to
make it functional in LibO

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #8 from sergio.calleg...@gmail.com ---
> missing closing parenthesis in Basic expressions is now considered to be an 
> error (which it really is)

Hard not to agree, yet:

Is there any good reason why a change with the potential to break extensions
has gone into a point release? According to wikipedia, which I think is copying
over the LibO policy, "[LibO] Releases are designated by three numbers
separated by dots. The first number is the major version (branch) number, the
second one usually indicates small changes, and the final one /bugfixes/."

Can this be pushed back for 5.4, having the 5.3.x point releases from now on
carry a clear deprecation statement in the release notes?

> Please have extension authors fix their code

Hard not to agree again, but without a clear deprecation note it will leave
users needing the extensions on "stable" rather than "fresh" until the
extensions are fixed, which will leave users with a codebase with less features
and ultimately make "fresh" less tested (possibly leading to a more buggy
"stable" when "fresh" is promoted)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

Katarina Behrens (CIB)  changed:

   What|Removed |Added

  Component|BASIC   |Extensions

--- Comment #7 from Katarina Behrens (CIB)  ---
'twas bug#80731 - missing closing parenthesis in Basic expressions is now
considered to be an error (which it really is) instead of being silently
ignored.

So yes, the issues mentioned here are bugs, but bugs in the extensions, not in
Libreoffice core code. 

Please have extension authors fix their code.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

tommy27  changed:

   What|Removed |Added

   Keywords||regression
 CC||ba...@quipo.it
Summary|Libreoffice 5.3 breaks  |LibO 5.3.1.x breaks
   |extensions for changes in   |extensions for changes in
   |basic parser|BASIC parser

--- Comment #6 from tommy27  ---
so it's a regression introduced in 5.3.1.x?
was it working in 5.3.0, right?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs