[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2020-11-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2020-11-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #54 from QA Administrators  ---
Dear jorojmaqui,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2020-10-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #53 from QA Administrators  ---
Dear jorojmaqui,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

Julien Nabet  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #52 from Julien Nabet  ---
jorojmaqui: any update with LO 6.3.5 or LO 6.4.3 + brand new LO profile (see
https://wiki.documentfoundation.org/UserProfile#Windows) ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #51 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/8402cd6974bf4dc6318bda39298ac1b56f1923f7%5E%21

tdf#121092: synchronize defaults for drivers settings

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #50 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/fde00c42b169d80c9fe850d4876a0d0e5d6744a6%5E%21

tdf#121092: save db:suppress-version-columns to ODB

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #49 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/87b44efa2a21279d22a3350b3a3d497284621d52%5E%21

tdf#121092: save AppendTableAliasName to ODB

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #48 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/f8eef913a33b24ce6d9c6e37fdcc2614ab823659%5E%21

tdf#121092: save GenerateASBeforeCorrelationName to ODB

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #47 from Mike Kaganski  ---
Settings other than

* Use SQL92 naming constraints
* End text lines with CR+LF
* Respect the result set type from the database driver

were not handled in the above patch, and still need investigation.

Also note tdf#123975.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #46 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/f33eb08a2b74e5de033af9b5f5283b220ac58ded%5E%21

tdf#121092: synchronize defaults for ODBC settings

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #45 from Mike Kaganski  ---
(In reply to Mike Kaganski from comment #44)
> but please note that that list corresponds
> with what is written to ODB's content.xml as db:driver-settings element's
> attributes, as opposed to sub-elements of
> db:application-connection-settings, which is how other settings are written
> here.

A thinko: not "as db:driver-settings element's attributes", but "as
db:application-connection-settings element's attributes"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #44 from Mike Kaganski  ---
(In reply to Julien Nabet from comment #43)
> I also noticed that:
> 487 void ODBExport::exportApplicationConnectionSettings(const
> TSettingsMap& _aSettings)
> 488 {
> 489 const ::xmloff::token::XMLTokenEnum pSettings[] = {
> 490 XML_IS_TABLE_NAME_LENGTH_LIMITED
> 491 ,XML_ENABLE_SQL92_CHECK
> 492 ,XML_APPEND_TABLE_ALIAS_NAME
> 493 ,XML_IGNORE_DRIVER_PRIVILEGES
> 494 ,XML_BOOLEAN_COMPARISON_MODE
> 495 ,XML_USE_CATALOG
> 496 ,XML_MAX_ROW_COUNT
> 497 ,XML_SUPPRESS_VERSION_COLUMNS
> 498 };
> See
> https://opengrok.libreoffice.org/xref/core/dbaccess/source/filter/xml/
> xmlExport.cxx?r=b47bca7f#487
> 
> It seems we can't export any settings, see:
> schema/odf1.2/OpenDocument-v1.2-os-schema.rng from line 9158
> schema/odf1.3/OpenDocument-schema-v1.3.rng from line from line 3036

I'm not sure I follow you here; but please note that that list corresponds with
what is written to ODB's content.xml as db:driver-settings element's
attributes, as opposed to sub-elements of db:application-connection-settings,
which is how other settings are written here.

All the settings might be written as far as I see.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #43 from Julien Nabet  ---
(In reply to Mike Kaganski from comment #42)
...
> (In reply to Julien Nabet from comment #32)
> > Lionel: should I submit a patch with false following comments 25 and 26
> 
> Julien: please do!

done here: https://gerrit.libreoffice.org/#/c/68979/

I also noticed that:
487 void ODBExport::exportApplicationConnectionSettings(const TSettingsMap&
_aSettings)
488 {
489 const ::xmloff::token::XMLTokenEnum pSettings[] = {
490 XML_IS_TABLE_NAME_LENGTH_LIMITED
491 ,XML_ENABLE_SQL92_CHECK
492 ,XML_APPEND_TABLE_ALIAS_NAME
493 ,XML_IGNORE_DRIVER_PRIVILEGES
494 ,XML_BOOLEAN_COMPARISON_MODE
495 ,XML_USE_CATALOG
496 ,XML_MAX_ROW_COUNT
497 ,XML_SUPPRESS_VERSION_COLUMNS
498 };
See
https://opengrok.libreoffice.org/xref/core/dbaccess/source/filter/xml/xmlExport.cxx?r=b47bca7f#487

It seems we can't export any settings, see:
schema/odf1.2/OpenDocument-v1.2-os-schema.rng from line 9158
schema/odf1.3/OpenDocument-schema-v1.3.rng from line from line 3036

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #42 from Mike Kaganski  ---
And indeed, *exchanging* the two defaults for RespectDriverResultSetType - in
ODatabaseModelImpl::getDefaultDataSourceSettings and
connectivity/registry/odbc/org/openoffice/Office/DataAccess/Drivers.xcu - make
the setting to not be written to ODB again, but this time, unchecked state
becomes the auto-restoring setting (just tested) :-)

(In reply to Julien Nabet from comment #32)
> Lionel: should I submit a patch with false following comments 25 and 26

Julien: please do!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #41 from Mike Kaganski  ---
And in the change, it's likely a good thing to add a comment there that the
settings must be aligned with each other - so that other devs would be aware of
this situation in the future.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #40 from Mike Kaganski  ---
I have setup a testing data connection, and tested myself.

I need to note that bibisect from comment 30 is indeed incorrect (though looks
amazingly relevant wrt affected files ;-D).

And the suggestion from comment 25 seems to be not a workaround after all, but
a proper solution:

ODatabaseModelImpl::getDefaultDataSourceSettings [1] sets the default for the
setting to false; that default is most probably taken to consideration at
*some* level when deciding if a value is different from default (i.e., it might
be simply dropped from some property set if it's equal to this default). On the
other hand, the change mentioned in comment 25 provides the opposite value for
default on a different level; that might also be considered likewise in the
process of writing the setting - so having them both makes the scenario likely
that neither value gets it to the content.xml in ODB.

Since the defaults in [1] are there at least since 2006 [2], they must be
relevant for all ODBs out there - so it's correct to change newly introduced
defaults accordingly.

I have checked that making the proposed change to that default of
RespectDriverResultSetType in
connectivity/registry/odbc/org/openoffice/Office/DataAccess/Drivers.xcu indeed
produces the "true" value into the ODB; while when "false", the value is not
present there.

I'm not sure if that is relevant to other connection types.

[1]
https://opengrok.libreoffice.org/xref/core/dbaccess/source/core/dataaccess/ModelImpl.cxx?r=435b64ec#1003
[2] https://git.libreoffice.org/core/+/0eb026293c88d422d701d1a06735d9cce5457ca9

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #39 from Mike Kaganski  ---
For reference: testing with setting all checkboxes in Advanced Settings dialog
then reloading; and unsetting all checkboxes in the dialog then reloading,
shows that the following settings are automatically reset to CHECKED:

* Use SQL92 naming constraints
* Use keyword AS before table alias names
* End text lines with CR+LF
* Respect the result set type from the database driver

These are automatically reset to UNCHECKED:

* Append the table alias name on SELECT statements
* Display version columns (when available)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #38 from Mike Kaganski  ---
(In reply to Julien Nabet from comment #36)
>  
> -  
> -true
> +  
> +0
>
>  
>  
> @@ -165,7 +165,7 @@
>  
>  
>
> -false
> +true
>
>  
> Both don't concern "RespectDriverResultSetType" quoted in previous comments.
> 
> I'm a bit lost here.

E.g., some code (that reads multiple settings, including
RespectDriverResultSetType) tries to read boolean from BooleanComparisonMode
(when now it's int), and that throws; so the rest is not read at all?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #37 from Mike Kaganski  ---
(In reply to Julien Nabet from comment #36)

I don't think that that patch should be reverted; only that something is
missing (possibly some code checks types strictly, and fails now not getting
expected type somewhere?). I can't test the bug myself - so I can't fix it; but
you said that you can - that's why I suppose you are in the right position to
check that and fix ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #36 from Julien Nabet  ---
(In reply to Mike Kaganski from comment #35)
> ...

Taking a look at
https://cgit.freedesktop.org/libreoffice/core/commit/?id=6de679cca6978694bacf5322c9ab8559740f0443
from comment 30, I see 4 files modified, they concern:
- ado
- jdbc
- mysql
- odbc
Since we're talking about odbc, I suppose we can consider ado, jdbc, mysql
changes not related and only consider odbc one and so we got:
 
-  
-true
+  
+0
   
 
 
@@ -165,7 +165,7 @@
 
 
   
-false
+true
   
 
Both don't concern "RespectDriverResultSetType" quoted in previous comments.

I'm a bit lost here.

Don't hesitate to revert what I did if you think it'll improve the situation.
I'm not deeply attached to my patches :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #35 from Mike Kaganski  ---
(In reply to Julien Nabet from comment #34)

Could you please check if reverting your commit referenced in comment 30 also
has an impact (checking if the options are actually saved and persist over
reopen); if so, could you check why that commit breaks saving/reloading the
values?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #34 from Julien Nabet  ---
(In reply to Mike Kaganski from comment #33)
> (In reply to Julien Nabet from comment #32)
> > Lionel: should I submit a patch with false following comments 25 and 26 even
> > if it's just a workaround?
> 
> Then those connections that rely on that value to be true would break :-)
So what should we do then?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #33 from Mike Kaganski  ---
(In reply to Julien Nabet from comment #32)
> Lionel: should I submit a patch with false following comments 25 and 26 even
> if it's just a workaround?

Then those connections that rely on that value to be true would break :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #32 from Julien Nabet  ---
Lionel: should I submit a patch with false following comments 25 and 26 even if
it's just a workaround?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #31 from Mike Kaganski  ---
And it was backported to 6-1 in
https://gerrit.libreoffice.org/plugins/gitiles/core/+/8d0f2c5192d2c6bc18e406906825c0889e1edc22,
which was included exactly in 6.1.3.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #30 from Mike Kaganski  ---
A bibisect by user mentioned in comment 17 gives this:

https://gerrit.libreoffice.org/plugins/gitiles/core/+/6de679cca6978694bacf5322c9ab8559740f0443

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #29 from Lionel Elie Mamane  ---
I think the values that the XML saving/parsing code considers are the default
(which I'm pretty sure is a global hard-coded thing, not taken from the
per-driver xcu config file!) are not saved explicitly in the XML stream; the
attribute is just omitted.

That's the source of my suggestion in comment 25. My theory is that this
interacts somewhat with "per driver" defaults in the xcu files in a way that
does not quite work as intended.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #28 from Mike Kaganski  ---
Setting default to true or false looks like a workaround. The real problem is
that the setting(s) apparently are not saved to or read from ODB, so a default
is used after the reload. And that is despite the value(s) clearly have effect
on the behavior of the connection.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #27 from Alex Thurgood  ---
(In reply to Julien Nabet from comment #26)


> Then I applied what Lionel indicated and put false
> odbc\org\openoffice\Office\DataAccess for RespectDriverResultSetType values
> both in Features and Properties part, I don't reproduce this anymore.

I suppose the question then is, what effect, if any, would changing these back
to false have on other ODBC driver connections ? I assume (perhaps wrongly)
that this current issue is specific to the properties of the sqlite ODBC
driver, as opposed to some more general functionality ?

See, for example, my comment in bug122306#c4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #26 from Julien Nabet  ---
On Win10 + Cywin 3.01 + master sources updated today and enable-dbgutil + odbc
sqlite driver Devart (trial), I could reproduce the pb.
When opening file, the option "Respect the resultset..." is checked.
If I uncheck this, save the file, then reopen the file, this option is checked
again.

Then I applied what Lionel indicated and put false
odbc\org\openoffice\Office\DataAccess for RespectDriverResultSetType values
both in Features and Properties part, I don't reproduce this anymore.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #25 from Lionel Elie Mamane  ---
Can someone try to change the "true" default added in
https://cgit.freedesktop.org/libreoffice/core/commit/?id=3208fcb3a36d75d6290d9c548430682f153b09db
to a "false" default? That might solve this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

Julien Nabet  changed:

   What|Removed |Added

 CC||lio...@mamane.lu

--- Comment #24 from Julien Nabet  ---
Alex: yes it may be related with
https://cgit.freedesktop.org/libreoffice/core/commit/?id=d6fce54c82868b82bd6fa190db6047d69bbb3ecf
and
https://cgit.freedesktop.org/libreoffice/core/commit/?id=3208fcb3a36d75d6290d9c548430682f153b09db

Now I don't know if it's the root cause or if it revealed a pb more than it's
the rootcause.

Indeed, looking at where "RespectDriverResultSetType" is used, I noticed:
https://opengrok.libreoffice.org/xref/core/dbaccess/source/core/api/RowSet.cxx?r=435b64ec#1579

Since it's now considered to true, perhaps the if has some impact.

I think it needs some debugging

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #23 from Alex Thurgood  ---
However, it may be worthwhile bearing in mind why this change came about, cf.
bug 119743

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||9743

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

Alex Thurgood  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #21 from Alex Thurgood  ---
That commit, added a default value of True to the ODBC Drivers.xcu file in:

connectivity/registry/odbc/org/openoffice/Office/DataAccess/Drivers.xcu

@Julien : any thoughts ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #22 from Alex Thurgood  ---
+
+  
+true
+  
+

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #20 from Alex Thurgood  ---
Any chance it is linked to :

commit d6fce54c82868b82bd6fa190db6047d69bbb3ecf

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

Mike Kaganski  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression

--- Comment #19 from Mike Kaganski  ---
I cannot myself bibisect this; so I ask original poster: could you please
follow the steps described on [1], and perform a bibisection, which would give
us the specific commit which is responsible for the regression?

[1] https://wiki.documentfoundation.org/QA/Bibisect/Windows

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #18 from Mike Kaganski  ---
The research described in comment 17 was performed using Windows hosts and
server.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-03-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

Mike Kaganski  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #17 from Mike Kaganski  ---
It is confirmed by independent research on
https://forumooo.ru/index.php/topic,7532.0.html, where another server
(Firebird) was connected using ODBC. Newer versions of LO (reportedly 6.0+)
could not perform specific tasks on the server (namely, add records), while
creation and editing of tables was possible. It was reportedly OK with 5.4.7.2.

The problem was nailed down to the "Respect the result set type from the
database driver" setting on the Advanced Settings dialog, where it is reset to
enabled state upon reloading the odb, along with some other settings. Being
unable to unset and save state drove the reporter to write a macro attached to
"File Open" event:

> ThisDatabaseDocument = ThisComponent
> ThisDatabaseDocument.DataSource.Settings.RespectDriverResultSetType = false

Setting to NEW.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-02-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #16 from jorojma...@gmail.com ---
Comment on attachment 149646
  --> https://bugs.documentfoundation.org/attachment.cgi?id=149646
error01

windows home 10
libreoffice 6.2.1
sqlite3 odbc on libreoffice Base

error:

Hay un controlador no registrado para el URL ~sdbc:odbc:FINCAxSQLITE3xODBC.

what can be done?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-02-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #15 from jorojma...@gmail.com ---
Created attachment 149646
  --> https://bugs.documentfoundation.org/attachment.cgi?id=149646=edit
error01

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-02-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||2306

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-02-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #14 from Alex Thurgood  ---
It may be that these options are no longer taken into account because LO
currently seems incapable of reading the metadata of a sqlite3 db over ODBC,
see bug 120695.

As it was, previously, there was never any guarantee that the options selected
in the Advanced Properties dialogue would be respected, even if they did just
happen to work.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2019-02-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

Alex Thurgood  changed:

   What|Removed |Added

Summary|Libreoffice 6.1.3.2 does|Libreoffice 6.1.3.2 does
   |not allow saving the|not allow saving Advanced
   |special configuration of|Properties options with
   |SQLITE 3 ODBC   |SQLITE 3 over ODBC

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs