[Libreoffice-bugs] [Bug 144853] Sentence case not undone when cycling case
https://bugs.documentfoundation.org/show_bug.cgi?id=144853 stragu changed: What|Removed |Added CC||matos...@gmail.com --- Comment #11 from stragu --- *** Bug 145121 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144853] Sentence case not undone when cycling case
https://bugs.documentfoundation.org/show_bug.cgi?id=144853 stragu changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||6234 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144853] Sentence case not undone when cycling case
https://bugs.documentfoundation.org/show_bug.cgi?id=144853 --- Comment #10 from Heiko Tietze --- (In reply to Michael Warner from comment #9) > I am un-assigning myself from this bug. The lack of response from committers > to my patches for Bug 49033 and Bug 144851 leaves me with little confidence > that any patch I were to provide for this bug would ever be merged. That would be a great pity! I see a comment on bug 49033 and would suggest to poke users at least once again (me inclusive; sorry for not responding immediately). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144853] Sentence case not undone when cycling case
https://bugs.documentfoundation.org/show_bug.cgi?id=144853 Michael Warner changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|michael.warner.ut+libreoffi |libreoffice-b...@lists.free |c...@gmail.com|desktop.org --- Comment #9 from Michael Warner --- I am un-assigning myself from this bug. The lack of response from committers to my patches for Bug 49033 and Bug 144851 leaves me with little confidence that any patch I were to provide for this bug would ever be merged. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144853] Sentence case not undone when cycling case
https://bugs.documentfoundation.org/show_bug.cgi?id=144853 Michael Warner changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |michael.warner.ut+libreoffi |desktop.org |c...@gmail.com -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144853] Sentence case not undone when cycling case
https://bugs.documentfoundation.org/show_bug.cgi?id=144853 --- Comment #8 from Heiko Tietze --- Whatever solution we implement it probably makes some users unhappy. The point of this discussion is that we have transparency in case of incoming complaints. My concerns besides consistency and learnability¹ is a clear feedback (unfortunately the auto-selection idea was not accepted). ¹ It would be terrible if we have to show a notification if the user expectation is not met. I think no selection - no action is easy to understand and can be described clearly in the documentation. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144853] Sentence case not undone when cycling case
https://bugs.documentfoundation.org/show_bug.cgi?id=144853 --- Comment #7 from V Stuart Foote --- (In reply to Michael Warner from comment #6) > > I am starting to think there is no completely consistent behavior with > Sentence Case in the cycle case rotation at all. Right. Which was basis for my suggestion to eliminate the expand to sentence bound (which I'm not sure our ICU lib tests even do correctly) leaving either transliterate exactly the selection--or--expand only to the word bound (for title, sentence, upper, lower) when no selection was made. Making an exact selection for word, sentence, or paragraph is now trivial--it was not before the UNO commands were implemented and made available to keyboard or mouse click actions. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144853] Sentence case not undone when cycling case
https://bugs.documentfoundation.org/show_bug.cgi?id=144853 --- Comment #6 from Michael Warner --- My understanding of what was desired in Comment 3 is that if there was no selection and user selected Format -> Text -> Sentence Case, it would continue to affect the entire sentence as before. It would only be restricted to the current word if there was no selection and user pressed Shift+F3. My point from Comment 4 is that by continuing to apply Sentence Case to the current word when cycling without selection, now the user will see the same result twice in the cycle, once from the Title Case action, and once from the Sentence Case action. This will appear to be a bug to that person. The downside to skipping Sentence Case when cycling without selection is there will appear to be three states; and when cycling WITH selection, there will appear to be four states, which would also seem like an issue, if there is only one word selected, then the user sees the same thing in twice again, so it doesn't fully solve that problem either. I am starting to think there is no completely consistent behavior with Sentence Case in the cycle case rotation at all. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144853] Sentence case not undone when cycling case
https://bugs.documentfoundation.org/show_bug.cgi?id=144853 --- Comment #5 from V Stuart Foote --- (In reply to Michael Warner from comment #4) > (In reply to Heiko Tietze from comment #3) > > >+ the ideal behavior would be as OP suggest, only change current word > > if no selection is done (Sascha) > > If this is the decision then I submit that we should just skip applying > sentence case formatting if cycling without selection, because applying > sentence case only to the current word is equivalent to applying title case > in this situation. No, the cycle case is four distinct actions [1]. For consistency, with or without selection must still be four states. So, logic for Sentence case without selection would need to apply at the word bound holding the cursor, just as TITLE_CASE. So, either test that we are in the cycle case loop--and modify the SENTENCE_CASE handling, or fully remove the expanded run passed to the SENTENCE_CASE transliteration [2]. Put another way, SENTENCE_CASE would *require* a selection (now trivial to make at sentence bounds via mouse or keyboard) that would be honored exactly with no expansion. Otherwise it would no longer expand beyond word holding text cursor and behave like TITLE_CASE. Probably simpler to do the later. The Format -> Text -> Sentence case would be minimally effected--maybe adjust do nothing with out a selection. While the cycle case mode would gain consistency (with or without selection), the main complaint. =-ref-= [1] https://opengrok.libreoffice.org/xref/core/unotools/source/i18n/caserotate.cxx?r=84f8e28d#25 [2] https://opengrok.libreoffice.org/xref/core/editeng/source/editeng/impedit4.cxx?r=6af0da48#2774 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144853] Sentence case not undone when cycling case
https://bugs.documentfoundation.org/show_bug.cgi?id=144853 --- Comment #4 from Michael Warner --- (In reply to Heiko Tietze from comment #3) >+ the ideal behavior would be as OP suggest, only change current word > if no selection is done (Sascha) If this is the decision then I submit that we should just skip applying sentence case formatting if cycling without selection, because applying sentence case only to the current word is equivalent to applying title case in this situation. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144853] Sentence case not undone when cycling case
https://bugs.documentfoundation.org/show_bug.cgi?id=144853 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Keywords|needsUXEval | Severity|normal |enhancement --- Comment #3 from Heiko Tietze --- The topic was on the agenda of the design meeting. + an automatic selection would be contra-productive because is force to adapt users to the behavior of the application (Sascha) + the ideal behavior would be as OP suggest, only change current word if no selection is done (Sascha) So let's do this. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144853] Sentence case not undone when cycling case
https://bugs.documentfoundation.org/show_bug.cgi?id=144853 Heiko Tietze changed: What|Removed |Added Blocks||112182, 145200 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=112182 [Bug 112182] [META] Text and object selection issues https://bugs.documentfoundation.org/show_bug.cgi?id=145200 [Bug 145200] [META] Case cycling -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144853] Sentence case not undone when cycling case
https://bugs.documentfoundation.org/show_bug.cgi?id=144853 Heiko Tietze changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #2 from Heiko Tietze --- Undo works for me. But the fact that case cycling is applied to the whole sentence without proper feedback is an usability issue. So how about selecting the whole sentence automatically? Would make the operation consistent with a clear feedback and shows how a single word/term can be cycled- by selecting this part. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144853] Sentence case not undone when cycling case
https://bugs.documentfoundation.org/show_bug.cgi?id=144853 Michael Warner changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||5121 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144853] Sentence case not undone when cycling case
https://bugs.documentfoundation.org/show_bug.cgi?id=144853
Michael Warner changed:
What|Removed |Added
CC||michael.warner.ut+libreoffi
||c...@gmail.com
Keywords||needsUXEval
See Also||https://bugs.documentfounda
||tion.org/show_bug.cgi?id=49
||033
--- Comment #1 from Michael Warner ---
It's not a problem when there is a selection, because all of the formatting
commands will affect all of the selected words.
I can think of two possible solutions:
1. Change the behavior of case cycling such that it does not apply sentence
case formatting if there is no selection; or
2. Change the behavior of each case format operation to store the command in
the undo information ("cycle case" or "direct"), then whenever cycle case
command is executed, have it check the top of the undo stack and if the undo
information indicates that the previous command was a cycle case that applied
sentence case, have it undo that command before executing the next case change.
--
You are receiving this mail because:
You are the assignee for the bug.
