[Libreoffice-bugs] [Bug 150302] Toggle SameLetterHeights does not work if property not initialized
https://bugs.documentfoundation.org/show_bug.cgi?id=150302 Matt K changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |matt...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150302] Toggle SameLetterHeights does not work if property not initialized
https://bugs.documentfoundation.org/show_bug.cgi?id=150302 --- Comment #4 from Hossein --- I've written a blog post around this issue that can be useful for the EasyHackers: ODF standard and the code – EasyHack https://dev.blog.documentfoundation.org/2022/08/16/odf-standard-and-the-code-easyhack/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150302] Toggle SameLetterHeights does not work if property not initialized
https://bugs.documentfoundation.org/show_bug.cgi?id=150302 Hossein changed: What|Removed |Added Keywords||difficultyMedium, easyHack Whiteboard||reviewed:2022 --- Comment #3 from Hossein --- (In reply to Regina Henschel from comment #1) > The error is in case SID_FONTWORK_SAME_LETTER_HEIGHTS in impl_execute method > in > https://opengrok.libreoffice.org/xref/core/svx/source/toolbars/fontworkbar. > cxx?r=4c0b033e#242 > The else part is missing. > Since the icon has a .uno command, a unit test is possible using the > dispatcher. > > @Hossein: I think, this can be an EasyHack. Do you agree? Yes! And thanks for suggesting this issue for an EasyHack. I've tested your code pointer, and the fix is straightforward. On the other hand, I think it should be marked as difficultyMedium, because one needs to gain a basic understanding of ODF and the draw:text-path-same-letter-heights attribute and change it manually inside to see its effect, then fix the code and write a test similar to some of those in sd/qa/unit/uiimpress.cxx. This is the related part of the ODF 1.3 standard for the above attribute: Open Document Format for Office Applications (OpenDocument) Version 1.3. Part 3: OpenDocument Schema OASIS Standard - 27 April 2021 19.224 draw:text-path-same-letter-heights https://docs.oasis-open.org/office/OpenDocument/v1.3/os/part3-schema/OpenDocument-v1.3-os-part3-schema.html#__RefHeading__1417288_253892949 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150302] Toggle SameLetterHeights does not work if property not initialized
https://bugs.documentfoundation.org/show_bug.cgi?id=150302 Hossein changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Hossein --- Reproduced with the latest LO 7.5 dev master: Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: cc3e2e7efa35dea85eecdd163de1ca1e71ce01f7 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150302] Toggle SameLetterHeights does not work if property not initialized
https://bugs.documentfoundation.org/show_bug.cgi?id=150302 Regina Henschel changed: What|Removed |Added CC||hoss...@libreoffice.org --- Comment #1 from Regina Henschel --- The error is in case SID_FONTWORK_SAME_LETTER_HEIGHTS in impl_execute method in https://opengrok.libreoffice.org/xref/core/svx/source/toolbars/fontworkbar.cxx?r=4c0b033e#242 The else part is missing. Since the icon has a .uno command, a unit test is possible using the dispatcher. @Hossein: I think, this can be an EasyHack. Do you agree? -- You are receiving this mail because: You are the assignee for the bug.
