[Libreoffice-bugs] [Bug 152738] LO75RC1: Automatic spell-check not underlining misspelled words; dialog doesn't use paragraph's language

2023-03-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152738

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||3628

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152738] LO75RC1: Automatic spell-check not underlining misspelled words; dialog doesn't use paragraph's language

2023-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152738

--- Comment #20 from Telesto  ---
(In reply to Stéphane Guillou (stragu) from comment #19)
> It looks like the issue might not be entirely fixed, as we've got two
> reporters saying they still have problems in 7.5.1, both on Windows:
> 
> - bug 153628
> - bug 153931
> 
> However, I haven't been able to reproduce.
> What do you think, László?

I'm maybe able to 'reproduce' a part of bug 153628. I'm lacking Australian
Dictionary, so it falls back to 'NONE' (OK so far). However if I select some
different language out of available dictionary's, the spell checker window
keeps being disabled (as described by the reporter).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152738] LO75RC1: Automatic spell-check not underlining misspelled words; dialog doesn't use paragraph's language

2023-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152738

--- Comment #19 from Stéphane Guillou (stragu) 
 ---
It looks like the issue might not be entirely fixed, as we've got two reporters
saying they still have problems in 7.5.1, both on Windows:

- bug 153628
- bug 153931

However, I haven't been able to reproduce.
What do you think, László?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152738] LO75RC1: Automatic spell-check not underlining misspelled words; dialog doesn't use paragraph's language

2023-02-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152738

Telesto  changed:

   What|Removed |Added

 CC||abodro...@gmail.com

--- Comment #18 from Telesto  ---
*** Bug 153836 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152738] LO75RC1: Automatic spell-check not underlining misspelled words; dialog doesn't use paragraph's language

2023-02-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152738

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||jglen...@onthenet.com.au

--- Comment #17 from Stéphane Guillou (stragu) 
 ---
*** Bug 153628 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152738] LO75RC1: Automatic spell-check not underlining misspelled words; dialog doesn't use paragraph's language

2023-02-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152738

Xisco Faulí  changed:

   What|Removed |Added

 CC||thedeadlysarc...@gmail.com

--- Comment #16 from Xisco Faulí  ---
*** Bug 153498 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152738] LO75RC1: Automatic spell-check not underlining misspelled words; dialog doesn't use paragraph's language

2023-02-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152738

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #15 from Stéphane Guillou (stragu) 
 ---
Fix verified in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b2bd60b8c1937502857e12b0eea42323fd2353c8
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thank you all! :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152738] LO75RC1: Automatic spell-check not underlining misspelled words; dialog doesn't use paragraph's language

2023-02-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152738

--- Comment #14 from Commit Notification 
 ---
László Németh committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/1ca9f7fc85db66c7c6ba25d43f05476ea787dfc4

tdf#152738 sw: fix lost SwPosition in spelling dialog

It will be available in 7.5.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152738] LO75RC1: Automatic spell-check not underlining misspelled words; dialog doesn't use paragraph's language

2023-02-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152738

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.6.0|target:7.6.0 target:7.5.1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152738] LO75RC1: Automatic spell-check not underlining misspelled words; dialog doesn't use paragraph's language

2023-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152738

László Németh  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
   Assignee|nem...@numbertext.org   |libreoffice-b...@lists.free
   ||desktop.org
 Resolution|--- |FIXED

--- Comment #13 from László Németh  ---
@Martin: many thanks for the bug report! (Unfortunatelly, I wasn't able to
reproduce it last year likely because of my old build.)

@Stéphane: many thanks for the test document and bibisecting!

@Noel: many thanks for the review!

@Telesto: many thanks for handling the issue!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152738] LO75RC1: Automatic spell-check not underlining misspelled words; dialog doesn't use paragraph's language

2023-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152738

László Németh  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |nem...@numbertext.org
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152738] LO75RC1: Automatic spell-check not underlining misspelled words; dialog doesn't use paragraph's language

2023-01-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152738

--- Comment #10 from Stéphane Guillou (stragu) 
 ---
Created attachment 185038
  --> https://bugs.documentfoundation.org/attachment.cgi?id=185038=edit
screenshot of issue in LO 7.5.0.2

This annotated screenshot shows the spellcheck dialog failing at using the
paragraph's language, French.

(Forget about that issue with whitespace inserted in the sentence, in comment
7, that must have been an error on my end. Haven't seen it again.)

Version: 7.5.0.2 (X86_64) / LibreOffice Community
Build ID: c0dd1bc3f1a385d110b88e26ece634da94921f58
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152738] LO75RC1: Automatic spell-check not underlining misspelled words; dialog doesn't use paragraph's language

2023-01-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152738

--- Comment #9 from Stéphane Guillou (stragu) 
 ---
(In reply to Stéphane Guillou (stragu) from comment #8)
> Bibisected with linux-64-7.5 repo [...]

Noel, note that I bibisected the "language is [none] in spelling dialog" issue,
as described in comment 7.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152738] LO75RC1: Automatic spell-check not underlining misspelled words; dialog doesn't use paragraph's language

2023-01-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152738

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

  Regression By||Noel Grandin
   Keywords|bibisectRequest |bibisected, bisected
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||3223
 CC||noelgran...@gmail.com
Summary|LO75RC1: Automatic  |LO75RC1: Automatic
   |spell-check on macOS not|spell-check not underlining
   |underlining misspelled  |misspelled words; dialog
   |words   |doesn't use paragraph's
   ||language
   Priority|medium  |high

--- Comment #8 from Stéphane Guillou (stragu) 
 ---
To bibisect, I had to first make sure that the extra dictionary was at the
right spot. I copied it from my 7.5 installation

/opt/libreoffice7.5/share/extensions/dict-fr

and pasted in the local bibisect repo:

[...]/linux-64-7.5/instdir/share/extensions/dict-fr

Bibisected with linux-64-7.5 repo to first bad commit
84e282373a120d0a41bb96378085b253e8568e97 which points to core commit:
commit  b484e5d9e0d22b794c2d1c73741191836158a4ad[log]
author  Noel Grandin Sat Oct 08 07:54:48 2022 +0200
committer   Noel Grandin  Sun Oct 09
19:16:29 2022 +0200
treea1f8d3d3c7d0d5a01284e400f4c9d6f5d5dba260
parent  ca1378b6552251743c92a19f9ce8b3833557b548 [diff]
use more SwPosition::Assign
part of the process of hiding the internals of SwPosition
Change-Id: I20842b90d0abb4435d6b06970c2545229268e5e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141097

Noel, can you please have a look?

Martin, regarding the underline issue: could you please check if it is at all
related to the zoom level you are using? See bug 153223. An annotated
screenshot of this aspect of the issue would be helpful.

-- 
You are receiving this mail because:
You are the assignee for the bug.