[Libreoffice-bugs] [Bug 154269] FindReplaceRememberedSearches not respected in quick find bar
https://bugs.documentfoundation.org/show_bug.cgi?id=154269 Andreas Heinisch changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |andreas.heini...@yahoo.de |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154269] FindReplaceRememberedSearches not respected in quick find bar
https://bugs.documentfoundation.org/show_bug.cgi?id=154269 Heiko Tietze changed: What|Removed |Added CC||andreas.heini...@yahoo.de --- Comment #9 from Heiko Tietze --- (In reply to maison from comment #8) > “FindReplaceRememberedSearches not respected in quick find bar” Thought you run into problem with the full search (ctrl+H). Search for 1, the close and reopen and search for 2, close and reopen etc. 1 and 2 alternate and you get the last search. This works as expected, hopefully. The request is to make the quickfind (ctrl+F) working similarly. It currently does not sort the list if a search item exists. In fact neither the full search does but it remembers the last search item. Something like 1,2,A,Z should become A,1,2,Z and 2,A,1,Z if you research for A and 2 subsequently. And the first item should be picked on show. Something for you, Andreas? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154269] FindReplaceRememberedSearches not respected in quick find bar
https://bugs.documentfoundation.org/show_bug.cgi?id=154269 --- Comment #8 from maison --- (In reply to Heiko Tietze from comment #7) > > (In reply to maison from comment #0) > > I would like to have by default the item last used, > > like all current software, not the last recorded in this list.) > Isn't it how it works. You get the last search entry but can pick one of the > n last used from the dropdown. If you search for FOO and BAR on a rotating > basis I don't know what program offers the previous search before the last. > And I believe it's more common to repeat the last search anyway. Sorry, your comment shows you still don’t make the distinction between the last recorded and the last used. Take a big spreadsheet where you want to browse “FindReplaceRememberedSearches not respected in quick find bar” one by one. When you encounter one of them, you realise you temporarily want to look for an occurrence of “abcde”. You did that then you want to go back to your main searches, but now every time you open the quick search bar, Calc stubbornly will want you to search only for abcde. Your main search is nuked and you have to remind it every time; as soon as you select it from the history and use it, close the search bar and open it again, it stubbornly comes back although you don’t want it any more (i.e. because you’ve been using “FindReplaceRememberedSearches not respected in quick find bar”). This behaviour is inconsistent with Excel (Excel always proposes to reuse the last used search) but also with Calc itself, since if you don’t open the quick search bar, but press Ctrl Shift F, it would indeed reuse the last used search term ! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154269] FindReplaceRememberedSearches not respected in quick find bar
https://bugs.documentfoundation.org/show_bug.cgi?id=154269 --- Comment #7 from Heiko Tietze --- (In reply to V Stuart Foote from comment #6) > So that the 'Findbar' (also the selector > in UI for the string the Navigator uses for repeat) work from the same > array/stack of strings the 'Find and Replace' dialog does. Wouldn't expect this but obviously it is the fact. So I agree to apply the REMEMBER_SIZE to the quickfind as well. (In reply to maison from comment #0) > I would like to have by default the item last used, > like all current software, not the last recorded in this list.) Isn't it how it works. You get the last search entry but can pick one of the n last used from the dropdown. If you search for FOO and BAR on a rotating basis I don't know what program offers the previous search before the last. And I believe it's more common to repeat the last search anyway. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154269] FindReplaceRememberedSearches not respected in quick find bar
https://bugs.documentfoundation.org/show_bug.cgi?id=154269 V Stuart Foote changed: What|Removed |Added CC||heiko.tietze@documentfounda ||tion.org Status|NEEDINFO|NEW See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||2322 --- Comment #6 from V Stuart Foote --- (In reply to Jim Raykowski from comment #5) > svx/source/dialog/srchdlg.cxx > SvxSearchDialog ctor > //tdf#122322 > nRememberSize = > officecfg::Office::Common::Misc::FindReplaceRememberedSearches::get(); > if (nRememberSize<1) >nRememberSize = 1; //0 crashes with no results found > > svx/source/tbxctrls/tbunosearchcontrollers.cxx > FindTextFieldControl::Remember_Impl > if (nCount == REMEMBER_SIZE) > m_xWidget->remove(REMEMBER_SIZE-1); Thanks Jim. Both look to use the same FindTextFieldControl() but manage their entries differently. And the 'Findbar' keeps its REMEMBER_SIZE fixed at 10 [1] when instantiated, and did not get assigned the same nRememberSize for the FindReplaceRememberedSearches handling that the Find and Replace dialog received [2] with some tweaks. Kind of seems like it should have. So that the 'Findbar' (also the selector in UI for the string the Navigator uses for repeat) work from the same array/stack of strings the 'Find and Replace' dialog does. @Heiko? =-ref-= [1] https://opengrok.libreoffice.org/xref/core/svx/source/tbxctrls/tbunosearchcontrollers.cxx?a=true&r=9ddbce1e#76 [2] https://gerrit.libreoffice.org/c/core/+/67614/ for bug 122322 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154269] FindReplaceRememberedSearches not respected in quick find bar
https://bugs.documentfoundation.org/show_bug.cgi?id=154269 --- Comment #5 from Jim Raykowski --- (In reply to V Stuart Foote from comment #4) > @Jim, confirm the Find bar list box and Navigator's repeat use does not > follow the count if changed, so assume its count is fixed, maybe the default > 10? I looked but couldn't find where. svx/source/dialog/srchdlg.cxx SvxSearchDialog ctor //tdf#122322 nRememberSize = officecfg::Office::Common::Misc::FindReplaceRememberedSearches::get(); if (nRememberSize<1) nRememberSize = 1; //0 crashes with no results found svx/source/tbxctrls/tbunosearchcontrollers.cxx FindTextFieldControl::Remember_Impl if (nCount == REMEMBER_SIZE) m_xWidget->remove(REMEMBER_SIZE-1); -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154269] FindReplaceRememberedSearches not respected in quick find bar
https://bugs.documentfoundation.org/show_bug.cgi?id=154269 V Stuart Foote changed: What|Removed |Added CC||rayk...@gmail.com, ||vsfo...@libreoffice.org Status|NEW |NEEDINFO --- Comment #4 from V Stuart Foote --- So your ask is to have the 'FindReplaceRememberedSearches' count from the "Find and Replace" dialog apply to the Find bar? OK. @Jim, confirm the Find bar list box and Navigator's repeat use does not follow the count if changed, so assume its count is fixed, maybe the default 10? I looked but couldn't find where. But also the Find bar lb seems a bit chaotic as to entry handling on the list, e.g. which find strings make the lb, both while active, but also on relaunch in current session. Can if be made to honor the 'FindReplaceRememberedSearches' setting? But also maybe tighten up the lb logic? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154269] FindReplaceRememberedSearches not respected in quick find bar
https://bugs.documentfoundation.org/show_bug.cgi?id=154269 --- Comment #3 from Buovjaga --- (In reply to maison from comment #1) > “Whiteboard: QA:needsComment” > What other comment is needed from the reporter? I can’t find an explanation > in the Whiteboard page. The steps are explained. The bug rather needs > someone to fix it. It needed a comment from QA. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154269] FindReplaceRememberedSearches not respected in quick find bar
https://bugs.documentfoundation.org/show_bug.cgi?id=154269 Buovjaga changed: What|Removed |Added Summary|FindReplaceRememberedSearch |FindReplaceRememberedSearch |es not always used |es not respected in quick ||find bar -- You are receiving this mail because: You are the assignee for the bug.
