[Libreoffice-bugs] [Bug 67302] TablesSupplier name clash when dots in schema/table name
https://bugs.documentfoundation.org/show_bug.cgi?id=67302 --- Comment #19 from Lionel Elie Mamane --- (In reply to Matt K from comment #18) > Can you explain how to create the schema, is it done through an outside > program? Database systems will differ a bit on that, but usually the SQL command is something like: CREATE SCHEMA "name"; > I created 2 tables in LO with the same table name/column name > pattern and the data stays separate between the tables. Exactly same table name is not supposed to be possible, except in different schema or catalog? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67302] TablesSupplier name clash when dots in schema/table name
https://bugs.documentfoundation.org/show_bug.cgi?id=67302 --- Comment #18 from Matt K --- Can you explain how to create the schema, is it done through an outside program? I created 2 tables in LO with the same table name/column name pattern and the data stays separate between the tables. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67302] TablesSupplier name clash when dots in schema/table name
https://bugs.documentfoundation.org/show_bug.cgi?id=67302 --- Comment #17 from Lionel Elie Mamane --- (In reply to Matt K from comment #16) > Can you please provide an example of how to exhibit this bug by using the > interface, and how to see the output? I'm not sure it can be exposed in the UI per se. But if one creates a schema with a "." in the name, and a table with a "." in the name, to trigger the name clash, possibly/probably bugs will start to appear in the UI, in the form of one being used when one means the other. To trigger the name clash, e.g.: - create two schemas "a" and "a.b" - in schema "a", create table "b.c" - in schema "a.b", create table "c" Make the two tables different, at least different data if not different structure. Then try to open one, the other, LibreOffice may be confused between the two, not sure. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67302] TablesSupplier name clash when dots in schema/table name
https://bugs.documentfoundation.org/show_bug.cgi?id=67302 --- Comment #16 from Matt K --- Can you please provide an example of how to exhibit this bug by using the interface, and how to see the output? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67302] TablesSupplier name clash when dots in schema/table name
https://bugs.documentfoundation.org/show_bug.cgi?id=67302 Prashant changed: What|Removed |Added Assignee|lprashan...@gmail.com |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67302] TablesSupplier name clash when dots in schema/table name
https://bugs.documentfoundation.org/show_bug.cgi?id=67302 Prashant changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |lprashan...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67302] TablesSupplier name clash when dots in schema/table name
https://bugs.documentfoundation.org/show_bug.cgi?id=67302 --- Comment #6 from Lionel Elie Mamane --- In connectivity/source/drivers/*, each directory should contain one implementation of getTables() from the XTablesSupplier interface. This does not concern the getTables from the XDatabaseMetaData interface. See http://api.libreoffice.org/docs/idl/ref/interfacecom_1_1sun_1_1star_1_1sdbc_1_1XDatabaseMetaData.html#aee9c7e3149e149b3694c900bd6a0671f http://api.libreoffice.org/docs/idl/ref/interfacecom_1_1sun_1_1star_1_1sdbcx_1_1XTablesSupplier.html#a364c9ed144725a9c2fdb159e2c201e19 The easy way to make the difference between the two is that the one we care about in this bug does not take any arguments, while the other one does. So we need to look for (e.g. with "git grep") getTables definitions and invocations without any argument. Each needs to be changed. Then everywhere getTables (without arguments) is *called* needs to be changed. For the first part, the likely matches are: connectivity/source/drivers/evoab2/NCatalog.cxx connectivity/source/drivers/kab/KCatalog.cxx connectivity/source/drivers/macab/MacabCatalog.cxx connectivity/source/drivers/mork/MCatalog.cxx connectivity/source/drivers/postgresql/pq_connection.cxx connectivity/source/sdbcx/VCatalog.cxx dbaccess/source/core/api/SingleSelectQueryComposer.cxx dbaccess/source/core/api/querycomposer.cxx dbaccess/source/core/dataaccess/connection.cxx dbaccess/source/core/dataaccess/datasource.cxx When these return a pre-made object (which I expect to be common), you need to go look where that object is created. For example, according to comment 0, for postgresql/pq_connection.cxx, this is in pq_xtables.cxx function Tables::refresh I suggest you take them one by one, and we can discuss them one by one. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67302] TablesSupplier name clash when dots in schema/table name
https://bugs.documentfoundation.org/show_bug.cgi?id=67302 --- Comment #5 from Prashant --- I find this task interesting, I want to solve it as my first easy hack. Can anyone please give me some pointer to file to start working on it so that I can assign this task to myself. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67302] TablesSupplier name clash when dots in schema/table name
https://bugs.documentfoundation.org/show_bug.cgi?id=67302 jan iversen changed: What|Removed |Added Whiteboard||ToBeReviewed -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67302] TablesSupplier name clash when dots in schema/table name
https://bugs.freedesktop.org/show_bug.cgi?id=67302 --- Comment #2 from Alex Thurgood --- Adding self to CC if not already on -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67302] TablesSupplier name clash when dots in schema/table name
https://bugs.freedesktop.org/show_bug.cgi?id=67302 Björn Michaelsen changed: What|Removed |Added CC||libreoffice@lists.freedeskt ||op.org --- Comment #1 from Björn Michaelsen --- adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility. see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67302] TablesSupplier name clash when dots in schema/table name
https://bugs.freedesktop.org/show_bug.cgi?id=67302 Lionel Elie Mamane changed: What|Removed |Added Whiteboard|Easyhack|EasyHack |DifficultyInteresting |DifficultyInteresting |SkillCpp SkillSQL |SkillCpp SkillSQL -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67302] TablesSupplier name clash when dots in schema/table name
https://bugs.freedesktop.org/show_bug.cgi?id=67302 Lionel Elie Mamane changed: What|Removed |Added Whiteboard||Easyhack ||DifficultyInteresting ||SkillCpp SkillSQL -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
