Re: [Libreoffice-qa] Extending subsequent tests with dogtail tests?

[Markus Mohrhard]

Hey,

On Fri, Mar 8, 2019 at 6:33 PM Miklos Vajna  wrote:

> Hi,
>
> The current practice is: if 'make check' passes (which is more or less
> enforced by Jenkins) and the change looks good to a reviewer, the change
> goes in. And then releases are based on time, so it's really rare that
> there are "blocker" bugs which would delay a release.
>
> The ideal for any new kind of testing (including accessibility) is that
> it's integrated into 'make check', and whatever those tests cover are
> not OK to be broken anytime.
>
> If the proposed a11y tests are part of make check, then it's easy to
> promise that they won't be broken; otherwise it's just a best effort
> thing without any guarantees.
>
> At least that's how I understood what Markus wrote, and I agree with
> that.
>

Exactly that. With the added comment about the reliability necessary or
developers will start ignoring test failures or even worse disable failing
tests.

Kind regards,
Markus


> Regards,
>
> Miklos
>
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Extending subsequent tests with dogtail tests?

[Markus Mohrhard]

Hey,

let me at least add some comments.

On Thu, Mar 7, 2019 at 5:42 PM Jean-Philippe MENGUAL <
jean-philippe.meng...@libreoffice.org> wrote:

> Hi,
>
>
> Le 06/03/2019 à 20:52, Samuel Thibault a écrit :
> > Hello,
> >
> > Markus Mohrhard, le lun. 25 févr. 2019 00:34:33 +0800, a ecrit:
> >> On a slightly related note I think that we have already quite a few
> tests for
> >> the accessibility UNO layer but as that layer is full of bugs many of
> the tests
> >> are disabled. It might be a good idea to work on these tests before
> actually
> >> trying to implement more complex tests that depend on lower layers
> working
> >> correctly.
> >
> > I'm not sure which piece you are referring to.  Is that the AWB?  I
> > indeed see some source code in toolkit/test/accessibility but no
> > reference to it.
>

There should be accessibility UNO API tests in most top level modules. E.g.
from a quick git grep Accessible -- qadevOOo/Jar_OOoRunner.mk:

qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/ifc/accessibility/_XAccessible \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/ifc/accessibility/_XAccessibleAction \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/ifc/accessibility/_XAccessibleContext \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/ifc/accessibility/_XAccessibleEditableText \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/ifc/accessibility/_XAccessibleEventBroadcaster \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/ifc/accessibility/_XAccessibleExtendedComponent \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/ifc/accessibility/_XAccessibleImage \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/ifc/accessibility/_XAccessibleSelection \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/ifc/accessibility/_XAccessibleTable \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/ifc/accessibility/_XAccessibleText \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/ifc/accessibility/_XAccessibleValue \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_basctl/AccessibleShape \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_sc/AccessibleEditableTextPara_HeaderFooter \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_sc/AccessibleEditableTextPara_PreviewCell \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_sch/AccessibleDocumentView \
qadevOOo/Jar_OOoRunner.mk:qadevOOo/tests/java/mod/_sc/ScAccessibleCell \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_sc/ScAccessibleCsvCell \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_sc/ScAccessibleCsvGrid \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_sc/ScAccessibleCsvRuler \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_sc/ScAccessibleDocument \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_sc/ScAccessibleDocumentPagePreview \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_sc/ScAccessiblePageHeader \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_sc/ScAccessiblePageHeaderArea \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_sc/ScAccessiblePreviewCell \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_sc/ScAccessiblePreviewHeaderCell \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_sc/ScAccessiblePreviewTable \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_sc/ScAccessibleSpreadsheet \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_sd/AccessibleDrawDocumentView \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_sd/AccessibleOutlineView \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_sd/AccessibleSlideView \
qadevOOo/Jar_OOoRunner.mk:qadevOOo/tests/java/mod/_sm/SmEditAccessible \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_sm/SmGraphicAccessible \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_svtools/AccessibleBrowseBox \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_svtools/AccessibleBrowseBoxHeaderBar \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_svtools/AccessibleBrowseBoxHeaderCell \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_svtools/AccessibleBrowseBoxTable \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_svtools/AccessibleBrowseBoxTableCell \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_svtools/AccessibleIconChoiceCtrl \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_svtools/AccessibleIconChoiceCtrlEntry \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_svtools/AccessibleTabBar \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_svtools/AccessibleTabBarPage \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_svtools/AccessibleTabBarPageList \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_svtools/AccessibleTreeListBox \
qadevOOo/Jar_OOoRunner.mk:
qadevOOo/tests/java/mod/_svtools/AccessibleTreeListBoxEntry \
qadevOOo/Jar_OOo

Re: [Libreoffice-qa] Extending subsequent tests with dogtail tests?

[Markus Mohrhard]

Hello Samuel,

let me add a few comments based on many years implementing testing
frameworks for LibreOffice and most recently working on the UI testing.

On Sat, Feb 23, 2019 at 6:24 PM Samuel Thibault  wrote:

> Noel Grandin, le sam. 23 févr. 2019 12:19:19 +0200, a ecrit:
> > However, the current python UI test stuff talks directly to the vcl/
> widgets.
> > But between the vcl/ widgets and an actual accessibility user lies at
> least two
> > major chunks of code - the generic accessibility/ stuff, and the
> operating
> > system specific bridges.
>
> Yes, that's my concern with testing only at the vcl layer.
>
> That said, we could as well make tests work at both layers. Run them
> along uitests, thus very frequently, and run them periodically through
> the accessibility layer on a system which has it.
>
>
If my understanding of your idea is correct you want to test actually two
things that are required for working accessibility for users. On one hand
you need to test the accessibility APIs and on the other hand correct focus
handling. I think you most likely want to test them independently if
possible as I think you'll discover that combining them will lead to hard
to diagnose problems. Additionally, the target of any test framework has to
be that it minimizes the number of random test failures and requires as
little adoption for unrelated code changes as possible.

I noticed after quickly looking at your proposed tests is that you use UI
strings in your tests which I think you want to avoid as much as possible.
There are several problems with UI strings that make them a bad property
during testing: they change often, often not even by developers and are
localized. Especially the second point means that your tests suddenly only
work in en-US which surely limits a bit the usefulness of the tests. Even
more if you plan to generate test cases automatically as it means that the
tests can only be generated with an en-US locale.

On a slightly related note I think that we have already quite a few tests
for the accessibility UNO layer but as that layer is full of bugs many of
the tests are disabled. It might be a good idea to work on these tests
before actually trying to implement more complex tests that depend on lower
layers working correctly. The focus handling can be easily integrated into
the existing UI testing infrastructure and might benefit there from some of
the concepts that should make them more stable (deadlock detection,
addressing UI elements through ID instead of UI visible strings, mostly
working async dialog and action handling) and I think it makes sense to
check how much of the accessibility part can not be covered with a
combination of UI testing and accessibility UNO API testing. It might even
be possible to get accessibility event interception into the UI testing to
check that events are generated correctly during actions. I would need to
look into how our accessibility handling works in the VCL layer to be sure
that this actually works.

For the dependencies we surely don't want to include the source code itself
into LibreOffice's external dependency handling. At least for the beginning
the easiest approach might be something like an
--enable-accessibility-tests flag which can be checked in configure.ac
where we make sure all required dependencies are around. If we ever decide
that they should be run by default we can still switch the default value
and make it possible for people to override the setting in their autogen
settings.

On a slightly related note, please make sure that you are developing
against python 3. I did not check if you are actually using any pure
python2 features but at least "#!/usr/bin/python" will get you a python 2
interpreter on most systems.

Kind regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Automate the installation of the nightly releases

[Markus Mohrhard]

Hey Jean-Philippe,

On Sun, Jan 13, 2019 at 12:38 AM Jean-Philippe MENGUAL <
jean-philippe.meng...@libreoffice.org> wrote:

> Hi,
>
> I now can use the Debian packaged release of the nightly builds of
> Libreoffice. I use the French langpack as well.
>
> Could you help me for writing a script run as root, in order to:
> - download the tarballs
> - untar
> - install the Debian packages
> - remove the tarballs and untarred foldersdossiers décompressés
>
> The binary needs to be installed before the langpack.
> I know all right what I need, but: in the URL processed by wget, there is:
>
> https://dev-builds.libreoffice.org/daily/master/Linux-rpm_deb-x86_64@86-TDF/current/
> 
> master~2019-01-11_09.39.05_LibreOfficeDev_6.3.0.0.alpha0_Linux_x86-64_deb.tar.gz
> 
> and:
>
> https://dev-builds.libreoffice.org/daily/master/Linux-rpm_deb-x86_64@86-TDF/current/master~2019-01-11_09.39.05_LibreOfficeDev_6.3.0.0.alpha0_Linux_x86-64_deb_langpack_fr.tar.gz
>
> - how can I detect th exact name of Linux-rpm_deb-x86_64@86-TDF
> automatically (the end number (86) is ramdom)
>

The number is the number for the build machine. So the @86 means that the
build was produced by the build machine with the number 86 and the
following "-TDF" that it is a TDF controlled machine. The remaining parts
are branch name, date and time, product name (LibreOffice vs
LibreOfficeDev), the version string and finally the platform.

I hope this helps you figuring out how to always find the correct build. I
think you want to keep build machine, branch name, product name and
platform constant and the version string should only change after a new
version has been branched off (only every 6 months).

Actually I think most of that is handled for you by always using the same
directory e.g.
https://dev-builds.libreoffice.org/daily/master/Linux-rpm_deb-x86_64@86-TDF/current/

 and then just picking the *_deb.tar.gz and the *_deb_langpack_fr.tar.gz
files.

Kind regards,
Markus

- the filename is ramdom too
>
> How can I detect them automatically to make them untar and processed
> automatically?
>
> Thanks for your help.
>
> Regards
>
>
>
>
> --
> signature_jp_2
> Logo Hypra  JEAN-PHILIPPE MENGUAL
> DIRECTEUR TECHNIQUE ET QUALITÉ
> 102, rue des poissonniers, 75018, Paris
> Tel : +331 84 73 06 61  Mob : +336 76 34 93 37
> 
> jpmeng...@hypra.fr 
> www.hypra.fr 
> Facebook Hypra  Twitter Hypra
>  Linkedin Jean-Philippe
> 
>
>
> ___
> List Name: Libreoffice-qa mailing list
> Mail address: Libreoffice-qa@lists.freedesktop.org
> Change settings:
> https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
> Problems?
> http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
> Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
> List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] minutes of ESC call ...

[Markus Mohrhard]

Hey all,

On Thu, Dec 6, 2018 at 4:31 PM Michael Meeks 
wrote:

>  + minor complaint wrt. single Chart save removal in calc (Heiko)
> + how to know ? - checkout release notes
>
>

These people should feel free to complain to me. However the removal was
necessary and long overdue. Actually, the feature was responsible for many
regressions and was originally intended by me for debugging purposes.


> * Tinderbox bits (Stephan)
> + gandalf – too old compiler; keeps failing tinderboxen
>+ bit of a problem, needs SUSE goodwill to help us connect a
> console etc.
>+ can we not live-upgrade it ? (Thorsten)
>+ just needs a new gcc (Stephan)
>   + some SLES12 there – with internal repos etc. (Thorsten)
>  + in some odd state there.
>+ not eager to touch it unless we can afford to loose it (Thorsten)
> + rsync some container or other onto there ?
> + what jobs run there ? (Thorsten)
>+ lcov, perftest(?), random config,
>  UI testing, update, UI testing (Stephan, Christian)
>+ can we move jobs off it ?
>   + unclear if they have extra build deps ? (Christian)
>  + perhaps more sustainable to migrate this (Thorsten)
> + poke Guilhelm → to poke admins (Christian)
>


perftest is not running on gandalf, instead on vm139.

As I'm one of the main users of gandalf (e.g. update, UI testing, random
config) and some more exotic builds not managed by jenkins I will try to
take care of the update during the weekend. I already managed to get gperf
working but the SUSE network firewall blocks access to github so flex could
not be updated. The new compiler should be possible without major issues.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Producing QA master crash report builds

[Markus Mohrhard]

Hey,

On Tue, Sep 13, 2016 at 1:48 PM, Xisco Fauli 
wrote:

> Hi,
>
> (adding Markus Mothrhard as CC)
>
> El 13/09/16 a les 04:04, Jay Philips ha escrit:
>
>> Hey guys,
>>
>> Hope LibOCon was enjoyable.
>>
>> So if i remember correctly, only release builds have the crash reporter
>> built in,
>>
> @Markus: Can you confirm?
>


Yes. Only TDF Windows and Linux release builds have enabled crash reporter.
You can enable it in other builds as well but it will be useless unless you
also upload the build symbols.


> but it would be useful to have crash reporting during the
>> development of the master, so i'd like to suggest that master crash
>> report builds be created atleast once a month so QA can bang against it,
>> especially those who use it on a regular basis outside of QA, so we are
>> less reliant on users to bang against it with real releases.
>>
>
> I would propose to enable it for alpha and beta versions in case it's not
> enable right now, but personally I wouldn't do it in master for 2 reasons:
> 1. master is mainly tested by QA people so we can report the crashes
> directly in bugzilla providing more information like regression, bibisect,
> etc...
> 2. I'm not sure the server would be able to handle all requests coming
> from master too.
>


It is enabled for alpha and beta builds. There are plans from my side to
enable it for at least one tinderbox build at some point however that needs
more work from me. The following problem currently block this:

* a way to automatically delete symbols after some time - we don't want to
keep the symbols for daily builds too long, each symbol set is around 700MB
* a way to identify builds with the git sha and not only with the version
number

The Server should be able to handle the additional load easily. The alpha
and beta build caused less than 50 crashes a day and we are now up to 1200
a day for the release builds. The theoretical max that we can process right
now is around 20k.


So for now it is mostly blocked by some missing work on the server side as
well as finding a solution to the additional disk space requirement. Feel
free to work on one or the other task and help make daily master builds
with crash reporting a reality.

Regards,
Markus


>
> Anyway, I'd like to hear markus' opinion on this.
>
>
>> Regards,
>> Yousuf
>> ___
>> List Name: Libreoffice-qa mailing list
>> Mail address: Libreoffice-qa@lists.freedesktop.org
>> Change settings: https://lists.freedesktop.org/
>> mailman/listinfo/libreoffice-qa
>> Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-uns
>> ubscribe/
>> Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
>> List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
>>
> Regards
>
> --
> Xisco Faulí
> Libreoffice QA Team
>
>
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] minutes of ESC call ...

[Markus Mohrhard]

On Thu, Jul 28, 2016 at 5:18 PM, Michael Meeks 
wrote:

>
> * Windows XP deprecation for 5.2 story ? (Cloph)
> + goal - to have the baseline be based on Windows Server 2016, and VS
> 2015
> + unclear if builds created with this combination will run on WinXP
> + Thorsten had a stackoverflow comment saying it should work.
> + just giving warning that if there are big hassles with WinXP API etc.
>   we may drop it for 5.3 and onwards.
> + no real reason to drop it as a platform for now.
>+ just want to give the advanced warning that it may go sooner
> (Norbert)
> + sob stories about old / stolen WinXP (Heiko)
>+ no sympathy - if running a 10 year old OS, can run old
> LibreOffice (Norbert)
>+ this is a meritocracy, who does the work chooses (Norbert, et. al)
> + even if we did remove it - always room for volunteers to make their
> own builds (Bjoern)
> + but no news here: we continue as before (Michael)
>


A side note about that. Both 5.2 as well as 5.1.5 should work much better
and fix the problem around curl on XP. That will bring back support for ucp
providers based on curl and the update check. Based on that experience
unless the toolchain makes it impossible most external libs seem to support
XP through passing the correct XP SDK version in.


>
>
> * Crashtest update (Caolan)
> + 1 import failure, 7 export failures, coverity pending
> + discovered there was a timeout, throwing an assert after 2 minutes
>   an issue on the crash-testing box, but not when tested.
> + marketing numbers of 0.00 for coverity correct as of last testing
> cf. 5.2 branch
> + database documents being round-tripped (Michael S)
>+ had a tendency to deadlock - 10% of them.
>+ ended up being killed by the python script: didn't result in a
> crashlog.
>+ only get an entry in the crashlog if we get a dispose exception.
>+ have a fix for that; to introduce in the database document the
>  solar mutex for locking
>+ another potential gift that will give and give.
>+ crash test now runs without deadlocking
>-> can we fix the python script - to report hangs ? (Michael)
>+ some where writer has an infinite layout loop (Michael S)
>+ should these be reported in crash-testing ? not sure.
>

The script was reporting the files it could not open and the files that
took too long. Keep in mind that this not only covers deadlocks and
therefore it was nearly impossible to get anything useful from the results.
It limits all tests for a file (so all the import and then reexport to
different formats to 3 minutes). In theory we could increase the limit and
enable reporting again to reduce the number of false positives but that
will also increase the runtime of the crash testing significantly.
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] (no subject)

[Markus Mohrhard]

On Fri, Jul 1, 2016 at 6:06 PM, Pedro  wrote:

> Since LO now has a crash report then there is no need to do backtraces,
> right?
>
>
So the crash reporter only works in official TDF builds. So currently in
the 5.2.0.0 beta2 build, the 5.2.0.1 build and any following beta, rc and
release builds. It does not work in master and daily builds. I might look
into supporting it for one master daily build at some point.



> When I reproduce a crash, how can I link the crash report to the bug report
> in the tracker?
>
>
The crash report website has now links that already fill in the required
information to connect the reports back. There is a script that then
updates the crash reporter and hopefully in a bit I might be able to get
the bugzilla extension working that actually makes that all a bit more user
friendly.

As an example
http://crashreport.libreoffice.org/stats/crash_details/06e4ab19-8bac-492d-a4f2-962ab692dd79
links to the bug report that is already connected with the crash and also
allows to file a bug report that will already set the custom field
correctly.

Regards,
Markus


>
>
> --
> View this message in context:
> http://nabble.documentfoundation.org/Libreoffice-qa-no-subject-tp4187667p4187714.html
> Sent from the QA mailing list archive at Nabble.com.
> ___
> List Name: Libreoffice-qa mailing list
> Mail address: Libreoffice-qa@lists.freedesktop.org
> Change settings:
> https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
> Problems?
> http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
> Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
> List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
>
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-qa] (no subject)

[Markus Mohrhard]

Hey,

so the crash report server has now a link to generate bug reports directly
from a crash report with a number of information already filled out.
Especially the crash signature is already correctly set and some default
comment to link back to the crash report.

The question for the QA team is now if you want these reports to be marked
with a keyword that is set at the same time. It would be no difference for
the code an I have no idea if that would be helpful in the future.

As an example see
http://crashreport.libreoffice.org/stats/crash_details/06e4ab19-8bac-492d-a4f2-962ab692dd79
You can click one of the links after "File a bug for: " and it will
automatically set the product, component and cf_crashreport field

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] minutes of ESC call ...

[Markus Mohrhard]

On Thu, Jun 23, 2016 at 5:08 PM, Michael Meeks 
wrote:

>
>
>
> + Most Pressing Bugs:
> http://tdf.io/mostressingbugs
> + tdf#100295 - LibODev-5.2.0.0.b2 does not run in Windows_XP (32
> or 64 bit)
> + Interest in fixing ?  (or is this a 'feature' ?)
> + Tor - thinks a feature.
> + last time - 10% of Windows market (Michael)
>+ compares vs. Mac install base.
> + can we bibisect for Windows to find what killed it.
> + could be related to breakpad ? (Cloph)
>+ a duplicate with more info in it out there.
>+ perhaps Moggi had a look ?
>


I think I mentioned it before. Currently I assume that it is a problem with
libcurl. Unless you specify that you want to compile against the correct
SDK version libcurl uses a vista function unconditionally. So this has been
an old problem (and would have crashed on XP if the corresponding ucp
component got loaded) but is now causing a crash already during start as
our minidump uploaded has a libcurl dependency.

There is a patch to fix it by telling the libcurl build to compile against
the old version but as I have no XP I can not test if it really helps.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Adding a field for crash reports to bugzilla

[Markus Mohrhard]

Hey,

On Wed, Jun 15, 2016 at 6:16 PM, Markus Mohrhard <
markus.mohrh...@googlemail.com> wrote:

> Hey,
>
> does anyone here have a problem with me adding a field for crash report
> ids to bugzilla. I would modify the message in the dialog that tells the
> user about the crash to post the crash id to a bug report.
>
> We would most likely also use that to map bug reports to crash reports.
>
> It looks like a cleaner solution than using the see also field.
>
> Regards,
> Markus
>


We have such a field now. I will update the text in the dialog that tells
the user about a crash and will implement a set of scripts to sanitize the
input and keep bugzilla and the crash reporter in sync.

I might also look into adding a button for logged-in users of the crash
report site to automatically generate a bug report.

If you have any comments or improvement requests please let me know.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Adding a field for crash reports to bugzilla

[Markus Mohrhard]

Hey Stuart,

On Wed, Jun 15, 2016 at 7:20 PM, V Stuart Foote 
wrote:

> Markus,
>
> This sounds great,  assisting the users to post the minidump details to BZ
> should help both QA triage, and developer response.  And of course the QA
> Wiki will need to include some guidance on what to do with the minidumps.
>
> Two questions...
>
> 1.) can our BZ infrastructure grow to hold increase of  minidumps that
> would
> result? Or do all the uploaded BreakPad dumps go to other infrastructure--
> and BZ will only have links to pull?
>


This is only about the crash id which is just a long UUID. The reports go
to the crashreporting infrastructure. The minidumps are never seen directly
by a developer or a QA person. This is just a way to link the two systems.


>
> 2.) will we be doing something for the OS X builds?  Is there a way to link
> Crash Reporter.app dumps to BreakPad on OS X and upload those dumps as
> well?
> Covering Linux, and Windows but not OS X would be unfortunate.
>


There are no plans to include it for OSX right now. The server side can
handle it but I don't plan to work on it and it will surely not be part of
the 5.2 release.

Regards,
Markus


>
> Stuart
>
>
>
> --
> View this message in context:
> http://nabble.documentfoundation.org/Libreoffice-qa-Adding-a-field-for-crash-reports-to-bugzilla-tp4186278p4186284.html
> Sent from the QA mailing list archive at Nabble.com.
> ___
> List Name: Libreoffice-qa mailing list
> Mail address: Libreoffice-qa@lists.freedesktop.org
> Change settings:
> https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
> Problems?
> http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
> Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
> List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
>
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-qa] Adding a field for crash reports to bugzilla

[Markus Mohrhard]

Hey,

does anyone here have a problem with me adding a field for crash report ids
to bugzilla. I would modify the message in the dialog that tells the user
about the crash to post the crash id to a bug report.

We would most likely also use that to map bug reports to crash reports.

It looks like a cleaner solution than using the see also field.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] 5.2 Beta problems

[Markus Mohrhard]

Hey Pedro,

On Sat, May 28, 2016 at 5:22 PM, Pedro  wrote:

> Hi all
>
> After installing version 5.2 Beta as a parallel install under Win 10 x64 I
> get two problems:
>
> 2) On the second run LibreOffice reports that it is not working correctly
> and needs to send a Bug Report. Clicking yes briefly flashes a console
> window (but the message is displayed too fast to be read) and nothing
> happens after: no Success/Failure/Thank you dialog but also no crash or any
> problem...
>

That is currently expected. The UI still needs to be improved but the crash
has been uploaded correctly.


>
> 
>
> Is this a feature test but no report is actually sent?
>
> Can anyone confirm this?
>

You can see your report at
http://crashreport.libreoffice.org/stats/signature/KERNELBASE.dll+0x71f28

I'm currently working on improving the client and the server side but for
now it is mostly to see how many resources we need to handle it for the
production. UI improvements will hopefully land for the beta2 builds both
on client as well as on the server.

Regards,
Markus


>
> Thanks,
> Pedro
>
>
>
> --
> View this message in context:
> http://nabble.documentfoundation.org/5-2-Beta-problems-tp4184641.html
> Sent from the QA mailing list archive at Nabble.com.
> ___
> List Name: Libreoffice-qa mailing list
> Mail address: Libreoffice-qa@lists.freedesktop.org
> Change settings:
> https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
> Problems?
> http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
> Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
> List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] CrashDumps?

[Markus Mohrhard]

Hey Pedro,

On Thu, May 12, 2016 at 6:23 PM, Pedro  wrote:

> Hi Stuart
>
> Thank you for the quick answer.
>
> Is this a new feature in LibreOffice?
>

These crash dumps are not a feature of LibreOffice. They are part of the
normal windows crash reporting procedures. However we are still hoping to
integrate some crash reporter for 5.2 that will generate the same format
and upload the crash reports to a TDF server.


>
> In case anyone is interested, the way to disable it is described in this
> page
>
>
> http://stackoverflow.com/questions/6035112/disable-application-crash-dumps-on-windows-7
>
> Thanks!
> Pedro
>
>
>
> --
> View this message in context:
> http://nabble.documentfoundation.org/CrashDumps-tp4183396p4183408.html
> Sent from the QA mailing list archive at Nabble.com.
> ___
> List Name: Libreoffice-qa mailing list
> Mail address: Libreoffice-qa@lists.freedesktop.org
> Change settings:
> https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
> Problems?
> http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
> Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
> List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
>
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] new keyword needUITest

[Markus Mohrhard]

Hey,

On Thu, Apr 28, 2016 at 7:35 AM, Tommy <ba...@quipo.it> wrote:

> Markus Mohrhard wrote:
>
>> Hey,
>>
>> can we add a new keyword needUITest to bugs that are purely in the UI?
>>
>> It would help me track bugs that can not be tested right now and would
>> need a test later.
>
>
>> Regards,
>> Markus
>>
>>
>
> no objections from my side.
> would you please dgive a couple of bugs that would follow in that category?
>


Of course. A good example is
https://bugs.documentfoundation.org/show_bug.cgi?id=98427 which obviously
can not be tested by the current framework as it is purely about the UI. So
I suppose many are difficult for the QA team to tag but it is right now
mostly a tool for me to track bugs. I have been using a tag for that but
that does not really scale.

Regards,
Markus


>
> cheers, Tommy27
>
>
> ___
> List Name: Libreoffice-qa mailing list
> Mail address: Libreoffice-qa@lists.freedesktop.org
> Change settings:
> https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
> Problems?
> http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
> Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
> List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-qa] new keyword needUITest

[Markus Mohrhard]

Hey,

can we add a new keyword needUITest to bugs that are purely in the UI?

It would help me track bugs that can not be tested right now and would need
a test later.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] writing unit test for calc functions

[Markus Mohrhard]

Hey Pedro,

On Sat, Apr 16, 2016 at 5:05 PM, Pedro  wrote:

> Hi Markus
>
> Personally I'm very interested in using Calc as a replacement for Excel.
> The
> spreadsheets I work with commonly have more than 65k lines so using the old
> Excel 2003 (included in my work desktop) is useless but Calc is still not
> stable/efficient enough.
>
> One of the main problems with Excel and Calc is compatibility. ODS is out
> of
> question (because MS manages to ruin all ODS files) and XLSX has lots of
> issues in round-trip work (particularly in Pivot Tables)
>

This whole stuff here is purely about the formula compiler and formula
interpreter. For other features exist other types of tests, filters-test,
export-test, ...


>
> Regarding your CSV only approach, Calc does have the option to Save
> formulae
> instead of values (and curiously opening these files in Excel 2010 works!)
> but there are probably limitations (I just found out that array formulas
> are
> not interpreted correctly on both programs)
>

The CSV approach is already implemented and is what we are currently using.
It is basically just a comparison of the formula results with a csv file.
So the question right now is if the csv part should be replaced by a pure
spreadsheet error checking. The CSV approach always required a developer as
there are many special cases that can not completely be handled without
running the test.


>
> Since it is not in Microsoft's interest to be 100% compatible with ODS, I
> think that your spreadsheet approach should include both ODS and XLSX.
>

These tests are for the formula compiler and formula interpreter.
Everything that can be evaluated can be expressed in an ODF file (maybe not
visible to the user).



>
> So, if manual testing your files leads to greater compatibility you can
> count me in.
>


The idea is to generate test files that can be used for manual testing but
more importantly can also be used in the automated testing. Currently all
our formula compiler and formula interpreter tests can only be used in the
automated testing. One advantage of the new approach would be that it makes
it easier for non-developers to write such test documents and make
therefore sure that all functions are properly tested.


>
> Regards,
> Pedro
>
>
>
> --
> View this message in context:
> http://nabble.documentfoundation.org/Libreoffice-qa-writing-unit-test-for-calc-functions-tp4181287p4181297.html
> Sent from the QA mailing list archive at Nabble.com.
> ___
> List Name: Libreoffice-qa mailing list
> Mail address: Libreoffice-qa@lists.freedesktop.org
> Change settings:
> https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
> Problems?
> http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
> Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
> List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-qa] writing unit test for calc functions

[Markus Mohrhard]

Hey guys,

so once again I was bit by our missing systematic unit tests for all the
formula functions. I'm wondering what we can do to make external people
interested in adding tests for all functions. Right now I think that my csv
based approach is too complicated (how to handle precision issues, ...) and
I wonder if it makes sense to switch from such an approach to a pure
spreadsheet approach.

So for each function creating a spreadsheet with a summary sheet that
contains one cell with a true false return value. This would mean that
writing the test is purely creating a spreadsheet and all the error
checking happens inside of the spreadsheet. The test would only open the
document, force a hard recalc and check that one cell.

Basically I'd like to have for each spreadsheet function a document that
checks all corner cases and can be used for manual testing as well as for
automated testing.

Does that make sense?

@Winfried: You are writing most of the spreadsheet functions right now.
Would that be something that would help you add tests for all new
functions? You could add your test cases directly in the spreadsheet and
use it for manual checking as well as later for an automated test.

@Eike: You are fixing most of the corner cases in the interpreter. Do you
think that this is better than our current ucalc based approach for bug
fixing?

@QA team: Does this sound like something that would make it easier for you
to add tests for spreadsheet functions?

I'm also open to alternative ideas or people telling me that it is a stupid
idea.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] minutes of ESC call ...

[Markus Mohrhard]

Hey Michael, Keny, Eike,

On Thu, Nov 26, 2015 at 5:51 PM, Michael Meeks 
wrote:

>
> + calc s/w interpreter-related patch
> [ also got in before the freeze; an 18x speedup on CPU for
>   some test sheets; currently guarded by a variable - and
>   subsetting to just some sheets.
>  + plan to test with crash-testing sheets & enable by
> default
>   Would like to look at it (Eike)
>  + dislike env.vars set - avoids the unit-tests
> + plan to remove it before ship (Kendy)
> + turn into normal config & default ->
> testable.
> + would like to turn it on now - default on for
> user-testing (Kendy)
> + optional B2 in the release-plan (Cloph)
> + can have an intermediate release.
>  + goal of the code - vectors of doubles
> + formula results (Michael)
> + moves big chunk of ptr chasing & branching
> from inner loop.
> ]
>


please add a performance test that ensures that future refactorings won't
regress here. In general any patch claiming performance improvements should
be accompanied by a performance test to make sure that we can still
refactor the code without someone complaining that we introduced huge
performance regression.

Related to the code I wanted to mention that the getenv calls should be
cached in a static variable as they might become expensive when called
repeatedly and that the new virtual method calls are not free so I would
like to see some before and after numbers for both the supposed 18x speedup
case and our normal matrix handling code.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Minutes of ESC call: 2015-07-30

[Markus Mohrhard]

 * Areas that require unit tests with each bugfix (Markus/???)
 + https://wiki.documentfoundation.org/Development/Unit_Tests
 + updated the page with the areas where tests for fixes are
 mandatory (Kendy)
 + so far: chart2, writer filters (import + export)
 + do we have more areas where we can have this rule? (Kendy)
 + important to have the maintainer who is checking the code,
 and the test itself too (Kendy)
 + happened in the past that the test did not fail when the fix
 was reverted (Kendy)


So just to make it clear as it seems that I gave the wrong impression. I
don't insist on all chart2 commits having a test (it would be nice if
everyone would write a test), however if I manage to review a patch and ask
for a test to a chart2 patch I expect that the patch is not pushed without
the test. In general I will ask for a test in all chart2 patches where it
makes sense. Of course I would be even more happy if everyone would just
write the test and I would only need to make sure that the test passes and
fails without the fix.


+ would be good to be able to make tests even for bugs that are not
 fixed yet (Bjoern)
 + happened in the past too, much appreciated, helps fixing (Miklos)
 + do we have a way to mark such a case? (Jan-Marek)
 + not really (Norbert, Miklos)
 + 'make -k stagingcheck' - for tests that do not have a fix yet
 (Bjoern)
 + isn't it enough to have them in gerrit? (Miklos)
 + can prototype that (Bjoern)
 + that's easy, harder is the infra to show them to the
 people (Bjoern)
 + might be better to have 'expected failures' tests (Jan-Marek)
 + with easy way to move them to 'expected passes'
 (Jan-Marek)
 + writing a test needs some knowledge, couldn't we actually mentor
 the author to do a fix too? (Kendy)
 + can be much harder (Norbert, Bjoern)
 + problem is how to promote the existing tests that don't have the
 fixes yet (Norbert)
 + more concerned to have some xxx tests run, yyy failed, zzz
 passed (Norbert)
 + have the special rule could work, would like not to see that
 some tests may fail
   in the normal build, so that it is not perceived as 'normal
 that some tests fail (Kendy)
 AI: + will have a look at the CppUnit to implement 'expected failure'
 (Jan-Marek)
 + Cpp logs are e.g. in
 workdir/CppunitTest/sal_rtl_math.test.log



That is already possible with cppunit. Instead of using CPPUNIT_TEST use
CPPUNIT_TEST_FAIL which tells cppunit that the test is expected to fail
with a cppunit exception being thrown (it is extensively used in the
cppunit internal unit tests). The test will start to fail when none of the
asserts fail anymore. Keep in mind that it might be dangerous to use this
with more than one assertion as an unexpected one might fail.

Additionally there is CPPUNIT_TEST_EXCEPTION which expects as second
parameter the expected exception. So this is a replacement for the
following pattern that can sometimes be found in our code:

void Test::someTestMethod()
{
bool bExceptionThrown = false;
try
{
callMethodThatShouldThrow();
}
catch (ExpectedExceptionType)
{
 bExceptionThrown = true;
}
CPPUNIT_ASSERT(bExceptionThrown);
}


 + people should look if there has been a -1 (Norbert)
 + -1 is not sticky, it is bound to the version of the patch
 (Norbert)
 + please look if somebody gave -1 before you are reviewing and
 pushing, to avoid too
   many people using -2 which is sticky (Norbert)
 + if reverting a patch, please don't forget to let the original author
 know (Kendy)
 + should we do a git hook to mail when a revert happened? (Norbert)
 + mechanic message maybe could make problems - human interaction
 probably better? (Bjoern)
 + but letting know is important; usually there is a good reason
 for a revent (Norbert)
 + it is not personal, it just happens (Norbert)
 AI: + can have a look (Norbert)
 + mail to the author + committer + the person who reverted
 (Bjoern)
 + best to get more reviewers in gerrit, so that reverts are seldom
 (Bjoern)
 + how to handle when something is pushed to these areas anyway?
 + the same rules as when breaking the build (Miklos)
 + when the author is responsive, and working on the test, let
 it in (Miklos)
 + when not, revert (Miklos)
 + timing is up to the maintainer (Miklos, Norbert)
 + it is always a trade-off (Bjoern)
 + best to talk to the maintainer, not to overrule him/her
 (Norbert)
 + important to talk to people, don't push without talking when
 overruling (Eike)


___
List Name: Libreoffice-qa mailing list
Mail address: 

Re: [Libreoffice-qa] Minutes of ESC call: 2015-07-30

[Markus Mohrhard]

Hey,

On Sun, Aug 2, 2015 at 9:01 PM, Norbert Thiebaud nthieb...@gmail.com
wrote:

 On Sun, Aug 2, 2015 at 11:25 AM, Markus Mohrhard
 markus.mohrh...@googlemail.com wrote:


  AI: + will have a look at the CppUnit to implement 'expected
 failure'
  (Jan-Marek)
  + Cpp logs are e.g. in
  workdir/CppunitTest/sal_rtl_math.test.log
 
 
 
  That is already possible with cppunit. Instead of using CPPUNIT_TEST use
  CPPUNIT_TEST_FAIL which tells cppunit that the test is expected to fail
 with
  a cppunit exception being thrown (it is extensively used in the cppunit
  internal unit tests). The test will start to fail when none of the
 asserts
  fail anymore. Keep in mind that it might be dangerous to use this with
 more
  than one assertion as an unexpected one might fail.
 

 That is not exactly what tha aim is...
 the aim is to have a failure be repport as such and not stop
 everything.. when a test is tagged as _can fail_ or something
 this is when a test is added before the fix


So you want to have this as non-fatal tests. Ok, that is currently missing
from cppunit but at least with the CPPUNIT_TEST_FAIL you can add tests
before the bugfix and just change it from CPPUNIT_TEST_FAIL to CPPUNIT_TEST
when the fix has been implemented. So it is a compromise as it is already
there and we can have a look how difficult it would be to properly
implement non-fatal tests in cppunit.



 also the minutes claim that cppunit log exist.. it is true they do,
 but they are not exploitable.
 I would like to be able to repport at the end of the build a nice recap

 module section nb_of_test #sucess #skipped #failed
 for each failed
 spacetestname : FAILED (optionally one line reason)

 the minute point to
 workdir/CppunitTest/sal_rtl_math.test.log
 which contains:
 OK (3)

 but  writerperfect_writer.test.log fro instance
 contain 12027 lines.. most of it random trace messages, and I could
 not find any way to parse (at all, even less reliably) that thing to
 extract any useful information.

 maybe it is just a matter of using

 http://cppunit.sourceforge.net/doc/1.8.0/class_cpp_unit_1_1_xml_outputter.html
 and then adding a (optional) post processing step in the build to
 generate a nice summary



It is even easier. You can add another TestListener in
sal/cppunittester/cppunittester.cxx that logs all failures, and executed
tests. Of course as there is no support for non-fatal tests right now you
can't log them. It would at least give you an information how many tests
are executed. I think there is no post-processing necessary as you get all
the information the the xml outputter has already in the listener and
process is directly there.

Regards,
Markus


 Norbert

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] How should Calc's WEBSERVICE function work?

[Markus Mohrhard]

Hey,

On Sat, Dec 13, 2014 at 10:15 AM, Thomas Hackert thack...@nexgo.de wrote:

 Hello @ll,
 either I do not understand this function (which might be ... ;) ) or
 I found a bug in it ... :(

 When I
 1. start Calc
 2. then enter, for example, =WEBSERVICE
 
 http://api.openweathermap.org/data/2.5/forecast?q=Berlin,demode=xmlunits=metric
 
 in e.g. cell A1 (I have tried it with the German =WEBDIENST
 
 http://api.openweathermap.org/data/2.5/forecast?q=Berlin,demode=xmlunits=metric
 ).

 I get a cell with a lot of XML data in A1. Is this a feature or a
 bug? I had expected, that Calc would insert all the data in
 different cells, but without the XML code around ... :(


This is expected. It will just return the data that the url provides. There
is no calc function that will return data to multiple cells. Normally you
would further process that content with FILTERXML to get the data that you
need.



 BTW: Why are there that much M$ Excel functions flooding Pootle? It
 is really time consuming to find out, if they are patented, or
 protected by any other rights ... :(
 Have a nice day
 Thomas


Because they help interoperability and there is someone implementing them.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] How should Calc's WEBSERVICE function work?

[Markus Mohrhard]

Hey,

On Sat, Dec 13, 2014 at 4:14 PM, Thomas Hackert thack...@nexgo.de wrote:

 Hello Markus, *,
 On Saterday, 13. December 2014 11:00 Markus Mohrhard wrote:
  On Sat, Dec 13, 2014 at 10:15 AM, Thomas Hackert
  thack...@nexgo.de wrote:
  either I do not understand this function (which might be ... ;) )
  or I found a bug in it ... :(
 
  When I
  1. start Calc
  2. then enter, for example, =WEBSERVICE
  
 

 http://api.openweathermap.org/data/2.5/forecast?q=Berlin,demode=xmlunits=metric
  
  in e.g. cell A1 (I have tried it with the German =WEBDIENST
  
 

 http://api.openweathermap.org/data/2.5/forecast?q=Berlin,demode=xmlunits=metric
  ).
 
  I get a cell with a lot of XML data in A1. Is this a feature or a
  bug? I had expected, that Calc would insert all the data in
  different cells, but without the XML code around ... :(
 
  This is expected.

 ah, O.K.

  It will just return the data that the url
  provides. There is no calc function that will return data to
  multiple cells. Normally you would further process that content
  with FILTERXML to get the data that you need.

 Will this FILTERXML function be implemented as well?


They were implemented together about a year and a half ago.


  BTW: Why are there that much M$ Excel functions flooding Pootle?
  It is really time consuming to find out, if they are patented, or
  protected by any other rights ... :(
 
  Because they help interoperability and there is someone
  implementing them.

 But are we allowed to use them in LO (and for me as a translator:
 Are we allowed to translate them)? Would this not lead to any
 copyright infringement and therefore lawsuits in the US / EU against
 us?
 Thanks for your answer
 Thomas.

 --
 NP: Mirrors of Obsidian – Slaves to Numbers

 ___
 List Name: Libreoffice-qa mailing list
 Mail address: Libreoffice-qa@lists.freedesktop.org
 Change settings:
 http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
 Problems?
 http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
 Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
 List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] question about a bug confirmation

[Markus Mohrhard]

Hey,

On Sun, Nov 23, 2014 at 4:51 PM, Lera Goncharuk
lera.goncha...@gmail.com wrote:
 Hi all,

 Basically. I translate documentation and news to Russian, but also I explain
 the position of developers and QA team about confirmation and fixing bugs to
 Russian users who have a weak command of the English.
 My question is about a bug that I submitted yesterday (have a look at
 comments):
 https://bugs.freedesktop.org/show_bug.cgi?id=86576
 I do not complain or protest, but I need the position of QA team that I can
 explain to other users.
 Do I understand correctly, that we should consult with developers when a bug
 violates principles of mathematical calculations and we give the status NEW
 only when developers confirm than bug can be fixed?
 Do mathematical rules no longer apply to LibreOffice?
 What should I tell users?
 Thanks in advance for the clarification.


First a spreadsheet is not a math program and is not mathematically
correct and most likely will never be.

Now to the issue at hand. A number format is not a unit, it is a cell
property that tells the program how to format the numbers. In the end
they are still just numbers and have no internal unit. There are some
ideas around implementing a real unit system for spreadsheet cells in
calc but that is not even under development. That would then realize
that adding a currency to a time is just wrong. As you can try
yourself you can easily do that today as it is just a formatting and
not a unit.

Currently the seen behavior is correct that the number format (if none
is set yet to the cell) is taken from the source cells.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-qa] new git bugzilla script

[Markus Mohrhard]

Hey,

so I finally implemented a new git bugzilla script that should bring
back the commit notifications in bugzilla for fixed bugs.

As it is a complete new implementation you should report any problems
as soon as possible. Especially in the beta and the RC phase. I used
the old script as a guideline but there are some special portions in
it that can only be tested between the first beta and the last RC.

Otherwise the script provides nearly the same features as the old
script plus it will now handle several bug references in the commit
line correctly. So now fdo#12345 fdo#23456 will be handled correctly
and both bugs will be updated.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] unit tests-functions

[Markus Mohrhard]

Hey,

On Thu, Oct 23, 2014 at 1:26 PM, zdenek r...@post.cz wrote:
 Hello,
 I supplemented tests of functions  - sheets Logical and Spreadsheet
 (file from 1 and 2 ). Should be all functions in the categories Logical
 and Spreadsheet.
 Please take a look if it's good, if yes I'll continue with other
 sheets/function categories.



It looks really good. Which name should I use for your commit?

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] 4.4.x master build with symbols for Windows. where?

[Markus Mohrhard]

Hey,


On Sat, Jun 7, 2014 at 10:01 AM, Tommy ba...@quipo.it wrote:

 I'd like to try debugging and obtaining a trace.
 I was told that I need a build with symbols.

 where can I find one 4.4.x master build for Windows?

 I took a look at this link: http://dev-builds.libreoffice.
 org/daily/master/Win-x86@39/symbols/
 but it looks confusing to me what should I download.



That are just the symbols. They will be downloaded by windbg or
VisualStudio.

Just use the build in the current directory and follow the instructions at
https://wiki.documentfoundation.org/How_to_get_a_backtrace_with_WinDbg
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] What should Calc Chart GL3D do?

[Markus Mohrhard]

Hey,


On Sat, May 24, 2014 at 4:57 PM, Thomas Hackert thack...@nexgo.de wrote:

 Hello @ll,
 while I was trying to translate LO's UI to German, I stumbled upon
 the new Chart type GL3D Bar. To translate it correctly, I created
 a new Calc spreadsheet, inserted different values (date, time,
 temperatures, or even just a couple of numbers), but I only get a
 white frame without any chart, text, title etc. ... :( Is this a bug
 or feature (or am I just too dump to understand it) ;?

 Steps to reproduce:
 1. Start Calc
 2. Insert Value 1, 1, 3, 5 in the first column
 3. Insert Value 2, 2, 4, 6 in the second column
 (you can even add a third column with Value 3, 3, 6, 9 or
 even different headers, type of data like date, time, temperature,
 etc. in it ... ;) )
 4. Go to Insert – Object – Chart... and click on GL3D Bar below
 Choose a chart type

 It does not lead to any different observation, if you click through
 the Chart Wizard via Next button or if you click on Finish on
 my system ... :( I only get a white frame (object?) without any
 chart in it ... :(

 Would someone be so kind to try it on a different system? Or is here
 someone who can explain this chart or its functionality?

 LO: Version: 4.3.0.0.beta1 Build ID:
 2e39c7e59c8fc8b16a54c3d981dceef27fb0c07f
 OS: Debian Testing i686 (parallel installed, following the
 instructions from
 https://wiki.documentfoundation.org/Installing_in_parallel) with
 Germanophone lang- as well as helppack



This feature is not ready for general use and will be removed for the next
beta build. Please ignore it for now unless you want to crash Libreoffice
or your graphic card driver. Sorry that it was not in a release ready state
at the point of the feature freeze.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Calc Import Unit Tests - Time Date Functions

[Markus Mohrhard]

Hey,


On Sat, May 10, 2014 at 7:14 PM, Markus Mohrhard 
markus.mohrh...@googlemail.com wrote:

 Hey,


 On Fri, May 9, 2014 at 11:12 PM, Ken Biondi kenbio...@hotmail.com wrote:

 Hello,

 I sent this a couple weeks ago and haven't received a response.  Just
 want to make sure it didn't go unnoticed.


 Yes. Sorry seems to have fallen through my radar as I was on vacation at
 that time. I'll have a look at it as soon as possible.

 Sorry for the delay,
 Markus


Has been integrated now as
http://cgit.freedesktop.org/libreoffice/core/commit/?id=adb497a0d2261f3b1233ffd25c6cade996072567and
http://cgit.freedesktop.org/libreoffice/core/commit/?id=28c9d9898064af9269526064cdb90b6c3427c72a

Thanks a lot for the test and for your patience. One improvement that I
have discussed with Eike at the Libreoffice hackfest recently is adding
test cases for each function using as input: number, text, single
reference( e.g. B3 ), double reference ( e.g. C4:G5 ) and external
references. We had some nasty regressions in 4.2 that were only visible
with one of the cases so this might help us catch them in the future a bit
earlier. If you are interested it would be great to improve the tests for
the old functions and use this in future tests.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Calc Import Unit Tests - Time Date Functions

[Markus Mohrhard]

Hey,


On Fri, May 9, 2014 at 11:12 PM, Ken Biondi kenbio...@hotmail.com wrote:

 Hello,

 I sent this a couple weeks ago and haven't received a response.  Just want
 to make sure it didn't go unnoticed.


Yes. Sorry seems to have fallen through my radar as I was on vacation at
that time. I'll have a look at it as soon as possible.

Sorry for the delay,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] No thinderbox build for Windows master after 30-04-14

[Markus Mohrhard]

On Sat, May 3, 2014 at 4:44 PM, Markus Mohrhard 
markus.mohrh...@googlemail.com wrote:

 Hey


 On Sat, May 3, 2014 at 1:31 PM, Florian Reisinger 
 flo...@libreoffice.orgwrote:

 Hi,

 Title says it all
 http://dev-builds.libreoffice.org/daily/master/Win-x86@39/
 http://dev-builds.libreoffice.org/daily/master/win-x86@39/
 [Shouldn't this 2 be the same more or less??]
 http://dev-builds.libreoffice.org/daily/master/Win-x86@42/
 http://dev-builds.libreoffice.org/daily/master/Win-x86@47-TDF/

 CC ed owners. Could someone of you please fix it :)


 As you can see at http://tinderbox.libreoffice.org/MASTER/status.html the
 build is broken right now so you need to wait until someone manages to fix
 it. That might take some time especially during the weekend.



Should be fixed with
http://cgit.freedesktop.org/libreoffice/core/commit/?id=20778b037c688759a4dc46acb8aeb66c9d1290cc

My tinderbox finally manages to package msi files again so I hope that it
also helps the tinderboxes that upload dailies.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] [documentliberation-discuss] ODF compatibility tests

[Markus Mohrhard]

Hey,


On Fri, May 2, 2014 at 3:01 PM, Charles-H. Schulz 
charles.sch...@documentfoundation.org wrote:

 Jay,

 Replying in more details: there are a few ODF validators out there but
 they are neither autoritative nor maintained. And ODF 1,2 has evolved after
 they were released:
 http://plugfest.opendocsociety.org/doku.php?id=validators:overview

 Cheers,

 Charles.



Just to follow-up on this. Inside Libreoffice's automated tests we use
officeotron for OOXMl validation and odfvalidator for ODF validation.

There are not many automated tests that check the layout (limited to
Impress and charts) but quite a few that make sure that we don't loose
content during import or export. Normally we add them after fixing a bug to
prevent the same error in the future. Additionally we have a script that
imports all bugzilla documents and exports them to different formats and
runs a validation on the exported files to find export problems.

Except for these tests we have currently no tests that check either
validation or our filters. As some people already pointed out there is
neither a official set of test documents nor is the layout specified in
either ODF or OOXML.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Calc Import Unit Tests - Database Functions

[Markus Mohrhard]

Hey,


On Wed, Apr 2, 2014 at 12:13 AM, Ken Biondi kenbio...@hotmail.com wrote:

 Hello,

 Attached are tests for all calc database functions.



Patch has been pushed as
http://cgit.freedesktop.org/libreoffice/core/commit/?id=dce1a07be479468ac6b6d4cba619313e38edeb69

Thanks for your work.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Calc Import Unit Tests - Text Functions

[Markus Mohrhard]

Hey,


On Wed, Mar 26, 2014 at 11:20 PM, Markus Mohrhard 
markus.mohrh...@googlemail.com wrote:

 Hey Ken,


 On Wed, Mar 26, 2014 at 12:27 AM, Ken Biondi kenbio...@hotmail.comwrote:

 Hello,

 See the attached two files: functions.ods and text-functions.csv.

 I extended functions.ods with tests (normal parameter values only) for
 every text function except BAHTTEXT.

 text-functions.csv contains the expected results.  Both files created on
 WIN 8 machine.

 I license this content under MPL/LGPLv3+.


 Sorry that I missed this patch. I'm going to review it as soon as possible
 but it looks good already.

 Please add me in the future in CC so I'm less likely to miss such a mail.

 Thanks for your work,
 Markus



And has been pushed as
http://cgit.freedesktop.org/libreoffice/core/commit/?id=8ed4cc64302415defd1838c4a3799583e602b545

I had to remove some lines as they were either trying to access the
internet or not working. Sadly it seems that either our csv test import or
our csv export has some problems with some UTF-8 strings. Anyway it helps
quite a bit.

Thanks,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Calc Import Unit Tests - Text Functions

[Markus Mohrhard]

Hey Ken,


On Wed, Mar 26, 2014 at 12:27 AM, Ken Biondi kenbio...@hotmail.com wrote:

 Hello,

 See the attached two files: functions.ods and text-functions.csv.

 I extended functions.ods with tests (normal parameter values only) for
 every text function except BAHTTEXT.

 text-functions.csv contains the expected results.  Both files created on
 WIN 8 machine.

 I license this content under MPL/LGPLv3+.


Sorry that I missed this patch. I'm going to review it as soon as possible
but it looks good already.

Please add me in the future in CC so I'm less likely to miss such a mail.

Thanks for your work,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] minutes of ESC call ...

[Markus Mohrhard]

 * Certification update (Stephan/Bjoern)
 + ran the script; identified a new set of candidates
 + certification - does it depend on fixing issues in 2x components ?
 (Kohei)
 + no, but a competence and community connection test.
 + seven candidates agreed unanimously.
 AI: + mail candidates to ask their permission (Stephan)

 * Gran Canaria hack-fest (Bjoern)
 + April 24-25, 2014 (Thu-Fri)
 + add good topic ideas to the wiki page
 + cf. action items above.

 * OOXML export validation and ODF validation (Markus)
 + have support for export validation in our testing framework
 + tinderebox maintainer need to enable validation, at least on few
 boxes
 + Markus will write a mail - wrt. what is necessary to have in your
 path.
 + enabled in calc for ODF  OOXML now
 + enabled in chart2 for OOXML
 + also available in writer - but issues need tackling in the
 export tests
 + a chunk is around ordering of elements (Miklos)
 + these seem to cause no practical problems really.
 + in Excel element order is important (Markus)
 + elements are removed if in the wrong order.
 + hopefully this keeps validation errors under control.
 + Cloph enabled this on 2x TDF / Linux test-boxes, so they will fail
 now.
 + shell wrappers for java validators - can we have them
   inside the tinderbox script ? (Thorsten)
 AI: + check them in to save time (Markus)



Done now with
http://cgit.freedesktop.org/libreoffice/contrib/dev-tools/commit/?id=e94ee6b8c3f732194c72c0fdb796483a5ee39201

If you have a tinderbox and think that the additional minute more does not
hurt it would be nice to enable it.


Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Calc Import Unit Tests - Financial Functions

[Markus Mohrhard]

Hey,


On Thu, Feb 27, 2014 at 8:19 PM, Ken Biondi kenbio...@hotmail.com wrote:

 
  Date: Thu, 27 Feb 2014 17:00:20 +0100
 
  Sorry that I missed that mail. I'm going to review the patch and
  integrate it.
 
  Thanks for your work. Are you interested in continuing with more
 functions?
 
  Regards,
  Markus


 Hi Markus,

 Yes, I plan to continue with more functions.  I'll wait for your feedback
 to make sure I'm doing this correctly.

 Cheers,

 Ken


I finally managed to get to this patch. It has been integrated after some
struggles. I missed that the file contains windows line endings but after
fixing that it works now like a charm. Thanks a lot for your patch. I hope
to see more of them in the future.

Regards,
Markus

http://cgit.freedesktop.org/libreoffice/core/commit/?id=35f39285991043a70f65c796c38624c9c51ec4b1
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Calc Import Unit Tests - Financial Functions

[Markus Mohrhard]

Hey Ken,


On Sun, Feb 16, 2014 at 2:25 AM, Ken Biondi kenbio...@hotmail.com wrote:

 Hello,

 See the attached two files: functions.ods and financial-functions.csv.

 I extended functions.ods with tests (normal values only) for every
 financial function except OPT_BARRIER and ODDFYIELD.  I don't fully
 understand OPT_BARRIER, so I will write a test for it after further study.
  ODDFYIELD has a bug inherited from AOO Bugzilla #92177.

 financial-functions.csv contains the expected results.

 I welcome any feedback - positive or constructive criticism.

 I license this content under MPL/LGPLv3+.



Sorry that I missed that mail. I'm going to review the patch and integrate
it.

Thanks for your work. Are you interested in continuing with more functions?

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] (BLOCKER) Bug-74825: Windows (x64): LibreOffice could not able to start as LCMS2.DLL is missing.

[Markus Mohrhard]

Hey,


On Tue, Feb 11, 2014 at 2:56 PM, Adam Fyne adam.f...@cloudon.com wrote:

 I am encountering the same problem on my Windows 8.1 machine.
 After installing master from TinderBox#42 from today (11.02.2014) - cannot
 run it with same error.


 On Tue, Feb 11, 2014 at 9:24 AM, Dushyant Bhalgami 
 dushyant.bhalg...@synerzip.com wrote:

 Hello

 Logged one BLOCKER bug https://bugs.freedesktop.org/show_bug.cgi?id=74825

 After installing the latest master build from TinderBox#42 on Windows
 7(x64), LibreOffice stopped launching.
 While trying to launch the LibreOffice, receiving popup message that The
 program can't start because LCMS2.DLL is missing from your computer. Try
 reinstalling the program to fix this problem





Just as a suggestion for the future. Such problems don't belong into
bugzilla and should be reported instead on the developer mailing list.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Minutes of ESC call 2014-01-09

[Markus Mohrhard]

 Jan Holesovsky-4 wrote
 
  * Crashtest update (Markus)
  + new crash-test / data:
  + cf. http://dev-builds.libreoffice.org/crashtest/
  +
 
 http://dev-builds.libreoffice.org/crashtest/2bb1a845a25ca9a39c96f37995453844461aed4e/
  + import crashes pretty good now
  + export still not too good
  + validation errors still high unfortunately

 How one can help with these? I have checked some bugs and their status is
 FIXED or an exported attachment is irrelevant to the bug itself. Should
 those crashers be marked somehow, bugs reopened or cloned into new reports,
 BTs added?


You can help by fixing the crashes or validation errors. Additionally there
are a number of scripting tasks to make the information a bit pretty.

IMHO it makes no sense to treat them as normal bugs or check the bug
reports. The bug numbers in there are just part of the name of the file. It
does not mean that they have any relations to the bug report. From my point
of view the crash testing is more a developer tool that we use similar to
unit tests to improve quality. From a QA perspective I think you can just
enjoy the numbers and the improved quality.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] [SOLVED] Re: .odt to .pdf -- file extension question

[Markus Mohrhard]

Hey,


On Tue, Jan 14, 2014 at 12:34 AM, Pedro pedl...@gmail.com wrote:

 Hi Markus


 Markus Mohrhard wrote
  No. I think we agreed to use od[stpg].pdf as extension during the export
  of
  hybrid pdf compared to pdf for normal pdf export. It just depends on
  whether you embed an odf document into the pdf or not.

 If you did that, then it's not working under Windows...
 Deliberately saving as an hybrid pdf does not create a file with a double
 extension.


If it was changed it was surely not me but I remember some discussion about
it either on the dev ML or in the ESC. See for example
https://bugs.freedesktop.org/show_bug.cgi?id=39168



 IMO a double extension  is a not such a good idea, although technically it
 might seem like a nice indicator...


You are a bit late with this. The discussion happened a long time ago.


Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] [SOLVED] Re: .odt to .pdf -- file extension question

[Markus Mohrhard]

Hey,


On Mon, Jan 13, 2014 at 4:48 PM, Marc Paré m...@marcpare.com wrote:

 Le 2014-01-13 04:30, Marc Paré a écrit :

  Hi,

 I am just asking here as I am not sure if this is a bug or a decision
 made by QA.

 When I create a document and then choose the option to export to .pdf,
 the regular PDF window opens, and, all if fine, BUT, when you then go on
 to Export, the file name that shows automatically has the .odt
 extension tacked onto the end of the file. This then creates a file with
 the extension

 ?.odt original file is then saved as
 ?.odt.pdf

 Is this the intended behaviour that we want? Would it not be more
 appropriate to export the file and stip the original extension off the
 file? Like this:

 ?.odt original file should be saved as
 ?.pdf

 Cheers,

 Marc



 Sorry about that, I'm using the Linux .rpm v.4.2.0.2.

 After reading both Pedro's and Henri's responses, I wiped my LibreOffice
 folder in the .config and it now saves as it should.

 All works great now! There must have been something causing the problem
 from the changeover from the 4.1.x versions to the 4.2.0.2 version. It was
 also doing it on the 4.2.0.1 version when I installed it.

 Anyway, the quick fix does it.




I think I remember it is used for hyprid pdf documents.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] [SOLVED] Re: .odt to .pdf -- file extension question

[Markus Mohrhard]

On Mon, Jan 13, 2014 at 7:43 PM, Marc Paré m...@marcpare.com wrote:

 Hi Markus,

 Le 2014-01-13 13:19, Markus Mohrhard a écrit :

  I think I remember it is used for hyprid pdf documents.

 Regards,
 Markus


 Actually, you are talking about Opening a .pdf file which is another
 thing. My problem was with Exporting to .pdf and not opening.


No. I think we agreed to use od[stpg].pdf as extension during the export of
hybrid pdf compared to pdf for normal pdf export. It just depends on
whether you embed an odf document into the pdf or not.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] OpenCL?

[Markus Mohrhard]

2013/11/3 Pedro pedl...@gmail.com

 mariosv wrote
  I have read about it in the Kohei Yoshida's Webspace:

 Thank you for the link. It allowed me to figure out that the limitation is
 not so much which formulas/functions it applies to but which GPUs it
 detects...

 My netPC based on the ION chipset does support CUDA and OpenCL but is not
 detected by LO so it is still using the Internal, software interpreter

 I guess I'll have to wait some more time :)


That means it will not be supported in the future. There are some
requirements to the hardware that must be satisfied before we can use the
GPU as OpenCL device.



 On a separate note: it's a shame there isn't more communication between
 developers and QA...

 It would make sense to ping the QA list when some feature is added with
 some
 note like I added this and that in Master can someone check if it's
 working
 as intended and if there are any regressions?



This feature is still under heavy development and not yet ready for testing
by QA. As you might have noticed it is still disabled and might still
contain serious bugs. If you want to test something in master it makes more
sense to test the normal code paths in Calc by making sure that the large
Calc refactorings did not introduce regressions.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Need help in compiling and running Test cases in Libreoffice

[Markus Mohrhard]

2013/9/20 Stephan Bergmann sberg...@redhat.com

 On 09/10/2013 01:50 PM, Tushar wrote:

 I was trying to run some unit test cases in Libreoffice code to take an
 example
 core/sc/qa/extras/regression-**test.cxx in a following manner :

 /make -rf  CppunitTest_sc_chart_**regression_test.mk
 qa/extras/regression-test.cx http://regression-test.cx/x

 however it is giving _make: Nothing to be done for
 `qa/extras/regression-test.**cxx'._


 sc/CppunitTest_sc_chart_**regression_test.mk is special in that it is
 commented out in sc/Module_sc.mk since http://cgit.freedesktop.org/**
 libreoffice/core/commit/?id=**782c3ccb3bc608a24483a64ae6bbae**bcd917ce0dhttp://cgit.freedesktop.org/libreoffice/core/commit/?id=782c3ccb3bc608a24483a64ae6bbaebcd917ce0d
 disable chart test for now.  If it were not, the way to run that test
 would be make CppunitTest_sc_chart_**regression_test (optionally
 preceded by cd sc for faster turnaround).

 Moggi, is disabling that test still relevant?



Yes. This test shows that we have a serious problem in charts where they
are rendered differently on different platforms. We had up to 15% of size
differences in the different XShape objects between different machines.

Sadly I don't have enough time to look into it but consider this test a
viable part of improving chart when someone has time to fix the underlying
problems.

Tushar, any special reason why you picked just this tet?

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] About LibreOffice Chart born [LibO-4.1.0.3]

[Markus Mohrhard]

Hey,

well I think you expect too much here. All I implemented was the
possibility to export charts and later import them again. Providing a full
chart application is an orthogonal problem to the import and export feature.

If users expect a full application I have to hide this feature in the
developer builds. The main idea was that I can quickly debug chart
copypaste issues and allow users to exchange charts without a host
document.

Regards,
Markus
On Jul 19, 2013 2:58 AM, ape os...@yandex.ru wrote:

 Hi, all!

 Read these messages please:
 https://bugs.freedesktop.org/show_bug.cgi?id=66894 (LibO_Chart haven’t
 menu
 bar - blocker)
 https://bugs.freedesktop.org/show_bug.cgi?id=66896 (Recent_Documents -
 ODC).
 https://bugs.freedesktop.org/show_bug.cgi?id=66913 (LibO_Chart.exe isn’t
 created).
 https://bugs.freedesktop.org/show_bug.cgi?id=66899 (not register the
 ODC-files (chart) in the Windows registry)

 I understand that:
 1. Create a new application “LibO Chart” was unexpected news for
 programmers.
 2.“LibreOffice 4.1.0” has many improvements and should be born in a
 specified period.
 3. Impossible to eliminate mistakes in one week or one month.
 4. The program without the menu bar is nonsense and an excuse to ridicule.

 What to do? I hope that Chief Engineers of the project will say about the
 views.

 My suggestions:
 1. Reduce the error status to critical.
 2. In Release Notes to write that:
 •  the application “LibO Chart” is experimental;
 • TDF is working on UI of “LibO Chart”, but “TDF” gives the user the
 opportunity to work with an application right now for the early detection
 of
 critical bugs.

 Thanks, ape




 --
 View this message in context:
 http://nabble.documentfoundation.org/About-LibreOffice-Chart-born-LibO-4-1-0-3-tp4065734.html
 Sent from the QA mailing list archive at Nabble.com.
 ___
 List Name: Libreoffice-qa mailing list
 Mail address: Libreoffice-qa@lists.freedesktop.org
 Change settings:
 http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
 Problems?
 http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
 Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
 List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] URGENT Cherry pick regressions to next release

[Markus Mohrhard]

 Markus Mohrhard wrote
 * Does the fix contain a new feature?
 * How important is the bug fix?
 * Is the fix safe enough for a stable branch?
 * How much did the code change between the two versions?

 Points 1 and 2: if it's a regression it's not new and it's EXTREMELY
 important not to have regressions (regardless of importance of the feature)

No. Just because it is a regression does not mean that it is that
important that we will included it without a careful risk analysis.

 Point 3: that is why it needs to be checked by 3 devs

In the first place it is the task of the author/commiter to decide if
it is safe enough in his opinion. If he does not feel comfortable with
a patch in a stable branch there will not be a review by 3 other
developers. The author/commiter is normally the person knowing the
code best.

 Point 4: that should not be relevant. If the regression is already fixed in
 master, then it should not be that difficult to backport it to the current
 branch (unless it's a major version change)

We have about 70 to 100 commits per day and you would be surprised how
different master and 4-1 are already in quite a few places. I already
had the nice experience for this release that my fix from master did
not work any more in 4-1 because the whole Calc logic changed in the
few weeks since the rebase.

In the end every change, even a simple bug fix, has the risk of
introducing another regression so there will never be an automatic
process for pushing fixes to a stable branch. Every commit has to be
checked against these points to decide whether it is worth the risk to
include the fix into the stable branch and after that and totally
independent from it is the actual review by other developers of the
code.


 Markus Mohrhard wrote
 This should never be an automatic process, instead each commit needs this
 check by
 a developer.

 I agree completely. I never mentioned automatic. But it should be included
 in the list of checks before a new release to make sure that ALL MAB
 regressions that *were* fixed should be cherry picked to the nearest
 release. I believe that is the reason there are 2 Release Candidates before
 the final release...


For me automatic in this context means that a bug fix has to be pushed
after review despite concerns of the author/commiter. Fixing bugs
comes with risk management and that means to compare the benefit of
fixing a bug and the risk of introducing another regression. For every
bug this depends very much on how serious the bug is and how complex
the bug fix is. Additionally bug fixes that require translatable
string changes or implementing a new feature have stricter rules and
have an even more complex review process.

And saying that a bug deserves special treatment because it is on a
special list is quite dangerous. The MAB list should only be used to
notify developers about serious bugs but should not influence the risk
analysis. Surely if the bug is on the MAB it is important but that is
just one aspect of the risk analysis. This still means that all the
other aspects have to be checked before the bug can be pushed to a
stable branch. I think that we are doing a quite good job at reviewing
bug fixes for stable branches but some commits are just too risky or
too complex for this.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] minutes of ESC call ...

[Markus Mohrhard]

 + publish results of automated load testing (Markus)
 + test still running, ~80% done, layout regression found,
 + fixed a layout regression in master recently (Kendy)
 + a very recent build (Markus)
 + a build from yesterday morning may have issues
 + work on fixing automated load test issues
 (Kendy,Fridrich,Eike)


The item is done and the list has been sent to the dev ML. I'll check if
the infinite loop in the writer layout code is fixed by Kendy's commit. The
current list has been generated with a workaround in the python script for
this issue.
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] GUI automation

[Markus Mohrhard]

Hey Vladimir,

2013/3/13 Michael Meeks michael.me...@suse.com:
 Hi Vladimir,

 First - great to see you here :-)

 On Wed, 2013-03-13 at 16:17 +0100, Vladimir Benes wrote:
 we were discussing recently how to improve testing of LO's GUI. We found
 out that situation if more than bad.

So I agree here with you but sadly I currently have no good idea how
to improve that. One idea I had a bit more than one year ago was to
use the uno commands for menu entries and an annotaion in the src
files for ui elements but I discarded it for several reasons. However
with the ui files it might finally be easily possible to follow this
idea with the ui files.

But please explore all of the concepts that you can think of. Our
codebase is so complex that some may work and others will reveal
either problems in our code or in the test concept. I'm happy to help
with any problems you have in implementing new test concepts.


 There are several options how to approach this. The first is LDTP [1]
 and the other one (in my opinion far better) is Dogtail [2]. If LO uses
 standard gtk widgets so they're a11y friendly we can easily access them.
 This works for accessing menu items, dialogs and so on.

 We used to have a huge chunk of code that did this GUI testing. The
 general consensus is/was that it is unreliable, and broadly worthless -
 breaking on minor UI changes, requiring lots of maintenance, incredibly
 slow to run, etc. We removed it all :-)

I agree with Michael that the old GUI testing code was horrible and
unreliable and my big fear is that our horrible accessibility code
will not make it easier to use existing GUI testing frameworks but I'm
happy if someone prooves me wrong. I have no idea how IA2 and the new
widget dialogs play into that. Michael and Caolan may know better
which consequences they have on our accesibility code.


 For comparing visual things like pictures, font alignment, etc there is
 Sikuli [3] framework actively developed at MIT that can be used for this.

 IMHO it would be far more useful to develop unit tests that are run
 during the build; and/or to write load/save/load tests such that we
 check that our filters are not loosing data left/right as they load and
 save :-) We have a lot of such tests already, we also have some layout
 test code that dumps the layout tree in writer to try to check that the
 output is the same, and more pieces in that vein.

 Is there anything where we can start or at least help with? What I would
 expect is at least some priority one functionality that should be
 covered first or so.

So a few things on my list of untested functionality that is not
related to GUI testing and has higher priority on my list:

* Copy  paste
* Draw is totally untested
* Improved export tests: optional validation of the exported files (ODF/OOXML)
* Porting the failing API tests to C++ and re-enable them
* Exploring and integrating test documents from different providers:
gnumeric, abiword, calligra, OpenOffice
* Performance tests


 Caolan prolly has some more good ideas around what is needed here; and
 we could use more man-power and build-hardware of course. Markus is an
 expert in the unit testing area (and elsewhere) and has a rather nice
 tool to run a ton of bug-documents through the code: it'd be great to
 get that hosted, running regularly, and the bugs filed / fixed alongside
 the tinderboxes.

That is mostly blocked on my side. There are a few nasty memory bugs
also in my local build that either show another memory corruption in
our code/toolchain or an error in my concept. I hope to find some free
time soon to look into these reports.


 Then of course, there is running that same (15k document) test suite
 regularly under valgrind - that would also be useful ;-)

 So - IIWY I'd do GUI testing as the very last thing in the stack of
 other more useful things that can be invested in to improve quality.


I'm a bit more enthusiastic about the idea of GUI testing but there
must be someone who explores the different ideas and implements a
prototype. It took us around half a year until the propotype for
import tests was copied by other developers and found widespread use
in Libreoffice. So in my opinion the first step is to explore all of
the ideas and implement a reliably working prototype that can be used
to promote the idea.

I know that it takes time to implement and promote a new testing idea
and I hope that GUI testing will help to have a testing concept for
more of our fixed bugs.

So if you want to spend a bit of your time on exploring the different
concepts you mentioned you have my support and I'll try to help
wherever I can.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? 

Re: [Libreoffice-qa] minutes of ESC call ...

[Markus Mohrhard]

 * Hard Hacks:
 + http://wiki.documentfoundation.org/HardHacks
 + pending updates tomorrow.
 + plan to have 2 writer, 1 spread, 1 draw/impress etc.
 fdo#61025 - Crash when adding a comment on a cell (Markus)

Fixed in master now. I reverted the commit introducing the regression
for as I need some time inspecting what is going on there.
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Accepting can't open-bugs even if original program fails?

[Markus Mohrhard]

Hey,

2013/3/3 Joren joren.libreoff...@telenet.be:
 Hi,

 I saw following bug passing by:  FILEOPEN: Opening a large (19MB) XLSX file
 very slow  https://bugs.freedesktop.org/show_bug.cgi?id=61721

 It is reproducible. Opening that (huge) document takes a lot of time (after
 5 minutes it didn't open yet on my MacOSX 10.8.2 both LibreOffice 4.0.1.2
 and master). Opening the same file using Excel (for mac) result in same
 behavior (also force quit it after 5 minutes).

 Should I mark this bug as NEW, because I can reproduce that very slow
 behavior? Or close it because it also can't open correctly using the
 (probably) original office suite that is used to create this file?


Please mark at least the calc ones as NEW and put perf in the
whiteboard line. We are always interested in documents showing
performance problems as we need them to actually improve our
performance.

And a general remark in this direction for Calc: If you see somebody
complaining about Calc's import or export performance please ask them
to open a bug report with perf in the whiteboard line and an attached
test document. We are very interested in real world documents showing
performance problems.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Calc quality and compatibility tests

[Markus Mohrhard]

 Michael Meeks-2 wrote
 In addition there are even some Perl scripts to automagically test if the
 builds pass the tests...

   We could easily do that headless during the build in LibreOffice if
 someone was interested.

 I assume people in the QA team would be interested?

We are already such tests in the build. See the sc/qa/unit directory
for all sorts of tests that we are excecuting during a build. We are
already executing import, export and further tests.



 Michael Meeks-2 wrote
   Not sure; as I say there are a lot of corner-cases in that document
 collection that we don't pass - some of those need major structural
 change in calc (eg. the boolean type) to make them work.

 I'm not sure I follow your logic here. There are major structural changes
 needed so it's best not to touch it? Is it like a wasp's nest?

It means that it is not as easy as you imagine it. All these large
refactoring normally feel for a Calc developer like a open heart
transplanation so we are very conservative in major changes there.



 Michael Meeks-2 wrote
   As an example of a pair of those. If we have other (small) torture-test
 documents to exercise one particular feature - implicit intersections
 say; it'd be great to have help extending that. Are you interested ? :-)
 no doubt Markus would have some good advice as to exactly what would
 help improve coverage most.

 I'm puzzled! How come =sum(2,2) equals 5???

 I am available to help. But first shouldn't we try to understand why these
 files work correctly in Excel and Gnumeric but not in Calc? Isn't it a
 LibreOffice goal to be 100% compatible with Excel files (at least on first
 import...)?


No. The target is to be OpenFormula compatible and then as second step
check how to be as good in opening Excel files as possible. Our native
format is ODF with OpenFormula so this is our main target and we
should make always sure to support it as good as possible. Then our
next goal is to support Excel roundtrips which is not always trivial
as not all concepts between the two can be mapped and our calc formula
model is built around ODF. We are working on improving the support for
both Excel and OpenFormula but these are long term goals.

So if you want to help out the best thing right now is to go through
these files and use the working corner cases in them to create test
files that we can use in our existing tests. Additionally filing bug
reports for every case where you see an error would help (maybe also
tracking them with a master bug). That helps to make sure that
whatever we do in the future non of the working corner cases becomes
broken. If you are interested in this task or know people who are
willing to help out with it I once wrote a wiki page for non-coders
how they can add test cases:
https://wiki.documentfoundation.org/Development/Calc_Import_Unit_Tests

There is an additional set of test documents from the OOo Calc team at
http://www.openoffice.org/sc/testdocs/ that can also be used and
transformed into test cases for our automatic tests.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] libre o. 4.0.0.3 - inaccurate pdf export

[Markus Mohrhard]

Hey Michael,

2013/2/11 Michael Fuchs f...@gmx.at:
 hi!

 i am not sure where i can report bugs. therefore i hope this mail is sent to
 the right person :)


I'm sorry that you did not get a response sooner and that you found a
bug in 4.0.0

Sadly this list is not the right place to report bugs. Please file a
proper bug report at https://www.libreoffice.org/get-help/bug/ which
will guide you through the steps needed to make a good bug report. The
QA-team will then process this bug report and maybe ask for additional
details from you.

In the mean time you might help them a bit and try to reproduce some
of the unconfirmed bug reports. If you have more questions how you can
help with QA for Libreoffice feel free to write another mail.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] [ANN] LibreOffice 4.0.0.1 RC1 available

[Markus Mohrhard]

Hi Pedro,


 BTW I think my profile data was not imported from 3.x (need to retest this)
 I already had reported this for the Alpha builds
 https://bugs.freedesktop.org/show_bug.cgi?id=57061

 Here is how you can replicate a crash (under Win XP at least):
 1) Delete the %appdata%\LOdev\4  folder (to simulate a fresh start of Win
 4.0 RC1 after install)
 2) Launch LibreOffice
 3) Press on the Spreadsheet button to create a new one (or open any
 spreadsheet)
 4) Go to Options, LibreOffice, Personalization and paste the link to a
 Persona (e.g. http://www.getpersonas.com/en-US/persona/491434)
 5) Press OK and then OK again.

 This should result in a crash and recovery process.


Can you please try tomorrow in a 4.0 daily build or in a master daily
build from today. I fixed a few of these crashes during the weekend in
calc and basic. There might be more of them but for me it worked after
my fixes without any problems.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-qa] Volunteer for QA talk at FOSDEM needed

[Markus Mohrhard]

Hey guys,

the QA talk at FOSDEm still needs a volunteer. It would be great if
one of you would be able to give this presentation. It will be on
Sunday morning in the Libreoffice dev-room.

Please consult https://wiki.documentfoundation.org/Marketing/Events/Fosdem2013
for more information. The talk is also listed there without a speaker
for now and we have to add the schedule to the FOSDEM system soon. It
is one of the coolest conference to present other people the great
work the QA team is doing and how much fun it is to participate.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] New Version Number PAttern

[Markus Mohrhard]

Hey guys,

2012/7/10 Petr Mladek pmla...@suse.cz:
 Rainer Bielefeld píše v Út 10. 07. 2012 v 13:26 +0200:
 Hi,

 I just in Bug 51899 UI PRESENTATION: Tooltips for Master Pages show
 wrong Name
   https://bugs.freedesktop.org/show_bug.cgi?id=51899
 Saw a target Version info what IMHO is not in accordance with
 https://wiki.documentfoundation.org/BugReport_Details#New_Versions_2012-06-20:
 target:3.6.0.0.rc1

 I think correct Version number would be 3.6.0.1 (or picker info 3.6.0.1
 rc, but those Additional Picker Info separated from the Version Number
 itself by a space should not be used in target, because the last rc
 will become the release)

 Is there any information I missed? If not, Markus should pleas adapt the
 script.

 Rainer is right. We should use 3.6.0.1 instead of 3.6.0.0.rc1
 because we can't mention rc in the final release. I am pretty sure
 that 3.6.0.1 will not be the last release candidate but...


The script is correct and sets 3.6.0.1 as target version right now.
This one is set by Andras and not by the git bugzilla script.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Cobra - WinLDTP Automation

[Markus Mohrhard]

 i wonder what AOO uses for UI testing; perhaps IBM has some internal
 thing for that.

 I have found the following resources:
 https://cwiki.apache.org/OOOUSERS/release-qa-plan.html
 http://wiki.services.openoffice.org/wiki/Quality_Assurance
 http://www.mail-archive.com/ooo-dev@incubator.apache.org/msg20994.html


The last thing I heard about it is that they are now using it already.
I did not yet have time to look into it and sadly it is another java
based test framework. I plan to have at least a look at it after the
3-6 release.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] minutes of the libreoffice qa call 2012-06-14

[Markus Mohrhard]

 AI:  - adapt script to new version theme (Markus)

done. The manual solution that is currently implemented is now
adjusted to the new version scheme.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] [EDITING] LibreO version 3.6.0alpha1 (Build ID: 66f01b5) Crash when copying a range with contional format.

[Markus Mohrhard]

Hey,

2012/6/4 MiguelAngel mari...@miguelangel.mobi:
 LibO-Dev_3.6.0alpha1_Win_x86_install_multi
 version 3.6.0alpha1 (Build ID: 66f01b5)
 Wintx64 Ultimate
 Clean profile.

 Hi,

 Can someone verify this regression before report the bug?.

 Open a new spreadsheet.

 1. Enter a conditional formatting in range B2, value: 1, select style:
 Result.
 2. Enter any value in B2
 2. Ctrl-c
 3. Select any cell, B2 included.
 4. Ctrl-v
 5. Crash.

 Not reproducible in LibreO 3.5.4rc2

 Maybe in relation with the work in progress over several bugs about
 conditional formatting.


It is related and most likely already fixed in my local commits that
will be pushed soon. Just to be sure open a bug report and assign it
to me.

Thanks for testing the alpha version.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] bugzilla git hook doesn't always work (Re: PM: [Bug 49342] CRASH EDITING TABLE when merge cells in .sxw and others)

[Markus Mohrhard]

Hey Rainer,

2012/5/16 Rainer Bielefeld libreoff...@bielefeldundbuss.de:
 Michael Stahl schrieb:


 yes it happens sometimes that the server side git hook that
 automatically adds these target statuses doesn't work for whatever reason.


 Hi Markus,

 can you help?

 it seems the missing target addition problem just appeared in
 https://bugs.freedesktop.org/show_bug.cgi?id=46074


Can you explain what you think is missing there? I see no problems
there but that might also because I expect something different from
the git-bugzilla script.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Visual representation of calc borders slightly changed

[Markus Mohrhard]

Hey,

 I just tested LOdev 3.5.3rc0+  (Build ID:
 90872c9-a73d29c-6845e52-f269e46-186d9ed or
 http://dev-builds.libreoffice.org/daily/Win-x86@15-Prague_Win32/libreoffice-3-5/2012-04-13_13.20.58/)
 and couldn't notice any change.

 On a positive note, I opened an ods produced with LOdev 3.5.3rc0+ with 3
 different line types on previous versions of LO (3.5.1, 3.5.0, 3.4.5 and
 3.3.4 under Windows XP Pro x86 SP3) and they looked exactly the same.

 The Preview in Web Browser option produces unexpected lines in the center
 part (different from the outer border which shows the selected line)


As mentioned in my initial mail this will not make it into 3.5 and is
only in master builds.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Visual representation of calc borders slightly changed

[Markus Mohrhard]

Hey,

2012/4/4 Markus Mohrhard markus.mohrh...@googlemail.com:
 Hey,

 I just pushed a fix for fdo#33634 to master. This patch changes the
 visual representation of borders significantly and I ask therefore for
 testing and a ux look. We now display the borders based on the actual
 width information and don't cast them to uInt16 which looses nearly
 all precision. It would be nice if we could get some people checking
 that their favorite area is not affected by this change. I had a look
 at the use of svx::frame::Style and it seems that one part of writer
 suffered from the same problem and should benefit from this fix too.

 Please have a special look at visual appearance, export to pdf,
 printing, print preview and all areas that you know which use borders.

 Comments and testing appreciated.


Now also attached two pictures showing before and after my change. I
hope that this makes it easier for all having no master build.
attachment: border_new.pngattachment: border_old.png___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-qa] Visual representation of calc borders slightly changed

[Markus Mohrhard]

Hey,

I just pushed a fix for fdo#33634 to master. This patch changes the
visual representation of borders significantly and I ask therefore for
testing and a ux look. We now display the borders based on the actual
width information and don't cast them to uInt16 which looses nearly
all precision. It would be nice if we could get some people checking
that their favorite area is not affected by this change. I had a look
at the use of svx::frame::Style and it seems that one part of writer
suffered from the same problem and should benefit from this fix too.

Please have a special look at visual appearance, export to pdf,
printing, print preview and all areas that you know which use borders.

Comments and testing appreciated.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] new automated test concept for chart2

[Markus Mohrhard]

Hey Cor,

 Writing to the Dutch Discuss list for people that do some things with
 charts...
 From the text below,is it correct that I can tell them to just make some
 simple example files, which preferably clearly shows one issue, and add them
 to the issue ?


Yes, but I would prefer test documents that focus on one single
feature and include one or more charts that focus on one single
feature. I don't think that it is useful to include a big set of
similar test document because this test is already a bit slower.

So if we get some nicely written test documents that would be awesome.

 Markus Mohrhard wrote (28-03-12 05:30)

 All you need to
 create a new test case is a bit of time.
 For everyone interested in writing and extending chart tests please
 have a look at: https://bugs.freedesktop.org/show_bug.cgi?id=47667

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-qa] new automated test concept for chart2

[Markus Mohrhard]

Hey,

finally I was able to finish my work on a chart2 test concept. I have
implemented an idea that renders the chart and then dumps the layout
data into an xml based on the information stored in the
XShape/XShapes. This allows us to easily add new test cases without
having to know anything about programming or chart2. All you need to
create a new test case is a bit of time.
For everyone interested in writing and extending chart tests please
have a look at: https://bugs.freedesktop.org/show_bug.cgi?id=47667

So here some more technical details for all who are interested in it:

The dumper code is in chart2/source/view/main/ChartView.cxx and takes
the drawing::XDrawPage and dumps the containing XShape/XShapes into
xml. The dumper can be easily extended and it would be nice if
everyone fixing a bug in chart2 could have a look at it and check if
this bug could have been prevented if the dumper would included some
more information.
BY enabling the debug output of the dumper you will get a list of
supported service names in the dump and can just add a method for this
service or for one interface of this service.

It might be that the same code is valuable for Draw/Impress too and we
can then think about extracting the dumper and moving it into test.


The test is not yet activated but is working already. So if you want
to play a bit with it just add it into Module_sc.mk. Feedback as
always highly appreciated. If there are no objections I plan to
activate the test in sc's subsequentcheck target at the end of the
week.

Regards,
Markus

P.S. For calc devs I will add a hidden export filter that exports the
same content to make debugging chart bugs easier.
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Regressions in Open Source projects ...

[Markus Mohrhard]

Hey all,

I did not want to answer nut since you chose mainly my commits here is
a short reply.

 On Fri, Mar 16, 2012 at 07:21:15AM +0100, Rainer Bielefeld wrote:
 a) Regression Bug 47096 EDITING: Alt + Drag and Drop for complete
 rows impossible in particular documents frequently forces me to use
 3.4.5.

 I had a short look at this one as a exemplary post-mortem (the bug seems to be
 assumed fixed from the developer side). What we have here is a bug that was
 introduced on the release branch (as it wasnt in the beta), which is not good.
 But such things can and will happen, the question is how to handle them
 quickly. So what can we do better here?

 A casual (actually I have no idea about this code domain) digging through the
 history shows that this regression was likely introduced by:

  http://cgit.freedesktop.org/libreoffice/core/commit/?id=a00c5917a8deb465cc1322e14a81340f9d69

The correct commit is
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-0id=49a1737b7d3d61304e749c6c164165b8bf68790e

While is not good that this commit introduced a new regression it was
fixing several problems and I was testing copy/paste (the only know
bug problem area at this point) and did not find any problems.


 because that last touched related code areas (so this was neither adding nor
 removing a regression, but exchanging one for another). So how can we improve
 detecting such things on the release branch?

No it is not that easy. This commit fixed several crashes and problems
in the copy/paste code. We will from time to time get such regressions
since it is nearly impossible to find all affected code paths in our
highly coupled code. This has been introduced somewhere in one of the
betas and has not been marked as serious for a long time.


  git log libreoffice-3.5.0.2..libreoffice-3-5-1

 tells me that there have been 213 commits between 3.5.0 final and 3.5.1 
 final, which suggest a rather limited scope of areas touched. IMHO it would 
 make sense to focus manual testing for the touched areas of code. Doing a:

 for d in `find . -maxdepth 1 -mindepth 1 -type d`; do echo `git log 
 --pretty=oneline libreoffice-3.5.0.2..HEAD $d|wc -l` $d;done|sort -n|tail

 shows the following stats:

 5 ./svx (GUI)
 7 ./officecfg (configuration/settings)
 7 ./oox (docx filters etc.)
 7 ./writerfilter (Writer)
 9 ./solenv (build/installation)
 12 ./scp2 (installation)
 13 ./extensions (various)
 15 ./connectivity (Base)
 22 ./sc (Calc)
 39 ./sw (Writer)

 If we could coordinate those interested in a bit more systematic manual 
 testing
 to look at these areas for micro releases, to prevent fixed a regression,
 introduced a regression scenarios, that would be awesome. Since the number of
 changes in one specific area of code in rather limited, we then can:

 - pinpoint the change (and the developer) that causes the trouble quickly
 - reject fixes that cause another regression
 - consciously make a choice to include a fix that causes a minor regression,
  when it fixes a major one and there is no good alternative

 Divide and conquer is the way to go here. With the 22 commits in Calc for
 example this should be something one volunteer should be able to comfortably
 have an eye on over the ~one month period between both releases. Writer (most
 likely because of Michael Stahls regression fixing rampage) currently might
 need two people volunteering. And obviously, the number of commits will likely
 slow down now after 3.5.1.

IMHO the way to go is automated testing and adding a test case for
fixed bugs im possible. I fear that most of the time not even devs
know all affected features so how should a normal user or qa person
know what to test.


 So dear QA-list members:
  Anyone interested in picking this up for one application?
  Who would like to do it for Writer?
  Who for Calc?

 b) Regression Bug 45385 EDITING: Copy Paste formula to different
 document adds source document filename to references (what even
 isn't accepted as a bug, but will be a showstopper for me to use
 LibO if no solution will be found) frequently forces me to use
 3.4.5.

 So far this is not a bug, but intended behaviour. As that I wouldnt consider 
 it
 a regression or an indication of QA problems. It indicates something else
 though: we had a failure to communicate there, the intended change of 
 behaviour
 would have needed to be communicated clearly and before the actual change was
 made. This is something we need to improve upon, and we need to find a good 
 way
 to make this information accessable. This could be done on the dev ML, but
 given the noise on it a bug filed for this would be even better. I am open to
 other ways to improve communication there, if proposed.

The old behavior while making sense in some corner cases was build on
a broken design. Even the OOo Calc devs knew that and added a big
warning in the code and had the code ready to show a warning message
to the user that the copy/paste action with absolute 

Re: [Libreoffice-qa] [ANN] Referencing bugs in commits

[Markus Mohrhard]

Hey,

2012/2/17 Lionel Elie Mamane lio...@mamane.lu:
 On Tue, Feb 14, 2012 at 04:16:33PM +0100, Jan Holesovsky wrote:

 whenever you are committing / pushing to git, and you
 reference the bugs.freedesktop.org bug in the commit message, it will
 automatically appear as a comment in the bug :-)

 It seems not to happen this morning. In general, after how much time
 after commit should we get worried and report it?


This one was my mistake. It is quite difficult to test this scricpt so
that sometimes after a change or a new situation it does not update
the bug (please watch next week with pushing bugs to 3-5 and 3-5-1).
If you see a commit with a bug number announced by CIA bot and the
script did not update the bug drop Kendy and me a short note.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Issues with 3.5.0 - ready for release ...

[Markus Mohrhard]

2012/2/8 Caolán McNamara caol...@redhat.com:
 On Tue, 2012-02-07 at 22:05 +0100, Markus Mohrhard wrote:
 But keep in mind that this is nothing that will be fast. I needed
 around one week to check a bit more than 4000 files

 My times are dramatically faster than this for .doc files in writer at
 least. I can load 4000 .doc files *under valgrind* overnight in about 10
 hours. So apparently mileage varies quite a bit depending on hardware
 and file format and debugging level.


That only works if you have no crashs or looping documents. Especially
looping is a big problem in calc.

Then if we want to be fast using a debug/dbgutil build is the wrong
way but then we loose the advantages of gcc's safe iterators.

So I think 4000 known good documents can be easily tested in one day
or even faster with a decent machine but taking 4000 random
documents from bugzilla needs some manual interaction and therefore
will need more time.
As mentionend in the last mail, I think we could speed that up by
copying the test code and the makefile several times and run the test
in parallel. That way we could use more cores and would be more
reliable against crashs. ( we should of course not commit this stuff
then)

Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Issues with 3.5.0 - ready for release ...

[Markus Mohrhard]

Hey,

2012/2/7 Caolán McNamara caol...@redhat.com:
 On Tue, 2012-02-07 at 20:32 +0100, Dag Wieers wrote:
 Do we
 have tests doing automated QA (conversions) to test export filters and are
 we using fuzzing techniques to test our import filters ?

 I've personally been to-date more interested in automated import filter
 tests, typically various binary file formats. You can find the existing
 tests in e.g. sw/qa/core/filters-test.cxx where the minimal
 always-tested test-cases are in e.g. sw/qa/core/data/*/

 The idea of these is that you use something like
 bin/get-bugzilla-attachments-by-mimetype to slurp down a pile of extra
 documents and shove them into sw/qa/core/data/*/indeterminate and just
 run make in sw to see if any of them triggers a crash (or a valgrind
 warning when export VALGRIND=memcheck make is used).

 Same basic see if file format parser crashes idea implemented for
 other modules spread around the place, e.g. sc, sd, svtools and stuff
 like .xls, .ppt .wmf and so forth.

With some modifications this will also work for odt. Odt is just a
special case because our internal code distinguishs odt and all other
filters and will fail if we don't provide all necessary information
for odt ( see sc/qa/unit/filters-test.cxx for the needed adjustments
). The more difficult part is then to find all necessary component
files and add them otherwise around 80% of the complex documents will
crash. I can port the sc adjustments to sw but someone else would need
to add the component files.


 calc has extended things a bit further for some extra tests to ensure
 that selected test documents have the expected calculation results and
 Markus demoed at FOSDEM the in-progress stuff for sd to ensure that
 selected test documents render as expected.

We also used Caolan's great script and concept to test all ods, xls
and xlsx files from OOo, fdo and redhat bugzilla for crashs. Testing
these files can only search for crashs not that documents are imported
because only around 60 to 70% of them can be imported at all. A lot of
them are either totally broken or contain passwords. I added a bit of
code to sc's filters-tesst and planned to improve that code for the
next release but if you plan to use this concept for writer or impress
I can integrate the remaining points from todo list.

But keep in mind that this is nothing that will be fast. I needed
around one week to check a bit more than 4000 files. Anyway it would
be great if you could help out doing the same for writer. This would
mainly involve finding the component files and running the test, I
would port all my changes to sw if needed.

Regards,
Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Tinderbox status

[Markus Mohrhard]

2011/12/1 Pedro Lino pedl...@gmail.com:
 So if Tinderbox #9 finished successfully 2 days ago with 176 errors
 and today with 846(!!!), doesn't that sound suspicious?

 Yes, it does - but only if it is the same machine, the same builder.
 In your initial post you were comparing different builders, and there
 it is rather irrelevant.

 No I wasn't. I was providing two examples of the same problem. On the
 MinGW errors increased from 16 to 220 and on the MSVC from 176 to 375
 (846 was copied from the wrong column by mistake. My bad :) ).

 I don't see a previous successful entry for #9, so nothing to compare
 with right now, and I surely don't remember the error count from
 before the rename :-)

 It was my mistake. I mixed results, But you can see that for Win
 machine #6 the current error number is 375 and the previous successful
 build had 176
 http://tinderbox.libreoffice.org/cgi-bin/tinder.cgi?tree=MASTERstart-time=1322562647display-hours=50


It was a build system change that switched to a more verbose output.
Nothing to worry about.

As long as a build is marked as succesful you don't need to worry
about anything. There might still be problems with it but then
normally you can't see them at the tinderbox page and only test if
they start correctly.

Markus
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-qa] New way for non coders to help with calc unit tests

[Markus Mohrhard]

Hello guys,

I want to present you the new way you can write build-time unit tests for
calc.
*
How are the tests organized?*

The tests are located in sc/qa/unit and consists of filters-test.cxx and the
files in sc/qa/unit/data. In the data directory there is one directory per
supported file extensions (ods, xls, xlsx) and one directory contentCSV that
only contains csv files. Please don't touch the other directories, they are
for special tests) At the moment we have a for-named-ranges test, a database
ranges test , a formatting test and a standard content test file.
Additionally there is one file per directory for bugfix tests so that import
bugs that are fixed once will not reoccur.  If possible a new test case
should be added to each of the three directories so that we test as much as
possible for every filter.
*
What can we test?*

We can test the content of a calc document directly after loading it. It is
quite easy to test the content of cells, that means the formula in a cell,
the result as a value and the formatted result as a string. It is even
possible to test the result of cells that are part of conditional
formatting. It gets more complicated for other stuff since I don't have any
csv handler for that or it might need some code to test it.

We can't test any dynamic changes in calc documents with this test ( there
is ucalc for these cases). So for unit tests that try to emulate user input
and/or changes that go beyond what is done during loading, can't be tested
with this easy unit test.

*
How to write a new test?*

It's quite easy to write a new unit test.
 The first step is to create a document that should be tested or
add/extend an existing sheet in a document.
 The second step is to create for every sheet a csv file that contains
the expected result, formula or string that the test document should
contain.

*How can I get the existing files?*

Either you have the source code already than it is in sc/qa/unit or you can
get the files from:
http://cgit.freedesktop.org/libreoffice/core/plain/sc/qa/unit/data


I will create a wiki page for these information soon but feel free to ask me
anything or make suggestions. I try to announce changes around this on the
QA list.


It would be amazing if some of the calc users would write or extend the
existing tests. Even if you could provide just one or two test cases you
would help very much ensure that our next release will contain less bugs and
that calc becomes even more stable.
Here are somethings, for instance, that could be tested or
the test extended:
 - normal content
 - data pilot/pivot table
 - the functions document should be extended to all build-in functions (
testing special cases, normal behaviour, etc. )
 - advanced functions like sorted content, autofilter, subtotals,
scenarios, etc.
 - some of the import bugs fixed during the 3-4 release cycle

I'm sure I missed a lot of important things and that is your big chance! Did
you ever wanted to commit something to Libreoffice source code but you don't
know how to code ? You don't have the time to get familiar with the code ?
This is the perfect opportunity to get your first commit ;) You have a nasty
bug that you don't want to see again ? Write a test file, add a csv file
with the expected content and send it to the
libreoffice-qa@lists.freedesktop.org list.

I'm looking forward to all your great contributions that will help us to
release a nice next version.

Regards,
Markus


 P.S. Links to all ods documents that we have at the moment:

http://cgit.freedesktop.org/libreoffice/core/plain/sc/qa/unit/data/ods/bug-fixes.ods

http://cgit.freedesktop.org/libreoffice/core/plain/sc/qa/unit/data/ods/database.ods

http://cgit.freedesktop.org/libreoffice/core/plain/sc/qa/unit/data/ods/formats.ods

http://cgit.freedesktop.org/libreoffice/core/plain/sc/qa/unit/data/ods/functions.ods

http://cgit.freedesktop.org/libreoffice/core/plain/sc/qa/unit/data/ods/named-ranges-global.ods

http://cgit.freedesktop.org/libreoffice/core/plain/sc/qa/unit/data/ods/universal-content.ods
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/