[patch #9442] Add flang (LLVM-based compiler) support

[Brad Smith]

Follow-up Comment #2, patch#9442 (group libtool):

This should be checking for *flang* to also match for the current name of
flang-new, though hopefully for LLVM 18 that'll change to flang, but not yet.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

Re: [PATCH 12/12] libtool.m4: For reproducibility stop encoding hostname in libtool script

[Mike Frysinger]

On 25 Oct 2021 15:33, Richard Purdie wrote:
> For reproducibilty, stop encoding the hostname into the libtool script, this 
> isn't
> really adding much to debugging and most distros are carrying such a patch 
> now as
> reproducibility is important.

thanks, merged
-mike


signature.asc
Description: PGP signature

[patch #9442] Add flang (LLVM-based compiler) support

[Mike Frysinger]

Update of patch#9442 (group libtool):

  Status:None => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #1:

i dropped the -DPIC part as no other target does it, and i think we handle
that in common code already.  feel free to follow up if you disagree.

https://git.savannah.gnu.org/cgit/libtool.git/commit/?h=33d4b69fccbbb557c1160cc46c3d8d2f30fb8a2d


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

Re: [PATCH] Support for Flang and ARM HPC compiler

[Mike Frysinger]

weird timing.  this was submitted a week before you:
https://savannah.gnu.org/patch/?9442
-mike


signature.asc
Description: PGP signature

Re: Armflang patch

[Mike Frysinger]

i think this earlier patch is more complete:
https://savannah.gnu.org/patch/?9442
-mike


signature.asc
Description: PGP signature

Re: Patch to set correct compiler flags for 'armflang' on 'aarch64'

[Mike Frysinger]

i think this earlier patch is more complete:
https://savannah.gnu.org/patch/?9442
-mike


signature.asc
Description: PGP signature

Re: [PATCH 1/2] libtool: replace : with $PATH_SEPARATOR

[Mike Frysinger]

On 15 Oct 2023 02:04, KO Myung-Hun wrote:
> Some OSes such as OS/2, uses ';' as a path separator. So using
> $PATH_SEPARATOR instead of hard-coded ':' is more proper.
> 
> * build-aux-ltmain.in: replace : with $PATH_SEPARATOR.
> * m4/libtool.m4: Likewise.
> ---
>  build-aux/ltmain.in | 76 ++---
>  m4/libtool.m4   | 16 +-
>  2 files changed, 46 insertions(+), 46 deletions(-)

this seems reasonable, but the size of the patch seems like it should require
copyright papers.  have you done those for the libtool project before ?
-mike


signature.asc
Description: PGP signature

Re: pass_all for z/OS

[Mike Frysinger]

On 24 Nov 2023 15:19, Igor Todorovski wrote:
> diff --git a/libltdl/m4/libtool.m4 b/libltdl/m4/libtool.m4
> index d812584..f959bae 100644
> --- a/libltdl/m4/libtool.m4
> +++ b/libltdl/m4/libtool.m4

this file doesn't exist.  i don't know what git tree you're working against,
but it isn't the latest libtool one.  please rebase onto the latest version,
and send a proper git patch.  hand written ones like what you've posted here
are a pain to merge as it forces us to do a lot of manual work.
-mike


signature.asc
Description: PGP signature

Re: [PATCH] ltmain.in: Pass through -fdiagnostics-color, -frecord-gcc-switches

[Mike Frysinger]

On 14 Jan 2024 06:27, Sam James wrote:
> * -fdiagnostics-color: who doesn't like color? No reason to strip it. This
>   makes the link phase stick out like a sore thumb if there's warnings 
> emitted.

i have a vague recollection of libtool processing output, but i can't recall
where.  i guess if it breaks people, it's kind of their own fault, and we can
wait for reports.

> * -frecord-gcc-switches: we use it in Gentoo to check if a package respects
>   *FLAGS. Note that we do not need to include -grecord-gcc-switches explicitly
>   here as -g* is already whitelisted.

this is certainly np.

merged!
-mike


signature.asc
Description: PGP signature

[PATCH] ltmain.in: Pass through -fdiagnostics-color, -frecord-gcc-switches

[Sam James]

* -fdiagnostics-color: who doesn't like color? No reason to strip it. This
  makes the link phase stick out like a sore thumb if there's warnings emitted.

* -frecord-gcc-switches: we use it in Gentoo to check if a package respects
  *FLAGS. Note that we do not need to include -grecord-gcc-switches explicitly
  here as -g* is already whitelisted.
---
 build-aux/ltmain.in | 3 +++
 1 file changed, 3 insertions(+)

There's probably more of these that we need to do, I only onticed these two
by chance the other day.

diff --git a/build-aux/ltmain.in b/build-aux/ltmain.in
index fb49d6c8..d5157a8d 100644
--- a/build-aux/ltmain.in
+++ b/build-aux/ltmain.in
@@ -5406,6 +5406,8 @@ func_mode_link ()
   # -O*, -g*, -flto*, -fwhopr*, -fuse-linker-plugin GCC link-time 
optimization
   # -specs=* GCC specs files
   # -stdlib=*select c++ std lib with clang
+  # -fdiagnostics-color* simply affects output
+  # -frecord-gcc-switches used to verify flags were respected
   # -fsanitize=* Clang/GCC memory and address sanitizer
   # -fno-sanitize*   Clang/GCC memory and address sanitizer
   # -shared-libsan   Link with shared sanitizer runtimes (Clang)
@@ -5417,6 +5419,7 @@ func_mode_link ()
   
-t[45]*|-txscale*|-p|-pg|--coverage|-fprofile-*|-F*|@*|-tp=*|--sysroot=*| \
   
-O*|-g*|-flto*|-fwhopr*|-fuse-linker-plugin|-fstack-protector*|-stdlib=*| \
   -specs=*|-fsanitize=*|-fno-sanitize*|-shared-libsan|-static-libsan| \
+  -fdiagnostics-color*|-frecord-gcc-switches| \
   -fuse-ld=*|-Wa,*|-Werror|-Werror=*)
 func_quote_arg pretty "$arg"
arg=$func_quote_arg_result
-- 
2.43.0

Re: [PATCH] Makefile.am: make sure autoheader run before automake

[Mike Frysinger]

merged, thx
-mike


signature.asc
Description: PGP signature

Re: [PATCH] Makefile.am: make sure autoheader run before autoconf

[Mike Frysinger]

merged, thx
-mike


signature.asc
Description: PGP signature

Re: [PATCH] docs: Fix typo in 'Linking Libraries' section

[Mike Frysinger]

merged, thanks
-mike


signature.asc
Description: PGP signature

Re: [PATCH] docs: Use @file for .libs directory

[Mike Frysinger]

merged, thanks
-mike


signature.asc
Description: PGP signature

Re: GCC Patch Tracking [https://lists.gnu.org/archive/html/libtool-patches/2011-01/msg00026.html]

[Mike Frysinger]

On 21 Dec 2022 17:36, Shinde, Yash wrote:
> https://lists.gnu.org/archive/html/libtool-patches/2011-01/msg00026.html
> Submission Date- Sun, 16 Jan 2011
> Upstream-Status: Submitted
> 
> The given Libtool patch is with it’s current status as ‘Submitted’ but still 
> is not taken to the upstream. Please let us know about why the patch is not 
> taken to the upstream or let us know if there is any problem in including it 
> in upstream.

sorry, but i don't understand the question or what you're looking for
-mike


signature.asc
Description: PGP signature

Re: [PATCH] Support "-fno-sanitize*" options.

[Mike Frysinger]

On 16 Dec 2022 10:10, Manoj Gupta wrote:
> "-fno-sanitize*" options e.g. -fno-sanitize=alignment
> or -fno-sanitize-recover=all are used to tune the behvior of
> sanitizers in GCC/clang. Let libtool pass these options
> to compiler similar to fsanitize=*.

merged now, thx
-mike


signature.asc
Description: PGP signature

[PATCH] maint: extend release version hook to cover config.lt

[Mike Frysinger]

* cfg.mk: Extend rule to cover config.lt.
* m4/libtool.m4: Update copyright year.
---
 cfg.mk| 5 -
 m4/libtool.m4 | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/cfg.mk b/cfg.mk
index 62782ba809fb..e334b1365c27 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -26,7 +26,10 @@ update-copyright-env := UPDATE_COPYRIGHT_FORCE=1 
UPDATE_COPYRIGHT_USE_INTERVALS=
 update-copyright: update-release-year
 update-release-year:
$(AM_V_GEN)year=`date +%Y`; \
-   sed -i "/_LT_COPY/,+1 { /Copyright/ {s:[0-9][0-9][0-9][0-9]:$${year}:} 
}" m4/libtool.m4
+   sed -i \
+   -e "/_LT_COPY/,+1 { /Copyright/ 
{s:[0-9][0-9][0-9][0-9]:$${year}:} }" \
+   -e "/^Copyright/ {s:[0-9][0-9][0-9][0-9]:$${year}:} " \
+   m4/libtool.m4
 
 # Set format of NEWS
 old_NEWS_hash := 68e21416d15e517576ce749b131f
diff --git a/m4/libtool.m4 b/m4/libtool.m4
index f439b5a62299..32485604e847 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -651,7 +651,7 @@ m4_ifset([AC_PACKAGE_NAME], [AC_PACKAGE_NAME 
])config.lt[]dnl
 m4_ifset([AC_PACKAGE_VERSION], [ AC_PACKAGE_VERSION])
 configured by $[0], generated by m4_PACKAGE_STRING.
 
-Copyright (C) 2011 Free Software Foundation, Inc.
+Copyright (C) 2024 Free Software Foundation, Inc.
 This config.lt script is free software; the Free Software Foundation
 gives unlimited permission to copy, distribute and modify it."
 
-- 
2.43.0

Re: [PATCH] tests: Fix grep warning about stray \ before /

[Mike Frysinger]

thx for the patch.  we ended up merging Paul's work as it covered more cases:
https://savannah.gnu.org/patch/index.php?10282
-mike


signature.asc
Description: PGP signature

Re: [PATCH] libtool.m4: fix typos

[Mike Frysinger]

thx, merged now
-mike


signature.asc
Description: PGP signature

Re: [PATCH] Fix mingw _putenv warning

[Mike Frysinger]

i merged Vadim's patch now, thanks
-mike


signature.asc
Description: PGP signature

[patch #8843] Include _CRTIMP in _putenv() declaration in EXE wrapper sources

[Mike Frysinger]

Update of patch#8843 (group libtool):

  Status:None => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #3:

merged now, thanks


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

Re: [PATCH] Include _CRTIMP in _putenv() declaration in EXE wrapper?sources.

[Mike Frysinger]

On 07 Jul 2011 15:45, Vadim Zeitlin wrote:
> Charles Wilson  cwilson.fastmail.fm> writes:
> > On 6/23/2011 5:34 AM, Vadim Zeitlin wrote:
> > > Re-declaring _putenv() without _CRTIMP in strict ANSI mode when using
> > > MinGW resulted in a warning because of a conflict with the previous
> > > declaration that did use _CRTIMP.
> > > 
> > > Simply add _CRTIMP to our declaration to avoid it.
> > 
> > > -int _putenv (const char *);
> > > +_CRTIMP int _putenv (const char *);
> > 
> > Probably should also add __cdecl (for correctness, not warning
> > suppression) in case the user has done a -mrtd.
> > 
> > _CRTIMP int __cdecl _putenv (const char*);
> 
>  Sorry for the delay, I left aside my struggles with libtool for some time,
> but am getting back to it now as I'd really like to not have to return to
> this again later.
> 
>  It's not totally clear to me if I should make this trivial change myself
> or whether this would be done by whoever applies the patch? FWIW I clearly
> agree that __cdecl should be there, I just didn't think about -mrtd case.

i've done it this time for you due to the vintage, but for future reference,
you should always make the updates and post v2/etc... in response to your
original patch.
-mike


signature.asc
Description: PGP signature

Re: [PATCH] hurd-amd64 support

[Mike Frysinger]

On 06 May 2023 16:17, Samuel Thibault wrote:
> This adds support for passing -m elf32_x86_64 vs -m elf_x86_64 to the
> linker on hurd-amd64

this was difficult to merge because you aren't using git.
please switch to that in the futrue when sending patches.
-mike


signature.asc
Description: PGP signature

[patch #10398] hurd-amd64 support

[Mike Frysinger]

Update of patch#10398 (group libtool):

  Status:None => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #2:

looks like you posted this to the mailing list previously, so i can pull
details from that.  it's still a pita though, so please use git in the
future.

https://lists.gnu.org/archive/html/libtool-patches/2023-05/msg0.html


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[patch #10387] Recognize the *-*-windows* config triplets introduced on 2023-06-26

[Mike Frysinger]

Update of patch#10387 (group libtool):

  Status:None => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #1:

thanks, merged now


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[patch #10398] hurd-amd64 support

[Mike Frysinger]

Follow-up Comment #1, patch#10398 (group libtool):

can you use git to create patches ?  hand written ones like this are a pita to
apply, and it's not clear what metadata to put into it (e.g. what name/e-mail
you prefer to use).

the content of the patch itself looks fine.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

Re: [PATCH 3/3] Update links to FlexDLL and edll

[Mike Frysinger]

thx, merged this one now
-mike


signature.asc
Description: PGP signature

Re: [PATCH 2/3] Fix ChangeLog.old encoding

[Mike Frysinger]

On 23 Nov 2023 09:44, Antonin Décimo wrote:
> Copyright-paperwork-exempt: Yes
> ---
>  ChangeLog.old | 10 +-
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/ChangeLog.old b/ChangeLog.old
> index 8e2b51ca..51d7859d 100644
> --- a/ChangeLog.old
> +++ b/ChangeLog.old
> @@ -15551,7 +15551,7 @@
>  
>   * libltdl/ltdl.c (foreach_dirinpath): Ensure that filename is '\0'
>   terminated by all code paths.
> - Reported by Lutz M?ller 
> + Reported by Lutz M?ller 

not sure what you mean by "fix" here.  were you trying to convert the
various ISO-8859-1 sequences with UTF-8 ?  your patch didn't come across
the mailing list correctly if so.  can you compress + resend ?  and put
a little more detail into the commit message ?
-mike


signature.asc
Description: PGP signature

Re: [PATCH 0/3] Fix typos and update links

[Mike Frysinger]

On 23 Nov 2023 15:11, Antonin Décimo wrote:
> > > I also note that the latest version isn't reported on the webpage
> > > (2.4.7 instead of 2.4.6).
> >
> > Which web page (e.g. URL, documentation file in libtool git) are you
> > talking about?
> 
> https://www.gnu.org/software/libtool/ reads:
> > Latest stable release:  libtool-2.4.6.tar.gz

it's fixed now
-mike


signature.asc
Description: PGP signature

Re: [PATCH] libtool: passthru '-shared-libsan' and '-static-libsan' flags

[Mike Frysinger]

On 21 May 2023 20:28, Dmitry Antipov wrote:
> * build-aux/ltmain.in: Pass '-shared-libsan' and '-static-libsan'
>   flags when linking.
> 
> This is intented to link against shared and static sanitizer
> runtimes with Clang.

thx, merged now
-mike


signature.asc
Description: PGP signature

Re: [PATCH] testsuite: Fix C99 compatibility issue in lt_dlopen_a.at

[Mike Frysinger]

On 10 Jan 2023 10:21, Florian Weimer wrote:
> Include  for the strcmp function.  This improves C99
> compiler compatibility because it avoids an implicit function
> declaration.

thx bud, merged now
-mike


signature.asc
Description: PGP signature

Re: [PATCH] libtool: remove stray \ before -

[Mike Frysinger]

On 14 Sep 2022 00:10, jspri...@debian.org wrote:
> From: Jochen Sprickerhof 
> 
> grep 3.8 emits a warning for this.

thanks for the patch ... we merged fixed from Paul via
https://savannah.gnu.org/patch/index.php?10282
-mike


signature.asc
Description: PGP signature

[patch #10282] port libtool to grep 3.8 and to POSIX

[Mike Frysinger]

Update of patch#10282 (group libtool):

  Status:None => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #4:

merged both patches.  verified they fixed failures on my system with current
git.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[patch #10275] link-order.at: fix tests with GNU grep 3.8

[Mike Frysinger]

Update of patch#10275 (group libtool):

  Status:None => Duplicate  
 Open/Closed:Open => Closed 

___

Follow-up Comment #3:

normally we don't dupe older-into-newer, but as Paul said, his fix is more
complete, so let's roll with his


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[patch #10385] Add an option for setting rpaths on darwin

[Mike Frysinger]

Update of patch#10385 (group libtool):

  Status:None => Duplicate  
 Open/Closed:Open => Closed 

___

Follow-up Comment #1:

duplicate of https://savannah.gnu.org/patch/index.php?10384


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[patch #8675] elftoolchain strip support

[Mike Frysinger]

Update of patch#8675 (group libtool):

  Status:None => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #1:

we merged a fix which i think covers this & more:
https://git.savannah.gnu.org/cgit/libtool.git/commit/?h=d7c8d3b43fef8641f4354edaa0429d157259bf56


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[patch #6691] FreeMiNT support to libtool 1.5.26 (tested)

[Mike Frysinger]

Update of patch#6691 (group libtool):

  Status:None => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #4:

looks like this was merged:
https://git.savannah.gnu.org/cgit/libtool.git/commit/?h=26d36541aded9124add202e288a79f3c08242687


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[patch #7759] Use AS_HELP_STRING in libtool.m4

[Mike Frysinger]

Update of patch#7759 (group libtool):

  Status:None => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #1:

thanks for the report.  this is fixed in current releases.
https://git.savannah.gnu.org/cgit/libtool.git/commit/?h=d5a9df4837136fa90e9147778939d5c628bc7213


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/