Re: [libvirt] [PATCH v1 0/3] Loadparm support
On 05/19/2017 07:34 PM, Daniel P. Berrange wrote: > On Fri, May 19, 2017 at 12:56:44PM -0400, Farhan Ali wrote: >> This patch series introduces the support for new s390x 'loadparm' >> feature. The 'loadparm' can be used to select the boot entry to >> boot from, for a boot device. > > Why do we need / want any of this when we already have bootindex=NN > support. Inventing a S390-only way to select the boot device order > is pretty horrible IMHO loadparm is an 8 byte character parameter for s390 systems and available on all other hypervisors (LPAR/z/VM). It is really a part of the architecture. Linux does use it to select a boot entry within a disk, but for other guest operating systems it is used to pass along other kind of parameters for the ipl process, e.g. check https://www.ibm.com/support/knowledgecenter/zosbasics/com.ibm.zos.zsysprog/zsysprogc_systemIPL.htm to see what z/OS uses. Not having it was really a missing part of the s390 support. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v1 0/3] Loadparm support
On 05/19/2017 01:34 PM, Daniel P. Berrange wrote: On Fri, May 19, 2017 at 12:56:44PM -0400, Farhan Ali wrote: This patch series introduces the support for new s390x 'loadparm' feature. The 'loadparm' can be used to select the boot entry to boot from, for a boot device. Why do we need / want any of this when we already have bootindex=NN support. Inventing a S390-only way to select the boot device order is pretty horrible IMHO Regards, Daniel Hi Daniel, The bootindex is used to select a boot device, the loadparm used to select a boot entry within that boot device. Loadparm is not a way to select boot device order. Bootindex is still used to select the boot device order. Hope this clears it up. Thanks Farhan -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v1 0/3] Loadparm support
On Fri, May 19, 2017 at 12:56:44PM -0400, Farhan Ali wrote: > This patch series introduces the support for new s390x 'loadparm' > feature. The 'loadparm' can be used to select the boot entry to > boot from, for a boot device. Why do we need / want any of this when we already have bootindex=NN support. Inventing a S390-only way to select the boot device order is pretty horrible IMHO Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v1 0/3] Loadparm support
Please ignore v1 tag on the email. It's actually v2, sorry about that On 05/19/2017 12:56 PM, Farhan Ali wrote: This patch series introduces the support for new s390x 'loadparm' feature. The 'loadparm' can be used to select the boot entry to boot from, for a boot device. Here is a link to the QEMU patches: https://lists.nongnu.org/archive/html/qemu-devel/2017-05/msg00192.html ChangeLog - v1 -> v2: - Rebased the patch series on the latest master, commit 2f69dd3 virfiletest: include linux/falloc.h Thanks Farhan Ali Farhan Ali (3): conf : Add loadparm boot option for a boot device qemu : Add loadparm to qemu command line string tests : Testcases for loadparm docs/formatdomain.html.in | 8 ++- docs/news.xml | 9 +++ docs/schemas/domaincommon.rng | 7 +++ src/conf/device_conf.h | 1 + src/conf/domain_conf.c | 69 +- src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c| 37 ...-machine-loadparm-multiple-disks-nets-s390.args | 28 + ...v-machine-loadparm-multiple-disks-nets-s390.xml | 43 ++ .../qemuxml2argv-machine-loadparm-net-s390.args| 20 +++ .../qemuxml2argv-machine-loadparm-net-s390.xml | 26 ...xml2argv-machine-loadparm-s390-char-invalid.xml | 26 ...uxml2argv-machine-loadparm-s390-len-invalid.xml | 26 .../qemuxml2argv-machine-loadparm-s390.args| 20 +++ .../qemuxml2argv-machine-loadparm-s390.xml | 26 tests/qemuxml2argvtest.c | 19 ++ 17 files changed, 364 insertions(+), 4 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-multiple-disks-nets-s390.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-multiple-disks-nets-s390.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-net-s390.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-net-s390.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390-char-invalid.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390-len-invalid.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390.xml -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v1 0/3] Loadparm support
On 05/17/2017 05:59 PM, John Ferlan wrote: On 05/17/2017 09:48 AM, Farhan Ali wrote: Polite ping :) Could you please update to top of tree and repost... I know for sure qemu_capabilities have changed. In general things look good to me though... Thanks! John Hi John, Thanks for taking a look, I have submitted a v2 to the mailing list. Would appreciate it if you could take a look. Thanks so much Farhan On 05/11/2017 09:27 AM, Farhan Ali wrote: This patch series introduces the support for new s390x 'loadparm' feature. The 'loadparm' can be used to select the boot entry to boot from, for a boot device. Here is a link to the QEMU patches: https://lists.nongnu.org/archive/html/qemu-devel/2017-05/msg00192.html Thanks Farhan Ali Farhan Ali (3): conf : Add loadparm boot option for a boot device qemu : Add loadparm to qemu command line string tests : Testcases for loadparm docs/formatdomain.html.in | 8 ++- docs/news.xml | 9 +++ docs/schemas/domaincommon.rng | 7 +++ src/conf/device_conf.h | 1 + src/conf/domain_conf.c | 69 +- src/qemu/qemu_capabilities.c | 3 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_command.c| 37 ...-machine-loadparm-multiple-disks-nets-s390.args | 28 + ...v-machine-loadparm-multiple-disks-nets-s390.xml | 43 ++ .../qemuxml2argv-machine-loadparm-net-s390.args| 20 +++ .../qemuxml2argv-machine-loadparm-net-s390.xml | 26 ...xml2argv-machine-loadparm-s390-char-invalid.xml | 26 ...uxml2argv-machine-loadparm-s390-len-invalid.xml | 26 .../qemuxml2argv-machine-loadparm-s390.args| 20 +++ .../qemuxml2argv-machine-loadparm-s390.xml | 26 tests/qemuxml2argvtest.c | 19 ++ 17 files changed, 367 insertions(+), 4 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-multiple-disks-nets-s390.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-multiple-disks-nets-s390.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-net-s390.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-net-s390.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390-char-invalid.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390-len-invalid.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390.xml -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH v1 0/3] Loadparm support
This patch series introduces the support for new s390x 'loadparm' feature. The 'loadparm' can be used to select the boot entry to boot from, for a boot device. Here is a link to the QEMU patches: https://lists.nongnu.org/archive/html/qemu-devel/2017-05/msg00192.html ChangeLog - v1 -> v2: - Rebased the patch series on the latest master, commit 2f69dd3 virfiletest: include linux/falloc.h Thanks Farhan Ali Farhan Ali (3): conf : Add loadparm boot option for a boot device qemu : Add loadparm to qemu command line string tests : Testcases for loadparm docs/formatdomain.html.in | 8 ++- docs/news.xml | 9 +++ docs/schemas/domaincommon.rng | 7 +++ src/conf/device_conf.h | 1 + src/conf/domain_conf.c | 69 +- src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c| 37 ...-machine-loadparm-multiple-disks-nets-s390.args | 28 + ...v-machine-loadparm-multiple-disks-nets-s390.xml | 43 ++ .../qemuxml2argv-machine-loadparm-net-s390.args| 20 +++ .../qemuxml2argv-machine-loadparm-net-s390.xml | 26 ...xml2argv-machine-loadparm-s390-char-invalid.xml | 26 ...uxml2argv-machine-loadparm-s390-len-invalid.xml | 26 .../qemuxml2argv-machine-loadparm-s390.args| 20 +++ .../qemuxml2argv-machine-loadparm-s390.xml | 26 tests/qemuxml2argvtest.c | 19 ++ 17 files changed, 364 insertions(+), 4 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-multiple-disks-nets-s390.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-multiple-disks-nets-s390.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-net-s390.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-net-s390.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390-char-invalid.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390-len-invalid.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390.xml -- 1.9.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v1 0/3] Loadparm support
On 05/17/2017 09:48 AM, Farhan Ali wrote: > Polite ping :) > Could you please update to top of tree and repost... I know for sure qemu_capabilities have changed. In general things look good to me though... Thanks! John > On 05/11/2017 09:27 AM, Farhan Ali wrote: >> This patch series introduces the support for new s390x 'loadparm' >> feature. The 'loadparm' can be used to select the boot entry to >> boot from, for a boot device. >> >> Here is a link to the QEMU patches: >> https://lists.nongnu.org/archive/html/qemu-devel/2017-05/msg00192.html >> >> Thanks >> Farhan Ali >> >> >> Farhan Ali (3): >> conf : Add loadparm boot option for a boot device >> qemu : Add loadparm to qemu command line string >> tests : Testcases for loadparm >> >> docs/formatdomain.html.in | 8 ++- >> docs/news.xml | 9 +++ >> docs/schemas/domaincommon.rng | 7 +++ >> src/conf/device_conf.h | 1 + >> src/conf/domain_conf.c | 69 >> +- >> src/qemu/qemu_capabilities.c | 3 + >> src/qemu/qemu_capabilities.h | 3 + >> src/qemu/qemu_command.c| 37 >> ...-machine-loadparm-multiple-disks-nets-s390.args | 28 + >> ...v-machine-loadparm-multiple-disks-nets-s390.xml | 43 ++ >> .../qemuxml2argv-machine-loadparm-net-s390.args| 20 +++ >> .../qemuxml2argv-machine-loadparm-net-s390.xml | 26 >> ...xml2argv-machine-loadparm-s390-char-invalid.xml | 26 >> ...uxml2argv-machine-loadparm-s390-len-invalid.xml | 26 >> .../qemuxml2argv-machine-loadparm-s390.args| 20 +++ >> .../qemuxml2argv-machine-loadparm-s390.xml | 26 >> tests/qemuxml2argvtest.c | 19 ++ >> 17 files changed, 367 insertions(+), 4 deletions(-) >> create mode 100644 >> tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-multiple-disks-nets-s390.args >> >> create mode 100644 >> tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-multiple-disks-nets-s390.xml >> >> create mode 100644 >> tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-net-s390.args >> create mode 100644 >> tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-net-s390.xml >> create mode 100644 >> tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390-char-invalid.xml >> >> create mode 100644 >> tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390-len-invalid.xml >> create mode 100644 >> tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390.args >> create mode 100644 >> tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390.xml >> > > -- > libvir-list mailing list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v1 0/3] Loadparm support
Polite ping :) On 05/11/2017 09:27 AM, Farhan Ali wrote: This patch series introduces the support for new s390x 'loadparm' feature. The 'loadparm' can be used to select the boot entry to boot from, for a boot device. Here is a link to the QEMU patches: https://lists.nongnu.org/archive/html/qemu-devel/2017-05/msg00192.html Thanks Farhan Ali Farhan Ali (3): conf : Add loadparm boot option for a boot device qemu : Add loadparm to qemu command line string tests : Testcases for loadparm docs/formatdomain.html.in | 8 ++- docs/news.xml | 9 +++ docs/schemas/domaincommon.rng | 7 +++ src/conf/device_conf.h | 1 + src/conf/domain_conf.c | 69 +- src/qemu/qemu_capabilities.c | 3 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_command.c| 37 ...-machine-loadparm-multiple-disks-nets-s390.args | 28 + ...v-machine-loadparm-multiple-disks-nets-s390.xml | 43 ++ .../qemuxml2argv-machine-loadparm-net-s390.args| 20 +++ .../qemuxml2argv-machine-loadparm-net-s390.xml | 26 ...xml2argv-machine-loadparm-s390-char-invalid.xml | 26 ...uxml2argv-machine-loadparm-s390-len-invalid.xml | 26 .../qemuxml2argv-machine-loadparm-s390.args| 20 +++ .../qemuxml2argv-machine-loadparm-s390.xml | 26 tests/qemuxml2argvtest.c | 19 ++ 17 files changed, 367 insertions(+), 4 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-multiple-disks-nets-s390.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-multiple-disks-nets-s390.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-net-s390.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-net-s390.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390-char-invalid.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390-len-invalid.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390.xml -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH v1 0/3] Loadparm support
This patch series introduces the support for new s390x 'loadparm' feature. The 'loadparm' can be used to select the boot entry to boot from, for a boot device. Here is a link to the QEMU patches: https://lists.nongnu.org/archive/html/qemu-devel/2017-05/msg00192.html Thanks Farhan Ali Farhan Ali (3): conf : Add loadparm boot option for a boot device qemu : Add loadparm to qemu command line string tests : Testcases for loadparm docs/formatdomain.html.in | 8 ++- docs/news.xml | 9 +++ docs/schemas/domaincommon.rng | 7 +++ src/conf/device_conf.h | 1 + src/conf/domain_conf.c | 69 +- src/qemu/qemu_capabilities.c | 3 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_command.c| 37 ...-machine-loadparm-multiple-disks-nets-s390.args | 28 + ...v-machine-loadparm-multiple-disks-nets-s390.xml | 43 ++ .../qemuxml2argv-machine-loadparm-net-s390.args| 20 +++ .../qemuxml2argv-machine-loadparm-net-s390.xml | 26 ...xml2argv-machine-loadparm-s390-char-invalid.xml | 26 ...uxml2argv-machine-loadparm-s390-len-invalid.xml | 26 .../qemuxml2argv-machine-loadparm-s390.args| 20 +++ .../qemuxml2argv-machine-loadparm-s390.xml | 26 tests/qemuxml2argvtest.c | 19 ++ 17 files changed, 367 insertions(+), 4 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-multiple-disks-nets-s390.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-multiple-disks-nets-s390.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-net-s390.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-net-s390.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390-char-invalid.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390-len-invalid.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-loadparm-s390.xml -- 1.9.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
