Re: [libvirt] [dbus PATCH 00/15] Implement Interface APIs
On Fri, Jul 06, 2018 at 05:36:40PM -0400, Anya Harter wrote: > https://libvirt.org/html/libvirt-libvirt-interface.html > > The following functions have been implemented: > > - virConnectListAllInterfaces (connect method) > - virInterfaceChangeBegin (connect method) > - virInterfaceChangeCommit (connect method) > - virInterfaceChangeRollback(connect method) > - virInterfaceCreate(interface method) > - virInterfaceDefineXML (connect method) > - virInterfaceDestroy (interface method) > - virInterfaceGetMACString (property) > - virInterfaceGetName (property) > - virInterfaceGetXMLDesc(interface method) > - virInterfaceIsActive (property) > - virInterfaceLookupByMACString (connect method) > - virInterfaceLookupByName (connect method) > - virInterfaceUndefine (interface method) Nice work, there are some minor issues that needs to be fixed but otherwise it looks good. Only tests are missing but we already discussed that on IRC and it will require DefineXML & Create APIs because test driver doesn't have virConnectListAllInterfaces() implemented which is used to get some interface to work with and there is no CreateXML API to create temporary interface like we do for NodeDevices. We usually introduce test case together with the new API and in this case it would require to change the order of patches to introduce DefineXML and Create API before introducing tests. Pavel signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [dbus PATCH 00/15] Implement Interface APIs
https://libvirt.org/html/libvirt-libvirt-interface.html The following functions have been implemented: - virConnectListAllInterfaces (connect method) - virInterfaceChangeBegin (connect method) - virInterfaceChangeCommit (connect method) - virInterfaceChangeRollback(connect method) - virInterfaceCreate(interface method) - virInterfaceDefineXML (connect method) - virInterfaceDestroy (interface method) - virInterfaceGetMACString (property) - virInterfaceGetName (property) - virInterfaceGetXMLDesc(interface method) - virInterfaceIsActive (property) - virInterfaceLookupByMACString (connect method) - virInterfaceLookupByName (connect method) - virInterfaceUndefine (interface method) Anya Harter (15): Introduce Interface Interface Implement Name property for Interface Interface Implement MACString property for Interface Interface Implement Active property for Interface Interface Implement ListInterfaces method for Connect Interface Implement InterfaceDefineXML method for Connect Interface Implement InterfaceChangeBegin method for Connect Interface Implement InterfaceChangeCommit method for Connect Interface Implement InterfaceChangeRollback method for Connect Interface Implement InterfaceLookupByName method for Connect Interface Implement InterfaceLookupByMACString method for Connect Interface Implement Create method for Interface Interface Implement Destroy method for Interface Interface Implement Undefine method for Interface Interface Implement GetXMLDesc method for Interface Interface data/Makefile.am | 1 + data/org.libvirt.Connect.xml | 40 ++ data/org.libvirt.Interface.xml | 41 ++ src/Makefile.am| 2 + src/connect.c | 198 ++ src/connect.h | 1 + src/interface.c| 249 + src/interface.h| 9 ++ src/util.c | 35 + src/util.h | 15 ++ 10 files changed, 591 insertions(+) create mode 100644 data/org.libvirt.Interface.xml create mode 100644 src/interface.c create mode 100644 src/interface.h -- 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list