Re: Various updates to reduce make doc output (issue 5727055)
ok
http://codereview.appspot.com/5727055/diff/11002/scripts/abc2ly.py
File scripts/abc2ly.py (right):
http://codereview.appspot.com/5727055/diff/11002/scripts/abc2ly.py#newcode1400
scripts/abc2ly.py:1400: help=_ ("suppress progress messages"))
On 2012/03/12 19:43:38, Julien Rioux wrote:
..change this to "suppress progress and warning messages"?
+1
http://codereview.appspot.com/5727055/diff/11002/scripts/midi2ly.py
File scripts/midi2ly.py (right):
http://codereview.appspot.com/5727055/diff/11002/scripts/midi2ly.py#newcode1078
scripts/midi2ly.py:1078: help=_ ("suppress progress messages"))
change to "suppress progress messages and warnings"
http://codereview.appspot.com/5727055/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: "Trevor Daniels" ; "Carl Sorensen" ; "Lily-Devel List" Sent: Thursday, March 15, 2012 3:20 PM Subject: Re: Various updates to reduce make doc output (issue 5727055) On Thu, Mar 15, 2012 at 03:06:22PM +, Graham Percival wrote: On Thu, Mar 15, 2012 at 08:59:53AM -, Phil Holmes wrote: > Can I please now quieten this warning using the explicit command > line switch --quiet? huh? I'm sorry, but I think this points to a different lesson. If we explicitly throw away warnings with --quiet, then we'll miss Sorry, I forgot again that we were talking about make doc and not make test. As long as make test still prints or saves the warning to a logfile, I'm happy with make doc throwing it away. - Graham In that case I withdraw my previous aargh... -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: "Trevor Daniels" ; "Carl Sorensen" ; "Lily-Devel List" Sent: Thursday, March 15, 2012 3:06 PM Subject: Re: Various updates to reduce make doc output (issue 5727055) On Thu, Mar 15, 2012 at 08:59:53AM -, Phil Holmes wrote: Please see http://code.google.com/p/lilypond/issues/detail?id=2407. Great! Can I please now quieten this warning using the explicit command line switch --quiet? huh? I'm sorry, but I think this points to a different lesson. If we explicitly throw away warnings with --quiet, then we'll miss seeing problems in lilypond. I don't think we need to see it on the command-line, but there should be *some* record of this warning *somewhere* (i.e. in a log file). - Graham Aargh. I am _not_ throwing away warnings. I am hiding a _single_ warning in midi2ly. This only warns the user that the output may not be optimal. I am going to update the --help to make this clear. If anyone runs midi2ly with --quiet and then doesn't like the output, they can check the help, run it without --quiet or fix the bug I've raised. Honestly, there's no point in redirecting a warning that no-one wants to see to a logfile that no-one will read. Check out the other logfiles for the other warnings if you don't believe me. Is anyone fixing http://code.google.com/p/lilypond/issues/detail?id=2146 which has a far more detrimental effect? Honestly, it is nit-picking like this that drives me crackers. Let's just go with hiding this during builds. Please? -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
On Thu, Mar 15, 2012 at 03:06:22PM +, Graham Percival wrote: > On Thu, Mar 15, 2012 at 08:59:53AM -, Phil Holmes wrote: > > Can I please now quieten this warning using the explicit command > > line switch --quiet? > > huh? I'm sorry, but I think this points to a different lesson. > If we explicitly throw away warnings with --quiet, then we'll miss Sorry, I forgot again that we were talking about make doc and not make test. As long as make test still prints or saves the warning to a logfile, I'm happy with make doc throwing it away. - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
On Thu, Mar 15, 2012 at 08:59:53AM -, Phil Holmes wrote: > Please see http://code.google.com/p/lilypond/issues/detail?id=2407. Great! > Can I please now quieten this warning using the explicit command > line switch --quiet? huh? I'm sorry, but I think this points to a different lesson. If we explicitly throw away warnings with --quiet, then we'll miss seeing problems in lilypond. I don't think we need to see it on the command-line, but there should be *some* record of this warning *somewhere* (i.e. in a log file). - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
Phil Holmes wrote Thursday, March 15, 2012 8:59 AM From: "Trevor Daniels" Carl Sorensen wrote Wednesday, March 14, 2012 6:01 PM So it would be nice to have a feature added to midi2ly that would automatically create voiceFive, voiceSix, etc. if needed. Exactly! Having discovered the problem, the correct procedure is to raise an issue for it, not try to hide it. It would be easy to add a couple of extra voices to ly/property-init.ly, if that would make it easier to fix midi2ly. Trevor The problem has been apparent for at least a year, had anyone wanted to look at the warnings from make doc. It would have been easy to raise an issue to cover the problem, had anyone been looking at the output of make doc. Yes, I guess you're the first developer to look at the warnings from make doc ... Please see http://code.google.com/p/lilypond/issues/detail?id=2407. ... and now you've raised an issue for this one so it doesn't get swept under the carpet ... Can I please now quieten this warning using the explicit command line switch --quiet? ... I for one would be happy for you to go ahead and quieten it. Thanks, Trevor ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
- Original Message - From: "Trevor Daniels" To: "Carl Sorensen" ; "Phil Holmes" Cc: "Lily-Devel List" Sent: Wednesday, March 14, 2012 11:55 PM Subject: Re: Various updates to reduce make doc output (issue 5727055) Carl Sorensen wrote Wednesday, March 14, 2012 6:01 PM On 3/14/12 11:48 AM, "Phil Holmes" wrote: I've looked at midi2ly and it uses explicit instantiation of voices, which is what we normally advise. My understanding is that there are only 4 explicit voices - voiceFive does not exist, AFAIK. The warning message comes from midi2ly stating that it has no more explicit voice names left, and therefore layout is likely to be poor. We don't need to see this during make doc. If I read the snippet correctly (Additional voices to avoid collisions, in NR 1.5.2), there is no limit to the number of voices in LilyPond. But only four voices are defined. In the snippet, voiceFive is defined, before it is used. So it would be nice to have a feature added to midi2ly that would automatically create voiceFive, voiceSix, etc. if needed. Exactly! Having discovered the problem, the correct procedure is to raise an issue for it, not try to hide it. It would be easy to add a couple of extra voices to ly/property-init.ly, if that would make it easier to fix midi2ly. Trevor The problem has been apparent for at least a year, had anyone wanted to look at the warnings from make doc. It would have been easy to raise an issue to cover the problem, had anyone been looking at the output of make doc. Please see http://code.google.com/p/lilypond/issues/detail?id=2407. Can I please now quieten this warning using the explicit command line switch --quiet? -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
Carl Sorensen wrote Wednesday, March 14, 2012 6:01 PM On 3/14/12 11:48 AM, "Phil Holmes" wrote: I've looked at midi2ly and it uses explicit instantiation of voices, which is what we normally advise. My understanding is that there are only 4 explicit voices - voiceFive does not exist, AFAIK. The warning message comes from midi2ly stating that it has no more explicit voice names left, and therefore layout is likely to be poor. We don't need to see this during make doc. If I read the snippet correctly (Additional voices to avoid collisions, in NR 1.5.2), there is no limit to the number of voices in LilyPond. But only four voices are defined. In the snippet, voiceFive is defined, before it is used. So it would be nice to have a feature added to midi2ly that would automatically create voiceFive, voiceSix, etc. if needed. Exactly! Having discovered the problem, the correct procedure is to raise an issue for it, not try to hide it. It would be easy to add a couple of extra voices to ly/property-init.ly, if that would make it easier to fix midi2ly. Trevor ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
On 3/14/12 11:48 AM, "Phil Holmes" wrote: >- Original Message - >From: "Trevor Daniels" >To: "Phil Holmes" >Cc: "Lily-Devel List" >Sent: Wednesday, March 14, 2012 4:28 PM >Subject: Re: Various updates to reduce make doc output (issue 5727055) > >> Didn't you see what I wrote before? There is no restriction to >> 4 voices in LilyPond, as is shown in the NR. See Single-staff >>polyphony >> in >> http://www.lilypond.org/doc/v2.15/Documentation/notation/multiple-voices >> >> >I've looked at midi2ly and it uses explicit instantiation of voices, >which >is what we normally advise. My understanding is that there are only 4 >explicit voices - voiceFive does not exist, AFAIK. The warning message >comes from midi2ly stating that it has no more explicit voice names left, >and therefore layout is likely to be poor. We don't need to see this >during >make doc. If I read the snippet correctly (Additional voices to avoid collisions, in NR 1.5.2), there is no limit to the number of voices in LilyPond. But only four voices are defined. In the snippet, voiceFive is defined, before it is used. So it would be nice to have a feature added to midi2ly that would automatically create voiceFive, voiceSix, etc. if needed. Thanks, Carl ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
- Original Message - From: "Trevor Daniels" To: "Phil Holmes" Cc: "Lily-Devel List" Sent: Wednesday, March 14, 2012 4:28 PM Subject: Re: Various updates to reduce make doc output (issue 5727055) Phil Holmes wrote Wednesday, March 14, 2012 12:00 PM From: "Trevor Daniels" To: "Julien Rioux" ; "Phil Holmes" Cc: ; Sent: Wednesday, March 14, 2012 11:41 AM Subject: Re: Various updates to reduce make doc output (issue 5727055) Julien Rioux wrote Wednesday, March 14, 2012 10:37 AM On Wed, Mar 14, 2012 at 9:56 AM, Phil Holmes wrote: - Original Message - From: "Julien Rioux" To: "Phil Holmes" The problem with this one is that Lilypond (like Sibelius...) only provides 4 voices to allow notes to avoid colliding on a stave. Not true. See Single-staff polyphony in http://www.lilypond.org/doc/v2.15/Documentation/notation/multiple-voices I'm fine with either 1) Leave the warning there (it's only one line of `make doc' output), or Strongly preferred - hiding this warning would be wrong until it is properly understood. I think it is understood. Lilypond has a maximum of 4 voices. The midi file has 5. They won't all fit into the 4 maximum. midi2ly warns the user that the output won't look great. But we know that for this midi file and don't need to be told every time it's compiled. Please keep your replies on the list. Apologies. Was in a hurry and had finger trouble. Didn't you see what I wrote before? There is no restriction to 4 voices in LilyPond, as is shown in the NR. See Single-staff polyphony in http://www.lilypond.org/doc/v2.15/Documentation/notation/multiple-voices So it seems unlikely this is the cause of the warning, hence it is not understood. So hiding this warning would be wrong. Trevor I've looked at midi2ly and it uses explicit instantiation of voices, which is what we normally advise. My understanding is that there are only 4 explicit voices - voiceFive does not exist, AFAIK. The warning message comes from midi2ly stating that it has no more explicit voice names left, and therefore layout is likely to be poor. We don't need to see this during make doc. I would have no problem with a request to add an issue suggesting an enhancement to midi2ly that it only uses implicit voices where it encounters more than 4 channels on a track, and therefore to lose the error message completely, but I remain firmly of the opinion that we don't need this warning repeated every time we make doc. -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
Phil Holmes wrote Wednesday, March 14, 2012 12:00 PM From: "Trevor Daniels" To: "Julien Rioux" ; "Phil Holmes" Cc: ; Sent: Wednesday, March 14, 2012 11:41 AM Subject: Re: Various updates to reduce make doc output (issue 5727055) Julien Rioux wrote Wednesday, March 14, 2012 10:37 AM On Wed, Mar 14, 2012 at 9:56 AM, Phil Holmes wrote: - Original Message - From: "Julien Rioux" To: "Phil Holmes" The problem with this one is that Lilypond (like Sibelius...) only provides 4 voices to allow notes to avoid colliding on a stave. Not true. See Single-staff polyphony in http://www.lilypond.org/doc/v2.15/Documentation/notation/multiple-voices I'm fine with either 1) Leave the warning there (it's only one line of `make doc' output), or Strongly preferred - hiding this warning would be wrong until it is properly understood. I think it is understood. Lilypond has a maximum of 4 voices. The midi file has 5. They won't all fit into the 4 maximum. midi2ly warns the user that the output won't look great. But we know that for this midi file and don't need to be told every time it's compiled. Please keep your replies on the list. Didn't you see what I wrote before? There is no restriction to 4 voices in LilyPond, as is shown in the NR. See Single-staff polyphony in http://www.lilypond.org/doc/v2.15/Documentation/notation/multiple-voices So it seems unlikely this is the cause of the warning, hence it is not understood. So hiding this warning would be wrong. Trevor ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
Julien Rioux wrote Wednesday, March 14, 2012 10:37 AM On Wed, Mar 14, 2012 at 9:56 AM, Phil Holmes wrote: - Original Message - From: "Julien Rioux" To: "Phil Holmes" The problem with this one is that Lilypond (like Sibelius...) only provides 4 voices to allow notes to avoid colliding on a stave. Not true. See Single-staff polyphony in http://www.lilypond.org/doc/v2.15/Documentation/notation/multiple-voices I'm fine with either 1) Leave the warning there (it's only one line of `make doc' output), or Strongly preferred - hiding this warning would be wrong until it is properly understood. 2) Document in `midi2ly --help' that --quiet also silences warning messages. Trevor ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
On Wed, Mar 14, 2012 at 9:56 AM, Phil Holmes wrote: > - Original Message - From: "Julien Rioux" > To: "Phil Holmes" > >> > >> > It seems just not worth it. We _never_ want to check warnings as part of >> > make doc. That's what regression tests are for. >> > >> > -- >> > Phil Holmes >> >> I disagree, make -s doc is useful to identify warning messages that >> need fixing, and the log files are also useful for this. I think that >> the progress messages are what you should focus on silencing. The >> warning messages should be either fixed at the source or left in place >> so that someone eventually decides to fix them at the source. In this >> particular case, it might be that nobody will ever work to improve >> midi2ly, but that's not for us to say. >> >> Regards, >> Julien > > > Sorry - I expressed myself badly. I meant that we shouldn't use make doc to > check that warnings that we expect to appear do, in fact, continue to > appear. We should use make test to check that the "correct" warnings > continue to be output. I agree 100% that make doc _should_ make it easy to > find new warnings we were unaware of. > > The problem with this one is that Lilypond (like Sibelius...) only provides > 4 voices to allow notes to avoid colliding on a stave. I haven't delved > deeply into midi2ly, but my assumption is that it maps midi channels on a > single stave to different voices. The "offending" midi file has more that 4 > channels on a stave and therefore the mapping to 4 voices is never going to > work properly - and so midi2ly warns the user. But we don't want to > continue to see those warnings on the screen, hence the suppression with -q. > I can't see why an interactive user would use -q, so it won't give them a > problem. I also don't believe that having another logfile solely to contain > the message "warning: found more than 5 voices on a staff, expect bad > output" makes much sense. Hence the way I went. > > -- > Phil Holmes > > I'm fine with either 1) Leave the warning there (it's only one line of `make doc' output), or 2) Document in `midi2ly --help' that --quiet also silences warning messages. Cheers, Julien ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
- Original Message - From: "Julien Rioux" To: "Phil Holmes" > > It seems just not worth it. We _never_ want to check warnings as part of > make doc. That's what regression tests are for. > > -- > Phil Holmes I disagree, make -s doc is useful to identify warning messages that need fixing, and the log files are also useful for this. I think that the progress messages are what you should focus on silencing. The warning messages should be either fixed at the source or left in place so that someone eventually decides to fix them at the source. In this particular case, it might be that nobody will ever work to improve midi2ly, but that's not for us to say. Regards, Julien Sorry - I expressed myself badly. I meant that we shouldn't use make doc to check that warnings that we expect to appear do, in fact, continue to appear. We should use make test to check that the "correct" warnings continue to be output. I agree 100% that make doc _should_ make it easy to find new warnings we were unaware of. The problem with this one is that Lilypond (like Sibelius...) only provides 4 voices to allow notes to avoid colliding on a stave. I haven't delved deeply into midi2ly, but my assumption is that it maps midi channels on a single stave to different voices. The "offending" midi file has more that 4 channels on a stave and therefore the mapping to 4 voices is never going to work properly - and so midi2ly warns the user. But we don't want to continue to see those warnings on the screen, hence the suppression with -q. I can't see why an interactive user would use -q, so it won't give them a problem. I also don't believe that having another logfile solely to contain the message "warning: found more than 5 voices on a staff, expect bad output" makes much sense. Hence the way I went. -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
On Mon, Mar 12, 2012 at 6:26 PM, Phil Holmes wrote: > - Original Message - From: "Graham Percival" > > To: "Phil Holmes" > Cc: ; ; ; > ; > Sent: Monday, March 12, 2012 7:27 PM > > Subject: Re: Various updates to reduce make doc output (issue 5727055) > > >> On Mon, Mar 12, 2012 at 06:31:35PM -, Phil Holmes wrote: >>> >>> - Original Message - From: >>> To: ; ; >>> ; >>> Cc: ; >>> Sent: Monday, March 12, 2012 6:18 PM >>> Subject: Re: Various updates to reduce make doc output (issue 5727055) >>> >>> >--quiet shouldn't suppress warning messages, everything else looks good. >>> >>> The problem with this warning message is that, as part of build, you >>> can't fix it - if you want to test converting midi with more than 5 >>> voices to lilypond, you'll get a message on screen, which is not >>> what's wanted. >> >> >> Can't you redirect the midi2ly call to a log file? If a test is >> deliberately checking that a midi file with more than 5 voices >> should produce a warning, then we _want_ that warning saved to a >> logfile so we can check that the warning doesn't go away. >> Conversely, if we don't want that warning, then it's good to save >> it in a logfile so that future programmers can see the problem >> easily. >> >> - Graham > > > It seems just not worth it. We _never_ want to check warnings as part of > make doc. That's what regression tests are for. > > -- > Phil Holmes I disagree, make -s doc is useful to identify warning messages that need fixing, and the log files are also useful for this. I think that the progress messages are what you should focus on silencing. The warning messages should be either fixed at the source or left in place so that someone eventually decides to fix them at the source. In this particular case, it might be that nobody will ever work to improve midi2ly, but that's not for us to say. Regards, Julien ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: ; ; ; ; Sent: Monday, March 12, 2012 7:27 PM Subject: Re: Various updates to reduce make doc output (issue 5727055) On Mon, Mar 12, 2012 at 06:31:35PM -, Phil Holmes wrote: - Original Message - From: To: ; ; ; Cc: ; Sent: Monday, March 12, 2012 6:18 PM Subject: Re: Various updates to reduce make doc output (issue 5727055) >--quiet shouldn't suppress warning messages, everything else looks good. The problem with this warning message is that, as part of build, you can't fix it - if you want to test converting midi with more than 5 voices to lilypond, you'll get a message on screen, which is not what's wanted. Can't you redirect the midi2ly call to a log file? If a test is deliberately checking that a midi file with more than 5 voices should produce a warning, then we _want_ that warning saved to a logfile so we can check that the warning doesn't go away. Conversely, if we don't want that warning, then it's good to save it in a logfile so that future programmers can see the problem easily. - Graham It seems just not worth it. We _never_ want to check warnings as part of make doc. That's what regression tests are for. -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
Maybe simply...
http://codereview.appspot.com/5727055/diff/11002/scripts/abc2ly.py
File scripts/abc2ly.py (right):
http://codereview.appspot.com/5727055/diff/11002/scripts/abc2ly.py#newcode1400
scripts/abc2ly.py:1400: help=_ ("suppress progress messages"))
..change this to "suppress progress and warning messages"?
http://codereview.appspot.com/5727055/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
On Mon, Mar 12, 2012 at 06:31:35PM -, Phil Holmes wrote: > - Original Message - From: > To: ; ; > ; > Cc: ; > Sent: Monday, March 12, 2012 6:18 PM > Subject: Re: Various updates to reduce make doc output (issue 5727055) > > >--quiet shouldn't suppress warning messages, everything else looks good. > > The problem with this warning message is that, as part of build, you > can't fix it - if you want to test converting midi with more than 5 > voices to lilypond, you'll get a message on screen, which is not > what's wanted. Can't you redirect the midi2ly call to a log file? If a test is deliberately checking that a midi file with more than 5 voices should produce a warning, then we _want_ that warning saved to a logfile so we can check that the warning doesn't go away. Conversely, if we don't want that warning, then it's good to save it in a logfile so that future programmers can see the problem easily. - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
- Original Message -
From:
To: ; ; ;
Cc: ;
Sent: Monday, March 12, 2012 6:18 PM
Subject: Re: Various updates to reduce make doc output (issue 5727055)
--quiet shouldn't suppress warning messages, everything else looks good.
Cheers,
Julien
http://codereview.appspot.com/5727055/diff/11002/scripts/midi2ly.py
File scripts/midi2ly.py (right):
http://codereview.appspot.com/5727055/diff/11002/scripts/midi2ly.py#newcode835
scripts/midi2ly.py:835: warning (_ ('found more than 5 voices on a
staff, expect bad output'))
--quiet shouldn't suppress warning messages.
http://codereview.appspot.com/5727055/
The problem with this warning message is that, as part of build, you can't
fix it - if you want to test converting midi with more than 5 voices to
lilypond, you'll get a message on screen, which is not what's wanted. Given
that you're only likely to run --quiet as part of doc build, and it's not a
warning you want to see every time you run make doc, I think it's better to
suppress this one.
--
Phil Holmes
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
--quiet shouldn't suppress warning messages, everything else looks good.
Cheers,
Julien
http://codereview.appspot.com/5727055/diff/11002/scripts/midi2ly.py
File scripts/midi2ly.py (right):
http://codereview.appspot.com/5727055/diff/11002/scripts/midi2ly.py#newcode835
scripts/midi2ly.py:835: warning (_ ('found more than 5 voices on a
staff, expect bad output'))
--quiet shouldn't suppress warning messages.
http://codereview.appspot.com/5727055/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
--quiet flag added to abc2ly and midi2ly invocations. make and make doc compile clean. Will push this to staging tomorrow unless anyone shouts. http://codereview.appspot.com/5727055/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
Updates as suggested. Please review. http://codereview.appspot.com/5727055/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
On 2012/03/04 16:50:20, Julien Rioux wrote: I think the scrips abc2ly and midi2ly are useful as stand-alone tools, i.e. outside of the build system, in which case users might still expect to see some progress messages. If that's the case then adding either a --quiet or a --verbose option (or maybe --debug) for these scripts would be nice; the build system would run them quietly of course. +1 It won't take too long to add such a flag, and the rest of this patch can be considered without those changes to abc2ly etc. http://codereview.appspot.com/5727055/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
On Sun, Mar 4, 2012 at 12:04 PM, Phil Holmes wrote: > - Original Message - From: >> http://codereview.appspot.com/5727055/diff/1/Documentation/GNUmakefile#newcode283 >> Documentation/GNUmakefile:283: cd $(outdir) && >> $(buildscript-dir)/run-and-check "$(LILYPOND_BINARY) --verbose >> $(top-src-dir)/ly/generate-documentation" "$(*F).log" >> Why not just call it "generate-documentation.log" > > > I did think of that, too! It actually produces internals.log, and I thought > that might fit better with the target. I used the make variable to be > relatively consistent with the other invocations. > Since this is a very specific rule and not a catch-all, there is no benefit in using the make variable. The filename also clashes with internals.log produced by pdflatex. That's why I think something else would be better. Cheers, Julien ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
- Original Message -
From:
To: ; ;
Cc: ;
Sent: Sunday, March 04, 2012 4:50 PM
Subject: Re: Various updates to reduce make doc output (issue 5727055)
I think the scrips abc2ly and midi2ly are useful as stand-alone tools,
i.e. outside of the build system, in which case users might still expect
to see some progress messages. If that's the case then adding either a
--quiet or a --verbose option (or maybe --debug) for these scripts would
be nice; the build system would run them quietly of course.
Cheers,
Julien
I did consider it, but concluded that if you're running these tools, you
could probably look in the output directory to see what it's produced. It
just seemed more effort than it was worth, to be honest.
http://codereview.appspot.com/5727055/diff/1/Documentation/GNUmakefile
File Documentation/GNUmakefile (right):
http://codereview.appspot.com/5727055/diff/1/Documentation/GNUmakefile#newcode283
Documentation/GNUmakefile:283: cd $(outdir) &&
$(buildscript-dir)/run-and-check "$(LILYPOND_BINARY) --verbose
$(top-src-dir)/ly/generate-documentation" "$(*F).log"
Why not just call it "generate-documentation.log"
I did think of that, too! It actually produces internals.log, and I thought
that might fit better with the target. I used the make variable to be
relatively consistent with the other invocations.
http://codereview.appspot.com/5727055/diff/1/scripts/abc2ly.py
File scripts/abc2ly.py (left):
http://codereview.appspot.com/5727055/diff/1/scripts/abc2ly.py#oldcode1413
scripts/abc2ly.py:1413: sys.stderr.write ('Parsing `%s\'...\n' % f)
What about this line?
http://codereview.appspot.com/5727055/diff/1/scripts/abc2ly.py#oldcode1431
scripts/abc2ly.py:1431: sys.stderr.write ('\n')
And this line?
http://codereview.appspot.com/5727055/diff/1/scripts/midi2ly.py
File scripts/midi2ly.py (left):
http://codereview.appspot.com/5727055/diff/1/scripts/midi2ly.py#oldcode1030
scripts/midi2ly.py:1030: progress (_ ("%s output to `%s'...") % ('LY',
out_file))
Change it to a debug output?
http://codereview.appspot.com/5727055/diff/1/scripts/midi2ly.py#oldcode1030
scripts/midi2ly.py:1030: progress (_ ("%s output to `%s'...") % ('LY',
out_file))
Change it to a debug output maybe?
http://codereview.appspot.com/5727055/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various updates to reduce make doc output (issue 5727055)
I think the scrips abc2ly and midi2ly are useful as stand-alone tools,
i.e. outside of the build system, in which case users might still expect
to see some progress messages. If that's the case then adding either a
--quiet or a --verbose option (or maybe --debug) for these scripts would
be nice; the build system would run them quietly of course.
Cheers,
Julien
http://codereview.appspot.com/5727055/diff/1/Documentation/GNUmakefile
File Documentation/GNUmakefile (right):
http://codereview.appspot.com/5727055/diff/1/Documentation/GNUmakefile#newcode283
Documentation/GNUmakefile:283: cd $(outdir) &&
$(buildscript-dir)/run-and-check "$(LILYPOND_BINARY) --verbose
$(top-src-dir)/ly/generate-documentation" "$(*F).log"
Why not just call it "generate-documentation.log"
http://codereview.appspot.com/5727055/diff/1/scripts/abc2ly.py
File scripts/abc2ly.py (left):
http://codereview.appspot.com/5727055/diff/1/scripts/abc2ly.py#oldcode1413
scripts/abc2ly.py:1413: sys.stderr.write ('Parsing `%s\'...\n' % f)
What about this line?
http://codereview.appspot.com/5727055/diff/1/scripts/abc2ly.py#oldcode1431
scripts/abc2ly.py:1431: sys.stderr.write ('\n')
And this line?
http://codereview.appspot.com/5727055/diff/1/scripts/midi2ly.py
File scripts/midi2ly.py (left):
http://codereview.appspot.com/5727055/diff/1/scripts/midi2ly.py#oldcode1030
scripts/midi2ly.py:1030: progress (_ ("%s output to `%s'...") % ('LY',
out_file))
Change it to a debug output?
http://codereview.appspot.com/5727055/diff/1/scripts/midi2ly.py#oldcode1030
scripts/midi2ly.py:1030: progress (_ ("%s output to `%s'...") % ('LY',
out_file))
Change it to a debug output maybe?
http://codereview.appspot.com/5727055/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Various updates to reduce make doc output (issue 5727055)
Reviewers: dak, Graham Percival, Julien Rioux,
Message:
Now down to less than 500 lines with these changes. Please review.
Description:
GNUmakefile: pushes lilypond output to a logfile. Using $(*F) for the
filename since the target name includes the directory.
GNUmakefile.in: heeltap from previous patch
lilypond-book-rules.make: removes output from pdflatex and prevents it
requesting input if it fails.
lysdoc-rules.make: Gets rid of echoed progress message
abc2ly.py; lys-to-tely.py; midi2ly.py: Gets rid of progress message.
Please review this at http://codereview.appspot.com/5727055/
Affected files:
M Documentation/GNUmakefile
M GNUmakefile.in
M make/lilypond-book-rules.make
M make/lysdoc-rules.make
M scripts/abc2ly.py
M scripts/build/lys-to-tely.py
M scripts/midi2ly.py
Index: Documentation/GNUmakefile
diff --git a/Documentation/GNUmakefile b/Documentation/GNUmakefile
index
5f04dc880cf1297f4f37d1297e2ff161344313a5..2092516cb7d9586f470cf959f96100d3380fa208
100644
--- a/Documentation/GNUmakefile
+++ b/Documentation/GNUmakefile
@@ -280,8 +280,7 @@ $(outdir)/ly-grammar.txt: $(top-src-dir)/lily/parser.yy
# compilation during install, which is a bad thing (tm).
$(outdir)/internals.texi: $(LILYPOND_BINARY)
- cd $(outdir) && $(LILYPOND_BINARY) --verbose
$(top-src-dir)/ly/generate-documentation
-
+ cd $(outdir) && $(buildscript-dir)/run-and-check "$(LILYPOND_BINARY)
--verbose $(top-src-dir)/ly/generate-documentation" "$(*F).log"
###
# Documentation and translations maintenance #
Index: GNUmakefile.in
diff --git a/GNUmakefile.in b/GNUmakefile.in
index
2d22f9f378202c703591eb6d7c0c50a3b89d290e..0ad3c6e30b409ecd6647e2ff91392399cf196d39
100644
--- a/GNUmakefile.in
+++ b/GNUmakefile.in
@@ -120,10 +120,6 @@ WEB_TARGETS = offline
WEB_ROOT_FILES = $(WEB_TARGETS:%=$(outdir)/%-root/index.html)
-WEB_EXAMPLE_FILES = $(wildcard input/$(outdir)/*.ly) \
-$(wildcard input/*/$(outdir)/*.ly) \
-$(wildcard input/*/*/$(outdir)/*.ly)
-
WEB_TRACKED_FILES = $(filter-out $(outdir)/index.html, \
$(shell bash -O nullglob -c "echo
$(outdir)/*.{midi,html,pdf,png,jpg,jpeg,txt,ly,ily,signature,css,zip,js,idx,php}"))
\
$(shell bash -O nullglob -c "echo
input/$(outdir)/*.{midi,html,pdf,png,jpg,jpeg,txt,ly,ily,signature,css,zip,js,idx,php}")
\
Index: make/lilypond-book-rules.make
diff --git a/make/lilypond-book-rules.make b/make/lilypond-book-rules.make
index
b0cf7663b158b43c687b6749c9b0988c1bd9c223..946e5a4759c61887101adf4bb8b7a6815b4b0611
100644
--- a/make/lilypond-book-rules.make
+++ b/make/lilypond-book-rules.make
@@ -26,7 +26,7 @@ $(outdir)/%.tex: %.latex
# Add the tex => pdf rule only if we have pdflatex
ifeq (,$(findstring pdflatex,$(MISSING_OPTIONAL)))
$(outdir)/%.pdf: $(outdir)/%.tex
- cd $(outdir) && $(PDFLATEX) $(notdir $<)
+ cd $(outdir) && $(buildscript-dir)/run-and-check "$(PDFLATEX)
-halt-on-error $(notdir $<)" "$*.pdflatex.log"
endif
## Texinfo ##
Index: make/lysdoc-rules.make
diff --git a/make/lysdoc-rules.make b/make/lysdoc-rules.make
index
001148aec2bd8ef09f83f8dd507e27fb976b66bb..11248f503083bec6336ad8a1a6b2b69416a0c598
100644
--- a/make/lysdoc-rules.make
+++ b/make/lysdoc-rules.make
@@ -3,7 +3,6 @@
# Split it up into 10 300-element chunks, and one chunk containing the rest
# if we have more than 3000 elements.
$(outdir)/collated-files.list: $(COLLATED_FILES)
- echo "(Re-)Generating $@"
@echo $(wordlist1, 299,$^)>$@
@echo $(wordlist 300, 599,$^)>>$@
@echo $(wordlist 600, 899,$^)>>$@
Index: scripts/abc2ly.py
diff --git a/scripts/abc2ly.py b/scripts/abc2ly.py
index
3a0aeaedabe7776a610acbc087b358a80bab3e90..3d508d2a58ad50f6a21f722ef253f05640dde969
100644
--- a/scripts/abc2ly.py
+++ b/scripts/abc2ly.py
@@ -1415,7 +1415,6 @@ for f in files:
if not global_options.output:
global_options.output = os.path.basename (os.path.splitext (f)[0])
+ ".ly"
-sys.stderr.write ('lilypond output to: `%s\'...' %
global_options.output)
outf = open (global_options.output, 'w')
# don't substitute @VERSION@. We want this to reflect
Index: scripts/build/lys-to-tely.py
diff --git a/scripts/build/lys-to-tely.py b/scripts/build/lys-to-tely.py
index
a3bc4b576bdc8e08f4bc9ff0f9e2dbbe42147c53..7a8684f1949b9cf50849ea65dcc2436d030319f7
100644
--- a/scripts/build/lys-to-tely.py
+++ b/scripts/build/lys-to-tely.py
@@ -163,11 +163,9 @@ if files:
s = "\n".join (map (name2line, files))
s = template.replace (include_snippets, s, 1)
f = "%s/%s" % (dir, name)
-sys.stderr.write ("%s: writing %s..." % (program_name, f))
h = open (f, "w")
h.write (s)
h.close ()
-sys.stderr.write ('\n')
else:
# not Unix philosophy, but hey, at least we notice when
# we don't distribute any .ly files.
Index: scripts/midi2ly.py
di
