Re: [regression] TCP_MD5SIG on established sockets
From: Eric Dumazet Date: Tue, 30 Jun 2020 13:39:27 -0700 > The (C) & (B) case are certainly doable. > > A) case is more complex, I have no idea of breakages of various TCP > stacks if a flow got SACK > at some point (in 3WHS) but suddenly becomes Reno. I agree that C and B are the easiest to implement without having to add complicated code to handle various negotiated TCP option scenerios. It does seem to be that some entities do A, or did I misread your behavioral analysis of various implementations Mathieu? Thanks.
Re: [PATCH][next] net/mlx5e: fix memory leak of tls
From: Colin King
Date: Tue, 30 Jun 2020 16:16:46 +0100
> From: Colin Ian King
>
> The error return path when create_singlethread_workqueue fails currently
> does not kfree tls and leads to a memory leak. Fix this by kfree'ing
> tls before returning -ENOMEM.
>
> Addresses-Coverity: ("Resource leak")
> Fixes: 1182f3659357 ("net/mlx5e: kTLS, Add kTLS RX HW offload support")
> Signed-off-by: Colin Ian King
Applied, thanks.
Re: [PATCH][next] net/tls: fix sign extension issue when left shifting u16 value
From: Colin King
Date: Tue, 30 Jun 2020 15:27:46 +0100
> From: Colin Ian King
>
> Left shifting the u16 value promotes it to a int and then it
> gets sign extended to a u64. If len << 16 is greater than 0x7fff
> then the upper bits get set to 1 because of the implicit sign extension.
> Fix this by casting len to u64 before shifting it.
>
> Addresses-Coverity: ("integer handling issues")
> Fixes: ed9b7646b06a ("net/tls: Add asynchronous resync")
> Signed-off-by: Colin Ian King
Applied, thanks Colin.
Re: [regression] TCP_MD5SIG on established sockets
From: Linus Torvalds Date: Tue, 30 Jun 2020 12:43:21 -0700 > If you're not willing to do the work to fix it, I will revert that > commit. Please let me handle this situation instead of making threats, this just got reported. Thank you.
Re: [PATCH net v2 0/3] net: ipa: three bug fixes
From: Alex Elder Date: Tue, 30 Jun 2020 07:44:41 -0500 > This series contains three bug fixes for the Qualcomm IPA driver. > In practice these bugs are unlikke.y to be harmful, but they do > represent incorrect code. > > Version 2 adds "Fixes" tags to two of the patches and fixes a typo > in one (found by checkpatch.pl). Series applied and queued up for v5.7 -stable, thanks.
Re: [PATCH net-next] net: dsa: Improve subordinate PHY error message
From: Florian Fainelli Date: Mon, 29 Jun 2020 21:43:13 -0700 > It is not very informative to know the DSA master device when a > subordinate network device fails to get its PHY setup. Provide the > device name and capitalize PHY while we are it. > > Signed-off-by: Florian Fainelli Applied, thanks.
Re: [PATCH net-next] hinic: remove unused but set variable
From: Luo bin Date: Tue, 30 Jun 2020 10:30:34 +0800 > remove unused but set variable to avoid auto build test WARNING > > Signed-off-by: Luo bin > Reported-by: kernel test robot Applied, thanks.
Re: [PATCH net-next 1/5] net: ipa: head-of-line block registers are RX only
From: Alex Elder Date: Mon, 29 Jun 2020 20:09:58 -0500 > But the reason I was > considering it conditional on a config option is that Qualcomm > has a crash analysis tool that expects a BUG() call to stop the > system so its instant state can be captured. I don't use this > tool, and I might be mistaken about what's required. A Qualcomm debugging tool with poorly choosen expectations does not determine how we do things in the kernel. > What I would *really* like to do is have a way to gracefully > shut down just the IPA driver when an unexpected condition occurs, > so I can stop everything without crashing the system. But doing > that in a way that works in all cases is Hard. Users would like their system and the IPA device to continue, even if in a reduced functionality manner, if possible. Doing things to make that less likely to be possible is undesirable.
Re: [PATCH net-next 1/5] net: ipa: head-of-line block registers are RX only
From: Alex Elder
Date: Mon, 29 Jun 2020 20:01:20 -0500
> On 6/29/20 7:35 PM, Jakub Kicinski wrote:
>> On Mon, 29 Jun 2020 16:49:15 -0500 Alex Elder wrote:
>>> The INIT_HOL_BLOCK_EN and INIT_HOL_BLOCK_TIMER endpoint registers
>>> are only valid for RX endpoints.
>>>
>>> Have ipa_endpoint_modem_hol_block_clear_all() skip writing these
>>> registers for TX endpoints.
>>>
>>> Signed-off-by: Alex Elder
>>> ---
>>> drivers/net/ipa/ipa_endpoint.c | 6 +-
>>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c
>>> index 9f50d0d11704..3f5a41fc1997 100644
>>> --- a/drivers/net/ipa/ipa_endpoint.c
>>> +++ b/drivers/net/ipa/ipa_endpoint.c
>>> @@ -642,6 +642,8 @@ static int ipa_endpoint_init_hol_block_timer(struct
>>> ipa_endpoint *endpoint,
>>> u32 offset;
>>> u32 val;
>>>
>>> + /* assert(!endpoint->toward_ipa); */
>>> +
>>> /* XXX We'll fix this when the register definition is clear */
>>> if (microseconds) {
>>> struct device *dev = >pdev->dev;
>>> @@ -671,6 +673,8 @@ ipa_endpoint_init_hol_block_enable(struct ipa_endpoint
>>> *endpoint, bool enable)
>>> u32 offset;
>>> u32 val;
>>>
>>> + /* assert(!endpoint->toward_ipa); */
>>
>> What are these assert comments for? :S
>
> They are place holders for when I can put in a proper assert
> function. For now I'm trying to avoid BUG_ON() calls, but
> at some point soon I'll replace these comments with calls
> to a macro that does BUG_ON() conditioned on a config option
> (or something else if there's a better suggestion).
>
> Even though it's commented, the assert() call does what
> I want, which is to communicate to the reader a condition
> assumed by the code, succinctly.
Never BUG_ON() unless you absolutely cannot continue executing kernel
without corrupting memory or similar.
If you can error out in some way at all, do not BUG().
Re: [v2,net-next] net:qos: police action offloading parameter 'burst' change to the original value
From: Po Liu Date: Mon, 29 Jun 2020 14:54:16 +0800 > Since 'tcfp_burst' with TICK factor, driver side always need to recover > it to the original value, this patch moves the generic calculation and > recover to the 'burst' original value before offloading to device driver. > > Signed-off-by: Po Liu > Acked-by: Vladimir Oltean Applied, thank you.
Re: [PATCH net-next 0/6] net: ethernet: ti: am65-cpsw: update and enable sr2.0 soc
From: Grygorii Strashko Date: Fri, 26 Jun 2020 21:17:03 +0300 > This series contains set of improvements for TI AM654x/J721E CPSW2G driver and > adds support for TI AM654x SR2.0 SoC. > > Patch 1: adds vlans restoration after "if down/up" > Patches 2-5: improvments > Patch 6: adds support for TI AM654x SR2.0 SoC which allows to disable errata > i2027 W/A. > By default, errata i2027 W/A (TX csum offload disabled) is enabled on AM654x > SoC > for backward compatibility, unless SR2.0 SoC is identified using SOC BUS > framework. Series applied to net-next, thank you.
Re: [PATCH 00/15] always use netdev_tx_t for xmit()'s return type
From: Luc Van Oostenryck Date: Sun, 28 Jun 2020 21:53:22 +0200 > The ndo_start_xmit() methods should return a 'netdev_tx_t', not > an int, and so should return NETDEV_TX_OK, not 0. > The patches in the series fix most of the remaning drivers and > subsystems (those included in allyesconfig on x86). Series applied, thanks.
Re: [PATCH net-next] sctp: use list_is_singular in sctp_list_single_entry
From: Geliang Tang Date: Sun, 28 Jun 2020 17:32:25 +0800 > Use list_is_singular() instead of open-coding. > > Signed-off-by: Geliang Tang Applied, thanks.
Re: [PATCH net-next] liquidio: use list_empty_careful in lio_list_delete_head
From: Geliang Tang Date: Sun, 28 Jun 2020 18:14:13 +0800 > Use list_empty_careful() instead of open-coding. > > Signed-off-by: Geliang Tang Also applied, thank you.
Re: [PATCH net] lib: packing: add documentation for pbuflen argument
From: Vladimir Oltean
Date: Sun, 28 Jun 2020 17:49:35 +0300
> Fixes sparse warning:
>
> Function parameter or member 'pbuflen' not described in 'packing'
>
> Fixes: 554aae35007e ("lib: Add support for generic packing operations")
> Signed-off-by: Vladimir Oltean
> ---
> Hi David, since the original "packing" submission went in through your
> tree, could you please take this patch as well?
Sure, applied, thank you.
Re: [PATCH net] bridge: mrp: Fix endian conversion and some other warnings
From: Horatiu Vultur
Date: Sun, 28 Jun 2020 15:45:16 +0200
> The following sparse warnings are fixed:
> net/bridge/br_mrp.c:106:18: warning: incorrect type in assignment (different
> base types)
> net/bridge/br_mrp.c:106:18:expected unsigned short [usertype]
> net/bridge/br_mrp.c:106:18:got restricted __be16 [usertype]
> net/bridge/br_mrp.c:281:23: warning: incorrect type in argument 1 (different
> modifiers)
> net/bridge/br_mrp.c:281:23:expected struct list_head *entry
> net/bridge/br_mrp.c:281:23:got struct list_head [noderef] *
> net/bridge/br_mrp.c:332:28: warning: incorrect type in argument 1 (different
> modifiers)
> net/bridge/br_mrp.c:332:28:expected struct list_head *new
> net/bridge/br_mrp.c:332:28:got struct list_head [noderef] *
> net/bridge/br_mrp.c:332:40: warning: incorrect type in argument 2 (different
> modifiers)
> net/bridge/br_mrp.c:332:40:expected struct list_head *head
> net/bridge/br_mrp.c:332:40:got struct list_head [noderef] *
> net/bridge/br_mrp.c:682:29: warning: incorrect type in argument 1 (different
> modifiers)
> net/bridge/br_mrp.c:682:29:expected struct list_head const *head
> net/bridge/br_mrp.c:682:29:got struct list_head [noderef] *
>
> Reported-by: kernel test robot
> Fixes: 2f1a11ae11d222 ("bridge: mrp: Add MRP interface.")
> Fixes: 4b8d7d4c599182 ("bridge: mrp: Extend bridge interface")
> Fixes: 9a9f26e8f7ea30 ("bridge: mrp: Connect MRP API with the switchdev API")
> Signed-off-by: Horatiu Vultur
Applied, thank you.
Re: [PATCH net-next v4 0/5] hinic: add some ethtool ops support
From: Luo bin Date: Sun, 28 Jun 2020 20:36:19 +0800 > patch #1: support to set and get pause params with > "ethtool -A/a" cmd > patch #2: support to set and get irq coalesce params with > "ethtool -C/c" cmd > patch #3: support to do self test with "ethtool -t" cmd > patch #4: support to identify physical device with "ethtool -p" cmd > patch #5: support to get eeprom information with "ethtool -m" cmd Series applied, thank you.
Re: [PATCH] net: ipv4: Fix wrong type conversion from hint to rt in ip_route_use_hint()
From: linmiaohe
Date: Sat, 27 Jun 2020 15:47:51 +0800
> From: Miaohe Lin
>
> We can't cast sk_buff to rtable by (struct rtable *)hint. Use skb_rtable().
>
> Fixes: 02b24941619f ("ipv4: use dst hint for ipv4 list receive")
>
> Signed-off-by: Miaohe Lin
Please do not put empty lines between Fixes: and other tags. All of the
tags belong together in a continuous uninterrupted sequence.
Applied and queued up for -stable, thank you.
Re: [PATCH net-next v3 0/5] hinic: add some ethtool ops support
From: Luo bin Date: Sat, 27 Jun 2020 14:52:37 +0800 > patch #1: support to set and get pause params with > "ethtool -A/a" cmd > patch #2: support to set and get irq coalesce params with > "ethtool -C/c" cmd > patch #3: support to do self test with "ethtool -t" cmd > patch #4: support to identify physical device with "ethtool -p" cmd > patch #5: support to get eeprom information with "ethtool -m" cmd In general, I want you to decrease the amount of log messages. You should only use them when the device or the kernel does something unexpected which should be notifier to the user. Kernel log messages are not for informating the user of limitations of what they can perform with "ethtool". For example, when setting pause paramenters, you complain in the logs if the autonet setting is different. This is completely inappropriate. Then in patch #2 you have these crazy macros that print out state changes with netdev_info(). That is also inappropriate. The user gets a success status, and they can query the settings later if they like as well. Please stop abusing kernel log messaging, it isn't a framework for giving more detailed ethtool command result statuses. Thank you.
Re: [PATCH 0/2] sparc32: srmmu: improve type safety of __nocache_fix()
From: Mike Rapoport Date: Fri, 26 Jun 2020 21:17:13 +0300 > Any comments on this? Sorry I didn't see this in my patchwork queue, could you please just resubmit it to sparcli...@vger.kernel.org Thank you.
Re: [PATCH 0/6] net: phy: relax PHY and MDIO reset handling
From: Bartosz Golaszewski Date: Fri, 26 Jun 2020 17:53:19 +0200 > From: Bartosz Golaszewski > > Previously these patches were submitted as part of a larger series[1] > but since the approach in it will have to be reworked I'm resending > the ones that were non-controversial and have been reviewed for upstream. > > Florian suggested a better solution for managing multiple resets. While > I will definitely try to implement something at the driver model's bus > level (together with regulator support), the 'resets' and 'reset-gpios' > DT property is a stable ABI defined in mdio.yaml so improving its support > is in order as we'll have to stick with it anyway. Current implementation > contains an unnecessary limitation where drivers without probe() can't > define resets. > > Changes from the previous version: > - order forward declarations in patch 4 alphabetically > - collect review tags > > [1] https://lkml.org/lkml/2020/6/22/253 Series applied, thank you.
Re: [PATCH 1/2] net: stmmac: change Kconfig menu entry to STMMAC/DWMAC
From: Johan Jonker Date: Fri, 26 Jun 2020 14:05:26 +0200 > When a Rockchip user wants to enable support for > the ethernet controller one has to search for > something with STMicroelectronics. > Change the Kconfig menu entry to STMMAC/DWMAC, > so that it better reflects the options it enables. > > Signed-off-by: Johan Jonker I'm not OK with this. It's called internally stmmac beause it's based upon an ST Microelectronics chipset. This is what happens when we have several sub drivers based upon a top-level common chipset "library". The problem you have is that just knowing the driver doesn't tell you the dependencies, but that's a larger scope generic problem that needs a high level solution rather then something we should be hacking around with name adjustments here and there.
Re: [PATCH net-next v3 0/2] bridge: mrp: Extend MRP netlink interface with IFLA_BRIDGE_MRP_CLEAR
From: Horatiu Vultur Date: Fri, 26 Jun 2020 09:33:47 +0200 > This patch series extends MRP netlink interface with IFLA_BRIDGE_MRP_CLEAR. > To allow the userspace to clear all MRP instances when is started. The > second patch in the series fix different sparse warnings. > > v3: > - add the second patch to fix sparse warnings These changes are completely unrelated. The sparse stuff should probably be submitted to 'net'. And I have to ask why you really need a clear operation. Routing daemons come up and see what routes are installed, and update their internal SW tables to match. This not only allows efficient restart after a crash, but it also allows multiple daemons to work cooperatively as an agent for the same forwarding/routing table. Your usage model limits one daemon to manage the table and that limitation is completely unnecessary. Furthermore, even in a one-daemon scenerio, it's wasteful to throw away all the work the previous daemon did to load the MRP entries into the bridge. Thanks.
Re: [PATCH net-next] bonding: Remove extraneous parentheses in bond_setup
From: Nathan Chancellor
Date: Thu, 25 Jun 2020 21:10:02 -0700
> Clang warns:
>
> drivers/net/bonding/bond_main.c:4657:23: warning: equality comparison
> with extraneous parentheses [-Wparentheses-equality]
> if ((BOND_MODE(bond) == BOND_MODE_ACTIVEBACKUP))
> ^
>
> drivers/net/bonding/bond_main.c:4681:23: warning: equality comparison
> with extraneous parentheses [-Wparentheses-equality]
> if ((BOND_MODE(bond) == BOND_MODE_ACTIVEBACKUP))
> ^
>
> This warning occurs when a comparision has two sets of parentheses,
> which is usually the convention for doing an assignment within an
> if statement. Since equality comparisons do not need a second set of
> parentheses, remove them to fix the warning.
>
> Fixes: 18cb261afd7b ("bonding: support hardware encryption offload to slaves")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1066
> Signed-off-by: Nathan Chancellor
Applied, thank you.
Re: [PATCH] net: stmmac: dwmac-meson8b: use clk_parent_data for clock registration
From: Martin Blumenstingl Date: Thu, 25 Jun 2020 20:21:42 +0200 > Simplify meson8b_init_rgmii_tx_clk() by using struct clk_parent_data to > initialize the clock parents. No functional changes intended. > > Signed-off-by: Martin Blumenstingl Applied to net-next, thank you.
Re: [PATCH v1] bnx2x: use generic power management
From: Vaibhav Gupta Date: Wed, 24 Jun 2020 23:21:17 +0530 > With legacy PM, drivers themselves were responsible for managing the > device's power states and takes care of register states. > > After upgrading to the generic structure, PCI core will take care of > required tasks and drivers should do only device-specific operations. > > The driver was also calling bnx2x_set_power_state() to set the power state > of the device by changing the device's registers' value. It is no more > needed. > > Compile-tested only. > > Signed-off-by: Vaibhav Gupta Applied, thanks.
Re: [Patch v4 3/3] net: Restrict receive packets queuing to housekeeping CPUs
From: Peter Zijlstra Date: Fri, 26 Jun 2020 13:14:01 +0200 > On Thu, Jun 25, 2020 at 06:34:43PM -0400, Nitesh Narayan Lal wrote: >> From: Alex Belits >> >> With the existing implementation of store_rps_map(), packets are queued >> in the receive path on the backlog queues of other CPUs irrespective of >> whether they are isolated or not. This could add a latency overhead to >> any RT workload that is running on the same CPU. >> >> Ensure that store_rps_map() only uses available housekeeping CPUs for >> storing the rps_map. >> >> Signed-off-by: Alex Belits >> Signed-off-by: Nitesh Narayan Lal > > Dave, ACK if I route this? No problem: Acked-by: David S. Miller
[GIT] Networking
1) Don't insert ESP trailer twice in IPSEC code, from Huy Nguyen.
2) The default crypto algorithm selection in Kconfig for IPSEC is
out of touch with modern reality, fix this up. From Eric Biggers.
3) bpftool is missing an entry for BPF_MAP_TYPE_RINGBUF, from Andrii
Nakryiko.
4) Missing init of ->frame_sz in xdp_convert_zc_to_xdp_frame(), from
Hangbin Liu.
5) Adjust packet alignment handling in ax88179_178a driver to match
what the hardware actually does. From Jeremy Kerr.
6) register_netdevice can leak in the case one of the notifiers fail,
from Yang Yingliang.
7) Use after free in ip_tunnel_lookup(), from Taehee Yoo.
8) VLAN checks in sja1105 DSA driver need adjustments, from Vladimir
Oltean.
9) tg3 driver can sleep forever when we get enough EEH errors, fix
from David Christensen.
10) Missing {READ,WRITE}_ONCE() annotations in various Intel ethernet
drivers, from Ciara Loftus.
11) Fix scanning loop break condition in of_mdiobus_register(), from
Florian Fainelli.
12) MTU limit is incorrect in ibmveth driver, from Thomas Falcon.
13) Endianness fix in mlxsw, from Ido Schimmel.
14) Use after free in smsc95xx usbnet driver, from Tuomas Tynkkynen.
15) Missing bridge mrp configuration validation, from Horatiu Vultur.
16) Fix circular netns references in wireguard, from Jason A. Donenfeld.
17) PTP initialization on recovery is not done properly in qed driver,
from Alexander Lobakin.
18) Endian conversion of L4 ports in filters of cxgb4 driver is wrong,
from Rahul Lakkireddy.
19) Don't clear bound device TX queue of socket prematurely otherwise
we get problems with ktls hw offloading, from Tariq Toukan.
20) ipset can do atomics on unaligned memory, fix from Russell King.
21) Align ethernet addresses properly in bridging code, from Thomas
Martitz.
22) Don't advertise ipv4 addresses on SCTP sockets having ipv6only
set, from Marcelo Ricardo Leitner.
Please pull, thanks a lot!
The following changes since commit 69119673bd50b176ded34032fadd41530fb5af21:
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net (2020-06-16
17:44:54 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
for you to fetch changes up to 4c342f778fe234e0c2a2601d87fec8ba42f0d2c6:
rds: transport module should be auto loaded when transport is set (2020-06-25
16:26:25 -0700)
Aiden Leong (1):
GUE: Fix a typo
Alexander Lobakin (11):
net: ethtool: add missing NETIF_F_GSO_FRAGLIST feature string
net: ethtool: add missing string for NETIF_F_GSO_TUNNEL_REMCSUM
net: qed: fix left elements count calculation
net: qed: fix async event callbacks unregistering
net: qede: stop adding events on an already destroyed workqueue
net: qed: fix NVMe login fails over VFs
net: qed: fix excessive QM ILT lines consumption
net: qede: fix PTP initialization on recovery
net: qede: fix use-after-free on recovery and AER handling
net: qed: reset ILT block sizes before recomputing to fix crashes
net: qed: fix "maybe uninitialized" warning
Andrew Lunn (1):
net: ethtool: Handle missing cable test TDR parameters
Andrii Nakryiko (3):
bpf: Fix definition of bpf_ringbuf_output() helper in UAPI comments
tools/bpftool: Add ringbuf map to a list of known map types
bpf: bpf_probe_read_kernel_str() has to return amount of data read on
success
Ard Biesheuvel (1):
net: phy: mscc: avoid skcipher API for single block AES encryption
Björn Töpel (1):
i40e: fix crash when Rx descriptor count is changed
Briana Oursler (1):
tc-testing: avoid action cookies with odd length.
Ciara Loftus (3):
ixgbe: protect ring accesses with READ- and WRITE_ONCE
i40e: protect ring accesses with READ- and WRITE_ONCE
ice: protect ring accesses with WRITE_ONCE
Claudiu Beznea (3):
net: macb: undo operations in case of failure
net: macb: call pm_runtime_put_sync on failure path
net: macb: free resources on failure path of at91ether_open()
Claudiu Manoil (1):
enetc: Fix HW_VLAN_CTAG_TX|RX toggling
Colin Ian King (1):
qed: add missing error test for DBG_STATUS_NO_MATCHING_FRAMING_MODE
Daniel Mack (1):
dsa: Allow forwarding of redirected IGMP traffic
Dany Madden (1):
ibmvnic: continue to init in CRQ reset returns H_CLOSED
David Christensen (1):
tg3: driver sleeps indefinitely when EEH errors exceed eeh_max_freezes
David Howells (4):
rxrpc: Fix trace string
rxrpc: Fix handling of rwind from an ACK packet
rxrpc: Fix afs large storage transmission performance drop
rxrpc: Fix notification call on completion of discarded calls
David S. Miller (24):
Merge git://git.kernel.org/.../bpf/bpf
Merge branch 'act_gate-fixes'
Merge branch 'sja1105-fixes'
Merge branch
Re: [PATCH net-next 0/8] net: phy: mscc: multiple improvements
From: Antoine Tenart Date: Thu, 25 Jun 2020 17:42:03 +0200 > This series contains various improvements to the MSCC PHY driver, fixing > sparse and smatch warnings, using functions provided by the PHY core, > and improving the driver consistency and maintenance. > > I don't think any of those improvements and fixes is worth backporting > to stable trees. Series applied, thanks.
Re: [PATCH net] sctp: Don't advertise IPv4 addresses if ipv6only is set on the socket
From: Marcelo Ricardo Leitner
Date: Wed, 24 Jun 2020 17:34:18 -0300
> If a socket is set ipv6only, it will still send IPv4 addresses in the
> INIT and INIT_ACK packets. This potentially misleads the peer into using
> them, which then would cause association termination.
>
> The fix is to not add IPv4 addresses to ipv6only sockets.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Reported-by: Corey Minyard
> Signed-off-by: Marcelo Ricardo Leitner
Applied and queued up for -stable, thank you.
Re: [PATCH net-next v11 0/5] RGMII Internal delay common property
From: Dan Murphy Date: Wed, 24 Jun 2020 07:16:00 -0500 > The RGMII internal delay is a common setting found in most RGMII capable PHY > devices. It was found that many vendor specific device tree properties exist > to do the same function. This creates a common property to be used for PHY's > that have internal delays for the Rx and Tx paths. > > If the internal delay is tunable then the caller needs to pass the internal > delay array and the return will be the index in the array that was found in > the firmware node. > > If the internal delay is fixed then the caller only needs to indicate which > delay to return. There is no need for a fixed delay to add device properties > since the value is not configurable. Per the ethernet-controller.yaml the > interface type indicates that the PHY should provide the delay. > > This series contains examples of both a configurable delay and a fixed delay. Series applied, thank you.
Re: [PATCH v2 1/2] net: macb: call pm_runtime_put_sync on failure path
From: Claudiu Beznea
Date: Wed, 24 Jun 2020 13:08:17 +0300
> Call pm_runtime_put_sync() on failure path of at91ether_open.
>
> Fixes: e6a41c23df0d ("net: macb: ensure interface is not suspended on
> at91rm9200")
> Signed-off-by: Claudiu Beznea
Applied and queued up for -stable.
Re: [PATCH v2 2/2] net: macb: free resources on failure path of at91ether_open()
From: Claudiu Beznea
Date: Wed, 24 Jun 2020 13:08:18 +0300
> DMA buffers were not freed on failure path of at91ether_open().
> Along with changes for freeing the DMA buffers the enable/disable
> interrupt instructions were moved to at91ether_start()/at91ether_stop()
> functions and the operations on at91ether_stop() were done in
> their reverse order (compared with how is done in at91ether_start()):
> before this patch the operation order on interface open path
> was as follows:
> 1/ alloc DMA buffers
> 2/ enable tx, rx
> 3/ enable interrupts
> and the order on interface close path was as follows:
> 1/ disable tx, rx
> 2/ disable interrupts
> 3/ free dma buffers.
>
> Fixes: 7897b071ac3b ("net: macb: convert to phylink")
> Signed-off-by: Claudiu Beznea
Also applied and queued up for -stable.
Please submit a proper header posting "[PATCH 0/N] " in the future
when you submit a patch series. Thank you.
Re: [PATCH][V2] qed: add missing error test for DBG_STATUS_NO_MATCHING_FRAMING_MODE
From: Colin King
Date: Thu, 25 Jun 2020 17:45:05 +0100
> From: Colin Ian King
>
> The error DBG_STATUS_NO_MATCHING_FRAMING_MODE was added to the enum
> enum dbg_status however there is a missing corresponding entry for
> this in the array s_status_str. This causes an out-of-bounds read when
> indexing into the last entry of s_status_str. Fix this by adding in
> the missing entry.
>
> Addresses-Coverity: ("Out-of-bounds read").
> Fixes: 2d22bc8354b1 ("qed: FW 8.42.2.0 debug features")
> Signed-off-by: Colin Ian King
> ---
>
> V2: use the error message as suggested by Igor Russkikh
I already applied your V1 so this patch no longer applies.
Re: [PATCH v1] ptp_pch: use generic power management
From: Vaibhav Gupta Date: Thu, 25 Jun 2020 17:40:43 +0530 > With legacy PM, drivers themselves were responsible for managing the > device's power states and takes care of register states. > > After upgrading to the generic structure, PCI core will take care of > required tasks and drivers should do only device-specific operations. > > In the case of ptp_pch, after removing PCI helper functions, .suspend() > and .resume() became empty-body functions. Hence, define them NULL and > use dev_pm_ops. > > Compile-tested only. > > Signed-off-by: Vaibhav Gupta A straight-forward transformation, looks good, applied to net-next thanks.
Re: [v2,net-next 2/4] net: enetc: add support max frame size for tc flower offload
From: Po Liu Date: Wed, 24 Jun 2020 17:36:29 +0800 > From: Po Liu > > Base on the tc flower offload police action add max frame size by the > parameter 'mtu'. Tc flower device driver working by the IEEE 802.1Qci > stream filter can implement the max frame size filtering. Add it to the > current hardware tc flower stearm filter driver. > > Signed-off-by: Po Liu Applied.
Re: [v2,net-next 1/4] net: qos: add tc police offloading action with max frame size limit
From: Po Liu Date: Wed, 24 Jun 2020 17:36:28 +0800 > From: Po Liu > > Current police offloading support the 'burst'' and 'rate_bytes_ps'. Some > hardware own the capability to limit the frame size. If the frame size > larger than the setting, the frame would be dropped. For the police > action itself already accept the 'mtu' parameter in tc command. But not > extend to tc flower offloading. So extend 'mtu' to tc flower offloading. > > Signed-off-by: Po Liu Applied.
Re: [v2,net-next 4/4] net: enetc add tc flower offload flow metering policing action
From: Po Liu Date: Wed, 24 Jun 2020 17:36:31 +0800 > From: Po Liu > > Flow metering entries in IEEE 802.1Qci is an optional function for a > flow filtering module. Flow metering is two rates two buckets and three > color marker to policing the frames. This patch only enable one rate one > bucket and in color blind mode. Flow metering instance are as > specified in the algorithm in MEF 10.3 and in Bandwidth Profile > Parameters. They are: > > a) Flow meter instance identifier. An integer value identifying the flow > meter instance. The patch use the police 'index' as thin value. > b) Committed Information Rate (CIR), in bits per second. This patch use > the 'rate_bytes_ps' represent this value. > c) Committed Burst Size (CBS), in octets. This patch use the 'burst' > represent this value. > d) Excess Information Rate (EIR), in bits per second. > e) Excess Burst Size per Bandwidth Profile Flow (EBS), in octets. > And plus some other parameters. This patch set EIR/EBS default disable > and color blind mode. > > v1->v2 changes: > - Use div_u64() as division replace the '/' report: > > Reported-by: kernel test robot > All errors (new ones prefixed by >>): > >ld: drivers/net/ethernet/freescale/enetc/enetc_qos.o: in function > `enetc_flowmeter_hw_set': >>> enetc_qos.c:(.text+0x66): undefined reference to `__udivdi3' > > > Signed-off-by: Po Liu Applied.
Re: [v2,net-next 3/4] net: qos: police action add index for tc flower offloading
From: Po Liu Date: Wed, 24 Jun 2020 17:36:30 +0800 > From: Po Liu > > Hardware device may include more than one police entry. Specifying the > action's index make it possible for several tc filters to share the same > police action when installing the filters. > > Propagate this index to device drivers through the flow offload > intermediate representation, so that drivers could share a single > hardware policer between multiple filters. > > v1->v2 changes: > - Update the commit message suggest by Ido Schimmel > > Signed-off-by: Po Liu Applied.
Re: [PATCH net 0/3] net: bcmgenet: use hardware padding of runt frames
From: Doug Berger Date: Wed, 24 Jun 2020 18:14:52 -0700 > Now that scatter-gather and tx-checksumming are enabled by default > it revealed a packet corruption issue that can occur for very short > fragmented packets. > > When padding these frames to the minimum length it is possible for > the non-linear (fragment) data to be added to the end of the linear > header in an SKB. Since the number of fragments is read before the > padding and used afterward without reloading, the fragment that > should have been consumed can be tacked on in place of part of the > padding. > > The third commit in this set corrects this by removing the software > padding and allowing the hardware to add the pad bytes if necessary. > > The first two commits resolve warnings observed by the kbuild test > robot and are included here for simplicity of application. Series applied, thank you.
Re: [PATCH v3 0/2] net: phy: call phy_disable_interrupts() in phy_init_hw()
From: Florian Fainelli Date: Wed, 24 Jun 2020 15:10:51 -0700 > Did you mean that you applied v4? It does not look like you pushed your > local changes to net-next yet, so I cannot tell for sure. I ended up applying v4, yes.
Re: [PATCH] qed: add missing error test for DBG_STATUS_NO_MATCHING_FRAMING_MODE
From: Colin King
Date: Wed, 24 Jun 2020 11:13:02 +0100
> From: Colin Ian King
>
> The error DBG_STATUS_NO_MATCHING_FRAMING_MODE was added to the enum
> enum dbg_status however there is a missing corresponding entry for
> this in the array s_status_str. This causes an out-of-bounds read when
> indexing into the last entry of s_status_str. Fix this by adding in
> the missing entry.
>
> Addresses-Coverity: ("Out-of-bounds read").
> Fixes: 2d22bc8354b1 ("qed: FW 8.42.2.0 debug features")
> Signed-off-by: Colin Ian King
Applied, thank you.
Re: [PATCH 2/2] net: ethernet: mvneta: Add back interface mode validation
From: Sascha Hauer Date: Wed, 24 Jun 2020 09:00:45 +0200 > When writing the serdes configuration register was moved to > mvneta_config_interface() the whole code block was removed from > mvneta_port_power_up() in the assumption that its only purpose was to > write the serdes configuration register. As mentioned by Russell King > its purpose was also to check for valid interface modes early so that > later in the driver we do not have to care for unexpected interface > modes. > Add back the test to let the driver bail out early on unhandled > interface modes. > > Signed-off-by: Sascha Hauer Applied. Please submit a proper patch series next time, with a header [PATCH 0/N] posting. Thank you.
Re: [PATCH 1/2] net: ethernet: mvneta: Do not error out in non serdes modes
From: Sascha Hauer Date: Wed, 24 Jun 2020 09:00:44 +0200 > In mvneta_config_interface() the RGMII modes are catched by the default > case which is an error return. The RGMII modes are valid modes for the > driver, so instead of returning an error add a break statement to return > successfully. > > This avoids this warning for non comphy SoCs which use RGMII, like > SolidRun Clearfog: > > WARNING: CPU: 0 PID: 268 at drivers/net/ethernet/marvell/mvneta.c:3512 > mvneta_start_dev+0x220/0x23c > > Signed-off-by: Sascha Hauer Applied.
Re: [PATCH v3 0/2] net: phy: call phy_disable_interrupts() in phy_init_hw()
From: Jisheng Zhang Date: Wed, 24 Jun 2020 11:25:16 +0800 > We face an issue with rtl8211f, a pin is shared between INTB and PMEB, > and the PHY Register Accessible Interrupt is enabled by default, so > the INTB/PMEB pin is always active in polling mode case. > > As Heiner pointed out "I was thinking about calling > phy_disable_interrupts() in phy_init_hw(), to have a defined init > state as we don't know in which state the PHY is if the PHY driver is > loaded. We shouldn't assume that it's the chip power-on defaults, BIOS > or boot loader could have changed this. Or in case of dual-boot > systems the other OS could leave the PHY in whatever state." > > patch1 makes phy_disable_interrupts() non-static so that it could be used > in phy_init_hw() to have a defined init state. > > patch2 calls phy_disable_interrupts() in phy_init_hw() to have a > defined init state. > > Since v2: > - Don't export phy_disable_interrupts() but just make it non-static > > Since v1: > - EXPORT the correct symbol Series applied, thank you.
Re: [PATCH net-next v4 0/8] net: phy: mscc: PHC and timestamping support
From: Antoine Tenart Date: Tue, 23 Jun 2020 16:30:06 +0200 > This series aims at adding support for PHC and timestamping operations > in the MSCC PHY driver, for the VSC858x and VSC8575. Those PHYs are > capable of timestamping in 1-step and 2-step for both L2 and L4 traffic. ... Series applied to net-next, thank you.
Re: [PATCH v1 0/5] ethernet: dec: tulip: use generic power management
From: Vaibhav Gupta Date: Mon, 22 Jun 2020 17:12:23 +0530 > Linux Kernel Mentee: Remove Legacy Power Management. > > The purpose of this patch series is to remove legacy power management > callbacks and invocation of PCI helper functions, from tulip ethernet drivers. > > With legacy PM, drivers themselves are responsible for handling the device's > power states. And they do this with the help of PCI helper functions like > pci_enable/disable_device(), pci_set/restore_state(), pci_set_powr_state(), > etc. > which is not recommended. > > In generic PM, all the required tasks are handled by PCI core and drivers need > to perform device-specific operations only. > > All patches are compile-tested only. Series applied to net-next, thanks.
Re: [PATCH v2 0/3] ethernet: amd: Convert to generic power management
From: Vaibhav Gupta Date: Mon, 22 Jun 2020 16:43:57 +0530 > Linux Kernel Mentee: Remove Legacy Power Management. > > The purpose of this patch series is to remove legacy power management > callbacks > from amd ethernet drivers. > > The callbacks performing suspend() and resume() operations are still calling > pci_save_state(), pci_set_power_state(), etc. and handling the power > management > themselves, which is not recommended. > > The conversion requires the removal of the those function calls and change the > callback definition accordingly and make use of dev_pm_ops structure. > > All patches are compile-tested only. Series applied, thanks.
Re: [PATCH] [net] dcb_doit: remove redundant skb check
From: Gaurav Singh Date: Mon, 22 Jun 2020 22:50:39 -0400 > skb cannot be NULL here since its already being accessed > before: sock_net(skb->sk). Remove the redundant null check. > > Signed-off-by: Gaurav Singh Applied.
Re: [PATCH] [net/decnet] dn_route_rcv: remove redundant dev null check
From: Gaurav Singh Date: Mon, 22 Jun 2020 23:41:19 -0400 > dev cannot be NULL here since its already being accessed > before. Remove the redundant null check. > > Signed-off-by: Gaurav Singh Applied.
Re: [PATCH][next] net: ipv6: Use struct_size() helper and kcalloc()
From: "Gustavo A. R. Silva" Date: Mon, 22 Jun 2020 18:07:41 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. Also, remove unnecessary > function ipv6_rpl_srh_alloc_size() and replace kzalloc() with kcalloc(), > which has a 2-factor argument form for multiplication. > > This code was detected with the help of Coccinelle and, audited and > fixed manually. > > Signed-off-by: Gustavo A. R. Silva Applied.
Re: [PATCH] net: qrtr: free flow in __qrtr_node_release
From: Carl Huang Date: Tue, 23 Jun 2020 11:22:03 +0800 > @@ -168,6 +168,7 @@ static void __qrtr_node_release(struct kref *kref) > struct radix_tree_iter iter; > unsigned long flags; > void __rcu **slot; > + struct qrtr_tx_flow *flow; Please retain the reverse christmas tree ordering of local variables here. Thanks.
Re: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in enic_init_affinity_hint()
From: Kaige Li Date: Wed, 24 Jun 2020 10:07:16 +0800 > You are right. Should I do spin_unlock before the enic_open, or remove > spin_lock in enic_reset? You need to learn how this driver's locking works and design a correct adjustment.
Re: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in enic_init_affinity_hint()
From: Kaige Li Date: Wed, 24 Jun 2020 09:56:47 +0800 > > On 06/24/2020 06:26 AM, David Miller wrote: >> From: David Miller >> Date: Tue, 23 Jun 2020 14:33:11 -0700 (PDT) >> >>> Calling a NIC driver open function from a context holding a spinlock >>> is very much the real problem, so many operations have to sleep and >>> in face that ->ndo_open() method is defined as being allowed to sleep >>> and that's why the core networking never invokes it with spinlocks >> >> >> I mean "without" of course. :-) >> >>> held. > > Did you mean that open function should be out of spinlock? If so, I > will > send V2 patch. Yes, but only if that is safe. You have to analyze the locking done by this driver and fix it properly. I anticipate it is not just a matter of changing where the spinlock is held, you will have to rearchitect things a bit.
Re: [PATCH] [net/wan] cosa_init: check bounds before access
From: Gaurav Singh Date: Tue, 23 Jun 2020 21:04:49 -0400 > Check i < io bounds before accessing io[i]. > > Signed-off-by: Gaurav Singh The io[] array is intentionally zero terminated, there is no problem.
Re: [PATCH] [net/ethernet] do_reset: remove dev null check
From: Gaurav Singh Date: Tue, 23 Jun 2020 20:55:45 -0400 > dev cannot be NULL here since its already being accessed > before. Remove the redundant null check. > > Signed-off-by: Gaurav Singh I changed your Subject to be: [PATCH net-next] xirc2ps_cs: remove dev null check from do_reset(). Since that is more properly formed. Applied to net-next, thanks.
Re: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in enic_init_affinity_hint()
From: David Miller Date: Tue, 23 Jun 2020 14:33:11 -0700 (PDT) > Calling a NIC driver open function from a context holding a spinlock > is very much the real problem, so many operations have to sleep and > in face that ->ndo_open() method is defined as being allowed to sleep > and that's why the core networking never invokes it with spinlocks I mean "without" of course. :-) > held.
Re: [PATCH net-next] bonding/xfrm: use real_dev instead of slave_dev
From: Jarod Wilson Date: Tue, 23 Jun 2020 16:40:01 -0400 > Rather than requiring every hw crypto capable NIC driver to do a check for > slave_dev being set, set real_dev in the xfrm layer and xso init time, and > then override it in the bonding driver as needed. Then NIC drivers can > always use real_dev, and at the same time, we eliminate the use of a > variable name that probably shouldn't have been used in the first place, > particularly given recent current events. > > CC: Boris Pismenny > CC: Saeed Mahameed > CC: Leon Romanovsky > CC: Jay Vosburgh > CC: Veaceslav Falico > CC: Andy Gospodarek > CC: "David S. Miller" > CC: Jeff Kirsher > CC: Jakub Kicinski > CC: Steffen Klassert > CC: Herbert Xu > CC: net...@vger.kernel.org > Suggested-by: Saeed Mahameed > Signed-off-by: Jarod Wilson Yes this is much nicer. Applied, thank you.
Re: [PATCH v2 net-next 2/2] ipv6: fib6: avoid indirect calls from fib6_rule_lookup
From: Brian Vazquez Date: Tue, 23 Jun 2020 09:42:32 -0700 > It was reported that a considerable amount of cycles were spent on the > expensive indirect calls on fib6_rule_lookup. This patch introduces an > inline helper called pol_route_func that uses the indirect_call_wrappers > to avoid the indirect calls. > > This patch saves around 50ns per call. > > Performance was measured on the receiver by checking the amount of > syncookies that server was able to generate under a synflood load. > > Traffic was generated using trafgen[1] which was pushing around 1Mpps on > a single queue. Receiver was using only one rx queue which help to > create a bottle neck and make the experiment rx-bounded. > > These are the syncookies generated over 10s from the different runs: > > Whithout the patch: ... > With the patch: ... > Without the patch the average is 354263 pkt/s or 2822 ns/pkt and with > the patch the average is 360738 pkt/s or 2772 ns/pkt which gives an > estimate of 50 ns per packet. > > [1] http://netsniff-ng.org/ > > Changelog since v1: > - Change ordering in the ICW (Paolo Abeni) > > Cc: Luigi Rizzo > Cc: Paolo Abeni > Reported-by: Eric Dumazet > Signed-off-by: Brian Vazquez Applied.
Re: [PATCH v2 net-next 1/2] indirect_call_wrapper: extend indirect wrapper to support up to 4 calls
From: Brian Vazquez Date: Tue, 23 Jun 2020 09:42:31 -0700 > There are many places where 2 annotations are not enough. This patch > adds INDIRECT_CALL_3 and INDIRECT_CALL_4 to cover such cases. > > Signed-off-by: Brian Vazquez Applied.
Re: [PATCH net-next] mlxsw: spectrum_dcb: Fix a spelling typo in spectrum_dcb.c
From: Masanari Iida Date: Tue, 23 Jun 2020 23:13:01 +0900 > This patch fixes a spelling typo in spectrum_dcb.c > > Signed-off-by: Masanari Iida Applied, thank you.
Re: [PATCH net-next v10 2/5] net: phy: Add a helper to return the index for of the internal delay
From: Dan Murphy Date: Tue, 23 Jun 2020 08:48:33 -0500 > diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c > index 29ef4456ac25..96f242eed058 100644 > --- a/drivers/net/phy/phy_device.c > +++ b/drivers/net/phy/phy_device.c ... > +static inline int phy_get_int_delay_property(struct device *dev, > + const char *name) Please do not use inline in foo.c files, thank you.
Re: [PATCH v2 net 0/9] net: qed/qede: various stability fixes
From: Alexander Lobakin Date: Tue, 23 Jun 2020 16:51:28 +0300 > This set addresses several near-critical issues that were observed > and reproduced on different test and production configurations. > > v2: > - don't split the "Fixes:" tag across several lines in patch 9; > - no functional changes. Series applied, thank you.
Re: [PATCH v3 net] net: ethtool: add missing string for NETIF_F_GSO_TUNNEL_REMCSUM
From: Alexander Lobakin
Date: Tue, 23 Jun 2020 10:43:48 +
> Commit e585f2363637 ("udp: Changes to udp_offload to support remote
> checksum offload") added new GSO type and a corresponding netdev
> feature, but missed Ethtool's 'netdev_features_strings' table.
> Give it a name so it will be exposed to userspace and become available
> for manual configuration.
>
> v3:
> - decouple from "netdev_features_strings[] cleanup" series;
> - no functional changes.
>
> v2:
> - don't split the "Fixes:" tag across lines;
> - no functional changes.
>
> Fixes: e585f2363637 ("udp: Changes to udp_offload to support remote checksum
> offload")
> Signed-off-by: Alexander Lobakin
Applied and queued up for -stable, thanks.
Re: [PATCH net v2 0/2] bridge: mrp: Update MRP_PORT_ROLE
From: Horatiu Vultur Date: Tue, 23 Jun 2020 11:05:39 +0200 > This patch series does the following: > - fixes the enum br_mrp_port_role_type. It removes the port role none(0x2) > because this is in conflict with the standard. The standard defines the > interconnect port role as value 0x2. > - adds checks regarding current defined port roles: primary(0x0) and > secondary(0x1). > > v2: > - add the validation code when setting the port role. Series applied, thank you.
Re: [PATCH v4 3/8] sparc64: Fix asm/percpu.h build error
From: Peter Zijlstra Date: Tue, 23 Jun 2020 10:36:48 +0200 > In order to break a header dependency between lockdep and task_struct, > I need per-cpu stuff from lockdep. > > Signed-off-by: Peter Zijlstra (Intel) Acked-by: David S. Miller
Re: [PATCH v2 1/2] net: phy: export phy_disable_interrupts()
From: Jisheng Zhang Date: Tue, 23 Jun 2020 15:41:04 +0800 > +EXPORT_SYMBOL_GPL(phy_disable_interrupts); phy.o and phy_device.o are always linked together, therefore you don't need a module symbol export. If you plan to use it later in a device, submit the symbol export with the driver change that uses it.
Re: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in enic_init_affinity_hint()
From: Kaige Li Date: Tue, 23 Jun 2020 16:13:09 +0800 > The kernel module may sleep with holding a spinlock. > > The function call paths (from bottom to top) are: > > [FUNC] zalloc_cpumask_var(GFP_KERNEL) > drivers/net/ethernet/cisco/enic/enic_main.c, 125: zalloc_cpumask_var in > enic_init_affinity_hint > drivers/net/ethernet/cisco/enic/enic_main.c, 1918: enic_init_affinity_hint in > enic_open > drivers/net/ethernet/cisco/enic/enic_main.c, 2348: enic_open in enic_reset > drivers/net/ethernet/cisco/enic/enic_main.c, 2341: spin_lock in enic_reset > > To fix this bug, GFP_KERNEL is replaced with GFP_ATOMIC. > > Signed-off-by: Kaige Li Just grepping around for GFP_KERNEL usage in atomic contexts I guess is fine. But you really have to look at the bigger picture. Calling a NIC driver open function from a context holding a spinlock is very much the real problem, so many operations have to sleep and in face that ->ndo_open() method is defined as being allowed to sleep and that's why the core networking never invokes it with spinlocks held.
Re: [PATCH v2] GUE: Fix a typo
From: Aiden Leong Date: Mon, 22 Jun 2020 20:04:58 -0700 > Fix a typo in gue.h > > Signed-off-by: Aiden Leong Applied, thank you.
Re: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in enic_init_affinity_hint()
Networking changes must be submitted with net...@vger.kernel.org Thank you.
Re: [PATCH net v2] mptcp: drop sndr_key in mptcp_syn_options
From: Geliang Tang
Date: Mon, 22 Jun 2020 19:45:58 +0800
> In RFC 8684, we don't need to send sndr_key in SYN package anymore, so drop
> it.
>
> Fixes: cc7972ea1932 ("mptcp: parse and emit MP_CAPABLE option according to v1
> spec")
> Signed-off-by: Geliang Tang
Applied and queued up for v5.6+ -stable, thanks.
Re: [PATCH] [net/sched] tcindex_change: Remove redundant null check
From: Gaurav Singh Date: Sun, 21 Jun 2020 22:24:30 -0400 > arg cannot be NULL since its already being dereferenced > before. Remove the redundant NULL check. > > Signed-off-by: Gaurav Singh Applied, thank you.
Re: linux-next: build failure after merge of the kspp tree
From: Stephen Rothwell Date: Tue, 23 Jun 2020 13:51:34 +1000 > I have added the following merge fix patch. > > From: Stephen Rothwell > Date: Tue, 23 Jun 2020 13:43:06 +1000 > Subject: [PATCH] net/core/devlink.c: remove new uninitialized_var() usage > > Signed-off-by: Stephen Rothwell Applied, thanks Stephen.
Re: [PATCH] Fix check in ethtool_rx_flow_rule_create
From: Gaurav Singh
Date: Sun, 21 Jun 2020 11:30:17 -0400
> Fix check in ethtool_rx_flow_rule_create
>
> Signed-off-by: Gaurav Singh
Applied and queued up for -stable with the following Fixes: tag added:
Fixes: eca4205f9ec3 ("ethtool: add ethtool_rx_flow_spec to flow_rule structure
translator")
Thank you.
Re: [PATCH 02/17] sparc64: enable HAVE_COPY_THREAD_TLS
From: Christian Brauner Date: Tue, 23 Jun 2020 01:43:11 +0200 > diff --git a/arch/sparc/kernel/syscalls.S b/arch/sparc/kernel/syscalls.S > index db42b4fb3708..192f3a28a2b7 100644 > --- a/arch/sparc/kernel/syscalls.S > +++ b/arch/sparc/kernel/syscalls.S > @@ -86,19 +86,22 @@ sys32_rt_sigreturn: >* during system calls... >*/ > .align 32 > -sys_vfork: /* Under Linux, vfork and fork are just special cases of clone. */ > - sethi %hi(0x4000 | 0x0100 | SIGCHLD), %o0 > - or %o0, %lo(0x4000 | 0x0100 | SIGCHLD), %o0 > - ba,pt %xcc, sys_clone > +sys_vfork: > + flushw > + ba,pt %xcc, sparc_vfork > + add %sp, PTREGS_OFF, %o0 Please indent branch delay slot instructions with one extra space, as was done in the code you are changing. > + ba,pt %xcc, sparc_fork > + add %sp, PTREGS_OFF, %o0 Likewise. > + ba,pt %xcc, sparc_clone > + add %sp, PTREGS_OFF, %o0 Likewise.
Re: [PATCH] usbnet: smsc95xx: Fix use-after-free after removal
From: Tuomas Tynkkynen Date: Sun, 21 Jun 2020 13:43:26 +0300 > Syzbot reports an use-after-free in workqueue context: > > BUG: KASAN: use-after-free in mutex_unlock+0x19/0x40 > kernel/locking/mutex.c:737 > mutex_unlock+0x19/0x40 kernel/locking/mutex.c:737 > __smsc95xx_mdio_read drivers/net/usb/smsc95xx.c:217 [inline] > smsc95xx_mdio_read+0x583/0x870 drivers/net/usb/smsc95xx.c:278 > check_carrier+0xd1/0x2e0 drivers/net/usb/smsc95xx.c:644 > process_one_work+0x777/0xf90 kernel/workqueue.c:2274 > worker_thread+0xa8f/0x1430 kernel/workqueue.c:2420 > kthread+0x2df/0x300 kernel/kthread.c:255 > > It looks like that smsc95xx_unbind() is freeing the structures that are > still in use by the concurrently running workqueue callback. Thus switch > to using cancel_delayed_work_sync() to ensure the work callback really > is no longer active. > > Reported-by: syzbot+29dc7d4ae19b703ff...@syzkaller.appspotmail.com > Signed-off-by: Tuomas Tynkkynen Applied, thanks.
Re: [PATCH v2 net 0/3] net: ethtool: netdev_features_strings[] cleanup
From: Alexander Lobakin Date: Sun, 21 Jun 2020 09:55:50 + > This little series adds the last forgotten feature string for > NETIF_F_GSO_TUNNEL_REMCSUM and attempts to prevent such losses > in future. > > Patches 2-3 seem more like net-next candidates rather than net-fixes, > but for me it seems a bit more suitable to pull it during "quiet" RC > windows, so any new related code could start from this base. > > I was thinking about some kind of static assertion to have an early > prevention mechanism for this, but the existing of 2 intended holes > (former NO_CSUM and UFO) makes this problematic, at least at first > sight. > > v2: > - fix the "Fixes:" tag in the first patch; > - no functional changes. Please do not mix bug fixes (missing netdev feature strings, etc.) with cleanups (indentation changes). Thank you.
Re: [PATCH 0/2] prepare dwmac-meson8b for G12A specific initialization
From: Martin Blumenstingl Date: Sat, 20 Jun 2020 21:26:39 +0200 > Some users are reporting that RGMII (and sometimes also RMII) Ethernet > is not working for them on G12A/G12B/SM1 boards. Upon closer inspection > of the vendor code for these SoCs new register bits are found. > > It's not clear yet how these registers work. Add a new compatible string > as the first preparation step to improve Ethernet support on these SoCs. Series applied to net-next, thanks Martin.
Re: [PATCH net v3] net: phy: smsc: fix printing too many logs
From: Dejin Zheng
Date: Sat, 20 Jun 2020 22:55:34 +0800
> Commit 7ae7ad2f11ef47 ("net: phy: smsc: use phy_read_poll_timeout()
> to simplify the code") will print a lot of logs as follows when Ethernet
> cable is not connected:
>
> [4.473105] SMSC LAN8710/LAN8720 2188000.ethernet-1:00:
> lan87xx_read_status failed: -110
>
> When wait 640 ms for check ENERGYON bit, the timeout should not be
> regarded as an actual error and an error message also should not be
> printed. due to a hardware bug in LAN87XX device, it leads to unstable
> detection of plugging in Ethernet cable when LAN87xx is in Energy Detect
> Power-Down mode. the workaround for it involves, when the link is down,
> and at each read_status() call:
>
> - disable EDPD mode, forcing the PHY out of low-power mode
> - waiting 640ms to see if we have any energy detected from the media
> - re-enable entry to EDPD mode
>
> This is presumably enough to allow the PHY to notice that a cable is
> connected, and resume normal operations to negotiate with the partner.
> The problem is that when no media is detected, the 640ms wait times
> out and this commit was modified to prints an error message. it is an
> inappropriate conversion by used phy_read_poll_timeout() to introduce
> this bug. so fix this issue by use read_poll_timeout() to replace
> phy_read_poll_timeout().
>
> Fixes: 7ae7ad2f11ef47 ("net: phy: smsc: use phy_read_poll_timeout() to
> simplify the code")
> Reported-by: Kevin Groeneveld
> Signed-off-by: Dejin Zheng
Applied and queued up for -stable, thanks.
Re: [Resend PATCH net] bridge: uapi: mrp: Fix MRP_PORT_ROLE
From: Horatiu Vultur
Date: Sat, 20 Jun 2020 15:14:03 +0200
> Currently the MRP_PORT_ROLE_NONE has the value 0x2 but this is in conflict
> with the IEC 62439-2 standard. The standard defines the following port
> roles: primary (0x0), secondary(0x1), interconnect(0x2).
> Therefore remove the port role none.
>
> Fixes: 4714d13791f831 ("bridge: uapi: mrp: Add mrp attributes.")
> Signed-off-by: Horatiu Vultur
The code accepts arbitrary 32-bit values for the role in a configuration
but only PRIMARY and SECONDARY seem to be valid.
There is no validation that the value used makes sense.
In the future if we handle type interconnect, and we add checks, it will
break any existing applications. Because they can validly pass any
non-zero valid and the code treats that as SECONDARY currently.
So you really can't just remove NONE, you have to add validation code
too so we don't run into problem in the future.
Thanks.
Re: [PATCH net-next v5 0/3] net: dsa: qca8k: Improve SGMII interface handling
From: Jonathan McDowell Date: Sat, 20 Jun 2020 11:30:03 +0100 > This 3 patch series migrates the qca8k switch driver over to PHYLINK, > and then adds the SGMII clean-ups (i.e. the missing initialisation) on > top of that as a second patch. The final patch is a simple spelling fix > in a comment. > > As before, tested with a device where the CPU connection is RGMII (i.e. > the common current use case) + one where the CPU connection is SGMII. I > don't have any devices where the SGMII interface is brought out to > something other than the CPU. ... Series applied, thanks.
Re: [PATCH] sparc: piggyback: handle invalid image
From: Corentin Labbe Date: Wed, 10 Jun 2020 07:55:19 + > With an old elftoaout, the generation of tftpboot.img fail with "lseek: > invalid argument". > This is due to offset being negative. > > Instead of printing this error message, let's print a better one. > > Signed-off-by: Corentin Labbe Applied, thank you.
Re: [PATCH][next] sparc64: viohs: Use struct_size() helper
From: "Gustavo A. R. Silva" Date: Fri, 19 Jun 2020 20:14:06 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. Also, remove unnecessary > variable _len_. > > This code was detected with the help of Coccinelle and, audited and > fixed manually. > > Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83 > Signed-off-by: Gustavo A. R. Silva Applied, thank you.
Re: [PATCH net-next v9 1/5] dt-bindings: net: Add tx and rx internal delays
From: Dan Murphy Date: Fri, 19 Jun 2020 11:18:09 -0500 > @@ -162,6 +162,19 @@ properties: > description: >Specifies a reference to a node representing a SFP cage. > > + > + rx-internal-delay-ps: Do you really want two empty lines between these two sections?
Re: [PATCH net-next v9 2/5] net: phy: Add a helper to return the index for of the internal delay
From: Dan Murphy
Date: Fri, 19 Jun 2020 11:18:10 -0500
> +s32 phy_get_internal_delay(struct phy_device *phydev, struct device *dev,
> +const int *delay_values, int size, bool is_rx)
> +{
> + int i;
> + s32 delay;
Please use reverse christmas tree ordering for local variables.
Re: [PATCH net-next v3 0/4] bonding: initial support for hardware crypto offload
From: Jarod Wilson Date: Fri, 19 Jun 2020 10:31:51 -0400 > This is an initial functional implementation for doing pass-through of > hardware encryption from bonding device to capable slaves, in active-backup > bond setups. This was developed and tested using ixgbe-driven Intel x520 > interfaces with libreswan and a transport mode connection, primarily using > netperf, with assorted connection failures forced during transmission. The > failover works quite well in my testing, and overall performance is right > on par with offload when running on a bare interface, no bond involved. > > Caveats: this is ONLY enabled for active-backup, because I'm not sure > how one would manage multiple offload handles for different devices all > running at the same time in the same xfrm, and it relies on some minor > changes to both the xfrm code and slave device driver code to get things > to behave, and I don't have immediate access to any other hardware that > could function similarly, but the NIC driver changes are minimal and > straight-forward enough that I've included what I think ought to be > enough for mlx5 devices too. > > v2: reordered patches, switched (back) to using CONFIG_XFRM_OFFLOAD > to wrap the code additions and wrapped overlooked additions. > v3: rebase w/net-next open, add proper cc list to cover letter Series applied, thanks.
Re: [PATCH net] rxrpc: Fix notification call on completion of discarded calls
From: David Howells
Date: Fri, 19 Jun 2020 23:38:16 +0100
> When preallocated service calls are being discarded, they're passed to
> ->discard_new_call() to have the caller clean up any attached higher-layer
> preallocated pieces before being marked completed. However, the act of
> marking them completed now invokes the call's notification function - which
> causes a problem because that function might assume that the previously
> freed pieces of memory are still there.
>
> Fix this by setting a dummy notification function on the socket after
> calling ->discard_new_call().
>
> This results in the following kasan message when the kafs module is
> removed.
...
> Reported-by: syzbot+d3eccef36ddbd0271...@syzkaller.appspotmail.com
> Fixes: 5ac0d62226a0 ("rxrpc: Fix missing notification")
> Signed-off-by: David Howells
Applied, thanks David.
Re: [PATCH] [net/sched] Remove redundant skb null check
From: Gaurav Singh Date: Fri, 19 Jun 2020 15:24:13 -0400 > Remove the redundant null check for skb. > > Signed-off-by: Gaurav Singh Applied to net-next.
Re: [PATCH net 0/3] net: ethtool: netdev_features_strings[] cleanup
Please submit this again, I have two copies in my inbox and I have no idea what is different between them. Also, in some of your patches you cut the Fixes: tag into mutliple lines please do not do that. The Fixes: tag line should be one single line no matter how long it is. Thank you.
Re: [PATCH net-next] of: mdio: preserve phy dev_flags in of_phy_connect()
From: rentao.b...@gmail.com
Date: Thu, 18 Jun 2020 15:04:44 -0700
> From: Tao Ren
>
> Replace assignment "=" with OR "|=" for "phy->dev_flags" so "dev_flags"
> configured in phy probe() function can be preserved.
>
> The idea is similar to commit e7312efbd5de ("net: phy: modify assignment
> to OR for dev_flags in phy_attach_direct").
>
> Signed-off-by: Tao Ren
Applied.
Re: [PATCH] [net/sched]: Remove redundant condition in qdisc_graft
From: Gaurav Singh Date: Thu, 18 Jun 2020 16:36:31 -0400 > parent cannot be NULL here since its in the else part > of the if (parent == NULL) condition. Remove the extra > check on parent pointer. > > Signed-off-by: Gaurav Singh Applied to net-next, thanks.
Re: [net-next,v1,0/5] Strict mode for VRF
From: David Ahern Date: Sat, 20 Jun 2020 16:32:53 -0700 > On 6/19/20 3:54 PM, Andrea Mayer wrote: >> This patch set adds the new "strict mode" functionality to the Virtual >> Routing and Forwarding infrastructure (VRF). Hereafter we discuss the >> requirements and the main features of the "strict mode" for VRF. >> > > For the set: > Acked-by: David Ahern Series applied to net-next, thanks.
Re: [PATCH][next] net/sched: cls_u32: Use struct_size() in kzalloc()
From: "Gustavo A. R. Silva" Date: Thu, 18 Jun 2020 09:53:42 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. > > This code was detected with the help of Coccinelle and, audited and > fixed manually. > > Signed-off-by: Gustavo A. R. Silva Applied.
Re: [PATCH][next] taprio: Use struct_size() in kzalloc()
From: "Gustavo A. R. Silva" Date: Thu, 18 Jun 2020 09:46:48 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. Also, remove unnecessary > variable _size_. > > This code was detected with the help of Coccinelle and, audited and > fixed manually. > > Signed-off-by: Gustavo A. R. Silva Applied, thank you.
Re: [PATCH][next] tipc: Use struct_size() helper
From: "Gustavo A. R. Silva" Date: Thu, 18 Jun 2020 08:35:00 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. > > This code was detected with the help of Coccinelle and, audited and > fixed manually. > > Signed-off-by: Gustavo A. R. Silva Applied, thank you.
Re: [PATCH -next] macvlan: Fix memleak in macvlan_changelink_sources
From: Zheng Bin
Date: Thu, 18 Jun 2020 21:26:29 +0800
> macvlan_changelink_sources
> if (addr)
> ret = macvlan_hash_add_source(vlan, addr)
> nla_for_each_attr(nla, head, len, rem)
> ret = macvlan_hash_add_source(vlan, addr)
> -->If fail, need to free previous malloc memory
>
> Fixes: 79cf79abce71 ("macvlan: add source mode")
> Signed-off-by: Zheng Bin
Bug fixes should never be submitted against net-next.
They should instead be submitted against 'net'.
Thank you.
Re: [PATCH v2] net: macb: undo operations in case of failure
From: Claudiu Beznea
Date: Thu, 18 Jun 2020 11:37:40 +0300
> Undo previously done operation in case macb_phylink_connect()
> fails. Since macb_reset_hw() is the 1st undo operation the
> napi_exit label was renamed to reset_hw.
>
> Fixes: 7897b071ac3b ("net: macb: convert to phylink")
> Signed-off-by: Claudiu Beznea
Applied and queued up for -stable, thank you.
Re: [PATCH net] bridge: uapi: mrp: Fix MRP_PORT_ROLE
Please send networking patches for review to net...@vger.kernel.org Thank you.
Re: [PATCH net 0/3] rxrpc: Performance drop fix and other fixes
From: David Howells Date: Thu, 18 Jun 2020 08:50:15 +0100 > > Here are three fixes for rxrpc: > > (1) Fix a trace symbol mapping. It doesn't seem to let you map to "". > > (2) Fix the handling of the remote receive window size when it increases > beyond the size we can support for our transmit window. > > (3) Fix a performance drop caused by retransmitted packets being > accidentally marked as already ACK'd. > > The patches are tagged here: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-fixes-20200618 Pulled, thanks David.
Re: [PATCH net v2 0/2] net: phy: MDIO bus scanning fixes
From: Florian Fainelli Date: Fri, 19 Jun 2020 11:47:45 -0700 > This patch series fixes two problems with the current MDIO bus scanning > logic which was identified while moving from 4.9 to 5.4 on devices that > do rely on scanning the MDIO bus at runtime because they use pluggable > cards. > > Changes in v2: > > - added comment explaining the special value of -ENODEV > - added Andrew's Reviewed-by tag Series applied and queued up for -stable, thanks.
