Re: [PATCH] fixed_phy: pass 'irq' to fixed_phy_add()

[David Miller]

From: Sergei Shtylyov 
Date: Thu, 03 Sep 2015 23:22:16 +0300

> I've noticed  that fixed_phy_register() ignores its 'irq' parameter instead of
> passing it to fixed_phy_add(). Luckily, fixed_phy_register()  seems to  always
> be  called with PHY_POLL  for 'irq'... :-)
> 
> Fixes: a75951217472 ("net: phy: extend fixed driver with 
> fixed_phy_register()")
> Signed-off-by: Sergei Shtylyov 

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] fixed_phy: pass 'irq' to fixed_phy_add()

[David Miller]

From: Sergei Shtylyov 
Date: Thu, 03 Sep 2015 23:22:16 +0300

> I've noticed  that fixed_phy_register() ignores its 'irq' parameter instead of
> passing it to fixed_phy_add(). Luckily, fixed_phy_register()  seems to  always
> be  called with PHY_POLL  for 'irq'... :-)
> 
> Fixes: a75951217472 ("net: phy: extend fixed driver with 
> fixed_phy_register()")
> Signed-off-by: Sergei Shtylyov 

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] fixed_phy: pass 'irq' to fixed_phy_add()

[Florian Fainelli]

On 03/09/15 13:22, Sergei Shtylyov wrote:
> I've noticed  that fixed_phy_register() ignores its 'irq' parameter instead of
> passing it to fixed_phy_add(). Luckily, fixed_phy_register()  seems to  always
> be  called with PHY_POLL  for 'irq'... :-)

So not critical for -stable, good!

> 
> Fixes: a75951217472 ("net: phy: extend fixed driver with 
> fixed_phy_register()")
> Signed-off-by: Sergei Shtylyov 

Acked-by: Florian Fainelli 
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] fixed_phy: pass 'irq' to fixed_phy_add()

[Sergei Shtylyov]

I've noticed  that fixed_phy_register() ignores its 'irq' parameter instead of
passing it to fixed_phy_add(). Luckily, fixed_phy_register()  seems to  always
be  called with PHY_POLL  for 'irq'... :-)

Fixes: a75951217472 ("net: phy: extend fixed driver with fixed_phy_register()")
Signed-off-by: Sergei Shtylyov 

---
The patch is against DaveM's 'net.git' repo.

 drivers/net/phy/fixed_phy.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: net/drivers/net/phy/fixed_phy.c
===
--- net.orig/drivers/net/phy/fixed_phy.c
+++ net/drivers/net/phy/fixed_phy.c
@@ -325,7 +325,7 @@ struct phy_device *fixed_phy_register(un
phy_addr = phy_fixed_addr++;
spin_unlock(_fixed_addr_lock);
 
-   ret = fixed_phy_add(PHY_POLL, phy_addr, status, link_gpio);
+   ret = fixed_phy_add(irq, phy_addr, status, link_gpio);
if (ret < 0)
return ERR_PTR(ret);
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] fixed_phy: pass 'irq' to fixed_phy_add()

[Sergei Shtylyov]

I've noticed  that fixed_phy_register() ignores its 'irq' parameter instead of
passing it to fixed_phy_add(). Luckily, fixed_phy_register()  seems to  always
be  called with PHY_POLL  for 'irq'... :-)

Fixes: a75951217472 ("net: phy: extend fixed driver with fixed_phy_register()")
Signed-off-by: Sergei Shtylyov 

---
The patch is against DaveM's 'net.git' repo.

 drivers/net/phy/fixed_phy.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: net/drivers/net/phy/fixed_phy.c
===
--- net.orig/drivers/net/phy/fixed_phy.c
+++ net/drivers/net/phy/fixed_phy.c
@@ -325,7 +325,7 @@ struct phy_device *fixed_phy_register(un
phy_addr = phy_fixed_addr++;
spin_unlock(_fixed_addr_lock);
 
-   ret = fixed_phy_add(PHY_POLL, phy_addr, status, link_gpio);
+   ret = fixed_phy_add(irq, phy_addr, status, link_gpio);
if (ret < 0)
return ERR_PTR(ret);
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] fixed_phy: pass 'irq' to fixed_phy_add()

[Florian Fainelli]

On 03/09/15 13:22, Sergei Shtylyov wrote:
> I've noticed  that fixed_phy_register() ignores its 'irq' parameter instead of
> passing it to fixed_phy_add(). Luckily, fixed_phy_register()  seems to  always
> be  called with PHY_POLL  for 'irq'... :-)

So not critical for -stable, good!

> 
> Fixes: a75951217472 ("net: phy: extend fixed driver with 
> fixed_phy_register()")
> Signed-off-by: Sergei Shtylyov 

Acked-by: Florian Fainelli 
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/