Re: [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given

[Du, Changbin]

On Fri, Jun 02, 2017 at 10:52:24AM +0800, Du, Changbin wrote:
> On Thu, Jun 01, 2017 at 12:21:39PM +0200, Jiri Olsa wrote:
> > On Thu, Jun 01, 2017 at 05:03:21PM +0800, changbin...@intel.com wrote:
> > > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> > > index 5762ae4..69eea3a 100644
> > > --- a/tools/perf/util/sort.c
> > > +++ b/tools/perf/util/sort.c
> > > @@ -2635,6 +2635,9 @@ static char *setup_overhead(char *keys)
> > >   if (sort__mode == SORT_MODE__DIFF)
> > >   return keys;
> > >  
> > > + if (strstr(keys, "overhead"))
> > > + return keys;
> > > +
> > >   keys = prefix_if_not_in("overhead", keys);
> > 
> > hum, you basicaly do what's at begining of prefix_if_not_in function:
> > 
> > static char *prefix_if_not_in(const char *pre, char *str)
> > {
> > char *n;
> > 
> > if (!str || strstr(str, pre))
> > return str;
> > ...
> > 
> Thanks, will change it.
>
Misunderstood your words. This is not equal to prefix_if_not_in.
# perf record -ag
# perf report -s overhead,sym

Samples: 7K of event 'cycles', Event count (approx.): 865138253
  Children  Self  Symbol
  +   26.41% 0.00%  [k] verify_cpu
  +   26.37% 0.04%  [k] cpu_startup_entry
  +   25.93% 0.27%  [k] do_idle
  +   19.88% 0.00%  [k] start_secondary
  

'Children' should not be here.

> > 
> > could you please provide the example described in changelog?
> > 
> Will add example cmdline there, Thanks.
> 
> > jirka
> 
> -- 
> Thanks,
> Changbin Du



-- 
Thanks,
Changbin Du


signature.asc
Description: PGP signature

Re: [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given

[Du, Changbin]

On Fri, Jun 02, 2017 at 10:52:24AM +0800, Du, Changbin wrote:
> On Thu, Jun 01, 2017 at 12:21:39PM +0200, Jiri Olsa wrote:
> > On Thu, Jun 01, 2017 at 05:03:21PM +0800, changbin...@intel.com wrote:
> > > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> > > index 5762ae4..69eea3a 100644
> > > --- a/tools/perf/util/sort.c
> > > +++ b/tools/perf/util/sort.c
> > > @@ -2635,6 +2635,9 @@ static char *setup_overhead(char *keys)
> > >   if (sort__mode == SORT_MODE__DIFF)
> > >   return keys;
> > >  
> > > + if (strstr(keys, "overhead"))
> > > + return keys;
> > > +
> > >   keys = prefix_if_not_in("overhead", keys);
> > 
> > hum, you basicaly do what's at begining of prefix_if_not_in function:
> > 
> > static char *prefix_if_not_in(const char *pre, char *str)
> > {
> > char *n;
> > 
> > if (!str || strstr(str, pre))
> > return str;
> > ...
> > 
> Thanks, will change it.
>
Misunderstood your words. This is not equal to prefix_if_not_in.
# perf record -ag
# perf report -s overhead,sym

Samples: 7K of event 'cycles', Event count (approx.): 865138253
  Children  Self  Symbol
  +   26.41% 0.00%  [k] verify_cpu
  +   26.37% 0.04%  [k] cpu_startup_entry
  +   25.93% 0.27%  [k] do_idle
  +   19.88% 0.00%  [k] start_secondary
  

'Children' should not be here.

> > 
> > could you please provide the example described in changelog?
> > 
> Will add example cmdline there, Thanks.
> 
> > jirka
> 
> -- 
> Thanks,
> Changbin Du



-- 
Thanks,
Changbin Du


signature.asc
Description: PGP signature

Re: [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given

[Du, Changbin]

On Thu, Jun 01, 2017 at 12:21:39PM +0200, Jiri Olsa wrote:
> On Thu, Jun 01, 2017 at 05:03:21PM +0800, changbin...@intel.com wrote:
> > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> > index 5762ae4..69eea3a 100644
> > --- a/tools/perf/util/sort.c
> > +++ b/tools/perf/util/sort.c
> > @@ -2635,6 +2635,9 @@ static char *setup_overhead(char *keys)
> > if (sort__mode == SORT_MODE__DIFF)
> > return keys;
> >  
> > +   if (strstr(keys, "overhead"))
> > +   return keys;
> > +
> > keys = prefix_if_not_in("overhead", keys);
> 
> hum, you basicaly do what's at begining of prefix_if_not_in function:
> 
> static char *prefix_if_not_in(const char *pre, char *str)
> {
> char *n;
> 
> if (!str || strstr(str, pre))
> return str;
> ...
> 
Thanks, will change it.

> 
> could you please provide the example described in changelog?
> 
Will add example cmdline there, Thanks.

> jirka

-- 
Thanks,
Changbin Du


signature.asc
Description: PGP signature

Re: [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given

[Du, Changbin]

On Thu, Jun 01, 2017 at 12:21:39PM +0200, Jiri Olsa wrote:
> On Thu, Jun 01, 2017 at 05:03:21PM +0800, changbin...@intel.com wrote:
> > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> > index 5762ae4..69eea3a 100644
> > --- a/tools/perf/util/sort.c
> > +++ b/tools/perf/util/sort.c
> > @@ -2635,6 +2635,9 @@ static char *setup_overhead(char *keys)
> > if (sort__mode == SORT_MODE__DIFF)
> > return keys;
> >  
> > +   if (strstr(keys, "overhead"))
> > +   return keys;
> > +
> > keys = prefix_if_not_in("overhead", keys);
> 
> hum, you basicaly do what's at begining of prefix_if_not_in function:
> 
> static char *prefix_if_not_in(const char *pre, char *str)
> {
> char *n;
> 
> if (!str || strstr(str, pre))
> return str;
> ...
> 
Thanks, will change it.

> 
> could you please provide the example described in changelog?
> 
Will add example cmdline there, Thanks.

> jirka

-- 
Thanks,
Changbin Du


signature.asc
Description: PGP signature

Re: [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given

[Jiri Olsa]

On Thu, Jun 01, 2017 at 05:03:21PM +0800, changbin...@intel.com wrote:
> From: Changbin Du 
> 
> If we always insert 'overhead' and 'overhead_children' as sort keys,
> this make it impossible to sort as overhead (which displayed as Self)
> first.Ths will be a problem if the data is collected with call-graph
> enabled. Then we never can sort the result as self-overhead on this
> data. And sometimes the data is hard to collect.
> 
> This patch fix this by only insert overhead && overhead_children
> when no overhead* field given.
> 
> Signed-off-by: Changbin Du 
> ---
>  tools/perf/util/sort.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> index 5762ae4..69eea3a 100644
> --- a/tools/perf/util/sort.c
> +++ b/tools/perf/util/sort.c
> @@ -2635,6 +2635,9 @@ static char *setup_overhead(char *keys)
>   if (sort__mode == SORT_MODE__DIFF)
>   return keys;
>  
> + if (strstr(keys, "overhead"))
> + return keys;
> +
>   keys = prefix_if_not_in("overhead", keys);

hum, you basicaly do what's at begining of prefix_if_not_in function:

static char *prefix_if_not_in(const char *pre, char *str)
{
char *n;

if (!str || strstr(str, pre))
return str;
...


could you please provide the example described in changelog?

jirka

Re: [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given

[Jiri Olsa]

On Thu, Jun 01, 2017 at 05:03:21PM +0800, changbin...@intel.com wrote:
> From: Changbin Du 
> 
> If we always insert 'overhead' and 'overhead_children' as sort keys,
> this make it impossible to sort as overhead (which displayed as Self)
> first.Ths will be a problem if the data is collected with call-graph
> enabled. Then we never can sort the result as self-overhead on this
> data. And sometimes the data is hard to collect.
> 
> This patch fix this by only insert overhead && overhead_children
> when no overhead* field given.
> 
> Signed-off-by: Changbin Du 
> ---
>  tools/perf/util/sort.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> index 5762ae4..69eea3a 100644
> --- a/tools/perf/util/sort.c
> +++ b/tools/perf/util/sort.c
> @@ -2635,6 +2635,9 @@ static char *setup_overhead(char *keys)
>   if (sort__mode == SORT_MODE__DIFF)
>   return keys;
>  
> + if (strstr(keys, "overhead"))
> + return keys;
> +
>   keys = prefix_if_not_in("overhead", keys);

hum, you basicaly do what's at begining of prefix_if_not_in function:

static char *prefix_if_not_in(const char *pre, char *str)
{
char *n;

if (!str || strstr(str, pre))
return str;
...


could you please provide the example described in changelog?

jirka

[PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given

[changbin . du]

From: Changbin Du 

If we always insert 'overhead' and 'overhead_children' as sort keys,
this make it impossible to sort as overhead (which displayed as Self)
first.Ths will be a problem if the data is collected with call-graph
enabled. Then we never can sort the result as self-overhead on this
data. And sometimes the data is hard to collect.

This patch fix this by only insert overhead && overhead_children
when no overhead* field given.

Signed-off-by: Changbin Du 
---
 tools/perf/util/sort.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index 5762ae4..69eea3a 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -2635,6 +2635,9 @@ static char *setup_overhead(char *keys)
if (sort__mode == SORT_MODE__DIFF)
return keys;
 
+   if (strstr(keys, "overhead"))
+   return keys;
+
keys = prefix_if_not_in("overhead", keys);
 
if (symbol_conf.cumulate_callchain)
-- 
2.7.4

[PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given

[changbin . du]

From: Changbin Du 

If we always insert 'overhead' and 'overhead_children' as sort keys,
this make it impossible to sort as overhead (which displayed as Self)
first.Ths will be a problem if the data is collected with call-graph
enabled. Then we never can sort the result as self-overhead on this
data. And sometimes the data is hard to collect.

This patch fix this by only insert overhead && overhead_children
when no overhead* field given.

Signed-off-by: Changbin Du 
---
 tools/perf/util/sort.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index 5762ae4..69eea3a 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -2635,6 +2635,9 @@ static char *setup_overhead(char *keys)
if (sort__mode == SORT_MODE__DIFF)
return keys;
 
+   if (strstr(keys, "overhead"))
+   return keys;
+
keys = prefix_if_not_in("overhead", keys);
 
if (symbol_conf.cumulate_callchain)
-- 
2.7.4

Re: [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given

[Du, Changbin]

hi, Arnaldo,
Seems you missed this one. In some case, sort by 'Children' first doesn't make
sense, bacause I only care the 'Self' overhead.

btw, does perf have a option that only calculate the *real* callee 
'overhead_acc'?
I mean only count the samples to parent when it is called by parent. For
example,

fun1fun2
  foo foo

Then the 'overhead_acc' for fun1 should not include the samples that fun2 call 
foo.
Thanks.
changbin

On Mon, Mar 13, 2017 at 04:36:01PM +0800, changbin...@intel.com wrote:
> From: Changbin Du 
> 
> If we always insert 'overhead' and 'overhead_children' as sort keys,
> this make it impossible to sort as overhead (which displayed as Self)
> first. This patch forbid adding any overhead* field if there is one
> already given.
> 
> Signed-off-by: Changbin Du 
> ---
>  tools/perf/util/sort.c | 7 +++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> index b6db140..7695b54 100644
> --- a/tools/perf/util/sort.c
> +++ b/tools/perf/util/sort.c
> @@ -2543,6 +2543,13 @@ static char *setup_overhead(char *keys)
>   if (sort__mode == SORT_MODE__DIFF)
>   return keys;
>  
> + /*
> +  * Only insert overhead && overhead_children when
> +  * no overhead* field given.
> +  */
> + if (strstr(keys, "overhead"))
> + return keys;
> +
>   keys = prefix_if_not_in("overhead", keys);
>  
>   if (symbol_conf.cumulate_callchain)
> -- 
> 2.7.4
> 

-- 
Thanks,
Changbin Du


signature.asc
Description: PGP signature

Re: [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given

[Du, Changbin]

hi, Arnaldo,
Seems you missed this one. In some case, sort by 'Children' first doesn't make
sense, bacause I only care the 'Self' overhead.

btw, does perf have a option that only calculate the *real* callee 
'overhead_acc'?
I mean only count the samples to parent when it is called by parent. For
example,

fun1fun2
  foo foo

Then the 'overhead_acc' for fun1 should not include the samples that fun2 call 
foo.
Thanks.
changbin

On Mon, Mar 13, 2017 at 04:36:01PM +0800, changbin...@intel.com wrote:
> From: Changbin Du 
> 
> If we always insert 'overhead' and 'overhead_children' as sort keys,
> this make it impossible to sort as overhead (which displayed as Self)
> first. This patch forbid adding any overhead* field if there is one
> already given.
> 
> Signed-off-by: Changbin Du 
> ---
>  tools/perf/util/sort.c | 7 +++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> index b6db140..7695b54 100644
> --- a/tools/perf/util/sort.c
> +++ b/tools/perf/util/sort.c
> @@ -2543,6 +2543,13 @@ static char *setup_overhead(char *keys)
>   if (sort__mode == SORT_MODE__DIFF)
>   return keys;
>  
> + /*
> +  * Only insert overhead && overhead_children when
> +  * no overhead* field given.
> +  */
> + if (strstr(keys, "overhead"))
> + return keys;
> +
>   keys = prefix_if_not_in("overhead", keys);
>  
>   if (symbol_conf.cumulate_callchain)
> -- 
> 2.7.4
> 

-- 
Thanks,
Changbin Du


signature.asc
Description: PGP signature

[PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given

[changbin . du]

From: Changbin Du 

If we always insert 'overhead' and 'overhead_children' as sort keys,
this make it impossible to sort as overhead (which displayed as Self)
first. This patch forbid adding any overhead* field if there is one
already given.

Signed-off-by: Changbin Du 
---
 tools/perf/util/sort.c | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index b6db140..7695b54 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -2543,6 +2543,13 @@ static char *setup_overhead(char *keys)
if (sort__mode == SORT_MODE__DIFF)
return keys;
 
+   /*
+* Only insert overhead && overhead_children when
+* no overhead* field given.
+*/
+   if (strstr(keys, "overhead"))
+   return keys;
+
keys = prefix_if_not_in("overhead", keys);
 
if (symbol_conf.cumulate_callchain)
-- 
2.7.4

[PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given

[changbin . du]

From: Changbin Du 

If we always insert 'overhead' and 'overhead_children' as sort keys,
this make it impossible to sort as overhead (which displayed as Self)
first. This patch forbid adding any overhead* field if there is one
already given.

Signed-off-by: Changbin Du 
---
 tools/perf/util/sort.c | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index b6db140..7695b54 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -2543,6 +2543,13 @@ static char *setup_overhead(char *keys)
if (sort__mode == SORT_MODE__DIFF)
return keys;
 
+   /*
+* Only insert overhead && overhead_children when
+* no overhead* field given.
+*/
+   if (strstr(keys, "overhead"))
+   return keys;
+
keys = prefix_if_not_in("overhead", keys);
 
if (symbol_conf.cumulate_callchain)
-- 
2.7.4