Re: [PATCH] uprobe: fix misleading log entry

2012-11-19 Thread Oleg Nesterov 
On 11/19, Steven Rostedt wrote:
>
> On Thu, 2012-10-25 at 16:12 +0200, Oleg Nesterov wrote:
> > On 07/18, Jovi Zhang wrote:
> > >
> > > --- a/kernel/trace/trace_uprobe.c
> > > +++ b/kernel/trace/trace_uprobe.c
> > > @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
> > >   if (argv[0][0] == '-')
> > >   is_delete = true;
> > >   else if (argv[0][0] != 'p') {
> > > - pr_info("Probe definition must be started with 'p', 'r' or" " 
> > > '-'.\n");
> > > + pr_info("Probe definition must be started with 'p' or '-'.\n");
> > >   return -EINVAL;
> > >   }
> >
> > Thanks, applied as 0d13ac96 (with Srikar's ack) in misc#uprobes/core
> >
> > Oleg.
>
> Hmm, this doesn't look like it ever got applied to mainline. Was it
> dropped?

I didn't send the pull request yet, will do today.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] uprobe: fix misleading log entry

2012-11-19 Thread Steven Rostedt 
On Thu, 2012-10-25 at 16:12 +0200, Oleg Nesterov wrote:
> On 07/18, Jovi Zhang wrote:
> >
> > --- a/kernel/trace/trace_uprobe.c
> > +++ b/kernel/trace/trace_uprobe.c
> > @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
> > if (argv[0][0] == '-')
> > is_delete = true;
> > else if (argv[0][0] != 'p') {
> > -   pr_info("Probe definition must be started with 'p', 'r' or" " 
> > '-'.\n");
> > +   pr_info("Probe definition must be started with 'p' or '-'.\n");
> > return -EINVAL;
> > }
> 
> Thanks, applied as 0d13ac96 (with Srikar's ack) in misc#uprobes/core
> 
> Oleg.

Hmm, this doesn't look like it ever got applied to mainline. Was it
dropped?

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] uprobe: fix misleading log entry

2012-11-19 Thread Steven Rostedt 
On Thu, 2012-10-25 at 16:12 +0200, Oleg Nesterov wrote:
 On 07/18, Jovi Zhang wrote:
 
  --- a/kernel/trace/trace_uprobe.c
  +++ b/kernel/trace/trace_uprobe.c
  @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
  if (argv[0][0] == '-')
  is_delete = true;
  else if (argv[0][0] != 'p') {
  -   pr_info(Probe definition must be started with 'p', 'r' or  
  '-'.\n);
  +   pr_info(Probe definition must be started with 'p' or '-'.\n);
  return -EINVAL;
  }
 
 Thanks, applied as 0d13ac96 (with Srikar's ack) in misc#uprobes/core
 
 Oleg.

Hmm, this doesn't look like it ever got applied to mainline. Was it
dropped?

-- Steve


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] uprobe: fix misleading log entry

2012-11-19 Thread Oleg Nesterov 
On 11/19, Steven Rostedt wrote:

 On Thu, 2012-10-25 at 16:12 +0200, Oleg Nesterov wrote:
  On 07/18, Jovi Zhang wrote:
  
   --- a/kernel/trace/trace_uprobe.c
   +++ b/kernel/trace/trace_uprobe.c
   @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
 if (argv[0][0] == '-')
 is_delete = true;
 else if (argv[0][0] != 'p') {
   - pr_info(Probe definition must be started with 'p', 'r' or  
   '-'.\n);
   + pr_info(Probe definition must be started with 'p' or '-'.\n);
 return -EINVAL;
 }
 
  Thanks, applied as 0d13ac96 (with Srikar's ack) in misc#uprobes/core
 
  Oleg.

 Hmm, this doesn't look like it ever got applied to mainline. Was it
 dropped?

I didn't send the pull request yet, will do today.

Oleg.

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] uprobe: fix misleading log entry

2012-10-25 Thread Oleg Nesterov 
On 07/18, Jovi Zhang wrote:
>
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
>   if (argv[0][0] == '-')
>   is_delete = true;
>   else if (argv[0][0] != 'p') {
> - pr_info("Probe definition must be started with 'p', 'r' or" " 
> '-'.\n");
> + pr_info("Probe definition must be started with 'p' or '-'.\n");
>   return -EINVAL;
>   }

Thanks, applied as 0d13ac96 (with Srikar's ack) in misc#uprobes/core

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] uprobe: fix misleading log entry

2012-10-25 Thread Oleg Nesterov 
On 07/18, Jovi Zhang wrote:

 --- a/kernel/trace/trace_uprobe.c
 +++ b/kernel/trace/trace_uprobe.c
 @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
   if (argv[0][0] == '-')
   is_delete = true;
   else if (argv[0][0] != 'p') {
 - pr_info(Probe definition must be started with 'p', 'r' or  
 '-'.\n);
 + pr_info(Probe definition must be started with 'p' or '-'.\n);
   return -EINVAL;
   }

Thanks, applied as 0d13ac96 (with Srikar's ack) in misc#uprobes/core

Oleg.

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] uprobe: fix misleading log entry

2012-10-11 Thread Srikar Dronamraju 
> On Wed, Jul 18, 2012 at 5:22 PM, Srikar Dronamraju
>  wrote:
> > * Jovi Zhang  [2012-07-18 11:08:42]:
> >
> >> From 68232ef2decae95b807f2f3763e8ea99c1a3b2ae Mon Sep 17 00:00:00 2001
> >> From: Jovi Zhang 
> >> Date: Wed, 18 Jul 2012 17:51:26 +0800
> >> Subject: [PATCH] uprobe: fix misleading log entry
> >>
> >> There don't have any 'r' prefix in uprobe event naming, remove it.
> >>
> >> Signed-off-by: Jovi Zhang 
> >> ---
> >>  kernel/trace/trace_uprobe.c |2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> >> index cf382de..852a584 100644
> >> --- a/kernel/trace/trace_uprobe.c
> >> +++ b/kernel/trace/trace_uprobe.c
> >> @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
> >>   if (argv[0][0] == '-')
> >>   is_delete = true;
> >>   else if (argv[0][0] != 'p') {
> >> - pr_info("Probe definition must be started with 'p', 'r' or" 
> >> " '-'.\n");
> >> + pr_info("Probe definition must be started with 'p' or 
> >> '-'.\n");
> >>   return -EINVAL;
> >>   }
> >>
> >
> > Yes, uprobes doesnt support return probes. So we should not have
> > mentioned about r.
> >
> > Acked-by: Srikar Dronamraju 
> >
> 

Ingo/Andrew

Can you please pick this.


-- 
Thanks and Regards
Srikar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] uprobe: fix misleading log entry

2012-10-11 Thread Jovi Zhang 
On Wed, Jul 18, 2012 at 5:22 PM, Srikar Dronamraju
 wrote:
> * Jovi Zhang  [2012-07-18 11:08:42]:
>
>> From 68232ef2decae95b807f2f3763e8ea99c1a3b2ae Mon Sep 17 00:00:00 2001
>> From: Jovi Zhang 
>> Date: Wed, 18 Jul 2012 17:51:26 +0800
>> Subject: [PATCH] uprobe: fix misleading log entry
>>
>> There don't have any 'r' prefix in uprobe event naming, remove it.
>>
>> Signed-off-by: Jovi Zhang 
>> ---
>>  kernel/trace/trace_uprobe.c |2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
>> index cf382de..852a584 100644
>> --- a/kernel/trace/trace_uprobe.c
>> +++ b/kernel/trace/trace_uprobe.c
>> @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
>>   if (argv[0][0] == '-')
>>   is_delete = true;
>>   else if (argv[0][0] != 'p') {
>> - pr_info("Probe definition must be started with 'p', 'r' or" " 
>> '-'.\n");
>> + pr_info("Probe definition must be started with 'p' or '-'.\n");
>>   return -EINVAL;
>>   }
>>
>
> Yes, uprobes doesnt support return probes. So we should not have
> mentioned about r.
>
> Acked-by: Srikar Dronamraju 
>

Hi Andrew,

Is this patch ok to go through your mm tree? mainline still don't merge it.

.jovi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] uprobe: fix misleading log entry

2012-10-11 Thread Jovi Zhang 
On Wed, Jul 18, 2012 at 5:22 PM, Srikar Dronamraju
sri...@linux.vnet.ibm.com wrote:
 * Jovi Zhang bookj...@gmail.com [2012-07-18 11:08:42]:

 From 68232ef2decae95b807f2f3763e8ea99c1a3b2ae Mon Sep 17 00:00:00 2001
 From: Jovi Zhang bookj...@gmail.com
 Date: Wed, 18 Jul 2012 17:51:26 +0800
 Subject: [PATCH] uprobe: fix misleading log entry

 There don't have any 'r' prefix in uprobe event naming, remove it.

 Signed-off-by: Jovi Zhang bookj...@gmail.com
 ---
  kernel/trace/trace_uprobe.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
 index cf382de..852a584 100644
 --- a/kernel/trace/trace_uprobe.c
 +++ b/kernel/trace/trace_uprobe.c
 @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
   if (argv[0][0] == '-')
   is_delete = true;
   else if (argv[0][0] != 'p') {
 - pr_info(Probe definition must be started with 'p', 'r' or  
 '-'.\n);
 + pr_info(Probe definition must be started with 'p' or '-'.\n);
   return -EINVAL;
   }


 Yes, uprobes doesnt support return probes. So we should not have
 mentioned about r.

 Acked-by: Srikar Dronamraju sri...@linux.vnet.ibm.com


Hi Andrew,

Is this patch ok to go through your mm tree? mainline still don't merge it.

.jovi
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] uprobe: fix misleading log entry

2012-10-11 Thread Srikar Dronamraju 
 On Wed, Jul 18, 2012 at 5:22 PM, Srikar Dronamraju
 sri...@linux.vnet.ibm.com wrote:
  * Jovi Zhang bookj...@gmail.com [2012-07-18 11:08:42]:
 
  From 68232ef2decae95b807f2f3763e8ea99c1a3b2ae Mon Sep 17 00:00:00 2001
  From: Jovi Zhang bookj...@gmail.com
  Date: Wed, 18 Jul 2012 17:51:26 +0800
  Subject: [PATCH] uprobe: fix misleading log entry
 
  There don't have any 'r' prefix in uprobe event naming, remove it.
 
  Signed-off-by: Jovi Zhang bookj...@gmail.com
  ---
   kernel/trace/trace_uprobe.c |2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
 
  diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
  index cf382de..852a584 100644
  --- a/kernel/trace/trace_uprobe.c
  +++ b/kernel/trace/trace_uprobe.c
  @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
if (argv[0][0] == '-')
is_delete = true;
else if (argv[0][0] != 'p') {
  - pr_info(Probe definition must be started with 'p', 'r' or 
   '-'.\n);
  + pr_info(Probe definition must be started with 'p' or 
  '-'.\n);
return -EINVAL;
}
 
 
  Yes, uprobes doesnt support return probes. So we should not have
  mentioned about r.
 
  Acked-by: Srikar Dronamraju sri...@linux.vnet.ibm.com
 
 

Ingo/Andrew

Can you please pick this.


-- 
Thanks and Regards
Srikar

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] uprobe: fix misleading log entry

2012-07-18 Thread Anton Arapov 
On Wed, 2012-07-18 at 19:43 +0800, Jovi Zhang wrote:
> On Wed, Jul 18, 2012 at 5:22 PM, Srikar Dronamraju
>  wrote:
> > * Jovi Zhang  [2012-07-18 11:08:42]:
> >
> >> From 68232ef2decae95b807f2f3763e8ea99c1a3b2ae Mon Sep 17 00:00:00 2001
> >> From: Jovi Zhang 
> >> Date: Wed, 18 Jul 2012 17:51:26 +0800
> >> Subject: [PATCH] uprobe: fix misleading log entry
> >>
> >> There don't have any 'r' prefix in uprobe event naming, remove it.
> >>
> >> Signed-off-by: Jovi Zhang 
> >> ---
> >>  kernel/trace/trace_uprobe.c |2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> >> index cf382de..852a584 100644
> >> --- a/kernel/trace/trace_uprobe.c
> >> +++ b/kernel/trace/trace_uprobe.c
> >> @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
> >>   if (argv[0][0] == '-')
> >>   is_delete = true;
> >>   else if (argv[0][0] != 'p') {
> >> - pr_info("Probe definition must be started with 'p', 'r' or" 
> >> " '-'.\n");
> >> + pr_info("Probe definition must be started with 'p' or 
> >> '-'.\n");
> >>   return -EINVAL;
> >>   }
> >>
> >
> > Yes, uprobes doesnt support return probes. So we should not have
> > mentioned about r.
> Hmm, Does this have specific reason? or just not implemented?

It is not implemented. I'm slowly(very) moving towards it. You are
welcome to take a look.
  https://github.com/arapov/linux-aa/commits/uretprobes

Anton.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] uprobe: fix misleading log entry

2012-07-18 Thread Jovi Zhang 
On Wed, Jul 18, 2012 at 5:22 PM, Srikar Dronamraju
 wrote:
> * Jovi Zhang  [2012-07-18 11:08:42]:
>
>> From 68232ef2decae95b807f2f3763e8ea99c1a3b2ae Mon Sep 17 00:00:00 2001
>> From: Jovi Zhang 
>> Date: Wed, 18 Jul 2012 17:51:26 +0800
>> Subject: [PATCH] uprobe: fix misleading log entry
>>
>> There don't have any 'r' prefix in uprobe event naming, remove it.
>>
>> Signed-off-by: Jovi Zhang 
>> ---
>>  kernel/trace/trace_uprobe.c |2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
>> index cf382de..852a584 100644
>> --- a/kernel/trace/trace_uprobe.c
>> +++ b/kernel/trace/trace_uprobe.c
>> @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
>>   if (argv[0][0] == '-')
>>   is_delete = true;
>>   else if (argv[0][0] != 'p') {
>> - pr_info("Probe definition must be started with 'p', 'r' or" " 
>> '-'.\n");
>> + pr_info("Probe definition must be started with 'p' or '-'.\n");
>>   return -EINVAL;
>>   }
>>
>
> Yes, uprobes doesnt support return probes. So we should not have
> mentioned about r.
Hmm, Does this have specific reason? or just not implemented?

>
> Acked-by: Srikar Dronamraju 
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] uprobe: fix misleading log entry

2012-07-18 Thread Srikar Dronamraju 
* Jovi Zhang  [2012-07-18 11:08:42]:

> From 68232ef2decae95b807f2f3763e8ea99c1a3b2ae Mon Sep 17 00:00:00 2001
> From: Jovi Zhang 
> Date: Wed, 18 Jul 2012 17:51:26 +0800
> Subject: [PATCH] uprobe: fix misleading log entry
> 
> There don't have any 'r' prefix in uprobe event naming, remove it.
> 
> Signed-off-by: Jovi Zhang 
> ---
>  kernel/trace/trace_uprobe.c |2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index cf382de..852a584 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
>   if (argv[0][0] == '-')
>   is_delete = true;
>   else if (argv[0][0] != 'p') {
> - pr_info("Probe definition must be started with 'p', 'r' or" " 
> '-'.\n");
> + pr_info("Probe definition must be started with 'p' or '-'.\n");
>   return -EINVAL;
>   }
> 

Yes, uprobes doesnt support return probes. So we should not have
mentioned about r.

Acked-by: Srikar Dronamraju 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] uprobe: fix misleading log entry

2012-07-18 Thread Srikar Dronamraju 
* Jovi Zhang bookj...@gmail.com [2012-07-18 11:08:42]:

 From 68232ef2decae95b807f2f3763e8ea99c1a3b2ae Mon Sep 17 00:00:00 2001
 From: Jovi Zhang bookj...@gmail.com
 Date: Wed, 18 Jul 2012 17:51:26 +0800
 Subject: [PATCH] uprobe: fix misleading log entry
 
 There don't have any 'r' prefix in uprobe event naming, remove it.
 
 Signed-off-by: Jovi Zhang bookj...@gmail.com
 ---
  kernel/trace/trace_uprobe.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
 index cf382de..852a584 100644
 --- a/kernel/trace/trace_uprobe.c
 +++ b/kernel/trace/trace_uprobe.c
 @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
   if (argv[0][0] == '-')
   is_delete = true;
   else if (argv[0][0] != 'p') {
 - pr_info(Probe definition must be started with 'p', 'r' or  
 '-'.\n);
 + pr_info(Probe definition must be started with 'p' or '-'.\n);
   return -EINVAL;
   }
 

Yes, uprobes doesnt support return probes. So we should not have
mentioned about r.

Acked-by: Srikar Dronamraju sri...@linux.vnet.ibm.com

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] uprobe: fix misleading log entry

2012-07-18 Thread Jovi Zhang 
On Wed, Jul 18, 2012 at 5:22 PM, Srikar Dronamraju
sri...@linux.vnet.ibm.com wrote:
 * Jovi Zhang bookj...@gmail.com [2012-07-18 11:08:42]:

 From 68232ef2decae95b807f2f3763e8ea99c1a3b2ae Mon Sep 17 00:00:00 2001
 From: Jovi Zhang bookj...@gmail.com
 Date: Wed, 18 Jul 2012 17:51:26 +0800
 Subject: [PATCH] uprobe: fix misleading log entry

 There don't have any 'r' prefix in uprobe event naming, remove it.

 Signed-off-by: Jovi Zhang bookj...@gmail.com
 ---
  kernel/trace/trace_uprobe.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
 index cf382de..852a584 100644
 --- a/kernel/trace/trace_uprobe.c
 +++ b/kernel/trace/trace_uprobe.c
 @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
   if (argv[0][0] == '-')
   is_delete = true;
   else if (argv[0][0] != 'p') {
 - pr_info(Probe definition must be started with 'p', 'r' or  
 '-'.\n);
 + pr_info(Probe definition must be started with 'p' or '-'.\n);
   return -EINVAL;
   }


 Yes, uprobes doesnt support return probes. So we should not have
 mentioned about r.
Hmm, Does this have specific reason? or just not implemented?


 Acked-by: Srikar Dronamraju sri...@linux.vnet.ibm.com

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] uprobe: fix misleading log entry

2012-07-18 Thread Anton Arapov 
On Wed, 2012-07-18 at 19:43 +0800, Jovi Zhang wrote:
 On Wed, Jul 18, 2012 at 5:22 PM, Srikar Dronamraju
 sri...@linux.vnet.ibm.com wrote:
  * Jovi Zhang bookj...@gmail.com [2012-07-18 11:08:42]:
 
  From 68232ef2decae95b807f2f3763e8ea99c1a3b2ae Mon Sep 17 00:00:00 2001
  From: Jovi Zhang bookj...@gmail.com
  Date: Wed, 18 Jul 2012 17:51:26 +0800
  Subject: [PATCH] uprobe: fix misleading log entry
 
  There don't have any 'r' prefix in uprobe event naming, remove it.
 
  Signed-off-by: Jovi Zhang bookj...@gmail.com
  ---
   kernel/trace/trace_uprobe.c |2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
 
  diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
  index cf382de..852a584 100644
  --- a/kernel/trace/trace_uprobe.c
  +++ b/kernel/trace/trace_uprobe.c
  @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
if (argv[0][0] == '-')
is_delete = true;
else if (argv[0][0] != 'p') {
  - pr_info(Probe definition must be started with 'p', 'r' or 
   '-'.\n);
  + pr_info(Probe definition must be started with 'p' or 
  '-'.\n);
return -EINVAL;
}
 
 
  Yes, uprobes doesnt support return probes. So we should not have
  mentioned about r.
 Hmm, Does this have specific reason? or just not implemented?

It is not implemented. I'm slowly(very) moving towards it. You are
welcome to take a look.
  https://github.com/arapov/linux-aa/commits/uretprobes

Anton.


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] uprobe: fix misleading log entry

2012-07-17 Thread Jovi Zhang 
>From 68232ef2decae95b807f2f3763e8ea99c1a3b2ae Mon Sep 17 00:00:00 2001
From: Jovi Zhang 
Date: Wed, 18 Jul 2012 17:51:26 +0800
Subject: [PATCH] uprobe: fix misleading log entry

There don't have any 'r' prefix in uprobe event naming, remove it.

Signed-off-by: Jovi Zhang 
---
 kernel/trace/trace_uprobe.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index cf382de..852a584 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
if (argv[0][0] == '-')
is_delete = true;
else if (argv[0][0] != 'p') {
-   pr_info("Probe definition must be started with 'p', 'r' or" " 
'-'.\n");
+   pr_info("Probe definition must be started with 'p' or '-'.\n");
return -EINVAL;
}

-- 
1.7.9.7
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] uprobe: fix misleading log entry

2012-07-17 Thread Jovi Zhang 
From 68232ef2decae95b807f2f3763e8ea99c1a3b2ae Mon Sep 17 00:00:00 2001
From: Jovi Zhang bookj...@gmail.com
Date: Wed, 18 Jul 2012 17:51:26 +0800
Subject: [PATCH] uprobe: fix misleading log entry

There don't have any 'r' prefix in uprobe event naming, remove it.

Signed-off-by: Jovi Zhang bookj...@gmail.com
---
 kernel/trace/trace_uprobe.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index cf382de..852a584 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
if (argv[0][0] == '-')
is_delete = true;
else if (argv[0][0] != 'p') {
-   pr_info(Probe definition must be started with 'p', 'r' or  
'-'.\n);
+   pr_info(Probe definition must be started with 'p' or '-'.\n);
return -EINVAL;
}

-- 
1.7.9.7
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/