Re: [PATCH 06/52] tools/perf/build: Split out feature check: 'stackprotector'
* Namhyung Kim wrote: > On Tue, 8 Oct 2013 12:10:36 +0200, Ingo Molnar wrote: > > -ifeq ($(call try-cc,$(SOURCE_HELLO),$(CFLAGS) -Werror > > -Wstack-protector,-Wstack-protector),y) > > +ifeq ($(feature-stackprotector), 1) > >CFLAGS += -Wstack-protector > > endif > > [SNIP] > > > +test-stackprotector: > > + $(BUILD) -Werror -fstack-protector > > The flag being checked should be -"W"stack-protector instead of > -"f"stack-protector. And the gcc manpage says that -Wstack-protector is > only active when -fstack-protector is active. So the end result should > look like > > $(BUILD) -Werror -fstack-protector -Wstack-protector So, I think this testcase only wanted to check whether GCC knows the option or not, right? Nevertheless I agree that we could add -Wstack-protector to be on the safe side, I'll send a patch for that. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/52] tools/perf/build: Split out feature check: 'stackprotector'
* Namhyung Kim namhy...@kernel.org wrote: On Tue, 8 Oct 2013 12:10:36 +0200, Ingo Molnar wrote: -ifeq ($(call try-cc,$(SOURCE_HELLO),$(CFLAGS) -Werror -Wstack-protector,-Wstack-protector),y) +ifeq ($(feature-stackprotector), 1) CFLAGS += -Wstack-protector endif [SNIP] +test-stackprotector: + $(BUILD) -Werror -fstack-protector The flag being checked should be -Wstack-protector instead of -fstack-protector. And the gcc manpage says that -Wstack-protector is only active when -fstack-protector is active. So the end result should look like $(BUILD) -Werror -fstack-protector -Wstack-protector So, I think this testcase only wanted to check whether GCC knows the option or not, right? Nevertheless I agree that we could add -Wstack-protector to be on the safe side, I'll send a patch for that. Thanks, Ingo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/52] tools/perf/build: Split out feature check: 'stackprotector'
On Tue, 8 Oct 2013 12:10:36 +0200, Ingo Molnar wrote: > -ifeq ($(call try-cc,$(SOURCE_HELLO),$(CFLAGS) -Werror > -Wstack-protector,-Wstack-protector),y) > +ifeq ($(feature-stackprotector), 1) >CFLAGS += -Wstack-protector > endif [SNIP] > +test-stackprotector: > + $(BUILD) -Werror -fstack-protector The flag being checked should be -"W"stack-protector instead of -"f"stack-protector. And the gcc manpage says that -Wstack-protector is only active when -fstack-protector is active. So the end result should look like $(BUILD) -Werror -fstack-protector -Wstack-protector Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/52] tools/perf/build: Split out feature check: 'stackprotector'
On Tue, 8 Oct 2013 12:10:36 +0200, Ingo Molnar wrote: -ifeq ($(call try-cc,$(SOURCE_HELLO),$(CFLAGS) -Werror -Wstack-protector,-Wstack-protector),y) +ifeq ($(feature-stackprotector), 1) CFLAGS += -Wstack-protector endif [SNIP] +test-stackprotector: + $(BUILD) -Werror -fstack-protector The flag being checked should be -Wstack-protector instead of -fstack-protector. And the gcc manpage says that -Wstack-protector is only active when -fstack-protector is active. So the end result should look like $(BUILD) -Werror -fstack-protector -Wstack-protector Thanks, Namhyung -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 06/52] tools/perf/build: Split out feature check: 'stackprotector'
Cc: Arnaldo Carvalho de Melo
Cc: Peter Zijlstra
Cc: Namhyung Kim
Cc: David Ahern
Cc: Jiri Olsa
Link: http://lkml.kernel.org/n/tip-eylyjhskzn6qxkoyjtjic...@git.kernel.org
Signed-off-by: Ingo Molnar
---
tools/perf/config/Makefile | 3 ++-
tools/perf/config/feature-checks/Makefile | 4
tools/perf/config/feature-checks/test-stackprotector.c | 6 ++
3 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index 1a67371..9f94912 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -104,6 +104,7 @@ $(info done)
FEATURE_TESTS =\
hello \
stackprotector-all \
+ stackprotector \
libnuma
$(foreach test,$(FEATURE_TESTS),$(call feature_check,$(test),$(test)))
@@ -112,7 +113,7 @@ ifeq ($(feature-stackprotector-all), 1)
CFLAGS += -fstack-protector-all
endif
-ifeq ($(call try-cc,$(SOURCE_HELLO),$(CFLAGS) -Werror
-Wstack-protector,-Wstack-protector),y)
+ifeq ($(feature-stackprotector), 1)
CFLAGS += -Wstack-protector
endif
diff --git a/tools/perf/config/feature-checks/Makefile
b/tools/perf/config/feature-checks/Makefile
index 7538c14..46b7650 100644
--- a/tools/perf/config/feature-checks/Makefile
+++ b/tools/perf/config/feature-checks/Makefile
@@ -2,6 +2,7 @@
FILES= \
test-hello \
test-stackprotector-all \
+ test-stackprotector \
test-libnuma
CC := $(CC) -MD
@@ -18,6 +19,9 @@ test-hello:
test-stackprotector-all:
$(BUILD) -Werror -fstack-protector-all
+test-stackprotector:
+ $(BUILD) -Werror -fstack-protector
+
test-libnuma:
$(BUILD) -lnuma
diff --git a/tools/perf/config/feature-checks/test-stackprotector.c
b/tools/perf/config/feature-checks/test-stackprotector.c
new file mode 100644
index 000..c9f398d
--- /dev/null
+++ b/tools/perf/config/feature-checks/test-stackprotector.c
@@ -0,0 +1,6 @@
+#include
+
+int main(void)
+{
+ return puts("hi");
+}
--
1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 06/52] tools/perf/build: Split out feature check: 'stackprotector'
Cc: Arnaldo Carvalho de Melo a...@redhat.com
Cc: Peter Zijlstra a.p.zijls...@chello.nl
Cc: Namhyung Kim namhy...@kernel.org
Cc: David Ahern dsah...@gmail.com
Cc: Jiri Olsa jo...@redhat.com
Link: http://lkml.kernel.org/n/tip-eylyjhskzn6qxkoyjtjic...@git.kernel.org
Signed-off-by: Ingo Molnar mi...@kernel.org
---
tools/perf/config/Makefile | 3 ++-
tools/perf/config/feature-checks/Makefile | 4
tools/perf/config/feature-checks/test-stackprotector.c | 6 ++
3 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index 1a67371..9f94912 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -104,6 +104,7 @@ $(info done)
FEATURE_TESTS =\
hello \
stackprotector-all \
+ stackprotector \
libnuma
$(foreach test,$(FEATURE_TESTS),$(call feature_check,$(test),$(test)))
@@ -112,7 +113,7 @@ ifeq ($(feature-stackprotector-all), 1)
CFLAGS += -fstack-protector-all
endif
-ifeq ($(call try-cc,$(SOURCE_HELLO),$(CFLAGS) -Werror
-Wstack-protector,-Wstack-protector),y)
+ifeq ($(feature-stackprotector), 1)
CFLAGS += -Wstack-protector
endif
diff --git a/tools/perf/config/feature-checks/Makefile
b/tools/perf/config/feature-checks/Makefile
index 7538c14..46b7650 100644
--- a/tools/perf/config/feature-checks/Makefile
+++ b/tools/perf/config/feature-checks/Makefile
@@ -2,6 +2,7 @@
FILES= \
test-hello \
test-stackprotector-all \
+ test-stackprotector \
test-libnuma
CC := $(CC) -MD
@@ -18,6 +19,9 @@ test-hello:
test-stackprotector-all:
$(BUILD) -Werror -fstack-protector-all
+test-stackprotector:
+ $(BUILD) -Werror -fstack-protector
+
test-libnuma:
$(BUILD) -lnuma
diff --git a/tools/perf/config/feature-checks/test-stackprotector.c
b/tools/perf/config/feature-checks/test-stackprotector.c
new file mode 100644
index 000..c9f398d
--- /dev/null
+++ b/tools/perf/config/feature-checks/test-stackprotector.c
@@ -0,0 +1,6 @@
+#include stdio.h
+
+int main(void)
+{
+ return puts(hi);
+}
--
1.8.3.1
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
