Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[dawei chien]

Hi Matthias,

On Thu, 2016-08-11 at 17:48 +0200, Matthias Brugger wrote:
> 
> On 11/07/16 10:52, dawei chien wrote:
> > Dear Keerthy,
> >
> > On Thu, 2016-07-07 at 16:39 +0530, Keerthy wrote:
> >>
> >> On Thursday 07 July 2016 02:36 PM, Dawei Chien wrote:
> >>> This adds the device tree binding documentation for the mediatek thermal
> >>> controller found on Mediatek MT2701.
> >>>
> >>> Signed-off-by: Dawei Chien 
> >>> ---
> >>>   .../bindings/thermal/mediatek-thermal.txt  |2 +-
> >>>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git 
> >>> a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
> >>> b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> >>> index 81f9a51..bb55e79 100644
> >>> --- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> >>> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> >>> @@ -8,7 +8,7 @@ apmixedsys register space via AHB bus accesses, so a 
> >>> phandle to the APMIXEDSYS
> >>>   is also needed.
> >>>
> >>>   Required properties:
> >>> -- compatible: "mediatek,mt8173-thermal"
> >>> +- compatible: "mediatek,mt8173-thermal" or "mediatek,mt2701-thermal"
> >>
> >> - compatible :
> >>   - "mediatek,mt8173-thermal" : For MT8173 family of SoCs
> >>   - "mediatek,mt2701-thermal" : For MT2701 family of SoCs
> >
> > Thank you, I will update it on next version.
> >
> 
> Do you know about the compability to older SoCs (e.g. mt6589)?
> It might make sense to add mediatek,mtk-thermal if they are compatible 
> or nearly compatible.

I agree with you that we should add mediatek,mtk-thermal for compatible
or nearly compatible SoC.
However, there is no more compatible SoC so far. Once we have such new
nearly compatible SoC, we would update it on this binding document soon,
thank you.

BR,
Dawei

> >>
> >>>   - reg: Address range of the thermal controller
> >>>   - interrupts: IRQ for the thermal controller
> >>>   - clocks, clock-names: Clocks needed for the thermal controller. 
> >>> required
> >>>
> >
> >

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[dawei chien]

Hi Matthias,

On Thu, 2016-08-11 at 17:48 +0200, Matthias Brugger wrote:
> 
> On 11/07/16 10:52, dawei chien wrote:
> > Dear Keerthy,
> >
> > On Thu, 2016-07-07 at 16:39 +0530, Keerthy wrote:
> >>
> >> On Thursday 07 July 2016 02:36 PM, Dawei Chien wrote:
> >>> This adds the device tree binding documentation for the mediatek thermal
> >>> controller found on Mediatek MT2701.
> >>>
> >>> Signed-off-by: Dawei Chien 
> >>> ---
> >>>   .../bindings/thermal/mediatek-thermal.txt  |2 +-
> >>>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git 
> >>> a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
> >>> b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> >>> index 81f9a51..bb55e79 100644
> >>> --- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> >>> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> >>> @@ -8,7 +8,7 @@ apmixedsys register space via AHB bus accesses, so a 
> >>> phandle to the APMIXEDSYS
> >>>   is also needed.
> >>>
> >>>   Required properties:
> >>> -- compatible: "mediatek,mt8173-thermal"
> >>> +- compatible: "mediatek,mt8173-thermal" or "mediatek,mt2701-thermal"
> >>
> >> - compatible :
> >>   - "mediatek,mt8173-thermal" : For MT8173 family of SoCs
> >>   - "mediatek,mt2701-thermal" : For MT2701 family of SoCs
> >
> > Thank you, I will update it on next version.
> >
> 
> Do you know about the compability to older SoCs (e.g. mt6589)?
> It might make sense to add mediatek,mtk-thermal if they are compatible 
> or nearly compatible.

I agree with you that we should add mediatek,mtk-thermal for compatible
or nearly compatible SoC.
However, there is no more compatible SoC so far. Once we have such new
nearly compatible SoC, we would update it on this binding document soon,
thank you.

BR,
Dawei

> >>
> >>>   - reg: Address range of the thermal controller
> >>>   - interrupts: IRQ for the thermal controller
> >>>   - clocks, clock-names: Clocks needed for the thermal controller. 
> >>> required
> >>>
> >
> >

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Matthias Brugger]

On 11/07/16 10:52, dawei chien wrote:

Dear Keerthy,

On Thu, 2016-07-07 at 16:39 +0530, Keerthy wrote:


On Thursday 07 July 2016 02:36 PM, Dawei Chien wrote:

This adds the device tree binding documentation for the mediatek thermal
controller found on Mediatek MT2701.

Signed-off-by: Dawei Chien 
---
  .../bindings/thermal/mediatek-thermal.txt  |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
index 81f9a51..bb55e79 100644
--- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -8,7 +8,7 @@ apmixedsys register space via AHB bus accesses, so a phandle to 
the APMIXEDSYS
  is also needed.

  Required properties:
-- compatible: "mediatek,mt8173-thermal"
+- compatible: "mediatek,mt8173-thermal" or "mediatek,mt2701-thermal"


- compatible :
  - "mediatek,mt8173-thermal" : For MT8173 family of SoCs
  - "mediatek,mt2701-thermal" : For MT2701 family of SoCs


Thank you, I will update it on next version.



Do you know about the compability to older SoCs (e.g. mt6589)?
It might make sense to add mediatek,mtk-thermal if they are compatible 
or nearly compatible.





  - reg: Address range of the thermal controller
  - interrupts: IRQ for the thermal controller
  - clocks, clock-names: Clocks needed for the thermal controller. required

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Matthias Brugger]

On 11/07/16 10:52, dawei chien wrote:

Dear Keerthy,

On Thu, 2016-07-07 at 16:39 +0530, Keerthy wrote:


On Thursday 07 July 2016 02:36 PM, Dawei Chien wrote:

This adds the device tree binding documentation for the mediatek thermal
controller found on Mediatek MT2701.

Signed-off-by: Dawei Chien 
---
  .../bindings/thermal/mediatek-thermal.txt  |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
index 81f9a51..bb55e79 100644
--- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -8,7 +8,7 @@ apmixedsys register space via AHB bus accesses, so a phandle to 
the APMIXEDSYS
  is also needed.

  Required properties:
-- compatible: "mediatek,mt8173-thermal"
+- compatible: "mediatek,mt8173-thermal" or "mediatek,mt2701-thermal"


- compatible :
  - "mediatek,mt8173-thermal" : For MT8173 family of SoCs
  - "mediatek,mt2701-thermal" : For MT2701 family of SoCs


Thank you, I will update it on next version.



Do you know about the compability to older SoCs (e.g. mt6589)?
It might make sense to add mediatek,mtk-thermal if they are compatible 
or nearly compatible.





  - reg: Address range of the thermal controller
  - interrupts: IRQ for the thermal controller
  - clocks, clock-names: Clocks needed for the thermal controller. required

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[dawei chien]

Dear Keerthy,

On Thu, 2016-07-07 at 16:39 +0530, Keerthy wrote:
> 
> On Thursday 07 July 2016 02:36 PM, Dawei Chien wrote:
> > This adds the device tree binding documentation for the mediatek thermal
> > controller found on Mediatek MT2701.
> >
> > Signed-off-by: Dawei Chien 
> > ---
> >   .../bindings/thermal/mediatek-thermal.txt  |2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
> > b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> > index 81f9a51..bb55e79 100644
> > --- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> > +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> > @@ -8,7 +8,7 @@ apmixedsys register space via AHB bus accesses, so a 
> > phandle to the APMIXEDSYS
> >   is also needed.
> >
> >   Required properties:
> > -- compatible: "mediatek,mt8173-thermal"
> > +- compatible: "mediatek,mt8173-thermal" or "mediatek,mt2701-thermal"
> 
> - compatible :
>   - "mediatek,mt8173-thermal" : For MT8173 family of SoCs
>   - "mediatek,mt2701-thermal" : For MT2701 family of SoCs

Thank you, I will update it on next version.

> 
> >   - reg: Address range of the thermal controller
> >   - interrupts: IRQ for the thermal controller
> >   - clocks, clock-names: Clocks needed for the thermal controller. required
> >

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[dawei chien]

Dear Keerthy,

On Thu, 2016-07-07 at 16:39 +0530, Keerthy wrote:
> 
> On Thursday 07 July 2016 02:36 PM, Dawei Chien wrote:
> > This adds the device tree binding documentation for the mediatek thermal
> > controller found on Mediatek MT2701.
> >
> > Signed-off-by: Dawei Chien 
> > ---
> >   .../bindings/thermal/mediatek-thermal.txt  |2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
> > b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> > index 81f9a51..bb55e79 100644
> > --- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> > +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> > @@ -8,7 +8,7 @@ apmixedsys register space via AHB bus accesses, so a 
> > phandle to the APMIXEDSYS
> >   is also needed.
> >
> >   Required properties:
> > -- compatible: "mediatek,mt8173-thermal"
> > +- compatible: "mediatek,mt8173-thermal" or "mediatek,mt2701-thermal"
> 
> - compatible :
>   - "mediatek,mt8173-thermal" : For MT8173 family of SoCs
>   - "mediatek,mt2701-thermal" : For MT2701 family of SoCs

Thank you, I will update it on next version.

> 
> >   - reg: Address range of the thermal controller
> >   - interrupts: IRQ for the thermal controller
> >   - clocks, clock-names: Clocks needed for the thermal controller. required
> >

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Keerthy]

On Thursday 07 July 2016 02:36 PM, Dawei Chien wrote:

This adds the device tree binding documentation for the mediatek thermal
controller found on Mediatek MT2701.

Signed-off-by: Dawei Chien 
---
  .../bindings/thermal/mediatek-thermal.txt  |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
index 81f9a51..bb55e79 100644
--- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -8,7 +8,7 @@ apmixedsys register space via AHB bus accesses, so a phandle to 
the APMIXEDSYS
  is also needed.

  Required properties:
-- compatible: "mediatek,mt8173-thermal"
+- compatible: "mediatek,mt8173-thermal" or "mediatek,mt2701-thermal"


- compatible :
 - "mediatek,mt8173-thermal" : For MT8173 family of SoCs
 - "mediatek,mt2701-thermal" : For MT2701 family of SoCs


  - reg: Address range of the thermal controller
  - interrupts: IRQ for the thermal controller
  - clocks, clock-names: Clocks needed for the thermal controller. required

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Keerthy]

On Thursday 07 July 2016 02:36 PM, Dawei Chien wrote:

This adds the device tree binding documentation for the mediatek thermal
controller found on Mediatek MT2701.

Signed-off-by: Dawei Chien 
---
  .../bindings/thermal/mediatek-thermal.txt  |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
index 81f9a51..bb55e79 100644
--- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -8,7 +8,7 @@ apmixedsys register space via AHB bus accesses, so a phandle to 
the APMIXEDSYS
  is also needed.

  Required properties:
-- compatible: "mediatek,mt8173-thermal"
+- compatible: "mediatek,mt8173-thermal" or "mediatek,mt2701-thermal"


- compatible :
 - "mediatek,mt8173-thermal" : For MT8173 family of SoCs
 - "mediatek,mt2701-thermal" : For MT2701 family of SoCs


  - reg: Address range of the thermal controller
  - interrupts: IRQ for the thermal controller
  - clocks, clock-names: Clocks needed for the thermal controller. required

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Dawei Chien]

This adds the device tree binding documentation for the mediatek thermal
controller found on Mediatek MT2701.

Signed-off-by: Dawei Chien 
---
 .../bindings/thermal/mediatek-thermal.txt  |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
index 81f9a51..bb55e79 100644
--- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -8,7 +8,7 @@ apmixedsys register space via AHB bus accesses, so a phandle to 
the APMIXEDSYS
 is also needed.
 
 Required properties:
-- compatible: "mediatek,mt8173-thermal"
+- compatible: "mediatek,mt8173-thermal" or "mediatek,mt2701-thermal"
 - reg: Address range of the thermal controller
 - interrupts: IRQ for the thermal controller
 - clocks, clock-names: Clocks needed for the thermal controller. required
-- 
1.7.9.5

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Dawei Chien]

This adds the device tree binding documentation for the mediatek thermal
controller found on Mediatek MT2701.

Signed-off-by: Dawei Chien 
---
 .../bindings/thermal/mediatek-thermal.txt  |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
index 81f9a51..bb55e79 100644
--- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -8,7 +8,7 @@ apmixedsys register space via AHB bus accesses, so a phandle to 
the APMIXEDSYS
 is also needed.
 
 Required properties:
-- compatible: "mediatek,mt8173-thermal"
+- compatible: "mediatek,mt8173-thermal" or "mediatek,mt2701-thermal"
 - reg: Address range of the thermal controller
 - interrupts: IRQ for the thermal controller
 - clocks, clock-names: Clocks needed for the thermal controller. required
-- 
1.7.9.5

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Eduardo Valentin]

Hello Sascha,

On Fri, Dec 18, 2015 at 08:16:33AM +0100, Sascha Hauer wrote:
> On Thu, Dec 17, 2015 at 11:23:31AM -0800, Eduardo Valentin wrote:
> > On Wed, Dec 16, 2015 at 07:23:22PM +0800, Daniel Kurtz wrote:
> > > On Mon, Nov 30, 2015 at 7:42 PM, Sascha Hauer  
> > > wrote:
> > > > +Example:



> > > > +
> > > > +   thermal: thermal@1100b000 {
> > > > +   #thermal-sensor-cells = <1>;
> > > 
> > > Tiny nit: this should now be:
> > > 
> > > #thermal-sensor-cells = <0>;
> > 
> > 
> > This is actually not so tiny'shy. Why does this driver masks out all
> > sensors available? Why don't we expose all of them and use id property
> > to expose and identify each of them?
> 
> This has been the case until v9 of this series. It was requested by
> Mediatek that the CPU frequency regulation works better when the maximum
> of all sensors is taken instead of only single sensors. We decided to
> expose the maximum of all sensors in the device tree. IN the end it will
> be easier to add additional sensors should we need them later than it is
> to get rid of sensors we don't need.

Apologize as I completely missed this transition from v9 to v10. In
fact, I really cannot understand the benefit of having such constraint
implemented in the driver. In device tree you can mark a thermal zone as
status disabled and it won't appear in your system.

One can select which sensors / thermal zones are required. And even
reuse same dtsi, and change status on dts per board. 

The combination of the above, with the possibility to select the maximum
from thermal core / sysfs, would be bring much more flexibility for a
system engineer, than having the maximum coded in the driver, because,
well, changing that relation would require changing the code. If you
keep the driver as simple as possible, changing the this setup later
would be as simple as changing the dts(i).

What do you think?

BR,

> 
> Sascha
> 
> -- 
> Pengutronix e.K.   | |
> Industrial Linux Solutions | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
> Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Eduardo Valentin]

Hello Sascha,

On Fri, Dec 18, 2015 at 08:16:33AM +0100, Sascha Hauer wrote:
> On Thu, Dec 17, 2015 at 11:23:31AM -0800, Eduardo Valentin wrote:
> > On Wed, Dec 16, 2015 at 07:23:22PM +0800, Daniel Kurtz wrote:
> > > On Mon, Nov 30, 2015 at 7:42 PM, Sascha Hauer  
> > > wrote:
> > > > +Example:



> > > > +
> > > > +   thermal: thermal@1100b000 {
> > > > +   #thermal-sensor-cells = <1>;
> > > 
> > > Tiny nit: this should now be:
> > > 
> > > #thermal-sensor-cells = <0>;
> > 
> > 
> > This is actually not so tiny'shy. Why does this driver masks out all
> > sensors available? Why don't we expose all of them and use id property
> > to expose and identify each of them?
> 
> This has been the case until v9 of this series. It was requested by
> Mediatek that the CPU frequency regulation works better when the maximum
> of all sensors is taken instead of only single sensors. We decided to
> expose the maximum of all sensors in the device tree. IN the end it will
> be easier to add additional sensors should we need them later than it is
> to get rid of sensors we don't need.

Apologize as I completely missed this transition from v9 to v10. In
fact, I really cannot understand the benefit of having such constraint
implemented in the driver. In device tree you can mark a thermal zone as
status disabled and it won't appear in your system.

One can select which sensors / thermal zones are required. And even
reuse same dtsi, and change status on dts per board. 

The combination of the above, with the possibility to select the maximum
from thermal core / sysfs, would be bring much more flexibility for a
system engineer, than having the maximum coded in the driver, because,
well, changing that relation would require changing the code. If you
keep the driver as simple as possible, changing the this setup later
would be as simple as changing the dts(i).

What do you think?

BR,

> 
> Sascha
> 
> -- 
> Pengutronix e.K.   | |
> Industrial Linux Solutions | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
> Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

On Thu, Dec 17, 2015 at 11:23:31AM -0800, Eduardo Valentin wrote:
> On Wed, Dec 16, 2015 at 07:23:22PM +0800, Daniel Kurtz wrote:
> > On Mon, Nov 30, 2015 at 7:42 PM, Sascha Hauer  
> > wrote:
> > > This adds the device tree binding documentation for the mediatek thermal
> > > controller found on Mediatek MT8173 and other SoCs.
> > >
> > > Signed-off-by: Sascha Hauer 
> > > Reviewed-by: Daniel Kurtz 
> > > Acked-by: Rob Herring 
> > > ---
> > >  .../bindings/thermal/mediatek-thermal.txt  | 43 
> > > ++
> > >  1 file changed, 43 insertions(+)
> > >  create mode 100644 
> > > Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> > >
> > > diff --git 
> > > a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
> > > b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> > > new file mode 100644
> > > index 000..81f9a51
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> > > @@ -0,0 +1,43 @@
> > > +* Mediatek Thermal
> > > +
> > > +This describes the device tree binding for the Mediatek thermal 
> > > controller
> > > +which measures the on-SoC temperatures. This device does not have its 
> > > own ADC,
> > > +instead it directly controls the AUXADC via AHB bus accesses. For this 
> > > reason
> > > +this device needs phandles to the AUXADC. Also it controls a mux in the
> > > +apmixedsys register space via AHB bus accesses, so a phandle to the 
> > > APMIXEDSYS
> > > +is also needed.
> > > +
> > > +Required properties:
> > > +- compatible: "mediatek,mt8173-thermal"
> > > +- reg: Address range of the thermal controller
> > > +- interrupts: IRQ for the thermal controller
> > > +- clocks, clock-names: Clocks needed for the thermal controller. required
> > > +   clocks are:
> > > +  "therm":  Main clock needed for register access
> > > +  "auxadc": The AUXADC clock
> > > +- resets: Reference to the reset controller controlling the thermal 
> > > controller.
> > > +- mediatek,auxadc: A phandle to the AUXADC which the thermal controller 
> > > uses
> > > +- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
> > > +- #thermal-sensor-cells : Should be 0. See ./thermal.txt for a 
> > > description.
> > > +
> > > +Optional properties:
> > > +- nvmem-cells: A phandle to the calibration data provided by a nvmem 
> > > device. If
> > > +   unspecified default values shall be used.
> > > +- nvmem-cell-names: Should be "calibration-data"
> > > +
> > > +Example:
> > > +
> > > +   thermal: thermal@1100b000 {
> > > +   #thermal-sensor-cells = <1>;
> > 
> > Tiny nit: this should now be:
> > 
> > #thermal-sensor-cells = <0>;
> 
> 
> This is actually not so tiny'shy. Why does this driver masks out all
> sensors available? Why don't we expose all of them and use id property
> to expose and identify each of them?

This has been the case until v9 of this series. It was requested by
Mediatek that the CPU frequency regulation works better when the maximum
of all sensors is taken instead of only single sensors. We decided to
expose the maximum of all sensors in the device tree. IN the end it will
be easier to add additional sensors should we need them later than it is
to get rid of sensors we don't need.

Sascha

-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Eduardo Valentin]

On Wed, Dec 16, 2015 at 07:23:22PM +0800, Daniel Kurtz wrote:
> On Mon, Nov 30, 2015 at 7:42 PM, Sascha Hauer  wrote:
> > This adds the device tree binding documentation for the mediatek thermal
> > controller found on Mediatek MT8173 and other SoCs.
> >
> > Signed-off-by: Sascha Hauer 
> > Reviewed-by: Daniel Kurtz 
> > Acked-by: Rob Herring 
> > ---
> >  .../bindings/thermal/mediatek-thermal.txt  | 43 
> > ++
> >  1 file changed, 43 insertions(+)
> >  create mode 100644 
> > Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> >
> > diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
> > b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> > new file mode 100644
> > index 000..81f9a51
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> > @@ -0,0 +1,43 @@
> > +* Mediatek Thermal
> > +
> > +This describes the device tree binding for the Mediatek thermal controller
> > +which measures the on-SoC temperatures. This device does not have its own 
> > ADC,
> > +instead it directly controls the AUXADC via AHB bus accesses. For this 
> > reason
> > +this device needs phandles to the AUXADC. Also it controls a mux in the
> > +apmixedsys register space via AHB bus accesses, so a phandle to the 
> > APMIXEDSYS
> > +is also needed.
> > +
> > +Required properties:
> > +- compatible: "mediatek,mt8173-thermal"
> > +- reg: Address range of the thermal controller
> > +- interrupts: IRQ for the thermal controller
> > +- clocks, clock-names: Clocks needed for the thermal controller. required
> > +   clocks are:
> > +  "therm":  Main clock needed for register access
> > +  "auxadc": The AUXADC clock
> > +- resets: Reference to the reset controller controlling the thermal 
> > controller.
> > +- mediatek,auxadc: A phandle to the AUXADC which the thermal controller 
> > uses
> > +- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
> > +- #thermal-sensor-cells : Should be 0. See ./thermal.txt for a description.
> > +
> > +Optional properties:
> > +- nvmem-cells: A phandle to the calibration data provided by a nvmem 
> > device. If
> > +   unspecified default values shall be used.
> > +- nvmem-cell-names: Should be "calibration-data"
> > +
> > +Example:
> > +
> > +   thermal: thermal@1100b000 {
> > +   #thermal-sensor-cells = <1>;
> 
> Tiny nit: this should now be:
> 
> #thermal-sensor-cells = <0>;


This is actually not so tiny'shy. Why does this driver masks out all
sensors available? Why don't we expose all of them and use id property
to expose and identify each of them?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Eduardo Valentin]

On Wed, Dec 16, 2015 at 07:23:22PM +0800, Daniel Kurtz wrote:
> On Mon, Nov 30, 2015 at 7:42 PM, Sascha Hauer  wrote:
> > This adds the device tree binding documentation for the mediatek thermal
> > controller found on Mediatek MT8173 and other SoCs.
> >
> > Signed-off-by: Sascha Hauer 
> > Reviewed-by: Daniel Kurtz 
> > Acked-by: Rob Herring 
> > ---
> >  .../bindings/thermal/mediatek-thermal.txt  | 43 
> > ++
> >  1 file changed, 43 insertions(+)
> >  create mode 100644 
> > Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> >
> > diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
> > b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> > new file mode 100644
> > index 000..81f9a51
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> > @@ -0,0 +1,43 @@
> > +* Mediatek Thermal
> > +
> > +This describes the device tree binding for the Mediatek thermal controller
> > +which measures the on-SoC temperatures. This device does not have its own 
> > ADC,
> > +instead it directly controls the AUXADC via AHB bus accesses. For this 
> > reason
> > +this device needs phandles to the AUXADC. Also it controls a mux in the
> > +apmixedsys register space via AHB bus accesses, so a phandle to the 
> > APMIXEDSYS
> > +is also needed.
> > +
> > +Required properties:
> > +- compatible: "mediatek,mt8173-thermal"
> > +- reg: Address range of the thermal controller
> > +- interrupts: IRQ for the thermal controller
> > +- clocks, clock-names: Clocks needed for the thermal controller. required
> > +   clocks are:
> > +  "therm":  Main clock needed for register access
> > +  "auxadc": The AUXADC clock
> > +- resets: Reference to the reset controller controlling the thermal 
> > controller.
> > +- mediatek,auxadc: A phandle to the AUXADC which the thermal controller 
> > uses
> > +- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
> > +- #thermal-sensor-cells : Should be 0. See ./thermal.txt for a description.
> > +
> > +Optional properties:
> > +- nvmem-cells: A phandle to the calibration data provided by a nvmem 
> > device. If
> > +   unspecified default values shall be used.
> > +- nvmem-cell-names: Should be "calibration-data"
> > +
> > +Example:
> > +
> > +   thermal: thermal@1100b000 {
> > +   #thermal-sensor-cells = <1>;
> 
> Tiny nit: this should now be:
> 
> #thermal-sensor-cells = <0>;


This is actually not so tiny'shy. Why does this driver masks out all
sensors available? Why don't we expose all of them and use id property
to expose and identify each of them?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

On Thu, Dec 17, 2015 at 11:23:31AM -0800, Eduardo Valentin wrote:
> On Wed, Dec 16, 2015 at 07:23:22PM +0800, Daniel Kurtz wrote:
> > On Mon, Nov 30, 2015 at 7:42 PM, Sascha Hauer  
> > wrote:
> > > This adds the device tree binding documentation for the mediatek thermal
> > > controller found on Mediatek MT8173 and other SoCs.
> > >
> > > Signed-off-by: Sascha Hauer 
> > > Reviewed-by: Daniel Kurtz 
> > > Acked-by: Rob Herring 
> > > ---
> > >  .../bindings/thermal/mediatek-thermal.txt  | 43 
> > > ++
> > >  1 file changed, 43 insertions(+)
> > >  create mode 100644 
> > > Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> > >
> > > diff --git 
> > > a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
> > > b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> > > new file mode 100644
> > > index 000..81f9a51
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> > > @@ -0,0 +1,43 @@
> > > +* Mediatek Thermal
> > > +
> > > +This describes the device tree binding for the Mediatek thermal 
> > > controller
> > > +which measures the on-SoC temperatures. This device does not have its 
> > > own ADC,
> > > +instead it directly controls the AUXADC via AHB bus accesses. For this 
> > > reason
> > > +this device needs phandles to the AUXADC. Also it controls a mux in the
> > > +apmixedsys register space via AHB bus accesses, so a phandle to the 
> > > APMIXEDSYS
> > > +is also needed.
> > > +
> > > +Required properties:
> > > +- compatible: "mediatek,mt8173-thermal"
> > > +- reg: Address range of the thermal controller
> > > +- interrupts: IRQ for the thermal controller
> > > +- clocks, clock-names: Clocks needed for the thermal controller. required
> > > +   clocks are:
> > > +  "therm":  Main clock needed for register access
> > > +  "auxadc": The AUXADC clock
> > > +- resets: Reference to the reset controller controlling the thermal 
> > > controller.
> > > +- mediatek,auxadc: A phandle to the AUXADC which the thermal controller 
> > > uses
> > > +- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
> > > +- #thermal-sensor-cells : Should be 0. See ./thermal.txt for a 
> > > description.
> > > +
> > > +Optional properties:
> > > +- nvmem-cells: A phandle to the calibration data provided by a nvmem 
> > > device. If
> > > +   unspecified default values shall be used.
> > > +- nvmem-cell-names: Should be "calibration-data"
> > > +
> > > +Example:
> > > +
> > > +   thermal: thermal@1100b000 {
> > > +   #thermal-sensor-cells = <1>;
> > 
> > Tiny nit: this should now be:
> > 
> > #thermal-sensor-cells = <0>;
> 
> 
> This is actually not so tiny'shy. Why does this driver masks out all
> sensors available? Why don't we expose all of them and use id property
> to expose and identify each of them?

This has been the case until v9 of this series. It was requested by
Mediatek that the CPU frequency regulation works better when the maximum
of all sensors is taken instead of only single sensors. We decided to
expose the maximum of all sensors in the device tree. IN the end it will
be easier to add additional sensors should we need them later than it is
to get rid of sensors we don't need.

Sascha

-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Daniel Kurtz]

On Mon, Nov 30, 2015 at 7:42 PM, Sascha Hauer  wrote:
> This adds the device tree binding documentation for the mediatek thermal
> controller found on Mediatek MT8173 and other SoCs.
>
> Signed-off-by: Sascha Hauer 
> Reviewed-by: Daniel Kurtz 
> Acked-by: Rob Herring 
> ---
>  .../bindings/thermal/mediatek-thermal.txt  | 43 
> ++
>  1 file changed, 43 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
>
> diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
> b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> new file mode 100644
> index 000..81f9a51
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> @@ -0,0 +1,43 @@
> +* Mediatek Thermal
> +
> +This describes the device tree binding for the Mediatek thermal controller
> +which measures the on-SoC temperatures. This device does not have its own 
> ADC,
> +instead it directly controls the AUXADC via AHB bus accesses. For this reason
> +this device needs phandles to the AUXADC. Also it controls a mux in the
> +apmixedsys register space via AHB bus accesses, so a phandle to the 
> APMIXEDSYS
> +is also needed.
> +
> +Required properties:
> +- compatible: "mediatek,mt8173-thermal"
> +- reg: Address range of the thermal controller
> +- interrupts: IRQ for the thermal controller
> +- clocks, clock-names: Clocks needed for the thermal controller. required
> +   clocks are:
> +  "therm":  Main clock needed for register access
> +  "auxadc": The AUXADC clock
> +- resets: Reference to the reset controller controlling the thermal 
> controller.
> +- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
> +- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
> +- #thermal-sensor-cells : Should be 0. See ./thermal.txt for a description.
> +
> +Optional properties:
> +- nvmem-cells: A phandle to the calibration data provided by a nvmem device. 
> If
> +   unspecified default values shall be used.
> +- nvmem-cell-names: Should be "calibration-data"
> +
> +Example:
> +
> +   thermal: thermal@1100b000 {
> +   #thermal-sensor-cells = <1>;

Tiny nit: this should now be:

#thermal-sensor-cells = <0>;

> +   compatible = "mediatek,mt8173-thermal";
> +   reg = <0 0x1100b000 0 0x1000>;
> +   interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
> +   clocks = < CLK_PERI_THERM>, < 
> CLK_PERI_AUXADC>;
> +   clock-names = "therm", "auxadc";
> +   resets = < MT8173_PERI_THERM_SW_RST>;
> +   reset-names = "therm";
> +   mediatek,auxadc = <>;
> +   mediatek,apmixedsys = <>;
> +   nvmem-cells = <_calibration_data>;
> +   nvmem-cell-names = "calibration-data";
> +   };
> --
> 2.6.2
>
>
> ___
> Linux-mediatek mailing list
> linux-media...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Daniel Kurtz]

On Mon, Nov 30, 2015 at 7:42 PM, Sascha Hauer  wrote:
> This adds the device tree binding documentation for the mediatek thermal
> controller found on Mediatek MT8173 and other SoCs.
>
> Signed-off-by: Sascha Hauer 
> Reviewed-by: Daniel Kurtz 
> Acked-by: Rob Herring 
> ---
>  .../bindings/thermal/mediatek-thermal.txt  | 43 
> ++
>  1 file changed, 43 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
>
> diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
> b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> new file mode 100644
> index 000..81f9a51
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> @@ -0,0 +1,43 @@
> +* Mediatek Thermal
> +
> +This describes the device tree binding for the Mediatek thermal controller
> +which measures the on-SoC temperatures. This device does not have its own 
> ADC,
> +instead it directly controls the AUXADC via AHB bus accesses. For this reason
> +this device needs phandles to the AUXADC. Also it controls a mux in the
> +apmixedsys register space via AHB bus accesses, so a phandle to the 
> APMIXEDSYS
> +is also needed.
> +
> +Required properties:
> +- compatible: "mediatek,mt8173-thermal"
> +- reg: Address range of the thermal controller
> +- interrupts: IRQ for the thermal controller
> +- clocks, clock-names: Clocks needed for the thermal controller. required
> +   clocks are:
> +  "therm":  Main clock needed for register access
> +  "auxadc": The AUXADC clock
> +- resets: Reference to the reset controller controlling the thermal 
> controller.
> +- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
> +- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
> +- #thermal-sensor-cells : Should be 0. See ./thermal.txt for a description.
> +
> +Optional properties:
> +- nvmem-cells: A phandle to the calibration data provided by a nvmem device. 
> If
> +   unspecified default values shall be used.
> +- nvmem-cell-names: Should be "calibration-data"
> +
> +Example:
> +
> +   thermal: thermal@1100b000 {
> +   #thermal-sensor-cells = <1>;

Tiny nit: this should now be:

#thermal-sensor-cells = <0>;

> +   compatible = "mediatek,mt8173-thermal";
> +   reg = <0 0x1100b000 0 0x1000>;
> +   interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
> +   clocks = < CLK_PERI_THERM>, < 
> CLK_PERI_AUXADC>;
> +   clock-names = "therm", "auxadc";
> +   resets = < MT8173_PERI_THERM_SW_RST>;
> +   reset-names = "therm";
> +   mediatek,auxadc = <>;
> +   mediatek,apmixedsys = <>;
> +   nvmem-cells = <_calibration_data>;
> +   nvmem-cell-names = "calibration-data";
> +   };
> --
> 2.6.2
>
>
> ___
> Linux-mediatek mailing list
> linux-media...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

This adds the device tree binding documentation for the mediatek thermal
controller found on Mediatek MT8173 and other SoCs.

Signed-off-by: Sascha Hauer 
Reviewed-by: Daniel Kurtz 
Acked-by: Rob Herring 
---
 .../bindings/thermal/mediatek-thermal.txt  | 43 ++
 1 file changed, 43 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
new file mode 100644
index 000..81f9a51
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -0,0 +1,43 @@
+* Mediatek Thermal
+
+This describes the device tree binding for the Mediatek thermal controller
+which measures the on-SoC temperatures. This device does not have its own ADC,
+instead it directly controls the AUXADC via AHB bus accesses. For this reason
+this device needs phandles to the AUXADC. Also it controls a mux in the
+apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+is also needed.
+
+Required properties:
+- compatible: "mediatek,mt8173-thermal"
+- reg: Address range of the thermal controller
+- interrupts: IRQ for the thermal controller
+- clocks, clock-names: Clocks needed for the thermal controller. required
+   clocks are:
+  "therm":  Main clock needed for register access
+  "auxadc": The AUXADC clock
+- resets: Reference to the reset controller controlling the thermal controller.
+- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
+- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
+- #thermal-sensor-cells : Should be 0. See ./thermal.txt for a description.
+
+Optional properties:
+- nvmem-cells: A phandle to the calibration data provided by a nvmem device. If
+   unspecified default values shall be used.
+- nvmem-cell-names: Should be "calibration-data"
+
+Example:
+
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = <1>;
+   compatible = "mediatek,mt8173-thermal";
+   reg = <0 0x1100b000 0 0x1000>;
+   interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
+   clocks = < CLK_PERI_THERM>, < CLK_PERI_AUXADC>;
+   clock-names = "therm", "auxadc";
+   resets = < MT8173_PERI_THERM_SW_RST>;
+   reset-names = "therm";
+   mediatek,auxadc = <>;
+   mediatek,apmixedsys = <>;
+   nvmem-cells = <_calibration_data>;
+   nvmem-cell-names = "calibration-data";
+   };
-- 
2.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

This adds the device tree binding documentation for the mediatek thermal
controller found on Mediatek MT8173 and other SoCs.

Signed-off-by: Sascha Hauer 
Reviewed-by: Daniel Kurtz 
Acked-by: Rob Herring 
---
 .../bindings/thermal/mediatek-thermal.txt  | 43 ++
 1 file changed, 43 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
new file mode 100644
index 000..81f9a51
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -0,0 +1,43 @@
+* Mediatek Thermal
+
+This describes the device tree binding for the Mediatek thermal controller
+which measures the on-SoC temperatures. This device does not have its own ADC,
+instead it directly controls the AUXADC via AHB bus accesses. For this reason
+this device needs phandles to the AUXADC. Also it controls a mux in the
+apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+is also needed.
+
+Required properties:
+- compatible: "mediatek,mt8173-thermal"
+- reg: Address range of the thermal controller
+- interrupts: IRQ for the thermal controller
+- clocks, clock-names: Clocks needed for the thermal controller. required
+   clocks are:
+  "therm":  Main clock needed for register access
+  "auxadc": The AUXADC clock
+- resets: Reference to the reset controller controlling the thermal controller.
+- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
+- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
+- #thermal-sensor-cells : Should be 0. See ./thermal.txt for a description.
+
+Optional properties:
+- nvmem-cells: A phandle to the calibration data provided by a nvmem device. If
+   unspecified default values shall be used.
+- nvmem-cell-names: Should be "calibration-data"
+
+Example:
+
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = <1>;
+   compatible = "mediatek,mt8173-thermal";
+   reg = <0 0x1100b000 0 0x1000>;
+   interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
+   clocks = < CLK_PERI_THERM>, < CLK_PERI_AUXADC>;
+   clock-names = "therm", "auxadc";
+   resets = < MT8173_PERI_THERM_SW_RST>;
+   reset-names = "therm";
+   mediatek,auxadc = <>;
+   mediatek,apmixedsys = <>;
+   nvmem-cells = <_calibration_data>;
+   nvmem-cell-names = "calibration-data";
+   };
-- 
2.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

This adds the device tree binding documentation for the mediatek thermal
controller found on Mediatek MT8173 and other SoCs.

Signed-off-by: Sascha Hauer 
Reviewed-by: Daniel Kurtz 
Acked-by: Rob Herring 
---
 .../bindings/thermal/mediatek-thermal.txt  | 43 ++
 1 file changed, 43 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
new file mode 100644
index 000..81f9a51
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -0,0 +1,43 @@
+* Mediatek Thermal
+
+This describes the device tree binding for the Mediatek thermal controller
+which measures the on-SoC temperatures. This device does not have its own ADC,
+instead it directly controls the AUXADC via AHB bus accesses. For this reason
+this device needs phandles to the AUXADC. Also it controls a mux in the
+apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+is also needed.
+
+Required properties:
+- compatible: "mediatek,mt8173-thermal"
+- reg: Address range of the thermal controller
+- interrupts: IRQ for the thermal controller
+- clocks, clock-names: Clocks needed for the thermal controller. required
+   clocks are:
+  "therm":  Main clock needed for register access
+  "auxadc": The AUXADC clock
+- resets: Reference to the reset controller controlling the thermal controller.
+- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
+- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
+- #thermal-sensor-cells : Should be 0. See ./thermal.txt for a description.
+
+Optional properties:
+- nvmem-cells: A phandle to the calibration data provided by a nvmem device. If
+   unspecified default values shall be used.
+- nvmem-cell-names: Should be "calibration-data"
+
+Example:
+
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = <1>;
+   compatible = "mediatek,mt8173-thermal";
+   reg = <0 0x1100b000 0 0x1000>;
+   interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
+   clocks = < CLK_PERI_THERM>, < CLK_PERI_AUXADC>;
+   clock-names = "therm", "auxadc";
+   resets = < MT8173_PERI_THERM_SW_RST>;
+   reset-names = "therm";
+   mediatek,auxadc = <>;
+   mediatek,apmixedsys = <>;
+   nvmem-cells = <_calibration_data>;
+   nvmem-cell-names = "calibration-data";
+   };
-- 
2.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

This adds the device tree binding documentation for the mediatek thermal
controller found on Mediatek MT8173 and other SoCs.

Signed-off-by: Sascha Hauer 
Reviewed-by: Daniel Kurtz 
Acked-by: Rob Herring 
---
 .../bindings/thermal/mediatek-thermal.txt  | 43 ++
 1 file changed, 43 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
new file mode 100644
index 000..81f9a51
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -0,0 +1,43 @@
+* Mediatek Thermal
+
+This describes the device tree binding for the Mediatek thermal controller
+which measures the on-SoC temperatures. This device does not have its own ADC,
+instead it directly controls the AUXADC via AHB bus accesses. For this reason
+this device needs phandles to the AUXADC. Also it controls a mux in the
+apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+is also needed.
+
+Required properties:
+- compatible: "mediatek,mt8173-thermal"
+- reg: Address range of the thermal controller
+- interrupts: IRQ for the thermal controller
+- clocks, clock-names: Clocks needed for the thermal controller. required
+   clocks are:
+  "therm":  Main clock needed for register access
+  "auxadc": The AUXADC clock
+- resets: Reference to the reset controller controlling the thermal controller.
+- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
+- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
+- #thermal-sensor-cells : Should be 0. See ./thermal.txt for a description.
+
+Optional properties:
+- nvmem-cells: A phandle to the calibration data provided by a nvmem device. If
+   unspecified default values shall be used.
+- nvmem-cell-names: Should be "calibration-data"
+
+Example:
+
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = <1>;
+   compatible = "mediatek,mt8173-thermal";
+   reg = <0 0x1100b000 0 0x1000>;
+   interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
+   clocks = < CLK_PERI_THERM>, < CLK_PERI_AUXADC>;
+   clock-names = "therm", "auxadc";
+   resets = < MT8173_PERI_THERM_SW_RST>;
+   reset-names = "therm";
+   mediatek,auxadc = <>;
+   mediatek,apmixedsys = <>;
+   nvmem-cells = <_calibration_data>;
+   nvmem-cell-names = "calibration-data";
+   };
-- 
2.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Rob Herring]

On Mon, Nov 09, 2015 at 11:13:31AM +0100, Sascha Hauer wrote:
> This adds the device tree binding documentation for the mediatek thermal
> controller found on Mediatek MT8173 and other SoCs.
> 
> Signed-off-by: Sascha Hauer 
> Reviewed-by: Daniel Kurtz 

Acked-by: Rob Herring 

> ---
>  .../bindings/thermal/mediatek-thermal.txt  | 43 
> ++
>  1 file changed, 43 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> 
> diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
> b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> new file mode 100644
> index 000..81f9a51
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> @@ -0,0 +1,43 @@
> +* Mediatek Thermal
> +
> +This describes the device tree binding for the Mediatek thermal controller
> +which measures the on-SoC temperatures. This device does not have its own 
> ADC,
> +instead it directly controls the AUXADC via AHB bus accesses. For this reason
> +this device needs phandles to the AUXADC. Also it controls a mux in the
> +apmixedsys register space via AHB bus accesses, so a phandle to the 
> APMIXEDSYS
> +is also needed.
> +
> +Required properties:
> +- compatible: "mediatek,mt8173-thermal"
> +- reg: Address range of the thermal controller
> +- interrupts: IRQ for the thermal controller
> +- clocks, clock-names: Clocks needed for the thermal controller. required
> +   clocks are:
> +"therm":  Main clock needed for register access
> +"auxadc": The AUXADC clock
> +- resets: Reference to the reset controller controlling the thermal 
> controller.
> +- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
> +- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
> +- #thermal-sensor-cells : Should be 0. See ./thermal.txt for a description.
> +
> +Optional properties:
> +- nvmem-cells: A phandle to the calibration data provided by a nvmem device. 
> If
> +   unspecified default values shall be used.
> +- nvmem-cell-names: Should be "calibration-data"
> +
> +Example:
> +
> + thermal: thermal@1100b000 {
> + #thermal-sensor-cells = <1>;
> + compatible = "mediatek,mt8173-thermal";
> + reg = <0 0x1100b000 0 0x1000>;
> + interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
> + clocks = < CLK_PERI_THERM>, < CLK_PERI_AUXADC>;
> + clock-names = "therm", "auxadc";
> + resets = < MT8173_PERI_THERM_SW_RST>;
> + reset-names = "therm";
> + mediatek,auxadc = <>;
> + mediatek,apmixedsys = <>;
> + nvmem-cells = <_calibration_data>;
> + nvmem-cell-names = "calibration-data";
> + };
> -- 
> 2.6.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

This adds the device tree binding documentation for the mediatek thermal
controller found on Mediatek MT8173 and other SoCs.

Signed-off-by: Sascha Hauer 
Reviewed-by: Daniel Kurtz 
---
 .../bindings/thermal/mediatek-thermal.txt  | 43 ++
 1 file changed, 43 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
new file mode 100644
index 000..81f9a51
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -0,0 +1,43 @@
+* Mediatek Thermal
+
+This describes the device tree binding for the Mediatek thermal controller
+which measures the on-SoC temperatures. This device does not have its own ADC,
+instead it directly controls the AUXADC via AHB bus accesses. For this reason
+this device needs phandles to the AUXADC. Also it controls a mux in the
+apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+is also needed.
+
+Required properties:
+- compatible: "mediatek,mt8173-thermal"
+- reg: Address range of the thermal controller
+- interrupts: IRQ for the thermal controller
+- clocks, clock-names: Clocks needed for the thermal controller. required
+   clocks are:
+  "therm":  Main clock needed for register access
+  "auxadc": The AUXADC clock
+- resets: Reference to the reset controller controlling the thermal controller.
+- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
+- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
+- #thermal-sensor-cells : Should be 0. See ./thermal.txt for a description.
+
+Optional properties:
+- nvmem-cells: A phandle to the calibration data provided by a nvmem device. If
+   unspecified default values shall be used.
+- nvmem-cell-names: Should be "calibration-data"
+
+Example:
+
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = <1>;
+   compatible = "mediatek,mt8173-thermal";
+   reg = <0 0x1100b000 0 0x1000>;
+   interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
+   clocks = < CLK_PERI_THERM>, < CLK_PERI_AUXADC>;
+   clock-names = "therm", "auxadc";
+   resets = < MT8173_PERI_THERM_SW_RST>;
+   reset-names = "therm";
+   mediatek,auxadc = <>;
+   mediatek,apmixedsys = <>;
+   nvmem-cells = <_calibration_data>;
+   nvmem-cell-names = "calibration-data";
+   };
-- 
2.6.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Rob Herring]

On Mon, Nov 09, 2015 at 11:13:31AM +0100, Sascha Hauer wrote:
> This adds the device tree binding documentation for the mediatek thermal
> controller found on Mediatek MT8173 and other SoCs.
> 
> Signed-off-by: Sascha Hauer 
> Reviewed-by: Daniel Kurtz 

Acked-by: Rob Herring 

> ---
>  .../bindings/thermal/mediatek-thermal.txt  | 43 
> ++
>  1 file changed, 43 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> 
> diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
> b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> new file mode 100644
> index 000..81f9a51
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> @@ -0,0 +1,43 @@
> +* Mediatek Thermal
> +
> +This describes the device tree binding for the Mediatek thermal controller
> +which measures the on-SoC temperatures. This device does not have its own 
> ADC,
> +instead it directly controls the AUXADC via AHB bus accesses. For this reason
> +this device needs phandles to the AUXADC. Also it controls a mux in the
> +apmixedsys register space via AHB bus accesses, so a phandle to the 
> APMIXEDSYS
> +is also needed.
> +
> +Required properties:
> +- compatible: "mediatek,mt8173-thermal"
> +- reg: Address range of the thermal controller
> +- interrupts: IRQ for the thermal controller
> +- clocks, clock-names: Clocks needed for the thermal controller. required
> +   clocks are:
> +"therm":  Main clock needed for register access
> +"auxadc": The AUXADC clock
> +- resets: Reference to the reset controller controlling the thermal 
> controller.
> +- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
> +- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
> +- #thermal-sensor-cells : Should be 0. See ./thermal.txt for a description.
> +
> +Optional properties:
> +- nvmem-cells: A phandle to the calibration data provided by a nvmem device. 
> If
> +   unspecified default values shall be used.
> +- nvmem-cell-names: Should be "calibration-data"
> +
> +Example:
> +
> + thermal: thermal@1100b000 {
> + #thermal-sensor-cells = <1>;
> + compatible = "mediatek,mt8173-thermal";
> + reg = <0 0x1100b000 0 0x1000>;
> + interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
> + clocks = < CLK_PERI_THERM>, < CLK_PERI_AUXADC>;
> + clock-names = "therm", "auxadc";
> + resets = < MT8173_PERI_THERM_SW_RST>;
> + reset-names = "therm";
> + mediatek,auxadc = <>;
> + mediatek,apmixedsys = <>;
> + nvmem-cells = <_calibration_data>;
> + nvmem-cell-names = "calibration-data";
> + };
> -- 
> 2.6.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

This adds the device tree binding documentation for the mediatek thermal
controller found on Mediatek MT8173 and other SoCs.

Signed-off-by: Sascha Hauer 
Reviewed-by: Daniel Kurtz 
---
 .../bindings/thermal/mediatek-thermal.txt  | 43 ++
 1 file changed, 43 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
new file mode 100644
index 000..81f9a51
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -0,0 +1,43 @@
+* Mediatek Thermal
+
+This describes the device tree binding for the Mediatek thermal controller
+which measures the on-SoC temperatures. This device does not have its own ADC,
+instead it directly controls the AUXADC via AHB bus accesses. For this reason
+this device needs phandles to the AUXADC. Also it controls a mux in the
+apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+is also needed.
+
+Required properties:
+- compatible: "mediatek,mt8173-thermal"
+- reg: Address range of the thermal controller
+- interrupts: IRQ for the thermal controller
+- clocks, clock-names: Clocks needed for the thermal controller. required
+   clocks are:
+  "therm":  Main clock needed for register access
+  "auxadc": The AUXADC clock
+- resets: Reference to the reset controller controlling the thermal controller.
+- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
+- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
+- #thermal-sensor-cells : Should be 0. See ./thermal.txt for a description.
+
+Optional properties:
+- nvmem-cells: A phandle to the calibration data provided by a nvmem device. If
+   unspecified default values shall be used.
+- nvmem-cell-names: Should be "calibration-data"
+
+Example:
+
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = <1>;
+   compatible = "mediatek,mt8173-thermal";
+   reg = <0 0x1100b000 0 0x1000>;
+   interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
+   clocks = < CLK_PERI_THERM>, < CLK_PERI_AUXADC>;
+   clock-names = "therm", "auxadc";
+   resets = < MT8173_PERI_THERM_SW_RST>;
+   reset-names = "therm";
+   mediatek,auxadc = <>;
+   mediatek,apmixedsys = <>;
+   nvmem-cells = <_calibration_data>;
+   nvmem-cell-names = "calibration-data";
+   };
-- 
2.6.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

This adds the device tree binding documentation for the mediatek thermal
controller found on Mediatek MT8173 and other SoCs.

Signed-off-by: Sascha Hauer 
Reviewed-by: Daniel Kurtz 
---
 .../bindings/thermal/mediatek-thermal.txt  | 38 ++
 include/dt-bindings/thermal/mt8173.h   | 13 
 2 files changed, 51 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
 create mode 100644 include/dt-bindings/thermal/mt8173.h

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
new file mode 100644
index 000..1697375
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -0,0 +1,38 @@
+* Mediatek Thermal
+
+This describes the device tree binding for the Mediatek thermal controller
+which measures the on-SoC temperatures. This device does not have its own ADC,
+instead it directly controls the AUXADC via AHB bus accesses. For this reason
+this device needs phandles to the AUXADC. Also it controls a mux in the
+apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+is also needed.
+
+Required properties:
+- compatible: "mediatek,mt8173-thermal"
+- reg: Address range of the thermal controller
+- interrupts: IRQ for the thermal controller
+- clocks, clock-names: Clocks needed for the thermal controller. required
+   clocks are:
+  "therm":  Main clock needed for register access
+  "auxadc": The AUXADC clock
+- resets: Reference to the reset controller controlling the thermal controller.
+- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
+- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
+- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description. See
+ include/dt-bindings/thermal/mt8173.h for valid sensor
+ numbers.
+
+Example:
+
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = <1>;
+   compatible = "mediatek,mt8173-thermal";
+   reg = <0 0x1100b000 0 0x1000>;
+   interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
+   clocks = < CLK_PERI_THERM>, < CLK_PERI_AUXADC>;
+   clock-names = "therm", "auxadc";
+   resets = < MT8173_PERI_THERM_SW_RST>;
+   reset-names = "therm";
+   mediatek,auxadc = <>;
+   mediatek,apmixedsys = <>;
+   };
diff --git a/include/dt-bindings/thermal/mt8173.h 
b/include/dt-bindings/thermal/mt8173.h
new file mode 100644
index 000..692e74c
--- /dev/null
+++ b/include/dt-bindings/thermal/mt8173.h
@@ -0,0 +1,13 @@
+/*
+ * This header provides constants for mediatek,mt8173-thermal
+ */
+
+#ifndef _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
+#define _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
+
+#define MT8173_THERMAL_ZONE_CA53   0
+#define MT8173_THERMAL_ZONE_CA57   1
+#define MT8173_THERMAL_ZONE_GPU2
+#define MT8173_THERMAL_ZONE_CORE   3
+
+#endif /* _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H */
-- 
2.5.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

This adds the device tree binding documentation for the mediatek thermal
controller found on Mediatek MT8173 and other SoCs.

Signed-off-by: Sascha Hauer 
Reviewed-by: Daniel Kurtz 
---
 .../bindings/thermal/mediatek-thermal.txt  | 38 ++
 include/dt-bindings/thermal/mt8173.h   | 13 
 2 files changed, 51 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
 create mode 100644 include/dt-bindings/thermal/mt8173.h

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
new file mode 100644
index 000..1697375
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -0,0 +1,38 @@
+* Mediatek Thermal
+
+This describes the device tree binding for the Mediatek thermal controller
+which measures the on-SoC temperatures. This device does not have its own ADC,
+instead it directly controls the AUXADC via AHB bus accesses. For this reason
+this device needs phandles to the AUXADC. Also it controls a mux in the
+apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+is also needed.
+
+Required properties:
+- compatible: "mediatek,mt8173-thermal"
+- reg: Address range of the thermal controller
+- interrupts: IRQ for the thermal controller
+- clocks, clock-names: Clocks needed for the thermal controller. required
+   clocks are:
+  "therm":  Main clock needed for register access
+  "auxadc": The AUXADC clock
+- resets: Reference to the reset controller controlling the thermal controller.
+- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
+- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
+- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description. See
+ include/dt-bindings/thermal/mt8173.h for valid sensor
+ numbers.
+
+Example:
+
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = <1>;
+   compatible = "mediatek,mt8173-thermal";
+   reg = <0 0x1100b000 0 0x1000>;
+   interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
+   clocks = < CLK_PERI_THERM>, < CLK_PERI_AUXADC>;
+   clock-names = "therm", "auxadc";
+   resets = < MT8173_PERI_THERM_SW_RST>;
+   reset-names = "therm";
+   mediatek,auxadc = <>;
+   mediatek,apmixedsys = <>;
+   };
diff --git a/include/dt-bindings/thermal/mt8173.h 
b/include/dt-bindings/thermal/mt8173.h
new file mode 100644
index 000..692e74c
--- /dev/null
+++ b/include/dt-bindings/thermal/mt8173.h
@@ -0,0 +1,13 @@
+/*
+ * This header provides constants for mediatek,mt8173-thermal
+ */
+
+#ifndef _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
+#define _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
+
+#define MT8173_THERMAL_ZONE_CA53   0
+#define MT8173_THERMAL_ZONE_CA57   1
+#define MT8173_THERMAL_ZONE_GPU2
+#define MT8173_THERMAL_ZONE_CORE   3
+
+#endif /* _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H */
-- 
2.5.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

On Mon, Aug 31, 2015 at 09:34:04AM +0200, Sascha Hauer wrote:
> Signed-off-by: Sascha Hauer 
> Reviewed-by: Daniel Kurtz 

Uh, still forgot the commit log. Will add something like:

This adds the device tree binding documentation for the mediatek thermal
controller found on Mediatek MT8173 and other SoCs.

Sascha

> ---
>  .../bindings/thermal/mediatek-thermal.txt  | 38 
> ++
>  include/dt-bindings/thermal/mt8173.h   | 13 
>  2 files changed, 51 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
>  create mode 100644 include/dt-bindings/thermal/mt8173.h
> 
> diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
> b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> new file mode 100644
> index 000..1697375
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> @@ -0,0 +1,38 @@
> +* Mediatek Thermal
> +
> +This describes the device tree binding for the Mediatek thermal controller
> +which measures the on-SoC temperatures. This device does not have its own 
> ADC,
> +instead it directly controls the AUXADC via AHB bus accesses. For this reason
> +this device needs phandles to the AUXADC. Also it controls a mux in the
> +apmixedsys register space via AHB bus accesses, so a phandle to the 
> APMIXEDSYS
> +is also needed.
> +
> +Required properties:
> +- compatible: "mediatek,mt8173-thermal"
> +- reg: Address range of the thermal controller
> +- interrupts: IRQ for the thermal controller
> +- clocks, clock-names: Clocks needed for the thermal controller. required
> +   clocks are:
> +"therm":  Main clock needed for register access
> +"auxadc": The AUXADC clock
> +- resets: Reference to the reset controller controlling the thermal 
> controller.
> +- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
> +- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
> +- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description. 
> See
> +   include/dt-bindings/thermal/mt8173.h for valid sensor
> +   numbers.
> +
> +Example:
> +
> + thermal: thermal@1100b000 {
> + #thermal-sensor-cells = <1>;
> + compatible = "mediatek,mt8173-thermal";
> + reg = <0 0x1100b000 0 0x1000>;
> + interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
> + clocks = < CLK_PERI_THERM>, < CLK_PERI_AUXADC>;
> + clock-names = "therm", "auxadc";
> + resets = < MT8173_PERI_THERM_SW_RST>;
> + reset-names = "therm";
> + mediatek,auxadc = <>;
> + mediatek,apmixedsys = <>;
> + };
> diff --git a/include/dt-bindings/thermal/mt8173.h 
> b/include/dt-bindings/thermal/mt8173.h
> new file mode 100644
> index 000..692e74c
> --- /dev/null
> +++ b/include/dt-bindings/thermal/mt8173.h
> @@ -0,0 +1,13 @@
> +/*
> + * This header provides constants for mediatek,mt8173-thermal
> + */
> +
> +#ifndef _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
> +#define _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
> +
> +#define MT8173_THERMAL_ZONE_CA53 0
> +#define MT8173_THERMAL_ZONE_CA57 1
> +#define MT8173_THERMAL_ZONE_GPU  2
> +#define MT8173_THERMAL_ZONE_CORE 3
> +
> +#endif /* _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H */
> -- 
> 2.5.0
> 
> 

-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

Signed-off-by: Sascha Hauer 
Reviewed-by: Daniel Kurtz 
---
 .../bindings/thermal/mediatek-thermal.txt  | 38 ++
 include/dt-bindings/thermal/mt8173.h   | 13 
 2 files changed, 51 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
 create mode 100644 include/dt-bindings/thermal/mt8173.h

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
new file mode 100644
index 000..1697375
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -0,0 +1,38 @@
+* Mediatek Thermal
+
+This describes the device tree binding for the Mediatek thermal controller
+which measures the on-SoC temperatures. This device does not have its own ADC,
+instead it directly controls the AUXADC via AHB bus accesses. For this reason
+this device needs phandles to the AUXADC. Also it controls a mux in the
+apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+is also needed.
+
+Required properties:
+- compatible: "mediatek,mt8173-thermal"
+- reg: Address range of the thermal controller
+- interrupts: IRQ for the thermal controller
+- clocks, clock-names: Clocks needed for the thermal controller. required
+   clocks are:
+  "therm":  Main clock needed for register access
+  "auxadc": The AUXADC clock
+- resets: Reference to the reset controller controlling the thermal controller.
+- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
+- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
+- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description. See
+ include/dt-bindings/thermal/mt8173.h for valid sensor
+ numbers.
+
+Example:
+
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = <1>;
+   compatible = "mediatek,mt8173-thermal";
+   reg = <0 0x1100b000 0 0x1000>;
+   interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
+   clocks = < CLK_PERI_THERM>, < CLK_PERI_AUXADC>;
+   clock-names = "therm", "auxadc";
+   resets = < MT8173_PERI_THERM_SW_RST>;
+   reset-names = "therm";
+   mediatek,auxadc = <>;
+   mediatek,apmixedsys = <>;
+   };
diff --git a/include/dt-bindings/thermal/mt8173.h 
b/include/dt-bindings/thermal/mt8173.h
new file mode 100644
index 000..692e74c
--- /dev/null
+++ b/include/dt-bindings/thermal/mt8173.h
@@ -0,0 +1,13 @@
+/*
+ * This header provides constants for mediatek,mt8173-thermal
+ */
+
+#ifndef _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
+#define _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
+
+#define MT8173_THERMAL_ZONE_CA53   0
+#define MT8173_THERMAL_ZONE_CA57   1
+#define MT8173_THERMAL_ZONE_GPU2
+#define MT8173_THERMAL_ZONE_CORE   3
+
+#endif /* _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H */
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

On Fri, Aug 28, 2015 at 10:23:15AM +0800, Daniel Kurtz wrote:
> On Thu, Aug 27, 2015 at 7:49 PM, Punit Agrawal  wrote:
> > [ + device tree folks ]
> >
> > Hi Sascha,
> >
> > When introducing a new binding, it is a good idea to get reviews from
> > the device tree maintainers. I've added a few folks here. Please keep
> > them in the loop for future postings.
> >
> > Sascha Hauer  writes:
> >
> >> Signed-off-by: Sascha Hauer 
> >> Reviewed-by: Daniel Kurtz 
> >
> > Please add a commit log.
> >
> >> ---
> >>  .../bindings/thermal/mediatek-thermal.txt  | 38 
> >> ++
> >>  include/dt-bindings/thermal/mt8173.h   | 13 
> >>  2 files changed, 51 insertions(+)
> >>  create mode 100644 
> >> Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> >>  create mode 100644 include/dt-bindings/thermal/mt8173.h
> >>
> >> diff --git 
> >> a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
> >> b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> >> new file mode 100644
> >> index 000..1697375
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> >> @@ -0,0 +1,38 @@
> >> +* Mediatek Thermal
> >> +
> >> +This describes the device tree binding for the Mediatek thermal controller
> >> +which measures the on-SoC temperatures. This device does not have its own 
> >> ADC,
> >> +instead it directly controls the AUXADC via AHB bus accesses. For this 
> >> reason
> >> +this device needs phandles to the AUXADC. Also it controls a mux in the
> >> +apmixedsys register space via AHB bus accesses, so a phandle to the 
> >> APMIXEDSYS
> >> +is also needed.
> >> +
> >> +Required properties:
> >> +- compatible: "mediatek,mt8173-thermal"
> >> +- reg: Address range of the thermal controller
> >> +- interrupts: IRQ for the thermal controller
> >> +- clocks, clock-names: Clocks needed for the thermal controller. required
> >> +   clocks are:
> >> +"therm":  Main clock needed for register access
> >> +"auxadc": The AUXADC clock
> >> +- resets: Reference to the reset controller controlling the thermal 
> >> controller.
> >> +- mediatek,auxadc: A phandle to the AUXADC which the thermal controller 
> >> uses
> >> +- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
> >> +- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a 
> >> description. See
> >> +   include/dt-bindings/thermal/mt8173.h for valid 
> >> sensor
> >> +   numbers.
> >> +
> >> +Example:
> >> +
> >> + thermal: thermal@1100b000 {
> >> + #thermal-sensor-cells = <1>;
> >> + compatible = "mediatek,mt8173-thermal";
> >> + reg = <0 0x1100b000 0 0x1000>;
> >> + interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
> >> + clocks = < CLK_PERI_THERM>, < 
> >> CLK_PERI_AUXADC>;
> >> + clock-names = "therm", "auxadc";
> >> + resets = < MT8173_PERI_THERM_SW_RST>;
> >> + reset-names = "therm";
> >> + mediatek,auxadc = <>;
> >> + mediatek,apmixedsys = <>;
> >> + };
> >> diff --git a/include/dt-bindings/thermal/mt8173.h 
> >> b/include/dt-bindings/thermal/mt8173.h
> >> new file mode 100644
> >> index 000..692e74c
> >> --- /dev/null
> >> +++ b/include/dt-bindings/thermal/mt8173.h
> >> @@ -0,0 +1,13 @@
> >> +/*
> >> + * This header provides constants for mediatek,mt8173-thermal
> >> + */
> >> +
> >> +#ifndef _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
> >> +#define _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
> >> +
> >> +#define MT8173_THERMAL_ZONE_CA53 0
> >> +#define MT8173_THERMAL_ZONE_CA57 1
> >> +#define MT8173_THERMAL_ZONE_GPU  2
> >> +#define MT8173_THERMAL_ZONE_CORE 3
> >> +
> >> +#endif /* _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H */
> >
> > The constants in this include are not used in the patchset. Please drop
> > this hunk and introduce it when you use it.
> 
> These constants are part of the devicetree ABI, and I believe they
> should be included with the binding.

Yes, that's what I was told for other series.

> To make this more concrete, I think these constants could be used as
> array indices when initializing the corresponding banks of "bank_data"
> in patch 2 (like you do when initializing scp_domain_data in the
> scpsys driver).

Good idea, will do that in the next round.

Sascha

-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

On Fri, Aug 28, 2015 at 10:23:15AM +0800, Daniel Kurtz wrote:
> On Thu, Aug 27, 2015 at 7:49 PM, Punit Agrawal  wrote:
> > [ + device tree folks ]
> >
> > Hi Sascha,
> >
> > When introducing a new binding, it is a good idea to get reviews from
> > the device tree maintainers. I've added a few folks here. Please keep
> > them in the loop for future postings.
> >
> > Sascha Hauer  writes:
> >
> >> Signed-off-by: Sascha Hauer 
> >> Reviewed-by: Daniel Kurtz 
> >
> > Please add a commit log.
> >
> >> ---
> >>  .../bindings/thermal/mediatek-thermal.txt  | 38 
> >> ++
> >>  include/dt-bindings/thermal/mt8173.h   | 13 
> >>  2 files changed, 51 insertions(+)
> >>  create mode 100644 
> >> Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> >>  create mode 100644 include/dt-bindings/thermal/mt8173.h
> >>
> >> diff --git 
> >> a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
> >> b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> >> new file mode 100644
> >> index 000..1697375
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> >> @@ -0,0 +1,38 @@
> >> +* Mediatek Thermal
> >> +
> >> +This describes the device tree binding for the Mediatek thermal controller
> >> +which measures the on-SoC temperatures. This device does not have its own 
> >> ADC,
> >> +instead it directly controls the AUXADC via AHB bus accesses. For this 
> >> reason
> >> +this device needs phandles to the AUXADC. Also it controls a mux in the
> >> +apmixedsys register space via AHB bus accesses, so a phandle to the 
> >> APMIXEDSYS
> >> +is also needed.
> >> +
> >> +Required properties:
> >> +- compatible: "mediatek,mt8173-thermal"
> >> +- reg: Address range of the thermal controller
> >> +- interrupts: IRQ for the thermal controller
> >> +- clocks, clock-names: Clocks needed for the thermal controller. required
> >> +   clocks are:
> >> +"therm":  Main clock needed for register access
> >> +"auxadc": The AUXADC clock
> >> +- resets: Reference to the reset controller controlling the thermal 
> >> controller.
> >> +- mediatek,auxadc: A phandle to the AUXADC which the thermal controller 
> >> uses
> >> +- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
> >> +- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a 
> >> description. See
> >> +   include/dt-bindings/thermal/mt8173.h for valid 
> >> sensor
> >> +   numbers.
> >> +
> >> +Example:
> >> +
> >> + thermal: thermal@1100b000 {
> >> + #thermal-sensor-cells = <1>;
> >> + compatible = "mediatek,mt8173-thermal";
> >> + reg = <0 0x1100b000 0 0x1000>;
> >> + interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
> >> + clocks = < CLK_PERI_THERM>, < 
> >> CLK_PERI_AUXADC>;
> >> + clock-names = "therm", "auxadc";
> >> + resets = < MT8173_PERI_THERM_SW_RST>;
> >> + reset-names = "therm";
> >> + mediatek,auxadc = <>;
> >> + mediatek,apmixedsys = <>;
> >> + };
> >> diff --git a/include/dt-bindings/thermal/mt8173.h 
> >> b/include/dt-bindings/thermal/mt8173.h
> >> new file mode 100644
> >> index 000..692e74c
> >> --- /dev/null
> >> +++ b/include/dt-bindings/thermal/mt8173.h
> >> @@ -0,0 +1,13 @@
> >> +/*
> >> + * This header provides constants for mediatek,mt8173-thermal
> >> + */
> >> +
> >> +#ifndef _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
> >> +#define _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
> >> +
> >> +#define MT8173_THERMAL_ZONE_CA53 0
> >> +#define MT8173_THERMAL_ZONE_CA57 1
> >> +#define MT8173_THERMAL_ZONE_GPU  2
> >> +#define MT8173_THERMAL_ZONE_CORE 3
> >> +
> >> +#endif /* _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H */
> >
> > The constants in this include are not used in the patchset. Please drop
> > this hunk and introduce it when you use it.
> 
> These constants are part of the devicetree ABI, and I believe they
> should be included with the binding.

Yes, that's what I was told for other series.

> To make this more concrete, I think these constants could be used as
> array indices when initializing the corresponding banks of "bank_data"
> in patch 2 (like you do when initializing scp_domain_data in the
> scpsys driver).

Good idea, will do that in the next round.

Sascha

-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More 

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

Signed-off-by: Sascha Hauer 
Reviewed-by: Daniel Kurtz 
---
 .../bindings/thermal/mediatek-thermal.txt  | 38 ++
 include/dt-bindings/thermal/mt8173.h   | 13 
 2 files changed, 51 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
 create mode 100644 include/dt-bindings/thermal/mt8173.h

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
new file mode 100644
index 000..1697375
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -0,0 +1,38 @@
+* Mediatek Thermal
+
+This describes the device tree binding for the Mediatek thermal controller
+which measures the on-SoC temperatures. This device does not have its own ADC,
+instead it directly controls the AUXADC via AHB bus accesses. For this reason
+this device needs phandles to the AUXADC. Also it controls a mux in the
+apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+is also needed.
+
+Required properties:
+- compatible: "mediatek,mt8173-thermal"
+- reg: Address range of the thermal controller
+- interrupts: IRQ for the thermal controller
+- clocks, clock-names: Clocks needed for the thermal controller. required
+   clocks are:
+  "therm":  Main clock needed for register access
+  "auxadc": The AUXADC clock
+- resets: Reference to the reset controller controlling the thermal controller.
+- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
+- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
+- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description. See
+ include/dt-bindings/thermal/mt8173.h for valid sensor
+ numbers.
+
+Example:
+
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = <1>;
+   compatible = "mediatek,mt8173-thermal";
+   reg = <0 0x1100b000 0 0x1000>;
+   interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
+   clocks = < CLK_PERI_THERM>, < CLK_PERI_AUXADC>;
+   clock-names = "therm", "auxadc";
+   resets = < MT8173_PERI_THERM_SW_RST>;
+   reset-names = "therm";
+   mediatek,auxadc = <>;
+   mediatek,apmixedsys = <>;
+   };
diff --git a/include/dt-bindings/thermal/mt8173.h 
b/include/dt-bindings/thermal/mt8173.h
new file mode 100644
index 000..692e74c
--- /dev/null
+++ b/include/dt-bindings/thermal/mt8173.h
@@ -0,0 +1,13 @@
+/*
+ * This header provides constants for mediatek,mt8173-thermal
+ */
+
+#ifndef _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
+#define _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
+
+#define MT8173_THERMAL_ZONE_CA53   0
+#define MT8173_THERMAL_ZONE_CA57   1
+#define MT8173_THERMAL_ZONE_GPU2
+#define MT8173_THERMAL_ZONE_CORE   3
+
+#endif /* _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H */
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

On Mon, Aug 31, 2015 at 09:34:04AM +0200, Sascha Hauer wrote:
> Signed-off-by: Sascha Hauer 
> Reviewed-by: Daniel Kurtz 

Uh, still forgot the commit log. Will add something like:

This adds the device tree binding documentation for the mediatek thermal
controller found on Mediatek MT8173 and other SoCs.

Sascha

> ---
>  .../bindings/thermal/mediatek-thermal.txt  | 38 
> ++
>  include/dt-bindings/thermal/mt8173.h   | 13 
>  2 files changed, 51 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
>  create mode 100644 include/dt-bindings/thermal/mt8173.h
> 
> diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
> b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> new file mode 100644
> index 000..1697375
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> @@ -0,0 +1,38 @@
> +* Mediatek Thermal
> +
> +This describes the device tree binding for the Mediatek thermal controller
> +which measures the on-SoC temperatures. This device does not have its own 
> ADC,
> +instead it directly controls the AUXADC via AHB bus accesses. For this reason
> +this device needs phandles to the AUXADC. Also it controls a mux in the
> +apmixedsys register space via AHB bus accesses, so a phandle to the 
> APMIXEDSYS
> +is also needed.
> +
> +Required properties:
> +- compatible: "mediatek,mt8173-thermal"
> +- reg: Address range of the thermal controller
> +- interrupts: IRQ for the thermal controller
> +- clocks, clock-names: Clocks needed for the thermal controller. required
> +   clocks are:
> +"therm":  Main clock needed for register access
> +"auxadc": The AUXADC clock
> +- resets: Reference to the reset controller controlling the thermal 
> controller.
> +- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
> +- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
> +- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description. 
> See
> +   include/dt-bindings/thermal/mt8173.h for valid sensor
> +   numbers.
> +
> +Example:
> +
> + thermal: thermal@1100b000 {
> + #thermal-sensor-cells = <1>;
> + compatible = "mediatek,mt8173-thermal";
> + reg = <0 0x1100b000 0 0x1000>;
> + interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
> + clocks = < CLK_PERI_THERM>, < CLK_PERI_AUXADC>;
> + clock-names = "therm", "auxadc";
> + resets = < MT8173_PERI_THERM_SW_RST>;
> + reset-names = "therm";
> + mediatek,auxadc = <>;
> + mediatek,apmixedsys = <>;
> + };
> diff --git a/include/dt-bindings/thermal/mt8173.h 
> b/include/dt-bindings/thermal/mt8173.h
> new file mode 100644
> index 000..692e74c
> --- /dev/null
> +++ b/include/dt-bindings/thermal/mt8173.h
> @@ -0,0 +1,13 @@
> +/*
> + * This header provides constants for mediatek,mt8173-thermal
> + */
> +
> +#ifndef _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
> +#define _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
> +
> +#define MT8173_THERMAL_ZONE_CA53 0
> +#define MT8173_THERMAL_ZONE_CA57 1
> +#define MT8173_THERMAL_ZONE_GPU  2
> +#define MT8173_THERMAL_ZONE_CORE 3
> +
> +#endif /* _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H */
> -- 
> 2.5.0
> 
> 

-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Daniel Kurtz]

On Thu, Aug 27, 2015 at 7:49 PM, Punit Agrawal  wrote:
> [ + device tree folks ]
>
> Hi Sascha,
>
> When introducing a new binding, it is a good idea to get reviews from
> the device tree maintainers. I've added a few folks here. Please keep
> them in the loop for future postings.
>
> Sascha Hauer  writes:
>
>> Signed-off-by: Sascha Hauer 
>> Reviewed-by: Daniel Kurtz 
>
> Please add a commit log.
>
>> ---
>>  .../bindings/thermal/mediatek-thermal.txt  | 38 
>> ++
>>  include/dt-bindings/thermal/mt8173.h   | 13 
>>  2 files changed, 51 insertions(+)
>>  create mode 100644 
>> Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
>>  create mode 100644 include/dt-bindings/thermal/mt8173.h
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
>> b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
>> new file mode 100644
>> index 000..1697375
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
>> @@ -0,0 +1,38 @@
>> +* Mediatek Thermal
>> +
>> +This describes the device tree binding for the Mediatek thermal controller
>> +which measures the on-SoC temperatures. This device does not have its own 
>> ADC,
>> +instead it directly controls the AUXADC via AHB bus accesses. For this 
>> reason
>> +this device needs phandles to the AUXADC. Also it controls a mux in the
>> +apmixedsys register space via AHB bus accesses, so a phandle to the 
>> APMIXEDSYS
>> +is also needed.
>> +
>> +Required properties:
>> +- compatible: "mediatek,mt8173-thermal"
>> +- reg: Address range of the thermal controller
>> +- interrupts: IRQ for the thermal controller
>> +- clocks, clock-names: Clocks needed for the thermal controller. required
>> +   clocks are:
>> +"therm":  Main clock needed for register access
>> +"auxadc": The AUXADC clock
>> +- resets: Reference to the reset controller controlling the thermal 
>> controller.
>> +- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
>> +- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
>> +- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description. 
>> See
>> +   include/dt-bindings/thermal/mt8173.h for valid sensor
>> +   numbers.
>> +
>> +Example:
>> +
>> + thermal: thermal@1100b000 {
>> + #thermal-sensor-cells = <1>;
>> + compatible = "mediatek,mt8173-thermal";
>> + reg = <0 0x1100b000 0 0x1000>;
>> + interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
>> + clocks = < CLK_PERI_THERM>, < CLK_PERI_AUXADC>;
>> + clock-names = "therm", "auxadc";
>> + resets = < MT8173_PERI_THERM_SW_RST>;
>> + reset-names = "therm";
>> + mediatek,auxadc = <>;
>> + mediatek,apmixedsys = <>;
>> + };
>> diff --git a/include/dt-bindings/thermal/mt8173.h 
>> b/include/dt-bindings/thermal/mt8173.h
>> new file mode 100644
>> index 000..692e74c
>> --- /dev/null
>> +++ b/include/dt-bindings/thermal/mt8173.h
>> @@ -0,0 +1,13 @@
>> +/*
>> + * This header provides constants for mediatek,mt8173-thermal
>> + */
>> +
>> +#ifndef _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
>> +#define _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
>> +
>> +#define MT8173_THERMAL_ZONE_CA53 0
>> +#define MT8173_THERMAL_ZONE_CA57 1
>> +#define MT8173_THERMAL_ZONE_GPU  2
>> +#define MT8173_THERMAL_ZONE_CORE 3
>> +
>> +#endif /* _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H */
>
> The constants in this include are not used in the patchset. Please drop
> this hunk and introduce it when you use it.

These constants are part of the devicetree ABI, and I believe they
should be included with the binding.
To make this more concrete, I think these constants could be used as
array indices when initializing the corresponding banks of "bank_data"
in patch 2 (like you do when initializing scp_domain_data in the
scpsys driver).

-Dan

>
> Thanks,
> Punit
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Punit Agrawal]

[ + device tree folks ]

Hi Sascha,

When introducing a new binding, it is a good idea to get reviews from
the device tree maintainers. I've added a few folks here. Please keep
them in the loop for future postings.

Sascha Hauer  writes:

> Signed-off-by: Sascha Hauer 
> Reviewed-by: Daniel Kurtz 

Please add a commit log.

> ---
>  .../bindings/thermal/mediatek-thermal.txt  | 38 
> ++
>  include/dt-bindings/thermal/mt8173.h   | 13 
>  2 files changed, 51 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
>  create mode 100644 include/dt-bindings/thermal/mt8173.h
>
> diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
> b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> new file mode 100644
> index 000..1697375
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> @@ -0,0 +1,38 @@
> +* Mediatek Thermal
> +
> +This describes the device tree binding for the Mediatek thermal controller
> +which measures the on-SoC temperatures. This device does not have its own 
> ADC,
> +instead it directly controls the AUXADC via AHB bus accesses. For this reason
> +this device needs phandles to the AUXADC. Also it controls a mux in the
> +apmixedsys register space via AHB bus accesses, so a phandle to the 
> APMIXEDSYS
> +is also needed.
> +
> +Required properties:
> +- compatible: "mediatek,mt8173-thermal"
> +- reg: Address range of the thermal controller
> +- interrupts: IRQ for the thermal controller
> +- clocks, clock-names: Clocks needed for the thermal controller. required
> +   clocks are:
> +"therm":  Main clock needed for register access
> +"auxadc": The AUXADC clock
> +- resets: Reference to the reset controller controlling the thermal 
> controller.
> +- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
> +- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
> +- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description. 
> See
> +   include/dt-bindings/thermal/mt8173.h for valid sensor
> +   numbers.
> +
> +Example:
> +
> + thermal: thermal@1100b000 {
> + #thermal-sensor-cells = <1>;
> + compatible = "mediatek,mt8173-thermal";
> + reg = <0 0x1100b000 0 0x1000>;
> + interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
> + clocks = < CLK_PERI_THERM>, < CLK_PERI_AUXADC>;
> + clock-names = "therm", "auxadc";
> + resets = < MT8173_PERI_THERM_SW_RST>;
> + reset-names = "therm";
> + mediatek,auxadc = <>;
> + mediatek,apmixedsys = <>;
> + };
> diff --git a/include/dt-bindings/thermal/mt8173.h 
> b/include/dt-bindings/thermal/mt8173.h
> new file mode 100644
> index 000..692e74c
> --- /dev/null
> +++ b/include/dt-bindings/thermal/mt8173.h
> @@ -0,0 +1,13 @@
> +/*
> + * This header provides constants for mediatek,mt8173-thermal
> + */
> +
> +#ifndef _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
> +#define _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
> +
> +#define MT8173_THERMAL_ZONE_CA53 0
> +#define MT8173_THERMAL_ZONE_CA57 1
> +#define MT8173_THERMAL_ZONE_GPU  2
> +#define MT8173_THERMAL_ZONE_CORE 3
> +
> +#endif /* _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H */

The constants in this include are not used in the patchset. Please drop
this hunk and introduce it when you use it.

Thanks,
Punit
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

Signed-off-by: Sascha Hauer 
Reviewed-by: Daniel Kurtz 
---
 .../bindings/thermal/mediatek-thermal.txt  | 38 ++
 include/dt-bindings/thermal/mt8173.h   | 13 
 2 files changed, 51 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
 create mode 100644 include/dt-bindings/thermal/mt8173.h

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
new file mode 100644
index 000..1697375
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -0,0 +1,38 @@
+* Mediatek Thermal
+
+This describes the device tree binding for the Mediatek thermal controller
+which measures the on-SoC temperatures. This device does not have its own ADC,
+instead it directly controls the AUXADC via AHB bus accesses. For this reason
+this device needs phandles to the AUXADC. Also it controls a mux in the
+apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+is also needed.
+
+Required properties:
+- compatible: "mediatek,mt8173-thermal"
+- reg: Address range of the thermal controller
+- interrupts: IRQ for the thermal controller
+- clocks, clock-names: Clocks needed for the thermal controller. required
+   clocks are:
+  "therm":  Main clock needed for register access
+  "auxadc": The AUXADC clock
+- resets: Reference to the reset controller controlling the thermal controller.
+- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
+- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
+- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description. See
+ include/dt-bindings/thermal/mt8173.h for valid sensor
+ numbers.
+
+Example:
+
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = <1>;
+   compatible = "mediatek,mt8173-thermal";
+   reg = <0 0x1100b000 0 0x1000>;
+   interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
+   clocks = < CLK_PERI_THERM>, < CLK_PERI_AUXADC>;
+   clock-names = "therm", "auxadc";
+   resets = < MT8173_PERI_THERM_SW_RST>;
+   reset-names = "therm";
+   mediatek,auxadc = <>;
+   mediatek,apmixedsys = <>;
+   };
diff --git a/include/dt-bindings/thermal/mt8173.h 
b/include/dt-bindings/thermal/mt8173.h
new file mode 100644
index 000..692e74c
--- /dev/null
+++ b/include/dt-bindings/thermal/mt8173.h
@@ -0,0 +1,13 @@
+/*
+ * This header provides constants for mediatek,mt8173-thermal
+ */
+
+#ifndef _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
+#define _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
+
+#define MT8173_THERMAL_ZONE_CA53   0
+#define MT8173_THERMAL_ZONE_CA57   1
+#define MT8173_THERMAL_ZONE_GPU2
+#define MT8173_THERMAL_ZONE_CORE   3
+
+#endif /* _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H */
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Daniel Kurtz]

On Thu, Aug 27, 2015 at 7:49 PM, Punit Agrawal punit.agra...@arm.com wrote:
 [ + device tree folks ]

 Hi Sascha,

 When introducing a new binding, it is a good idea to get reviews from
 the device tree maintainers. I've added a few folks here. Please keep
 them in the loop for future postings.

 Sascha Hauer s.ha...@pengutronix.de writes:

 Signed-off-by: Sascha Hauer s.ha...@pengutronix.de
 Reviewed-by: Daniel Kurtz djku...@chromium.org

 Please add a commit log.

 ---
  .../bindings/thermal/mediatek-thermal.txt  | 38 
 ++
  include/dt-bindings/thermal/mt8173.h   | 13 
  2 files changed, 51 insertions(+)
  create mode 100644 
 Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
  create mode 100644 include/dt-bindings/thermal/mt8173.h

 diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
 b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
 new file mode 100644
 index 000..1697375
 --- /dev/null
 +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
 @@ -0,0 +1,38 @@
 +* Mediatek Thermal
 +
 +This describes the device tree binding for the Mediatek thermal controller
 +which measures the on-SoC temperatures. This device does not have its own 
 ADC,
 +instead it directly controls the AUXADC via AHB bus accesses. For this 
 reason
 +this device needs phandles to the AUXADC. Also it controls a mux in the
 +apmixedsys register space via AHB bus accesses, so a phandle to the 
 APMIXEDSYS
 +is also needed.
 +
 +Required properties:
 +- compatible: mediatek,mt8173-thermal
 +- reg: Address range of the thermal controller
 +- interrupts: IRQ for the thermal controller
 +- clocks, clock-names: Clocks needed for the thermal controller. required
 +   clocks are:
 +therm:  Main clock needed for register access
 +auxadc: The AUXADC clock
 +- resets: Reference to the reset controller controlling the thermal 
 controller.
 +- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
 +- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
 +- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description. 
 See
 +   include/dt-bindings/thermal/mt8173.h for valid sensor
 +   numbers.
 +
 +Example:
 +
 + thermal: thermal@1100b000 {
 + #thermal-sensor-cells = 1;
 + compatible = mediatek,mt8173-thermal;
 + reg = 0 0x1100b000 0 0x1000;
 + interrupts = 0 70 IRQ_TYPE_LEVEL_LOW;
 + clocks = pericfg CLK_PERI_THERM, pericfg CLK_PERI_AUXADC;
 + clock-names = therm, auxadc;
 + resets = pericfg MT8173_PERI_THERM_SW_RST;
 + reset-names = therm;
 + mediatek,auxadc = auxadc;
 + mediatek,apmixedsys = apmixedsys;
 + };
 diff --git a/include/dt-bindings/thermal/mt8173.h 
 b/include/dt-bindings/thermal/mt8173.h
 new file mode 100644
 index 000..692e74c
 --- /dev/null
 +++ b/include/dt-bindings/thermal/mt8173.h
 @@ -0,0 +1,13 @@
 +/*
 + * This header provides constants for mediatek,mt8173-thermal
 + */
 +
 +#ifndef _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
 +#define _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
 +
 +#define MT8173_THERMAL_ZONE_CA53 0
 +#define MT8173_THERMAL_ZONE_CA57 1
 +#define MT8173_THERMAL_ZONE_GPU  2
 +#define MT8173_THERMAL_ZONE_CORE 3
 +
 +#endif /* _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H */

 The constants in this include are not used in the patchset. Please drop
 this hunk and introduce it when you use it.

These constants are part of the devicetree ABI, and I believe they
should be included with the binding.
To make this more concrete, I think these constants could be used as
array indices when initializing the corresponding banks of bank_data
in patch 2 (like you do when initializing scp_domain_data in the
scpsys driver).

-Dan


 Thanks,
 Punit
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

Signed-off-by: Sascha Hauer s.ha...@pengutronix.de
Reviewed-by: Daniel Kurtz djku...@chromium.org
---
 .../bindings/thermal/mediatek-thermal.txt  | 38 ++
 include/dt-bindings/thermal/mt8173.h   | 13 
 2 files changed, 51 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
 create mode 100644 include/dt-bindings/thermal/mt8173.h

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
new file mode 100644
index 000..1697375
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -0,0 +1,38 @@
+* Mediatek Thermal
+
+This describes the device tree binding for the Mediatek thermal controller
+which measures the on-SoC temperatures. This device does not have its own ADC,
+instead it directly controls the AUXADC via AHB bus accesses. For this reason
+this device needs phandles to the AUXADC. Also it controls a mux in the
+apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+is also needed.
+
+Required properties:
+- compatible: mediatek,mt8173-thermal
+- reg: Address range of the thermal controller
+- interrupts: IRQ for the thermal controller
+- clocks, clock-names: Clocks needed for the thermal controller. required
+   clocks are:
+  therm:  Main clock needed for register access
+  auxadc: The AUXADC clock
+- resets: Reference to the reset controller controlling the thermal controller.
+- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
+- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
+- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description. See
+ include/dt-bindings/thermal/mt8173.h for valid sensor
+ numbers.
+
+Example:
+
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = 1;
+   compatible = mediatek,mt8173-thermal;
+   reg = 0 0x1100b000 0 0x1000;
+   interrupts = 0 70 IRQ_TYPE_LEVEL_LOW;
+   clocks = pericfg CLK_PERI_THERM, pericfg CLK_PERI_AUXADC;
+   clock-names = therm, auxadc;
+   resets = pericfg MT8173_PERI_THERM_SW_RST;
+   reset-names = therm;
+   mediatek,auxadc = auxadc;
+   mediatek,apmixedsys = apmixedsys;
+   };
diff --git a/include/dt-bindings/thermal/mt8173.h 
b/include/dt-bindings/thermal/mt8173.h
new file mode 100644
index 000..692e74c
--- /dev/null
+++ b/include/dt-bindings/thermal/mt8173.h
@@ -0,0 +1,13 @@
+/*
+ * This header provides constants for mediatek,mt8173-thermal
+ */
+
+#ifndef _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
+#define _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
+
+#define MT8173_THERMAL_ZONE_CA53   0
+#define MT8173_THERMAL_ZONE_CA57   1
+#define MT8173_THERMAL_ZONE_GPU2
+#define MT8173_THERMAL_ZONE_CORE   3
+
+#endif /* _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H */
-- 
2.5.0

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Punit Agrawal]

[ + device tree folks ]

Hi Sascha,

When introducing a new binding, it is a good idea to get reviews from
the device tree maintainers. I've added a few folks here. Please keep
them in the loop for future postings.

Sascha Hauer s.ha...@pengutronix.de writes:

 Signed-off-by: Sascha Hauer s.ha...@pengutronix.de
 Reviewed-by: Daniel Kurtz djku...@chromium.org

Please add a commit log.

 ---
  .../bindings/thermal/mediatek-thermal.txt  | 38 
 ++
  include/dt-bindings/thermal/mt8173.h   | 13 
  2 files changed, 51 insertions(+)
  create mode 100644 
 Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
  create mode 100644 include/dt-bindings/thermal/mt8173.h

 diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
 b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
 new file mode 100644
 index 000..1697375
 --- /dev/null
 +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
 @@ -0,0 +1,38 @@
 +* Mediatek Thermal
 +
 +This describes the device tree binding for the Mediatek thermal controller
 +which measures the on-SoC temperatures. This device does not have its own 
 ADC,
 +instead it directly controls the AUXADC via AHB bus accesses. For this reason
 +this device needs phandles to the AUXADC. Also it controls a mux in the
 +apmixedsys register space via AHB bus accesses, so a phandle to the 
 APMIXEDSYS
 +is also needed.
 +
 +Required properties:
 +- compatible: mediatek,mt8173-thermal
 +- reg: Address range of the thermal controller
 +- interrupts: IRQ for the thermal controller
 +- clocks, clock-names: Clocks needed for the thermal controller. required
 +   clocks are:
 +therm:  Main clock needed for register access
 +auxadc: The AUXADC clock
 +- resets: Reference to the reset controller controlling the thermal 
 controller.
 +- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
 +- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
 +- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description. 
 See
 +   include/dt-bindings/thermal/mt8173.h for valid sensor
 +   numbers.
 +
 +Example:
 +
 + thermal: thermal@1100b000 {
 + #thermal-sensor-cells = 1;
 + compatible = mediatek,mt8173-thermal;
 + reg = 0 0x1100b000 0 0x1000;
 + interrupts = 0 70 IRQ_TYPE_LEVEL_LOW;
 + clocks = pericfg CLK_PERI_THERM, pericfg CLK_PERI_AUXADC;
 + clock-names = therm, auxadc;
 + resets = pericfg MT8173_PERI_THERM_SW_RST;
 + reset-names = therm;
 + mediatek,auxadc = auxadc;
 + mediatek,apmixedsys = apmixedsys;
 + };
 diff --git a/include/dt-bindings/thermal/mt8173.h 
 b/include/dt-bindings/thermal/mt8173.h
 new file mode 100644
 index 000..692e74c
 --- /dev/null
 +++ b/include/dt-bindings/thermal/mt8173.h
 @@ -0,0 +1,13 @@
 +/*
 + * This header provides constants for mediatek,mt8173-thermal
 + */
 +
 +#ifndef _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
 +#define _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
 +
 +#define MT8173_THERMAL_ZONE_CA53 0
 +#define MT8173_THERMAL_ZONE_CA57 1
 +#define MT8173_THERMAL_ZONE_GPU  2
 +#define MT8173_THERMAL_ZONE_CORE 3
 +
 +#endif /* _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H */

The constants in this include are not used in the patchset. Please drop
this hunk and introduce it when you use it.

Thanks,
Punit
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

Signed-off-by: Sascha Hauer 
Reviewed-by: Daniel Kurtz 
---
 .../bindings/thermal/mediatek-thermal.txt  | 38 ++
 include/dt-bindings/thermal/mt8173.h   | 13 
 2 files changed, 51 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
 create mode 100644 include/dt-bindings/thermal/mt8173.h

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
new file mode 100644
index 000..1697375
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -0,0 +1,38 @@
+* Mediatek Thermal
+
+This describes the device tree binding for the Mediatek thermal controller
+which measures the on-SoC temperatures. This device does not have its own ADC,
+instead it directly controls the AUXADC via AHB bus accesses. For this reason
+this device needs phandles to the AUXADC. Also it controls a mux in the
+apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+is also needed.
+
+Required properties:
+- compatible: "mediatek,mt8173-thermal"
+- reg: Address range of the thermal controller
+- interrupts: IRQ for the thermal controller
+- clocks, clock-names: Clocks needed for the thermal controller. required
+   clocks are:
+  "therm":  Main clock needed for register access
+  "auxadc": The AUXADC clock
+- resets: Reference to the reset controller controlling the thermal controller.
+- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
+- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
+- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description. See
+ include/dt-bindings/thermal/mt8173.h for valid sensor
+ numbers.
+
+Example:
+
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = <1>;
+   compatible = "mediatek,mt8173-thermal";
+   reg = <0 0x1100b000 0 0x1000>;
+   interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
+   clocks = < CLK_PERI_THERM>, < CLK_PERI_AUXADC>;
+   clock-names = "therm", "auxadc";
+   resets = < MT8173_PERI_THERM_SW_RST>;
+   reset-names = "therm";
+   mediatek,auxadc = <>;
+   mediatek,apmixedsys = <>;
+   };
diff --git a/include/dt-bindings/thermal/mt8173.h 
b/include/dt-bindings/thermal/mt8173.h
new file mode 100644
index 000..692e74c
--- /dev/null
+++ b/include/dt-bindings/thermal/mt8173.h
@@ -0,0 +1,13 @@
+/*
+ * This header provides constants for mediatek,mt8173-thermal
+ */
+
+#ifndef _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
+#define _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
+
+#define MT8173_THERMAL_ZONE_CA53   0
+#define MT8173_THERMAL_ZONE_CA57   1
+#define MT8173_THERMAL_ZONE_GPU2
+#define MT8173_THERMAL_ZONE_CORE   3
+
+#endif /* _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H */
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

Signed-off-by: Sascha Hauer s.ha...@pengutronix.de
Reviewed-by: Daniel Kurtz djku...@chromium.org
---
 .../bindings/thermal/mediatek-thermal.txt  | 38 ++
 include/dt-bindings/thermal/mt8173.h   | 13 
 2 files changed, 51 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
 create mode 100644 include/dt-bindings/thermal/mt8173.h

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
new file mode 100644
index 000..1697375
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -0,0 +1,38 @@
+* Mediatek Thermal
+
+This describes the device tree binding for the Mediatek thermal controller
+which measures the on-SoC temperatures. This device does not have its own ADC,
+instead it directly controls the AUXADC via AHB bus accesses. For this reason
+this device needs phandles to the AUXADC. Also it controls a mux in the
+apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+is also needed.
+
+Required properties:
+- compatible: mediatek,mt8173-thermal
+- reg: Address range of the thermal controller
+- interrupts: IRQ for the thermal controller
+- clocks, clock-names: Clocks needed for the thermal controller. required
+   clocks are:
+  therm:  Main clock needed for register access
+  auxadc: The AUXADC clock
+- resets: Reference to the reset controller controlling the thermal controller.
+- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
+- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
+- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description. See
+ include/dt-bindings/thermal/mt8173.h for valid sensor
+ numbers.
+
+Example:
+
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = 1;
+   compatible = mediatek,mt8173-thermal;
+   reg = 0 0x1100b000 0 0x1000;
+   interrupts = 0 70 IRQ_TYPE_LEVEL_LOW;
+   clocks = pericfg CLK_PERI_THERM, pericfg CLK_PERI_AUXADC;
+   clock-names = therm, auxadc;
+   resets = pericfg MT8173_PERI_THERM_SW_RST;
+   reset-names = therm;
+   mediatek,auxadc = auxadc;
+   mediatek,apmixedsys = apmixedsys;
+   };
diff --git a/include/dt-bindings/thermal/mt8173.h 
b/include/dt-bindings/thermal/mt8173.h
new file mode 100644
index 000..692e74c
--- /dev/null
+++ b/include/dt-bindings/thermal/mt8173.h
@@ -0,0 +1,13 @@
+/*
+ * This header provides constants for mediatek,mt8173-thermal
+ */
+
+#ifndef _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
+#define _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
+
+#define MT8173_THERMAL_ZONE_CA53   0
+#define MT8173_THERMAL_ZONE_CA57   1
+#define MT8173_THERMAL_ZONE_GPU2
+#define MT8173_THERMAL_ZONE_CORE   3
+
+#endif /* _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H */
-- 
2.5.0

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

Signed-off-by: Sascha Hauer 
---
 .../bindings/thermal/mediatek-thermal.txt  | 38 ++
 include/dt-bindings/thermal/mt8173.h   | 13 
 2 files changed, 51 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
 create mode 100644 include/dt-bindings/thermal/mt8173.h

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
new file mode 100644
index 000..1697375
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -0,0 +1,38 @@
+* Mediatek Thermal
+
+This describes the device tree binding for the Mediatek thermal controller
+which measures the on-SoC temperatures. This device does not have its own ADC,
+instead it directly controls the AUXADC via AHB bus accesses. For this reason
+this device needs phandles to the AUXADC. Also it controls a mux in the
+apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+is also needed.
+
+Required properties:
+- compatible: "mediatek,mt8173-thermal"
+- reg: Address range of the thermal controller
+- interrupts: IRQ for the thermal controller
+- clocks, clock-names: Clocks needed for the thermal controller. required
+   clocks are:
+  "therm":  Main clock needed for register access
+  "auxadc": The AUXADC clock
+- resets: Reference to the reset controller controlling the thermal controller.
+- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
+- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
+- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description. See
+ include/dt-bindings/thermal/mt8173.h for valid sensor
+ numbers.
+
+Example:
+
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = <1>;
+   compatible = "mediatek,mt8173-thermal";
+   reg = <0 0x1100b000 0 0x1000>;
+   interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
+   clocks = < CLK_PERI_THERM>, < CLK_PERI_AUXADC>;
+   clock-names = "therm", "auxadc";
+   resets = < MT8173_PERI_THERM_SW_RST>;
+   reset-names = "therm";
+   mediatek,auxadc = <>;
+   mediatek,apmixedsys = <>;
+   };
diff --git a/include/dt-bindings/thermal/mt8173.h 
b/include/dt-bindings/thermal/mt8173.h
new file mode 100644
index 000..692e74c
--- /dev/null
+++ b/include/dt-bindings/thermal/mt8173.h
@@ -0,0 +1,13 @@
+/*
+ * This header provides constants for mediatek,mt8173-thermal
+ */
+
+#ifndef _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
+#define _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
+
+#define MT8173_THERMAL_ZONE_CA53   0
+#define MT8173_THERMAL_ZONE_CA57   1
+#define MT8173_THERMAL_ZONE_GPU2
+#define MT8173_THERMAL_ZONE_CORE   3
+
+#endif /* _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H */
-- 
2.4.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

Signed-off-by: Sascha Hauer s.ha...@pengutronix.de
---
 .../bindings/thermal/mediatek-thermal.txt  | 38 ++
 include/dt-bindings/thermal/mt8173.h   | 13 
 2 files changed, 51 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
 create mode 100644 include/dt-bindings/thermal/mt8173.h

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
new file mode 100644
index 000..1697375
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -0,0 +1,38 @@
+* Mediatek Thermal
+
+This describes the device tree binding for the Mediatek thermal controller
+which measures the on-SoC temperatures. This device does not have its own ADC,
+instead it directly controls the AUXADC via AHB bus accesses. For this reason
+this device needs phandles to the AUXADC. Also it controls a mux in the
+apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+is also needed.
+
+Required properties:
+- compatible: mediatek,mt8173-thermal
+- reg: Address range of the thermal controller
+- interrupts: IRQ for the thermal controller
+- clocks, clock-names: Clocks needed for the thermal controller. required
+   clocks are:
+  therm:  Main clock needed for register access
+  auxadc: The AUXADC clock
+- resets: Reference to the reset controller controlling the thermal controller.
+- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
+- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
+- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description. See
+ include/dt-bindings/thermal/mt8173.h for valid sensor
+ numbers.
+
+Example:
+
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = 1;
+   compatible = mediatek,mt8173-thermal;
+   reg = 0 0x1100b000 0 0x1000;
+   interrupts = 0 70 IRQ_TYPE_LEVEL_LOW;
+   clocks = pericfg CLK_PERI_THERM, pericfg CLK_PERI_AUXADC;
+   clock-names = therm, auxadc;
+   resets = pericfg MT8173_PERI_THERM_SW_RST;
+   reset-names = therm;
+   mediatek,auxadc = auxadc;
+   mediatek,apmixedsys = apmixedsys;
+   };
diff --git a/include/dt-bindings/thermal/mt8173.h 
b/include/dt-bindings/thermal/mt8173.h
new file mode 100644
index 000..692e74c
--- /dev/null
+++ b/include/dt-bindings/thermal/mt8173.h
@@ -0,0 +1,13 @@
+/*
+ * This header provides constants for mediatek,mt8173-thermal
+ */
+
+#ifndef _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
+#define _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
+
+#define MT8173_THERMAL_ZONE_CA53   0
+#define MT8173_THERMAL_ZONE_CA57   1
+#define MT8173_THERMAL_ZONE_GPU2
+#define MT8173_THERMAL_ZONE_CORE   3
+
+#endif /* _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H */
-- 
2.4.6

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

Signed-off-by: Sascha Hauer 
---
 .../bindings/thermal/mediatek-thermal.txt  | 38 ++
 include/dt-bindings/thermal/mt8173.h   | 13 
 2 files changed, 51 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
 create mode 100644 include/dt-bindings/thermal/mt8173.h

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
new file mode 100644
index 000..1697375
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -0,0 +1,38 @@
+* Mediatek Thermal
+
+This describes the device tree binding for the Mediatek thermal controller
+which measures the on-SoC temperatures. This device does not have its own ADC,
+instead it directly controls the AUXADC via AHB bus accesses. For this reason
+this device needs phandles to the AUXADC. Also it controls a mux in the
+apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+is also needed.
+
+Required properties:
+- compatible: "mediatek,mt8173-thermal"
+- reg: Address range of the thermal controller
+- interrupts: IRQ for the thermal controller
+- clocks, clock-names: Clocks needed for the thermal controller. required
+   clocks are:
+  "therm":  Main clock needed for register access
+  "auxadc": The AUXADC clock
+- resets: Reference to the reset controller controlling the thermal controller.
+- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
+- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
+- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description. See
+ include/dt-bindings/thermal/mt8173.h for valid sensor
+ numbers.
+
+Example:
+
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = <1>;
+   compatible = "mediatek,mt8173-thermal";
+   reg = <0 0x1100b000 0 0x1000>;
+   interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
+   clocks = < CLK_PERI_THERM>, < CLK_PERI_AUXADC>;
+   clock-names = "therm", "auxadc";
+   resets = < MT8173_PERI_THERM_SW_RST>;
+   reset-names = "therm";
+   mediatek,auxadc = <>;
+   mediatek,apmixedsys = <>;
+   };
diff --git a/include/dt-bindings/thermal/mt8173.h 
b/include/dt-bindings/thermal/mt8173.h
new file mode 100644
index 000..692e74c
--- /dev/null
+++ b/include/dt-bindings/thermal/mt8173.h
@@ -0,0 +1,13 @@
+/*
+ * This header provides constants for mediatek,mt8173-thermal
+ */
+
+#ifndef _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
+#define _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
+
+#define MT8173_THERMAL_ZONE_CA53   0
+#define MT8173_THERMAL_ZONE_CA57   1
+#define MT8173_THERMAL_ZONE_GPU2
+#define MT8173_THERMAL_ZONE_CORE   3
+
+#endif /* _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H */
-- 
2.4.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

Signed-off-by: Sascha Hauer s.ha...@pengutronix.de
---
 .../bindings/thermal/mediatek-thermal.txt  | 38 ++
 include/dt-bindings/thermal/mt8173.h   | 13 
 2 files changed, 51 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
 create mode 100644 include/dt-bindings/thermal/mt8173.h

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
new file mode 100644
index 000..1697375
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -0,0 +1,38 @@
+* Mediatek Thermal
+
+This describes the device tree binding for the Mediatek thermal controller
+which measures the on-SoC temperatures. This device does not have its own ADC,
+instead it directly controls the AUXADC via AHB bus accesses. For this reason
+this device needs phandles to the AUXADC. Also it controls a mux in the
+apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+is also needed.
+
+Required properties:
+- compatible: mediatek,mt8173-thermal
+- reg: Address range of the thermal controller
+- interrupts: IRQ for the thermal controller
+- clocks, clock-names: Clocks needed for the thermal controller. required
+   clocks are:
+  therm:  Main clock needed for register access
+  auxadc: The AUXADC clock
+- resets: Reference to the reset controller controlling the thermal controller.
+- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
+- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
+- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description. See
+ include/dt-bindings/thermal/mt8173.h for valid sensor
+ numbers.
+
+Example:
+
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = 1;
+   compatible = mediatek,mt8173-thermal;
+   reg = 0 0x1100b000 0 0x1000;
+   interrupts = 0 70 IRQ_TYPE_LEVEL_LOW;
+   clocks = pericfg CLK_PERI_THERM, pericfg CLK_PERI_AUXADC;
+   clock-names = therm, auxadc;
+   resets = pericfg MT8173_PERI_THERM_SW_RST;
+   reset-names = therm;
+   mediatek,auxadc = auxadc;
+   mediatek,apmixedsys = apmixedsys;
+   };
diff --git a/include/dt-bindings/thermal/mt8173.h 
b/include/dt-bindings/thermal/mt8173.h
new file mode 100644
index 000..692e74c
--- /dev/null
+++ b/include/dt-bindings/thermal/mt8173.h
@@ -0,0 +1,13 @@
+/*
+ * This header provides constants for mediatek,mt8173-thermal
+ */
+
+#ifndef _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
+#define _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H
+
+#define MT8173_THERMAL_ZONE_CA53   0
+#define MT8173_THERMAL_ZONE_CA57   1
+#define MT8173_THERMAL_ZONE_GPU2
+#define MT8173_THERMAL_ZONE_CORE   3
+
+#endif /* _DT_BINDINGS_THERMAL_MEDIATEK_MT8173_H */
-- 
2.4.6

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

Signed-off-by: Sascha Hauer 
---
 .../bindings/thermal/mediatek-thermal.txt  | 38 ++
 1 file changed, 38 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
new file mode 100644
index 000..c425a0f
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -0,0 +1,38 @@
+* Mediatek Thermal
+
+This describes the device tree binding for the Mediatek thermal controller
+which measures the on-SoC temperatures. This device does not have its own ADC,
+instead it directly controls the AUXADC via AHB bus accesses. For this reason
+this device needs phandles to the AUXADC. Also it controls a mux in the
+apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+is also needed.
+
+Required properties:
+- compatible: "mediatek,mt8173-thermal"
+- reg: Address range of the thermal controller
+- interrupts: IRQ for the thermal controller
+- clocks, clock-names: Clocks needed for the thermal controller. required
+   clocks are:
+   "therm":Main clock needed for register access
+   "auxadc":   The AUXADC clock
+- resets, reset-names: Reference to the reset controller controlling the 
thermal
+   controller. Required reset-names:
+   "therm":The main reset line
+- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
+- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
+- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description
+
+Example:
+
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = <1>;
+   compatible = "mediatek,mt8173-thermal";
+   reg = <0 0x1100b000 0 0x1000>;
+   interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
+   clocks = < CLK_PERI_THERM>, < CLK_PERI_AUXADC>;
+   clock-names = "therm", "auxadc";
+   resets = < MT8173_PERI_THERM_SW_RST>;
+   reset-names = "therm";
+   mediatek,auxadc = <>;
+   mediatek,apmixedsys = <>;
+   };
-- 
2.4.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

Signed-off-by: Sascha Hauer s.ha...@pengutronix.de
---
 .../bindings/thermal/mediatek-thermal.txt  | 38 ++
 1 file changed, 38 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
new file mode 100644
index 000..c425a0f
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -0,0 +1,38 @@
+* Mediatek Thermal
+
+This describes the device tree binding for the Mediatek thermal controller
+which measures the on-SoC temperatures. This device does not have its own ADC,
+instead it directly controls the AUXADC via AHB bus accesses. For this reason
+this device needs phandles to the AUXADC. Also it controls a mux in the
+apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+is also needed.
+
+Required properties:
+- compatible: mediatek,mt8173-thermal
+- reg: Address range of the thermal controller
+- interrupts: IRQ for the thermal controller
+- clocks, clock-names: Clocks needed for the thermal controller. required
+   clocks are:
+   therm:Main clock needed for register access
+   auxadc:   The AUXADC clock
+- resets, reset-names: Reference to the reset controller controlling the 
thermal
+   controller. Required reset-names:
+   therm:The main reset line
+- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
+- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
+- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description
+
+Example:
+
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = 1;
+   compatible = mediatek,mt8173-thermal;
+   reg = 0 0x1100b000 0 0x1000;
+   interrupts = 0 70 IRQ_TYPE_LEVEL_LOW;
+   clocks = pericfg CLK_PERI_THERM, pericfg CLK_PERI_AUXADC;
+   clock-names = therm, auxadc;
+   resets = pericfg MT8173_PERI_THERM_SW_RST;
+   reset-names = therm;
+   mediatek,auxadc = auxadc;
+   mediatek,apmixedsys = apmixedsys;
+   };
-- 
2.4.6

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

Signed-off-by: Sascha Hauer 
---
 .../bindings/thermal/mediatek-thermal.txt  | 38 ++
 1 file changed, 38 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
new file mode 100644
index 000..d90e4dc
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -0,0 +1,38 @@
+* Mediatek Thermal
+
+This describes the device tree binding for the Mediatek thermal controller
+which measures the on-SoC temperatures. This device does not have its own ADC,
+instead it directly controls the AUXADC via AHB bus accesses. For this reason
+this device needs phandles to the AUXADC. Also it controls a mux in the
+apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+is also needed.
+
+Required properties:
+- compatible: "mediatek,mt8173-thermal"
+- reg: Address range of the thermal controller
+- interrupts: IRQ for the thermal controller
+- clocks, clock-names: Clocks needed for the thermal controller. required
+   clocks are:
+   "therm":Main clock needed for register access
+   "auxadc":   The AUXADC clock
+- resets, reset-names: Reference to the reset controller controlling the 
thermal
+   controller. Required reset-names:
+   "therm":The main reset line
+- auxadc: A phandle to the AUXADC which the thermal controller uses
+- apmixedsys: A phandle to the APMIXEDSYS controller.
+- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description
+
+Example:
+
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = <1>;
+   compatible = "mediatek,mt8173-thermal";
+   reg = <0 0x1100b000 0 0x1000>;
+   interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
+   clocks = < CLK_PERI_THERM>, < CLK_PERI_AUXADC>;
+   clock-names = "therm", "auxadc";
+   resets = < MT8173_PERI_THERM_SW_RST>;
+   reset-names = "therm";
+   auxadc = <>;
+   apmixedsys = <>;
+   };
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

Signed-off-by: Sascha Hauer s.ha...@pengutronix.de
---
 .../bindings/thermal/mediatek-thermal.txt  | 38 ++
 1 file changed, 38 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
new file mode 100644
index 000..d90e4dc
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -0,0 +1,38 @@
+* Mediatek Thermal
+
+This describes the device tree binding for the Mediatek thermal controller
+which measures the on-SoC temperatures. This device does not have its own ADC,
+instead it directly controls the AUXADC via AHB bus accesses. For this reason
+this device needs phandles to the AUXADC. Also it controls a mux in the
+apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+is also needed.
+
+Required properties:
+- compatible: mediatek,mt8173-thermal
+- reg: Address range of the thermal controller
+- interrupts: IRQ for the thermal controller
+- clocks, clock-names: Clocks needed for the thermal controller. required
+   clocks are:
+   therm:Main clock needed for register access
+   auxadc:   The AUXADC clock
+- resets, reset-names: Reference to the reset controller controlling the 
thermal
+   controller. Required reset-names:
+   therm:The main reset line
+- auxadc: A phandle to the AUXADC which the thermal controller uses
+- apmixedsys: A phandle to the APMIXEDSYS controller.
+- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description
+
+Example:
+
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = 1;
+   compatible = mediatek,mt8173-thermal;
+   reg = 0 0x1100b000 0 0x1000;
+   interrupts = 0 70 IRQ_TYPE_LEVEL_LOW;
+   clocks = pericfg CLK_PERI_THERM, pericfg CLK_PERI_AUXADC;
+   clock-names = therm, auxadc;
+   resets = pericfg MT8173_PERI_THERM_SW_RST;
+   reset-names = therm;
+   auxadc = auxadc;
+   apmixedsys = apmixedsys;
+   };
-- 
2.1.4

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Daniel Kurtz]

On Mon, Jul 13, 2015 at 6:34 PM, Sascha Hauer  wrote:
> Signed-off-by: Sascha Hauer 
> ---
>  .../bindings/thermal/mediatek-thermal.txt  | 38 
> ++
>  1 file changed, 38 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
>
> diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
> b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> new file mode 100644
> index 000..d90e4dc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
> @@ -0,0 +1,38 @@
> +* Mediatek Thermal
> +
> +This describes the device tree binding for the Mediatek thermal controller
> +which measures the on-SoC temperatures. This device does not have its own 
> ADC,
> +instead it directly controls the AUXADC via AHB bus accesses. For this reason
> +this device needs phandles to the AUXADC. Also it controls a mux in the
> +apmixedsys register space via AHB bus accesses, so a phandle to the 
> APMIXEDSYS
> +is also needed.
> +
> +Required properties:
> +- compatible: "mediatek,mt8173-thermal"
> +- reg: Address range of the thermal controller
> +- interrupts: IRQ for the thermal controller
> +- clocks, clock-names: Clocks needed for the thermal controller. required
> +   clocks are:
> +   "therm":Main clock needed for register access
> +   "auxadc":   The AUXADC clock
> +- resets, reset-names: Reference to the reset controller controlling the 
> thermal
> +   controller. Required reset-names:
> +   "therm":The main reset line
> +- auxadc: A phandle to the AUXADC which the thermal controller uses
> +- apmixedsys: A phandle to the APMIXEDSYS controller.

Hmm, shouldn't these custom properties be prefixed with:
  "mediatek,..."

-Dan

> +- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description
> +
> +Example:
> +
> +   thermal: thermal@1100b000 {
> +   #thermal-sensor-cells = <1>;
> +   compatible = "mediatek,mt8173-thermal";
> +   reg = <0 0x1100b000 0 0x1000>;
> +   interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
> +   clocks = < CLK_PERI_THERM>, < 
> CLK_PERI_AUXADC>;
> +   clock-names = "therm", "auxadc";
> +   resets = < MT8173_PERI_THERM_SW_RST>;
> +   reset-names = "therm";
> +   auxadc = <>;
> +   apmixedsys = <>;
> +   };
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Daniel Kurtz]

On Mon, Jul 13, 2015 at 6:34 PM, Sascha Hauer s.ha...@pengutronix.de wrote:
 Signed-off-by: Sascha Hauer s.ha...@pengutronix.de
 ---
  .../bindings/thermal/mediatek-thermal.txt  | 38 
 ++
  1 file changed, 38 insertions(+)
  create mode 100644 
 Documentation/devicetree/bindings/thermal/mediatek-thermal.txt

 diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
 b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
 new file mode 100644
 index 000..d90e4dc
 --- /dev/null
 +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
 @@ -0,0 +1,38 @@
 +* Mediatek Thermal
 +
 +This describes the device tree binding for the Mediatek thermal controller
 +which measures the on-SoC temperatures. This device does not have its own 
 ADC,
 +instead it directly controls the AUXADC via AHB bus accesses. For this reason
 +this device needs phandles to the AUXADC. Also it controls a mux in the
 +apmixedsys register space via AHB bus accesses, so a phandle to the 
 APMIXEDSYS
 +is also needed.
 +
 +Required properties:
 +- compatible: mediatek,mt8173-thermal
 +- reg: Address range of the thermal controller
 +- interrupts: IRQ for the thermal controller
 +- clocks, clock-names: Clocks needed for the thermal controller. required
 +   clocks are:
 +   therm:Main clock needed for register access
 +   auxadc:   The AUXADC clock
 +- resets, reset-names: Reference to the reset controller controlling the 
 thermal
 +   controller. Required reset-names:
 +   therm:The main reset line
 +- auxadc: A phandle to the AUXADC which the thermal controller uses
 +- apmixedsys: A phandle to the APMIXEDSYS controller.

Hmm, shouldn't these custom properties be prefixed with:
  mediatek,...

-Dan

 +- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description
 +
 +Example:
 +
 +   thermal: thermal@1100b000 {
 +   #thermal-sensor-cells = 1;
 +   compatible = mediatek,mt8173-thermal;
 +   reg = 0 0x1100b000 0 0x1000;
 +   interrupts = 0 70 IRQ_TYPE_LEVEL_LOW;
 +   clocks = pericfg CLK_PERI_THERM, pericfg 
 CLK_PERI_AUXADC;
 +   clock-names = therm, auxadc;
 +   resets = pericfg MT8173_PERI_THERM_SW_RST;
 +   reset-names = therm;
 +   auxadc = auxadc;
 +   apmixedsys = apmixedsys;
 +   };
 --
 2.1.4

 --
 To unsubscribe from this list: send the line unsubscribe linux-kernel in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
 Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

Signed-off-by: Sascha Hauer 
---
 .../bindings/thermal/mediatek-thermal.txt  | 38 ++
 1 file changed, 38 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
new file mode 100644
index 000..d90e4dc
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -0,0 +1,38 @@
+* Mediatek Thermal
+
+This describes the device tree binding for the Mediatek thermal controller
+which measures the on-SoC temperatures. This device does not have its own ADC,
+instead it directly controls the AUXADC via AHB bus accesses. For this reason
+this device needs phandles to the AUXADC. Also it controls a mux in the
+apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+is also needed.
+
+Required properties:
+- compatible: "mediatek,mt8173-thermal"
+- reg: Address range of the thermal controller
+- interrupts: IRQ for the thermal controller
+- clocks, clock-names: Clocks needed for the thermal controller. required
+   clocks are:
+   "therm":Main clock needed for register access
+   "auxadc":   The AUXADC clock
+- resets, reset-names: Reference to the reset controller controlling the 
thermal
+   controller. Required reset-names:
+   "therm":The main reset line
+- auxadc: A phandle to the AUXADC which the thermal controller uses
+- apmixedsys: A phandle to the APMIXEDSYS controller.
+- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description
+
+Example:
+
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = <1>;
+   compatible = "mediatek,mt8173-thermal";
+   reg = <0 0x1100b000 0 0x1000>;
+   interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>;
+   clocks = < CLK_PERI_THERM>, < CLK_PERI_AUXADC>;
+   clock-names = "therm", "auxadc";
+   resets = < MT8173_PERI_THERM_SW_RST>;
+   reset-names = "therm";
+   auxadc = <>;
+   apmixedsys = <>;
+   };
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller

[Sascha Hauer]

Signed-off-by: Sascha Hauer s.ha...@pengutronix.de
---
 .../bindings/thermal/mediatek-thermal.txt  | 38 ++
 1 file changed, 38 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal.txt

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
new file mode 100644
index 000..d90e4dc
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -0,0 +1,38 @@
+* Mediatek Thermal
+
+This describes the device tree binding for the Mediatek thermal controller
+which measures the on-SoC temperatures. This device does not have its own ADC,
+instead it directly controls the AUXADC via AHB bus accesses. For this reason
+this device needs phandles to the AUXADC. Also it controls a mux in the
+apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+is also needed.
+
+Required properties:
+- compatible: mediatek,mt8173-thermal
+- reg: Address range of the thermal controller
+- interrupts: IRQ for the thermal controller
+- clocks, clock-names: Clocks needed for the thermal controller. required
+   clocks are:
+   therm:Main clock needed for register access
+   auxadc:   The AUXADC clock
+- resets, reset-names: Reference to the reset controller controlling the 
thermal
+   controller. Required reset-names:
+   therm:The main reset line
+- auxadc: A phandle to the AUXADC which the thermal controller uses
+- apmixedsys: A phandle to the APMIXEDSYS controller.
+- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description
+
+Example:
+
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = 1;
+   compatible = mediatek,mt8173-thermal;
+   reg = 0 0x1100b000 0 0x1000;
+   interrupts = 0 70 IRQ_TYPE_LEVEL_LOW;
+   clocks = pericfg CLK_PERI_THERM, pericfg CLK_PERI_AUXADC;
+   clock-names = therm, auxadc;
+   resets = pericfg MT8173_PERI_THERM_SW_RST;
+   reset-names = therm;
+   auxadc = auxadc;
+   apmixedsys = apmixedsys;
+   };
-- 
2.1.4

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/