[PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

2014-05-22 Thread Lee Jones 
The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
devices. It has 2 ports which it can use for either; both SATA, both
PCIe or one of each in any configuration.

Cc: Srinivas Kandagatla 
Acked-by: Mark Rutland 
Acked-by: Alexandre Torgue 
Signed-off-by: Lee Jones 
---
 arch/arm/boot/dts/stih416-b2020-revE.dts |  5 +
 arch/arm/boot/dts/stih416-b2020.dts  |  6 ++
 arch/arm/boot/dts/stih416.dtsi   | 14 ++
 3 files changed, 25 insertions(+)

diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts 
b/arch/arm/boot/dts/stih416-b2020-revE.dts
index ba0fa2c..0e2c870 100644
--- a/arch/arm/boot/dts/stih416-b2020-revE.dts
+++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
@@ -31,5 +31,10 @@
ethernet1: dwmac@fef08000 {
snps,reset-gpio = < 7>;
};
+
+   miphy365x_phy: miphy365x@fe382000 {
+   st,pcie-tx-pol-inv;
+   st,sata-gen = <3>;
+   };
};
 };
diff --git a/arch/arm/boot/dts/stih416-b2020.dts 
b/arch/arm/boot/dts/stih416-b2020.dts
index 276f28d..172f222 100644
--- a/arch/arm/boot/dts/stih416-b2020.dts
+++ b/arch/arm/boot/dts/stih416-b2020.dts
@@ -13,4 +13,10 @@
model = "STiH416 B2020";
compatible = "st,stih416", "st,stih416-b2020";
 
+   soc {
+   miphy365x_phy: miphy365x@fe382000 {
+   st,pcie-tx-pol-inv;
+   st,sata-gen = <3>;
+   };
+   };
 };
diff --git a/arch/arm/boot/dts/stih416.dtsi b/arch/arm/boot/dts/stih416.dtsi
index 78746d2..00b217a 100644
--- a/arch/arm/boot/dts/stih416.dtsi
+++ b/arch/arm/boot/dts/stih416.dtsi
@@ -9,6 +9,8 @@
 #include "stih41x.dtsi"
 #include "stih416-clock.dtsi"
 #include "stih416-pinctrl.dtsi"
+
+#include 
 #include 
 #include 
 / {
@@ -224,5 +226,17 @@
 
status = "disabled";
};
+
+   miphy365x_phy: miphy365x@fe382000 {
+   compatible  = "st,miphy365x-phy";
+   reg = <0xfe382000 0x100>,
+ <0xfe38a000 0x100>,
+ <0xfe394000 0x100>,
+ <0xfe804000 0x100>;
+   reg-names   = "sata0", "sata1", "pcie0", "pcie1";
+
+   #phy-cells  = <2>;
+   st,syscfg   = <_rear>;
+   };
};
 };
-- 
1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

2014-05-22 Thread Lee Jones 
The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
devices. It has 2 ports which it can use for either; both SATA, both
PCIe or one of each in any configuration.

Cc: Srinivas Kandagatla srinivas.kandaga...@st.com
Acked-by: Mark Rutland mark.rutl...@arm.com
Acked-by: Alexandre Torgue alexandre.tor...@st.com
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
 arch/arm/boot/dts/stih416-b2020-revE.dts |  5 +
 arch/arm/boot/dts/stih416-b2020.dts  |  6 ++
 arch/arm/boot/dts/stih416.dtsi   | 14 ++
 3 files changed, 25 insertions(+)

diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts 
b/arch/arm/boot/dts/stih416-b2020-revE.dts
index ba0fa2c..0e2c870 100644
--- a/arch/arm/boot/dts/stih416-b2020-revE.dts
+++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
@@ -31,5 +31,10 @@
ethernet1: dwmac@fef08000 {
snps,reset-gpio = PIO0 7;
};
+
+   miphy365x_phy: miphy365x@fe382000 {
+   st,pcie-tx-pol-inv;
+   st,sata-gen = 3;
+   };
};
 };
diff --git a/arch/arm/boot/dts/stih416-b2020.dts 
b/arch/arm/boot/dts/stih416-b2020.dts
index 276f28d..172f222 100644
--- a/arch/arm/boot/dts/stih416-b2020.dts
+++ b/arch/arm/boot/dts/stih416-b2020.dts
@@ -13,4 +13,10 @@
model = STiH416 B2020;
compatible = st,stih416, st,stih416-b2020;
 
+   soc {
+   miphy365x_phy: miphy365x@fe382000 {
+   st,pcie-tx-pol-inv;
+   st,sata-gen = 3;
+   };
+   };
 };
diff --git a/arch/arm/boot/dts/stih416.dtsi b/arch/arm/boot/dts/stih416.dtsi
index 78746d2..00b217a 100644
--- a/arch/arm/boot/dts/stih416.dtsi
+++ b/arch/arm/boot/dts/stih416.dtsi
@@ -9,6 +9,8 @@
 #include stih41x.dtsi
 #include stih416-clock.dtsi
 #include stih416-pinctrl.dtsi
+
+#include dt-bindings/phy/phy-miphy365x.h
 #include dt-bindings/interrupt-controller/arm-gic.h
 #include dt-bindings/reset-controller/stih416-resets.h
 / {
@@ -224,5 +226,17 @@
 
status = disabled;
};
+
+   miphy365x_phy: miphy365x@fe382000 {
+   compatible  = st,miphy365x-phy;
+   reg = 0xfe382000 0x100,
+ 0xfe38a000 0x100,
+ 0xfe394000 0x100,
+ 0xfe804000 0x100;
+   reg-names   = sata0, sata1, pcie0, pcie1;
+
+   #phy-cells  = 2;
+   st,syscfg   = syscfg_rear;
+   };
};
 };
-- 
1.8.3.2

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [STLinux Kernel] [PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

2014-05-20 Thread Maxime Coquelin 



On 05/20/2014 10:28 AM, Lee Jones wrote:

The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
devices. It has 2 ports which it can use for either; both SATA, both
PCIe or one of each in any configuration.

Cc: Srinivas Kandagatla 
Acked-by: Mark Rutland 
Acked-by: Alexandre Torgue 
Signed-off-by: Lee Jones 
---
  arch/arm/boot/dts/stih416-b2020-revE.dts | 22 ++
  arch/arm/boot/dts/stih416-b2020.dts  |  6 ++
  arch/arm/boot/dts/stih416.dtsi   | 14 ++
  3 files changed, 42 insertions(+)
  create mode 100644 arch/arm/boot/dts/stih416-b2020-revE.dts

diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts 
b/arch/arm/boot/dts/stih416-b2020-revE.dts
new file mode 100644
index 000..23fdaf7
--- /dev/null
+++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
@@ -0,0 +1,22 @@
+/*
+ * Copyright (C) 2014 STMicroelectronics Limited.
+ * Author: Lee Jones 
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * publishhed by the Free Software Foundation.
+ */
+/dts-v1/;
+#include "stih416.dtsi"
+#include "stih41x-b2020.dtsi"
+/ {
+model = "STiH416 B2020 REV-E";
+   compatible = "st,stih416-b2020", "st,stih416";
+
+   soc {
+   miphy365x_phy: miphy365x@fe382000 {
+   st,pcie-tx-pol-inv;
+   st,sata-gen = <3>;
+   };
+   };
+};

Shouldn't this new board being added in a separate patch?


I certainly can do that, but I don't think that it's necessary?


I think it is, as you introduce a new board.


Introducing an empty dts file just so you can say "this is a new
board" seems odd to me, but I'll go with whatever you feel it right.


Moreover, the miphy description being the same as in
stih416-b2020.dts, so I don't understand why you introduce this
board for this feature.


It's historical.  There are other differences between rev-E and the
other reversions, such as; gpio-leds (red, green) and the reset GPIO
for ethernet.  As these are dts files (rather than dtsi) files, you
can only use one at a time.


My point was to create a new patch that would also introduce the 
differences (Ethernet, leds...). The commit message would explain the 
differences versus stih416-b2020.


From your patch, if I didn't know the differences, I would ask why you 
don't use stih416-b2020.dts.


If you have another pending patch that make Ethernet to work on revE 
board, you can keep this one as it is.





diff --git a/arch/arm/boot/dts/stih416-b2020.dts 
b/arch/arm/boot/dts/stih416-b2020.dts
index 276f28d..172f222 100644
--- a/arch/arm/boot/dts/stih416-b2020.dts
+++ b/arch/arm/boot/dts/stih416-b2020.dts
@@ -13,4 +13,10 @@
model = "STiH416 B2020";
compatible = "st,stih416", "st,stih416-b2020";

+   soc {
+   miphy365x_phy: miphy365x@fe382000 {
+   st,pcie-tx-pol-inv;
+   st,sata-gen = <3>;
+   };
+   };
  };

...





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [STLinux Kernel] [PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

2014-05-20 Thread Lee Jones 
> >>>The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
> >>>devices. It has 2 ports which it can use for either; both SATA, both
> >>>PCIe or one of each in any configuration.
> >>>
> >>>Cc: Srinivas Kandagatla 
> >>>Acked-by: Mark Rutland 
> >>>Acked-by: Alexandre Torgue 
> >>>Signed-off-by: Lee Jones 
> >>>---
> >>>  arch/arm/boot/dts/stih416-b2020-revE.dts | 22 ++
> >>>  arch/arm/boot/dts/stih416-b2020.dts  |  6 ++
> >>>  arch/arm/boot/dts/stih416.dtsi   | 14 ++
> >>>  3 files changed, 42 insertions(+)
> >>>  create mode 100644 arch/arm/boot/dts/stih416-b2020-revE.dts
> >>>
> >>>diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts 
> >>>b/arch/arm/boot/dts/stih416-b2020-revE.dts
> >>>new file mode 100644
> >>>index 000..23fdaf7
> >>>--- /dev/null
> >>>+++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
> >>>@@ -0,0 +1,22 @@
> >>>+/*
> >>>+ * Copyright (C) 2014 STMicroelectronics Limited.
> >>>+ * Author: Lee Jones 
> >>>+ *
> >>>+ * This program is free software; you can redistribute it and/or modify
> >>>+ * it under the terms of the GNU General Public License version 2 as
> >>>+ * publishhed by the Free Software Foundation.
> >>>+ */
> >>>+/dts-v1/;
> >>>+#include "stih416.dtsi"
> >>>+#include "stih41x-b2020.dtsi"
> >>>+/ {
> >>>+model = "STiH416 B2020 REV-E";
> >>>+  compatible = "st,stih416-b2020", "st,stih416";
> >>>+
> >>>+  soc {
> >>>+  miphy365x_phy: miphy365x@fe382000 {
> >>>+  st,pcie-tx-pol-inv;
> >>>+  st,sata-gen = <3>;
> >>>+  };
> >>>+  };
> >>>+};
> >>Shouldn't this new board being added in a separate patch?
> >
> >I certainly can do that, but I don't think that it's necessary?
> 
> I think it is, as you introduce a new board.

Introducing an empty dts file just so you can say "this is a new
board" seems odd to me, but I'll go with whatever you feel it right.

> Moreover, the miphy description being the same as in
> stih416-b2020.dts, so I don't understand why you introduce this
> board for this feature.

It's historical.  There are other differences between rev-E and the
other reversions, such as; gpio-leds (red, green) and the reset GPIO
for ethernet.  As these are dts files (rather than dtsi) files, you
can only use one at a time.

> >>>diff --git a/arch/arm/boot/dts/stih416-b2020.dts 
> >>>b/arch/arm/boot/dts/stih416-b2020.dts
> >>>index 276f28d..172f222 100644
> >>>--- a/arch/arm/boot/dts/stih416-b2020.dts
> >>>+++ b/arch/arm/boot/dts/stih416-b2020.dts
> >>>@@ -13,4 +13,10 @@
> >>>   model = "STiH416 B2020";
> >>>   compatible = "st,stih416", "st,stih416-b2020";
> >>>
> >>>+  soc {
> >>>+  miphy365x_phy: miphy365x@fe382000 {
> >>>+  st,pcie-tx-pol-inv;
> >>>+  st,sata-gen = <3>;
> >>>+  };
> >>>+  };
> >>>  };
> >>...
> >

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [STLinux Kernel] [PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

2014-05-20 Thread Maxime Coquelin 


On 05/19/2014 05:51 PM, Lee Jones wrote:

The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
devices. It has 2 ports which it can use for either; both SATA, both
PCIe or one of each in any configuration.

Cc: Srinivas Kandagatla 
Acked-by: Mark Rutland 
Acked-by: Alexandre Torgue 
Signed-off-by: Lee Jones 
---
  arch/arm/boot/dts/stih416-b2020-revE.dts | 22 ++
  arch/arm/boot/dts/stih416-b2020.dts  |  6 ++
  arch/arm/boot/dts/stih416.dtsi   | 14 ++
  3 files changed, 42 insertions(+)
  create mode 100644 arch/arm/boot/dts/stih416-b2020-revE.dts

diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts 
b/arch/arm/boot/dts/stih416-b2020-revE.dts
new file mode 100644
index 000..23fdaf7
--- /dev/null
+++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
@@ -0,0 +1,22 @@
+/*
+ * Copyright (C) 2014 STMicroelectronics Limited.
+ * Author: Lee Jones 
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * publishhed by the Free Software Foundation.
+ */
+/dts-v1/;
+#include "stih416.dtsi"
+#include "stih41x-b2020.dtsi"
+/ {
+model = "STiH416 B2020 REV-E";
+   compatible = "st,stih416-b2020", "st,stih416";
+
+   soc {
+   miphy365x_phy: miphy365x@fe382000 {
+   st,pcie-tx-pol-inv;
+   st,sata-gen = <3>;
+   };
+   };
+};

Shouldn't this new board being added in a separate patch?


I certainly can do that, but I don't think that it's necessary?


I think it is, as you introduce a new board.
Moreover, the miphy description being the same as in stih416-b2020.dts, 
so I don't understand why you introduce this board for this feature.






diff --git a/arch/arm/boot/dts/stih416-b2020.dts 
b/arch/arm/boot/dts/stih416-b2020.dts
index 276f28d..172f222 100644
--- a/arch/arm/boot/dts/stih416-b2020.dts
+++ b/arch/arm/boot/dts/stih416-b2020.dts
@@ -13,4 +13,10 @@
model = "STiH416 B2020";
compatible = "st,stih416", "st,stih416-b2020";

+   soc {
+   miphy365x_phy: miphy365x@fe382000 {
+   st,pcie-tx-pol-inv;
+   st,sata-gen = <3>;
+   };
+   };
  };

...



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [STLinux Kernel] [PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

2014-05-20 Thread Maxime Coquelin 


On 05/19/2014 05:51 PM, Lee Jones wrote:

The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
devices. It has 2 ports which it can use for either; both SATA, both
PCIe or one of each in any configuration.

Cc: Srinivas Kandagatla srinivas.kandaga...@st.com
Acked-by: Mark Rutland mark.rutl...@arm.com
Acked-by: Alexandre Torgue alexandre.tor...@st.com
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
  arch/arm/boot/dts/stih416-b2020-revE.dts | 22 ++
  arch/arm/boot/dts/stih416-b2020.dts  |  6 ++
  arch/arm/boot/dts/stih416.dtsi   | 14 ++
  3 files changed, 42 insertions(+)
  create mode 100644 arch/arm/boot/dts/stih416-b2020-revE.dts

diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts 
b/arch/arm/boot/dts/stih416-b2020-revE.dts
new file mode 100644
index 000..23fdaf7
--- /dev/null
+++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
@@ -0,0 +1,22 @@
+/*
+ * Copyright (C) 2014 STMicroelectronics Limited.
+ * Author: Lee Jones lee.jo...@linaro.org
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * publishhed by the Free Software Foundation.
+ */
+/dts-v1/;
+#include stih416.dtsi
+#include stih41x-b2020.dtsi
+/ {
+model = STiH416 B2020 REV-E;
+   compatible = st,stih416-b2020, st,stih416;
+
+   soc {
+   miphy365x_phy: miphy365x@fe382000 {
+   st,pcie-tx-pol-inv;
+   st,sata-gen = 3;
+   };
+   };
+};

Shouldn't this new board being added in a separate patch?


I certainly can do that, but I don't think that it's necessary?


I think it is, as you introduce a new board.
Moreover, the miphy description being the same as in stih416-b2020.dts, 
so I don't understand why you introduce this board for this feature.






diff --git a/arch/arm/boot/dts/stih416-b2020.dts 
b/arch/arm/boot/dts/stih416-b2020.dts
index 276f28d..172f222 100644
--- a/arch/arm/boot/dts/stih416-b2020.dts
+++ b/arch/arm/boot/dts/stih416-b2020.dts
@@ -13,4 +13,10 @@
model = STiH416 B2020;
compatible = st,stih416, st,stih416-b2020;

+   soc {
+   miphy365x_phy: miphy365x@fe382000 {
+   st,pcie-tx-pol-inv;
+   st,sata-gen = 3;
+   };
+   };
  };

...



--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [STLinux Kernel] [PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

2014-05-20 Thread Lee Jones 
 The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
 devices. It has 2 ports which it can use for either; both SATA, both
 PCIe or one of each in any configuration.
 
 Cc: Srinivas Kandagatla srinivas.kandaga...@st.com
 Acked-by: Mark Rutland mark.rutl...@arm.com
 Acked-by: Alexandre Torgue alexandre.tor...@st.com
 Signed-off-by: Lee Jones lee.jo...@linaro.org
 ---
   arch/arm/boot/dts/stih416-b2020-revE.dts | 22 ++
   arch/arm/boot/dts/stih416-b2020.dts  |  6 ++
   arch/arm/boot/dts/stih416.dtsi   | 14 ++
   3 files changed, 42 insertions(+)
   create mode 100644 arch/arm/boot/dts/stih416-b2020-revE.dts
 
 diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts 
 b/arch/arm/boot/dts/stih416-b2020-revE.dts
 new file mode 100644
 index 000..23fdaf7
 --- /dev/null
 +++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
 @@ -0,0 +1,22 @@
 +/*
 + * Copyright (C) 2014 STMicroelectronics Limited.
 + * Author: Lee Jones lee.jo...@linaro.org
 + *
 + * This program is free software; you can redistribute it and/or modify
 + * it under the terms of the GNU General Public License version 2 as
 + * publishhed by the Free Software Foundation.
 + */
 +/dts-v1/;
 +#include stih416.dtsi
 +#include stih41x-b2020.dtsi
 +/ {
 +model = STiH416 B2020 REV-E;
 +  compatible = st,stih416-b2020, st,stih416;
 +
 +  soc {
 +  miphy365x_phy: miphy365x@fe382000 {
 +  st,pcie-tx-pol-inv;
 +  st,sata-gen = 3;
 +  };
 +  };
 +};
 Shouldn't this new board being added in a separate patch?
 
 I certainly can do that, but I don't think that it's necessary?
 
 I think it is, as you introduce a new board.

Introducing an empty dts file just so you can say this is a new
board seems odd to me, but I'll go with whatever you feel it right.

 Moreover, the miphy description being the same as in
 stih416-b2020.dts, so I don't understand why you introduce this
 board for this feature.

It's historical.  There are other differences between rev-E and the
other reversions, such as; gpio-leds (red, green) and the reset GPIO
for ethernet.  As these are dts files (rather than dtsi) files, you
can only use one at a time.

 diff --git a/arch/arm/boot/dts/stih416-b2020.dts 
 b/arch/arm/boot/dts/stih416-b2020.dts
 index 276f28d..172f222 100644
 --- a/arch/arm/boot/dts/stih416-b2020.dts
 +++ b/arch/arm/boot/dts/stih416-b2020.dts
 @@ -13,4 +13,10 @@
model = STiH416 B2020;
compatible = st,stih416, st,stih416-b2020;
 
 +  soc {
 +  miphy365x_phy: miphy365x@fe382000 {
 +  st,pcie-tx-pol-inv;
 +  st,sata-gen = 3;
 +  };
 +  };
   };
 ...
 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [STLinux Kernel] [PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

2014-05-20 Thread Maxime Coquelin 



On 05/20/2014 10:28 AM, Lee Jones wrote:

The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
devices. It has 2 ports which it can use for either; both SATA, both
PCIe or one of each in any configuration.

Cc: Srinivas Kandagatla srinivas.kandaga...@st.com
Acked-by: Mark Rutland mark.rutl...@arm.com
Acked-by: Alexandre Torgue alexandre.tor...@st.com
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
  arch/arm/boot/dts/stih416-b2020-revE.dts | 22 ++
  arch/arm/boot/dts/stih416-b2020.dts  |  6 ++
  arch/arm/boot/dts/stih416.dtsi   | 14 ++
  3 files changed, 42 insertions(+)
  create mode 100644 arch/arm/boot/dts/stih416-b2020-revE.dts

diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts 
b/arch/arm/boot/dts/stih416-b2020-revE.dts
new file mode 100644
index 000..23fdaf7
--- /dev/null
+++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
@@ -0,0 +1,22 @@
+/*
+ * Copyright (C) 2014 STMicroelectronics Limited.
+ * Author: Lee Jones lee.jo...@linaro.org
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * publishhed by the Free Software Foundation.
+ */
+/dts-v1/;
+#include stih416.dtsi
+#include stih41x-b2020.dtsi
+/ {
+model = STiH416 B2020 REV-E;
+   compatible = st,stih416-b2020, st,stih416;
+
+   soc {
+   miphy365x_phy: miphy365x@fe382000 {
+   st,pcie-tx-pol-inv;
+   st,sata-gen = 3;
+   };
+   };
+};

Shouldn't this new board being added in a separate patch?


I certainly can do that, but I don't think that it's necessary?


I think it is, as you introduce a new board.


Introducing an empty dts file just so you can say this is a new
board seems odd to me, but I'll go with whatever you feel it right.


Moreover, the miphy description being the same as in
stih416-b2020.dts, so I don't understand why you introduce this
board for this feature.


It's historical.  There are other differences between rev-E and the
other reversions, such as; gpio-leds (red, green) and the reset GPIO
for ethernet.  As these are dts files (rather than dtsi) files, you
can only use one at a time.


My point was to create a new patch that would also introduce the 
differences (Ethernet, leds...). The commit message would explain the 
differences versus stih416-b2020.


From your patch, if I didn't know the differences, I would ask why you 
don't use stih416-b2020.dts.


If you have another pending patch that make Ethernet to work on revE 
board, you can keep this one as it is.





diff --git a/arch/arm/boot/dts/stih416-b2020.dts 
b/arch/arm/boot/dts/stih416-b2020.dts
index 276f28d..172f222 100644
--- a/arch/arm/boot/dts/stih416-b2020.dts
+++ b/arch/arm/boot/dts/stih416-b2020.dts
@@ -13,4 +13,10 @@
model = STiH416 B2020;
compatible = st,stih416, st,stih416-b2020;

+   soc {
+   miphy365x_phy: miphy365x@fe382000 {
+   st,pcie-tx-pol-inv;
+   st,sata-gen = 3;
+   };
+   };
  };

...





--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [STLinux Kernel] [PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

2014-05-19 Thread Lee Jones 
> >The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
> >devices. It has 2 ports which it can use for either; both SATA, both
> >PCIe or one of each in any configuration.
> >
> >Cc: Srinivas Kandagatla 
> >Acked-by: Mark Rutland 
> >Acked-by: Alexandre Torgue 
> >Signed-off-by: Lee Jones 
> >---
> >  arch/arm/boot/dts/stih416-b2020-revE.dts | 22 ++
> >  arch/arm/boot/dts/stih416-b2020.dts  |  6 ++
> >  arch/arm/boot/dts/stih416.dtsi   | 14 ++
> >  3 files changed, 42 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/stih416-b2020-revE.dts
> >
> >diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts 
> >b/arch/arm/boot/dts/stih416-b2020-revE.dts
> >new file mode 100644
> >index 000..23fdaf7
> >--- /dev/null
> >+++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
> >@@ -0,0 +1,22 @@
> >+/*
> >+ * Copyright (C) 2014 STMicroelectronics Limited.
> >+ * Author: Lee Jones 
> >+ *
> >+ * This program is free software; you can redistribute it and/or modify
> >+ * it under the terms of the GNU General Public License version 2 as
> >+ * publishhed by the Free Software Foundation.
> >+ */
> >+/dts-v1/;
> >+#include "stih416.dtsi"
> >+#include "stih41x-b2020.dtsi"
> >+/ {
> >+model = "STiH416 B2020 REV-E";
> >+compatible = "st,stih416-b2020", "st,stih416";
> >+
> >+soc {
> >+miphy365x_phy: miphy365x@fe382000 {
> >+st,pcie-tx-pol-inv;
> >+st,sata-gen = <3>;
> >+};
> >+};
> >+};
> Shouldn't this new board being added in a separate patch?

I certainly can do that, but I don't think that it's necessary?

> >diff --git a/arch/arm/boot/dts/stih416-b2020.dts 
> >b/arch/arm/boot/dts/stih416-b2020.dts
> >index 276f28d..172f222 100644
> >--- a/arch/arm/boot/dts/stih416-b2020.dts
> >+++ b/arch/arm/boot/dts/stih416-b2020.dts
> >@@ -13,4 +13,10 @@
> > model = "STiH416 B2020";
> > compatible = "st,stih416", "st,stih416-b2020";
> >
> >+soc {
> >+miphy365x_phy: miphy365x@fe382000 {
> >+st,pcie-tx-pol-inv;
> >+st,sata-gen = <3>;
> >+};
> >+};
> >  };
> ...

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [STLinux Kernel] [PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

2014-05-19 Thread Maxime Coquelin 



On 04/29/2014 09:21 AM, Lee Jones wrote:

The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
devices. It has 2 ports which it can use for either; both SATA, both
PCIe or one of each in any configuration.

Cc: Srinivas Kandagatla 
Acked-by: Mark Rutland 
Acked-by: Alexandre Torgue 
Signed-off-by: Lee Jones 
---
  arch/arm/boot/dts/stih416-b2020-revE.dts | 22 ++
  arch/arm/boot/dts/stih416-b2020.dts  |  6 ++
  arch/arm/boot/dts/stih416.dtsi   | 14 ++
  3 files changed, 42 insertions(+)
  create mode 100644 arch/arm/boot/dts/stih416-b2020-revE.dts

diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts 
b/arch/arm/boot/dts/stih416-b2020-revE.dts
new file mode 100644
index 000..23fdaf7
--- /dev/null
+++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
@@ -0,0 +1,22 @@
+/*
+ * Copyright (C) 2014 STMicroelectronics Limited.
+ * Author: Lee Jones 
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * publishhed by the Free Software Foundation.
+ */
+/dts-v1/;
+#include "stih416.dtsi"
+#include "stih41x-b2020.dtsi"
+/ {
+model = "STiH416 B2020 REV-E";
+   compatible = "st,stih416-b2020", "st,stih416";
+
+   soc {
+   miphy365x_phy: miphy365x@fe382000 {
+   st,pcie-tx-pol-inv;
+   st,sata-gen = <3>;
+   };
+   };
+};

Shouldn't this new board being added in a separate patch?




diff --git a/arch/arm/boot/dts/stih416-b2020.dts 
b/arch/arm/boot/dts/stih416-b2020.dts
index 276f28d..172f222 100644
--- a/arch/arm/boot/dts/stih416-b2020.dts
+++ b/arch/arm/boot/dts/stih416-b2020.dts
@@ -13,4 +13,10 @@
model = "STiH416 B2020";
compatible = "st,stih416", "st,stih416-b2020";

+   soc {
+   miphy365x_phy: miphy365x@fe382000 {
+   st,pcie-tx-pol-inv;
+   st,sata-gen = <3>;
+   };
+   };
  };

...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [STLinux Kernel] [PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

2014-05-19 Thread Maxime Coquelin 



On 04/29/2014 09:21 AM, Lee Jones wrote:

The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
devices. It has 2 ports which it can use for either; both SATA, both
PCIe or one of each in any configuration.

Cc: Srinivas Kandagatla srinivas.kandaga...@st.com
Acked-by: Mark Rutland mark.rutl...@arm.com
Acked-by: Alexandre Torgue alexandre.tor...@st.com
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
  arch/arm/boot/dts/stih416-b2020-revE.dts | 22 ++
  arch/arm/boot/dts/stih416-b2020.dts  |  6 ++
  arch/arm/boot/dts/stih416.dtsi   | 14 ++
  3 files changed, 42 insertions(+)
  create mode 100644 arch/arm/boot/dts/stih416-b2020-revE.dts

diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts 
b/arch/arm/boot/dts/stih416-b2020-revE.dts
new file mode 100644
index 000..23fdaf7
--- /dev/null
+++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
@@ -0,0 +1,22 @@
+/*
+ * Copyright (C) 2014 STMicroelectronics Limited.
+ * Author: Lee Jones lee.jo...@linaro.org
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * publishhed by the Free Software Foundation.
+ */
+/dts-v1/;
+#include stih416.dtsi
+#include stih41x-b2020.dtsi
+/ {
+model = STiH416 B2020 REV-E;
+   compatible = st,stih416-b2020, st,stih416;
+
+   soc {
+   miphy365x_phy: miphy365x@fe382000 {
+   st,pcie-tx-pol-inv;
+   st,sata-gen = 3;
+   };
+   };
+};

Shouldn't this new board being added in a separate patch?




diff --git a/arch/arm/boot/dts/stih416-b2020.dts 
b/arch/arm/boot/dts/stih416-b2020.dts
index 276f28d..172f222 100644
--- a/arch/arm/boot/dts/stih416-b2020.dts
+++ b/arch/arm/boot/dts/stih416-b2020.dts
@@ -13,4 +13,10 @@
model = STiH416 B2020;
compatible = st,stih416, st,stih416-b2020;

+   soc {
+   miphy365x_phy: miphy365x@fe382000 {
+   st,pcie-tx-pol-inv;
+   st,sata-gen = 3;
+   };
+   };
  };

...
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [STLinux Kernel] [PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

2014-05-19 Thread Lee Jones 
 The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
 devices. It has 2 ports which it can use for either; both SATA, both
 PCIe or one of each in any configuration.
 
 Cc: Srinivas Kandagatla srinivas.kandaga...@st.com
 Acked-by: Mark Rutland mark.rutl...@arm.com
 Acked-by: Alexandre Torgue alexandre.tor...@st.com
 Signed-off-by: Lee Jones lee.jo...@linaro.org
 ---
   arch/arm/boot/dts/stih416-b2020-revE.dts | 22 ++
   arch/arm/boot/dts/stih416-b2020.dts  |  6 ++
   arch/arm/boot/dts/stih416.dtsi   | 14 ++
   3 files changed, 42 insertions(+)
   create mode 100644 arch/arm/boot/dts/stih416-b2020-revE.dts
 
 diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts 
 b/arch/arm/boot/dts/stih416-b2020-revE.dts
 new file mode 100644
 index 000..23fdaf7
 --- /dev/null
 +++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
 @@ -0,0 +1,22 @@
 +/*
 + * Copyright (C) 2014 STMicroelectronics Limited.
 + * Author: Lee Jones lee.jo...@linaro.org
 + *
 + * This program is free software; you can redistribute it and/or modify
 + * it under the terms of the GNU General Public License version 2 as
 + * publishhed by the Free Software Foundation.
 + */
 +/dts-v1/;
 +#include stih416.dtsi
 +#include stih41x-b2020.dtsi
 +/ {
 +model = STiH416 B2020 REV-E;
 +compatible = st,stih416-b2020, st,stih416;
 +
 +soc {
 +miphy365x_phy: miphy365x@fe382000 {
 +st,pcie-tx-pol-inv;
 +st,sata-gen = 3;
 +};
 +};
 +};
 Shouldn't this new board being added in a separate patch?

I certainly can do that, but I don't think that it's necessary?

 diff --git a/arch/arm/boot/dts/stih416-b2020.dts 
 b/arch/arm/boot/dts/stih416-b2020.dts
 index 276f28d..172f222 100644
 --- a/arch/arm/boot/dts/stih416-b2020.dts
 +++ b/arch/arm/boot/dts/stih416-b2020.dts
 @@ -13,4 +13,10 @@
  model = STiH416 B2020;
  compatible = st,stih416, st,stih416-b2020;
 
 +soc {
 +miphy365x_phy: miphy365x@fe382000 {
 +st,pcie-tx-pol-inv;
 +st,sata-gen = 3;
 +};
 +};
   };
 ...

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

2014-04-29 Thread Lee Jones 
The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
devices. It has 2 ports which it can use for either; both SATA, both
PCIe or one of each in any configuration.

Cc: Srinivas Kandagatla 
Acked-by: Mark Rutland 
Acked-by: Alexandre Torgue 
Signed-off-by: Lee Jones 
---
 arch/arm/boot/dts/stih416-b2020-revE.dts | 22 ++
 arch/arm/boot/dts/stih416-b2020.dts  |  6 ++
 arch/arm/boot/dts/stih416.dtsi   | 14 ++
 3 files changed, 42 insertions(+)
 create mode 100644 arch/arm/boot/dts/stih416-b2020-revE.dts

diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts 
b/arch/arm/boot/dts/stih416-b2020-revE.dts
new file mode 100644
index 000..23fdaf7
--- /dev/null
+++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
@@ -0,0 +1,22 @@
+/*
+ * Copyright (C) 2014 STMicroelectronics Limited.
+ * Author: Lee Jones 
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * publishhed by the Free Software Foundation.
+ */
+/dts-v1/;
+#include "stih416.dtsi"
+#include "stih41x-b2020.dtsi"
+/ {
+model = "STiH416 B2020 REV-E";
+   compatible = "st,stih416-b2020", "st,stih416";
+
+   soc {
+   miphy365x_phy: miphy365x@fe382000 {
+   st,pcie-tx-pol-inv;
+   st,sata-gen = <3>;
+   };
+   };
+};
diff --git a/arch/arm/boot/dts/stih416-b2020.dts 
b/arch/arm/boot/dts/stih416-b2020.dts
index 276f28d..172f222 100644
--- a/arch/arm/boot/dts/stih416-b2020.dts
+++ b/arch/arm/boot/dts/stih416-b2020.dts
@@ -13,4 +13,10 @@
model = "STiH416 B2020";
compatible = "st,stih416", "st,stih416-b2020";
 
+   soc {
+   miphy365x_phy: miphy365x@fe382000 {
+   st,pcie-tx-pol-inv;
+   st,sata-gen = <3>;
+   };
+   };
 };
diff --git a/arch/arm/boot/dts/stih416.dtsi b/arch/arm/boot/dts/stih416.dtsi
index 78746d2..00b217a 100644
--- a/arch/arm/boot/dts/stih416.dtsi
+++ b/arch/arm/boot/dts/stih416.dtsi
@@ -9,6 +9,8 @@
 #include "stih41x.dtsi"
 #include "stih416-clock.dtsi"
 #include "stih416-pinctrl.dtsi"
+
+#include 
 #include 
 #include 
 / {
@@ -224,5 +226,17 @@
 
status = "disabled";
};
+
+   miphy365x_phy: miphy365x@fe382000 {
+   compatible  = "st,miphy365x-phy";
+   reg = <0xfe382000 0x100>,
+ <0xfe38a000 0x100>,
+ <0xfe394000 0x100>,
+ <0xfe804000 0x100>;
+   reg-names   = "sata0", "sata1", "pcie0", "pcie1";
+
+   #phy-cells  = <2>;
+   st,syscfg   = <_rear>;
+   };
};
 };
-- 
1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

2014-04-29 Thread Lee Jones 
The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
devices. It has 2 ports which it can use for either; both SATA, both
PCIe or one of each in any configuration.

Cc: Srinivas Kandagatla srinivas.kandaga...@st.com
Acked-by: Mark Rutland mark.rutl...@arm.com
Acked-by: Alexandre Torgue alexandre.tor...@st.com
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
 arch/arm/boot/dts/stih416-b2020-revE.dts | 22 ++
 arch/arm/boot/dts/stih416-b2020.dts  |  6 ++
 arch/arm/boot/dts/stih416.dtsi   | 14 ++
 3 files changed, 42 insertions(+)
 create mode 100644 arch/arm/boot/dts/stih416-b2020-revE.dts

diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts 
b/arch/arm/boot/dts/stih416-b2020-revE.dts
new file mode 100644
index 000..23fdaf7
--- /dev/null
+++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
@@ -0,0 +1,22 @@
+/*
+ * Copyright (C) 2014 STMicroelectronics Limited.
+ * Author: Lee Jones lee.jo...@linaro.org
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * publishhed by the Free Software Foundation.
+ */
+/dts-v1/;
+#include stih416.dtsi
+#include stih41x-b2020.dtsi
+/ {
+model = STiH416 B2020 REV-E;
+   compatible = st,stih416-b2020, st,stih416;
+
+   soc {
+   miphy365x_phy: miphy365x@fe382000 {
+   st,pcie-tx-pol-inv;
+   st,sata-gen = 3;
+   };
+   };
+};
diff --git a/arch/arm/boot/dts/stih416-b2020.dts 
b/arch/arm/boot/dts/stih416-b2020.dts
index 276f28d..172f222 100644
--- a/arch/arm/boot/dts/stih416-b2020.dts
+++ b/arch/arm/boot/dts/stih416-b2020.dts
@@ -13,4 +13,10 @@
model = STiH416 B2020;
compatible = st,stih416, st,stih416-b2020;
 
+   soc {
+   miphy365x_phy: miphy365x@fe382000 {
+   st,pcie-tx-pol-inv;
+   st,sata-gen = 3;
+   };
+   };
 };
diff --git a/arch/arm/boot/dts/stih416.dtsi b/arch/arm/boot/dts/stih416.dtsi
index 78746d2..00b217a 100644
--- a/arch/arm/boot/dts/stih416.dtsi
+++ b/arch/arm/boot/dts/stih416.dtsi
@@ -9,6 +9,8 @@
 #include stih41x.dtsi
 #include stih416-clock.dtsi
 #include stih416-pinctrl.dtsi
+
+#include dt-bindings/phy/phy-miphy365x.h
 #include dt-bindings/interrupt-controller/arm-gic.h
 #include dt-bindings/reset-controller/stih416-resets.h
 / {
@@ -224,5 +226,17 @@
 
status = disabled;
};
+
+   miphy365x_phy: miphy365x@fe382000 {
+   compatible  = st,miphy365x-phy;
+   reg = 0xfe382000 0x100,
+ 0xfe38a000 0x100,
+ 0xfe394000 0x100,
+ 0xfe804000 0x100;
+   reg-names   = sata0, sata1, pcie0, pcie1;
+
+   #phy-cells  = 2;
+   st,syscfg   = syscfg_rear;
+   };
};
 };
-- 
1.8.3.2

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

2014-03-12 Thread Lee Jones 
The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
devices. It has 2 ports which it can use for either; both SATA, both
PCIe or one of each in any configuration.

Cc: Srinivas Kandagatla 
Acked-by: Mark Rutland 
Acked-by: Alexandre Torgue 
Signed-off-by: Lee Jones 
---
 arch/arm/boot/dts/stih416-b2020-revE.dts |  6 +-
 arch/arm/boot/dts/stih416-b2020.dts  |  6 ++
 arch/arm/boot/dts/stih416.dtsi   | 14 ++
 3 files changed, 25 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts 
b/arch/arm/boot/dts/stih416-b2020-revE.dts
index a874570..047f14d 100644
--- a/arch/arm/boot/dts/stih416-b2020-revE.dts
+++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
@@ -32,6 +32,10 @@
ethernet1: ethernet@fef08000 {
snps,reset-gpio = < 7>;
};
-   };
 
+   miphy365x_phy: miphy365x@fe382000 {
+   st,pcie-tx-pol-inv;
+   st,sata-gen = <3>;
+   };
+   };
 };
diff --git a/arch/arm/boot/dts/stih416-b2020.dts 
b/arch/arm/boot/dts/stih416-b2020.dts
index 276f28d..172f222 100644
--- a/arch/arm/boot/dts/stih416-b2020.dts
+++ b/arch/arm/boot/dts/stih416-b2020.dts
@@ -13,4 +13,10 @@
model = "STiH416 B2020";
compatible = "st,stih416", "st,stih416-b2020";
 
+   soc {
+   miphy365x_phy: miphy365x@fe382000 {
+   st,pcie-tx-pol-inv;
+   st,sata-gen = <3>;
+   };
+   };
 };
diff --git a/arch/arm/boot/dts/stih416.dtsi b/arch/arm/boot/dts/stih416.dtsi
index 226d3a9..4f7d3ff 100644
--- a/arch/arm/boot/dts/stih416.dtsi
+++ b/arch/arm/boot/dts/stih416.dtsi
@@ -9,6 +9,8 @@
 #include "stih41x.dtsi"
 #include "stih416-clock.dtsi"
 #include "stih416-pinctrl.dtsi"
+
+#include 
 #include 
 #include 
 / {
@@ -191,5 +193,17 @@
clock-names = "stmmaceth";
clocks  = <_S_ICN_REG_0>;
};
+
+   miphy365x_phy: miphy365x@fe382000 {
+   compatible  = "st,miphy365x-phy";
+   reg = <0xfe382000 0x100>,
+ <0xfe38a000 0x100>,
+ <0xfe394000 0x100>,
+ <0xfe804000 0x100>;
+   reg-names   = "sata0", "sata1", "pcie0", "pcie1";
+
+   #phy-cells  = <2>;
+   st,syscfg   = <_rear>;
+   };
};
 };
-- 
1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

2014-03-12 Thread Lee Jones 
The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
devices. It has 2 ports which it can use for either; both SATA, both
PCIe or one of each in any configuration.

Cc: Srinivas Kandagatla srinivas.kandaga...@st.com
Acked-by: Mark Rutland mark.rutl...@arm.com
Acked-by: Alexandre Torgue alexandre.tor...@st.com
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
 arch/arm/boot/dts/stih416-b2020-revE.dts |  6 +-
 arch/arm/boot/dts/stih416-b2020.dts  |  6 ++
 arch/arm/boot/dts/stih416.dtsi   | 14 ++
 3 files changed, 25 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts 
b/arch/arm/boot/dts/stih416-b2020-revE.dts
index a874570..047f14d 100644
--- a/arch/arm/boot/dts/stih416-b2020-revE.dts
+++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
@@ -32,6 +32,10 @@
ethernet1: ethernet@fef08000 {
snps,reset-gpio = PIO0 7;
};
-   };
 
+   miphy365x_phy: miphy365x@fe382000 {
+   st,pcie-tx-pol-inv;
+   st,sata-gen = 3;
+   };
+   };
 };
diff --git a/arch/arm/boot/dts/stih416-b2020.dts 
b/arch/arm/boot/dts/stih416-b2020.dts
index 276f28d..172f222 100644
--- a/arch/arm/boot/dts/stih416-b2020.dts
+++ b/arch/arm/boot/dts/stih416-b2020.dts
@@ -13,4 +13,10 @@
model = STiH416 B2020;
compatible = st,stih416, st,stih416-b2020;
 
+   soc {
+   miphy365x_phy: miphy365x@fe382000 {
+   st,pcie-tx-pol-inv;
+   st,sata-gen = 3;
+   };
+   };
 };
diff --git a/arch/arm/boot/dts/stih416.dtsi b/arch/arm/boot/dts/stih416.dtsi
index 226d3a9..4f7d3ff 100644
--- a/arch/arm/boot/dts/stih416.dtsi
+++ b/arch/arm/boot/dts/stih416.dtsi
@@ -9,6 +9,8 @@
 #include stih41x.dtsi
 #include stih416-clock.dtsi
 #include stih416-pinctrl.dtsi
+
+#include dt-bindings/phy/phy-miphy365x.h
 #include dt-bindings/interrupt-controller/arm-gic.h
 #include dt-bindings/reset-controller/stih416-resets.h
 / {
@@ -191,5 +193,17 @@
clock-names = stmmaceth;
clocks  = CLK_S_ICN_REG_0;
};
+
+   miphy365x_phy: miphy365x@fe382000 {
+   compatible  = st,miphy365x-phy;
+   reg = 0xfe382000 0x100,
+ 0xfe38a000 0x100,
+ 0xfe394000 0x100,
+ 0xfe804000 0x100;
+   reg-names   = sata0, sata1, pcie0, pcie1;
+
+   #phy-cells  = 2;
+   st,syscfg   = syscfg_rear;
+   };
};
 };
-- 
1.8.3.2

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

2014-03-04 Thread Mark Rutland 
On Fri, Feb 14, 2014 at 11:23:55AM +, Lee Jones wrote:
> The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
> devices. It has 2 ports which it can use for either; both SATA, both
> PCIe or one of each in any configuration.
> 
> Cc: devicet...@vger.kernel.org
> Cc: Srinivas Kandagatla 
> Signed-off-by: Lee Jones 
> ---
>  arch/arm/boot/dts/stih416-b2020-revE.dts |  6 +-
>  arch/arm/boot/dts/stih416-b2020.dts  |  6 ++
>  arch/arm/boot/dts/stih416.dtsi   | 13 +
>  3 files changed, 24 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts 
> b/arch/arm/boot/dts/stih416-b2020-revE.dts
> index a874570..dbe67fa 100644
> --- a/arch/arm/boot/dts/stih416-b2020-revE.dts
> +++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
> @@ -32,6 +32,10 @@
>   ethernet1: ethernet@fef08000 {
>   snps,reset-gpio = < 7>;
>   };
> - };
>  
> + miphy365x_phy: miphy365x@0 {

This has registers at 0x0? Or is the unit-address wrong?

> + st,pcie_tx_pol_inv = <1>;

This is a boolean. The '= <1>' is not required and is confusing.

> + st,sata_gen = "gen3";

s/"gen3"/<3>/

Both these properties need s/_/-/ applied.

All these apply to the other dts too.

> + };
> + };
>  };
> diff --git a/arch/arm/boot/dts/stih416-b2020.dts 
> b/arch/arm/boot/dts/stih416-b2020.dts
> index 276f28d..fd9cbad 100644
> --- a/arch/arm/boot/dts/stih416-b2020.dts
> +++ b/arch/arm/boot/dts/stih416-b2020.dts
> @@ -13,4 +13,10 @@
>   model = "STiH416 B2020";
>   compatible = "st,stih416", "st,stih416-b2020";

This compatible list is the wrong way around. Left to right should go
from most specific to most general / oldest variant.

>  
> + soc {
> + miphy365x_phy: miphy365x@0 {

> + st,pcie_tx_pol_inv = <1>;
> + st,sata_gen = "gen3";
> + };
> + };
>  };
> diff --git a/arch/arm/boot/dts/stih416.dtsi b/arch/arm/boot/dts/stih416.dtsi
> index 85b8063..9fd8efb 100644
> --- a/arch/arm/boot/dts/stih416.dtsi
> +++ b/arch/arm/boot/dts/stih416.dtsi
> @@ -9,6 +9,8 @@
>  #include "stih41x.dtsi"
>  #include "stih416-clock.dtsi"
>  #include "stih416-pinctrl.dtsi"
> +
> +#include 
>  #include 
>  #include 
>  / {
> @@ -140,5 +142,16 @@
>   clocks  = <_S_ICN_REG_0>;
>   };
>  
> + miphy365x_phy: miphy365x@0 {

The unit-address should be fe382000 rather than 0 to match the first reg
entry.

Cheers,
Mark.

> + compatible  = "st,miphy365x-phy";
> + reg = <0xfe382000 0x100>,
> +   <0xfe38a000 0x100>,
> +   <0xfe394000 0x100>,
> +   <0xfe804000 0x100>;
> + reg-names   = "sata0", "sata1", "pcie0", "pcie1";
> +
> + #phy-cells  = <2>;
> + st,syscfg   = <_rear>;
> + };
>   };
>  };
> -- 
> 1.8.3.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

2014-03-04 Thread Mark Rutland 
On Fri, Feb 14, 2014 at 11:23:55AM +, Lee Jones wrote:
 The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
 devices. It has 2 ports which it can use for either; both SATA, both
 PCIe or one of each in any configuration.
 
 Cc: devicet...@vger.kernel.org
 Cc: Srinivas Kandagatla srinivas.kandaga...@st.com
 Signed-off-by: Lee Jones lee.jo...@linaro.org
 ---
  arch/arm/boot/dts/stih416-b2020-revE.dts |  6 +-
  arch/arm/boot/dts/stih416-b2020.dts  |  6 ++
  arch/arm/boot/dts/stih416.dtsi   | 13 +
  3 files changed, 24 insertions(+), 1 deletion(-)
 
 diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts 
 b/arch/arm/boot/dts/stih416-b2020-revE.dts
 index a874570..dbe67fa 100644
 --- a/arch/arm/boot/dts/stih416-b2020-revE.dts
 +++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
 @@ -32,6 +32,10 @@
   ethernet1: ethernet@fef08000 {
   snps,reset-gpio = PIO0 7;
   };
 - };
  
 + miphy365x_phy: miphy365x@0 {

This has registers at 0x0? Or is the unit-address wrong?

 + st,pcie_tx_pol_inv = 1;

This is a boolean. The '= 1' is not required and is confusing.

 + st,sata_gen = gen3;

s/gen3/3/

Both these properties need s/_/-/ applied.

All these apply to the other dts too.

 + };
 + };
  };
 diff --git a/arch/arm/boot/dts/stih416-b2020.dts 
 b/arch/arm/boot/dts/stih416-b2020.dts
 index 276f28d..fd9cbad 100644
 --- a/arch/arm/boot/dts/stih416-b2020.dts
 +++ b/arch/arm/boot/dts/stih416-b2020.dts
 @@ -13,4 +13,10 @@
   model = STiH416 B2020;
   compatible = st,stih416, st,stih416-b2020;

This compatible list is the wrong way around. Left to right should go
from most specific to most general / oldest variant.

  
 + soc {
 + miphy365x_phy: miphy365x@0 {

 + st,pcie_tx_pol_inv = 1;
 + st,sata_gen = gen3;
 + };
 + };
  };
 diff --git a/arch/arm/boot/dts/stih416.dtsi b/arch/arm/boot/dts/stih416.dtsi
 index 85b8063..9fd8efb 100644
 --- a/arch/arm/boot/dts/stih416.dtsi
 +++ b/arch/arm/boot/dts/stih416.dtsi
 @@ -9,6 +9,8 @@
  #include stih41x.dtsi
  #include stih416-clock.dtsi
  #include stih416-pinctrl.dtsi
 +
 +#include dt-bindings/phy/phy-miphy365x.h
  #include dt-bindings/interrupt-controller/arm-gic.h
  #include dt-bindings/reset-controller/stih416-resets.h
  / {
 @@ -140,5 +142,16 @@
   clocks  = CLK_S_ICN_REG_0;
   };
  
 + miphy365x_phy: miphy365x@0 {

The unit-address should be fe382000 rather than 0 to match the first reg
entry.

Cheers,
Mark.

 + compatible  = st,miphy365x-phy;
 + reg = 0xfe382000 0x100,
 +   0xfe38a000 0x100,
 +   0xfe394000 0x100,
 +   0xfe804000 0x100;
 + reg-names   = sata0, sata1, pcie0, pcie1;
 +
 + #phy-cells  = 2;
 + st,syscfg   = syscfg_rear;
 + };
   };
  };
 -- 
 1.8.3.2
 
 --
 To unsubscribe from this list: send the line unsubscribe devicetree in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
 
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

2014-03-01 Thread Kishon Vijay Abraham I 

Hi,

On Friday 14 February 2014 04:53 PM, Lee Jones wrote:

The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
devices. It has 2 ports which it can use for either; both SATA, both
PCIe or one of each in any configuration.

Cc: devicet...@vger.kernel.org
Cc: Srinivas Kandagatla 
Signed-off-by: Lee Jones 


since this uses 'dt-bindings/phy/phy-miphy365x.h' which is used in phy 
driver as well, I need ACK from dt maintainers so that I can queue both 
the driver and dt patches myself.


Thanks
Kishon

---
  arch/arm/boot/dts/stih416-b2020-revE.dts |  6 +-
  arch/arm/boot/dts/stih416-b2020.dts  |  6 ++
  arch/arm/boot/dts/stih416.dtsi   | 13 +
  3 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts 
b/arch/arm/boot/dts/stih416-b2020-revE.dts
index a874570..dbe67fa 100644
--- a/arch/arm/boot/dts/stih416-b2020-revE.dts
+++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
@@ -32,6 +32,10 @@
ethernet1: ethernet@fef08000 {
snps,reset-gpio = < 7>;
};
-   };

+   miphy365x_phy: miphy365x@0 {
+   st,pcie_tx_pol_inv = <1>;
+   st,sata_gen = "gen3";
+   };
+   };
  };
diff --git a/arch/arm/boot/dts/stih416-b2020.dts 
b/arch/arm/boot/dts/stih416-b2020.dts
index 276f28d..fd9cbad 100644
--- a/arch/arm/boot/dts/stih416-b2020.dts
+++ b/arch/arm/boot/dts/stih416-b2020.dts
@@ -13,4 +13,10 @@
model = "STiH416 B2020";
compatible = "st,stih416", "st,stih416-b2020";

+   soc {
+   miphy365x_phy: miphy365x@0 {
+   st,pcie_tx_pol_inv = <1>;
+   st,sata_gen = "gen3";
+   };
+   };
  };
diff --git a/arch/arm/boot/dts/stih416.dtsi b/arch/arm/boot/dts/stih416.dtsi
index 85b8063..9fd8efb 100644
--- a/arch/arm/boot/dts/stih416.dtsi
+++ b/arch/arm/boot/dts/stih416.dtsi
@@ -9,6 +9,8 @@
  #include "stih41x.dtsi"
  #include "stih416-clock.dtsi"
  #include "stih416-pinctrl.dtsi"
+
+#include 
  #include 
  #include 
  / {
@@ -140,5 +142,16 @@
clocks  = <_S_ICN_REG_0>;
};

+   miphy365x_phy: miphy365x@0 {
+   compatible  = "st,miphy365x-phy";
+   reg = <0xfe382000 0x100>,
+ <0xfe38a000 0x100>,
+ <0xfe394000 0x100>,
+ <0xfe804000 0x100>;
+   reg-names   = "sata0", "sata1", "pcie0", "pcie1";
+
+   #phy-cells  = <2>;
+   st,syscfg   = <_rear>;
+   };
};
  };



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

2014-03-01 Thread Kishon Vijay Abraham I 

Hi,

On Friday 14 February 2014 04:53 PM, Lee Jones wrote:

The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
devices. It has 2 ports which it can use for either; both SATA, both
PCIe or one of each in any configuration.

Cc: devicet...@vger.kernel.org
Cc: Srinivas Kandagatla srinivas.kandaga...@st.com
Signed-off-by: Lee Jones lee.jo...@linaro.org


since this uses 'dt-bindings/phy/phy-miphy365x.h' which is used in phy 
driver as well, I need ACK from dt maintainers so that I can queue both 
the driver and dt patches myself.


Thanks
Kishon

---
  arch/arm/boot/dts/stih416-b2020-revE.dts |  6 +-
  arch/arm/boot/dts/stih416-b2020.dts  |  6 ++
  arch/arm/boot/dts/stih416.dtsi   | 13 +
  3 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts 
b/arch/arm/boot/dts/stih416-b2020-revE.dts
index a874570..dbe67fa 100644
--- a/arch/arm/boot/dts/stih416-b2020-revE.dts
+++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
@@ -32,6 +32,10 @@
ethernet1: ethernet@fef08000 {
snps,reset-gpio = PIO0 7;
};
-   };

+   miphy365x_phy: miphy365x@0 {
+   st,pcie_tx_pol_inv = 1;
+   st,sata_gen = gen3;
+   };
+   };
  };
diff --git a/arch/arm/boot/dts/stih416-b2020.dts 
b/arch/arm/boot/dts/stih416-b2020.dts
index 276f28d..fd9cbad 100644
--- a/arch/arm/boot/dts/stih416-b2020.dts
+++ b/arch/arm/boot/dts/stih416-b2020.dts
@@ -13,4 +13,10 @@
model = STiH416 B2020;
compatible = st,stih416, st,stih416-b2020;

+   soc {
+   miphy365x_phy: miphy365x@0 {
+   st,pcie_tx_pol_inv = 1;
+   st,sata_gen = gen3;
+   };
+   };
  };
diff --git a/arch/arm/boot/dts/stih416.dtsi b/arch/arm/boot/dts/stih416.dtsi
index 85b8063..9fd8efb 100644
--- a/arch/arm/boot/dts/stih416.dtsi
+++ b/arch/arm/boot/dts/stih416.dtsi
@@ -9,6 +9,8 @@
  #include stih41x.dtsi
  #include stih416-clock.dtsi
  #include stih416-pinctrl.dtsi
+
+#include dt-bindings/phy/phy-miphy365x.h
  #include dt-bindings/interrupt-controller/arm-gic.h
  #include dt-bindings/reset-controller/stih416-resets.h
  / {
@@ -140,5 +142,16 @@
clocks  = CLK_S_ICN_REG_0;
};

+   miphy365x_phy: miphy365x@0 {
+   compatible  = st,miphy365x-phy;
+   reg = 0xfe382000 0x100,
+ 0xfe38a000 0x100,
+ 0xfe394000 0x100,
+ 0xfe804000 0x100;
+   reg-names   = sata0, sata1, pcie0, pcie1;
+
+   #phy-cells  = 2;
+   st,syscfg   = syscfg_rear;
+   };
};
  };



--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

2014-02-14 Thread Lee Jones 
The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
devices. It has 2 ports which it can use for either; both SATA, both
PCIe or one of each in any configuration.

Cc: devicet...@vger.kernel.org
Cc: Srinivas Kandagatla 
Signed-off-by: Lee Jones 
---
 arch/arm/boot/dts/stih416-b2020-revE.dts |  6 +-
 arch/arm/boot/dts/stih416-b2020.dts  |  6 ++
 arch/arm/boot/dts/stih416.dtsi   | 13 +
 3 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts 
b/arch/arm/boot/dts/stih416-b2020-revE.dts
index a874570..dbe67fa 100644
--- a/arch/arm/boot/dts/stih416-b2020-revE.dts
+++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
@@ -32,6 +32,10 @@
ethernet1: ethernet@fef08000 {
snps,reset-gpio = < 7>;
};
-   };
 
+   miphy365x_phy: miphy365x@0 {
+   st,pcie_tx_pol_inv = <1>;
+   st,sata_gen = "gen3";
+   };
+   };
 };
diff --git a/arch/arm/boot/dts/stih416-b2020.dts 
b/arch/arm/boot/dts/stih416-b2020.dts
index 276f28d..fd9cbad 100644
--- a/arch/arm/boot/dts/stih416-b2020.dts
+++ b/arch/arm/boot/dts/stih416-b2020.dts
@@ -13,4 +13,10 @@
model = "STiH416 B2020";
compatible = "st,stih416", "st,stih416-b2020";
 
+   soc {
+   miphy365x_phy: miphy365x@0 {
+   st,pcie_tx_pol_inv = <1>;
+   st,sata_gen = "gen3";
+   };
+   };
 };
diff --git a/arch/arm/boot/dts/stih416.dtsi b/arch/arm/boot/dts/stih416.dtsi
index 85b8063..9fd8efb 100644
--- a/arch/arm/boot/dts/stih416.dtsi
+++ b/arch/arm/boot/dts/stih416.dtsi
@@ -9,6 +9,8 @@
 #include "stih41x.dtsi"
 #include "stih416-clock.dtsi"
 #include "stih416-pinctrl.dtsi"
+
+#include 
 #include 
 #include 
 / {
@@ -140,5 +142,16 @@
clocks  = <_S_ICN_REG_0>;
};
 
+   miphy365x_phy: miphy365x@0 {
+   compatible  = "st,miphy365x-phy";
+   reg = <0xfe382000 0x100>,
+ <0xfe38a000 0x100>,
+ <0xfe394000 0x100>,
+ <0xfe804000 0x100>;
+   reg-names   = "sata0", "sata1", "pcie0", "pcie1";
+
+   #phy-cells  = <2>;
+   st,syscfg   = <_rear>;
+   };
};
 };
-- 
1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

2014-02-14 Thread Lee Jones 
The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
devices. It has 2 ports which it can use for either; both SATA, both
PCIe or one of each in any configuration.

Cc: devicet...@vger.kernel.org
Cc: Srinivas Kandagatla srinivas.kandaga...@st.com
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
 arch/arm/boot/dts/stih416-b2020-revE.dts |  6 +-
 arch/arm/boot/dts/stih416-b2020.dts  |  6 ++
 arch/arm/boot/dts/stih416.dtsi   | 13 +
 3 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts 
b/arch/arm/boot/dts/stih416-b2020-revE.dts
index a874570..dbe67fa 100644
--- a/arch/arm/boot/dts/stih416-b2020-revE.dts
+++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
@@ -32,6 +32,10 @@
ethernet1: ethernet@fef08000 {
snps,reset-gpio = PIO0 7;
};
-   };
 
+   miphy365x_phy: miphy365x@0 {
+   st,pcie_tx_pol_inv = 1;
+   st,sata_gen = gen3;
+   };
+   };
 };
diff --git a/arch/arm/boot/dts/stih416-b2020.dts 
b/arch/arm/boot/dts/stih416-b2020.dts
index 276f28d..fd9cbad 100644
--- a/arch/arm/boot/dts/stih416-b2020.dts
+++ b/arch/arm/boot/dts/stih416-b2020.dts
@@ -13,4 +13,10 @@
model = STiH416 B2020;
compatible = st,stih416, st,stih416-b2020;
 
+   soc {
+   miphy365x_phy: miphy365x@0 {
+   st,pcie_tx_pol_inv = 1;
+   st,sata_gen = gen3;
+   };
+   };
 };
diff --git a/arch/arm/boot/dts/stih416.dtsi b/arch/arm/boot/dts/stih416.dtsi
index 85b8063..9fd8efb 100644
--- a/arch/arm/boot/dts/stih416.dtsi
+++ b/arch/arm/boot/dts/stih416.dtsi
@@ -9,6 +9,8 @@
 #include stih41x.dtsi
 #include stih416-clock.dtsi
 #include stih416-pinctrl.dtsi
+
+#include dt-bindings/phy/phy-miphy365x.h
 #include dt-bindings/interrupt-controller/arm-gic.h
 #include dt-bindings/reset-controller/stih416-resets.h
 / {
@@ -140,5 +142,16 @@
clocks  = CLK_S_ICN_REG_0;
};
 
+   miphy365x_phy: miphy365x@0 {
+   compatible  = st,miphy365x-phy;
+   reg = 0xfe382000 0x100,
+ 0xfe38a000 0x100,
+ 0xfe394000 0x100,
+ 0xfe804000 0x100;
+   reg-names   = sata0, sata1, pcie0, pcie1;
+
+   #phy-cells  = 2;
+   st,syscfg   = syscfg_rear;
+   };
};
 };
-- 
1.8.3.2

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

2014-02-12 Thread Lee Jones 
The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
devices. It has 2 ports which it can use for either; both SATA, both
PCIe or one of each in any configuration.

Cc: devicet...@vger.kernel.org
Cc: Srinivas Kandagatla 
Signed-off-by: Lee Jones 
---
 arch/arm/boot/dts/stih416-b2020-revE.dts |  6 +-
 arch/arm/boot/dts/stih416-b2020.dts  |  6 ++
 arch/arm/boot/dts/stih416.dtsi   | 13 +
 3 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts 
b/arch/arm/boot/dts/stih416-b2020-revE.dts
index a874570..dbe67fa 100644
--- a/arch/arm/boot/dts/stih416-b2020-revE.dts
+++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
@@ -32,6 +32,10 @@
ethernet1: ethernet@fef08000 {
snps,reset-gpio = < 7>;
};
-   };
 
+   miphy365x_phy: miphy365x@0 {
+   st,pcie_tx_pol_inv = <1>;
+   st,sata_gen = "gen3";
+   };
+   };
 };
diff --git a/arch/arm/boot/dts/stih416-b2020.dts 
b/arch/arm/boot/dts/stih416-b2020.dts
index 276f28d..fd9cbad 100644
--- a/arch/arm/boot/dts/stih416-b2020.dts
+++ b/arch/arm/boot/dts/stih416-b2020.dts
@@ -13,4 +13,10 @@
model = "STiH416 B2020";
compatible = "st,stih416", "st,stih416-b2020";
 
+   soc {
+   miphy365x_phy: miphy365x@0 {
+   st,pcie_tx_pol_inv = <1>;
+   st,sata_gen = "gen3";
+   };
+   };
 };
diff --git a/arch/arm/boot/dts/stih416.dtsi b/arch/arm/boot/dts/stih416.dtsi
index 85b8063..9fd8efb 100644
--- a/arch/arm/boot/dts/stih416.dtsi
+++ b/arch/arm/boot/dts/stih416.dtsi
@@ -9,6 +9,8 @@
 #include "stih41x.dtsi"
 #include "stih416-clock.dtsi"
 #include "stih416-pinctrl.dtsi"
+
+#include 
 #include 
 #include 
 / {
@@ -140,5 +142,16 @@
clocks  = <_S_ICN_REG_0>;
};
 
+   miphy365x_phy: miphy365x@0 {
+   compatible  = "st,miphy365x-phy";
+   reg = <0xfe382000 0x100>,
+ <0xfe38a000 0x100>,
+ <0xfe394000 0x100>,
+ <0xfe804000 0x100>;
+   reg-names   = "sata0", "sata1", "pcie0", "pcie1";
+
+   #phy-cells  = <2>;
+   st,syscfg   = <_rear>;
+   };
};
 };
-- 
1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 3/4] ARM: DT: STi: Add DT node for MiPHY365x

2014-02-12 Thread Lee Jones 
The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
devices. It has 2 ports which it can use for either; both SATA, both
PCIe or one of each in any configuration.

Cc: devicet...@vger.kernel.org
Cc: Srinivas Kandagatla srinivas.kandaga...@st.com
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
 arch/arm/boot/dts/stih416-b2020-revE.dts |  6 +-
 arch/arm/boot/dts/stih416-b2020.dts  |  6 ++
 arch/arm/boot/dts/stih416.dtsi   | 13 +
 3 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts 
b/arch/arm/boot/dts/stih416-b2020-revE.dts
index a874570..dbe67fa 100644
--- a/arch/arm/boot/dts/stih416-b2020-revE.dts
+++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
@@ -32,6 +32,10 @@
ethernet1: ethernet@fef08000 {
snps,reset-gpio = PIO0 7;
};
-   };
 
+   miphy365x_phy: miphy365x@0 {
+   st,pcie_tx_pol_inv = 1;
+   st,sata_gen = gen3;
+   };
+   };
 };
diff --git a/arch/arm/boot/dts/stih416-b2020.dts 
b/arch/arm/boot/dts/stih416-b2020.dts
index 276f28d..fd9cbad 100644
--- a/arch/arm/boot/dts/stih416-b2020.dts
+++ b/arch/arm/boot/dts/stih416-b2020.dts
@@ -13,4 +13,10 @@
model = STiH416 B2020;
compatible = st,stih416, st,stih416-b2020;
 
+   soc {
+   miphy365x_phy: miphy365x@0 {
+   st,pcie_tx_pol_inv = 1;
+   st,sata_gen = gen3;
+   };
+   };
 };
diff --git a/arch/arm/boot/dts/stih416.dtsi b/arch/arm/boot/dts/stih416.dtsi
index 85b8063..9fd8efb 100644
--- a/arch/arm/boot/dts/stih416.dtsi
+++ b/arch/arm/boot/dts/stih416.dtsi
@@ -9,6 +9,8 @@
 #include stih41x.dtsi
 #include stih416-clock.dtsi
 #include stih416-pinctrl.dtsi
+
+#include dt-bindings/phy/phy-miphy365x.h
 #include dt-bindings/interrupt-controller/arm-gic.h
 #include dt-bindings/reset-controller/stih416-resets.h
 / {
@@ -140,5 +142,16 @@
clocks  = CLK_S_ICN_REG_0;
};
 
+   miphy365x_phy: miphy365x@0 {
+   compatible  = st,miphy365x-phy;
+   reg = 0xfe382000 0x100,
+ 0xfe38a000 0x100,
+ 0xfe394000 0x100,
+ 0xfe804000 0x100;
+   reg-names   = sata0, sata1, pcie0, pcie1;
+
+   #phy-cells  = 2;
+   st,syscfg   = syscfg_rear;
+   };
};
 };
-- 
1.8.3.2

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/