Re: [PATCH v2] extcon: axp288: Add a depends on ACPI to the Kconfig entry

2019-04-11 Thread Chanwoo Choi 
Dear all,
 
+ sta...@vger.kernel.org 
 
It should be posted to sta...@vger.kernel.org
in order to merge it to stable tree.
 
Regards,
Chanwoo Choi


On 19. 4. 12. 오전 8:30, Chanwoo Choi wrote:
> On 19. 4. 4. 오후 11:17, Yue Haibing wrote:
>> From: YueHaibing 
>>
>> As Hans de Goede pointed, using this driver without ACPI
>> makes little sense, so add ACPI dependency to Kconfig entry
>> to fix a build error while CONFIG_ACPI is not set.
>>
>> drivers/extcon/extcon-axp288.c: In function 'axp288_extcon_probe':
>> drivers/extcon/extcon-axp288.c:363:20: error: dereferencing pointer to 
>> incomplete type
>> put_device(&adev->dev);
>>
>> Fixes: 0cf064db948a ("extcon: axp288: Convert to use 
>> acpi_dev_get_first_match_dev()")
>> Reported-by: Hulk Robot 
>> Suggested-by: Hans de Goede 
>> Signed-off-by: YueHaibing 
>> ---
>> v2: rework patch
>> ---
>>  drivers/extcon/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
>> index 1ed4b45..de06faf 100644
>> --- a/drivers/extcon/Kconfig
>> +++ b/drivers/extcon/Kconfig
>> @@ -30,7 +30,7 @@ config EXTCON_ARIZONA
>>  
>>  config EXTCON_AXP288
>>  tristate "X-Power AXP288 EXTCON support"
>> -depends on MFD_AXP20X && USB_SUPPORT && X86
>> +depends on MFD_AXP20X && USB_SUPPORT && X86 && ACPI
>>  select USB_ROLE_SWITCH
>>  help
>>Say Y here to enable support for USB peripheral detection
>>
> 
> Applied it. Thanks.
> 


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

Re: [PATCH v2] extcon: axp288: Add a depends on ACPI to the Kconfig entry

2019-04-11 Thread Chanwoo Choi 
On 19. 4. 4. 오후 11:17, Yue Haibing wrote:
> From: YueHaibing 
> 
> As Hans de Goede pointed, using this driver without ACPI
> makes little sense, so add ACPI dependency to Kconfig entry
> to fix a build error while CONFIG_ACPI is not set.
> 
> drivers/extcon/extcon-axp288.c: In function 'axp288_extcon_probe':
> drivers/extcon/extcon-axp288.c:363:20: error: dereferencing pointer to 
> incomplete type
> put_device(&adev->dev);
> 
> Fixes: 0cf064db948a ("extcon: axp288: Convert to use 
> acpi_dev_get_first_match_dev()")
> Reported-by: Hulk Robot 
> Suggested-by: Hans de Goede 
> Signed-off-by: YueHaibing 
> ---
> v2: rework patch
> ---
>  drivers/extcon/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index 1ed4b45..de06faf 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -30,7 +30,7 @@ config EXTCON_ARIZONA
>  
>  config EXTCON_AXP288
>   tristate "X-Power AXP288 EXTCON support"
> - depends on MFD_AXP20X && USB_SUPPORT && X86
> + depends on MFD_AXP20X && USB_SUPPORT && X86 && ACPI
>   select USB_ROLE_SWITCH
>   help
> Say Y here to enable support for USB peripheral detection
> 

Applied it. Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

Re: [PATCH v2] extcon: axp288: Add a depends on ACPI to the Kconfig entry

2019-04-04 Thread Mukesh Ojha 



On 4/4/2019 7:47 PM, Yue Haibing wrote:

From: YueHaibing 

As Hans de Goede pointed, using this driver without ACPI
makes little sense, so add ACPI dependency to Kconfig entry
to fix a build error while CONFIG_ACPI is not set.

drivers/extcon/extcon-axp288.c: In function 'axp288_extcon_probe':
drivers/extcon/extcon-axp288.c:363:20: error: dereferencing pointer to 
incomplete type
 put_device(&adev->dev);

Fixes: 0cf064db948a ("extcon: axp288: Convert to use 
acpi_dev_get_first_match_dev()")
Reported-by: Hulk Robot 
Suggested-by: Hans de Goede 
Signed-off-by: YueHaibing 


This looks good too.
Reviewed-by: Mukesh Ojha 

Cheers,
-Mukesh


---
v2: rework patch
---
  drivers/extcon/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
index 1ed4b45..de06faf 100644
--- a/drivers/extcon/Kconfig
+++ b/drivers/extcon/Kconfig
@@ -30,7 +30,7 @@ config EXTCON_ARIZONA
  
  config EXTCON_AXP288

tristate "X-Power AXP288 EXTCON support"
-   depends on MFD_AXP20X && USB_SUPPORT && X86
+   depends on MFD_AXP20X && USB_SUPPORT && X86 && ACPI
select USB_ROLE_SWITCH
help
  Say Y here to enable support for USB peripheral detection

Re: [PATCH v2] extcon: axp288: Add a depends on ACPI to the Kconfig entry

2019-04-04 Thread Hans de Goede 

Hi,

On 04-04-19 16:17, Yue Haibing wrote:

From: YueHaibing 

As Hans de Goede pointed, using this driver without ACPI
makes little sense, so add ACPI dependency to Kconfig entry
to fix a build error while CONFIG_ACPI is not set.

drivers/extcon/extcon-axp288.c: In function 'axp288_extcon_probe':
drivers/extcon/extcon-axp288.c:363:20: error: dereferencing pointer to 
incomplete type
 put_device(&adev->dev);

Fixes: 0cf064db948a ("extcon: axp288: Convert to use 
acpi_dev_get_first_match_dev()")
Reported-by: Hulk Robot 
Suggested-by: Hans de Goede 
Signed-off-by: YueHaibing 


Patch looks to me, thanks:

Reviewed-by: Hans de Goede 

Regards,

Hans



---
v2: rework patch
---
  drivers/extcon/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
index 1ed4b45..de06faf 100644
--- a/drivers/extcon/Kconfig
+++ b/drivers/extcon/Kconfig
@@ -30,7 +30,7 @@ config EXTCON_ARIZONA
  
  config EXTCON_AXP288

tristate "X-Power AXP288 EXTCON support"
-   depends on MFD_AXP20X && USB_SUPPORT && X86
+   depends on MFD_AXP20X && USB_SUPPORT && X86 && ACPI
select USB_ROLE_SWITCH
help
  Say Y here to enable support for USB peripheral detection

[PATCH v2] extcon: axp288: Add a depends on ACPI to the Kconfig entry

2019-04-04 Thread Yue Haibing 
From: YueHaibing 

As Hans de Goede pointed, using this driver without ACPI
makes little sense, so add ACPI dependency to Kconfig entry
to fix a build error while CONFIG_ACPI is not set.

drivers/extcon/extcon-axp288.c: In function 'axp288_extcon_probe':
drivers/extcon/extcon-axp288.c:363:20: error: dereferencing pointer to 
incomplete type
put_device(&adev->dev);

Fixes: 0cf064db948a ("extcon: axp288: Convert to use 
acpi_dev_get_first_match_dev()")
Reported-by: Hulk Robot 
Suggested-by: Hans de Goede 
Signed-off-by: YueHaibing 
---
v2: rework patch
---
 drivers/extcon/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
index 1ed4b45..de06faf 100644
--- a/drivers/extcon/Kconfig
+++ b/drivers/extcon/Kconfig
@@ -30,7 +30,7 @@ config EXTCON_ARIZONA
 
 config EXTCON_AXP288
tristate "X-Power AXP288 EXTCON support"
-   depends on MFD_AXP20X && USB_SUPPORT && X86
+   depends on MFD_AXP20X && USB_SUPPORT && X86 && ACPI
select USB_ROLE_SWITCH
help
  Say Y here to enable support for USB peripheral detection
-- 
2.7.4