Re: [PATCH v2 1/1] stmmac: fix oops on rmmod after assigning ip addr
From: Bryan O'Donoghue Date: Thu, 16 Apr 2015 17:20:50 +0100 > I'll spin again against : > https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/ Currently active tree is 'net', not 'net-next' -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 1/1] stmmac: fix oops on rmmod after assigning ip addr
On 16/04/15 17:07, David Miller wrote: This patch does not apply to the current tree, please respin. /facepalm Did this against : https://github.com/torvalds/linux.git I'll spin again against : https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 1/1] stmmac: fix oops on rmmod after assigning ip addr
From: Bryan O'Donoghue Date: Wed, 15 Apr 2015 02:07:46 +0100 > An oops exists in the flow of stmmac_release(). > phy_ethtool_get_wol() depends on phydev->drv. > phydev->drv will be null after stmmac_mdio_unreg() completes. > > Steps to reproduce on Quark X1000: > > 1. ifconfig eth0 192.168.0.1 > 2. rmmod stmmac_pci > > To fix this stmmac_mdio_unreg() should be run after unregister_netdev(). > > Signed-off-by: Bryan O'Donoghue > Reported-by: Dan O'Donovan This patch does not apply to the current tree, please respin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 1/1] stmmac: fix oops on rmmod after assigning ip addr
From: Bryan O'Donoghue pure.lo...@nexus-software.ie Date: Wed, 15 Apr 2015 02:07:46 +0100 An oops exists in the flow of stmmac_release(). phy_ethtool_get_wol() depends on phydev-drv. phydev-drv will be null after stmmac_mdio_unreg() completes. Steps to reproduce on Quark X1000: 1. ifconfig eth0 192.168.0.1 2. rmmod stmmac_pci To fix this stmmac_mdio_unreg() should be run after unregister_netdev(). Signed-off-by: Bryan O'Donoghue pure.lo...@nexus-software.ie Reported-by: Dan O'Donovan dan.odono...@emutex.com This patch does not apply to the current tree, please respin. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 1/1] stmmac: fix oops on rmmod after assigning ip addr
On 16/04/15 17:07, David Miller wrote: This patch does not apply to the current tree, please respin. /facepalm Did this against : https://github.com/torvalds/linux.git I'll spin again against : https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 1/1] stmmac: fix oops on rmmod after assigning ip addr
From: Bryan O'Donoghue pure.lo...@nexus-software.ie Date: Thu, 16 Apr 2015 17:20:50 +0100 I'll spin again against : https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/ Currently active tree is 'net', not 'net-next' -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 1/1] stmmac: fix oops on rmmod after assigning ip addr
An oops exists in the flow of stmmac_release(). phy_ethtool_get_wol() depends on phydev->drv. phydev->drv will be null after stmmac_mdio_unreg() completes. Steps to reproduce on Quark X1000: 1. ifconfig eth0 192.168.0.1 2. rmmod stmmac_pci To fix this stmmac_mdio_unreg() should be run after unregister_netdev(). Signed-off-by: Bryan O'Donoghue Reported-by: Dan O'Donovan --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index a0ea84f..3ab3e4a8 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -2958,14 +2958,14 @@ int stmmac_dvr_remove(struct net_device *ndev) priv->hw->dma->stop_tx(priv->ioaddr); stmmac_set_mac(priv->ioaddr, false); - if (priv->pcs != STMMAC_PCS_RGMII && priv->pcs != STMMAC_PCS_TBI && - priv->pcs != STMMAC_PCS_RTBI) - stmmac_mdio_unregister(ndev); netif_carrier_off(ndev); unregister_netdev(ndev); if (priv->stmmac_rst) reset_control_assert(priv->stmmac_rst); clk_disable_unprepare(priv->stmmac_clk); + if (priv->pcs != STMMAC_PCS_RGMII && priv->pcs != STMMAC_PCS_TBI && + priv->pcs != STMMAC_PCS_RTBI) + stmmac_mdio_unregister(ndev); free_netdev(ndev); return 0; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 1/1] stmmac: fix oops on rmmod after assigning ip addr
An oops exists in the flow of stmmac_release(). phy_ethtool_get_wol() depends on phydev-drv. phydev-drv will be null after stmmac_mdio_unreg() completes. Steps to reproduce on Quark X1000: 1. ifconfig eth0 192.168.0.1 2. rmmod stmmac_pci To fix this stmmac_mdio_unreg() should be run after unregister_netdev(). Signed-off-by: Bryan O'Donoghue pure.lo...@nexus-software.ie Reported-by: Dan O'Donovan dan.odono...@emutex.com --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index a0ea84f..3ab3e4a8 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -2958,14 +2958,14 @@ int stmmac_dvr_remove(struct net_device *ndev) priv-hw-dma-stop_tx(priv-ioaddr); stmmac_set_mac(priv-ioaddr, false); - if (priv-pcs != STMMAC_PCS_RGMII priv-pcs != STMMAC_PCS_TBI - priv-pcs != STMMAC_PCS_RTBI) - stmmac_mdio_unregister(ndev); netif_carrier_off(ndev); unregister_netdev(ndev); if (priv-stmmac_rst) reset_control_assert(priv-stmmac_rst); clk_disable_unprepare(priv-stmmac_clk); + if (priv-pcs != STMMAC_PCS_RGMII priv-pcs != STMMAC_PCS_TBI + priv-pcs != STMMAC_PCS_RTBI) + stmmac_mdio_unregister(ndev); free_netdev(ndev); return 0; -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
