Re: [PATCH v7 12/13] selftests/resctrl: Disable MBA and MBM tests for AMD
Fenghua/Andre, On 5/10/19 2:29 PM, Yu, Fenghua wrote: > [CAUTION: External Email] > >> On Friday, May 10, 2019 10:40 AM >> Andre Przywara [mailto:andre.przyw...@arm.com] wrote: >> To: Yu, Fenghua >> Cc: Thomas Gleixner ; Ingo Molnar >> ; Borislav Petkov ; H Peter Anvin >> ; Luck, Tony ; Chatre, Reinette >> ; Shankar, Ravi V ; >> Shen, Xiaochen ; Pathan, Arshiya Hayatkhan >> ; Prakhya, Sai Praneeth >> ; Babu Moger ; >> linux-kernel ; James Morse >> >> Subject: Re: [PATCH v7 12/13] selftests/resctrl: Disable MBA and MBM tests >> for AMD >> >> On Sat, 9 Feb 2019 18:50:41 -0800 >> Fenghua Yu wrote: >> >> Hi, >> >>> From: Babu Moger >>> >>> For now, disable MBA and MBM tests for AMD. Deciding test pass/fail is >>> not clear right now. We can enable when we have some clarity. >> >> I don't think this is the right way. The availability of features should be >> queryable, for instance by looking into /sys/fs/resctrl/info. Checking for a >> certain vendor to skip tests just sounds wrong to me, and is definitely not >> scalable or future proof. >> >> We should really check the availability of a feature, then skip the whole >> subsystem test in resctrl_tests.c. > > Babu may correct if I'm wrong: AMD does support the MBA and MBM features. So > if querying the info directory, the features are there. But AMD doesn't want > to support the testing for the features in the current patch set. They may > support the testing in the future. Yes. AMD supports the MBA and MBM features. But, deciding the test pass/fail was not clear to me. That is why I decided to disable the test for now. Right now, it reports the test result as "fail". We can add the test in the future with some modifications. > > Thanks. > > -Fenghua >
RE: [PATCH v7 12/13] selftests/resctrl: Disable MBA and MBM tests for AMD
> On Friday, May 10, 2019 10:40 AM > Andre Przywara [mailto:andre.przyw...@arm.com] wrote: > To: Yu, Fenghua > Cc: Thomas Gleixner ; Ingo Molnar > ; Borislav Petkov ; H Peter Anvin > ; Luck, Tony ; Chatre, Reinette > ; Shankar, Ravi V ; > Shen, Xiaochen ; Pathan, Arshiya Hayatkhan > ; Prakhya, Sai Praneeth > ; Babu Moger ; > linux-kernel ; James Morse > > Subject: Re: [PATCH v7 12/13] selftests/resctrl: Disable MBA and MBM tests > for AMD > > On Sat, 9 Feb 2019 18:50:41 -0800 > Fenghua Yu wrote: > > Hi, > > > From: Babu Moger > > > > For now, disable MBA and MBM tests for AMD. Deciding test pass/fail is > > not clear right now. We can enable when we have some clarity. > > I don't think this is the right way. The availability of features should be > queryable, for instance by looking into /sys/fs/resctrl/info. Checking for a > certain vendor to skip tests just sounds wrong to me, and is definitely not > scalable or future proof. > > We should really check the availability of a feature, then skip the whole > subsystem test in resctrl_tests.c. Babu may correct if I'm wrong: AMD does support the MBA and MBM features. So if querying the info directory, the features are there. But AMD doesn't want to support the testing for the features in the current patch set. They may support the testing in the future. Thanks. -Fenghua
Re: [PATCH v7 12/13] selftests/resctrl: Disable MBA and MBM tests for AMD
On Sat, 9 Feb 2019 18:50:41 -0800 Fenghua Yu wrote: Hi, > From: Babu Moger > > For now, disable MBA and MBM tests for AMD. Deciding test pass/fail > is not clear right now. We can enable when we have some clarity. I don't think this is the right way. The availability of features should be queryable, for instance by looking into /sys/fs/resctrl/info. Checking for a certain vendor to skip tests just sounds wrong to me, and is definitely not scalable or future proof. We should really check the availability of a feature, then skip the whole subsystem test in resctrl_tests.c. Cheers, Andre. > > Signed-off-by: Babu Moger > Signed-off-by: Fenghua Yu > --- > tools/testing/selftests/resctrl/cat_test.c | 2 +- > tools/testing/selftests/resctrl/resctrl_tests.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/resctrl/cat_test.c > b/tools/testing/selftests/resctrl/cat_test.c > index 1a0f77e4f7bf..264bf2325f9e 100644 > --- a/tools/testing/selftests/resctrl/cat_test.c > +++ b/tools/testing/selftests/resctrl/cat_test.c > @@ -69,7 +69,7 @@ static void show_cache_info(unsigned long > sum_llc_perf_miss, int no_of_bits, > printf("Allocated cache lines: %lu \t", allocated_cache_lines); > printf("Percent diff=%d \t", abs((int)diff_percent)); > > - if (abs((int)diff_percent) > MAX_DIFF_PERCENT) > + if (genuine_intel && (abs((int)diff_percent) > MAX_DIFF_PERCENT)) > printf("Failed\n"); > else > printf("Passed\n"); > diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c > b/tools/testing/selftests/resctrl/resctrl_tests.c > index 1d9adcfbdb4c..620be40b8c01 100644 > --- a/tools/testing/selftests/resctrl/resctrl_tests.c > +++ b/tools/testing/selftests/resctrl/resctrl_tests.c > @@ -197,7 +197,7 @@ int main(int argc, char **argv) > sprintf(bw_report, "reads"); > sprintf(bm_type, "fill_buf"); > > - if (mbm_test) { > + if (genuine_intel && mbm_test) { > printf("\nMBM BW Change Starting..\n"); > if (!has_ben) > sprintf(benchmark_cmd[5], "%s", "mbm"); > @@ -207,7 +207,7 @@ int main(int argc, char **argv) > mbm_test_cleanup(); > } > > - if (mba_test) { > + if (genuine_intel && mba_test) { > printf("\nMBA Schemata Change Starting..\n"); > if (!has_ben) > sprintf(benchmark_cmd[5], "%s", "mba");