Re: [PATCH, RFC 1/8] ARM: localtimer: return percpu clkevt on register

2013-02-19 Thread Felipe Balbi 
Hi,

On Mon, Feb 18, 2013 at 05:06:39PM +0530, Afzal Mohammed wrote:
> @@ -315,6 +315,7 @@ static struct local_timer_ops twd_lt_ops __cpuinitdata = {
>  static int __init twd_local_timer_common_register(struct device_node *np)
>  {
>   int err;
> + struct clock_event_device *evt;
>  
>   twd_evt = alloc_percpu(struct clock_event_device *);
>   if (!twd_evt) {
> @@ -328,8 +329,8 @@ static int __init twd_local_timer_common_register(struct 
> device_node *np)
>   goto out_free;
>   }
>  
> - err = local_timer_register(_lt_ops);
> - if (err)
> + evt = local_timer_register(_lt_ops);
> + if (IS_ERR(evt))
>   goto out_irq;

this is wrong. Will return 0 even in the error case. Correct version
would be:

if (IS_ERR(evt)) {
err = PTR_ERR(evt);
goto out_irq;
}

-- 
balbi


signature.asc
Description: Digital signature

Re: [PATCH, RFC 1/8] ARM: localtimer: return percpu clkevt on register

2013-02-19 Thread Santosh Shilimkar 

On Monday 18 February 2013 05:06 PM, Afzal Mohammed wrote:

Return percpu clock event on local timer register. It is the boot cpu
that calls this and it can use the returned percpu clock event to
register a clock event in the case of SMP configuration with one core.

SMP configuration with 1 core is UP :-)
Jokes apart as said already, lets see whether we really need it.

Regards,
Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH, RFC 1/8] ARM: localtimer: return percpu clkevt on register

2013-02-19 Thread Santosh Shilimkar 

On Monday 18 February 2013 05:06 PM, Afzal Mohammed wrote:

Return percpu clock event on local timer register. It is the boot cpu
that calls this and it can use the returned percpu clock event to
register a clock event in the case of SMP configuration with one core.

SMP configuration with 1 core is UP :-)
Jokes apart as said already, lets see whether we really need it.

Regards,
Santosh
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH, RFC 1/8] ARM: localtimer: return percpu clkevt on register

2013-02-19 Thread Felipe Balbi 
Hi,

On Mon, Feb 18, 2013 at 05:06:39PM +0530, Afzal Mohammed wrote:
 @@ -315,6 +315,7 @@ static struct local_timer_ops twd_lt_ops __cpuinitdata = {
  static int __init twd_local_timer_common_register(struct device_node *np)
  {
   int err;
 + struct clock_event_device *evt;
  
   twd_evt = alloc_percpu(struct clock_event_device *);
   if (!twd_evt) {
 @@ -328,8 +329,8 @@ static int __init twd_local_timer_common_register(struct 
 device_node *np)
   goto out_free;
   }
  
 - err = local_timer_register(twd_lt_ops);
 - if (err)
 + evt = local_timer_register(twd_lt_ops);
 + if (IS_ERR(evt))
   goto out_irq;

this is wrong. Will return 0 even in the error case. Correct version
would be:

if (IS_ERR(evt)) {
err = PTR_ERR(evt);
goto out_irq;
}

-- 
balbi


signature.asc
Description: Digital signature