Re: [PATCH 4/9] MIPS: xilfpga: Use Xilinx AXI Interrupt Controller

[Jason Cooper]

Hi Zubair,

On Mon, Aug 15, 2016 at 02:55:30PM +0100, Zubair Lutfullah Kakakhel wrote:
> IRQs from peripherals such as i2c/uart/ethernet come via
> the AXI Interrupt controller.
> 
> Select it in Kconfig for xilfpga and add the DT node
> 
> Signed-off-by: Zubair Lutfullah Kakakhel 
> ---
>  arch/mips/Kconfig|  1 +
>  arch/mips/boot/dts/xilfpga/nexys4ddr.dts | 12 
>  2 files changed, 13 insertions(+)
> 
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 2638856..42ecf40 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -426,6 +426,7 @@ config MACH_XILFPGA
>   select SYS_SUPPORTS_ZBOOT_UART16550
>   select USE_OF
>   select USE_GENERIC_EARLY_PRINTK_8250
> + select XILINX_IRQ
>   help
> This enables support for the IMG University Program MIPSfpga platform.

Please split dt changes from code changes.

> diff --git a/arch/mips/boot/dts/xilfpga/nexys4ddr.dts 
> b/arch/mips/boot/dts/xilfpga/nexys4ddr.dts
> index 48d2112..8db660b 100644
> --- a/arch/mips/boot/dts/xilfpga/nexys4ddr.dts
> +++ b/arch/mips/boot/dts/xilfpga/nexys4ddr.dts
> @@ -17,6 +17,18 @@
>   compatible = "mti,cpu-interrupt-controller";
>   };
>  
> + axi_intc: interrupt-controller@1020 {
> + #interrupt-cells = <1>;
> + compatible = "xlnx,xps-intc-1.00.a";

This compatible string isn't documented, mind adding it?  Please make
sure to Cc the devicetree maintainers on it.

thx,

Jason.

> + interrupt-controller;
> + reg = <0x1020 0x1>;
> + xlnx,kind-of-intr = <0x0>;
> + xlnx,num-intr-inputs = <0x6>;
> +
> + interrupt-parent = <>;
> + interrupts = <6>;
> + };
> +
>   axi_gpio: gpio@1060 {
>   #gpio-cells = <1>;
>   compatible = "xlnx,xps-gpio-1.00.a";
> -- 
> 1.9.1
> 

Re: [PATCH 4/9] MIPS: xilfpga: Use Xilinx AXI Interrupt Controller

[Jason Cooper]

Hi Zubair,

On Mon, Aug 15, 2016 at 02:55:30PM +0100, Zubair Lutfullah Kakakhel wrote:
> IRQs from peripherals such as i2c/uart/ethernet come via
> the AXI Interrupt controller.
> 
> Select it in Kconfig for xilfpga and add the DT node
> 
> Signed-off-by: Zubair Lutfullah Kakakhel 
> ---
>  arch/mips/Kconfig|  1 +
>  arch/mips/boot/dts/xilfpga/nexys4ddr.dts | 12 
>  2 files changed, 13 insertions(+)
> 
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 2638856..42ecf40 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -426,6 +426,7 @@ config MACH_XILFPGA
>   select SYS_SUPPORTS_ZBOOT_UART16550
>   select USE_OF
>   select USE_GENERIC_EARLY_PRINTK_8250
> + select XILINX_IRQ
>   help
> This enables support for the IMG University Program MIPSfpga platform.

Please split dt changes from code changes.

> diff --git a/arch/mips/boot/dts/xilfpga/nexys4ddr.dts 
> b/arch/mips/boot/dts/xilfpga/nexys4ddr.dts
> index 48d2112..8db660b 100644
> --- a/arch/mips/boot/dts/xilfpga/nexys4ddr.dts
> +++ b/arch/mips/boot/dts/xilfpga/nexys4ddr.dts
> @@ -17,6 +17,18 @@
>   compatible = "mti,cpu-interrupt-controller";
>   };
>  
> + axi_intc: interrupt-controller@1020 {
> + #interrupt-cells = <1>;
> + compatible = "xlnx,xps-intc-1.00.a";

This compatible string isn't documented, mind adding it?  Please make
sure to Cc the devicetree maintainers on it.

thx,

Jason.

> + interrupt-controller;
> + reg = <0x1020 0x1>;
> + xlnx,kind-of-intr = <0x0>;
> + xlnx,num-intr-inputs = <0x6>;
> +
> + interrupt-parent = <>;
> + interrupts = <6>;
> + };
> +
>   axi_gpio: gpio@1060 {
>   #gpio-cells = <1>;
>   compatible = "xlnx,xps-gpio-1.00.a";
> -- 
> 1.9.1
>