Re: [Rt2400-devel] rt73usb: support for wireless in Kohjinsha subnotebook

2007-10-21 Thread Luis Correia
Hi

On 10/21/07, Ivo van Doorn <[EMAIL PROTECTED]> wrote:
> On Sunday 21 October 2007, Pavel Machek wrote:
> > On Sun 2007-10-21 15:49:44, Ivo van Doorn wrote:
> > > On Sunday 21 October 2007, Pavel Machek wrote:
> > > > Hi!
> > > >
> > > > > > Kohjinsha subnotebook seems to contain wifi with USB IDs 0x18e8,
> > > > > > 0x6206... I hope that to be compatible with
> > > > > > net/wireless/rt2x00/rt73usb.c .
> > > > >
> > > > > Is there any reason you assume it is a rt73usb device,
> > > > > or are you just making wild guesses about what the chipset is?
> > > >
> > > > Wild guess. I've seen 18e8:6XXX being handled by rt73usb, so..
> > >
> > > Thats an incorrect assumption. USB ID's listed in rt73usb don't even
> > > guarentee that the device contains a rt73usb chipset since some 
> > > manufacturers
> > > produce cards with different chipsets while keeping the USB ID the same.
> > > So the case that the card false in the 6xxx range says absolutely 
> > > _nothing_.
> >
> > Well, see the other mail, it seems like rt73usb partially communicates
> > with the card.
>
> If you add a USB ID to the driver, then you are telling it to communciate to
> the device. It doesn't suddenly make the driver compatible with the device.
>
> > What info would be useful in determining what is this card similar to?
> > Boot windows and look for driver name?
>
> Looking at the name of the windows driver is indeed usually a good start,
> but you don't need to boot to windows to check that. How about looking
> at the driver name on the driver CD, or on the support website of the
> manufacturer.

I'm currently going throught the manufacturer's website (in Japanese)
to try and figure out which wireless chipset it is.

Only one driver to go and I'm not even sure it is the wireless driver...

Luis Correia
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [Rt2400-devel] rt73usb: support for wireless in Kohjinsha subnotebook

2007-10-21 Thread Ivo van Doorn
On Sunday 21 October 2007, Pavel Machek wrote:
> On Sun 2007-10-21 15:49:44, Ivo van Doorn wrote:
> > On Sunday 21 October 2007, Pavel Machek wrote:
> > > Hi!
> > > 
> > > > > Kohjinsha subnotebook seems to contain wifi with USB IDs 0x18e8,
> > > > > 0x6206... I hope that to be compatible with
> > > > > net/wireless/rt2x00/rt73usb.c .
> > > > 
> > > > Is there any reason you assume it is a rt73usb device,
> > > > or are you just making wild guesses about what the chipset is?
> > > 
> > > Wild guess. I've seen 18e8:6XXX being handled by rt73usb, so..
> > 
> > Thats an incorrect assumption. USB ID's listed in rt73usb don't even
> > guarentee that the device contains a rt73usb chipset since some 
> > manufacturers
> > produce cards with different chipsets while keeping the USB ID the same.
> > So the case that the card false in the 6xxx range says absolutely _nothing_.
> 
> Well, see the other mail, it seems like rt73usb partially communicates
> with the card.

If you add a USB ID to the driver, then you are telling it to communciate to
the device. It doesn't suddenly make the driver compatible with the device.

> What info would be useful in determining what is this card similar to?
> Boot windows and look for driver name?

Looking at the name of the windows driver is indeed usually a good start,
but you don't need to boot to windows to check that. How about looking
at the driver name on the driver CD, or on the support website of the
manufacturer.

Ivo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [Rt2400-devel] rt73usb: support for wireless in Kohjinsha subnotebook

2007-10-21 Thread Ivo van Doorn
Hi,

> > If rt2x00 is loaded and detected the device, it should print out a debug 
> > message that starts with:
> > "Chipset detected - " What is in your case the complete line?
> 
> Ok, I guess I should include more complete debug output.
> 
> phy0 -> rt2x00usb_vendor_request: Error - Vendor Request 0x09 failed for 
> offset 0x with error -32

- Vendor requests error with the -32 errors often indicate the incorrect device.

> phy0 -> rt73usb_validate_eeprom: EEPROM recover - MAC: 66:76:2b:e8:68:e7

- Incorrect MAC address read from the device. Another hint that the device is 
not rt73.

> phy0 -> rt2x00usb_vendor_request: Error - Vendor Request 0x07 failed for 
> offset 0x3000 with error -32
> phy0 -> rt2x00_set_chip: Info - Chipset detected - rt: 1300, rf: , rev: 
> c03c0ae0

- A incorrect RF chipset. (valid values are: 1, 2, 3 or 4). Another indication 
of a incorrect device.
- A completely bogus chipset revision. A valid rt73 device has the revision 
"2573X" Where only the
  X is a variable.

> phy0 -> rt73usb_init_eeprom: Error - Invalid RF chipset detected
> 
> ...so, I think hardware is indeed quite similar to what rt73usb driver
> expects...?

No. You can assume you are forcing rt73 to control a non-rt73 device.
The fact that you had to hack to bypass the RT and RF chipset validation also 
confirms that,
those checks were there for a reason. Namely to make sure the corect driver was 
being used for the device.

Ivo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [Rt2400-devel] rt73usb: support for wireless in Kohjinsha subnotebook

2007-10-21 Thread Pavel Machek
On Sun 2007-10-21 15:49:44, Ivo van Doorn wrote:
> On Sunday 21 October 2007, Pavel Machek wrote:
> > Hi!
> > 
> > > > Kohjinsha subnotebook seems to contain wifi with USB IDs 0x18e8,
> > > > 0x6206... I hope that to be compatible with
> > > > net/wireless/rt2x00/rt73usb.c .
> > > 
> > > Is there any reason you assume it is a rt73usb device,
> > > or are you just making wild guesses about what the chipset is?
> > 
> > Wild guess. I've seen 18e8:6XXX being handled by rt73usb, so..
> 
> Thats an incorrect assumption. USB ID's listed in rt73usb don't even
> guarentee that the device contains a rt73usb chipset since some manufacturers
> produce cards with different chipsets while keeping the USB ID the same.
> So the case that the card false in the 6xxx range says absolutely _nothing_.

Well, see the other mail, it seems like rt73usb partially communicates
with the card.

What info would be useful in determining what is this card similar to?
Boot windows and look for driver name?
Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [Rt2400-devel] rt73usb: support for wireless in Kohjinsha subnotebook

2007-10-21 Thread Ivo van Doorn
On Sunday 21 October 2007, Pavel Machek wrote:
> Hi!
> 
> > > Kohjinsha subnotebook seems to contain wifi with USB IDs 0x18e8,
> > > 0x6206... I hope that to be compatible with
> > > net/wireless/rt2x00/rt73usb.c .
> > 
> > Is there any reason you assume it is a rt73usb device,
> > or are you just making wild guesses about what the chipset is?
> 
> Wild guess. I've seen 18e8:6XXX being handled by rt73usb, so..

Thats an incorrect assumption. USB ID's listed in rt73usb don't even
guarentee that the device contains a rt73usb chipset since some manufacturers
produce cards with different chipsets while keeping the USB ID the same.
So the case that the card false in the 6xxx range says absolutely _nothing_.

Ivo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [Rt2400-devel] rt73usb: support for wireless in Kohjinsha subnotebook

2007-10-21 Thread Pavel Machek
Hi!

> > Kohjinsha subnotebook seems to contain wifi with USB IDs 0x18e8,
> > 0x6206... I hope that to be compatible with
> > net/wireless/rt2x00/rt73usb.c .
> 
> Is there any reason you assume it is a rt73usb device,
> or are you just making wild guesses about what the chipset is?

Wild guess. I've seen 18e8:6XXX being handled by rt73usb, so..

> > [Sidenote: could we add some real author info into rt73usb.c?]
> 
> You mean expanding the project name to the full list of developers in
> the project? I don't see any need for that.

At least put name and email of lead developer there, or something.

I do not think "copyright sourceforge project" is okay thing to do --
unless the sf project legaly exists and you did some paperwork.
Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [Rt2400-devel] rt73usb: support for wireless in Kohjinsha subnotebook

2007-10-21 Thread Pavel Machek
Hi!

> > I did this on 2.6.23-rc8-mm1 kernel (The RT hack may not be
> > neccessary), but then it oopses somewhere in softmac layer. I'll try
> > to play with it some more.
> > 
> > If you have any ideas, let me know.
> > Pavel
> > 
> > --- clean-mm/drivers/net/wireless/rt2x00/rt73usb.c  2007-10-09 
> > 09:32:08.0 +0200
> > +++ linux-mm/drivers/net/wireless/rt2x00/rt73usb.c  2007-10-19 
> > 22:19:45.0 +0200
> > @@ -1580,7 +1580,6 @@
> >  
> > if (!rt2x00_rev(>chip, 0x25730)) {
> > ERROR(rt2x00dev, "Invalid RT chipset detected.\n");
> > -   return -ENODEV;
> > }
> >  
> > if (!rt2x00_rf(>chip, RF5226) &&
> > @@ -1588,7 +1587,6 @@
> > !rt2x00_rf(>chip, RF5225) &&
> > !rt2x00_rf(>chip, RF2527)) {
> > ERROR(rt2x00dev, "Invalid RF chipset detected.\n");
> > -   return -ENODEV;
> > }
> 
> Both removals of -ENODEV are completely wrong. If the device does not pass 
> the above
> 2 checks it is _not_ a rt73usb device. And forcing the driver to work with 
> the device will
> result in all kinds of problems.

Of course they are :-).

> If rt2x00 is loaded and detected the device, it should print out a debug 
> message that starts with:
> "Chipset detected - " What is in your case the complete line?

Ok, I guess I should include more complete debug output.

phy0 -> rt2x00usb_vendor_request: Error - Vendor Request 0x09 failed for offset 
0x with error -32
phy0 -> rt73usb_validate_eeprom: EEPROM recover - MAC: 66:76:2b:e8:68:e7
phy0 -> rt2x00usb_vendor_request: Error - Vendor Request 0x07 failed for offset 
0x3000 with error -32
phy0 -> rt2x00_set_chip: Info - Chipset detected - rt: 1300, rf: , rev: 
c03c0ae0
phy0 -> rt73usb_init_eeprom: Error - Invalid RF chipset detected

...so, I think hardware is indeed quite similar to what rt73usb driver
expects...?

Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [Rt2400-devel] rt73usb: support for wireless in Kohjinsha subnotebook

2007-10-21 Thread Pavel Machek
Hi!

  I did this on 2.6.23-rc8-mm1 kernel (The RT hack may not be
  neccessary), but then it oopses somewhere in softmac layer. I'll try
  to play with it some more.
  
  If you have any ideas, let me know.
  Pavel
  
  --- clean-mm/drivers/net/wireless/rt2x00/rt73usb.c  2007-10-09 
  09:32:08.0 +0200
  +++ linux-mm/drivers/net/wireless/rt2x00/rt73usb.c  2007-10-19 
  22:19:45.0 +0200
  @@ -1580,7 +1580,6 @@
   
  if (!rt2x00_rev(rt2x00dev-chip, 0x25730)) {
  ERROR(rt2x00dev, Invalid RT chipset detected.\n);
  -   return -ENODEV;
  }
   
  if (!rt2x00_rf(rt2x00dev-chip, RF5226) 
  @@ -1588,7 +1587,6 @@
  !rt2x00_rf(rt2x00dev-chip, RF5225) 
  !rt2x00_rf(rt2x00dev-chip, RF2527)) {
  ERROR(rt2x00dev, Invalid RF chipset detected.\n);
  -   return -ENODEV;
  }
 
 Both removals of -ENODEV are completely wrong. If the device does not pass 
 the above
 2 checks it is _not_ a rt73usb device. And forcing the driver to work with 
 the device will
 result in all kinds of problems.

Of course they are :-).

 If rt2x00 is loaded and detected the device, it should print out a debug 
 message that starts with:
 Chipset detected -  What is in your case the complete line?

Ok, I guess I should include more complete debug output.

phy0 - rt2x00usb_vendor_request: Error - Vendor Request 0x09 failed for offset 
0x with error -32
phy0 - rt73usb_validate_eeprom: EEPROM recover - MAC: 66:76:2b:e8:68:e7
phy0 - rt2x00usb_vendor_request: Error - Vendor Request 0x07 failed for offset 
0x3000 with error -32
phy0 - rt2x00_set_chip: Info - Chipset detected - rt: 1300, rf: , rev: 
c03c0ae0
phy0 - rt73usb_init_eeprom: Error - Invalid RF chipset detected

...so, I think hardware is indeed quite similar to what rt73usb driver
expects...?

Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [Rt2400-devel] rt73usb: support for wireless in Kohjinsha subnotebook

2007-10-21 Thread Pavel Machek
Hi!

  Kohjinsha subnotebook seems to contain wifi with USB IDs 0x18e8,
  0x6206... I hope that to be compatible with
  net/wireless/rt2x00/rt73usb.c .
 
 Is there any reason you assume it is a rt73usb device,
 or are you just making wild guesses about what the chipset is?

Wild guess. I've seen 18e8:6XXX being handled by rt73usb, so..

  [Sidenote: could we add some real author info into rt73usb.c?]
 
 You mean expanding the project name to the full list of developers in
 the project? I don't see any need for that.

At least put name and email of lead developer there, or something.

I do not think copyright sourceforge project is okay thing to do --
unless the sf project legaly exists and you did some paperwork.
Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [Rt2400-devel] rt73usb: support for wireless in Kohjinsha subnotebook

2007-10-21 Thread Ivo van Doorn
On Sunday 21 October 2007, Pavel Machek wrote:
 Hi!
 
   Kohjinsha subnotebook seems to contain wifi with USB IDs 0x18e8,
   0x6206... I hope that to be compatible with
   net/wireless/rt2x00/rt73usb.c .
  
  Is there any reason you assume it is a rt73usb device,
  or are you just making wild guesses about what the chipset is?
 
 Wild guess. I've seen 18e8:6XXX being handled by rt73usb, so..

Thats an incorrect assumption. USB ID's listed in rt73usb don't even
guarentee that the device contains a rt73usb chipset since some manufacturers
produce cards with different chipsets while keeping the USB ID the same.
So the case that the card false in the 6xxx range says absolutely _nothing_.

Ivo
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [Rt2400-devel] rt73usb: support for wireless in Kohjinsha subnotebook

2007-10-21 Thread Ivo van Doorn
Hi,

  If rt2x00 is loaded and detected the device, it should print out a debug 
  message that starts with:
  Chipset detected -  What is in your case the complete line?
 
 Ok, I guess I should include more complete debug output.
 
 phy0 - rt2x00usb_vendor_request: Error - Vendor Request 0x09 failed for 
 offset 0x with error -32

- Vendor requests error with the -32 errors often indicate the incorrect device.

 phy0 - rt73usb_validate_eeprom: EEPROM recover - MAC: 66:76:2b:e8:68:e7

- Incorrect MAC address read from the device. Another hint that the device is 
not rt73.

 phy0 - rt2x00usb_vendor_request: Error - Vendor Request 0x07 failed for 
 offset 0x3000 with error -32
 phy0 - rt2x00_set_chip: Info - Chipset detected - rt: 1300, rf: , rev: 
 c03c0ae0

- A incorrect RF chipset. (valid values are: 1, 2, 3 or 4). Another indication 
of a incorrect device.
- A completely bogus chipset revision. A valid rt73 device has the revision 
2573X Where only the
  X is a variable.

 phy0 - rt73usb_init_eeprom: Error - Invalid RF chipset detected
 
 ...so, I think hardware is indeed quite similar to what rt73usb driver
 expects...?

No. You can assume you are forcing rt73 to control a non-rt73 device.
The fact that you had to hack to bypass the RT and RF chipset validation also 
confirms that,
those checks were there for a reason. Namely to make sure the corect driver was 
being used for the device.

Ivo
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [Rt2400-devel] rt73usb: support for wireless in Kohjinsha subnotebook

2007-10-21 Thread Pavel Machek
On Sun 2007-10-21 15:49:44, Ivo van Doorn wrote:
 On Sunday 21 October 2007, Pavel Machek wrote:
  Hi!
  
Kohjinsha subnotebook seems to contain wifi with USB IDs 0x18e8,
0x6206... I hope that to be compatible with
net/wireless/rt2x00/rt73usb.c .
   
   Is there any reason you assume it is a rt73usb device,
   or are you just making wild guesses about what the chipset is?
  
  Wild guess. I've seen 18e8:6XXX being handled by rt73usb, so..
 
 Thats an incorrect assumption. USB ID's listed in rt73usb don't even
 guarentee that the device contains a rt73usb chipset since some manufacturers
 produce cards with different chipsets while keeping the USB ID the same.
 So the case that the card false in the 6xxx range says absolutely _nothing_.

Well, see the other mail, it seems like rt73usb partially communicates
with the card.

What info would be useful in determining what is this card similar to?
Boot windows and look for driver name?
Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [Rt2400-devel] rt73usb: support for wireless in Kohjinsha subnotebook

2007-10-21 Thread Ivo van Doorn
On Sunday 21 October 2007, Pavel Machek wrote:
 On Sun 2007-10-21 15:49:44, Ivo van Doorn wrote:
  On Sunday 21 October 2007, Pavel Machek wrote:
   Hi!
   
 Kohjinsha subnotebook seems to contain wifi with USB IDs 0x18e8,
 0x6206... I hope that to be compatible with
 net/wireless/rt2x00/rt73usb.c .

Is there any reason you assume it is a rt73usb device,
or are you just making wild guesses about what the chipset is?
   
   Wild guess. I've seen 18e8:6XXX being handled by rt73usb, so..
  
  Thats an incorrect assumption. USB ID's listed in rt73usb don't even
  guarentee that the device contains a rt73usb chipset since some 
  manufacturers
  produce cards with different chipsets while keeping the USB ID the same.
  So the case that the card false in the 6xxx range says absolutely _nothing_.
 
 Well, see the other mail, it seems like rt73usb partially communicates
 with the card.

If you add a USB ID to the driver, then you are telling it to communciate to
the device. It doesn't suddenly make the driver compatible with the device.

 What info would be useful in determining what is this card similar to?
 Boot windows and look for driver name?

Looking at the name of the windows driver is indeed usually a good start,
but you don't need to boot to windows to check that. How about looking
at the driver name on the driver CD, or on the support website of the
manufacturer.

Ivo
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [Rt2400-devel] rt73usb: support for wireless in Kohjinsha subnotebook

2007-10-21 Thread Luis Correia
Hi

On 10/21/07, Ivo van Doorn [EMAIL PROTECTED] wrote:
 On Sunday 21 October 2007, Pavel Machek wrote:
  On Sun 2007-10-21 15:49:44, Ivo van Doorn wrote:
   On Sunday 21 October 2007, Pavel Machek wrote:
Hi!
   
  Kohjinsha subnotebook seems to contain wifi with USB IDs 0x18e8,
  0x6206... I hope that to be compatible with
  net/wireless/rt2x00/rt73usb.c .

 Is there any reason you assume it is a rt73usb device,
 or are you just making wild guesses about what the chipset is?
   
Wild guess. I've seen 18e8:6XXX being handled by rt73usb, so..
  
   Thats an incorrect assumption. USB ID's listed in rt73usb don't even
   guarentee that the device contains a rt73usb chipset since some 
   manufacturers
   produce cards with different chipsets while keeping the USB ID the same.
   So the case that the card false in the 6xxx range says absolutely 
   _nothing_.
 
  Well, see the other mail, it seems like rt73usb partially communicates
  with the card.

 If you add a USB ID to the driver, then you are telling it to communciate to
 the device. It doesn't suddenly make the driver compatible with the device.

  What info would be useful in determining what is this card similar to?
  Boot windows and look for driver name?

 Looking at the name of the windows driver is indeed usually a good start,
 but you don't need to boot to windows to check that. How about looking
 at the driver name on the driver CD, or on the support website of the
 manufacturer.

I'm currently going throught the manufacturer's website (in Japanese)
to try and figure out which wireless chipset it is.

Only one driver to go and I'm not even sure it is the wireless driver...

Luis Correia
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [Rt2400-devel] rt73usb: support for wireless in Kohjinsha subnotebook

2007-10-20 Thread Ivo van Doorn
Hi,

> Kohjinsha subnotebook seems to contain wifi with USB IDs 0x18e8,
> 0x6206... I hope that to be compatible with
> net/wireless/rt2x00/rt73usb.c .

Is there any reason you assume it is a rt73usb device,
or are you just making wild guesses about what the chipset is?

> [Sidenote: could we add some real author info into rt73usb.c?]

You mean expanding the project name to the full list of developers in
the project? I don't see any need for that.

> I did this on 2.6.23-rc8-mm1 kernel (The RT hack may not be
> neccessary), but then it oopses somewhere in softmac layer. I'll try
> to play with it some more.
> 
> If you have any ideas, let me know.
>   Pavel
> 
> --- clean-mm/drivers/net/wireless/rt2x00/rt73usb.c2007-10-09 
> 09:32:08.0 +0200
> +++ linux-mm/drivers/net/wireless/rt2x00/rt73usb.c2007-10-19 
> 22:19:45.0 +0200
> @@ -1580,7 +1580,6 @@
>  
>   if (!rt2x00_rev(>chip, 0x25730)) {
>   ERROR(rt2x00dev, "Invalid RT chipset detected.\n");
> - return -ENODEV;
>   }
>  
>   if (!rt2x00_rf(>chip, RF5226) &&
> @@ -1588,7 +1587,6 @@
>   !rt2x00_rf(>chip, RF5225) &&
>   !rt2x00_rf(>chip, RF2527)) {
>   ERROR(rt2x00dev, "Invalid RF chipset detected.\n");
> - return -ENODEV;
>   }

Both removals of -ENODEV are completely wrong. If the device does not pass the 
above
2 checks it is _not_ a rt73usb device. And forcing the driver to work with the 
device will
result in all kinds of problems.

If rt2x00 is loaded and detected the device, it should print out a debug 
message that starts with:
"Chipset detected - " What is in your case the complete line?

Ivo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [Rt2400-devel] rt73usb: support for wireless in Kohjinsha subnotebook

2007-10-20 Thread Ivo van Doorn
Hi,

 Kohjinsha subnotebook seems to contain wifi with USB IDs 0x18e8,
 0x6206... I hope that to be compatible with
 net/wireless/rt2x00/rt73usb.c .

Is there any reason you assume it is a rt73usb device,
or are you just making wild guesses about what the chipset is?

 [Sidenote: could we add some real author info into rt73usb.c?]

You mean expanding the project name to the full list of developers in
the project? I don't see any need for that.

 I did this on 2.6.23-rc8-mm1 kernel (The RT hack may not be
 neccessary), but then it oopses somewhere in softmac layer. I'll try
 to play with it some more.
 
 If you have any ideas, let me know.
   Pavel
 
 --- clean-mm/drivers/net/wireless/rt2x00/rt73usb.c2007-10-09 
 09:32:08.0 +0200
 +++ linux-mm/drivers/net/wireless/rt2x00/rt73usb.c2007-10-19 
 22:19:45.0 +0200
 @@ -1580,7 +1580,6 @@
  
   if (!rt2x00_rev(rt2x00dev-chip, 0x25730)) {
   ERROR(rt2x00dev, Invalid RT chipset detected.\n);
 - return -ENODEV;
   }
  
   if (!rt2x00_rf(rt2x00dev-chip, RF5226) 
 @@ -1588,7 +1587,6 @@
   !rt2x00_rf(rt2x00dev-chip, RF5225) 
   !rt2x00_rf(rt2x00dev-chip, RF2527)) {
   ERROR(rt2x00dev, Invalid RF chipset detected.\n);
 - return -ENODEV;
   }

Both removals of -ENODEV are completely wrong. If the device does not pass the 
above
2 checks it is _not_ a rt73usb device. And forcing the driver to work with the 
device will
result in all kinds of problems.

If rt2x00 is loaded and detected the device, it should print out a debug 
message that starts with:
Chipset detected -  What is in your case the complete line?

Ivo
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/