Re: [f2fs-dev] [PATCH 1/2] f2fs: disable the extent cache ops on high fragmented files
> Signed-off-by: Jaegeuk Kim
Function looks good to me. But some nitpicking below for code cleanup..
> @@ -71,6 +71,9 @@ static int check_extent_cache(struct inode *inode, pgoff_t
> pgofs,
return value could be boolean?
> pgoff_t start_fofs, end_fofs;
> block_t start_blkaddr;
>
> + if (is_inode_flag_set(fi, FI_NO_EXTENT))
> + return 0;
> +
> read_lock(>ext.ext_lock);
> if (fi->ext.len == 0) {
> read_unlock(>ext.ext_lock);
> @@ -109,6 +112,7 @@ void update_extent_cache(block_t blk_addr, struct
> dnode_of_data *dn)
> struct f2fs_inode_info *fi = F2FS_I(dn->inode);
> pgoff_t fofs, start_fofs, end_fofs;
> block_t start_blkaddr, end_blkaddr;
> + int need_update = true;
bool?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [f2fs-dev] [PATCH 1/2] f2fs: disable the extent cache ops on high fragmented files
Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com
Function looks good to me. But some nitpicking below for code cleanup..
@@ -71,6 +71,9 @@ static int check_extent_cache(struct inode *inode, pgoff_t
pgofs,
return value could be boolean?
pgoff_t start_fofs, end_fofs;
block_t start_blkaddr;
+ if (is_inode_flag_set(fi, FI_NO_EXTENT))
+ return 0;
+
read_lock(fi-ext.ext_lock);
if (fi-ext.len == 0) {
read_unlock(fi-ext.ext_lock);
@@ -109,6 +112,7 @@ void update_extent_cache(block_t blk_addr, struct
dnode_of_data *dn)
struct f2fs_inode_info *fi = F2FS_I(dn-inode);
pgoff_t fofs, start_fofs, end_fofs;
block_t start_blkaddr, end_blkaddr;
+ int need_update = true;
bool?
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
