Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse
On Mon, 24 Feb 2014, Bjorn Helgaas wrote: > On Mon, Feb 24, 2014 at 3:06 PM, Thomas Gleixner wrote: > > On Mon, 24 Feb 2014, Bjorn Helgaas wrote: > >> On Sun, Feb 23, 2014 at 4:33 PM, Jingoo Han wrote: > >> > On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote: > >> >> > >> >> There is no reason to care about irq_desc in that context, escpecially > >> >> as irq_data for that interrupt is retrieved as well. > >> >> > >> >> Use the proper accessor for the msi descriptor > >> >> > >> >> Signed-off-by: Thomas Gleixner > >> >> Cc: Bjorn Helgaas > >> >> Cc: Jingoo Han > >> >> Cc: Mohit Kumar > >> >> Cc: pci > >> > > >> > Acked-by: Jingoo Han > >> > >> Acked-by: Bjorn Helgaas > >> > >> Thomas, I assume you'll merge this along with the rest of your series. > >> I don't have any pending changes in this area. > > > > I can do, but it does not depend on anything else, so you can pick it > > up as well. Either way is fine. > > I never know what to do with these. I suggested that you pick it up > so the whole series would be together, because I assumed it would make > more sense in the git history to have all these similar changes > grouped together. But maybe that really doesn't matter. > > What's the recommended practice? Dunno. There is no rule. I'll merge it up with the rest of the lot. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse
On Mon, Feb 24, 2014 at 3:06 PM, Thomas Gleixner wrote: > On Mon, 24 Feb 2014, Bjorn Helgaas wrote: >> On Sun, Feb 23, 2014 at 4:33 PM, Jingoo Han wrote: >> > On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote: >> >> >> >> There is no reason to care about irq_desc in that context, escpecially >> >> as irq_data for that interrupt is retrieved as well. >> >> >> >> Use the proper accessor for the msi descriptor >> >> >> >> Signed-off-by: Thomas Gleixner >> >> Cc: Bjorn Helgaas >> >> Cc: Jingoo Han >> >> Cc: Mohit Kumar >> >> Cc: pci >> > >> > Acked-by: Jingoo Han >> >> Acked-by: Bjorn Helgaas >> >> Thomas, I assume you'll merge this along with the rest of your series. >> I don't have any pending changes in this area. > > I can do, but it does not depend on anything else, so you can pick it > up as well. Either way is fine. I never know what to do with these. I suggested that you pick it up so the whole series would be together, because I assumed it would make more sense in the git history to have all these similar changes grouped together. But maybe that really doesn't matter. What's the recommended practice? Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse
On Mon, 24 Feb 2014, Bjorn Helgaas wrote: > On Sun, Feb 23, 2014 at 4:33 PM, Jingoo Han wrote: > > On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote: > >> > >> There is no reason to care about irq_desc in that context, escpecially > >> as irq_data for that interrupt is retrieved as well. > >> > >> Use the proper accessor for the msi descriptor > >> > >> Signed-off-by: Thomas Gleixner > >> Cc: Bjorn Helgaas > >> Cc: Jingoo Han > >> Cc: Mohit Kumar > >> Cc: pci > > > > Acked-by: Jingoo Han > > Acked-by: Bjorn Helgaas > > Thomas, I assume you'll merge this along with the rest of your series. > I don't have any pending changes in this area. I can do, but it does not depend on anything else, so you can pick it up as well. Either way is fine. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse
On Sun, Feb 23, 2014 at 4:33 PM, Jingoo Han wrote:
> On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote:
>>
>> There is no reason to care about irq_desc in that context, escpecially
>> as irq_data for that interrupt is retrieved as well.
>>
>> Use the proper accessor for the msi descriptor
>>
>> Signed-off-by: Thomas Gleixner
>> Cc: Bjorn Helgaas
>> Cc: Jingoo Han
>> Cc: Mohit Kumar
>> Cc: pci
>
> Acked-by: Jingoo Han
Acked-by: Bjorn Helgaas
Thomas, I assume you'll merge this along with the rest of your series.
I don't have any pending changes in this area.
Bjorn
> A few days ago, I noticed that irq_data_get_msi() can be used.
> However, I did not submit the same patch. I really appreciate
> your patch. :-)
>
> Best regards,
> Jingoo Han
>
>> ---
>> drivers/pci/host/pcie-designware.c |4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> Index: tip/drivers/pci/host/pcie-designware.c
>> ===
>> --- tip.orig/drivers/pci/host/pcie-designware.c
>> +++ tip/drivers/pci/host/pcie-designware.c
>> @@ -294,14 +294,12 @@ no_valid_irq:
>> static void clear_irq(unsigned int irq)
>> {
>> unsigned int pos, nvec;
>> - struct irq_desc *desc;
>> struct msi_desc *msi;
>> struct pcie_port *pp;
>> struct irq_data *data = irq_get_irq_data(irq);
>>
>> /* get the port structure */
>> - desc = irq_to_desc(irq);
>> - msi = irq_desc_get_msi_desc(desc);
>> + msi = irq_data_get_msi(data);
>> pp = sys_to_pcie(msi->dev->bus->sysdata);
>> if (!pp) {
>> BUG();
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse
On Sun, Feb 23, 2014 at 4:33 PM, Jingoo Han jg1@samsung.com wrote:
On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote:
There is no reason to care about irq_desc in that context, escpecially
as irq_data for that interrupt is retrieved as well.
Use the proper accessor for the msi descriptor
Signed-off-by: Thomas Gleixner t...@linutronix.de
Cc: Bjorn Helgaas bhelg...@google.com
Cc: Jingoo Han jg1@samsung.com
Cc: Mohit Kumar mohit.ku...@st.com
Cc: pci linux-...@vger.kernel.org
Acked-by: Jingoo Han jg1@samsung.com
Acked-by: Bjorn Helgaas bhelg...@google.com
Thomas, I assume you'll merge this along with the rest of your series.
I don't have any pending changes in this area.
Bjorn
A few days ago, I noticed that irq_data_get_msi() can be used.
However, I did not submit the same patch. I really appreciate
your patch. :-)
Best regards,
Jingoo Han
---
drivers/pci/host/pcie-designware.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Index: tip/drivers/pci/host/pcie-designware.c
===
--- tip.orig/drivers/pci/host/pcie-designware.c
+++ tip/drivers/pci/host/pcie-designware.c
@@ -294,14 +294,12 @@ no_valid_irq:
static void clear_irq(unsigned int irq)
{
unsigned int pos, nvec;
- struct irq_desc *desc;
struct msi_desc *msi;
struct pcie_port *pp;
struct irq_data *data = irq_get_irq_data(irq);
/* get the port structure */
- desc = irq_to_desc(irq);
- msi = irq_desc_get_msi_desc(desc);
+ msi = irq_data_get_msi(data);
pp = sys_to_pcie(msi-dev-bus-sysdata);
if (!pp) {
BUG();
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse
On Mon, 24 Feb 2014, Bjorn Helgaas wrote: On Sun, Feb 23, 2014 at 4:33 PM, Jingoo Han jg1@samsung.com wrote: On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote: There is no reason to care about irq_desc in that context, escpecially as irq_data for that interrupt is retrieved as well. Use the proper accessor for the msi descriptor Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Bjorn Helgaas bhelg...@google.com Cc: Jingoo Han jg1@samsung.com Cc: Mohit Kumar mohit.ku...@st.com Cc: pci linux-...@vger.kernel.org Acked-by: Jingoo Han jg1@samsung.com Acked-by: Bjorn Helgaas bhelg...@google.com Thomas, I assume you'll merge this along with the rest of your series. I don't have any pending changes in this area. I can do, but it does not depend on anything else, so you can pick it up as well. Either way is fine. Thanks, tglx -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse
On Mon, Feb 24, 2014 at 3:06 PM, Thomas Gleixner t...@linutronix.de wrote: On Mon, 24 Feb 2014, Bjorn Helgaas wrote: On Sun, Feb 23, 2014 at 4:33 PM, Jingoo Han jg1@samsung.com wrote: On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote: There is no reason to care about irq_desc in that context, escpecially as irq_data for that interrupt is retrieved as well. Use the proper accessor for the msi descriptor Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Bjorn Helgaas bhelg...@google.com Cc: Jingoo Han jg1@samsung.com Cc: Mohit Kumar mohit.ku...@st.com Cc: pci linux-...@vger.kernel.org Acked-by: Jingoo Han jg1@samsung.com Acked-by: Bjorn Helgaas bhelg...@google.com Thomas, I assume you'll merge this along with the rest of your series. I don't have any pending changes in this area. I can do, but it does not depend on anything else, so you can pick it up as well. Either way is fine. I never know what to do with these. I suggested that you pick it up so the whole series would be together, because I assumed it would make more sense in the git history to have all these similar changes grouped together. But maybe that really doesn't matter. What's the recommended practice? Bjorn -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse
On Mon, 24 Feb 2014, Bjorn Helgaas wrote: On Mon, Feb 24, 2014 at 3:06 PM, Thomas Gleixner t...@linutronix.de wrote: On Mon, 24 Feb 2014, Bjorn Helgaas wrote: On Sun, Feb 23, 2014 at 4:33 PM, Jingoo Han jg1@samsung.com wrote: On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote: There is no reason to care about irq_desc in that context, escpecially as irq_data for that interrupt is retrieved as well. Use the proper accessor for the msi descriptor Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Bjorn Helgaas bhelg...@google.com Cc: Jingoo Han jg1@samsung.com Cc: Mohit Kumar mohit.ku...@st.com Cc: pci linux-...@vger.kernel.org Acked-by: Jingoo Han jg1@samsung.com Acked-by: Bjorn Helgaas bhelg...@google.com Thomas, I assume you'll merge this along with the rest of your series. I don't have any pending changes in this area. I can do, but it does not depend on anything else, so you can pick it up as well. Either way is fine. I never know what to do with these. I suggested that you pick it up so the whole series would be together, because I assumed it would make more sense in the git history to have all these similar changes grouped together. But maybe that really doesn't matter. What's the recommended practice? Dunno. There is no rule. I'll merge it up with the rest of the lot. Thanks, tglx -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse
On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote:
>
> There is no reason to care about irq_desc in that context, escpecially
> as irq_data for that interrupt is retrieved as well.
>
> Use the proper accessor for the msi descriptor
>
> Signed-off-by: Thomas Gleixner
> Cc: Bjorn Helgaas
> Cc: Jingoo Han
> Cc: Mohit Kumar
> Cc: pci
Acked-by: Jingoo Han
A few days ago, I noticed that irq_data_get_msi() can be used.
However, I did not submit the same patch. I really appreciate
your patch. :-)
Best regards,
Jingoo Han
> ---
> drivers/pci/host/pcie-designware.c |4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> Index: tip/drivers/pci/host/pcie-designware.c
> ===
> --- tip.orig/drivers/pci/host/pcie-designware.c
> +++ tip/drivers/pci/host/pcie-designware.c
> @@ -294,14 +294,12 @@ no_valid_irq:
> static void clear_irq(unsigned int irq)
> {
> unsigned int pos, nvec;
> - struct irq_desc *desc;
> struct msi_desc *msi;
> struct pcie_port *pp;
> struct irq_data *data = irq_get_irq_data(irq);
>
> /* get the port structure */
> - desc = irq_to_desc(irq);
> - msi = irq_desc_get_msi_desc(desc);
> + msi = irq_data_get_msi(data);
> pp = sys_to_pcie(msi->dev->bus->sysdata);
> if (!pp) {
> BUG();
Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse
On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote:
There is no reason to care about irq_desc in that context, escpecially
as irq_data for that interrupt is retrieved as well.
Use the proper accessor for the msi descriptor
Signed-off-by: Thomas Gleixner t...@linutronix.de
Cc: Bjorn Helgaas bhelg...@google.com
Cc: Jingoo Han jg1@samsung.com
Cc: Mohit Kumar mohit.ku...@st.com
Cc: pci linux-...@vger.kernel.org
Acked-by: Jingoo Han jg1@samsung.com
A few days ago, I noticed that irq_data_get_msi() can be used.
However, I did not submit the same patch. I really appreciate
your patch. :-)
Best regards,
Jingoo Han
---
drivers/pci/host/pcie-designware.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Index: tip/drivers/pci/host/pcie-designware.c
===
--- tip.orig/drivers/pci/host/pcie-designware.c
+++ tip/drivers/pci/host/pcie-designware.c
@@ -294,14 +294,12 @@ no_valid_irq:
static void clear_irq(unsigned int irq)
{
unsigned int pos, nvec;
- struct irq_desc *desc;
struct msi_desc *msi;
struct pcie_port *pp;
struct irq_data *data = irq_get_irq_data(irq);
/* get the port structure */
- desc = irq_to_desc(irq);
- msi = irq_desc_get_msi_desc(desc);
+ msi = irq_data_get_msi(data);
pp = sys_to_pcie(msi-dev-bus-sysdata);
if (!pp) {
BUG();
