Re: mmotm 2018-03-07-16-19 uploaded (UML & memcg)

[Stephen Rothwell]

Hi Andrew,

On Wed, 7 Mar 2018 18:41:41 -0800 Andrew Morton  
wrote:
>
> On Wed, 7 Mar 2018 18:20:12 -0800 Randy Dunlap  wrote:
> 
> > On 03/07/2018 04:20 PM, a...@linux-foundation.org wrote:  
> > > The mm-of-the-moment snapshot 2018-03-07-16-19 has been uploaded to
> > > 
> > >http://www.ozlabs.org/~akpm/mmotm/
> > > 
> > > mmotm-readme.txt says
> > > 
> > > README for mm-of-the-moment:
> > > 
> > > http://www.ozlabs.org/~akpm/mmotm/
> > > 
> > > This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
> > > more than once a week.  
> > 
> > UML on i386 and/or x86_64:
> > 
> > defconfig, CONFIG_MEMCG is not set:
> > 
> > ../fs/notify/group.c: In function 'fsnotify_final_destroy_group':
> > ../fs/notify/group.c:41:24: error: dereferencing pointer to incomplete type
> >css_put(>memcg->css);  
> 
> oops.
> 
> From: Andrew Morton 
> Subject: fs-fsnotify-account-fsnotify-metadata-to-kmemcg-fix
> 
> fix CONFIG_MEMCG=n build
> 
> Reported-by: Randy Dunlap 
> Cc: Amir Goldstein 
> Cc: Christoph Lameter 
> Cc: David Rientjes 
> Cc: Greg Thelen 
> Cc: Jan Kara 
> Cc: Johannes Weiner 
> Cc: Joonsoo Kim 
> Cc: Mel Gorman 
> Cc: Michal Hocko 
> Cc: Pekka Enberg 
> Cc: Shakeel Butt 
> Cc: Vladimir Davydov 
> Cc: Vlastimil Babka 
> Signed-off-by: Andrew Morton 
> ---
> 
>  fs/notify/group.c |2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/fs/notify/group.c~fs-fsnotify-account-fsnotify-metadata-to-kmemcg-fix
> +++ a/fs/notify/group.c
> @@ -38,7 +38,7 @@ static void fsnotify_final_destroy_group
>   group->ops->free_group_priv(group);
>  
>   if (group->memcg)
> - css_put(>memcg->css);
> + mem_cgroup_put(group->memcg);
>  
>   kfree(group);
>  }

I have applied that to linux-next today.
-- 
Cheers,
Stephen Rothwell


pgpBRci7ycUrV.pgp
Description: OpenPGP digital signature

Re: mmotm 2018-03-07-16-19 uploaded (UML & memcg)

[Stephen Rothwell]

Hi Andrew,

On Wed, 7 Mar 2018 18:41:41 -0800 Andrew Morton  
wrote:
>
> On Wed, 7 Mar 2018 18:20:12 -0800 Randy Dunlap  wrote:
> 
> > On 03/07/2018 04:20 PM, a...@linux-foundation.org wrote:  
> > > The mm-of-the-moment snapshot 2018-03-07-16-19 has been uploaded to
> > > 
> > >http://www.ozlabs.org/~akpm/mmotm/
> > > 
> > > mmotm-readme.txt says
> > > 
> > > README for mm-of-the-moment:
> > > 
> > > http://www.ozlabs.org/~akpm/mmotm/
> > > 
> > > This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
> > > more than once a week.  
> > 
> > UML on i386 and/or x86_64:
> > 
> > defconfig, CONFIG_MEMCG is not set:
> > 
> > ../fs/notify/group.c: In function 'fsnotify_final_destroy_group':
> > ../fs/notify/group.c:41:24: error: dereferencing pointer to incomplete type
> >css_put(>memcg->css);  
> 
> oops.
> 
> From: Andrew Morton 
> Subject: fs-fsnotify-account-fsnotify-metadata-to-kmemcg-fix
> 
> fix CONFIG_MEMCG=n build
> 
> Reported-by: Randy Dunlap 
> Cc: Amir Goldstein 
> Cc: Christoph Lameter 
> Cc: David Rientjes 
> Cc: Greg Thelen 
> Cc: Jan Kara 
> Cc: Johannes Weiner 
> Cc: Joonsoo Kim 
> Cc: Mel Gorman 
> Cc: Michal Hocko 
> Cc: Pekka Enberg 
> Cc: Shakeel Butt 
> Cc: Vladimir Davydov 
> Cc: Vlastimil Babka 
> Signed-off-by: Andrew Morton 
> ---
> 
>  fs/notify/group.c |2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/fs/notify/group.c~fs-fsnotify-account-fsnotify-metadata-to-kmemcg-fix
> +++ a/fs/notify/group.c
> @@ -38,7 +38,7 @@ static void fsnotify_final_destroy_group
>   group->ops->free_group_priv(group);
>  
>   if (group->memcg)
> - css_put(>memcg->css);
> + mem_cgroup_put(group->memcg);
>  
>   kfree(group);
>  }

I have applied that to linux-next today.
-- 
Cheers,
Stephen Rothwell


pgpBRci7ycUrV.pgp
Description: OpenPGP digital signature

Re: mmotm 2018-03-07-16-19 uploaded (UML & memcg)

[Andrew Morton]

On Wed, 7 Mar 2018 18:20:12 -0800 Randy Dunlap  wrote:

> On 03/07/2018 04:20 PM, a...@linux-foundation.org wrote:
> > The mm-of-the-moment snapshot 2018-03-07-16-19 has been uploaded to
> > 
> >http://www.ozlabs.org/~akpm/mmotm/
> > 
> > mmotm-readme.txt says
> > 
> > README for mm-of-the-moment:
> > 
> > http://www.ozlabs.org/~akpm/mmotm/
> > 
> > This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
> > more than once a week.
> 
> UML on i386 and/or x86_64:
> 
> defconfig, CONFIG_MEMCG is not set:
> 
> ../fs/notify/group.c: In function 'fsnotify_final_destroy_group':
> ../fs/notify/group.c:41:24: error: dereferencing pointer to incomplete type
>css_put(>memcg->css);

oops.

From: Andrew Morton 
Subject: fs-fsnotify-account-fsnotify-metadata-to-kmemcg-fix

fix CONFIG_MEMCG=n build

Reported-by: Randy Dunlap 
Cc: Amir Goldstein 
Cc: Christoph Lameter 
Cc: David Rientjes 
Cc: Greg Thelen 
Cc: Jan Kara 
Cc: Johannes Weiner 
Cc: Joonsoo Kim 
Cc: Mel Gorman 
Cc: Michal Hocko 
Cc: Pekka Enberg 
Cc: Shakeel Butt 
Cc: Vladimir Davydov 
Cc: Vlastimil Babka 
Signed-off-by: Andrew Morton 
---

 fs/notify/group.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/notify/group.c~fs-fsnotify-account-fsnotify-metadata-to-kmemcg-fix
+++ a/fs/notify/group.c
@@ -38,7 +38,7 @@ static void fsnotify_final_destroy_group
group->ops->free_group_priv(group);
 
if (group->memcg)
-   css_put(>memcg->css);
+   mem_cgroup_put(group->memcg);
 
kfree(group);
 }
_

Re: mmotm 2018-03-07-16-19 uploaded (UML & memcg)

[Andrew Morton]

On Wed, 7 Mar 2018 18:20:12 -0800 Randy Dunlap  wrote:

> On 03/07/2018 04:20 PM, a...@linux-foundation.org wrote:
> > The mm-of-the-moment snapshot 2018-03-07-16-19 has been uploaded to
> > 
> >http://www.ozlabs.org/~akpm/mmotm/
> > 
> > mmotm-readme.txt says
> > 
> > README for mm-of-the-moment:
> > 
> > http://www.ozlabs.org/~akpm/mmotm/
> > 
> > This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
> > more than once a week.
> 
> UML on i386 and/or x86_64:
> 
> defconfig, CONFIG_MEMCG is not set:
> 
> ../fs/notify/group.c: In function 'fsnotify_final_destroy_group':
> ../fs/notify/group.c:41:24: error: dereferencing pointer to incomplete type
>css_put(>memcg->css);

oops.

From: Andrew Morton 
Subject: fs-fsnotify-account-fsnotify-metadata-to-kmemcg-fix

fix CONFIG_MEMCG=n build

Reported-by: Randy Dunlap 
Cc: Amir Goldstein 
Cc: Christoph Lameter 
Cc: David Rientjes 
Cc: Greg Thelen 
Cc: Jan Kara 
Cc: Johannes Weiner 
Cc: Joonsoo Kim 
Cc: Mel Gorman 
Cc: Michal Hocko 
Cc: Pekka Enberg 
Cc: Shakeel Butt 
Cc: Vladimir Davydov 
Cc: Vlastimil Babka 
Signed-off-by: Andrew Morton 
---

 fs/notify/group.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/notify/group.c~fs-fsnotify-account-fsnotify-metadata-to-kmemcg-fix
+++ a/fs/notify/group.c
@@ -38,7 +38,7 @@ static void fsnotify_final_destroy_group
group->ops->free_group_priv(group);
 
if (group->memcg)
-   css_put(>memcg->css);
+   mem_cgroup_put(group->memcg);
 
kfree(group);
 }
_

Re: mmotm 2018-03-07-16-19 uploaded (UML & memcg)

[Shakeel Butt]

On Wed, Mar 7, 2018 at 6:34 PM, Shakeel Butt  wrote:
> On Wed, Mar 7, 2018 at 6:23 PM, Randy Dunlap  wrote:
>> On 03/07/2018 06:20 PM, Randy Dunlap wrote:
>>> On 03/07/2018 04:20 PM, a...@linux-foundation.org wrote:
 The mm-of-the-moment snapshot 2018-03-07-16-19 has been uploaded to

http://www.ozlabs.org/~akpm/mmotm/

 mmotm-readme.txt says

 README for mm-of-the-moment:

 http://www.ozlabs.org/~akpm/mmotm/

 This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
 more than once a week.
>>>
>>> UML on i386 and/or x86_64:
>>>
>>> defconfig, CONFIG_MEMCG is not set:
>>>
>>> ../fs/notify/group.c: In function 'fsnotify_final_destroy_group':
>>> ../fs/notify/group.c:41:24: error: dereferencing pointer to incomplete type
>>>css_put(>memcg->css);
>>> ^
>>>
>>> From: Shakeel Butt 
>>> Subject: fs: fsnotify: account fsnotify metadata to kmemcg
>>
>>
>>
>> or x86 any time that CONFIG_MEMCG is not enabled.
>>
>>
>
> Sorry about that. Replacing this with mem_cgroup_put(group->memcg)
> should solve the issue on the mm tree.

Andrew, do you want me to extract mem_cgroup_put() API from Roman's
patches as a separate patch?

Re: mmotm 2018-03-07-16-19 uploaded (UML & memcg)

[Shakeel Butt]

On Wed, Mar 7, 2018 at 6:34 PM, Shakeel Butt  wrote:
> On Wed, Mar 7, 2018 at 6:23 PM, Randy Dunlap  wrote:
>> On 03/07/2018 06:20 PM, Randy Dunlap wrote:
>>> On 03/07/2018 04:20 PM, a...@linux-foundation.org wrote:
 The mm-of-the-moment snapshot 2018-03-07-16-19 has been uploaded to

http://www.ozlabs.org/~akpm/mmotm/

 mmotm-readme.txt says

 README for mm-of-the-moment:

 http://www.ozlabs.org/~akpm/mmotm/

 This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
 more than once a week.
>>>
>>> UML on i386 and/or x86_64:
>>>
>>> defconfig, CONFIG_MEMCG is not set:
>>>
>>> ../fs/notify/group.c: In function 'fsnotify_final_destroy_group':
>>> ../fs/notify/group.c:41:24: error: dereferencing pointer to incomplete type
>>>css_put(>memcg->css);
>>> ^
>>>
>>> From: Shakeel Butt 
>>> Subject: fs: fsnotify: account fsnotify metadata to kmemcg
>>
>>
>>
>> or x86 any time that CONFIG_MEMCG is not enabled.
>>
>>
>
> Sorry about that. Replacing this with mem_cgroup_put(group->memcg)
> should solve the issue on the mm tree.

Andrew, do you want me to extract mem_cgroup_put() API from Roman's
patches as a separate patch?

Re: mmotm 2018-03-07-16-19 uploaded (UML & memcg)

[Shakeel Butt]

On Wed, Mar 7, 2018 at 6:23 PM, Randy Dunlap  wrote:
> On 03/07/2018 06:20 PM, Randy Dunlap wrote:
>> On 03/07/2018 04:20 PM, a...@linux-foundation.org wrote:
>>> The mm-of-the-moment snapshot 2018-03-07-16-19 has been uploaded to
>>>
>>>http://www.ozlabs.org/~akpm/mmotm/
>>>
>>> mmotm-readme.txt says
>>>
>>> README for mm-of-the-moment:
>>>
>>> http://www.ozlabs.org/~akpm/mmotm/
>>>
>>> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
>>> more than once a week.
>>
>> UML on i386 and/or x86_64:
>>
>> defconfig, CONFIG_MEMCG is not set:
>>
>> ../fs/notify/group.c: In function 'fsnotify_final_destroy_group':
>> ../fs/notify/group.c:41:24: error: dereferencing pointer to incomplete type
>>css_put(>memcg->css);
>> ^
>>
>> From: Shakeel Butt 
>> Subject: fs: fsnotify: account fsnotify metadata to kmemcg
>
>
>
> or x86 any time that CONFIG_MEMCG is not enabled.
>
>

Sorry about that. Replacing this with mem_cgroup_put(group->memcg)
should solve the issue on the mm tree.

Re: mmotm 2018-03-07-16-19 uploaded (UML & memcg)

[Shakeel Butt]

On Wed, Mar 7, 2018 at 6:23 PM, Randy Dunlap  wrote:
> On 03/07/2018 06:20 PM, Randy Dunlap wrote:
>> On 03/07/2018 04:20 PM, a...@linux-foundation.org wrote:
>>> The mm-of-the-moment snapshot 2018-03-07-16-19 has been uploaded to
>>>
>>>http://www.ozlabs.org/~akpm/mmotm/
>>>
>>> mmotm-readme.txt says
>>>
>>> README for mm-of-the-moment:
>>>
>>> http://www.ozlabs.org/~akpm/mmotm/
>>>
>>> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
>>> more than once a week.
>>
>> UML on i386 and/or x86_64:
>>
>> defconfig, CONFIG_MEMCG is not set:
>>
>> ../fs/notify/group.c: In function 'fsnotify_final_destroy_group':
>> ../fs/notify/group.c:41:24: error: dereferencing pointer to incomplete type
>>css_put(>memcg->css);
>> ^
>>
>> From: Shakeel Butt 
>> Subject: fs: fsnotify: account fsnotify metadata to kmemcg
>
>
>
> or x86 any time that CONFIG_MEMCG is not enabled.
>
>

Sorry about that. Replacing this with mem_cgroup_put(group->memcg)
should solve the issue on the mm tree.

Re: mmotm 2018-03-07-16-19 uploaded (UML & memcg)

[Randy Dunlap]

On 03/07/2018 06:20 PM, Randy Dunlap wrote:
> On 03/07/2018 04:20 PM, a...@linux-foundation.org wrote:
>> The mm-of-the-moment snapshot 2018-03-07-16-19 has been uploaded to
>>
>>http://www.ozlabs.org/~akpm/mmotm/
>>
>> mmotm-readme.txt says
>>
>> README for mm-of-the-moment:
>>
>> http://www.ozlabs.org/~akpm/mmotm/
>>
>> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
>> more than once a week.
> 
> UML on i386 and/or x86_64:
> 
> defconfig, CONFIG_MEMCG is not set:
> 
> ../fs/notify/group.c: In function 'fsnotify_final_destroy_group':
> ../fs/notify/group.c:41:24: error: dereferencing pointer to incomplete type
>css_put(>memcg->css);
> ^
> 
> From: Shakeel Butt 
> Subject: fs: fsnotify: account fsnotify metadata to kmemcg



or x86 any time that CONFIG_MEMCG is not enabled.


-- 
~Randy

Re: mmotm 2018-03-07-16-19 uploaded (UML & memcg)

[Randy Dunlap]

On 03/07/2018 06:20 PM, Randy Dunlap wrote:
> On 03/07/2018 04:20 PM, a...@linux-foundation.org wrote:
>> The mm-of-the-moment snapshot 2018-03-07-16-19 has been uploaded to
>>
>>http://www.ozlabs.org/~akpm/mmotm/
>>
>> mmotm-readme.txt says
>>
>> README for mm-of-the-moment:
>>
>> http://www.ozlabs.org/~akpm/mmotm/
>>
>> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
>> more than once a week.
> 
> UML on i386 and/or x86_64:
> 
> defconfig, CONFIG_MEMCG is not set:
> 
> ../fs/notify/group.c: In function 'fsnotify_final_destroy_group':
> ../fs/notify/group.c:41:24: error: dereferencing pointer to incomplete type
>css_put(>memcg->css);
> ^
> 
> From: Shakeel Butt 
> Subject: fs: fsnotify: account fsnotify metadata to kmemcg



or x86 any time that CONFIG_MEMCG is not enabled.


-- 
~Randy

Re: mmotm 2018-03-07-16-19 uploaded (UML & memcg)

[Randy Dunlap]

On 03/07/2018 04:20 PM, a...@linux-foundation.org wrote:
> The mm-of-the-moment snapshot 2018-03-07-16-19 has been uploaded to
> 
>http://www.ozlabs.org/~akpm/mmotm/
> 
> mmotm-readme.txt says
> 
> README for mm-of-the-moment:
> 
> http://www.ozlabs.org/~akpm/mmotm/
> 
> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
> more than once a week.

UML on i386 and/or x86_64:

defconfig, CONFIG_MEMCG is not set:

../fs/notify/group.c: In function 'fsnotify_final_destroy_group':
../fs/notify/group.c:41:24: error: dereferencing pointer to incomplete type
   css_put(>memcg->css);
^

From: Shakeel Butt 
Subject: fs: fsnotify: account fsnotify metadata to kmemcg


-- 
~Randy

Re: mmotm 2018-03-07-16-19 uploaded (UML & memcg)

[Randy Dunlap]

On 03/07/2018 04:20 PM, a...@linux-foundation.org wrote:
> The mm-of-the-moment snapshot 2018-03-07-16-19 has been uploaded to
> 
>http://www.ozlabs.org/~akpm/mmotm/
> 
> mmotm-readme.txt says
> 
> README for mm-of-the-moment:
> 
> http://www.ozlabs.org/~akpm/mmotm/
> 
> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
> more than once a week.

UML on i386 and/or x86_64:

defconfig, CONFIG_MEMCG is not set:

../fs/notify/group.c: In function 'fsnotify_final_destroy_group':
../fs/notify/group.c:41:24: error: dereferencing pointer to incomplete type
   css_put(>memcg->css);
^

From: Shakeel Butt 
Subject: fs: fsnotify: account fsnotify metadata to kmemcg


-- 
~Randy