Re: Module dvb-usb
Hi Matias, On Friday 30 March 2012 09:42:14 Matias Aguirre wrote: My name is Matias and im a programmer. I need to ask some things to you about the creation of new modules into the kernel for TV adapters. I have a new TV adapter with the chipset DM1305. I have the firmware of this chipset.. can i start with that or i need more info? First of all you should ask on the linux-media mailing list whether there is already someone working on a driver for this device. (CC'd) If not having the firmware-binary is not enough, you also need to know how to communicate with it and what kind of messages have to be sent to the firmware to make it do something. If you do not have any documentation about it (and you cannot get hold of it from the vendor), you need to reverse-engineer the communication. This is where the vp7045-example comes into the game: the vp7045 has a relatively simple firmware interface which can help you to quickly make a driver for you device. But, there is two different dvb usb device types: 1) the USB-firmware contains the demod/tuner-drivers and the firmware interface is high-level. (this is the case for the vp7045) or 2) the USB-firmware only implements a bridge for I2C/SPI or other control protocols and the demod/tuner-drivers have to be handled from the host. If your device is of the 2nd kind you should rather look at cxusb.c . HTH -- Patrick Kernel Labs Inc. http://www.kernellabs.com/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/1] [media] V4L: OV5642:remove redundant code to set cropping w/h
From: Liu Ying ying@freescale.com This patch contains code change only to remove redundant code to set priv-crop_rect.width/height in probe function. Signed-off-by: Liu Ying ying@freescale.com --- drivers/media/video/ov5642.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/ov5642.c b/drivers/media/video/ov5642.c index bb37ec8..efdd6be 100644 --- a/drivers/media/video/ov5642.c +++ b/drivers/media/video/ov5642.c @@ -1025,8 +1025,6 @@ static int ov5642_probe(struct i2c_client *client, priv-crop_rect.height = OV5642_DEFAULT_HEIGHT; priv-crop_rect.left= (OV5642_MAX_WIDTH - OV5642_DEFAULT_WIDTH) / 2; priv-crop_rect.top = (OV5642_MAX_HEIGHT - OV5642_DEFAULT_HEIGHT) / 2; - priv-crop_rect.width = OV5642_DEFAULT_WIDTH; - priv-crop_rect.height = OV5642_DEFAULT_HEIGHT; priv-total_width = OV5642_DEFAULT_WIDTH + BLANKING_EXTRA_WIDTH; priv-total_height = BLANKING_MIN_HEIGHT; -- 1.7.1 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
omap3isp Linux-3.3
Laurent, I'm looking at your latest tree. I've merged my platform support that I had working in 3.2, but I never see the TVP5150 sensor driver being probed. Has this changed? Do you have an example [tree] with working board support? Previously you had a branch with support for the BeagleBoard in place. Is 'omap3isp-sensors-board' up to date? Thanks - I'll keep trying to figure out what's happening here. -- Gary Thomas | Consulting for the MLB Associates |Embedded world -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL FOR 3.5] AF9035/AF9033/TUA9001 = TerraTec Cinergy T Stick [0ccd:0093]
Terve Mauro and all the other hackers, I did some massive rewrite for my old AF9035/AF9033 driver that was never merged. Anyhow, here it is. New drivers here are: Infineon TUA 9001 silicon tuner driver Afatech AF9033 DVB-T demodulator driver Afatech AF9035 DVB USB driver AF9035 integrates AF9033. Both chips are also sold separately. AF9033 will not likely work as a stand-alone since I didn't have hardware to test, but in theory it is quite well split out from the DVB USB interface driver (AF9035). Tips for cheap AF9035 based dual devices are welcome! regards Antti The following changes since commit 26315a507f6acda933f0d41200de8fec51775867: em28xx-dvb: stop URBs when stopping the streaming (2012-03-28 15:32:23 +0300) are available in the git repository at: git://linuxtv.org/anttip/media_tree.git af9035 Antti Palosaari (3): Infineon TUA 9001 silicon tuner driver Afatech AF9033 DVB-T demodulator driver Afatech AF9035 DVB USB driver drivers/media/common/tuners/Kconfig|6 + drivers/media/common/tuners/Makefile |1 + drivers/media/common/tuners/tua9001.c | 215 drivers/media/common/tuners/tua9001.h | 46 ++ drivers/media/common/tuners/tua9001_priv.h | 34 ++ drivers/media/dvb/dvb-usb/Kconfig |9 + drivers/media/dvb/dvb-usb/Makefile |3 + drivers/media/dvb/dvb-usb/af9035.c | 799 drivers/media/dvb/dvb-usb/af9035.h | 102 drivers/media/dvb/dvb-usb/dvb-usb-ids.h|1 + drivers/media/dvb/frontends/Kconfig|5 + drivers/media/dvb/frontends/Makefile |1 + drivers/media/dvb/frontends/af9033.c | 706 drivers/media/dvb/frontends/af9033.h | 73 +++ drivers/media/dvb/frontends/af9033_priv.h | 242 + 15 files changed, 2243 insertions(+), 0 deletions(-) create mode 100644 drivers/media/common/tuners/tua9001.c create mode 100644 drivers/media/common/tuners/tua9001.h create mode 100644 drivers/media/common/tuners/tua9001_priv.h create mode 100644 drivers/media/dvb/dvb-usb/af9035.c create mode 100644 drivers/media/dvb/dvb-usb/af9035.h create mode 100644 drivers/media/dvb/frontends/af9033.c create mode 100644 drivers/media/dvb/frontends/af9033.h create mode 100644 drivers/media/dvb/frontends/af9033_priv.h -- http://palosaari.fi/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: cron job: media_tree daily build: ERRORS
On Thursday, March 29, 2012 19:44:27 Hans Verkuil wrote: This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Thu Mar 29 19:00:28 CEST 2012 git hash:296da3cd14db9eb5606924962b2956c9c656dbb0 gcc version: i686-linux-gcc (GCC) 4.6.2 host hardware:x86_64 host os: 3.1-2.slh.1-amd64 linux-git-arm-eabi-enoxys: WARNINGS linux-git-arm-eabi-omap: WARNINGS linux-git-armv5-ixp: WARNINGS linux-git-i686: WARNINGS linux-git-m32r: WARNINGS linux-git-mips: WARNINGS linux-git-powerpc64: WARNINGS linux-git-x86_64: WARNINGS linux-2.6.31.12-i686: ERRORS linux-2.6.32.6-i686: ERRORS linux-2.6.33-i686: ERRORS linux-2.6.34-i686: ERRORS linux-2.6.35.3-i686: ERRORS linux-2.6.36-i686: ERRORS I've fixed these errors. I also fixed a huge number of pr_fmt, module_usb_driver and module_platform_driver redefine warnings. This should reduce the number of reported warnings considerably, making it easier to see the really important warnings. I also upgraded the compiler to 4.6.3. I tried 4.7.0 but that gave me some weird errors and actually crashed on me. Since I don't have the time to track that down, I went back to 4.6.3. Regards, Hans linux-2.6.37-i686: WARNINGS linux-2.6.38.2-i686: WARNINGS linux-2.6.39.1-i686: WARNINGS linux-3.0-i686: WARNINGS linux-3.1-i686: WARNINGS linux-3.2.1-i686: WARNINGS linux-3.3-i686: WARNINGS linux-2.6.31.12-x86_64: ERRORS linux-2.6.32.6-x86_64: ERRORS linux-2.6.33-x86_64: ERRORS linux-2.6.34-x86_64: ERRORS linux-2.6.35.3-x86_64: ERRORS linux-2.6.36-x86_64: ERRORS linux-2.6.37-x86_64: WARNINGS linux-2.6.38.2-x86_64: WARNINGS linux-2.6.39.1-x86_64: WARNINGS linux-3.0-x86_64: WARNINGS linux-3.1-x86_64: WARNINGS linux-3.2.1-x86_64: WARNINGS linux-3.3-x86_64: WARNINGS apps: WARNINGS spec-git: WARNINGS sparse: ERRORS Detailed results are available here: http://www.xs4all.nl/~hverkuil/logs/Thursday.log Full logs are available here: http://www.xs4all.nl/~hverkuil/logs/Thursday.tar.bz2 The V4L-DVB specification from this daily build is here: http://www.xs4all.nl/~hverkuil/spec/media.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: omap3isp Linux-3.3
Hi Gary, On Friday 30 March 2012 04:59:24 Gary Thomas wrote: Laurent, I'm looking at your latest tree. I've merged my platform support that I had working in 3.2, but I never see the TVP5150 sensor driver being probed. Is the OMAP3 ISP driver loaded ? What does it print to the kernel log ? Has this changed? Do you have an example [tree] with working board support? Previously you had a branch with support for the BeagleBoard in place. Is 'omap3isp-sensors-board' up to date? The branch is up-to-date, yes. It contains support for the Beagleabord-xM with the MT9P031 camera module. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: omap3isp Linux-3.3
On 2012-03-30 07:33, Laurent Pinchart wrote: Hi Gary, On Friday 30 March 2012 04:59:24 Gary Thomas wrote: Laurent, I'm looking at your latest tree. I've merged my platform support that I had working in 3.2, but I never see the TVP5150 sensor driver being probed. Is the OMAP3 ISP driver loaded ? What does it print to the kernel log ? Has this changed? Do you have an example [tree] with working board support? Previously you had a branch with support for the BeagleBoard in place. Is 'omap3isp-sensors-board' up to date? The branch is up-to-date, yes. It contains support for the Beagleabord-xM with the MT9P031 camera module. Thanks. My configuration was a bit messed up, got that part working now. Sadly, the TVP5150 driver has no pad operations which I'm now re-adding from my previous version. I'll let you know what else I find. -- Gary Thomas | Consulting for the MLB Associates |Embedded world -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 1/2] [resend] radio-isa: PnP support for the new ISA radio framework
Hi Ondrej, Sorry for the delay, Real Life intervened and made it impossible for me to work on this. I finally had some time (and access to ISA hardware), so for both patches: Reviewed-by: Hans Verkuil hans.verk...@cisco.com I've also tested with with my non-PnP radio-gemtek board. Regards, Hans On Thursday, March 22, 2012 19:53:01 Ondrej Zary wrote: Add PnP support to the new ISA radio framework. Signed-off-by: Ondrej Zary li...@rainbow-software.org diff --git a/drivers/media/radio/radio-isa.c b/drivers/media/radio/radio-isa.c index 02bcead..ed9039f 100644 --- a/drivers/media/radio/radio-isa.c +++ b/drivers/media/radio/radio-isa.c @@ -26,6 +26,7 @@ #include linux/delay.h #include linux/videodev2.h #include linux/io.h +#include linux/slab.h #include media/v4l2-device.h #include media/v4l2-ioctl.h #include media/v4l2-fh.h @@ -198,56 +199,31 @@ static bool radio_isa_valid_io(const struct radio_isa_driver *drv, int io) return false; } -int radio_isa_probe(struct device *pdev, unsigned int dev) +struct radio_isa_card *radio_isa_alloc(struct radio_isa_driver *drv, + struct device *pdev) { - struct radio_isa_driver *drv = pdev-platform_data; - const struct radio_isa_ops *ops = drv-ops; struct v4l2_device *v4l2_dev; - struct radio_isa_card *isa; - int res; + struct radio_isa_card *isa = drv-ops-alloc(); + if (!isa) + return NULL; - isa = drv-ops-alloc(); - if (isa == NULL) - return -ENOMEM; dev_set_drvdata(pdev, isa); isa-drv = drv; - isa-io = drv-io_params[dev]; v4l2_dev = isa-v4l2_dev; strlcpy(v4l2_dev-name, dev_name(pdev), sizeof(v4l2_dev-name)); - if (drv-probe ops-probe) { - int i; - - for (i = 0; i drv-num_of_io_ports; ++i) { - int io = drv-io_ports[i]; - - if (request_region(io, drv-region_size, v4l2_dev-name)) { - bool found = ops-probe(isa, io); - - release_region(io, drv-region_size); - if (found) { - isa-io = io; - break; - } - } - } - } - - if (!radio_isa_valid_io(drv, isa-io)) { - int i; + return isa; +} - if (isa-io 0) - return -ENODEV; - v4l2_err(v4l2_dev, you must set an I/O address with io=0x%03x, - drv-io_ports[0]); - for (i = 1; i drv-num_of_io_ports; i++) - printk(KERN_CONT /0x%03x, drv-io_ports[i]); - printk(KERN_CONT .\n); - kfree(isa); - return -EINVAL; - } +int radio_isa_common_probe(struct radio_isa_card *isa, struct device *pdev, + int radio_nr, unsigned region_size) +{ + const struct radio_isa_driver *drv = isa-drv; + const struct radio_isa_ops *ops = drv-ops; + struct v4l2_device *v4l2_dev = isa-v4l2_dev; + int res; - if (!request_region(isa-io, drv-region_size, v4l2_dev-name)) { + if (!request_region(isa-io, region_size, v4l2_dev-name)) { v4l2_err(v4l2_dev, port 0x%x already in use\n, isa-io); kfree(isa); return -EBUSY; @@ -300,8 +276,8 @@ int radio_isa_probe(struct device *pdev, unsigned int dev) v4l2_err(v4l2_dev, Could not setup card\n); goto err_node_reg; } - res = video_register_device(isa-vdev, VFL_TYPE_RADIO, - drv-radio_nr_params[dev]); + res = video_register_device(isa-vdev, VFL_TYPE_RADIO, radio_nr); + if (res 0) { v4l2_err(v4l2_dev, Could not register device node\n); goto err_node_reg; @@ -316,24 +292,110 @@ err_node_reg: err_hdl: v4l2_device_unregister(isa-v4l2_dev); err_dev_reg: - release_region(isa-io, drv-region_size); + release_region(isa-io, region_size); kfree(isa); return res; } -EXPORT_SYMBOL_GPL(radio_isa_probe); -int radio_isa_remove(struct device *pdev, unsigned int dev) +int radio_isa_common_remove(struct radio_isa_card *isa, unsigned region_size) { - struct radio_isa_card *isa = dev_get_drvdata(pdev); const struct radio_isa_ops *ops = isa-drv-ops; ops-s_mute_volume(isa, true, isa-volume ? isa-volume-cur.val : 0); video_unregister_device(isa-vdev); v4l2_ctrl_handler_free(isa-hdl); v4l2_device_unregister(isa-v4l2_dev); - release_region(isa-io, isa-drv-region_size); + release_region(isa-io, region_size); v4l2_info(isa-v4l2_dev, Removed radio card %s\n, isa-drv-card); kfree(isa); return 0; } + +int radio_isa_probe(struct device *pdev,
Re: [PATCH for v3.4] Add missing slab.h to radio-rtrack2.c
On 03/28/2012 09:27 AM, Randy Dunlap wrote: On 03/27/2012 02:39 AM, Hans Verkuil wrote: Missed this one, this patch should solve this issue: http://www.spinics.net/lists/linux-media/msg45880.html Slab.h was added to all the other isa drivers, but not radio-rtrack2.c. Subject: [PATCH] radio-rtrack2: add missing slab.h. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Randy Dunlap rdun...@xenotime.net Please merge so that linux-next builds do not fail. Thanks. --- drivers/media/radio/radio-rtrack2.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/radio/radio-rtrack2.c b/drivers/media/radio/radio- rtrack2.c index b275c5d..b1f844c 100644 --- a/drivers/media/radio/radio-rtrack2.c +++ b/drivers/media/radio/radio-rtrack2.c @@ -17,6 +17,7 @@ #include linux/videodev2.h/* kernel radio structs */ #include linux/mutex.h #include linux/io.h /* outb, outb_p */ +#include linux/slab.h #include media/v4l2-device.h #include media/v4l2-ioctl.h #include radio-isa.h -- ~Randy -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
cron job: media_tree daily build: WARNINGS
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Fri Mar 30 19:00:14 CEST 2012 git hash:296da3cd14db9eb5606924962b2956c9c656dbb0 gcc version: i686-linux-gcc (GCC) 4.6.3 host hardware:x86_64 host os: 3.1-2.slh.1-amd64 linux-git-arm-eabi-enoxys: WARNINGS linux-git-arm-eabi-omap: WARNINGS linux-git-armv5-ixp: WARNINGS linux-git-i686: WARNINGS linux-git-m32r: WARNINGS linux-git-mips: WARNINGS linux-git-powerpc64: WARNINGS linux-git-x86_64: WARNINGS linux-2.6.31.12-i686: WARNINGS linux-2.6.32.6-i686: WARNINGS linux-2.6.33-i686: WARNINGS linux-2.6.34-i686: WARNINGS linux-2.6.35.3-i686: WARNINGS linux-2.6.36-i686: WARNINGS linux-2.6.37-i686: WARNINGS linux-2.6.38.2-i686: WARNINGS linux-2.6.39.1-i686: WARNINGS linux-3.0-i686: WARNINGS linux-3.1-i686: WARNINGS linux-3.2.1-i686: WARNINGS linux-3.3-i686: WARNINGS linux-2.6.31.12-x86_64: WARNINGS linux-2.6.32.6-x86_64: WARNINGS linux-2.6.33-x86_64: WARNINGS linux-2.6.34-x86_64: WARNINGS linux-2.6.35.3-x86_64: WARNINGS linux-2.6.36-x86_64: WARNINGS linux-2.6.37-x86_64: WARNINGS linux-2.6.38.2-x86_64: WARNINGS linux-2.6.39.1-x86_64: WARNINGS linux-3.0-x86_64: WARNINGS linux-3.1-x86_64: WARNINGS linux-3.2.1-x86_64: WARNINGS linux-3.3-x86_64: WARNINGS apps: WARNINGS spec-git: WARNINGS sparse: ERRORS Detailed results are available here: http://www.xs4all.nl/~hverkuil/logs/Friday.log Full logs are available here: http://www.xs4all.nl/~hverkuil/logs/Friday.tar.bz2 The V4L-DVB specification from this daily build is here: http://www.xs4all.nl/~hverkuil/spec/media.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hauppauge WinTV-HVR4000 DVB-S/S2/T/Hybrid no longer works properly with kernel 3.3
Hi, hope you can point me into the right direction. I have got 2 Hauppauge WinTV-HVR4000 DVB-S/S2/T/Hybrid cards in my system. They worked perfectly fine with kernel 3.2 (e.g. the last Fedora 16 kernel that worked is 3.2.10-3.fc16.x86_64). As soon as Fedora went kernel 3.3 (kernel 3.3.0-4.fc16.x86_64) the problems started. The cards are still recognized and you can tune them. But trying to watch any DVB-S (or DVB-S2) channel just results in block artefacts, loss of audio-video sychronization etc. The only thing /var/log/messages or dmesg tells me is: cx8802_start_dma() Failed. Unsupported value in .mpeg (0x0001) Same machine, same everything, just rebooting back into the 3.2 kernel the problem is gone. Any idea where I could start my investigation, please? Thanks Thomas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 13/15] media/video/s5p-tv: mark const init data with __initconst instead of __initdata
As long as there is no other non-const variable marked __initdata in the same compilation unit it doesn't hurt. If there were one however compilation would fail with error: $variablename causes a section type conflict because a section containing const variables is marked read only and so cannot contain non-const variables. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Tomasz Stanislawski t.stanisl...@samsung.com Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-media@vger.kernel.org --- no changes since (implicit) v1 drivers/media/video/s5p-tv/mixer_drv.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/video/s5p-tv/mixer_drv.c b/drivers/media/video/s5p-tv/mixer_drv.c index a2c0c25..edca065 100644 --- a/drivers/media/video/s5p-tv/mixer_drv.c +++ b/drivers/media/video/s5p-tv/mixer_drv.c @@ -461,7 +461,7 @@ static struct platform_driver mxr_driver __refdata = { static int __init mxr_init(void) { int i, ret; - static const char banner[] __initdata = KERN_INFO + static const char banner[] __initconst = KERN_INFO Samsung TV Mixer driver, (c) 2010-2011 Samsung Electronics Co., Ltd.\n; printk(banner); -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL FOR 3.5] AF9035/AF9033/TUA9001 = TerraTec Cinergy T Stick [0ccd:0093]
On Fri, 30 Mar 2012 15:33:02 +0300 Antti Palosaari cr...@iki.fi wrote: Terve Mauro and all the other hackers, I did some massive rewrite for my old AF9035/AF9033 driver that was never merged. Anyhow, here it is. New drivers here are: Infineon TUA 9001 silicon tuner driver Afatech AF9033 DVB-T demodulator driver Afatech AF9035 DVB USB driver This looks pretty nice. I recently wrote a tuner driver for the fc0011 tuner, which is used in some af9035 sticks: http://patchwork.linuxtv.org/patch/10503/ It was developed against an af903x driver by Hans-Frieder Vogt. I'll port it to your AF9035 driver, ASAP, to check whether this works on my DVB USB stick. -- Greetings, Michael. PGP encryption is encouraged / 908D8B0E signature.asc Description: PGP signature
Re: [GIT PULL FOR 3.5] AF9035/AF9033/TUA9001 = TerraTec Cinergy T Stick [0ccd:0093]
On 31.03.2012 00:45, Michael Büsch wrote: On Fri, 30 Mar 2012 15:33:02 +0300 Antti Palosaaricr...@iki.fi wrote: Terve Mauro and all the other hackers, I did some massive rewrite for my old AF9035/AF9033 driver that was never merged. Anyhow, here it is. New drivers here are: Infineon TUA 9001 silicon tuner driver Afatech AF9033 DVB-T demodulator driver Afatech AF9035 DVB USB driver This looks pretty nice. I recently wrote a tuner driver for the fc0011 tuner, which is used in some af9035 sticks: http://patchwork.linuxtv.org/patch/10503/ It was developed against an af903x driver by Hans-Frieder Vogt. I'll port it to your AF9035 driver, ASAP, to check whether this works on my DVB USB stick. Feel free to do that. Actually, I just tried it about 2 hours ago. But I failed, since there callbacks given as a param for tuner attach and it is wrong. There is frontend callback defined just for that. Look example from some Xceive tuners also hd29l2 demod driver contains one example. Use git grep DVB_FRONTEND_COMPONENT_ drivers/media/ to see all those existing callbacks. struct dvb_frontend *fc0011_attach(struct dvb_frontend *fe, struct i2c_adapter *i2c, u8 i2c_address, int (*tuner_reset)(unsigned long, unsigned long),unsigned long tuner_reset_arg0,unsigned long tuner_reset_arg1) My short term plans are now * fix af9033 IF freq control (now Zero-IF only) * change firmware download to use new firmware syntax * dual tuner support * check if IT9035 is enough similar (My personal suspicion is that integrated tuner is only main difference, whilst USB-interface and demod are same. But someone has told that it is quite different design though.) * implement SNR, BER and USB counters * implement remote controller regards Antti -- http://palosaari.fi/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL FOR 3.5] AF9035/AF9033/TUA9001 = TerraTec Cinergy T Stick [0ccd:0093]
On Sat, 31 Mar 2012 01:00:21 +0300 Antti Palosaari cr...@iki.fi wrote: Feel free to do that. Actually, I just tried it about 2 hours ago. But I failed, since there callbacks given as a param for tuner attach and it is wrong. There is frontend callback defined just for that. Look example from some Xceive tuners also hd29l2 demod driver contains one example. Use git grep DVB_FRONTEND_COMPONENT_ drivers/media/ to see all those existing callbacks. Cool. Thanks for the hint. I'll fix this. My short term plans are now * fix af9033 IF freq control (now Zero-IF only) * change firmware download to use new firmware syntax * dual tuner support * check if IT9035 is enough similar (My personal suspicion is that integrated tuner is only main difference, whilst USB-interface and demod are same. But someone has told that it is quite different design though.) * implement SNR, BER and USB counters * implement remote controller Sounds good. -- Greetings, Michael. PGP encryption is encouraged / 908D8B0E signature.asc Description: PGP signature
RE: [PATCH v2] media: rotator: Add new image rotator driver for EXYNOS
Hi Sylwester Thanks for the review. God bless you! :) On 03/15/2012 06:21 AM, Sylwester Nawrocki wrote: Hi Sunyoung, thank you for addressing my previous comments. It looks much better now. I have is a few more comments... On 03/14/2012 09:00 AM, Sunyoung Kang wrote: This patch adds new rotator driver which is a device for rotation on EXYNOS SoCs. This rotator device supports the belows as key feature. 1) Image format : RGB565/888, YUV422 1p, YUV420 2p/3p 2) rotation : 0/90/180/270 and X/Y Flip Signed-off-by: Sunyoung Kangsy0816.k...@samsung.com Signed-off-by: Ayoung Sima@samsung.com ---NOTE: It's almost right;) After the --- there must be immediately a new line character. So NOTE should be in a new line. Oh.. ok. Thanks. This patch has been created based on following - media: media-dev: Add media devices for EXYNOS5 by Sungchun Kang - media: fimc-lite: Add new driver for camera interface by Sungchun Kang Changes since v1: - address comments from Sylwester Nawrocki drivers/media/video/exynos/Kconfig|1 + drivers/media/video/exynos/Makefile |1 + drivers/media/video/exynos/rotator/Kconfig|7 + drivers/media/video/exynos/rotator/Makefile |9 + drivers/media/video/exynos/rotator/rotator-core.c | 1344 + drivers/media/video/exynos/rotator/rotator-regs.c | 215 drivers/media/video/exynos/rotator/rotator-regs.h | 70 ++ drivers/media/video/exynos/rotator/rotator.h | 286 + 8 files changed, 1933 insertions(+), 0 deletions(-) create mode 100644 drivers/media/video/exynos/rotator/Kconfig create mode 100644 drivers/media/video/exynos/rotator/Makefile create mode 100644 drivers/media/video/exynos/rotator/rotator-core.c create mode 100644 drivers/media/video/exynos/rotator/rotator-regs.c create mode 100644 drivers/media/video/exynos/rotator/rotator-regs.h create mode 100644 drivers/media/video/exynos/rotator/rotator.h ... diff --git a/drivers/media/video/exynos/rotator/Kconfig b/drivers/media/video/exynos/rotator/Kconfig new file mode 100644 index 000..977423a --- /dev/null +++ b/drivers/media/video/exynos/rotator/Kconfig @@ -0,0 +1,7 @@ +config VIDEO_EXYNOS_ROTATOR +bool EXYNOS Image Rotator Driver +select V4L2_MEM2MEM_DEV +select VIDEOBUF2_DMA_CONTIG +default n No need, the default default already is n. OK. +---help--- + Support for Image Rotator Driver with v4l2 on EXYNOS SoCs diff --git a/drivers/media/video/exynos/rotator/Makefile b/drivers/media/video/exynos/rotator/Makefile new file mode 100644 index 000..6f74403 --- /dev/null +++ b/drivers/media/video/exynos/rotator/Makefile @@ -0,0 +1,9 @@ +# +# Copyright (c) 2012 Samsung Electronics Co., Ltd. +# http://www.samsung.com +# +# Licensed under GPLv2 +# + +rotator-objs:= rotator-core.o rotator-regs.o +obj-$(CONFIG_VIDEO_EXYNOS_ROTATOR) += rotator.o diff --git a/drivers/media/video/exynos/rotator/rotator-core.c b/drivers/media/video/exynos/rotator/rotator-core.c new file mode 100644 index 000..75d28f2 --- /dev/null +++ b/drivers/media/video/exynos/rotator/rotator-core.c @@ -0,0 +1,1344 @@ +/* + * Copyright (c) 2012 Samsung Electronics Co., Ltd. + * http://www.samsung.com + * + * Core file for Samsung EXYNOS Image Rotator driver + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. +*/ + +#includelinux/module.h +#includelinux/kernel.h +#includelinux/version.h +#includelinux/platform_device.h +#includelinux/interrupt.h +#includelinux/clk.h +#includelinux/slab.h + +#includemedia/v4l2-ioctl.h +#includemedia/videobuf2-dma-contig.h + +#include rotator.h + +int log_level; +module_param_named(log_level, log_level, uint, 0644); + +static struct rot_fmt rot_formats[] = { +{ +.name = RGB565, +.pixelformat= V4L2_PIX_FMT_RGB565, +.num_planes = 1, +.num_comp = 1, +.bitperpixel= { 16 }, +}, { +.name = XRGB-, 32 bps, What 'bps' stands for ? Oops.. it should be 'bpp' means bit per pixel.. thanks. +.pixelformat= V4L2_PIX_FMT_RGB32, +.num_planes = 1, +.num_comp = 1, +.bitperpixel= { 32 }, +}, { +.name = YUV 4:2:2 packed, YCbYCr, +.pixelformat= V4L2_PIX_FMT_YUYV, +.num_planes = 1, +.num_comp = 1, +.bitperpixel= { 16 }, +}, { +.name = YUV 4:2:0 non-contiguous 2-planar, Y/CbCr, +.pixelformat= V4L2_PIX_FMT_NV12M, +.num_planes = 2, +.num_comp